42951 Commits

Author SHA1 Message Date
Sergey Biryukov
6f4e4aada8 Site Health: Add missing i18n for the App Passwords documentation link.
Follow-up to [49334].

Props tai.
Reviewed by TimothyBlynJacobs, SergeyBiryukov.
Merges [49650] to the 5.6 branch.
Fixes #51815.

git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49652 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-18 15:55:13 +00:00
Jake Spurlock
ea1f90a050 Security: Update the Security Policy to acccount for 5.6.
See [49645].
Props helen, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49646 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 22:58:13 +00:00
Helen Hou-Sandi
cf85561480 Branch 5.6.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49643 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 22:49:33 +00:00
Helen Hou-Sandi
af54a08642 Post WordPress 5.6 RC 1 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@49642 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 22:37:48 +00:00
Helen Hou-Sandi
6d71eb492a WordPress 5.6 RC 1.
git-svn-id: https://develop.svn.wordpress.org/trunk@49641 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 21:59:53 +00:00
ryelle
efb664735f Help/About: WordPress 5.6 About Page.
This change introduces the new About page for WordPress 5.6.

Props elmastudio, ryelle, melchoyce, karmatosed, webcommsat, marybaum, meher, OGlekler, lmurillom, vimes1984, sabrinazeidan, nalininonstopnewsuk, afshanadiya, michelleames, bmcdede, yvettesonneveld, sarahricker, isabel_brison, helen, hellofromtonya, poena, chanthaboune, cbringmann, joedolson, sabernhardt, garrett-eclipse, audrasjb, marks99.
See #51415.



git-svn-id: https://develop.svn.wordpress.org/trunk@49640 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 21:32:16 +00:00
Sergey Biryukov
1a338a859b I18N: Avoid PHP notices for relative URLs in load_script_textdomain().
Props hellofromTonya, SeBsZ, archon810, nourma, justinahinon, SergeyBiryukov.
Fixes #49145.

git-svn-id: https://develop.svn.wordpress.org/trunk@49639 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 20:50:21 +00:00
Helen Hou-Sandi
8372bbdfa5 Upgrade/Install: Consistent layout and accurate messages on the update screen.
* Clarifies that if you are on maintenance/security auto-updates that you are only on those and therefore there are more options available.
* Adds a message if a version control system has been detected, as automatic updates are disabled in that case.
* Ensures only one heading between `update available`, `you are on a dev version`, and `you are on latest` appears at any given time, falling back to `you are on latest` if something strange happens with the returned update data.
* Removes some older strings related to auto-updates, which greatly simplifies the above.
* Strips the `core-major-auto-updates-saved` query arg from the URL, as it is related to a dismissible notice.

Props audrasjb, pbiron, helen.
Fixes #51742.


git-svn-id: https://develop.svn.wordpress.org/trunk@49638 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 20:26:32 +00:00
Sergey Biryukov
2486c13ee7 Users: Use do_action_ref_array() for pre_get_users and pre_get_terms actions.
This brings some consistency with the other similar actions:

* `pre_get_comments`
* `pre_get_networks`
* `pre_get_posts`
* `pre_get_sites`
* `pre_user_query`

Follow-up to [29363] and [37572].

Props andy, adamsilverstein, hellofromTonya, desrosj, SergeyBiryukov.
Fixes #50961.

git-svn-id: https://develop.svn.wordpress.org/trunk@49637 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 20:07:57 +00:00
Jonathan Desrosiers
f6e265070d Build/Test Tools: Update the package.json engines to point to the new LTS versions of Node/NPM.
Props mkaz, jorbin.
Fixes #51749.

git-svn-id: https://develop.svn.wordpress.org/trunk@49636 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 19:28:21 +00:00
Sergey Biryukov
ee3585ac1e General: Rename the wp_error_checked action to is_wp_error_instance for clarity.
Follow-up to [49022], [49023].

Props johnbillion, helen, johnjamesjacoby, Mte90, alexstandiford, hellofromTonya, jnylen0, SergeyBiryukov.
Fixes #40568.

git-svn-id: https://develop.svn.wordpress.org/trunk@49635 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 19:19:37 +00:00
Jonathan Desrosiers
01ab2e9060 Build/Test Tools: Update several NPM dependencies.
These updates were applied when running `npm install`.

See #50769.

git-svn-id: https://develop.svn.wordpress.org/trunk@49634 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 19:17:29 +00:00
Jonathan Desrosiers
4f66a69d9e Twenty Twenty-One: Sync the latest changes for 5.6 RC1.
For a full list of changes since [49574-49577], see https://github.com/WordPress/twentytwentyone/compare/aa284fd...trunk.

Props poena, luminuu, kjellr, ryelle, aristath.
See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49633 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 18:58:52 +00:00
Sergey Biryukov
99d692ddfe App Passwords: Regenerate the .htaccess file to add a new rule.
Application Passwords introduced a new Rewrite Rule to handle the Authorization header on certain systems.

This bumps the database version and updates the file so the change is applied to sites upon upgrading to 5.6.

Follow-up to [49534].

Props pbiron, TimothyBlynJacobs, SergeyBiryukov.
Fixes #51723.

git-svn-id: https://develop.svn.wordpress.org/trunk@49632 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 17:22:32 +00:00
Sergey Biryukov
62d0303bb1 Plugins: Make sure the HTML ID attributes for plugin checkboxes are unique.
Follow-up to [48374].

Props helen, sabernhardt, kishanjasani, mukesh27, hareesh-pillai.
Fixes #51256.

git-svn-id: https://develop.svn.wordpress.org/trunk@49631 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 16:46:30 +00:00
Sergey Biryukov
22e4cb5266 Docs: Further remove tautology from comments in recurse_dirsize() tests.
Follow-up to [49212], [49616], [49628].

See #19879.

git-svn-id: https://develop.svn.wordpress.org/trunk@49630 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 15:48:07 +00:00
Sergey Biryukov
205c025c63 Multisite: Rename the calculate_current_dirsize filter to pre_recurse_dirsize.
Set the default value to `false`. This brings some consistency with the `pre_get_space_used` filter.

Follow-up to [49212], [49616], [49628].

See #19879.

git-svn-id: https://develop.svn.wordpress.org/trunk@49629 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 15:42:57 +00:00
Sergey Biryukov
025ad3469b Docs: Adjust comments for recurse_dirsize() and related tests per the documentation standards.
Follow-up to [49212], [49616].

See #19879.

git-svn-id: https://develop.svn.wordpress.org/trunk@49628 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 15:36:02 +00:00
Sergey Biryukov
eb9fb00ee6 App Passwords: Add missing i18n for an error message.
Follow-up to [49617].

See #51513.

git-svn-id: https://develop.svn.wordpress.org/trunk@49627 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 10:19:29 +00:00
Sergey Biryukov
41decddb7f Docs: Document the $args parameter of wp_oembed_get().
Link to `wp_oembed_get()` as the canonical source when documenting additional arguments in various `WP_oEmbed` methods.

Follow-up to [49620].

See #51269.

git-svn-id: https://develop.svn.wordpress.org/trunk@49626 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 10:09:12 +00:00
Robert Anderson
6b6a643b0b Customize: Temporary fix for autosave restore notice not being removed
Fixes the "There is a more recent autosave of your changes" notice from not
being removed when the dismiss button is clicked.

The problem is caused by the notice being initialized twice: once by the
`common` script and then again by the `customize-controls` script.

This temporary fix prevents `customize-controls` from initializing a notice if
it has already been initialized.

A better fix would be to not initialize notices twice. This can be done by
removing `common` as a dependency of `updates` when `deprecateL10nObject` is
removed.

When this happens (est: 5.7), this temporary fix should be reverted.

Fixes #51425.
See #51317.
Props karthikbhatb, dlh, SergeyBiryukov.


git-svn-id: https://develop.svn.wordpress.org/trunk@49625 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 04:43:33 +00:00
Robert Anderson
ac71fffac0 Customize: Ensure multiple CSS classes are passed to nav_menu_link_attributes as an array
When multiple CSS classes are added to a menu item, the nav_menu_link_attributes
filter should be called with $item->classes set to an array of CSS class names.

When previewing in the Customizer, however, a single string was being passed to
$item->classes because WP_Customize_Nav_Menu_Item_Setting::preview() bypasses
wp_update_nav_menu_item() and instead uses filter_wp_get_nav_menu_items().

The fix is to make filter_wp_get_nav_menu_items() match what
wp_update_nav_menu_item() does and split the string into an array.

Fixes #43113.
Props dlh.


git-svn-id: https://develop.svn.wordpress.org/trunk@49624 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 04:29:02 +00:00
Robert Anderson
3b2097317e Editor: Update WordPress packages for RC1
@wordpress/block-directory: 1.17.3 -> 1.17.4
@wordpress/block-library: 2.26.3 -> 2.26.4
@wordpress/edit-post: 3.25.3 -> 3.25.4

Fixes #51793.
Props isabel_brison.


git-svn-id: https://develop.svn.wordpress.org/trunk@49623 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 04:11:04 +00:00
Peter Wilson
64ad8eb332 Permalinks: Prevent attachment pages 404ing following [49563].
This largely reverts [49563] due to attachment pages returning 404: File not found errors when they use the `inherit` status.

Permalink changes to attachment pages are retained when they are descendants of trashed or deleted posts.

Props Toro_Unit, helen, johnbillion, peterwilsoncc.
Fixes #51776.
See #5272.



git-svn-id: https://develop.svn.wordpress.org/trunk@49622 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 03:27:07 +00:00
Jonathan Desrosiers
828ee6c1ed Code Modernization: Only call libxml_disable_entity_loader() in PHP < 8.
This function has been deprecated in PHP 8.0 because in libxml 2.9.0, external entity loading is disabled by default, so this function is no longer needed to protect against XXE attacks.

This change fixes an instance of `libxml_disable_entity_loader()` within the getID3 library that has not yet been included in a tagged release for the library.

Props jrf, hellofromtonya.
Fixes #50898.

git-svn-id: https://develop.svn.wordpress.org/trunk@49621 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 00:58:33 +00:00
Helen Hou-Sandi
4fcdd01f33 Embeds: Document $args in wp_oembed_get().
Props hellofromTonya, audrasjb, SergeyBiryukov.
Fixes #51269.


git-svn-id: https://develop.svn.wordpress.org/trunk@49620 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 23:11:21 +00:00
Jake Spurlock
4b8faba8db Feeds: Add an early exit when calling RSS functions directly.
While this file is depracated, it shouldn't throw errors when called directly.

Fixes #35835.

Props thib3113, dd32, TheGP, flymike, zodiac1978, williampatton.


git-svn-id: https://develop.svn.wordpress.org/trunk@49619 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 22:50:03 +00:00
Jake Spurlock
737867e4ea Build/Test Tools: Update several NPM dependencies.
These updates were applied by running `npm i`. These are changing some `http` links to `https`.

See #50769.


git-svn-id: https://develop.svn.wordpress.org/trunk@49618 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 22:45:08 +00:00
Timothy Jacobs
ba8de96fc6 App Passwords: Unify availability language.
Previously App Passwords used a mix of "enabled" and "available". We've now standardized on using "available".

Additionally, we now use a 501 status code when indicating that App Passwords is not available.

Props SergeyBiryukov, ocean90, TimothyBlynJacobs.
Fixes #51513.


git-svn-id: https://develop.svn.wordpress.org/trunk@49617 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 22:40:11 +00:00
Helen Hou-Sandi
56ffe940b0 Multisite: More consistency for clean_dirsize_cache().
Props SergeyBiryukov.
Fixes #19879.


git-svn-id: https://develop.svn.wordpress.org/trunk@49616 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 22:29:42 +00:00
Sergey Biryukov
740d99daf4 Script Loader: Correct version for jQuery Migrate.
Follow-up to [49338].

See #51621, #50564.

git-svn-id: https://develop.svn.wordpress.org/trunk@49615 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 21:34:56 +00:00
Helen Hou-Sandi
117de3b2cd Posts, Post Types: Go back to "Auto Draft" for CPTs without title support.
Reverts [49288] due to late point in 5.6 cycle and lack of update in Gutenberg package to account for the string change.
See #45516.


git-svn-id: https://develop.svn.wordpress.org/trunk@49614 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 19:42:32 +00:00
Helen Hou-Sandi
271702cd27 Media: Avoid fatal error in `wp_prepare_attachment_for_js().
In certain contexts, in particular on the front-end, `get_media_states()` is not availble.

Props rebasaurus.
Fixes #51791.


git-svn-id: https://develop.svn.wordpress.org/trunk@49613 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 19:18:51 +00:00
Sergey Biryukov
2c7b5c37db Docs: Fix typo in wp_get_object_terms filter DocBlock.
Follow-up to [49597].

See #50768.

git-svn-id: https://develop.svn.wordpress.org/trunk@49612 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 17:26:42 +00:00
Sergey Biryukov
10208c1e35 Docs: Add missing full stop for a comment in create_initial_rest_routes().
Follow-up to [49154].

Props david.binda.
Fixes #51788.

git-svn-id: https://develop.svn.wordpress.org/trunk@49611 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 16:46:27 +00:00
John Blackbourn
10deb31dd6 Docs: Corrections and improvements to inline docs relating to the REST API.
See #50768


git-svn-id: https://develop.svn.wordpress.org/trunk@49610 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 11:02:32 +00:00
Sergey Biryukov
568e208e67 Docs: Drop src/ from pre_render_block duplicate hook reference.
Follow-up to [49608].

See #51612.

git-svn-id: https://develop.svn.wordpress.org/trunk@49609 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 10:51:19 +00:00
Robert Anderson
7a42314c8b Editor: Move pre_render_block, render_block_data, render_block_context
Move the pre_render_block, render_block_data, and render_block_context
filters from render_block() to WP_Block. This ensures that they are
called for all blocks, including nested blocks, not just top-level
blocks.

Fixes #51612.
Props gaambo, gziolo, TimothyBlynJacobs.


git-svn-id: https://develop.svn.wordpress.org/trunk@49608 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 00:45:55 +00:00
Timothy Jacobs
2425a11255 App Passwords: Include authorization rewrite rule in default multisite .htaccess
This rule was previously added to `WP_Rewrite`, but multisite uses a different .htaccess generation mechanism.

Props pbiron.
Fixes #51772.
See [49109].


git-svn-id: https://develop.svn.wordpress.org/trunk@49607 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-15 17:44:56 +00:00
John Blackbourn
82e44bc702 Build/Test Tools: Misc test enhancements.
See #51344


git-svn-id: https://develop.svn.wordpress.org/trunk@49606 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-15 17:17:55 +00:00
John Blackbourn
cd9ed5e3ad Built/Test Tools: Switch to a data provider for the default user role and capability tests.
This test previously performed 1,010 assertions, and a failure in any one would prevent the other assertions from running. Using a data provider means simultaneous failures will all be reported at once.

See #51344, #32394


git-svn-id: https://develop.svn.wordpress.org/trunk@49605 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-15 14:57:39 +00:00
John Blackbourn
ea852af151 Build/Test Tools: Ensure user capability assertions are performed for all default roles.
The existing assertions were erroneously placed outside the iteration of all users, and therefore were only run against the last user in the list, which is the Subscriber role.

See #51344, #32394


git-svn-id: https://develop.svn.wordpress.org/trunk@49604 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-15 14:17:31 +00:00
John Blackbourn
e8435082d6 Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.
This brings consistency to this often-used method, and allows IDEs to provide help to developers when using its `$factory` parameter.

See #51344


git-svn-id: https://develop.svn.wordpress.org/trunk@49603 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-15 13:59:32 +00:00
Sergey Biryukov
9b97ec4c7d Twenty Nineteen: Remove unnecessary references to some variables in twentynineteen_hsl_hex() before they are defined.
Props ankitmaru, sabernhardt.
Fixes #49052.

git-svn-id: https://develop.svn.wordpress.org/trunk@49602 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-15 12:14:45 +00:00
John Blackbourn
5f257b4931 Build/Test Tools: Improve the reliability of the test that ensures correct dependency order when inline scripts are used.
This test already ensures `WP_Scripts->do_concat` is true, therefore it has no dependency on `SCRIPT_DEBUG` being false. This means the test can run in an environment where the `.min` suffix is not used.

This change allows for the test to pass in this situation.

See #36392, #51734, #51344


git-svn-id: https://develop.svn.wordpress.org/trunk@49601 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-14 17:20:57 +00:00
John Blackbourn
356f5664a7 Docs: For clarity, add some information about the return types of get_option().
Props ReneHermi, johannadevos

See #51278


git-svn-id: https://develop.svn.wordpress.org/trunk@49600 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-14 17:00:31 +00:00
Sergey Biryukov
c375590c0e Docs: Add missing descriptions for _WP_List_Table_Compat methods.
Props johannadevos, SaeedFard, swissspidy, desrosj, SergeyBiryukov.
Fixes #46842.

git-svn-id: https://develop.svn.wordpress.org/trunk@49599 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-14 16:52:25 +00:00
John Blackbourn
fca21076e0 Docs: Revert an accidental revert of this package name.
See #51414, #50768


git-svn-id: https://develop.svn.wordpress.org/trunk@49598 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-14 16:38:23 +00:00
John Blackbourn
c19f56747f Docs: Various docblock corrections and improvements.
See #50768


git-svn-id: https://develop.svn.wordpress.org/trunk@49597 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-14 16:33:52 +00:00
Sergey Biryukov
36f47ff751 Docs: Add missing descriptions for Automatic_Upgrader_Skin methods.
Props johannadevos, dilipbheda.
Fixes #44546.

git-svn-id: https://develop.svn.wordpress.org/trunk@49596 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-14 16:21:19 +00:00