34224 Commits

Author SHA1 Message Date
Jonathan Desrosiers
766399744d Build/Test Tools: Restore automated testing in the 4.5 branch.
This commit merges the workflow files required to run automated testing on GitHub Actions.

In addition, [49836] and [50285] have been included in order to keep the local Docker environment consistent across all branches.

Merges [49162,49168-49169,49175,49204,49227-49228,49244,49369,49371,49548,49781-49784,49786,49836,49938,50268,50285,50298] to the 4.5 branch.
See #50401.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@50313 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 20:00:11 +00:00
Jonathan Desrosiers
5a92c7bd76 Build/Test Tools: Backport the local Docker environment to the 4.5 branch.
This commit introduces the Docker-based local WordPress development environment to the 4.5 branch and converts the Travis test jobs to utilize this environment for easier and more consistent testing.

Merges [44176,45445,45745,45762,45783-45784,45800,45819,45885,46320,46999,47225,47912,48121,49267,49335,49358,49360,49362] to the 4.5 branch.
See #48301, #47767.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@50243 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-08 20:50:12 +00:00
Jonathan Desrosiers
0c39994b9d Build/Test Tools: Ignore patch related files, so they can't be accidentally committed.
Merges [39360-39361] to the 4.5 branch.
See #38727.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@50209 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-05 04:21:05 +00:00
Jonathan Desrosiers
2f3e040c4f Build/Test Tools: Support NodeJS 14.x in the 4.5 branch.
This updates the 4.5 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.

Because older branches use (really) old versions of NodeJS, the local Docker environment cannot be backported since the needed dependencies will not run on these older versions (see #48301). This also blocks the ability to move automated testing over to GitHub Actions (see #50401).

This also replaces the `npm-shrinkwrap.json` with a `package-lock.json` file. Lock files were not supported in earlier versions of NPM, but can now be used.

In addition to backporting the package updates that happened after branching 4.5, dependencies that were removed in future releases have also been updated to their latest versions.

Props desrosj, dd32, netweb, jorbin.
Merges [37185,37212,37612,38111,38688,39110,39113-39119,39478,42460-42461,42463,42887,43320,43323,43977,44219,44233,44728,45321,45765,46404,46408-46409,47404,47867-47869,47872-47873,48705,49636,49933,49937,49939,50017,50126,50176,50185,50192] to the 4.5 branch.
See #52341.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@50208 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-05 04:19:31 +00:00
Sergey Biryukov
994ccb10f9 Tests: Move skipTestOnTimeout() to a more appropriate location, for consistency with other branches.
Follow-up to [50088].

Merges [50097] to the 4.5 branch.
See #51669.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@50099 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-30 15:26:30 +00:00
Sergey Biryukov
f8317b35a7 Tests: Use skipTestOnTimeout() in more HTTP tests.
Adjust it to handle more types of timeouts, e.g. "Resolving timed out", "Connection timed out".

Merges [38757], [43511], [43512], [46682], [46996] to the 4.5 branch.
See #51669.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@50090 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-30 12:04:12 +00:00
Jonathan Desrosiers
9fc560b07b Build/Test Tools: Remove the TravisCI configuration file.
In [49162], GitHub Action workflow configuration files were introduced to run all of Core’s automated testing with the intent to fully transition after some time was allowed for testing.

After two full months of testing, the time to finish this transition has come.

We thank TravisCI for testing the codebase through nearly 20 major and many more minor releases.

Merges [49876] to the 4.5 branch.
See #52161. See #50401.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@49888 602fd350-edb4-49c9-b593-d223f7449a82
2020-12-22 21:10:49 +00:00
Jake Spurlock
13cc6cc6e3 Build/Test Tools: Match .nvmrc with the declared node engine.
Let's match up the versions from package.json, .travis.yml and .nvmrc.

This brings the changes from [49653] to the 4.5 branch.

Fixes #51682.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@49658 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-18 22:56:31 +00:00
Jake Spurlock
7d3e6bd78d Build/Test Tools: Match .nvmrc with the declared node engine.
Let's match up the versions from package.json, .travis.yml and .nvmrc.

This brings the changes from [49653] to the 4.5 branch.

Fixes #51682.

Props SergeyBiryukov, desrosj, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@49657 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-18 22:52:48 +00:00
Jonathan Desrosiers
a5fc920c18 WordPress 4.5.23.
git-svn-id: https://develop.svn.wordpress.org/branches/4.5@49419 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 19:34:03 +00:00
Jake Spurlock
05a7b2bce2 General: WordPress updates
* XML-RPC: Improve error messages for unprivileged users.
* External Libraries: Disable deserialization in Requests_Utility_FilteredIterator
* Embeds: Disable embeds on deactivated Multisite sites.
* Coding standards: Modify escaping functions to avoid potential false positives.
* XML-RPC: Return error message if attachment ID is incorrect.
* Upgrade/install: Improve logic check when determining installation status.
* Meta: Sanitize meta key before checking protection status.
* Themes: Ensure that only privileged users can set a background image when a theme is using the deprecated custom background page.

Brings the changes from [49380,49382-49388] to the 4.5 branch.

Props xknown, zieladam, peterwilsoncc, whyisjake, desrosj, dd32.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@49401 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 19:01:42 +00:00
Sergey Biryukov
87ed4449f3 Administration: Pass the result of set-screen-option filter to the new set_screen_option_{$option} filter to ensure backward compatibility.
Rename the `$keep` parameter of both filters to `$screen_option` for clarity, update the documentation to better reflect its purpose.

Follow-up to [47951].

Props Chouby, sswells, SergeyBiryukov.
Merges [48241] to the 4.5 branch.
Fixes #50392.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@48253 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-01 09:49:28 +00:00
Jonathan Desrosiers
d2c2699f9c WordPress 4.5.22.
git-svn-id: https://develop.svn.wordpress.org/branches/4.5@47998 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-10 21:32:38 +00:00
Jake Spurlock
6552d95984 General: Backport several commits for release.
- Embeds: Ensure that the title attribute is set correctly on embeds.
- Editor: Prevent HTML decoding on by setting the proper editor context.
- Formatting: Ensure that wp_validate_redirect() sanitizes a wider variety of characters.
- Themes: Ensure a broken theme name is returned properly.
- Administration: Add a new filter to extend set-screen-option.
Merges [47947-47951] to the 4.5 branch.
Props xknown, sstoqnov, vortfu, SergeyBiryukov, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@47973 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-10 18:39:52 +00:00
Sergey Biryukov
5c08ae53ec Update the About page for WordPress 4.5.21
git-svn-id: https://develop.svn.wordpress.org/branches/4.5@47695 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 18:32:00 +00:00
Jonathan Desrosiers
939846655e WordPress 4.5.21
git-svn-id: https://develop.svn.wordpress.org/branches/4.5@47675 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 17:56:28 +00:00
Jake Spurlock
6ae390697f Cache API: Ensure proper escaping around the stats method in the cache API.
Brings the changes in [47637] to the 4.5 branch.

Props: nickdaugherty, batmoo, whyisjake, westi.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@47654 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 16:42:56 +00:00
Jake Spurlock
971529fb03 User: Invalidate user_activation_key on password update.
Query: Ensure that only a single post can be returned on date/time based queries.
Cache API: Ensure proper escaping around the stats method in the cache API.
Formatting: Expand `sanitize_file_name` to have better support for utf8 characters.

Brings the changes in [47634], [47635], [47637], and [47638] to the 4.7 branch.

Props: batmoo, ehti, nickdaugherty, peterwilsoncc, sergeybiryukov, sstoqnov, westi, whyisjake, whyisjake, xknown.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@47652 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 16:25:54 +00:00
Sergey Biryukov
daf66727df Build/Test Tools: Remove unused ::assertPostHasTerms() method from tests/term.php.
The associated test was removed in [30241].

Merges [47341] to 3.7+ branches.
See #49485.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@47489 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-22 14:29:03 +00:00
Sergey Biryukov
9f33a098c9 Embeds: Remove the external oEmbed tests for YouTube.
These tests no longer test anything that WordPress core has control over. YouTube now serves everything
over HTTPS by default, so the tests for #23149 will always pass, and the tests for #32714 aren't testing
anything that core has control over.

Tests for the responses from oEmbed providers has been attempted and reverted in #32360.

Props johnbillion.
Merges [41712] to the 4.4 branch.
See #42076, #32714, #23149.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@47483 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-22 13:57:09 +00:00
Sergey Biryukov
4f12f34567 Embeds: Remove the external oEmbed tests for YouTube.
These tests no longer test anything that WordPress core has control over. YouTube now serves everything
over HTTPS by default, so the tests for #23149 will always pass, and the tests for #32714 aren't testing
anything that core has control over.

Tests for the responses from oEmbed providers has been attempted and reverted in #32360.

Props johnbillion.
Merges [41712] to the 4.5 branch.
See #42076, #32714, #23149.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@47482 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-22 13:46:15 +00:00
Sergey Biryukov
e9e95c33cd WordPress 4.5.20
git-svn-id: https://develop.svn.wordpress.org/branches/4.5@46928 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-12 20:29:37 +00:00
Sergey Biryukov
9573084b5d Update wp_kses_bad_protocol() to recognize : on uri attributes,
`wp_kses_bad_protocol()` makes sure to validate that uri attributes don’t contain invalid/or not allowed protocols. While this works fine in most cases, there’s a risk that by using the colon html5 named entity, one is able to bypass this function.

Brings r46895 to the 4.5 branch.

Props: xknown, nickdaugherty, peterwilsoncc.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@46913 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-12 18:44:52 +00:00
Jonathan Desrosiers
578c990d87 WordPress 4.5.19.
git-svn-id: https://develop.svn.wordpress.org/branches/4.5@46515 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 20:10:22 +00:00
Jake Spurlock
478c668350 Backporting several bug fixes.
- Query: Remove the static query property.
- HTTP API: Protect against hex interpretation.
- Filesystem API: Prevent directory travelersals when creating new folders.
- Administration: Ensure that admin referer nonce is valid.
- REST API: Send a Vary: Origin header on GET requests.
- Customizer: Properly sanitize background images.

Backports [46474], [46475], [46476], [46477], [46478], [46483], [46485] to the 4.5 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@46497 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 19:06:04 +00:00
Jake Spurlock
26f09592f8 Add .nvmrc files to older versions of WordPress
When jumping between branches, it would be nice to have the correct node version for the older versions of WordPress. Let's add .nvmrc files to these older branches for the supported versions.

Merges [46295] to the 4.5 branch.

Fixes #48140


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@46299 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-25 20:56:32 +00:00
Jonathan Desrosiers
34782dedae WordPress 4.5.18.
git-svn-id: https://develop.svn.wordpress.org/branches/4.5@46039 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 21:21:17 +00:00
Andrew Ozz
4504f6e969 jQuery: Backport the patch from jQuery 3.4.0.
Merges [45342] to the 4.5 branch.

Props MikeNGarrett, peterwilsoncc, azaozz.
Fixes #47020.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@46027 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 18:46:52 +00:00
Jonathan Desrosiers
fafead9bef Fix for URL sanitization in wp_kses_bad_protocol_once().
Merges [45997] to the 4.5 branch.

Props irsdl, sstoqnov, whyisjake.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@46009 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 18:21:38 +00:00
Sergey Biryukov
db04e3935e Improve handling the existing rel attribute in wp_rel_nofollow_callback().
Merges [45990] to the 4.5 branch.
Props xknown, sstoqnov.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@45999 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 17:53:08 +00:00
Sergey Biryukov
3796421296 Improve URL validation in wp_validate_redirect().
Merges [45971] to the 4.5 branch.
Props vortfu, whyisjake, peterwilsoncc.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@45980 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 17:11:47 +00:00
Jake Spurlock
7cab047134 Remove _convert_urlencoded_to_entities() from the get_the_content() callback.
Merges [45937] to the 4.5 branch.

Props vortfu, whyisjake, peterwilsoncc


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@45957 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:38:26 +00:00
Sergey Biryukov
27ba9999e3 Escape the output in wp_ajax_upload_attachment().
Merges [45936] to the 4.5 branch.
Props whyisjake, sstoqnov.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@45950 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:35:39 +00:00
John Blackbourn
63a7bc73b0 Build/Test tools: Further trimming of CI jobs on the 4.5 branch.
This removes the PHP 5.6 job which runs without an object cache in place as the likelihood of a change being backported that only breaks 5.6 environments without an object cache is small.

See #42387


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@45010 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-25 16:28:56 +00:00
John Blackbourn
1d9a3bd8cd Build/Test tools: Switch npm dependency caching strategy on Travis CI.
This switches to caching npm's local cache instead of `node_modules` in order to prevent issues caused by modules compiled using a different version of node.

Merges [44993] into the 4.5 branch.

See #46632


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@45000 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-25 00:58:06 +00:00
Gary Pendergast
fba7252de7 WordPress 4.5.17
git-svn-id: https://develop.svn.wordpress.org/branches/4.5@44876 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-13 01:24:06 +00:00
Sergey Biryukov
9f8474ace8 Formatting: Fix a PHP warning in introduced in [44840].
Merges [44864] to the 4.5 branch.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@44865 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-13 00:37:02 +00:00
Sergey Biryukov
19d2f136fe Comments: Improve comment content filtering.
Merges [44842] to the 4.5 branch.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@44849 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-12 22:37:58 +00:00
Sergey Biryukov
3b84dcc1e1 Formatting: Improve rel="nofollow" handling in comments.
Merges [44833] to the 4.5 branch.

git-svn-id: https://develop.svn.wordpress.org/branches/4.5@44840 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-12 22:24:04 +00:00
Jeremy Felt
58654f5739 Bump 4.5 branch to version 4.5.16.
git-svn-id: https://develop.svn.wordpress.org/branches/4.5@44082 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 02:12:25 +00:00
Gary Pendergast
a1208230a9 Editor: Remove unwanted fields before saving posts.
The `meta_input`, `file`, and `guid` fields are not intended to be updated through user input.

Merges [44047] to the 4.5 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.5@44060 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 01:44:41 +00:00
Peter Wilson
14759800ef Multisite: Validate activation links.
Merges [44048] to the 4.5 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@44059 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 01:43:52 +00:00
Ian Dunn
3a47187d69 KSES: Make the URI attributes DRY.
This commit introduces the `wp_kses_uri_attributes` function and filter. The function centralizes the list of attributes, in order to prevent inconsistency, and the filter provides a way for plugins to customize the attributes.

Merges [44014] and [44017] to the `4.6` branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@44032 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 00:53:10 +00:00
Peter Wilson
80801998e0 Multisite: Improve messaging for previously activated users.
Ensure activation of a site is not attempted multiple times and users are shown the correct message if they follow the link a second time.

Merges [44021] to the 4.5 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@44029 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 00:46:50 +00:00
Jeremy Felt
6eb8051102 Media: Remove invalid data from test data provider.
See [43993].


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@44006 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-12 23:37:16 +00:00
Gary Pendergast
42d4df558e KSES: Conditionally remove the <form> element from $allowedposttags.
To avoid backwards compatibility issues, `<form>` is re-added if a custom filter has added the `<input>` or `<select>` elements to `$allowedposttags`.

Merges [43994] to the 4.5 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@44002 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-12 23:28:48 +00:00
Jeremy Felt
0127179f66 Media: Improve verification of MIME file types.
Merges [43988] to the 4.5 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@43993 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-12 23:10:04 +00:00
Aaron D. Campbell
35f2f3acc0 Bump 4.5 branch to version 4.5.15
git-svn-id: https://develop.svn.wordpress.org/branches/4.5@43411 602fd350-edb4-49c9-b593-d223f7449a82
2018-07-05 16:10:34 +00:00
John Blackbourn
1c7f816341 Media: Limit thumbnail file deletions to the same directory as the original file.
Merges [43393] into the 4.5 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.5@43397 602fd350-edb4-49c9-b593-d223f7449a82
2018-07-05 14:54:32 +00:00
Aaron D. Campbell
d6f9fa0658 Bump 4.5 branch to version 4.5.14
git-svn-id: https://develop.svn.wordpress.org/branches/4.5@42937 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 20:27:08 +00:00