Follow up to [59727]. Handle cases where the `#current-page-selector` is not present on the page to prevent a JS warning.
Props tobiasbg, mamaduka, jorbin, joedolson.
See #62534.
git-svn-id: https://develop.svn.wordpress.org/trunk@59746 602fd350-edb4-49c9-b593-d223f7449a82
Custom post types may contain underscores, however block template registration has been using a regular expression that disallows underscores. Since the block template name for certain templates is directly associated with which post type it applies to, this regular expression was causing unexpected failures. This changeset adjusts the regular expression to allow block template names with underscore characters, effectively allowing block templates to be registered for any custom post type.
Props alexandrebuffet, ankitkumarshah, gaambo, jorbin, karthickmurugan, oglekler, poena, sukhendu2002.
Fixes#62523.
git-svn-id: https://develop.svn.wordpress.org/trunk@59742 602fd350-edb4-49c9-b593-d223f7449a82
The Root Certificate bundle maintained by Mozilla ships in WordPress to allow SSL certificates to be verified on hosts with incomplete, outdated, or invalid local SSL configurations. To date, updates have only been merged into Core when problems arise using a highly manual process.
This introduces the `certificates:upgrade` Grunt task to automate the process of updating the included bundle with upstream changes using Composer to manage versioning.
The legacy 1024bit certificates included for backwards compatibility are now maintained in a separate file that is prepended to the built version of the bundle during the relevant Grunt tasks. Some expired certificates from this list have been removed:
- Cybertrust Global Root (expired 2021-12-15)
- Thawte Server CA (expired 2020-12-31)
- Thawte Premium Server CA (expired 2020-12-31)
The Dependabot configuration has also been updated to open pull requests when new releases occur upstream. Going forward, the recommendation is to create a task ticket for updating these certificates with each release when an update is published. See #62811 for an example of this.
Props johnbillion, desrosj, whyisjake, ayeshrajans, SergeyBiryukov, swissspidy, skithund, barry.
Fixes#62812. See #62811, 50828.
git-svn-id: https://develop.svn.wordpress.org/trunk@59740 602fd350-edb4-49c9-b593-d223f7449a82
On some instances of Windows, the assertions seem to find additional nodes. As this test is just about verifying that the handlers get called, not about testing the functionality of the handlers, we can adjust the assertion to look for a minimum number of nodes rather than exact number.
Follow-up to [59062].
Props yogeshbhutkar, hellofromTonya, SergeyBiryukov, coquardcyr, jrf, benniledl, desrosj, jorbin.
Fixes#62110. See #62061.
git-svn-id: https://develop.svn.wordpress.org/trunk@59739 602fd350-edb4-49c9-b593-d223f7449a82
Includes a micro-optimization to avoid calling `get_current_network_id()` in a loop.
Follow-up to [8075], [9798], [26120], [38814].
Props aristath, poena, afercia, SergeyBiryukov.
See #62279.
git-svn-id: https://develop.svn.wordpress.org/trunk@59738 602fd350-edb4-49c9-b593-d223f7449a82
Fix omitted filter argument variable name for `the_password_form_incorrect_password`. Follow up to [59736].
Props mukesh27, joedolson.
See #37332.
git-svn-id: https://develop.svn.wordpress.org/trunk@59737 602fd350-edb4-49c9-b593-d223f7449a82
Display a message notifying the user of an incorrect password when submitting the post password form. Improve the accessibility of the form by adding a required attribute for consistent identification.
Props henry.wright, jonnyauk, kreppar, tommusrhodus, joedolson, audrasjb, jdahir0789, parthvataliya, dhruvang21.
Fixes#37332.
git-svn-id: https://develop.svn.wordpress.org/trunk@59736 602fd350-edb4-49c9-b593-d223f7449a82
Deprecate the actions `setted_transient` and `setted_site_transient` in favour of `set_transient` and `set_site_transient` respectively.
This serves two purposes, the name is consistent with the transient specific actions `set_(site_)_transient_{$transient}`, and to make the names grammatically correct.
Props sukhendu2002, swissspidy, johnbillion, peterwilsoncc.
Fixes#62849.
git-svn-id: https://develop.svn.wordpress.org/trunk@59735 602fd350-edb4-49c9-b593-d223f7449a82
This changeset replaces plugin sanitized names with an auto increment integer to fix an issue with accordions displaying privacy policies for plugins with special characters in their names.
Follow-up to [50161].
Props ecgan, sabernhardt, audrasjb.
Fixes#62713.
git-svn-id: https://develop.svn.wordpress.org/trunk@59732 602fd350-edb4-49c9-b593-d223f7449a82
This changeset allows for block metadata collections to be registered for almost any source, such as MU plugins, themes, or custom directories with e.g. symlinked plugins or symlinked themes. Prior to the change, block metadata collections could only be registered for plugins and WordPress Core.
There are still safeguards in place to prevent registration of collections in locations that would cause conflicts. For example, it is not possible to register a collection for the entire `wp-content/plugins` directory or the entire `wp-content/themes` directory, since such a collection would conflict with any specific plugin's or theme's collection. In case developers would like to enable this safeguard for their own custom directories, they can use the new `wp_allowed_block_metadata_collection_roots` filter.
Props assassinateur, bowedk, desrosj, dougwollison, flixos90, glynnquelch, gziolo, jorbin, mreishus, swissspidy.
Fixes#62140.
git-svn-id: https://develop.svn.wordpress.org/trunk@59730 602fd350-edb4-49c9-b593-d223f7449a82
While the `skipTestOnTimeout()` method will catch a timeout and prevent it from causing a test to fail, other errors such as a failed DNS lookup or HTTPS handshake can still cause a test to unnecessarily fail. This introduces a simple retry mechanism that will hopefully further reduce the flakiness of tests that perform HTTP API requests.
Fixes#62830
git-svn-id: https://develop.svn.wordpress.org/trunk@59729 602fd350-edb4-49c9-b593-d223f7449a82
This instructs an intermediate cache, for example a proxy server, to not cache a password protected post both before and after a visitor has entered a password.
Props brevilo, haozi, ironprogrammer, narenin
Fixes#61711
git-svn-id: https://develop.svn.wordpress.org/trunk@59728 602fd350-edb4-49c9-b593-d223f7449a82
Fix an issue introduced in [59134] that prevented manual entry of a page number in the pagination input field from navigating pages. Requiring validation of the bulk actions input also impacted other inputs nested in the same form.
Also fixes a pre-existing bug where it was not possible to navigate to page 1 using the input field.
Props ffffelix, im3dabasia1, apermo, rishavdutta, joedolson, swissspidy, jorbin, joedolson.
Fixes#62534.
git-svn-id: https://develop.svn.wordpress.org/trunk@59727 602fd350-edb4-49c9-b593-d223f7449a82
The intention of these headers is to prevent any form of caching, whether that's in the browser or in an intermediate cache such as a proxy server. These directives instruct an intermediate cache to not store the response in their cache for any user – not just for logged-in users.
This does not affect the caching behaviour of assets within a page such as images, CSS, and JavaScript files.
Props kkmuffme, devansh2002, johnbillion.
Fixes#61942
git-svn-id: https://develop.svn.wordpress.org/trunk@59724 602fd350-edb4-49c9-b593-d223f7449a82
Because the build process test workflow accepts an input for runner image, older workflows still use `ubuntu-latest`. This adjusts a conditional check to be more broad, allowing any `ubuntu-` image to match.
Follow up to [59720].
See #62221.
git-svn-id: https://develop.svn.wordpress.org/trunk@59722 602fd350-edb4-49c9-b593-d223f7449a82
While using the `ubuntu-latest`, `macos-latest`, and `windows-latest` runner image tags is convenient, it has proven to be problematic in a number of instances as the runners are slowly updated (see #62808 and #62843).
This switches all workflows to using specific version tags representing the latest non-preview versions, which currently are as follows:
- `ubuntu-24.04`
- `windows-2022`
- `macos-14`
Props swissspidy, johnbillion.
See #62221.
git-svn-id: https://develop.svn.wordpress.org/trunk@59720 602fd350-edb4-49c9-b593-d223f7449a82
The menu, menu item, and menu location endpoints were added to the REST API in [52079]. In that commit, menu data was treated as private and restricted to logged-in users with the edit_theme_options capability. However, in many cases, this data can be considered public. Previously, there was no simple way for developers to allow this data to be exposed via the REST API.
This commit introduces the rest_menu_read_access filter, enabling developers to control read access to menus, menu items, and menu locations in the REST API. The same filter is applied across all three REST API classes, simplifying the process of opting into exposing this data.
Each instance of the filter provides the current request and the relevant class instance as context, allowing developers to selectively or globally enable access to the data.
Props spacedmonkey, antonvlasenko, kadamwhite, julianmar, masteradhoc.
Fixes#54304.
git-svn-id: https://develop.svn.wordpress.org/trunk@59718 602fd350-edb4-49c9-b593-d223f7449a82
The input for providing files to the `codecov/codecov-action` was changed from `file` to `files` in version `5.0.0`.
See #62221.
git-svn-id: https://develop.svn.wordpress.org/trunk@59717 602fd350-edb4-49c9-b593-d223f7449a82
This updates the following GitHub Actions to their latest versions:
- `actions/cache`
- `actions/checkout`
- `actions/setup-node`
- `actions/upload-artifact`
- `codecov/codecov-action`
- `shivammathur/setup-php`
See #62221.
git-svn-id: https://develop.svn.wordpress.org/trunk@59716 602fd350-edb4-49c9-b593-d223f7449a82
Replaced the raw SQL query in the `wp_get_post_autosave` function with a `WP_Query` call. This change improves code maintainability and replaces the raw SQL query with a cacheable query via `WP_Query`.
Props narenin, swissspidy, mukesh27, spacedmonkey, im3dabasia1.
Fixes#62658.
git-svn-id: https://develop.svn.wordpress.org/trunk@59715 602fd350-edb4-49c9-b593-d223f7449a82
Change "Text to have the HTML tags striped out of." to "Text to strip the HTML tags from."
Replaces an unclear statement with a typo with a more clear statement.
Props joedolson, mukesh27, dhruvang21.
Fixes#62851.
git-svn-id: https://develop.svn.wordpress.org/trunk@59714 602fd350-edb4-49c9-b593-d223f7449a82
This sets the same referrer policy of `strict-origin-when-cross-origin` that's used in the admin area to prevent a referrer being sent to other origins. This helps prevent unwanted exposure of potentially sensitive information that may be contained within the URL.
The header can be disabled if necessary by removing the `wp_admin_headers` action from the `login_init` hook.
Props kkmuffme, sagarlakhani, albatross10
Fixes#62273
See #42036
git-svn-id: https://develop.svn.wordpress.org/trunk@59712 602fd350-edb4-49c9-b593-d223f7449a82
This changeset replaces `title` attributes with `aria-label` for weekdays in `get_calendar()` table cells.
Props sabernhardt, audrasjb, mukesh27, shailu25.
Fixes#62860.
See #24766.
git-svn-id: https://develop.svn.wordpress.org/trunk@59711 602fd350-edb4-49c9-b593-d223f7449a82
This changeset lowers the font-weight value from `600` to `400` for labels located in the Settings screens.
This is an initial implementation of the WordPress design system, aligning with the broader goal of achieving a more consistent and unified design across the administration.
Props karmatosed, audrasjb.
Fixes#62865.
git-svn-id: https://develop.svn.wordpress.org/trunk@59709 602fd350-edb4-49c9-b593-d223f7449a82
This changeset fixes an UI issue where the theme count in the "Add Themes" screen touches the top border on small screens.
Props sukhendu2002, diliphingarajiya, dilipbheda, ankitkumarshah, dhruvang21, im3dabasia1.
Fixes#62499.
git-svn-id: https://develop.svn.wordpress.org/trunk@59708 602fd350-edb4-49c9-b593-d223f7449a82
This changeset fixes a margin issue in the search input box on the Add New Plugins screen, which was previously breaking below 1138px. Specifically, the top margin was set to 0px, and the overall appearance of the search box was inconsistent between 1000px and 1138px. Now, the margin is consistent across all breakpoints.
Props jomonthomaslobo1, narenin, iflairwebtechnologies, peterwilsoncc, audrasjb, shailu25.
Fixes#61785.
git-svn-id: https://develop.svn.wordpress.org/trunk@59706 602fd350-edb4-49c9-b593-d223f7449a82
This changeset replaces the light grey background color with the white color defined in the Editor Storybook. This change also impacts admin color schemes that previously utilized the default admin background color.
This is an initial implementation of the WordPress design system, aligning with the broader goal of achieving a more consistent and unified design across the administration.
Props karmatosed, audrasjb.
Fixes#62831.
git-svn-id: https://develop.svn.wordpress.org/trunk@59705 602fd350-edb4-49c9-b593-d223f7449a82
This changeset adds more details on the `WP_Term` returned by `get_category()` as it contains additional backwards compatible aliases for the era before WP 4.4 and 2.3.
Props apermo, audrasjb.
Fixes#62842.
See #62281.
git-svn-id: https://develop.svn.wordpress.org/trunk@59704 602fd350-edb4-49c9-b593-d223f7449a82
Since [13683], `the_shortlink()` has included a `title` attribute. By default, that gives the sanitized post title, and it does not sanitize custom text. Given the low value of this attribute, this changeset removes it.
Props sabernhardt, audrasjb, joedolson.
Fixes#62838.
See #24766.
git-svn-id: https://develop.svn.wordpress.org/trunk@59703 602fd350-edb4-49c9-b593-d223f7449a82
This changeset introduces the new `import_filters` action hook at the end of the Import screen, consistently with other admin screens like `export.php`.
Props audrasjb, lenasterg.
Fixes#54419.
See #19863.
git-svn-id: https://develop.svn.wordpress.org/trunk@59701 602fd350-edb4-49c9-b593-d223f7449a82
This new argument, which defaults to the value of `public`, can be used to determine whether a post can be embedded using oEmbed. A new `is_post_embeddable()` function is added to easily check this.
Props pampfelimetten, swissspidy, bradleyt, DrewAPicture, gadelhas, mukesh27.
Fixes#35567.
git-svn-id: https://develop.svn.wordpress.org/trunk@59700 602fd350-edb4-49c9-b593-d223f7449a82
This changeset introduces new classes to the body tag. The classes `wp-theme-<name>` and `wp-child-theme-<name>` (when the current theme is a child theme) are added, where `<name>` represents the sanitized name of the active theme.
Props cais, GaryJ, nacin, SergeyBiryukov, johnjamesjacoby, nirajgirixd, poena, audrasjb, rinkalpagdar.
Fixes#19736.
git-svn-id: https://develop.svn.wordpress.org/trunk@59698 602fd350-edb4-49c9-b593-d223f7449a82
This resolves a WPCS warning:
{{{
Variable "$ID" is not in valid snake_case format, try "$i_d"
}}}
Follow-up to [28448].
See #62279.
git-svn-id: https://develop.svn.wordpress.org/trunk@59697 602fd350-edb4-49c9-b593-d223f7449a82
Rename the 'Text' tab of the classic editor to 'Code', mimicking the labels used in the block editor: "Visual editor" and "Code editor".
Update code comment and Help documentation to reference the editor using the new label.
Props lukecavanagh, ctienshi, travel_girl, audrasjb, sabernhardt, joedolson, rseigel, mark-k, sergeybiryukov, presskopp, giuriani, afercia, knutsp, audrasjb, sukhendu2002.
Fixes#38061.
git-svn-id: https://develop.svn.wordpress.org/trunk@59696 602fd350-edb4-49c9-b593-d223f7449a82
Remove the option "Disable the visual editor when writing" from the user profile if it is currently false. If enabled, the option will stay available until disabled.
This was blocked due to issues with tab order and focusability in the classic editor environment until [59188].
Props mark-k, SergeyBiryukov, joedolson, pento, iseulde, chriscct7, afercia, prasadkarmalkar, rcreators, jamieblomerus.
Fixes#34681.
git-svn-id: https://develop.svn.wordpress.org/trunk@59695 602fd350-edb4-49c9-b593-d223f7449a82
Prior to r59679 this value was echoed to GitHub output which meant that its surrounding double quotes lost their significance. Now this value is used directly in the job output it needs to be treated as a plain string.
This concludes the conclusion confusion.
See #82221
git-svn-id: https://develop.svn.wordpress.org/trunk@59693 602fd350-edb4-49c9-b593-d223f7449a82
This aims to avoid confusion with `the_date()` and `get_the_date()`.
Includes synchronizing the description for `the_weekday()` and `the_weekday_date()`, which have very similar functionality, except that the latter will only output the weekday if the current post's weekday is different from the previous one output.
Follow-up to [59691].
See #51289.
git-svn-id: https://develop.svn.wordpress.org/trunk@59692 602fd350-edb4-49c9-b593-d223f7449a82
This changeset clarifies the purpose of these functions and make the documentation more accurate and flexible. Instead of referring to the "date the post was written," the functions and filter descriptions now refer to the "date of the post." This change accommodates scenarios where the displayed date might not strictly correspond to the writing date (e.g. scheduled posts, backdated posts, or content where the "date" represents something other than creation).
Props casiepa, audrasjb, SergeyBiryukov, Rarst, helen, azouamauriac, pbearne.
Fixes#51289.
git-svn-id: https://develop.svn.wordpress.org/trunk@59691 602fd350-edb4-49c9-b593-d223f7449a82
This changeset deletes the arrow that is typically added next to WordPress admin menu items that have submenus. The `.wp-menu-arrow` element is no longer visible since the WP 3.8 redesign, but the HTML and CSS remained. With this changeset, the HTML generating the arrow is removed, and the corresponding CSS styling is deleted.
Props helen, azaozz, jbkkd, pbearne, flixos90.
Fixes#26960.
git-svn-id: https://develop.svn.wordpress.org/trunk@59690 602fd350-edb4-49c9-b593-d223f7449a82
