43944 Commits

Author SHA1 Message Date
Sergey Biryukov
81e84e12e8 Tests: Ignore EOL differences in some tests using multiline string assertions.
Unix vs. Windows EOL style mismatches can cause misleading failures in tests using the heredoc syntax (`<<<`) or multiline strings as the expected result.

Follow-up to [48466], [50995], [51079].

See .

git-svn-id: https://develop.svn.wordpress.org/trunk@51135 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-09 19:41:47 +00:00
Jonathan Desrosiers
b0eadda6e6 Upgrade/Install: Built files should not be included in the $_old_files list.
Follow up to [51133].
Unprops desrosj.
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@51134 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-09 16:20:11 +00:00
Jonathan Desrosiers
20d1075ed0 Upgrade/Install: Update the $_old_files list for 5.8.
Follow up to [50761], [50794], [51021].
Props kapilpaul, desrosj.
See , , .
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@51133 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-09 15:53:49 +00:00
Jonathan Desrosiers
676fb1bc18 Post WordPress 5.8 Beta 1 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@51132 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-09 02:39:44 +00:00
Jonathan Desrosiers
1707206579 WordPress 5.8 Beta 1.
git-svn-id: https://develop.svn.wordpress.org/trunk@51131 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-09 02:01:05 +00:00
Jonathan Desrosiers
c83d315d52 Build/Test Tools: Silence jQuery Migrate console warnings when running E2E tests.
These warnings will still be visible in the browser console. The majority of the warnings are coming from jQuery UI, which is still waiting for a new update to be released that is jQuery >= 3.0 friendly.

This change makes the E2E test results more readable without having to tread through the large number of warnings.

Props isabel_brison.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@51130 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-09 01:35:26 +00:00
Anthony Burchell
1c418298bf Privacy: Improve naming of user confimed action email filters.
The filters `user_confirmed_action_email_content`, `user_erasure_complete_email_subject`, and `user_erasure_complete_email_headers` have been deprecated.

They have been replaced with `user_erasure_fulfillment_email_content`, `user_erasure_fulfillment_email_subject`, and `user_erasure_fulfillment_email_headers`.

Props desrosj, garrett-eclipse, birgire, DrewAPicture, lifeforceinst, ocean90, pbiron, pento, coffee2code, TZ-Media, SergeyBiryukov, johnbillion, audrasjb, davidbaumwald, hellofromTonya, helen, xkon, antpb, peterwilsoncc, lukecarbis.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@51129 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-09 01:34:09 +00:00
Jonathan Desrosiers
a2969fb07f Tests: Introduce some E2E tests for the Quick Draft dashboard widget.
Props isabel_brison, johnbillion.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@51128 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-09 00:19:25 +00:00
Jake Spurlock
c4373a7004 Widgets: Don't decode HTML entities ahead of the widget constructor.
This reverts the changes from [51114]. 

See .

Unprops whyisjake. 


git-svn-id: https://develop.svn.wordpress.org/trunk@51127 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 23:38:50 +00:00
Jonathan Desrosiers
387f3eebf2 Login and Registration: Improve the unknown username error message
The new message is more clear and makes the next step more clear to the user. 

Props dd32, SergeyBiryukov, audrasjb, desrosj, dlh, marybaum, chanthaboune, jeffpaul.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@51126 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 23:33:16 +00:00
Jake Spurlock
d56d4afd02 Permalinks: Revert the changes stemming from pagination limits.
In [51118], an attempt was made to add pagination limits. The added tests need to be updated to ensure that they pass with the new changes.

Reverts [51118].

See .


git-svn-id: https://develop.svn.wordpress.org/trunk@51125 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 23:31:46 +00:00
Jake Spurlock
1eb777209d Revisions: Check and return errors for insertions to revisions.
Fixes .

Props rmccue, adamsilverstein, coreymckrill, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/trunk@51124 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 23:23:12 +00:00
Anthony Burchell
9f9261f051 Media: Allow multi-uploads in Galleries.
Previously, when more than one media item was uploaded using a gallery, failures occurred on the second upload.

Props glendaviesnz, Mista-Flo, hellofromTonya.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@51123 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 23:12:23 +00:00
Jake Spurlock
38232f655d Media: Add new functions to return the previous/next attachment links.
New functions:

* get_adjacent_image_link()
* get_next_image_link()
* get_previous_image_link()

Fixes .

Props flixos90, DrewAPicture, mor10, antpb, hellofromTonya, whyisjake.




git-svn-id: https://develop.svn.wordpress.org/trunk@51122 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 23:12:22 +00:00
Anthony Burchell
c2313c6934 Feeds: Avoid notices in get_post_comments_feed_link().
When an feed request is made to a non-existent page, surpress the notice.

Props dd32, SergeyBiryukov, mukesh27, hellofromTonya.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@51121 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 22:59:19 +00:00
Jonathan Desrosiers
de69bbd713 Coding Standards: Use single quotes when there are no variables within the string.
Follow up to [51117].

See .

git-svn-id: https://develop.svn.wordpress.org/trunk@51120 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 22:54:59 +00:00
Jonathan Desrosiers
37d7346ea2 Administration: Adjust Internet Explorer message to be a bit more clear.
This moves “Internet Explorer” to the beginning of the sentence introduced in [51117] to make the reason the user is seeing this message more clear.

Props chanthaboune, jeffpaul, desrosj.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@51119 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 22:53:10 +00:00
Jake Spurlock
346e47b176 Permalinks: Limit pagination for posts with comments.
Additionally, redirect pages back to the source page if comments don't exist.

Props devrekli, carike, sumanm, mukesh27, chaion07, audrasjb, whyisjake, SergeyBiryukov.

Fixes .


git-svn-id: https://develop.svn.wordpress.org/trunk@51118 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 22:49:27 +00:00
Anthony Burchell
7b2793e242 Administration: Introduce dashboard notice to discourage use of out of date browser.
If a browser matches Internet Explorer, the dashboard will display a notice recommending a more modern browser.

Props youknowriad, sabernhardt, afercia, SergeyBiryukov, davidbaumwald, netweb, johnbillion, jeherve.
See .



git-svn-id: https://develop.svn.wordpress.org/trunk@51117 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 22:47:00 +00:00
Jake Spurlock
69d7762ad4 Editor: Ensure that the block editor can be used on the page post type.
Additionally, add a notice for when you are editing the "latest posts" page.

Fixes .

Props cameronjonesweb, swissspidy, hannahmalcolm, Fantasy1125, ArnaudBan, grantmkin, youknowriad, knutsp, SergeyBiryukov, audrasjb, whyisjake. 


git-svn-id: https://develop.svn.wordpress.org/trunk@51116 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 22:37:34 +00:00
Jake Spurlock
5001efad74 Administration: Escape the values of data-colname.
Adds a `esc_attr` wrapper to `strip_all_tags`.

See [33016].

Fixes .

Props rellect, SergeyBiryukov, hareesh-pillai, audrasjb.



git-svn-id: https://develop.svn.wordpress.org/trunk@51115 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 22:20:42 +00:00
Jake Spurlock
fe1ef97ef3 Widgets: Ensure that HTML entities are converted in widget descriptions.
Fixes .

Props justinahinon, audrasjb.


git-svn-id: https://develop.svn.wordpress.org/trunk@51114 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 22:16:03 +00:00
Jonathan Desrosiers
f64478d67c Emoji: Update the Twemoji library to version 13.1.0.
This version introduces support for the latest Emoji added in version Emoji 13.1, which includes “face in clouds”, “face exhaling”, and of course, “face with spiral eyes”.

A new corresponding folder has been pushed to WordPress.org in [dotorg:17419].

Rages deep within, ❤️‍🔥.

Props kraftbj., desrosj.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@51113 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 22:13:27 +00:00
Jake Spurlock
68b6298828 Build/Test Tools: Ensure that we are using https:// urls.
Fix from automated install.

See [51111], .


git-svn-id: https://develop.svn.wordpress.org/trunk@51112 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 22:11:37 +00:00
Jake Spurlock
3f41775f27 Media: Ensure that post_id variable is initiated ahead of usage.
This prevents warnings when using custom bulk actions in the media library.

Props gitlost, achbed, Boniu91, wpgurudev, hellofromTonya.

Fixes .


git-svn-id: https://develop.svn.wordpress.org/trunk@51111 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 22:06:32 +00:00
Kelly Choyce-Dwan
cea3994d29 Twenty Thirteen: Add "No Shadow" style to button block.
This creates a new block style without a shadow, and fixes colors on outline buttons.

Props melchoyce, kjellr, scruffian.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@51110 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 20:36:36 +00:00
Kelly Choyce-Dwan
b98d11e680 Block Editor: Ignore generated CSS files in Page List and Post Template blocks.
Add SVN ignore property to match existing rule in `.gitignore`.

Follow up to [51101], [51105].
See , .



git-svn-id: https://develop.svn.wordpress.org/trunk@51109 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 20:08:50 +00:00
Kelly Choyce-Dwan
a49b4f6ed3 Login and Registration: Wrap long site titles to a new line.
Props sumitsingh, geekpress, sabernhardt.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@51108 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 19:45:20 +00:00
Aaron Jorbin
d5dcf8fab7 Widgets: Prevent infinite loop in PHP8+ if the URL for the widget instance is incorrectly defined
This checks to make sure $link isn't empty before attempting to manipulate it.  A simple test to demonstrate this can be seen at https://3v4l.org/PgSZg. Unit tests for both what already works and what is fixed by this change.

Props hellofromTonya, dd32, peterwilsoncc.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@51107 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 19:34:28 +00:00
Kelly Choyce-Dwan
d0daedb0ac Bundled Themes: Introduce block patterns for Twenty Ten.
Props beafialho, kjellr, melchoyce, danieldudzic, onemaggie.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@51106 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 18:52:55 +00:00
Riad Benguella
0d4bdbf835 Block Editor: Include the page list block server-side code.
On a previous package update, this block's server-side code has been missed.
This was causing the block to not render properly.

Props Chouby, desrosj, mcsf.
Fixes .


git-svn-id: https://develop.svn.wordpress.org/trunk@51105 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 18:11:31 +00:00
Riad Benguella
cbacd3c356 Block Editor: Fix typo in the typography block support.
The function wp_typography_get_css_variable_inline_style has been renamed when backported to Core.
But its usage was untouched causing potential php errors on the frontend.

See .


git-svn-id: https://develop.svn.wordpress.org/trunk@51104 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 18:05:35 +00:00
Kelly Choyce-Dwan
192462462e Bundled Themes: Introduce block patterns for Twenty Eleven.
Props beafialho, kjellr, melchoyce, audrasjb.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@51103 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 18:02:20 +00:00
Riad Benguella
716a99587c Block Editor: Allow themes to add inline styles for all blocks when using lazy styles loading.
Props aristath.
Fixes .


git-svn-id: https://develop.svn.wordpress.org/trunk@51102 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 17:35:06 +00:00
Riad Benguella
9ae2587b76 Block Editor: Package updates for WordPress 5.8 beta 1 (batch2).
This includes the following fixes:

 - Fix inspector opening when clicking outside the widget areas
 - Assume light theme when a transparent background is used
 - Make Post blocks non editable inside Query block
 - Rename QueryLoop to PostTemplate block

Props ntsekouras.
See .


git-svn-id: https://develop.svn.wordpress.org/trunk@51101 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 17:31:14 +00:00
Jonathan Desrosiers
12af1ca279 Twenty Twenty: Regenerate the RTL editor stylesheet.
This applies the change made in [51095] to the RTL stylesheet.

See .

git-svn-id: https://develop.svn.wordpress.org/trunk@51100 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 17:27:41 +00:00
Jonathan Desrosiers
e17ec05b7b Build/Test Tools: Update devDependencies for bundled themes.
This applies several minor updates bring `devDependencies` to their latest versions in Twenty Twenty-One, Twenty Twenty, and Twenty Nineteen.

Several other packages are also having their versions bumped as a result of running `npm audit fix`.

See .

git-svn-id: https://develop.svn.wordpress.org/trunk@51099 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 17:24:43 +00:00
Kelly Choyce-Dwan
3a2e2cd450 Twenty Nineteen: Set a default color for button links in the editor.
Props mikejolley, poena, boniu91.
Fixes .


git-svn-id: https://develop.svn.wordpress.org/trunk@51098 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 17:20:19 +00:00
Jonathan Desrosiers
4b5bd0fccd Build/Test Tools: Update several devDependencies.
This updates `qunit`, `sass`, and `uglify-js` to thei latest versions.

Several other packages are also having their versions bumped as a result of running `npm audit fix`.

See .

git-svn-id: https://develop.svn.wordpress.org/trunk@51097 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 17:13:26 +00:00
Kelly Choyce-Dwan
842157a4fd Twenty Nineteen: Fix pullquote styling in editor when block has alignment.
Props devnel, sabernhardt.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@51096 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 16:49:21 +00:00
Kelly Choyce-Dwan
34bda4070b Twenty Twenty: Ensure custom primary color is applied to text in the editor.
Update the specificity of the custom CSS to match the editor styles. This overrides the default primary color with the selected custom color, matching the frontend display.

Props sabernhardt, notlaura.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@51095 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 15:05:34 +00:00
Jonathan Desrosiers
d5e419ade2 Script Loader: Fix 404 errors for the jquery-masonry script when SCRIPT_DEBUG is true.
The unminified version of `jquery-masonry` has never been included in Core. This hard codes the `.min` into the file source to prevent these errors.

Props pondermatic, isabel_brison, SergeyBiryukov, azaozz, desrosj.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@51094 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 14:58:22 +00:00
Jonathan Desrosiers
5cd6bfe2e0 Coding Standards: Apply an alignment fix.
Follow up to [51021].

See .

git-svn-id: https://develop.svn.wordpress.org/trunk@51093 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 13:21:41 +00:00
Sergey Biryukov
38d47a9979 Upgrade/Install: Remove parsing of readme.txt files for plugin or theme requirements.
This affects:
* `validate_plugin_requirements()`
* `validate_theme_requirements()`

Historically, the `Requires PHP` header was introduced in #meta2952 for the Plugin Directory first, so at the time it made sense to have it defined in the same place as `Requires at least`, which only existed in `readme.txt`. 

Since parsing of PHP and WordPress requirements was later added to WordPress core, the core should retrieve all the necessary data from the main plugin or theme file and not from `readme.txt`, which only contains the data meant for the Plugin or Theme Directory.

The recommended place for `Requires PHP` and `Requires at least` headers is as follows:
* The plugin's main PHP file
* The theme's `style.css` file

The place for the `Tested up to` header remains in `readme.txt` for the time being, as it's not used by WordPress core.

Follow-up to [44978], [45546], [47573], [47574], [meta5841], [meta9050].

Props afragen, Otto42, joyously, williampatton, audrasjb.
Fixes . See , #meta2952, #meta4514, #meta4621.

git-svn-id: https://develop.svn.wordpress.org/trunk@51092 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 10:11:49 +00:00
Riad Benguella
611d953e15 Block Editor: Add the Site Logo block's server implementation.
Props aristath, timothyblynjacobs, ocean90.
Fixes .


git-svn-id: https://develop.svn.wordpress.org/trunk@51091 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 08:26:23 +00:00
Riad Benguella
900367bc7a Block Editor: Add a type property to allow Core to identify the source of the editor styles.
Gutenberg plugin need to override the editor styles provided by core selectively,
this added property allows it to do so without committing to a public API.

Props nosolosw, jorgefilipecosta.
See .


git-svn-id: https://develop.svn.wordpress.org/trunk@51090 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 08:14:59 +00:00
Riad Benguella
377c88d462 Block Editor: Package updates for 5.8 beta 1.
This includes the following fixes:


Widgets Editor:
  - Load widgets.php https://github.com/WordPress/gutenberg/pull/32299
 - Fix Legacy Widget Preview https://github.com/WordPress/gutenberg/pull/32300
 - Fix error when saving empty Legacy Widget block https://github.com/WordPress/gutenberg/pull/32359

Widget blocks in the customizer: 
 - Fix deselection blocks when the inspector is open https://github.com/WordPress/gutenberg/pull/32361
 - Display wide widgets as popovers https://github.com/WordPress/gutenberg/pull/31736

Global Styles:
 - Align classNames generation between client and server https://github.com/WordPress/gutenberg/pull/32352
 - Group typography block supports https://github.com/WordPress/gutenberg/pull/32252 https://github.com/WordPress/gutenberg/pull/32444 https://github.com/WordPress/gutenberg/pull/32459
 - Make theme.json syntax errors more visible to the users https://github.com/WordPress/gutenberg/pull/32404


Template Editor:
  - Update the appearance of the template details https://github.com/WordPress/gutenberg/pull/32042
  - Fix layout definition https://github.com/WordPress/gutenberg/pull/32425
  - Fix grouping post content block https://github.com/WordPress/gutenberg/pull/32453

Miscellaneous:
 - Prevent saving when the post is locked https://github.com/WordPress/gutenberg/pull/32341
 - Fix allowed block patterns selector https://github.com/WordPress/gutenberg/pull/32376
 - Fix wrong results in the Post Author picker https://github.com/WordPress/gutenberg/pull/32344
 - Fix notices position in top toolbar mode https://github.com/WordPress/gutenberg/pull/32238
 - Allow non-latin characters in post slugs https://github.com/WordPress/gutenberg/pull/32232
 - Fix Random collapse of the color settings panel https://github.com/WordPress/gutenberg/pull/32388
 - Fix theme logo theme mode not being removed on theme removal https://github.com/WordPress/gutenberg/pull/32370
 - Fix block alignment styles in the editor https://github.com/WordPress/gutenberg/pull/32454
 - Fix some block toolbar overlaps https://github.com/WordPress/gutenberg/pull/32424
 - Fix content loss when switching list types https://github.com/WordPress/gutenberg/pull/32432


Performance:
 - Improve the performance of buttons block https://github.com/WordPress/gutenberg/pull/32356
 - Improve the performance of the container blocks https://github.com/WordPress/gutenberg/pull/32380

Props noisysocks, nosolosw, jorgefilipecosta.
See .


git-svn-id: https://develop.svn.wordpress.org/trunk@51089 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 08:07:15 +00:00
Robert Anderson
8add05ff15 Make new WordPress installations use blocks in widget areas instead of widgets
Modifies `wp_install_defaults()` so that when you install a new WordPress site you
have block in your widget areas, not widgets.

Fixes .
Props isabel_brison, hellofromtonya, andraganescu.


git-svn-id: https://develop.svn.wordpress.org/trunk@51088 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 01:54:27 +00:00
Aaron Jorbin
880a308485 Boostrap/Load: Add filter to allow disabling of object cache
In [37626] a filter was added to allow disabling the advanced cache dropin, but no similar filter was added for the object cache dropin. This corrects that oversight.

Fixes .


git-svn-id: https://develop.svn.wordpress.org/trunk@51087 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-08 01:44:26 +00:00
Joe Dolson
bad2471fa9 Application Passwords: Allow enter key to submit profile form.
Fix the enter key in profile form fields moving focus to the application password input instead of submitting the profile update for. Replace the submit button type used for application passwords with `button type="button"` and ensure that the enter key's native behavior isn't overwritten.

props audrasjb, alexstine, promz, sabernhardt.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@51086 602fd350-edb4-49c9-b593-d223f7449a82
2021-06-07 23:48:18 +00:00