48673 Commits

Author SHA1 Message Date
Jonathan Desrosiers
96c463adf5 Security: Update bundled Root Certificates.
Some checks failed
End-to-end Tests / Test with SCRIPT_DEBUG disabled (push) Has been cancelled
End-to-end Tests / Test with SCRIPT_DEBUG enabled (push) Has been cancelled
JavaScript Tests / QUnit Tests (push) Has been cancelled
Performance Tests / Run performance tests (push) Has been cancelled
PHP Compatibility / Check PHP compatibility (push) Has been cancelled
PHPUnit Tests / PHP 7.0 (push) Has been cancelled
PHPUnit Tests / PHP 7.1 (push) Has been cancelled
PHPUnit Tests / PHP 7.2 (push) Has been cancelled
PHPUnit Tests / PHP 7.3 (push) Has been cancelled
PHPUnit Tests / PHP 7.4 (push) Has been cancelled
PHPUnit Tests / PHP 8.0 (push) Has been cancelled
PHPUnit Tests / PHP 8.1 (push) Has been cancelled
PHPUnit Tests / PHP 8.2 (push) Has been cancelled
PHPUnit Tests / PHP 8.3 (push) Has been cancelled
Test Build Processes / Core running from build (push) Has been cancelled
Test Build Processes / Core running from src (push) Has been cancelled
Coding Standards / Slack Notifications (push) Has been cancelled
Coding Standards / Failed workflow tasks (push) Has been cancelled
End-to-end Tests / Slack Notifications (push) Has been cancelled
End-to-end Tests / Failed workflow tasks (push) Has been cancelled
JavaScript Tests / Slack Notifications (push) Has been cancelled
JavaScript Tests / Failed workflow tasks (push) Has been cancelled
Performance Tests / Slack Notifications (push) Has been cancelled
Performance Tests / Failed workflow tasks (push) Has been cancelled
PHP Compatibility / Slack Notifications (push) Has been cancelled
PHP Compatibility / Failed workflow tasks (push) Has been cancelled
PHPUnit Tests / Slack Notifications (push) Has been cancelled
PHPUnit Tests / Failed workflow tasks (push) Has been cancelled
Test Build Processes / Slack Notifications (push) Has been cancelled
Test Build Processes / Failed workflow tasks (push) Has been cancelled
The Root Certificate bundle maintained by Mozilla ships in WordPress to allow SSL certificates to be verified on hosts with incomplete, outdated, or invalid local SSL configurations.

This updates the `ca-bundle.crt` file to the latest version, which applies upstream changes from the bundle maintained by Mozilla and keeps all unexpired legacy 1024bit certificates which are kept for backward compatibility purposes (see [35919]).

Partially merges [59740] and [59969] to the 6.4 branch.

Props johnbillion, desrosj, whyisjake, ayeshrajans, SergeyBiryukov, swissspidy, skithund, barry.
See #62811, #62711.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@59996 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-16 22:57:27 +00:00
Jonathan Desrosiers
1c9edf8854 Build/Test Tools: Update @playwright/test.
Some checks failed
End-to-end Tests / Test with SCRIPT_DEBUG disabled (push) Has been cancelled
End-to-end Tests / Test with SCRIPT_DEBUG enabled (push) Has been cancelled
JavaScript Tests / QUnit Tests (push) Has been cancelled
Performance Tests / Run performance tests (push) Has been cancelled
PHP Compatibility / Check PHP compatibility (push) Has been cancelled
PHPUnit Tests / PHP 7.0 (push) Has been cancelled
PHPUnit Tests / PHP 7.1 (push) Has been cancelled
PHPUnit Tests / PHP 7.2 (push) Has been cancelled
PHPUnit Tests / PHP 7.3 (push) Has been cancelled
PHPUnit Tests / PHP 7.4 (push) Has been cancelled
PHPUnit Tests / PHP 8.0 (push) Has been cancelled
PHPUnit Tests / PHP 8.1 (push) Has been cancelled
PHPUnit Tests / PHP 8.2 (push) Has been cancelled
PHPUnit Tests / PHP 8.3 (push) Has been cancelled
Test Build Processes / Core running from build (push) Has been cancelled
Test Build Processes / Core running from src (push) Has been cancelled
Coding Standards / Slack Notifications (push) Has been cancelled
Coding Standards / Failed workflow tasks (push) Has been cancelled
End-to-end Tests / Slack Notifications (push) Has been cancelled
End-to-end Tests / Failed workflow tasks (push) Has been cancelled
JavaScript Tests / Slack Notifications (push) Has been cancelled
JavaScript Tests / Failed workflow tasks (push) Has been cancelled
Performance Tests / Slack Notifications (push) Has been cancelled
Performance Tests / Failed workflow tasks (push) Has been cancelled
PHP Compatibility / Slack Notifications (push) Has been cancelled
PHP Compatibility / Failed workflow tasks (push) Has been cancelled
PHPUnit Tests / Slack Notifications (push) Has been cancelled
PHPUnit Tests / Failed workflow tasks (push) Has been cancelled
Test Build Processes / Slack Notifications (push) Has been cancelled
Test Build Processes / Failed workflow tasks (push) Has been cancelled
This updates `@playwright/test` to the latest version, currently `1.49.1`.

In older branches using Playwright, the E2E and Performance workflows have recently started failing. This is due to changes in the GitHub Actions runner images. Updating Playwright ensures more modern dependency trees are used when installing browsers for testing and fixes the issue.

Merges [59682] to the 6.4 branch.

Props swissspidy.
Fixes #62843.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@59686 602fd350-edb4-49c9-b593-d223f7449a82
2025-01-22 17:57:41 +00:00
Peter Wilson
43e9f1fe2b Tests: Use better domain for HTTP API invalid hostname test.
Some checks failed
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 7.1) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 7.2) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 7.3) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 7.4) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 8.0) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 8.1) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 8.2) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 8.3) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, true, false, ubuntu-latest, 7.4) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, true, true, ubuntu-latest, 7.4) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (build, ubuntu-latest, ${{ github.event_name == 'pull_request' && true || '' }}, true) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (build, windows-latest) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (src, ubuntu-latest) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (src, windows-latest) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (build, macos-latest) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (src, macos-latest) (push) Has been cancelled
Coding Standards / Slack Notifications (push) Has been cancelled
Coding Standards / Failed workflow tasks (push) Has been cancelled
End-to-end Tests / Slack Notifications (push) Has been cancelled
End-to-end Tests / Failed workflow tasks (push) Has been cancelled
JavaScript Tests / Slack Notifications (push) Has been cancelled
JavaScript Tests / Failed workflow tasks (push) Has been cancelled
Performance Tests / Slack Notifications (push) Has been cancelled
Performance Tests / Failed workflow tasks (push) Has been cancelled
PHP Compatibility / Slack Notifications (push) Has been cancelled
PHP Compatibility / Failed workflow tasks (push) Has been cancelled
PHPUnit Tests / Slack Notifications (push) Has been cancelled
PHPUnit Tests / Failed workflow tasks (push) Has been cancelled
Test Build Processes / Slack Notifications (push) Has been cancelled
Test Build Processes / Failed workflow tasks (push) Has been cancelled
The previous domain that was used to test for a host whose IPv4 address cannot be resolved, `exampleeeee.com`, got registered and has an A-record now, so it's not invalid anymore.

`.invalid` is intended for use in online construction of domain names that are sure to be invalid and which it is obvious at a glance are invalid.

Reference: [https://datatracker.ietf.org/doc/html/rfc2606#section-2 Reserved Top Level DNS Names: TLDs for Testing, & Documentation Examples].

Follow-up to [52084], [58384], [58388].

Props sippis, johnbillion, MattyRob, swissspidy.
Fixes #62303.

Reviewed by 
Merges [59293] to the 6.4 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/6.4@59300 602fd350-edb4-49c9-b593-d223f7449a82
2024-10-27 22:56:44 +00:00
Jonathan Desrosiers
62cb57a863 Build/Test Tools: Use a specific version of Gutenberg for E2E tests.
Some checks failed
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 7.1) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 7.2) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 7.3) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 7.4) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 8.0) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 8.1) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 8.2) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 8.3) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, true, false, ubuntu-latest, 7.4) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, true, true, ubuntu-latest, 7.4) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (build, ubuntu-latest, ${{ github.event_name == 'pull_request' && true || '' }}, true) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (build, windows-latest) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (src, ubuntu-latest) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (src, windows-latest) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (build, macos-latest) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (src, macos-latest) (push) Has been cancelled
Coding Standards / Slack Notifications (push) Has been cancelled
Coding Standards / Failed workflow tasks (push) Has been cancelled
End-to-end Tests / Slack Notifications (push) Has been cancelled
End-to-end Tests / Failed workflow tasks (push) Has been cancelled
JavaScript Tests / Slack Notifications (push) Has been cancelled
JavaScript Tests / Failed workflow tasks (push) Has been cancelled
Performance Tests / Slack Notifications (push) Has been cancelled
Performance Tests / Failed workflow tasks (push) Has been cancelled
PHP Compatibility / Slack Notifications (push) Has been cancelled
PHP Compatibility / Failed workflow tasks (push) Has been cancelled
PHPUnit Tests / Slack Notifications (push) Has been cancelled
PHPUnit Tests / Failed workflow tasks (push) Has been cancelled
Test Build Processes / Slack Notifications (push) Has been cancelled
Test Build Processes / Failed workflow tasks (push) Has been cancelled
This updates the 6.4 branch to make use of the new `gutenberg-version` input introduced in [59220].

The past version of the plugin that supports WordPress 6.4 is `18.9.0`.

Props swissspidy.
See #61530.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@59221 602fd350-edb4-49c9-b593-d223f7449a82
2024-10-12 13:22:47 +00:00
Jonathan Desrosiers
0caeea219a Build/Test Tools: Don’t install Gutenberg for E2E tests in 6.4.
Some checks failed
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 7.1) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 7.2) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 7.3) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 7.4) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 8.0) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 8.1) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 8.2) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, false, true, ubuntu-latest, 8.3) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, true, false, ubuntu-latest, 7.4) (push) Has been cancelled
PHPUnit Tests / PHP ${{ matrix.php }} (mariadb, 11.0, true, true, ubuntu-latest, 7.4) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (build, ubuntu-latest, ${{ github.event_name == 'pull_request' && true || '' }}, true) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (build, windows-latest) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (src, ubuntu-latest) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (src, windows-latest) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (build, macos-latest) (push) Has been cancelled
Test Build Processes / Core running from ${{ matrix.directory }} (src, macos-latest) (push) Has been cancelled
Coding Standards / Slack Notifications (push) Has been cancelled
Coding Standards / Failed workflow tasks (push) Has been cancelled
End-to-end Tests / Slack Notifications (push) Has been cancelled
End-to-end Tests / Failed workflow tasks (push) Has been cancelled
JavaScript Tests / Slack Notifications (push) Has been cancelled
JavaScript Tests / Failed workflow tasks (push) Has been cancelled
Performance Tests / Slack Notifications (push) Has been cancelled
Performance Tests / Failed workflow tasks (push) Has been cancelled
PHP Compatibility / Slack Notifications (push) Has been cancelled
PHP Compatibility / Failed workflow tasks (push) Has been cancelled
PHPUnit Tests / Slack Notifications (push) Has been cancelled
PHPUnit Tests / Failed workflow tasks (push) Has been cancelled
Test Build Processes / Slack Notifications (push) Has been cancelled
Test Build Processes / Failed workflow tasks (push) Has been cancelled
The minimum required version of WordPress for the Gutenberg plugin was recently raised to 6.5.

This updates the 6.4 branch to skip installing and activating Gutenberg during E2E testing as has already been done for older branches.

See #61530.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@59212 602fd350-edb4-49c9-b593-d223f7449a82
2024-10-10 18:06:13 +00:00
Jonathan Desrosiers
9dc9cc136c Build/Test Tools: Change 6.4 default values of LOCAL_PHP/LOCAL_DB_VERSION.
This changes the default values for `LOCAL_PHP` and `LOCAL_DB_VERSION` in the 6.4 branch from `latest` to `8.3-fpm` (with beta support) and `8.0`, respectively, to properly reflect the highest versions of PHP and MySQL that this branch will support.

See #61533.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@58659 602fd350-edb4-49c9-b593-d223f7449a82
2024-07-03 17:25:45 +00:00
Jonathan Desrosiers
cadd3c63a8 Build/Test Tools: Update the reusable PHPUnit workflow name.
Follow up to [58645] for the 6.4 branch.

Props jorbin.
See #61213.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@58648 602fd350-edb4-49c9-b593-d223f7449a82
2024-07-03 15:56:33 +00:00
Jonathan Desrosiers
1f1a5b0f0a WordPress 6.4.5 (with lock file update).
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@58509 602fd350-edb4-49c9-b593-d223f7449a82
2024-06-24 16:18:13 +00:00
Jb Audras
c3a282fde7 WordPress 6.4.5.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@58503 602fd350-edb4-49c9-b593-d223f7449a82
2024-06-24 16:07:40 +00:00
Aaron Jorbin
3a2acb564f Add file missed in [58475].
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@58482 602fd350-edb4-49c9-b593-d223f7449a82
2024-06-24 15:21:14 +00:00
Jb Audras
1b6ce9e00f Grouped Backports to the 6.4 branch.
- Editor: Fix Path Traversal issue on Windows in Template-Part Block.
- Editor: Sanitize Template Part HTML tag on save.
- HTML API: Run URL attributes through `esc_url()`.

Merges [58470], [58471], [58472] and [58473] to the 6.4 branch.
Props xknown, peterwilsoncc, jorbin, bernhard-reiter, azaozz, dmsnell, gziolo.




git-svn-id: https://develop.svn.wordpress.org/branches/6.4@58475 602fd350-edb4-49c9-b593-d223f7449a82
2024-06-24 15:08:05 +00:00
Jonathan Desrosiers
96a5188be3 Build/Test Tools: Always generate build ZIP on push for 6.4.
This updates the 6.5 branch to make use of [58345], which fixes a bug where a ZIP file with built WordPress is not saved as an artifact causing the performance workflow to fail.

Merges [53845] to the 6.4 branch.

Props jorbin.
See #59416.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@58347 602fd350-edb4-49c9-b593-d223f7449a82
2024-06-05 18:33:22 +00:00
Jonathan Desrosiers
366ad4db1a Build/Test Tools: Make use of new reusable workflows.
This updates the 6.4 branch to utilize the new reusable workflows in trunk introduced in [58165].

This also includes backports for a some additional improvements and bug fixes that are necessary for the local development environment to continue working long term:
- Migrating to Docker Compose V2 (#60901).
- Removing the `version` property from `docker-compose.yml` (#59416).
- Improvements to how artifacts and comments for Playground testing are generated.
- Removing SVN related commands causing failures (#61216).
- Updating the `actions/github-scripts` action to the latest version.

Merges [57918], [58157], [57124], [57125], [57249] to the 6.4 branch.

Props johnbillion, joemcgill, swissspidy, thelovekesh, narenin, mukesh27, JeffPaul, peterwilsoncc, zieladam, ockham, SergeyBiryukov, jorbin.
Fixes #61216. See #60901, #61101, #59416, #59805, #61213.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@58276 602fd350-edb4-49c9-b593-d223f7449a82
2024-05-31 19:23:44 +00:00
Joe McGill
451db80f74 Build/Test Tools: Fix the Performance workflow in the 6.4 branch.
This pins the `LOCAL_PHP` version to 8.2 in the Performance workflow to ensure that the base measurements taken from WordPress version 6.1.1 can be run, since PHP 8.2 is the greatest version that WordPress 6.1.1 supports.

The default PHP version used in the 6.4 branch was bumped to 8.3 in [57198] to reflect the highest version that WordPress 6.4 supports, resulting in the failures to the Performance workflow.

Props joemcgill, freewebmentor, desrosj, swissspidy.
Fixes #60127.


git-svn-id: https://develop.svn.wordpress.org/branches/6.4@58272 602fd350-edb4-49c9-b593-d223f7449a82
2024-05-31 18:07:06 +00:00
bernhard-reiter
db589b327c Tests: Add comment to explain when e2e test for gutenberg is skipped
Follow-up to [58046].

Reviewed by jorbin.
Merges [58141] to the 6.4 branch.

See #60971.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@58154 602fd350-edb4-49c9-b593-d223f7449a82
2024-05-15 07:06:46 +00:00
bernhard-reiter
fe402e06ac Tests: Skip Gutenberg plugin activation test on older WP versions.
The purpose of `tests/e2e/specs/gutenberg-plugin.test.js` is to ensure that running the Gutenberg plugin (stable version) on a WordPress `trunk` install doesn't produce any fatals.

The test was introduced in [54913], i.e. it has been around since WP 6.2. It makes sense to have it present on older branches, as the Gutenberg plugin not only supports `trunk`, but also the current stable version of WordPress (i.e. currently 6.5), and one version below (6.4). However, it is not expected to work on any earlier versions beyond that; in practice, it has produced errors on some of those.

This changeset checks the REST API response from the plugin activation request. If it returns an error with error code `plugin_wp_incompatible`, it skips the test.

Reviewed by jorbin.
Merges [58046] to the 6.4 branch.

Props jorbin, johnbillion, swissspidy.
Fixes #60971.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@58153 602fd350-edb4-49c9-b593-d223f7449a82
2024-05-15 07:05:03 +00:00
John Blackbourn
569a37976b WordPress 6.4.4.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57960 602fd350-edb4-49c9-b593-d223f7449a82
2024-04-09 14:09:39 +00:00
John Blackbourn
6ef3cac25b Editor: Update npm packages for the 6.4 branch.
Updates the editor npm packages to the latest patch versions.


git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57951 602fd350-edb4-49c9-b593-d223f7449a82
2024-04-09 11:08:26 +00:00
Sergey Biryukov
812ad8dc12 Tests: Use an image on WordPress.org CDN in external HTTP tests.
Due to some changes on the WP.com side to compress the requested images on the fly, the exact image size in the response could be different between platforms.

This commit aims to make the affected tests more reliable.

Follow-up to [139/tests], [31258], [34568], [47142], [57903], [57904], [57924].

Merges [57931] to the 6.4 branch.

Props peterwilsoncc, jorbin.
See #60865.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57938 602fd350-edb4-49c9-b593-d223f7449a82
2024-04-07 21:18:24 +00:00
Aaron Jorbin
17643e8645 Tests: Update expectations in wp_remote_head() and wp_remote_get() tests.
It appears that something has changed on the WP.com side to compress the requested images on the fly, which interfered with the previous expectations in these tests.

This commit uses a direct file URL and updates the expected image size to match the currently returned response.

Follow-up to [139/tests], [31258], [47142].

Reviewed by jorbin.
Merges [57903] to the 6.4 branch.

Props dextorlobo, swissspidy, davidbaumwald, SergeyBiryukov.
See #60865.


git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57930 602fd350-edb4-49c9-b593-d223f7449a82
2024-04-04 21:10:39 +00:00
Aaron Jorbin
6f021272d3 Upload: Fallback to PclZip to validate ZIP file uploads.
ZipArchive can fail to validate ZIP files correctly and report valid files as invalid. This introduces a fallback to PclZip to check validity of files if ZipArchive fails them.

This introduces the new function wp_zip_file_is_valid() to validate archives.

Follow up to [57388].

Reviewed by jorbin.
Merges [57537] to the 6.4 branch.

Props audunmb, azaozz, britner, cdevroe, colorful-tones, costdev, courane01, endymion00, feastdesignco, halounsbury, jeffpaul, johnbillion, jorbin, jsandtro, karinclimber, kevincoleman, koesper, maartenbelmans, mathewemoore, melcarthus, mujuonly, nerdpressteam, olegfuture, otto42, peterwilsoncc, room34, sayful, schutzsmith, stephencronin, svitlana41319, swissspidy, tnolte, tobiasbg, vikram6, welaunchio.
Fixes #60398.


git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57929 602fd350-edb4-49c9-b593-d223f7449a82
2024-04-04 19:28:21 +00:00
Jonathan Desrosiers
02fb53498f Docs: Correct the URLs that document the available images for MySQL and MariaDB for the local development environment.
Merges [57678] to the 6.4 branch.

See #59930.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57863 602fd350-edb4-49c9-b593-d223f7449a82
2024-03-21 19:06:33 +00:00
Jonathan Desrosiers
a38890fa99 Build/Test Tools: Fix bug pulling local environment containers on Apple silicone.
The MySQL Docker containers for versions 5.7 and below do not support recent Apple silicone chips. Previously this was fixed by including `amd64/` as a prefix to the image name in the `docker-compose.yml` file (see [54096]). However, this stopped working after recent updates to Docker Desktop.

This changeset removes the `amd64/` prefix for the image used as the database container and raises the default version of MySQL in the local development environment to the current LTS version (8.0). Because this version is still maintained, there are `arm64` containers available to use.

This also documents a new workaround for contributors looking to run the local Docker environment using MySQL 5.7 or earlier, which entails creating a small `docker-compose.override.yml`.

Merges [57568] to the 6.4 branch.

Props bernhard-reiter, johnbillion, afragen, huzaifaalmesbah.
Fixes #59930.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57862 602fd350-edb4-49c9-b593-d223f7449a82
2024-03-21 18:40:34 +00:00
Jonathan Desrosiers
2e60defa5d Build/Test Tools: Bump the Node.js version for Codespaces.
This bumps the version of Node.js used in GitHub Codespaces from 16 to 20.

Follow up to [57212].

Merges [57667] to the 6.4 branch.

Props itschristiandale, huzaifaalmesbah.
Fixes #60555.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57672 602fd350-edb4-49c9-b593-d223f7449a82
2024-02-20 17:31:36 +00:00
Joe McGill
8338c63028 Post WordPress 6.4.3 version bump.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57488 602fd350-edb4-49c9-b593-d223f7449a82
2024-01-30 21:25:28 +00:00
Joe McGill
ef752922cc WordPress 6.4.3.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57463 602fd350-edb4-49c9-b593-d223f7449a82
2024-01-30 19:08:26 +00:00
Aaron Jorbin
28b06ee1bc Install: When populating options, maybe_serialize instead of always serialize.
Merges [57389] to 6.4 branch.

Props xknown, peterwilsoncc, jorbin, desrosj.


git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57391 602fd350-edb4-49c9-b593-d223f7449a82
2024-01-30 14:25:41 +00:00
Aaron Jorbin
ee5a601e0f Uploads: Check for and verify ZIP archives.
Merges [57388] to 6.4 branch.

Props costdev, peterwilsoncc, azaozz, tykoted, johnbillion, desrosj, afragen, jorbin.


git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57390 602fd350-edb4-49c9-b593-d223f7449a82
2024-01-30 14:24:32 +00:00
Joe McGill
89c53f4db7 Post WordPress 6.4.3 RC1 version bump.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57360 602fd350-edb4-49c9-b593-d223f7449a82
2024-01-25 20:23:20 +00:00
Joe McGill
a2a06c2620 WordPress 6.4.3 RC1.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57359 602fd350-edb4-49c9-b593-d223f7449a82
2024-01-25 20:06:57 +00:00
Aaron Jorbin
69242ba40f Media: Redirect inactive attachment pages for logged-out users.
Ensure logged out users are redirected to the media file when attachment pages are inactive. This removes the read_post capability check from the canonical redirects as anonymous users lack the permission.

This was previously committed in [57310] before being reverted in [57318]. This update includes a fix to cover instances where revealing a URL could be considered a data leak and greatly expands the unit tests to ensure that this is covered along with many other instances.

Follow-up to [56657], [56658], [56711], [57310], [57318].

Reviewed by joemcgill.
Merges [57357] to 6.4 branch.

Props peterwilsoncc, jorbin, afercia, aristath, chesio, joppuyo, jorbin, lakshmananphp, poena, sergeybiryukov, swissspidy, johnbillion, mukesh27.
Fixes #59866.
See #57913.



git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57358 602fd350-edb4-49c9-b593-d223f7449a82
2024-01-25 19:41:24 +00:00
Aaron Jorbin
6338d63ec7 Embeds: Ensure the deprecated function print_emoji_styles isn't used
Ensure that the proper new function wp_enqueue_emoji_styles is used in embeds.

Follow-up to: [56194].

Reviewed by davidbaumwald.
Merges [57306] to the 6.4 branch.

Props peterwilsoncc, bobbingwide, hellofromTonya.
Fixes #59892. See: #58775.


git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57347 602fd350-edb4-49c9-b593-d223f7449a82
2024-01-24 19:25:00 +00:00
Aaron Jorbin
4368dbadf6 Editor: update npm packages in trunk for 6.4.3.
Package Update includes fixes for:
- Fix block rename control shown in "Advanced" for unsupported blocks
- Query block: remove unnecessary class
- Fix duotone not showing in site editor style block level styles
- Query Loop - Add accessibility markup at the end of the loop in all cases.
- Background Image Support: Hide the background image reset button when there's no image
- Background image support: Fix focus loss when resetting background image
- Autocomplete: Fix Voiceover not announcing suggestions
- Fix pattern category renaming causing potential duplicate categories
- Patterns: use existing download function for JSON downloads to fix non-ASCII encoding
- Add context for translators to any unclear usage of "synced"
- Image block: Add check for lightbox values during image block migration
- Image Block: Enable image block to be selected correctly when clicked
- Reduce specificity of default Cover text color styles.
- Image Block: Fix deprecation when width/height attribute is number
- Text selection: show CSS hack to Safari only.
- SlotFill: Allow contextual SlotFillProviders

Reviewed by peterwilsoncc.
Merges [57258] and [57109] to 6.4 branch.

Props mikachan, isabel_brison, kebbet, artemiosans, talldanwp, ramonopoly, alexstine, andrewserong, mamaduka, cbravobernal, ajlende, luisherranz, wildworks, poena, czapla, andraganescu, joen, ellatrix, youknowriad, ntsekouras.
Fixes #59828.



git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57346 602fd350-edb4-49c9-b593-d223f7449a82
2024-01-24 19:00:51 +00:00
Peter Wilson
7714f5deec Twenty Twenty-Four: Add missing textdomain in pattern category description.
Follow-up to [56951].

Reviewed by jorbin.
Merges [57127] to the 6.4 branch.

Props gavande1, acosmin, afercia, huzaifaalmesbah, ironprogrammer, SergeyBiryukov.
Fixes #59840.




git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57307 602fd350-edb4-49c9-b593-d223f7449a82
2024-01-18 02:59:29 +00:00
Jonathan Desrosiers
a473f0e19d Bundled Themes: Version bump themes affected by #60241.
In order to release the fix for #60241, this bumps the version of the following themes:

- Twenty Seventeen: 3.5
- Twenty Twenty: 2.5
- Twenty Twenty-One: 2.2 

Merges [57296] to the 6.4 branch.

Props sabernhardt, jorbin.
See #60267.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57297 602fd350-edb4-49c9-b593-d223f7449a82
2024-01-16 19:30:16 +00:00
Jonathan Desrosiers
5a52b8ec6f Twenty Twenty-One: Revert usage of str_contains() in theme files.
The theme supports WordPress 5.3 or later, while the polyfill for str_contains() only exists in WordPress 5.9 or later.

Follow-up to [55988], [57275], [57276].

Merges [57277] to the 6.4 branch.

Props poena, SergeyBiryukov.
Fixes #60241.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57293 602fd350-edb4-49c9-b593-d223f7449a82
2024-01-16 16:09:50 +00:00
Jonathan Desrosiers
716e160435 Twenty Twenty: Revert usage of str_contains() in theme files.
The theme supports WordPress 4.7 or later, while the polyfill for str_contains() only exists in WordPress 5.9 or later.

Follow-up to [55988], [57275].

Merges [57276] to the 6.4 branch.

Props poena, SergeyBiryukov.
See #60241.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57292 602fd350-edb4-49c9-b593-d223f7449a82
2024-01-16 16:07:50 +00:00
Jonathan Desrosiers
41b3e781b9 Twenty Seventeen: Revert usage of str_contains() in theme files.
The theme supports WordPress 4.7 or later, while the polyfill for str_contains() only exists in WordPress 5.9 or later.

Follow-up to [55988].

Merges [57275] to the 6.4 branch.

Props poena, SergeyBiryukov.
See #60241.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57291 602fd350-edb4-49c9-b593-d223f7449a82
2024-01-16 16:06:41 +00:00
Peter Wilson
08f27013d6 Login and Registration: Use correct variable to display a single error message.
When the `wp_login_errors` filter is used to add an error message followed by an instructional message, the former was not displayed and the latter was errouneously displayed twice above the login form.

This commit ensures that the error message is displayed as expected.

Follow-up to [56654].

Reviewed by jorbin.
Merges [57142] to the 6.4 branch.

Props mapumba, SergeyBiryukov.
Fixes #59983.




git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57288 602fd350-edb4-49c9-b593-d223f7449a82
2024-01-16 03:21:45 +00:00
Jonathan Desrosiers
87dfd5514b Build/Test Tools: Raise minimum required version of Node.js/npm.
This bumps the minimum required version of Node.js/npm from 16.19.1 and 8.19.3 to 20.10.0 and 10.2.3.

Since 20.10.0 is the latest 20.x version of Node.js, the check-latest option has been enabled for actions/setup-node in GitHub Actions workflows. This performs an additional external call to the Node.js API confirming the latest version is installed on the runner for use. In testing, it seems that 20.10.0 was not consistently deployed to all runner machines in use. This should be removed in the near future when the version of Node.js is reliably above the new minimum requirement.

The Gutenberg repository has also been updated to use the same values for engines.

Merges [57212] to the 6.4 branch.

Props jorbin, joemcgill, swissspidy, benharri, dhrupo, flootr, gziolo, noahtallen.
See #59663.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57214 602fd350-edb4-49c9-b593-d223f7449a82
2023-12-20 18:59:17 +00:00
Jonathan Desrosiers
02e0733577 Build/Test Tools: Change the default value of LOCAL_PHP.
This changes the default value for `LOCAL_PHP` in the 6.4 branch from `latest` to `8.3-fpm` to reflect the highest version of PHP this branch will support (with beta support).

After this change, future updates to the `latest` container built and published by the `wpdev-docker-images` repository will not cause failures in this branch.

While there are currently no failures in the 6.4 branch, the `latest` container was recently changed from using PHP 7.4 to 8.2 and caused failures in the 5.8-6.3 branches. Pinning a PHP version to this branch now will prevent that same scenario in the future. Going forward, this should be done at the time of branching.

Older branches already have specific PHP versions defined.

See #60095.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57198 602fd350-edb4-49c9-b593-d223f7449a82
2023-12-18 18:54:28 +00:00
Sergey Biryukov
d9d0fd6495 Tests: Revert [57182] from the 6.4 branch.
This will be committed to trunk instead.

See #59825.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57183 602fd350-edb4-49c9-b593-d223f7449a82
2023-12-12 12:15:45 +00:00
Aaron Jorbin
1bc6ffd52b Build/Test: Add unit tests for wp_checkdate.
Props pbearne, ironprogrammer.
Fixes #59825.


git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57182 602fd350-edb4-49c9-b593-d223f7449a82
2023-12-11 19:19:25 +00:00
Joe McGill
f90515acdb Update package-lock.json after the 6.4.3-alpha version bump.
This is a followup to [57167] to fix a version number in `package-lock.json` that was missed in the initial commit.


git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57168 602fd350-edb4-49c9-b593-d223f7449a82
2023-12-06 17:18:31 +00:00
Joe McGill
a211c6848a Post WordPress 6.4.2 version bump.
The 6.4 branch is now 6.4.3-alpha.



git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57167 602fd350-edb4-49c9-b593-d223f7449a82
2023-12-06 16:58:04 +00:00
Joe McGill
e6be06e823 WordPress 6.4.2.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57165 602fd350-edb4-49c9-b593-d223f7449a82
2023-12-06 16:10:27 +00:00
Joe McGill
b90dc99d51 HTML-API: Prevent unintended behavior when WP_HTML_Token is unserialized.
Merges [57163] to the to the 6.4 branch.

Props dmsnell, peterwilsoncc, dd32, xknown, rawrly, johnbillion, barry, jeffpaul, vortfu, isabel_brison, mikeschroder, jorbin.


git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57164 602fd350-edb4-49c9-b593-d223f7449a82
2023-12-06 16:04:44 +00:00
Aaron Jorbin
c1f36fafdb Help/About: Change CSS align-item for full browser support.
The values of start and end are not fully supported by Opera Mini which has 1.01% usage. There is no material change in functionality with this change.

Reviewed by hellofromTonya.
Merges [57151] to 6.4 branch.

Props kebbet, NekoJonez, luminuu, hellofromTonya.
Fixes #59819.



git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57160 602fd350-edb4-49c9-b593-d223f7449a82
2023-12-05 17:11:26 +00:00
Aaron Jorbin
f2c05952c0 Themes: Remove memoization from stylesheet and theme directories.
This fixes bugs introduced in [56635] whereby the template or stylesheet path could be memoized incorrectly if get_template_directory() or get_stylesheet_directory() were called before the theme has been fully initialized.

Reviewed by Jorbin.
Merges [57129] to 6.4 branch.

Props partyfrikadelle, coreyw, kdowns, rebasaurus, meta4, flixos90, mukesh27, joemcgill, icaleb.
Fixes #59847.


git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57156 602fd350-edb4-49c9-b593-d223f7449a82
2023-12-04 19:57:30 +00:00
Tonya Mork
743109013b REST API: Restore site logo and icon in index.
Restores setting the site's logo, icon, and wp-admin's back button image (which defaults to W).

Prior to [56566], the site logo and icon were unconditionally added to the index. [56566] changed this by conditionally adding them if either the `_links` or `_embedded` fields were included. However, these fields are not included when using the Site Logo block, as it uses the `site_logo`, `site_icon`, and `site_icon_url` fields instead.

This changeset restores the functionality by checking specifically for the `site_*` fields when neither of the `_links` or `_embedded` fields are present.

Follow up to [56566].

Reviewed by jorbin.
Merges [57147] to the 6.4 branch.

Props antonvlasenko, hellofromTonya, ironprogrammer, priethor, wildworks.
Fixes #59935.

git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57154 602fd350-edb4-49c9-b593-d223f7449a82
2023-12-04 19:42:44 +00:00