30971 Commits

Author SHA1 Message Date
Jonathan Desrosiers
9d911df43e Build/Test Tools: Use the correct build matrix for the 4.3 branch.
Follow up to [50317].

See #50401.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@50318 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 20:33:10 +00:00
Jonathan Desrosiers
52db7ed165 Build/Test Tools: Restore automated testing in the 4.3 branch.
This commit merges the workflow files required to run automated testing on GitHub Actions.

In addition, [49836] and [50285] have been included in order to keep the local Docker environment consistent across all branches.

Merges [49162,49168-49169,49175,49204,49227-49228,49244,49369,49371,49548,49781-49784,49786,49836,49938,50268,50285,50298] to the 4.3 branch.
See #50401.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@50317 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 20:27:47 +00:00
Jonathan Desrosiers
2339f32f42 Build/Test Tools: Backport the local Docker environment to the 4.3 branch.
This commit introduces the Docker-based local WordPress development environment to the 4.3 branch.

Merges [44176,45445,45745,45762,45783-45784,45800,45819,45885,46320,46999,47225,47912,48121,49267,49335,49358,49360,49362] to the 4.3 branch.
See #48301, #47767.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@50245 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-08 20:52:53 +00:00
Sergey Biryukov
b9bf0b16b1 Build/Test Tools: Correct svn:mergeinfo for the 4.3 branch.
Follow-up to [50212].

See #52341.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@50226 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-05 08:24:57 +00:00
Jonathan Desrosiers
8c217af411 Build/Test Tools: Ignore patch related files, so they can't be accidentally committed.
Merges [39360-39361] to the 4.3 branch.
See #38727.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@50213 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-05 04:25:46 +00:00
Jonathan Desrosiers
fa7ecfc440 Build/Test Tools: Support NodeJS 14.x in the 4.3 branch.
This updates the 4.3 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.

Because older branches use (really) old versions of NodeJS, the local Docker environment cannot be backported since the needed dependencies will not run on these older versions (see #48301). This also blocks the ability to move automated testing over to GitHub Actions (see #50401).

This change also introduces a `packager-lock.json` file to the branch.

In addition to backporting the package updates that happened after branching 4.3, dependencies that were removed in future releases have also been updated to their latest versions.

Props desrosj, dd32, netweb, jorbin.
Merges [33726,34888,35332,35335,35363,35513,35520-35521,35538-35541,35562-35563,35859-36865,36935,36978-36980,37017,37019-37020,37212,37612,38111,38688,39110,39113-39119,39478,42460-42461,42463,42887,43320,43323,43977,44219,44233,44728,45321,45765,46404,46408-46409,47404,47867-47869,47872-47873,48705,49636,49933,49937,49939,50017,50126,50176,50185] to the 4.3 branch.
See #52341.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@50212 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-05 04:24:59 +00:00
Sergey Biryukov
a89e3d0f7d Tests: Use skipTestOnTimeout() in more HTTP tests.
Adjust it to handle more types of timeouts, e.g. "Resolving timed out", "Connection timed out".

Merges [38757], [43511], [43512], [46682], [46996] to the 4.3 branch.
See #51669.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@50101 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-30 20:45:47 +00:00
Jonathan Desrosiers
36f61069d5 Build/Test Tools: Correct JavaScript file in the 4.3 branch.
In [46499], a JavaScript file was unintentionally changed. This restores that file to the correct state.

Partially reverts [46499].
See #52367.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@50019 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-25 20:15:27 +00:00
Jonathan Desrosiers
94ef6e899a Build/Test Tools: Remove the TravisCI configuration file.
In [49162], GitHub Action workflow configuration files were introduced to run all of Core’s automated testing with the intent to fully transition after some time was allowed for testing.

After two full months of testing, the time to finish this transition has come.

We thank TravisCI for testing the codebase through nearly 20 major and many more minor releases.

Merges [49876] to the 4.3 branch.
See #52161. See #50401.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@49890 602fd350-edb4-49c9-b593-d223f7449a82
2020-12-22 21:12:29 +00:00
Jake Spurlock
3bed776a06 Build/Test Tools: Match .nvmrc with the declared node engine.
Let's match up the versions from package.json, .travis.yml and .nvmrc.

This brings the changes from [49653] to the 4.3 branch.

Fixes #51682.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@49660 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-18 23:07:12 +00:00
Jonathan Desrosiers
600bc98f22 WordPress 4.3.25.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@49421 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 19:34:12 +00:00
Jake Spurlock
f9829f95a4 General: WordPress updates
* XML-RPC: Improve error messages for unprivileged users.
* External Libraries: Disable deserialization in Requests_Utility_FilteredIterator
* Embeds: Disable embeds on deactivated Multisite sites.
* Coding standards: Modify escaping functions to avoid potential false positives.
* XML-RPC: Return error message if attachment ID is incorrect.
* Upgrade/install: Improve logic check when determining installation status.
* Meta: Sanitize meta key before checking protection status.
* Themes: Ensure that only privileged users can set a background image when a theme is using the deprecated custom background page.

Brings the changes from [49380,49382-49388] to the 4.3 branch.

Props xknown, zieladam, peterwilsoncc, whyisjake, desrosj, dd32.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@49403 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 19:05:53 +00:00
Sergey Biryukov
30d7ba6103 Administration: Pass the result of set-screen-option filter to the new set_screen_option_{$option} filter to ensure backward compatibility.
Rename the `$keep` parameter of both filters to `$screen_option` for clarity, update the documentation to better reflect its purpose.

Follow-up to [47951].

Props Chouby, sswells, SergeyBiryukov.
Merges [48241] to the 4.3 branch.
Fixes #50392.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@48255 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-01 09:50:30 +00:00
Jonathan Desrosiers
39e2b55143 WordPress 4.3.24.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@48000 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-10 21:32:49 +00:00
Jake Spurlock
30819bde67 General: Backport several commits for release.
- Embeds: Ensure that the title attribute is set correctly on embeds.
- Editor: Prevent HTML decoding on by setting the proper editor context.
- Formatting: Ensure that wp_validate_redirect() sanitizes a wider variety of characters.
- Themes: Ensure a broken theme name is returned properly.
- Administration: Add a new filter to extend set-screen-option.

Merges [47947-47951] to the 4.3 branch.

Props xknown, sstoqnov, vortfu, SergeyBiryukov, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@47982 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-10 19:03:59 +00:00
Jake Spurlock
d2a1b90537 General: Backport several commits for release.
- Embeds: Ensure that the title attribute is set correctly on embeds.
- Editor: Prevent HTML decoding on by setting the proper editor context.
- Formatting: Ensure that wp_validate_redirect() sanitizes a wider variety of characters.
- Themes: Ensure a broken theme name is returned properly.
- Administration: Add a new filter to extend set-screen-option.
Merges [47947-47951] to the 4.3 branch.
Props xknown, sstoqnov, vortfu, SergeyBiryukov, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@47971 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-10 18:36:32 +00:00
Jonathan Desrosiers
11d47be9d9 Update the About page for WordPress 4.3.23
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@47693 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 18:25:07 +00:00
Jonathan Desrosiers
6ae13d7972 WordPress 4.3.23
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@47677 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 17:56:47 +00:00
Jake Spurlock
ee5835cde9 User: Invalidate user_activation_key on password update.
Query: Ensure that only a single post can be returned on date/time based queries.
Cache API: Ensure proper escaping around the stats method in the cache API.
Formatting: Expand `sanitize_file_name` to have better support for utf8 characters.

Brings the changes in [47634], [47635], [47637], and [47638] to the 4.3 branch.

Props: batmoo, ehti, nickdaugherty, peterwilsoncc, sergeybiryukov, sstoqnov, westi, whyisjake, whyisjake, xknown.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@47656 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 16:48:42 +00:00
Sergey Biryukov
1499a3f9e3 Build/Test Tools: Remove unused ::assertPostHasTerms() method from tests/term.php.
The associated test was removed in [30241].

Merges [47341] to 3.7+ branches.
See #49485.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@47489 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-22 14:29:03 +00:00
Sergey Biryukov
d581bb0953 Embeds: Remove the external oEmbed tests for YouTube.
These tests no longer test anything that WordPress core has control over. YouTube now serves everything
over HTTPS by default, so the tests for #23149 will always pass, and the tests for #32714 aren't testing
anything that core has control over.

Tests for the responses from oEmbed providers has been attempted and reverted in #32360.

Props johnbillion.
Merges [41712] to the 4.3 branch.
See #42076, #32714, #23149.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@47484 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-22 14:04:40 +00:00
Sergey Biryukov
0214dc808d WordPress 4.3.22
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@46930 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-12 20:30:39 +00:00
Sergey Biryukov
972c0b26f5 Update wp_kses_bad_protocol() to recognize : on uri attributes,
`wp_kses_bad_protocol()` makes sure to validate that uri attributes don’t contain invalid/or not allowed protocols. While this works fine in most cases, there’s a risk that by using the colon html5 named entity, one is able to bypass this function.

Brings r46895 to the 4.3 branch.

Props: xknown, nickdaugherty, peterwilsoncc.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@46911 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-12 18:42:58 +00:00
Jonathan Desrosiers
94af14bbb6 WordPress 4.3.21.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@46517 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 20:12:20 +00:00
Jake Spurlock
ef4b6d35ed Backporting several bug fixes.
- Query: Remove the static query property.
- HTTP API: Protect against hex interpretation.
- Filesystem API: Prevent directory travelersals when creating new folders.
- Administration: Ensure that admin referer nonce is valid.
- REST API: Send a Vary: Origin header on GET requests.
- Customizer: Properly sanitize background images.

Backports [46474], [46475], [46476], [46477], [46478], [46483], [46485] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@46499 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 19:11:50 +00:00
Jake Spurlock
d2dfcf5665 Add .nvmrc files to older versions of WordPress
When jumping between branches, it would be nice to have the correct node version for the older versions of WordPress. Let's add .nvmrc files to these older branches for the supported versions.

Merges [46295] to the 4.3 branch.

Fixes #48140


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@46301 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-25 21:00:56 +00:00
Jonathan Desrosiers
bd55432f59 WordPress 4.3.20.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@46037 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 21:20:08 +00:00
Jonathan Desrosiers
c49ecfb258 Fix for URL sanitization in wp_kses_bad_protocol_once().
Merges [45997] to the 4.3 branch.

Props irsdl, sstoqnov, whyisjake.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@46011 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 18:30:31 +00:00
Sergey Biryukov
f60f49b788 Improve URL validation in wp_validate_redirect().
Merges [45971] to the 4.3 branch.
Props vortfu, whyisjake, peterwilsoncc.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@45982 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 17:12:57 +00:00
Jake Spurlock
2dadc8cf79 Remove _convert_urlencoded_to_entities() from the get_the_content() callback.
Merges [45937] to the 4.3 branch.

Props vortfu, whyisjake, peterwilsoncc


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@45959 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:40:17 +00:00
Sergey Biryukov
dff4347a98 Escape the output in wp_ajax_upload_attachment().
Merges [45936] to the 4.3 branch.
Props whyisjake, sstoqnov.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@45952 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:36:31 +00:00
John Blackbourn
3cfb855a71 Build/Test tools: Switch npm dependency caching strategy on Travis CI for the 4.3 branch.
This switches to caching npm's local cache instead of the compiled modules in `node_modules`. The latter is causing errors on the PHP 5.2 build.

Merges [44989] to the 4.3 branch.
 
See #42385


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44990 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-24 23:46:17 +00:00
Gary Pendergast
940117fd65 WordPress 4.3.19
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44880 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-13 01:36:11 +00:00
Sergey Biryukov
7f00dfaa36 Comments: Improve comment content filtering.
Merges [44842] to the 4.3 branch.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44851 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-12 22:40:30 +00:00
Jeremy Felt
b73d26f031 Bump 4.3 branch to version 4.3.18.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44084 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 02:13:08 +00:00
Gary Pendergast
f1b2bfebba Editor: Remove unwanted fields before saving posts.
The `meta_input`, `file`, and `guid` fields are not intended to be updated through user input.

Merges [44047] to the 4.3 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44064 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 01:50:03 +00:00
Peter Wilson
d56a06f954 Multisite: Validate activation links.
Merges [44048] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44063 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 01:48:48 +00:00
Ian Dunn
5b282b8cd7 KSES: Make the URI attributes DRY.
This commit introduces the `wp_kses_uri_attributes` function and filter. The function centralizes the list of attributes, in order to prevent inconsistency, and the filter provides a way for plugins to customize the attributes.

Merges [44014] and [44017] to the `4.3` branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44041 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 01:13:46 +00:00
Peter Wilson
7195a2c8ca Multisite: Improve messaging for previously activated users.
Ensure activation of a site is not attempted multiple times and users are shown the correct message if they follow the link a second time.

Merges [44021] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44033 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 00:53:12 +00:00
Gary Pendergast
95bf8bc711 KSES: Conditionally remove the <form> element from $allowedposttags.
To avoid backwards compatibility issues, `<form>` is re-added if a custom filter has added the `<input>` or `<select>` elements to `$allowedposttags`.

Merges [43994] to the 4.3 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44005 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-12 23:36:48 +00:00
Jeremy Felt
bb03adb1b5 Media: Improve verification of MIME file types.
Merges [43988] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@43996 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-12 23:16:07 +00:00
Aaron D. Campbell
beee8e687a Bump 4.3 branch to version 4.3.17
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@43413 602fd350-edb4-49c9-b593-d223f7449a82
2018-07-05 16:10:44 +00:00
John Blackbourn
bad264e665 Media: Limit thumbnail file deletions to the same directory as the original file.
Merges [43393] into the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@43399 602fd350-edb4-49c9-b593-d223f7449a82
2018-07-05 15:02:04 +00:00
Aaron D. Campbell
7882cfbf99 Bump 4.3 branch to version 4.3.16
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42939 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 20:27:47 +00:00
Dominik Schilling (ocean90)
3f56622c55 Template: Make sure the version string is correctly escaped for use in attributes.
Merge of [42893] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42923 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 16:05:56 +00:00
Dominik Schilling (ocean90)
893762f7c4 Login: Use wp_safe_redirect() when redirecting the login page if forced to use HTTPS.
Merge of [42892] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42901 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 15:28:58 +00:00
Sergey Biryukov
d96c5664d1 General: Update copyright year to 2018 in license.txt.
Props rachelbaker.
Merges [42424] to the 4.3 branch.
Fixes #43007.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42558 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-23 11:26:00 +00:00
Dion Hulse
fdd08af1ed Bump the 4.3 branch to 4.3.15.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42500 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 21:41:24 +00:00
Dion Hulse
e5de1841f1 External Libraries: Remove unnecessary / obsoleted MediaElement.js files.
Merges [42478] to the 4.3 branch.
Fixes #42720 for 4.3.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42483 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 08:09:13 +00:00
Dion Hulse
a91a669874 Upgrade: When deleting old files, if deletion fails attempt to empty the file instead.
Props joemcgill, dd32.
Merges [42434] to the 4.3 branch.
Fixes #42963 for 4.3.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42471 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 06:55:18 +00:00