The supported status values for Site Health tests are `good`, `recommended`, and `critical`.
Follow-up to [50660].
Props TimothyBlynJacobs.
Merges [50710] to the 5.7 branch.
Fixes#52783.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50711 602fd350-edb4-49c9-b593-d223f7449a82
Twenty Twenty-One: Bump version to 1.3
Twenty Seventeen: Bump version to 2.7
Props desrosj, mukesh27, peterwilsoncc.
Merges [50708] to the 5.7 branch.
Fixes#52859.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50709 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that contrast between text color and background meets the WCAG 2.0 AA recommended value. The following locations were changed:
- Network List Tables: Use lighter background colors for site status indicator.
- Nav Menus: Use a lighter background color for invalid menu items.
- Pointers: Use a darker background for pointer header.
- Themes: Use darker background on filter button hover.
- Customizer: Use darker background for selected widget.
Follow-up to [50025], [50571].
Props kebbet, melchoyce, peterwilsoncc.
Merges [50687] to the 5.7 branch.
Fixes#52760.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50688 602fd350-edb4-49c9-b593-d223f7449a82
Improve the check for sourceless or dimensionless media when determining if the lazy loading attribute should be added to iframes and images. Never include the lazy loading attribute on embeds of WordPress posts as the iframe is initially hidden.
Including `loading="lazy"` on initially hidden iframes and images can prevent the media from loading in some browsers.
Props adamsilverstein, fabianpimminger, flixos90, johnbillion, jonkastonka, joyously, peterwilsoncc, SergeyBiryukov, SirStuey, swissspidy.
Merges [50682], [50683] to the 5.7 branch.
Fixes#52768.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50684 602fd350-edb4-49c9-b593-d223f7449a82
“Tested up to” is not displayed on the theme directory or within the WordPress dashboard, but should be updated to be accurate for anyone reading the theme’s source code.
Follow up to [50508].
Props desrosj.
Merges [50669] to the 5.7 branch.
Fixes#52982.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50681 602fd350-edb4-49c9-b593-d223f7449a82
Update the default/fresh theme color swatch displayed on user profile pages to match CSS changes made during the 5.7 release cycle.
Props audrasjb, desrosj, ninetyninew, ryelle.
Merges [50663] to the 5.7 branch.
Fixes#52750.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50679 602fd350-edb4-49c9-b593-d223f7449a82
Update @wordpress npm packages to the latest published versions for the 5.7 branch. This includes block editor bug fixes for WordPress 5.7.1.
Props gziolo, noisysocks, youknowriad.
See #52912.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50678 602fd350-edb4-49c9-b593-d223f7449a82
The reorganization of the PHPUnit workflow in [50441] unintentionally caused the tests to be run for every `push` event, even for forks and private mirrors.
Previously, the second job required the first one to pass, and the conditional check on the first prevented both from running. Because the first job is no longer required for the second, both jobs must have the appropriate conditional check.
Merges [50670] to the 5.7 branch.
Fixes#52983.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50671 602fd350-edb4-49c9-b593-d223f7449a82
In the wrapper function `wp_getimagesize()` check if the second parameter was passed before sending it to the PHP function `getimagesize()`.
The PHP function has a different execution path depending on the number of parameters passed, this ensures the wrapper function follows the appropriate path.
Follow up to [50552].
Props azaozz, hellofromtonya, Mista-Flo, peterwilsoncc, rinatkhaziev, RogerTheriault, SergeyBiryukov, terriann, whyisjake.
Merges [50586] to the 5.7 branch.
Fixes#52826.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50662 602fd350-edb4-49c9-b593-d223f7449a82
Reduce severity of failing HTTPS tests from critical to warning. Stop reporting failures if the site is being accessed over HTTPS but `wp_is_https_supported()` indicates a lack of support.
Props annalamprou, AnotherDave, ayeshrajans, bobbingwide, Clorith, dragongate, eatsleepcode, gab81, geoffrey1963, Ipstenu, k3nsai, mmuyskens, nicegamer7, peterwilsoncc, pwallner, SergeyBiryukov, TimothyBlynJacobs, Toru.
Merges [50659] to the 5.7 branch.
Fixes#52783.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50660 602fd350-edb4-49c9-b593-d223f7449a82
When validating `enum` values as `integer` or `number`, consider a number with a zero fractional part to be equivalent to an integer of the same value.
In `rest_are_values_equal()`, when comparing two values of type `int` or `float` (in any combination), first cast both of them to `float` and then compare.
This matches some test cases from the official JSON Schema test suite.
Follow-up to [50010].
Props yakimun, stefanjoebstl, TimothyBlynJacobs, rachelbaker.
Merges [50653] to the 5.7 branch.
Fixes#52932.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50656 602fd350-edb4-49c9-b593-d223f7449a82
This resolves an issue with the Cover block, where the `object-position` property is removed from the content when a non-admin user saves the post, leading to block recovery loop.
Props Mamaduka, aristath.
Merges [50634] to the 5.7 branch.
Fixes#52961.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50649 602fd350-edb4-49c9-b593-d223f7449a82
This change switches out sprintf for printf on the "Copy suggested policy text from..." button screen reader text. Also, wrap the actual button text in a <span aria-hidden="true"> to prevent both the button text and the screen reader text from being spoken.
Props mukesh27, SergeyBiryukov, sabernhardt, desrosj.
Merges [50585] to the 5.7 branch.
Fixes#52891.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50609 602fd350-edb4-49c9-b593-d223f7449a82
This backports a handful of test fixes related to generating code coverage reporting, as well as some `devDependency` updates.
Backports [50591-50595,50597-50598] to the 5.7 branch.
See #52624, #52786, #51734.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50601 602fd350-edb4-49c9-b593-d223f7449a82
Because the changes in Twenty Twelve did not impact site look or functionality, version 3.4 of Twenty Twelve was not released in coordination with WordPress 5.7.
This reverts the portion of [50508] relevant to Twenty Twelve, changing the version back to 3.3 so that version 3.4 is not skipped accidentally when there are changes that should be released.
Merges [50596] to the 5.7 branch.
See #52704.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50597 602fd350-edb4-49c9-b593-d223f7449a82
On TravisCI, old branches still receiving security updates were tested on a regular basis. This ensured tests continued to pass as time passed even if updates were not made to these branches.
On GitHub Actions, there is no interface to configure this (TravisCI had a UI), but there is a `schedule` event that can trigger workflow runs on cron that can be used to accomplish the same thing.
This introduces a workflow file that runs twice a month (on the 1st and 15th) to verify the tests within older branches.
Because the `schedule` event only runs within the primary branch, the appropriate workflows in each old branch will be triggered manually through the `workflow_dispatch` trigger using the GitHub REST API. `workflow_dispatch` will need to be added to all workflows in all old branches in order for the event to dispatch successfully.
Merges [50590] to the 5.7 branch.
See #52653.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50591 602fd350-edb4-49c9-b593-d223f7449a82
The editor uses the full height of its container, so the added margins cause the visual editor to break out of the container. This removes the top & bottom margins, and makes the left & right margins consistent with the meta box area.
Follow-up to [50465].
Props joseeyoast, audrasjb, SergeyBiryukov.
Merges [50534] to the 5.7 branch.
Fixes#52816.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50588 602fd350-edb4-49c9-b593-d223f7449a82
Removes the mutually exclusive directives check in `wp_robots()`, ie allow both `follow` and `nofollow` to be specified and for `archive` and `noarchive` to be specified.
This fixes a bug in which WordPress would defer to the most permissive over the least permissive. When contradictory instructions are included, WordPress will defer to the search engine's or archivist's resolution policy: generally this is to observe the least, not most permissive.
Props Cybr, flixos90, SergeyBiryukov.
Merges [50566] to the 5.7 branch.
Fixes#52713.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50587 602fd350-edb4-49c9-b593-d223f7449a82
Replace the CSS removed in [50569], which is used to align the login & register buttons.
Props mukesh27, audrasjb.
Reviewed by SergeyBiryukov.
Merges [50577] to the 5.7 branch.
Fixes#52834.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50580 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.
Follow-up to [50025], [50525].
Props sabernhardt, ryelle.
Merges [50571] to the 5.7 branch.
Fixes#52760.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50578 602fd350-edb4-49c9-b593-d223f7449a82
On narrow screens allow the text to wrap in the copy buttons on the privacy policy guide screen to avoid horizontal overflow of the parent container.
Props audrasjb, davidbaumwald, jaymanpandya, paaljoachim, palmiak, sabernhardt, SergeyBiryukov, sumitsingh.
Merges [50568] to the 5.7 branch.
Fixes#52751.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50574 602fd350-edb4-49c9-b593-d223f7449a82
Add a check to `WP_REST_Meta_Fields::delete_meta_value()` ensuring meta data is set before attempting to delete it from the database. If the data does not exist, the delete is considered successful as the data matches the desired state.
Props BrechtVds, goaroundagain, TimothyBlynJacobs.
Merges [50567] to the 5.7 branch.
Fixes#52787.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50573 602fd350-edb4-49c9-b593-d223f7449a82
Prevent misalignment of "generate password" and "save password" buttons on the password reset screen on narrow screens and in languages requiring longer text than English.
Props audrasjb, grapplerulrich, ryelle.
Merges [50569] to the 5.7 branch.
Fixes#52834.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50572 602fd350-edb4-49c9-b593-d223f7449a82
With changes that were introduced in #49889 the second parameter for getimagesize() function is expecting a a reference.
Previously, most calls did not pass the 2nd param, and as a result, we are getting unexpected results.
This was only a problem with applications that are using a custom stream wrapper, and the image contained EXIF data.
For more see:
https://github.com/humanmade/S3-Uploads/issues/496https://github.com/aws/aws-sdk-php/issues/1923Fixes#52826.
Merges [50552] to the 5.7 branch.
Props terriann, SergeyBiryukov, Mista-Flo, hellofromTonya, rinatkhaziev, whyisjake.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50553 602fd350-edb4-49c9-b593-d223f7449a82
If the callback is called before the images are loaded, the comparison doesn't work. `wp.domReady` uses `DOMContentLoaded`, which does not guarantee that the images are loaded. This switches to use the `load` event, which waits for all resources to load.
Props vladytimy, joyously, sergeybiryukov.
Merges [50535] to the 5.7 branch.
Fixes#52758.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50536 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.
Follow-up to [50025].
Props sabernhardt, Otshelnik-Fm, audrasjb.
Merges [50525] to the 5.7 branch.
Fixes#52760.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50526 602fd350-edb4-49c9-b593-d223f7449a82
This ensures the images are loaded correctly from both single site and network About pages.
Props TobiasBg, audrasjb.
Merges [50523] to the 5.7 branch.
Fixes#52743.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50524 602fd350-edb4-49c9-b593-d223f7449a82
This avoids an "Undefined variable" PHP notice in the `::mt_supportedMethods()` and `::mt_supportedTextFilters()` methods.
Follow-up to [50353].
Props dd32.
Reviewed by dd32, SergeyBiryukov.
Merges [50499] to the 5.7 branch.
Fixes#52524.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50500 602fd350-edb4-49c9-b593-d223f7449a82
The intro text has been updated for accuracy and to make it easier for translation. The button text has been updated for accuracy.
Props jdy68, audrasjb, marybaum, davidbaumwald.
Reviewed by ryelle, SergeyBiryukov.
Merges [50495] to the 5.7 branch.
See #52347.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50498 602fd350-edb4-49c9-b593-d223f7449a82
