50828 Commits

Author SHA1 Message Date
Aaron Jorbin
ac057e6c69 Build/Test: Remove unused ink-docstrap.
jsdoc is not currently in use and this theme for it is very out of date. There are currently a small handful of minor vulnerabilities within transitive dependencies being privately reported by Dependabot that cannot be resolved due to version constraints within ink-docstrap. While this in no way affects WordPress (since this code is not used by WordPress), it does create noise which can be eliminated.

This was first added in [41351] as a part of .

Props desrosj.
Fixes .


git-svn-id: https://develop.svn.wordpress.org/trunk@59935 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-04 21:35:09 +00:00
Joe Dolson
4ad0135eca Media: Tests: Remove extraneous @test annotation.
The data provider for tests added in [59902] had an @test annotation, causing it to be run as if it were a test, throwing a risky test warning. Remove the @test annotation to prevent this undesired warning.

Props johnbillion, joedolson.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@59934 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-04 19:16:33 +00:00
Joe McGill
2e078fe869 Post WordPress 6.8 Beta 1 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@59933 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-04 16:09:29 +00:00
Joe McGill
311b2c13e3 WordPress 6.8 Beta 1.
git-svn-id: https://develop.svn.wordpress.org/trunk@59932 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-04 15:30:39 +00:00
John Blackbourn
dc21f5b889 Date/Time: Add tests that cover the wp_timezone_override_offset() function.
Props pbearne, audrasjb

Fixes 

git-svn-id: https://develop.svn.wordpress.org/trunk@59931 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-04 14:56:14 +00:00
Sergey Biryukov
87953e10e4 Tests: Move get_calendar() tests to a more appropriate place.
This aims to bring consistency with the tests for the other functions in `wp-includes/general-template.php`.

Includes correcting the test class name as per the naming conventions.

Follow-up to [59908].

See .

git-svn-id: https://develop.svn.wordpress.org/trunk@59930 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-04 14:55:38 +00:00
Jonathan Desrosiers
224cc6e4aa Build/Test Tools: Update devDependencies.
This updates the following `devDependencies` to their latest versions:

- `@playwright/test` from `1.49.1` to `1.50.1`
- `chalk` from `5.3.0` to `5.4.1`
- `copy-webpack-plugin` from `12.0.2` to `13.0.0`
- `grunt-sass` from `3.1.0` to `4.0.0`
- `postcss` from `8.4.49` to `8.5.3`
- `sass` from `1.83.4` to `1.85.1`
- `terser-webpack-plugin` from `5.3.11` to `5.3.12`
- `uuid` from `11.0.3` to `11.1.0`
- `wait-on` from `8.0.1` to `8.0.2`
- `wepback` from `5.97.1` to `5.98.0`

Additionally, `npm dedupe` and `npm audit fix` have been run.

Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@59929 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-04 14:53:42 +00:00
Jonathan Desrosiers
bbfe51c3e5 External Libraries: Update json2php to version 0.0.12.
A full list of changes can be found on GitHub: https://github.com/daniel-zahariev/json2php/compare/0.0.9...v0.0.12.

Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@59928 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-04 14:43:04 +00:00
John Blackbourn
fd3f4e3818 Docs: Various improvements to inline documentation.
See 

git-svn-id: https://develop.svn.wordpress.org/trunk@59927 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-04 14:17:18 +00:00
John Blackbourn
cc77f085c3 Upgrade/Install: Prevent an unnecessary plugin update check when the plugin update data is up to date.
This ensures the `checked` property is always populated with the latest plugin data before determining whether to perform an update check. Previously this was only populated when the data was already identified as being stale, which could result in a subsequent unnecessary update check when viewing the Plugins screen.

Props siliconforks, bookdude13, pbiron, francina, Cybr, snehapatil02, johnbillion

Fixes , 

git-svn-id: https://develop.svn.wordpress.org/trunk@59926 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-04 13:48:58 +00:00
George Mamadashvili
13fe8be435 Block support: Add server-side processing for ariaLabel.
Adds server-side registration for `ariaLabel` block support and its required fields. Fully enabling feature support for dynamic blocks and consumers using `ServerSideRender` component.

Props wildworks, fabiankaegy, joemcgill, poena.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@59925 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-04 13:04:49 +00:00
Jb Audras
2a0517b05f Editor: Use the export cap to determine whether users can export themes.
This changeset replaces `edit_theme_options` with the `export` capability to determine whether the current user can export themes. That condition determines whether to show the Export Theme button in the Site Editor. Using `export` capability makes it more consistent with general export capabilities across the administration.

Props unsalkorkmaz, rajinsharwar, audrasjb, peterwilsoncc, desrosj, Mamaduka, TimothyBlynJacobs.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@59924 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-04 06:05:15 +00:00
Jb Audras
1439cc5f40 Bookmarks: Update link_updated when a link is created or updated.
This changeset fixes an issue where the `link_updated` field was not updated in the old Link Manager. When a link was created or updated the `link_updated` field remained `0000-00-00 00:00:00`.

Props lenasterg, audrasjb.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@59923 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-04 05:53:27 +00:00
Peter Wilson
b1cfb19629 Build/Test Tools: Remove redundant decoding from the commit message that's passed to the Slack API.
This JSON decoding is no longer needed since the commit message was converted to a plain string in r59920. The commit message can now be treated as a plain text string in an environment variable throughout the workflow.

Props johnbillion.
See 


git-svn-id: https://develop.svn.wordpress.org/trunk@59922 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-04 02:17:13 +00:00
Joe Dolson
1578f25674 Bundled Themes: Twenty Nineteen: Omit irrelevant ARIA in menus.
Don't set `aria-expanded` and `aria-haspopup` attributes outside of the primary menu. Secondary menus (social and footer) are set to a depth of 1, and have nothing to expand or popup.

Props bschneidewind, joedolson, mikinc860.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@59921 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 22:51:24 +00:00
John Blackbourn
24a47a419a Build/Test Tools: Remove redundant escaping from the commit message that's passed to the Slack API.
This escaping is no longer needed since all instances of inline expressions were removed from workflows in r59679. The commit message can now be treated as a plain text string in an environment variable throughout the workflow.

Props johnbillion, swissspidy

Unprops johnblackbourn

See 


git-svn-id: https://develop.svn.wordpress.org/trunk@59920 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 22:07:57 +00:00
Peter Wilson
e6fa3b914c Query: Ensure secondary loops populate the full global post.
Modifies `WP_Query::the_post()` to ensure the entire global post object is populated regardless of the `fields` parameter initially set by the developer.

In secondary loops, this ensures that `get_the_content()` and other getter functions operate as documented when called without a post ID and return the appropriate data for the global post object.

This introduces consistency when starting the loop and the `fields` parameter is set to `id=>parent` to the behaviour when set to either `all` or `ids`.

There is no change to the `WP_Query::$posts` parameter nor when a query is made without starting the secondary loop, ie without calling `WP_Query::the_post()`.

Props juzar, mukesh27, oglekler, peterwilsoncc, sirlouen, joemcgill.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@59919 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 21:43:44 +00:00
Jb Audras
9c11701d77 Widgets: Fix get_calendar() related PHPUnit tests.
This is a new fix for PHPUnit tests failures after [59908].

Follow-up to [59908], [59917].

See .



git-svn-id: https://develop.svn.wordpress.org/trunk@59918 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 21:29:54 +00:00
Jb Audras
d55d8dcffa Widgets: Fix get_calendar() related PHPUnit tests.
This is a temporary fix for PHPUnit tests failures after [59908].

Follow-up to [59908].

See .



git-svn-id: https://develop.svn.wordpress.org/trunk@59917 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 21:15:50 +00:00
Joe Dolson
ad039b2f25 Bundled Themes: Twenty Fifteen: Fix ARIA expanded in primary menu.
Set `aria-expanded` to true when automatically expanding active child menus in the primary menu. Add `aria-controls` to explicitly define controlled content in menus.

Props bschneidewind, joedolson, dhruvang21, pooja1210, shailu25.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@59916 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 21:05:20 +00:00
Sergey Biryukov
04b6524cb0 Coding Standards: Use strict comparison in wp_insert_comment().
Includes type casting `$comment_approved` to an integer to avoid breaking WP-CLI tests, since the value can be passed as a string.

Follow-up to [3104], [3193], [3887], [59903].

Props swissspidy.
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@59915 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 20:57:07 +00:00
Joe Dolson
8731d62dc7 Bundled Themes: Twenty Fourteen: Move skip link to top of body.
Move the skip link to the top of the body content, so it is the first focusable item on the page.

Props joedolson, abcd95, manojmaharrshi, vganavda, shailu25.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@59914 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 20:35:34 +00:00
Joe Dolson
c1d2a5d18d Bundled Themes: Twenty Thirteen: Move skip link to top of body.
Move the skip link to the top of the body content, so it is the first focusable item on the page.

Props joedolson, sabernhardt, abcd95, manojmaharrshi, shailu25, audrasjb, krupajnanda.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@59913 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 20:23:49 +00:00
Joe Dolson
81743366e7 Bundled Themes: Twenty Twelve: Move skip link to top of body.
Move the skip link to the top of the body content, so it is the first focusable item on the page.

Props joedolson, sabernhardt, abcd95, vgnavada, shailu25.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@59912 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 20:20:47 +00:00
Joe Dolson
5aa3534c2d Bundled Themes: Twenty Twelve: Add ARIA attributes on menu toggle.
Add `aria-expanded` and `aria-controls` attributes to the Twenty Twelve mobile menu toggle.

Props bschneidewind, joedolson, sabernhardt, umeshsinghin.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@59911 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 20:06:03 +00:00
Jb Audras
f578d8ebab Admin bar: Update the "Edit Site" link.
This changeset replaces the "Edit Site" link in the admin bar to point to the top level screen of the Site Editor, instead of opening the current template.
Merges Gutenberg changeset: WordPress/gutenberg#69271

Props mosne, poena, audrasjb, shailu25.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@59910 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 20:05:52 +00:00
Jb Audras
7903c32edf Docs: Param indentation improvements in get_calendar() function and hooks.
See .



git-svn-id: https://develop.svn.wordpress.org/trunk@59909 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 19:57:16 +00:00
Jb Audras
2b697b8f21 Widgets: Add post type support to get_calendar() function.
This changeset updates the `get_calendar()` function to allow post type filtering via the `$post_type` parameter, with backard compatibility for previous params. It also updates the related `get_calendar_args` and `get_calendar` hooks accordingly.

Props sebastianpisula, swissspidy, dwainm, moxie, sukhendu2002, audrasjb, mukesh27. 
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@59908 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 19:54:34 +00:00
Joe Dolson
4452b6707e Bundled Themes: Add aria-current="page" on header links.
Mark links that point to the current URL in bundled theme headers with `aria-current="page"` to inform screen reader users that this link is the current page.

Changes to Twenty Ten through Twenty Twenty add `aria-current` and `rel="home"` where appropriate, Twenty Twenty One only adds `rel="home"`.

Props bschneidewind, joedolson, hiabhaykulkarni, sabernhardt.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@59907 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 18:43:08 +00:00
Joe McGill
bc1bdb3a06 Editor: Update packages for 6.8 Beta 1.
Syncs @wordpress/* packages to the 'latest' npm tag.

Props mamaduka, joemcgill, desrosj.
See .


git-svn-id: https://develop.svn.wordpress.org/trunk@59906 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 18:06:16 +00:00
Joe McGill
4ed2a8b128 Editor: Support Stylebook in the Site Editor for classic themes.
This modifies the submenu for the Site Editor which previously linked directly to the Patterns page after [58278] to support accessing the Stylebook in classic themes via a new "Design" link. Currently, any classic themes that have either added support for `editor-styles` or have a theme.json file will automatically see this new link in the admin menu.

Props isabel_brison, poena, wildworks, mamaduka, karmatosed, joemcgill.
Fixes .


git-svn-id: https://develop.svn.wordpress.org/trunk@59905 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 17:20:36 +00:00
John Blackbourn
b5e0c16c04 Security: Reduce the length of the hash returned by wp_fast_hash() so it can be used in the user_activation_key field when a legacy database schema is still in use.
This reduces the hash length from 32 bytes to 30 so the overall length of an activation key after encoding, prefixing, and prepending a timestamp fits into 60 bytes.

A key is also introduced for domain separation. This doesn't affect the output length.

Props dd32, paragoninitiativeenterprises, peterwilsoncc, johnbillion

Fixes 

git-svn-id: https://develop.svn.wordpress.org/trunk@59904 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 09:49:36 +00:00
Pascal Birchler
1b236aa435 Coding Standards: Revert strict comparison added in [59898].
`$comment_approved` can be both a string or an integer, so this change had unintended consequences such as breaking WP-CLI tests.

See .

git-svn-id: https://develop.svn.wordpress.org/trunk@59903 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 09:03:26 +00:00
Joe Dolson
b4f0fc916e Media: Allow uploading images from URLs without extensions.
Enable `download_url()` to fetch and verify file types if the URL does not contain a file extension. This allows URL downloads to handle media endpoints like istockphoto.com that use file IDs and formatting arguments to deliver images.

Props masteradhoc, mitogh, joedolson, hellofromTonya, antpb, audrasjb, navi161, dmsnell.
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@59902 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-03 00:17:08 +00:00
Peter Wilson
cad2f8cff9 Users: Use editable_roles filter for multisite sub-sites.
Adds a check of the `editable_roles` filter when adding users to a multisite sub-site to ensure the role is permitted to be used on the network. If the role is blocked by the filter, attempting to add the role will trigger a `wp_die()` similar to attempting to add a user with the role on a single site install.

Props eartboard, hareesh-pillai, ideag, sukhendu2002, spacedmonkey, thomaswm.
Fixes .


git-svn-id: https://develop.svn.wordpress.org/trunk@59901 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-02 23:33:56 +00:00
Peter Wilson
e30ab16337 Users: Add pre-flight filter to count_many_users_posts().
Introduces the filter `pre_count_many_users_posts()` to allow developers to bypass the function in favour of either avoiding counts or their own counting functionality.

Props audrasjb, ethitter, jigar-bhanushali, jorbin.
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@59900 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-02 23:04:23 +00:00
Timothy Jacobs
1c2a87b294 REST API: Improve performance for HEAD requests.
By default, the REST API responds to HEAD rqeuests by calling the GET handler and omitting the body from the response. While convenient, this ends up performing needless work that slows down the API response time.

This commit adjusts the Core controllers to specifically handle HEAD requests by not preparing the response body.

Fixes .
Props antonvlasenko, janusdev, ironprogrammer, swissspidy, spacedmonkey, mukesh27, mamaduka, timothyblynjacobs.



git-svn-id: https://develop.svn.wordpress.org/trunk@59899 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-02 22:05:08 +00:00
Sergey Biryukov
c19e4a45c2 Coding Standards: Use strict comparison in wp_insert_comment().
Follow-up to [3104], [3193], [3887].

Props aristath, poena, afercia, SergeyBiryukov.
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@59898 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-02 19:46:43 +00:00
Joe Dolson
1964aec667 Media: Simplify file name generation for image conversions.
Use the empty string argument in `$editor->save()` added in [59855] to simplify the code used to prevent image format conversions from getting a suffix appended to their file names.

Props joedolson, audrasjb, azaozz.
See .
Fixes .

git-svn-id: https://develop.svn.wordpress.org/trunk@59897 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-02 18:53:33 +00:00
John Blackbourn
3e56dfc905 Docs: Various improvements to inline documentation.
See 

git-svn-id: https://develop.svn.wordpress.org/trunk@59896 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-02 00:41:48 +00:00
John Blackbourn
f6b55440a6 Security: Add some test files that were missed in [59828].
See 

git-svn-id: https://develop.svn.wordpress.org/trunk@59895 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-02 00:35:45 +00:00
Sergey Biryukov
7e13238bf9 Site Health: Fix typo in the robots.txt check messages.
Follow-up to [59890].

See .

git-svn-id: https://develop.svn.wordpress.org/trunk@59894 602fd350-edb4-49c9-b593-d223f7449a82
2025-03-01 00:27:21 +00:00
John Blackbourn
360732e132 Security: Reintroduce support for passwords hashed with MD5.
This reinstates the ability for a user to log in to an account where the password is hashed using MD5. This means that the ability to reset a password directly in the database using an SQL query or a database administration tool will be retained without the need to implement or integrate with bcrypt or phpass.

A password hashed with MD5 will get upgraded to bcrypt at the point where a user successfully logs in, just as is the case with a phpass hash.

Props audrasjb, aaronjorbin, johnbillion, david-innes, benniledl.

See .

git-svn-id: https://develop.svn.wordpress.org/trunk@59893 602fd350-edb4-49c9-b593-d223f7449a82
2025-02-28 18:51:44 +00:00
Joe McGill
bcaaa16a1f REST API: Add support for search_columns to the user endpoint.
This adds support for passing a `search_columns` argument to the user controller so that users with `list_users` caps can specify which field is being searched.

Props youknowriad, joemcgill, ntsekouras, mreishus, mamaduka.
Fixes 62596.


git-svn-id: https://develop.svn.wordpress.org/trunk@59892 602fd350-edb4-49c9-b593-d223f7449a82
2025-02-28 18:19:21 +00:00
Tammie Lister
980f2541aa Twenty Twenty-Five: Improves text strings.
This ticket replaces the issue not resolved in time before the release of the theme. This now takes the feedback of translators and iterates on that.
  
Props poena, desrosj, hameem1102, burakkaptan, jorbin, prathamesh24, audrasjb.  
Fixes .


git-svn-id: https://develop.svn.wordpress.org/trunk@59891 602fd350-edb4-49c9-b593-d223f7449a82
2025-02-28 17:05:16 +00:00
Aaron Jorbin
73c0f0ba72 Site Health: Add a robots.txt check to the server data.
Provide a bit of information about robots.txt to help people understand if the file is generated by WordPress.

Props zodiac1978, audrasjb, joostdevalk, jorbin.
Fixes .


git-svn-id: https://develop.svn.wordpress.org/trunk@59890 602fd350-edb4-49c9-b593-d223f7449a82
2025-02-28 16:56:57 +00:00
Jb Audras
57828fa0de General: Add missing space before checked attributes in various WP_Screen functions.
Props kkmuffme, audrasjb. 
Fixes .



git-svn-id: https://develop.svn.wordpress.org/trunk@59889 602fd350-edb4-49c9-b593-d223f7449a82
2025-02-28 14:59:53 +00:00
Jb Audras
3f82512e5c Embeds: Revert [59883].
This reverts [59883] as the addition of the youtube-nocookie domain to the embed providers list wasn't done correctly.

Unprops audrasjb. Props otto42, swissspidy. 
See .



git-svn-id: https://develop.svn.wordpress.org/trunk@59888 602fd350-edb4-49c9-b593-d223f7449a82
2025-02-28 13:28:01 +00:00
Sergey Biryukov
46399d6eb3 Coding Standards: Use strict comparison in privacy_ping_filter().
Follow-up to [3548], [3885].

Props aristath, poena, afercia, SergeyBiryukov.
See .

git-svn-id: https://develop.svn.wordpress.org/trunk@59887 602fd350-edb4-49c9-b593-d223f7449a82
2025-02-28 11:25:15 +00:00
Peter Wilson
e7ce9bbfbf REST API: Exit gracefully for malformed URLs.
Exit gracefully for requests with a malformed `rest_route` query string parameter, ie anything that is not a string.

This prevents fatal errors from occurring with URLs such as `example.com/?rest_route[]=array` as the URL is user input so logging the data provides no benefit to developers as they are unable to resolve the issue.

Props geekofshire, dd32, timothyblynjacobs.
Fixes .


git-svn-id: https://develop.svn.wordpress.org/trunk@59886 602fd350-edb4-49c9-b593-d223f7449a82
2025-02-27 23:17:38 +00:00