42993 Commits

Author SHA1 Message Date
Sergey Biryukov
b1385b73fe Administration: Make sure row actions for recent comments in Activity dashboard widget stay visible when a single row gets focus.
Follow-up to [49142].

Props sabernhardt, kebbet, hareesh-pillai, pbiron.
Fixes #51886. See #51516, #49715.

git-svn-id: https://develop.svn.wordpress.org/trunk@49725 602fd350-edb4-49c9-b593-d223f7449a82
2020-12-01 18:14:37 +00:00
Sergey Biryukov
b4819255d3 Editor: Don't unnecessarily split a translatable string in block templates.
As a best practice, strings available for translation should contain entire sentences whenever possible.

Splitting a sentence in two parts and putting them back together after translation should be avoided, as the word order in other languages can be different from English.

Props tobifjellner, kebbet, audrasjb, mukesh27, hellofromTonya, azaozz, SergeyBiryukov.
Fixes #51893.

git-svn-id: https://develop.svn.wordpress.org/trunk@49722 602fd350-edb4-49c9-b593-d223f7449a82
2020-12-01 17:01:50 +00:00
Sergey Biryukov
39fd44dd59 Media: Revert [49567].
This addresses a regression with the pagination section in Media Library no longer taking additional query filtering into account.

Props iCaleb, trepmal, peterwilsoncc.
See #39968.

git-svn-id: https://develop.svn.wordpress.org/trunk@49720 602fd350-edb4-49c9-b593-d223f7449a82
2020-12-01 16:31:30 +00:00
Sergey Biryukov
0d3bc82559 Editor: Update packages for WordPress 5.6 RC2.
The following package versions were changed:

@wordpress/block-directory: 1.17.4 -> 1.17.5
@wordpress/block-editor: 5.1.3 -> 5.1.4
@wordpress/block-library: 2.26.4 -> 2.26.5
@wordpress/blocks: 6.24.1 -> 6.24.2
@wordpress/components: 11.1.1 -> 11.1.2
@wordpress/core-data: 2.24.1 -> 2.24.2
@wordpress/edit-post: 3.25.4 -> 3.25.5
@wordpress/editor: 9.24.3 -> 9.24.4
@wordpress/format-library: 1.25.3 -> 1.25.4
@wordpress/list-reusable-blocks: 1.24.1 -> 1.24.2
@wordpress/nux: 3.23.1 -> 3.23.2
@wordpress/reusable-blocks: 1.0.3 -> 1.0.4
@wordpress/server-side-render: 1.19.1 -> 1.19.2

See https://github.com/WordPress/gutenberg/pull/27366 for the list of fixed bugs.

Props isabel_brison.
Fixes #51902.

git-svn-id: https://develop.svn.wordpress.org/trunk@49718 602fd350-edb4-49c9-b593-d223f7449a82
2020-12-01 12:17:07 +00:00
Timothy Jacobs
901909bf2c Site Health, App Passwords: Ensure REST API responses are properly translated.
The REST API requests in Site Health and App Passwords now include `_locale=user` in the request URL to ensure the user's locale is used instead of the site locale. Additionally, the `apiRequest` library now sends a JSON `Accept` header which is required by `determine_locale()` to respect the `_locale` query parameter.

The Site Health REST API controllers now manually load the default admin textdomain if not `is_admin()`. This allows for the Site Health tests to be translated even though the translations are part of the administration project and the REST API is not.

Props oglekler, kebbet, Clorith, TimothyBlynJacobs, ocean90, SergeyBiryukov, adamsilverstein.
Fixes #51871.


git-svn-id: https://develop.svn.wordpress.org/trunk@49716 602fd350-edb4-49c9-b593-d223f7449a82
2020-12-01 03:42:31 +00:00
Sergey Biryukov
0d53804ea3 External Libraries: Upgrade PHPMailer to version 6.2.0.
For a full list of changes in this update, see the PHPMailer GitHub:
https://github.com/PHPMailer/PHPMailer/compare/v6.1.8...v6.2.0

Props ayeshrajans, jrf.
Fixes #51874.

git-svn-id: https://develop.svn.wordpress.org/trunk@49713 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-30 17:08:24 +00:00
Andrew Ozz
69c3ab8a11 Quick/Bulk Edit: Follow up to [49703]. Improve the logic a bit and always return this (the jQuery object) in wpTagsSuggest.
Fixes #51872.

git-svn-id: https://develop.svn.wordpress.org/trunk@49710 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-30 14:29:42 +00:00
Sergey Biryukov
19864318cc Upgrade/Install: Display "You are using a development version" message on WordPress Updates screen for Beta or RC versions.
This ensures that the message is displayed when the `WP_AUTO_UPDATE_CORE` constant is set to `beta` or `rc` and the user is on a development version.

Follow-up to [49245], [49254], [49292], [49638], [49708].

Props afragen, audrasjb, azaozz, SergeyBiryukov.
Fixes #51822.

git-svn-id: https://develop.svn.wordpress.org/trunk@49709 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-30 13:40:02 +00:00
Sergey Biryukov
d6f17ebfef Upgrade/Install: Display "You are using a development version" message in the admin footer for Beta or RC versions.
This ensures that the message is displayed when the `WP_AUTO_UPDATE_CORE` constant is set to `beta` or `rc` and the user is on a development version.

Props afragen.
Fixes #51892.

git-svn-id: https://develop.svn.wordpress.org/trunk@49708 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-29 16:11:34 +00:00
Sergey Biryukov
86330218cd Comments: Correct ending tag placement in the "Search results for: ..." subtitle.
Follow-up to [49284], [49286].

Props Clorith, kebbet, johnbillion, audrasjb, azaozz.
Fixes #51889. See #37353.

git-svn-id: https://develop.svn.wordpress.org/trunk@49705 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-28 17:26:17 +00:00
Andrew Ozz
24e41d6bba External Libraries: Fix hiding of the text in the jQuery UI dialog close button.
Props marijnkoopman, SergeyBiryukov, Clorith, azaozz.
Fixes #51863.

git-svn-id: https://develop.svn.wordpress.org/trunk@49704 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-28 13:48:48 +00:00
Andrew Ozz
b2d59e7c8d Quick/Bulk Edit: Fix undefined error when initializing UI Autocomplete 1.12.1 on non-existing element and then attempting to use the autocomplete instance.
Example: `jQuery( '#nonexisting' ).autocomplete().autocomplete( 'instance' ).something`.

Props _luigi, sabernhardt, donmhico, azaozz.
Fixes #51872.

git-svn-id: https://develop.svn.wordpress.org/trunk@49703 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-28 12:44:44 +00:00
ryelle
f4525a2e93 Help/About: Update URLs in About page
Replace the placeholder links now that the posts have been published. This also updates the jQuery plugin links to to local-site links, if the user can install plugins.

Follow-up to [49640].
Props mukesh27, ocean90.
See #51415.



git-svn-id: https://develop.svn.wordpress.org/trunk@49702 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-27 17:08:34 +00:00
Sergey Biryukov
1c2aada05b Tests: Test that sanitize_title_with_dashes() strips HTML tags.
`sanitize_title()` already has the same test in its own file.

Props pbearne.
Fixes #51881.

git-svn-id: https://develop.svn.wordpress.org/trunk@49701 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-27 12:50:11 +00:00
johnbillion
850e31dc58 Docs: Corrections and improvements to docs for properties of the WP_Query class.
This also adds additional type hinting inside some methods to help IDEs.

See #51800


git-svn-id: https://develop.svn.wordpress.org/trunk@49700 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-26 17:02:02 +00:00
Sergey Biryukov
7f547618fd Options, Meta APIs: Pass $meta_type to the get_{$meta_type}_metadata filter in metadata_exists().
This matches the main instance of the filter in `get_metadata_raw()`.

Follow-up to [48505].

Props pbiron, jsmoriss, TimothyBlynJacobs.
Fixes #51866.

git-svn-id: https://develop.svn.wordpress.org/trunk@49699 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-26 12:32:35 +00:00
Sergey Biryukov
4a4d46fbe3 Docs: Use typed array notation for the $size parameter of embed_defaults filter.
Previously committed in [42876], accidentally reverted in [44154].

See #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@49698 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-25 12:12:46 +00:00
Peter Wilson
0addc4ac04 Build/Test Tools: Use dataProviders for some kses tests.
Refactor several kses tests to use dataProviers rather than looping through assertions.

See #51802.


git-svn-id: https://develop.svn.wordpress.org/trunk@49697 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-25 04:49:04 +00:00
Peter Wilson
95751aeec2 Build/Test Tools: Remove unused posts from AJAX test setUp().
Removes the creation of five posts from the AJAX test suite `setUp()` function, replacing it with a shared fixture only where required.

See #51802.


git-svn-id: https://develop.svn.wordpress.org/trunk@49696 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-25 04:09:41 +00:00
Robert Anderson
a86bedfc92 Editor: Remove render_block hooks from WP_Block
Reverts the move of pre_render_block, render_block_data, and
render_block_context to WP_Block.

This change has more implications than first thought so will be revisted later
in 5.7.

Reverts [49609,49608].
See #51612.


git-svn-id: https://develop.svn.wordpress.org/trunk@49695 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-25 01:18:25 +00:00
John Blackbourn
c8f7440c6a Docs: Upgrade more parameters in docblocks to used typed array notation.
See #51800, #41756


git-svn-id: https://develop.svn.wordpress.org/trunk@49693 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-24 21:25:46 +00:00
John Blackbourn
f2c9d2851c Docs: Various docblock corrections relating to parameter types.
See #51800


git-svn-id: https://develop.svn.wordpress.org/trunk@49692 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-24 21:20:36 +00:00
Sergey Biryukov
c869ef617e Tests: Ignore EOL differences in WP_List_Table::get_bulk_items() test for optgroups.
This avoids a misleading failure due to Unix vs. Windows EOL style mismatches and allows the test to pass on Windows.

Follow-up to [46612], [49190].

See #19278.

git-svn-id: https://develop.svn.wordpress.org/trunk@49691 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-24 20:41:13 +00:00
Sergey Biryukov
d9976e94e2 Docs: Clarify that the $class argument of wp_list_bookmarks() can accept an array.
Follow-up to [32906].

See #51855, #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@49688 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-24 12:27:49 +00:00
Sergey Biryukov
cf6c201446 Help/About: Move trailing punctuation in the jQuery Migrate Helper plugin link outside of the HTML tag.
Props psmits1567, audrasjb, tobifjellner, fierevere, markscottrobson.
Fixes #51813.

git-svn-id: https://develop.svn.wordpress.org/trunk@49685 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-23 19:33:48 +00:00
Sergey Biryukov
617097260d Plugins: Check if _error_nonce is set before attempting to verify it.
This avoids a PHP notice on the Plugins screen when `error` query string is added to the URL.

Props wponlinesupport.
Fixes #43876.

git-svn-id: https://develop.svn.wordpress.org/trunk@49683 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-23 13:34:21 +00:00
Sergey Biryukov
31315dd401 Docs: Update syntax for multi-line comment in core_auto_updates_settings() per the documentation standards.
Follow-up to [49677].

See #51827.

git-svn-id: https://develop.svn.wordpress.org/trunk@49681 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-22 15:57:19 +00:00
Sergey Biryukov
8d7651fde1 Docs: Add documentation for the $type and $mime_type properties in WP_Customize_Image_Control.
Follow-up to [20319], [30309], [31698], [32023], [49679].

Props subrataemfluence.
Fixes #44411.

git-svn-id: https://develop.svn.wordpress.org/trunk@49680 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-22 15:50:35 +00:00
Sergey Biryukov
d8007597b3 Docs: Add documentation for the $type, $mime_type, and $button_labels properties in WP_Customize_Upload_Control.
Follow-up to [20319], [30309], [31698], [32023].

Props subrataemfluence.
See #44411.

git-svn-id: https://develop.svn.wordpress.org/trunk@49679 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-22 15:49:48 +00:00
Sergey Biryukov
dea4db7176 Docs: Correct @since tag for the class-wp-widget-area-customize-control.php file.
Per the documentation standards, the file header `@since` tag is supposed to specify when the file was introduced.

Follow-up to [35389].

See #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@49678 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-22 15:10:55 +00:00
Andrew Ozz
8e7ca8320e Upgrade/Install: Replace the conditionals that check the AUTOMATIC_UPDATER_DISABLED constant and the automatic_updater_disabled filter in update-core.php with a call to WP_Automatic_Updater::is_disabled(). This prevents a PHP warning, fixes the logic, and considers wp_is_file_mod_allowed( 'automatic_updater' ) when determining the UI state.
Props jamesros161, pbiron, audrasjb, azaozz.
Fixes #51827.

git-svn-id: https://develop.svn.wordpress.org/trunk@49677 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-22 13:01:46 +00:00
Sergey Biryukov
6511b5817f Site Health: Check if $core_updates is an array before iterating on it.
This avoids a PHP warning if `get_core_updates()` returns `false`.

Props paulschreiber.
Fixes #51818.

git-svn-id: https://develop.svn.wordpress.org/trunk@49676 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-21 14:37:44 +00:00
Sergey Biryukov
b304faf343 Docs: Add missing @since tags for WP_Upgrader_Skin methods.
See #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@49675 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-21 12:06:34 +00:00
ryelle
23a8d5bcb2 Help/About: Clarify accessibility features.
* Captions are uploaded in the block editor, and not created in the editor.
* Avoid making an invalid claim of WCAG 2.1 conformance or trivialize the efforts still required to build an accessible and compliant site.

Follow-up to [49640].
Props joedolson.
See #51415.



git-svn-id: https://develop.svn.wordpress.org/trunk@49674 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-21 00:11:48 +00:00
Sergey Biryukov
4f28c68eb6 Docs: Correct $fire_after_hooks parameter name in @since tags.
Follow-up to [49172], [49173].

See #45114.

git-svn-id: https://develop.svn.wordpress.org/trunk@49673 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-20 11:56:08 +00:00
John Blackbourn
a47e8924b0 Docs: Document parameters that accept an array of integers using typed array notation.
While many of these parameters also technically accept an array of numerical strings, they are all ultimately cast to an array of integers. Documenting them as such assists developers in understanding the expected types.

See #51800, #41756


git-svn-id: https://develop.svn.wordpress.org/trunk@49672 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-19 18:22:02 +00:00
John Blackbourn
4eeb1c3acf Docs: Add missing @since tags.
See #51800


git-svn-id: https://develop.svn.wordpress.org/trunk@49671 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-19 17:52:52 +00:00
John Blackbourn
8b70c78281 Docs: Clarify and standardise on terminology used for rewrite rule endpoint masks.
See #51800


git-svn-id: https://develop.svn.wordpress.org/trunk@49670 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-19 16:13:54 +00:00
Sergey Biryukov
dff0ccf60a Docs: Use more specific type in parameter descriptions for in_category() and is_object_in_term().
This better aligns with `is_category()` and other conditional tags and their `WP_Query` counterpart methods.

Follow-up to [47402].

Props princeahmed.
Fixes #51825.

git-svn-id: https://develop.svn.wordpress.org/trunk@49669 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-19 15:18:28 +00:00
Sergey Biryukov
6884e1340d Coding Standards: Remove redundant isset() check in core_upgrade_preamble().
`isset()` can be safely used to check properties and subproperties of objects directly.

Follow-up to [49638].

See #51799.

git-svn-id: https://develop.svn.wordpress.org/trunk@49668 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-19 12:03:11 +00:00
Sergey Biryukov
72fe9fb127 Help/About: Correct placeholder for the accessibility statement feature plugin link.
Add missing translator comment.

Props audrasjb.
See #51415.

git-svn-id: https://develop.svn.wordpress.org/trunk@49651 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-18 15:49:31 +00:00
Sergey Biryukov
ab202d0148 Site Health: Add missing i18n for the App Passwords documentation link.
Follow-up to [49334].

Props tai.
Fixes #51815.

git-svn-id: https://develop.svn.wordpress.org/trunk@49650 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-18 15:02:07 +00:00
Andrew Ozz
874c87138e External Libraries: Update jQuery Migrate to 3.3.2.
Props mgol, azaozz.
Fixes #50564.

git-svn-id: https://develop.svn.wordpress.org/trunk@49649 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-18 09:04:26 +00:00
Helen Hou-Sandi
1f5ff2f169 Trunk is now really 5.7-alpha.
git-svn-id: https://develop.svn.wordpress.org/trunk@49645 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 22:55:11 +00:00
Helen Hou-Sandi
b73f9fc5f6 Trunk is now 5.7-alpha.
git-svn-id: https://develop.svn.wordpress.org/trunk@49644 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 22:50:57 +00:00
Helen Hou-Sandi
af54a08642 Post WordPress 5.6 RC 1 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@49642 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 22:37:48 +00:00
Helen Hou-Sandi
6d71eb492a WordPress 5.6 RC 1.
git-svn-id: https://develop.svn.wordpress.org/trunk@49641 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 21:59:53 +00:00
ryelle
efb664735f Help/About: WordPress 5.6 About Page.
This change introduces the new About page for WordPress 5.6.

Props elmastudio, ryelle, melchoyce, karmatosed, webcommsat, marybaum, meher, OGlekler, lmurillom, vimes1984, sabrinazeidan, nalininonstopnewsuk, afshanadiya, michelleames, bmcdede, yvettesonneveld, sarahricker, isabel_brison, helen, hellofromtonya, poena, chanthaboune, cbringmann, joedolson, sabernhardt, garrett-eclipse, audrasjb, marks99.
See #51415.



git-svn-id: https://develop.svn.wordpress.org/trunk@49640 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 21:32:16 +00:00
Sergey Biryukov
1a338a859b I18N: Avoid PHP notices for relative URLs in load_script_textdomain().
Props hellofromTonya, SeBsZ, archon810, nourma, justinahinon, SergeyBiryukov.
Fixes #49145.

git-svn-id: https://develop.svn.wordpress.org/trunk@49639 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 20:50:21 +00:00
Helen Hou-Sandi
8372bbdfa5 Upgrade/Install: Consistent layout and accurate messages on the update screen.
* Clarifies that if you are on maintenance/security auto-updates that you are only on those and therefore there are more options available.
* Adds a message if a version control system has been detected, as automatic updates are disabled in that case.
* Ensures only one heading between `update available`, `you are on a dev version`, and `you are on latest` appears at any given time, falling back to `you are on latest` if something strange happens with the returned update data.
* Removes some older strings related to auto-updates, which greatly simplifies the above.
* Strips the `core-major-auto-updates-saved` query arg from the URL, as it is related to a dismissible notice.

Props audrasjb, pbiron, helen.
Fixes #51742.


git-svn-id: https://develop.svn.wordpress.org/trunk@49638 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 20:26:32 +00:00