This JSON decoding is no longer needed since the commit message was converted to a plain string in r59920. The commit message can now be treated as a plain text string in an environment variable throughout the workflow.
Props johnbillion.
See #62221
git-svn-id: https://develop.svn.wordpress.org/trunk@59922 602fd350-edb4-49c9-b593-d223f7449a82
Don't set `aria-expanded` and `aria-haspopup` attributes outside of the primary menu. Secondary menus (social and footer) are set to a depth of 1, and have nothing to expand or popup.
Props bschneidewind, joedolson, mikinc860.
Fixes#62896.
git-svn-id: https://develop.svn.wordpress.org/trunk@59921 602fd350-edb4-49c9-b593-d223f7449a82
This escaping is no longer needed since all instances of inline expressions were removed from workflows in r59679. The commit message can now be treated as a plain text string in an environment variable throughout the workflow.
Props johnbillion, swissspidy
Unprops johnblackbourn
See #62221
git-svn-id: https://develop.svn.wordpress.org/trunk@59920 602fd350-edb4-49c9-b593-d223f7449a82
Modifies `WP_Query::the_post()` to ensure the entire global post object is populated regardless of the `fields` parameter initially set by the developer.
In secondary loops, this ensures that `get_the_content()` and other getter functions operate as documented when called without a post ID and return the appropriate data for the global post object.
This introduces consistency when starting the loop and the `fields` parameter is set to `id=>parent` to the behaviour when set to either `all` or `ids`.
There is no change to the `WP_Query::$posts` parameter nor when a query is made without starting the secondary loop, ie without calling `WP_Query::the_post()`.
Props juzar, mukesh27, oglekler, peterwilsoncc, sirlouen, joemcgill.
Fixes#56992.
git-svn-id: https://develop.svn.wordpress.org/trunk@59919 602fd350-edb4-49c9-b593-d223f7449a82
Set `aria-expanded` to true when automatically expanding active child menus in the primary menu. Add `aria-controls` to explicitly define controlled content in menus.
Props bschneidewind, joedolson, dhruvang21, pooja1210, shailu25.
Fixes#62936.
git-svn-id: https://develop.svn.wordpress.org/trunk@59916 602fd350-edb4-49c9-b593-d223f7449a82
Includes type casting `$comment_approved` to an integer to avoid breaking WP-CLI tests, since the value can be passed as a string.
Follow-up to [3104], [3193], [3887], [59903].
Props swissspidy.
See #62279.
git-svn-id: https://develop.svn.wordpress.org/trunk@59915 602fd350-edb4-49c9-b593-d223f7449a82
Move the skip link to the top of the body content, so it is the first focusable item on the page.
Props joedolson, abcd95, manojmaharrshi, vganavda, shailu25.
Fixes#62969.
git-svn-id: https://develop.svn.wordpress.org/trunk@59914 602fd350-edb4-49c9-b593-d223f7449a82
Move the skip link to the top of the body content, so it is the first focusable item on the page.
Props joedolson, sabernhardt, abcd95, manojmaharrshi, shailu25, audrasjb, krupajnanda.
Fixes#62968.
git-svn-id: https://develop.svn.wordpress.org/trunk@59913 602fd350-edb4-49c9-b593-d223f7449a82
Move the skip link to the top of the body content, so it is the first focusable item on the page.
Props joedolson, sabernhardt, abcd95, vgnavada, shailu25.
Fixes#62892.
git-svn-id: https://develop.svn.wordpress.org/trunk@59912 602fd350-edb4-49c9-b593-d223f7449a82
Add `aria-expanded` and `aria-controls` attributes to the Twenty Twelve mobile menu toggle.
Props bschneidewind, joedolson, sabernhardt, umeshsinghin.
Fixes#62892.
git-svn-id: https://develop.svn.wordpress.org/trunk@59911 602fd350-edb4-49c9-b593-d223f7449a82
This changeset replaces the "Edit Site" link in the admin bar to point to the top level screen of the Site Editor, instead of opening the current template.
Merges Gutenberg changeset: WordPress/gutenberg#69271
Props mosne, poena, audrasjb, shailu25.
Fixes#62368.
git-svn-id: https://develop.svn.wordpress.org/trunk@59910 602fd350-edb4-49c9-b593-d223f7449a82
This changeset updates the `get_calendar()` function to allow post type filtering via the `$post_type` parameter, with backard compatibility for previous params. It also updates the related `get_calendar_args` and `get_calendar` hooks accordingly.
Props sebastianpisula, swissspidy, dwainm, moxie, sukhendu2002, audrasjb, mukesh27.
Fixes#34093.
git-svn-id: https://develop.svn.wordpress.org/trunk@59908 602fd350-edb4-49c9-b593-d223f7449a82
Mark links that point to the current URL in bundled theme headers with `aria-current="page"` to inform screen reader users that this link is the current page.
Changes to Twenty Ten through Twenty Twenty add `aria-current` and `rel="home"` where appropriate, Twenty Twenty One only adds `rel="home"`.
Props bschneidewind, joedolson, hiabhaykulkarni, sabernhardt.
Fixes#62895.
git-svn-id: https://develop.svn.wordpress.org/trunk@59907 602fd350-edb4-49c9-b593-d223f7449a82
This modifies the submenu for the Site Editor which previously linked directly to the Patterns page after [58278] to support accessing the Stylebook in classic themes via a new "Design" link. Currently, any classic themes that have either added support for `editor-styles` or have a theme.json file will automatically see this new link in the admin menu.
Props isabel_brison, poena, wildworks, mamaduka, karmatosed, joemcgill.
Fixes#62509.
git-svn-id: https://develop.svn.wordpress.org/trunk@59905 602fd350-edb4-49c9-b593-d223f7449a82
This reduces the hash length from 32 bytes to 30 so the overall length of an activation key after encoding, prefixing, and prepending a timestamp fits into 60 bytes.
A key is also introduced for domain separation. This doesn't affect the output length.
Props dd32, paragoninitiativeenterprises, peterwilsoncc, johnbillion
Fixes#21022
git-svn-id: https://develop.svn.wordpress.org/trunk@59904 602fd350-edb4-49c9-b593-d223f7449a82
`$comment_approved` can be both a string or an integer, so this change had unintended consequences such as breaking WP-CLI tests.
See #62279.
git-svn-id: https://develop.svn.wordpress.org/trunk@59903 602fd350-edb4-49c9-b593-d223f7449a82
Enable `download_url()` to fetch and verify file types if the URL does not contain a file extension. This allows URL downloads to handle media endpoints like istockphoto.com that use file IDs and formatting arguments to deliver images.
Props masteradhoc, mitogh, joedolson, hellofromTonya, antpb, audrasjb, navi161, dmsnell.
Fixes#54738.
git-svn-id: https://develop.svn.wordpress.org/trunk@59902 602fd350-edb4-49c9-b593-d223f7449a82
Adds a check of the `editable_roles` filter when adding users to a multisite sub-site to ensure the role is permitted to be used on the network. If the role is blocked by the filter, attempting to add the role will trigger a `wp_die()` similar to attempting to add a user with the role on a single site install.
Props eartboard, hareesh-pillai, ideag, sukhendu2002, spacedmonkey, thomaswm.
Fixes#43251.
git-svn-id: https://develop.svn.wordpress.org/trunk@59901 602fd350-edb4-49c9-b593-d223f7449a82
Introduces the filter `pre_count_many_users_posts()` to allow developers to bypass the function in favour of either avoiding counts or their own counting functionality.
Props audrasjb, ethitter, jigar-bhanushali, jorbin.
Fixes#63004.
git-svn-id: https://develop.svn.wordpress.org/trunk@59900 602fd350-edb4-49c9-b593-d223f7449a82
By default, the REST API responds to HEAD rqeuests by calling the GET handler and omitting the body from the response. While convenient, this ends up performing needless work that slows down the API response time.
This commit adjusts the Core controllers to specifically handle HEAD requests by not preparing the response body.
Fixes#56481.
Props antonvlasenko, janusdev, ironprogrammer, swissspidy, spacedmonkey, mukesh27, mamaduka, timothyblynjacobs.
git-svn-id: https://develop.svn.wordpress.org/trunk@59899 602fd350-edb4-49c9-b593-d223f7449a82
Use the empty string argument in `$editor->save()` added in [59855] to simplify the code used to prevent image format conversions from getting a suffix appended to their file names.
Props joedolson, audrasjb, azaozz.
See #62385.
Fixes#63003.
git-svn-id: https://develop.svn.wordpress.org/trunk@59897 602fd350-edb4-49c9-b593-d223f7449a82
This reinstates the ability for a user to log in to an account where the password is hashed using MD5. This means that the ability to reset a password directly in the database using an SQL query or a database administration tool will be retained without the need to implement or integrate with bcrypt or phpass.
A password hashed with MD5 will get upgraded to bcrypt at the point where a user successfully logs in, just as is the case with a phpass hash.
Props audrasjb, aaronjorbin, johnbillion, david-innes, benniledl.
See #21022.
git-svn-id: https://develop.svn.wordpress.org/trunk@59893 602fd350-edb4-49c9-b593-d223f7449a82
This adds support for passing a `search_columns` argument to the user controller so that users with `list_users` caps can specify which field is being searched.
Props youknowriad, joemcgill, ntsekouras, mreishus, mamaduka.
Fixes 62596.
git-svn-id: https://develop.svn.wordpress.org/trunk@59892 602fd350-edb4-49c9-b593-d223f7449a82
This ticket replaces the issue not resolved in time before the release of the theme. This now takes the feedback of translators and iterates on that.
Props poena, desrosj, hameem1102, burakkaptan, jorbin, prathamesh24, audrasjb.
Fixes#62482.
git-svn-id: https://develop.svn.wordpress.org/trunk@59891 602fd350-edb4-49c9-b593-d223f7449a82
Provide a bit of information about robots.txt to help people understand if the file is generated by WordPress.
Props zodiac1978, audrasjb, joostdevalk, jorbin.
Fixes#56595.
git-svn-id: https://develop.svn.wordpress.org/trunk@59890 602fd350-edb4-49c9-b593-d223f7449a82
This reverts [59883] as the addition of the youtube-nocookie domain to the embed providers list wasn't done correctly.
Unprops audrasjb. Props otto42, swissspidy.
See #44610.
git-svn-id: https://develop.svn.wordpress.org/trunk@59888 602fd350-edb4-49c9-b593-d223f7449a82
Exit gracefully for requests with a malformed `rest_route` query string parameter, ie anything that is not a string.
This prevents fatal errors from occurring with URLs such as `example.com/?rest_route[]=array` as the URL is user input so logging the data provides no benefit to developers as they are unable to resolve the issue.
Props geekofshire, dd32, timothyblynjacobs.
Fixes#62932.
git-svn-id: https://develop.svn.wordpress.org/trunk@59886 602fd350-edb4-49c9-b593-d223f7449a82
This update updates the `page` post-type definition and sets `template-locked` as the new default rendering mode for the block editor.
Props mamaduka, wildworks, joemcgill, tyb, swissspidy, audrasjb.
Fixes#61811.
git-svn-id: https://develop.svn.wordpress.org/trunk@59885 602fd350-edb4-49c9-b593-d223f7449a82
This updates the header area of the theme and plugin file editor screen to make them more consistent. It now displays the name of theme or plugin, the active or inactive state, and the path to the file that is selected.
Props karmatosed, poena, audrasjb.
Fixes#41142.
git-svn-id: https://develop.svn.wordpress.org/trunk@59884 602fd350-edb4-49c9-b593-d223f7449a82
The accepted value is `WP_Comment::$comment_approved`, which is documented as a string.
Follow-up to [38832], [33891], [39015], [59805], [59871].
See #62281.
git-svn-id: https://develop.svn.wordpress.org/trunk@59882 602fd350-edb4-49c9-b593-d223f7449a82
This reverts the full-white background update that was committed in [59705] to give it more time for testing and feedback. Let's revisit this proposal later and revert to the good ol’ grey background.
Props afercia, richtabor, karmatosed, johnjamesjacoby, johnbillion, sabernhardt,
See #62831.
git-svn-id: https://develop.svn.wordpress.org/trunk@59879 602fd350-edb4-49c9-b593-d223f7449a82
This changeset introduces the `manage_users-network_custom_column` filter that fires for each custom column in the Network Users list table. This is an override hook for `manage_users_custom_column` which was already filtering each custom column in all Users list tables.
Props lenasterg, realloc, audrasjb.
Fixes#43318.
git-svn-id: https://develop.svn.wordpress.org/trunk@59878 602fd350-edb4-49c9-b593-d223f7449a82
This changeset adds a conditional to show the comments bulk actions dropdown only when the current user has `moderate_comments` capability.
Props snicco, iflairwebtechnologies, shanemuir, audrasjb.
Fixes#59440.
git-svn-id: https://develop.svn.wordpress.org/trunk@59877 602fd350-edb4-49c9-b593-d223f7449a82
This reverts the lighter font-weight update that was committed in [59709] to give it more time for testing and feedback.
Fixes#62865.
git-svn-id: https://develop.svn.wordpress.org/trunk@59876 602fd350-edb4-49c9-b593-d223f7449a82
This changeset adjusts the padding for submenu link groups in the admin menu, ensuring consistent top and bottom padding.
Follow-up to [26072].
Props trushaamin, modi2918, hellofromTonya, peterwilsoncc, sabernhardt, im3dabasia1, audrasjb, karmatosed, dhrumilk.
Fixes#61689.
git-svn-id: https://develop.svn.wordpress.org/trunk@59875 602fd350-edb4-49c9-b593-d223f7449a82
[59132] introduced the `wp_register_block_metadata_collection()` function and underlying `WP_Block_Metadata_Registry` class to allow central registration of a block metadata PHP manifest file in favor of parsing individual JSON files. While this improves performance, it only increases the amount of APIs and code that plugin developers need to use to register their block types properly.
This changeset introduces a new function `wp_register_block_types_from_metadata_collection()` that improves the developer experience of registering block types from a single source, by handling it in only a single function call.
Developers that already use a generated block metadata PHP manifest file (e.g. via the `wp-scripts build-blocks-manifest` tool) can now call `wp_register_block_types_from_metadata_collection()` with that file to automatically register all block types from that block metadata collection. Individual calls to `register_block_type()` or `register_block_type_from_metadata()` are no longer necessary when the new function is used.
Props flixos90, gziolo, joemcgill, mreishus, mukesh27, swissspidy.
Fixes#62267.
See #62002.
git-svn-id: https://develop.svn.wordpress.org/trunk@59874 602fd350-edb4-49c9-b593-d223f7449a82
The test suite when run on PHP 8.4 with MySQL is currently taking 2-3x the amount of time to run. The jobs are regularly hitting the conservative `20` minute time out configured to prevent runaway jobs.
While this performance regression is investigated, this increases the timeout value to `30` to avoid running into unnecessary failures now that the issue has been discovered.
Props johnbillion.
See #63026.
git-svn-id: https://develop.svn.wordpress.org/trunk@59873 602fd350-edb4-49c9-b593-d223f7449a82
