39189 Commits

Author SHA1 Message Date
Gary Pendergast
bef9b9138d Admin: Introduce the Site Health screens.
The Site Health tool serves two purposes:
- Provide site owners with information to improve the performance, reliability, and security of their site.
- Collect comprehensive debug information about the site.

By encouraging site owners to maintain their site and adhere to modern best practices, we ultimately improve the software hygeine of both the WordPress ecosystem, and the open internet as a whole.

Props Clorith, hedgefield, melchoyce, xkon, karmatosed, jordesign, earnjam, ianbelanger, wpscholar, desrosj, pedromendonca, peterbooker, jcastaneda, garyj, soean, pento, timothyblynjacobs, zodiac1978, dgroddick, garrett-eclipse, netweb, tobifjellner, pixolin, afercia, joedolson, birgire.
See #46573.


git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44984 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-23 03:17:14 +00:00
Felix Arntz
c29015f3b3 Multisite: Do not prime site meta caches unless necessary.
Merges [44926] to the 5.1 branch.

Props spacedmonkey.
Fixes #46357. See #46167.


git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44928 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-18 16:20:53 +00:00
Felix Arntz
de65eacf12 Multisite: Ensure site meta caches are not primed unless the wp_blogmeta table is available.
Prior to this change, querying sites early in the bootstrap process could potentially cause a fatal error, since at that stage the filter to bail on updating site meta cache if the respective database table has not been installed yet is not hooked in yet. This changeset forces the filter to be added if that is not already the case.

Merges [44925] to the 5.1 branch.

Props spacedmonkey.
Fixes #46167.


git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44927 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-18 16:19:27 +00:00
Gary Pendergast
688b855fd3 WordPress 5.1.1
git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44860 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-13 00:16:04 +00:00
Sergey Biryukov
8df47ff01f PHPCS: Fix errors introduced in [44833].
Merges [44858] to the 5.1 branch.

git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44859 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-12 22:56:44 +00:00
Sergey Biryukov
67a2a6feb9 Comments: Improve comment content filtering.
Merges [44842] to the 5.1 branch.

git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44843 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-12 22:31:55 +00:00
Sergey Biryukov
7206b554d9 Formatting: Improve rel="nofollow" handling in comments.
Merges [44833] to the 5.1 branch.

git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44834 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-12 22:15:37 +00:00
Aaron Jorbin
6d22ce686a General: Add missing @since annotation for wp_get_direct_php_update_url().
Backports [44829] to 5.1 branch. Dev-reviewed by desrosj and SergeyBiryukov.

Missed in [44815].

Props birgire.
See #46074.



git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44831 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-12 17:12:22 +00:00
Gary Pendergast
68fa2f44cf WordPress 5.1.1 RC1 post release version bump.
git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44820 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-08 00:29:18 +00:00
Gary Pendergast
3c91f92aba WordPress 5.1.1 RC1.
git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44819 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-08 00:12:51 +00:00
Jonathan Desrosiers
057d0fbff1 Widgets: Remove change event when editing a Custom HTML widget.
The `change` event was previously required to ensure that the Customizer picked detected changes to the widget's content and synced them to the preview. In the current state, though, the `trigger( 'change' )` is no longer required and is causing issues with the widget's “Done” and “Save” buttons.

Merges [44816] to the 5.1 branch.

Fixes #46335.
Props audrasjb, afercia, westonruter.

git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44817 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-07 22:34:03 +00:00
Jonathan Desrosiers
85076ad9f9 General: Add a way to specify a direct link for a user to update PHP.
A direct URL to where a user can update PHP for their website can now be specified in one of two ways:

- Defining the `WP_DIRECT_UPDATE_PHP_URL` environment variable.
- Returning a URL to the `wp_direct_php_update_url` filter.

When a URL is specified, an additional “Update PHP” button will be displayed at the bottom of the Core dashboard widget informing administrators that their site is running an outdated version of PHP (see [42832]).

Merges [44814] to the 5.1 branch.

Fixes #46074.
Props afragen, desrosj, lukecarbis.

git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44815 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-07 21:36:22 +00:00
Jeremy Felt
cd010b40fe Multisite: Ensure wpmu_new_blog hook receives expected data in $meta.
Restores `public`, `archived`, `mature`, `spam`, `deleted`, `lang_id`, and `WPLANG` to the `$meta` data passed to `wpmu_new_blog`. This hook was deprecated in 5.1.0, but code using it still relies on this data.

Props davidbinda, pbiron.
Merges [44805] and [44806] to the 5.1 branch.
Fixes #46351.


git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44807 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-07 04:36:36 +00:00
Sergey Biryukov
9042c9d9b7 Menus: After [42857], apply background to the correct elements on Menus screen.
Props audrasjb, afercia, mukesh27, garrett-eclipse.
Merges [44801] to the 5.1 branch.
Fixes #46368.

git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44802 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-05 21:02:47 +00:00
Sergey Biryukov
b57deec916 Networks and Sites: Check the result of get_site() in wp_insert_site().
Props davidbinda, vanyukov, lukecarbis.
Merges [44799] to the 5.1 branch.
Fixes #46300.

git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44800 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-05 20:36:28 +00:00
Sergey Biryukov
0b63929b95 I18N: Remove trailing spaces from translatable strings introduced in [43436].
Props dimadin.
Merges [44797] to the 5.1 branch.
Fixes #46277.

git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44798 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-05 20:29:19 +00:00
Peter Wilson
8f8b1c9237 Comments: Allow for comment-reply.js to be loaded in the HTML header.
Allows for themes or plugins setting the comment-reply JavaScript as a dependency of an HTML header script. This in turn causes `comment-reply.js` to be loaded early, requiring execution to be delayed.

Props pento, peterwilsoncc, jorbin for feedback.
Merges [44794] to the 5.1 branch.
Fixes #46280.



git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44795 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-05 02:13:25 +00:00
Felix Arntz
11b3b4bca8 General: Introduce wp_is_php_version_acceptable filter to make the check for triggering PHP version warnings stricter.
The filter is only run if the wordpress.org API considers the PHP version acceptable. This ensures that other plugins or hosting providers can only make this check stricter, but not loosen it.

Merges [44788] to the 5.1 branch.

Props j-falk, mikeschroder.
Fixes #46065.


git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44789 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-04 21:22:30 +00:00
Jonathan Desrosiers
c6cd9f81b8 Build: Minify images
After `grunt-contrib-imagemin` was upgraded in WordPress 5.0, the `grunt precommit:image` task results in further minifications to `loading.gif`.

Merges [44768] to the 5.1 branch.

Fixes #46295.

git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44783 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-28 21:55:15 +00:00
Jonathan Desrosiers
984f2b6aae Help/About: Fix mismatched opening/closing tags.
The 5.1 About page contains some invalid HTML markup.

Props bulletdigital.

Merges [44769] to the 5.1 branch.

Fixes #46319.

git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44770 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-26 16:23:45 +00:00
Gary Pendergast
ae3d09e136 Bump version to 5.1.1-alpha.
git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44766 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-21 22:54:01 +00:00
Gary Pendergast
eb6a46184a WordPress 5.1! 🕺🏻
git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44764 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-21 22:06:06 +00:00
Aaron Jorbin
13feabce1d Script Loader: Load fakejshint as jshint due to "good and evil".
Backports [44762] from trunk to 5.1. Devreviewed by Pento.

Originally fixed in [42547]. Broken in [44163]. We've been here before. I recognize that tree.

Fixes #46299



git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44763 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-21 21:21:24 +00:00
Gary Pendergast
7a13795e40 Upgrades: Update $_old_files for WordPress 5.1.
`wp-includes/random_compat/random_bytes_openssl.php` was removed in [43130], this commit updates `$_old_files` to match.

Merges [44760] to the 5.1 branch.

Fixes #46284.



git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44761 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-21 04:36:10 +00:00
Gary Pendergast
aeee7aca2b Post WordPress 5.1 RC2 version bump.
git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44754 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-19 02:57:05 +00:00
Gary Pendergast
f7fc6a541f WordPress 5.1 RC2.
git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44753 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-19 02:43:54 +00:00
Gary Pendergast
3f8c9c81c3 Admin: Update the About page design to match mockups.
This commit also moves the images to s.w.org, removes the old "Gutenberg has been deactivated" warning, as well as removing some old JS from About pages of years gone past.

Merges [44749] to the 5.1 branch.

Props melchoyce, ryelle, paaljoachim, karmatosed, pento.
Fixes #46161.




git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44752 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-19 02:01:27 +00:00
Gary Pendergast
bd559de86e Comments: Fix backward compatibility regressions in comment reply JavaScript.
Adds a `MutationObserver` to `comment-reply.js` to allow for lazy-loaded comments to continue working without the need to re-initialize the comment form.

Merges [44748] to the 5.1 branch.

Fixes #46260.


git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44751 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-19 02:00:21 +00:00
Gary Pendergast
67384779e5 Accessibility: Fix a regression in the old media modal pagination links.
[43019] improved the table pagination link styling, but introduced a regression in the old media dialog.

Merges [44747] to the 5.1 branch.

Props afercia, joneiseman.
Fixes #41858.


git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44750 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-19 01:58:51 +00:00
Peter Wilson
ccb5b50f1b Build: Fix formatting issues introduced in [44740].
Merges [44744] to the 5.1 branch.
See #46218.



git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44745 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-14 00:47:21 +00:00
Peter Wilson
48e25b3cd4 Twenty Nineteen: Revert [44739] from the 5.1 branch.
Reverts block quote style changes intended for a later release.

See #46239.



git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44743 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-14 00:25:41 +00:00
Peter Wilson
5546201c9f Branch 5.1.
git-svn-id: https://develop.svn.wordpress.org/branches/5.1@44741 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-14 00:09:47 +00:00
Peter Wilson
3ec3100195 Build: Remove source map from jquery.form.min.js.
Minimize jquery.form.js as part of build process to remove the source map reference. 

Modify source map tests to include all JavaScript files rather than testing Backbone and jQuery only.

Props pento.
Fixes #46218.



git-svn-id: https://develop.svn.wordpress.org/trunk@44740 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-14 00:06:39 +00:00
laurelfulford
e7e42efe18 Twenty Nineteen: Update the quote block styles.
Update the theme's quote block border styles, so they will work better with the updated styles for the quote block, coming in Gutenberg 5.2.

Props @kjellr.
Fixes #46239.



git-svn-id: https://develop.svn.wordpress.org/trunk@44739 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-13 18:39:59 +00:00
Dominik Schilling (ocean90)
41d644ca52 Upgrade/Install: Update character count for the $table_prefix config line after [43650] and [42343].
Fixes #46220.

git-svn-id: https://develop.svn.wordpress.org/trunk@44738 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-12 16:51:12 +00:00
Gary Pendergast
83275aab4c Post WordPress 5.1 RC1 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@44737 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-08 02:22:08 +00:00
Gary Pendergast
508846a721 WordPress 5.1 RC1.
git-svn-id: https://develop.svn.wordpress.org/trunk@44736 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-08 02:13:42 +00:00
Peter Wilson
4b1885c836 Admin: Improve logic of PHP version check on about page.
Props noisysocks, peterwilsoncc.
See #46161.



git-svn-id: https://develop.svn.wordpress.org/trunk@44735 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-08 01:52:17 +00:00
Gary Pendergast
985958f870 Admin: Fix code formatting issues in the About page.
See #46161.



git-svn-id: https://develop.svn.wordpress.org/trunk@44734 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-08 01:27:39 +00:00
Gary Pendergast
ab1bf7b3da Admin: Initial version of the WordPress 5.1 About page.
This includes the final strings, the design will continue to iterate.

Props mcsf, noisysocks, melchoyce, azaozz, afragen, JeffPaul, peterwilsoncc, andreamiddleton.
See #46161.



git-svn-id: https://develop.svn.wordpress.org/trunk@44733 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-08 01:24:57 +00:00
Peter Wilson
ef74cf5c56 Install/upgrade: Remove Gutenberg plugin deactivation from upgrade process.
The Gutenberg plugin will not be deactivated on sites upgrading to WordPress 5.1. This deprecates the `upgrade_500_was_gutenberg_active` option and the `upgrade_500()` function as they are no longer required.

Props peterwilsoncc.
Fixes #46029.



git-svn-id: https://develop.svn.wordpress.org/trunk@44732 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-08 00:15:54 +00:00
Gary Pendergast
d2f41560d3 Formatting: Loosen the type checking in _sanitize_text_fields().
[44618] added strict type checking to `_sanitize_text_fields()`, which has caused some compat issues with plugins.

We can loosen the type checking to only reject objects and arrays, and cast other types to string.

Props Nick_theGeek, pento.
Fixes #41450.



git-svn-id: https://develop.svn.wordpress.org/trunk@44731 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-07 23:34:22 +00:00
laurelfulford
2a49b5c469 Default Themes: Bump the version numbers and release dates.
Update the theme versions and release dates for the default themes, in time for WordPress 5.1.

The POT files for Twenty Eleven and Twenty Ten have also been updated.

Fixes #46070.



git-svn-id: https://develop.svn.wordpress.org/trunk@44730 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-07 23:22:04 +00:00
Riad Benguella
98bee9bf08 Block Editor: Update WordPress Packages to solve PHP 5.2.2 parser incompatibility.
Updated:

 - @wordpress/block-library@2.2.16
 - @wordpress/block-serialization-default-parser@2.0.5
 - @wordpress/blocks@6.0.7
 - @wordpress/edit-post@3.1.11
 - @wordpress/editor@9.0.11
 - @wordpress/format-library@1.2.14

Props pento.
Fixes #46200.


git-svn-id: https://develop.svn.wordpress.org/trunk@44729 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-07 09:01:10 +00:00
Gary Pendergast
107453024f Build: Update package.json dependencies to match Gutenberg.
Props wpscholar, azaozz, gziolo.
Fixes #46039.



git-svn-id: https://develop.svn.wordpress.org/trunk@44728 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-07 06:26:48 +00:00
Gary Pendergast
6b2c62eee2 Multisite: After creating a new blog, ensure the blog cache is correctly cleaned up.
Props david.binda, spacedmonkey.
Fixes #46125.



git-svn-id: https://develop.svn.wordpress.org/trunk@44727 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-07 06:03:32 +00:00
Gary Pendergast
17a022e3d0 Admin: Re-add some validation from [44048] that was accidentally removed in [44165].
Props david.binda.
See #45037.



git-svn-id: https://develop.svn.wordpress.org/trunk@44726 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-07 04:11:23 +00:00
Jonathan Desrosiers
666d713c1b Themes: Revert returning the value of locate_template() in functions that call it.
Because the names of the `get_header()`, `get_footer()`, `get_sidebar()`, and `get_template_part()` functions indicate that a value is returned, some plugins and themes already have `echo get_template_part()` in their codebase. Adding a return value to these functions using the approach in [44678] will cause the two unintended side effects of unexpected content being sent to the browser, and accidental path disclosure.

Reverts [44678].

Props davidbinda.
See #40969.

git-svn-id: https://develop.svn.wordpress.org/trunk@44725 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-06 18:36:49 +00:00
Andrew Ozz
5f38ce3d98 TinyMCE: fix color of highlighted drop-down menu items in Classic Block.
Fixes #46164.

git-svn-id: https://develop.svn.wordpress.org/trunk@44724 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-05 17:46:25 +00:00
Sergey Biryukov
3e19129dc9 Build/Test Tools: Display a message about currently supported PHPUnit branch to avoid fatal errors on later versions.
See #46149.

git-svn-id: https://develop.svn.wordpress.org/trunk@44723 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-03 22:40:56 +00:00