43545 Commits

Author SHA1 Message Date
Sergey Biryukov
ccb4474b4a Docs: Fix typo in pre_term_link filter description.
See #52628.

git-svn-id: https://develop.svn.wordpress.org/trunk@50562 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-22 19:17:45 +00:00
Sergey Biryukov
4cc3f127df Coding Standards: Move some translator comments to the correct place.
Follow-up to [48172].

See #52627.

git-svn-id: https://develop.svn.wordpress.org/trunk@50561 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-21 13:11:11 +00:00
Sergey Biryukov
89e6e2d31e Coding Standards: Add missing semicolon to some endif keywords.
See #52627.

git-svn-id: https://develop.svn.wordpress.org/trunk@50560 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-21 13:03:14 +00:00
Sergey Biryukov
133b6a9f91 Tests: Move the get_current_commenter() method next to the test it's used in.
Follow-up to [48133].

See #52625.

git-svn-id: https://develop.svn.wordpress.org/trunk@50559 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-21 12:53:24 +00:00
Sergey Biryukov
05566e992d Coding Standards: Use strict comparison for return type checks in a few functions:
* `get_bookmark()`
* `get_comment()`
* `get_post()`
* `get_children()`
* `wp_get_recent_posts()`
* `wp_get_post_revision()`
* `wp_get_nav_menu_items()`

Follow-up to [45710] for `get_term()`, [48507] for `wpdb::get_row()` and `wpdb::get_results()`.

See #52627.

git-svn-id: https://develop.svn.wordpress.org/trunk@50558 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-21 12:39:25 +00:00
Sergey Biryukov
eea4f303a1 Coding Standards: Use strict comparison in wp-admin/includes/class-wp-upgrader.php.
See #52627.

git-svn-id: https://develop.svn.wordpress.org/trunk@50557 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-21 12:10:55 +00:00
Sergey Biryukov
f552384ebd Coding Standards: Add a space before / character in some self-closing HTML tags.
While this has no effect on the code, it fixes a minor inconsistency with the rest of core.

Props laxman-prajapati.
Fixes #52870.

git-svn-id: https://develop.svn.wordpress.org/trunk@50556 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-20 18:28:32 +00:00
Sergey Biryukov
b40cf64e6a I18N: Update list of continents and cities for the timezone selection.
Props wangql, mukesh27.
Fixes #52861.

git-svn-id: https://develop.svn.wordpress.org/trunk@50555 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-19 15:40:22 +00:00
Sergey Biryukov
97037b3ab8 I18N: Remove duplicate entries from the list of continents and cities.
Follow-up to [37554].

See #52861.

git-svn-id: https://develop.svn.wordpress.org/trunk@50554 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-19 15:19:12 +00:00
Jake Spurlock
140bd894d6 Media: Pass the appropriate reference into wp_getimagesize.
With changes that were introduced in [49889] the second parameter for getimagesize() function is expecting a a reference.

Previously, most calls did not pass the 2nd param, and as a result, we are getting unexpected results.

This was only a problem with applications that are using a custom stream wrapper, and the image contained EXIF data.

For more see:

* https://github.com/humanmade/S3-Uploads/issues/496
* https://github.com/aws/aws-sdk-php/issues/1923

Fixes #52826.
Props terriann, SergeyBiryukov, Mista-Flo, hellofromTonya, rinatkhaziev, whyisjake.



git-svn-id: https://develop.svn.wordpress.org/trunk@50552 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 23:59:12 +00:00
Kelly Choyce-Dwan
a6d69a3298 Pointers: Make pointer border darker to match arrow tip.
Props johnjamesjacoby, melchoyce, SergeyBiryukov.
Fixes #52670.



git-svn-id: https://develop.svn.wordpress.org/trunk@50551 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 23:24:04 +00:00
Peter Wilson
1710b4bdbc External libraries: Update generated script loader version hashes.
Update the generated file `src/wp-includes/assets/script-loader-packages.php` following the clipboard.js update in [50544].

See #52850.


git-svn-id: https://develop.svn.wordpress.org/trunk@50550 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 22:43:41 +00:00
Kelly Choyce-Dwan
e2bb839d08 Administration: Make focus states consistent in admin menu when collapsed.
When collapsed or on a small screen, these styles would override the color schemes, causing a dark background to appear regardless of the color scheme's settings. This change also uses `focus-within` to show or hide the menu item's arrow, consistent with how the arrow behaves on hover.

Props afercia, Bueltge.
Fixes #32579.



git-svn-id: https://develop.svn.wordpress.org/trunk@50549 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 21:42:12 +00:00
Jonathan Desrosiers
2111085dff Emoji: Update the Twemoji library to version 13.0.2.
This point release does not add any new Emoji and only slightly modifies 14 existing Emoji without changing their meanings.

Because of this, the same CDN location (currently `/images/core/emoji/13.0.1`) can be updated with the new versions and sites running WordPress 5.6 or higher will start using the updated versions once their cache expires.

See #52852.

git-svn-id: https://develop.svn.wordpress.org/trunk@50548 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 19:18:12 +00:00
Sergey Biryukov
e467e6867e External Libraries: Further fix jQuery deprecations in WordPress core.
Follow-up to [50001], [50270], [50367], [50383], [50410], [50420], [50429].

Props Clorith.
See #51812.

git-svn-id: https://develop.svn.wordpress.org/trunk@50547 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 18:59:34 +00:00
Jonathan Desrosiers
4af708c3b8 External Libraries: Update the jQuery Form library.
This updates the `jquery-form` library from version `4.2.1` to `4.3.0`.

A full list of changes can be found on GitHub: https://github.com/jquery-form/form/compare/v4.2.1...v4.3.0.

Fixes #52685.

git-svn-id: https://develop.svn.wordpress.org/trunk@50546 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 17:51:52 +00:00
Jonathan Desrosiers
b91fab0ddf Build/Test Tools: Update some devDependencies.
This updates a handful of dependencies to their latest versions.

- `qunit` from `2.14.0` to `2.14.1`.
- `uglify-js` from `3.13.0` to `3.13.1`.
- `wait-on` from `5.2.1` to `5.3.0`.

See #52624.

git-svn-id: https://develop.svn.wordpress.org/trunk@50545 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 17:47:01 +00:00
Jonathan Desrosiers
4d66791327 External Libraries: Update Clipboard.js library to version 2.0.8.
This updates the `clipboard` library from version `2.0.6` to `2.0.8`.

A full list of changes can be found on GitHub: https://github.com/zenorocha/clipboard.js/compare/v2.0.6...v2.0.8.

Fixes #52850.

git-svn-id: https://develop.svn.wordpress.org/trunk@50544 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 15:52:10 +00:00
Jonathan Desrosiers
4842f978a7 External Libraries: Update jQuery Color library to version 2.2.0.
This updates the `jquery-color` library from version `2.1.2` to `2.2.0`.

This also switches back to installing the dependency from NPM instead of GitHub. The maintainers have resumed publishing to NPM with the 2.2.0 release.

A full list of changes can be found on GitHub: https://github.com/jquery/jquery-color/compare/2.1.2...2.2.0.

Props hareesh-pillai, desrosj.
Fixes #51405.

git-svn-id: https://develop.svn.wordpress.org/trunk@50543 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 15:48:43 +00:00
Jonathan Desrosiers
afbcd1bd63 Build/Test Tools: Revert [50540].
The E2E workflow is failing after this change. Reverting to to investigate further.

Unprops desrosj.
See #52843.

git-svn-id: https://develop.svn.wordpress.org/trunk@50542 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 14:33:12 +00:00
Sergey Biryukov
3c85e60449 Coding Standards: Use strict comparison for JS fragment in some admin files.
Follow-up to [48083].

Props nayanchamp7, rnaby.
Fixes #52845, #41988.

git-svn-id: https://develop.svn.wordpress.org/trunk@50541 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 14:11:55 +00:00
Jonathan Desrosiers
6447fcc8a6 Build/Test Tools: Remove explicit puppeteer dependency.
This was added in [48177] to fix an issue where Puppeteer was not being installed correctly as a dependency of `@wordpress/wp-scripts`. This has been fixed, so this explicit dependency can be removed.

Props isabel_brison.
Fixes #52843.

git-svn-id: https://develop.svn.wordpress.org/trunk@50540 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-18 12:42:28 +00:00
Sergey Biryukov
3f7760b93e Docs: Correct formatting for the description of some register_post_type() parameters.
Props audrasjb.
Fixes #52836.

git-svn-id: https://develop.svn.wordpress.org/trunk@50538 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-17 17:31:19 +00:00
Sergey Biryukov
d984b548c8 Tests: Correct some newly introduced @covers tags.
Follow-up to [50289], [50344].

Props jrf.
See #39265.

git-svn-id: https://develop.svn.wordpress.org/trunk@50537 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-16 18:44:40 +00:00
Kelly Choyce-Dwan
1479f1e543 Help/About: Run image comparison script after all assets have loaded.
If the callback is called before the images are loaded, the comparison doesn't work. `wp.domReady` uses `DOMContentLoaded`, which does not guarantee that the images are loaded. This switches to use the `load` event, which waits for all resources to load.

Props vladytimy, joyously, sergeybiryukov.
Fixes #52758.



git-svn-id: https://develop.svn.wordpress.org/trunk@50535 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-15 19:49:50 +00:00
Sergey Biryukov
a33ee3511a Twenty Seventeen: Remove extra space around post editor.
The editor uses the full height of its container, so the added margins cause the visual editor to break out of the container. This removes the top & bottom margins, and makes the left & right margins consistent with the meta box area.

Follow-up to [50465].

Props joseeyoast, audrasjb.
Fixes #52816.

git-svn-id: https://develop.svn.wordpress.org/trunk@50534 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-15 13:24:24 +00:00
Sergey Biryukov
b22c4a1dce Coding Standards: Remove some extra whitespace in sanitize_comment_cookies().
See #52627.

git-svn-id: https://develop.svn.wordpress.org/trunk@50533 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-14 16:59:45 +00:00
Sergey Biryukov
1f993de977 Docs: Synchronize $category_name description in WP_Block_Pattern_Categories_Registry methods.
Follow-up to [48156].

See #52628.

git-svn-id: https://develop.svn.wordpress.org/trunk@50532 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-13 11:15:14 +00:00
Sergey Biryukov
72e10ec97b Docs: Correct DocBlock formatting for register_block_style_handle().
Follow-up to [48141].

See #52628.

git-svn-id: https://develop.svn.wordpress.org/trunk@50531 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-13 11:13:55 +00:00
Sergey Biryukov
a3dd4b7d56 Site Health: Use a singular string in dashboard widget if there is only one critical issue or recommendation.
Props Presskopp, hareesh-pillai.
Fixes #52521.

git-svn-id: https://develop.svn.wordpress.org/trunk@50530 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-13 10:57:27 +00:00
Sergey Biryukov
1446948f95 Docs: Add missing @since tags for item_link and item_link_description post type and taxonomy labels.
Follow-up to [50527].

See #52688.

git-svn-id: https://develop.svn.wordpress.org/trunk@50529 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-13 10:23:56 +00:00
David Baumwald
43443bdf15 Docs: Correct unregister_block_style @param for $block_name.
In `unregister_block_style`, the `$block_name` parameter was documented as an array.  This change corrects the type to `string`, as that's what is expected in `WP_Block_Styles_Registry->unregister`. 

Props kraftner.
Fixes #52795.

git-svn-id: https://develop.svn.wordpress.org/trunk@50528 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-12 20:03:44 +00:00
Greg Ziółkowski
380d0445e8 Editor: Make block type aware of variations
Currently block variations are only defined on the client. In some cases, creating block variations on the server can be very useful, especially when needed data is not exposed in the REST APIs.

Related to https://github.com/WordPress/gutenberg/pull/29095.

Props: gwwar, timothyblynjacobs.
Fixes: #52688.



git-svn-id: https://develop.svn.wordpress.org/trunk@50527 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-12 13:33:21 +00:00
Sergey Biryukov
6877f57f36 Accessibility: Administration: Use a darker color for post dates in the Activity and Quick Draft dashboard widgets.
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.

Follow-up to [50025].

Props sabernhardt, Otshelnik-Fm, audrasjb.
Fixes #52760.

git-svn-id: https://develop.svn.wordpress.org/trunk@50525 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-12 12:04:21 +00:00
Kelly Choyce-Dwan
cded2eb52a Help/About: Use absolute URLs for inline images on About pages.
This ensures the images are loaded correctly from both single site and network About pages.

Props TobiasBg, audrasjb.
Fixes #52743.



git-svn-id: https://develop.svn.wordpress.org/trunk@50523 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-11 21:36:55 +00:00
Sergey Biryukov
4fadd1f574 Coding Standards: Consistently format opendir() calls in get_plugins().
Props sabernhardt, subrataemfluence.
Fixes #44250.

git-svn-id: https://develop.svn.wordpress.org/trunk@50522 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-11 15:17:56 +00:00
Jonathan Desrosiers
e20b23d810 External Libraries: Update jQuery hoverIntent to version 1.10.1.
This updates the `jquery-hoverintent` dependency from 1.8.3 to 1.10.1.

For a full list of changes, see https://github.com/briancherne/jquery-hoverIntent/compare/v1.8.3...v1.10.1.

Fixes #52686.

git-svn-id: https://develop.svn.wordpress.org/trunk@50521 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-10 15:23:06 +00:00
Jonathan Desrosiers
9af2725b7c External Libraries: Update jQuery to version 3.6.0.
This updates the jQuery dependency from 3.5.1 to 3.6.0.

For a full list of changes, see https://github.com/jquery/jquery/compare/3.5.1...3.6.0.

Fixes #52707. See #51812.

git-svn-id: https://develop.svn.wordpress.org/trunk@50520 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-10 15:05:43 +00:00
Sergey Biryukov
5c7c0df15b Help/About: Correct the WebM video URL on About page.
Props mihdan, audrasjb.
Fixes #52756.

git-svn-id: https://develop.svn.wordpress.org/trunk@50518 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-10 10:26:33 +00:00
Peter Wilson
6d4739c51f Docs: Improve spelling in [50516].
Props jeremyfelt.
See #52628, #34564.


git-svn-id: https://develop.svn.wordpress.org/trunk@50517 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-09 23:20:24 +00:00
Peter Wilson
bc14aea75d Docs: Improve compatibility comment in WP_List_Table.
Improve comment explaining backward compatibility check for the primary column in `WP_List_Table::get_column_info()`.

Unprops helen, markjaquith.
See #52628, #34564.



git-svn-id: https://develop.svn.wordpress.org/trunk@50516 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-09 22:33:47 +00:00
Sergey Biryukov
5ae4c30a03 Classic Editor: Make sure word count is hidden if JavaScript is disabled.
Removing `display: block` from the element allows the `.hide-if-no-js` class to have the intended effect.

Follow-up to [34275].

Props sabernhardt, mukesh27.
Fixes #52662.

git-svn-id: https://develop.svn.wordpress.org/trunk@50512 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-09 10:11:21 +00:00
Jonathan Desrosiers
a6f9088a35 Update $_old_files for 5.7.
Follow up to [50066].

See #52334.

git-svn-id: https://develop.svn.wordpress.org/trunk@50510 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-08 18:28:35 +00:00
Jonathan Desrosiers
94e3c028e6 Bundled Themes: Bump theme version numbers for WordPres 5.7.
This updates all new default themes to new versions, which will be released shortly after WordPress 5.7. The new versions are:

- Twenty Twenty-One: 1.2
- Twenty Twenty: 1.7
- Twenty Nineteen: 2.0
- Twenty Seventeen: 2.6
- Twenty Sixteen: 2.4
- Twenty Fifteen: 2.9
- Twenty Fourteen: 3.1
- Twenty Thirteen: 3.3
- Twenty Twelve: 3.4
- Twenty Eleven: 3.7
- Twenty Ten: 3.3

Fixes #52704.

git-svn-id: https://develop.svn.wordpress.org/trunk@50507 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-08 14:15:53 +00:00
Sergey Biryukov
3d8a5fd839 Upgrade/Install: Display version number on the "Update now" button on WordPress Updates screen.
Additionally, adjust the "Update to latest nightly" button to include the major version number of the nightly build.

This makes the button labels more accurate and provides more clear understanding of what the update will be.

Follow-up to [49984].

Props afragen, pbiron, SergeyBiryukov.
Fixes #52513.

git-svn-id: https://develop.svn.wordpress.org/trunk@50506 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-08 11:29:37 +00:00
John Blackbourn
fa05e5e733 Docs: Add examples of possible names for various hooks whose name contains a dynamic portion.
This provides greater discoverability of such hooks in search results on the Code Reference site as well as increased clarity when reading the source.

See #50734, #52628


git-svn-id: https://develop.svn.wordpress.org/trunk@50505 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-07 12:30:38 +00:00
Sergey Biryukov
c3be472657 Docs: Add a @since note to wp_admin_bar_edit_menu() about the "View Post" link on Comments screen for a single post.
Follow-up to [47903].

Props sabernhardt, janak007, munyagu.
Fixes #42366.

git-svn-id: https://develop.svn.wordpress.org/trunk@50504 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-07 11:54:53 +00:00
John Blackbourn
26772874ce Build/Test Tools: Ensure the test_php_and_js_shortcode_attribute_regexes_match() test can run when testing using either the src or build directory.
Props alexstine, desrosj

See #51734


git-svn-id: https://develop.svn.wordpress.org/trunk@50501 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-05 15:26:22 +00:00
Sergey Biryukov
a577e4f21e XML-RPC: Pass an empty array to the xmlrpc_call action in methods that have no arguments.
This avoids an "Undefined variable" PHP notice in the `::mt_supportedMethods()` and `::mt_supportedTextFilters()` methods.

Follow-up to [50353].

Props dd32.
Fixes #52524.

git-svn-id: https://develop.svn.wordpress.org/trunk@50499 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-05 11:01:54 +00:00
Robert Anderson
0db14900ff Editor: Update @wordpress npm packages
Update @wordpress npm packages to the latest published versions. This includes
block editor bug fixes for WordPress 5.7 RC 3.

See #52718.


git-svn-id: https://develop.svn.wordpress.org/trunk@50496 602fd350-edb4-49c9-b593-d223f7449a82
2021-03-05 04:08:33 +00:00