50545 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Jonathan Desrosiers	d0e1e903fb	Tests: Fix explode() error for old DB versions on PHP 8.1+. ... On MySQL/MariaDB 5.5, the default value for `sql_mode` was a blank string. By itself this is not a problem. However, `$wpdb->get_var()` returns `null` when a variable has an empty value. One test method currently passes the result of `$wpdb->get_var( 'SELECT @@SESSION.sql_mode;' )` to `explode()` in order to reset the database to the pre-test method state. This causes an error when running PHP 8.1+, which deprecated the ability to pass `null` as a parameter of `explode()`. This edge case was undiscovered because these versions are not currently included in the automated testing matrix. See #62280. git-svn-id: https://develop.svn.wordpress.org/trunk@59583 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-07 15:40:19 +00:00
Felix Arntz	4a9a928dbc	Build/Test Tools: Fix incorrect commit time being reported to WordPress Code Vitals Dashboard. ... 2nd attempt of [59570]. Props mukesh27, ayeshrajans, swissspidy, desrosj. Fixes #62766. git-svn-id: https://develop.svn.wordpress.org/trunk@59582 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-06 21:19:51 +00:00
Kelly Choyce-Dwan	d49258b6f7	Help/About: Allow "See everything new" button to wrap ... On some screen sizes and languages, the "See everything new" button expands out of the content area. This change allows the button to wrap at all screen sizes, and updates the style of this button for wrapped text. Props franciscabusas22, sabernhardt, yogeshbhutka, sainathpoojary, im3dabasia1, audrasjb. Fixes #62380. git-svn-id: https://develop.svn.wordpress.org/trunk@59580 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-06 16:18:25 +00:00
Sergey Biryukov	375af8c6c6	Tests: Improve the test for the copyright year in bundled themes' readme.txt. ... This aims to catch entries like `(C) 2024 WordPress.org` in addition to `Copyright 2024 WordPress.org`. Includes converting the test to use a data provider, so that messages could be displayed for each individual theme. Follow-up to [46719], [59569]. See #62280. git-svn-id: https://develop.svn.wordpress.org/trunk@59579 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-06 15:58:50 +00:00
John Blackbourn	3a0717625f	Security: Enhance the wp_hash() function to support custom hashing algorithms. ... The default algorithm remains as md5, but this change allows any algorithm that's supported by `hash_hmac()` to be used instead. Props pushpenderindia, ayeshrajans, debarghyabanerjee, johnbillion Fixes #62005 git-svn-id: https://develop.svn.wordpress.org/trunk@59578 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-06 15:21:26 +00:00
Pascal Birchler	d6aa043853	Build/Test Tools: Expand performance tests setup. ... Run tests against Multisite (possible since [58097]) and on single post pages. Also improve cache flushes/resets between iterations. Props swissspidy, flixos90, desrosj, mukesh27. Fixes #62725. git-svn-id: https://develop.svn.wordpress.org/trunk@59577 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-06 10:29:09 +00:00
Peter Wilson	938d27abf2	Comments: Noindex pages containing unapproved comments. ... Adds a `noindex` directive to pages displaying a preview of an unapproved comment, ie pages with both an `approved` and `moderation-hash` parameter. This is to prevent the pages from appearing in search engines which can be the case if they ignore the canonical URL directive. Props peterwilsoncc, flixos90, joostdevalk. Fixes #62760. git-svn-id: https://develop.svn.wordpress.org/trunk@59576 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-05 22:12:25 +00:00
Sergey Biryukov	bb3f90f974	Coding Standards: Use strict comparison in get_pages(). ... Follow-up to [4180], [49108]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59575 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-05 22:10:39 +00:00
Sergey Biryukov	8f6f8098ef	Coding Standards: Replace loose comparison in wpmu_welcome_notification(). ... Follow-up to [https://mu.trac.wordpress.org/changeset/543 mu:543]. Props debarghyabanerjee, aristath, poena, afercia, SergeyBiryukov. Fixes #62283. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59574 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-04 10:25:13 +00:00
Sergey Biryukov	8da02a8665	Coding Standards: Use strict comparison in wpmu_validate_blog_signup(). ... Follow-up to [https://mu.trac.wordpress.org/changeset/8 mu:8], [https://mu.trac.wordpress.org/changeset/543 mu:543], [https://mu.trac.wordpress.org/changeset/550 mu:550], [https://mu.trac.wordpress.org/changeset/1364 mu:1364], [https://mu.trac.wordpress.org/changeset/1958 mu:1958], [12603], [32733]. Props debarghyabanerjee, aristath, poena, afercia, SergeyBiryukov. See #62279, #62283. git-svn-id: https://develop.svn.wordpress.org/trunk@59573 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-03 22:55:42 +00:00
Sergey Biryukov	016bbeca9b	Coding Standards: Use strict comparison in _reset_front_page_settings_for_post(). ... Follow-up to [6337], [25686]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59572 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-02 18:25:59 +00:00
Felix Arntz	7bd68355aa	Build/Test Tools: Revert [59570]. ... The fix did not work properly and is causing performance data for commits to not be sent at all. It is therefore reverted until a proper solution has been implemented. See #62766. git-svn-id: https://develop.svn.wordpress.org/trunk@59571 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-02 16:39:28 +00:00
Felix Arntz	5948245e57	Build/Test Tools: Fix incorrect commit time being reported to WordPress Code Vitals Dashboard. ... Props mukesh27, ayeshrajans. Fixes #62766. git-svn-id: https://develop.svn.wordpress.org/trunk@59570 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-02 16:11:14 +00:00
Peter Wilson	238f8657d7	Happy New Year Twenty Twenty-Five! 🎄 ... Update copyright year to 2025 in the Twenty Twenty-Five bundled theme's `readme.txt`. Follow-up to [18201], [23306], [28064], [36855], [36856], [39659], [40241], [42424], [46719], [46720], [47025], [47026], [49915], [52427], [55024], [57235], [59568]. git-svn-id: https://develop.svn.wordpress.org/trunk@59569 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-02 01:06:38 +00:00
Sergey Biryukov	de14028c76	Happy New Year! 🎄 ... Update copyright year to 2025 in `license.txt` and bundled themes. Follow-up to [18201], [23306], [28064], [36855], [36856], [39659], [40241], [42424], [46719], [46720], [47025], [47026], [49915], [52427], [55024], [57235]. git-svn-id: https://develop.svn.wordpress.org/trunk@59568 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-01 00:10:57 +00:00
Sergey Biryukov	7fedfd4dc1	Coding Standards: Use strict comparison in wp_count_attachments(). ... Follow-up to [54255]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59567 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-31 19:17:10 +00:00
Sergey Biryukov	2ba84334c9	Coding Standards: Use strict comparison in get_post_ancestors(). ... Follow-up to [7074], [15758], [21559], [21953]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59566 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-30 09:30:14 +00:00
Sergey Biryukov	4e1752dee9	Coding Standards: Use strict comparison in sanitize_post(). ... Follow-up to [12062]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59565 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-29 21:52:34 +00:00
Sergey Biryukov	4a6b12bea7	Options, Meta APIs: Ensure after_section is printed for sections without any fields. ... This brings consistency with the `before_section` HTML content, which did get printed in `do_settings_sections()` regardless of whether the settings section has any fields attached. Follow-up to [8855], [21742], [54247]. Props alpipego, SergeyBiryukov. Fixes #62746. git-svn-id: https://develop.svn.wordpress.org/trunk@59564 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-28 22:08:19 +00:00
Sergey Biryukov	779ed48a03	Coding Standards: Use strict comparison in is_user_spammy(). ... Follow-up to [https://mu.trac.wordpress.org/changeset/1640 mu:1640]. Props debarghyabanerjee, aristath, poena, afercia, SergeyBiryukov. See #62279, #62283. git-svn-id: https://develop.svn.wordpress.org/trunk@59563 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-27 23:00:41 +00:00
Sergey Biryukov	20110f63aa	Coding Standards: Use strict comparison in get_active_blog_for_user(). ... Follow-up to [https://mu.trac.wordpress.org/changeset/804 mu:804], [https://mu.trac.wordpress.org/changeset/1918 mu:1918]. Props debarghyabanerjee, aristath, poena, afercia, SergeyBiryukov. See #62279, #62283. git-svn-id: https://develop.svn.wordpress.org/trunk@59562 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-26 23:55:05 +00:00
Sergey Biryukov	27bb7ac234	Coding Standards: Use strict comparison in remove_user_from_blog(). ... Follow-up to [https://mu.trac.wordpress.org/changeset/543 mu:543]. Props debarghyabanerjee, aristath, poena, afercia, SergeyBiryukov. See #62279, #62283. git-svn-id: https://develop.svn.wordpress.org/trunk@59561 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-25 18:29:51 +00:00
Sergey Biryukov	87f99b4316	Coding Standards: Use strict comparison in wpmu_signup_blog_notification(). ... Follow-up to [https://mu.trac.wordpress.org/changeset/1970 mu:1970]. Props debarghyabanerjee. See #62283. git-svn-id: https://develop.svn.wordpress.org/trunk@59560 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-24 22:22:49 +00:00
Joe Dolson	70ecc6b642	Themes: Add an ID to the block theme skip link. ... Add the ID `wp-skip-link` to the block theme generated skip link, so that block themes have a standardized target at the top of the `body` element. Props philliproth, audrasjb, debarghyabanerjee, sabernhardt, joedolson, apermo. Fixes #62311. git-svn-id: https://develop.svn.wordpress.org/trunk@59559 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-23 23:01:23 +00:00
Jb Audras	9dd87b8f91	Coding Standards: Fix a comment indentation issue in script-loader.php. ... Follow-up to [58703]. Props mukesh27. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59558 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-23 22:07:47 +00:00
Sergey Biryukov	a9e2f1c1e5	Coding Standards: Use strict comparison in wpmu_validate_user_signup(). ... Follow-up to [14298], [19852]. Props debarghyabanerjee. See #62283. git-svn-id: https://develop.svn.wordpress.org/trunk@59557 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-23 20:04:18 +00:00
Sergey Biryukov	07be2445e4	Coding Standards: Use strict comparison in wp_handle_comment_submission(). ... Follow-up to [549], [1985], [2464], [2556], [2558], [34799], [40667]. Props deepakrohilla, narenin. See #62316. git-svn-id: https://develop.svn.wordpress.org/trunk@59556 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-22 22:42:35 +00:00
Joe Dolson	d030306983	Customizer: Allow custom accordion items with obsolete structure. ... In [59224], customizer accordion item HTML structure was changed to include a `button` element as the interactive control. However, some themes inject custom markup for panel headings. Fix `controls.js` to handle both the new markup and the old markup, which is relatively common in themes. Props paullb, desrosj, sabernhardt, joedolson, jorbin. Fixes #62494. git-svn-id: https://develop.svn.wordpress.org/trunk@59555 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-22 20:44:06 +00:00
Jb Audras	de76b6ee76	I18n: Add translator context for various occurrences of "upload". ... This changeset adds a `noun` or `verb` context to the various occurrences of "upload" in the admin, to make it easier for translators to differenciate these strings depending on the context. Props timse201, wpgerd. Fixes #62732. git-svn-id: https://develop.svn.wordpress.org/trunk@59554 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-22 19:13:23 +00:00
Jb Audras	71eaaad689	Themes: Fix unwanted horizontal scrolling in theme details screen on mobile. ... This changeset fixes an issue where the theme browser created unwanted horizontal scrolling on some mobile devices. The issue occured when viewing theme details on mobile. Follow-up to [26142]. Props wildworks, abcd95, sainathpoojary, dhruvang21, sabernhardt. Fixes #62411. git-svn-id: https://develop.svn.wordpress.org/trunk@59553 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-22 08:34:08 +00:00
Sergey Biryukov	322b984395	Help/About: Reorder release squad titles for some consistency in translation tools. ... Follow-up to [59545]. See #62386. git-svn-id: https://develop.svn.wordpress.org/trunk@59552 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-21 23:14:46 +00:00
Jb Audras	08c3dd4aff	Login and Registration: Adjust login form margins for better consistency. ... This changeset addresses adjusts margins around the login form for visual consistency. The margin above and below the form is now consistently set to 24px, and the margin below the logo has also been adjusted to 24px. Follow-up to [26072]. Props deeppatel8950, audrasjb, priyank9033, viralsampat, vijaysinh9094, sabernhardt, . Fixes #61667. git-svn-id: https://develop.svn.wordpress.org/trunk@59551 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-21 22:37:35 +00:00
Jb Audras	17d5e47aee	Media: Fix margin issues on the Media file upload screen. ... This changeset fixes an issue in the Media Library where icons or thumbnails of uploaded files were stuck to the border of their container after file upload. Follow-up to [58279]. Props sukhendu2002, im3dabasia1, sainathpoojary, joedolson. Fixes #62573. See #60141. git-svn-id: https://develop.svn.wordpress.org/trunk@59550 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-21 21:52:56 +00:00
Jb Audras	afc8acfbf6	Docs: Docblock improvements in . ... Props shailu25. Fixes #62730. See #62281. git-svn-id: https://develop.svn.wordpress.org/trunk@59549 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-21 17:21:30 +00:00
Sergey Biryukov	a64ad57db6	Docs: Update parameter type hints to include null for post thumbnail functions. ... Follow-up to [12320], [12351], [20646], [32618], [34167], [34373], [37915]. Props apermo, jasonsa19. Fixes #62720. git-svn-id: https://develop.svn.wordpress.org/trunk@59548 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-20 23:33:05 +00:00
Peter Wilson	b8ecfbf954	Help/About: Add additional release squad titles to credits page. ... Introduces translatable strings for additional [https://make.wordpress.org/core/handbook/about/release-cycle/wordpress-release-team-and-focus-leads/ release squad titles]. This is to allow improved acknowledgement of an individual's role in a release squad by enabling the use of these roles in the credits API going forward. Props audrasjb, desrosj, jorbin, timse201, yogeshbhutkar. Fixes #62386. git-svn-id: https://develop.svn.wordpress.org/trunk@59545 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-19 21:54:57 +00:00
Peter Wilson	7381a8273a	REST API: Protect against fatal error for post types without format support. ... Ignore the `format` parameter introduced in WordPress 6.7 for post types that do not support post formats. This protects against a fatal error being thrown in later version of PHP or a warning in earlier versions of PHP. Follow up to r59115. Props dd32, sergeybiryukov, yogeshbhutkar. Fixes #62646. See #62014. git-svn-id: https://develop.svn.wordpress.org/trunk@59544 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-19 21:41:19 +00:00
bernhard-reiter	ef7606073b	Block Hooks: Apply to synced patterns. ... Apply Block Hooks to synced patterns (i.e. `core/block` instances). Props bernhard-reiter, gziolo. Fixes #62704. git-svn-id: https://develop.svn.wordpress.org/trunk@59543 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-19 13:24:22 +00:00
Sergey Biryukov	816ec5df8a	Docs: Add missing single quote in WP_User_Query::prepare_query() DocBlock. ... Follow-up to [38715], [52226]. Props kkmuffme, mukesh27. Fixes #62714. git-svn-id: https://develop.svn.wordpress.org/trunk@59542 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-19 10:22:34 +00:00
Sergey Biryukov	17b50d3d9c	Privacy: Replace hardcoded MD5 references in wp_credits_section_list(). ... The Credits API has been updated to return SHA-256 email hashes. Follow-up to [59532], [meta14307]. Props haozi. Fixes #62706, #60638. git-svn-id: https://develop.svn.wordpress.org/trunk@59541 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-19 03:42:32 +00:00
Peter Wilson	9e4b268049	External Libraries: Append .1 to react/react-dom versions. ... Replaces the `-umd` appendage for the `react` and `react-dom` script versions with `.1`. This it to prevent issues with third party code expecting the version number in the form `/^[\d\.]+$/`. Updates the version to tests in `Tests_Dependencies_Scripts::test_vendor_script_versions_registered_manually` to include the modified version used for cache busting. Follow up to [59536], [58775]. Props azaozz, desrosj, peterwilsoncc. Fixes #62422. git-svn-id: https://develop.svn.wordpress.org/trunk@59540 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-19 03:07:09 +00:00
Jonathan Desrosiers	a2107c2f39	External Libraries: Append a string to react/react-dom versions. ... In 6.7, [58775] changed the way `react` and `react-dom` are bundled in Core. This commit resulted in some changes to the built files that are distributed in WordPress even though the actual version of the libraries remained the same. The result can be a blank white screen when trying to edit a post when those two script files are heavily cached. This adds `-umd` to the end of the version number to properly purge caches until the next update to these libraries occurs. Props levskipg, get_dave, smerriman, jdnd, juanwp22, seanlanglands, robertstaddon. Fixes 62422. git-svn-id: https://develop.svn.wordpress.org/trunk@59536 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-18 18:49:53 +00:00
John Blackbourn	7af04695d8	Build/Test Tools: Remove an unnecessary call to svn in a debugging step. ... None of the steps in any of the workflows use svn, so this debugging step is unnecessary, and svn has been removed in the ubuntu-24.04 runner which will be rolling out to GitHub Actions imminently. See #62221 git-svn-id: https://develop.svn.wordpress.org/trunk@59534 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-18 11:29:53 +00:00
Sergey Biryukov	2238011c33	Coding Standards: Fix WPCS issues in get_avatar_data(). ... Follow-up to [59532]. See #60638. git-svn-id: https://develop.svn.wordpress.org/trunk@59533 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-18 00:23:35 +00:00
Sergey Biryukov	68c4efcd57	Privacy: Use SHA-256 hashing algorithm for Gravatar. ... This aims to improve privacy by switching to a more secure algorithm, as an MD5 string can be reversed. Follow-up to [6748], [31107]. Props henry.wright, jucaduca, haozi, desrosj, dd32, SergeyBiryukov. See #60638. git-svn-id: https://develop.svn.wordpress.org/trunk@59532 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-17 23:56:28 +00:00
Jonathan Desrosiers	c697356c29	Build/Test Tools: Document every matrix exclusion. ... There should be inline documentation anytime a strategy matrix has an `exclude` combination configured so that contributors have proper context as to why it’s there. See #62221. git-svn-id: https://develop.svn.wordpress.org/trunk@59531 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-17 17:20:35 +00:00
Jonathan Desrosiers	8ed4caec8d	Build/Test Tools: Update Default Theme devDependencies. ... The `devDependencies` for all default themes with `package.json` files (Twenty Nineteen, Twenty Twenty, and Twenty Twenty-One) are now updated to their latest versions with a few exceptions in Twenty Twenty-One: - Upgrading `stylelint`/`@wordpress/stylelint-config` requires some work to address rule deprecations. - `@wordpress/eslint-plugin` does not yet support `eslint` 9.x. Additionally, `npm audit fix` has been run for each theme. See #62220. git-svn-id: https://develop.svn.wordpress.org/trunk@59530 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-17 16:58:04 +00:00
Jonathan Desrosiers	f08e51f6b1	Build/Test Tools: Allow more control when testing older branches. ... This adds an input to the Test Old Branches workflow that allows a specific branch to be specified or `all` to run all old branches. The default behavior is to only test the currently supported version of WordPress as defined in the `CURRENTLY_SUPPORTED_BRANCH` environment variable. Follow up to [59520]. See #62221. git-svn-id: https://develop.svn.wordpress.org/trunk@59529 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-17 16:49:52 +00:00
Jonathan Desrosiers	1458de74b6	Build/Test Tools: Regularly run the html-api-html5lib-tests. ... In [58010], the external test suite from `html5lib` was imported to validate the tree-construction steps in the HTML Processor to ensure that they are behaving according to the HTML specification. The test group was excluded by default because there are a high number of skipped tests. The number of skipped tests has come down, but the group does not need to be run on every job. This introduces a new job in the PHPUnit workflow for regularly running these tests on their own using the changes in [59251[. Props desrosj, jonsurrell, jorbin, dmsnell, costdev, chaion07, engahmeds3ed. Fixes #61209. git-svn-id: https://develop.svn.wordpress.org/trunk@59528 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-17 16:38:07 +00:00
Jonathan Desrosiers	ffceac51da	Build/Test Tools: Use MySQL 8.4 as the default. ... MySQL 8.4 is the latest LTS. See #62221. git-svn-id: https://develop.svn.wordpress.org/trunk@59527 602fd350-edb4-49c9-b593-d223f7449a82	2024-12-17 14:43:43 +00:00