30951 Commits

Author SHA1 Message Date
Sergey Biryukov
d581bb0953 Embeds: Remove the external oEmbed tests for YouTube.
These tests no longer test anything that WordPress core has control over. YouTube now serves everything
over HTTPS by default, so the tests for #23149 will always pass, and the tests for #32714 aren't testing
anything that core has control over.

Tests for the responses from oEmbed providers has been attempted and reverted in #32360.

Props johnbillion.
Merges [41712] to the 4.3 branch.
See #42076, #32714, #23149.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@47484 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-22 14:04:40 +00:00
Sergey Biryukov
0214dc808d WordPress 4.3.22
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@46930 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-12 20:30:39 +00:00
Sergey Biryukov
972c0b26f5 Update wp_kses_bad_protocol() to recognize : on uri attributes,
`wp_kses_bad_protocol()` makes sure to validate that uri attributes don’t contain invalid/or not allowed protocols. While this works fine in most cases, there’s a risk that by using the colon html5 named entity, one is able to bypass this function.

Brings r46895 to the 4.3 branch.

Props: xknown, nickdaugherty, peterwilsoncc.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@46911 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-12 18:42:58 +00:00
Jonathan Desrosiers
94af14bbb6 WordPress 4.3.21.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@46517 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 20:12:20 +00:00
Jake Spurlock
ef4b6d35ed Backporting several bug fixes.
- Query: Remove the static query property.
- HTTP API: Protect against hex interpretation.
- Filesystem API: Prevent directory travelersals when creating new folders.
- Administration: Ensure that admin referer nonce is valid.
- REST API: Send a Vary: Origin header on GET requests.
- Customizer: Properly sanitize background images.

Backports [46474], [46475], [46476], [46477], [46478], [46483], [46485] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@46499 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 19:11:50 +00:00
Jake Spurlock
d2dfcf5665 Add .nvmrc files to older versions of WordPress
When jumping between branches, it would be nice to have the correct node version for the older versions of WordPress. Let's add .nvmrc files to these older branches for the supported versions.

Merges [46295] to the 4.3 branch.

Fixes #48140


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@46301 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-25 21:00:56 +00:00
Jonathan Desrosiers
bd55432f59 WordPress 4.3.20.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@46037 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 21:20:08 +00:00
Jonathan Desrosiers
c49ecfb258 Fix for URL sanitization in wp_kses_bad_protocol_once().
Merges [45997] to the 4.3 branch.

Props irsdl, sstoqnov, whyisjake.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@46011 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 18:30:31 +00:00
Sergey Biryukov
f60f49b788 Improve URL validation in wp_validate_redirect().
Merges [45971] to the 4.3 branch.
Props vortfu, whyisjake, peterwilsoncc.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@45982 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 17:12:57 +00:00
Jake Spurlock
2dadc8cf79 Remove _convert_urlencoded_to_entities() from the get_the_content() callback.
Merges [45937] to the 4.3 branch.

Props vortfu, whyisjake, peterwilsoncc


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@45959 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:40:17 +00:00
Sergey Biryukov
dff4347a98 Escape the output in wp_ajax_upload_attachment().
Merges [45936] to the 4.3 branch.
Props whyisjake, sstoqnov.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@45952 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:36:31 +00:00
John Blackbourn
3cfb855a71 Build/Test tools: Switch npm dependency caching strategy on Travis CI for the 4.3 branch.
This switches to caching npm's local cache instead of the compiled modules in `node_modules`. The latter is causing errors on the PHP 5.2 build.

Merges [44989] to the 4.3 branch.
 
See #42385


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44990 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-24 23:46:17 +00:00
Gary Pendergast
940117fd65 WordPress 4.3.19
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44880 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-13 01:36:11 +00:00
Sergey Biryukov
7f00dfaa36 Comments: Improve comment content filtering.
Merges [44842] to the 4.3 branch.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44851 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-12 22:40:30 +00:00
Jeremy Felt
b73d26f031 Bump 4.3 branch to version 4.3.18.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44084 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 02:13:08 +00:00
Gary Pendergast
f1b2bfebba Editor: Remove unwanted fields before saving posts.
The `meta_input`, `file`, and `guid` fields are not intended to be updated through user input.

Merges [44047] to the 4.3 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44064 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 01:50:03 +00:00
Peter Wilson
d56a06f954 Multisite: Validate activation links.
Merges [44048] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44063 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 01:48:48 +00:00
Ian Dunn
5b282b8cd7 KSES: Make the URI attributes DRY.
This commit introduces the `wp_kses_uri_attributes` function and filter. The function centralizes the list of attributes, in order to prevent inconsistency, and the filter provides a way for plugins to customize the attributes.

Merges [44014] and [44017] to the `4.3` branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44041 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 01:13:46 +00:00
Peter Wilson
7195a2c8ca Multisite: Improve messaging for previously activated users.
Ensure activation of a site is not attempted multiple times and users are shown the correct message if they follow the link a second time.

Merges [44021] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44033 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 00:53:12 +00:00
Gary Pendergast
95bf8bc711 KSES: Conditionally remove the <form> element from $allowedposttags.
To avoid backwards compatibility issues, `<form>` is re-added if a custom filter has added the `<input>` or `<select>` elements to `$allowedposttags`.

Merges [43994] to the 4.3 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.3@44005 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-12 23:36:48 +00:00
Jeremy Felt
bb03adb1b5 Media: Improve verification of MIME file types.
Merges [43988] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@43996 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-12 23:16:07 +00:00
Aaron D. Campbell
beee8e687a Bump 4.3 branch to version 4.3.17
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@43413 602fd350-edb4-49c9-b593-d223f7449a82
2018-07-05 16:10:44 +00:00
John Blackbourn
bad264e665 Media: Limit thumbnail file deletions to the same directory as the original file.
Merges [43393] into the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@43399 602fd350-edb4-49c9-b593-d223f7449a82
2018-07-05 15:02:04 +00:00
Aaron D. Campbell
7882cfbf99 Bump 4.3 branch to version 4.3.16
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42939 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 20:27:47 +00:00
Dominik Schilling (ocean90)
3f56622c55 Template: Make sure the version string is correctly escaped for use in attributes.
Merge of [42893] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42923 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 16:05:56 +00:00
Dominik Schilling (ocean90)
893762f7c4 Login: Use wp_safe_redirect() when redirecting the login page if forced to use HTTPS.
Merge of [42892] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42901 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 15:28:58 +00:00
Sergey Biryukov
d96c5664d1 General: Update copyright year to 2018 in license.txt.
Props rachelbaker.
Merges [42424] to the 4.3 branch.
Fixes #43007.

git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42558 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-23 11:26:00 +00:00
Dion Hulse
fdd08af1ed Bump the 4.3 branch to 4.3.15.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42500 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 21:41:24 +00:00
Dion Hulse
e5de1841f1 External Libraries: Remove unnecessary / obsoleted MediaElement.js files.
Merges [42478] to the 4.3 branch.
Fixes #42720 for 4.3.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42483 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 08:09:13 +00:00
Dion Hulse
a91a669874 Upgrade: When deleting old files, if deletion fails attempt to empty the file instead.
Props joemcgill, dd32.
Merges [42434] to the 4.3 branch.
Fixes #42963 for 4.3.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42471 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 06:55:18 +00:00
John Blackbourn
3b9ea18ecd Bump 4.3 branch to version 4.3.14.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42322 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-29 19:00:36 +00:00
John Blackbourn
be2fc6b3e4 Hardening: Remove the ability to upload JavaScript files for users who do not have the unfiltered_html capability.
Merges [42261] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42291 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-29 16:30:42 +00:00
John Blackbourn
786ca60751 Hardening: Ensure the attributes of enclosures are correctly escaped in RSS and Atom feeds.
Merges [42260] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42290 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-29 16:30:06 +00:00
John Blackbourn
ef20417bf3 Hardening: Add escaping to the language attributes used on html elements.
Merges [42259] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42289 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-29 16:29:35 +00:00
John Blackbourn
9ecf1ec6ba Hardening: Use a properly generated hash for the newbloguser key instead of a determinate substring.
Merges [42258] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42288 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-29 16:29:06 +00:00
Dion Hulse
c60e988ffb WPDB: Check that AUTH_SALT is not empty, Fix a PHP notice when AUTH_SALT is undefined.
Props jsonfry, mkomar, pento.
Merges [42119] and [42120] to the 4.3 branch.
Fixes #42431 and #42401 for 4.3.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42235 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-27 01:10:13 +00:00
John Blackbourn
c4d712b498 General: Remove the version number from the readme file in the 4.3 branch.
See #42386


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42093 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-31 17:43:17 +00:00
Gary Pendergast
3b90965b99 Bump 4.3 branch to version 4.3.13.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42074 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-31 13:32:49 +00:00
Gary Pendergast
df74cf1a48 Database: Restore numbered placeholders in wpdb::prepare().
[41496] removed support for numbered placeholders in queries send through `wpdb::prepare()`, which, despite being undocumented, were quite commonly used.

This change restores support for numbered placeholders (as well as a subset of placeholder formatting), while also adding extra checks to ensure the correct number of arguments are being passed to `wpdb::prepare()`, given the number of placeholders.

Merges [41662], [42056] to the 4.3 branch.
See #41925.



git-svn-id: https://develop.svn.wordpress.org/branches/4.3@42062 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-31 12:48:20 +00:00
Dominik Schilling (ocean90)
5ea16786bc Users: Use correct escaping function for URLs.
Merge of [41522] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@41528 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-19 21:37:43 +00:00
Dominik Schilling (ocean90)
94f13ff58f Bump 4.3 branch to version 4.3.12.
git-svn-id: https://develop.svn.wordpress.org/branches/4.3@41515 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-19 20:01:36 +00:00
Aaron D. Campbell
a9693ba63b Database: Hardening to bring wpdb::prepare() inline with documentation.
`wpdb::prepare()` supports %s, %d, and %F as placeholders in the query string. Any other non-escaped % will be escaped.

Merges [41496] to 4.3 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.3@41502 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-19 18:27:47 +00:00
Aaron D. Campbell
80879ca17b Database: Don’t trigger _doing_it_wrong() for null values in wpdb::prepare().
While `wpdb::prepare()` does not support null values (see #12819) they still appear in the wild like in the WordPress Importer and other plugins.

Merges [41483] to 4.3 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.3@41489 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-19 16:23:20 +00:00
Aaron D. Campbell
2fe5bc9cb3 Database: Hardening for wpdb::prepare()
Previously if you passed an array of values for placeholders, additional values could be passed as well. Now additional values will be ignored.

Merges [41470] to 4.3 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.3@41476 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-19 15:00:59 +00:00
John Blackbourn
73bd3846f5 Filesystem API: Ensure filenames are valid before attempting to unzip them to ensure malformed file paths don't cause issues.
Merges [41457] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@41463 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-19 14:41:23 +00:00
John Blackbourn
0affa539ea General: Add missing URL-encoding and add extra hardening to plugin and template names when they're displayed in the admin area.
Merges [41434] with changes to the 4.3 branch.

See #13377


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@41444 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-19 13:19:20 +00:00
Dominik Schilling (ocean90)
a6037e1979 TinyMCE: Improve the previews for shortcodes.
Merge of [41395] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@41440 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-19 12:40:22 +00:00
Dominik Schilling (ocean90)
7de576a2f1 Users: Provide a fallback for incorrect HTTP referrers.
Merge of [41398] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@41422 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-19 11:10:35 +00:00
Dominik Schilling (ocean90)
ea0311f7cb Editor: Prevent adding javascript: and data: URLs through the inline link dialog.
Merge of [41393] to the 4.3 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@41405 602fd350-edb4-49c9-b593-d223f7449a82
2017-09-19 10:15:11 +00:00
John Blackbourn
9f07ed775f Build/Test tools: Use the latest in the 4.x and 5.x branches of PHPUnit when running tests on Travis for the 4.3 branch.
See #41472


git-svn-id: https://develop.svn.wordpress.org/branches/4.3@41300 602fd350-edb4-49c9-b593-d223f7449a82
2017-08-22 17:25:06 +00:00