openscad/BOSL2
1
0
Fork 0
mirror of https://github.com/revarbat/BOSL2.git synced 2025-08-12 00:54:58 +02:00
Code Issues Projects Releases Wiki Activity

Address regression error

Browse Source
This commit is contained in:
Alex Matulich
2025-05-03 19:18:24 -07:00
parent 2e61bf7bfb
commit 1363a8d44d
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
geometry.scad
View File

@@ -434,12 +434,12 @@ function _line_greatest_distance(points,line) = // internal function
max(d); max(d);
function line_from_points(points, check_collinear=false, eps=EPSILON) = function line_from_points(points, check_collinear=false, eps=EPSILON) =
assert( is_path(points,dim=3), "\nImproper 3d point list." ) assert( is_path(points), "\nInvalid point list." )
assert( is_finite(eps) && (eps>=0), "\nThe tolerance should be a non-negative value." ) assert( is_finite(eps) && (eps>=0), "\nThe tolerance should be a non-negative value." )
len(points) == 2 len(points) == 2
? points ? points
: let( : let(
covmix = _covariance_evec_eval(points,0), // pass 0 to use largest eigenvalue covmix = _covariance_evec_eval(path3d(points), 0), // pass 0 to use largest eigenvalue
pm = covmix[0], // point mean pm = covmix[0], // point mean
evec = unit(covmix[1]), // normalized eigenvector corresponding to largest eigenvalue evec = unit(covmix[1]), // normalized eigenvector corresponding to largest eigenvalue
maxext = let(b=pointlist_bounds(points)) norm(b[1]-b[0])/2, maxext = let(b=pointlist_bounds(points)) norm(b[1]-b[0])/2,