openscad/BOSL2
1
0
Fork 0
mirror of https://github.com/revarbat/BOSL2.git synced 2025-07-31 01:50:33 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #138 from adrianVmariano/master

Browse Source 
bug fix qr factorization, removed echo in plane intersection, fixed bezier_surface so vnf arg is in right order
This commit is contained in:
Revar Desmera
2020-03-09 18:27:30 -07:00
committed by GitHub
parent 1d10c15d57 ee82a8bb97
commit 37392e1376
3 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
beziers.scad
View File

@@ -923,12 +923,12 @@ function patch_reverse(patch) = [for (row=patch) reverse(row)];
// ];
// vnf = bezier_surface(patches=[patch1, patch2], splinesteps=16);
// polyhedron(points=vnf[0], faces=vnf[1]);
function bezier_surface(patches=[], splinesteps=16, i=0, vnf=[[],[]]) =
function bezier_surface(patches=[], splinesteps=16, vnf=[[],[]], i=0) =
let(
vnf = (i >= len(patches))? vnf :
bezier_patch(patches[i], splinesteps=splinesteps, vnf=vnf)
) (i >= len(patches))? vnf :
bezier_surface(patches=patches, splinesteps=splinesteps, i=i+1, vnf=vnf);
bezier_surface(patches=patches, splinesteps=splinesteps, vnf=vnf, i=i+1);

3
geometry.scad
View File

@@ -606,8 +606,7 @@ function plane_intersection(plane1,plane2,plane3) =
let(
matrix = [for(p=[plane1,plane2]) select(p,0,2)],
rhs = [for(p=[plane1,plane2]) p[3]],
point = linear_solve(matrix,rhs),
dd=echo(point=point, normal=normal)
point = linear_solve(matrix,rhs)
)
[point, point+normal];

2
math.scad
View File

@@ -579,7 +579,7 @@ function qr_factor(A) =
)
assert(len(dim)==2)
let(
qr =_qr_factor(A, column=0, m = m, n=m, Q=ident(m)),
qr =_qr_factor(A, column=0, m = m, n=n, Q=ident(m)),
Rzero = [
for(i=[0:m-1]) [
for(j=[0:n-1])