openscad/BOSL2
1
0
Fork 0
mirror of https://github.com/revarbat/BOSL2.git synced 2025-01-16 13:50:23 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #1230 from BelfrySCAD/revarbat_dev

Browse Source 
Rack profile shift bugfix for tooth rounding.
This commit is contained in:
Revar Desmera 2023-07-31 14:17:29 -07:00 committed by GitHub
commit fbfcd4ab74
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gears.scad
View File

@ -1513,7 +1513,8 @@ function rack2d(
) = let(
pitch = _inherit_gear_pitch("rack2d()",pitch, circ_pitch, diam_pitch, mod, warn=false),
PA = _inherit_gear_pa(pressure_angle),
helical = _inherit_gear_helical(helical)
helical = _inherit_gear_helical(helical),
mod = module_value(circ_pitch=pitch)
)
assert(is_integer(teeth) && teeth>0)
assert(is_finite(PA) && PA>=0 && PA<90, "Bad pressure_angle value.")
@ -1526,6 +1527,7 @@ function rack2d(
let(
adendum = _adendum(pitch, profile_shift),
dedendum = _dedendum(pitch, clearance, profile_shift),
clear = default(clearance, 0.25 * mod),
bottom = is_def(bottom) ?
assert(is_finite(bottom) && bottom>dedendum, "bottom is invalid or too small for teeth")
bottom
@ -1544,7 +1546,6 @@ function rack2d(
l = teeth * trans_pitch,
ax = ang_adj_to_opp(trans_pa, adendum),
dx = ang_adj_to_opp(trans_pa, dedendum),
clear = dedendum - adendum,
poff = tthick/2 - backlash,
tooth = [
[-trans_pitch/2, -dedendum],