Merge branch 'jeroenrnl-VariableNamesWithDigitsDeprecated'

Merge branch 'VariableNamesWithDigitsDeprecated' of https://github.com/jeroenrnl/NopSCADlib into jeroenrnl-VariableNamesWithDigitsDeprecated
Updated changelog.
2025-09-18 11:11:31 +02:00 · 2025-03-27 12:24:15 +00:00 · 2025-03-27 12:01:05 +00:00 · 2025-03-27 02:00:24 +00:00 · 2025-03-27 01:59:05 +00:00 · 2025-03-27 01:57:19 +00:00
3 changed files with 11 additions and 5 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,12 @@
 This changelog is generated by `changelog.py` using manually added semantic version tags to classify commits as breaking changes, additions or fixes.


+#### [v21.35.3](https://github.com/nophead/NopSCADlib/releases/tag/v21.35.3 "show release") Fixes [...](https://github.com/nophead/NopSCADlib/compare/v21.35.2...v21.35.3 "diff with v21.35.2")
+*   2025-03-27 [`9f9aa67`](https://github.com/nophead/NopSCADlib/commit/9f9aa6723eff9b7439e17758406e9f8e409828ee "show commit") [C.P.](# "Chris Palmer") Third attempt to fix dimension image.
+
+#### [v21.35.2](https://github.com/nophead/NopSCADlib/releases/tag/v21.35.2 "show release") Fixes [...](https://github.com/nophead/NopSCADlib/compare/v21.35.1...v21.35.2 "diff with v21.35.1")
+*   2025-03-27 [`6b6704b`](https://github.com/nophead/NopSCADlib/commit/6b6704b823291119697bf4993eddb3f2e6873875 "show commit") [C.P.](# "Chris Palmer") Second attempt to fix dimension image.
+
 #### [v21.35.1](https://github.com/nophead/NopSCADlib/releases/tag/v21.35.1 "show release") Fixes [...](https://github.com/nophead/NopSCADlib/compare/v21.35.0...v21.35.1 "diff with v21.35.0")
 *   2025-03-27 [`117fb62`](https://github.com/nophead/NopSCADlib/commit/117fb626e7023ca92339947a0f84a8aee5c6429e "show commit") [C.P.](# "Chris Palmer") Fixed dimension example image address.

--- a/docs/sliding_t_nut_small.png
+++ b/docs/sliding_t_nut_small.png
--- a/utils/maths.scad
+++ b/utils/maths.scad
@@ -164,13 +164,13 @@ function xor(a,b) = (a && !b) || (!a && b);     //! Logical exclusive OR
 function cuberoot(x)= sign(x)*abs(x)^(1/3);

 function quadratic_real_roots(a, b, c) =        //! Returns real roots of a quadratic equation, biggest first. Returns empty list if no real roots
-    let(2a = 2 * a,
-        2c = 2 * c,
-        det = b^2 - 2a * 2c
+    let(ax2 = 2 * a,
+        cx2 = 2 * c,
+        det = b^2 - ax2 * cx2
    ) det < 0 ? [] :
        let(r = sqrt(det),
-            x1 = b < 0 ? 2c / (-b + r) : (-b - r) / 2a,
-            x2 = b < 0 ? (-b + r) / 2a : 2c / (-b - r)
+            x1 = b < 0 ? cx2 / (-b + r) : (-b - r) / ax2,
+            x2 = b < 0 ? (-b + r) / ax2 : cx2 / (-b - r)
        ) [x2, x1];

 function cubic_real_roots(a, b, c, d) = //! Returns real roots of cubic equation
Author	SHA1	Message	Date
Chris Palmer	dbf8e6c7ae	Merge branch 'jeroenrnl-VariableNamesWithDigitsDeprecated'	2025-03-27 12:24:15 +00:00
Chris Palmer	7d281cbcdd	Merge branch 'VariableNamesWithDigitsDeprecated' of https://github.com/jeroenrnl/NopSCADlib into jeroenrnl-VariableNamesWithDigitsDeprecated	2025-03-27 12:01:05 +00:00
Chris Palmer	f1a651a2d2	Updated changelog.	2025-03-27 02:00:24 +00:00
Chris Palmer	9f9aa6723e	Third attempt to fix dimension image.	2025-03-27 01:59:05 +00:00
Chris Palmer	83d2d511e3	Updated changelog.	2025-03-27 01:57:19 +00:00
Jeroen Roos	fdbe0c7a9e	Change variable names that start with a digit Change names of variables from `2a` and `2c` to `ax2` (a times 2) and `cx2`, because variable names starting with a digit are deprecated in OpenSCAD.	2025-03-23 10:45:33 +01:00