87 Commits

Author SHA1 Message Date
3830919a99 Fix backwards compatibility nut_sides arg
* nut_sides must be last argument
* default value = 0. With 120 as default, we cannot set nut_sides to 120
  while simultaneously setting fn to something different from 120.
2024-01-27 12:35:12 +01:00
40c02e5ecb Added nut_sides parameter to allow creation of non-cylinder nut 2024-01-27 12:35:12 +01:00
32c20eb982 Code of Conduct
* Added CODE_OF_CONDUCT.md
* Linked it in README.rst
* Fixed typo in CONTRIBUTING.md
2024-01-16 18:40:47 +01:00
d8257b7da3 readme: openscad/scad-utils
Use *openscad*/scad-utilsb(there are others). Hopefully helps prevent #85.
2024-01-16 17:50:17 +01:00
f98aa484bf make.yml: pull_request_target
Trying to get PRs from forks running. Seems to require pull_request_target event that uses (trusted) tox.yml in base branch instead of (untrusted) tox.yml in branch of fork.
2024-01-15 22:04:51 +01:00
950ee06171 make.yml fix 2023-04-08 12:55:40 +02:00
acaa453ab4 make make-workflow manually trigger able 2023-04-08 12:54:49 +02:00
298a0681ef Create make workflow
make clean; make; make test
2023-04-08 12:51:57 +02:00
bad6cbea2e Add link CONTRIBUTING.md => UnitTests.md 2023-04-02 16:33:34 +02:00
38c81bdc22 link to CONTRIBUTING from README 2023-04-02 16:31:21 +02:00
c0c58cc172 prepare for release
- Update README.rst (supported threads, changelog)
- bump version number (in threadlib.scad)
2023-04-02 16:16:57 +02:00
ba6024c0cd .gitignore 2023-04-02 16:02:24 +02:00
0b785b7b4f re-org docs/ 2023-04-02 16:02:01 +02:00
33c5cdd035 re-ordered rms-thread profile
* Adhere to docs/DesignOfThreadlib.md
* Make unittests pass
2023-04-02 15:15:30 +02:00
10259b696b tests for rms thread 2023-04-02 15:15:30 +02:00
149b4b9fb7 Added RMS microscope threads. Tested with an RMS microscope objective lens and it worked properly. 2023-04-02 15:12:16 +02:00
ad42e03241 Release.md
What I should not forget when creating a release
2022-12-08 22:13:17 +01:00
a1bbde40a5 fixed __THREADLIB_VERSION (=> 0.4) 2022-12-08 22:09:20 +01:00
3a7fbc7a1d README.rst
- Added PCO-1810 to list of supported threads
2022-12-03 17:13:07 +01:00
9bae5785c0 Bump to 0.4
- Update LICENSE to include Contributors
- Update ChangeLog
- Bump version to 0.4
2022-04-03 19:05:16 +02:00
b1eeb69f75 Add PCO-1810 thread
* Update PCO_thread.csv
* Added PCO-1810 to THREAD_TABLE.scad and tests/test_table.awk
2022-04-03 18:19:14 +02:00
dab2cc95ff Give us as star :) 2022-01-05 18:34:06 +01:00
75814d2013 Prevent duplicates
Prevent duplicate lines in THREAD_TABLE.scad when long and short descriptors
are identical => if condition in metric_thread.awk
2022-01-05 18:33:15 +01:00
d8c8384988 ThreadProfile.png
Improved illustration of thread-profile spec by showing
Rsup and Rrot in ThreadProfile.png.
2021-10-10 16:16:00 +02:00
4bb8c70987 Development Docs (#58)
Improved development docs and link to it from README.
2021-10-09 15:26:08 +02:00
91eb1b0121 Full and short designators
List metric threads not only with their short
designator but also with full designator as
proposed by @uDude.
2021-10-08 22:51:52 +02:00
dfe2266f44 pass fn in call to straight_thread() (#50)
Addressing issue #46: "fn needs to be passed in call to straight_thread()".
I just added the missing "fn=fn," line 36. That should take care of the issue.
I tested locally and it seems to be fine, now specifying fn in bolt(), nut() and tap() work as expected.
2021-07-11 12:02:39 +02:00
931d519f2a fix thread size used in example (#48) 2021-05-18 13:16:14 +02:00
bb860b61a2 Fix docs (#44)
Docs

* Fixed broken links (to mdmetrics.com) in docs/* and README.rst
* Removed externally rendered formula (broken link) in BSPPthread.md
* Added explanation for tap module to README.rst
  which also required a new image and a line in the docs/Makefile

CONTRIBUTING

* Added CONTRIBUTING (closes #3)
2020-08-04 22:36:37 +02:00
53944df3fa Merging PR #42 by bvarner
Add a tap() module which creates tapped holes by differencing
the tap() from some parent-part.
2020-08-03 15:13:46 +02:00
7054d253b0 Corrected :author: field 2020-08-03 14:56:57 +02:00
9734ccdea3 Added a test case. 2020-07-08 11:11:00 -04:00
2021b75ceb In trying to convert some of my existing openscad projects over to this module
I ran across the mental block of adding interior threads to a pre-cut hollow, which broke my brain a bit.

I find it more natural to think of adding a threaded hole to a solid as a 'tap' or difference() operation, rather than differencing a hollow and then adding interior threads to it.

For this reason I've created the, `tap(...)` module, which creates a positive of the internal threads suitable for differencing to produce a threaded tap hole.
2020-07-08 11:02:22 -04:00
21af7ca550 Fixed formatting problem
Directory structure is now readable.
2020-06-12 11:38:01 +02:00
08851025f5 fix warning in test.scad
Apparently, cube does not take 3 arguments anymore but only 1.
2020-06-09 18:38:03 +02:00
c6b8562c56 Class 2 UIS threads
Documented that threadlib provides *class* *2* UIS threads,
not class 1 and not class 3. Clarifies issue #33.
2020-06-09 18:36:36 +02:00
778bc41afb README: Supported threads / installation
* Extended section of supported threads to
  include UIS-threads.
* Clarified installation instructions: Added dir-tree
  showing how the libraries-folder should look like.
2020-06-09 18:33:30 +02:00
61cecdb68d updated .gitignore 2020-06-09 18:30:58 +02:00
703d6a8859 thread_specs(...): Error Msg
Added helpful error message if thread_specs(...) is unable to
look up designator. Compare PR #36.

closes #37
2020-06-09 18:13:47 +02:00
63bde7f4f8 - bumped up version number
- updated change log in README
- clearly stated units threadlib is using
2019-11-13 21:03:14 +01:00
55e360d76b Unified Inch Screw Threads (#29)
Unified Inch Screw Threads
++++++++++++++++++++++++++

Added unified inch screw threads. Namely UNC, UNF, UNEF, 4-UN, 6-UN,
8-UN, 12-UN, 16-UN, 20-UN, 28-UN, and 32-UN.

Also, removed reference to long-gone Excel table.

solves #11 
solves #12 
solves #13
2019-11-11 21:20:33 +01:00
7e30d8e824 Add tech-docs for metric thread (#23)
Describes the choices made when deriving threadlib specs from the metric
thread norms.

closes #7
2019-05-26 19:00:07 +02:00
8865c654ce fix pco-1881-int minor diameter (#22)
minor diameter has been too small => collision with sealing lip on
pco-1881 neck. It is now large enough to fit the sealing lip through the
internal thread.

closes #18
2019-05-26 17:52:35 +02:00
ad12ec4961 Tech docs bspp (#21)
Tech-docs BSP-Parallel thread

- Documented how threadlike specs for BSPP thread are derived from norm data. 
- Refactoring of BSPP_thread.awk to make the code easier to document (order of calculations, avoid repetition).

closes #6
2019-05-08 22:08:33 +02:00
827723d1b1 Eliminate threads.xlsx
Replaces threads.xlsx by one .csv file and one awk script per thread
type. The script calculates threadlib specs from the data in the .csv
file. Finally and as before, autogenerate.awk generates the OpenSCAD
code (i.e. THREAD_TABLE.scad).

A new Makefile automates this process: make does what is needed. It
also provides a target 'test' to run the (existing) tests.

To add a new thread type:

- provide newthread.csv
- provide newthread.awk
- modify Makefile to generate your new threads
- add appropriate tests

Additionally:

- fixed bug in Rrot when DRmax is too large.
- reduced number of significant figures to a resolution of 0.1 um
  (while not extremely generous for the very finest threads, it
  should be enough by far for any 3D-prints).
- increased test limit for thread angle deviations (necessary due to
  reduced number of significant figures)
- added test counter: 'make test' now prints number of tests run +
  number of threads tested.
- For unknown reasons (MacOS awk?) final match-all rule in
  test_table.awk does not match with double-quotes. Work-around: Match
  without double-quotes.
2019-05-05 22:29:09 +02:00
26b7e66184 Merge branch 'develop' of github.com:adrianschlatter/threadlib into develop 2019-04-30 21:45:23 +02:00
26ad35c72a Add developer docs
- explain structure of THREAD_TABLE.scad and relation to thread module
- explain threads and how to derive proper specs for inclusion in threadlib
- explain use of autogenerate.awk
- explain tests (i.e., test_table.awk)

closes #5
2019-04-30 21:45:02 +02:00
45412ab352 Fixed error in Rrot of PCO-1881-int 2019-04-18 22:53:58 +02:00
deed429816 Fixed Dpitch error in G-ext threads 2019-04-18 16:26:47 +02:00
fb0d9d1d21 Unit tests for Rrot
Makefile for unit testing
2019-04-14 18:15:55 +02:00