* nut_sides must be last argument
* default value = 0. With 120 as default, we cannot set nut_sides to 120
while simultaneously setting fn to something different from 120.
Trying to get PRs from forks running. Seems to require pull_request_target event that uses (trusted) tox.yml in base branch instead of (untrusted) tox.yml in branch of fork.
Addressing issue #46: "fn needs to be passed in call to straight_thread()".
I just added the missing "fn=fn," line 36. That should take care of the issue.
I tested locally and it seems to be fine, now specifying fn in bolt(), nut() and tap() work as expected.
Docs
* Fixed broken links (to mdmetrics.com) in docs/* and README.rst
* Removed externally rendered formula (broken link) in BSPPthread.md
* Added explanation for tap module to README.rst
which also required a new image and a line in the docs/Makefile
CONTRIBUTING
* Added CONTRIBUTING (closes#3)
I ran across the mental block of adding interior threads to a pre-cut hollow, which broke my brain a bit.
I find it more natural to think of adding a threaded hole to a solid as a 'tap' or difference() operation, rather than differencing a hollow and then adding interior threads to it.
For this reason I've created the, `tap(...)` module, which creates a positive of the internal threads suitable for differencing to produce a threaded tap hole.
* Extended section of supported threads to
include UIS-threads.
* Clarified installation instructions: Added dir-tree
showing how the libraries-folder should look like.
minor diameter has been too small => collision with sealing lip on
pco-1881 neck. It is now large enough to fit the sealing lip through the
internal thread.
closes#18
Tech-docs BSP-Parallel thread
- Documented how threadlike specs for BSPP thread are derived from norm data.
- Refactoring of BSPP_thread.awk to make the code easier to document (order of calculations, avoid repetition).
closes#6
Replaces threads.xlsx by one .csv file and one awk script per thread
type. The script calculates threadlib specs from the data in the .csv
file. Finally and as before, autogenerate.awk generates the OpenSCAD
code (i.e. THREAD_TABLE.scad).
A new Makefile automates this process: make does what is needed. It
also provides a target 'test' to run the (existing) tests.
To add a new thread type:
- provide newthread.csv
- provide newthread.awk
- modify Makefile to generate your new threads
- add appropriate tests
Additionally:
- fixed bug in Rrot when DRmax is too large.
- reduced number of significant figures to a resolution of 0.1 um
(while not extremely generous for the very finest threads, it
should be enough by far for any 3D-prints).
- increased test limit for thread angle deviations (necessary due to
reduced number of significant figures)
- added test counter: 'make test' now prints number of tests run +
number of threads tested.
- For unknown reasons (MacOS awk?) final match-all rule in
test_table.awk does not match with double-quotes. Work-around: Match
without double-quotes.
- explain structure of THREAD_TABLE.scad and relation to thread module
- explain threads and how to derive proper specs for inclusion in threadlib
- explain use of autogenerate.awk
- explain tests (i.e., test_table.awk)
closes#5
