1
0
mirror of https://github.com/flarum/core.git synced 2025-08-20 23:31:27 +02:00

Flatten logic

With an early return, the method becomes more readable, and the
actual (very small) change from #46 becomes more apparent.
This commit is contained in:
Franz Liedke
2018-02-08 17:14:28 +01:00
parent 26483cc0c5
commit 7667b80bf7

View File

@@ -110,22 +110,25 @@ class UpdateTagMetadata
return;
}
// We do not count private discussions in tags
if ($discussion->is_private) {
return;
}
if (! $tags) {
$tags = $discussion->tags;
}
if (! $discussion->is_private) {
foreach ($tags as $tag) {
$tag->discussions_count += $delta;
foreach ($tags as $tag) {
$tag->discussions_count += $delta;
if ($discussion->last_time > $tag->last_time) {
$tag->setLastDiscussion($discussion);
} elseif ($discussion->id == $tag->last_discussion_id) {
$tag->refreshLastDiscussion();
}
$tag->save();
if ($discussion->last_time > $tag->last_time) {
$tag->setLastDiscussion($discussion);
} elseif ($discussion->id == $tag->last_discussion_id) {
$tag->refreshLastDiscussion();
}
$tag->save();
}
}
}