Flatten logic

With an early return, the method becomes more readable, and the
actual (very small) change from #46 becomes more apparent.

extensions/tags/src/Listener/UpdateTagMetadata.php

@@ -110,22 +110,25 @@ class UpdateTagMetadata
             return;
         }
 
+        // We do not count private discussions in tags
+        if ($discussion->is_private) {
+            return;
+        }
+
         if (! $tags) {
             $tags = $discussion->tags;
         }
 
-        if (! $discussion->is_private) {
+        foreach ($tags as $tag) {
-            foreach ($tags as $tag) {
+            $tag->discussions_count += $delta;
-                $tag->discussions_count += $delta;
 
-                if ($discussion->last_time > $tag->last_time) {
+            if ($discussion->last_time > $tag->last_time) {
-                    $tag->setLastDiscussion($discussion);
+                $tag->setLastDiscussion($discussion);
-                } elseif ($discussion->id == $tag->last_discussion_id) {
+            } elseif ($discussion->id == $tag->last_discussion_id) {
-                    $tag->refreshLastDiscussion();
+                $tag->refreshLastDiscussion();
-                }
-
-                $tag->save();
             }
+
+            $tag->save();
         }
     }
 }