1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-04-13 12:22:03 +02:00

[ticket/16526] Adjust test to use better assertions

PHPBB3-16526
This commit is contained in:
rxu 2020-08-14 04:30:20 +07:00
parent 59900357a7
commit 6cd54639b5
No known key found for this signature in database
GPG Key ID: 8EF9758E0A54D19E

View File

@ -31,7 +31,7 @@ class phpbb_functional_acp_post_settings_test extends phpbb_functional_test_case
]);
$crawler = self::submit($form);
$this->assertContainsLang('WARNING', $crawler->filter('div[class="errorbox"] > h3')->text());
$this->assertContains($this->lang('CSV_INVALID', $this->lang('ALLOWED_SCHEMES_LINKS')), $crawler->filter('div[class="errorbox"] > p')->text());
$this->assertStringContainsString($this->lang('CSV_INVALID', $this->lang('ALLOWED_SCHEMES_LINKS')), $crawler->filter('div[class="errorbox"] > p')->text());
// Test trailing comma and invalid scheme - invalid
$form = $crawler->selectButton($this->lang('SUBMIT'))->form([
@ -39,8 +39,8 @@ class phpbb_functional_acp_post_settings_test extends phpbb_functional_test_case
]);
$crawler = self::submit($form);
$this->assertContainsLang('WARNING', $crawler->filter('div[class="errorbox"] > h3')->text());
$this->assertContains($this->lang('CSV_INVALID', $this->lang('ALLOWED_SCHEMES_LINKS')), $crawler->filter('div[class="errorbox"] > p')->text());
$this->assertContains($this->lang('URL_SCHEME_INVALID', $this->lang('ALLOWED_SCHEMES_LINKS'), '2ftp'), $crawler->filter('div[class="errorbox"] > p')->text());
$this->assertStringContainsString($this->lang('CSV_INVALID', $this->lang('ALLOWED_SCHEMES_LINKS')), $crawler->filter('div[class="errorbox"] > p')->text());
$this->assertStringContainsString($this->lang('URL_SCHEME_INVALID', $this->lang('ALLOWED_SCHEMES_LINKS'), '2ftp'), $crawler->filter('div[class="errorbox"] > p')->text());
// Test empty setting - valid
$form = $crawler->selectButton($this->lang('SUBMIT'))->form([