mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-05-15 03:55:23 +02:00
Code Issues Releases Wiki Activity
16,251 Commits 18 Branches 192 Tags
499dd3a833
Commit Graph

16251 Commits

Author SHA1 Message Date
Joas Schilling
499dd3a833 [ticket/11495] Move tests to tree/ directory 
PHPBB3-11495
 2013-04-25 17:13:21 +02:00
Joas Schilling
b334a2ce0f [ticket/11495] Move classes to tree/ as they all implement a tree 
PHPBB3-11495
 2013-04-25 17:04:37 +02:00
Joas Schilling
94dee77647 [ticket/11495] Replace fixtures content with manual calls 
Should be easier to maintain

PHPBB3-11495
 2013-04-25 16:50:11 +02:00
Joas Schilling
c72f5bf487 [ticket/11495] Explain use of set_subset_zero on remove_subset() 
PHPBB3-11495
 2013-04-25 16:24:31 +02:00
Joas Schilling
804f139be0 [ticket/11495] Use default exceptions 
PHPBB3-11495
 2013-04-25 16:17:58 +02:00
Joas Schilling
9d7d962c0d [ticket/11495] Explain what "given item" means 
PHPBB3-11495
 2013-04-25 14:08:06 +02:00
Joas Schilling
fe97915fc9 [ticket/11495] Split get_branch_data into multiple methods 
PHPBB3-11495
 2013-04-25 14:05:41 +02:00
Joas Schilling
ab7054445f [ticket/11495] Rename set_parent to change_parent() 
PHPBB3-11495
 2013-04-25 13:48:19 +02:00
Joas Schilling
3efae6d8af [ticket/11495] Explain whether move_children prepends/appends/overwrittes 
PHPBB3-11495
 2013-04-25 13:44:52 +02:00
Joas Schilling
4bff28a0ee [ticket/11495] Rename fix function to regenerate_left_right_ids() 
This method regenerates the left/right ids for the nested set based on the
parent/child relations. This function executes three queries per item, so
it should only be called, when the set has one of the following problems:
- The set has a duplicated value inside the left/right id chain
- The set has a missing value inside the left/right id chain
- The set has items that do not have a left/right is set

When regenerating the items, the items are sorted by parent id and their
current left id, so the current child/parent relationships are kept and
running the function on a working set will not change any orders.

PHPBB3-11495
 2013-04-25 13:40:25 +02:00
Joas Schilling
61e72d3a10 [ticket/11495] Explain move() more 
An item is only moved up/down within the same parent. If the delta is larger
then the number of children, the item is moved to the top/bottom of the list
of children within this parent.

PHPBB3-11495
 2013-04-25 13:09:00 +02:00
Joas Schilling
e8b192fa32 [ticket/11495] Do not compare to null anymore (left over from item class) 
PHPBB3-11495
 2013-04-25 12:57:21 +02:00
Joas Schilling
87dc3b1e55 [ticket/11495] Use item ids instead of requiring all data 
The data is grabbed again in most cases anyway, so it just makes the system
easier to use.

PHPBB3-11495
 2013-04-19 21:07:42 +02:00
Joas Schilling
f66b5323a7 [ticket/11495] Cast some values to int 
PHPBB3-11495
 2013-04-19 19:09:22 +02:00
Joas Schilling
3d54a81ed9 [ticket/11495] Use item_id only as parameter for delete() and remove() 
The data is acquired again anyway

PHPBB3-11495
 2013-04-19 16:19:01 +02:00
Joas Schilling
d24ff2329f [ticket/11495] Use item_id only as parameter for get_branch_data() 
PHPBB3-11495
 2013-04-19 16:18:03 +02:00
Joas Schilling
f3ff8b36be [ticket/11495] Fix Spacing and lowercase on docs 
PHPBB3-11495
 2013-04-19 01:14:38 +02:00
Joas Schilling
5cb7342dd3 [ticket/11495] Remove acquire locks from forum implementation 
PHPBB3-11495
 2013-04-18 22:17:05 +02:00
Joas Schilling
b28180be1d [ticket/11495] Acquire locks for operations that manipulate the tree 
PHPBB3-11495
 2013-04-18 22:16:14 +02:00
Joas Schilling
153b29c6c9 [ticket/11495] Remove item class as its no longer required 
PHPBB3-11495
 2013-04-18 19:31:08 +02:00
Joas Schilling
a183fc1118 [ticket/11495] Manually specify the table columns 
PHPBB3-11495
 2013-04-18 00:54:26 +02:00
Joas Schilling
514bcb2fac [ticket/11495] Move nestedset default values to new method 
PHPBB3-11495
 2013-04-18 00:50:30 +02:00
Joas Schilling
e0393a3062 [ticket/11495] Fix column variable names 
PHPBB3-11495
 2013-04-18 00:34:09 +02:00
Joas Schilling
d11fed65da [ticket/11495] Remove item class from unit tests 
PHPBB3-11495
 2013-04-18 00:33:48 +02:00
Joas Schilling
86937e03ec [ticket/11495] Remove item classes 
PHPBB3-11495
 2013-04-18 00:15:02 +02:00
Joas Schilling
8c3443ba99 [ticket/11495] Use array directly instead of phpbb_nestedset_item_interface 
PHPBB3-11495
 2013-04-18 00:13:19 +02:00
Joas Schilling
5c379db085 [ticket/11495] Fix description of get_sql_where 
PHPBB3-11495
 2013-04-17 22:56:12 +02:00
Joas Schilling
f831e3c66e [ticket/11495] Use unique properties for the column names 
PHPBB3-11495
 2013-04-17 22:52:17 +02:00
Joas Schilling
dcee7961e8 [ticket/11495] Add unit tests for the implemented functions 
PHPBB3-11495
 2013-04-16 23:43:38 +02:00
Joas Schilling
57a05e7cf5 [ticket/11495] Add forum implementation of nestedset 
PHPBB3-11495
 2013-04-16 23:09:21 +02:00
Joas Schilling
0d5efcc1d5 [ticket/11495] Add abstract implementation of the interface 
PHPBB3-11495
 2013-04-16 23:08:35 +02:00
Joas Schilling
a1183a5889 [ticket/11495] Add basic interface with nestedset operations 
PHPBB3-11495
 2013-04-16 23:07:48 +02:00
Andreas Fischer
a0d10cd7fc Merge remote-tracking branch 'nickvergessen/ticket/11491' into develop 
* nickvergessen/ticket/11491:
  [ticket/11491] Copy files back only if we saved them previously
  [ticket/11491] Only copy files from phpBB/ext/ the directory exists
  [ticket/11491] Correctly remove the store/temp_ext/ directory after use
  [ticket/11491] Fix path to the ext/ folder
  [ticket/11491] Add extension_acp_test.php to functional group
  [ticket/11491] Fix class name of functional test
  [ticket/11491] Move file to correct directory
 2013-04-15 14:56:13 -04:00
Andreas Fischer
fbe115b434 Merge branch 'develop-olympus' into develop 
* develop-olympus:
  [ticket/11493] add checks for Notice and Warning
  [ticket/11493] add check for phpBB Debug in functional tests
 2013-04-15 14:27:52 -04:00
Andreas Fischer
453f98f6d3 Merge remote-tracking branch 'dhruvgoel92/ticket/11493' into develop-olympus 
* dhruvgoel92/ticket/11493:
  [ticket/11493] add checks for Notice and Warning
  [ticket/11493] add check for phpBB Debug in functional tests
 2013-04-15 13:15:03 -04:00
Andreas Fischer
b43ed11470 Merge remote-tracking branch 'marc1706/ticket/11488' into develop 
* marc1706/ticket/11488:
  [ticket/11488] Use correct base class in email notification method
 2013-04-15 13:10:10 -04:00
Dhruv
14071e6085 [ticket/11493] add checks for Notice and Warning 
PHPBB3-11493
 2013-04-15 22:02:21 +05:30
Dhruv
82a630cd64 [ticket/11493] add check for phpBB Debug in functional tests 
PHPBB3-11493
 2013-04-15 20:41:05 +05:30
Marc Alexander
c1dedabdfb [ticket/11488] Use correct base class in email notification method 
In ticket/11451 this was not correctly changed to reflect the new class
phpbb_notifcation_method_messenger_base. Additionally, an undefined
variable error has been fixed in messenger_base.php (change should be
confirmed by bantu though).

PHPBB3-11488
 2013-04-15 12:50:21 +02:00
Andreas Fischer
bf98122cf4 Merge remote-tracking branch 'nickvergessen/ticket/11494' into develop 
* nickvergessen/ticket/11494:
  [ticket/11494] Filter crawler in first place
  [ticket/11494] Use functions instead of repeating
  [ticket/11494] Fix memberlist leaders functional tests
 2013-04-14 21:40:01 -04:00
Joas Schilling
6bcc220df3 [ticket/11494] Filter crawler in first place 
PHPBB3-11494
 2013-04-15 03:37:03 +02:00
Joas Schilling
cbfe866eba [ticket/11494] Use functions instead of repeating 
PHPBB3-11494
 2013-04-13 18:03:02 +02:00
Andreas Fischer
ec33bada93 Merge remote-tracking branch 'hjpotter92/ticket/11225' into develop 
* hjpotter92/ticket/11225:
  [ticket/11225] Deletion of unused mcp_jumpbox.html file
 2013-04-13 00:23:22 -04:00
Nils Adermann
c25dfef770 Merge pull request from marc1706/ticket/11314 
[ticket/11314] Improve readability and code cleanup in new JavaScript files
 2013-04-12 06:32:13 -07:00
Nils Adermann
653666c76e Merge branch 'develop-olympus' into develop 
* develop-olympus:
  [ticket/11358] Removed all trailing white spaces.
  [ticket/11358] Fixed the code according to coding guidlines.
 2013-04-12 14:03:56 +02:00
Nils Adermann
0ce94fde77 Merge branch 'ticket/11358' into develop-olympus 
* ticket/11358:
  [ticket/11358] Removed all trailing white spaces.
  [ticket/11358] Fixed the code according to coding guidlines.
 2013-04-12 14:03:24 +02:00
erangamapa
7d8bbcd596 [ticket/11358] Removed all trailing white spaces. 
Removed all trailing white spaces with new lines.

PHPBB3-11358
 2013-04-12 14:03:06 +02:00
erangamapa
00b45fa4dc [ticket/11358] Fixed the code according to coding guidlines. 
Added proper indentation and new line after break in switch
statement.

PHPBB3-11358
 2013-04-12 14:02:51 +02:00
Joas Schilling
13ca1f5598 [ticket/11491] Copy files back only if we saved them previously 
PHPBB3-11491
 2013-04-12 02:18:38 +02:00
Joas Schilling
3436e3f102 [ticket/11491] Only copy files from phpBB/ext/ the directory exists 
PHPBB3-11491
 2013-04-12 02:03:58 +02:00