[ticket/12839] Include update related templates and assets in the package
* nickvergessen/ticket/12839:
[ticket/12839] Include update related templates and assets in the package
[ticket/12768] 'NOTIFICATION_REPORT_CLOSED' entry has wrong indentation
* n-aleha/ticket/12768:
[ticket/12768] More fixes in language files
[ticket/12768] 'NOTIFICATION_REPORT_CLOSED' entry has wrong indentation
[ticket/12818] Deleting a log entry in MCP produces a General error
* Nicofuma/ticket/12818:
[ticket/12818] Use assertGreaterThanOrEqual in the tests
[ticket/12818] Don't use the id for i=
[ticket/12818] Add tests
[ticket/12818] Fix the conditions in the call to $log->delete() in mcp_logs
[ticket/12775] Replace functions_container with a container_builder class.
* Nicofuma/ticket/12775: (34 commits)
[ticket/12775] Set dbal.conn.driver as synthetic during installation
[ticket/12775] Add the definition of dbal.conn in fixtures/config/services.yml
[ticket/12775] Inject the connection when created in the container
[ticket/12775] Extract the vars later in install/install_update.php
[ticket/12775] Rename config_php_handler to config_php_file container_builder
[ticket/12775] Set defined_vars as a property of config_php_file
[ticket/12775] Fix doc blocks in the container builder
[ticket/12775] Remove useless includes of config.php
[ticket/12775] Move phpbb_convert_30_dbms_to_31 into the config file class
[ticket/12775] Fix comments
[ticket/12775] Update doc blocks
[ticket/12775] Fix container_builder
[ticket/12775] Rename config_php to config_php_file
[ticket/12775] Renamed to \phpbb\di\container_builder
[ticket/12775] Remove the last include of functions_container
[ticket/12775] Fix unit tests
[ticket/12775] Add tests for \phpbb\config_php
[ticket/12775] Add tests for the container factory
[ticket/12775] Use a field instead of a local var in load_config_var()
[ticket/12775] Update container and config in install/
...
[ticket/12695] Add viewtopic language file for parse_attachments in mcp_...
* marc1706/ticket/12695:
[ticket/12695] Add viewtopic language file for parse_attachments in mcp_post
[ticket/12786] Extend profilefield_base_migration.php class
* lucifer4o/ticket/12786:
[ticket/12786] Correcting some tabs
[ticket/12786] Array_merge instead copy array parts
[ticket/12786] Some changes of the comments.
[ticket/12786] Dixing a typo
[ticket/12786] Some minor fixes of comments and function naming
[ticket/12786] Add clean_cpf_db_entries
[ticket/12786] White spaces found
[ticket/12786] Add create_language_entries
[ticket/12786] Add get_custom_field_id
[ticket/12786] Extend profilefield_base_migration.php class
[ticket/12787] Allow the route to say that the referer has to be used.
* Nicofuma/ticket/12787:
[ticket/12787] Updates phpbb_mock_controller_helper
[ticket/12787] Add controller_helper::get_current_url()
[ticket/12787] Remove one app.php when it's both in $path and $web_root_path
[ticket/12787] Fix the absolute board url
[ticket/12787] Use a parameter (_referer) instead of the Referer header
[ticket/12099] Add unit tests for get_web_root_path_from_ajax_referer()
[ticket/12099] Remove config again
[ticket/12099] Correctly fix the path when performing AJAX requests
[ticket/12099] Add request argument to path_helper service
[ticket/12825] Better sniff for the extensions and skip the vendor/ directory
* Nicofuma/ticket/12825:
[ticket/12825] Better sniff for the extensions and skip the vendor/ directory
[ticket/12782] Use an interface for the phpbb event_dispatcher
* Nicofuma/ticket/12782:
[ticket/12782] Add doc block
[ticket/12782] Use an interface for the phpbb event_dispatcher
* PayBas/ticket/12813:
[ticket/12813] Move inline-CSS to css file
[ticket/12813] Use -moz-only fix instead of generic padding
[ticket/12813] Reorder .row pagination so it aligns better
[ticket/12813] Fix page-jump title lang and use input type=number
[ticket/12810] Use correct template vars for shadow pruning settings
* marc1706/ticket/12810:
[ticket/12810] Use correct template vars for shadow pruning settings
[ticket/12013] Use new dropdown for quickmod tools and jumpbox.
* prototech/ticket/12013:
[ticket/12013] Fix functional tests and sniffer issue.
[ticket/12013] Clear the jumpbox.
[ticket/12013] Add moderator tools icon.
[ticket/12013] Remove obsolete jumpbox and quickmod CSS.
[ticket/12013] Prevent the dropdown scrollbar from overlapping the content.
[ticket/12013] Update to use the new .button class.
[ticket/12013] Add missing class to place the buttons on the rightside.
[ticket/12013] Use the correct variable for the forum id.
[ticket/12013] Use DEFINE instead of Twig's set.
[ticket/12013] Use path helper.
[ticket/12013] Use new dropdown for quickmod tools and jumpbox.
* PayBas/ticket/12662: (29 commits)
[ticket/12662] Hide quick-links when empty
[ticket/12662] Fix white-space issue to make dropdowns uniform
[ticket/12662] Remove last remaining linklist outside navbars
[ticket/12662] Use data-last-responsive attr instead of hardcoded list
[ticket/12662] Remove <li> container from logged_out_content event
[ticket/12662] Username <span> fix for list columns
[ticket/12662] Fix notifications dropdown positioning for RTL
[ticket/12662] Update tests that utilize get_username_string
[ticket/12662] Update subsilver2 index template event names
[ticket/12662] Update events docs from b5 to rc1/rc2
[ticket/12662] Move dropdown container from <li> to new inner div
[ticket/12662] Remove linklist container and update template events
[ticket/12662] Add span containers to all usernames for consistency
[ticket/12662] IE8 fixes
[ticket/12662] Fix responsive positioning of notifications dropdown
[ticket/12662] Remove inherited props from ddown-extendended
[ticket/12662] Change CSS selectors to direct descendants for linklist
[ticket/12662] Reorder icon CSS rules alphabetically
[ticket/12662] Use slack variable to determine line-break sensitivity
[ticket/12662] Change new event names and fix events.md
...
* 'ticket/12562' of https://github.com/PayBas/phpbb:
[ticket/12562] Use border for all sizes except responsive
[ticket/12562] Use Hanakin's version
[ticket/12562] Increase mq trigger screen size to hide border
[ticket/12562] Add max-width to proSilver
Ticket/12783 Move require:phpbb/phpbb to extra:phpbb/phpbb in Extensions composer.json files
* nickvergessen/ticket/12783:
[ticket/12783] Move phpbb requirement to extra->soft-require
[ticket/12783] Correctly use dataProviders and mark tests as incomplete
[ticket/12783] Move phpbb/phpbb require version to extra
[ticket/12781] Template regex for IF catch too many things
* Nicofuma/ticket/12781:
[ticket/12781] Add tests
[ticket/12781] Template regex for IF catch too many things
[ticket/9801] Allow display of page outside board directory on viewonline
* marc1706/ticket/9801:
[ticket/9801] Use empty instead of sizeof
[ticket/9801] Remove spaces before * in docblock
[ticket/9801] Add viewonline_helper service to allow proper testing
[ticket/9801] Allow display of page outside board directory on viewonline
[ticket/12784] Allow the extensions to add a custom auto loader
* Nicofuma/ticket/12784:
[ticket/12784] Shearch the "vendor" folders and then the autoload.php files
[ticket/12784] Allow the extensions to add a custom auto loader
[ticket/12334] Add PROFILE_FIELD_VALUE_RAW template var
* Dragooon/ticket/12334:
[ticket/12334] Remove profile fields test group
[ticket/12334] Add additional test for type_string
[ticket/12334] Add string test for type_int
[ticket/12334] Improve type_dropdown's test description
[ticket/12334] Group profile fields test
[ticket/12334] Change get_profile_value_raw_data to profile_value_raw_data
[ticket/12334] Add get_profile_value_raw unit test for type_bool
[ticket/12334] Add get_profile_value_raw unit test for type_date
[ticket/12334] Add get_profile_value_raw unit tests for type_dropdown
[ticket/12334] Add get_profile_value_raw unit test for type_string
[ticket/12334] Add get_profile_value_raw unit test for type_url
[ticket/12334] Add get_profile_value_raw unit tests for type_int
[ticket/12334] Removed tests
[ticket/12334] Dropdowns cannot be tested this way
[ticket/12334] Added test get_profile_value_raw
[ticket/12334] Changed from valueid to value_raw
[ticket/12334] Implemented get_profile_valueid method
[ticket/12334] Added field_novalue fall-back as requested
[ticket/12334] Add PROFILE_FIELD_VALUEID template var
[ticket/12790] Use \phpbb\db\driver\driver_interface in prune_shadow_topics
* Nicofuma/ticket/12790:
[ticket/12790] Use \phpbb\db\driver\driver_interface in prune_shadow_topics
If the current request is a AJAX we need to fix the paths.
We need to get the root path based on the Referer, so we can use
the generated URLs in the template of the Referer. If we do not
generate the relative path based on the Referer, but based on the
currently requested URL, the generated URLs will not point to the
intended locations:
Referer desired URL desired relative root path
memberlist.php faq.php ./
memberlist.php app.php/foo/bar ./
app.php/foo memberlist.php ../
app.php/foo app.php/fox ../
app.php/foo/bar memberlist.php ../../
../page.php memberlist.php ./phpBB/
../sub/page.php memberlist.php ./../phpBB/
PHPBB3-12099
If extensions authors will use profilefield_base_migration.php
class as base class for creation of CPFs, the class need to be
extended a bit.
At the moment there are two issues with it:
It does not create entries for PROFILE_FIELDS_LANG_TABLE
(as it can't know what fields to create).
The migration is not "cleaning" the DBMS after purging
the extension and leaves everything except the CPF column.
Adding profilefield_language_data
PHPBB3-12786
[ticket/12716] Add the missing parameters in the call of clearToken
* Nicofuma/ticket/12716:
[ticket/12716] Use a string as session_id
[ticket/12716] Add regression test
[ticket/12716] Add the missing parameters in the call of clearToken
[ticket/12764] Properly handle errors upon connecting to MySQLi database
* marc1706/ticket/12764:
[ticket/12764] Properly handle errors upon connecting to MySQLi database
[ticket/12771] Bug in profilefield_base_migration when used in ext
* lucifer4o/ticket/12771:
[ticket/12771] Shanging substr to strpos
[ticket/12771] Change var name
[ticket/12771] Bug in profilefield_base_migration when used in ext
[ticket/12759] Resolve query flooding while displaying large number of custom profile fields
* Dragooon/ticket/12759:
[ticket/12759] Fix type_bool and type_dropdown's UCP fields
[ticket/12759] Remove lang_helper from profilefields_manager
[ticket/12759] Cache all lang_options in lang_helper instead
[ticket/12759] Extra line in profilefields_manager
[ticket/12759] Cache lang_options for pm_viewmessage
[ticket/12759] Cache lang_options on memberlist
[ticket/12759] Add phpDoc comments to explain get_option_lang
[ticket/12759] Little code cleanup
[ticket/12759] Make sure $field_id has unique elements
[ticket/12759] Cache the lang options earlier
[ticket/12759] Cache lang options for all fields while displaying
[ticket/12759] Allow multiple fields to be loaded via get_option_lang
Previously these would be fetched one field at one time, causing a large
number of queries in case there were large number of custom profile fields
and/or unique number of users in areas such as viewing topics. Resolve this
by caching them at once when generating data for displaying them in templates.
PHPBB3-12759
[ticket/12325] Automatic update should notify about outdated files
* Nicofuma/ticket/12325:
[ticket/12325] Fix the language var name
[ticket/12325] Update coding style in template
[ticket/12325] Fix: add a missing colon
[ticket/12325] Don't use L_COLON
[ticket/12325] Fix: it's not stuck in an inifinite loop anymore
[ticket/12325] Automatic update should notify about outdated files
[ticket/12773] Fix language variable name in cli extension enable command
* n-aleha/ticket/12773:
[ticket/12773] Fix language variable name in cli extension enable command
* nickvergessen/ticket/12099:
[ticket/12099] Fix correction in path_helper test
[ticket/12099] Prepend ./ to path to fix assets
[ticket/12099] Deduplicate path generation
[ticket/12099] Fix clean_path() ".." stripping when previous directory was "."
[ticket/12099] Break clean_path tests with a simple test
[ticket/12099] Clean paths in tests
[ticket/12099] Correctly fix go back to root before prepending the root path
[ticket/12099] Clean some paths before using them
[ticket/12099] Fix several issues in path_helper test
As the db_connect_id gets set up by mysql_init(), the db_connect_id will be an
object with empty settings instead of just empty. Even if mysql_real_connect()
encounters an error upon connecting, the db_connect_id is still set. This
will result in trying to just access the database which obviously does
nothing.
By setting db_connect_id to an empty string, the script will not try to query
th database and properly handle any errors that occur upon connecting.
PHPBB3-12764
The base migration class should create lang entry for the new CPF
but it is supposed to strip it of phpbb_ prefix. As extensions
CPFs do not use phpbb_ prefix it will not create a lang entry.
This is as simple solution as it can be done.
PHPBB3-12771
[Ticket/12680] - Adds alternative text to contact icon in viewtopic.php
* Crizz0/ticket/12680:
[ticket/12680] Adds variable for guest user
[ticket/12680] Brings back get_username_string()
[ticket/12680] Solves last bugs. viewprofile: contact --> contact nickname
[ticket/12680] Still some problems with displaying the nickname in ucp
[ticket/12680] Little changes, but some issues are still there
[ticket/12680] Removes unnessesary $user->lang from CONTACT_USER
[ticket/12680] Adds alternativ text with new variable to contact:
[ticket/12680] Adds second alternativ text and font-size: 0 to remove text
[ticket/12680] Adds alternative text to contact icon in viewtopic.php
* prep-release-3.1.0-RC1:
[prep-release-3.1.0-RC1] Update phpBB Version for RC2 development
[prep-release-3.1.0-RC1] Add changelog for 3.1.0-RC1
[prep-release-3.1.0-RC1] Prepare Changelog
[prep-release-3.1.0-RC1] Add migration for 3.1.0-RC1
[prep-release-3.1.0-RC1] Update version to 3.1.0-RC1
* develop-olympus:
[ticket/12755] Apply de morgan to conditional
[ticket/12755] Terminate upload loop if upload reaches filesize
[ticket/12755] Change upload in remote_upload() method to fit get_remote_file
[ticket/12755] Add language string for timed out remote upload
[ticket/12755] Add timeout to remote upload to prevent infinite loop
[ticket/12755] Add timeout to remote upload to prevent infinite loop
* marc1706/ticket/12755:
[ticket/12755] Apply de morgan to conditional
[ticket/12755] Terminate upload loop if upload reaches filesize
[ticket/12755] Change upload in remote_upload() method to fit get_remote_file
[ticket/12755] Add language string for timed out remote upload
[ticket/12755] Add timeout to remote upload to prevent infinite loop
Terminate the upload loop if the expected filesize has been reached instead
of trying to read more bytes until the timeout has been reached.
PHPBB3-12755
* github-nickvergessen/ticket/12612:
[ticket/12612] Prefix check_ids() with phpbb_
[ticket/12612] Prefix mcp_sorting() with phpbb_
[ticket/12612] Prefix get_*_data() with phpbb_ and delete unused global
[ticket/12612] Prefix module url functions with phpbb_
[ticket/12612] Prefix upload_popup() with phpbb_
[ticket/12612] Prefix handle_post_delete() with phpbb and remove unused global
[ticket/12612] Prefix custom UCP module function with phpbb_
[ticket/12612] Prefix _sort_last_active() with phpbb_
[ticket/12612] Prefix show_profile() with phpbb and delete unused global
Ticket/12763 Do not regenerate the *_schema.sql files
* nickvergessen/ticket/12763:
[ticket/12763] Remove invalid comment from oracle and postgres *_schema.sql
[ticket/12763] Remove empty schema files
[ticket/12763] Do not regenerate the *_schema.sql files
[ticket/11528] Refactor install_board( ) into a new mink class
* dhruvgoel92/ticket/11528:
[ticket/11528] Change click_submit() to accept id as param
[ticket/11528] Handle case when config file cant be written by installer
[ticket/11528] Change NULL to null
[ticket/11528] Fix spaces and slashes as per guidelines
[ticket/11528] Add asserts in installation steps
[ticket/11528] Use 'use' keyword to import classes to current scope
[ticket/11528] Move parent::tearDown() to end of tearDown()
[ticket/11528] Call parent::tearDown in overrided tearDown method
[ticket/11528] Instantiate $client, $driver from functional test case
[ticket/11528] Refactor install_board() code into a new class
[ticket/11528] Add behat/mink and mink-goutte-driver as dependency
[Ticket/12696] Add events to ucp_register.html
* lucifer4o/ticket/12696:
[ticket/12696] Typo
[ticket/12696] Change some parts
[ticket/12696] Naming convention changes
[ticket/12696] A small error with events.md perms
[ticket/12696] Add events to evets.md
[ticket/12696] Add prosilver ucp_register
[ticket/12696] Add events to ucp_register.html
[ticket/12690] Add core.submit_pm_after event
* lucifer4o/ticket/12690:
[ticket/12690] Find a space
[ticket/12690] Remove $msg_id and chmod
[ticket/12690] Add other info to core.submit_pm_after
[ticket/12690] Add core.submit_pm_after event
* github-nickvergessen/ticket/12612-ascraeus:
[ticket/12612] Move functions from mcp.php to functions_mcp.php
[ticket/12612] Move function from ucp.php to functions_user.php
[ticket/12612] Move functions from memberlist.php to functions_display.php
[ticket/12612] Move functions from posting.php to functions_posting.php
[ticket/12747] Drop support for Firebird
* nickvergessen/ticket/12747:
[ticket/12747] Remove some methods which are not used anymore
[ticket/12747] Drop support for Firebird
Conflicts:
phpBB/phpbb/db/driver/firebird.php
[ticket/12704] Improve the load time information in the footer when enabled
* rxu/ticket/12704:
[ticket/12704] Improve the load time information in the footer when enabled
[ticket/12714] Switching the description of radio buttons to align the correct description above the listbox
* Skouat/ticket/12714:
[ticket/12714] Move "allow all forums" in its own dd-element
[Ticket/12701] Add events to user_add function
* lucifer4o/ticket/12701:
[ticket/12701] Add change
[ticket/12701] Rmove before event and expand modify_data
[ticket/12701] Add events to user_add function
Add events to UCP Register template:
ucp_register_before - add before start of registration form fields
ucp_register_after - add after end of registration form fileds
ucp_register_passowrd_after - add event after passowrd field
ucp_register_language_before - add event before language selector
ucp_register_profiles_before - add event just before begining of
registration profile informatiom
All events are inside the registration form fieldset.
All events are inside the registration form
Justification:
Add abbility of extension author to include custom
checks or fields inside the registration form.
Like age check field/verification.
PHPBB3-12696
Add two new events to user_add function
in ./includes/functions_user.php.
core.user_add_before - allow modification of
submitted to function data.
Returns:
@var array $user_row - user_row array - User array
@var array $cp_data - cp_data array - CPF array
core.user_add_after - return user_id, user_row and
cp_data after user registration
Returns:
@var int $user_id - user_id of the new user
@var array $user_row - user_row array - User array
@var array $cp_data - cp_data array - CPF array
Justification:
Allow extensions to parse data before and after
creation of the user.
PHPBB3-12701
Add core.delete_pm to funtion delete_pm.
Event will return:
int $user_id - ID of the user requested the message delete
array $msg_ids - array of all messages to be deleted
int $folder_id - ID of the user folder where the messages are stored
Justification:
Allow extensions to capture this event
and act as intended by ext author
PHPBB3-12691
Add core.submit_pm_after to funtion submit_pm.
Event will return just submited msg_id. It should be plased
just before return $data['msg_id'];
Justification:
Using only core.submit_pm_before does not allow to
follow up after message submission.
The message ID is recieved at DB submission.
Some times we need the MSG_ID as identifier
PHPBB3-12690
[ticket/12758] Add show_results var to core.search_modify_rowset
* PayBas/ticket/12758:
[ticket/12758] Add @changed to doc block
[ticket/12758] Add show_results var to core.search_modify_rowset
[ticket/12753] Add invalid chars string for ALPHA_DOTS and ALPHA_PUNCTUAION
* Dragooon/ticket/12753:
[ticket/12753] Add invalid chars string for ALPHA_DOTS and ALPHA_PUNCTUATION
[ticket/12730] Add Google+ profile field
* Dragooon/ticket/12730:
[ticket/12730] Update Google+ button class to use proper identification
[ticket/12730] Update maxlen for type_googleplus to 255
[ticket/12730] Fix type_googleplus_test to use same validation rule as the field
[ticket/12730] Update field_length to be 20 by default for Google+
[ticket/12730] Google+ field_order should be 13
[ticket/12730] Switch service name to googleplus for type_googleplus
[ticket/12730] Restore field_length to 10 for type_googleplus
[ticket/12730] Add functional test for Google+ field
[ticket/12730] Value shouldn't be escaped for schema_data.sql
[ticket/12730] Missing newline at type_googleplus_test.php
[ticket/12730] Set field_active to 1 for Google+ field
[ticket/12730] Add unit test for type_googleplus
[ticket/12730] Add missing brackets to type_googleplus.php
[ticket/12730] Update field_order for Google+ CPF
[ticket/12730] Use string template for Google+ CPF instead of a new one
[ticket/12730] Minor formatting fixes
[ticket/12730] Incorrect indentation for type_googleplus
[ticket/12730] Spaces in block header
[ticket/12730] Add a Google+ field by default
[ticket/12730] Add Google+ profile field type
[ticket/12723] Add Sniff ensuring PHP files use the correct file header
* Nicofuma/ticket/12723:
[ticket/12723] Do not mention too many details on documentation.
[ticket/12723] Do not reference the coding guidelines section.
[ticket/12757] Add a Code Sniffer ruleset for PHP files of phpBB extensions
[ticket/12723] Properly describe new Code Sniffer rulsets.
[ticket/12723] Use core suffix in filename instead of phpbb in the middle.
[ticket/12723] Add Sniff ensuring PHP files use the correct file header
[ticket/12752] Cron list tests fail on windows with ansi support
* Nicofuma/ticket/12752:
[ticket/12752] Cron list tests fail on windows with ansi support
Google+ has a "+" before a custom URL but doesn't for those which are using
their integer ID. To cover that we need to have an extra profile field
PHPBB3-12730
[ticket/12731] Add YouTube custom profile field
* Dragooon/ticket/12731:
[ticket/12731] Add functional test for youtube field
[ticket/12731] Set field_active to 1 for YouTube field
[ticket/12731] Add YouTube custom profile field
Conflicts:
phpBB/install/schemas/schema.json
phpBB/install/schemas/schema_data.sql
phpBB/language/en/memberlist.php
tests/functional/ucp_profile_test.php
[ticket/12732] Add Skype custom profile field
* Dragooon/ticket/12732:
[ticket/12732] Update schema.json for Skype
[ticket/12732] Add functional test for Skype profile field
[ticket/12732] Values shouldn't be escaped for schema_data.sql
[ticket/12732] Set field_active to 1 for Skype's field
[ticket/12732] Add unit tests for ALPHA_PUNCTUATION
[ticket/12732] Missing comma after validation definition
[ticket/12732] Improve ALPHA_PUNCTUATION description
[ticket/12732] Use user info instead of chat as default Skype action
[ticket/12732] Add Skype custom profile field
Conflicts:
phpBB/install/schemas/schema.json
phpBB/install/schemas/schema_data.sql
phpBB/language/en/memberlist.php
tests/functional/ucp_profile_test.php
tests/profilefields/type_string_test.php
[ticket/12733] Add Twitter custom profile field
* Dragooon/ticket/12733:
[ticket/12733] Add functional test for twitter profile field
[ticket/12733] Values needn't be escaped for schema_data.sql
[ticket/12733] Set field_active to 1 for Twitter
[ticket/12733] Convert spaces to tabs
[ticket/12733] Fix spacing for block header in profilefield_twitter.php
[ticket/12733] Update schema.json
[ticket/12733] Add Twitter custom profile field
Conflicts:
phpBB/install/schemas/schema.json
phpBB/install/schemas/schema_data.sql
phpBB/language/en/memberlist.php
tests/functional/ucp_profile_test.php
[ticket/12729] Add Facebook custom profile field
* Dragooon/ticket/12729:
[ticket/12729] Add functional test for Facebook field
[ticket/12730] Values needn't be escaped for schema_data.sql
[ticket/12729] Set field_active as 1 for Facebook profile field
[ticket/12729] Add unit test for ALPHA_DOTS validation
[ticket/12729] Move ALPHA_DOTS to above ALPHA_SPACERS
[ticket/12729] Convert spaces to tabs
[ticket/12729] Fix block header spacing for profilefield_facebook.php
[ticket/12729] Update schema.json
[ticket/12729] Unnecessary whitespace in profilefield_facebook.php
[ticket/12729] Cleanup schema_data.sql for Facebook field
[ticket/12729] Add Facebook custom profile field
[ticket/12746] Init phpbb_dispatcher being used by delete_post()
* dhruvgoel92/ticket/12746:
[ticket/12746] Init phpbb_dispatcher being used by delete_post()
PR #2570 has added new constant to display load time information without
debug mode is being on (https://tracker.phpbb.com/browse/PHPBB3-12687).
This patch expands the total load time info with SQL/PHP load times,
while hiding the additional info with <abbr> element.
PHPBB3-12704
[ticket/12514] Add tests for profile fields
* Dragooon/ticket/12514: (28 commits)
[ticket/12514] Fix array formatting for tests
[ticket/12514] Fix indention for type_url_test.php
[ticket/12514] Missed a few spaces in comments
[ticket/12514] Convert spaces to tabs
[ticket/12514] Add a few additional tests for type_dropdown
[ticket/12514] Add a few additional tests for type_int
[ticket/12514] Fix some formatting for tests
[ticket/12514] Add a few more tests for type_date
[ticket/12514] Remove spaces in header blocks
[ticket/12514] Use generic domain name for URL test
[ticket/12514] Update file headers to represent the current format
[ticket/12514] Remove get_ prefix from data providers
[ticket/12514] Add a few more validation cases for type_string_test
[ticket/12514] Minor fault in type_bool_test.php
[ticket/12514] Remove tests/profiles as they're no longer required
[ticket/12514] Fix type_int_test to correctly respect boundaries
[ticket/12514] Multi value GET parameters are invalid for phpBB
[ticket/12514] Add unit test for type_url custom profile field
[ticket/12514] Add unit test for type_date custom profile field
[ticket/12514] Add unit test for type_bool custom profile field
...
[ticket/11711] Inform user of unsupported characters while posting
* marc1706/ticket/11711:
[ticket/11711] Improve coding and comments of character check
[ticket/11711] Reduce size of tests and also test topic titles
[ticket/11711] Improve checks for unsupported characters and check subject
[ticket/11711] Inform user of unsupported characters while posting
[ticket/12553] Right-to-left fixes.
* prototech/ticket/12553:
[ticket/12553] Fix responsive user profile.
[ticket/12553] Fix responsive post profile.
[ticket/12553] Remove dropdown-trigger class from member search input.
[ticket/12553] Fix the merge topic list.
[ticket/12553] Fix dropdown position of live search
[ticket/12553] Fix the responsive topic/forum lists.
[ticket/12553] Align the text in responsive tables to the right.
[ticket/12553] Center the responsive CP menus instead of floating right.
[ticket/12553] Open the notification dropdown to the left.
[ticket/12553] Fix alignment of contact icon.
[ticket/12553] Fix incorrect alignment in ACP responsive tables.
[ticket/12553] Align alert text to the right.
[ticket/12553] Remove incorrect size for site logo.
[ticket/12553] Fix links in the last post column that are not clickable.
[ticket/12553] Align contact icons to the right.
[ticket/12553] Move Place inline and Delete buttons left of the file name.
[ticket/12638] v30x\local_url_bbcode break the migrations if we don't use the auto updater
* Nicofuma/ticket/12638:
[ticket/12638] Use require if phpbb_require_updated isn't available
[Ticket/12699] Remove magic numbers in the message textarea keydown callback
* brunoais/ticket/12699:
[ticket/12699] Replace magic numbers for the TAB and for ENTER keydown
[ticket/12699] Add tab key to keymap
[ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset
* Nicofuma/ticket/12722:
[ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset
[ticket/12720] Allow commit heading to begin with lowercase letters
* dhruvgoel92/ticket/12720:
[ticket/12720] Allow commit heading to begin with lowercase letters
Ticket/12643 Fixes deletion of columns that have the target column as a prefix
* Noxwizard/ticket/12643:
[ticket/12643] Properly handle changing columns on tables with constraints
[ticket/12643] Tests dropping similarly named columns
[ticket/12643] Ensure that similarly named columns are not removed
[ticket/12715] Fix mistakes in the doc blocks
* Nicofuma/ticket/12715: (30 commits)
[ticket/12715] Add missing new line in the notification manager
[ticket/12715] Cleanup comments in \phpbb\symfony_request
[ticket/12715] Cleanup comments in \phpbb\permissions
[ticket/12715] Cleanup comments in \phpbb\path_helper
[ticket/12715] Cleanup comments in \phpbb\pagination
[ticket/12715] Cleanup comments in \phpbb\datetime
[ticket/12715] Cleanup comments in \phpbb\content_visibility
[ticket/12715] Cleanup comments in \phpbb\tree\*
[ticket/12715] Cleanup comments in \phpbb\template\*
[ticket/12715] Cleanup comments in \phpbb\plupload\*
[ticket/12715] Cleanup comments in \phpbb\profilefields\*
[ticket/12715] Cleanup comments in \phpbb\passwords\*
[ticket/12715] Cleanup comments in \phpbb\notification\*
[ticket/12715] Cleanup comments in \phpbb\mimetype\*
[ticket/12715] Cleanup comments in \phpbb\message\*
[ticket/12715] Cleanup comments in \phpbb\log\*
[ticket/12715] Cleanup comments in \phpbb\lock\*
[ticket/12715] Cleanup comments in \phpbb\groupposition\*
[ticket/12715] Cleanup comments in \phpbb\feed\*
[ticket/12715] Cleanup comments in \phpbb\extension\*
...
[ticket/12712] Add user_password to GROUP BY clause to fix query for mssql
* marc1706/ticket/12712:
[ticket/12712] Remove unneeded GROUP BY clause to fix query for mssql
* PayBas/ticket/12613: (25 commits)
[ticket/12613] Add distinction between top/bottom action-bar
[ticket/12613] Replaced topic-actions with action-bar
[ticket/12613] Remove responsive linklist from memberlist
[ticket/12613] Remove unnecessary checks and clean up CSS
[ticket/12613] role="navigation" not allowed on <ul>
[ticket/12613] Improved screen reader functionality
[ticket/12613] Removed unnecessary checks
[ticket/12613] Set fixed font-size
[ticket/12613] Slightly better icons
[ticket/12613] Typo and L_COLON
[ticket/12613] Small inconsistency fixes
[ticket/12613] Don't display page-jump if all pages are visible (6)
[ticket/12613] Fixes from comments (single quotes and typos)
[ticket/12613] Minor $bull; and <hr> fix
[ticket/12613] Pagination should never be in responsive linklist
[ticket/12613] Minor CSS fixes
[ticket/12613] Dropdown-visible page-jump icon, fix focus() timing
[ticket/12613] Renamed jump-to to page-jump to prevent confusion
[ticket/12613] Removed form in order to prevent nested forms
[ticket/12613] Fix functional test and post sorting bug
...
The value is stored in a text column and the key is stored in a varchar. Some
DBMSes do not like it when we insert integers into text columns. Cast both to
string to be on the safe side.
PHPBB3-12711
The relative position of the <dt> is causing it to sit atop of the <dd> thus
preventing the user from clicking the links. The <dl> has a relative position
in LTR, which takes care of containing the read/unread icon link that has an
absolute position. We no longer support IE6, so removing the tweak that sets
the <dl> position to static will make everything behave the same way in RTL as
in LTR.
PHPBB3-12553
[ticket/12707] Do not try to load 3.1 DBMS driver name as 3.0 driver.
* bantu/ticket/12707:
[ticket/12707] Do not try to load 3.1 DBMS driver name as 3.0 driver.
[ticket/12575] Use a proxy pattern in \phpbb\di\service_collection
* Nicofuma/ticket/12575:
[ticket/12575] Use strict comparison
[ticket/12575] Add missing property
[ticket/12575] Usethe new header
[ticket/12575] Fix 2 typos in comments
[ticket/12575] Fix typos in comments
[ticket/12575] Skip sniffer issue triggered by the solution of a php bug
[ticket/12575] Remove inline assignments
[ticket/12575] Fix the tests
[ticket/12575] Move service_collection_iterator to its own file
[ticket/12575] Speed up load_class()
[ticket/11445] optimize no of queries in get_global_subscriptions( )
* dhruvgoel92/ticket/11445:
[ticket/11445] Move get user's notification code into its own method
[ticket/11445] Remove unused foreach key $group_name
[ticket/11445] Improve unit tests for get_global_subscriptions
[ticket/11445] Optimize no of queries in get_global_subscriptions
[ticket/12682] Make Code Sniffer run properly on Travis CI again.
* bantu/ticket/12682:
[ticket/12682] Make Code Sniffer run properly on Travis CI again.
[ticket/12687] Add a constant to display the load time without DEBUG
* Nicofuma/ticket/12687:
[ticket/12687] Remove french spaces
[ticket/12687] Display the number of cached queries
[ticket/12687] Don't check if memory_get_peak_usage() exists
[ticket/12687] Wrap $GLOBALS['starttime'] in a if
[ticket/12687] Fix the namespace of $request
[ticket/12687] Update doc block
[ticket/12687] Use microtime(true)
[ticket/12687] Remove globals
[ticket/12687] Return a string and move the displaying of the sql report
[ticket/12687] Rename DISPLAY_LOAD_TIME to PHPBB_DISPLAY_LOAD_TIME
[ticket/12687] Display the explain link only when DEBUG is set
[ticket/12687] Add a constant to display the load time without DEBUG
The --ignore parameter takes a case-insensitive pattern and as such
'phpBB/phpbb/*' matches any '/home/travis/build/phpbb/phpbb/...' file name.
This results in nothing being checked against ruleset-php-legacy.xml.
Using absolute paths in the --ignore pattern fixes this issues.
PHPBB3-12682
Until now, the preg_match didn't take into account that a page might be
outside the board directory. After this change, the regular expression will
allow preceding dots and slashes. Paths like ../../test.php will be allowed.
The page will be unknown in viewonline.php and it will revert to index.php as
current page. However, the core.viewonline_overwrite_location event will
receive proper info of the page the user is on right now allowing a listener
to change the info that is being displayed.
PHPBB3-9801
* github-marc1706/ticket/12352: (33 commits)
[ticket/12352] Do not check hashes that don't have the necessary length
[ticket/12352] Update file headers to fit new format
[ticket/12352] Use custom provider collection for auth providers
[ticket/12352] Add checks for existing user_pass_convert to migrations
[ticket/12352] Remove usages of user_pass_convert column
[ticket/12352] Update schema json file
[ticket/12352] Remove user_pass_convert column from database
[ticket/12352] Check each newly added passwords driver in manager_test
[ticket/12352] Add get_settings_only method to passwords driver base
[ticket/12352] Add passwords driver for xenforo 1.0, 1.1 passwords
[ticket/12352] Add tests for wcf1 and wcf2 drivers
[ticket/12352] Add driver for woltlab community framework 1 passwords
[ticket/12352] Add driver for woltlab community framework 2 passwords
[ticket/12352] Add missing $ to md5_mybb and md5_vb driver
[ticket/12352] Fix spacing in passwords tests
[ticket/12352] Add passwords driver for vB passwords
[ticket/12352] Use correct hashing method in md5_mybb driver
[ticket/12352] Add driver for myBB md5 passwords
[ticket/12352] Rename phpbb2_md5 driver to fit filenames of other drivers
[ticket/12352] Add passwords driver for sha1 password hashes
...
* nickvergessen/ticket/12483:
[ticket/12483] Fix selectors for installing extensions in functional tests
[ticket/12483] Remove unused globals
[ticket/12483] Fix finder usage when generating the schema.json file
[ticket/12483] Fix copyright in prepare_extension.sh
[ticket/12483] Use file_put_contents()
[ticket/12483] Close database connection when tearDown() is called
[ticket/12483] Require the extension manager class
[ticket/12483] Move schema files into tmp/ and only copy them when needed
[ticket/12483] Add a .sh that moves an extension in place
[ticket/12483] Allow to setup extensions before database and functional tests
* github-nickvergessen/ticket/12508:
[ticket/12508] Ignore extensions in migration_tips dev tool
[ticket/12508] Fix doc block
[ticket/12508] Add new line to separate the if and foreach better
[ticket/12508] Add a unit test for set_extensions()
[ticket/12508] Only take a list of names for set_extensions()
[ticket/12508] Fix class doc block
[ticket/12508] Move \phpbb\extension\finder to \phpbb\finder
[ticket/12508] Fix usages of the finder
[ticket/12508] Remove extension manager from finder
[ticket/12664] Refactor develop/migration_tips.php into a console command.
* bantu/ticket/12664:
[ticket/12664] Refactor develop/migration_tips.php into a console command.
[ticket/12667] Do not point viewtopic URL to unread post outside of view=unread.
* prototech/ticket/12667:
[ticket/12667] Do not point viewtopic URL to unread post outside of view=unread
[ticket/8610] Merging topics does not handle bookmarks correctly
* Nicofuma/ticket/8610:
[ticket/8610] Use css selector instead of xPath
[ticket/8610] Add functional test when two topics are merged
[ticket/8610] Throw an error when the dest topic isn't set
[ticket/8610] Fix bookmarks when merging all the posts of a topic
[ticket/8610] Merging topics does not handle bookmarks correctly
* github-nickvergessen/ticket/10073: (36 commits)
[ticket/10073] Fix button descriptions
[ticket/10073] Do not check disable boxes by default
[ticket/10073] Store values with config_text in the ACP
[ticket/10073] Move config values to config_text
[ticket/10073] Fix request usage
[ticket/10073] Deduplicate template variable names
[ticket/10073] Get service from container
[ticket/10073] Fix more "Contact Us" strings
[ticket/10073] Move template code into the template
[ticket/10073] Make contact page available when board is disabled
[ticket/10073] Change name of the ACP module
[ticket/10073] Deduplicate posting buttons code in ACP
[ticket/10073] Use phpbb_validate_email to verify email address
[ticket/10073] Add tests for new validate_email()
[ticket/10073] Split email validation from email ban and taken checks
[ticket/10073] Deduplicate the if statement
[ticket/10073] Fallback to board_contact when contact page is disabled
[ticket/10073] Remove language string from rebase conflict
[ticket/10073] Add ACP module to add bbcode text for contact admin info
[ticket/10073] Add new configs to the schema
...
[ticket/12672] Make tab intercept; CB for keypress only react without key mods
* brunoais/ticket/12672:
[ticket/12672] Make tab intercept; CB for keypress only react without key mods
Add core event to the function display_forums()
in includes/functions_display.php to allow assigning additional template data
for every forum, f.e. additional forumrow subloops.
PHPBB3-12669
Changed the callback of keypress inside the <textarea> for the posting
such that, if key 9 is pressed (tab character) and ctrl, shift, alt and meta
are not pressed the tab is placed. Otherwise, nothing is made and default is
not prevented.
PHPBB3-12672
[ticket/12655] Run phpbbcli as a shell when --shell or -s is used
* Nicofuma/ticket/12655:
[ticket/12655] Set register_container_commands as public
[ticket/12655] Don't try to restore the definition in the help
[ticket/12655] Fix coding style
[ticket/12655] Make the --shell option available only for phpbbcli.php
[ticket/12655] Fix coding style in \phpbb\console\application
[ticket/12655] Set the arguments of \phpbb\console\application as required
[ticket/12655] Don't require acp/common again in the commands
[ticket/12655] Run the shell when --shell is used
[ticket/12602] Add command to print the cron list
* Stephannos/ticket/12602:
[ticket/12602] Fix language key removal.
[ticket/12602] Rectify language keys.
[ticket/12602] Fix test mistake.
[ticket/12602] Fix language var mistakes.
[ticket/12602] Add types, change description of cron:list.
[ticket/12602] Fix internationalisation of cron_list.php
[ticket/12602] Fix spaces issues.
[ticket/12602] Coding style correction.
[ticket/12602] Fix coding style mistakes.
[ticket/12602] Headers updated.
[ticket/12602] Changes to respect coding style and to factorize code.
[ticket/12602] Cleanup tests
[ticket/12602] Add function get_tasks.
[ticket/12602] Correction of the output message for the cron list
[ticket/12602] Add files to print the cron list and test files.
[ticket/12666] Use "None" for images in root of gallery avatar path
* marc1706/ticket/12666:
[ticket/12666] Use "None" for images in root of gallery avatar path
* PayBas/ticket/12541:
[ticket/12541] Activate attachments tab when files are dropped into textarea
Conflicts:
phpBB/styles/prosilver/template/forum_fn.js
[ticket/12457] Default to first category if none is selected in gallery avatar
* marc1706/ticket/12457:
[ticket/12457] Default to first category if none is selected in gallery avatar
[ticket/12639] Delete entry in admin-log leads to mysql-error
* Nicofuma/ticket/12639:
[ticket/12639] Add a space in the code generated by generate_sql_keyword()
[ticket/12639] Handle $conditions['keywords'] outside of the loop
[ticket/12639] Don't make a copy of $marked when deleting logs in acp_logs
[ticket/12639] Send a correct IN entry when deleting marked logs
[ticket/12639] Use assertSame
[ticket/12639] Remove old commented tests
[ticket/12639] Order the results correctly in the test
[ticket/12639] Fix tests on postgres
[ticket/12639] Update tests to use a dataProvider
[ticket/12639] Add a test case with an empty keywords list
[ticket/12639] Delete entry in admin-log leads to mysql-error
Using this custom provider collection, we can properly check whether the
configured auth provider does exist. The method get_provider() has been added
for returning the default auth provider or the standard db auth provider if
the specified one does not exist.
Additionally, the method get_provider() will throw an RuntimeException if
none of the above exist.
PHPBB3-12352
This will make sure that we will not encounter a non-existing auth provider.
We will revert to the default db auth provider if the one set in the config
does not exist in our auth provider collection.
PHPBB3-12352
[ticket/12641] Use jQuery's trim() method. IE8 does not support the native one.
* prototech/ticket/12641:
[ticket/12641] Use jQuery's trim() method. IE8 does not support the native one
[ticket/12589] Search directly in $directory if it's an absolute sub-path
* Nicofuma/ticket/12589:
[ticket/12589] Add test searching in a non absolute directory
[ticket/12589] Fix tests
[ticket/12589] Search directly in $directory if it's an absolute sub-path
[ticket/12637] Correct file header in coding-guidelines
* bantu/ticket/12637:
[ticket/12637] Fixup all incorrect uses of file header.
[ticket/12637] Correctly escape the file header in coding-guidelines.html.
[ticket/10899] Using Delete All in log viewer with keyword search
* Nicofuma/ticket/10899:
[ticket/10899] Update doc block
[ticket/10899] Use isset($field_value['IN'])
[ticket/10899] Add event core.delete_log
[ticket/10899] Remove trailing ;
[ticket/10899] Fix typo in the class name
[ticket/10899] Add unit tests
[ticket/10899] Get $phpbb_log from the container
[ticket/10899] Remove extra ';'
[ticket/10899] Typo
[ticket/10899] Refactoring in \phpbb\log\log_interface
[ticket/10899] Using Delete All in log viewer with keyword search
[ticket/11942] Delete post/topic reason should be added to logs
* Nicofuma/ticket/11942:
[ticket/11942] Don't change the reason to '' when hard deleting
[ticket/11942] Don't show the checkbox if the post is already soft-deleted
[ticket/11942] Remove useless IF in templates
[ticket/11942] Apply the modifications to subsilver
[ticket/11942] Always display delete reason
[ticket/11942] Edits messages
[ticket/11942] Change the formulation
[ticket/11942] Adding the reason to hard deleted topic/post
[ticket/11942] Delete post/topic reason should be added to logs
[ticket/11467] Add language variables for extension exception messages
* n-aleha/ticket/11467:
[ticket/11467] Add user object to extension manager for tests
[ticket/11467] Add language variables to tests
[ticket/11467] Add language variables for extension exception messages
[ticket/11266] Better message for when composer dependencies are missing...
* bantu/ticket/11266:
[ticket/11266] Better message for when composer dependencies are missing.
[ticket/12597] Command for executing all available cron tasks
* bantu/ticket/12597:
[ticket/12597] Update USE_SYSTEM_CRON_EXPLAIN to be a bit more verbose.
[ticket/12597] Improve language for cron:run command.
[ticket/12597] Do not output anything besides the gif image.
[ticket/12597] Command for executing all available cron tasks
* ptitlazy/ticket/12597: (27 commits)
[ticket/12597] Reformating an acp message
[ticket/12597] Modifiying acp message
[ticket/12597] Fix wrong global variable name
[ticket/12597] Typo correction
[ticket/12597] Typo corrections
[ticket/12597] Changing place of lock release in execute() method
[ticket/12597] Fix test file
[ticket/12597] Typing corrections and improvement of code consistency
[ticket/12597] Fix various mistakes
[ticket/12597] Fix various mistakes
[ticket/12597] Fix visibilty of two functions in run.php
[ticket/12597] Refactoring and test improving
[ticket/12597] Fix language key name
[ticket/12597] Fix coding style and typing mistakes
[ticket/12597] Changes name of command cron:run-all to cron:run.
[ticket/12597] Fix various problems
[ticket/12597] Fix constructor bug and servral doc blocs
[ticket/12597] Modification of return statuses and of test files
[ticket/12597] Fix misplaced release of db lock
[ticket/12597] Change EXECUTE to RUN in language
...
* prep-release-3.1.0-b4:
[prep-release-3.1.0-b4] Update phpBB Version for b5 development
[prep-release-3.1.0-b4] Add changelog for 3.1.0-b4
[prep-release-3.1.0-b4] Prepare Changelog
[prep-release-3.1.0-b4] Add migration for 3.1.0-b4
[prep-release-3.1.0-b4] Update version to 3.1.0-b4
[ticket/12621] schema.json is not up to date with migration files
* PayBas/ticket/12621:
[ticket/12621] schema.json is not up to date with migration files
[ticket/12594] Fix file headers of new files
* nickvergessen/ticket/12594:
[ticket/12594] Update file header in non-php files
[ticket/12594] Fix file headers of new files
[ticket/12611] Remove phpBB Group copyright notice from .gifs
* Marshalrusty/ticket/12611:
[ticket/12611] Remove phpBB Group copyright notice from .gifs
[ticket/11226] filespec::move_file() should error correctly
* Nicofuma/ticket/11226:
[ticket/11226] Explicity set file_moved to false
[ticket/11226] Add tests
[ticket/11226] Use $user->lang()
[ticket/11226] filespec::move_file() should error correctly
[ticket/11366] Extension's version's check
* Nicofuma/ticket/11366: (29 commits)
[ticket/11366] Fix headings css in list page
[ticket/11366] Add config value in schema_data.sql
[ticket/11366] Fix HTML
[ticket/11366] Exchange links and settings' form
[ticket/11366] Remove the extra {S_FORM_TOKEN}
[ticket/11366] Move the links to the top of the page
[ticket/11366] Hide the version check settings by default
[ticket/11366] Versions, options and actions heading should be centered
[ticket/11366] Better language string for "recheck all"
[ticket/11366] Move "recheck all" link
[ticket/11366] Add $config['extension_force_unstable']
[ticket/11366] Use force_cache on the list page
[ticket/11366] Add recheck-all link
[ticket/11366] Force the use of the cache on the list page
[ticket/11366] Update FILE_NOT_FOUND language string
[ticket/11366] Fix whitespaces
[ticket/11366] Update FILE_NOT_FOUND language string
[ticket/11366] Update var names
[ticket/11366] Align language strings
[ticket/11366] Fix detailed view
...
[ticket/12561] Add "after" check to schema_generator for columns_add
* PayBas/ticket/12561:
[ticket/12561] Reworked tests by nickvergessen
[ticket/12561] Added tests for "after last", "after missing" and "empty"
[ticket/12561] Add check to see if "after" column actually exists
[ticket/12561] Added test for "after"
[ticket/12561] Add "after" check to schema_generator for columns_add
[ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.
* bantu/ticket/12384-ascraeus:
[ticket/12384] Use mysqli on hhvm in ascraeus. Keep explicit matrix though.
[ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.
[ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.
* bantu/ticket/12384:
[ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.
Add a feature to check automatically the version of the installed
extensions. The informations are cached for 24 hours (like for the
global update check on the main page of the acp).
The informations about the versions are display both on the global list
and on the detailled page.
To do this the developper has to to let the composer.json of the latest
version available and add some informations into it :
"extra": {
"version-check": {
"host": "<the host>",
"directory": "<the directory containing the file>",
"filename": "<the composer.json of the latest version>"
}
}
He can also add two extra informations which will be displayed if a new
version is available :
"extra": {
"download": "<download link>",
"annoucement": "<announcement link>",
}
Currently a notice is displayed when the "extra.version-check"
informations are
missing.
Ticket: https://tracker.phpbb.com/browse/PHPBB3-11366
Signed-off-by: Nicofuma <github@nicofuma.fr>
PHPBB3-11366
[ticket/12582] Strip away copyrighted ICC profile from images
* bantu/ticket/12582-ascraeus:
[ticket/12582] Use the correct script name.
[ticket/12582] Fix coding style.
[ticket/12582] Remove set -e due to exiftool not liking 0 byte files.
[ticket/12582] Strip away copyrighted ICC profile
[ticket/12582] Change strip_icc_profiles.sh to only take a single file.
[ticket/12582] Run strip_icc_profiles.sh on Travis CI.
[ticket/12582] Overwrite inplace instead of creating _original files.
[ticket/12582] Add script for strippping ICC profiles from images.
[ticket/12582] Strip away copyrighted ICC profile from images
* bantu/ticket/12582:
[ticket/12582] Fix coding style.
[ticket/12582] Remove set -e due to exiftool not liking 0 byte files.
[ticket/12582] Strip away copyrighted ICC profile
[ticket/12582] Change strip_icc_profiles.sh to only take a single file.
[ticket/12582] Run strip_icc_profiles.sh on Travis CI.
[ticket/12582] Overwrite inplace instead of creating _original files.
[ticket/12582] Add script for strippping ICC profiles from images.
[ticket/12174] Update topic_attachment flag when a post is soft-deleted
* Nicofuma/ticket/12174:
[ticket/12174] Add tests
[ticket/12174] Coding style
[ticket/12174] Remove $update_topic_attachments_flag
[ticket/12174] Don't update the flag for a post without attachment
[ticket/12174] Update the conditions
[ticket/12174] Remove inline assignment
[ticket/12174] Update sql query
[ticket/12174] Revert the changes on $topic_update_array
[ticket/12174] Corrections
[ticket/12174] Update topic_attachment flag when a post is soft-deleted
Actually fix the return status of command cron:run-all
Fix some doc block coding style issue
Fix missing and obsolete file headers
Delete a useless constructor method
PHPBB3-12597
Added a class to the <li> when the <li> represents that there's no
notifications (no_notifications) and
Added a CSS rule that matches the change to the HTML source for when
there's no notifications.
PHPBB3-12604
[ticket/12509] Add an option to set the path of custom style directory (ie: email templates) for extensions
* Nicofuma/ticket/12509:
[ticket/12509] Add example in doc block
[ticket/12509] Add missing ',' in arrays
[ticket/12509] Update calls to set_custom_style in forgotten places
[ticket/12509] Fix path in adm/index.php
[ticket/12509] Fix typo in adm/index.php
[ticket/12509] Fix doc block
[ticket/12509] Fix the call to set_custom_file in adm/index and messenger
[ticket/12509] Update acp custom_style setter
[ticket/12509] Add an option to set the path of custom file for extensions
[ticket/12536] Get Versions Should Not Require Both Stable and Unstable
* Nicofuma/ticket/12536:
[ticket/12536] Restore missing @throws
[ticket/12536] Add test cases with empty versions list
[ticket/12536] Use stable values when unstable are unavailable
[ticket/12536] Update doc block
[ticket/12536] Return empty array if stability unavailable
[ticket/12536] Get Versions Should Not Require Both Stable and Unstable
* ticket/12582:
[ticket/12582] Strip away copyrighted ICC profile
[ticket/12582] Change strip_icc_profiles.sh to only take a single file.
[ticket/12582] Run strip_icc_profiles.sh on Travis CI.
[ticket/12582] Overwrite inplace instead of creating _original files.
[ticket/12582] Add script for strippping ICC profiles from images.
Conflicts:
.travis.yml
[ticket/12155] Construct post buttons using CSS.
* prototech/ticket/12155: (21 commits)
[ticket/12155] Remove use of !important and move reddish color back to .button
[ticket/12155] Reposition the button icons to the left side while we're at it.
[ticket/12155] Get rid of line-height value causing alignment issues in FF.
[ticket/12155] Get rid of the <span> where possible and fix buttons in Safari.
[ticket/12155] Fix misplaced semicolon and ensure that value comparison works.
[ticket/12155] Combine the post and topic/PM button icons into a single sprite
[ticket/12155] Move icon class directly to <a> and use <span> consistently.
[ticket/12155] Remove star hack from padding-right property of .button.
[ticket/12155] Fix tabbing and put one selector per line if string is too long
[ticket/12155] Make opacity transition faster and fix background image paths.
[ticket/12155] Keep the selection method consistent with the one below it.
[ticket/12155] Fade out the buttons when leaving the post.
[ticket/12155] Display the buttons only when hovering the post.
[ticket/12155] Make the buttons bigger on touch devices.
[ticket/12155] Clean up icons.
[ticket/12155] Remove unused font.
[ticket/12155] Remove obsolete images.
[ticket/12155] Use the new .button class as the basis for the post buttons.
[ticket/12155] Move existing button style to a more generic class.
[ticket/12155] Remove obsolete language images.
...
This images embed a non free ICC profile that doesn’t allow
modification:
http://web.archive.org/web/20020603153925/srgb.com/usingsrgb.html
Please use the proposed version stripping away this copyrighted binary
profile, probably embedded by an image software at one time:
exiftool -icc_profile"-<=" phpBB/adm/images/phpbb_logo.png
I’ve checked the resulting image and trust it is identical to the
original.
Some more background on the issue:
https://lists.debian.org/debian-devel/2014/05/msg00339.html
PHPBB3-12582
The code for hooks still exists in Ascraeus for compatibility reasons, however,
it is no longer recommended that they be used. The events system should be
used instead.
PHPBB3-12603
[ticket/12527] Remove translation editor from ACP
* nickvergessen/ticket/12527:
[ticket/12527] Fix "board’s language" vs "boards language"
[ticket/12527] Use a proper language string on confirm screen
[ticket/12527] Remove unnecessary language strings
[ticket/12527] Check whether the language exists
[ticket/12527] Restore missing files and variables check
[ticket/12527] Remove editor from template
[ticket/12527] Remove language file editor form ACP
This was in place for IE7 due to the use of :after for inserting the button
icon. IE7 does not support :after, so the hack removed the extra padding that
made room for the icon. We no longer use :after for the icon, so this is no
longer an issue... not to mention that IE7 is no longer supported.
PHPBB3-12155
[ticket/12570] Fix updating a config with the same value
* nickvergessen/ticket/12570:
[ticket/12570] Keep MySQLi procedural
[ticket/12570] Remove test for affected rows after SELECT
[ticket/12570] Add a test for set_array() and updating with the same value
[ticket/12570] Fix MySQL affectedrows
[ticket/12570] Fix MySQLi affectedrows by specifying MYSQLI_CLIENT_FOUND_ROWS
[ticket/12570] Add a unit test to show broken sql_affectedrows()
[ticket/12570] Add test for updating a config with the same value
We always want the number of matched rows instead of changed rows,
when running an update. So when mysql_info() returns the number of
matched rows we return that one instead of mysql_affected_rows()
PHPBB3-12570
[ticket/12592] Run mysql driver on Travis CI.
* bantu/ticket/12592:
[ticket/12592] Add PHP 5.4 environment using mysql driver.
[ticket/12592] Rename mysql environment to mysqli.
[ticket/12074] Managing extensions doesn't produce any log entry
* Nicofuma/ticket/12074:
[ticket/12074] Update the visibility of the constructor
[ticket/12074] Don't log errors
[ticket/12074] Managing extensions doesn't produce any log entry
[ticket/12270] Current post and topic approval notification message
* marcosbc/ticket/12270:
[ticket/12270] Fixed topic counting bug and tests
[ticket/12270] Fixed tests not working
[ticket/12270] No quote notif and double poster notification fix
[ticket/12270] Fixed tests
[ticket/12270] Fixed rebase conflicts
[ticket/12270] Correct confirm approval message for topics
[ticket/12270] Correcting to follow phpBB coding standards
[ticket/12270] Better structured code and no debug error message
[ticket/12270] Correct notifications for posts/topics now working
[ticket/12270] Reverted templates
[ticket/12270] Correct post&topic approval msg, no template changes
[ticket/12270] Corrent post and topic approval notification message
[ticket/12543] Only take over ENTER and ESC keys when alert box is active.
* prototech/ticket/12543:
[ticket/12543] Only take over ENTER and ESC keys when alert box is active.
[ticket/12275] Fix a bug on the event "core.modify_username_string"
* Zoddo/ticket/12275:
[ticket/12275] Change if (empty) to if (!isset)
[ticket/12275] Fix a bug on the event "core.modify_username_string"
Topics was not correctly counted (the counter didn't count topics
that were re-approved, for example, but only the ones that were
unapproved.
This should also fix the test that wasn't working correctly.
PHPBB3-12270
[ticket/12531] Restore default topic link behavior to subsilver2
* VSEphpbb/ticket/12531:
[ticket/12531] Add some line breaks to really long lines
[ticket/12531] Restore default topic link functionality in subsilver2
[ticket/12585] Don't check the cron on each page load
* Nicofuma/ticket/12585:
[ticket/12585] Use a 5 minutes interval instead of 10 minutes
[ticket/12585] Don't check the cron on each page load
[Ticket/12555] Make use of canonical urls to avoid duplicate content
* nickvergessen/ticket/12555:
[ticket/12555] Add canonical URL for viewtopic
[ticket/12555] Add canonical URL for viewforum
[ticket/12555] Add canonical URl for memberlist mode=viewprofile
[ticket/12555] Allow to set canonical URLs to avoid duplicate content
[ticket/12572] Fix JS error when alert message title is undefined
* rxu/ticket/12572:
[ticket/12572] Fix JS error when alert message title is undefined
[ticket/12551] Float breadcrumbs to the right in RTL languages.
* prototech/ticket/12551:
[ticket/12551] Float breadcrumbs to the right in RTL languages.
[ticket/12550] Prevent last post column from jumping to second line in RTL.
* prototech/ticket/12550:
[ticket/12550] Prevent last post column from jumping to second line in RTL.
[ticket/12549] Hide topic/forum list <dfn> tags in RTL languages.
* prototech/ticket/12549:
[ticket/12549] Hide topic/forum list <dfn> tags in RTL languages.
[ticket/12576] Remove cron from common.php
* Nicofuma/ticket/12576:
[ticket/12576] Retrieve the cron_manager in cron.php if needed
[ticket/12576] Remove cron from common.php
Ticket/12586 Filter files and depth when looking for extensions
* nickvergessen/ticket/12586:
[ticket/12586] Limit depth to 2, we require vendor/extension/ext.php
[ticket/12586] Use dot filter when trying to find available extensions
[task/sami-ascraeus] Add Sami to composer dependencies and build script
* bantu/task/sami-ascraeus:
[task/sami] Establish alphabetical order.
[task/sami] Also ignore ext/ directory.
[task/sami] Replace phpdoctor with sami.
[task/sami] Add sami/sami as a composer development dependency.
[task/sami] Add Sami to composer dependencies and build script
* bantu/task/sami:
[task/sami] Establish alphabetical order.
[task/sami] Also ignore ext/ directory.
[task/sami] Replace phpdoctor with sami.
[task/sami] Add sami/sami as a composer development dependency.
In language/en/common.php:
* Introduce a new language variable 'CONTACT' => 'Contact'
* Add a string argument to lang var 'CONTACT_USER' to avoid an appended
'{USERNAME}' in template.
* Add a string argument to lang var 'SEND_EMAIL_USER' to avoid an appended
'{USERNAME}' in template.
Also fix typos.
PHPBB3-12525
* task/sami:
[task/sami] Replace phpdoctor with sami.
[task/sami] Add sami/sami as a composer development dependency.
Conflicts:
phpBB/composer.json
phpBB/composer.lock
[ticket/12433] Use a different message when nesting of quotes is not allowed
* nickvergessen/ticket/12433:
[ticket/12433] Use a different message when nesting of quotes is not allowed
Changed padding CSS to the notifications' `<li>` and it's
`<a>` (immediate child) so that the `<a>` block uses all
it's container width and height.
To compensate that, I added the padding that was in the
`<li>` to the `<a>`
PHPBB3-12533
* nickvergessen/ticket/12534:
[ticket/12534] Fix filter for functional tests
[ticket/12534] Do not use errorbox for multi steps
[ticket/12534] Do not abuse errorbox for en/disable confirmation of extensions
[ticket/12518] Apply De Morgan to make the conditions easier reasable
* nickvergessen/ticket/12518:
[ticket/12518] Apply De Morgan to make the conditions easier to read
* nickvergessen/ticket/12518:
[ticket/12518] Add event to overwrite the cannot edit condition in posting.php
[ticket/12518] Add event to overwrite the allow edit and delete conditions
[ticket/12529] Use root_path in controller\resolver to check the template dir
* Nicofuma/ticket/12529:
[ticket/12529] Move $phpbb_root_path to the end of the constructor
[ticket/12529] Use root_path in controller\resolver to check the template dir
[ticket/12501] Fix improper display of inline attachments in post report page
* prototech/ticket/12501:
[ticket/12501] Only select attachments uploaded before the post was reported.
[ticket/12501] Parse the reported post message before its attachments.
[ticket/9388] Only display the settings for the selected method in the auth and search ACP pages.
* prototech/ticket/9388:
[ticket/9388] Use "togglable" instead of "toggable"
[ticket/9388] Do not nest the <fieldset> tags in the OAuth settings.
[ticket/9388] Reopen <fieldset> after auth templates.
[ticket/9388] Fix unit tests.
[ticket/9388] Use the new toggle function for the avatar type <select>.
[ticket/9388] Display only the settings for the selected search backend.
[ticket/9388] Display only the settings for the auth method that's selected.
[ticket/9388] Add support for making <select> options able to toggle settings.
[ticket/12407] Allow changing of post_data, etc. at end of posting.php
* marc1706/ticket/12407:
[ticket/12407] Remove merge marker from posting.php
[ticket/12407] Fix incorrect @since line in event
[ticket/12407] Merge @change in doc block of event
[ticket/12407] Assign template variables again after merging develop-ascraeus
[ticket/12407] Add message_parser as passed variable to event
[ticket/12407] Allow changing of post_data, etc. at end of posting.php
Currently it is possible to change search results within the search row scope,
but it should be possible to modify/unset every individual row
within the rowset.
PHPBB3-12524
[ticket/12522] Add function parameter description in guesser interface
* n-aleha/ticket/12522:
[ticket/12522] Add function parameter description in guesser interface
[ticket/12476] Increase assets version on cache purge
* n-aleha/ticket/12476:
[ticket/12476] Label the constructor as public
[ticket/12476] Increase assets also from acp_styles and phpbbcli
[ticket/12476] Increase asset version on cache purge
Ticket/10839 Remove phpunit configuration files
* nickvergessen/ticket/10839:
[ticket/10839] Remove version compare as the php minimum requirement is 5.3.3
[ticket/10839] Fix note about running slow tests and build task
[ticket/10839] Removing phpunit.xml.all
[ticket/10839] Always run functional tests by default
Since a call was added to self::approve_topic(), the poster would
get double-notified about it (even if it was later marked as read).
Also, when creating a new topic with a quote, it would not be
notified, this has also been fixed.
PHPBB3-12270
They are skipped anyway, if $phpbb_functional_url is not configured.
If you want to run tests without functional tests, just append
--exclude-group functional
to your call
PHPBB3-10839
* 'develop-ascraeus' of github.com:phpbb/phpbb: (424 commits)
[ticket/12428] Use the database to store the original version number
[ticket/12493] Add functional test
[ticket/12493] Fix sql query for selection of users that have disabled PM
[ticket/12513] Add asset include support to simple header/footer in ACP
[ticket/12513] Add simple_header head event with support for CSS assets calls
[ticket/12511] Add missing titles for profile fields in members group view
[ticket/12428] Incorrect from version in database update log entry
[ticket/12510] Convert & to & in build_url() when no params are stripped.
[ticket/12402] CAPTCHA plugin migration fails to detect missing plugins
[ticket/12440] Use a more generic approach for replacing the URL.
[ticket/12507] Move the 'require' statement
[ticket/12507] Add console command to purge the cache
[ticket/12421] Rebase and enable tests
[ticket/12421] Don't parse [attachment] tags if user can't view them
[ticket/12325] Use \RecursiveDirectoryIterator
[ticket/12325] Doc blocks
[ticket/12440] Set browser URL to point to specific post when using view=unread
[ticket/12357] Support routes in generate_smilies() function.
[ticket/12459] Change language strings
[ticket/12504] Use local variables where possible
...
Conflicts:
phpBB/posting.php
[ticket/12451] Split lang vars in posting.php for plurals
* Elsensee/ticket/12451:
[ticket/12451] Remove duplicated lang var
[ticket/12451] Use new line to concatenate strings
[ticket/12451] Split TOO_MANY_CHARS vars for plurals
[ticket/12451] Split TOO_FEW_CHARS_LIMIT for plurals
[ticket/12025] Post Preview no longer shows warnings
* Nicofuma/ticket/12025:
[ticket/12025] Apply DeMorgan
[ticket/12025] Fixing the condition....
[ticket/12025] Don't show any error on preview if the message is empty
[ticket/12025] Post Preview no longer shows warnings
[ticket/12325] Generate the list of the deleted files and folders
* Nicofuma/ticket/12325:
[ticket/12325] Use \RecursiveDirectoryIterator
[ticket/12325] Doc blocks
[ticket/12325] Change private function to protected
[ticket/12325] Add visibilities
[ticket/12325] Add files located in deleted dirs
[ticket/12325] Generate the list of the deleted files and folders
[ticket/12440] Set browser URL to point to specific post when using view=unread
* prototech/ticket/12440:
[ticket/12440] Use a more generic approach for replacing the URL.
[ticket/12440] Set browser URL to point to specific post when using view=unread
Conflicts:
phpBB/styles/prosilver/template/viewtopic_body.html
[ticket/12510] Convert & to & in build_url() when no params are stripped.
* prototech/ticket/12510:
[ticket/12510] Convert & to & in build_url() when no params are stripped.
[ticket/12428] Incorrect from version in database update log entry
* Nicofuma/ticket/12428:
[ticket/12428] Use the database to store the original version number
[ticket/12428] Incorrect from version in database update log entry
[ticket/12511] Add missing titles for profile fields in members group view
* rxu/ticket/12511:
[ticket/12511] Add missing titles for profile fields in members group view
[ticket/12513] Add simple_header head event with support for asset calls
* VSEphpbb/ticket/12513:
[ticket/12513] Add asset include support to simple header/footer in ACP
[ticket/12513] Add simple_header head event with support for CSS assets calls
[ticket/12493] Fix sql query for selection of users that have disabled PM
* n-aleha/ticket/12493:
[ticket/12493] Add functional test
[ticket/12493] Fix sql query for selection of users that have disabled PM
This fixes a bug where a user A could not send a PM to user B when both users
allowed other users to send them a PM. More precisely, it fixes the selection
of users that either are inactive or have disabled private messages.
PHPBB3-12493
For memberlist group view in cases the group is presented with the group leader
and group members, for members profile fields titles are missing: Posts,
Joined, Last active and custom profile fields titles.
PHPBB3-12511
[ticket/12421] Don't parse [attachment] tags if user can't view them
* Nicofuma/ticket/12421:
[ticket/12421] Rebase and enable tests
[ticket/12421] Don't parse [attachment] tags if user can't view them
[ticket/12507] Add console command to purge the cache
* Nicofuma/ticket/12507:
[ticket/12507] Move the 'require' statement
[ticket/12507] Add console command to purge the cache
[ticket/12459] Unapproved posts/topics are not correctly handled in feeds
* Nicofuma/ticket/12459:
[ticket/12459] Change language strings
[ticket/12459] Enable related tests
[ticket/12459] Fix: Differentiating unapproved and deleted posts
[ticket/12459] Fix: Soft deleted topics should appear in feeds
[ticket/12459] Fix: the posts were always marked as unapproved
[ticket/11497] Remove 'ext.finder' from services' list
* Nicofuma/ticket/11497:
[ticket/11497] Rename set_ext_finder in find_routing_files
[ticket/11497] Change the date in the package declaration
[ticket/11497] Fix pagination tests
[ticket/11497] Use a mock object to define the root folder for the finder
[ticket/11497] Generate the list of the routes in controller_helper
[ticket/11497] Fix the path for the finder in controller_provider
[ticket/11497] Fix tests
[ticket/11497] Update pagination test
[ticket/11497] Remove 'ext.finder' from services' list
* VSEphpbb/ticket/12332:
[ticket/12332] Add missing semicolon to inline styling
[ticket/12332] Adjust size of mark column where too wide
[ticket/12332] Adjust column widths for responsive changes
[ticket/12332] Restore some changes back to original state
[ticket/12332] Add break-word to fixed width table CSS
[ticket/12332] Accomplish all word creaking in template and CSS
[ticket/12332] Remove width sizing, as it is already set
[ticket/12332] Fix displaying attachments with long file names
The post text displayed to the user is the same as when it was reported, even if
the post was edited afterwards, thus it follows that the attachments would be
the same. This also addresses an issue where the index in the attachment bbcode
no longer matches that of its corresponding attachment when new attachments
are uploaded after the post is reported.
PHPBB3-12501
[ticket/12499] Incorrect call to phpbb\log\log::add() in db:migrate
* Nicofuma/ticket/12499:
[ticket/12499] Incorrect call to phpbb\log\log::add() in db:migrate
* prep-release-3.1.0-b3:
[prep-release-3.1.0-b3] Update phpBB Version for b4 development
[prep-release-3.1.0-b3] Add changelog for 3.1.0-b3
[prep-release-3.1.0-b3] Prepare Changelog
[prep-release-3.1.0-b3] Add migration for 3.1.0-b3
[prep-release-3.1.0-b3] Update version to 3.1.0-b3
[ticket/12411] Expand vars of event: core.search_modify_tpl_ary
* PayBas/ticket/12411:
[ticket/12411] Improved change documentation
[ticket/12411] Missed on bool var
[ticket/12411] Corrected event vars description
[ticket/12411] Expand vars of event: core.search_modify_tpl_ary
[ticket/12392] Include $profile_fields in core.memberlist_view_profile
* PayBas/ticket/12392:
[ticket/12392] Fix avatar double assignment bug
[ticket/12392] Include $profile_fields in core.memberlist_view_profile
[ticket/12366] Add Event core.search_get_posts_data
* PayBas/ticket/12366:
[ticket/12366] Fixed missing comma
[ticket/12366] Conform to new event coding guidelines
[ticket/12366] Expanded event vars
[ticket/12366] Include ORDER BY into the query builder
[ticket/12366] Changed to sql_build_query
[ticket/12366] Add Event core.search_get_posts_data
[ticket/12335] Add Events to phpbb\profilefields\manager
* PayBas/ticket/12335:
[ticket/12335] Remove $ from desc
[ticket/12335] Added generate_profile_fields _ before
[ticket/12335] Documentation fix and added use_contact_fields
[ticket/12335] Fix phpBB version number
[ticket/12335] Add Events to phpbb\profilefields\manager
[ticket/12455] Remove unused language strings from common.php and app.php
* n-aleha/ticket/12455:
[ticket/12455] Remove unused language strings from common.php and app.php
Removed the following unused language strings from common.php:
EXTENSION_CONTROLLER_MISSING
EXTENSION_CLASS_WRONG_TYPE
Removed the following unused language strings from app.php:
CONTROLLER_NOT_FOUND
CONTROLLER_SERVICE_NOT_GIVEN
CONTROLLER_RETURN_TYPE_INVALID
PHPBB3-12455
When clicking on approving a topic's first post in the MCP to
approve the topic itself, the confirm box dialog asks whether
to approve the post or not, instead of asking to approve the
topic.
To achieve this fix, we just need to count the topics to be
approved and check if it's greater than zero.
PHPBB3-12270
I forgot to put the brackets (so it follows the phpBB coding
standards) and changed "count($topic_id_list) > 0"
to "!empty($topic_id_list)", making the syntax more
comprehensible.
PHPBB3-12270
A variable (that's not essential) has been removed, two if's
has been merged to an if-else control structure. A variable
named topic_ids_list has been renamed to topic_id_list to follow
the naming standard in that file's code.
Also, the debug error has been fixed by changing the topic data
key 'username' to 'post_username' in the array_merge function
in approve_topics().
PHPBB3-12270
This patch should finally work correctly: Add the correct
notification for post/topic approval without touching templates.
This has been done by calling the function approve_topics()
inside the approve_posts() function. It's the simplest way for
this to work correctly. There may be a call to the DB but other
ways (if any), without touching templates, would have been too
messy for a function like this.
PHPBB3-12270
Following the previous commits, this patch removes the changes
done to templates to depend only on code, as suggested by
@nickvergessen.
All previous modifications have been removed, with another one
which checks, in the approve_posts() function, if it is sending a
notification for post approval and it is the first one in the
topic, send notification indicating that the topic has been
approved (and not the post). If not the first post in the topic,
do just as before (send a notification about a newly approved
post).
PHPBB3-12270
When you submit a post with needed approval (say user A), and then
it gets approved by another user (user B), a subscribed user (user C)
to that forum would receive a notification indicating:
-A has replied to topic 'New Topic' in the forum 'xyz'.
The expected result would be:
-A has posted a new topic 'New topic' in the forum 'xyz'.
This has fixed by adding a TOPIC_ID template variable to
mcp_post.html and, in there, depending if the first post is the topic's
first post or not, add a input's with name topic_id_list[] or
post_id_list[] and then the respective value (TOPIC_ID or POST_ID).
PHPBB3-12270
[ticket/10737] Add live member search.
* prototech/ticket/10737:
[ticket/10737] Remove loading indicator.
[ticket/10737] Enforce allow_live_searches setting in memberlist.php.
[ticket/10737] Add config setting to disable live searches.
[ticket/10737] Add loading indicator and alert box code to simple_footer.html.
[ticket/10737] Load core.js and ajax.js in simple_footer.html.
[ticket/10737] Set the username as the input value instead of redirecting.
[ticket/10737] Drop subsilver2 changes.
[ticket/10737] Add a more generic live search implementation.
[ticket/10737] Clean up memberlist.php.
[ticket/10737] Use dropdown for search results container.
[ticket/10737] Adding delayed keyup and removing target_blank.
[ticket/10737] Using UTF-8 aware alternatives in PHP code.
[ticket/10737] Removing obsolete code.
[ticket/10737] Avoid hard-coding table row and use case-insensitive search.
[ticket/10737] Removing unnecessary/obsolete code.
[ticket/10737] Using JQuery events and JSON response.
[ticket/10737] Code fixes in AJAX search feature
[ticket/10737] Improvements over last commit
[ticket/10737] Adding username suggestions in "Find a member" using AJAX
Ticket/12470 Move commands from .travis.yml to separate files to allow reusing
* nickvergessen/ticket/12470:
[ticket/12470] Correctly set up the php extensions
[ticket/12470] Fix setup of phpbb
[ticket/12470] Move setup of phpBB to new .sh
[ticket/12470] Move setup of database to new .sh
[ticket/12470] Move phing sniff into new .sh
[ticket/12480] Only load config/routing.yml from extensions route
* nickvergessen/ticket/12480:
[ticket/12480] Remove unused use statements
[ticket/12480] Add subfolder/config/routing.yml which should not be found
[ticket/12480] Only load config/routing.yml from extensions route
* github-vse/ticket/12254:
[ticket/12254] Add subsilver2 support for cookie storage instead of SID
[ticket/12254] Use a cookie instead of SID to store language selection
[ticket/12254] No longer need to add change_lang to the URL params
[ticket/12254] Use 'language' instead of 'set_lang' as the variable name
[ticket/12254] Persist set_lang after reg only if changed from default
[ticket/12254] Add set_lang var changes to subsilver2 files
[ticket/12254] Use new set_lang var to avoid conflict with change_lang
[ticket/12254] Stop using deprecated request_var in user class
[ticket/12254] Better language switching on registration page
[ticket/12474] The console command for updating/migrating the db should display the error with the <error> tag
* Nicofuma/ticket/12474:
[ticket/12474] Error messages should be displayed with <error> tag
* github-bantu/ticket/12473:
[ticket/12473] Add console command for database migration.
[ticket/12473] Add more compatibility to phpBB Console Application.
[ticket/12473] Move compatibility globals out into its own file.
* github-prototech/ticket/12265:
[ticket/12265] Actually use $u_pm.
[ticket/12265] Ensure that dropdown is always at the very left of the container
[ticket/12265] Define a loop for contact icons.
[ticket/12265] Break the icons that aren't in loop in case extensions add more
[ticket/12265] Fix modulo logic.
[ticket/12265] Adjust alignment of AIM and Jabber icons.
[ticket/12265] Ensure that there's only 4 icons per row in IE & Opera.
[ticket/12265] Add contact icon and remove border from last row & cells.
[ticket/12265] Fix issue with dropdown being restricted by the width of parent
[ticket/12265] Remove ugly logic.
[ticket/12265] Simplify contact icon design and move to dropdown.
Conflicts:
phpBB/viewtopic.php
* github-nickvergessen/feature/sqlite3:
[feature/sqlite3] Add sqlite3 database to .gitignore
[feature/sqlite3] Use SQLite3 by default
[feature/sqlite3] Remove invalid comment
[feature/sqlite3] Remove unneeded ORDER BY type from sqlite_master queries
[feature/sqlite3] Correctly recreate indexes when recreating a table
[feature/sqlite3] Fix sql_index_drop() for sqlite3
[feature/sqlite3] Remove trailing comma from column list
[feature/sqlite3] Update docblocks and function visibility
[feature/sqlite3] Add support for SQLite 3
* github-marc1706/ticket/12071:
[ticket/12071] Add test that covers not available fileinfo
[ticket/12071] Get rid of unneeded cast to boolean in tests
[ticket/12071] Skip tests that depend on fileinfo and fix expected results
* github-prototech/ticket/11508:
[ticket/11508] Fix build_url test.
[ticket/11508] Add functional test for jumpbox.
[ticket/11508] Use $phpbb_path_helper.
[ticket/11508] Allow equal sign in parameter value.
[ticket/11508] Remove unnecessary implode.
[ticket/11508] Remove unnecessary isset check.
[ticket/11508] Fix build_url test.
[ticket/11508] Curly brace should be on its own line...
[ticket/11508] The question mark is expected even if there are no parameters.
[ticket/11508] Add tests.
[ticket/11508] Do not add the '?' unless there are parameters.
[ticket/11508] Change separator parameter to a simple true|false $is_amp.
[ticket/11508] Move helper functions to path_helper class.
[ticket/11508] Move the stripping param code to separate function as well.
[ticket/11508] Build the jumpbox hidden fields using the _form action_
[ticket/11508] Split parts of build_url() into reusable functions.
* github-exreaction/ticket/8323:
[ticket/8323] Cache auth request
[ticket/8323] Combine into a single query
[ticket/8323] Comments on phpbb_get_banned_user_ids input for test
[ticket/8323] More readability in test case
[ticket/8323] Comments
[ticket/8323] dataProvider for the test; better test data
[ticket/8323] Comments
[ticket/8323] Unit test for phpbb_get_banned_user_ids
[ticket/8323] Comments for inactive reasons in constants.php
[ticket/8323] Only disable administrative deactivated accounts from receiving PMs
[ticket/8323] Allow temporarily banned users to receive PMs, but not a notification
[ticket/8323] Correct PM notification settings (only notify those who can receive them)
[ticket/8323] Cleanup viewtopic code (not sure how this mess happened)
[ticket/8323] Allow sending PMs to temporarily banned users
[ticket/8323] Do not allow sending PMs to Inactive users
[ticket/8323] Hide the Send PM link if users cannot receive the PM
[ticket/8323] Correcting the comment
[ticket/8323] Do not allow sending of Private Messages to users who are banned
[ticket/8323] Remove code used for testing
[ticket/8323] Do not allow sending of Private Messages to users who do not have permission to read private messages
Conflicts:
phpBB/language/en/ucp.php
* github-bantu/ticket/12468:
[ticket/12468] Having mbstring.http_input set to '' is as good as 'pass'.
[ticket/12467] Add config*.php and tests_config*.php to .gitignore
* exreaction/ticket/11881:
[ticket/11881] Move convert_timezones_test to migrator
[ticket/11881] Fix test filename
[ticket/11881] Limit to 500
[ticket/11881] Make sure user_timezone isn't converted twice
[ticket/11881] Better split the timezone conversion into chunks; add test
[ticket/11881] Timezone migration can take a long time
[ticket/12467] Add config*.php and tests_config*.php to .gitignore
* nickvergessen/ticket/12467:
[ticket/12467] Add config*.php and tests_config*.php to .gitignore
Using a static attribute to store the initial state of the feeds instead
of transmit it with the @depends annotation.
This attribute is also added to backupStaticAttributesBlackList
PHPBB3-12413
* github-elsensee/ticket/stenudd/8558-2:
[ticket/8558] Fix operator
[ticket/8558] Fix field length in ACP
[ticket/8558] Use only one variable and improve explain string
[ticket/8558] Add config in migrations and schema_data
[ticket/8558] Add display name in emails from board
Conflicts:
phpBB/includes/functions_messenger.php
* github-elsensee/ticket/stenudd/8558:
[ticket/8558] Do string concatenation only once and do htmlspecialchars
[ticket/8558] Add display name in emails from board
* github-nickvergessen/ticket/12273: (55 commits)
[ticket/12273] Move $extension to constructor so the path is always set
[ticket/12273] Find events.md relative from the path not the phpbb root
[ticket/12273] Do not look in extensions docs/ and tests/ directory
[ticket/12273] Also check file for adm "Location:" events
[ticket/12273] Do not allow template events in non-html files
[ticket/12273] Fix return description
[ticket/12273] Update exporter to allow specifying an extension
[ticket/12273] Allow to filter events for extensions
[ticket/12273] Remove old parameter from function call
[ticket/12273] Fix table header for adm events
[ticket/12273] Add root path to recursive_event_filter_iterator
[ticket/12273] Fix missing classes in export_events_for_wiki.php
[ticket/12273] Use RecursiveDirectoryIterator with filter in php_exporter
[ticket/12273] Use RecursiveDirectoryIterator in md_exporter
[ticket/12273] Fix doc blocks
[ticket/12273] Do not allow 3.1-A1 for template events
[ticket/12273] Sort arguments alphabetically before exporting
[ticket/12273] Do not allow 3.1-A1 version
[ticket/12273] Update since version to 3.1.0-a* style
[ticket/12273] Update existing events
...
* github-nickvergessen/ticket/12371:
[ticket/12371] Fix language string
[ticket/12371] Fix typos in comment
[ticket/12371] Fix redirect link for approve_post and post_in_queue
[ticket/12371] Delete the approve_post notification when editing a post
[ticket/12371] Fix language in comment
[ticket/12371] Reapprove the post and topic again in tests
[ticket/12371] Correctly set is_starter when editing first post of the topic
[ticket/12371] Add functional tests for reapproving
[ticket/12371] Fix query in mcp_sorting()
[ticket/12371] Rename disapprove and softdelete tests
[ticket/12371] We do not group quote notifications anymore
[ticket/12371] Fix SQL query
[ticket/11772] Do not send out new topic/post notifications when reapproving
[ticket/12052] Use different visibility when post was edited
[ticket/12052] Add support for ITEM_UNAPPROVED to set_post_visibility method
[ticket/12371] Do not add unlimited users as responders
[ticket/12371] Do not update the notification entry unneccessarily
[ticket/12371] Do not delete post related notifications when a post is deleted
[ticket/12371] Allow notification types to redirect to a different url
[ticket/12371] Do not group "quote" notifications
# By Crizzo
# Via Crizzo
* remotes/Crizz0/ticket/12404:
[ticket/12404] Splits up the line 18 in subsilver2 into more lines
[ticket/12404] Changes append/prepend to after/before
[ticket/12404] Adds two new events and changes some places
[ticket/12404] Adds a new event before and after the Timezone display
# By Nicofuma
# Via Nicofuma
* remotes/Nicofuma/ticket/12432:
[ticket/12432] Correcting the assertion
[ticket/12432] Adding unit test
[ticket/12432] Migrator should not revert custom functions
# By Nicofuma
# Via Nicofuma
* remotes/Nicofuma/ticket/12444:
[ticket/12444] Replacing spaces with tabs
[ticket/12444] Replace spaces with tabs
[ticket/12444] Adding regression test
[ticket/12444] The logs message aren't filled correctly
# By Nicofuma
# Via Nicofuma
* remotes/Nicofuma/ticket/12445:
[ticket/12445] Change the formulation
[ticket/12445] Disapproved post: the name of the poster should be in logs
[ticket/12186] Move PM reports below post reports while installing for ascraeus
* n-aleha/ticket/12186a:
[ticket/12186] Move PM reports below post reports while installing for ascraeus
[ticket/12186] Move PM reports below post reports while installing
[ticket/12186] Move PM reports below post reports while installing
* n-aleha/ticket/12186:
[ticket/12186] Move PM reports below post reports while installing
* There MUST NOT be trailing whitespace at the end of lines.
* There MUST NOT be whitespace before the first content of a file.
* There MUST NOT be whitespace after the last content of a file.
* Functions MUST NOT contain multiple empty lines in a row.
PHPBB3-12458
[ticket/12456] Missing new lines at the end of file in language files
* nickvergessen/ticket/12456:
[ticket/12456] Add , after the last array element
[ticket/12456] Fix duplicated empty lines in language files
[ticket/12456] Fix missing new lines at the end of email templates
[ticket/12097] Validate_data() should work with class method
* Nicofuma/ticket/12097:
[ticket/12097] Bug fix and adding unit test
[ticket/12097] Validate_data() should work with class method
Currently 13 functions are marked as deprecated:
functions.php:
function set_var()
function request_var()
function set_config()
function set_config_count()
function tz_select()
function add_log()
functions_admin:
function cache_moderators()
function update_foes()
functions_compatibility:
function get_user_avatar()
function phpbb_hash()
function phpbb_check_hash()
function phpbb_clean_path()
functions_install:
function get_tables()
8 of them are still used in the core:
add_log Used in many places (~198 calls)
get_tables Used in install\install_convert::get_convert_settings
and functions_install.php\connect_check_db
get_user_avatar Used in phpbb\user_loader:get_avatar
phpbb_hash Used in phpbb\db\migration\data\v30x\release_3_0_5_rc1
request_var Used quite everywhere (~997 calls)
set_config Used in many places (~129 calls)
set_config_count Used in a few places (~37 calls)
set_var Used by phpbb_http_login
and phpbb\auth\provider\apache::autologin
PHPBB3-12199
[ticket/12012] Correctly drop default value constraints
* nickvergessen/ticket/12012:
[ticket/12012] Move property to the top
[ticket/12012] Move MS SQL server comparison into a method
[ticket/12012] Fix docs in connection manager
[ticket/12012] Remove duplicated code (only the $sql are different)
[ticket/12012] Handle begin and commit transactions in tests
[ticket/12012] Drop and recreate indexes when removing columns
[ticket/12012] Add a unit test for removing a column with indexes
[ticket/12012] Add a unit test for changing the column type
[ticket/12012] Return SQL statements for index drop/create
[ticket/12012] Fix tools::mssql_get_existing_indexes() for SQL Server 2000
[ticket/12012] Drop and recreate indexes when changing a column on MSSQL
[ticket/12012] Fix query layout
[ticket/12012] Correctly drop default value constraints on MSSQL
* nickvergessen/ticket/12382:
[ticket/12382] Mark broken nested loop with include as incomplete
[ticket/12382] Add template test for subloops inside includes
[ticket/12382] Add template test for subloops inside events
Since it is possible for extensions to add new user preferences to UCP,
it should be also possible to control it via ACP too
just like for build-in user preferences.
Thus, some prepend/append template events are added.
PHPBB3-12403
Only add notifications, if we are not reapproving post
When the topic was already approved, but was edited and
now needs re-approval, we don't want to notify the users again.
PHPBB3-11772
We run into the risc that the data is longer then the character limit
of the table column. However as we trim the users list anyway, we can
also just stop adding them and display "many others" instead of "x others"
PHPBB3-12371
When a post is marked edited and therefor marked as softdeleted/unapproved,
we should not delete the notifications, just like we can't delete the emails.
Links are out there anyway and just keeping the notification is fail save.
If we keep the notification we can just continue to update it when more posts
are added. Also when we delete a post, we don't have to go though the table
and find all related notifications to be able to delete them or even update
them, when they have responders set.
PHPBB3-12371
[ticket/12436] Data passed to sql_multi_insert is expected to be multi-d...
* bantu/ticket/12436:
[ticket/12436] Data passed to sql_multi_insert is expected to be multi-dim.
* github-nickvergessen/ticket/11917:
[ticket/11917] Move OAuth Module to the bottom while installing
[ticket/11917] Hide OAuth UCP Module when OAuth is not the selected backend
Conflicts:
phpBB/install/install_install.php
[ticket/12201] Clean up ACP attachment management page
* prototech/ticket/12201:
[ticket/12201] Decreased pagination font size.
[ticket/12201] Update select element to follow same design as prosilver.
[ticket/12201] Increase sort font size just slightly.
[ticket/12201] Add link to resync file stats after error.
[ticket/12201] Fix typos in language pack.
[ticket/12201] Display error and sorting options when there are no attachments
[ticket/12201] Only the top pagination should be floated to the right.
[ticket/12201] Rearrange pagination, sorting, and submit elements.
[ticket/12201] Center the file size and mark columns.
[ticket/12201] Separate pagination from table.
[ticket/12130] Fix issue with li:first-child in <ul> having a bullet in IE8.
* prototech/ticket/12130:
[ticket/12130] Fix issue with li:first-child in <ul> having a bullet in IE8.
Merge branch 'ticket/12413' into ticket/12413-ascraeus
* ticket/12413:
[ticket/12413] Revert e65a6dd8f4
Conflicts:
phpBB/feed.php
The reverting is not done for develop-ascraeus and above.
We want to fix it properly there instead.
PHPBB3-12413
"Merge remote-tracking branch 'dhruvgoel92/ticket/11271' into develop-olympus"
This reverts commit e65a6dd8f4, reversing
changes made to 214f515e9c.
PHPBB3-12413
[ticket/12193] Fix broken HTML if SQL error occurs during migration
* Elsensee/ticket/12193:
[ticket/12193] Fix broken HTML if SQL error occurs during migration
* PayBas/ticket/12347:
[ticket/12347] Remove unknown/unnecessary hack
[ticket/12347] IE8 compatible CSS selector
[ticket/12347] Changed from :after to :before
[ticket/12347] Changed to the new navbar templates
[ticket/12405] Valid timezone and dateformat for create_user() in tests
* VSEphpbb/ticket/12405:
[ticket/12405] Valid timezone and dateformat for create_user() in tests
[ticket/12390] Remove documentation, tests and other files from vendor/
* nickvergessen/ticket/12390:
[ticket/12390] Add comment to composer.json to update the build target
[ticket/12390] Move cleaning of vendor into it's own target
[ticket/12390] Remove documentation, tests and other files from vendor/
* VSEphpbb/ticket/12419:
[ticket/12419] Also shrink the size of "See All" in footer a little bit
[ticket/12419] Improve font size in notifications drop-down
There're events to modify UCP user preferences in ucp_prefs.php,
so it makes sense to add related events to acp_users.php to control
new user's prefs via ACP.
PHPBB3-12409
[ticket/12121] Preserve link redirect counts when updating from 3.0.x.
* prototech/ticket/12121:
[ticket/12121] Preserve link redirect counts when updating from 3.0.x.
[ticket/12417] Revert "No longer allow Travis CI HHVM environment to fai...
* bantu/ticket/12417:
[ticket/12417] Revert "No longer allow Travis CI HHVM environment to fail."
hhvm-nightly 2014.04.16~precise introduced "Attempted to serialize
unserializable builtin class DOMElement" errors when running functional tests.
This reverts commit ff7cc77f9d.
PHPBB3-12417
[ticket/12191] Move notification options to bottom while installing
* n-aleha/ticket/12191:
[ticket/12191] Move notification options to bottom while installing
[ticket/12401] Add $topic_data array to core.viewtopic_modify_post_row event
* rxu/ticket/12401:
[ticket/12401] Pass more data to core.viewtopic_modify_post_row event
* develop-olympus:
[ticket/10423] Replace foreach with function in viewtopic.php
[ticket/10423] Remove unnecessary include in test
[ticket/10423] Match multiple wildcards
[ticket/10423] Move code into a function and add tests for it
[ticket/10423] Remove * from search or highlight string
[ticket/10423] Remove * from search or highlight string
* Elsensee/ticket/10423:
[ticket/10423] Replace foreach with function in viewtopic.php
[ticket/10423] Remove unnecessary include in test
[ticket/10423] Match multiple wildcards
[ticket/10423] Move code into a function and add tests for it
[ticket/10423] Remove * from search or highlight string
[ticket/12388] Fix translation of log entries without additional log data
* nickvergessen/ticket/12388:
[ticket/12388] Add tests for lang() use on log actions without data
[ticket/12388] Fix translation of log entries without additional log data
This change will allow users to change the avatar path even if it's not
writable. However, this will get rid of the error message that the path is
not writable. Due to this, a minor addition to the explain message in the ACP
settings has been made.
PHPBB3-8960
The current event core.posting_modify_template_vars is just ran using dispatch
but it doesn't pass any data from posting.php to the listener. Because of that,
it's not possible to know anything from posting.php and therefore limits the
use cases of this event. This will change it to allow similar actions as with
the event core.modify_posting_parameters.
PHPBB3-12407
* marc/ticket/12372:
[ticket/12372] Use $() instead of jQuery() in core.js for toggleDisplay
[ticket/12372] Use admin.js $(document).ready for hiding questionnaire details
[ticket/12372] Rename JS function dE() to phpbb.toggleDisplay()
[ticket/12372] Move dE() function core.js
[ticket/12372] Unify definition of function dE() across all files
[ticket/12372] Use jQuery in javascript dE() function
Multiple wildcards are removed from the string if there is
no word before or after them. If there is a word before or
after them, they are just replaced with a single one.
PHPBB3-10423
$topic_data array is used in viewtopic.php to populate $post_row template
block array data. Although $topic_data is not being passed
to core.viewtopic_modify_post_row event for modifying/adding
$post_row data in it. So, pass this array to the event.
Also, total_posts is added.
PHPBB3-12401
The event allows extensions to use and/or modify topics list and/or
topics data before dumping out the viewforum page.
For extensions which operate with viewforum page, f.e. if the topics list
and data is needed to retrieve, add, modify additional topics info
before the output loop.
PHPBB3-12400
* marc/ticket/12398:
[ticket/12398] Use return of submit_post in softdelete and download tests
[ticket/12398] Use submit_post return in prune_shadow_topic_test
Upload filenames are already processed via htmlspecialchars in the
type_cast_helper of the new request class. There is no need to run it through
htmlspecialchars() again in the filespec class.
PHPBB3-12211
When you click on the link, the turning circle is missing, so you don't
know whether it is actually doing something or not, until the response is
served.
PHPBB3-12351
The symfony routing component allows us to use the path "/" for routes.
Therefore, we should be able to use example.com/app.php/ for controllers.
However, this currently does not properly work. The method get_web_root_path
incorrectly returns phpbb_root_path. Therefore, paths to images or files are
broken.
PHPBB3-12004
* marc/ticket/12386:
[ticket/12386] Rename DEBUG_EXTRA to DEBUG_CONTAINER for more descriptive name
[ticket/12386] Add DEBUG_EXTRA again and use it for container creation
We are currently creating a new compiled container on every page load when
having DEBUG enabled. However, one might only have that enabled to be
presented with errors or for getting the page load stats.
This change will add the DEBUG_EXTRA constant again. It will be used for
choosing whether the compiled container should be created on every page load -
when defined as true - or just once after the cache is cleared.
PHPBB3-12386
* paybas/ticket/12377:
[ticket/12377] Forgot to change the INCLUDEs
[ticket/12377] Renamed template files to navbar_xxx
[ticket/12377] Moved notifications to new template
[ticket/12377] Forgot empty line at the end
[ticket/12377] Move navbar(s) to new template file
* vsephpbb/ticket/12380:
[ticket/12380] Explicity state the order of sorting for login keys
[ticket/12380] Sort Remember Me keys by last login time in UCP
The Topic Tools menu appears at the top of a topic page and again at the
bottom of a topic page.
When you use the Topic Tools menu to Bookmark or Subscribe to a Topic, the
menu item you chose is updated to reflect that, by switching to say
Unsubscribe topic or Remove from Bookmarks.
However, this change is not mirrored in the other Topic Tools menu at the
other location on the page.
Both Topic Tools menus should be updated during the AJAX event, so that
they always show the same options to the user.
It is solved by creating a data-update-all attribute which contains all
the class/ID that will update when topic tool is clicked
PHPBB3-12355
* github-nickvergessen/ticket/12370:
[ticket/12370] Add unit tests for topic notifications
[ticket/12370] Fix functional notification test and remove unneeded requests
[ticket/12370] Do not delete topic notifications when the topic is visible
* github-nickvergessen/ticket/12113:
[ticket/12113] Fix view_log() tests
[ticket/12113] Correctly use plurals when deleting user warnings
[ticket/12113] Allow log entries to use plurals
* github-nickvergessen/ticket/12331:
[ticket/12331] Add functional test for saving custom profile fields
[ticket/12331] Fix SQL error when inserting a new entry to profile field data
* github-nickvergessen/ticket/12286:
[ticket/12286] Reword section about plurals
[ticket/12286] Fix spelling of elephant(s) in the sample
[ticket/12286] Correctly capitalize PHP
[ticket/12286] Fix nesting of ul inside li element
[ticket/12286] Add note that goto should not be used
[ticket/12286] Add section about plurals to the coding guidelines
[ticket/12286] Classes must use the name space
[ticket/12286] Remove section about utf8_normalize_nfc()
[ticket/12286] Use $request->variable() instead of request_var()
[ticket/12286] Function names should be prefixed with phpbb_
[ticket/12286] Add "Since" to template event docs
[ticket/12286] style.php and imagesets dont exist anymore
[ticket/12286] Styles have a phpbb_version and a style_version in 3.1
[ticket/12286] Use UTF8 (c) in style.cfg samples
* github-nickvergessen/ticket/12282:
[ticket/12282] Update new references
[ticket/12282] Update container db mock
[ticket/12282] Add new line at EOF of the interface
[ticket/12282] Use interface for type hinting
[ticket/12282] Use {@inheritDoc} for inherited methods
[ticket/12282] Add Interface for DBAL drivers
* github-nickvergessen/ticket/11352:
[ticket/11352] Add functional tests for disapproving a post/topic
[ticket/11352] Redirect the user back to view*.php after disapproving
* vsephpbb/ticket/11098:
[ticket/11098] Fix error reporting on the autologin key pages
[ticket/11098] Update subsilver2 to also include mark/unmark all buttons
[ticket/11098] HTML Validity fix to Notifications in UCP
[ticket/11098] Add mark/unmark all options to remember me keys
The error message that is presented if getimagesize() was unable to determine
an image's dimensions now additionally states that this might be caused by an
incorrect URL.
PHPBB3-10687
The response is already parsed and when running it through parseJSON returned
null prior to 1.9. Now there's an actual error thrown, so the function is
returning and thus leaving the attachment row intact.
PHPBB3-12375
* paybas/ticket/12369:
[ticket/12369] White-space cleanup
[ticket/12369] Removed template vars initial state
[ticket/12369] Added ACP vars
[ticket/12369] Add template var {BODY_CLASS} to HTML body
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/ticket/12349:
[ticket/12349] Fix Sniffer for @license tag
[ticket/12349] Update license header in several new files
* Marc/ticket/12362:
[ticket/12362] Do not use database test case as it's not needed
[ticket/12362] Add tests for schema generator
[ticket/12362] Throw exception in schema generator on unresolvable dependency
Currently, a link to Google and its logo are displayed in the
language/en/help_bbcode.php file to explain how to correctly format tags
and to add an image to a post. However, the Google logo is outdated and
Google does not allow the use of its logo on third-party websites. Plus,
that overload their servers. I used the blue phpBB logo to replace it
because the grey one with transparent background is hardly visible.
Originally, I just refreshed the old Google logo with the new one
(https://www.google.com/images/srpr/logo5w.png) but Joas proposed to use
the phpBB logo, and I agree with him.
PHPBB3-12361
We should only delete the topic notifications, when the topic is not approved
anymore. This happens, when the post was the last approved but is now
unapproved because the user is on queue, or when it has been softdeleted while
editing.
PHPBB3-12370
The user should be redirected back to:
- the topic, if he came from viewtopic and the topic still exists
- the forum, if he came from viewtopic, but the topic does not exist anymore
PHPBB3-11352
In 7d8b578 this line was introduced to fix a bug with style.php.
Later since 1d42d1b a new session is always created after
killing the old one.
This causes a duplicated creation of the session everytime
the user logs itself out.
PHPBB3-12360
* Marc/ticket/12150:
[ticket/12150] Use correct license URL in prune shadow migrations file
[ticket/12150] Remove 'after' for columns from migrations file
[ticket/12150] Update schema files for prune shadow topics
[ticket/12150] Use log service instead of add_log() function
[ticket/12150] Use shorter column names for prune settings
[ticket/12150] Add functional tests for pruning shadow topics
[ticket/12150] Add missing space to query for shadow topics
[ticket/12150] Add missing prune settings variables in acp_forums
[ticket/12150] Add file and caller for pruning shadow topics
[ticket/12150] Add prune columns to schema files and migration file
[ticket/12150] Add options to acp
Make sure we throw an exception in the schema generator if we come across an
unresolvable dependency. Otherwise we'll get stuck in a infinite loop that
needs to be cancelled by the user or the maximum execution time.
PHPBB3-12362
In some tests we try to make sure that we do not get the same output in a
limited timeframe. These tests should use assertSame/NotSame instead of
assertEqual/NotEqual.
PHPBB3-12354
* Marc/ticket/10851-ascraeus:
[ticket/10851] Request index instead of logging in and out in tests
[ticket/10851] Add unit and functional tests for checking attachments
[ticket/10851] Set disallowed content to empty array if checking is disabled
* Elsensee/ticket/7707:
[ticket/7707] Fix undefined variable: perm_from
[ticket/7707] Add comma to last entry of arrays
[ticket/7707] Remove unnecessary variables
[ticket/7707] Add get_username_string() once more
[ticket/7707] Remove unnecessary variables
[ticket/7707] Add get_username_string() where possible
* paybas/ticket/12339:
[ticket/12339] removed return var
[ticket/12339] more complete params and updated _since version
[ticket/12339] Add Event core.page_header_after
* vsephpbb/ticket/12342:
[ticket/12342] Remove spinner and fix useage of ajax on memberlist
[ticket/12342] Fix the Custom Dates function in UCP Prefs Global
[ticket/12342] Fix Find a member show / hide script
[ticket/12342] Use prop() instead of attr() for boolean properties
This reverts commit f6614f2078 as the install
command started failing with "Version '3.0.0~precise' for 'hhvm' was not found"
in the meantime.
PHPBB3-12318
The disallowed content defaults to a standard set of mimetype triggers by
default. If one doesn't want to check the attachments mimetype triggers then
we need to set the disallowed content to an empty array.
PHPBB3-10851
* vsephpbb/ticket/12043:
[ticket/12043] Fix order of disabled extensions in unit tests
[ticket/12043] Correct try/catch exceptions for invalid extensions
[ticket/12043] Sort Extensions by Display Name in ACP Extension mananger
* develop-olympus:
[ticket/12318] Use MySQL instead of MySQLi for now on HHVM.
[ticket/12318] Pin HHVM version to 3.0.0~precise.
[ticket/12318] Always install new config file on HHVM upgrade conflict.
[ticket/12318] Add PPA providing dependencies for recent HHVM on Ubuntu 12.04.
[ticket/12318] Upgrade to a recent stable version of HHVM.
[ticket/12318] Correctly setup HHVM for functional tests.
* bantu/ticket/12318-olympus:
[ticket/12318] Use MySQL instead of MySQLi for now on HHVM.
[ticket/12318] Pin HHVM version to 3.0.0~precise.
[ticket/12318] Always install new config file on HHVM upgrade conflict.
[ticket/12318] Add PPA providing dependencies for recent HHVM on Ubuntu 12.04.
[ticket/12318] Upgrade to a recent stable version of HHVM.
[ticket/12318] Correctly setup HHVM for functional tests.
* crizz0/ticket/9758:
[ticket/9758] Clickable avatar in header and renamed class for avatar-img
[ticket/9758] Remove unnessary if-question for include functions_display
[ticket/9758] Slims the line 4775 in includes/functions.php
[ticket/9758] Adds id and changes filter to fix travis CI test
[ticket/9758] Removed the needless space after first ENDIF
[ticket/9758] Adding impr. for overall_header display of avatar and username
[ticket/9758] Fixed bug in mcp_warn.php
[ticket/9758] Optimises the html code of avatar image in header
[ticket/9758] Error because of missing functions_display.php fixed
[ticket/9758] Removed useless if-conditions to include functions.php
[ticket/9758] Changes class name of new "span" in overall_header.html
[ticket/9758] Adds global template variable CURRENT_USER_AVATAR
* prep-release-3.1.0-b2:
[prep-release-3.1.0-b2] Prepare development of 3.1.0-b3
[prep-release-3.1.0-b2] Add changelog for 3.1.0-b2
[prep-release-3.1.0-b2] Prepare Changelog
[prep-release-3.1.0-b2] Add migration for 3.1.0-b2
[prep-release-3.1.0-b2] Update version to 3.1.0-b2
* nickvergessen/ticket/12326:
[ticket/12326] Correctly format update/index.php and remove php closing tag
[ticket/12326] Do not add deleted files to the list of changed files
There was a "Field 'pf_phpbb_interests' doesn't have a default value" error,
because we didn't specify values for the disabled fields.
We can not disable the sql_return_on_error() thou, because it otherwise we run
into "Duplicate entry '2' for key 'PRIMARY'" errors when the user submits the
form again but didn't change any values.
PHPBB3-12331
[ticket/12321] Remove execute bit from ucp_main_subscribed.html and buttons.png
* n-aleha/ticket/12321:
[ticket/12321] Remove execute bit from ucp_main_subscribed.html and buttons.png
All columns were renamed from having prune_shadow_topics as namebase to just
prune_shadow.
A missing column was also added to the migration file's remove_schema() method.
PHPBB3-12150
* github-nickvergessen/ticket/11459: (21 commits)
[ticket/11459] Make 3.1.0-dev migration depend on migrations_table
[ticket/11459] Move $supported_dbms to beginning of create schema file
[ticket/11459] Fix missing constant CONFIG_TABLE for sql_create_index()
[ticket/11459] Fix auth provider test
[ticket/11459] Correctly set up the database from schema in unit tests
[ticket/11459] Install DB schema from json file
[ticket/11459] Clean up a little more
[ticket/11459] Do not add table schema to database schema files
[ticket/11459] Create schema.json from migration files
[ticket/11459] Do not take files of extensions into account
[ticket/11459] Pass array with migration class names to schema generator
[ticket/11459] Refresh schema files
[ticket/11459] Remove spaces from the end of lines in MSSQL
[ticket/11459] Correctly handle index column length
[ticket/11459] Add migration for migrations table
[ticket/11459] Update doc blocks
[ticket/11459] Remove old schema file
[ticket/11459] Update schema files with new script
[ticket/11459] Use new migration/schema_generator to create schema files
[ticket/11459] Add Schema from 3.0.0
...
* prototech/ticket/11959:
[ticket/11959] Move phpbb_generate_string_list() to functions_content.php.
[ticket/11959] Add unit tests.
[ticket/11959] Remove use of plurals and make it possible to use Oxford comma.
[ticket/11959] Rename phpbb_gen_string_list() & fix incorrect var name.
[ticket/11959] Simplify how the users are trimmed.
[ticket/11959] Add function to create a string list.
[ticket/11959] Add samples for the untrimmed strings.
[ticket/11959] List the last user with "and" instead of a comma.
[ticket/11959] Use the plurals system for the untrimmed language strings.
[ticket/11959] Fix the NOTIFICATION_QUOTE_TRIMMED text.
[ticket/11959] Use plurals for the language strings.
When a forum has a forum-rules link instead of forum-rules text, there
is no way to distinguish in the styling of the container (or the button)
it will have.
It should be possible to style the <div class="rules"> container
differently if there is only a link (no text).
PHPBB3-12304
* vsephpbb/ticket/12300:
[ticket/12300] Make only red topic/forum row icons clickable to unread posts
[ticket/12300] Fix broken link to last post in topic subscriptions list
[ticket/12300] Fix alignment of clickable icons
[ticket/12300] Make all topic row icons clickable
[ticket/12300] Rename new class for row icon links
[ticket/12300] Make topic icon links clickable to newest unread posts
[ticket/12300] Revert topic title links back to default behavior
This migration will always be skipped on updates, because database_update.php
creates the table. But the create schema script requires the migration,
so the table is created for new installs.
PHPBB3-11459
* crizz0/ticket/11336:
[ticket/11336] Adds 301 info to redirect
[ticket/11336] Adds redirect for old "leaders" mode
[ticket/11336] Changes language variabel LOGIN_EXPLAIN_LEADERS to _TEAM
[ticket/11336] Changes "leaders"-mode to "team"-mode and so in test-file
* vsephpbb/ticket/12311:
[ticket/12311] Use British-English spelling of licence in lang file
[ticket/12311] Use valid composer schema - license - for extensions
* vsephpbb/ticket/11230:
[ticket/11230] Add missing last returns to dock block
[ticket/11230] Update cache driver dock blocks
[ticket/11230] Use inheritdoc in docblocks in cache drivers
* geetakshi/ticket/11360:
[ticket/11360] Updating default value of $display_online_list
[ticket/11360] Avoiding online list where not required
[ticket/11360] Change second parameter in page_header function
Forum list icons link to first page of forum
UCP subscribed forums icons link to first page of forum
MCP Forum page topic icons link to first (or first unread) post
PM Icons link to the message
PHPBB3-12300
Upgrade all composer.phar to 1.0.0-alpha8
* s9e/ticket/12302:
[ticket/12302] Added `--no-dev` to composer call in build.xml
[ticket/12302] Updated composer.phar to 1.0.0-alpha8
[ticket/12257] Use MyISAM in PHP 5.3 environment such that FULLTEXT test...
* bantu/ticket/12257:
[ticket/12257] Use MyISAM in PHP 5.3 environment such that FULLTEXT tests run.
Conflicts:
.travis.yml
Changing the language string from "Ban usernames" to "Ban users"
to clarify its use. It bans users by their name and not the username itself
PHPBB3-10174
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/ticket/12268:
[ticket/12268] Do not use substr but just compare the character
[ticket/12268] Rename class file to recursive_dot_prefix_filter_iterator.php
[ticket/12268] Move class out of extension namespace and rename it
[ticket/12268] Do not search in folders starting with a dot
[ticket/12268] Use FilesystemIterator::SKIP_DOTS
[ticket/12268] Extension finder should not crawl through .git/ of extensions
* develop-olympus:
[ticket/12035] Correcting the condition
[ticket/12035] Adding necessary conditions
[ticket/12035] Adding link to user posts to ACP page
Conflicts:
phpBB/adm/style/acp_users_overview.html
* geetakshi/ticket/12035:
[ticket/12035] Correcting the condition
[ticket/12035] Adding necessary conditions
[ticket/12035] Adding link to user posts to ACP page
http://tracker.phpbb.com/browse/PHPBB3-12292
Gave style details page a proper heading and back button.
Also removed a few obsolete code leftovers in the style
and CSS.
PHPBB3-12292
* prototech/ticket/12160:
[ticket/12160] Use phpbb_check_installation_exists() in the other modules.
[ticket/12160] Move phpbb_check_installation_exists() to functions_install.php
[ticket/12160] Check if phpBB is installed before creating phpBB container.
[ticket/12160] Add function to check if phpBB is installed.
This event allows extensions to set display option for custom MCP modules
for extensions which add custom MCP modules
and some of them should be displayed conditionally.
PHPBB3-12278
Currently when an user adds a HTML entity to a custom profile field, the length
gets incremented by 4 since the code reads > instead of <. However, the
length is presentational and not DB storage so it should be treated as a
single character even if it takes four lengths in the DB by being stored as
a HTML entity.
Work around this by decoding html entities before counting. Also, added unit
tests for string field type
PHPBB3-9040
http://tracker.phpbb.com/browse/PHPBB3-7580
This test demonstrates that is possible to test if a
variable exists and then use it if it does, similar to
using isset(), but in template/twig syntax.
<!— IF {VAR} is defined —>{VAR}<!— ENDIF —>
PHPBB3-7580
# By geetakshi
# Via geetakshi
* 'ticket/11239' of github.com:geetakshi/phpbb:
[ticket/11239] Removing hard-coded, language specific possessive
[ticket/11239] Including username before Overview title
/home/travis/build/phpbb/phpbb/redis/redis.c:6141:34:
error: unknown type name ‘tsrm_ls’
make: *** [redis.lo] Error 1
The command "sh -c "if [ '$TRAVIS_PHP_VERSION' != 'hhvm' ];
then travis/setup-php-extensions.sh; fi"" failed
and exited with 2 during install.
PHPBB3-12281
* prep-release-3.1.0-b1:
[prep-release-3.1.0-b1] Update build version to 3.1.0-b2-dev
[prep-release-3.1.0-b1] Add changelog for 3.1.0-b1
[prep-release-3.1.0-b1] Prepare Changelog
[prep-release-3.1.0-b1] Add migration for 3.1.0-b1
[prep-release-3.1.0-b1] Update version to 3.1.0-b1
This new filter ignores .svn and .git directories.
When searching for php classes and template files of extensions
we don't need to look inside these directories.
PHPBB3-12268
SQL Azure requires a primary AKA clustered key on every table.
This adds a dummy INT column to act as key,
avoiding possible duplicate entries.
so that these columns can support bigger (speak: huge) tables
PHPBB3-9725
Two problems were encountered when installing on AzureSQL:
-Azure SQL does not support the ON clause of T-SQL
-Azure SQL requries a clustered index AKA primary key on all tables
The fix is makeshift; it introduces questionable primary indices, which should be replaced with auto--increment columns.
PHPBB3-9725
The newly added test case will also emulate a non-existing fileinfo
in order to check if the mimetype guesser is properly working when
fileinfo is not available.
PHPBB3-12071
Tests that depend on fileinfo being enabled will now be skipped to prevent
fatal errors while running the test suite. The expected results will be
modified to "application/octet-stream" in test_guess_files() if only the
extension_guesser is available due to the non-existing extension of those
files.
PHPBB3-12071
# By Joas Schilling (613) and others
# Via Andreas Fischer (214) and others
* 'develop' of github.com:phpbb/phpbb3: (2494 commits)
[ticket/11825] Move schema_data.php into includes/ instead of phpbb/
[ticket/11215] Remove unnecessary comment
[ticket/11755] MySQL upgrader out of date
[prep-release-3.0.12] Update Changelog for 3.0.12-RC3 release.
[prep-release-3.0.12] Bumping version number for 3.0.12-RC3.
[ticket/11823] Set up nginx server to match PHP files with characters after .php
[ticket/11812] Fix empty define
[ticket/11818] Update Symfony dependencies to 2.3.*
[ticket/11791] Load adm/ events from styles/adm/event/
[ticket/11215] Fix helper_url_test.php tests
[ticket/11215] Add newline back to .htaccess, fix wording
[ticket/11215] Update comment in .htaccess
[ticket/11215] Uncomment rewrite rules in .htaccess
[ticket/11215] Make controller helper url() method use correct format
[ticket/11215] Add commented-out URL rewrite capability to .htaccess
[ticket/11821] Fix comma usage next to "You are receiving this notification".
[ticket/11769] Allow using 0 as poster name
[ticket/11769] Allow '0' as username
[ticket/11215] Use new URL structure for controllers
[ticket/11215] Everything appears to be working...
...
Conflicts:
phpBB/includes/functions_privmsgs.php
Allow other types of inactive accounts to receive PMs. Remove the banned PM error message and use the string saying they do not have permission (less translation)
PHPBB3-8323
Also correcting the way it was setup for users to be able to receive PMs (do not allow administrators/moderators to send to banned, inactive, or non-standard users, that just doesn't make sense)
PHPBB3-8323
Added an argument to the phpbb_get_banned_user_ids() function to allow specifying a banned end time (default true for current functionality, false for only permanent bans, timestamp to find banned until a specified time)
PHPBB3-8323
@@ -25,9 +25,11 @@ To be able to run an installation from the repo (and not from a pre-built packag
## AUTOMATED TESTING
We have unit and functional tests in order to prevent regressions. You can view the bamboo continuous integration [here](http://bamboo.phpbb.com) or check our travis build below.
We have unit and functional tests in order to prevent regressions. You can view the bamboo continuous integration [here](http://bamboo.phpbb.com) or check our travis build below:
; The directory to place generated documentation in. If the given path is
; relative to it will be relative to "source_path".
d="../build/api/"
; Specifies the title to be placed in the HTML <title> tag.
windowtitle="phpBB3"
; Specifies the title to be placed near the top of the overview summary file.
doctitle="phpBB3 Sourcecode Documentation"
; Specifies the header text to be placed at the top of each output file. The
; header will be placed to the right of the upper navigation bar.
header="phpBB3"
; Specifies the footer text to be placed at the bottom of each output file. The
; footer will be placed to the right of the lower navigation bar.
footer="phpBB3"
; Specifies the text to be placed at the bottom of each output file. The text
; will be placed at the bottom of the page, below the lower navigation bar.
;bottom = "This document was generated by <a href="http://peej.github.com/phpdoctor/">PHPDoctor: The PHP Documentation Creator</a>"
; Create a class tree?
;tree = off
; Use GeSHi to include formatted source files in the documentation. PHPDoctor will look in the current doclet directory for a /geshi subdirectory. Unpack the GeSHi archive from http://qbnz.com/highlighter to get this directory - it will contain a php script and a subdirectory with formatting files.
<inputtype="button"class="button2"accesskey="b"name="addbbcode0"value=" B "style="font-weight:bold; width: 30px"onclick="bbstyle(0)"title="{L_BBCODE_B_HELP}"/>
<inputtype="button"class="button2"accesskey="i"name="addbbcode2"value=" i "style="font-style:italic; width: 30px"onclick="bbstyle(2)"title="{L_BBCODE_I_HELP}"/>
<inputtype="button"class="button2"accesskey="u"name="addbbcode4"value=" u "style="text-decoration: underline; width: 30px"onclick="bbstyle(4)"title="{L_BBCODE_U_HELP}"/>
<inputtype="button"class="button2"accesskey="b"name="addbbcode0"value=" B "style="font-weight:bold; width: 30px"onclick="bbstyle(0)"title="{L_BBCODE_B_HELP}"/>
<inputtype="button"class="button2"accesskey="i"name="addbbcode2"value=" i "style="font-style:italic; width: 30px"onclick="bbstyle(2)"title="{L_BBCODE_I_HELP}"/>
<inputtype="button"class="button2"accesskey="u"name="addbbcode4"value=" u "style="text-decoration: underline; width: 30px"onclick="bbstyle(4)"title="{L_BBCODE_U_HELP}"/>
* @license GNU General Public License, version 2 (GPL-2.0)
*
* For full copyright and license information, please see
* the docs/CREDITS.txt file.
*
*/
Some files were not shown because too many files have changed in this diff
Show More
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.