* develop-olympus:
[ticket/12755] Apply de morgan to conditional
[ticket/12755] Terminate upload loop if upload reaches filesize
[ticket/12755] Change upload in remote_upload() method to fit get_remote_file
[ticket/12755] Add language string for timed out remote upload
[ticket/12755] Add timeout to remote upload to prevent infinite loop
[ticket/12755] Add timeout to remote upload to prevent infinite loop
* marc1706/ticket/12755:
[ticket/12755] Apply de morgan to conditional
[ticket/12755] Terminate upload loop if upload reaches filesize
[ticket/12755] Change upload in remote_upload() method to fit get_remote_file
[ticket/12755] Add language string for timed out remote upload
[ticket/12755] Add timeout to remote upload to prevent infinite loop
Terminate the upload loop if the expected filesize has been reached instead
of trying to read more bytes until the timeout has been reached.
PHPBB3-12755
* github-nickvergessen/ticket/12612:
[ticket/12612] Prefix check_ids() with phpbb_
[ticket/12612] Prefix mcp_sorting() with phpbb_
[ticket/12612] Prefix get_*_data() with phpbb_ and delete unused global
[ticket/12612] Prefix module url functions with phpbb_
[ticket/12612] Prefix upload_popup() with phpbb_
[ticket/12612] Prefix handle_post_delete() with phpbb and remove unused global
[ticket/12612] Prefix custom UCP module function with phpbb_
[ticket/12612] Prefix _sort_last_active() with phpbb_
[ticket/12612] Prefix show_profile() with phpbb and delete unused global
Ticket/12763 Do not regenerate the *_schema.sql files
* nickvergessen/ticket/12763:
[ticket/12763] Remove invalid comment from oracle and postgres *_schema.sql
[ticket/12763] Remove empty schema files
[ticket/12763] Do not regenerate the *_schema.sql files
[ticket/11528] Refactor install_board( ) into a new mink class
* dhruvgoel92/ticket/11528:
[ticket/11528] Change click_submit() to accept id as param
[ticket/11528] Handle case when config file cant be written by installer
[ticket/11528] Change NULL to null
[ticket/11528] Fix spaces and slashes as per guidelines
[ticket/11528] Add asserts in installation steps
[ticket/11528] Use 'use' keyword to import classes to current scope
[ticket/11528] Move parent::tearDown() to end of tearDown()
[ticket/11528] Call parent::tearDown in overrided tearDown method
[ticket/11528] Instantiate $client, $driver from functional test case
[ticket/11528] Refactor install_board() code into a new class
[ticket/11528] Add behat/mink and mink-goutte-driver as dependency
[Ticket/12696] Add events to ucp_register.html
* lucifer4o/ticket/12696:
[ticket/12696] Typo
[ticket/12696] Change some parts
[ticket/12696] Naming convention changes
[ticket/12696] A small error with events.md perms
[ticket/12696] Add events to evets.md
[ticket/12696] Add prosilver ucp_register
[ticket/12696] Add events to ucp_register.html
[ticket/12690] Add core.submit_pm_after event
* lucifer4o/ticket/12690:
[ticket/12690] Find a space
[ticket/12690] Remove $msg_id and chmod
[ticket/12690] Add other info to core.submit_pm_after
[ticket/12690] Add core.submit_pm_after event
* github-nickvergessen/ticket/12612-ascraeus:
[ticket/12612] Move functions from mcp.php to functions_mcp.php
[ticket/12612] Move function from ucp.php to functions_user.php
[ticket/12612] Move functions from memberlist.php to functions_display.php
[ticket/12612] Move functions from posting.php to functions_posting.php
[ticket/12747] Drop support for Firebird
* nickvergessen/ticket/12747:
[ticket/12747] Remove some methods which are not used anymore
[ticket/12747] Drop support for Firebird
Conflicts:
phpBB/phpbb/db/driver/firebird.php
[ticket/12704] Improve the load time information in the footer when enabled
* rxu/ticket/12704:
[ticket/12704] Improve the load time information in the footer when enabled
[ticket/12714] Switching the description of radio buttons to align the correct description above the listbox
* Skouat/ticket/12714:
[ticket/12714] Move "allow all forums" in its own dd-element
[Ticket/12701] Add events to user_add function
* lucifer4o/ticket/12701:
[ticket/12701] Add change
[ticket/12701] Rmove before event and expand modify_data
[ticket/12701] Add events to user_add function
Add events to UCP Register template:
ucp_register_before - add before start of registration form fields
ucp_register_after - add after end of registration form fileds
ucp_register_passowrd_after - add event after passowrd field
ucp_register_language_before - add event before language selector
ucp_register_profiles_before - add event just before begining of
registration profile informatiom
All events are inside the registration form fieldset.
All events are inside the registration form
Justification:
Add abbility of extension author to include custom
checks or fields inside the registration form.
Like age check field/verification.
PHPBB3-12696
Add two new events to user_add function
in ./includes/functions_user.php.
core.user_add_before - allow modification of
submitted to function data.
Returns:
@var array $user_row - user_row array - User array
@var array $cp_data - cp_data array - CPF array
core.user_add_after - return user_id, user_row and
cp_data after user registration
Returns:
@var int $user_id - user_id of the new user
@var array $user_row - user_row array - User array
@var array $cp_data - cp_data array - CPF array
Justification:
Allow extensions to parse data before and after
creation of the user.
PHPBB3-12701
Add core.delete_pm to funtion delete_pm.
Event will return:
int $user_id - ID of the user requested the message delete
array $msg_ids - array of all messages to be deleted
int $folder_id - ID of the user folder where the messages are stored
Justification:
Allow extensions to capture this event
and act as intended by ext author
PHPBB3-12691
Add core.submit_pm_after to funtion submit_pm.
Event will return just submited msg_id. It should be plased
just before return $data['msg_id'];
Justification:
Using only core.submit_pm_before does not allow to
follow up after message submission.
The message ID is recieved at DB submission.
Some times we need the MSG_ID as identifier
PHPBB3-12690
[ticket/12758] Add show_results var to core.search_modify_rowset
* PayBas/ticket/12758:
[ticket/12758] Add @changed to doc block
[ticket/12758] Add show_results var to core.search_modify_rowset
[ticket/12753] Add invalid chars string for ALPHA_DOTS and ALPHA_PUNCTUAION
* Dragooon/ticket/12753:
[ticket/12753] Add invalid chars string for ALPHA_DOTS and ALPHA_PUNCTUATION
[ticket/12730] Add Google+ profile field
* Dragooon/ticket/12730:
[ticket/12730] Update Google+ button class to use proper identification
[ticket/12730] Update maxlen for type_googleplus to 255
[ticket/12730] Fix type_googleplus_test to use same validation rule as the field
[ticket/12730] Update field_length to be 20 by default for Google+
[ticket/12730] Google+ field_order should be 13
[ticket/12730] Switch service name to googleplus for type_googleplus
[ticket/12730] Restore field_length to 10 for type_googleplus
[ticket/12730] Add functional test for Google+ field
[ticket/12730] Value shouldn't be escaped for schema_data.sql
[ticket/12730] Missing newline at type_googleplus_test.php
[ticket/12730] Set field_active to 1 for Google+ field
[ticket/12730] Add unit test for type_googleplus
[ticket/12730] Add missing brackets to type_googleplus.php
[ticket/12730] Update field_order for Google+ CPF
[ticket/12730] Use string template for Google+ CPF instead of a new one
[ticket/12730] Minor formatting fixes
[ticket/12730] Incorrect indentation for type_googleplus
[ticket/12730] Spaces in block header
[ticket/12730] Add a Google+ field by default
[ticket/12730] Add Google+ profile field type
[ticket/12723] Add Sniff ensuring PHP files use the correct file header
* Nicofuma/ticket/12723:
[ticket/12723] Do not mention too many details on documentation.
[ticket/12723] Do not reference the coding guidelines section.
[ticket/12757] Add a Code Sniffer ruleset for PHP files of phpBB extensions
[ticket/12723] Properly describe new Code Sniffer rulsets.
[ticket/12723] Use core suffix in filename instead of phpbb in the middle.
[ticket/12723] Add Sniff ensuring PHP files use the correct file header
[ticket/12752] Cron list tests fail on windows with ansi support
* Nicofuma/ticket/12752:
[ticket/12752] Cron list tests fail on windows with ansi support
Google+ has a "+" before a custom URL but doesn't for those which are using
their integer ID. To cover that we need to have an extra profile field
PHPBB3-12730
[ticket/12731] Add YouTube custom profile field
* Dragooon/ticket/12731:
[ticket/12731] Add functional test for youtube field
[ticket/12731] Set field_active to 1 for YouTube field
[ticket/12731] Add YouTube custom profile field
Conflicts:
phpBB/install/schemas/schema.json
phpBB/install/schemas/schema_data.sql
phpBB/language/en/memberlist.php
tests/functional/ucp_profile_test.php
[ticket/12732] Add Skype custom profile field
* Dragooon/ticket/12732:
[ticket/12732] Update schema.json for Skype
[ticket/12732] Add functional test for Skype profile field
[ticket/12732] Values shouldn't be escaped for schema_data.sql
[ticket/12732] Set field_active to 1 for Skype's field
[ticket/12732] Add unit tests for ALPHA_PUNCTUATION
[ticket/12732] Missing comma after validation definition
[ticket/12732] Improve ALPHA_PUNCTUATION description
[ticket/12732] Use user info instead of chat as default Skype action
[ticket/12732] Add Skype custom profile field
Conflicts:
phpBB/install/schemas/schema.json
phpBB/install/schemas/schema_data.sql
phpBB/language/en/memberlist.php
tests/functional/ucp_profile_test.php
tests/profilefields/type_string_test.php
[ticket/12733] Add Twitter custom profile field
* Dragooon/ticket/12733:
[ticket/12733] Add functional test for twitter profile field
[ticket/12733] Values needn't be escaped for schema_data.sql
[ticket/12733] Set field_active to 1 for Twitter
[ticket/12733] Convert spaces to tabs
[ticket/12733] Fix spacing for block header in profilefield_twitter.php
[ticket/12733] Update schema.json
[ticket/12733] Add Twitter custom profile field
Conflicts:
phpBB/install/schemas/schema.json
phpBB/install/schemas/schema_data.sql
phpBB/language/en/memberlist.php
tests/functional/ucp_profile_test.php
[ticket/12729] Add Facebook custom profile field
* Dragooon/ticket/12729:
[ticket/12729] Add functional test for Facebook field
[ticket/12730] Values needn't be escaped for schema_data.sql
[ticket/12729] Set field_active as 1 for Facebook profile field
[ticket/12729] Add unit test for ALPHA_DOTS validation
[ticket/12729] Move ALPHA_DOTS to above ALPHA_SPACERS
[ticket/12729] Convert spaces to tabs
[ticket/12729] Fix block header spacing for profilefield_facebook.php
[ticket/12729] Update schema.json
[ticket/12729] Unnecessary whitespace in profilefield_facebook.php
[ticket/12729] Cleanup schema_data.sql for Facebook field
[ticket/12729] Add Facebook custom profile field
[ticket/12746] Init phpbb_dispatcher being used by delete_post()
* dhruvgoel92/ticket/12746:
[ticket/12746] Init phpbb_dispatcher being used by delete_post()
PR #2570 has added new constant to display load time information without
debug mode is being on (https://tracker.phpbb.com/browse/PHPBB3-12687).
This patch expands the total load time info with SQL/PHP load times,
while hiding the additional info with <abbr> element.
PHPBB3-12704
[ticket/12514] Add tests for profile fields
* Dragooon/ticket/12514: (28 commits)
[ticket/12514] Fix array formatting for tests
[ticket/12514] Fix indention for type_url_test.php
[ticket/12514] Missed a few spaces in comments
[ticket/12514] Convert spaces to tabs
[ticket/12514] Add a few additional tests for type_dropdown
[ticket/12514] Add a few additional tests for type_int
[ticket/12514] Fix some formatting for tests
[ticket/12514] Add a few more tests for type_date
[ticket/12514] Remove spaces in header blocks
[ticket/12514] Use generic domain name for URL test
[ticket/12514] Update file headers to represent the current format
[ticket/12514] Remove get_ prefix from data providers
[ticket/12514] Add a few more validation cases for type_string_test
[ticket/12514] Minor fault in type_bool_test.php
[ticket/12514] Remove tests/profiles as they're no longer required
[ticket/12514] Fix type_int_test to correctly respect boundaries
[ticket/12514] Multi value GET parameters are invalid for phpBB
[ticket/12514] Add unit test for type_url custom profile field
[ticket/12514] Add unit test for type_date custom profile field
[ticket/12514] Add unit test for type_bool custom profile field
...
[ticket/11711] Inform user of unsupported characters while posting
* marc1706/ticket/11711:
[ticket/11711] Improve coding and comments of character check
[ticket/11711] Reduce size of tests and also test topic titles
[ticket/11711] Improve checks for unsupported characters and check subject
[ticket/11711] Inform user of unsupported characters while posting
[ticket/12553] Right-to-left fixes.
* prototech/ticket/12553:
[ticket/12553] Fix responsive user profile.
[ticket/12553] Fix responsive post profile.
[ticket/12553] Remove dropdown-trigger class from member search input.
[ticket/12553] Fix the merge topic list.
[ticket/12553] Fix dropdown position of live search
[ticket/12553] Fix the responsive topic/forum lists.
[ticket/12553] Align the text in responsive tables to the right.
[ticket/12553] Center the responsive CP menus instead of floating right.
[ticket/12553] Open the notification dropdown to the left.
[ticket/12553] Fix alignment of contact icon.
[ticket/12553] Fix incorrect alignment in ACP responsive tables.
[ticket/12553] Align alert text to the right.
[ticket/12553] Remove incorrect size for site logo.
[ticket/12553] Fix links in the last post column that are not clickable.
[ticket/12553] Align contact icons to the right.
[ticket/12553] Move Place inline and Delete buttons left of the file name.
[ticket/12638] v30x\local_url_bbcode break the migrations if we don't use the auto updater
* Nicofuma/ticket/12638:
[ticket/12638] Use require if phpbb_require_updated isn't available
[Ticket/12699] Remove magic numbers in the message textarea keydown callback
* brunoais/ticket/12699:
[ticket/12699] Replace magic numbers for the TAB and for ENTER keydown
[ticket/12699] Add tab key to keymap
[ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset
* Nicofuma/ticket/12722:
[ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset
[ticket/12720] Allow commit heading to begin with lowercase letters
* dhruvgoel92/ticket/12720:
[ticket/12720] Allow commit heading to begin with lowercase letters
Ticket/12643 Fixes deletion of columns that have the target column as a prefix
* Noxwizard/ticket/12643:
[ticket/12643] Properly handle changing columns on tables with constraints
[ticket/12643] Tests dropping similarly named columns
[ticket/12643] Ensure that similarly named columns are not removed
[ticket/12715] Fix mistakes in the doc blocks
* Nicofuma/ticket/12715: (30 commits)
[ticket/12715] Add missing new line in the notification manager
[ticket/12715] Cleanup comments in \phpbb\symfony_request
[ticket/12715] Cleanup comments in \phpbb\permissions
[ticket/12715] Cleanup comments in \phpbb\path_helper
[ticket/12715] Cleanup comments in \phpbb\pagination
[ticket/12715] Cleanup comments in \phpbb\datetime
[ticket/12715] Cleanup comments in \phpbb\content_visibility
[ticket/12715] Cleanup comments in \phpbb\tree\*
[ticket/12715] Cleanup comments in \phpbb\template\*
[ticket/12715] Cleanup comments in \phpbb\plupload\*
[ticket/12715] Cleanup comments in \phpbb\profilefields\*
[ticket/12715] Cleanup comments in \phpbb\passwords\*
[ticket/12715] Cleanup comments in \phpbb\notification\*
[ticket/12715] Cleanup comments in \phpbb\mimetype\*
[ticket/12715] Cleanup comments in \phpbb\message\*
[ticket/12715] Cleanup comments in \phpbb\log\*
[ticket/12715] Cleanup comments in \phpbb\lock\*
[ticket/12715] Cleanup comments in \phpbb\groupposition\*
[ticket/12715] Cleanup comments in \phpbb\feed\*
[ticket/12715] Cleanup comments in \phpbb\extension\*
...
[ticket/12712] Add user_password to GROUP BY clause to fix query for mssql
* marc1706/ticket/12712:
[ticket/12712] Remove unneeded GROUP BY clause to fix query for mssql
* PayBas/ticket/12613: (25 commits)
[ticket/12613] Add distinction between top/bottom action-bar
[ticket/12613] Replaced topic-actions with action-bar
[ticket/12613] Remove responsive linklist from memberlist
[ticket/12613] Remove unnecessary checks and clean up CSS
[ticket/12613] role="navigation" not allowed on <ul>
[ticket/12613] Improved screen reader functionality
[ticket/12613] Removed unnecessary checks
[ticket/12613] Set fixed font-size
[ticket/12613] Slightly better icons
[ticket/12613] Typo and L_COLON
[ticket/12613] Small inconsistency fixes
[ticket/12613] Don't display page-jump if all pages are visible (6)
[ticket/12613] Fixes from comments (single quotes and typos)
[ticket/12613] Minor $bull; and <hr> fix
[ticket/12613] Pagination should never be in responsive linklist
[ticket/12613] Minor CSS fixes
[ticket/12613] Dropdown-visible page-jump icon, fix focus() timing
[ticket/12613] Renamed jump-to to page-jump to prevent confusion
[ticket/12613] Removed form in order to prevent nested forms
[ticket/12613] Fix functional test and post sorting bug
...
The value is stored in a text column and the key is stored in a varchar. Some
DBMSes do not like it when we insert integers into text columns. Cast both to
string to be on the safe side.
PHPBB3-12711
The relative position of the <dt> is causing it to sit atop of the <dd> thus
preventing the user from clicking the links. The <dl> has a relative position
in LTR, which takes care of containing the read/unread icon link that has an
absolute position. We no longer support IE6, so removing the tweak that sets
the <dl> position to static will make everything behave the same way in RTL as
in LTR.
PHPBB3-12553
[ticket/12707] Do not try to load 3.1 DBMS driver name as 3.0 driver.
* bantu/ticket/12707:
[ticket/12707] Do not try to load 3.1 DBMS driver name as 3.0 driver.
[ticket/12575] Use a proxy pattern in \phpbb\di\service_collection
* Nicofuma/ticket/12575:
[ticket/12575] Use strict comparison
[ticket/12575] Add missing property
[ticket/12575] Usethe new header
[ticket/12575] Fix 2 typos in comments
[ticket/12575] Fix typos in comments
[ticket/12575] Skip sniffer issue triggered by the solution of a php bug
[ticket/12575] Remove inline assignments
[ticket/12575] Fix the tests
[ticket/12575] Move service_collection_iterator to its own file
[ticket/12575] Speed up load_class()
[ticket/11445] optimize no of queries in get_global_subscriptions( )
* dhruvgoel92/ticket/11445:
[ticket/11445] Move get user's notification code into its own method
[ticket/11445] Remove unused foreach key $group_name
[ticket/11445] Improve unit tests for get_global_subscriptions
[ticket/11445] Optimize no of queries in get_global_subscriptions
[ticket/12682] Make Code Sniffer run properly on Travis CI again.
* bantu/ticket/12682:
[ticket/12682] Make Code Sniffer run properly on Travis CI again.
[ticket/12687] Add a constant to display the load time without DEBUG
* Nicofuma/ticket/12687:
[ticket/12687] Remove french spaces
[ticket/12687] Display the number of cached queries
[ticket/12687] Don't check if memory_get_peak_usage() exists
[ticket/12687] Wrap $GLOBALS['starttime'] in a if
[ticket/12687] Fix the namespace of $request
[ticket/12687] Update doc block
[ticket/12687] Use microtime(true)
[ticket/12687] Remove globals
[ticket/12687] Return a string and move the displaying of the sql report
[ticket/12687] Rename DISPLAY_LOAD_TIME to PHPBB_DISPLAY_LOAD_TIME
[ticket/12687] Display the explain link only when DEBUG is set
[ticket/12687] Add a constant to display the load time without DEBUG
The --ignore parameter takes a case-insensitive pattern and as such
'phpBB/phpbb/*' matches any '/home/travis/build/phpbb/phpbb/...' file name.
This results in nothing being checked against ruleset-php-legacy.xml.
Using absolute paths in the --ignore pattern fixes this issues.
PHPBB3-12682
* github-marc1706/ticket/12352: (33 commits)
[ticket/12352] Do not check hashes that don't have the necessary length
[ticket/12352] Update file headers to fit new format
[ticket/12352] Use custom provider collection for auth providers
[ticket/12352] Add checks for existing user_pass_convert to migrations
[ticket/12352] Remove usages of user_pass_convert column
[ticket/12352] Update schema json file
[ticket/12352] Remove user_pass_convert column from database
[ticket/12352] Check each newly added passwords driver in manager_test
[ticket/12352] Add get_settings_only method to passwords driver base
[ticket/12352] Add passwords driver for xenforo 1.0, 1.1 passwords
[ticket/12352] Add tests for wcf1 and wcf2 drivers
[ticket/12352] Add driver for woltlab community framework 1 passwords
[ticket/12352] Add driver for woltlab community framework 2 passwords
[ticket/12352] Add missing $ to md5_mybb and md5_vb driver
[ticket/12352] Fix spacing in passwords tests
[ticket/12352] Add passwords driver for vB passwords
[ticket/12352] Use correct hashing method in md5_mybb driver
[ticket/12352] Add driver for myBB md5 passwords
[ticket/12352] Rename phpbb2_md5 driver to fit filenames of other drivers
[ticket/12352] Add passwords driver for sha1 password hashes
...
* nickvergessen/ticket/12483:
[ticket/12483] Fix selectors for installing extensions in functional tests
[ticket/12483] Remove unused globals
[ticket/12483] Fix finder usage when generating the schema.json file
[ticket/12483] Fix copyright in prepare_extension.sh
[ticket/12483] Use file_put_contents()
[ticket/12483] Close database connection when tearDown() is called
[ticket/12483] Require the extension manager class
[ticket/12483] Move schema files into tmp/ and only copy them when needed
[ticket/12483] Add a .sh that moves an extension in place
[ticket/12483] Allow to setup extensions before database and functional tests
* github-nickvergessen/ticket/12508:
[ticket/12508] Ignore extensions in migration_tips dev tool
[ticket/12508] Fix doc block
[ticket/12508] Add new line to separate the if and foreach better
[ticket/12508] Add a unit test for set_extensions()
[ticket/12508] Only take a list of names for set_extensions()
[ticket/12508] Fix class doc block
[ticket/12508] Move \phpbb\extension\finder to \phpbb\finder
[ticket/12508] Fix usages of the finder
[ticket/12508] Remove extension manager from finder
[ticket/12664] Refactor develop/migration_tips.php into a console command.
* bantu/ticket/12664:
[ticket/12664] Refactor develop/migration_tips.php into a console command.
[ticket/12667] Do not point viewtopic URL to unread post outside of view=unread.
* prototech/ticket/12667:
[ticket/12667] Do not point viewtopic URL to unread post outside of view=unread
[ticket/8610] Merging topics does not handle bookmarks correctly
* Nicofuma/ticket/8610:
[ticket/8610] Use css selector instead of xPath
[ticket/8610] Add functional test when two topics are merged
[ticket/8610] Throw an error when the dest topic isn't set
[ticket/8610] Fix bookmarks when merging all the posts of a topic
[ticket/8610] Merging topics does not handle bookmarks correctly
* github-nickvergessen/ticket/10073: (36 commits)
[ticket/10073] Fix button descriptions
[ticket/10073] Do not check disable boxes by default
[ticket/10073] Store values with config_text in the ACP
[ticket/10073] Move config values to config_text
[ticket/10073] Fix request usage
[ticket/10073] Deduplicate template variable names
[ticket/10073] Get service from container
[ticket/10073] Fix more "Contact Us" strings
[ticket/10073] Move template code into the template
[ticket/10073] Make contact page available when board is disabled
[ticket/10073] Change name of the ACP module
[ticket/10073] Deduplicate posting buttons code in ACP
[ticket/10073] Use phpbb_validate_email to verify email address
[ticket/10073] Add tests for new validate_email()
[ticket/10073] Split email validation from email ban and taken checks
[ticket/10073] Deduplicate the if statement
[ticket/10073] Fallback to board_contact when contact page is disabled
[ticket/10073] Remove language string from rebase conflict
[ticket/10073] Add ACP module to add bbcode text for contact admin info
[ticket/10073] Add new configs to the schema
...
[ticket/12672] Make tab intercept; CB for keypress only react without key mods
* brunoais/ticket/12672:
[ticket/12672] Make tab intercept; CB for keypress only react without key mods
Add core event to the function display_forums()
in includes/functions_display.php to allow assigning additional template data
for every forum, f.e. additional forumrow subloops.
PHPBB3-12669
Changed the callback of keypress inside the <textarea> for the posting
such that, if key 9 is pressed (tab character) and ctrl, shift, alt and meta
are not pressed the tab is placed. Otherwise, nothing is made and default is
not prevented.
PHPBB3-12672
[ticket/12655] Run phpbbcli as a shell when --shell or -s is used
* Nicofuma/ticket/12655:
[ticket/12655] Set register_container_commands as public
[ticket/12655] Don't try to restore the definition in the help
[ticket/12655] Fix coding style
[ticket/12655] Make the --shell option available only for phpbbcli.php
[ticket/12655] Fix coding style in \phpbb\console\application
[ticket/12655] Set the arguments of \phpbb\console\application as required
[ticket/12655] Don't require acp/common again in the commands
[ticket/12655] Run the shell when --shell is used
[ticket/12602] Add command to print the cron list
* Stephannos/ticket/12602:
[ticket/12602] Fix language key removal.
[ticket/12602] Rectify language keys.
[ticket/12602] Fix test mistake.
[ticket/12602] Fix language var mistakes.
[ticket/12602] Add types, change description of cron:list.
[ticket/12602] Fix internationalisation of cron_list.php
[ticket/12602] Fix spaces issues.
[ticket/12602] Coding style correction.
[ticket/12602] Fix coding style mistakes.
[ticket/12602] Headers updated.
[ticket/12602] Changes to respect coding style and to factorize code.
[ticket/12602] Cleanup tests
[ticket/12602] Add function get_tasks.
[ticket/12602] Correction of the output message for the cron list
[ticket/12602] Add files to print the cron list and test files.
[ticket/12666] Use "None" for images in root of gallery avatar path
* marc1706/ticket/12666:
[ticket/12666] Use "None" for images in root of gallery avatar path
* PayBas/ticket/12541:
[ticket/12541] Activate attachments tab when files are dropped into textarea
Conflicts:
phpBB/styles/prosilver/template/forum_fn.js
[ticket/12457] Default to first category if none is selected in gallery avatar
* marc1706/ticket/12457:
[ticket/12457] Default to first category if none is selected in gallery avatar
[ticket/12639] Delete entry in admin-log leads to mysql-error
* Nicofuma/ticket/12639:
[ticket/12639] Add a space in the code generated by generate_sql_keyword()
[ticket/12639] Handle $conditions['keywords'] outside of the loop
[ticket/12639] Don't make a copy of $marked when deleting logs in acp_logs
[ticket/12639] Send a correct IN entry when deleting marked logs
[ticket/12639] Use assertSame
[ticket/12639] Remove old commented tests
[ticket/12639] Order the results correctly in the test
[ticket/12639] Fix tests on postgres
[ticket/12639] Update tests to use a dataProvider
[ticket/12639] Add a test case with an empty keywords list
[ticket/12639] Delete entry in admin-log leads to mysql-error
Using this custom provider collection, we can properly check whether the
configured auth provider does exist. The method get_provider() has been added
for returning the default auth provider or the standard db auth provider if
the specified one does not exist.
Additionally, the method get_provider() will throw an RuntimeException if
none of the above exist.
PHPBB3-12352
This will make sure that we will not encounter a non-existing auth provider.
We will revert to the default db auth provider if the one set in the config
does not exist in our auth provider collection.
PHPBB3-12352
[ticket/12641] Use jQuery's trim() method. IE8 does not support the native one.
* prototech/ticket/12641:
[ticket/12641] Use jQuery's trim() method. IE8 does not support the native one
[ticket/12589] Search directly in $directory if it's an absolute sub-path
* Nicofuma/ticket/12589:
[ticket/12589] Add test searching in a non absolute directory
[ticket/12589] Fix tests
[ticket/12589] Search directly in $directory if it's an absolute sub-path
[ticket/12637] Correct file header in coding-guidelines
* bantu/ticket/12637:
[ticket/12637] Fixup all incorrect uses of file header.
[ticket/12637] Correctly escape the file header in coding-guidelines.html.
[ticket/10899] Using Delete All in log viewer with keyword search
* Nicofuma/ticket/10899:
[ticket/10899] Update doc block
[ticket/10899] Use isset($field_value['IN'])
[ticket/10899] Add event core.delete_log
[ticket/10899] Remove trailing ;
[ticket/10899] Fix typo in the class name
[ticket/10899] Add unit tests
[ticket/10899] Get $phpbb_log from the container
[ticket/10899] Remove extra ';'
[ticket/10899] Typo
[ticket/10899] Refactoring in \phpbb\log\log_interface
[ticket/10899] Using Delete All in log viewer with keyword search
[ticket/11942] Delete post/topic reason should be added to logs
* Nicofuma/ticket/11942:
[ticket/11942] Don't change the reason to '' when hard deleting
[ticket/11942] Don't show the checkbox if the post is already soft-deleted
[ticket/11942] Remove useless IF in templates
[ticket/11942] Apply the modifications to subsilver
[ticket/11942] Always display delete reason
[ticket/11942] Edits messages
[ticket/11942] Change the formulation
[ticket/11942] Adding the reason to hard deleted topic/post
[ticket/11942] Delete post/topic reason should be added to logs
[ticket/11467] Add language variables for extension exception messages
* n-aleha/ticket/11467:
[ticket/11467] Add user object to extension manager for tests
[ticket/11467] Add language variables to tests
[ticket/11467] Add language variables for extension exception messages
[ticket/11266] Better message for when composer dependencies are missing...
* bantu/ticket/11266:
[ticket/11266] Better message for when composer dependencies are missing.
[ticket/12597] Command for executing all available cron tasks
* bantu/ticket/12597:
[ticket/12597] Update USE_SYSTEM_CRON_EXPLAIN to be a bit more verbose.
[ticket/12597] Improve language for cron:run command.
[ticket/12597] Do not output anything besides the gif image.
[ticket/12597] Command for executing all available cron tasks
* ptitlazy/ticket/12597: (27 commits)
[ticket/12597] Reformating an acp message
[ticket/12597] Modifiying acp message
[ticket/12597] Fix wrong global variable name
[ticket/12597] Typo correction
[ticket/12597] Typo corrections
[ticket/12597] Changing place of lock release in execute() method
[ticket/12597] Fix test file
[ticket/12597] Typing corrections and improvement of code consistency
[ticket/12597] Fix various mistakes
[ticket/12597] Fix various mistakes
[ticket/12597] Fix visibilty of two functions in run.php
[ticket/12597] Refactoring and test improving
[ticket/12597] Fix language key name
[ticket/12597] Fix coding style and typing mistakes
[ticket/12597] Changes name of command cron:run-all to cron:run.
[ticket/12597] Fix various problems
[ticket/12597] Fix constructor bug and servral doc blocs
[ticket/12597] Modification of return statuses and of test files
[ticket/12597] Fix misplaced release of db lock
[ticket/12597] Change EXECUTE to RUN in language
...
* prep-release-3.1.0-b4:
[prep-release-3.1.0-b4] Update phpBB Version for b5 development
[prep-release-3.1.0-b4] Add changelog for 3.1.0-b4
[prep-release-3.1.0-b4] Prepare Changelog
[prep-release-3.1.0-b4] Add migration for 3.1.0-b4
[prep-release-3.1.0-b4] Update version to 3.1.0-b4
[ticket/12621] schema.json is not up to date with migration files
* PayBas/ticket/12621:
[ticket/12621] schema.json is not up to date with migration files
[ticket/12594] Fix file headers of new files
* nickvergessen/ticket/12594:
[ticket/12594] Update file header in non-php files
[ticket/12594] Fix file headers of new files
[ticket/12611] Remove phpBB Group copyright notice from .gifs
* Marshalrusty/ticket/12611:
[ticket/12611] Remove phpBB Group copyright notice from .gifs
[ticket/11226] filespec::move_file() should error correctly
* Nicofuma/ticket/11226:
[ticket/11226] Explicity set file_moved to false
[ticket/11226] Add tests
[ticket/11226] Use $user->lang()
[ticket/11226] filespec::move_file() should error correctly
[ticket/11366] Extension's version's check
* Nicofuma/ticket/11366: (29 commits)
[ticket/11366] Fix headings css in list page
[ticket/11366] Add config value in schema_data.sql
[ticket/11366] Fix HTML
[ticket/11366] Exchange links and settings' form
[ticket/11366] Remove the extra {S_FORM_TOKEN}
[ticket/11366] Move the links to the top of the page
[ticket/11366] Hide the version check settings by default
[ticket/11366] Versions, options and actions heading should be centered
[ticket/11366] Better language string for "recheck all"
[ticket/11366] Move "recheck all" link
[ticket/11366] Add $config['extension_force_unstable']
[ticket/11366] Use force_cache on the list page
[ticket/11366] Add recheck-all link
[ticket/11366] Force the use of the cache on the list page
[ticket/11366] Update FILE_NOT_FOUND language string
[ticket/11366] Fix whitespaces
[ticket/11366] Update FILE_NOT_FOUND language string
[ticket/11366] Update var names
[ticket/11366] Align language strings
[ticket/11366] Fix detailed view
...
[ticket/12561] Add "after" check to schema_generator for columns_add
* PayBas/ticket/12561:
[ticket/12561] Reworked tests by nickvergessen
[ticket/12561] Added tests for "after last", "after missing" and "empty"
[ticket/12561] Add check to see if "after" column actually exists
[ticket/12561] Added test for "after"
[ticket/12561] Add "after" check to schema_generator for columns_add
[ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.
* bantu/ticket/12384-ascraeus:
[ticket/12384] Use mysqli on hhvm in ascraeus. Keep explicit matrix though.
[ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.
[ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.
* bantu/ticket/12384:
[ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.
Add a feature to check automatically the version of the installed
extensions. The informations are cached for 24 hours (like for the
global update check on the main page of the acp).
The informations about the versions are display both on the global list
and on the detailled page.
To do this the developper has to to let the composer.json of the latest
version available and add some informations into it :
"extra": {
"version-check": {
"host": "<the host>",
"directory": "<the directory containing the file>",
"filename": "<the composer.json of the latest version>"
}
}
He can also add two extra informations which will be displayed if a new
version is available :
"extra": {
"download": "<download link>",
"annoucement": "<announcement link>",
}
Currently a notice is displayed when the "extra.version-check"
informations are
missing.
Ticket: https://tracker.phpbb.com/browse/PHPBB3-11366
Signed-off-by: Nicofuma <github@nicofuma.fr>
PHPBB3-11366
[ticket/12582] Strip away copyrighted ICC profile from images
* bantu/ticket/12582-ascraeus:
[ticket/12582] Use the correct script name.
[ticket/12582] Fix coding style.
[ticket/12582] Remove set -e due to exiftool not liking 0 byte files.
[ticket/12582] Strip away copyrighted ICC profile
[ticket/12582] Change strip_icc_profiles.sh to only take a single file.
[ticket/12582] Run strip_icc_profiles.sh on Travis CI.
[ticket/12582] Overwrite inplace instead of creating _original files.
[ticket/12582] Add script for strippping ICC profiles from images.
[ticket/12582] Strip away copyrighted ICC profile from images
* bantu/ticket/12582:
[ticket/12582] Fix coding style.
[ticket/12582] Remove set -e due to exiftool not liking 0 byte files.
[ticket/12582] Strip away copyrighted ICC profile
[ticket/12582] Change strip_icc_profiles.sh to only take a single file.
[ticket/12582] Run strip_icc_profiles.sh on Travis CI.
[ticket/12582] Overwrite inplace instead of creating _original files.
[ticket/12582] Add script for strippping ICC profiles from images.
[ticket/12174] Update topic_attachment flag when a post is soft-deleted
* Nicofuma/ticket/12174:
[ticket/12174] Add tests
[ticket/12174] Coding style
[ticket/12174] Remove $update_topic_attachments_flag
[ticket/12174] Don't update the flag for a post without attachment
[ticket/12174] Update the conditions
[ticket/12174] Remove inline assignment
[ticket/12174] Update sql query
[ticket/12174] Revert the changes on $topic_update_array
[ticket/12174] Corrections
[ticket/12174] Update topic_attachment flag when a post is soft-deleted
Actually fix the return status of command cron:run-all
Fix some doc block coding style issue
Fix missing and obsolete file headers
Delete a useless constructor method
PHPBB3-12597
Added a class to the <li> when the <li> represents that there's no
notifications (no_notifications) and
Added a CSS rule that matches the change to the HTML source for when
there's no notifications.
PHPBB3-12604
[ticket/12509] Add an option to set the path of custom style directory (ie: email templates) for extensions
* Nicofuma/ticket/12509:
[ticket/12509] Add example in doc block
[ticket/12509] Add missing ',' in arrays
[ticket/12509] Update calls to set_custom_style in forgotten places
[ticket/12509] Fix path in adm/index.php
[ticket/12509] Fix typo in adm/index.php
[ticket/12509] Fix doc block
[ticket/12509] Fix the call to set_custom_file in adm/index and messenger
[ticket/12509] Update acp custom_style setter
[ticket/12509] Add an option to set the path of custom file for extensions
[ticket/12536] Get Versions Should Not Require Both Stable and Unstable
* Nicofuma/ticket/12536:
[ticket/12536] Restore missing @throws
[ticket/12536] Add test cases with empty versions list
[ticket/12536] Use stable values when unstable are unavailable
[ticket/12536] Update doc block
[ticket/12536] Return empty array if stability unavailable
[ticket/12536] Get Versions Should Not Require Both Stable and Unstable
* ticket/12582:
[ticket/12582] Strip away copyrighted ICC profile
[ticket/12582] Change strip_icc_profiles.sh to only take a single file.
[ticket/12582] Run strip_icc_profiles.sh on Travis CI.
[ticket/12582] Overwrite inplace instead of creating _original files.
[ticket/12582] Add script for strippping ICC profiles from images.
Conflicts:
.travis.yml
[ticket/12155] Construct post buttons using CSS.
* prototech/ticket/12155: (21 commits)
[ticket/12155] Remove use of !important and move reddish color back to .button
[ticket/12155] Reposition the button icons to the left side while we're at it.
[ticket/12155] Get rid of line-height value causing alignment issues in FF.
[ticket/12155] Get rid of the <span> where possible and fix buttons in Safari.
[ticket/12155] Fix misplaced semicolon and ensure that value comparison works.
[ticket/12155] Combine the post and topic/PM button icons into a single sprite
[ticket/12155] Move icon class directly to <a> and use <span> consistently.
[ticket/12155] Remove star hack from padding-right property of .button.
[ticket/12155] Fix tabbing and put one selector per line if string is too long
[ticket/12155] Make opacity transition faster and fix background image paths.
[ticket/12155] Keep the selection method consistent with the one below it.
[ticket/12155] Fade out the buttons when leaving the post.
[ticket/12155] Display the buttons only when hovering the post.
[ticket/12155] Make the buttons bigger on touch devices.
[ticket/12155] Clean up icons.
[ticket/12155] Remove unused font.
[ticket/12155] Remove obsolete images.
[ticket/12155] Use the new .button class as the basis for the post buttons.
[ticket/12155] Move existing button style to a more generic class.
[ticket/12155] Remove obsolete language images.
...
This images embed a non free ICC profile that doesn’t allow
modification:
http://web.archive.org/web/20020603153925/srgb.com/usingsrgb.html
Please use the proposed version stripping away this copyrighted binary
profile, probably embedded by an image software at one time:
exiftool -icc_profile"-<=" phpBB/adm/images/phpbb_logo.png
I’ve checked the resulting image and trust it is identical to the
original.
Some more background on the issue:
https://lists.debian.org/debian-devel/2014/05/msg00339.html
PHPBB3-12582
The code for hooks still exists in Ascraeus for compatibility reasons, however,
it is no longer recommended that they be used. The events system should be
used instead.
PHPBB3-12603
[ticket/12527] Remove translation editor from ACP
* nickvergessen/ticket/12527:
[ticket/12527] Fix "board’s language" vs "boards language"
[ticket/12527] Use a proper language string on confirm screen
[ticket/12527] Remove unnecessary language strings
[ticket/12527] Check whether the language exists
[ticket/12527] Restore missing files and variables check
[ticket/12527] Remove editor from template
[ticket/12527] Remove language file editor form ACP
This was in place for IE7 due to the use of :after for inserting the button
icon. IE7 does not support :after, so the hack removed the extra padding that
made room for the icon. We no longer use :after for the icon, so this is no
longer an issue... not to mention that IE7 is no longer supported.
PHPBB3-12155
[ticket/12570] Fix updating a config with the same value
* nickvergessen/ticket/12570:
[ticket/12570] Keep MySQLi procedural
[ticket/12570] Remove test for affected rows after SELECT
[ticket/12570] Add a test for set_array() and updating with the same value
[ticket/12570] Fix MySQL affectedrows
[ticket/12570] Fix MySQLi affectedrows by specifying MYSQLI_CLIENT_FOUND_ROWS
[ticket/12570] Add a unit test to show broken sql_affectedrows()
[ticket/12570] Add test for updating a config with the same value
We always want the number of matched rows instead of changed rows,
when running an update. So when mysql_info() returns the number of
matched rows we return that one instead of mysql_affected_rows()
PHPBB3-12570
[ticket/12592] Run mysql driver on Travis CI.
* bantu/ticket/12592:
[ticket/12592] Add PHP 5.4 environment using mysql driver.
[ticket/12592] Rename mysql environment to mysqli.
[ticket/12074] Managing extensions doesn't produce any log entry
* Nicofuma/ticket/12074:
[ticket/12074] Update the visibility of the constructor
[ticket/12074] Don't log errors
[ticket/12074] Managing extensions doesn't produce any log entry
[ticket/12270] Current post and topic approval notification message
* marcosbc/ticket/12270:
[ticket/12270] Fixed topic counting bug and tests
[ticket/12270] Fixed tests not working
[ticket/12270] No quote notif and double poster notification fix
[ticket/12270] Fixed tests
[ticket/12270] Fixed rebase conflicts
[ticket/12270] Correct confirm approval message for topics
[ticket/12270] Correcting to follow phpBB coding standards
[ticket/12270] Better structured code and no debug error message
[ticket/12270] Correct notifications for posts/topics now working
[ticket/12270] Reverted templates
[ticket/12270] Correct post&topic approval msg, no template changes
[ticket/12270] Corrent post and topic approval notification message
[ticket/12543] Only take over ENTER and ESC keys when alert box is active.
* prototech/ticket/12543:
[ticket/12543] Only take over ENTER and ESC keys when alert box is active.
[ticket/12275] Fix a bug on the event "core.modify_username_string"
* Zoddo/ticket/12275:
[ticket/12275] Change if (empty) to if (!isset)
[ticket/12275] Fix a bug on the event "core.modify_username_string"
Topics was not correctly counted (the counter didn't count topics
that were re-approved, for example, but only the ones that were
unapproved.
This should also fix the test that wasn't working correctly.
PHPBB3-12270
[ticket/12531] Restore default topic link behavior to subsilver2
* VSEphpbb/ticket/12531:
[ticket/12531] Add some line breaks to really long lines
[ticket/12531] Restore default topic link functionality in subsilver2
[ticket/12585] Don't check the cron on each page load
* Nicofuma/ticket/12585:
[ticket/12585] Use a 5 minutes interval instead of 10 minutes
[ticket/12585] Don't check the cron on each page load
[Ticket/12555] Make use of canonical urls to avoid duplicate content
* nickvergessen/ticket/12555:
[ticket/12555] Add canonical URL for viewtopic
[ticket/12555] Add canonical URL for viewforum
[ticket/12555] Add canonical URl for memberlist mode=viewprofile
[ticket/12555] Allow to set canonical URLs to avoid duplicate content
[ticket/12572] Fix JS error when alert message title is undefined
* rxu/ticket/12572:
[ticket/12572] Fix JS error when alert message title is undefined
[ticket/12551] Float breadcrumbs to the right in RTL languages.
* prototech/ticket/12551:
[ticket/12551] Float breadcrumbs to the right in RTL languages.
[ticket/12550] Prevent last post column from jumping to second line in RTL.
* prototech/ticket/12550:
[ticket/12550] Prevent last post column from jumping to second line in RTL.
[ticket/12549] Hide topic/forum list <dfn> tags in RTL languages.
* prototech/ticket/12549:
[ticket/12549] Hide topic/forum list <dfn> tags in RTL languages.
[ticket/12576] Remove cron from common.php
* Nicofuma/ticket/12576:
[ticket/12576] Retrieve the cron_manager in cron.php if needed
[ticket/12576] Remove cron from common.php
Ticket/12586 Filter files and depth when looking for extensions
* nickvergessen/ticket/12586:
[ticket/12586] Limit depth to 2, we require vendor/extension/ext.php
[ticket/12586] Use dot filter when trying to find available extensions
[task/sami-ascraeus] Add Sami to composer dependencies and build script
* bantu/task/sami-ascraeus:
[task/sami] Establish alphabetical order.
[task/sami] Also ignore ext/ directory.
[task/sami] Replace phpdoctor with sami.
[task/sami] Add sami/sami as a composer development dependency.
[task/sami] Add Sami to composer dependencies and build script
* bantu/task/sami:
[task/sami] Establish alphabetical order.
[task/sami] Also ignore ext/ directory.
[task/sami] Replace phpdoctor with sami.
[task/sami] Add sami/sami as a composer development dependency.
In language/en/common.php:
* Introduce a new language variable 'CONTACT' => 'Contact'
* Add a string argument to lang var 'CONTACT_USER' to avoid an appended
'{USERNAME}' in template.
* Add a string argument to lang var 'SEND_EMAIL_USER' to avoid an appended
'{USERNAME}' in template.
Also fix typos.
PHPBB3-12525
* task/sami:
[task/sami] Replace phpdoctor with sami.
[task/sami] Add sami/sami as a composer development dependency.
Conflicts:
phpBB/composer.json
phpBB/composer.lock
[ticket/12433] Use a different message when nesting of quotes is not allowed
* nickvergessen/ticket/12433:
[ticket/12433] Use a different message when nesting of quotes is not allowed
Changed padding CSS to the notifications' `<li>` and it's
`<a>` (immediate child) so that the `<a>` block uses all
it's container width and height.
To compensate that, I added the padding that was in the
`<li>` to the `<a>`
PHPBB3-12533
* nickvergessen/ticket/12534:
[ticket/12534] Fix filter for functional tests
[ticket/12534] Do not use errorbox for multi steps
[ticket/12534] Do not abuse errorbox for en/disable confirmation of extensions
[ticket/12518] Apply De Morgan to make the conditions easier reasable
* nickvergessen/ticket/12518:
[ticket/12518] Apply De Morgan to make the conditions easier to read
* nickvergessen/ticket/12518:
[ticket/12518] Add event to overwrite the cannot edit condition in posting.php
[ticket/12518] Add event to overwrite the allow edit and delete conditions
[ticket/12529] Use root_path in controller\resolver to check the template dir
* Nicofuma/ticket/12529:
[ticket/12529] Move $phpbb_root_path to the end of the constructor
[ticket/12529] Use root_path in controller\resolver to check the template dir
[ticket/12501] Fix improper display of inline attachments in post report page
* prototech/ticket/12501:
[ticket/12501] Only select attachments uploaded before the post was reported.
[ticket/12501] Parse the reported post message before its attachments.
[ticket/9388] Only display the settings for the selected method in the auth and search ACP pages.
* prototech/ticket/9388:
[ticket/9388] Use "togglable" instead of "toggable"
[ticket/9388] Do not nest the <fieldset> tags in the OAuth settings.
[ticket/9388] Reopen <fieldset> after auth templates.
[ticket/9388] Fix unit tests.
[ticket/9388] Use the new toggle function for the avatar type <select>.
[ticket/9388] Display only the settings for the selected search backend.
[ticket/9388] Display only the settings for the auth method that's selected.
[ticket/9388] Add support for making <select> options able to toggle settings.
[ticket/12407] Allow changing of post_data, etc. at end of posting.php
* marc1706/ticket/12407:
[ticket/12407] Remove merge marker from posting.php
[ticket/12407] Fix incorrect @since line in event
[ticket/12407] Merge @change in doc block of event
[ticket/12407] Assign template variables again after merging develop-ascraeus
[ticket/12407] Add message_parser as passed variable to event
[ticket/12407] Allow changing of post_data, etc. at end of posting.php
Currently it is possible to change search results within the search row scope,
but it should be possible to modify/unset every individual row
within the rowset.
PHPBB3-12524
[ticket/12522] Add function parameter description in guesser interface
* n-aleha/ticket/12522:
[ticket/12522] Add function parameter description in guesser interface
[ticket/12476] Increase assets version on cache purge
* n-aleha/ticket/12476:
[ticket/12476] Label the constructor as public
[ticket/12476] Increase assets also from acp_styles and phpbbcli
[ticket/12476] Increase asset version on cache purge
Ticket/10839 Remove phpunit configuration files
* nickvergessen/ticket/10839:
[ticket/10839] Remove version compare as the php minimum requirement is 5.3.3
[ticket/10839] Fix note about running slow tests and build task
[ticket/10839] Removing phpunit.xml.all
[ticket/10839] Always run functional tests by default
Since a call was added to self::approve_topic(), the poster would
get double-notified about it (even if it was later marked as read).
Also, when creating a new topic with a quote, it would not be
notified, this has also been fixed.
PHPBB3-12270
They are skipped anyway, if $phpbb_functional_url is not configured.
If you want to run tests without functional tests, just append
--exclude-group functional
to your call
PHPBB3-10839
* 'develop-ascraeus' of github.com:phpbb/phpbb: (424 commits)
[ticket/12428] Use the database to store the original version number
[ticket/12493] Add functional test
[ticket/12493] Fix sql query for selection of users that have disabled PM
[ticket/12513] Add asset include support to simple header/footer in ACP
[ticket/12513] Add simple_header head event with support for CSS assets calls
[ticket/12511] Add missing titles for profile fields in members group view
[ticket/12428] Incorrect from version in database update log entry
[ticket/12510] Convert & to & in build_url() when no params are stripped.
[ticket/12402] CAPTCHA plugin migration fails to detect missing plugins
[ticket/12440] Use a more generic approach for replacing the URL.
[ticket/12507] Move the 'require' statement
[ticket/12507] Add console command to purge the cache
[ticket/12421] Rebase and enable tests
[ticket/12421] Don't parse [attachment] tags if user can't view them
[ticket/12325] Use \RecursiveDirectoryIterator
[ticket/12325] Doc blocks
[ticket/12440] Set browser URL to point to specific post when using view=unread
[ticket/12357] Support routes in generate_smilies() function.
[ticket/12459] Change language strings
[ticket/12504] Use local variables where possible
...
Conflicts:
phpBB/posting.php
[ticket/12451] Split lang vars in posting.php for plurals
* Elsensee/ticket/12451:
[ticket/12451] Remove duplicated lang var
[ticket/12451] Use new line to concatenate strings
[ticket/12451] Split TOO_MANY_CHARS vars for plurals
[ticket/12451] Split TOO_FEW_CHARS_LIMIT for plurals
[ticket/12025] Post Preview no longer shows warnings
* Nicofuma/ticket/12025:
[ticket/12025] Apply DeMorgan
[ticket/12025] Fixing the condition....
[ticket/12025] Don't show any error on preview if the message is empty
[ticket/12025] Post Preview no longer shows warnings
[ticket/12325] Generate the list of the deleted files and folders
* Nicofuma/ticket/12325:
[ticket/12325] Use \RecursiveDirectoryIterator
[ticket/12325] Doc blocks
[ticket/12325] Change private function to protected
[ticket/12325] Add visibilities
[ticket/12325] Add files located in deleted dirs
[ticket/12325] Generate the list of the deleted files and folders
[ticket/12440] Set browser URL to point to specific post when using view=unread
* prototech/ticket/12440:
[ticket/12440] Use a more generic approach for replacing the URL.
[ticket/12440] Set browser URL to point to specific post when using view=unread
Conflicts:
phpBB/styles/prosilver/template/viewtopic_body.html
[ticket/12510] Convert & to & in build_url() when no params are stripped.
* prototech/ticket/12510:
[ticket/12510] Convert & to & in build_url() when no params are stripped.
[ticket/12428] Incorrect from version in database update log entry
* Nicofuma/ticket/12428:
[ticket/12428] Use the database to store the original version number
[ticket/12428] Incorrect from version in database update log entry
[ticket/12511] Add missing titles for profile fields in members group view
* rxu/ticket/12511:
[ticket/12511] Add missing titles for profile fields in members group view
[ticket/12513] Add simple_header head event with support for asset calls
* VSEphpbb/ticket/12513:
[ticket/12513] Add asset include support to simple header/footer in ACP
[ticket/12513] Add simple_header head event with support for CSS assets calls
[ticket/12493] Fix sql query for selection of users that have disabled PM
* n-aleha/ticket/12493:
[ticket/12493] Add functional test
[ticket/12493] Fix sql query for selection of users that have disabled PM
This fixes a bug where a user A could not send a PM to user B when both users
allowed other users to send them a PM. More precisely, it fixes the selection
of users that either are inactive or have disabled private messages.
PHPBB3-12493
For memberlist group view in cases the group is presented with the group leader
and group members, for members profile fields titles are missing: Posts,
Joined, Last active and custom profile fields titles.
PHPBB3-12511
[ticket/12421] Don't parse [attachment] tags if user can't view them
* Nicofuma/ticket/12421:
[ticket/12421] Rebase and enable tests
[ticket/12421] Don't parse [attachment] tags if user can't view them
[ticket/12507] Add console command to purge the cache
* Nicofuma/ticket/12507:
[ticket/12507] Move the 'require' statement
[ticket/12507] Add console command to purge the cache
[ticket/12459] Unapproved posts/topics are not correctly handled in feeds
* Nicofuma/ticket/12459:
[ticket/12459] Change language strings
[ticket/12459] Enable related tests
[ticket/12459] Fix: Differentiating unapproved and deleted posts
[ticket/12459] Fix: Soft deleted topics should appear in feeds
[ticket/12459] Fix: the posts were always marked as unapproved
[ticket/11497] Remove 'ext.finder' from services' list
* Nicofuma/ticket/11497:
[ticket/11497] Rename set_ext_finder in find_routing_files
[ticket/11497] Change the date in the package declaration
[ticket/11497] Fix pagination tests
[ticket/11497] Use a mock object to define the root folder for the finder
[ticket/11497] Generate the list of the routes in controller_helper
[ticket/11497] Fix the path for the finder in controller_provider
[ticket/11497] Fix tests
[ticket/11497] Update pagination test
[ticket/11497] Remove 'ext.finder' from services' list
* VSEphpbb/ticket/12332:
[ticket/12332] Add missing semicolon to inline styling
[ticket/12332] Adjust size of mark column where too wide
[ticket/12332] Adjust column widths for responsive changes
[ticket/12332] Restore some changes back to original state
[ticket/12332] Add break-word to fixed width table CSS
[ticket/12332] Accomplish all word creaking in template and CSS
[ticket/12332] Remove width sizing, as it is already set
[ticket/12332] Fix displaying attachments with long file names
The post text displayed to the user is the same as when it was reported, even if
the post was edited afterwards, thus it follows that the attachments would be
the same. This also addresses an issue where the index in the attachment bbcode
no longer matches that of its corresponding attachment when new attachments
are uploaded after the post is reported.
PHPBB3-12501
[ticket/12499] Incorrect call to phpbb\log\log::add() in db:migrate
* Nicofuma/ticket/12499:
[ticket/12499] Incorrect call to phpbb\log\log::add() in db:migrate
* prep-release-3.1.0-b3:
[prep-release-3.1.0-b3] Update phpBB Version for b4 development
[prep-release-3.1.0-b3] Add changelog for 3.1.0-b3
[prep-release-3.1.0-b3] Prepare Changelog
[prep-release-3.1.0-b3] Add migration for 3.1.0-b3
[prep-release-3.1.0-b3] Update version to 3.1.0-b3
When clicking on approving a topic's first post in the MCP to
approve the topic itself, the confirm box dialog asks whether
to approve the post or not, instead of asking to approve the
topic.
To achieve this fix, we just need to count the topics to be
approved and check if it's greater than zero.
PHPBB3-12270
I forgot to put the brackets (so it follows the phpBB coding
standards) and changed "count($topic_id_list) > 0"
to "!empty($topic_id_list)", making the syntax more
comprehensible.
PHPBB3-12270
A variable (that's not essential) has been removed, two if's
has been merged to an if-else control structure. A variable
named topic_ids_list has been renamed to topic_id_list to follow
the naming standard in that file's code.
Also, the debug error has been fixed by changing the topic data
key 'username' to 'post_username' in the array_merge function
in approve_topics().
PHPBB3-12270
This patch should finally work correctly: Add the correct
notification for post/topic approval without touching templates.
This has been done by calling the function approve_topics()
inside the approve_posts() function. It's the simplest way for
this to work correctly. There may be a call to the DB but other
ways (if any), without touching templates, would have been too
messy for a function like this.
PHPBB3-12270
Following the previous commits, this patch removes the changes
done to templates to depend only on code, as suggested by
@nickvergessen.
All previous modifications have been removed, with another one
which checks, in the approve_posts() function, if it is sending a
notification for post approval and it is the first one in the
topic, send notification indicating that the topic has been
approved (and not the post). If not the first post in the topic,
do just as before (send a notification about a newly approved
post).
PHPBB3-12270
When you submit a post with needed approval (say user A), and then
it gets approved by another user (user B), a subscribed user (user C)
to that forum would receive a notification indicating:
-A has replied to topic 'New Topic' in the forum 'xyz'.
The expected result would be:
-A has posted a new topic 'New topic' in the forum 'xyz'.
This has fixed by adding a TOPIC_ID template variable to
mcp_post.html and, in there, depending if the first post is the topic's
first post or not, add a input's with name topic_id_list[] or
post_id_list[] and then the respective value (TOPIC_ID or POST_ID).
PHPBB3-12270
The current event core.posting_modify_template_vars is just ran using dispatch
but it doesn't pass any data from posting.php to the listener. Because of that,
it's not possible to know anything from posting.php and therefore limits the
use cases of this event. This will change it to allow similar actions as with
the event core.modify_posting_parameters.
PHPBB3-12407
; The directory to place generated documentation in. If the given path is
; relative to it will be relative to "source_path".
d="../build/api/"
; Specifies the title to be placed in the HTML <title> tag.
windowtitle="phpBB3"
; Specifies the title to be placed near the top of the overview summary file.
doctitle="phpBB3 Sourcecode Documentation"
; Specifies the header text to be placed at the top of each output file. The
; header will be placed to the right of the upper navigation bar.
header="phpBB3"
; Specifies the footer text to be placed at the bottom of each output file. The
; footer will be placed to the right of the lower navigation bar.
footer="phpBB3"
; Specifies the text to be placed at the bottom of each output file. The text
; will be placed at the bottom of the page, below the lower navigation bar.
;bottom = "This document was generated by <a href="http://peej.github.com/phpdoctor/">PHPDoctor: The PHP Documentation Creator</a>"
; Create a class tree?
;tree = off
; Use GeSHi to include formatted source files in the documentation. PHPDoctor will look in the current doclet directory for a /geshi subdirectory. Unpack the GeSHi archive from http://qbnz.com/highlighter to get this directory - it will contain a php script and a subdirectory with formatting files.
<inputtype="button"class="button2"accesskey="b"name="addbbcode0"value=" B "style="font-weight:bold; width: 30px"onclick="bbstyle(0)"title="{L_BBCODE_B_HELP}"/>
<inputtype="button"class="button2"accesskey="i"name="addbbcode2"value=" i "style="font-style:italic; width: 30px"onclick="bbstyle(2)"title="{L_BBCODE_I_HELP}"/>
<inputtype="button"class="button2"accesskey="u"name="addbbcode4"value=" u "style="text-decoration: underline; width: 30px"onclick="bbstyle(4)"title="{L_BBCODE_U_HELP}"/>
<inputtype="button"class="button2"accesskey="b"name="addbbcode0"value=" B "style="font-weight:bold; width: 30px"onclick="bbstyle(0)"title="{L_BBCODE_B_HELP}"/>
<inputtype="button"class="button2"accesskey="i"name="addbbcode2"value=" i "style="font-style:italic; width: 30px"onclick="bbstyle(2)"title="{L_BBCODE_I_HELP}"/>
<inputtype="button"class="button2"accesskey="u"name="addbbcode4"value=" u "style="text-decoration: underline; width: 30px"onclick="bbstyle(4)"title="{L_BBCODE_U_HELP}"/>
Some files were not shown because too many files have changed in this diff
Show More
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.