[ticket/13137] Remove schema.json from repository
* nickvergessen/ticket/13137:
[ticket/13137] Create schema.json in build script
[ticket/13137] Improve output of create_schema_files.php
[ticket/13137] Add schema.json file to .gitignore
[ticket/13137] Generate the schema when the schema.json file is not available
[ticket/13137] Remove schema.json file
[ticket/13077] Move extension module to the top of the Customise tab
* nickvergessen/ticket/13077:
[ticket/13077] Move extension module to the top of the Customise tab
* nickvergessen/ticket/13119:
[ticket/13119] Remove unused globals and use the request class
[ticket/13119] Add events to ACP's ban module
[ticket/13119] Add events to MCP's ban module
[ticket/13122] Make phpbb_wrapper_gmgetdate_test more reliable
* fredemmott/ticket/13122:
[ticket/13122] Make phpbb_wrapper_gmgetdate_test more reliable
If you're unlucky, calling time() or similar twice in a row will
give you different results. Facebook runs these tests thousands of
times a day, so we occasionally get bogus failures.
PHPBB3-13122
[ticket/13120] Follows the symlinks in phpbb_load_extensions_autoloaders
* Nicofuma/ticket/13120:
[ticket/13120] Follows the symlinks in phpbb_load_extensions_autoloaders
[ticket/13105] Fix the code logic as described in the comment
* nickvergessen/ticket/13105:
[ticket/13105] Fix the code logic as described in the comment
[ticket/13111] Dropdown options are already an array in the field data
* nickvergessen/ticket/13111:
[ticket/13111] Dropdown options are already an array in the field data
[ticket/13105] Future relative dates are always displayed as "Tomorrow"
* nickvergessen/ticket/13105:
[ticket/13105] Do not display future dates 2+ days ahead as "tomorrow"
[ticket/13105] Add a test for relative dates
[ticket/13011] Do not apply bbcode to whole text when selecting first 2 chars.
* prototech/ticket/13011:
[ticket/13011] Do not apply bbcode to whole text when selecting first 2 chars.
[ticket/13048] Only do not update the session page for ajax requests
* nickvergessen/ticket/13048:
[ticket/13048] Only do not update the session page for ajax requests
[ticket/13070] Use old 'template' class for template class hook
* marc1706/ticket/13070:
[ticket/13070] Use old 'template' class for template class hook
* prep-release-3.1.0-RC4:
[prep-release-3.1.0-RC4] Update phpBB Version for RC4 development
[prep-release-3.1.0-RC4] Add changelog for 3.1.0-RC4
[prep-release-3.1.0-RC4] Prepare Changelog
[prep-release-3.1.0-RC4] Add migration for 3.1.0-RC4
[prep-release-3.1.0-RC4] Update version to 3.1.0-RC4
[ticket/13073] Correctly generate routes from subfolders like /adm
* marc1706/ticket/13073:
[ticket/13073] Remove _test suffix from common test class
[ticket/13073] Switch $input with $expected and add paths with letters
[ticket/13073] Use abstract class for controller helper route tests
[ticket/13073] Add path regex to get_preg_expression() and add unit tests
[ticket/13073] Use just one regex in helper route()
[ticket/13073] Properly place comments in helper
[ticket/13073] Use correct class names in test files
[ticket/13073] Rework route tests and add tests for more directory types
[ticket/13073] Test that routes from subfolders like /adm work
[ticket/13073] Add tests for routes from adm pages
[ticket/13073] Add phpbb root path with mod rewrite enabled for proper routes
* hanakin/ticket/12598:
[ticket/12598] Fix sir typo
[ticket/12598] Fix rtl positon in header
[ticket/12598] Remove right border
[ticket/12598] Remove border from .search-header
[ticket/12598] Replace #search-box with class
[ticket/12598] Remove hover border-color and use hover icon
[ticket/12598] Add some responsive margin to give breathing room
[ticket/12598] Clean up unused link colors
[ticket/12598] Remove unused link colors
[ticket/12598] Add lt IE9 fixes
[ticket/12598] Improve search box styling
[ticket/12961] Add link in anti-spam ACP page which links directly to captchas in titania
* PayBas/ticket/12961:
[ticket/12961] Shorten ext-db link text
[ticket/12961] Fix missing phpBB.com
[ticket/12961] Remove target="_blank" and switch to <strong>
[ticket/12961] Add additional link to the KB
[ticket/12961] Move link to language file
[ticket/12961] Refactor lang entry
[ticket/12961] Change url to anti-spam-ext
[ticket/12961] Change url to https://www.phpbb.com/go/anti-spam/
[ticket/12961] Add link in anti-spam ACP page to titania
[ticket/12963] Revert back to "migrations" folder name for extensions
* nickvergessen/ticket/12963:
[ticket/12963] Always use core_path and core_directory()
[ticket/12963] Remove old migration/ folder from tests
[ticket/12963] Revert back to "migrations" folder name for extensions
[ticket/12963] Correctly load migration files from migration/ in tests as well
* nickvergessen/ticket/12963:
[ticket/12963] Correctly load migration files from migration/ in tests as well
[ticket/13061] Replace the service event.subscriber_loader by a compiler pass
* Nicofuma/ticket/13061:
[ticket/13061] Replace the service event.subscriber_loader by a compiler pass
[ticket/13064] Validate the migrations provided to migrator::set_migrations()
* Nicofuma/ticket/13064:
[ticket/13064] Validate the migrations provided to migrator::set_migrations()
[ticket/13044] Expires header violates RFC 2616
* Senky/ticket/13044:
[ticket/13044] Move GMT out of gmdate in functions_acp
[ticket/13044] Move GMT out of gmdate()
[ticket/13044] \G\M\T to GMT in whole project
[ticket/13044] move GMT string out of gmdate()
[ticket/13044] Correct Expires headers
$timezone contains the original jQuery object, therefore the subsequent
removal of the optgroup children while filtering has no effect on the
$replacement object - the one that's now visible to the user. We'll simplify
and fix this by injecting the content of the copy instead of going through the
trouble of cloning it.
PHPBB3-13069
[ticket/13018] Remove duplicate logic in confirm box and alert box handling.
* prototech/ticket/13018:
[ticket/13018] Clean up and fix some logic.
[ticket/13018] Do not handle events in close function.
[ticket/13018] Reduce the delta further.
[ticket/13018] Remove duplicate logic in confirm box and alert box handling.
[ticket/13056] Move the arguments of the request class to the DI
* Nicofuma/ticket/13056:
[ticket/13056] Move the arguments of the request class to the DI
* PayBas/ticket/10472:
[ticket/10472] Remove dd selector and use -moz-padding-end
[ticket/10472] Fix weird padding on input type=number
[ticket/10472] More clearing and white-space fixes
[ticket/10472] Fix ACP overflow:hidden problem for medium-sized screens
The callback does not actually do anything when cancelling the confirmation
box so we can avoid calling it altogether when cancel is clicked.
PHPBB3-13018
This ensures a more consistent handling of the various closing/opening actions
and fixes some bugs where certain event handlers are not turned off in certain
instances.
PHPBB3-13018
[ticket/13019] Always accept a reason for deleting a post/topic.
* prototech/ticket/13019:
[ticket/13019] Do not hide reason field when deleting permanently.
[ticket/13019] Rename deletion reason label.
[ticket/13019] Always accept a reason for deleting a post/topic.
Added a non-breaking space to remove the following warning:
**Empty heading.**
```html
<h3 class="alert_title"></h3><p class="alert_text"></p>
```
PHPBB3-13040
[ticket/12734] Custom profile manager should not suppress errors when inserting user rows
* Senky/ticket/12734:
[ticket/12734] Remove unnecessary error supressing
[ticket/13057] Add $phpbb_dispatcher to the global in mcp/mcp_report.php
* Nicofuma/ticket/13057:
[ticket/13057] Add $phpbb_dispatcher to the global in mcp/mcp_report.php
[ticket/13005] Add event to display_forums() to modify category template data
* rxu/ticket/13005:
[ticket/13005] Add event to display_forums() to modify category template data
[ticket/13006] Add variables to the 'core.modify_quickmod_actions' event
* rxu/ticket/13006:
[ticket/13006] Add variables to the 'core.modify_quickmod_actions' event
[ticket/12976] Correctly use plurals for attachment count in UCP navigation
* nickvergessen/ticket/12976:
[ticket/12976] Correctly use plurals for attachment count in UCP navigation
The static var was global to all instance of \phpbb\base and so if two
different instances (for two different extensions) were created by the
same script they shared the same migrations list.
PHPBB3-12963
Without this patch the finder grab all the class available in the ext
folder and not only the migrations. This change is backported for the one
done before to the cli tool db:migrate. (see the commit
3420f8f320)
PHPBB3-12963
Ticket/13052 Remove additional parameter from check_form_key()
* nickvergessen/ticket/13052:
[ticket/13052] Use request class instead of $_POST and request_var()
[ticket/13052] Fix appearances with multiple parameters
[ticket/13052] Remove additional parameter from check_form_key()
[ticket/13050] Allow topic/forum subscription when email/jabber is off
* rxu/ticket/13050:
[ticket/13050] Allow topic/forum subscription when email/jabber is off
Currently, there's impossible to subscribe topic/forum if emails and/or jabber
is disabled. This seems to be a 3.0 leftover since 3.1 introduces new
notification system which handles this case and offers email/jabber-free
board notifications.
PHPBB3-13050
[ticket/12852] Make get_url_parts handle get variable with no value
* Senky/ticket/12852:
[ticket/12852] Add unit tests
[ticket/12852] Add space after if
[ticket/12852] Remove whitespace
[ticket/12852] Make get_url_parts handle get variable with no value
[ticket/13031] Only use mimetype guesser guess if it helps us
* marc1706/ticket/13031:
[ticket/13031] Slightly change behavior of choose_mime_type and add unit tests
[ticket/13031] Guess with all mimetype guessers and pick best guess
[ticket/13031] Only use mimetype guesser guess if it helps us
The mime type 'application/octet-stream' will still always be overwritten by
proper guesses. However, guesses with guessers that have a higher priority
will now overwrite previous guesses even if the mime types of these guesses
had a slash in them.
PHPBB3-13031
If we already have a mimetype and the guesser's guess is the default fallback,
we should keep the already existing mimetype the browser supplied. Otherwise,
platforms that might not support mimetype guessers will cause us to always
have the mimetype set to application/octet-stream on images. This will prevent
users from uploading images.
PHPBB3-13031
* PayBas/ticket/12506:
[ticket/12506] Fix search result h3 margin
[ticket/12506] Fix responsive profile min-height (no avatar)
[ticket/12506] Reposition buttons to make room for "online" banner
[ticket/12506] Reposition post-buttons for compact layout
[ticket/13008] Use an absolute path with the FileLocator for the routing files
* Nicofuma/ticket/13008:
[ticket/13008] Add functionnal test
[ticket/13008] Use an absolute path with the FileLocator for the routing files
[ticket/12658] Add test for base case of commands config:
* ptitlazy/ticket/12658:
[ticket/12658] Rebased and fixed unit tests
[ticket/12658] Fix wrong eol character
[ticket/12658] Refactoring code
[ticket/12658] Fix typo and coding style mistakes
[ticket/12658] Add test for command config:delete
[ticket/12658] Add test for command config:increment
[ticket/12658] Add test for command config:get
[ticket/12658] Add test for command config:set-atomic
[ticket/12658] Add test for base case of command config:set
Add $quickmod and $action variables
for the 'core.modify_quickmod_actions' event trigerring
to avoid of using global operator in corresponding extensions.
PHPBB3-13006
$delta was always an int - so, this test would sometimes fail if you
happened to call time() /very/ close to a 1s boundary.
Found by HHVM's continuous testing.
PHPBB3-12996
[ticket/12984] Remove blank line when no forum description shown
* Oyabun1/ticket/12984:
[ticket/12984] Remove blank line when no forum description shown
Add a conditional for forum description and move the <br /> within it.
Currently if there is no forum description but there is
1. a displayed forum moderator and/or
2. a displayed sub-forum
a blank line is added in place of the description
PHPBB3-12984
$search->get_common_words() call goes before the split_keywords() call,
but $search->common_words array is being generated
within the function $search->split_keywords(). Thus, get_common_words()
returned an empty array instead of common words array.
PHPBB3-12986
[ticket/12975] Fix the construction of phpbb\auth\provider\db for Oauth
* Nicofuma/ticket/12975:
[ticket/12975] Fix the construction of phpbb\auth\provider\db for Oauth
* prep-release-3.1.0-RC3:
[prep-release-3.1.0-RC3] Update phpBB Version for RC4 development
[prep-release-3.1.0-RC3] Add changelog for 3.1.0-RC3
[prep-release-3.1.0-RC3] Prepare Changelog
[prep-release-3.1.0-RC3] Add migration for 3.1.0-RC3
[prep-release-3.1.0-RC3] Update version to 3.1.0-RC3
* github-marc1706/ticket/12822:
[ticket/12822] Fix test runs of avatar manager_test
[ticket/12822] Add method for deleting avatars and use confirm_box
[ticket/12822] Remove "None" option from avatar select boxes
[ticket/12932] Add method for allowing override of \phpbb\datetime class
* marc1706/ticket/12932:
[ticket/12932] Remove set_datetime_class method from user class
[ticket/12932] Fix tests and calls to create_datetime
[ticket/12932] Add method for getting the datetime class and allow overriding
[ticket/12956] Ensure the contact columns have been added before using t...
* nickvergessen/ticket/12956:
[ticket/12956] Ensure the contact columns have been added before using them
[ticket/12794] Properly validate google+ field against valid character set
* marc1706/ticket/12794:
[ticket/12794] Properly validate google+ field against valid character set
Ticket/12671 Possibility to use NOT LIKE expression
* Geolim4/ticket/12671:
[ticket/12671] Possibility to use NOT LIKE expression
[ticket/12671] Possibility to use NOT LIKE expression
[ticket/12671] Possibility to use NOT LIKE expression
[ticket/12671] Possibility to use NOT LIKE expression
[ticket/12671] Possibility to use NOT LIKE expression
[ticket/12953] Page title not updated when notifications are marked as read
* Geolim4/ticket/12953:
[ticket/12953] Page title not updated when notifications are marked as read
[ticket/12938] Remove the 'Download all attachments' feature.
* bantu/ticket/12938:
[ticket/12938] Remove functional tests for 'Download all attachments'.
[ticket/12938] Remove the 'Download all attachments' feature.
[ticket/12941] Check for Sami parse errors on Travis CI.
* bantu/ticket/12941:
[ticket/12941] Fix remaining Sami complaints.
[ticket/12941] Check for Sami parse errors on Travis CI.
[ticket/12941] Add sami.conf.php for Travis CI.
[ticket/12718] Use remove_topic_from_statistic() for delete_topic
* dhruvgoel92/ticket/12718:
[ticket/12718] Use a separate variable for sql query
[ticket/12718] Fix spacing and type casting
[ticket/12718] Fix docblocks
[ticket/12718] Add tests to check user_posts on post deletion
[ticket/12718] Update docblock
[ticket/12718] Use remove_topic_from_statistic() for delete_topic
* github-nickvergessen/ticket/12710:
[ticket/12710] Fix missing closing bracket
[ticket/12710] Prefix column so it does not start with a number
[ticket/12710] Pass the original column data to the create function
[ticket/12710] Fix foreach generation
[ticket/12710] Compare to uppercase version
[ticket/12710] Do not try to match the uniqueness in the query
[ticket/12710] Remove table_name from index_name before deleting and recreating them
[ticket/12710] Can not use upper in oracles where claus
[ticket/12710] Correctly select index name and compare to column name
[ticket/12710] Fix "ORA-00972: identifier is too long [972]" on oracle
[ticket/12710] Fix problems with creating unique indexes on oracle
[ticket/12710] Correctly fetch unique and normal indexes only in MSSQL
[ticket/12710] Fix changing the column type on oracle
[ticket/12710] Prepare get_existing_indexes() for other DBMS
* github-nicofuma/ticket/12693:
[ticket/12693] Fix composer.phar path
[ticket/12693] The files skipped list can not be empty
[ticket/12693] Force the composer.phar to be executable
[ticket/12693] All the files in bin/ must be executable
[ticket/12693] Expand manually the wildcard
[ticket/12693] Fix the query for bin/*
[ticket/12693] Extract exceptions, bin/* must be executable
[ticket/12693] Remove the executable bit on icon_print.gif
[ticket/12693] Check the persmissions of the owner
[ticket/12693] Check if the are executable and not if they are 644
[ticket/12693] Fix the permissions
[ticket/12693] Check if the files have the right 644
[ticket/12693] Fix indentation
[ticket/12693] Add a travis test that checks file permissions
[ticket/12841] Allow extensions to position new config vars
* VSEphpbb/ticket/12841:
[ticket/12841] Make config position default to after
[ticket/12841] Update comments in tests making after default
[ticket/12841] prefix function name with phpbb_
[ticket/12841] Add a tests for the new function
[ticket/12841] Fix white space issues reported by sniffer
[ticket/12841] Allow extensions to position new config vars
The method might now return an empty array in case of an empty users array,
too. The notification types then check if the returned array is empty and
return this if it is empty and if the notification types would otherwise
carry out other operations afterwards.
PHPBB3-12742
[ticket/10404] Use anonymous function instead of create_function in acp/auth
* marc1706/ticket/10404:
[ticket/10404] Fix codesniffer complaint about anonymous function
[ticket/10404] Use anonymous function instead of create_function in acp/auth
[ticket/12778] Automatically delete files on update
* dhruvgoel92/ticket/12778:
[ticket/12778] Rename the file to *.bak instead of deleting
[ticket/12778] Automatically delete files on update
* github-nicofuma/ticket/12789:
[ticket/12789] Move duplicated functions to the base class
[ticket/12789] Remove the directories in \phpbb\cache\driver\memory::purge()
The user shouldn't be able to unlock his own topic if he doesn't have m_lock
permissions. Also, the check for f_user_lock was never going to evaluate to
true due to the topic not being unlocked making it obsolete anyway.
PHPBB3-12886
[ticket/12922] Posts per page in MCP should have a min value of zero
* n-aleha/ticket/12922:
[ticket/12922] Subsilver2 fix
[ticket/12922] Posts per page in MCP should have a min value of zero
The method will take care of the actual deletion process in the avatar manager.
Additionally, we'll be using a confirm box while deleting the avatar to prevent
users from accidentally deleting their avatars.
PHPBB3-12822
[ticket/12873] Test the correct identifier in \phpbb\db\tools
* Nicofuma/ticket/12873:
[ticket/12873] Add migration to rename the index
[ticket/12873] Don not touch the existing migrations
[ticket/12873] Test the good identifier in \phpbb\db\tools
[ticket/12738] Move related code from functions_posting to function
* dhruvgoel92/ticket/12738:
[ticket/12738] Update constructor docblock
[ticket/12738] Add $config to constructor in notification test
[ticket/12738] Fix tests with new config object injection
[ticket/12738] Inject config object into content_visibility class
[ticket/11528] Move related code from functions_posting to function
[ticket/12920] Add composer.json to phpBB/phpbb and fix the one in phpBB/
* naderman/ticket/12920:
[ticket/12920] Add missing comma
[ticket/12920] Update composer.lock file after update nothing
[ticket/12920] Fix sh syntax error in post-update-cmd script
[ticket/12920] Remove incorrect @ from self.version reference in composer.json
[ticket/12920] Output warning message about vendor cleaning target
[ticket/12920] Turn phpBB composer.json into publishable full version
[ticket/12920] Add require for minimum php version
[ticket/12920] Add composer.json for phpbb/phpbb-core library
[ticket/12918] Load class fileupload in fileupload_remote_test.php.
* bantu/ticket/12918:
[ticket/12918] Load class fileupload in fileupload_remote_test.php.
[ticket/12847] Allow the extensions to say if they can be enabled
* Nicofuma/ticket/12847:
[ticket/12847] Allow the extensions to say if they can be enabled
[ticket/12557] Fix doc block errors found by Sami for ascraeus
* n-aleha/ticket/12557ascraeus:
[ticket/12557] Fix load active module description
[ticket/12557] Fix php file description
[ticket/12557] Fix post data description for notifications
[ticket/12557] Fix pass by reference doc blocks
[ticket/12557] Fix doc block in extension base class
[ticket/12557] Fix doc block in mimetype guesser
[ticket/12557] Fix var $preserve_cr description
[ticket/12557] Fix doc block errors found by Sami
[ticket/12557] Fix doc block errors found by Sami
[ticket/12557] Fix doc block errors found by Sami
[ticket/12557] Template fixes
[ticket/12557] Search, cron and profilefields fixes
[ticket/12557] Notification fixes
[ticket/12557] Fix doc block errors found by Sami pt1
[ticket/12557] Fix doc block errors found by Sami
[ticket/12557] Fix doc block errors found by Sami
* github-marc1706/ticket/11148:
[ticket/11148] Remove unneeded variable mimetype and use type octet-stream
[ticket/11148] Change expected output with disallowed content in test
[ticket/11148] Always use the output of the mimetype guesser in get_mimetype
[ticket/11148] Get rid of extra line in mimetype guesser setter doc block
[ticket/11148] Add missing parts to docblock of get_mimetype() method
[ticket/11148] Default to application/octet-stream if no mimetype given
[ticket/11148] Use mimetype guesser for uploaded avatars
[ticket/11148] Pass mimetype guesser to upload_attachment() function
[ticket/11148] Add mimetype guesser to filespec and fileupload class
[ticket/12912] Undefined index when adding logs from extensions
* tmbackoff/ticket/12912:
[ticket/12912] Undefined index when adding logs from extensions
As @event core.modify_submit_post_data can modify any of the
function submit_post parameters, they may be needed to perform
actions directly after a post or topic has been submitted in
@event core.submit_post_end (includes/functions_posting.php).
PHPBB3-12913
[ticket/12895] Rename user style setting to resolve conflict with style param
* marc1706/ticket/12895:
[ticket/12895] Rename user style setting to resolve conflict with style param
[ticket/11480-ascraeus] PM : "Unknown folder" returned when inbox folder is full
* Nicofuma/ticket/11480-ascraeus:
[ticket/11480] Header file
[ticket/11480] Fix unit tests
[ticket/11480] Move the test into get_folder()
[ticket/11480] Fix the double spaces in phpbb_functional_test_case
[ticket/11480] Fix typos
[ticket/11480] Add functionnal test
[ticket/11480] PM : "Unknown folder" returned when inbox folder is full
[ticket/11480] PM : "Unknown folder" returned when inbox folder is full
* Nicofuma/ticket/11480:
[ticket/11480] Move the test into get_folder()
[ticket/11480] Fix the double spaces in phpbb_functional_test_case
[ticket/11480] Fix typos
[ticket/11480] Add functionnal test
[ticket/11480] PM : "Unknown folder" returned when inbox folder is full
[ticket/12882] Update search_type when it's not prefixed by phpbb_search
* Nicofuma/ticket/12882:
[ticket/12882] Use a new migration
[ticket/12882] Update search_type when it's not prefixed by phpbb_search
* ticket/11480:
[ticket/11480] Move the test into get_folder()
[ticket/11480] Fix the double spaces in phpbb_functional_test_case
[ticket/11480] Fix typos
[ticket/11480] Add functionnal test
[ticket/11480] PM : "Unknown folder" returned when inbox folder is full
Conflicts:
tests/test_framework/phpbb_functional_test_case.php
The style URL parameter, i.e. style=1, will conflict with the user's style
setting due to it also being named style. This patch with solve this conflict.
PHPBB3-12895
[ticket/12870] phpbbcli.php db:migrate can not update from 3.0.12 to 3.1
* Nicofuma/ticket/12870:
[ticket/12870] Add doc block
[ticket/12870] Create the migrations table with a method in the migrator
[ticket/12870] Add $config['version'] in phpbb_extension_manager_test
[ticket/12870] Create the migrations table in db:migrate
[ticket/12656] Translate existing CLI commands
* dhruvgoel92/ticket/12656:
[ticket/12656] Fix typo for "purged extension"
[ticket/12656] Fix syntax in language file
[ticket/12656] Fix typo
[ticket/12656] Use utf8 ’ instead of escaping '
[ticket/12656] Use lang keys for all CLI strings
[ticket/12656] Use lang keys for CLI command descriptions
[ticket/12793] String '0' does not display for string profile fields
* lucifer4o/ticket/12793:
[ticket/12793] Tests (added and changed)
[ticket/12793] Changing get_profile_contact_value to get_profile_value_raw
[ticket/12793] String '0' does not display for string profile fields
[ticket/12791] String profile fields do not use links ...
* lucifer4o/ticket/12791:
[ticket/12791] Changed the if check
[ticket/12791] String profile fields do not use links ...
When you click on "Mark forums read" in the browser console error occurs
ReferenceError: assignment to undeclared variable phpbbAlertTimer
ajax.js (line13)
PHPBB3-12843
[ticket/12884] Add core event to the function upload_attachment()
* rxu/ticket/12884:
[ticket/12884] Add core event to the function upload_attachment()
[ticket/12883] Do not use basename() to get the search class in tidy_search
* Nicofuma/ticket/12883:
[ticket/12883] Remove pointless comments
[ticket/12883] Do not use basename() to get the search class in tidy_search
[ticket/12892] Do not set S_NUM_ROWS when adding a row to a template loop
* nickvergessen/ticket/12892:
[ticket/12892] Do not set S_NUM_ROWS when adding a row to a template loop
We do not set S_NUM_ROWS while adding a row, to reduce the complexity
If we would set it on adding, each subsequent adding would cause
n modifications, resulting in a O(n!) complexity, rather then O(n)
PHPBB3-12892
Add core event to the function upload_attachment()
in functions_posting.php to provide ability for extensions
to perform additional actions on uploaded files, like resizing etc.
PHPBB3-12884
[ticket/12871] Add PHPBB_DISPLAY_LOAD_TIME const to config.php on installation
* rxu/ticket/12871:
[ticket/12871] Add PHPBB_DISPLAY_LOAD_TIME const to config.php on installation
[ticket/12861] Add event to modify the post, poster and attachment data
* nickvergessen/ticket/12861:
[ticket/12861] Add event to modify the post, poster and attachment data
We need to rename the index key because with the default prefix (phpbb_)
this key has a length of 31. And because we don't accept the keys longer
than 30 characters we should ensure that by default no key is longer than
30 characters.
PHPBB3-12873
[ticket/12663] Extract CLI language string into their own file
* bantu/ticket/12663:
[ticket/12663] Have cli.php language file at top level; unrelated to ACP.
[ticket/12663] Extract CLI language string into their own file
[ticket/12685] New CLI container for load extensions
* carlo94it/ticket/12685:
[ticket/12685] Setup class loader for extensions only if not in safe mode
[ticket/12685] Replace getParameterOption with hasParameterOption
[ticket/12685] Do not dump container
[ticket/12685] Override getDefaultInputDefinition()
[ticket/12685] Removed unused USE statement
[ticket/12685] Inject console.command_collection instead of the container
[ticket/12685] Add a new line
[ticket/12685] Container is dumped by default
[ticket/12685] Removed spaces
[ticket/12685] Add --safe-mode
[ticket/12685] We need extensions enabled
[ticket/12685] Add space after foreach
[ticket/12685] Add console collection and fixing CLI
[WIP][ticket/12853] Change navbar ACP from skip- to last-responsive
* PayBas/ticket/12853:
[ticket/12853] Change navbar ACP from skip- to last-responsive
[ticket/12837] Detect "viewing contact admin page" on viewonline
* PayBas/ticket/12837:
[ticket/12837] Use else if instead of elseif
[ticket/12837] Detect "viewing contact admin page" on viewonline
[ticket/12854] Don't show contact page link if board emails are disabled
* Elsensee/ticket/12854:
[ticket/12854] Don't show contact page link if board emails are disabled
[ticket/12855] Dump the container based on DEBUG_CONTAINER instead of DEBUG
* Elsensee/ticket/12855:
[ticket/12855] Dump the container based on DEBUG_CONTAINER instead of DEBUG
Add common core event at the bottom of the includes/ucp/ucp_prefs.php
to allow additional actions (like template variable assignments etc.)
before the page load.
PHPBB3-12828
[ticket/12844] Don't clear $dbpasswd early in connection manager
* Nicofuma/ticket/12844:
[ticket/12844] Don't clear $dbpasswd early in connection manager
Using profilefield_base_migration.php to create a custom profile
field with SQlite3 DBMS returns warning:
[phpBB Debug] PHP Warning: in file [ROOT]/phpbb/db/driver/sqlite3.php
on line 218: SQLite3Result::fetchArray(): Unable to execute statement:
constraint failed
This is due passing filed_id and lang_id to the DB driver in
unspecified format. As they are always int we should cast them
in int to prevent the error message appearance.
PHPBB3-12846
* prep-release-3.1.0-RC2:
[prep-release-3.1.0-RC2] Update phpBB Version for RC3 development
[prep-release-3.1.0-RC2] Add changelog for 3.1.0-RC2
[prep-release-3.1.0-RC2] Prepare Changelog
[prep-release-3.1.0-RC2] Add migration for 3.1.0-RC2
[prep-release-3.1.0-RC2] Update version to 3.1.0-RC2
[ticket/12839] Include update related templates and assets in the package
* nickvergessen/ticket/12839:
[ticket/12839] Include update related templates and assets in the package
[ticket/12768] 'NOTIFICATION_REPORT_CLOSED' entry has wrong indentation
* n-aleha/ticket/12768:
[ticket/12768] More fixes in language files
[ticket/12768] 'NOTIFICATION_REPORT_CLOSED' entry has wrong indentation
[ticket/12818] Deleting a log entry in MCP produces a General error
* Nicofuma/ticket/12818:
[ticket/12818] Use assertGreaterThanOrEqual in the tests
[ticket/12818] Don't use the id for i=
[ticket/12818] Add tests
[ticket/12818] Fix the conditions in the call to $log->delete() in mcp_logs
[ticket/12775] Replace functions_container with a container_builder class.
* Nicofuma/ticket/12775: (34 commits)
[ticket/12775] Set dbal.conn.driver as synthetic during installation
[ticket/12775] Add the definition of dbal.conn in fixtures/config/services.yml
[ticket/12775] Inject the connection when created in the container
[ticket/12775] Extract the vars later in install/install_update.php
[ticket/12775] Rename config_php_handler to config_php_file container_builder
[ticket/12775] Set defined_vars as a property of config_php_file
[ticket/12775] Fix doc blocks in the container builder
[ticket/12775] Remove useless includes of config.php
[ticket/12775] Move phpbb_convert_30_dbms_to_31 into the config file class
[ticket/12775] Fix comments
[ticket/12775] Update doc blocks
[ticket/12775] Fix container_builder
[ticket/12775] Rename config_php to config_php_file
[ticket/12775] Renamed to \phpbb\di\container_builder
[ticket/12775] Remove the last include of functions_container
[ticket/12775] Fix unit tests
[ticket/12775] Add tests for \phpbb\config_php
[ticket/12775] Add tests for the container factory
[ticket/12775] Use a field instead of a local var in load_config_var()
[ticket/12775] Update container and config in install/
...
[ticket/12695] Add viewtopic language file for parse_attachments in mcp_...
* marc1706/ticket/12695:
[ticket/12695] Add viewtopic language file for parse_attachments in mcp_post
smilies and line breaks in memberlist
The value is overwritten with the contact value
Added aditional check if the field is a contact so we don't overwrite it.
PHPBB3-12791
[ticket/12786] Extend profilefield_base_migration.php class
* lucifer4o/ticket/12786:
[ticket/12786] Correcting some tabs
[ticket/12786] Array_merge instead copy array parts
[ticket/12786] Some changes of the comments.
[ticket/12786] Dixing a typo
[ticket/12786] Some minor fixes of comments and function naming
[ticket/12786] Add clean_cpf_db_entries
[ticket/12786] White spaces found
[ticket/12786] Add create_language_entries
[ticket/12786] Add get_custom_field_id
[ticket/12786] Extend profilefield_base_migration.php class
[ticket/12787] Allow the route to say that the referer has to be used.
* Nicofuma/ticket/12787:
[ticket/12787] Updates phpbb_mock_controller_helper
[ticket/12787] Add controller_helper::get_current_url()
[ticket/12787] Remove one app.php when it's both in $path and $web_root_path
[ticket/12787] Fix the absolute board url
[ticket/12787] Use a parameter (_referer) instead of the Referer header
[ticket/12099] Add unit tests for get_web_root_path_from_ajax_referer()
[ticket/12099] Remove config again
[ticket/12099] Correctly fix the path when performing AJAX requests
[ticket/12099] Add request argument to path_helper service
[ticket/12825] Better sniff for the extensions and skip the vendor/ directory
* Nicofuma/ticket/12825:
[ticket/12825] Better sniff for the extensions and skip the vendor/ directory
[ticket/12782] Use an interface for the phpbb event_dispatcher
* Nicofuma/ticket/12782:
[ticket/12782] Add doc block
[ticket/12782] Use an interface for the phpbb event_dispatcher
* PayBas/ticket/12813:
[ticket/12813] Move inline-CSS to css file
[ticket/12813] Use -moz-only fix instead of generic padding
[ticket/12813] Reorder .row pagination so it aligns better
[ticket/12813] Fix page-jump title lang and use input type=number
[ticket/12810] Use correct template vars for shadow pruning settings
* marc1706/ticket/12810:
[ticket/12810] Use correct template vars for shadow pruning settings
[ticket/12013] Use new dropdown for quickmod tools and jumpbox.
* prototech/ticket/12013:
[ticket/12013] Fix functional tests and sniffer issue.
[ticket/12013] Clear the jumpbox.
[ticket/12013] Add moderator tools icon.
[ticket/12013] Remove obsolete jumpbox and quickmod CSS.
[ticket/12013] Prevent the dropdown scrollbar from overlapping the content.
[ticket/12013] Update to use the new .button class.
[ticket/12013] Add missing class to place the buttons on the rightside.
[ticket/12013] Use the correct variable for the forum id.
[ticket/12013] Use DEFINE instead of Twig's set.
[ticket/12013] Use path helper.
[ticket/12013] Use new dropdown for quickmod tools and jumpbox.
* PayBas/ticket/12662: (29 commits)
[ticket/12662] Hide quick-links when empty
[ticket/12662] Fix white-space issue to make dropdowns uniform
[ticket/12662] Remove last remaining linklist outside navbars
[ticket/12662] Use data-last-responsive attr instead of hardcoded list
[ticket/12662] Remove <li> container from logged_out_content event
[ticket/12662] Username <span> fix for list columns
[ticket/12662] Fix notifications dropdown positioning for RTL
[ticket/12662] Update tests that utilize get_username_string
[ticket/12662] Update subsilver2 index template event names
[ticket/12662] Update events docs from b5 to rc1/rc2
[ticket/12662] Move dropdown container from <li> to new inner div
[ticket/12662] Remove linklist container and update template events
[ticket/12662] Add span containers to all usernames for consistency
[ticket/12662] IE8 fixes
[ticket/12662] Fix responsive positioning of notifications dropdown
[ticket/12662] Remove inherited props from ddown-extendended
[ticket/12662] Change CSS selectors to direct descendants for linklist
[ticket/12662] Reorder icon CSS rules alphabetically
[ticket/12662] Use slack variable to determine line-break sensitivity
[ticket/12662] Change new event names and fix events.md
...
* 'ticket/12562' of https://github.com/PayBas/phpbb:
[ticket/12562] Use border for all sizes except responsive
[ticket/12562] Use Hanakin's version
[ticket/12562] Increase mq trigger screen size to hide border
[ticket/12562] Add max-width to proSilver
Ticket/12783 Move require:phpbb/phpbb to extra:phpbb/phpbb in Extensions composer.json files
* nickvergessen/ticket/12783:
[ticket/12783] Move phpbb requirement to extra->soft-require
[ticket/12783] Correctly use dataProviders and mark tests as incomplete
[ticket/12783] Move phpbb/phpbb require version to extra
[ticket/12781] Template regex for IF catch too many things
* Nicofuma/ticket/12781:
[ticket/12781] Add tests
[ticket/12781] Template regex for IF catch too many things
[ticket/9801] Allow display of page outside board directory on viewonline
* marc1706/ticket/9801:
[ticket/9801] Use empty instead of sizeof
[ticket/9801] Remove spaces before * in docblock
[ticket/9801] Add viewonline_helper service to allow proper testing
[ticket/9801] Allow display of page outside board directory on viewonline
[ticket/12784] Allow the extensions to add a custom auto loader
* Nicofuma/ticket/12784:
[ticket/12784] Shearch the "vendor" folders and then the autoload.php files
[ticket/12784] Allow the extensions to add a custom auto loader
[ticket/12334] Add PROFILE_FIELD_VALUE_RAW template var
* Dragooon/ticket/12334:
[ticket/12334] Remove profile fields test group
[ticket/12334] Add additional test for type_string
[ticket/12334] Add string test for type_int
[ticket/12334] Improve type_dropdown's test description
[ticket/12334] Group profile fields test
[ticket/12334] Change get_profile_value_raw_data to profile_value_raw_data
[ticket/12334] Add get_profile_value_raw unit test for type_bool
[ticket/12334] Add get_profile_value_raw unit test for type_date
[ticket/12334] Add get_profile_value_raw unit tests for type_dropdown
[ticket/12334] Add get_profile_value_raw unit test for type_string
[ticket/12334] Add get_profile_value_raw unit test for type_url
[ticket/12334] Add get_profile_value_raw unit tests for type_int
[ticket/12334] Removed tests
[ticket/12334] Dropdowns cannot be tested this way
[ticket/12334] Added test get_profile_value_raw
[ticket/12334] Changed from valueid to value_raw
[ticket/12334] Implemented get_profile_valueid method
[ticket/12334] Added field_novalue fall-back as requested
[ticket/12334] Add PROFILE_FIELD_VALUEID template var
[ticket/12790] Use \phpbb\db\driver\driver_interface in prune_shadow_topics
* Nicofuma/ticket/12790:
[ticket/12790] Use \phpbb\db\driver\driver_interface in prune_shadow_topics
If the current request is a AJAX we need to fix the paths.
We need to get the root path based on the Referer, so we can use
the generated URLs in the template of the Referer. If we do not
generate the relative path based on the Referer, but based on the
currently requested URL, the generated URLs will not point to the
intended locations:
Referer desired URL desired relative root path
memberlist.php faq.php ./
memberlist.php app.php/foo/bar ./
app.php/foo memberlist.php ../
app.php/foo app.php/fox ../
app.php/foo/bar memberlist.php ../../
../page.php memberlist.php ./phpBB/
../sub/page.php memberlist.php ./../phpBB/
PHPBB3-12099
If extensions authors will use profilefield_base_migration.php
class as base class for creation of CPFs, the class need to be
extended a bit.
At the moment there are two issues with it:
It does not create entries for PROFILE_FIELDS_LANG_TABLE
(as it can't know what fields to create).
The migration is not "cleaning" the DBMS after purging
the extension and leaves everything except the CPF column.
Adding profilefield_language_data
PHPBB3-12786
[ticket/12716] Add the missing parameters in the call of clearToken
* Nicofuma/ticket/12716:
[ticket/12716] Use a string as session_id
[ticket/12716] Add regression test
[ticket/12716] Add the missing parameters in the call of clearToken
[ticket/12764] Properly handle errors upon connecting to MySQLi database
* marc1706/ticket/12764:
[ticket/12764] Properly handle errors upon connecting to MySQLi database
[ticket/12771] Bug in profilefield_base_migration when used in ext
* lucifer4o/ticket/12771:
[ticket/12771] Shanging substr to strpos
[ticket/12771] Change var name
[ticket/12771] Bug in profilefield_base_migration when used in ext
[ticket/12759] Resolve query flooding while displaying large number of custom profile fields
* Dragooon/ticket/12759:
[ticket/12759] Fix type_bool and type_dropdown's UCP fields
[ticket/12759] Remove lang_helper from profilefields_manager
[ticket/12759] Cache all lang_options in lang_helper instead
[ticket/12759] Extra line in profilefields_manager
[ticket/12759] Cache lang_options for pm_viewmessage
[ticket/12759] Cache lang_options on memberlist
[ticket/12759] Add phpDoc comments to explain get_option_lang
[ticket/12759] Little code cleanup
[ticket/12759] Make sure $field_id has unique elements
[ticket/12759] Cache the lang options earlier
[ticket/12759] Cache lang options for all fields while displaying
[ticket/12759] Allow multiple fields to be loaded via get_option_lang
Previously these would be fetched one field at one time, causing a large
number of queries in case there were large number of custom profile fields
and/or unique number of users in areas such as viewing topics. Resolve this
by caching them at once when generating data for displaying them in templates.
PHPBB3-12759
[ticket/12325] Automatic update should notify about outdated files
* Nicofuma/ticket/12325:
[ticket/12325] Fix the language var name
[ticket/12325] Update coding style in template
[ticket/12325] Fix: add a missing colon
[ticket/12325] Don't use L_COLON
[ticket/12325] Fix: it's not stuck in an inifinite loop anymore
[ticket/12325] Automatic update should notify about outdated files
[ticket/12773] Fix language variable name in cli extension enable command
* n-aleha/ticket/12773:
[ticket/12773] Fix language variable name in cli extension enable command
* nickvergessen/ticket/12099:
[ticket/12099] Fix correction in path_helper test
[ticket/12099] Prepend ./ to path to fix assets
[ticket/12099] Deduplicate path generation
[ticket/12099] Fix clean_path() ".." stripping when previous directory was "."
[ticket/12099] Break clean_path tests with a simple test
[ticket/12099] Clean paths in tests
[ticket/12099] Correctly fix go back to root before prepending the root path
[ticket/12099] Clean some paths before using them
[ticket/12099] Fix several issues in path_helper test
As the db_connect_id gets set up by mysql_init(), the db_connect_id will be an
object with empty settings instead of just empty. Even if mysql_real_connect()
encounters an error upon connecting, the db_connect_id is still set. This
will result in trying to just access the database which obviously does
nothing.
By setting db_connect_id to an empty string, the script will not try to query
th database and properly handle any errors that occur upon connecting.
PHPBB3-12764
The base migration class should create lang entry for the new CPF
but it is supposed to strip it of phpbb_ prefix. As extensions
CPFs do not use phpbb_ prefix it will not create a lang entry.
This is as simple solution as it can be done.
PHPBB3-12771
[Ticket/12680] - Adds alternative text to contact icon in viewtopic.php
* Crizz0/ticket/12680:
[ticket/12680] Adds variable for guest user
[ticket/12680] Brings back get_username_string()
[ticket/12680] Solves last bugs. viewprofile: contact --> contact nickname
[ticket/12680] Still some problems with displaying the nickname in ucp
[ticket/12680] Little changes, but some issues are still there
[ticket/12680] Removes unnessesary $user->lang from CONTACT_USER
[ticket/12680] Adds alternativ text with new variable to contact:
[ticket/12680] Adds second alternativ text and font-size: 0 to remove text
[ticket/12680] Adds alternative text to contact icon in viewtopic.php
* prep-release-3.1.0-RC1:
[prep-release-3.1.0-RC1] Update phpBB Version for RC2 development
[prep-release-3.1.0-RC1] Add changelog for 3.1.0-RC1
[prep-release-3.1.0-RC1] Prepare Changelog
[prep-release-3.1.0-RC1] Add migration for 3.1.0-RC1
[prep-release-3.1.0-RC1] Update version to 3.1.0-RC1
* develop-olympus:
[ticket/12755] Apply de morgan to conditional
[ticket/12755] Terminate upload loop if upload reaches filesize
[ticket/12755] Change upload in remote_upload() method to fit get_remote_file
[ticket/12755] Add language string for timed out remote upload
[ticket/12755] Add timeout to remote upload to prevent infinite loop
[ticket/12755] Add timeout to remote upload to prevent infinite loop
* marc1706/ticket/12755:
[ticket/12755] Apply de morgan to conditional
[ticket/12755] Terminate upload loop if upload reaches filesize
[ticket/12755] Change upload in remote_upload() method to fit get_remote_file
[ticket/12755] Add language string for timed out remote upload
[ticket/12755] Add timeout to remote upload to prevent infinite loop
Terminate the upload loop if the expected filesize has been reached instead
of trying to read more bytes until the timeout has been reached.
PHPBB3-12755
* github-nickvergessen/ticket/12612:
[ticket/12612] Prefix check_ids() with phpbb_
[ticket/12612] Prefix mcp_sorting() with phpbb_
[ticket/12612] Prefix get_*_data() with phpbb_ and delete unused global
[ticket/12612] Prefix module url functions with phpbb_
[ticket/12612] Prefix upload_popup() with phpbb_
[ticket/12612] Prefix handle_post_delete() with phpbb and remove unused global
[ticket/12612] Prefix custom UCP module function with phpbb_
[ticket/12612] Prefix _sort_last_active() with phpbb_
[ticket/12612] Prefix show_profile() with phpbb and delete unused global
Ticket/12763 Do not regenerate the *_schema.sql files
* nickvergessen/ticket/12763:
[ticket/12763] Remove invalid comment from oracle and postgres *_schema.sql
[ticket/12763] Remove empty schema files
[ticket/12763] Do not regenerate the *_schema.sql files
The variable $mimetype is not used in the method local_upload() afterwards
so it shouldn't be assigned. The correct default mimetype should be
application/octet-stream and not application/octetstream according to RFC 2046.
PHPBB3-11148
The mimetype guesser will be used to get the mimetype of uploaded files.
Until now, this was only used for files uploaded with plupload. If a file
doesn't have a mimetype supplied, we will now try to get the correct mimetype.
PHPBB3-11148
[ticket/11528] Refactor install_board( ) into a new mink class
* dhruvgoel92/ticket/11528:
[ticket/11528] Change click_submit() to accept id as param
[ticket/11528] Handle case when config file cant be written by installer
[ticket/11528] Change NULL to null
[ticket/11528] Fix spaces and slashes as per guidelines
[ticket/11528] Add asserts in installation steps
[ticket/11528] Use 'use' keyword to import classes to current scope
[ticket/11528] Move parent::tearDown() to end of tearDown()
[ticket/11528] Call parent::tearDown in overrided tearDown method
[ticket/11528] Instantiate $client, $driver from functional test case
[ticket/11528] Refactor install_board() code into a new class
[ticket/11528] Add behat/mink and mink-goutte-driver as dependency
[Ticket/12696] Add events to ucp_register.html
* lucifer4o/ticket/12696:
[ticket/12696] Typo
[ticket/12696] Change some parts
[ticket/12696] Naming convention changes
[ticket/12696] A small error with events.md perms
[ticket/12696] Add events to evets.md
[ticket/12696] Add prosilver ucp_register
[ticket/12696] Add events to ucp_register.html
[ticket/12690] Add core.submit_pm_after event
* lucifer4o/ticket/12690:
[ticket/12690] Find a space
[ticket/12690] Remove $msg_id and chmod
[ticket/12690] Add other info to core.submit_pm_after
[ticket/12690] Add core.submit_pm_after event
* github-nickvergessen/ticket/12612-ascraeus:
[ticket/12612] Move functions from mcp.php to functions_mcp.php
[ticket/12612] Move function from ucp.php to functions_user.php
[ticket/12612] Move functions from memberlist.php to functions_display.php
[ticket/12612] Move functions from posting.php to functions_posting.php
[ticket/12747] Drop support for Firebird
* nickvergessen/ticket/12747:
[ticket/12747] Remove some methods which are not used anymore
[ticket/12747] Drop support for Firebird
Conflicts:
phpBB/phpbb/db/driver/firebird.php
[ticket/12704] Improve the load time information in the footer when enabled
* rxu/ticket/12704:
[ticket/12704] Improve the load time information in the footer when enabled
[ticket/12714] Switching the description of radio buttons to align the correct description above the listbox
* Skouat/ticket/12714:
[ticket/12714] Move "allow all forums" in its own dd-element
[Ticket/12701] Add events to user_add function
* lucifer4o/ticket/12701:
[ticket/12701] Add change
[ticket/12701] Rmove before event and expand modify_data
[ticket/12701] Add events to user_add function
Add events to UCP Register template:
ucp_register_before - add before start of registration form fields
ucp_register_after - add after end of registration form fileds
ucp_register_passowrd_after - add event after passowrd field
ucp_register_language_before - add event before language selector
ucp_register_profiles_before - add event just before begining of
registration profile informatiom
All events are inside the registration form fieldset.
All events are inside the registration form
Justification:
Add abbility of extension author to include custom
checks or fields inside the registration form.
Like age check field/verification.
PHPBB3-12696
Add two new events to user_add function
in ./includes/functions_user.php.
core.user_add_before - allow modification of
submitted to function data.
Returns:
@var array $user_row - user_row array - User array
@var array $cp_data - cp_data array - CPF array
core.user_add_after - return user_id, user_row and
cp_data after user registration
Returns:
@var int $user_id - user_id of the new user
@var array $user_row - user_row array - User array
@var array $cp_data - cp_data array - CPF array
Justification:
Allow extensions to parse data before and after
creation of the user.
PHPBB3-12701
Add core.delete_pm to funtion delete_pm.
Event will return:
int $user_id - ID of the user requested the message delete
array $msg_ids - array of all messages to be deleted
int $folder_id - ID of the user folder where the messages are stored
Justification:
Allow extensions to capture this event
and act as intended by ext author
PHPBB3-12691
Add core.submit_pm_after to funtion submit_pm.
Event will return just submited msg_id. It should be plased
just before return $data['msg_id'];
Justification:
Using only core.submit_pm_before does not allow to
follow up after message submission.
The message ID is recieved at DB submission.
Some times we need the MSG_ID as identifier
PHPBB3-12690
[ticket/12758] Add show_results var to core.search_modify_rowset
* PayBas/ticket/12758:
[ticket/12758] Add @changed to doc block
[ticket/12758] Add show_results var to core.search_modify_rowset
[ticket/12753] Add invalid chars string for ALPHA_DOTS and ALPHA_PUNCTUAION
* Dragooon/ticket/12753:
[ticket/12753] Add invalid chars string for ALPHA_DOTS and ALPHA_PUNCTUATION
[ticket/12730] Add Google+ profile field
* Dragooon/ticket/12730:
[ticket/12730] Update Google+ button class to use proper identification
[ticket/12730] Update maxlen for type_googleplus to 255
[ticket/12730] Fix type_googleplus_test to use same validation rule as the field
[ticket/12730] Update field_length to be 20 by default for Google+
[ticket/12730] Google+ field_order should be 13
[ticket/12730] Switch service name to googleplus for type_googleplus
[ticket/12730] Restore field_length to 10 for type_googleplus
[ticket/12730] Add functional test for Google+ field
[ticket/12730] Value shouldn't be escaped for schema_data.sql
[ticket/12730] Missing newline at type_googleplus_test.php
[ticket/12730] Set field_active to 1 for Google+ field
[ticket/12730] Add unit test for type_googleplus
[ticket/12730] Add missing brackets to type_googleplus.php
[ticket/12730] Update field_order for Google+ CPF
[ticket/12730] Use string template for Google+ CPF instead of a new one
[ticket/12730] Minor formatting fixes
[ticket/12730] Incorrect indentation for type_googleplus
[ticket/12730] Spaces in block header
[ticket/12730] Add a Google+ field by default
[ticket/12730] Add Google+ profile field type
[ticket/12723] Add Sniff ensuring PHP files use the correct file header
* Nicofuma/ticket/12723:
[ticket/12723] Do not mention too many details on documentation.
[ticket/12723] Do not reference the coding guidelines section.
[ticket/12757] Add a Code Sniffer ruleset for PHP files of phpBB extensions
[ticket/12723] Properly describe new Code Sniffer rulsets.
[ticket/12723] Use core suffix in filename instead of phpbb in the middle.
[ticket/12723] Add Sniff ensuring PHP files use the correct file header
[ticket/12752] Cron list tests fail on windows with ansi support
* Nicofuma/ticket/12752:
[ticket/12752] Cron list tests fail on windows with ansi support
Google+ has a "+" before a custom URL but doesn't for those which are using
their integer ID. To cover that we need to have an extra profile field
PHPBB3-12730
[ticket/12731] Add YouTube custom profile field
* Dragooon/ticket/12731:
[ticket/12731] Add functional test for youtube field
[ticket/12731] Set field_active to 1 for YouTube field
[ticket/12731] Add YouTube custom profile field
Conflicts:
phpBB/install/schemas/schema.json
phpBB/install/schemas/schema_data.sql
phpBB/language/en/memberlist.php
tests/functional/ucp_profile_test.php
[ticket/12732] Add Skype custom profile field
* Dragooon/ticket/12732:
[ticket/12732] Update schema.json for Skype
[ticket/12732] Add functional test for Skype profile field
[ticket/12732] Values shouldn't be escaped for schema_data.sql
[ticket/12732] Set field_active to 1 for Skype's field
[ticket/12732] Add unit tests for ALPHA_PUNCTUATION
[ticket/12732] Missing comma after validation definition
[ticket/12732] Improve ALPHA_PUNCTUATION description
[ticket/12732] Use user info instead of chat as default Skype action
[ticket/12732] Add Skype custom profile field
Conflicts:
phpBB/install/schemas/schema.json
phpBB/install/schemas/schema_data.sql
phpBB/language/en/memberlist.php
tests/functional/ucp_profile_test.php
tests/profilefields/type_string_test.php
[ticket/12733] Add Twitter custom profile field
* Dragooon/ticket/12733:
[ticket/12733] Add functional test for twitter profile field
[ticket/12733] Values needn't be escaped for schema_data.sql
[ticket/12733] Set field_active to 1 for Twitter
[ticket/12733] Convert spaces to tabs
[ticket/12733] Fix spacing for block header in profilefield_twitter.php
[ticket/12733] Update schema.json
[ticket/12733] Add Twitter custom profile field
Conflicts:
phpBB/install/schemas/schema.json
phpBB/install/schemas/schema_data.sql
phpBB/language/en/memberlist.php
tests/functional/ucp_profile_test.php
[ticket/12729] Add Facebook custom profile field
* Dragooon/ticket/12729:
[ticket/12729] Add functional test for Facebook field
[ticket/12730] Values needn't be escaped for schema_data.sql
[ticket/12729] Set field_active as 1 for Facebook profile field
[ticket/12729] Add unit test for ALPHA_DOTS validation
[ticket/12729] Move ALPHA_DOTS to above ALPHA_SPACERS
[ticket/12729] Convert spaces to tabs
[ticket/12729] Fix block header spacing for profilefield_facebook.php
[ticket/12729] Update schema.json
[ticket/12729] Unnecessary whitespace in profilefield_facebook.php
[ticket/12729] Cleanup schema_data.sql for Facebook field
[ticket/12729] Add Facebook custom profile field
[ticket/12746] Init phpbb_dispatcher being used by delete_post()
* dhruvgoel92/ticket/12746:
[ticket/12746] Init phpbb_dispatcher being used by delete_post()
PR #2570 has added new constant to display load time information without
debug mode is being on (https://tracker.phpbb.com/browse/PHPBB3-12687).
This patch expands the total load time info with SQL/PHP load times,
while hiding the additional info with <abbr> element.
PHPBB3-12704
[ticket/12514] Add tests for profile fields
* Dragooon/ticket/12514: (28 commits)
[ticket/12514] Fix array formatting for tests
[ticket/12514] Fix indention for type_url_test.php
[ticket/12514] Missed a few spaces in comments
[ticket/12514] Convert spaces to tabs
[ticket/12514] Add a few additional tests for type_dropdown
[ticket/12514] Add a few additional tests for type_int
[ticket/12514] Fix some formatting for tests
[ticket/12514] Add a few more tests for type_date
[ticket/12514] Remove spaces in header blocks
[ticket/12514] Use generic domain name for URL test
[ticket/12514] Update file headers to represent the current format
[ticket/12514] Remove get_ prefix from data providers
[ticket/12514] Add a few more validation cases for type_string_test
[ticket/12514] Minor fault in type_bool_test.php
[ticket/12514] Remove tests/profiles as they're no longer required
[ticket/12514] Fix type_int_test to correctly respect boundaries
[ticket/12514] Multi value GET parameters are invalid for phpBB
[ticket/12514] Add unit test for type_url custom profile field
[ticket/12514] Add unit test for type_date custom profile field
[ticket/12514] Add unit test for type_bool custom profile field
...
[ticket/11711] Inform user of unsupported characters while posting
* marc1706/ticket/11711:
[ticket/11711] Improve coding and comments of character check
[ticket/11711] Reduce size of tests and also test topic titles
[ticket/11711] Improve checks for unsupported characters and check subject
[ticket/11711] Inform user of unsupported characters while posting
[ticket/12553] Right-to-left fixes.
* prototech/ticket/12553:
[ticket/12553] Fix responsive user profile.
[ticket/12553] Fix responsive post profile.
[ticket/12553] Remove dropdown-trigger class from member search input.
[ticket/12553] Fix the merge topic list.
[ticket/12553] Fix dropdown position of live search
[ticket/12553] Fix the responsive topic/forum lists.
[ticket/12553] Align the text in responsive tables to the right.
[ticket/12553] Center the responsive CP menus instead of floating right.
[ticket/12553] Open the notification dropdown to the left.
[ticket/12553] Fix alignment of contact icon.
[ticket/12553] Fix incorrect alignment in ACP responsive tables.
[ticket/12553] Align alert text to the right.
[ticket/12553] Remove incorrect size for site logo.
[ticket/12553] Fix links in the last post column that are not clickable.
[ticket/12553] Align contact icons to the right.
[ticket/12553] Move Place inline and Delete buttons left of the file name.
[ticket/12638] v30x\local_url_bbcode break the migrations if we don't use the auto updater
* Nicofuma/ticket/12638:
[ticket/12638] Use require if phpbb_require_updated isn't available
[Ticket/12699] Remove magic numbers in the message textarea keydown callback
* brunoais/ticket/12699:
[ticket/12699] Replace magic numbers for the TAB and for ENTER keydown
[ticket/12699] Add tab key to keymap
[ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset
* Nicofuma/ticket/12722:
[ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset
[ticket/12720] Allow commit heading to begin with lowercase letters
* dhruvgoel92/ticket/12720:
[ticket/12720] Allow commit heading to begin with lowercase letters
Ticket/12643 Fixes deletion of columns that have the target column as a prefix
* Noxwizard/ticket/12643:
[ticket/12643] Properly handle changing columns on tables with constraints
[ticket/12643] Tests dropping similarly named columns
[ticket/12643] Ensure that similarly named columns are not removed
[ticket/12715] Fix mistakes in the doc blocks
* Nicofuma/ticket/12715: (30 commits)
[ticket/12715] Add missing new line in the notification manager
[ticket/12715] Cleanup comments in \phpbb\symfony_request
[ticket/12715] Cleanup comments in \phpbb\permissions
[ticket/12715] Cleanup comments in \phpbb\path_helper
[ticket/12715] Cleanup comments in \phpbb\pagination
[ticket/12715] Cleanup comments in \phpbb\datetime
[ticket/12715] Cleanup comments in \phpbb\content_visibility
[ticket/12715] Cleanup comments in \phpbb\tree\*
[ticket/12715] Cleanup comments in \phpbb\template\*
[ticket/12715] Cleanup comments in \phpbb\plupload\*
[ticket/12715] Cleanup comments in \phpbb\profilefields\*
[ticket/12715] Cleanup comments in \phpbb\passwords\*
[ticket/12715] Cleanup comments in \phpbb\notification\*
[ticket/12715] Cleanup comments in \phpbb\mimetype\*
[ticket/12715] Cleanup comments in \phpbb\message\*
[ticket/12715] Cleanup comments in \phpbb\log\*
[ticket/12715] Cleanup comments in \phpbb\lock\*
[ticket/12715] Cleanup comments in \phpbb\groupposition\*
[ticket/12715] Cleanup comments in \phpbb\feed\*
[ticket/12715] Cleanup comments in \phpbb\extension\*
...
[ticket/12712] Add user_password to GROUP BY clause to fix query for mssql
* marc1706/ticket/12712:
[ticket/12712] Remove unneeded GROUP BY clause to fix query for mssql
* PayBas/ticket/12613: (25 commits)
[ticket/12613] Add distinction between top/bottom action-bar
[ticket/12613] Replaced topic-actions with action-bar
[ticket/12613] Remove responsive linklist from memberlist
[ticket/12613] Remove unnecessary checks and clean up CSS
[ticket/12613] role="navigation" not allowed on <ul>
[ticket/12613] Improved screen reader functionality
[ticket/12613] Removed unnecessary checks
[ticket/12613] Set fixed font-size
[ticket/12613] Slightly better icons
[ticket/12613] Typo and L_COLON
[ticket/12613] Small inconsistency fixes
[ticket/12613] Don't display page-jump if all pages are visible (6)
[ticket/12613] Fixes from comments (single quotes and typos)
[ticket/12613] Minor $bull; and <hr> fix
[ticket/12613] Pagination should never be in responsive linklist
[ticket/12613] Minor CSS fixes
[ticket/12613] Dropdown-visible page-jump icon, fix focus() timing
[ticket/12613] Renamed jump-to to page-jump to prevent confusion
[ticket/12613] Removed form in order to prevent nested forms
[ticket/12613] Fix functional test and post sorting bug
...
The value is stored in a text column and the key is stored in a varchar. Some
DBMSes do not like it when we insert integers into text columns. Cast both to
string to be on the safe side.
PHPBB3-12711
The relative position of the <dt> is causing it to sit atop of the <dd> thus
preventing the user from clicking the links. The <dl> has a relative position
in LTR, which takes care of containing the read/unread icon link that has an
absolute position. We no longer support IE6, so removing the tweak that sets
the <dl> position to static will make everything behave the same way in RTL as
in LTR.
PHPBB3-12553
[ticket/12707] Do not try to load 3.1 DBMS driver name as 3.0 driver.
* bantu/ticket/12707:
[ticket/12707] Do not try to load 3.1 DBMS driver name as 3.0 driver.
[ticket/12575] Use a proxy pattern in \phpbb\di\service_collection
* Nicofuma/ticket/12575:
[ticket/12575] Use strict comparison
[ticket/12575] Add missing property
[ticket/12575] Usethe new header
[ticket/12575] Fix 2 typos in comments
[ticket/12575] Fix typos in comments
[ticket/12575] Skip sniffer issue triggered by the solution of a php bug
[ticket/12575] Remove inline assignments
[ticket/12575] Fix the tests
[ticket/12575] Move service_collection_iterator to its own file
[ticket/12575] Speed up load_class()
[ticket/11445] optimize no of queries in get_global_subscriptions( )
* dhruvgoel92/ticket/11445:
[ticket/11445] Move get user's notification code into its own method
[ticket/11445] Remove unused foreach key $group_name
[ticket/11445] Improve unit tests for get_global_subscriptions
[ticket/11445] Optimize no of queries in get_global_subscriptions
[ticket/12682] Make Code Sniffer run properly on Travis CI again.
* bantu/ticket/12682:
[ticket/12682] Make Code Sniffer run properly on Travis CI again.
[ticket/12687] Add a constant to display the load time without DEBUG
* Nicofuma/ticket/12687:
[ticket/12687] Remove french spaces
[ticket/12687] Display the number of cached queries
[ticket/12687] Don't check if memory_get_peak_usage() exists
[ticket/12687] Wrap $GLOBALS['starttime'] in a if
[ticket/12687] Fix the namespace of $request
[ticket/12687] Update doc block
[ticket/12687] Use microtime(true)
[ticket/12687] Remove globals
[ticket/12687] Return a string and move the displaying of the sql report
[ticket/12687] Rename DISPLAY_LOAD_TIME to PHPBB_DISPLAY_LOAD_TIME
[ticket/12687] Display the explain link only when DEBUG is set
[ticket/12687] Add a constant to display the load time without DEBUG
The --ignore parameter takes a case-insensitive pattern and as such
'phpBB/phpbb/*' matches any '/home/travis/build/phpbb/phpbb/...' file name.
This results in nothing being checked against ruleset-php-legacy.xml.
Using absolute paths in the --ignore pattern fixes this issues.
PHPBB3-12682
Until now, the preg_match didn't take into account that a page might be
outside the board directory. After this change, the regular expression will
allow preceding dots and slashes. Paths like ../../test.php will be allowed.
The page will be unknown in viewonline.php and it will revert to index.php as
current page. However, the core.viewonline_overwrite_location event will
receive proper info of the page the user is on right now allowing a listener
to change the info that is being displayed.
PHPBB3-9801
* github-marc1706/ticket/12352: (33 commits)
[ticket/12352] Do not check hashes that don't have the necessary length
[ticket/12352] Update file headers to fit new format
[ticket/12352] Use custom provider collection for auth providers
[ticket/12352] Add checks for existing user_pass_convert to migrations
[ticket/12352] Remove usages of user_pass_convert column
[ticket/12352] Update schema json file
[ticket/12352] Remove user_pass_convert column from database
[ticket/12352] Check each newly added passwords driver in manager_test
[ticket/12352] Add get_settings_only method to passwords driver base
[ticket/12352] Add passwords driver for xenforo 1.0, 1.1 passwords
[ticket/12352] Add tests for wcf1 and wcf2 drivers
[ticket/12352] Add driver for woltlab community framework 1 passwords
[ticket/12352] Add driver for woltlab community framework 2 passwords
[ticket/12352] Add missing $ to md5_mybb and md5_vb driver
[ticket/12352] Fix spacing in passwords tests
[ticket/12352] Add passwords driver for vB passwords
[ticket/12352] Use correct hashing method in md5_mybb driver
[ticket/12352] Add driver for myBB md5 passwords
[ticket/12352] Rename phpbb2_md5 driver to fit filenames of other drivers
[ticket/12352] Add passwords driver for sha1 password hashes
...
* nickvergessen/ticket/12483:
[ticket/12483] Fix selectors for installing extensions in functional tests
[ticket/12483] Remove unused globals
[ticket/12483] Fix finder usage when generating the schema.json file
[ticket/12483] Fix copyright in prepare_extension.sh
[ticket/12483] Use file_put_contents()
[ticket/12483] Close database connection when tearDown() is called
[ticket/12483] Require the extension manager class
[ticket/12483] Move schema files into tmp/ and only copy them when needed
[ticket/12483] Add a .sh that moves an extension in place
[ticket/12483] Allow to setup extensions before database and functional tests
* github-nickvergessen/ticket/12508:
[ticket/12508] Ignore extensions in migration_tips dev tool
[ticket/12508] Fix doc block
[ticket/12508] Add new line to separate the if and foreach better
[ticket/12508] Add a unit test for set_extensions()
[ticket/12508] Only take a list of names for set_extensions()
[ticket/12508] Fix class doc block
[ticket/12508] Move \phpbb\extension\finder to \phpbb\finder
[ticket/12508] Fix usages of the finder
[ticket/12508] Remove extension manager from finder
[ticket/12664] Refactor develop/migration_tips.php into a console command.
* bantu/ticket/12664:
[ticket/12664] Refactor develop/migration_tips.php into a console command.
[ticket/12667] Do not point viewtopic URL to unread post outside of view=unread.
* prototech/ticket/12667:
[ticket/12667] Do not point viewtopic URL to unread post outside of view=unread
[ticket/8610] Merging topics does not handle bookmarks correctly
* Nicofuma/ticket/8610:
[ticket/8610] Use css selector instead of xPath
[ticket/8610] Add functional test when two topics are merged
[ticket/8610] Throw an error when the dest topic isn't set
[ticket/8610] Fix bookmarks when merging all the posts of a topic
[ticket/8610] Merging topics does not handle bookmarks correctly
* github-nickvergessen/ticket/10073: (36 commits)
[ticket/10073] Fix button descriptions
[ticket/10073] Do not check disable boxes by default
[ticket/10073] Store values with config_text in the ACP
[ticket/10073] Move config values to config_text
[ticket/10073] Fix request usage
[ticket/10073] Deduplicate template variable names
[ticket/10073] Get service from container
[ticket/10073] Fix more "Contact Us" strings
[ticket/10073] Move template code into the template
[ticket/10073] Make contact page available when board is disabled
[ticket/10073] Change name of the ACP module
[ticket/10073] Deduplicate posting buttons code in ACP
[ticket/10073] Use phpbb_validate_email to verify email address
[ticket/10073] Add tests for new validate_email()
[ticket/10073] Split email validation from email ban and taken checks
[ticket/10073] Deduplicate the if statement
[ticket/10073] Fallback to board_contact when contact page is disabled
[ticket/10073] Remove language string from rebase conflict
[ticket/10073] Add ACP module to add bbcode text for contact admin info
[ticket/10073] Add new configs to the schema
...
[ticket/12672] Make tab intercept; CB for keypress only react without key mods
* brunoais/ticket/12672:
[ticket/12672] Make tab intercept; CB for keypress only react without key mods
Add core event to the function display_forums()
in includes/functions_display.php to allow assigning additional template data
for every forum, f.e. additional forumrow subloops.
PHPBB3-12669
Changed the callback of keypress inside the <textarea> for the posting
such that, if key 9 is pressed (tab character) and ctrl, shift, alt and meta
are not pressed the tab is placed. Otherwise, nothing is made and default is
not prevented.
PHPBB3-12672
[ticket/12655] Run phpbbcli as a shell when --shell or -s is used
* Nicofuma/ticket/12655:
[ticket/12655] Set register_container_commands as public
[ticket/12655] Don't try to restore the definition in the help
[ticket/12655] Fix coding style
[ticket/12655] Make the --shell option available only for phpbbcli.php
[ticket/12655] Fix coding style in \phpbb\console\application
[ticket/12655] Set the arguments of \phpbb\console\application as required
[ticket/12655] Don't require acp/common again in the commands
[ticket/12655] Run the shell when --shell is used
[ticket/12602] Add command to print the cron list
* Stephannos/ticket/12602:
[ticket/12602] Fix language key removal.
[ticket/12602] Rectify language keys.
[ticket/12602] Fix test mistake.
[ticket/12602] Fix language var mistakes.
[ticket/12602] Add types, change description of cron:list.
[ticket/12602] Fix internationalisation of cron_list.php
[ticket/12602] Fix spaces issues.
[ticket/12602] Coding style correction.
[ticket/12602] Fix coding style mistakes.
[ticket/12602] Headers updated.
[ticket/12602] Changes to respect coding style and to factorize code.
[ticket/12602] Cleanup tests
[ticket/12602] Add function get_tasks.
[ticket/12602] Correction of the output message for the cron list
[ticket/12602] Add files to print the cron list and test files.
[ticket/12666] Use "None" for images in root of gallery avatar path
* marc1706/ticket/12666:
[ticket/12666] Use "None" for images in root of gallery avatar path
* PayBas/ticket/12541:
[ticket/12541] Activate attachments tab when files are dropped into textarea
Conflicts:
phpBB/styles/prosilver/template/forum_fn.js
[ticket/12457] Default to first category if none is selected in gallery avatar
* marc1706/ticket/12457:
[ticket/12457] Default to first category if none is selected in gallery avatar
[ticket/12639] Delete entry in admin-log leads to mysql-error
* Nicofuma/ticket/12639:
[ticket/12639] Add a space in the code generated by generate_sql_keyword()
[ticket/12639] Handle $conditions['keywords'] outside of the loop
[ticket/12639] Don't make a copy of $marked when deleting logs in acp_logs
[ticket/12639] Send a correct IN entry when deleting marked logs
[ticket/12639] Use assertSame
[ticket/12639] Remove old commented tests
[ticket/12639] Order the results correctly in the test
[ticket/12639] Fix tests on postgres
[ticket/12639] Update tests to use a dataProvider
[ticket/12639] Add a test case with an empty keywords list
[ticket/12639] Delete entry in admin-log leads to mysql-error
Using this custom provider collection, we can properly check whether the
configured auth provider does exist. The method get_provider() has been added
for returning the default auth provider or the standard db auth provider if
the specified one does not exist.
Additionally, the method get_provider() will throw an RuntimeException if
none of the above exist.
PHPBB3-12352
This will make sure that we will not encounter a non-existing auth provider.
We will revert to the default db auth provider if the one set in the config
does not exist in our auth provider collection.
PHPBB3-12352
[ticket/12641] Use jQuery's trim() method. IE8 does not support the native one.
* prototech/ticket/12641:
[ticket/12641] Use jQuery's trim() method. IE8 does not support the native one
[ticket/12589] Search directly in $directory if it's an absolute sub-path
* Nicofuma/ticket/12589:
[ticket/12589] Add test searching in a non absolute directory
[ticket/12589] Fix tests
[ticket/12589] Search directly in $directory if it's an absolute sub-path
[ticket/12637] Correct file header in coding-guidelines
* bantu/ticket/12637:
[ticket/12637] Fixup all incorrect uses of file header.
[ticket/12637] Correctly escape the file header in coding-guidelines.html.
[ticket/10899] Using Delete All in log viewer with keyword search
* Nicofuma/ticket/10899:
[ticket/10899] Update doc block
[ticket/10899] Use isset($field_value['IN'])
[ticket/10899] Add event core.delete_log
[ticket/10899] Remove trailing ;
[ticket/10899] Fix typo in the class name
[ticket/10899] Add unit tests
[ticket/10899] Get $phpbb_log from the container
[ticket/10899] Remove extra ';'
[ticket/10899] Typo
[ticket/10899] Refactoring in \phpbb\log\log_interface
[ticket/10899] Using Delete All in log viewer with keyword search
[ticket/11942] Delete post/topic reason should be added to logs
* Nicofuma/ticket/11942:
[ticket/11942] Don't change the reason to '' when hard deleting
[ticket/11942] Don't show the checkbox if the post is already soft-deleted
[ticket/11942] Remove useless IF in templates
[ticket/11942] Apply the modifications to subsilver
[ticket/11942] Always display delete reason
[ticket/11942] Edits messages
[ticket/11942] Change the formulation
[ticket/11942] Adding the reason to hard deleted topic/post
[ticket/11942] Delete post/topic reason should be added to logs
[ticket/11467] Add language variables for extension exception messages
* n-aleha/ticket/11467:
[ticket/11467] Add user object to extension manager for tests
[ticket/11467] Add language variables to tests
[ticket/11467] Add language variables for extension exception messages
[ticket/11266] Better message for when composer dependencies are missing...
* bantu/ticket/11266:
[ticket/11266] Better message for when composer dependencies are missing.
[ticket/12597] Command for executing all available cron tasks
* bantu/ticket/12597:
[ticket/12597] Update USE_SYSTEM_CRON_EXPLAIN to be a bit more verbose.
[ticket/12597] Improve language for cron:run command.
[ticket/12597] Do not output anything besides the gif image.
[ticket/12597] Command for executing all available cron tasks
* ptitlazy/ticket/12597: (27 commits)
[ticket/12597] Reformating an acp message
[ticket/12597] Modifiying acp message
[ticket/12597] Fix wrong global variable name
[ticket/12597] Typo correction
[ticket/12597] Typo corrections
[ticket/12597] Changing place of lock release in execute() method
[ticket/12597] Fix test file
[ticket/12597] Typing corrections and improvement of code consistency
[ticket/12597] Fix various mistakes
[ticket/12597] Fix various mistakes
[ticket/12597] Fix visibilty of two functions in run.php
[ticket/12597] Refactoring and test improving
[ticket/12597] Fix language key name
[ticket/12597] Fix coding style and typing mistakes
[ticket/12597] Changes name of command cron:run-all to cron:run.
[ticket/12597] Fix various problems
[ticket/12597] Fix constructor bug and servral doc blocs
[ticket/12597] Modification of return statuses and of test files
[ticket/12597] Fix misplaced release of db lock
[ticket/12597] Change EXECUTE to RUN in language
...
* prep-release-3.1.0-b4:
[prep-release-3.1.0-b4] Update phpBB Version for b5 development
[prep-release-3.1.0-b4] Add changelog for 3.1.0-b4
[prep-release-3.1.0-b4] Prepare Changelog
[prep-release-3.1.0-b4] Add migration for 3.1.0-b4
[prep-release-3.1.0-b4] Update version to 3.1.0-b4
[ticket/12621] schema.json is not up to date with migration files
* PayBas/ticket/12621:
[ticket/12621] schema.json is not up to date with migration files
[ticket/12594] Fix file headers of new files
* nickvergessen/ticket/12594:
[ticket/12594] Update file header in non-php files
[ticket/12594] Fix file headers of new files
[ticket/12611] Remove phpBB Group copyright notice from .gifs
* Marshalrusty/ticket/12611:
[ticket/12611] Remove phpBB Group copyright notice from .gifs
[ticket/11226] filespec::move_file() should error correctly
* Nicofuma/ticket/11226:
[ticket/11226] Explicity set file_moved to false
[ticket/11226] Add tests
[ticket/11226] Use $user->lang()
[ticket/11226] filespec::move_file() should error correctly
[ticket/11366] Extension's version's check
* Nicofuma/ticket/11366: (29 commits)
[ticket/11366] Fix headings css in list page
[ticket/11366] Add config value in schema_data.sql
[ticket/11366] Fix HTML
[ticket/11366] Exchange links and settings' form
[ticket/11366] Remove the extra {S_FORM_TOKEN}
[ticket/11366] Move the links to the top of the page
[ticket/11366] Hide the version check settings by default
[ticket/11366] Versions, options and actions heading should be centered
[ticket/11366] Better language string for "recheck all"
[ticket/11366] Move "recheck all" link
[ticket/11366] Add $config['extension_force_unstable']
[ticket/11366] Use force_cache on the list page
[ticket/11366] Add recheck-all link
[ticket/11366] Force the use of the cache on the list page
[ticket/11366] Update FILE_NOT_FOUND language string
[ticket/11366] Fix whitespaces
[ticket/11366] Update FILE_NOT_FOUND language string
[ticket/11366] Update var names
[ticket/11366] Align language strings
[ticket/11366] Fix detailed view
...
[ticket/12561] Add "after" check to schema_generator for columns_add
* PayBas/ticket/12561:
[ticket/12561] Reworked tests by nickvergessen
[ticket/12561] Added tests for "after last", "after missing" and "empty"
[ticket/12561] Add check to see if "after" column actually exists
[ticket/12561] Added test for "after"
[ticket/12561] Add "after" check to schema_generator for columns_add
[ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.
* bantu/ticket/12384-ascraeus:
[ticket/12384] Use mysqli on hhvm in ascraeus. Keep explicit matrix though.
[ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.
[ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.
* bantu/ticket/12384:
[ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.
Add a feature to check automatically the version of the installed
extensions. The informations are cached for 24 hours (like for the
global update check on the main page of the acp).
The informations about the versions are display both on the global list
and on the detailled page.
To do this the developper has to to let the composer.json of the latest
version available and add some informations into it :
"extra": {
"version-check": {
"host": "<the host>",
"directory": "<the directory containing the file>",
"filename": "<the composer.json of the latest version>"
}
}
He can also add two extra informations which will be displayed if a new
version is available :
"extra": {
"download": "<download link>",
"annoucement": "<announcement link>",
}
Currently a notice is displayed when the "extra.version-check"
informations are
missing.
Ticket: https://tracker.phpbb.com/browse/PHPBB3-11366
Signed-off-by: Nicofuma <github@nicofuma.fr>
PHPBB3-11366
[ticket/12582] Strip away copyrighted ICC profile from images
* bantu/ticket/12582-ascraeus:
[ticket/12582] Use the correct script name.
[ticket/12582] Fix coding style.
[ticket/12582] Remove set -e due to exiftool not liking 0 byte files.
[ticket/12582] Strip away copyrighted ICC profile
[ticket/12582] Change strip_icc_profiles.sh to only take a single file.
[ticket/12582] Run strip_icc_profiles.sh on Travis CI.
[ticket/12582] Overwrite inplace instead of creating _original files.
[ticket/12582] Add script for strippping ICC profiles from images.
[ticket/12582] Strip away copyrighted ICC profile from images
* bantu/ticket/12582:
[ticket/12582] Fix coding style.
[ticket/12582] Remove set -e due to exiftool not liking 0 byte files.
[ticket/12582] Strip away copyrighted ICC profile
[ticket/12582] Change strip_icc_profiles.sh to only take a single file.
[ticket/12582] Run strip_icc_profiles.sh on Travis CI.
[ticket/12582] Overwrite inplace instead of creating _original files.
[ticket/12582] Add script for strippping ICC profiles from images.
[ticket/12174] Update topic_attachment flag when a post is soft-deleted
* Nicofuma/ticket/12174:
[ticket/12174] Add tests
[ticket/12174] Coding style
[ticket/12174] Remove $update_topic_attachments_flag
[ticket/12174] Don't update the flag for a post without attachment
[ticket/12174] Update the conditions
[ticket/12174] Remove inline assignment
[ticket/12174] Update sql query
[ticket/12174] Revert the changes on $topic_update_array
[ticket/12174] Corrections
[ticket/12174] Update topic_attachment flag when a post is soft-deleted
Actually fix the return status of command cron:run-all
Fix some doc block coding style issue
Fix missing and obsolete file headers
Delete a useless constructor method
PHPBB3-12597
Added a class to the <li> when the <li> represents that there's no
notifications (no_notifications) and
Added a CSS rule that matches the change to the HTML source for when
there's no notifications.
PHPBB3-12604
[ticket/12509] Add an option to set the path of custom style directory (ie: email templates) for extensions
* Nicofuma/ticket/12509:
[ticket/12509] Add example in doc block
[ticket/12509] Add missing ',' in arrays
[ticket/12509] Update calls to set_custom_style in forgotten places
[ticket/12509] Fix path in adm/index.php
[ticket/12509] Fix typo in adm/index.php
[ticket/12509] Fix doc block
[ticket/12509] Fix the call to set_custom_file in adm/index and messenger
[ticket/12509] Update acp custom_style setter
[ticket/12509] Add an option to set the path of custom file for extensions
[ticket/12536] Get Versions Should Not Require Both Stable and Unstable
* Nicofuma/ticket/12536:
[ticket/12536] Restore missing @throws
[ticket/12536] Add test cases with empty versions list
[ticket/12536] Use stable values when unstable are unavailable
[ticket/12536] Update doc block
[ticket/12536] Return empty array if stability unavailable
[ticket/12536] Get Versions Should Not Require Both Stable and Unstable
* ticket/12582:
[ticket/12582] Strip away copyrighted ICC profile
[ticket/12582] Change strip_icc_profiles.sh to only take a single file.
[ticket/12582] Run strip_icc_profiles.sh on Travis CI.
[ticket/12582] Overwrite inplace instead of creating _original files.
[ticket/12582] Add script for strippping ICC profiles from images.
Conflicts:
.travis.yml
[ticket/12155] Construct post buttons using CSS.
* prototech/ticket/12155: (21 commits)
[ticket/12155] Remove use of !important and move reddish color back to .button
[ticket/12155] Reposition the button icons to the left side while we're at it.
[ticket/12155] Get rid of line-height value causing alignment issues in FF.
[ticket/12155] Get rid of the <span> where possible and fix buttons in Safari.
[ticket/12155] Fix misplaced semicolon and ensure that value comparison works.
[ticket/12155] Combine the post and topic/PM button icons into a single sprite
[ticket/12155] Move icon class directly to <a> and use <span> consistently.
[ticket/12155] Remove star hack from padding-right property of .button.
[ticket/12155] Fix tabbing and put one selector per line if string is too long
[ticket/12155] Make opacity transition faster and fix background image paths.
[ticket/12155] Keep the selection method consistent with the one below it.
[ticket/12155] Fade out the buttons when leaving the post.
[ticket/12155] Display the buttons only when hovering the post.
[ticket/12155] Make the buttons bigger on touch devices.
[ticket/12155] Clean up icons.
[ticket/12155] Remove unused font.
[ticket/12155] Remove obsolete images.
[ticket/12155] Use the new .button class as the basis for the post buttons.
[ticket/12155] Move existing button style to a more generic class.
[ticket/12155] Remove obsolete language images.
...
This images embed a non free ICC profile that doesn’t allow
modification:
http://web.archive.org/web/20020603153925/srgb.com/usingsrgb.html
Please use the proposed version stripping away this copyrighted binary
profile, probably embedded by an image software at one time:
exiftool -icc_profile"-<=" phpBB/adm/images/phpbb_logo.png
I’ve checked the resulting image and trust it is identical to the
original.
Some more background on the issue:
https://lists.debian.org/debian-devel/2014/05/msg00339.html
PHPBB3-12582
The code for hooks still exists in Ascraeus for compatibility reasons, however,
it is no longer recommended that they be used. The events system should be
used instead.
PHPBB3-12603
[ticket/12527] Remove translation editor from ACP
* nickvergessen/ticket/12527:
[ticket/12527] Fix "board’s language" vs "boards language"
[ticket/12527] Use a proper language string on confirm screen
[ticket/12527] Remove unnecessary language strings
[ticket/12527] Check whether the language exists
[ticket/12527] Restore missing files and variables check
[ticket/12527] Remove editor from template
[ticket/12527] Remove language file editor form ACP
This was in place for IE7 due to the use of :after for inserting the button
icon. IE7 does not support :after, so the hack removed the extra padding that
made room for the icon. We no longer use :after for the icon, so this is no
longer an issue... not to mention that IE7 is no longer supported.
PHPBB3-12155
[ticket/12570] Fix updating a config with the same value
* nickvergessen/ticket/12570:
[ticket/12570] Keep MySQLi procedural
[ticket/12570] Remove test for affected rows after SELECT
[ticket/12570] Add a test for set_array() and updating with the same value
[ticket/12570] Fix MySQL affectedrows
[ticket/12570] Fix MySQLi affectedrows by specifying MYSQLI_CLIENT_FOUND_ROWS
[ticket/12570] Add a unit test to show broken sql_affectedrows()
[ticket/12570] Add test for updating a config with the same value
We always want the number of matched rows instead of changed rows,
when running an update. So when mysql_info() returns the number of
matched rows we return that one instead of mysql_affected_rows()
PHPBB3-12570
[ticket/12592] Run mysql driver on Travis CI.
* bantu/ticket/12592:
[ticket/12592] Add PHP 5.4 environment using mysql driver.
[ticket/12592] Rename mysql environment to mysqli.
[ticket/12074] Managing extensions doesn't produce any log entry
* Nicofuma/ticket/12074:
[ticket/12074] Update the visibility of the constructor
[ticket/12074] Don't log errors
[ticket/12074] Managing extensions doesn't produce any log entry
[ticket/12270] Current post and topic approval notification message
* marcosbc/ticket/12270:
[ticket/12270] Fixed topic counting bug and tests
[ticket/12270] Fixed tests not working
[ticket/12270] No quote notif and double poster notification fix
[ticket/12270] Fixed tests
[ticket/12270] Fixed rebase conflicts
[ticket/12270] Correct confirm approval message for topics
[ticket/12270] Correcting to follow phpBB coding standards
[ticket/12270] Better structured code and no debug error message
[ticket/12270] Correct notifications for posts/topics now working
[ticket/12270] Reverted templates
[ticket/12270] Correct post&topic approval msg, no template changes
[ticket/12270] Corrent post and topic approval notification message
[ticket/12543] Only take over ENTER and ESC keys when alert box is active.
* prototech/ticket/12543:
[ticket/12543] Only take over ENTER and ESC keys when alert box is active.
[ticket/12275] Fix a bug on the event "core.modify_username_string"
* Zoddo/ticket/12275:
[ticket/12275] Change if (empty) to if (!isset)
[ticket/12275] Fix a bug on the event "core.modify_username_string"
Topics was not correctly counted (the counter didn't count topics
that were re-approved, for example, but only the ones that were
unapproved.
This should also fix the test that wasn't working correctly.
PHPBB3-12270
[ticket/12531] Restore default topic link behavior to subsilver2
* VSEphpbb/ticket/12531:
[ticket/12531] Add some line breaks to really long lines
[ticket/12531] Restore default topic link functionality in subsilver2
[ticket/12585] Don't check the cron on each page load
* Nicofuma/ticket/12585:
[ticket/12585] Use a 5 minutes interval instead of 10 minutes
[ticket/12585] Don't check the cron on each page load
[Ticket/12555] Make use of canonical urls to avoid duplicate content
* nickvergessen/ticket/12555:
[ticket/12555] Add canonical URL for viewtopic
[ticket/12555] Add canonical URL for viewforum
[ticket/12555] Add canonical URl for memberlist mode=viewprofile
[ticket/12555] Allow to set canonical URLs to avoid duplicate content
[ticket/12572] Fix JS error when alert message title is undefined
* rxu/ticket/12572:
[ticket/12572] Fix JS error when alert message title is undefined
[ticket/12551] Float breadcrumbs to the right in RTL languages.
* prototech/ticket/12551:
[ticket/12551] Float breadcrumbs to the right in RTL languages.
[ticket/12550] Prevent last post column from jumping to second line in RTL.
* prototech/ticket/12550:
[ticket/12550] Prevent last post column from jumping to second line in RTL.
[ticket/12549] Hide topic/forum list <dfn> tags in RTL languages.
* prototech/ticket/12549:
[ticket/12549] Hide topic/forum list <dfn> tags in RTL languages.
[ticket/12576] Remove cron from common.php
* Nicofuma/ticket/12576:
[ticket/12576] Retrieve the cron_manager in cron.php if needed
[ticket/12576] Remove cron from common.php
Ticket/12586 Filter files and depth when looking for extensions
* nickvergessen/ticket/12586:
[ticket/12586] Limit depth to 2, we require vendor/extension/ext.php
[ticket/12586] Use dot filter when trying to find available extensions
[task/sami-ascraeus] Add Sami to composer dependencies and build script
* bantu/task/sami-ascraeus:
[task/sami] Establish alphabetical order.
[task/sami] Also ignore ext/ directory.
[task/sami] Replace phpdoctor with sami.
[task/sami] Add sami/sami as a composer development dependency.
[task/sami] Add Sami to composer dependencies and build script
* bantu/task/sami:
[task/sami] Establish alphabetical order.
[task/sami] Also ignore ext/ directory.
[task/sami] Replace phpdoctor with sami.
[task/sami] Add sami/sami as a composer development dependency.
In language/en/common.php:
* Introduce a new language variable 'CONTACT' => 'Contact'
* Add a string argument to lang var 'CONTACT_USER' to avoid an appended
'{USERNAME}' in template.
* Add a string argument to lang var 'SEND_EMAIL_USER' to avoid an appended
'{USERNAME}' in template.
Also fix typos.
PHPBB3-12525
* task/sami:
[task/sami] Replace phpdoctor with sami.
[task/sami] Add sami/sami as a composer development dependency.
Conflicts:
phpBB/composer.json
phpBB/composer.lock
[ticket/12433] Use a different message when nesting of quotes is not allowed
* nickvergessen/ticket/12433:
[ticket/12433] Use a different message when nesting of quotes is not allowed
Changed padding CSS to the notifications' `<li>` and it's
`<a>` (immediate child) so that the `<a>` block uses all
it's container width and height.
To compensate that, I added the padding that was in the
`<li>` to the `<a>`
PHPBB3-12533
* nickvergessen/ticket/12534:
[ticket/12534] Fix filter for functional tests
[ticket/12534] Do not use errorbox for multi steps
[ticket/12534] Do not abuse errorbox for en/disable confirmation of extensions
[ticket/12518] Apply De Morgan to make the conditions easier reasable
* nickvergessen/ticket/12518:
[ticket/12518] Apply De Morgan to make the conditions easier to read
* nickvergessen/ticket/12518:
[ticket/12518] Add event to overwrite the cannot edit condition in posting.php
[ticket/12518] Add event to overwrite the allow edit and delete conditions
[ticket/12529] Use root_path in controller\resolver to check the template dir
* Nicofuma/ticket/12529:
[ticket/12529] Move $phpbb_root_path to the end of the constructor
[ticket/12529] Use root_path in controller\resolver to check the template dir
[ticket/12501] Fix improper display of inline attachments in post report page
* prototech/ticket/12501:
[ticket/12501] Only select attachments uploaded before the post was reported.
[ticket/12501] Parse the reported post message before its attachments.
[ticket/9388] Only display the settings for the selected method in the auth and search ACP pages.
* prototech/ticket/9388:
[ticket/9388] Use "togglable" instead of "toggable"
[ticket/9388] Do not nest the <fieldset> tags in the OAuth settings.
[ticket/9388] Reopen <fieldset> after auth templates.
[ticket/9388] Fix unit tests.
[ticket/9388] Use the new toggle function for the avatar type <select>.
[ticket/9388] Display only the settings for the selected search backend.
[ticket/9388] Display only the settings for the auth method that's selected.
[ticket/9388] Add support for making <select> options able to toggle settings.
[ticket/12407] Allow changing of post_data, etc. at end of posting.php
* marc1706/ticket/12407:
[ticket/12407] Remove merge marker from posting.php
[ticket/12407] Fix incorrect @since line in event
[ticket/12407] Merge @change in doc block of event
[ticket/12407] Assign template variables again after merging develop-ascraeus
[ticket/12407] Add message_parser as passed variable to event
[ticket/12407] Allow changing of post_data, etc. at end of posting.php
Currently it is possible to change search results within the search row scope,
but it should be possible to modify/unset every individual row
within the rowset.
PHPBB3-12524
[ticket/12522] Add function parameter description in guesser interface
* n-aleha/ticket/12522:
[ticket/12522] Add function parameter description in guesser interface
[ticket/12476] Increase assets version on cache purge
* n-aleha/ticket/12476:
[ticket/12476] Label the constructor as public
[ticket/12476] Increase assets also from acp_styles and phpbbcli
[ticket/12476] Increase asset version on cache purge
Ticket/10839 Remove phpunit configuration files
* nickvergessen/ticket/10839:
[ticket/10839] Remove version compare as the php minimum requirement is 5.3.3
[ticket/10839] Fix note about running slow tests and build task
[ticket/10839] Removing phpunit.xml.all
[ticket/10839] Always run functional tests by default
Since a call was added to self::approve_topic(), the poster would
get double-notified about it (even if it was later marked as read).
Also, when creating a new topic with a quote, it would not be
notified, this has also been fixed.
PHPBB3-12270
They are skipped anyway, if $phpbb_functional_url is not configured.
If you want to run tests without functional tests, just append
--exclude-group functional
to your call
PHPBB3-10839
* 'develop-ascraeus' of github.com:phpbb/phpbb: (424 commits)
[ticket/12428] Use the database to store the original version number
[ticket/12493] Add functional test
[ticket/12493] Fix sql query for selection of users that have disabled PM
[ticket/12513] Add asset include support to simple header/footer in ACP
[ticket/12513] Add simple_header head event with support for CSS assets calls
[ticket/12511] Add missing titles for profile fields in members group view
[ticket/12428] Incorrect from version in database update log entry
[ticket/12510] Convert & to & in build_url() when no params are stripped.
[ticket/12402] CAPTCHA plugin migration fails to detect missing plugins
[ticket/12440] Use a more generic approach for replacing the URL.
[ticket/12507] Move the 'require' statement
[ticket/12507] Add console command to purge the cache
[ticket/12421] Rebase and enable tests
[ticket/12421] Don't parse [attachment] tags if user can't view them
[ticket/12325] Use \RecursiveDirectoryIterator
[ticket/12325] Doc blocks
[ticket/12440] Set browser URL to point to specific post when using view=unread
[ticket/12357] Support routes in generate_smilies() function.
[ticket/12459] Change language strings
[ticket/12504] Use local variables where possible
...
Conflicts:
phpBB/posting.php
[ticket/12451] Split lang vars in posting.php for plurals
* Elsensee/ticket/12451:
[ticket/12451] Remove duplicated lang var
[ticket/12451] Use new line to concatenate strings
[ticket/12451] Split TOO_MANY_CHARS vars for plurals
[ticket/12451] Split TOO_FEW_CHARS_LIMIT for plurals
[ticket/12025] Post Preview no longer shows warnings
* Nicofuma/ticket/12025:
[ticket/12025] Apply DeMorgan
[ticket/12025] Fixing the condition....
[ticket/12025] Don't show any error on preview if the message is empty
[ticket/12025] Post Preview no longer shows warnings
[ticket/12325] Generate the list of the deleted files and folders
* Nicofuma/ticket/12325:
[ticket/12325] Use \RecursiveDirectoryIterator
[ticket/12325] Doc blocks
[ticket/12325] Change private function to protected
[ticket/12325] Add visibilities
[ticket/12325] Add files located in deleted dirs
[ticket/12325] Generate the list of the deleted files and folders
[ticket/12440] Set browser URL to point to specific post when using view=unread
* prototech/ticket/12440:
[ticket/12440] Use a more generic approach for replacing the URL.
[ticket/12440] Set browser URL to point to specific post when using view=unread
Conflicts:
phpBB/styles/prosilver/template/viewtopic_body.html
[ticket/12510] Convert & to & in build_url() when no params are stripped.
* prototech/ticket/12510:
[ticket/12510] Convert & to & in build_url() when no params are stripped.
[ticket/12428] Incorrect from version in database update log entry
* Nicofuma/ticket/12428:
[ticket/12428] Use the database to store the original version number
[ticket/12428] Incorrect from version in database update log entry
[ticket/12511] Add missing titles for profile fields in members group view
* rxu/ticket/12511:
[ticket/12511] Add missing titles for profile fields in members group view
[ticket/12513] Add simple_header head event with support for asset calls
* VSEphpbb/ticket/12513:
[ticket/12513] Add asset include support to simple header/footer in ACP
[ticket/12513] Add simple_header head event with support for CSS assets calls
[ticket/12493] Fix sql query for selection of users that have disabled PM
* n-aleha/ticket/12493:
[ticket/12493] Add functional test
[ticket/12493] Fix sql query for selection of users that have disabled PM
This fixes a bug where a user A could not send a PM to user B when both users
allowed other users to send them a PM. More precisely, it fixes the selection
of users that either are inactive or have disabled private messages.
PHPBB3-12493
For memberlist group view in cases the group is presented with the group leader
and group members, for members profile fields titles are missing: Posts,
Joined, Last active and custom profile fields titles.
PHPBB3-12511
[ticket/12421] Don't parse [attachment] tags if user can't view them
* Nicofuma/ticket/12421:
[ticket/12421] Rebase and enable tests
[ticket/12421] Don't parse [attachment] tags if user can't view them
[ticket/12507] Add console command to purge the cache
* Nicofuma/ticket/12507:
[ticket/12507] Move the 'require' statement
[ticket/12507] Add console command to purge the cache
[ticket/12459] Unapproved posts/topics are not correctly handled in feeds
* Nicofuma/ticket/12459:
[ticket/12459] Change language strings
[ticket/12459] Enable related tests
[ticket/12459] Fix: Differentiating unapproved and deleted posts
[ticket/12459] Fix: Soft deleted topics should appear in feeds
[ticket/12459] Fix: the posts were always marked as unapproved
[ticket/11497] Remove 'ext.finder' from services' list
* Nicofuma/ticket/11497:
[ticket/11497] Rename set_ext_finder in find_routing_files
[ticket/11497] Change the date in the package declaration
[ticket/11497] Fix pagination tests
[ticket/11497] Use a mock object to define the root folder for the finder
[ticket/11497] Generate the list of the routes in controller_helper
[ticket/11497] Fix the path for the finder in controller_provider
[ticket/11497] Fix tests
[ticket/11497] Update pagination test
[ticket/11497] Remove 'ext.finder' from services' list
* VSEphpbb/ticket/12332:
[ticket/12332] Add missing semicolon to inline styling
[ticket/12332] Adjust size of mark column where too wide
[ticket/12332] Adjust column widths for responsive changes
[ticket/12332] Restore some changes back to original state
[ticket/12332] Add break-word to fixed width table CSS
[ticket/12332] Accomplish all word creaking in template and CSS
[ticket/12332] Remove width sizing, as it is already set
[ticket/12332] Fix displaying attachments with long file names
The post text displayed to the user is the same as when it was reported, even if
the post was edited afterwards, thus it follows that the attachments would be
the same. This also addresses an issue where the index in the attachment bbcode
no longer matches that of its corresponding attachment when new attachments
are uploaded after the post is reported.
PHPBB3-12501
[ticket/12499] Incorrect call to phpbb\log\log::add() in db:migrate
* Nicofuma/ticket/12499:
[ticket/12499] Incorrect call to phpbb\log\log::add() in db:migrate
* prep-release-3.1.0-b3:
[prep-release-3.1.0-b3] Update phpBB Version for b4 development
[prep-release-3.1.0-b3] Add changelog for 3.1.0-b3
[prep-release-3.1.0-b3] Prepare Changelog
[prep-release-3.1.0-b3] Add migration for 3.1.0-b3
[prep-release-3.1.0-b3] Update version to 3.1.0-b3
When clicking on approving a topic's first post in the MCP to
approve the topic itself, the confirm box dialog asks whether
to approve the post or not, instead of asking to approve the
topic.
To achieve this fix, we just need to count the topics to be
approved and check if it's greater than zero.
PHPBB3-12270
I forgot to put the brackets (so it follows the phpBB coding
standards) and changed "count($topic_id_list) > 0"
to "!empty($topic_id_list)", making the syntax more
comprehensible.
PHPBB3-12270
A variable (that's not essential) has been removed, two if's
has been merged to an if-else control structure. A variable
named topic_ids_list has been renamed to topic_id_list to follow
the naming standard in that file's code.
Also, the debug error has been fixed by changing the topic data
key 'username' to 'post_username' in the array_merge function
in approve_topics().
PHPBB3-12270
This patch should finally work correctly: Add the correct
notification for post/topic approval without touching templates.
This has been done by calling the function approve_topics()
inside the approve_posts() function. It's the simplest way for
this to work correctly. There may be a call to the DB but other
ways (if any), without touching templates, would have been too
messy for a function like this.
PHPBB3-12270
Following the previous commits, this patch removes the changes
done to templates to depend only on code, as suggested by
@nickvergessen.
All previous modifications have been removed, with another one
which checks, in the approve_posts() function, if it is sending a
notification for post approval and it is the first one in the
topic, send notification indicating that the topic has been
approved (and not the post). If not the first post in the topic,
do just as before (send a notification about a newly approved
post).
PHPBB3-12270
When you submit a post with needed approval (say user A), and then
it gets approved by another user (user B), a subscribed user (user C)
to that forum would receive a notification indicating:
-A has replied to topic 'New Topic' in the forum 'xyz'.
The expected result would be:
-A has posted a new topic 'New topic' in the forum 'xyz'.
This has fixed by adding a TOPIC_ID template variable to
mcp_post.html and, in there, depending if the first post is the topic's
first post or not, add a input's with name topic_id_list[] or
post_id_list[] and then the respective value (TOPIC_ID or POST_ID).
PHPBB3-12270
The current event core.posting_modify_template_vars is just ran using dispatch
but it doesn't pass any data from posting.php to the listener. Because of that,
it's not possible to know anything from posting.php and therefore limits the
use cases of this event. This will change it to allow similar actions as with
the event core.modify_posting_parameters.
PHPBB3-12407
; The directory to place generated documentation in. If the given path is
; relative to it will be relative to "source_path".
d="../build/api/"
; Specifies the title to be placed in the HTML <title> tag.
windowtitle="phpBB3"
; Specifies the title to be placed near the top of the overview summary file.
doctitle="phpBB3 Sourcecode Documentation"
; Specifies the header text to be placed at the top of each output file. The
; header will be placed to the right of the upper navigation bar.
header="phpBB3"
; Specifies the footer text to be placed at the bottom of each output file. The
; footer will be placed to the right of the lower navigation bar.
footer="phpBB3"
; Specifies the text to be placed at the bottom of each output file. The text
; will be placed at the bottom of the page, below the lower navigation bar.
;bottom = "This document was generated by <a href="http://peej.github.com/phpdoctor/">PHPDoctor: The PHP Documentation Creator</a>"
; Create a class tree?
;tree = off
; Use GeSHi to include formatted source files in the documentation. PHPDoctor will look in the current doclet directory for a /geshi subdirectory. Unpack the GeSHi archive from http://qbnz.com/highlighter to get this directory - it will contain a php script and a subdirectory with formatting files.
<inputtype="button"class="button2"accesskey="b"name="addbbcode0"value=" B "style="font-weight:bold; width: 30px"onclick="bbstyle(0)"title="{L_BBCODE_B_HELP}"/>
<inputtype="button"class="button2"accesskey="i"name="addbbcode2"value=" i "style="font-style:italic; width: 30px"onclick="bbstyle(2)"title="{L_BBCODE_I_HELP}"/>
<inputtype="button"class="button2"accesskey="u"name="addbbcode4"value=" u "style="text-decoration: underline; width: 30px"onclick="bbstyle(4)"title="{L_BBCODE_U_HELP}"/>
<inputtype="button"class="button2"accesskey="b"name="addbbcode0"value=" B "style="font-weight:bold; width: 30px"onclick="bbstyle(0)"title="{L_BBCODE_B_HELP}"/>
<inputtype="button"class="button2"accesskey="i"name="addbbcode2"value=" i "style="font-style:italic; width: 30px"onclick="bbstyle(2)"title="{L_BBCODE_I_HELP}"/>
<inputtype="button"class="button2"accesskey="u"name="addbbcode4"value=" u "style="text-decoration: underline; width: 30px"onclick="bbstyle(4)"title="{L_BBCODE_U_HELP}"/>
Some files were not shown because too many files have changed in this diff
Show More
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.