2733 Commits

Author SHA1 Message Date
Andrew Nicols
fa197fbf09 Merge branch 'MDL-68099-master' of git://github.com/marinaglancy/moodle 2020-05-26 11:29:48 +08:00
Andrew Nicols
17238ab079 MDL-68388 grade: Tidy comments and whitespace 2020-05-26 10:15:52 +08:00
Marcus Boon
f1f5ba36ad MDL-68388 core_grades: Use MUC for grade letters
In the get_grade_letters there is a static variable that is used
to cache grade letters, we should use MUC for this so that it is
reset properly between unit tests.
2020-05-26 09:06:50 +10:00
Andrew Nicols
6c0ffdd7ff Merge branch 'MDL-68783-master' of git://github.com/junpataleta/moodle 2020-05-22 11:21:47 +08:00
Jun Pataleta
0763480b33 MDL-68783 core_grades: Fix outcome page's add/remove button styles
* Applied proper styles of btn-secondary.
* Added some vertical spacing between the buttons by enclosing them in
divs with 'm-y-1' class instead of just a br tag.
2020-05-20 13:12:58 +08:00
Marina Glancy
5b529aca15 MDL-68333 testing: trigger user_created event in user generator 2020-05-19 19:11:54 +02:00
Marina Glancy
ae0218624f MDL-68099 gradereport_grader: prevent exception without groups 2020-05-18 15:18:30 +02:00
Andrew Nicols
29c5fafff5 MDL-66109 js: Fix Shifter linting issues 2020-05-11 11:07:49 +08:00
Andrew Nicols
149d80e819 MDL-66109 behat: Fix Example usage in feature files
The gherkin-lint package now understands the use of "Examples" and
requries that their indentation be correct and consistent.

This change sets the indentatation for these to:

    "Examples": 4,
    "example": 6,

This is in-line with the examples given in the offical Cucumber/Gherkin
documentation at
https://cucumber.io/docs/gherkin/reference/#scenario-outline whereby the
Examples and individual rows of the Examples table are children of the
Scenario outline.

This is contrary to the default for Gherkin-lint which places them as
top-level nodes with an indentatio of 0, and 2 respectively.
2020-05-11 10:55:58 +08:00
Jun Pataleta
08103b0a64 MDL-68355 gradingform_guide: Improve lang strings 2020-05-07 11:49:53 +08:00
Jake Dallimore
1b4e6b3826 Merge branch 'MDL-68355-master' of git://github.com/junpataleta/moodle 2020-05-06 08:36:06 +08:00
Jun Pataleta
2a858c2d5e Merge branch 'MDL-68404-master' of git://github.com/lucaboesch/moodle 2020-04-30 13:33:45 +08:00
Luca Bösch
e944a8f86d MDL-68404 gradingform_rubric: Style "Add level" button. 2020-04-28 14:06:49 +02:00
Helen Foster
1fce3f52ac MDL-68434 lang: Import fixed English strings (en_fix)
Significant string changes:

* pluginnamesummary,qtype_ddimageortext and
  pluginnamesummary,qtype_ddmarker - Note about the question type not
  being accessible to visually impaired users

* addresourceoractivity,core - Removing 'resource' as the new activity
  chooser doesn't have resource types separated
2020-04-28 14:01:20 +02:00
Jun Pataleta
3c28246234 MDL-68355 gradingform_guide: Fix accessibility issues
* Add sr-only label for criterion information.
* Add sr-only label for frequently used comments picker button.
* Removed unused string grade_help.
* Fixed tags for hidden help texts, changing them from <small> to <span>
* Added aria-label for the score and additional comments fields so that
  the user would know which criterion they are currently working on.
* Added score_help and remark_help lang strings for more description
  for the score and additional comments fields.
* Remove text-muted class for additional comments' field label to avoid
  colour contrast issues.
2020-04-24 15:05:09 +08:00
Shamim Rezaie
8a944856eb MDL-68343 gradereport_singleview: Remove adjacent links to the same URL 2020-04-22 04:30:53 +10:00
Shamim Rezaie
976dac3fd1 MDL-68343 gradereport_singleview: Use caption instead of summary
The summary attribute on the table element is obsolete.
2020-04-22 04:30:53 +10:00
Shamim Rezaie
4e9b0c4278 MDL-68343 gradereport_singleview: fix empty links 2020-04-22 04:30:53 +10:00
Shamim Rezaie
1031303a54 MDL-68343 gradereport_singleview: Only output label tag if label exists
This also fixes the issue of having multiple form labels for a single
element.
2020-04-22 04:30:53 +10:00
Jwalit Shah
c74ccbcbaa MDL-66200 gradebook: check selected feedback option when importing data 2020-04-09 11:01:15 +10:00
Tim Hunt
1dcd0d3499 MDL-68233 renderers/block: remove illegal uses of $PAGE and $OUTPUT 2020-03-29 15:34:26 +01:00
Eloy Lafuente (stronk7)
d950188c19 Merge branch 'MDL-68061-master' of git://github.com/mickhawkins/moodle 2020-03-11 22:56:13 +01:00
Marina Glancy
99b3ce9669 MDL-56287 gradereport_history: Separate groups queries improved 2020-03-04 11:46:52 +01:00
Jun Pataleta
29ddc8ff32 MDL-56287 gradereport_history: Show users from groups that can be viewed 2020-03-04 11:46:52 +01:00
Michael Hawkins
b34f2c75c9 MDL-68061 gradereport_history: Restrict per page config value to int 2020-02-27 13:38:37 +08:00
Helen Foster
a753f4f9a1 MDL-67979 lang: Import fixed English strings (en_fix)
Significant string changes:

* configcustommenuitems,core_admin - corrected example
* custommenuitems_desc,tool_mobile - fallback behaviour of custom menu
  items in the app
2020-02-25 12:21:09 +01:00
Luca Bösch
8f2a32ed95 MDL-67617 gradereport_singleview: Style the form element with bs classes 2020-01-09 16:51:18 +01:00
Andrew Nicols
5e34719d7e Merge branch 'MDL-65948-master' of git://github.com/junpataleta/moodle 2020-01-08 08:50:03 +08:00
Jun Pataleta
e4e9e56882 MDL-65948 core_grade: Use category names as master checkbox labels
Use the name of the grade categories as label to distinguish master
checkboxes from regular ones.
2019-12-30 14:13:35 +08:00
Jun Pataleta
2f848616c7 MDL-65948 core_grade: Use new core/checkbox-toggleall 2019-12-30 14:13:35 +08:00
Eloy Lafuente (stronk7)
a0ba8feef6 Merge branch 'MDL-67527-master-enfix' of git://github.com/mudrd8mz/moodle 2019-12-29 23:26:52 +01:00
Adrian Greeve
42d7f7f9e4 Merge branch 'MDL-65809-master' of git://github.com/sarjona/moodle 2019-12-24 14:53:03 +08:00
Adrian Greeve
f00542c485 Merge branch 'MDL-66999-master' of git://github.com/bmbrands/moodle 2019-12-23 14:26:39 +08:00
Sara Arjona
a26cfe71d3 MDL-65809 upgrade: clean < 3.5.0 upgrade steps
This just deletes all the upgrade steps previous to 3.5.0. Some
small adjustments, like tweaking globals can also be applied
when needed.

Also includes an upgrade step to prevent upgrading from any
version < 2018051700 (v3.5.0) as anti-cheating measure.

Previous commits have removed/deprecated all the upgradelib functions
not used anymore in codebase. Deletion has been documented in corresponding
upgrade.txt files:

- upgrade_fix_block_instance_configuration()
- upgrade_theme_is_from_family(), upgrade_find_theme_location()
and linkcoursesectionsupgradescriptwasrun setting
- upgrade_block_positions
- upgrade_fix_config_auth_plugin_names()
 and upgrade_fix_config_auth_plugin_defaults()
- format_xxx_upgrade_remove_numsections(), format_xxx_upgrade_hide_extra_sections()
and format_xxx_upgrade_add_empty_sections()
- filter_mathjaxloader_upgrade_cdn_cloudflare()
and filter_mathjaxloader_upgrade_mathjaxconfig_equal()
- get_assignments_with_rescaled_null_grades()

These have been kept because continue being used by restore:

- \core\task\refresh_mod_calendar_events_task
2019-12-20 12:20:43 +01:00
David Mudrák
6aff025cad MDL-67527 lang: Propagate the string fixes to Behat and other places 2019-12-18 21:23:46 +01:00
Helen Foster
824c87f370 MDL-67527 lang: Import fixed English strings (en_fix) 2019-12-18 21:23:46 +01:00
Mathew May
97ba6091ab MDL-67165 core_grade: Add the grader name to webservices 2019-12-17 10:46:02 +08:00
Bas Brands
cacf692578 MDL-66999 theme_boost: @extend remove extends for grades 2019-12-12 11:27:58 +01:00
Luca Bösch
b7e3c2495f MDL-40360 gradingform_rubric: remove unused class 'label' for a label. 2019-11-30 09:42:44 +01:00
Eloy Lafuente (stronk7)
8e98f82f12 MDL-67049 grading: options are array, ensure json_decode() knows it
By default json_decode() returns object for associative arrays. That
was not a problem till now becuause array_key_exists() worked with
objects too. But in php74 that emits a warning.

So we need to ensure that the information arriving to it is
an array, allowing everything to continue working ok.
2019-11-22 01:40:18 +01:00
Eloy Lafuente (stronk7)
492d047d11 MDL-67284 upgrade: add 3.8.0 separation line to all upgrade scripts 2019-11-17 11:40:19 +01:00
Andrew Nicols
fb803f8854 Merge branch 'MDL-67268-master' of git://github.com/mihailges/moodle 2019-11-15 12:08:33 +08:00
Mihail Geshoski
c7cb3b297b MDL-67268 mod_forum: Group and label radio buttons in forum grader 2019-11-15 12:05:59 +08:00
Eloy Lafuente (stronk7)
d5be859063 MDL-67199 versions: bump all versions and requires near release
version = 2019111800 release version
requires= 2019111200 current beta (week7roll1) version
2019-11-12 17:57:08 +01:00
Andrew Nicols
49d5920ac6 MDL-66906 gradingform_rubric: Add back missing field 2019-11-12 21:04:54 +08:00
Mathew May
07d8669dbf MDL-66906 mod_forum: Show learners their grades in a Modal 2019-11-12 16:17:04 +08:00
Andrew Nicols
0e32b5ae41 MDL-66360 grading: Validate notifyuser 2019-11-12 16:00:50 +08:00
Andrew Nicols
656f2e5a38 MDL-66360 grade: Correct argument order in params 2019-11-12 15:59:53 +08:00
Eloy Lafuente (stronk7)
6b69013461 MDL-66360 grade: whitespace fix 2019-11-11 10:49:31 +01:00
Andrew Nicols
9359533972 MDL-66360 forum: Fix unit tests in integration 2019-11-11 17:38:02 +08:00