114053 Commits

Author SHA1 Message Date
Andrew Nicols
7fc931cdd8
Merge branch 'MDL-81698' of https://github.com/stronk7/moodle 2024-05-28 10:10:39 +08:00
Huong Nguyen
f1528765a5
Merge branch 'MDL-81915' of https://github.com/AnupamaSarjoshi/moodle 2024-05-28 08:57:26 +07:00
Andrew Nicols
e8f8a4c494
Merge branch 'MDL-74582' of https://github.com/paulholden/moodle 2024-05-28 09:52:14 +08:00
Andrew Nicols
d69333acc3
MDL-72786 core: Style fix on upgrade notes 2024-05-28 09:49:50 +08:00
Andrew Nicols
f8ba03ce1a
Merge branch 'MDL-72786' of https://github.com/paulholden/moodle 2024-05-28 09:43:32 +08:00
Andrew Nicols
d6d795cd0f
MDL-81872 course: Coding style improvements 2024-05-28 09:25:39 +08:00
Andrew Nicols
455cdd8c5b
Merge branch 'MDL-81872-main' of https://github.com/sarjona/moodle 2024-05-28 09:20:14 +08:00
Andrew Nicols
fe3f6350d9
Merge branch 'MDL-78942' of https://github.com/paulholden/moodle 2024-05-28 09:00:35 +08:00
Sara Arjona
47cd442dc9
MDL-81872 course: Fix behat errors after improving reset 2024-05-27 16:18:54 +02:00
Sara Arjona
cb72a08193
MDL-81872 course: Improve the summary page for reset 2024-05-27 16:18:54 +02:00
Sara Arjona
22cc975705
MDL-81872 course: Improve wording and workflow for reset 2024-05-27 16:18:54 +02:00
Sara Arjona
b2e325836b
MDL-81872 workshop: Fix coding style 2024-05-27 16:18:54 +02:00
Sara Arjona
b25d60526e
MDL-81872 wiki: Fix coding style 2024-05-27 09:23:25 +02:00
Sara Arjona
dd5a82ede7
MDL-81872 book: Fix coding style 2024-05-27 09:23:25 +02:00
Sara Arjona
727e167946
MDL-81872 lesson: Fix coding style 2024-05-27 09:23:25 +02:00
Sara Arjona
4a02c6de5d
MDL-81872 glossary: Fix coding style 2024-05-27 09:23:24 +02:00
Sara Arjona
2d595135b6
MDL-81872 forum: Fix coding style 2024-05-27 09:23:24 +02:00
Sara Arjona
8866f34208
MDL-81872 data: Fix coding style 2024-05-27 09:23:24 +02:00
Sara Arjona
278fab6a50
MDL-81872 choice: Fix coding style 2024-05-27 09:23:24 +02:00
Sara Arjona
9bfc49c5bc
MDL-81872 chat: Fix coding style 2024-05-27 09:23:24 +02:00
Sara Arjona
b77c6c5c21
MDL-81872 feedback: Fix coding style 2024-05-27 09:23:24 +02:00
Sara Arjona
6c78f19365
MDL-81872 assign: Fix coding style 2024-05-27 09:23:24 +02:00
Sara Arjona
c088bec544
MDL-81872 course: Fix coding style 2024-05-27 09:23:24 +02:00
Eloy Lafuente (stronk7)
76e41b936d
MDL-81698 phpunit: Convert some skipped tests into useful ones
After some tests, it seems that we can safely cover
phpunit_util::reset_all_data() executing it within
own basic_test self tests.

That way we can confirm that the reset code is doing its job
and detecting unexpected changes at various levels (database,
globals, ...).

Note that, in order to catch the E_USER_WARNINGS, for PHPUnit 9.6
and up, we have to convert them to exceptions, because the notice/
warning/error expectations have been deprecated and will be removed
in PHPUnit 10. So we are using a trick, already used also by
advanced_test. And, no matter that we are repeating the trick
a few times, that's ok in order to have all its uses controlled.
2024-05-25 17:19:44 +02:00
Eloy Lafuente (stronk7)
018e6e1fc8
MDL-81698 phpunit: Apply various fixes towards 1by1 execution
The changes here are heterogeneous:
- Include stuff that is not available (other test has included it).
  Sometimes local to a unit test, others in setupBeforeClass() or
  globally, ... depends on every case.
- Rename some tests (namespaces, test name, ...) towards getting it
  running.
- Amend small bits here and there.

Important note: I've left any "cosmetic" warning out from the
changes, only a few errors (like long array syntax) have been fixed.
2024-05-25 17:19:44 +02:00
Eloy Lafuente (stronk7)
6fe0e66d06
MDL-81698 phpunit: Uncomment some tests and make them skipped
There are a few tests in core that are commented since the
beginning. That's not useful at all, so with this commit we
are un-commenting them instead.

Note that this is an initial step to have them back with skipped
outcome. Later in this issue we'll decide about to keep them or
completely remove them (each test can have a different outcome).
2024-05-25 17:19:43 +02:00
Eloy Lafuente (stronk7)
3e486ad9ca
MDL-81698 phpunit: New workflow to run tests 1by1 @ GitHub
This workflow just finds all the individual
tests available in core (all the test_ methods
in _test.php file) and runs them one by one,
with a total isolation, because each one is
executed by a different PHPUnit invocation..

Any test ending with error, will be reported
as part of the output.

Note that we are not using PHPUnit's own
isolation here, just running them one by one.
2024-05-25 17:19:43 +02:00
Paul Holden
c4b06e48a6
MDL-72786 report_eventlist: final removal of deprecated event methods. 2024-05-24 22:27:03 +01:00
Anupama Sarjoshi
f0168354b6 MDL-81915 admin: Fix test_admin_output_new_settings_by_page unit test 2024-05-24 11:15:38 +01:00
Ilya Tregubov
d32844ce29 weekly release 4.5dev 2024-05-24 10:51:52 +08:00
Ilya Tregubov
8f9e93f5a3 NOBUG: Add upgrade notes 2024-05-24 10:51:52 +08:00
Ilya Tregubov
9d38dcbca4 NOBUG: Fixed file access permissions 2024-05-24 10:51:30 +08:00
Andrew Nicols
a4484911bf
MDL-80741 mod_assign: Move upgrade notes 2024-05-24 09:25:29 +07:00
Huong Nguyen
48bc966a59
Merge branch 'MDL-81914-main' of https://github.com/andrewnicols/moodle 2024-05-23 11:01:38 +07:00
Huong Nguyen
1776003d39
MDL-81407 core_question: Update upgrade.txt file to document new upgrade note 2024-05-23 10:37:46 +07:00
Huong Nguyen
f2af8e005f
Merge branch 'MDL-81407' of https://github.com/AnupamaSarjoshi/moodle 2024-05-23 10:33:36 +07:00
Huong Nguyen
22859fa326
Merge branch 'MDL-81992' of https://github.com/timhunt/moodle 2024-05-23 09:44:55 +07:00
Huong Nguyen
571d3d8821
Merge branch 'MDL-81862' of https://github.com/paulholden/moodle 2024-05-23 08:47:27 +07:00
Tim Hunt
38227bbcc2 MDL-81992 question bank: disable create question button until ready
Previously, you could click the button before it was ready, and that
just led to an error, which was very silly usability.
2024-05-22 16:11:08 +01:00
Shamim Rezaie
633fde271f Merge branch 'MDL-80741-main' of https://github.com/mihailges/moodle 2024-05-22 01:28:46 +10:00
Mihail Geshoski
d5e7960139 MDL-80741 mod_assign: Remove 'none' from 'attemptreopenmethod' setting
The default option "ASSIGN_ATTEMPT_REOPEN_METHOD_NONE" for the
"attemptreopenmethod" setting, which disallows multiple attempts at the
assignment, has been removed. This option was unnecessary because
limiting attempts to 1 through the "maxattempts" setting achieves the
same behavior.
Apart from removing this setting option (including removal of usage in
code and updating existing data in the DB), these changes include:
- Introducing a more effective progressive disclosure by allowing the
  "maxattempts" setting to control the visibility of the
  "attemptreopenmethod" setting in the form.
- String improvements to the labels and help text for the "maxattempts"
  and "attemptreopenmethod" settings
- Changing the default value of the "maxattempts" setting from
  "unlimited" to "1"
2024-05-21 23:05:18 +08:00
Huong Nguyen
5d5726d86d
Merge branch 'MDL-81652-main' of https://github.com/lucaboesch/moodle 2024-05-21 17:33:30 +07:00
Huong Nguyen
b4783d39dd
Merge branch 'MDL-76765-main' of https://github.com/lucaboesch/moodle 2024-05-21 17:28:23 +07:00
Huong Nguyen
37c79e282d
MDL-74581 grade: Update upgrade.txt file to document new upgrade note 2024-05-21 16:51:30 +07:00
Huong Nguyen
5fb2dd40fa
Merge branch 'MDL-74581' of https://github.com/paulholden/moodle 2024-05-21 16:45:35 +07:00
Huong Nguyen
eaf2fe4f8a
Merge branch 'MDL-81538-main' of https://github.com/rezaies/moodle 2024-05-21 16:31:35 +07:00
Huong Nguyen
1de7c31ddd
MDL-81125 core: Fix illegal whitespace 2024-05-21 15:42:48 +07:00
Huong Nguyen
1b02c68e72
MDL-81125 core: Fix minor typos 2024-05-21 15:35:15 +07:00
Huong Nguyen
bd9631bda5
Merge branch 'MDL-81125-main-alt' of https://github.com/andrewnicols/moodle 2024-05-21 15:33:09 +07:00
Paul Holden
62783eeef2
MDL-81862 mod_assign: add activity field files for backup/restore. 2024-05-21 09:05:58 +01:00