1292 Commits

Author SHA1 Message Date
Abdul Malik Ikhsan
1e667b454f
[CI] Add PHP 8.0 to Github actions tests (#4779) 2020-12-05 12:10:44 +01:00
github-actions[bot]
c7d2af6966
[automated] Apply Coding Standard (#4784)
Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>
2020-12-05 11:07:25 +01:00
Tomas Votruba
520b8a9a85
[DeadDocBlock] decouple return and param rules (#4782)
* decopule return and parma rules

* enable in CI

* cleanup

* protected class-string vs string
2020-12-05 00:31:05 +00:00
Tomas Votruba
5201e949a1
[PHPStanExtensions] Add ForbiddenMethodCallOnTypeRule + move from docComment and Comments to PhpDocInfo (#4780)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-05 00:22:12 +01:00
Abdul Malik Ikhsan
24dda87f60
[Downgrade PHP 7.1] Fixes #4196 Add DowngradePipeToMultiCatchExceptionRector (#4776)
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
2020-12-04 15:07:54 +01:00
Abdul Malik Ikhsan
87af56c3fa
[DX] Fixes #4777 Update ConfiguredCodeSample to CodeSample for no configuration in Rector class (#4778) 2020-12-04 15:05:06 +01:00
Abdul Malik Ikhsan
d3a6a1db28
[Downgrade PHP 8.0] Add DowngradeClassOnObjectToGetClassRector (#4772) 2020-12-04 15:00:52 +01:00
Abdul Malik Ikhsan
0308cfd63b
[PHPstan] Fixes #4731 Skip RemoveNonExistingVarAnnotationRector on comment in next line of @var (#4775) 2020-12-04 12:31:49 +01:00
Leonardo Losoviz
5257f3ae3e
Downgrade PHP 7.4 contravariant argument type (#4770)
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
2020-12-04 12:30:37 +01:00
Leonardo Losoviz
1bb4e06fd8
Downgrade PHP 7.4 Covariant return types - Handle also interfaces (#4774) 2020-12-04 12:28:32 +01:00
Tomas Votruba
09f17a7b64
[Downgrade] [PHP 8.0] Add DowngradePropertyPromotionToConstructorPropertyAssignRector (#4762)
* [Downgrade] [PHP 8.0] Add DowngradePropertyPromotionToConstructorPropertyAssignRector

* fix parent

* various fixes for PHP 8.0 tests

* [ci-review] Rector Rectify

* Update rules/downgrade-php80/tests/Rector/Class_/DowngradePropertyPromotionToConstructorPropertyAssignRector/DowngradePropertyPromotionToConstructorPropertyAssignRectorTest.php

Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-03 13:27:24 +00:00
Tomas Votruba
ca5399b249
[Downgrade] Fix file matching for ChangePhpVersionInPlatformCheckRector (#4763) 2020-12-03 12:27:00 +00:00
Abdul Malik Ikhsan
0e421247e8
[Solid] Skip ChangeAndIfToEarlyReturnRector on nested if in loop (#4757)
* ChangeAndIfToEarlyReturnRector: added failing test

* fix test warning

* rename test

* rename test

* try to fix the issue

* Update skip_nested_if_in_loop.inc

* rename fixture

* rename fixture

* extracted loop-types into constant

* fix

* refactor

* take Else_/ElseIf_ into account

* Update ChangeAndIfToEarlyReturnRector.php

* [Solid] Skip ChangeAndIfToEarlyReturnRector on nested if in loop, Closes #4728

* [ci-review] Rector Rectify

Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
Co-authored-by: Markus Staab <markus.staab@redaxo.de>
Co-authored-by: Markus Staab <maggus.staab@googlemail.com>
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-03 09:20:59 +01:00
Leonardo Losoviz
36ed4ee6a2
Downgrade PHP 7.4 covariant return type (#4755)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-02 18:47:51 +01:00
Tomas Votruba
0b9c72ea9a
[PHP 8.0] Fix property removal in property promotion, if they have doctrine annotations (#4752)
* [PHP 8.0] Keep doctrine proeprty with annotations on property promotion

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-02 14:26:14 +00:00
Michal Lulco
7fb280a739
Fix CallTypeAnalyzer when methodName is null (#4753)
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
2020-12-02 15:14:22 +01:00
Krystian Marcisz
2eba542760
Fix UnusedForeachValueToArrayKeysRector on objects (#4750) 2020-12-02 14:09:35 +01:00
Abdul Malik Ikhsan
7dc7763585
[DeadCode] Fixes #4663 Handle RemoveEmptyMethodCallRector on parent is Assign (#4746) 2020-12-02 12:44:56 +01:00
Tomas Votruba
42dae6a86a
[DeadCode] Fix RemoveDeadConstructorRector (#4751)
* [DeadCode] Fix RemoveDeadConstructorRector

* [DeadCode] Fix RemoveUnusedParameterRector in property promotion
2020-12-02 10:38:59 +00:00
Tomas Votruba
132062acf3
[DeadCode] Fix dead method in property promotion (#4749)
* [DeadCode] Fix dead method in property promotion

* bump workflows PHP version to 7.2, to respect symplify bump

* allow non-existing attributes in tests
2020-12-02 10:15:39 +00:00
Tomas Votruba
f38dc68649
[Naming] Skip union type to resolve param name (#4742) 2020-12-01 15:57:41 +01:00
TomasVotruba
275ef81062 fix missing deafault replace empty string 2020-12-01 15:00:00 +01:00
Tomas Votruba
2030badc19
[PHP 8.0] Add nette utils strings replace, static fixes (#4741)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-12-01 14:52:24 +01:00
Tomas Votruba
267989bb05
[Docs] Add docblock docs (#4740)
* skip getUser() as the method is final

* drop comment along with removed node, as in other removed nodes

* [docs] add doc block docs
2020-12-01 01:09:50 +00:00
Abdul Malik Ikhsan
d0cb30f9ed
[DX] Fixes #4724 Filename too long, rename ChangeQuerySetParametersMethodParameterFromArrayToArrayCollectionRector to ChangeSetParametersArrayToArrayCollectionRector (#4729) 2020-11-30 11:11:11 +01:00
Abdul Malik Ikhsan
4087029cb9
[BetterStandardPrinter] Fixes #4691 Donot convert string literal comment (#4727)
* [BetterStandardPrinter] Fixes #4691 Donot change convert string literal comment

* handle spacing

* [ci-review] Rector Rectify

* fix conflict

* [ci-review] Rector Rectify

* try --debug

* Trigger notification

* phpstan

* phpstan

Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-30 09:51:11 +00:00
Tomas Votruba
3d721e8ca8
drop symfony\process for single call (#4735) 2020-11-29 18:47:29 +01:00
Tomas Votruba
79f3611dc9
remove ci-detector, make no-progress-bar api compatible with other CI tools (#4734) 2020-11-29 18:37:13 +01:00
Tomas Votruba
d962e3f6b0
[Downgrade] Add composer platform check (#4721) 2020-11-28 00:16:19 +01:00
Tomas Votruba
dade40765a
trait refactoring (#4718)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-27 22:29:40 +01:00
Tomas Votruba
499d452f99
Various improvements (#4717) 2020-11-27 21:39:42 +01:00
Markus Staab
ae0d38e1f0
added failing ChangeIfElseValueAssignToEarlyReturnRector test, regarding lost comments (#4698) 2020-11-27 17:38:07 +01:00
Markus Staab
04abc7af5c
create LostCommentBeforeElseIf failing test (#4697) 2020-11-27 17:33:16 +01:00
Tomas Votruba
0eb6e29176
drop MinimalVersionChecker, is checked by composer itself (#4715)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-27 17:32:38 +01:00
Markus Staab
972e0457cb
ChangeAndIfToEarlyReturnRector: added a failing testcase for continue-in-foreach (#4696)
* added a failing testcase

* initial try to fix 4693

* fix existing if_in_foreach test with wrong expected result

* Restore if_in_foreach.php.inc

* adusted wrong test expectation of if_in_foreach.php

* use betterNodeFinder->findFirstParentInstanceOf

* fix test expectation in if_in_foreach fixture

* fixed method name which was misleading

* fix variable name

* adjust impl

* Restore if_in_foreach.php.inc

* rm unused use

* fix impl
2020-11-27 16:10:48 +00:00
Markus Staab
fe47bc2cc7
ChangeAndIfToEarlyReturnRector: fix test expectation in if_in_foreach fixture (#4711)
* fix test expectation in if_in_foreach fixture

* fixed method name which was misleading

* fix variable name

* adjust impl
2020-11-27 13:59:56 +00:00
Tomas Votruba
f718d90cd2
remove extra space after declare, if there already is one (#4710) 2020-11-27 12:39:01 +00:00
Tomas Votruba
51ab276d57
[Downgrade PHP 7.1] feature/downgrade iterable pseudo type (#4706)
* [Downgrade PHP 7.1] iterable pseudo-type

* fix PHP version type

* cleanup

* static fixes

Co-authored-by: Norbert Orzechowicz <norbert@orzechowicz.pl>
2020-11-27 12:00:56 +00:00
Markus Staab
74a17fde01
ArrayThisCallToThisMethodCallRector: use betterNodeFinder->findFirstParentInstanceOf() (#4707) 2020-11-27 11:43:53 +00:00
Tomas Votruba
080e5cbe00
use symplify/skipper (#4689) 2020-11-26 23:09:21 +01:00
Tomas Votruba
0993088cda
[SymfonyPhpConfig] Use Symplify package instead + simplify set validation (#4694)
* [SymfonyPhpConfig] Use Symplify package instead

* [SymfonyPhpConfig] Drop forgotten custom-jobs Rectors

* [CI] simplify set validation

* from inline functions to Static class

* cleanup

* decouple rector.php to allow static analysis and coding standards
2020-11-26 16:44:27 +00:00
Abdul Malik Ikhsan
35d8693187
[NetteUtilsCodeQuality] Fixes #4686 Add SubstrMinusToStringEndsWithRector (#4687)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-26 13:33:51 +01:00
Tomas Votruba
8e7c4bfc96 [CI] do not push to forks 2020-11-24 21:30:17 +00:00
HDVinnie
3fc5163f01
update: drop migrify/php-config-printer for symplify/php-config-printer (#4684)
* update: composer.json

- Package migrify/php-config-printer is abandoned. Using symplify/php-config-printer instead.

* update: migrify to symplify

* update: composer.json

Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>

Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
2020-11-24 16:14:21 +00:00
Abdul Malik Ikhsan
a38debb672
[DX] Fixes #4205 Change phpversion from string to php constant int type (#4679)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-24 16:32:49 +01:00
Abdul Malik Ikhsan
1c9cfafdda
[Solid] Fixes #4677 Skip MoveVariableDeclarationNearReferenceRector on multiple usage in Switch -> cases (#4678) 2020-11-23 22:23:44 +01:00
Tomas Votruba
da6d703687
Improve Blade class renames (#4676)
* [Console] Use single point of command naming

* use blade in process command

* filter out blade templates from PHP files

* make test process blade as non php file

* add failing test

* remove duplicated tests

* rename php to php.inc suffix to make it skip to CI tools

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-23 19:16:48 +00:00
Tomas Votruba
cb57430655
[Renaming] Add renaming support for blade.php templates in Laravel (#4672)
* [CI] fix monorepo split

* naming, add blade.php suffix

* [Renaming] Add class rename support for laravel blade templates

* skip test fixture
2020-11-23 11:35:42 +00:00
Abdul Malik Ikhsan
715b616ada
[Solid] use Variable node type for for MoveVariableDeclarationNearReferenceRector (#4670)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-23 11:40:29 +01:00
Tomas Votruba
131357aac6
[CodingStyle] Fix lowercase misses in importing, decouple ImportSkipper to collector with ClassNameImportSkipVoters (#4665)
* add import doc block test

* [CodingStyle] Decouple ImportSkipper to ClassNameImportSkipVoters

* drop same short namespace check, not used anywhere
2020-11-20 13:37:53 +00:00