Resolves a bug by first initializing in the AJAX callback `WP_Plugin_Dependencies::check_plugin_dependencies_during_ajax()`.
More details:
[57658] removed auto-deactivation and bootstrapping logic from the Plugin Dependencies feature. In doing so, initialization calls were added to various locations in Core to ensure dependencies were detected and ready to be checked. However, an initialization call was missed in the AJAX callback before checking plugin dependencies.
This means that a plugin's dependencies may not be detected, and lead to a false positive, which in turn allows the user to click Activate only to see a failure message.
Follow-up to [57658].
Props kevinwhoffman, costdev, afragen.
Fixes#61294.
git-svn-id: https://develop.svn.wordpress.org/trunk@58252 602fd350-edb4-49c9-b593-d223f7449a82
Restores the Activate button's `href` native behavior by changing the AJAX activation handler introduced in 6.5.0. It restores the pre-6.5 behavior of clicking the "Activate" button, i.e. navigates the user to the button's `href` (i.e. to the `plugins.php` UI).
Why?
Feedback was given after shipping [57545] in 6.5.0 (but was unknown during the development and testing cycles) revealed significant impacts for plugins who's users valued the onboarding / configuration experiences.
6.5.3's [58081] and [58083] added a new user action / step to the workflow. Though helpful, it did not fully resolve the impacts.
For the minor, this commit seeks to restore only the "Activate" button's `href` pre-6.5 native behavior to resolve the regression.
The next phase of the Add Plugins workflow can then continue in a major release to gain the benefits of a full major to move it from ideation through the development phases. (See #61040). The questions of redirect, how / should configuration be in the workflow, etc. can best be explored and experimented with in a major.
Follow-up to [57545], [58081], [58083].
Props costdev, jorbin, hellofromTonya, afragen, kevinwhoffman, azaozz, adrianduffell, beaulebens, hmbashar, illuminea, ironprogrammer, jjj, lopo, louiswol94, mikachan, nerrad, mukesh27, peterwilsoncc, pooja1210, smub, swissspidy.
Fixes#61319.
See #22316, #60992.
git-svn-id: https://develop.svn.wordpress.org/trunk@58250 602fd350-edb4-49c9-b593-d223f7449a82
Remove duplicate CSS from the `media-views.css` file. Follow up to [50829].
Props afercia, joedolson, shailu25.
Fixes#60499.
git-svn-id: https://develop.svn.wordpress.org/trunk@58249 602fd350-edb4-49c9-b593-d223f7449a82
Handle `$preferred_ext` arguments that are passed with minor errors in formatting, such as incorrect casing or missing `.`. Add unit tests to verify that an omitted period on an otherwise correct extension is accepted. Follow up to [57687].
Props sabernhardt, joedolson, khokansardar.
Fixes#60610.
git-svn-id: https://develop.svn.wordpress.org/trunk@58248 602fd350-edb4-49c9-b593-d223f7449a82
Updates the `WP_Block_Styles_Registry` class to allow registering an array of blocks.
Props aaronrobertshaw, talldanwp, isabel_brison.
Fixes#61274.
git-svn-id: https://develop.svn.wordpress.org/trunk@58246 602fd350-edb4-49c9-b593-d223f7449a82
Ensures that feature-level selectors for block style variations are correctly scoped when generating a theme.json stylesheet.
Props aaronrobertshaw, audrasjb, vcanales, isabel_brison.
Fixes#61119.
git-svn-id: https://develop.svn.wordpress.org/trunk@58244 602fd350-edb4-49c9-b593-d223f7449a82
Fixes a condition that was preventing align full blocks to extend full width when their parent block has custom padding.
Props richtabor, isabel_brison, ramonopoly.
Fixes#61313.
git-svn-id: https://develop.svn.wordpress.org/trunk@58243 602fd350-edb4-49c9-b593-d223f7449a82
Enables customizing the list of aspect ratio options available through theme.json.
Props fabiankaegy, isabel_brison, swissspidy.
git-svn-id: https://develop.svn.wordpress.org/trunk@58242 602fd350-edb4-49c9-b593-d223f7449a82
Adjusts the block level global styles selectors so they have a consistent specificity of 0-1-0, and adjusts base and layout global style selectors to their minimum required specificity.
Props aaronrobertshaw, isabel_brison, andrewserong, mukesh27.
Fixes#61165.
git-svn-id: https://develop.svn.wordpress.org/trunk@58241 602fd350-edb4-49c9-b593-d223f7449a82
Allow translators to replace the W3C WAI decision tree link used to provide information about writing alt text. Improves accessibility for non-English speaking content authors.
Props tmatsuur, joedolson, oglekler, SergeyBiryukov, myhro, sabernhardt.
Fixes#60975.
git-svn-id: https://develop.svn.wordpress.org/trunk@58240 602fd350-edb4-49c9-b593-d223f7449a82
The verse block has different padding between editor and frontend.
Props pranitdugad, sumitsingh, sumitbagthariya16, hitendra-chopda, sabernhardt, huzaifaalmesbah, shuvomohajan, hmbashar.
Fixes#61306.
git-svn-id: https://develop.svn.wordpress.org/trunk@58239 602fd350-edb4-49c9-b593-d223f7449a82
The media and test block had misaligned padding. This changes styles to match margins.
Props kajalgohel, nidhidhandhukiya, ironprogrammer, sabernhardt, costdev, huzaifaalmesbah, hmbashar.
Fixes#57195.
git-svn-id: https://develop.svn.wordpress.org/trunk@58238 602fd350-edb4-49c9-b593-d223f7449a82
The new function twentyseventeen_should_show_featured_image was missing documentation for the custom filter. This brings that in.
Props poena.
Fixes#39281.
git-svn-id: https://develop.svn.wordpress.org/trunk@58237 602fd350-edb4-49c9-b593-d223f7449a82
This new filter in `WP_Textdomain_Registry` allows plugins to override the determined languages folder when using just-in-time translation loading.
Props swissspidy, chouby, johnbillion.
Fixes#61206.
git-svn-id: https://develop.svn.wordpress.org/trunk@58236 602fd350-edb4-49c9-b593-d223f7449a82
Integrates the directives processing into the WP_Block class. It removes the overhead of running additional hooks when rendering blocks and simplifies the way we detect whether the directive processing should run on an interactive region of the produced final HTML for the blocks.
Introduces `interactivity_process_directives` filter to offer a way to opt out from directives processing. It's needed in Gutenberg: https://github.com/WordPress/gutenberg/pull/62095.
Props gziolo, cbravobernal.
Fixes#61185.
git-svn-id: https://develop.svn.wordpress.org/trunk@58234 602fd350-edb4-49c9-b593-d223f7449a82
The Tag Processor stores the byte-offsets into its HTML document where
the current token starts and ends, and also for every bookmark. In some
cases for tags, the end offset has been off by one.
In this patch the offset is fixed so that a bookmark always properly
refers to the full span of the token it's bookmarking. Also the current
token byte offsets are properly recorded.
While this is a defect in the Tag Processor, it hasn't been exposed
through the public interface and has not affected any of the working
of the processor. Only subclasses which rely on the length of a bookmark
have been potentially affected, and these are not supported environments
in the ongoing work.
This fix is important for future work and for ensuring that subclasses
performing custom behaviors remain as reliable as the public interface.
Developed in https://github.com/WordPress/wordpress-develop/pull/6625
Discussed in https://core.trac.wordpress.org/ticket/61301
Props dmsnell, gziolo, jonsurrell, westonruter.
Fixes#61301.
git-svn-id: https://develop.svn.wordpress.org/trunk@58233 602fd350-edb4-49c9-b593-d223f7449a82
The seperator block was looking different in the iframe editor. This resolves that by unifying.
Props nidhidhandhukiya, sabernhardt, darshitrajyaguru97, yuvrajsinj2211.
Fixes#60079.
git-svn-id: https://develop.svn.wordpress.org/trunk@58231 602fd350-edb4-49c9-b593-d223f7449a82
In order to render the block template in the locked template preview inside the post editor we need to be able to fetch the contents of any block templates/template parts for any user role that can edit a post.
Props fabiankaegy, youknowriad.
Fixes#61137.
git-svn-id: https://develop.svn.wordpress.org/trunk@58227 602fd350-edb4-49c9-b593-d223f7449a82
Improve the behaviour of global padding when useRootPaddingAwareAlignments is enabled in theme.json to be more consistent across blocks, templates and patterns.
Props richtabor, isabel_brison, andrewserong.
Fixes#61304.
git-svn-id: https://develop.svn.wordpress.org/trunk@58226 602fd350-edb4-49c9-b593-d223f7449a82
Updated the global styles endpoints in the REST API to extend from existing posts and revisions controllers. This reduces duplicated code and inconsistencies. The revisions controller is now a subclass of the `WP_REST_Revisions_Controller`. Related redundant methods were removed and schema generation and collection parameters were adjusted to suit the global styles context. Updated permission checks, constructor, and collection parameters accordingly. This change allows for easy override of these classes using the `register_post_type_args` filter.
This reintroduces [57624] (reverted in [57628]) with improved backward compatibility and further enhancements.
Props ramonopoly, spacedmonkey, mukesh27, swissspidy.
Fixes#60131.
git-svn-id: https://develop.svn.wordpress.org/trunk@58225 602fd350-edb4-49c9-b593-d223f7449a82
The details page is being removed from the site editor in 6.6. we need to direct the admin bar menu item to the "edit" mode page directly.
Props youknowriad, mamaduka.
Fixes#61266.
git-svn-id: https://develop.svn.wordpress.org/trunk@58223 602fd350-edb4-49c9-b593-d223f7449a82
Syncs the necessary changes from Gutenberg to allow setting site-wide
background images using the top-level `styles.background` key in `theme.json`.
Props ramonopoly.
Fixes#61123.
git-svn-id: https://develop.svn.wordpress.org/trunk@58222 602fd350-edb4-49c9-b593-d223f7449a82
Replaces various boolean assertions wrapping `file_exists()` with either `assertFileExists()` or `assertFileDoesNotExist()` as appropriate for the test.
Props peterwilsoncc, mukesh27.
See #60705.
git-svn-id: https://develop.svn.wordpress.org/trunk@58221 602fd350-edb4-49c9-b593-d223f7449a82
This changeset indicates that the `$title` parameter is now nullable.
Follow-up to [58209].
Props skithund.
Fixes#60668.
git-svn-id: https://develop.svn.wordpress.org/trunk@58220 602fd350-edb4-49c9-b593-d223f7449a82
This reverts some unwanted changes related to `react` and react-dom` versions in `$vendor_scripts_versions`.
Follow-up to [58218].
Unprops audrasjb.
Fixes#61090.
git-svn-id: https://develop.svn.wordpress.org/trunk@58219 602fd350-edb4-49c9-b593-d223f7449a82
Include explicit units for media length and dimensions in attachment modal and media details screen.
Props Presskopp, joedolson, shailu25, audrasjb.
Fixes#59009.
git-svn-id: https://develop.svn.wordpress.org/trunk@58217 602fd350-edb4-49c9-b593-d223f7449a82
Change the priority of the search form & remove `float` so that the visual position of the form matches it's positioning in the DOM.
This sets the priority of the search form to an arbitrarily high value of `9999` to ensure it will generally be last in the DOM.
Props joedolson, sabernhardt, audrasjb.
Fixes#60685.
git-svn-id: https://develop.svn.wordpress.org/trunk@58215 602fd350-edb4-49c9-b593-d223f7449a82
Adjust the max-width of the image edit settings panel so that reflow handling at intermediary breakpoints is more consistent and less fragile.
Props deepakvijayan, huzaifaalmesbah, joedolson, khokansardar.
Fixes#58979.
git-svn-id: https://develop.svn.wordpress.org/trunk@58214 602fd350-edb4-49c9-b593-d223f7449a82
The logo block does not use theme mods, and instead saves a site-wide option `site_logo` to use as the site logo.
Add handling for cases where the logo image does not exist and delete the `site_logo` option when the attachment configured as site logo is deleted.
Props afercia, joedolson, khokansardar, SergeyBiryukov.
Fixes#60922.
git-svn-id: https://develop.svn.wordpress.org/trunk@58213 602fd350-edb4-49c9-b593-d223f7449a82
This changeset ensures the login header default title string is translatable in `login_header()`.
Props juliobox, swissspidy, audrasjb.
Fixes#60668.
git-svn-id: https://develop.svn.wordpress.org/trunk@58209 602fd350-edb4-49c9-b593-d223f7449a82
This changeset improves the error message returned when no URL is provided, and updates the related unit tests accordingly.
Props hinnerk, audrasjb.
Fixes#60565.
git-svn-id: https://develop.svn.wordpress.org/trunk@58208 602fd350-edb4-49c9-b593-d223f7449a82
The caption for image block was misaligned. The issue appeared in 5.8 due to the block class name change making the selector meaningless. This is resolved by a change in the selectors.
Props nkeller15, sabernhardt, thakordarshil, anilvaza, shailu25, pavanpatil1, darshitrajyaguru97.
Fixes#58539.
git-svn-id: https://develop.svn.wordpress.org/trunk@58207 602fd350-edb4-49c9-b593-d223f7449a82
When a layout doesn't use custom post types it was appearing broken. This adds a filter for the display of the featured image to resolve this.
Props justnorris, JPry, davidakennedy, SergeyBiryukov, zkarj, poena, nhrrob, lamarajan.
Fixes#39281.
git-svn-id: https://develop.svn.wordpress.org/trunk@58206 602fd350-edb4-49c9-b593-d223f7449a82
The button block link did not inherit the custom letter spacing. This resolves that issue.
Props nidhidhandhukiya, sabernhardt, wesatintellitonic, pooja1210, shailu25.
Fixes#58024.
git-svn-id: https://develop.svn.wordpress.org/trunk@58205 602fd350-edb4-49c9-b593-d223f7449a82
The latest comments author font weight was showing different between editor and front. This fixes that and also removes an extra ruleset.
Props pitamdey, sabernhardt, shailu25, naeemhaque, darshitrajyaguru97.
Fixes#61180.
git-svn-id: https://develop.svn.wordpress.org/trunk@58204 602fd350-edb4-49c9-b593-d223f7449a82
