21469 Commits

Author SHA1 Message Date
Jun Pataleta
8b2b47f733 Merge branch 'MDL-66694-master' of git://github.com/junpataleta/moodle 2019-10-17 22:48:16 +08:00
Jun Pataleta
10cc5e8100 MDL-66694 mod_forum: Fix unit test
* Set $forum1's displaywordcount to true in
  test_mod_forum_get_discussion_posts() so that the word and char counts
  will be returned.
* Use count_words() and count_letters() instead of hard coding the
  expected values for the word and char counts.
2019-10-17 22:39:36 +08:00
Michael Hawkins
97aeba56ba MDL-66694 mod_forum: Refactored post counts scheduled task 2019-10-17 17:07:05 +08:00
Michael Hawkins
d21d6baac6 MDL-66694 mod_forum: Word/char count tidy ups & add task config option
The chunk size used by the existing post word/char count calculation
ad-hoc task can now be set as a $CFG parameter. Also improved the way
the ad-hoc task is re-queued and tidied up some redundant code.
2019-10-17 16:13:23 +08:00
Michael Hawkins
3c36cdb150 MDL-66694 mod_forum: Updated adhoc task to requeue until completion
The adhoc task run during upgrade will now be requeued until no more
word/char counts require updating. Previously it was only run once,
so only the first 5000 posts would be updated.
2019-10-17 15:05:57 +08:00
David Monllaó
7d8f604b3c MDL-66694 mod_forum: Upgrade forum post word and char counts 2019-10-17 15:05:57 +08:00
Michael Hawkins
3eb0a82fef MDL-66694 mod_forum: Word & char count update consistency fixes
Charcount logic is now consistent with wordcount in the post exporter.
Counts update now called in forum_udpate_instance since it is updating
the data.
2019-10-17 15:05:57 +08:00
David Monllaó
591dd68790 MDL-66694 mod_forum: Update word & char counts on db save 2019-10-17 15:05:57 +08:00
Michael Hawkins
68f2d677ae MDL-66694 forumreport_summary: String update and method tidy up
Replaced 'Char' with full word 'Character' in the charcount string.
Also tidied up show_word_char_counts code and set to protected instead
of private.
2019-10-17 15:05:57 +08:00
David Monllaó
74f94dfc26 MDL-66694 mod_forum: Word count and char count columns 2019-10-17 15:05:57 +08:00
Andrew Nicols
bcce0270fe MDL-66496 mod_data: Fixes during integration 2019-10-17 12:20:54 +08:00
Andrew Nicols
a7139f7600 Merge branch 'MDL-66496-master' of git://github.com/tobiasreischmann/moodle 2019-10-17 11:05:34 +08:00
Eloy Lafuente (stronk7)
d1729ce196 Merge branch 'MDL-66790-master' of git://github.com/junpataleta/moodle 2019-10-16 00:55:48 +02:00
Jun Pataleta
80d7651534 MDL-66790 quizreport: Prevent sorting for checkbox column 2019-10-15 17:25:16 +08:00
Jun Pataleta
d75eb57daa Merge branch 'MDL-66821' of https://github.com/timhunt/moodle 2019-10-15 07:35:36 +08:00
Eloy Lafuente (stronk7)
82d71a5c83 Merge branch 'MDL-66335' of https://github.com/timhunt/moodle 2019-10-14 18:53:44 +02:00
Sara Arjona
5b91deed2c Merge branch 'MDL-63349-Master' of github.com:tuanngocnguyen/moodle 2019-10-14 13:58:09 +02:00
Tim Hunt
9c14b28d0b MDL-66821 question behat: new step for acting on questions in the bank
There is a proposed change MDL-66816 which will change the question
bank UI. This will break any Behat tests which uses low-level steps
like

    When I click on "Duplicate" "link" in the "Test question" "table_row"

to perform an action on a question in the question bank. This commit
introduces a new step:

    When I choose "Duplicate" action for "Test question" in the question bank

This commit also converts all core Behat tests to use the new step.
2019-10-14 11:36:12 +01:00
Tim Hunt
4e1ebf8cde MDL-66335 quiz behat: using the new generic navigation steps
This converts all the navigation to quiz pages when that is not
the thing under test. Also, I decided that the Quiz settings form
belonged to the course, so did not do that here.
2019-10-14 11:21:22 +01:00
Eloy Lafuente (stronk7)
70d33bc399 Merge branch 'MDL-66874-master' of git://github.com/junpataleta/moodle 2019-10-14 10:05:27 +02:00
Jun Pataleta
5a85b7fc13 MDL-66874 mod_feedback: Use correct option attribute 'classes' 2019-10-14 11:27:19 +08:00
Jun Pataleta
4f71255e61 MDL-66874 mod_data: Explicitly add btn-secondary class to select all
* Plus use correct option attribute 'classes' for the slave
  checkboxes
2019-10-14 11:27:19 +08:00
Jun Pataleta
bc003428bc MDL-66874 mod_choice: Explicitly add btn-secondary class to select all 2019-10-14 11:27:19 +08:00
Jake Dallimore
e7ac8db8a1 Merge branch 'MDL-66768-master' of git://github.com/rezaies/moodle 2019-10-14 11:21:03 +08:00
Shamim Rezaie
bf2e1bec4e MDL-66768 forumreport_summary: remove the select column when downloading 2019-10-14 13:07:17 +11:00
Shamim Rezaie
a90b8056ba MDL-66768 forumreport_summary: move back bulk action menu to the bottom 2019-10-14 13:07:16 +11:00
Simey Lameze
850ce97425 MDL-66768 forumreport_summary: add ability to download report 2019-10-14 13:05:04 +11:00
Jun Pataleta
75c49ad291 Merge branch 'MDL-66553' of https://github.com/timhunt/moodle 2019-10-14 09:42:03 +08:00
Tim Hunt
c2200bd5dc MDL-66553 quiz/questions: show idnumber and tags when adding from qbank 2019-10-11 13:59:26 +01:00
Tim Hunt
61cc1e6494 MDL-66553 question bank: show tags and idnumbers in question list 2019-10-11 13:59:26 +01:00
Nathan Nguyen
4a6edc5767 MDL-63349 assignfeedback_editpdf: Rotate submitted image automatically 2019-10-11 15:26:53 +11:00
Jun Pataleta
ad01d8bed5 Merge branch 'MDL-66076-master-2' of git://github.com/junpataleta/moodle 2019-10-11 11:16:37 +08:00
Jun Pataleta
ce8a2d11d8 MDL-66076 forumreport_summary: filter JS and template optimisations 2019-10-11 11:09:50 +08:00
Michael Hawkins
aa4b62baac MDL-66076 forumreport_summary: Filter styles update 2019-10-11 11:09:50 +08:00
Michael Hawkins
9523f0e040 MDL-66076 forumreport_summary: Added missing SQL group by fields
Also removed a redundant variable declaration.
2019-10-11 11:09:50 +08:00
Michael Hawkins
d4d9b8c67c MDL-66076 forumreport_summary: Template example context fixes 2019-10-11 11:09:50 +08:00
Michael Hawkins
b9669dd319 MDL-66076 forumreport_summary: Always show viewcount column
Previously this was hidden if filtering by groups, but will now be
visible, along with a disclaimer that the data is not filtered
(since the groups cannot be determined from the logs used).
2019-10-11 11:09:50 +08:00
Michael Hawkins
cc15134c7b MDL-66076 forumreport_summary: Groups filter made accessible 2019-10-11 11:09:50 +08:00
Shamim Rezaie
14f92164f1 MDL-66076 forumreport_summary: Minor cleanup of report code
Removed some unnecessary code and added the current page to breadcrumbs
2019-10-11 11:09:50 +08:00
Shamim Rezaie
0942e58c91 MDL-66298 forumreport_summary: Added ability to bulk message users
Part of MDL-66076.
2019-10-11 11:09:50 +08:00
Shamim Rezaie
cc97038258 MDL-66298 forumreport_summary: Moved table generation out of renderer
Part of MDL-66076.
2019-10-11 11:09:50 +08:00
Shamim Rezaie
806d634359 MDL-66298 forumreport_summary: Display full names consistently
Part of MDL-66076. Display full names and profile links consistent
with other areas of Moodle.
2019-10-11 11:09:50 +08:00
Michael Hawkins
9eebd58aa2 MDL-66695 forumreport_summary: Added handling for all groups view count
Part of MDL-66076.
2019-10-11 11:10:41 +08:00
David Monllaó
235a6db7fb MDL-66695 forumreport_summary: New viewcount column
Part of MDL-66076.
2019-10-11 11:10:33 +08:00
Michael Hawkins
b29de56dd7 MDL-66268 forumreport_summary: Add filters handling incl groups filter
Part of MDL-66076.
2019-10-11 11:10:27 +08:00
Michael Hawkins
382168a0aa MDL-66594 forumreport_summary: Added first/last post date columns
Part of MDL-66076.
2019-10-11 11:10:14 +08:00
Michael Hawkins
d0e125cfc7 MDL-66299 forumreport_summary: Added attachments count column
Part of MDL-66076.
2019-10-11 11:10:10 +08:00
Michael Hawkins
90107b6f38 MDL-66299 mod_forum: Created new behat steps for bulk post creation
New behat steps created for adding bulk discussions and
replies in forums. Also includes private methods to prepare the
required information.

Part of MDL-66076.
2019-10-11 11:10:06 +08:00
Michael Hawkins
6388b6572c MDL-66153 mod_forum: Introduced summary report sub-plugin
Part of MDL-66076.
2019-10-11 11:09:50 +08:00
Sara Arjona
137befc2bd Merge branch 'MDL-66852-master' of github.com:lucaboesch/moodle 2019-10-09 12:58:00 +02:00