1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-09-06 22:30:44 +02:00

Compare commits

...

5389 Commits

Author SHA1 Message Date
Joas Schilling
b2b5addd09 [prep-release-3.1.3] Add changelog for 3.1.3-RC1 2015-01-26 20:09:46 +01:00
Joas Schilling
513b2f8296 [prep-release-3.1.3] Prepare Changelog 2015-01-26 20:00:11 +01:00
Joas Schilling
32b25d7b11 [prep-release-3.1.3] Add migration for 3.1.3-RC1 2015-01-26 19:43:36 +01:00
Joas Schilling
acfb9b9539 [prep-release-3.1.3] Update version to 3.1.2-RC1 2015-01-26 19:42:06 +01:00
Nils Adermann
1c6ebcf02b Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [prep-release-3.0.13] Bump version numbers for 3.0.13 release
  [prep-release-3.0.13] Highlight security relevant changes

Conflicts:
	build/build.xml
	phpBB/install/database_update.php
2015-01-26 19:01:34 +01:00
Nils Adermann
ebd5aace3f Merge branch 'prep-release-3.0.13' into develop-olympus
* prep-release-3.0.13:
  [prep-release-3.0.13] Bump version numbers for 3.0.13 release
  [prep-release-3.0.13] Highlight security relevant changes

Conflicts:
	build/build.xml
	phpBB/includes/constants.php
	phpBB/install/database_update.php
	phpBB/install/schemas/schema_data.sql
2015-01-26 18:57:06 +01:00
Nils Adermann
5ce89ae82f [prep-release-3.0.13] Bump version numbers for 3.0.13 release 2015-01-26 18:08:31 +01:00
Nils Adermann
4b42589cfa [prep-release-3.0.13] Highlight security relevant changes 2015-01-26 17:53:43 +01:00
Andreas Fischer
ffbe8cdc96 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12089] Add assert message on HTTP status code check
2015-01-26 02:47:38 +01:00
Andreas Fischer
4c11ea97d5 Merge pull request #3339 from nickvergessen/ticket/12089
[ticket/12089] Add assert message on HTTP status code check

* nickvergessen/ticket/12089:
  [ticket/12089] Add assert message on HTTP status code check
2015-01-26 02:47:36 +01:00
Joas Schilling
ed2d080551 [ticket/12089] Add assert message on HTTP status code check
PHPBB3-12089
2015-01-25 23:06:56 +01:00
Marc Alexander
a2fbde44c0 Merge pull request #3336 from nickvergessen/ticket/13543
Ticket/13543
2015-01-24 21:52:56 +01:00
Joas Schilling
b2674cf1f6 [ticket/13543] Fix broken slow test
PHPBB3-13543
2015-01-24 21:10:53 +01:00
Joas Schilling
c423038587 [ticket/13543] Add slow tests to travis matrix
PHPBB3-13543
2015-01-24 21:10:35 +01:00
Joas Schilling
9cdbb69f9e Merge pull request #3321 from marc1706/ticket/13282
[ticket/13282] Use 0 as default for integer type columns in postgresql
2015-01-23 17:32:28 +01:00
Marc Alexander
eb4594d8ee [ticket/13282] Add unit test for adding integer column with default null
PHPBB3-13282
2015-01-22 23:17:59 +01:00
Nils Adermann
40ab75478e Merge pull request #3173 from Nicofuma/ticket/13361
[ticket/13361] Improve the exception listener
2015-01-22 16:16:21 +01:00
Marc Alexander
47f04d7620 [ticket/13282] Add functional tests for adding profilefields
PHPBB3-13282
2015-01-22 10:30:24 +01:00
Marc Alexander
816465bfe9 [ticket/13282] Use strpos() instead of preg_match()
PHPBB3-13282
2015-01-22 10:11:08 +01:00
Marc Alexander
1367fc234f [ticket/13282] Use 0 as default for integer type columns in postgresql
PHPBB3-13282
2015-01-22 00:06:48 +01:00
Andreas Fischer
a737eeb6ce Merge pull request #3320 from marc1706/ticket/13534
[ticket/13534] Set imagick path to empty string to prevent failing path ...

* marc1706/ticket/13534:
  [ticket/13534] Set imagick path to empty string to prevent failing path check
2015-01-21 16:59:26 +01:00
Andreas Fischer
7ed065a630 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [develop-olympus] Increment version number to 3.0.14-dev.
  [develop-olympus] Add changelog for 3.0.13 release.
  [develop-olympus] Bump version numbers for 3.0.13-RC1 release.
  [develop-olympus] Bumping version numbers to final for 3.0.13 releases.

Conflicts:
	build/build.xml
	phpBB/docs/CHANGELOG.html
	phpBB/docs/INSTALL.html
	phpBB/includes/constants.php
	phpBB/install/convertors/convert_phpbb20.php
	phpBB/install/database_update.php
	phpBB/install/schemas/schema_data.sql
	phpBB/styles/prosilver/imageset/imageset.cfg
	phpBB/styles/prosilver/style.cfg
	phpBB/styles/prosilver/template/template.cfg
	phpBB/styles/prosilver/theme/theme.cfg
	phpBB/styles/subsilver2/imageset/imageset.cfg
	phpBB/styles/subsilver2/style.cfg
	phpBB/styles/subsilver2/template/template.cfg
	phpBB/styles/subsilver2/theme/theme.cfg
2015-01-21 16:07:12 +01:00
Marc Alexander
7d6fdcfaa5 [ticket/13534] Set imagick path to empty string to prevent failing path check
The imagick path defaults to /usr/bin. If it doesn't exist for some reason,
for example on travis, the form won't be submitted and the settings won't be
changed.

PHPBB3-13534
2015-01-21 15:18:25 +01:00
Andreas Fischer
14585fcb4f [develop-olympus] Increment version number to 3.0.14-dev. 2015-01-21 15:15:30 +01:00
Tristan Darricau
7fef91afd2 [ticket/13361] Rename exception to runtime_exception
PHPBB3-13361
2015-01-21 08:41:02 +01:00
Andreas Fischer
2c9e178a42 [develop-olympus] Add changelog for 3.0.13 release. 2015-01-21 01:45:23 +01:00
Andreas Fischer
9f7f366573 [develop-olympus] Bump version numbers for 3.0.13-RC1 release. 2015-01-21 01:32:18 +01:00
Andreas Fischer
c09023d1db [develop-olympus] Bumping version numbers to final for 3.0.13 releases. 2015-01-21 01:25:50 +01:00
Nils Adermann
ddeb696b25 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/13531] Send 404 Not Found.
  [ticket/13531] Explicitly disallow trailing paths (e.g. PATH_INFO).
2015-01-21 01:07:30 +01:00
Nils Adermann
eaeb88133f Merge pull request #3316 from bantu/ticket/13531
[ticket/13531] Explicitly disallow trailing paths (e.g. PATH_INFO).
2015-01-21 01:05:13 +01:00
Andreas Fischer
e34b92882a [ticket/13531] Send 404 Not Found.
PHPBB3-13531
2015-01-21 01:02:16 +01:00
Marc Alexander
4b9434bf1b [ticket/13531] Explicitly disallow trailing paths (e.g. PATH_INFO).
PHPBB3-13531
2015-01-21 01:02:08 +01:00
Tristan Darricau
08e186af8e Merge pull request #3314 from VSEphpbb/ticket/13133
[ticket/13133] Fix variable name in set_custom_style()

* VSEphpbb/ticket/13133:
  [ticket/13133] Fix variable name in set_custom_style()
2015-01-20 23:47:44 +01:00
Tristan Darricau
f6057c5eab Merge pull request #3315 from nickvergessen/ticket/13530
[ticket/13530] Fix undefined variables

* nickvergessen/ticket/13530:
  [ticket/13530] Fix undefined variables
2015-01-20 23:43:57 +01:00
Joas Schilling
ed6b8f84ad [ticket/13530] Fix undefined variables
PHPBB3-13530
2015-01-20 23:36:45 +01:00
Tristan Darricau
9334100cb3 Merge pull request #3313 from nickvergessen/ticket/13528
[ticket/13528] Return correct translation instead of is_set()

* nickvergessen/ticket/13528:
  [ticket/13528] Return correct translation instead of is_set()
2015-01-20 23:36:23 +01:00
Joas Schilling
a5fae1b1f0 Merge pull request #3293 from Nicofuma/ticket/13489
[ticket/13489] Disable the event dispatcher in the migrator
2015-01-20 23:27:54 +01:00
Matt Friedman
41966c481f [ticket/13133] Fix variable name in set_custom_style()
PHPBB3-13133
2015-01-20 14:21:02 -08:00
Andreas Fischer
d0e5c0a187 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/13527] Apply htmlspecialchars() to data from version server.
  [ticket/13527] Remove two unused variables.

Conflicts:
	phpBB/includes/acp/acp_update.php
2015-01-20 23:15:21 +01:00
Andreas Fischer
d17904884e Merge pull request #3312 from bantu/ticket/13527
[ticket/13527] Escape information received from version server

* bantu/ticket/13527:
  [ticket/13527] Apply htmlspecialchars() to data from version server.
  [ticket/13527] Remove two unused variables.
2015-01-20 23:14:38 +01:00
Andreas Fischer
6e00529f36 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/13526] Correctly validate the ucp_pm_options form key.
2015-01-20 23:12:53 +01:00
Andreas Fischer
a8027c542f Merge pull request #3311 from bantu/ticket/13526
[ticket/13526] Correctly validate the ucp_pm_options form key.

* bantu/ticket/13526:
  [ticket/13526] Correctly validate the ucp_pm_options form key.
2015-01-20 23:12:00 +01:00
Andreas Fischer
4d0b04a397 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/13519] Correctly validate imagick path as path and not string

Conflicts:
	phpBB/includes/acp/acp_attachments.php
2015-01-20 23:11:29 +01:00
Andreas Fischer
3134b6b70e Merge pull request #3306 from marc1706/ticket/13519
[ticket/13519] Correctly validate imagick path as path and not string

* marc1706/ticket/13519:
  [ticket/13519] Correctly validate imagick path as path and not string
2015-01-20 23:10:19 +01:00
Joas Schilling
d1bff80dd1 [ticket/13528] Return correct translation instead of is_set()
PHPBB3-13528
2015-01-20 22:56:33 +01:00
Joas Schilling
f02dc44a23 Merge pull request #3138 from prototech/ticket/12642
[ticket/12642] Ensure CPF type specific options are set when editing booleans.
2015-01-20 22:46:08 +01:00
Andreas Fischer
92b5222295 [ticket/13527] Apply htmlspecialchars() to data from version server.
PHPBB3-13527
2015-01-20 22:40:39 +01:00
Andreas Fischer
251868dd7e [ticket/13527] Remove two unused variables.
PHPBB3-13527
2015-01-20 22:34:14 +01:00
Joas Schilling
23069a13e2 [ticket/13526] Correctly validate the ucp_pm_options form key.
PHPBB3-13526
2015-01-20 22:16:24 +01:00
Joas Schilling
40006376f2 Merge pull request #3226 from prototech/ticket/13420
[ticket/13420] Correctly filter by lt/gt/equal to 0 posts when pruning users.
2015-01-20 20:58:12 +01:00
Joas Schilling
e66a28eb14 Merge branch 'develop-olympus' into develop-ascraeus
Conflicts:
	.travis.yml
2015-01-20 20:49:45 +01:00
Joas Schilling
03e3ee7f16 Merge pull request #3310 from bantu/ticket/13523
[ticket/13523] Install PHPUnit manually instead of from PEAR.
2015-01-20 20:47:36 +01:00
Andreas Fischer
0beb9128f9 [ticket/13523] Install PHPUnit manually instead of from PEAR.
The pear.phpunit.de channel has been shut down in 2014.

PHPBB3-13523
2015-01-20 20:31:08 +01:00
Joas Schilling
d99cd2d02e Merge pull request #3278 from rxu/ticket/13492
[ticket/13492] Fix IDN support for custom BBCode URL tokens
2015-01-20 17:31:06 +01:00
Tristan Darricau
dab0728357 [ticket/13489] Fix service configuration
PHPBB3-13489
2015-01-20 14:19:55 +01:00
rxu
8002af7526 [ticket/13492] Add the migration to update custom bbcodes with IDN regexps
Also fix the $utf8 checking regexp removing the curly braces.

PHPBB3-13492
2015-01-20 08:47:56 +07:00
Andreas Fischer
38c5ee6eec Merge pull request #3308 from nickvergessen/ticket/13504
[ticket/13504] Fix invalid variable $user

* nickvergessen/ticket/13504:
  [ticket/13504] Fix invalid variable $user
2015-01-19 23:23:57 +01:00
Nils Adermann
e4a041fedb Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/10985] Add fix to properly inherit style during update process

Conflicts:
	phpBB/includes/bbcode.php
2015-01-19 22:29:38 +01:00
Nils Adermann
ebbe6a7791 Merge pull request #2990 from Senky/ticket/10985
[ticket/10985] Error bbcode.html not found when updating with custom style inheriting from prosilver
2015-01-19 22:27:14 +01:00
Joas Schilling
7e8bb68999 [ticket/13504] Fix invalid variable $user
PHPBB3-13504
2015-01-19 21:42:22 +01:00
Joas Schilling
ff39ffacf6 Merge pull request #3296 from PayBas/ticket/13431
[ticket/13431] Fix responsive RTL media queries for <IE11
2015-01-19 21:37:14 +01:00
Joas Schilling
c29db8e7a4 Merge pull request #3294 from PayBas/ticket/13507
[ticket/13507] Fix horizontal scrollbar for large images in posts
2015-01-19 21:13:41 +01:00
Marc Alexander
6564446b0f [ticket/13519] Correctly validate imagick path as path and not string
PHPBB3-13519
2015-01-19 20:47:47 +01:00
Tristan Darricau
add3d3e760 Merge pull request #3055 from marc1706/ticket/13192
[ticket/13192] Add method for generating valid user page links based on mod_rewrite

* marc1706/ticket/13192:
  [ticket/13192] Add test for app.php in external subfolder
  [ticket/13192] Use ltrim() instead of preg_replace()
  [ticket/13192] Order test cases consistently
  [ticket/13192] Remove app.php on mod rewrite even if app.php is outside root
  [ticket/13192] Pass correct parameters and rename method to get_valid_page
  [ticket/13192] Use get_valid_user_page in confirm_box() and cleanup globals
  [ticket/13192] Use get_valid_user_page method in build_url function
  [ticket/13192] Add method for generating valid user page links
2015-01-19 16:45:43 +01:00
Marc Alexander
da189a105b [ticket/13192] Add test for app.php in external subfolder
PHPBB3-13192
2015-01-19 16:10:32 +01:00
Andreas Fischer
9d2c6b6ed6 Merge pull request #3299 from Nicofuma/ticket/13511
[ticket/13511] Call the check() method with the phpcsFile object

* Nicofuma/ticket/13511:
  [ticket/13511] Call the check() method with the phpcsFile object
2015-01-17 01:20:40 +01:00
Tristan Darricau
6b92fccd06 [ticket/13511] Call the check() method with the phpcsFile object
PHPBB3-13511
2015-01-17 00:09:06 +01:00
PayBas
4e5e356555 [ticket/13431] Fix responsive RTL media queries for <IE11
PHPBB3-13431
2015-01-16 19:25:45 +01:00
PayBas
9e38e9dc6f [ticket/13507] Fix horizontal scrollbar for large images in posts
PHPBB3-13507
2015-01-16 19:10:04 +01:00
Tristan Darricau
ce47170c29 [ticket/13489] Update migrations
PHPBB3-13489
2015-01-14 12:16:24 +01:00
Tristan Darricau
4df125625c [ticket/13489] Fix tests
PHPBB3-13489
2015-01-14 12:04:30 +01:00
Tristan Darricau
8ef238ea73 [ticket/13361] Fix the JsonResponse in the exception listener
PHPBB3-13361
2015-01-14 11:13:28 +01:00
Tristan Darricau
c99ed64473 [ticket/13489] Disable the event dispatcher in the migrator
PHPBB3-13489
2015-01-14 11:09:44 +01:00
Joas Schilling
e3e16a0166 Merge pull request #3234 from brunoais/ticket/13154
[ticket/13154] Event to edit user list for notification in notifications
2015-01-13 23:31:28 +01:00
Joas Schilling
2a08c60a62 Merge pull request #3233 from brunoais/ticket/13160
[ticket/13160] Viewtopic; before viewing permissions event
2015-01-13 23:27:30 +01:00
Joas Schilling
b27c0ab992 Merge pull request #3283 from Elsensee/ticket/13490
[ticket/13490] Allow multibyte characters in edit reason
2015-01-12 23:56:35 +01:00
brunoais
1d49ccd920 [ticket/13160] New line before comment block
PHPBB3-13160
2015-01-11 19:12:08 +00:00
Oliver Schramm
f075fb78f6 [ticket/13490] Allow multibyte characters in edit reason
PHPBB3-13490
2015-01-11 19:29:33 +01:00
rxu
17f4dce0fc [ticket/13492] Add IDN support for custom BBCode URL tokens
Custom BBCode URL tokens does not support IDN.
Custom BBCodes added earlier than IDN has been applied are unaffected.

PHPBB3-13492
2015-01-11 20:36:22 +07:00
Tristan Darricau
1f4bb2c149 [ticket/13361] Add tests
PHPBB3-13361
2015-01-11 11:28:45 +01:00
Dhruv Goel
e8464d7fe2 Merge pull request #3276 from nickvergessen/ticket/13272
[ticket/13272] Add vendor/ folder to "changed files" package
2015-01-11 15:42:58 +05:30
Dhruv Goel
fbf7726642 Merge pull request #3176 from Senky/ticket/13346
[ticket/13346] Fix indentation, spacing and missing divs
2015-01-11 14:42:40 +05:30
Joas Schilling
bfba52781b Merge pull request #3210 from brunoais/ticket/13147
[ticket/13147] Change get_global_visibility_sql()'s results
2015-01-10 22:00:07 +01:00
Joas Schilling
659e15656f [ticket/13272] Add vendor/ folder to "changed files" package
PHPBB3-13272
2015-01-10 21:17:16 +01:00
Jakub Senko
10e72a36a3 [ticket/13346] Remove unnecessary divs
PHPBB3-13346
2015-01-10 21:05:30 +01:00
brunoais
e0733ae435 [ticket/13147] New line before comment block
PHPBB3-13147
2015-01-10 17:15:54 +00:00
brunoais
ef9abd7165 [ticket/13147] Override variable name changed by request
PHPBB3-13147
2015-01-10 17:15:22 +00:00
brunoais
9cc4d60b88 [ticket/13146] Remove empty line
PHPBB3-13146
2015-01-10 17:08:46 +00:00
brunoais
ec749a2b39 [ticket/13146] "Make it" -> "Set it to"
PHPBB3-13146
2015-01-10 17:08:46 +00:00
brunoais
6d3fca9a41 [ticket/13146] Forced line feed on long line
PHPBB3-13146
2015-01-10 17:08:45 +00:00
brunoais
9cbb9b4253 [ticket/13146] Fixed wrong tab + space into only tab
PHPBB3-13146
2015-01-10 17:08:44 +00:00
brunoais
fce1be2684 [ticket/13160] Appending "_check" to override variable names
PHPBB3-13160
2015-01-10 17:08:43 +00:00
brunoais
f02e3a4076 [ticket/13160] lowercase null
PHPBB3-13160
2015-01-10 17:08:43 +00:00
brunoais
3d8aaf6aaf [ticket/13160] Wrong variable types fixed
PHPBB3-13160
2015-01-10 17:08:42 +00:00
brunoais
ffb7d618ac [ticket/13160] Removed an unwanted tab char.
PHPBB3-13160
2015-01-10 17:08:41 +00:00
brunoais
11269fe62a [ticket/13160] Allow override topic_tracking_info
PHPBB3-13160
2015-01-10 17:08:40 +00:00
brunoais
a5a6855a0d [ticket/13160] Allow override f_read and forum password
Adds a couple of variables to the event that allows  extension authors to
bypass the f_read and forum password checks as if the user had those permissions
whether or not he actually has them.

PHPBB3-13160
2015-01-10 17:08:40 +00:00
brunoais
a0287a62c1 [ticket/13160] Viewtopic; before viewing permissions event
An event before the f_Read permissions check in viewtopic

PHPBB3-13160
2015-01-10 17:08:39 +00:00
brunoais
2b76d7dc7c [ticket/13154] Don't assign dispatcher to a variable. Just the obj param.
PHPBB3-13154
2015-01-10 17:06:51 +00:00
Tristan Darricau
74e8f9bd4e [ticket/13361] Support ajax request (send a json response)
PHPBB3-13361
2015-01-10 17:14:14 +01:00
Marc Alexander
a415a4ec2b Merge pull request #3274 from nickvergessen/ticket/13486
[ticket/13486] Fix typo in method name
2015-01-10 16:25:27 +01:00
Joas Schilling
f756632185 [ticket/13486] Fix typo in method name
PHPBB3-13486
2015-01-10 15:14:58 +01:00
Marc Alexander
c28ef9afdd Merge pull request #3195 from nickvergessen/ticket/13238-asc
[ticket/13238] Do not drop indexes that do not exist from fulltext search
2015-01-10 13:17:59 +01:00
Marc Alexander
ba477f77c7 Merge pull request #3272 from nickvergessen/ticket/13307
[ticket/13307] Update mysql_upgrader.php to work without the schema_data...
2015-01-10 13:06:46 +01:00
brunoais
8ed5a047ec [ticket/13147] Wrong extra new line
PHPBB3-13147
2015-01-10 11:48:01 +00:00
Marc Alexander
e6509aaf60 [ticket/13192] Use ltrim() instead of preg_replace()
PHPBB3-13192
2015-01-10 12:46:40 +01:00
brunoais
9caec668af [ticket/13147] Renaming content_replaced->get_global_visibility_sql_overwrite
Renamed content_replaced to get_global_visibility_sql_overwrite in order to
follow the convention in other events' variables that have the same basic
function

PHPBB3-13147
2015-01-10 11:44:55 +00:00
brunoais
a09c38f1cc [ticket/13147] Removing globals and using injection
Using globals is NG. Using a parameter instead.

PHPBB3-13147
2015-01-10 11:44:54 +00:00
brunoais
0f6a0d820e [ticket/13147] Using $phpbb_dispatcher global var
PHPBB3-13147
2015-01-10 11:44:54 +00:00
brunoais
8f5e3d5efb [ticket/13147] Allow changing the result of calling get_global_visibility_sql
PHPBB3-13147
2015-01-10 11:44:52 +00:00
Marc Alexander
67c987f0d0 Merge pull request #3166 from nickvergessen/Senky-ticket/12866
[ticket/12866] Wrong profile field validation options
2015-01-10 12:36:49 +01:00
Joas Schilling
bf59d8dd74 Merge pull request #3209 from brunoais/ticket/13146
[ticket/13146] Allow changing the result of calling get_forums_visibility_sql
2015-01-10 12:29:48 +01:00
brunoais
cea35c486c [ticket/13146] Removed stray empty line
PHPBB3-13146
2015-01-10 09:55:43 +00:00
brunoais
b64d8c59b0 [ticket/13146] dispatcher, not phpbb_dispatcher
PHPBB3-13146
2015-01-10 09:18:03 +00:00
brunoais
349aaab6ac [ticket/13146] Even more missing phpbb_mock_event_dispatcher()
PHPBB3-13146
2015-01-10 08:32:22 +00:00
brunoais
da9ac2da72 [ticket/13146] Last missing phpbb_mock_event_dispatcher()
Thank you nickvergessen

PHPBB3-13146
2015-01-10 08:11:51 +00:00
Joas Schilling
8ae1b0c52e Merge pull request #3189 from rxu/ticket/12926
[ticket/12926] Support for IDN (IRI)
2015-01-10 00:09:57 +01:00
Joas Schilling
58d8ea5b0b Merge pull request #3265 from tas2580/develop-ascraeus
[ticket/13453] Sort param in Canonical URL
2015-01-09 21:41:19 +01:00
rxu
d86bdcb2a7 [ticket/12926] Get rid of the $scheme and $inline vars, fix regex_idn.php
Get rid of the $scheme and $inline vars, fix regex_idn.php to generate
both common and inline mode regexes all at once.

PHPBB3-12926
2015-01-10 03:21:36 +07:00
Joas Schilling
d2a4d6624f [ticket/13307] Update mysql_upgrader.php to work without the schema_data.php
The file has been delete quite some time ago.

PHPBB3-13307
2015-01-09 19:46:14 +01:00
Joas Schilling
d9bdd05c80 Merge pull request #3128 from omniError/ticket/13306
[ticket/13306] add error level to collector
2015-01-09 18:39:11 +01:00
Joas Schilling
3350df131f Merge pull request #3227 from prototech/ticket/13366
[ticket/13366] Ensure plupload_last_gc config entry is dynamic.
2015-01-09 18:11:41 +01:00
Joas Schilling
9ce8b62894 Merge pull request #3242 from lavigor/ticket/13442
[ticket/13442] UTF-8 symbols for database host
2015-01-09 18:07:00 +01:00
Joas Schilling
65ffc76e2f Merge pull request #3258 from marc1706/ticket/13385
[ticket/13385] Free result in \phpbb\config\db::set_atomic()
2015-01-09 18:03:21 +01:00
Joas Schilling
b64da23fe1 Merge pull request #3267 from Elsensee/ticket/13478
[ticket/13478] Add event core.bbcode_cache_init_end
2015-01-09 17:47:46 +01:00
Joas Schilling
67c9f4d064 Merge pull request #3268 from Elsensee/ticket/13470
[ticket/13470] Fix non-empty username array if no usernames are given
2015-01-09 17:41:42 +01:00
Joas Schilling
d4c078cc78 Merge pull request #3271 from marc1706/ticket/13432
[ticket/13432] Make sure to add language file when including acp_modules
2015-01-09 17:36:07 +01:00
Marc Alexander
9d9c57f334 [ticket/13432] Make sure to add language file when including acp_modules
PHPBB3-13432
2015-01-09 13:47:36 +01:00
Marc Alexander
38f184ad6b [ticket/13385] Remove unneeded $result in \phpbb\config\db::set_atomic()
PHPBB3-13385
2015-01-09 13:41:36 +01:00
Marc Alexander
7ba1a96427 [ticket/13192] Order test cases consistently
PHPBB3-13192
2015-01-09 13:38:52 +01:00
Oliver Schramm
e3571fc6eb [ticket/13470] Fix non-empty username array if no usernames are given
PHPBB3-13470
2015-01-08 22:17:05 +01:00
Oliver Schramm
953a98dc0b [ticket/13478] Add event core.bbcode_cache_init_end
PHPBB3-13478
2015-01-08 00:13:58 +01:00
Tobi Schäfer
de3d7aca16 [ticket/13453] Sort param in Canonical URL
PHPBB3-13453
2015-01-06 15:31:27 +01:00
brunoais
346f654b2e [ticket/13146] Use the correct phpbb_mock_event_dispatcher, instead of builder
PHPBB3-13146
2015-01-06 12:58:01 +00:00
Joas Schilling
87578e90eb Merge pull request #3262 from Elsensee/ticket/13466
[ticket/13466] Add bitfield and uid to event core.message_parser_check_message
2015-01-06 11:29:11 +01:00
Joas Schilling
874356e57f Merge pull request #3243 from kinerity/ticket/13437
[ticket/13437] Add template event viewtopic_body_post_author_before/after
2015-01-06 11:24:25 +01:00
Joas Schilling
26bf79425c Merge pull request #3231 from rxu/ticket/13435
[ticket/13435] Add core event to modify submit_post() sql data
2015-01-06 11:08:01 +01:00
Joas Schilling
d36b0452bd Merge pull request #3230 from omniError/ticket/13430
[ticket/13430] Add event core.prune_sql
2015-01-06 11:05:08 +01:00
Joas Schilling
64d880a15c Merge branch 'Wolfsblvt-ticket/13428' into develop-ascraeus 2015-01-06 11:01:40 +01:00
Wolfsblvt
387e4b942b [ticket/13428] Add core events to memberlist.php for teampage
PHPBB3-13428
2015-01-06 11:01:18 +01:00
Joas Schilling
6fd8f1b835 Merge pull request #3221 from MasterShredder/ticket/13422
[ticket/13422] New events for save custom cookies and set custom ban type
2015-01-06 10:48:14 +01:00
Joas Schilling
2dab3c8c52 Merge pull request #3211 from brunoais/ticket/13148
[ticket/13148] Creating a final way to modify edit logs output
2015-01-06 10:25:10 +01:00
Joas Schilling
35b7f94754 Merge pull request #3070 from brunoais/ticket/13141
[Event] Allow applying additional permissions to MCP access besides f_read
2015-01-06 10:04:51 +01:00
Oliver Schramm
2532583765 [ticket/13466] Add bitfield and uid to event core.message_parser_check_message
PHPBB3-13466
2015-01-05 22:15:56 +01:00
Joas Schilling
7a34bf9bf5 Merge pull request #3244 from rxu/ticket/13449
[ticket/13449] Add viewforum event after the topic's been assigned to template
2015-01-05 20:39:58 +01:00
Marc Alexander
281cc53532 [ticket/13192] Remove app.php on mod rewrite even if app.php is outside root
PHPBB3-13192
2015-01-04 17:41:02 +01:00
Marc Alexander
3638b2ff64 Merge pull request #3254 from VSEphpbb/ticket/13440
[ticket/13440] Update event version to 3.1.3-RC1
2015-01-04 12:21:09 +01:00
Marc Alexander
8c27c7f10b Merge pull request #3253 from VSEphpbb/ticket/13439
[ticket/13439] Update event version to 3.1.3-RC1
2015-01-04 11:25:43 +01:00
Matt Friedman
88034ea2f0 [ticket/13440] Update event version to 3.1.3-RC1
PHPBB3-13440
2015-01-04 01:40:18 -08:00
Matt Friedman
86f66b5f72 [ticket/13439] Update event version to 3.1.3-RC1
PHPBB3-13439
2015-01-04 01:38:50 -08:00
Marc Alexander
838b1250f6 Merge pull request #3249 from VSEphpbb/ticket/13440
[ticket/13440] Add event core.login_box_failed
2015-01-04 00:43:11 +01:00
Marc Alexander
4da3d41083 Merge pull request #3248 from VSEphpbb/ticket/13439
[ticket/13439] Add event core.acp_users_overview_before
2015-01-04 00:25:20 +01:00
Matt Friedman
9d9b8139d0 [ticket/13440] Add event core.login_box_failed
PHPBB3-13440
2015-01-03 15:23:50 -08:00
Matt Friedman
179a7a4c71 [ticket/13439] Add event core.acp_users_overview_before
PHPBB3-13439
2015-01-03 15:21:47 -08:00
rxu
970ed40b09 [ticket/13449] Add viewforum event after the topic's been assigned to template
PHPBB3-13449
2015-01-03 20:12:47 +07:00
Gaëtan Muller
0e0c649477 [ticket/13441] Functions_convert fails to set global moderators default group
PHPBB3-13441
2015-01-03 13:45:52 +01:00
brunoais
b3bcc1b501 [ticket/13146] Missing delete post test mock
PHPBB3-13146
2015-01-02 19:26:05 +00:00
Kailey Truscott
652a7630bb [ticket/13437] Change "View" to "view"
PHPBB3-13437
2015-01-02 10:38:56 -05:00
Kailey Truscott
7dad863a41 Fix events.md event name
PHPBB3-13437
2015-01-02 10:20:36 -05:00
Kailey Truscott
c61fa1aaa1 [ticket/13437] Add template event viewtopic_body_post_author_before/after
PHPBB3-13437
2015-01-02 10:00:01 -05:00
brunoais
8376a027a1 [ticket/13146] Setup mocks for tests with dispatcher
PHPBB3-13146
2015-01-02 11:46:03 +00:00
lavigor
d769e59090 [ticket/13442] UTF-8 symbols for database host
Added support for cyrillic domains as database hosts.

PHPBB3-13442
2015-01-02 14:21:05 +03:00
brunoais
abc5dbcd71 [ticket/13146] Realign variables and descriptions in event
PHPBB3-13146
2014-12-29 08:42:13 +00:00
brunoais
59ab09273f [ticket/13146] Improved $get_forums_visibility_sql_overwrite's clarity
PHPBB3-13146
2014-12-29 08:40:23 +00:00
brunoais
92d7c16782 [ticket/13148] Wrong version num; copy & paste fail
PHPBB3-13148
2014-12-29 08:23:31 +00:00
brunoais
0104188074 [ticket/13148] Fixed my error
PHPBB3-13148
2014-12-28 20:35:16 +00:00
brunoais
d455dd68f6 [ticket/13148] Fixed syntax error
PHPBB3-13148
2014-12-28 20:25:36 +00:00
brunoais
cf036ea0e8 [ticket/13148] Added more variables as requested
Added more variables as requested and some extra that may be of use.

PHPBB3-13148
2014-12-28 19:52:58 +00:00
MasterShredder
655d95002c [ticket/13422] Renamed event
PHPBB3-13422
2014-12-28 13:20:04 +04:00
MasterShredder
0a1f8388d0 [ticket/13422] Changed some spaces to tabs
PHPBB3-13422
2014-12-28 03:44:07 +04:00
MasterShredder
3f88be6527 [ticket/13422] Changed variable descriptions
PHPBB3-13422
2014-12-28 03:35:21 +04:00
MasterShredder
50ed202aac [ticket/13422] Renamed "continue" variable to "retain_cookie" for the event core.ucp_save_custom_cookies
PHPBB3-13422
2014-12-27 17:43:30 +04:00
Joas Schilling
a92589436a Merge pull request #3213 from brunoais/ticket/13158
[ticket/13158] Allow adding extra auth checks when the user is posting
2014-12-27 14:22:48 +01:00
Joas Schilling
b0f1a0f4bb Merge pull request #3229 from n-aleha/ticket/13098
[ticket/13098] Repair Yahoo contact field
2014-12-27 14:16:55 +01:00
Joas Schilling
6ff0aaaa70 Merge pull request #3225 from prototech/ticket/13302
[ticket/13302] Fix incorrect links to phpBB.com resources
2014-12-27 14:12:23 +01:00
Joas Schilling
ffbe1d424b Merge pull request #3224 from prototech/ticket/13427
[ticket/13427] Add several before/after template events to mcp_front.html
2014-12-27 14:08:51 +01:00
Joas Schilling
a5922a0e8b Merge pull request #3223 from prototech/ticket/13370
[ticket/13370] Allow calling class method in convertor framework directly
2014-12-27 14:07:37 +01:00
Joas Schilling
fa06c7967e Merge pull request #3218 from rxu/ticket/13419
[ticket/13419] Add the lowermost template event
2014-12-27 14:02:39 +01:00
Joas Schilling
d5f99e0478 Merge pull request #3216 from kinerity/ticket/13409
[ticket/13409] Add event core.search_modify_param_before
2014-12-27 14:01:05 +01:00
Joas Schilling
7b43d5c54e Merge pull request #3214 from brunoais/ticket/13159
[ticket/13159] Allow to do extra auth checks on report posting
2014-12-27 13:58:49 +01:00
Joas Schilling
3ba62628dc Merge pull request #3205 from rxu/ticket/13406
[ticket/13406] Add a space between the index name and columns list
2014-12-27 13:51:24 +01:00
Joas Schilling
faad779cf6 Merge pull request #3202 from Nicofuma/ticket/13402
[ticket/13402] Code sniffer, unused use, check the function doc blocks
2014-12-27 13:49:50 +01:00
Joas Schilling
f6b21a2789 Merge pull request #3191 from Elsensee/ticket/13312
[ticket/13312] Add event core.acp_email_send_before
2014-12-27 13:46:32 +01:00
Joas Schilling
867a45138c Merge pull request #3175 from Senky/ticket/13368
[ticket/13368] Add $forum_data to viewforum_get_topic_ids_data event
2014-12-27 13:38:19 +01:00
Joas Schilling
aea67c8e37 Merge pull request #3168 from Senky/ticket/11033
[ticket/11033] FULLTEXT_SPHINX_NO_CONFIG_DATA references unrequired field
2014-12-27 13:37:04 +01:00
Joas Schilling
d2334ab3e0 Merge pull request #3167 from Senky/ticket/12924
[ticket/12924] Make meta tags self-closing
2014-12-27 13:34:48 +01:00
Joas Schilling
5b1c9831c2 Merge pull request #3099 from Senky/ticket/13266
[ticket/13266] Enabling twig dump function if DEBUG is defined
2014-12-27 13:31:01 +01:00
Joas Schilling
a66e4770c1 Merge pull request #3159 from Crizz0/ticket/13357
[ticket/13357] Adds missing LOG_MOVED_TOPIC for 3.0.12 left-over entries
2014-12-27 13:29:04 +01:00
brunoais
0929267e72 [ticket/13154] Wrong variable name in the comment block
PHPBB3-13154
2014-12-19 11:23:23 +00:00
brunoais
dd9c415020 [ticket/13154] space before @var
Not a tab.

PHPBB3-13154
2014-12-19 10:03:57 +00:00
brunoais
dd6efdad59 [ticket/13154] Fix submit_post_test() test group
PHPBB3-13154
2014-12-18 14:56:58 +00:00
brunoais
13320a08ef [ticket/13154] Forgot the $this->
PHPBB3-13154
2014-12-17 23:17:12 +00:00
brunoais
8098d313e6 [ticket/13154] Adjusting phpBB tests for the dispatcher
PHPBB3-13154
2014-12-17 23:11:14 +00:00
brunoais
458f9cade6 [ticket/13154] Adding phpBB dispatcher to notifications manager
PHPBB3-13154
2014-12-17 23:10:54 +00:00
brunoais
7512efed9e [ticket/13154] Allow filtering the list of users to be notified
PHPBB3-13154
2014-12-17 15:17:44 +00:00
rxu
2929f28243 [ticket/13435] Add core event to modify submit_post() sql data
PHPBB3-13435
2014-12-13 21:08:01 +07:00
omniError
7b0cabc416 [ticket/13430] update event version
https://tracker.phpbb.com/browse/PHPBB3-13430

PHPBB3-13430
2014-12-12 17:39:30 -06:00
n-aleha
6463354a39 [ticket/13098] Repair Yahoo contact field
Update the Yahoo link of the yahoo profile field.

PHPBB3-13098
2014-12-12 13:54:35 +02:00
omniError
9f1493ce73 [ticket/13430] Add event core.prune_sql
https://tracker.phpbb.com/browse/PHPBB3-13430

PHPBB3-13430
2014-12-11 16:58:29 -06:00
Jakub Senko
91dc002c31 [ticket/13368] Update version
PHPBB3-13368
2014-12-11 14:11:43 +01:00
Cesar G
54b5ee5806 [ticket/13366] Ensure plupload_last_gc config entry is dynamic.
PHPBB3-13366
2014-12-09 18:50:29 -08:00
Cesar G
75780d7fc8 [ticket/13420] Correctly filter by lt/gt/equal to 0 posts when pruning users.
PHPBB3-13420
2014-12-09 18:27:04 -08:00
Cesar G
61df1ac2b3 Merge remote-tracking branch 'Senky/ticket/12567' into develop-ascraeus
* Senky/ticket/12567:
  [ticket/12567] wrap to top
2014-12-09 17:58:43 -08:00
Cesar G
46384adf00 Merge remote-tracking branch 'Senky/ticket/13319' into develop-ascraeus
* Senky/ticket/13319:
  [ticket/13319] Add missing table tags
2014-12-09 17:50:14 -08:00
Cesar G
719aa66224 [ticket/13302] Fix incorrect link to extensions database.
PHPBB3-13302
2014-12-09 17:10:08 -08:00
Cesar G
15507ffc16 [ticket/13302] Update translations forum link to 3.1.
PHPBB3-13302
2014-12-09 17:10:08 -08:00
Cesar G
bb4b3d2731 [ticket/13302] Update documentation and support forum links to 3.1 versions.
PHPBB3-13302
2014-12-09 17:10:03 -08:00
Cesar G
4dab281da1 [ticket/13427] Add several before/after template events to mcp_front.html.
PHPBB3-13427
2014-12-09 16:26:32 -08:00
Cesar G
1aea572aca [ticket/13370] Allow calling class method in convertor framework directly.
This change allows the usage of array($class, 'method')) directly instead of
having to use the functionX syntax as follows:
array('function1' => array($class, 'method')))

PHPBB3-13370
2014-12-09 15:59:05 -08:00
MasterShredder
fda5d8d637 [ticket/13422] Deleted event core.session_check_user_session 2014-12-08 21:37:07 +03:00
MasterShredder
1896825f39 [ticket/13422] Add new event core.session_set_custom_ban
PHPBB3-13422
2014-12-07 05:59:20 +04:00
MasterShredder
566510769b [ticket/13422] Add new event core.session_check_user_session
PHPBB3-13422
2014-12-07 05:57:07 +04:00
MasterShredder
4700b44125 [ticket/13422] Add new event core.ucp_save_custom_cookies
PHPBB3-13422
2014-12-07 05:52:24 +04:00
Joas Schilling
641a9e5441 Merge pull request #3208 from prototech/ticket/13396
[ticket/13396] Normalize multibyte characters in attachment file names.
2014-12-06 14:22:49 +01:00
Joas Schilling
7fbf5649eb Merge branch 'ticket/13400' into develop-ascraeus 2014-12-06 13:42:24 +01:00
kochi
dfbc109b59 [ticket/13400] Information text if the server load id high at search
PHPBB3-13400
2014-12-06 13:42:16 +01:00
rxu
0a419781c2 [ticket/13419] Add the lowermost template event
PHPBB3-13419
2014-12-06 16:36:33 +07:00
Kailey Truscott
0795b6bd6c [ticket/13409] Change search_id type and release version
PHPBB3-13409
2014-12-05 05:53:59 -05:00
Kailey Truscott
ddd1937655 [ticket/13409] Fix event name
PHPBB3-13409
2014-12-04 21:04:58 -05:00
Kailey Truscott
3bf55c0b4d [ticket/13409] Add event core.search_modify_param_before
PHPBB3-13409
2014-12-04 20:30:16 -05:00
brunoais
a8d3cbe53b [ticket/13159] Allow to do extra auth checks on report posting
PHPBB3-13159
2014-12-03 17:53:10 +00:00
brunoais
96a734b012 [ticket/13158] Allow adding extra auth checks when the user is posting
PHPBB3-13158
2014-12-03 17:34:35 +00:00
brunoais
b7f83b2cfc [ticket/13148] Creating a final way to modify edit logs output
PHPBB3-13148
2014-12-03 16:04:32 +00:00
brunoais
bfecae1d60 [ticket/13146] Forgot delete_post_test.php
PHPBB3-13146
2014-12-03 15:43:27 +00:00
brunoais
1c02f7e032 [ticket/13146] Adding required tests modifications for the new constructor
PHPBB3-13146
2014-12-03 15:10:32 +00:00
brunoais
f045744606 [ticket/13146] FIxed wrong order in config/content.yml
PHPBB3-13146
2014-12-03 14:26:25 +00:00
brunoais
10a4f79135 [ticket/13146] Fixed variable name for the override
PHPBB3-13146
2014-12-03 14:00:00 +00:00
brunoais
4159bb1340 [ticket/13146] Wrong usage of tabs in .yml
PHPBB3-13146
2014-12-03 13:56:50 +00:00
brunoais
ac8a4b05b4 [ticket/13146] Fixing what merging broke
Merging added content I didn't expect it to add. This fixes back to what it is supposed to be.

PHPBB3-13146
2014-12-03 13:55:53 +00:00
brunoais
80a7f6930c [ticket/13146] Adding eventDispatcher to the list
PHPBB3-13146
2014-12-03 13:55:53 +00:00
brunoais
614f975e68 [ticket/13146] $contentReplaced -> $content_replaced
PHPBB3-13146
2014-12-03 13:55:52 +00:00
brunoais
df3447b725 [ticket/13146] Extra line for clarity
Added an extra line after the "if ($contentReplaced)"  to help reading the code

PHPBB3-13146
2014-12-03 13:55:52 +00:00
brunoais
e9cb9baedb [ticket/13146] $phpbb_dispatcher was missing
Added $phpbb_dispatcher to the globals list for this function.

PHPBB3-13146
2014-12-03 13:55:51 +00:00
brunoais
e279a779fc [ticket/13146] Typo on the returning variable
PHPBB3-13146
2014-12-03 13:55:50 +00:00
brunoais
e596d0b6ce [ticket/13147] Adding $approve_forums to the list of the event's variables
PHPBB3-13147
2014-12-03 13:55:50 +00:00
brunoais
0388d82504 [ticket/13146] Adding $content_replaced to allow even more flexibility
PHPBB3-13146
2014-12-03 13:55:49 +00:00
brunoais
909bb523bf [ticket/13146] Allow changing the result of calling get_forums_visibility_sql
PHPBB3-13146
2014-12-03 13:55:48 +00:00
Cesar G
589394e80b [ticket/13396] Normalize multibyte characters in attachment file names.
PHPBB3-13396
2014-12-02 16:23:40 -08:00
Tristan Darricau
7f7f60698c [ticket/13402] Handle arrays and multiples types
PHPBB3-13402
2014-11-30 20:55:29 +01:00
Tristan Darricau
13d4394844 [ticket/13402] Refactor unused use Sniff
PHPBB3-13402
2014-11-30 19:18:18 +01:00
Tristan Darricau
70483d6088 Merge pull request #3204 from rxu/ticket/13405
[ticket/13405] Fix a typo in phpbb/migration/data/v310/style_update_p1.php

* rxu/ticket/13405:
  [ticket/13405] Fix a typo in phpbb/migration/data/v310/style_update_p1.php
2014-11-30 19:07:14 +01:00
rxu
2f92bc38e6 [ticket/13406] Add a space between the index name and columns list
Currently there's no space between the index name and columns list
when generating ADD INDEX sql query for MySQL DBMSes. This may cause errors
on earlier MySQL versions like 3.23.

PHPBB3-13406
2014-11-30 16:52:36 +07:00
rxu
499c1467df [ticket/13405] Fix a typo in phpbb/migration/data/v310/style_update_p1.php
PHPBB3-13405
2014-11-30 11:27:47 +07:00
Tristan Darricau
c5227ab2a5 [ticket/13402] Code sniffer, unused use, check the function doc blocks
PHPBB3-13402
2014-11-29 19:17:52 +01:00
brunoais
fe1f7beaf8 [ticket/13142] Extra space before the comment block
PHPBB3-13142
2014-11-29 10:40:35 +00:00
Joas Schilling
ac8b07ddd9 Merge pull request #3192 from Elsensee/ticket/13393
[ticket/13393] Call user->lang function directly
2014-11-29 09:08:51 +01:00
Joas Schilling
aab98b8626 [ticket/13238] Do not drop indexes that do not exist from fulltext search
PHPBB3-13238
2014-11-28 20:13:49 +01:00
Joas Schilling
1145af71bf [ticket/12866] Update existing profile fields with the new validation
PHPBB3-12866
2014-11-28 20:00:49 +01:00
Jakub Senko
b7f69edaa2 [ticket/12866] Assume underscore is part of \w
PHPBB3-12866
2014-11-28 20:00:48 +01:00
Joas Schilling
8f1a1874a9 Merge pull request #3194 from Nicofuma/ticket/13381
[ticket/13381] Allow ' *' in the doc blocks (especially the header files)
2014-11-28 19:58:56 +01:00
brunoais
bc7db0ae16 [ticket/13141] BUMPing version to 3.1.3
PHPBB3-13141
2014-11-28 15:05:20 +00:00
brunoais
88798b3514 [ticket/13141] Adding more variables to the event
Adding action, forum_id, mode, module and quickmod to
core.mcp_global_f_read_auth_after

PHPBB3-13141
2014-11-28 15:04:31 +00:00
Tristan Darricau
79ce924bc1 [ticket/13381] Allow ' *' in the doc blocks (especially the header files)
PHPBB3-13381
2014-11-27 11:20:26 +01:00
Tristan Darricau
d43e8c94f5 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/11613] Allow cookies to work on netbios domains
2014-11-27 10:39:11 +01:00
Tristan Darricau
b54dbe0df6 Merge pull request #3188 from marc1706/ticket/11613
[ticket/11613] Allow cookies for domains without dots

* marc1706/ticket/11613:
  [ticket/11613] Allow cookies to work on netbios domains
2014-11-27 10:38:45 +01:00
Cesar G
79a1495f66 Merge remote-tracking branch 'Prosk8er/ticket/13391' into develop-ascraeus
* Prosk8er/ticket/13391:
  [ticket/13391] subsilver2 poll options must have a setting of 1 when editing a post
2014-11-26 18:43:24 -08:00
Oliver Schramm
893e4b3067 [ticket/13393] Call user->lang function directly
PHPBB3-13393
2014-11-27 00:55:01 +01:00
Oliver Schramm
a349db54d6 [ticket/13312] Use empty for usernames array
PHPBB3-13312
2014-11-26 23:10:02 +01:00
Oliver Schramm
41d0b5d3a2 [ticket/13312] Add event core.acp_email_send_before
PHPBB3-13312
2014-11-26 23:01:58 +01:00
Prosk8er
a5a18fb6dd [ticket/13391] subsilver2 poll options must have a setting of 1 when editing a post
PHPBB3-13391
2014-11-26 14:09:07 -05:00
rxu
a8c62e707a [ticket/12926] Support for IDN (IRI)
Add international domain name support for URLs.

PHPBB3-12926
2014-11-27 01:18:49 +07:00
Jakub Senko
b67b67f2df [ticket/11613] Allow cookies to work on netbios domains
PHPBB3-11613
2014-11-26 14:58:33 +01:00
Marc Alexander
ee90d227c2 Merge pull request #3187 from Nicofuma/ticket/13362
[ticket/13362] Fix cache paths in .gitignore
2014-11-26 13:37:02 +01:00
Marc Alexander
51f46a8f91 Merge pull request #3185 from Nicofuma/ticket/13389
[ticket/13389] Replace pattern with path
2014-11-26 13:30:03 +01:00
Marc Alexander
6ac088ea2f Merge pull request #3075 from Senky/ticket/11613
[ticket/11613] Cookies do not work for netbios domain
2014-11-26 13:20:36 +01:00
Tristan Darricau
6a4179cef5 [ticket/13362] Fix cache paths in .gitignore
PHPBB3-13362
2014-11-26 12:38:02 +01:00
Tristan Darricau
90012c86e8 [ticket/13389] Replace pattern with path
PHPBB3-13389
2014-11-26 12:24:50 +01:00
Marc Alexander
aa3a46a35f Merge remote-tracking branch 'nickvergessen/ticket/13381' into develop-ascraeus 2014-11-25 23:15:03 +01:00
Joas Schilling
2e7ae40d49 Merge pull request #3183 from Nicofuma/ticket/13362
[ticket/13362] Ignore the whole cache directory in git
2014-11-25 22:45:23 +01:00
Joas Schilling
eb83bd5797 [ticket/13381] Fix header intendation of v312.php
PHPBB3-13381
2014-11-25 22:42:52 +01:00
Tristan Darricau
f46057ca02 [ticket/13362] Ignore the whole cache directory in git
PHPBB3-13362
2014-11-25 18:00:07 +01:00
Joas Schilling
f4898b9258 Merge branch 'prep-release-3.1.2' into develop-ascraeus 2014-11-25 16:44:57 +01:00
Joas Schilling
9c9623e47f [prep-release-3.1.2] Update the development version to 3.1.3-RC1-dev 2014-11-25 16:43:43 +01:00
Joas Schilling
1ad0dd28f1 Merge branch 'develop-olympus' into prep-release-3.1.2 2014-11-25 16:36:32 +01:00
Joas Schilling
ff9b541070 Merge pull request #3180 from naderman/ticket/13376
[ticket/13376] Revert unnecessary change for cookies called GLOBALS 92f554e3
2014-11-25 16:36:18 +01:00
Nils Adermann
965042d015 [ticket/13376] Revert unnecessary change for cookies called GLOBALS 92f554e3
Also introduce a clear cookie message hardcoded just in case.

PHPBB3-13376
2014-11-25 15:57:12 +01:00
Joas Schilling
9264d7c758 [prep-release-3.1.2] Update Changelog with 13376 2014-11-25 15:44:39 +01:00
Joas Schilling
0fbe8e8e69 [prep-release-3.1.2] Add migration to update version to 3.1.2 2014-11-24 21:32:17 +01:00
Joas Schilling
3862b60094 [prep-release-3.1.2] Increase version number to 3.1.2 2014-11-24 21:31:49 +01:00
Jakub Senko
b8ecd1a656 [ticket/13368] Add @changed entry
PHPBB3-13368
2014-11-24 21:30:42 +01:00
Jakub Senko
bb4b04f89a [ticket/13319] Add missing table tags
PHPBB3-13319
2014-11-24 20:48:15 +01:00
Jakub Senko
d24fa2e777 [ticket/13346] Fix indentation, spacing and missing divs
PHPBB3-13346
2014-11-24 20:41:01 +01:00
Jakub Senko
9348b0c4f2 [ticket/13368] Add $forum_data to viewforum_get_topic_ids_data event
PHPBB3-13368
2014-11-24 20:28:47 +01:00
Tristan Darricau
b00d02496e [ticket/13361] Improve the exception listener
PHPBB3-13361
2014-11-23 03:15:50 +01:00
Joas Schilling
5f3dffa820 [prep-release-3.1.2] Add changelog for 3.1.2-RC1 2014-11-22 19:35:24 +01:00
Joas Schilling
18d5ca9ce5 [prep-release-3.1.2] Prepare Changelog 2014-11-22 19:32:36 +01:00
Joas Schilling
dcd0f200d6 [prep-release-3.1.2] Add migration for 3.1.2-RC1 2014-11-22 19:27:34 +01:00
Joas Schilling
a5b3393bb0 [prep-release-3.1.2] Update version to 3.1.2-RC1 2014-11-22 19:22:40 +01:00
Jakub Senko
595f9c132b [ticket/12924] Remove newlines at the EOF
PHPBB3-12924
2014-11-22 19:19:08 +01:00
Joas Schilling
5c3b6a8559 Merge pull request #10 from phpbb/ticket/security-171
[ticket/security-171] Use type cast helper for json data
2014-11-22 17:48:37 +01:00
Joas Schilling
a3b18d87dd Merge pull request #8 from phpbb/ticket/security-169
[ticket/security-169] Stop loop through referer dir in top directory
2014-11-22 15:51:48 +01:00
Marc Alexander
0f06b88ee7 [ticket/security-171] Remove duplicate semicolon from tests
SECURITY-171
2014-11-22 15:48:09 +01:00
Joas Schilling
fd993cbaf2 Merge pull request #3157 from marc1706/ticket/13358
[ticket/13358] Add class for retrieving remote file data
2014-11-22 15:42:37 +01:00
Marc Alexander
ab69c79d07 Merge branch 'ticket/13358' into ticket/security-171 2014-11-22 15:24:27 +01:00
Marc Alexander
f3ae5e4cb2 [ticket/13358] Correctly create version_helper in acp_extensions
The full namespace for the file_downloader is now also being used in
version_helper.

PHPBB3-13358
2014-11-22 15:23:26 +01:00
Jakub Senko
b9289340d9 [ticket/12567] wrap to top
PHPBB3-12567
2014-11-22 12:37:31 +01:00
Joas Schilling
8b71103836 Merge pull request #3123 from Elsensee/ticket/13310
[ticket/13310] Add event core.acp_email_modify_sql
2014-11-22 12:21:24 +01:00
Joas Schilling
ea101f7932 Merge pull request #3160 from PayBas/ticket/13228
[ticket/13228] Fix codebox "select all" font-size in UCP and MCP
2014-11-22 12:18:00 +01:00
Joas Schilling
7700f31213 Merge pull request #3116 from rxu/ticket/13297
[ticket/13297] Add unicode modifier to url/email regular expression patterns
2014-11-22 12:13:39 +01:00
Jakub Senko
a609c9db82 [ticket/12924] Make meta tags self-closing
PHPBB3-12924
2014-11-22 12:12:13 +01:00
Joas Schilling
a83b952f63 Merge pull request #3158 from prototech/ticket/13354
[ticket/13354] Fix incorrect column name when deleting all topic logs.
2014-11-22 12:08:33 +01:00
Jakub Senko
86b3c54c77 [ticket/11033] Update string to reflect real requirements
PHPBB3-11033
2014-11-22 11:56:52 +01:00
Joas Schilling
e283611dc2 Merge pull request #3161 from Crizz0/ticket/12885
[ticket/12885] New if for Index-page - board-index-text switch
2014-11-22 11:35:51 +01:00
Joas Schilling
8489e0bdc2 Merge branch 'develop-olympus' into develop-ascraeus 2014-11-22 11:31:41 +01:00
Joas Schilling
a415b8e37b Merge pull request #3164 from Crizz0/ticket/10442
[ticket/10442] Adds <dd>&nbsp;</dd> to <dl> for xhtml correctness
2014-11-22 11:31:31 +01:00
Jakub Senko
30f292f5a2 [ticket/11613] Allow cookies to work on netbios domains
PHPBB3-11613
2014-11-22 11:29:57 +01:00
PayBas
2c15388520 [ticket/13228] Gotta use !important after all. Too bad
PHPBB3-13228
2014-11-22 02:42:25 +01:00
Crizzo
867bfa3f9e [ticket/10442] Adds <dd>&nbsp;</dd> to <dl> for xhtml correctness
PHPBB3-10442
2014-11-22 01:08:14 +01:00
Crizzo
4cb930c2c1 [ticket/12885] New if for Index-page - board-index-text switch
PHPBB3-12885
2014-11-22 00:09:38 +01:00
Marc Alexander
70692dd522 Merge pull request #3094 from nickvergessen/ticket/10744
Ticket/10744 Prevent installing styles with reserved names
2014-11-22 00:00:22 +01:00
Joas Schilling
c174862b7e [ticket/10744] Fix some doc blocks
PHPBB3-10744
2014-11-21 23:59:29 +01:00
Joas Schilling
7c683608ab [ticket/10744] Type hint objects for IDE usages
PHPBB3-10744
2014-11-21 23:58:53 +01:00
Joas Schilling
7f8c4d877a [ticket/10744] Prevent installing styles with reserved names
PHPBB3-10744
2014-11-21 23:55:48 +01:00
Marc Alexander
f648fe88d5 [ticket/security-171] Modify tests for new file_downloader class
SECURITY-171
2014-11-21 23:49:54 +01:00
Marc Alexander
9649d78fa4 Merge branch 'ticket/13358' into ticket/security-171 2014-11-21 23:37:17 +01:00
PayBas
16c43b6a7d [ticket/13228] Fix codebox "select all" font-size in UCP and MCP
PHPBB3-13228
2014-11-21 23:35:33 +01:00
Joas Schilling
2e2ab7b485 Merge pull request #3127 from omniError/ticket/13323
[ticket/13323] empty auth option in posting.php
2014-11-21 23:33:45 +01:00
Marc Alexander
6d3ac29aee [ticket/13358] Use protected and public keywords where applicable
PHPBB3-13358
2014-11-21 23:30:47 +01:00
Crizzo
f930a75471 [ticket/13357] Adds missing LOG_MOVED_TOPIC for 3.0.12 left-over entries
PHPBB3-13357
2014-11-21 23:18:42 +01:00
Marc Alexander
171837eefe [ticket/13358] Do not pass variables by reference
PHPBB3-13358
2014-11-21 23:16:22 +01:00
Joas Schilling
0017fad554 Merge pull request #3108 from Elsensee/ticket/13284
[ticket/13284] Message body not included in email
2014-11-21 23:10:00 +01:00
Joas Schilling
c98cceaf22 Merge pull request #3068 from marc1706/ticket/13204
[ticket/13204] Tell user that password was incorrect when exceeding attempts
2014-11-21 22:52:24 +01:00
Joas Schilling
dd7e09d092 Merge pull request #3064 from marc1706/ticket/13197
[ticket/13197] Also delete group avatar from users that have it set
2014-11-21 22:41:17 +01:00
Marc Alexander
4ee05b1c17 [ticket/security-171] Add tests for retrieved remote data in version_helper
SECURITY-171
2014-11-21 22:32:28 +01:00
Marc Alexander
34004612ac [ticket/security-171] Sanitize data from composer.json
SECURITY-171
2014-11-21 22:32:28 +01:00
Marc Alexander
da1888a7fa [ticket/security-171] Use type cast helper for json data
SECURITY-171
2014-11-21 22:32:28 +01:00
Joas Schilling
d7d4f681ca Merge pull request #3156 from prototech/ticket/13316
[ticket/13316] Ensure Recaptcha image uses https when necessary.
2014-11-21 22:29:02 +01:00
Cesar G
8d8c2930d2 [ticket/13354] Fix incorrect column name when deleting all topic logs.
PHPBB3-13354
2014-11-21 12:48:26 -08:00
Marc Alexander
352648f173 [ticket/13358] Fix tests and use exceptions instead of user object
PHPBB3-13358
2014-11-21 21:37:43 +01:00
Marc Alexander
f6e7a94bd5 [ticket/13358] Use file_downloader in get_remote_file()
get_remote_file() has been marked as deprecated.

PHPBB3-13358
2014-11-21 21:37:43 +01:00
Marc Alexander
2793f9c078 [ticket/13358] Add file_downloader to version_helper
PHPBB3-13358
2014-11-21 21:37:43 +01:00
Marc Alexander
a080173010 [ticket/13358] Add file_downloader as replacement for get_remote_file
PHPBB3-13358
2014-11-21 21:37:43 +01:00
Cesar G
f3373e1e32 [ticket/13316] Ensure Recaptcha image uses https when necessary.
PHPBB3-13316
2014-11-21 12:17:04 -08:00
Joas Schilling
f719803fdc Merge pull request #3144 from marc1706/ticket/13337
[ticket/13337] Do not use SQL IN comparison with empty array
2014-11-21 21:04:11 +01:00
Joas Schilling
d56da0d68f Merge pull request #3044 from Elsensee/ticket/13100
[ticket/13100] Display only confirmation buttons when deleting shadow topic
2014-11-21 20:59:22 +01:00
Joas Schilling
1689191f29 Merge pull request #3023 from Nicofuma/ticket/13133
[ticket/13133] Allow @vendor_name for includecss
2014-11-21 20:36:41 +01:00
Joas Schilling
973c2a9a3a Merge pull request #2765 from Elsensee/ticket/11863
[ticket/11863] Set require_activation to none if emails are disabled
2014-11-21 20:18:15 +01:00
Joas Schilling
707a85b6c1 Merge pull request #3043 from rxu/ticket/13182
[ticket/13182] Add posting.php core event to allow modifying the message text
2014-11-21 20:14:36 +01:00
Joas Schilling
71a015557f Merge pull request #3150 from omniError/ticket/13347
[ticket/13347] missing acp_forums template events

Conflicts:
	phpBB/docs/events.md
2014-11-21 20:09:13 +01:00
Joas Schilling
bc52a84998 Merge pull request #3131 from omniError/ticket/13328
[ticket/13328] add core.mcp_view_forum_modify_sql
2014-11-21 20:05:19 +01:00
Joas Schilling
d6e8cce44b Merge pull request #3130 from omniError/ticket/13326
[ticket/13326] add viewtopic_url to event
2014-11-21 19:58:43 +01:00
Joas Schilling
2d6734cb0a Merge pull request #3126 from VSEphpbb/ticket/13290
[ticket/13290] Add EVENT index_body_forumlist_body_after
2014-11-21 19:53:15 +01:00
Joas Schilling
7bc1917908 Merge pull request #3122 from Elsensee/ticket/13309
[ticket/13309] Add event acp_email_options_after
2014-11-21 19:42:14 +01:00
rxu
bb75cd40f5 [ticket/13182] Add posting.php core event to allow modifying the message text
posting.php core event to allow modifying the message before parsing
would be needed for some extensions, like for adding topic title to the
topic URL etc.
Also removed 'delete' var from core.posting_modify_template_vars and
core.modify_posting_parameters as it does not exist.

PHPBB3-13182
2014-11-22 01:33:12 +07:00
Joas Schilling
4bf3dcbebd Merge pull request #3114 from rxu/ticket/13294
[ticket/13294] Add function parse() core event for additional message checks
2014-11-21 19:28:07 +01:00
Joas Schilling
c31b53942d Merge pull request #3071 from rxu/ticket/13220
[ticket/13220] Add template events to memberlist_search.html
2014-11-21 19:23:10 +01:00
rxu
1e867ce52b [ticket/13294] Add function parse() core event for additional message checks
Add core event to the function parse() in includes/message_parser.php to allow
additional handling message before parsing (i.e. perform custom message
checks, cleanup etc.).

PHPBB3-13294
2014-11-20 00:47:51 +07:00
Tristan Darricau
acfe6dd37d Merge pull request #3149 from prototech/ticket/13342
[ticket/13342] Fix invalid resetting of CAPTCHA plugin when using Recaptcha

* prototech/ticket/13342:
  [ticket/13342] Fix invalid resetting of CAPTCHA plugin when using Recaptcha.
2014-11-18 16:28:59 +01:00
Tristan Darricau
0019039bc1 Merge pull request #3148 from prototech/ticket/13315
[ticket/13315] Fix loss of CAPTCHA plugin config value.

* prototech/ticket/13315:
  [ticket/13315] Check for the includes/captcha/plugins/ directory instead.
  [ticket/13315] Fix loss of CAPTCHA plugin config value.
2014-11-18 15:11:07 +01:00
Marc Alexander
ba3e4da853 Merge pull request #3154 from cyberalien/ticket/13349
[ticket/13349] Fix breadcrumb arrow entity
2014-11-18 15:00:45 +01:00
cyberalien
795fd75d60 [ticket/13349] Fix breadcrumb arrow entity
PHPBB3-13349
2014-11-18 14:13:07 +02:00
Marc Alexander
b84d151afa Merge pull request #3151 from nickvergessen/ticket/13298
[ticket/13298] Add missing $db->freeresult(); calls in functions_admin.php
2014-11-18 13:11:55 +01:00
Marc Alexander
17d76de7b8 Merge pull request #3152 from prototech/ticket/13277
[ticket/13277] Force IE to not cache AJAX requests.
2014-11-18 13:08:58 +01:00
Cesar G
052fdcc8d9 Merge remote-tracking branch 'Nicofuma/ticket/13023' into develop-ascraeus
* Nicofuma/ticket/13023:
  [ticket/13023] Add template event posting_editor_buttons_custom_tags_before
2014-11-18 01:30:06 -08:00
Cesar G
266755bd82 [ticket/13277] Force IE to not cache AJAX requests.
Caching causes problems, such as the inability to move a forum/CPF/module in the
same direction by more than one row.

PHPBB3-13277
2014-11-18 00:41:57 -08:00
Cesar G
7c68964153 [ticket/13315] Check for the includes/captcha/plugins/ directory instead.
PHPBB3-13315
2014-11-18 00:37:07 -08:00
Joas Schilling
31c59cad83 [ticket/13298] Add missing $db->freeresult(); calls in functions_admin.php
PHPBB3-13298
2014-11-17 23:56:33 +01:00
Joas Schilling
4f96688bf7 Merge pull request #3145 from bantu/ticket/13338
[ticket/13338] Make all tests run on their own. Avoid _test suffix for abstract test case classes.
2014-11-17 23:32:45 +01:00
omniError
c1a0d1bf3d [ticket/13347] update event docs
PHPBB3-13347
2014-11-17 16:25:56 -06:00
omniError
115bf63538 [ticket/13347] fix CS
PHPBB3-13347
2014-11-17 16:14:57 -06:00
omniError
bd0107a2ab [ticket/13347] missing acp_forums template events
PHPBB3-13347
2014-11-17 16:09:40 -06:00
Joas Schilling
f261c748b6 Merge branch 'develop-olympus' into develop-ascraeus 2014-11-17 22:47:46 +01:00
Joas Schilling
2b55476df0 Merge pull request #3147 from bantu/ticket/13341-ascraeus
[ticket/13341] Change coverage to whitelist to prevent errors with temp files
2014-11-17 22:47:41 +01:00
Joas Schilling
d4fd5e3365 Merge pull request #3146 from bantu/ticket/13341
[ticket/13341] Change coverage to whitelist to prevent errors with temp ...
2014-11-17 22:47:17 +01:00
Andreas Fischer
21c8985fe8 [ticket/13338] Add include statements for dependencies.
PHPBB3-13338
2014-11-17 21:54:02 +01:00
Andreas Fischer
765d72d194 [ticket/13338] Do not use the _test.php suffix for abstract test case classes.
PHPBB3-13338
2014-11-17 21:53:27 +01:00
Andreas Fischer
a918abe113 [ticket/13338] Move insert_config_array_test to functions_acp, add deps.
PHPBB3-13338
2014-11-17 21:53:27 +01:00
Cesar G
7b33018ade [ticket/13315] Fix loss of CAPTCHA plugin config value.
The plugins were moved to phpbb/captcha/plugins/ after this migration was
created, thus the check is no longer valid and ends up resetting the value
prematurely.

PHPBB3-13315
2014-11-16 17:01:38 -08:00
Cesar G
fb34cbf7cd [ticket/13342] Fix invalid resetting of CAPTCHA plugin when using Recaptcha.
The Recaptcha plugin class name does not follow the phpbb_captcha_ prefix
convention as all others. Instead it simply uses phpbb_, hence the check
for its existence under phpbb/captcha/plugins/ fails.

PHPBB3-13342
2014-11-16 17:01:03 -08:00
Nils Adermann
4ffdb12938 Merge remote-tracking branch 'github-nicofuma/ticket/13280' into develop-ascraeus
* github-nicofuma/ticket/13280:
  [ticket/13280] Output escaping for the symfony request object
  [ticket/13280] Add new tests
  [ticket/13280] Make the tests failing
  [ticket/13280] Revert "Merge pull request #3107 from marc1706/ticket/13280"
2014-11-16 16:50:15 +01:00
Tristan Darricau
0dfe1d0d8b [ticket/13280] Output escaping for the symfony request object
PHPBB3-13280
2014-11-16 16:45:19 +01:00
Tristan Darricau
e27b69f42a Merge pull request #3136 from marc1706/ticket/13332
[ticket/13332] Pass user row to passwords manager check method

* marc1706/ticket/13332:
  [ticket/13332] Fix auth provider tests
  [ticket/13332] Remove useless $result assignment
  [ticket/13332] Pass user row to passwords manager check method
2014-11-16 12:22:51 +01:00
Tristan Darricau
074b91497b [ticket/13023] Add template event posting_editor_buttons_custom_tags_before
PHPBB3-13023
2014-11-16 11:52:30 +01:00
Andreas Fischer
8297f700d0 Merge pull request #3146 from bantu/ticket/13341
[ticket/13341] Change coverage to whitelist to prevent errors with temp ...

* bantu/ticket/13341:
  [ticket/13341] Change coverage to whitelist to prevent errors with temp files.

Conflicts:
	phpunit.xml.dist
2014-11-14 17:27:15 +01:00
Andreas Fischer
c40d7f0896 [ticket/13341] Change coverage to whitelist to prevent errors with temp files.
b4f95deefc suggests that this can lead to issues
with classes having the same name. However, this does not seem to be a problem
with the current version of PHPUnit we are using.

Despite https://phpunit.de/manual/4.1/en/code-coverage-analysis.html saying
that addUncoveredFilesFromWhitelist="true" is optional, this seems to be on by
default in PHPUnit 4.1.0. As a result, all files are considered for code
coverage; which is what we want.

processUncoveredFilesFromWhitelist is however false (by default) and as such
even files that are considered for code coverage are not processed through PHP
when not used in actual tests. Since it is already impossible to test multiple
classes with the same name in the same test run (without process isolation),
because that would already lead to "cannot redeclare class" errors, it is also
impossible for "cannot redeclare class" errors to happen in test coverage.

PHPBB3-13341
2014-11-14 13:44:42 +01:00
Marc Alexander
556565d072 [ticket/13337] Allow empty array passed to sql_in_set()
is_array() will evaluate to true even if the array is just an empty array.
Make sure we also expect an empty array passed to sql_in_set().

PHPBB3-13337
2014-11-14 11:08:35 +01:00
omniError
8a9c2c055c [ticket/13306] update test
https://tracker.phpbb.com/browse/PHPBB3-13306

PHPBB3-13306
2014-11-13 20:55:20 -06:00
omniError
0a4ffb7cf8 [ticket/13306] move error_reporting call
https://tracker.phpbb.com/browse/PHPBB3-13306

PHPBB3-13306
2014-11-13 20:55:10 -06:00
Marc Alexander
c9db08873f Merge pull request #3141 from bantu/ticket/13325
[ticket/13325] Make installing composer dependencies in tests folder optional.
2014-11-13 17:11:48 +01:00
Marc Alexander
9f9ce10f2f Merge pull request #3125 from lavigor/ticket/13318
[ticket/13318] login_username needs to have the multibyte parameter set to true
2014-11-13 01:02:49 +01:00
Marc Alexander
2f54ab0a24 Merge pull request #3137 from prototech/ticket/13209
[ticket/13209] Fix loss of CPF language field values when switching steps
2014-11-13 00:14:54 +01:00
Joas Schilling
a520edb8fa Merge branch 'develop-olympus' into develop-ascraeus 2014-11-12 23:04:10 +01:00
Joas Schilling
12fd9a8827 Merge pull request #3143 from bantu/ticket/13331-ascraeus
[ticket/13331] Use docs target for this branch, add docs-all for all branches
2014-11-12 23:04:07 +01:00
Joas Schilling
b99fbd0be0 Merge pull request #3142 from bantu/ticket/13331
[ticket/13331] Use docs target for this branch, add docs-all for all branches
2014-11-12 22:55:30 +01:00
Andreas Fischer
968360fed6 [ticket/13331] Remove travis/sami.conf.php. Use build/sami-checkout.conf.php.
PHPBB3-13331
2014-11-12 21:45:03 +01:00
Andreas Fischer
0103478521 Merge pull request #3142 from bantu/ticket/13331
[ticket/13331] Use docs target for this branch, add docs-all for all branches

* bantu/ticket/13331:
  [ticket/13331] Use docs target for this branch, add docs-all for dev branches.

Conflicts:
	build/build.xml
	build/sami-checkout.conf.php
2014-11-12 21:43:56 +01:00
Andreas Fischer
b55d744e77 [ticket/13331] Use docs target for this branch, add docs-all for dev branches.
PHPBB3-13331
2014-11-12 21:40:26 +01:00
Andreas Fischer
1e4ff6105a [ticket/13325] Make installing composer dependencies in tests folder optional.
Make phpbb_ui_test_case available unconditionally. Nothing depends on 5.3.19
here. Remove __init__ include. Composer classmap autoloading ensures classes
can be loaded.

PHPBB3-13325
2014-11-12 20:34:36 +01:00
Andreas Fischer
8df63a4499 [ticket/13325] Remove whitespace at end of line.
PHPBB3-13325
2014-11-12 20:32:36 +01:00
Andreas Fischer
e1bf699ad4 [ticket/13325] Update / Fix composer.lock hash.
PHPBB3-13325
2014-11-12 20:31:41 +01:00
Tristan Darricau
526a97db7c [ticket/13280] Add new tests
PHPBB3-13280
2014-11-12 15:43:20 +01:00
Tristan Darricau
f142ed28e4 [ticket/13280] Make the tests failing
PHPBB3-13280
2014-11-12 15:43:12 +01:00
Tristan Darricau
6d533d2f86 [ticket/13280] Revert "Merge pull request #3107 from marc1706/ticket/13280"
This reverts commit a1b58d05d1, reversing
changes made to 0e772afb9d.

PHPBB3-13280
2014-11-12 15:42:23 +01:00
Marc Alexander
09ad1d529e Merge pull request #3139 from prototech/ticket/13239
[ticket/13239] Ensure "Add files" button position is correctly calculated.
2014-11-12 13:04:46 +01:00
Marc Alexander
63022f3c59 [ticket/13332] Fix auth provider tests
PHPBB3-13332
2014-11-12 11:42:08 +01:00
omniError
834a93f76c [ticket/13306] allow 0 error types
https://tracker.phpbb.com/browse/PHPBB3-13306

PHPBB3-13306
2014-11-11 20:23:13 -06:00
omniError
efd4b43c1b [ticket/13306] constructor sets error types
https://tracker.phpbb.com/browse/PHPBB3-13306

PHPBB3-13306
2014-11-11 20:20:52 -06:00
Cesar G
430c6aa32f [ticket/13239] Ensure "Add files" button position is correctly calculated.
PHPBB3-13239
2014-11-11 17:30:34 -08:00
Cesar G
d43f196fa6 [ticket/12642] Ensure CPF type specific options are set when editing booleans.
prepare_hidden_fields is expected to return null if the option is not sent
in the request. The boolean method returns false instead, which results in
the options being set as false in hidden fields when accessing the first edit
step.

When checking the "Default value" option, there is also a failure to check
whether the "Field type" option is set to checkbox, thus resulting in this
option getting lost as well.

PHPBB3-12642
2014-11-11 16:48:25 -08:00
Cesar G
ec220d6494 [ticket/13209] Gather language field values for boolean CPF's in all steps.
The user can move back and forth between all three steps and as such the lang
field data should be expected in all steps.

PHPBB3-13209
2014-11-11 16:32:04 -08:00
Cesar G
3108d0b060 [ticket/13209] Fix expected request value of CPF language fields.
Multiple languages can be edited, thus the expected value is an array.

PHPBB3-13209
2014-11-11 16:28:06 -08:00
Marc Alexander
91f7d53d8e [ticket/13332] Remove useless $result assignment
PHPBB3-13332
2014-11-11 19:02:20 +01:00
Marc Alexander
040fc6dd0f [ticket/13332] Pass user row to passwords manager check method
PHPBB3-13332
2014-11-11 19:02:01 +01:00
omniError
65f83b814c [ticket/13326] fix CS
https://tracker.phpbb.com/browse/PHPBB3-13326

PHPBB3-13326
2014-11-11 10:51:03 -06:00
omniError
b648d3eb4c [ticket/13328] fix CS
https://tracker.phpbb.com/browse/PHPBB3-13328

PHPBB3-13328
2014-11-11 10:47:39 -06:00
Tristan Darricau
cd6085ebdc Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/13324] Update sami/sami and fabpot/goutte for new zipball location.
2014-11-11 15:29:58 +01:00
Tristan Darricau
6949f64d28 Merge pull request #3133 from bantu/ticket/13324
[ticket/13324] Update sami/sami and fabpot/goutte for new zipball location

* bantu/ticket/13324:
  [ticket/13324] Update sami/sami and fabpot/goutte for new zipball location.
2014-11-11 15:27:53 +01:00
Andreas Fischer
9bd24e2efb [ticket/13324] Update sami/sami and fabpot/goutte for new zipball location.
PHPBB3-13324
2014-11-11 12:23:02 +01:00
Tristan Darricau
4dfd4e4cd3 Merge pull request #3112 from Elsensee/ticket/13083
[ticket/13083] Fix language string NO_ENTRIES for logs

* Elsensee/ticket/13083:
  [ticket/13083] Fix language string NO_ENTRIES for logs
2014-11-11 11:56:23 +01:00
omniError
71e0de5588 [ticket/13328] add core.mcp_view_forum_modify_sql
https://tracker.phpbb.com/browse/PHPBB3-13328

PHPBB3-13328
2014-11-10 22:57:54 -06:00
omniError
42b595e7e7 [ticket/13326] add viewtopic_url to event
https://tracker.phpbb.com/browse/PHPBB3-13326

PHPBB3-13326
2014-11-10 20:35:23 -06:00
omniError
a143a19b8b [ticket/13306] add error level to collector
https://tracker.phpbb.com/browse/PHPBB3-13306

PHPBB3-13306
2014-11-10 18:05:18 -06:00
omniError
2d0917c56e [ticket/13323] empty auth option in posting.php
https://tracker.phpbb.com/browse/PHPBB3-13323

PHPBB3-13323
2014-11-10 17:23:23 -06:00
Matt Friedman
971b30a76d [ticket/13290] Add EVENT index_body_forumlist_body_after
PHPBB3-13290
2014-11-10 13:56:52 -08:00
lavigor
8171087cfb [ticket/13318] login_username needs to have the multibyte parameter set to true
This is needed for usernames with UTF-8 characters.

PHPBB3-13318
2014-11-10 20:12:10 +03:00
Marc Alexander
9bb302b92c [ticket/security-169] Stop loop through referer dir in top directory
SECURITY-169
2014-11-09 23:00:39 +01:00
Marc Alexander
6a4cb42565 Merge pull request #3113 from prototech/ticket/13251
[ticket/13251] Escape container parameters defined from config.php.
2014-11-09 20:01:20 +01:00
Oliver Schramm
b6f0c789d5 [ticket/13310] Add event core.acp_email_modify_sql
PHPBB3-13310
2014-11-09 15:34:54 +01:00
rxu
483af1d036 [ticket/13297] Add unicode modifier to url/email regular expression patterns.
PHPBB3-13297
2014-11-09 20:59:14 +07:00
Joas Schilling
7ab774bc8d Merge pull request #3121 from Elsensee/ticket/13300
[ticket/13300] Don't show jabber in profile if jabber is disabled
2014-11-09 14:50:06 +01:00
Marc Alexander
f23634d580 [ticket/13197] Fix tabbing
PHPBB3-13197
2014-11-09 13:43:26 +01:00
Marc Alexander
8dd32c2bb5 [ticket/13197] Correctly format sql query
PHPBB3-13197
2014-11-09 13:07:38 +01:00
Marc Alexander
10b628a20a Merge pull request #3120 from Elsensee/ticket/13301
[ticket/13301] Fix called function in apche auth module
2014-11-09 10:42:30 +01:00
Marc Alexander
8e64652d80 Merge pull request #3119 from Elsensee/ticket/13243
[ticket/13243] Validate announcement entry for existence in version_helper
2014-11-09 10:38:48 +01:00
Oliver Schramm
054ab67771 [ticket/13310] Always use sql_build_query in acp_email.php
PHPBB3-13310
2014-11-09 02:46:50 +01:00
Oliver Schramm
98711450dd [ticket/13309] Add event acp_email_options_after
PHPBB3-13309
2014-11-09 02:31:20 +01:00
Oliver Schramm
ced316d88c [ticket/13300] Don't show jabber in profile if jabber is disabled
PHPBB3-13300
2014-11-09 02:22:39 +01:00
Oliver Schramm
c4628bd92a [ticket/13301] Fix called function in apche auth module
PHPBB3-13301
2014-11-09 01:37:28 +01:00
Oliver Schramm
3fba5e317a [ticket/13243] Validate announcement entry for existence in version_helper
PHPBB3-13243
2014-11-09 01:21:40 +01:00
Joas Schilling
101945acf9 Merge pull request #3110 from Elsensee/ticket/13242
[ticket/13242] Fix HTML validity
2014-11-09 00:39:19 +01:00
Cesar G
92c509bc48 Merge remote-tracking branch 'Elsensee/ticket/13265' into develop-ascraeus
* Elsensee/ticket/13265:
  [ticket/13265] Don't show link to edit own profile to those without permission
2014-11-08 13:53:11 -08:00
rxu
70641e701a [ticket/13220] Add template events to memberlist_search.html
PHPBB3-13220
2014-11-08 21:22:59 +07:00
Tristan Darricau
9aa8f44489 [ticket/13133] Rename $ok variable
PHPBB3-13133
2014-11-07 15:57:31 +01:00
Tristan Darricau
778e0e06f3 Merge pull request #3118 from prototech/ticket/13270
[ticket/13270] Make m_softdelete perm global for boards updated from 3.0.12.

* prototech/ticket/13270:
  [ticket/13270] Make m_softdelete perm global for boards updated from 3.0.12.
2014-11-07 15:19:35 +01:00
Tristan Darricau
8956ec0bd4 Merge pull request #3117 from prototech/ticket/13303
[ticket/13303] Speed up migration dependency calculation.

* prototech/ticket/13303:
  [ticket/13303] Speed up migration dependency calculation.
2014-11-07 11:38:40 +01:00
Cesar G
757e1eac7a [ticket/13270] Make m_softdelete perm global for boards updated from 3.0.12.
PHPBB3-13270
2014-11-07 02:31:11 -08:00
Cesar G
95140bb724 [ticket/13303] Speed up migration dependency calculation.
PHPBB3-13303
2014-11-07 02:30:44 -08:00
Cesar G
d60534d52c [ticket/13251] Escape container parameters defined from config.php.
PHPBB3-13251
2014-11-07 02:30:03 -08:00
Tristan Darricau
a1b58d05d1 Merge pull request #3107 from marc1706/ticket/13280
[ticket/13280] Properly format the current page and add sanitizer to tests

* marc1706/ticket/13280:
  [ticket/13280] Remove unneeded str_replace in build_url()
  [ticket/13280] Only run sanitizer for server superglobal and modify tests
  [ticket/13280] Seperate server sanitizer call and add comment
  [ticket/13280] Add additional sanitizer for ampersands in server superglobal
  [ticket/13280] Correctly format user page for build_url()
  [ticket/13280] Properly format the current page and add sanitizer to tests
2014-11-07 11:10:03 +01:00
Marc Alexander
f432193e07 [ticket/13280] Remove unneeded str_replace in build_url()
PHPBB3-13280
2014-11-06 13:45:09 +01:00
Oliver Schramm
25a7c6e829 [ticket/13083] Fix language string NO_ENTRIES for logs
The string was misleading because there does not
always have to be a period when viewing log entries.

PHPBB3-13083
2014-11-05 21:16:04 +01:00
Oliver Schramm
307fa831d6 [ticket/13265] Don't show link to edit own profile to those without permission
PHPBB3-13265
2014-11-05 21:06:32 +01:00
Oliver Schramm
85031a66cc [ticket/13242] Fix HTML validity
PHPBB3-13242
2014-11-05 20:59:38 +01:00
Oliver Schramm
32010de36e [ticket/13284] Set message body in topic form too, so it will be sent
PHPBB3-13284
2014-11-04 18:33:59 +01:00
Oliver Schramm
b32dc8c667 [ticket/13284] Fix request name so users can cc themselves
PHPBB3-13284
2014-11-04 18:22:46 +01:00
Marc Alexander
32881dbe31 [ticket/13280] Only run sanitizer for server superglobal and modify tests
PHPBB3-13280
2014-11-04 16:54:45 +01:00
Marc Alexander
3986470b3c [ticket/13280] Seperate server sanitizer call and add comment
PHPBB3-13280
2014-11-04 16:14:11 +01:00
Oliver Schramm
e502c8db86 [ticket/13100] Remove pointless variable
PHPBB3-13100
2014-11-04 00:46:06 +01:00
Marc Alexander
13b59af1ff [ticket/13280] Add additional sanitizer for ampersands in server superglobal
PHPBB3-13280
2014-11-03 17:27:01 +01:00
Marc Alexander
6fd092b5df [ticket/13280] Correctly format user page for build_url()
PHPBB3-13280
2014-11-03 16:24:09 +01:00
Marc Alexander
6cc7da0c9c [ticket/13280] Properly format the current page and add sanitizer to tests
PHPBB3-13280
2014-11-03 16:07:32 +01:00
Marc Alexander
0868831675 [ticket/13204] Tell user that password was incorrect when exceeding attempts
At the end of the login method, the captcha was entered correctly and only
the password was incorrect. Therefore, just tell the user that the password
was incorrect. He will see that he still needs to enter a captcha.

PHPBB3-13204
2014-11-02 11:18:08 +01:00
Nils Adermann
0e772afb9d Merge branch 'prep-release-3.1.1' into develop-ascraeus
* prep-release-3.1.1:
  [ticket/13271] Disable CC sender feature for anonymous users
  [prep-release-3.1.1] Add 3.1.1 CHANGELOG
  [prep-release-3.1.1] Add 3.1.1 migration file
  [ticket/13263] Make sure default style exists and clean up code
  [ticket/13263] Only install/set prosilver if no style available
  [ticket/13263] Use prosilver as default style if user's style doesn't exist
  [ticket/security-164] Correctly format page_name
  [ticket/security-164] Sanitize all global variables in symfony_request class
  [ticket/13248] Use functional framework login method in tests
  [ticket/13248] Correctly pass provider name
  [ticket/13248] Always use provider collection for getting provider
  [ticket/13248] Allow specifying different auth provider in provider collection
  [ticket/13248] Use auth provider collection for getting provider
  [ticket/13262] Mention htaccess file when updating from 3.0 to 3.1
  [ticket/13267] Update Automatic Update instructions to include vendor directory
  [ticket/13268] Properly append ternary result in get_existing_indexes()
  [prep-release-3.1.1] Update version number to 3.1.1

Conflicts:
	build/build.xml
	phpBB/includes/constants.php
	phpBB/install/schemas/schema_data.sql
2014-11-02 01:25:51 +01:00
Nils Adermann
b6a4f83c41 Merge remote-tracking branch 'github-security/ticket/security-164-alt' into prep-release-3.1.1
* github-security/ticket/security-164-alt:
  [ticket/security-164] Correctly format page_name
  [ticket/security-164] Sanitize all global variables in symfony_request class
2014-11-02 00:24:02 +01:00
Nils Adermann
c980402a4c Merge branch 'ticket/13271' into prep-release-3.1.1
* ticket/13271:
  [ticket/13271] Disable CC sender feature for anonymous users
2014-11-02 00:22:58 +01:00
Nils Adermann
27be69e3b3 [ticket/13271] Disable CC sender feature for anonymous users
PHPBB3-13271
2014-11-02 00:21:23 +01:00
Nils Adermann
aede89d408 [prep-release-3.1.1] Add 3.1.1 CHANGELOG 2014-11-02 00:20:44 +01:00
Nils Adermann
4ae9e8cf6e [prep-release-3.1.1] Add 3.1.1 migration file 2014-11-02 00:08:21 +01:00
Nils Adermann
0843fd4b77 Merge remote-tracking branch 'github-marc1706/ticket/13263' into prep-release-3.1.1
* github-marc1706/ticket/13263:
  [ticket/13263] Make sure default style exists and clean up code
  [ticket/13263] Only install/set prosilver if no style available
  [ticket/13263] Use prosilver as default style if user's style doesn't exist
2014-11-01 23:57:12 +01:00
Marc Alexander
7461536459 [ticket/13263] Make sure default style exists and clean up code
PHPBB3-13263
2014-11-01 23:53:58 +01:00
Marc Alexander
d1f85f0de3 [ticket/13263] Only install/set prosilver if no style available
Users that have a nonexistent style selectd will revert back to the default
style.

PHPBB3-13263
2014-11-01 23:53:53 +01:00
Marc Alexander
be8b5a41c8 [ticket/13263] Use prosilver as default style if user's style doesn't exist
If prosilver is not installed for whatever reason, it will be installed by
the newly added migration.

PHPBB3-13263
2014-11-01 23:53:48 +01:00
Marc Alexander
f534503a66 [ticket/security-164] Correctly format page_name
SECURITY-164
2014-11-01 22:43:28 +01:00
Marc Alexander
28ef238a5c [ticket/security-164] Sanitize all global variables in symfony_request class
SECURITY-164
2014-11-01 22:43:18 +01:00
Nils Adermann
dde1c7424f Merge pull request #3104 from marc1706/ticket/13248-alt
[ticket/13248] Login functions need to use provider collection for retrieving provider
2014-11-01 22:41:27 +01:00
Marc Alexander
8aec6b58e0 [ticket/13248] Use functional framework login method in tests
PHPBB3-13248
2014-11-01 21:54:34 +01:00
Marc Alexander
d9c868d0f5 [ticket/13248] Correctly pass provider name
PHPBB3-13248
2014-11-01 21:54:27 +01:00
Marc Alexander
a9249bce5e [ticket/13248] Always use provider collection for getting provider
PHPBB3-13248
2014-11-01 21:54:21 +01:00
Marc Alexander
c3f5dc75be [ticket/13248] Allow specifying different auth provider in provider collection
PHPBB3-13248
2014-11-01 21:54:14 +01:00
Marc Alexander
6b057e026c [ticket/13248] Use auth provider collection for getting provider
PHPBB3-13248
2014-11-01 21:54:06 +01:00
Nils Adermann
f3588c66ec Merge branch 'ticket/13262' into prep-release-3.1.1
* ticket/13262:
  [ticket/13262] Mention htaccess file when updating from 3.0 to 3.1
2014-11-01 19:14:11 +01:00
Matt Friedman
a269929f0e [ticket/13262] Mention htaccess file when updating from 3.0 to 3.1
PHPBB3-13262
2014-11-01 19:14:00 +01:00
Nils Adermann
45d054d295 Merge branch 'ticket/13267' into prep-release-3.1.1
* ticket/13267:
  [ticket/13267] Update Automatic Update instructions to include vendor directory
2014-11-01 19:13:21 +01:00
Patrick Webster
8bdbadabb2 [ticket/13267] Update Automatic Update instructions to include vendor directory
PHPBB3-13267
2014-11-01 19:13:09 +01:00
Nils Adermann
2cc9fe5267 Merge branch 'ticket/13268' into prep-release-3.1.1
* ticket/13268:
  [ticket/13268] Properly append ternary result in get_existing_indexes()
2014-11-01 19:12:43 +01:00
Patrick Webster
c3aca59cfb [ticket/13268] Properly append ternary result in get_existing_indexes()
PHPBB3-13268
2014-11-01 19:12:28 +01:00
Nils Adermann
3f3c8d74e8 [prep-release-3.1.1] Update version number to 3.1.1 2014-11-01 18:47:56 +01:00
Jakub Senko
4522db7624 [ticket/13266] Enable twig dump function
PHPBB3-13266
2014-11-01 12:31:58 +01:00
Marc Alexander
a61299a940 Merge pull request #3098 from VSEphpbb/ticket/13262
[ticket/13262] Mention htaccess file when updating from 3.0 to 3.1
2014-11-01 09:10:34 +01:00
Marc Alexander
af77106a2f Merge pull request #3097 from prototech/ticket/13253
[ticket/13253] Fix MCP queue link in active topics search.
2014-11-01 09:08:11 +01:00
Matt Friedman
416577f3dc [ticket/13262] Mention htaccess file when updating from 3.0 to 3.1
PHPBB3-13262
2014-10-31 13:08:36 -07:00
Cesar G
65c3f2a8f1 [ticket/13253] Fix MCP queue link in active topics search.
PHPBB3-13253
2014-10-30 22:47:51 -07:00
Andreas Fischer
17928563a2 Merge pull request #3093 from nickvergessen/ticket/13241
[ticket/13241] Fix pagination of viewforum with global announcements

* nickvergessen/ticket/13241:
  [ticket/13241] Remove sleep() and change flood interval instead
  [ticket/13241] Remove sleep() since the method takes care of this now
  [ticket/13241] Sleep for 1 second when posting twice in the same second
  [ticket/13241] Fix pagination with global announcements
  [ticket/13241] Correctly ignore announcements from topics list
  [ticket/13241] Add a functional test for viewforum with global announcement
2014-10-29 15:10:39 +01:00
Andreas Fischer
bb4f65d743 Merge pull request #3076 from marc1706/ticket/12703
[ticket/12703] Only query database for subscription types once

* marc1706/ticket/12703:
  [ticket/12703] Only query database for subscription types once
2014-10-29 15:09:55 +01:00
Andreas Fischer
932b75c166 Merge pull request #3065 from dhruvgoel92/feature/phantom
[feature/phantom]

* dhruvgoel92/feature/phantom:
  [ticket/12962] Rename setup-phpbb-test
  [ticket/12962] Use phpVersion in phpunit.xml
  [ticket/12962] Functional tests run for php <5.3.19
  [ticket/12962] Clean up composer.json
  [ticket/12962] Fix Line Endings in bootstrap
  [ticket/12962] Load composer test dependencies for php >= 5.3.19
  [ticket/12962] bootstrap functional and ui test when php >5.3.19
  [ticket/12962] Install test dependencies on travis
  [ticket/12962] Add facebook/webdriver dependency
  [ticket/12962] Fix whitespace characters
  [ticket/12962] Run tests for all databases on Travis
  [ticket/12962] Force language=en for UI tests installation
  [ticket/12962] Dump server output to /dev/null
  [ticket/12962] Start phantomjs on travis in background
  [ticket/12962] Mark test skipped when phantom server not running
  [ticket/12962] Add setup-phantomjs-server.sh
  [ticket/12962] Run UI tests on Travis-mysql
  [ticket/12962] Add UI tests to phpunit.xml.dist
  [ticket/12962] Add quick-links JS test
  [ticket/12962] Add initial class for ui_testing
2014-10-29 15:09:22 +01:00
Joas Schilling
1787ccb585 [ticket/13241] Remove sleep() and change flood interval instead
PHPBB3-13241
2014-10-29 14:17:15 +01:00
Joas Schilling
b868886b25 [ticket/13241] Remove sleep() since the method takes care of this now
PHPBB3-13241
2014-10-29 13:42:44 +01:00
Joas Schilling
e42202e794 [ticket/13241] Sleep for 1 second when posting twice in the same second
PHPBB3-13241
2014-10-29 13:42:43 +01:00
Joas Schilling
9ee177573d [ticket/13241] Fix pagination with global announcements
PHPBB3-13241
2014-10-29 13:42:42 +01:00
Joas Schilling
ae6a3b03c4 [ticket/13241] Correctly ignore announcements from topics list
PHPBB3-13241
2014-10-29 13:42:41 +01:00
Joas Schilling
82aed75b3b [ticket/13241] Add a functional test for viewforum with global announcement
PHPBB3-13241
2014-10-29 13:42:41 +01:00
Joas Schilling
3a2ccd079e Merge branch 'prep-release-3.1.0' into develop-ascraeus 2014-10-28 13:35:27 +01:00
Joas Schilling
197fed16bd [prep-release-3.1.0] Update changelog with final changes 2014-10-28 13:08:52 +01:00
Joas Schilling
c57fbe9d0d Merge branch 'prep-release-3.1.0' into develop-ascraeus 2014-10-28 12:58:45 +01:00
Joas Schilling
12033bc499 Merge branch 'develop-olympus' into prep-release-3.1.0
Conflicts:
	phpBB/phpbb/session.php
2014-10-28 12:57:38 +01:00
Joas Schilling
71c19f6eb7 Merge pull request #3091 from Nicofuma/ticket/13234-2
Ticket/13234 2
2014-10-28 12:56:47 +01:00
Joas Schilling
d2cd24e875 Merge pull request #3090 from Nicofuma/ticket/13234
Ticket/13234
2014-10-28 12:56:15 +01:00
Tristan Darricau
9036edd935 [ticket/13234] Merge branch 'ticket/13234' into ticket/13234-2
* ticket/13234:
  [ticket/13234] Fix conditions and CS

Conflicts:
	phpBB/phpbb/session.php

PHPBB3-13234
2014-10-28 12:27:16 +01:00
Tristan Darricau
fcc320e385 [ticket/13234] Fix conditions and CS
PHPBB3-13234
2014-10-28 12:19:53 +01:00
Joas Schilling
0682e5719d Merge branch 'prep-release-3.1.0' into develop-ascraeus 2014-10-28 10:02:53 +01:00
Joas Schilling
679559ce18 Merge branch 'naderman-ticket/13232' into prep-release-3.1.0 2014-10-28 10:02:33 +01:00
Joas Schilling
2e814cc43f [ticket/13232] Fix spaces vs tabs
PHPBB3-13232
2014-10-28 10:01:28 +01:00
Nils Adermann
087a5363bb [ticket/13234-2] Correctly verify that user_id is set in user data array
PHPBB3-13234-2
2014-10-27 23:56:20 -07:00
Nils Adermann
3472b6c5bc [ticket/13234-2] Never allow autologin/remember me to modify the userid
Ascraeus version of 64d97d0787 commit

PHPBB3-13234
2014-10-27 19:58:32 -07:00
Nils Adermann
e1277c26ca Merge branch 'ticket/13234' into ticket/13234-2
* ticket/13234:
  [ticket/13234] Never allow autologin/remember me to modify the userid
2014-10-27 19:57:16 -07:00
Nils Adermann
64d97d0787 [ticket/13234] Never allow autologin/remember me to modify the userid
This prevents admin relogin with forced user id from overwriting
remember me cookies

PHPBB3-13234
2014-10-27 19:55:56 -07:00
Nils Adermann
b9c08cddd4 Merge branch 'prep-release-3.1.0' into develop-ascraeus
* prep-release-3.1.0:
  [ticket/13227] Properly handle curlwrapper headers in remote avatars
  [ticket/13231] Update the dependencies of the migration contact_admin_form
2014-10-27 19:04:01 -07:00
Nils Adermann
dccbd573e8 [ticket/13232] Ensure prune cron job always gets run in prune test
The cron scheduler might pick a different task but we don't want to go
through them all to find the one we need. So we just make sure cron is
run at all and then manually run the one we want.

PHPBB3-13232
2014-10-27 19:00:23 -07:00
Nils Adermann
efe3aaaf0b Merge pull request #3085 from naderman/ticket/13227
[ticket/13227] Properly handle curlwrapper headers in remote avatars
2014-10-27 18:58:11 -07:00
Nils Adermann
df1212ce27 Merge pull request #3083 from Nicofuma/ticket/13231
[ticket/13231] Update the dependencies of the migration contact_admin_form
2014-10-27 18:51:47 -07:00
Nils Adermann
4c75f013de Merge branch 'prep-release-3.1.0' into develop-ascraeus
* prep-release-3.1.0:
  [ticket/13229] Fix overloading memberlist with redundant SQL queries
2014-10-27 17:01:57 -07:00
Nils Adermann
1f31e8e243 Merge branch 'ticket/13229' into prep-release-3.1.0
* ticket/13229:
  [ticket/13229] Fix overloading memberlist with redundant SQL queries
2014-10-27 17:01:46 -07:00
rxu
16d78407db [ticket/13229] Fix overloading memberlist with redundant SQL queries
PHPBB3-13229
2014-10-27 17:01:29 -07:00
Nils Adermann
4e4c3de103 [ticket/13227] Properly handle curlwrapper headers in remote avatars
Read a bit of the file to ensure header values are populated and then
handle headers in the nested array structure too.

PHPBB3-13227
2014-10-27 16:49:30 -07:00
Nils Adermann
dbaee1a5da Merge pull request #4 from nickvergessen/naderman-ticket/13232
[ticket/13232] Fix more issues with TTL and global cache file
2014-10-27 16:36:39 -07:00
Joas Schilling
6380aea647 [ticket/13232] Fix more issues with TTL and global cache file
PHPBB3-13232
2014-10-28 00:34:51 +01:00
Tristan Darricau
47663a4ad3 [ticket/13231] Update the dependencies of the migration contact_admin_form
PHPBB3-13231
2014-10-27 23:45:24 +01:00
Nils Adermann
0cdd071230 [ticket/13232] Fix indentation
PHPBB3-13232
2014-10-27 15:45:24 -07:00
Nils Adermann
df5366a5ca [ticket/13232] Use a cache var with _ to force TTL and shuffle cron tasks
PHPBB3-13232
2014-10-27 15:42:26 -07:00
Joas Schilling
91a9d25a38 Merge branch 'prep-release-3.1.0' into develop-ascraeus 2014-10-27 23:40:04 +01:00
Joas Schilling
aa916fc43f Merge pull request #3077 from marc1706/ticket/13225
[ticket/13225] Use passwords manager instead of phpbb_hash in migration
2014-10-27 23:38:53 +01:00
Dhruv
505ee586ff [ticket/12962] Rename setup-phpbb-test
PHPBB3-12962
2014-10-27 18:36:33 -04:00
Marc Alexander
b295fa4f4f [ticket/13225] Prefix converted passwords with $CP$ in phpBB 3.0.5-RC1
PHPBB3-13225
2014-10-27 20:57:31 +01:00
Nils Adermann
b1d7386075 Merge branch 'prep-release-3.1.0' into develop-ascraeus
* prep-release-3.1.0:
  [ticket/13230] Add missing globals and missing request object for path helper
  [ticket/13226] Add functional test for group ranks
  [ticket/13226] Fix the usage of $rank_img
2014-10-27 12:25:41 -07:00
Nils Adermann
d693d91e26 Merge remote-tracking branch 'github-nicofuma/ticket/13226' into prep-release-3.1.0
* github-nicofuma/ticket/13226:
  [ticket/13226] Add functional test for group ranks
  [ticket/13226] Fix the usage of $rank_img
2014-10-27 12:25:18 -07:00
Nils Adermann
decabb62c0 Merge pull request #3079 from nickvergessen/ticket/13230
[ticket/13230] Add missing globals and missing request object for path helper
2014-10-27 12:16:12 -07:00
Dhruv
cc82f95c8f [ticket/12962] Use phpVersion in phpunit.xml
PHPBB3-12962
2014-10-27 08:13:41 -07:00
Joas Schilling
47759eb096 [ticket/13230] Add missing globals and missing request object for path helper
PHPBB3-13230
2014-10-27 14:54:17 +01:00
Tristan Darricau
2e5cc62071 [ticket/13226] Add functional test for group ranks
PHPBB3-13226
2014-10-27 14:37:51 +01:00
Tristan Darricau
9ccb87675d [ticket/13226] Fix the usage of $rank_img
PHPBB3-13226
2014-10-27 10:00:24 +01:00
Dhruv
c6cca9d0d2 [ticket/12962] Functional tests run for php <5.3.19
PHPBB3-12962
2014-10-26 21:30:31 -07:00
Dhruv
98554475be [ticket/12962] Clean up composer.json
PHPBB3-12962
2014-10-26 20:58:21 -07:00
Marc Alexander
6cc5160d60 [ticket/13225] Use passwords manager instead of phpbb_hash in migration
PHPBB3-13225
2014-10-26 17:14:34 -07:00
Marc Alexander
cb65cd363a [ticket/12703] Only query database for subscription types once
PHPBB3-12703
2014-10-26 13:56:34 -07:00
Nils Adermann
222bec0204 Merge branch 'prep-release-3.1.0' into develop-ascraeus
* prep-release-3.1.0:
  [prep-release-3.1.0] Update CHANGELOG with last minute changes
2014-10-26 12:54:02 -07:00
Nils Adermann
51251293ab [prep-release-3.1.0] Update CHANGELOG with last minute changes 2014-10-26 12:53:45 -07:00
Nils Adermann
78aa120089 Merge branch 'prep-release-3.1.0' into develop-ascraeus
* prep-release-3.1.0:
  [ticket/13223] Fix USERNAME email template variable in notification
2014-10-26 12:48:25 -07:00
Nils Adermann
d5022d87e7 Merge branch 'ticket/13223' into prep-release-3.1.0
* ticket/13223:
  [ticket/13223] Fix USERNAME email template variable in notification
2014-10-26 12:48:16 -07:00
rxu
5431aa6391 [ticket/13223] Fix USERNAME email template variable in notification
admin_activate_user.php notification type is assigning usernames to email
template variables using user_loader->get_username() in 'no_profile' mode,
which in its turn calls get_username_string() function in 'no_profile' mode.
This causes HTML markup in emails for username colour.

PHPBB3-13223
2014-10-26 12:47:57 -07:00
Nils Adermann
c19ab58420 Merge branch 'prep-release-3.1.0' into develop-ascraeus
* prep-release-3.1.0:
  [ticket/13221] Add bot_update as a dependency to gold
  [ticket/13221] Perform bot updates after user table changes
2014-10-26 12:43:17 -07:00
Marc Alexander
b0942fe31d [ticket/13197] Test that user's group avatar is deleted by group avatar delete
PHPBB3-13197
2014-10-26 12:42:47 -07:00
Nils Adermann
7f347a290c Merge pull request #3073 from nickvergessen/ticket/13221
[ticket/13221] Perform bot updates after user table changes
2014-10-26 12:42:28 -07:00
Joas Schilling
0d1d836a89 [ticket/13221] Add bot_update as a dependency to gold
PHPBB3-13221
2014-10-26 20:03:46 +01:00
Joas Schilling
79d782c1d5 [ticket/13221] Perform bot updates after user table changes
PHPBB3-13221
2014-10-26 19:57:08 +01:00
Andreas Fischer
69cf5782d4 Merge pull request #3054 from Senky/ticket/13193
[ticket/13193] Post count in PMs not a link

* Senky/ticket/13193:
  [ticket/13193] Swap ternary condition members
  [ticket/13193] Make template more readable
  [ticket/13193] Add load_search config check
  [ticket/13193] Add link to post count in PMs
2014-10-26 14:20:33 +01:00
brunoais
1fc7bd107d [ticket/13141] Ups wrong version
PHPBB3-13141
2014-10-26 10:58:53 +00:00
brunoais
203f9c24d4 [ticket/13141] Implement core.mcp_global_f_read_auth_after
PHPBB3-13141
2014-10-26 10:58:23 +00:00
Jakub Senko
79274e904c [ticket/13193] Swap ternary condition members
PHPBB3-13193
2014-10-26 08:44:21 +01:00
Nils Adermann
5441a4ea13 Merge pull request #3067 from marc1706/ticket/13216
[ticket/13216] Use gmdate() instead of date() in datetime tests
2014-10-25 21:26:38 -07:00
Nils Adermann
5c1ef45488 Merge remote-tracking branch 'github-marc1706/ticket/13207' into develop-ascraeus
* github-marc1706/ticket/13207:
  [ticket/13207] Use assert_checkbox_is_checked for registration test
2014-10-25 21:01:51 -07:00
Nils Adermann
7a4b404af7 [develop-ascraeus] Update version number to 3.1.1-RC1-dev 2014-10-25 20:28:46 -07:00
Marc Alexander
1046ada9fc [ticket/13216] Use gmdate() instead of date() in datetime tests
PHPBB3-13216
2014-10-25 20:25:57 -07:00
Marc Alexander
cafd3b79fd [ticket/13207] Use assert_checkbox_is_checked for registration test
PHPBB3-13207
2014-10-25 20:05:25 -07:00
Nils Adermann
a5830fe0d5 Merge branch 'prep-release-3.1.0' into develop-ascraeus
* prep-release-3.1.0:
  [prep-release-3.1.0] Add missing CHANGELOG entries for RC6
2014-10-25 18:11:03 -07:00
Nils Adermann
5cee745fc5 [prep-release-3.1.0] Add missing CHANGELOG entries for RC6 2014-10-25 18:10:30 -07:00
Dhruv
1c88a2cb25 [ticket/12962] Fix Line Endings in bootstrap
PHPBB3-12962
2014-10-25 17:33:47 -07:00
Nils Adermann
9c95831f35 Merge branch 'prep-release-3.1.0' into develop-ascraeus
* prep-release-3.1.0:
  [prep-release-3.1.0] Add CHANGELOG for 3.1.0
2014-10-25 17:12:34 -07:00
Nils Adermann
c789acc091 [prep-release-3.1.0] Add CHANGELOG for 3.1.0 2014-10-25 17:12:14 -07:00
Nils Adermann
8de93bee95 Merge branch 'prep-release-3.1.0' into develop-ascraeus
* prep-release-3.1.0:
  [prep-release-3.1.0] Add 3.1.0 gold release migration
2014-10-25 17:05:07 -07:00
Nils Adermann
f2e9c62a97 [prep-release-3.1.0] Add 3.1.0 gold release migration 2014-10-25 17:03:50 -07:00
Nils Adermann
26d4483d36 Merge branch 'prep-release-3.1.0' into develop-ascraeus
* prep-release-3.1.0:
  [ticket/13207] Add notification manager mock to user_add method in tests
  [ticket/13207] Move default user notifications settings to user_add()
  [ticket/13207] Add default subscription options for newly registered users
2014-10-25 16:56:05 -07:00
Nils Adermann
4859cec0c5 Merge remote-tracking branch 'github-marc1706/ticket/13207' into prep-release-3.1.0
* github-marc1706/ticket/13207:
  [ticket/13207] Add notification manager mock to user_add method in tests
  [ticket/13207] Move default user notifications settings to user_add()
  [ticket/13207] Add default subscription options for newly registered users
2014-10-25 16:55:29 -07:00
Marc Alexander
0dcb874c09 [ticket/13207] Add notification manager mock to user_add method in tests
PHPBB3-13207
2014-10-25 16:16:25 -07:00
Marc Alexander
1da1a70650 [ticket/13197] Also delete group avatar from users that have it set
PHPBB3-13197
2014-10-25 15:57:41 -07:00
Dhruv
e78210dc96 [ticket/12962] Load composer test dependencies for php >= 5.3.19
PHPBB3-12962
2014-10-25 15:34:39 -07:00
Marc Alexander
81ad381263 [ticket/13207] Move default user notifications settings to user_add()
PHPBB3-13207
2014-10-25 14:57:01 -07:00
Marc Alexander
18f24a2270 [ticket/13207] Add default subscription options for newly registered users
PHPBB3-13207
2014-10-25 14:50:01 -07:00
Nils Adermann
f22cd2d734 Merge branch 'prep-release-3.1.0' into develop-ascraeus
* prep-release-3.1.0:
  [ticket/13215] Update Symfony components to v2.3.21.
2014-10-25 14:01:54 -07:00
Nils Adermann
07e7cde560 Merge pull request #3062 from bantu/ticket/13215
[ticket/13215] Update Symfony components to v2.3.21.
2014-10-25 14:01:13 -07:00
Andreas Fischer
ad06f6dd71 [ticket/13215] Update Symfony components to v2.3.21.
PHPBB3-13215
2014-10-25 21:29:45 +02:00
Nils Adermann
9ea08aa4d7 Merge branch 'prep-release-3.1.0' into develop-ascraeus
* prep-release-3.1.0:
2014-10-25 12:09:55 -07:00
Nils Adermann
4e952ad443 Merge commit '078e0c1e440f7f906b670348e8da00141e245876' into prep-release-3.1.0
* commit '078e0c1e440f7f906b670348e8da00141e245876':
  [ticket/13211] Move console migrator output handler back to console folder
  [ticket/13211] Also use log wrapper output handler for console migrations
  [ticket/13211] Move console migrator output handler to db folder
  [ticket/13211] Add log wrapper for writing database updater to log file
  [ticket/13126] Add missing use statement
  [ticket/13126] Fix tests
  [ticket/13126] Change messages verbosity levels
  [ticket/13126] Move migrator_output_handler to an interface
  [ticket/13126] Extends migrator_output_handler instead of using a closure
  [ticket/13126] Improve the feedback when running the migrations
2014-10-25 12:09:20 -07:00
Nils Adermann
6308a442d1 Merge pull request #3060 from marc1706/ticket/13211
[ticket/13211] Add log wrapper for writing database updater to log file
2014-10-25 12:04:29 -07:00
Marc Alexander
078e0c1e44 [ticket/13211] Move console migrator output handler back to console folder
PHPBB3-13211
2014-10-25 12:03:13 -07:00
Marc Alexander
8443463006 [ticket/13211] Also use log wrapper output handler for console migrations
PHPBB3-13211
2014-10-25 11:55:15 -07:00
Andreas Fischer
d2e3198407 Merge branch 'prep-release-3.1.0' into develop-ascraeus
* prep-release-3.1.0:
  [ticket/13210] Use the correct config value
2014-10-25 19:50:26 +02:00
Andreas Fischer
a43879fe91 Merge pull request #3061 from Elsensee/ticket/13210
[ticket/13210] Use the correct config value

* Elsensee/ticket/13210:
  [ticket/13210] Use the correct config value
2014-10-25 19:48:33 +02:00
Andreas Fischer
103c929ff0 Merge branch 'prep-release-3.1.0' into develop-ascraeus
* prep-release-3.1.0:
  [ticket/13208] Add security issues to the final changelog
  [prep-release-3.1.0] Prepare Changelog
  [prep-release-3.1.0] Update version to 3.1.0
2014-10-25 19:39:50 +02:00
Oliver Schramm
a9a67b08a5 [ticket/13210] Use the correct config value
PHPBB3-13210
2014-10-25 14:28:56 +02:00
Marc Alexander
b27b9a6984 [ticket/13211] Move console migrator output handler to db folder
PHPBB3-13211
2014-10-24 13:33:26 -07:00
Marc Alexander
516bd9ea51 [ticket/13211] Add log wrapper for writing database updater to log file
PHPBB3-13211
2014-10-24 13:22:56 -07:00
Marc Alexander
14300a1475 Merge remote-tracking branch 'Nicofuma/ticket/13126' into ticket/13211 2014-10-24 13:22:39 -07:00
Marc Alexander
6217a51920 Merge pull request #3059 from nickvergessen/ticket/13208
[ticket/13208] Add security issues to the final changelog
2014-10-23 08:56:01 -04:00
Joas Schilling
c814483627 [ticket/13208] Add security issues to the final changelog
PHPBB3-13208
2014-10-23 12:36:27 +02:00
Joas Schilling
1cd09a03e6 [prep-release-3.1.0] Prepare Changelog 2014-10-23 12:25:52 +02:00
Joas Schilling
80a9c24b6b [prep-release-3.1.0] Update version to 3.1.0 2014-10-23 12:22:02 +02:00
Joas Schilling
08f365236a Merge branch 'prep-release-3.1.0-RC6' into develop-ascraeus 2014-10-23 02:44:45 +02:00
Joas Schilling
7a90184421 [prep-release-3.1.0-RC6] Update phpBB Version for RC7 development 2014-10-23 02:44:18 +02:00
Joas Schilling
5847a50334 [prep-release-3.1.0-RC6] Add changelog for 3.1.0-RC6 2014-10-23 01:57:59 +02:00
Joas Schilling
1ade9b39e4 [prep-release-3.1.0-RC6] Prepare Changelog 2014-10-23 01:55:48 +02:00
Joas Schilling
4c94e44710 [prep-release-3.1.0-RC6] Add migration for 3.1.0-RC6 2014-10-23 01:50:12 +02:00
Joas Schilling
d640a37984 [prep-release-3.1.0-RC6] Update version to 3.1.0-RC6 2014-10-23 01:48:38 +02:00
Joas Schilling
e4c8e4905c Merge pull request #3 from phpbb/ticket/security-161
[ticket/security-161] Add form token to styles management form.
2014-10-23 01:38:12 +02:00
Cesar G
4d30633cd4 [ticket/security-161] Add form token to styles management form.
SECURITY-161
2014-10-22 15:46:00 -07:00
Marc Alexander
6a0727acdc Merge pull request #3058 from naderman/ticket/13205
[ticket/13205] Add a mark all messages read link to PM folders
2014-10-22 17:39:13 -05:00
Nils Adermann
df72846b89 [ticket/13205] Explicitly cast ids to integers and reformat SQL
PHPBB3-13205
2014-10-22 18:35:07 -04:00
Nils Adermann
b5594371ab [ticket/13205] Remove superfluous newline
PHPBB3-13205
2014-10-22 18:31:29 -04:00
Nils Adermann
d7553893c4 Merge pull request #3057 from marc1706/ticket/security-159
[ticket/security-159] Only show first 8 characters of login keys in UCP
2014-10-22 18:20:46 -04:00
Nils Adermann
48dc4c02ae [ticket/13205] Add a mark all messages read link to PM folders
PHPBB3-13205
2014-10-22 18:02:43 -04:00
Marc Alexander
f796f92058 [ticket/security-159] Only show first 8 characters of login keys in UCP
SECURITY-159
2014-10-22 16:21:16 -05:00
Nils Adermann
fad280f94b Merge pull request #3056 from marc1706/ticket/13203
[ticket/13203] Use constant time comparison method for comparing password hashes
2014-10-22 16:57:50 -04:00
Marc Alexander
cf9d1fbd1a [ticket/13203] Fix passwords manager tests
PHPBB3-13203
2014-10-22 15:09:58 -05:00
Marc Alexander
0bc04a4df0 [ticket/13203] Use string_compare method in passwords drivers
PHPBB3-13203
2014-10-22 14:54:55 -05:00
Marc Alexander
2b47ef1266 [ticket/13203] Add method for byte by byte comparison to drivers helper
PHPBB3-13203
2014-10-22 14:54:22 -05:00
Tristan Darricau
fdece6cdf3 [ticket/13126] Add missing use statement
PHPBB3-13126
2014-10-22 15:25:50 +02:00
Marc Alexander
a623868f20 [ticket/13192] Pass correct parameters and rename method to get_valid_page
PHPBB3-13192
2014-10-21 22:38:03 -05:00
Marc Alexander
ce8c09f51f [ticket/13192] Use get_valid_user_page in confirm_box() and cleanup globals
The $request global existed twice and the $phpEx global is not being used
in confirm_box().

PHPBB3-13192
2014-10-21 22:17:48 -05:00
Marc Alexander
c381ad2002 [ticket/13192] Use get_valid_user_page method in build_url function
PHPBB3-13192
2014-10-21 22:17:24 -05:00
Marc Alexander
40497ec824 [ticket/13192] Add method for generating valid user page links
PHPBB3-13192
2014-10-21 22:16:53 -05:00
Marc Alexander
e43d1781bf Merge branch 'develop-olympus' into develop-ascraeus
Conflicts:
	phpBB/docs/AUTHORS
2014-10-21 19:24:48 -05:00
Marc Alexander
d51c1707e3 Merge pull request #3051 from nickvergessen/ticket/12120
[ticket/12120] Remove EXreaction from active authors
2014-10-21 19:22:11 -05:00
Marc Alexander
faec26b873 Merge pull request #3053 from Senky/ticket/13194
[ticket/13194] BBCode isn't parsed when issuing a warning for a post
2014-10-21 18:57:43 -05:00
Marc Alexander
0de7adfa37 Merge pull request #3052 from VSEphpbb/ticket/13041
[ticket/13041] Help_faq.php language file needs to be revised
2014-10-21 18:53:51 -05:00
Jakub Senko
5581a30f58 [ticket/13193] Make template more readable
PHPBB3-13193
2014-10-21 23:12:00 +02:00
Jakub Senko
0dcfcf5854 [ticket/13193] Add load_search config check
PHPBB3-13193
2014-10-21 22:53:59 +02:00
Jakub Senko
92f077a4e9 [ticket/13193] Add link to post count in PMs
PHPBB3-13193
2014-10-21 22:32:57 +02:00
Jakub Senko
defeb1a56f [ticket/13194] Use correct array to access bbcode_bitfield
PHPBB3-13194
2014-10-21 22:21:48 +02:00
Matt Friedman
4b99ab7066 [ticket/13041] Final grammar and language changes to help_faq
PHPBB3-13041
2014-10-21 09:54:25 -07:00
Joas Schilling
9cf81ac7f5 [ticket/12120] Remove EXreaction from active authors
PHPBB3-12120
2014-10-21 18:17:59 +02:00
Nils Adermann
1358acfd7c Merge pull request #3049 from marc1706/ticket/13189
[ticket/13189] Do not use confirm box for marking all notifications read
2014-10-21 09:49:16 -04:00
Marc Alexander
99eeb52b76 Merge pull request #3050 from prototech/ticket/13070
[ticket/13070] Adjust template hook name to match that provided in the class.
2014-10-20 22:44:33 -05:00
Cesar G
b9b15b7007 [ticket/13070] Adjust template hook name to match that provided in the class.
PHPBB3-13070
2014-10-20 19:59:56 -07:00
Marc Alexander
293d64e122 [ticket/13189] Do not use confirm box for marking all notifications read
We already use a token for preventing CSRF when marking notifications read.
Making a user confirm the marking read action serves no real purpose. No
information will be lost by just marking the notifications read but it will
prevent users from always having to confirm this action.

PHPBB3-13189
2014-10-20 21:55:36 -05:00
Andreas Fischer
b71cf56bda Merge pull request #3047 from Elsensee/ticket/13168
[ticket/13168] Fix mbstring warnings in ACP for PHP 5.6 compatibility

* Elsensee/ticket/13168:
  [ticket/13168] Fix mbstring warnings in ACP for PHP 5.6 compatibility
2014-10-20 23:20:42 +02:00
Andreas Fischer
afada9ed40 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/13168] Fix mbstring warnings in ACP for PHP 5.6 compatibility
2014-10-20 23:20:42 +02:00
Joas Schilling
75b6545bc2 Merge pull request #3040 from nickvergessen/ticket/13138-asc
[3.1] Ticket/13138 Only use cookie data when we do not force a user_id

Conflicts:
	phpBB/phpbb/session.php
2014-10-20 22:19:25 +02:00
Nils Adermann
973dfbf868 Merge pull request #3048 from naderman/ticket/13188
[ticket/13188] Add missing where clause to post_id query in sphinx index
2014-10-20 15:30:08 -04:00
Nils Adermann
99f63f39eb Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/13138] Do not use cookie data and autologin while forcing a user_id

Conflicts:
	phpBB/phpbb/session.php
2014-10-20 14:53:38 -04:00
Nils Adermann
d4faeb064b Merge pull request #3039 from nickvergessen/ticket/13138
[ticket/13138] Only use cookie data when we do not force a user_id
2014-10-20 14:49:29 -04:00
Tristan Darricau
981d3005f3 [ticket/13126] Fix tests
PHPBB3-13126
2014-10-20 20:46:11 +02:00
Tristan Darricau
faf4b03c43 [ticket/13126] Change messages verbosity levels
PHPBB3-13126
2014-10-20 19:42:54 +02:00
Tristan Darricau
8f6fcd2744 [ticket/13126] Move migrator_output_handler to an interface
PHPBB3-13126
2014-10-20 19:41:32 +02:00
Nils Adermann
941cf6979e [ticket/13188] Correctly format string concatenation
PHPBB3-13188
2014-10-20 12:20:44 -04:00
Nils Adermann
566c8a1bbc [ticket/13188] Add missing where clause to post_id query in sphinx index
PHPBB3-13188
2014-10-20 12:08:35 -04:00
Oliver Schramm
53f166274a [ticket/13168] Fix mbstring warnings in ACP for PHP 5.6 compatibility
PHPBB3-13168
2014-10-20 16:47:52 +02:00
Joas Schilling
57a575b5f0 Merge pull request #3046 from Elsensee/ticket/13187
[ticket/13187] Fix HTML validity of INSTALL.html
2014-10-20 16:28:44 +02:00
Oliver Schramm
51044167d1 [ticket/13187] Fix HTML validity of INSTALL.html
PHPBB3-13187
2014-10-20 15:36:27 +02:00
Joas Schilling
009d59335f Merge pull request #2960 from prototech/ticket/12568
[ticket/12568] Update user docs
2014-10-20 15:21:00 +02:00
Joas Schilling
ec5729a99f Merge pull request #3045 from Elsensee/ticket/13186
[ticket/13186] Don't show link on post count when search disabled
2014-10-20 14:23:46 +02:00
Oliver Schramm
86c472f4f7 [ticket/13186] Don't show link on post count when search disabled
PHPBB3-13186
2014-10-20 13:25:07 +02:00
Oliver Schramm
30213816ae [ticket/13100] Display only confirmation buttons when deleting shadow topic
PHPBB3-13100
2014-10-20 00:24:16 +02:00
Marc Alexander
c939f1b2c7 Merge pull request #3030 from Senky/ticket/13164
[ticket/13164] data sent to core.submit_post_end event does not include fresh post_visibility
2014-10-18 21:47:15 -04:00
Marc Alexander
b3421e397d Merge pull request #3041 from nickvergessen/ticket/13171
[ticket/13171] Check the correct (soft)delete permission when deleting in MCP
2014-10-18 17:59:48 -04:00
Dhruv Goel
c6272fca07 Merge pull request #3042 from naderman/ticket/13181
[ticket/13181] Replace database credentials with placeholders in sphinx conf
2014-10-19 01:28:36 +05:30
Nils Adermann
e7ad87e15f [ticket/13181] Replace database credentials with placeholders in sphinx conf
PHPBB3-13181
2014-10-18 12:32:39 -04:00
Mario Skouat
737894027a [ticket/13041] Added multiple changes
- Improper english in some sentences.
- Improper use of singular/plural in some sentences
- Replace "the board administrator" by "a board administrator"
- Update the category "Posting Issues" and "Subscriptions and Bookmarks"

PHPBB3-13041
2014-10-18 13:28:18 +02:00
Oliver Schramm
0ba3bd9aed [ticket/11863] Add functional test
PHPBB3-11863
2014-10-17 23:33:28 +02:00
Oliver Schramm
f049fcd604 [ticket/11863] Display warning to user because of activation method
PHPBB3-11863
2014-10-17 15:42:11 +02:00
Oliver Schramm
01df1d3301 [ticket/11863] Grey out unavailable activation methods when emails disabled
Further fall back to USER_ACTIVATION_DISABLE when emails are disabled
but evaluate it at runtime.

PHPBB3-11863
2014-10-17 15:40:03 +02:00
Joas Schilling
66342f5b89 [ticket/13171] Check the correct (soft)delete permission when deleting in MCP
PHPBB3-13171
2014-10-17 15:39:20 +02:00
Joas Schilling
dec6c7ea8c [ticket/13138] Type hint the variables for IDE usage
PHPBB3-13138
2014-10-17 14:53:56 +02:00
Joas Schilling
f847a1a567 [ticket/13138] Fix the session key tests
PHPBB3-13138
2014-10-17 14:50:14 +02:00
Cesar G
6763de2f25 [ticket/12568] Fix awkward use of "phpBB Limited."
PHPBB3-12568
2014-10-16 20:37:26 -07:00
Cesar G
09b6add6ee [ticket/12568] The "Purge cache" option in the Customise tab no longer exists.
PHPBB3-12568
2014-10-16 20:33:24 -07:00
Cesar G
810d249ca2 [ticket/12568] Update GitHub link.
PHPBB3-12568
2014-10-16 20:20:15 -07:00
Cesar G
29ea1c85b4 [ticket/12568] Fix typo - "directorie" -> "directories"
PHPBB3-12568
2014-10-16 20:18:52 -07:00
Cesar G
f19a6b9714 [ticket/12568] Remove various unnecessary references to phpBB3.
PHPBB3-12568
2014-10-16 20:17:01 -07:00
Cesar G
d06c2cf0f7 [ticket/12568] Update style installation instructions.
PHPBB3-12568
2014-10-16 19:47:02 -07:00
Cesar G
7e08109229 [ticket/12568] Update path to language pack installation page.
PHPBB3-12568
2014-10-16 19:47:02 -07:00
Cesar G
defd36ad7f [ticket/12568] Replace modifications explanation with extensions.
PHPBB3-12568
2014-10-16 19:47:02 -07:00
Cesar G
39e51e5599 Merge remote-tracking branch 'PayBas/ticket/12796' into develop-ascraeus
* PayBas/ticket/12796:
  [ticket/12796] Use dedicated lang vars
  [ticket/12796] Use &amp; in path
  [ticket/12796] Add view own profile to UCP (and vice versa)
2014-10-16 19:32:11 -07:00
Cesar G
6768490f69 Merge remote-tracking branch 'PayBas/ticket/13163' into develop-ascraeus
* PayBas/ticket/13163:
  [ticket/13163] Check for images
  [ticket/13163] Terminate timely when no data-last links exist
  [ticket/13163] Fix responsive link lists
2014-10-16 19:19:53 -07:00
Joas Schilling
55b97ffc27 Merge branch 'ticket/13138-2' into ticket/13138-asc
Conflicts:
	phpBB/phpbb/session.php
2014-10-16 12:48:13 +02:00
Joas Schilling
e7e016637b [ticket/13138] Do not use cookie data and autologin while forcing a user_id
PHPBB3-13138
2014-10-16 12:32:48 +02:00
Tristan Darricau
58075e25e8 [ticket/13126] Extends migrator_output_handler instead of using a closure
PHPBB3-13126
2014-10-16 01:34:23 +02:00
Joas Schilling
e1af6584d9 Merge pull request #3038 from prototech/ticket/12530
[ticket/12530] Move style and class to parent <a>.
2014-10-15 21:15:08 +02:00
Cesar G
23a513baec [ticket/12530] Move style and class to parent <a>.
PHPBB3-12530
2014-10-15 10:35:13 -07:00
Joas Schilling
b343bf783a Merge pull request #3037 from PayBas/ticket/13169
[ticket/13169] Fix RTL forms in responsive mode
2014-10-15 18:56:11 +02:00
Joas Schilling
8be701db0a Merge pull request #2938 from PayBas/ticket/12530
[ticket/12530] Fix captcha challange image breaking responsive layout
2014-10-15 18:47:45 +02:00
Joas Schilling
90771c1762 Merge pull request #3024 from marc1706/ticket/13124
[ticket/13124] Also trim spaces in front of comments except for first line
2014-10-15 18:31:46 +02:00
Joas Schilling
759950c1a6 Merge pull request #3036 from prototech/ticket/13177
[ticket/13177] Fix display of post count-based ranks in viewtopic.
2014-10-15 18:29:23 +02:00
PayBas
205be67622 [ticket/13169] Fix RTL forms in responsive mode
PHPBB3-13169
2014-10-15 17:08:11 +02:00
PayBas
1a128f9a76 [ticket/12796] Use dedicated lang vars
PHPBB3-12796
2014-10-15 16:07:01 +02:00
PayBas
223ae1dfc2 [ticket/13163] Check for images
PHPBB3-13163
2014-10-15 13:06:54 +02:00
PayBas
965894a875 [ticket/12530] Combine logo and TOS link into one
PHPBB3-12530
2014-10-15 12:08:55 +02:00
Cesar G
5c54e96aab [ticket/13177] Fix display of post count-based ranks in viewtopic.
PHPBB3-13177
2014-10-14 15:24:57 -07:00
Tristan Darricau
56d7c2c6ed [ticket/13126] Improve the feedback when running the migrations
PHPBB3-13126
2014-10-14 17:58:29 +02:00
Cesar G
df75b70f3e Merge remote-tracking branch 'PayBas/ticket/13174' into develop-ascraeus
* PayBas/ticket/13174:
  [ticket/13174] Add missing closing </div> to ucp_pm_viewmessage
2014-10-14 07:32:54 -07:00
PayBas
4bdae294cb [ticket/12796] Use &amp; in path
PHPBB3-12796
2014-10-14 12:58:07 +02:00
PayBas
253c6e1fc1 [ticket/12796] Add view own profile to UCP (and vice versa)
PHPBB3-12796
2014-10-14 10:59:03 +02:00
PayBas
9c4ba813d4 [ticket/13174] Add missing closing </div> to ucp_pm_viewmessage
PHPBB3-13174
2014-10-14 10:08:48 +02:00
PayBas
41d660dd98 [ticket/13163] Terminate timely when no data-last links exist
PHPBB3-13163
2014-10-14 00:05:22 +02:00
PayBas
36d1f87c5a [ticket/13163] Fix responsive link lists
PHPBB3-13163
2014-10-13 23:29:01 +02:00
Jakub Senko
9bc9e42c94 [ticket/13164] Fix syntax error
PHPBB3-13164
2014-10-11 17:58:41 +02:00
Jakub Senko
eb7152436c [ticket/13164] Add post_visibility to core.submit_post_end event
PHPBB3-13164
2014-10-11 16:56:03 +02:00
Mario Skouat
2bc79701e6 [ticket/13041] Added multiple changes
- Added the changes reported by VSE.

PHPBB3-13041
2014-10-11 10:43:01 +02:00
Tristan Darricau
29b54d12cc Merge pull request #3029 from nickvergessen/ticket/13161
Ticket/13161 PHP Warnings issued from phpbb database test case

* nickvergessen/ticket/13161:
  [ticket/13161] Check whether the schema exists, before deleting it
  [ticket/13161] Avoid problems when running tests with different migrations
2014-10-10 15:55:03 +02:00
Joas Schilling
1a04d15d4d [ticket/13161] Check whether the schema exists, before deleting it
PHPBB3-13161
2014-10-10 15:26:29 +02:00
Joas Schilling
f6fc8c08a4 [ticket/13161] Avoid problems when running tests with different migrations
PHPBB3-13161
2014-10-10 15:26:28 +02:00
Jakub Senko
699c642128 [ticket/13164] Update post_visibility before event is triggered
PHPBB3-13164
2014-10-10 14:24:46 +02:00
Tristan Darricau
d285363700 [ticket/13133] Add unit tests
PHPBB3-13133
2014-10-09 19:54:56 +02:00
Marc Alexander
a9ed32663a [ticket/13124] Add another test case as requested
PHPBB3-13124
2014-10-09 13:30:10 -04:00
Tristan Darricau
911831a9c5 [ticket/13133] Allow @vendor_name for includecss
PHPBB3-13133
2014-10-08 18:25:36 +02:00
Mario Skouat
97db218829 [ticket/13041] Added multiple changes
- "phpBB3" replaced by "phpBB"
- Added the changes suggested by VSE.
- "Subscriptions and Bookmarks" reviewed
- Added trailing comma on modified lines

PHPBB3-13041
2014-10-08 00:14:00 +02:00
Joas Schilling
5b186c936d Merge branch 'prep-release-3.1.0-RC5' into develop-ascraeus 2014-10-07 22:11:14 +02:00
Joas Schilling
eed4d0d30f [prep-release-3.1.0-RC5] Update phpBB Version for RC6 development 2014-10-07 22:10:45 +02:00
Joas Schilling
366451c11c [prep-release-3.1.0-RC5] Add changelog for 3.1.0-RC5 2014-10-07 21:16:34 +02:00
Joas Schilling
9d13b91f46 [prep-release-3.1.0-RC5] Prepare Changelog 2014-10-07 21:14:55 +02:00
Joas Schilling
7f692e7b28 [prep-release-3.1.0-RC5] Add migration for 3.1.0-RC5 2014-10-07 21:12:06 +02:00
Joas Schilling
7137dc387a [prep-release-3.1.0-RC5] Update version to 3.1.0-RC5 2014-10-07 21:10:14 +02:00
PayBas
757c67b7d8 [ticket/12530] Show logo and policy in responsive
PHPBB3-12530
2014-10-07 20:49:39 +02:00
Andreas Fischer
63bdd193e0 Merge pull request #3027 from nickvergessen/ticket/13137
[ticket/13137] Remove schema.json from repository

* nickvergessen/ticket/13137:
  [ticket/13137] Create schema.json in build script
  [ticket/13137] Improve output of create_schema_files.php
  [ticket/13137] Add schema.json file to .gitignore
  [ticket/13137] Generate the schema when the schema.json file is not available
  [ticket/13137] Remove schema.json file
2014-10-07 20:30:40 +02:00
PayBas
66ecbd8545 [ticket/12530] Fix captcha challange image breaking responsive layout
PHPBB3-12530
2014-10-07 18:30:20 +02:00
Joas Schilling
d64a515476 [ticket/13137] Create schema.json in build script
PHPBB3-13137
2014-10-07 17:18:00 +02:00
Joas Schilling
34a9ed3587 [ticket/13137] Improve output of create_schema_files.php
PHPBB3-13137
2014-10-07 17:17:59 +02:00
Joas Schilling
ba1776d6a9 [ticket/13137] Add schema.json file to .gitignore
PHPBB3-13137
2014-10-07 16:33:26 +02:00
Joas Schilling
4fe95d6870 [ticket/13137] Generate the schema when the schema.json file is not available
PHPBB3-13137
2014-10-07 14:55:08 +02:00
Joas Schilling
943f2e1a7b [ticket/13137] Remove schema.json file
PHPBB3-13137
2014-10-07 14:55:05 +02:00
Nils Adermann
c77d6f39f2 Merge pull request #3026 from nickvergessen/ticket/13136
[ticket/13136] Update schema.json with latest changes
2014-10-07 13:57:31 +02:00
Joas Schilling
7bd5c793bb [ticket/13136] Update schema.json with latest changes
PHPBB3-13136
2014-10-07 13:14:33 +02:00
Joas Schilling
61601a052c Merge pull request #2942 from Senky/ticket/12489
[ticket/12489] Description for Contact link in custom profile fields
2014-10-07 11:41:47 +02:00
Jakub Senko
0c0024497d [ticket/12489] Language correction
PHPBB3-12489
2014-10-07 10:24:30 +02:00
Andreas Fischer
46a9e5657f Merge pull request #3002 from Nicofuma/ticket/12987
[ticket/12987] Cleanup the services.yml file

* Nicofuma/ticket/12987:
  [ticket/12987] Cleanup the services.yml file
2014-10-07 00:51:11 +02:00
Joas Schilling
4b90357d79 Merge pull request #2307 from PayBas/ticket/12408
[ticket/12408] Add quick setting for "default guest style" to ACP
2014-10-06 23:43:27 +02:00
Andreas Fischer
38ac0bcc8e Merge pull request #2991 from nickvergessen/ticket/13077
[ticket/13077] Move extension module to the top of the Customise tab

* nickvergessen/ticket/13077:
  [ticket/13077] Move extension module to the top of the Customise tab
2014-10-06 23:35:35 +02:00
Joas Schilling
b300e06226 Merge branch 'develop-olympus' into develop-ascraeus 2014-10-06 23:21:19 +02:00
Joas Schilling
f3eaf6fe04 Merge pull request #3016 from Nicofuma/ticket/11224-ascraeus
[ticket/11224][ascraeus] SQL cache destroy does not destroy queries to tables joined
2014-10-06 23:21:13 +02:00
Joas Schilling
a12a7d0b90 Merge pull request #2460 from Nicofuma/ticket/11224
[ticket/11224] SQL cache destroy does not destroy queries to tables joined
2014-10-06 23:20:50 +02:00
Joas Schilling
7479c61d05 Merge pull request #2828 from brunoais/ticket/12930
[ticket/12930] core.ucp_pm_compose_compose_pm_quotepost_query_after
2014-10-06 22:37:48 +02:00
Joas Schilling
3c91fbeaa6 Merge pull request #2827 from brunoais/ticket/12929
[ticket/12929] core.ucp_pm_compose_compose_pm_basic_info_query_before
2014-10-06 22:25:08 +02:00
Joas Schilling
2f2a306994 Merge pull request #3019 from Senky/ticket/13025
[ticket/13025] Add template events for buttons on viewforum and viewtopic
2014-10-06 22:20:16 +02:00
Joas Schilling
6c284060d7 Merge pull request #3025 from rxu/ticket/13134
[ticket/13134] Add core event to the root of the function display_forums()
2014-10-06 22:10:33 +02:00
rxu
1e8735eac1 [ticket/13134] Add core event to the root of the function display_forums()
PHPBB3-13134
2014-10-07 01:47:01 +08:00
Marc Alexander
7bcf6a621f [ticket/13124] Fix tests for event exporter
PHPBB3-13124
2014-10-06 16:53:41 +02:00
Marc Alexander
825af557ae [ticket/13124] Also trim spaces in front of comments except for first line
PHPBB3-13124
2014-10-06 16:09:56 +02:00
Nils Adermann
5e86c89989 Merge pull request #3017 from nickvergessen/ticket/13033
[ticket/13033] Fix "Duplicate entry 'notification.type.*' for key 'type'"
2014-10-06 02:07:52 +02:00
Marc Alexander
ce4cb9c917 Merge pull request #3022 from Nicofuma/ticket/12368
[ticket/12368] Always clean the cache prior to run the migrations
2014-10-05 15:00:40 +02:00
Tristan Darricau
bda6879305 [ticket/12368] Always clean the cache prior to run the migrations
PHPBB3-12368
2014-10-05 12:25:14 +02:00
Jakub Senko
608d3f4d8d [ticket/13025] Correct events in subsilver2 viewforum_body
PHPBB3-13025
2014-10-04 11:38:21 +02:00
Jakub Senko
51ece03612 [ticket/13025] Make RC uppercase
PHPBB3-13025
2014-10-04 10:36:45 +02:00
Andreas Fischer
682527f509 Merge pull request #3018 from Senky/ticket/13125
[ticket/13125] Uploaded avatars are not displayed

* Senky/ticket/13125:
  [ticket/13125] $user->browser to $browser
2014-10-04 00:41:25 +02:00
Tristan Darricau
5354c46e01 [ticket/11224] Updates tests
PHPBB3-11224
2014-10-03 23:51:16 +02:00
Tristan Darricau
8e638dbf6d [ticket/11224] Revert Revert "Merge pull request #2460 from ticket/11224"
This reverts commit 40cd7570e6.
2014-10-03 23:50:24 +02:00
Jakub Senko
a0673f8e10 [ticket/13025] rc4 -> rc5
PHPBB3-13025
2014-10-03 13:18:41 +02:00
Jakub Senko
4193bf5641 [ticket/13025] Add button template events
PHPBB3-13025
2014-10-03 13:16:44 +02:00
Tristan Darricau
ebaec047f2 [ticket/12987] Cleanup the services.yml file
PHPBB3-12987
2014-10-03 00:32:08 +02:00
Joas Schilling
3d9b257597 [ticket/13033] Fix "Duplicate entry 'notification.type.*' for key 'type'"
Caused by the solution of PHPBB3-12990

PHPBB3-13033
2014-10-02 16:04:33 +02:00
brunoais
9d9685eec9 [ticket/12929] BUMP to RC5
PHPBB3-12929
2014-10-02 14:44:43 +01:00
brunoais
cf2ac56950 [ticket/12930] BUMP to RC5
PHPBB3-12930
2014-10-02 14:43:50 +01:00
Joas Schilling
240ff27707 Merge pull request #3000 from rxu/ticket/13110
[ticket/13110] Add core event to the page_footer() function
2014-10-02 15:38:22 +02:00
Joas Schilling
90241ae4e6 Merge pull request #2947 from rxu/ticket/13059
[ticket/13059] Add core event to generate_page_link()
2014-10-02 15:35:55 +02:00
Jakub Senko
6400902a01 [ticket/13125] $user->browser to $browser
PHPBB3-13125
2014-10-02 15:34:56 +02:00
Joas Schilling
ee758e22a6 Merge pull request #2999 from rxu/ticket/13108
[ticket/13108] Add core event to the parse_attachments() function
2014-10-02 15:33:32 +02:00
Joas Schilling
2ee13bbc24 Merge pull request #3004 from Senky/ticket/13116
[ticket/13116] Topic and post approval notifications got interchanged
2014-10-02 15:18:23 +02:00
Mario Skouat
e5a5933db6 [ticket/13041] Updating "Topic Subscriptions and Bookmarks"
PHPBB3-13041
2014-10-02 12:57:17 +02:00
Mario Skouat
8c628a6dc2 [ticket/13041] Updating "phpBB3 Issues"
PHPBB3-13041
2014-10-02 12:56:56 +02:00
Mario Skouat
1fb4ebb34a [ticket/13041] Updating "Searching the Forums"
PHPBB3-13041
2014-10-02 11:54:48 +02:00
Mario Skouat
64eec22884 [ticket/13041] Updating "Posting Issues"
PHPBB3-13041
2014-10-02 11:53:39 +02:00
Mario Skouat
abb1244b44 [ticket/13041] Updating "Login and Registration Issues"
PHPBB3-13041
2014-10-02 10:27:48 +02:00
Mario Skouat
e816006b8e [ticket/13041] Updating "User Preferences and settings"
PHPBB3-13041
2014-10-01 20:14:30 +02:00
Tristan Darricau
c123c93ca0 Merge pull request #3012 from nickvergessen/ticket/13123
[ticket/13123] Add events to allow modifying post data

* nickvergessen/ticket/13123:
  [ticket/13123] Add events to allow modifying post data
2014-10-01 16:09:04 +02:00
Marc Alexander
0e27b10b8f Merge pull request #3015 from nickvergessen/ticket/13119
[ticket/13119] Add another event which is triggered independent from actions
2014-10-01 15:59:00 +02:00
rxu
a876cc8c26 [ticket/13108] Add core event to the parse_attachments() function
Add core event to the parse_attachments() function in functions_content.php
to allow modifying/adding attachment template data.

PHPBB3-13108
2014-10-01 21:00:37 +08:00
rxu
ce4035fdd3 [ticket/13059] Add core event to generate_page_link()
Add core event to generate_page_link() to allow
overriding/modifying pagination URLs.
Event request: http://area51.phpbb.com/phpBB/viewtopic.php?f=111&t=45905

PHPBB3-13059
2014-10-01 20:55:07 +08:00
Joas Schilling
95c0d81ba1 [ticket/13119] Add another event which is triggered independent from actions
PHPBB3-13119
2014-10-01 14:54:26 +02:00
Joas Schilling
40cd7570e6 [ticket/11224] Revert "Merge pull request #2460 from Nicofuma/ticket/11224"
This reverts commit d264369441, reversing
changes made to 75fcfb1c1d.

PHPBB3-11224
2014-10-01 11:38:45 +02:00
Joas Schilling
b003019958 Merge pull request #3013 from VSEphpbb/ticket/13121
[ticket/13121] Remove cache mode from style management module
2014-10-01 10:34:08 +02:00
Joas Schilling
d264369441 Merge pull request #2460 from Nicofuma/ticket/11224
[ticket/11224] SQL cache destroy does not destroy queries to tables joined
2014-10-01 10:27:47 +02:00
Joas Schilling
75fcfb1c1d Merge pull request #2545 from ptitlazy/ticket/12657
[ticket/12657] Add a test file for base case of command cache:purge
2014-10-01 10:24:19 +02:00
Joas Schilling
170b75d0c9 Merge pull request #2888 from Nicofuma/ticket/12993
[ticket/12993] Improve get_user_ranks
2014-10-01 10:19:24 +02:00
Joas Schilling
994a0dcd4c Merge branch 'ticket/12985' into develop-ascraeus 2014-10-01 10:09:29 +02:00
david63
5314c2bddf [ticket/12985] Add core.login_box_redirect
Add core.login_box_redirect core event to allow extensions to redirect a
user to a specific page when logging in.

PHPBB3-12985
2014-10-01 10:09:10 +02:00
Joas Schilling
b6acc1b9db Merge pull request #2978 from blitze/ticket/13071
[ticket/13071] Only use total_match_count after event dispatcher
2014-10-01 10:01:09 +02:00
Joas Schilling
1b393b1d0b Merge pull request #2979 from blitze/ticket/13072
[ticket/13072] Add total_match_count to core.search_get_topic_data event
2014-10-01 09:56:39 +02:00
Joas Schilling
effb5d95d0 Merge pull request #2998 from rxu/ticket/13107
[ticket/13107] Add template events to forum row in forumlist_body.html
2014-10-01 09:50:38 +02:00
Cesar G
8ab7f6b595 Merge remote-tracking branch 'nickvergessen/ticket/13119' into develop-ascraeus
* nickvergessen/ticket/13119:
  [ticket/13119] Remove unused globals and use the request class
  [ticket/13119] Add events to ACP's ban module
  [ticket/13119] Add events to MCP's ban module
2014-10-01 00:43:41 -07:00
Matt Friedman
1ee4894271 [ticket/13121] Fix migration file
PHPBB3-13121
2014-10-01 00:29:45 -07:00
Matt Friedman
65539df39a [ticket/13121] Remove cache mode from style management module
https://tracker.phpbb.com/browse/PHPBB3-13121

PHPBB3-13121
2014-10-01 00:03:54 -07:00
Andreas Fischer
8fef959418 Merge pull request #3011 from fredemmott/ticket/13122
[ticket/13122] Make phpbb_wrapper_gmgetdate_test more reliable

* fredemmott/ticket/13122:
  [ticket/13122] Make phpbb_wrapper_gmgetdate_test more reliable
2014-10-01 02:15:25 +02:00
Fred Emmott
f30c5f730e [ticket/13122] Make phpbb_wrapper_gmgetdate_test more reliable
If you're unlucky, calling time() or similar twice in a row will
give you different results. Facebook runs these tests thousands of
times a day, so we occasionally get bogus failures.

PHPBB3-13122
2014-09-30 15:53:02 -07:00
Andreas Fischer
a8e74fff9b Merge pull request #3010 from Nicofuma/ticket/13120
[ticket/13120] Follows the symlinks in phpbb_load_extensions_autoloaders

* Nicofuma/ticket/13120:
  [ticket/13120] Follows the symlinks in phpbb_load_extensions_autoloaders
2014-10-01 00:26:39 +02:00
Joas Schilling
cb49a0c4cc [ticket/13123] Add events to allow modifying post data
PHPBB3-13123
2014-10-01 00:13:37 +02:00
Tristan Darricau
3a413cbf30 [ticket/13120] Follows the symlinks in phpbb_load_extensions_autoloaders
PHPBB3-13120
2014-09-30 21:20:42 +02:00
Andreas Fischer
cb8b245639 Merge pull request #3005 from nickvergessen/ticket/13105
[ticket/13105] Fix the code logic as described in the comment

* nickvergessen/ticket/13105:
  [ticket/13105] Fix the code logic as described in the comment
2014-09-30 21:15:26 +02:00
Andreas Fischer
8fb9f19aae Merge pull request #3008 from nickvergessen/ticket/13111
[ticket/13111] Dropdown options are already an array in the field data

* nickvergessen/ticket/13111:
  [ticket/13111] Dropdown options are already an array in the field data
2014-09-30 21:04:25 +02:00
Andreas Fischer
a0db23bd0e Merge pull request #3007 from nickvergessen/ticket/13118
[ticket/13118] Correctly use the provided datetime class

* nickvergessen/ticket/13118:
  [ticket/13118] Correctly use the provided datetime class
2014-09-30 21:00:05 +02:00
Joas Schilling
6f66423de9 [ticket/13119] Remove unused globals and use the request class
PHPBB3-13119
2014-09-30 18:22:06 +02:00
Joas Schilling
7efc624b0a [ticket/13119] Add events to ACP's ban module
PHPBB3-13119
2014-09-30 18:22:05 +02:00
Joas Schilling
9c3126add0 [ticket/13119] Add events to MCP's ban module
PHPBB3-13119
2014-09-30 18:22:04 +02:00
Nils Adermann
f1ab6f31a1 Merge pull request #3003 from nickvergessen/ticket/13117
[ticket/13117] Correctly define auto increment columns as "NOT NULL" on mysql
2014-09-30 14:00:02 +02:00
Joas Schilling
f64a937a57 [ticket/13111] Dropdown options are already an array in the field data
PHPBB3-13111
2014-09-30 12:27:14 +02:00
Joas Schilling
526329e697 [ticket/13118] Correctly use the provided datetime class
PHPBB3-13118
2014-09-30 11:58:02 +02:00
Joas Schilling
89fdd1baf2 [ticket/13105] Fix the code logic as described in the comment
PHPBB3-13105
2014-09-29 21:39:31 +02:00
Jakub Senko
e132cdd325 [ticket/13116] Interchange post and topic approval notification
PHPBB3-13116
2014-09-29 21:13:53 +02:00
Joas Schilling
bc24c78e06 [ticket/13117] Correctly define auto increment columns as "NOT NULL" on mysql
Unintended change from 95ab4b3e93

PHPBB3-13117
2014-09-29 20:48:47 +02:00
Nils Adermann
6f093ade8a Merge pull request #3001 from Nicofuma/ticket/13113
[ticket/13113] Updates the base url only when the front-end isn't app.php
2014-09-29 16:16:30 +02:00
Tristan Darricau
a159899d02 [ticket/13113] Updates the base url only when the front-end isn't app.php
PHPBB3-13113
2014-09-28 23:32:56 +02:00
rxu
eb2aa1f83a [ticket/13110] Add core event to the page_footer() function
Add core event to the page_footer() in includes/functions.php to allow
extensions handling overall page output before its displaying.

PHPBB3-13110
2014-09-28 15:39:06 +08:00
rxu
cee8ac9dbe [ticket/13107] Add template events to forum row in forumlist_body.html
PHPBB3-13107
2014-09-27 09:26:35 +08:00
Joas Schilling
71ac6ab2b8 Merge pull request #2996 from Senky/ticket/13104
[ticket/13104] Responsive tabs display bug in IE11
2014-09-25 22:02:23 +02:00
Andreas Fischer
be769d4ca6 Merge pull request #2995 from nickvergessen/ticket/13105
[ticket/13105] Future relative dates are always displayed as "Tomorrow"

* nickvergessen/ticket/13105:
  [ticket/13105] Do not display future dates 2+ days ahead as "tomorrow"
  [ticket/13105] Add a test for relative dates
2014-09-25 21:52:53 +02:00
Andreas Fischer
e802c5f082 Merge pull request #2997 from Senky/ticket/13106
[ticket/13106] Remove the \phpbb\di\pass\kernel_pass class

* Senky/ticket/13106:
  [ticket/13106] Remove \phpbb\di\pass\kernel_pass.php
2014-09-25 21:47:28 +02:00
Jakub Senko
f64373a29f [ticket/13106] Remove \phpbb\di\pass\kernel_pass.php
PHPBB3-13106
2014-09-25 20:12:33 +02:00
Jakub Senko
a1683dfb67 [ticket/13104] inline-block -> block
PHPBB3-13104
2014-09-25 20:07:06 +02:00
Joas Schilling
e803efc6fc [ticket/13105] Do not display future dates 2+ days ahead as "tomorrow"
PHPBB3-13105
2014-09-25 18:09:32 +02:00
Joas Schilling
459c62b339 [ticket/13105] Add a test for relative dates
PHPBB3-13105
2014-09-25 18:09:24 +02:00
Andreas Fischer
1b3109d650 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/13086] String replaces 50 with 20

Conflicts:
	phpBB/language/en/acp/email.php
2014-09-24 21:24:29 +02:00
Andreas Fischer
ce0c33f62a Merge pull request #2994 from Skouat/ticket/13086-olympus
[ticket/13086] Update ACP_MASS_EMAIL_EXPLAIN language key

* Skouat/ticket/13086-olympus:
  [ticket/13086] String replaces 50 with 20
2014-09-24 21:21:53 +02:00
Mario Skouat
077db77259 [ticket/13086] String replaces 50 with 20
PHPBB3-13086
2014-09-24 19:03:33 +02:00
Marc Alexander
30e1d29f58 Merge pull request #2993 from nickvergessen/ticket/13087
[ticket/13087] Correctly link to user profile when contact field has no URL
2014-09-24 18:27:37 +02:00
blitze
04e9789e7f [ticket/13072] Added '@changed 3.1.0-RC5 Added total_match_count'
PHPBB3-13072
2014-09-24 16:15:38 +00:00
Joas Schilling
b51b4c92e2 [ticket/13087] Correctly link to user profile when contact field has no URL
Broken by 975c5655f0

PHPBB3-13087
2014-09-24 17:33:54 +02:00
Tristan Darricau
74a96bf7c2 [ticket/11224] Adds a test case
PHPBB3-11224
2014-09-24 16:16:47 +02:00
Tristan Darricau
cd7b21a703 [ticket/12993] Update doc block
PHPBB3-12993
2014-09-24 16:07:23 +02:00
Tristan Darricau
834aea70a7 [ticket/12657] Fix unit tests
PHPBB3-12657
2014-09-24 15:24:56 +02:00
Joas Schilling
85bc9b69ae Merge pull request #2844 from marc1706/ticket/12858
[ticket/12858] Remove hard-coded GMT from timezone drop-down and rename to UTC
2014-09-24 13:47:59 +02:00
Joas Schilling
f3fef8934e Merge pull request #2954 from rxu/ticket/13055
[ticket/13055] Fix string profile fields validation to support unicode
2014-09-24 12:25:57 +02:00
Joas Schilling
43279ee010 Merge pull request #2983 from Senky/ticket/13094
[ticket/13094] Remove the search box if there are no new posts to search for
2014-09-24 10:33:58 +02:00
Joas Schilling
6d0697eb89 [ticket/13077] Move extension module to the top of the Customise tab
PHPBB3-13077
2014-09-24 00:34:17 +02:00
Andreas Fischer
d5128b3e87 Merge pull request #2988 from prototech/ticket/13011
[ticket/13011] Do not apply bbcode to whole text when selecting first 2 chars.

* prototech/ticket/13011:
  [ticket/13011] Do not apply bbcode to whole text when selecting first 2 chars.
2014-09-23 23:34:03 +02:00
Andreas Fischer
9feb7096ee Merge pull request #2985 from nickvergessen/ticket/13048
[ticket/13048] Only do not update the session page for ajax requests

* nickvergessen/ticket/13048:
  [ticket/13048] Only do not update the session page for ajax requests
2014-09-23 23:29:52 +02:00
Andreas Fischer
34aad4046f Merge pull request #2982 from marc1706/ticket/13070
[ticket/13070] Use old 'template' class for template class hook

* marc1706/ticket/13070:
  [ticket/13070] Use old 'template' class for template class hook
2014-09-23 23:25:59 +02:00
Jakub Senko
ca7f4fb531 [ticket/10985] Add fix to properly inherit style during update process
PHPBB3-10985
2014-09-23 23:03:07 +02:00
Andreas Fischer
80f15a41c4 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/13096] Add phpbb_ prefix to ldap_escape()

Conflicts:
	phpBB/includes/auth/auth_ldap.php
2014-09-23 22:55:13 +02:00
Andreas Fischer
2f773fca18 Merge pull request #2989 from Senky/ticket/13096
[ticket/13096] ldap_escape() added to PHP 5.6.0

* Senky/ticket/13096:
  [ticket/13096] Add phpbb_ prefix to ldap_escape()
2014-09-23 22:54:27 +02:00
Jakub Senko
ba464ec93a [ticket/13096] Add phpbb_ prefix to ldap_escape()
PHPBB3-13096
2014-09-23 22:43:52 +02:00
Cesar G
80d5a1ec1f [ticket/13011] Do not apply bbcode to whole text when selecting first 2 chars.
PHPBB3-13011
2014-09-23 12:56:20 -07:00
Cesar G
f2a98339e2 Merge remote-tracking branch 'hanakin/ticket/12889' into develop-ascraeus
* hanakin/ticket/12889:
  [ticket/12889] Fix multiple select lists
2014-09-23 12:49:04 -07:00
Cesar G
2478eef550 Merge remote-tracking branch 'Senky/ticket/13082' into develop-ascraeus
* Senky/ticket/13082:
  [ticket/13082] Repair fix
  [ticket/13082] Join classes
  [ticket/13082] move style to css file
  [ticket/13082] Replace float by text-align
2014-09-23 12:48:23 -07:00
Cesar G
7307380091 Merge remote-tracking branch 'hanakin/ticket/13097' into develop-ascraeus
* hanakin/ticket/13097:
  [ticket/13097] Add missing unit type
2014-09-23 10:06:00 -07:00
hanakin
fb610f99df [ticket/12889] Fix multiple select lists
PHPBB3-12889
2014-09-23 17:24:26 +02:00
hanakin
aa1ffc9319 [ticket/13097] Add missing unit type
PHPBB3-13097
2014-09-23 17:11:51 +02:00
Joas Schilling
ef9e0e743a Merge pull request #2937 from Senky/ticket/13027
[ticket/13027] PM folder full percentage could be a bit more accurate
2014-09-23 15:32:14 +02:00
Joas Schilling
820db008ff [ticket/13048] Only do not update the session page for ajax requests
The session time still needs to be updated, so e.g. long upload times
with PLupload stop the session from timing out.

PHPBB3-13048
2014-09-23 15:25:40 +02:00
Joas Schilling
05ae327553 Merge pull request #2974 from hanakin/ticket/13080
[Ticket/13080] Fix text overflow issue in mobile
2014-09-23 14:43:04 +02:00
Marc Alexander
9b8d8b020f Merge branch 'develop-olympus' into develop-ascraeus 2014-09-23 11:10:47 +02:00
Marc Alexander
92b096b05b Merge pull request #2984 from nickvergessen/ticket/10729-asc
[3.1][ticket/10729] Update editor information when user being deleted
2014-09-23 11:09:29 +02:00
Marc Alexander
8bd1853b56 Merge pull request #2981 from nickvergessen/ticket/10729
Ticket/10729 Update editor information when user being deleted
2014-09-23 11:08:56 +02:00
Joas Schilling
96024e88e9 [ticket/10729] Also test *delete_user on posts and topics
PHPBB3-10729
2014-09-23 09:54:21 +02:00
Joas Schilling
d6008e896a [ticket/10729] Fix handling of third parameter in 3.1
PHPBB3-10729
2014-09-23 09:42:30 +02:00
Joas Schilling
10b6399d30 [ticket/10729] Fix setup of the tests for 3.1
PHPBB3-10729
2014-09-23 09:38:35 +02:00
Joas Schilling
eeeb62b433 [ticket/10729] Update fixture to 3.1 database structure
PHPBB3-10729
2014-09-23 09:31:33 +02:00
Joas Schilling
9ff6358dc9 Merge branch 'ticket/10729' into ticket/10729-asc
Conflicts:
	phpBB/includes/functions_user.php
2014-09-23 09:31:13 +02:00
Joas Schilling
bea5f94de6 [ticket/10729] Use mocked null cache for phpunit 3.6 on travis with php 5.2
PHPBB3-10729
2014-09-23 09:03:44 +02:00
Joas Schilling
e28b93e0cc [ticket/10729] Ensure that no bans exist before testing create_session
PHPBB3-10729
2014-09-22 23:56:31 +02:00
Jakub Senko
9a8a0af7ba [ticket/13094] Condition search properly
PHPBB3-13094
2014-09-22 21:12:18 +02:00
Marc Alexander
d03be5ea5f [ticket/13070] Use old 'template' class for template class hook
PHPBB3-13070
2014-09-22 20:03:55 +02:00
Joas Schilling
7fca351e05 [ticket/10729] Add assert messages and finish up tests
PHPBB3-10729
2014-09-22 02:01:54 +02:00
Joas Schilling
d7c12ccd60 [ticket/10729] Add tests for some special tables with unique conditions
PHPBB3-10729
2014-09-22 01:42:36 +02:00
Joas Schilling
74854ac65d [ticket/10729] Add tests for user posts, reports and attachments
PHPBB3-10729
2014-09-22 00:55:34 +02:00
Joas Schilling
d48e4b680e [ticket/10729] Fix doc block for user_delete
PHPBB3-10729
2014-09-22 00:55:08 +02:00
Dhruv
29ffddee71 [ticket/12962] bootstrap functional and ui test when php >5.3.19
PHPBB3-12962
2014-09-21 15:54:52 +05:30
Dhruv
7fa596a991 [ticket/12962] Install test dependencies on travis
PHPBB3-12962
2014-09-21 14:24:36 +05:30
Dhruv
77d52982c8 [ticket/12962] Add facebook/webdriver dependency
Create a new composer.json for tests dir and add
facebook/webdriver dependency

PHPBB3-12962
2014-09-21 14:24:29 +05:30
Mario Skouat
39d46e2599 [ticket/13041] Reordering "Login and Registration Issues"
PHPBB3-13041
2014-09-21 10:43:10 +02:00
Dhruv
a1dff65cd1 [ticket/12962] Fix whitespace characters
PHPBB3-12962
2014-09-21 13:53:28 +05:30
Dhruv
a2627e8790 [ticket/12962] Run tests for all databases on Travis
PHPBB3-12962
2014-09-21 13:53:26 +05:30
Dhruv
20dfb23dd4 [ticket/12962] Force language=en for UI tests installation
PHPBB3-12962
2014-09-21 13:53:24 +05:30
Dhruv
d1935b0b0b [ticket/12962] Dump server output to /dev/null
PHPBB3-12962
2014-09-21 13:53:23 +05:30
Dhruv
039b466bd0 [ticket/12962] Start phantomjs on travis in background
PHPBB3-12962
2014-09-21 13:53:20 +05:30
Dhruv
c371e86fa1 [ticket/12962] Mark test skipped when phantom server not running
PHPBB3-12962
2014-09-21 13:53:19 +05:30
Dhruv
8d0933ca4b [ticket/12962] Add setup-phantomjs-server.sh
PHPBB3-12962
2014-09-21 13:53:17 +05:30
Dhruv
6de352f7da [ticket/12962] Run UI tests on Travis-mysql
PHPBB3-12962
2014-09-21 13:53:15 +05:30
Dhruv
c0d3cf6a27 [ticket/12962] Add UI tests to phpunit.xml.dist
PHPBB3-12962
2014-09-21 13:53:14 +05:30
Dhruv
f21ef60175 [ticket/12962] Add quick-links JS test
PHPBB3-12962
2014-09-21 13:53:08 +05:30
blitze
d6de9ce5d9 [ticket/13072] Add total_match_count to core.search_get_topic_data event
PHPBB3-13072
2014-09-21 08:22:15 +00:00
Jakub Senko
9f981a7741 [ticket/13082] Repair fix
PHPBB3-13082
2014-09-21 10:03:48 +02:00
blitze
6a33472214 [ticket/13071] Only use total_match_count after event dispatcher
PHPBB3-13071
2014-09-21 07:39:50 +00:00
Dhruv
77f8bb48fe [ticket/12962] Add initial class for ui_testing
PHPBB3-12962
2014-09-21 12:07:06 +05:30
Dhruv Goel
84e68b3a73 Merge pull request #2963 from Senky/ticket/13045
[ticket/13045] Remove Pragma headers
2014-09-21 11:29:56 +05:30
Dhruv Goel
b02e579c1c Merge pull request #2976 from n-aleha/ticket/13085
[ticket/13085] Fix typo in oauth.php
2014-09-21 10:29:07 +05:30
Jakub Senko
6851ff8fab [ticket/13082] Join classes
PHPBB3-13082
2014-09-21 00:07:39 +02:00
n-aleha
7313cc777e [ticket/13085] Fix typo in oauth.php
PHPBB3-13085
2014-09-21 00:33:07 +03:00
Jakub Senko
ace3b806a9 [ticket/13082] move style to css file
PHPBB3-13082
2014-09-20 20:35:14 +02:00
Jakub Senko
ef58752db8 [ticket/13082] Replace float by text-align
PHPBB3-13082
2014-09-20 18:35:26 +02:00
hanakin
8b8e065441 [ticket/13080] Fix mediaqueries formating
open { are should not to be on new lines for
media queries per spec, causes code highlight
issues in reputible code editors

PHPBB3-13080
2014-09-20 16:55:20 +02:00
hanakin
e3eff2a976 [ticket/13080] Remove nowrap from dd in responsive
PHPBB3-13080
2014-09-20 16:51:01 +02:00
Joas Schilling
e005455881 Merge branch 'prep-release-3.1.0-RC4' into develop-ascraeus
* prep-release-3.1.0-RC4:
  [prep-release-3.1.0-RC4] Update phpBB Version for RC4 development
  [prep-release-3.1.0-RC4] Add changelog for 3.1.0-RC4
  [prep-release-3.1.0-RC4] Prepare Changelog
  [prep-release-3.1.0-RC4] Add migration for 3.1.0-RC4
  [prep-release-3.1.0-RC4] Update version to 3.1.0-RC4
2014-09-20 09:53:23 +02:00
Joas Schilling
26c6ffa458 [prep-release-3.1.0-RC4] Update phpBB Version for RC4 development 2014-09-20 09:52:53 +02:00
Marc Alexander
457e13634e [ticket/12858] Properly format UTC offset in footer
PHPBB3-12858
2014-09-19 23:45:03 +02:00
Joas Schilling
2c5e184ea1 [prep-release-3.1.0-RC4] Add changelog for 3.1.0-RC4 2014-09-19 19:09:46 +02:00
Joas Schilling
841abf712e [prep-release-3.1.0-RC4] Prepare Changelog 2014-09-19 19:07:41 +02:00
Joas Schilling
221f4a4a8c [prep-release-3.1.0-RC4] Add migration for 3.1.0-RC4 2014-09-19 19:04:21 +02:00
Joas Schilling
301694e922 [prep-release-3.1.0-RC4] Update version to 3.1.0-RC4 2014-09-19 19:02:31 +02:00
Joas Schilling
fc252f1ba5 Merge pull request #2969 from marc1706/ticket/13073
[ticket/13073] Correctly generate routes from subfolders like /adm

* marc1706/ticket/13073:
  [ticket/13073] Remove _test suffix from common test class
  [ticket/13073] Switch $input with $expected and add paths with letters
  [ticket/13073] Use abstract class for controller helper route tests
  [ticket/13073] Add path regex to get_preg_expression() and add unit tests
  [ticket/13073] Use just one regex in helper route()
  [ticket/13073] Properly place comments in helper
  [ticket/13073] Use correct class names in test files
  [ticket/13073] Rework route tests and add tests for more directory types
  [ticket/13073] Test that routes from subfolders like /adm work
  [ticket/13073] Add tests for routes from adm pages
  [ticket/13073] Add phpbb root path with mod rewrite enabled for proper routes
2014-09-19 18:58:53 +02:00
Marc Alexander
3418683cfc [ticket/13073] Remove _test suffix from common test class
PHPBB3-13073
2014-09-19 16:50:26 +02:00
Marc Alexander
d720428564 [ticket/13073] Switch $input with $expected and add paths with letters
PHPBB3-13073
2014-09-19 15:30:24 +02:00
Marc Alexander
543d68a7d3 [ticket/13073] Use abstract class for controller helper route tests
PHPBB3-13073
2014-09-19 15:21:04 +02:00
Marc Alexander
6fd54436ee [ticket/13073] Add path regex to get_preg_expression() and add unit tests
We're now calling get_preg_expression() instead of hardcoding the regex into
the helper route method.

PHPBB3-13073
2014-09-19 13:54:15 +02:00
Marc Alexander
4186ced479 [ticket/13073] Use just one regex in helper route()
PHPBB3-13073
2014-09-19 12:14:57 +02:00
Marc Alexander
eaef881e7d [ticket/13073] Properly place comments in helper
PHPBB3-13073
2014-09-19 12:03:04 +02:00
Marc Alexander
de7ed7c286 [ticket/13073] Use correct class names in test files
PHPBB3-13073
2014-09-19 12:01:31 +02:00
Tristan Darricau
c767712c64 [ticket/12657] Fix the order of the parameters for the constructor
PHPBB3-12657
2014-09-19 11:09:37 +02:00
Tristan Darricau
689eaab3e2 [ticket/12657] The test does not need to depend on the database
PHPBB3-12657
2014-09-19 11:09:35 +02:00
LEZY Thomas
fb08d1b27e [ticket/12657] Remove unused global variables
PHPBB3-12657
2014-09-19 11:09:32 +02:00
LEZY Thomas
6e4348b0ea [ticket/12657] Fix name temporary directory used by test file
PHPBB3-12657
2014-09-19 11:09:30 +02:00
LEZY Thomas
4a76763a8a [ticket/12657] Add a test file for base case
PHPBB3-12657
2014-09-19 11:09:29 +02:00
brunoais
55664c1c10 [ticket/12930] Fixing event comment block and variable
According to comments on pull request

PHPBB3-12930
2014-09-19 08:44:12 +01:00
brunoais
d4938e34b0 [ticket/12929] Fixing event comment block and variable
PHPBB3-12929
2014-09-19 08:36:00 +01:00
rxu
c20b658f70 [ticket/13055] Add UTF-8 string tests for profile fields validation options
PHPBB3-13055
2014-09-19 09:31:28 +08:00
Tristan Darricau
98f02ece97 Merge pull request #2970 from nickvergessen/ticket/13062
[ticket/13062] Fix name of "ORDER_BY" key in SQL array

* nickvergessen/ticket/13062:
  [ticket/13062] Fix name of "ORDER_BY" key in SQL array
2014-09-19 01:18:32 +02:00
Joas Schilling
6bc23ee282 [ticket/13062] Fix name of "ORDER_BY" key in SQL array
PHPBB3-13062
2014-09-19 00:56:16 +02:00
Marc Alexander
a6d9b42e5f [ticket/13073] Rework route tests and add tests for more directory types
PHPBB3-13073
2014-09-19 00:35:17 +02:00
Joas Schilling
e9285d43af Merge pull request #2952 from rxu/ticket/13066
[ticket/13066] Add search results core event to modify search title

* rxu/ticket/13066:
  [ticket/13066] Add search results core event to modify search title
2014-09-19 00:22:53 +02:00
Marc Alexander
d74f45aee0 [ticket/13073] Test that routes from subfolders like /adm work
PHPBB3-13073
2014-09-19 00:11:36 +02:00
Marc Alexander
a70addbf14 [ticket/13073] Add tests for routes from adm pages
PHPBB3-13073
2014-09-19 00:07:31 +02:00
Cesar G
ae14b0f272 Merge remote-tracking branch 'hanakin/ticket/12598' into develop-ascraeus
* hanakin/ticket/12598:
  [ticket/12598] Fix sir typo
  [ticket/12598] Fix rtl positon in header
  [ticket/12598] Remove right border
  [ticket/12598] Remove border from .search-header
  [ticket/12598] Replace #search-box with class
  [ticket/12598] Remove hover border-color and use hover icon
  [ticket/12598] Add some responsive margin to give breathing room
  [ticket/12598] Clean up unused link colors
  [ticket/12598] Remove unused link colors
  [ticket/12598] Add lt IE9 fixes
  [ticket/12598] Improve search box styling
2014-09-18 15:07:27 -07:00
Marc Alexander
d892dfe084 [ticket/13073] Add phpbb root path with mod rewrite enabled for proper routes
PHPBB3-13073
2014-09-18 23:44:51 +02:00
hanakin
1914a08088 [ticket/12598] Fix sir typo
PHPBB3-12598
2014-09-18 23:13:42 +02:00
hanakin
88f645eeda [ticket/12598] Fix rtl positon in header
PHPBB3-12598
2014-09-18 22:45:24 +02:00
hanakin
2ca001edcf [ticket/12598] Remove right border
PHPBB3-12598
2014-09-18 22:34:55 +02:00
hanakin
6eb2b876f1 [ticket/12598] Remove border from .search-header
PHPBB3-12598
2014-09-18 21:47:24 +02:00
hanakin
0dc181a529 [ticket/12598] Replace #search-box with class
PHPBB3-12598
2014-09-18 21:47:23 +02:00
PayBas
d27e9c7c76 [ticket/12598] Remove hover border-color and use hover icon
PHPBB3-12598
2014-09-18 21:47:23 +02:00
PayBas
93d50db2d6 [ticket/12598] Add some responsive margin to give breathing room
PHPBB3-12598
2014-09-18 21:47:22 +02:00
PayBas
b5800d1124 [ticket/12598] Clean up unused link colors
PHPBB3-12598
2014-09-18 21:47:22 +02:00
PayBas
3f71d7dba1 [ticket/12598] Remove unused link colors
PHPBB3-12598
2014-09-18 21:47:21 +02:00
PayBas
514bf6e39a [ticket/12598] Add lt IE9 fixes
In case this one gets merged before hanakin's gradient PR.

PHPBB3-12598
2014-09-18 21:47:21 +02:00
PayBas
470e6d5edf [ticket/12598] Improve search box styling
PHPBB3-12598
2014-09-18 21:47:20 +02:00
Joas Schilling
3066cd700a Merge pull request #2875 from PayBas/ticket/12961
[ticket/12961] Add link in anti-spam ACP page which links directly to captchas in titania

* PayBas/ticket/12961:
  [ticket/12961] Shorten ext-db link text
  [ticket/12961] Fix missing phpBB.com
  [ticket/12961] Remove target="_blank" and switch to <strong>
  [ticket/12961] Add additional link to the KB
  [ticket/12961] Move link to language file
  [ticket/12961] Refactor lang entry
  [ticket/12961] Change url to anti-spam-ext
  [ticket/12961] Change url to https://www.phpbb.com/go/anti-spam/
  [ticket/12961] Add link in anti-spam ACP page to titania
2014-09-18 14:23:41 +02:00
Tristan Darricau
bad07b355c Merge pull request #2967 from nickvergessen/ticket/12963
[ticket/12963] Revert back to "migrations" folder name for extensions

* nickvergessen/ticket/12963:
  [ticket/12963] Always use core_path and core_directory()
  [ticket/12963] Remove old migration/ folder from tests
  [ticket/12963] Revert back to "migrations" folder name for extensions
2014-09-18 14:04:06 +02:00
Joas Schilling
b82a3cddd8 Merge pull request #2927 from Senky/ticket/13022
[ticket/13022] "Return to advanced search" wrong assumption

* Senky/ticket/13022:
  [ticket/13022] Language adjustments
  [ticket/13022] Remove ternary condition
  [ticket/13022] Condition Return to advanced search link
2014-09-18 12:44:12 +02:00
Jakub Senko
31e43ce124 [ticket/12489] Add notice about %s wildcard in FIELD_IS_CONTACT_EXPLAIN
PHPBB3-12489
2014-09-18 12:13:17 +02:00
Joas Schilling
1da5c41ab3 [ticket/12963] Always use core_path and core_directory()
PHPBB3-12963
2014-09-18 11:21:53 +02:00
Joas Schilling
5ce61e8c3a [ticket/12963] Remove old migration/ folder from tests
PHPBB3-12963
2014-09-18 11:21:51 +02:00
Joas Schilling
c220fa89a1 [ticket/12963] Revert back to "migrations" folder name for extensions
The issues that can be created with the name change are just too much

PHPBB3-12963
2014-09-18 10:45:08 +02:00
Cesar G
53e028ff14 Merge remote-tracking branch 'GiampaoloFalqui/develop-ascraeus' into develop-ascraeus
* GiampaoloFalqui/develop-ascraeus:
  [ticket/13068] Language correction in FIELD_IS_CONTACT_EXPLAIN
2014-09-17 18:17:56 -07:00
Cesar G
53f62f1129 Merge remote-tracking branch 'Nicofuma/ticket/12963' into develop-ascraeus
* Nicofuma/ticket/12963:
  [ticket/12963] Fix the migration's finder for the tests (path, new instance)
2014-09-17 17:49:01 -07:00
Giampaolo Falqui
a2b5ec7e1b [ticket/13068] Language correction in FIELD_IS_CONTACT_EXPLAIN
PHPBB3-13068
2014-09-18 02:25:39 +02:00
rxu
dc65058c20 [ticket/13055] Add string profile fields validation options to support unicode
PHPBB3-13055
2014-09-18 08:19:08 +08:00
Tristan Darricau
0d1f0c07fe [ticket/12963] Fix the migration's finder for the tests (path, new instance)
PHPBB3-12963
2014-09-18 02:04:47 +02:00
Tristan Darricau
6c043c4a86 Merge pull request #2964 from nickvergessen/ticket/12963
[ticket/12963] Correctly load migration files from migration/ in tests as well

* nickvergessen/ticket/12963:
  [ticket/12963] Correctly load migration files from migration/ in tests as well
2014-09-18 01:32:08 +02:00
Joas Schilling
180f9bf4fa [ticket/12963] Correctly load migration files from migration/ in tests as well
PHPBB3-12963
2014-09-17 23:33:26 +02:00
Joas Schilling
7729ae4ad0 [ticket/13064] Revert "[ticket/13064] Validate the migrations provided to ..."
This reverts commit 46a9fe93d7.

PHPBB3-13064
2014-09-17 21:24:33 +02:00
Jakub Senko
e59222496a [ticket/13045] Remove Pragma headers
PHPBB3-13045
2014-09-17 20:10:01 +02:00
Joas Schilling
910cd5edbe Merge pull request #2948 from Nicofuma/ticket/13061
[ticket/13061] Replace the service event.subscriber_loader by a compiler pass

* Nicofuma/ticket/13061:
  [ticket/13061] Replace the service event.subscriber_loader by a compiler pass
2014-09-17 20:09:49 +02:00
Joas Schilling
676f453cbd Merge pull request #2949 from rxu/ticket/13062
[ticket/13062] Add viewforum.php core event to modify topic ids sql query

* rxu/ticket/13062:
  [ticket/13062] Add viewforum.php core event to modify topic ids sql query
2014-09-17 20:02:13 +02:00
Joas Schilling
86ea314598 Merge pull request #2951 from Nicofuma/ticket/13064
[ticket/13064] Validate the migrations provided to migrator::set_migrations()

* Nicofuma/ticket/13064:
  [ticket/13064] Validate the migrations provided to migrator::set_migrations()
2014-09-17 19:59:39 +02:00
Joas Schilling
7201238104 Merge pull request #2962 from Senky/ticket/13044
[ticket/13044] Expires header violates RFC 2616

* Senky/ticket/13044:
  [ticket/13044] Move GMT out of gmdate in functions_acp
  [ticket/13044] Move GMT out of gmdate()
  [ticket/13044] \G\M\T to GMT in whole project
  [ticket/13044] move GMT string out of gmdate()
  [ticket/13044] Correct Expires headers
2014-09-17 19:44:42 +02:00
Marc Alexander
f4761b5e08 [ticket/12858] Directly return and use timezone selects
PHPBB3-12858
2014-09-17 19:07:24 +02:00
Jakub Senko
3885ac90f1 [ticket/13044] Move GMT out of gmdate in functions_acp
PHPBB3-13044
2014-09-17 18:38:21 +02:00
Jakub Senko
3d637fea98 [ticket/13044] Move GMT out of gmdate()
PHPBB3-13044
2014-09-17 18:35:38 +02:00
Marc Alexander
9c310f789f [ticket/12858] Rename tz_ prefixed block variables to timezone_ prefix
PHPBB3-12858
2014-09-17 17:56:09 +02:00
Marc Alexander
ad596f4390 [ticket/12858] Fix timezone select display in subsilver2
PHPBB3-12858
2014-09-17 17:56:09 +02:00
Marc Alexander
6323180344 [ticket/12858] Fix timezone display on acp users page
PHPBB3-12858
2014-09-17 17:56:09 +02:00
Marc Alexander
9a3aeb8a99 [ticket/12858] Remove hardcoded language entries from timezone selects
PHPBB3-12858
2014-09-17 17:56:04 +02:00
Marc Alexander
3dbac0f88b [ticket/12858] Use UTC for time info in footer and hide offset if it's 0
PHPBB3-12858
2014-09-17 14:23:34 +02:00
Marc Alexander
9ebee7de32 [ticket/12858] Generate timezone selects with template loop
PHPBB3-12858
2014-09-17 14:22:08 +02:00
Jakub Senko
ea5e46f6dd [ticket/13044] \G\M\T to GMT in whole project
Note that there are more uses of "\G\M\T" in vendor files.

PHPBB3-13044
2014-09-17 11:56:37 +02:00
Jakub Senko
7cbd9e9524 [ticket/13044] move GMT string out of gmdate()
PHPBB3-13044
2014-09-17 11:15:24 +02:00
Jakub Senko
33b2063680 [ticket/13044] Correct Expires headers
PHPBB3-13044
2014-09-17 10:52:19 +02:00
Marc Alexander
20903c0a9b Merge pull request #2922 from Nicofuma/ticket/13036
[ticket/13036] Make the reference type configurable when generating a route
2014-09-17 00:57:04 +02:00
Marc Alexander
4a06511d85 Merge pull request #2932 from Nicofuma/ticket/12963
[ticket/12963] Load extensions migrations from /migration
2014-09-17 00:36:38 +02:00
Marc Alexander
2e1aebbc12 Merge pull request #2959 from prototech/ticket/13069
[ticket/13069] Fix timezone location filtering.
2014-09-17 00:24:36 +02:00
Cesar G
4df031187f [ticket/13069] Fix timezone location filtering.
$timezone contains the original jQuery object, therefore the subsequent
removal of the optgroup children while filtering has no effect on the
$replacement object - the one that's now visible to the user. We'll simplify
and fix this by injecting the content of the copy instead of going through the
trouble of cloning it.

PHPBB3-13069
2014-09-16 14:47:42 -07:00
Tristan Darricau
a48b740b94 [ticket/13036] Complete tests
PHPBB3-13036
2014-09-16 21:56:45 +02:00
Tristan Darricau
8b16d31413 [ticket/12963] Edit deprecation message
PHPBB3-12963
2014-09-16 20:18:10 +02:00
Tristan Darricau
bb5d6a2551 [ticket/13036] Add unit tests
PHPBB3-13036
2014-09-16 19:44:58 +02:00
Tristan Darricau
dab6b99bcd [ticket/13036] Make the reference type configurable when generating a route
PHPBB3-13036
2014-09-16 19:28:06 +02:00
Marc Alexander
b3576d77da Merge pull request #2921 from Nicofuma/ticket/13034
[ticket/13034] Fix the route generated for the frontend not in the phpbb root path
2014-09-16 19:24:07 +02:00
Tristan Darricau
f4260e261f [ticket/13034] Fix tests
PHPBB3-13034
2014-09-16 01:25:36 +02:00
Tristan Darricau
68ad7685bc [ticket/13034] Update the base url to move to the root dir
PHPBB3-13034
2014-09-15 23:47:05 +02:00
Andreas Fischer
0b4f714bc4 Merge pull request #2958 from prototech/ticket/13018
[ticket/13018] Remove duplicate logic in confirm box and alert box handling.

* prototech/ticket/13018:
  [ticket/13018] Clean up and fix some logic.
  [ticket/13018] Do not handle events in close function.
  [ticket/13018] Reduce the delta further.
  [ticket/13018] Remove duplicate logic in confirm box and alert box handling.
2014-09-15 22:50:58 +02:00
Andreas Fischer
720561de6e Merge pull request #2943 from Nicofuma/ticket/13056
[ticket/13056] Move the arguments of the request class to the DI

* Nicofuma/ticket/13056:
  [ticket/13056] Move the arguments of the request class to the DI
2014-09-15 22:42:38 +02:00
Tristan Darricau
06f42f433b [ticket/13034] Add comment
PHPBB3-13034
2014-09-15 20:25:20 +02:00
Cesar G
4ae447b205 [ticket/13018] Clean up and fix some logic.
PHPBB3-13018
2014-09-15 07:44:02 -07:00
Cesar G
2b4807b116 [ticket/13018] Do not handle events in close function.
PHPBB3-13018
2014-09-15 07:43:18 -07:00
Cesar G
f807b82162 Merge remote-tracking branch 'PayBas/ticket/10472' into develop-ascraeus
* PayBas/ticket/10472:
  [ticket/10472] Remove dd selector and use -moz-padding-end
  [ticket/10472] Fix weird padding on input type=number
  [ticket/10472] More clearing and white-space fixes
  [ticket/10472] Fix ACP overflow:hidden problem for medium-sized screens
2014-09-15 06:58:21 -07:00
PayBas
0061a305d8 [ticket/12408] Fix white-space sniffer
PHPBB3-12408
2014-09-15 15:25:43 +02:00
PayBas
6488d236ec [ticket/10472] Remove dd selector and use -moz-padding-end
PHPBB3-10472
2014-09-15 14:58:57 +02:00
PayBas
38830f9cbb [ticket/10472] Fix weird padding on input type=number
PHPBB3-10472
2014-09-15 14:53:04 +02:00
PayBas
726573f100 [ticket/10472] More clearing and white-space fixes
PHPBB3-10472
2014-09-15 14:53:04 +02:00
PayBas
da716058fa [ticket/10472] Fix ACP overflow:hidden problem for medium-sized screens
PHPBB3-10472
2014-09-15 14:53:03 +02:00
PayBas
5a780dfab1 [ticket/12408] Clarify the behavior of "override style"
PHPBB3-12408
2014-09-15 14:49:56 +02:00
PayBas
aaddf41e5b [ticket/12408] Changed lang vars, added fieldset and removed "default"
PHPBB3-12408
2014-09-15 14:43:40 +02:00
PayBas
0b4944f125 [ticket/12408] Public functions and updated doc block
PHPBB3-12408
2014-09-15 14:43:40 +02:00
PayBas
60c9955f51 [ticket/12408] Code cleanup
Rebased to see if travis will finally play along

PHPBB3-12408
2014-09-15 14:43:39 +02:00
PayBas
ae63843647 [ticket/12408] Simplified queries
PHPBB3-12408
2014-09-15 14:43:38 +02:00
PayBas
265c621c9e [ticket/12408] Add quick setting for "default guest style" to ACP
PHPBB3-12408
2014-09-15 14:43:38 +02:00
Cesar G
5034b3ad7d [ticket/13018] Reduce the delta further.
The callback does not actually do anything when cancelling the confirmation
box so we can avoid calling it altogether when cancel is clicked.

PHPBB3-13018
2014-09-14 15:49:18 -07:00
Cesar G
6d80770ba4 [ticket/13018] Remove duplicate logic in confirm box and alert box handling.
This ensures a more consistent handling of the various closing/opening actions
and fixes some bugs where certain event handlers are not turned off in certain
instances.

PHPBB3-13018
2014-09-14 14:54:08 -07:00
Tristan Darricau
b9e7ed004c [ticket/13034] Use utf8_basename
PHPBB3-13034
2014-09-14 23:41:15 +02:00
Tristan Darricau
9ef01e7f82 Merge pull request #2956 from prototech/ticket/13019
[ticket/13019] Always accept a reason for deleting a post/topic.

* prototech/ticket/13019:
  [ticket/13019] Do not hide reason field when deleting permanently.
  [ticket/13019] Rename deletion reason label.
  [ticket/13019] Always accept a reason for deleting a post/topic.
2014-09-14 22:00:16 +02:00
Marc Alexander
1487e6f857 Merge pull request #2955 from prototech/ticket/13065
[ticket/13065] Fix rehashing of stored password hash in phpBB2 convertor.
2014-09-14 20:44:49 +02:00
Cesar G
ffe24d5b8f [ticket/13019] Do not hide reason field when deleting permanently.
PHPBB3-13019
2014-09-14 10:41:57 -07:00
Cesar G
8c11927b55 [ticket/13019] Rename deletion reason label.
PHPBB3-13019
2014-09-14 10:39:25 -07:00
Cesar G
bf7041eeb9 [ticket/13019] Always accept a reason for deleting a post/topic.
PHPBB3-13019
2014-09-14 10:38:56 -07:00
Cesar G
b71571b793 [ticket/13065] Fix rehashing of stored password hash in phpBB2 convertor.
PHPBB3-13065
2014-09-14 10:04:18 -07:00
Cesar G
a45df1d840 Merge remote-tracking branch 'prototech/ticket/13040' into develop-ascraeus
* prototech/ticket/13040:
  [ticket/13040] Fix W3C validator warning in overall_footer.html
2014-09-14 07:40:30 -07:00
John
e4401b2534 [ticket/13040] Fix W3C validator warning in overall_footer.html
Added a non-breaking space to remove the following warning:
**Empty heading.**

```html
<h3 class="alert_title"></h3><p class="alert_text"></p>
```

PHPBB3-13040
2014-09-14 06:30:03 -07:00
Cesar G
ca7168ee4a Merge remote-tracking branch 'hanakin/ticket/13009' into develop-ascraeus
* hanakin/ticket/13009:
  [ticket/13009] Remove legacy browser hacks
2014-09-14 06:23:00 -07:00
Cesar G
7f86b6e71e Merge remote-tracking branch 'Nicofuma/ticket/13058' into develop-ascraeus
* Nicofuma/ticket/13058:
  [ticket/13058] Add min value to jump to page input
2014-09-14 06:21:25 -07:00
rxu
bf6bc330af [ticket/13066] Add search results core event to modify search title
PHPBB3-13066
2014-09-14 15:00:47 +08:00
Tristan Darricau
46a9fe93d7 [ticket/13064] Validate the migrations provided to migrator::set_migrations()
PHPBB3-13064
2014-09-14 00:56:41 +02:00
Louis7777
2cf5b848db [ticket/13058] Add min value to jump to page input
PHPBB3-13058
2014-09-13 22:44:37 +02:00
rxu
e731dcfe6e [ticket/13062] Add viewforum.php core event to modify topic ids sql query
Event request: http://area51.phpbb.com/phpBB/viewtopic.php?f=111&t=45383

PHPBB3-13062
2014-09-14 01:04:34 +08:00
Tristan Darricau
c988b98ac6 [ticket/13061] Replace the service event.subscriber_loader by a compiler pass
PHPBB3-13061
2014-09-13 14:34:18 +02:00
Tristan Darricau
3dc73485ee [ticket/13056] Move the arguments of the request class to the DI
PHPBB3-13056
2014-09-13 14:22:55 +02:00
Marc Alexander
48dbef391b Merge pull request #2879 from callumacrae/ticket/12982
[ticket/12982] JS refactoring
2014-09-12 19:54:03 +02:00
Andreas Fischer
f26b6b6251 Merge pull request #2941 from Senky/ticket/12734
[ticket/12734] Custom profile manager should not suppress errors when inserting user rows

* Senky/ticket/12734:
  [ticket/12734] Remove unnecessary error supressing
2014-09-12 00:54:51 +02:00
Andreas Fischer
f892646a84 Merge pull request #2944 from Nicofuma/ticket/13057
[ticket/13057] Add $phpbb_dispatcher to the global in mcp/mcp_report.php

* Nicofuma/ticket/13057:
  [ticket/13057] Add $phpbb_dispatcher to the global in mcp/mcp_report.php
2014-09-12 00:52:22 +02:00
Tristan Darricau
7b4c5bdd34 [ticket/13057] Add $phpbb_dispatcher to the global in mcp/mcp_report.php
PHPBB3-13057
2014-09-11 22:01:09 +02:00
hanakin
7618e0387c [ticket/13009] Remove legacy browser hacks
PHPBB3-13009
2014-09-11 17:33:30 +02:00
Tristan Darricau
7d6ceb81c1 Merge pull request #2901 from rxu/ticket/13005
[ticket/13005] Add event to display_forums() to modify category template data

* rxu/ticket/13005:
  [ticket/13005] Add event to display_forums() to modify category template data
2014-09-11 16:58:34 +02:00
Tristan Darricau
5804e43589 Merge pull request #2903 from rxu/ticket/13006
[ticket/13006] Add variables to the 'core.modify_quickmod_actions' event

* rxu/ticket/13006:
  [ticket/13006] Add variables to the 'core.modify_quickmod_actions' event
2014-09-11 16:44:16 +02:00
Andreas Fischer
d42401056c Merge pull request #2940 from Senky/ticket/13042
[ticket/13042] Unused var in login_box()

* Senky/ticket/13042:
  [ticket/13042] Remove unused variables
2014-09-10 22:17:17 +02:00
Tristan Darricau
c842583bbf Merge pull request #2936 from nickvergessen/ticket/12976
[ticket/12976] Correctly use plurals for attachment count in UCP navigation

* nickvergessen/ticket/12976:
  [ticket/12976] Correctly use plurals for attachment count in UCP navigation
2014-09-10 20:00:52 +02:00
Tristan Darricau
04e0d305d0 [ticket/12963] Add unit tests
PHPBB3-12963
2014-09-10 19:22:00 +02:00
Tristan Darricau
72ee4b3a7c [ticket/12963] Load extensions migrations from /migration
PHPBB3-12963
2014-09-10 19:21:57 +02:00
Tristan Darricau
ff872a7970 [ticket/12963] Don't use static var in \extension\base\get_migration_file_list
The static var was global to all instance of \phpbb\base and so if two
different instances (for two different extensions) were created by the
same script they shared the same migrations list.

PHPBB3-12963
2014-09-10 19:21:55 +02:00
Jakub Senko
fcd2a2f186 [ticket/12734] Remove unnecessary error supressing
PHPBB3-12734
2014-09-10 18:37:16 +02:00
Jakub Senko
51f5c2d094 [ticket/13042] Remove unused variables
PHPBB3-13042
2014-09-10 17:38:05 +02:00
Tristan Darricau
a093c28d1a [ticket/12963] Fix the list of migrations in database_update.php
Without this patch the finder grab all the class available in the ext
folder and not only the migrations. This change is backported for the one
done before to the cli tool db:migrate. (see the commit
3420f8f320)

PHPBB3-12963
2014-09-10 12:01:01 +02:00
Tristan Darricau
b2a28962bc Merge pull request #2939 from nickvergessen/ticket/13052
[ticket/13052] Restore timespan parameter for check_form_key()

* nickvergessen/ticket/13052:
  [ticket/13052] Restore timespan parameter for check_form_key()
2014-09-10 11:50:13 +02:00
Callum Macrae
cb7e1540c6 [ticket/12982] Refactoring: Killed undescriptive variables
PHPBB3-12982
2014-09-10 09:58:46 +01:00
Joas Schilling
d87547da66 [ticket/13052] Restore timespan parameter for check_form_key()
PHPBB3-13052
2014-09-10 08:07:21 +02:00
Marc Alexander
6c0a3bb247 Merge pull request #2934 from VSEphpbb/ticket/13051
[ticket/13051] Fix viewonline event (recently broken) and add a new core event
2014-09-09 23:37:30 +02:00
Matt Friedman
0fc5a27889 [ticket/13051] Fix core event name
PHPBB3-13051
2014-09-09 13:12:29 -07:00
Matt Friedman
0861404121 [ticket/13051] Rename new event core.viewonline_modify_user_row
PHPBB3-13051
2014-09-09 12:52:53 -07:00
Jakub Senko
bfb672f326 [ticket/13027] round to floor
PHPBB3-13027
2014-09-09 21:33:19 +02:00
Joas Schilling
d9f36ae7e1 [ticket/12976] Correctly use plurals for attachment count in UCP navigation
PHPBB3-12976
2014-09-09 21:31:34 +02:00
Andreas Fischer
65026ed1fa Merge pull request #2935 from nickvergessen/ticket/13052
Ticket/13052 Remove additional parameter from check_form_key()

* nickvergessen/ticket/13052:
  [ticket/13052] Use request class instead of $_POST and request_var()
  [ticket/13052] Fix appearances with multiple parameters
  [ticket/13052] Remove additional parameter from check_form_key()
2014-09-09 21:25:15 +02:00
Joas Schilling
ef61deb132 [ticket/13052] Use request class instead of $_POST and request_var()
PHPBB3-13052
2014-09-09 19:49:17 +02:00
Joas Schilling
ad8d53af27 [ticket/13052] Fix appearances with multiple parameters
PHPBB3-13052
2014-09-09 19:47:00 +02:00
Joas Schilling
047728e3d4 [ticket/13052] Remove additional parameter from check_form_key()
PHPBB3-13052
2014-09-09 19:46:27 +02:00
Matt Friedman
c56c0fce0d [ticket/13051] Add a new core event to handle the template array
PHPBB3-13051
2014-09-09 09:14:32 -07:00
Matt Friedman
c6fc455432 [ticket/13051] Fix viewonline event, remove template data
PHPBB3-13051
2014-09-08 15:54:16 -07:00
Jakub Senko
4b4a673d98 [ticket/13022] Language adjustments
PHPBB3-13022
2014-09-08 23:14:33 +02:00
Andreas Fischer
e00697f3a1 Merge pull request #2926 from Senky/ticket/13038
[ticket/13038] Link user post tally to their posts

* Senky/ticket/13038:
  [ticket/13038] Add link to number of posts of user in viewtopic
2014-09-08 22:12:44 +02:00
Andreas Fischer
3458aa2482 Merge pull request #2931 from rxu/ticket/13050
[ticket/13050] Allow topic/forum subscription when email/jabber is off

* rxu/ticket/13050:
  [ticket/13050] Allow topic/forum subscription when email/jabber is off
2014-09-08 21:23:46 +02:00
Jakub Senko
aefd96e604 [ticket/13038] Add link to number of posts of user in viewtopic
PHPBB3-13038
2014-09-08 17:36:08 +02:00
Marc Alexander
bcd4cebd48 Merge pull request #2915 from rxu/ticket/13026
[ticket/13026] Add template vars array to core.viewonline_overwrite_location
2014-09-08 16:46:26 +02:00
Marc Alexander
cc96bcff99 Merge pull request #2911 from rxu/ticket/13020
[ticket/13020] Add variables to core.viewforum_get_topic_data event
2014-09-08 16:30:05 +02:00
Andreas Fischer
33e5e426d4 Merge pull request #2933 from bantu/ticket/13035
[ticket/13035] Remove empty meta tags

* bantu/ticket/13035:
  [ticket/13035] Remove empty meta tags
2014-09-08 13:45:34 +02:00
dcz
85468ce2ec [ticket/13035] Remove empty meta tags
PHPBB3-13035
2014-09-08 13:09:38 +02:00
Jakub Senko
dfbc2adc08 [ticket/13022] Remove ternary condition
PHPBB3-13022
2014-09-07 22:39:22 +02:00
rxu
de7b100b8a [ticket/13020] Add forum_data variable to core.viewforum_get_topic_data event
PHPBB3-13020
2014-09-07 19:48:06 +08:00
rxu
d470d628f5 [ticket/13026] Add template vars array to core.viewonline_overwrite_location
Add template vars array to core.viewonline_overwrite_location event
to allow modifying/adding template vars for every user row.

PHPBB3-13026
2014-09-07 19:04:32 +08:00
rxu
40ef561349 [ticket/13050] Allow topic/forum subscription when email/jabber is off
Currently, there's impossible to subscribe topic/forum if emails and/or jabber
is disabled. This seems to be a 3.0 leftover since 3.1 introduces new
notification system which handles this case and offers email/jabber-free
board notifications.

PHPBB3-13050
2014-09-07 18:54:34 +08:00
Joas Schilling
12398d65fd Merge pull request #2930 from Senky/ticket/13048
[ticket/13048] AJAX requests are being stored to session_page

* Senky/ticket/13048:
  [ticket/13048] Only update session_page if request is not ajax
2014-09-07 12:50:03 +02:00
Joas Schilling
c1d0528d80 Merge pull request #2929 from rxu/ticket/13047
[ticket/13047] Add $post_list array to core.viewtopic_modify_page_title event

* rxu/ticket/13047:
  [ticket/13047] Add $post_list array to core.viewtopic_modify_page_title event
2014-09-07 12:47:13 +02:00
Joas Schilling
b3a8e92810 Merge pull request #2928 from Nicofuma/ticket/13046
[ticket/13046] Call phpbb_load_extensions_autoloaders() in $download/file.php

* Nicofuma/ticket/13046:
  [ticket/13046] Call phpbb_load_extensions_autoloaders() in $download/file.php
2014-09-07 12:42:52 +02:00
Marc Alexander
a0ee6ccdf3 Merge pull request #2925 from nickvergessen/ticket/12983
Ticket/12983 UCP preferences, Display posts ordering by: input is not properly validated
2014-09-07 11:41:44 +02:00
Joas Schilling
d5801333f7 [ticket/12983] Do not test invalid values until Symfony 2.4
PHPBB3-12983
2014-09-07 10:40:18 +02:00
Jakub Senko
b218f3ad43 [ticket/13048] Only update session_page if request is not ajax
PHPBB3-13048
2014-09-07 10:15:51 +02:00
rxu
a6f1b22eb3 [ticket/13047] Add $post_list array to core.viewtopic_modify_page_title event
PHPBB3-13047
2014-09-07 13:36:23 +08:00
Tristan Darricau
088e34dc47 [ticket/13046] Call phpbb_load_extensions_autoloaders() in $download/file.php
PHPBB3-13046
2014-09-07 01:41:21 +02:00
Tristan Darricau
297ab5c526 Merge pull request #2919 from Senky/ticket/12852
[ticket/12852] Make get_url_parts handle get variable with no value

* Senky/ticket/12852:
  [ticket/12852] Add unit tests
  [ticket/12852] Add space after if
  [ticket/12852] Remove whitespace
  [ticket/12852] Make get_url_parts handle get variable with no value
2014-09-06 15:47:30 +02:00
Joas Schilling
647a75249c [ticket/12983] Add functional test for ucp pref module
PHPBB3-12983
2014-09-06 15:16:51 +02:00
Jakub Senko
1094de49c2 [ticket/13022] Condition Return to advanced search link
PHPBB3-13022
2014-09-06 14:53:14 +02:00
Tristan Darricau
6387bf8d13 Merge pull request #2918 from marc1706/ticket/13031
[ticket/13031] Only use mimetype guesser guess if it helps us

* marc1706/ticket/13031:
  [ticket/13031] Slightly change behavior of choose_mime_type and add unit tests
  [ticket/13031] Guess with all mimetype guessers and pick best guess
  [ticket/13031] Only use mimetype guesser guess if it helps us
2014-09-06 13:53:43 +02:00
Marc Alexander
21029e9fd2 [ticket/13031] Slightly change behavior of choose_mime_type and add unit tests
The mime type 'application/octet-stream' will still always be overwritten by
proper guesses. However, guesses with guessers that have a higher priority
will now overwrite previous guesses even if the mime types of these guesses
had a slash in them.

PHPBB3-13031
2014-09-05 21:55:49 +02:00
Marc Alexander
6eaeae60f6 Merge pull request #2748 from carlo94it/ticket/12765
[ticket/12765] Use db_tools instead of generating queries at moment
2014-09-05 21:23:04 +02:00
Marc Alexander
b854882470 Merge pull request #2868 from rxu/ticket/12969
[ticket/12969] Add template events around username link on composing pm
2014-09-05 21:05:33 +02:00
Joas Schilling
b9cb3b9e3e [ticket/12983] Correctly validate sorting options in the UCP
PHPBB3-12983
2014-09-05 13:24:31 +02:00
Marc Alexander
d31ff51785 [ticket/13031] Guess with all mimetype guessers and pick best guess
PHPBB3-13031
2014-09-05 10:56:06 +02:00
Tristan Darricau
4f44e73b21 [ticket/13034] Fix unit tests
PHPBB3-13034
2014-09-04 23:21:56 +02:00
Tristan Darricau
cb3eb84665 [ticket/13034] Fix the route generated for the frontend not in the phpbb root
PHPBB3-13034
2014-09-04 23:21:55 +02:00
Jakub Senko
7b796532df [ticket/12852] Add unit tests
PHPBB3-12852
2014-09-04 17:56:48 +02:00
Jakub Senko
1d4cae9ecb [ticket/12852] Add space after if
PHPBB3-12852
2014-09-04 17:44:41 +02:00
Jakub Senko
28587d0afc [ticket/12852] Remove whitespace
PHPBB3-12852
2014-09-04 16:15:45 +02:00
Jakub Senko
17e4e5f8c4 [ticket/12852] Make get_url_parts handle get variable with no value
PHPBB3-12852
2014-09-04 13:33:04 +02:00
Marc Alexander
10c99b3c2b Merge pull request #2917 from bantu/ticket/13032
[ticket/13032] Update Symfony Components to 2.3.19
2014-09-04 13:06:13 +02:00
Marc Alexander
7de15bc54c [ticket/13031] Only use mimetype guesser guess if it helps us
If we already have a mimetype and the guesser's guess is the default fallback,
we should keep the already existing mimetype the browser supplied. Otherwise,
platforms that might not support mimetype guessers will cause us to always
have the mimetype set to application/octet-stream on images. This will prevent
users from uploading images.

PHPBB3-13031
2014-09-03 23:09:17 +02:00
Andreas Fischer
a3c63f6c03 [ticket/13032] Also update symfony/css-selector and pin it down.
PHPBB3-13032
2014-09-03 21:47:41 +02:00
Andreas Fischer
65577ed422 [ticket/13032] Update Symfony Components to 2.3.19
PHPBB3-13032
2014-09-03 21:40:38 +02:00
Marc Alexander
6777d462ff Merge pull request #2908 from Pico/t/12661
[ticket/12661] Load extensions templates from "all" folder by render()
2014-09-02 20:54:51 +02:00
Marc Alexander
d86817ef07 Merge pull request #2887 from Pico/ticket/12991
[ticket/12991] Have events after/before "add warning" field - user and post
2014-09-01 22:43:54 +02:00
rxu
1d4c040d4f [ticket/12969] Add template events around username link on composing pm
Add template event before/after find username link on composing pm
to allow extensions perform additional actions on user finding.

PHPBB3-12969
2014-09-02 01:02:17 +08:00
Marc Alexander
97c798a375 Merge pull request #2913 from Nicofuma/ticket/13024
[ticket/13024] Add template event viewtopic_body_postrow_post_content_footer
2014-08-31 19:30:01 +02:00
Tristan Darricau
76053b3cd4 [ticket/13024] Add template event viewtopic_body_postrow_post_content_footer
PHPBB3-13024
2014-08-30 23:52:14 +02:00
Marc Alexander
01f821bbc3 Merge pull request #2826 from brunoais/ticket/12928
[ticket/12928] core.mcp_reports_gather_query_before
2014-08-30 22:55:56 +02:00
Pico
7fc550aedc [ticket/12991] Correct language mistakes
PHPBB3-12991
2014-08-30 06:31:55 +02:00
Dhruv Goel
6d9c0a76df Merge pull request #2865 from marc1706/ticket/12966
[ticket/12966] Sort posts by post_id in addition to sorting by post_time
2014-08-29 20:44:01 +05:30
Marc Alexander
cbbef46c6c Merge pull request #2909 from n-aleha/ticket/11909
[ticket/11909] Remove unused function load_migrations
2014-08-28 21:18:17 +02:00
PayBas
ab9cdcadfb [ticket/12961] Shorten ext-db link text
PHPBB3-12961
2014-08-26 12:45:54 +02:00
n-aleha
bcc1b7aec9 [ticket/11909] Remove unused function load_migrations
Remove unused function load_migrations from \phpbb\db\migrator

PHPBB3-11909
2014-08-26 02:56:47 +03:00
Pico
9d44c5d940 [ticket/12661] Add new line at the end of files
PHPBB3-12661
2014-08-25 22:35:55 +02:00
Cesar G
7cd6dbe898 Merge remote-tracking branch 'PayBas/ticket/12506' into develop-ascraeus
* PayBas/ticket/12506:
  [ticket/12506] Fix search result h3 margin
  [ticket/12506] Fix responsive profile min-height (no avatar)
  [ticket/12506] Reposition buttons to make room for "online" banner
  [ticket/12506] Reposition post-buttons for compact layout
2014-08-25 13:13:25 -07:00
Andreas Fischer
9fc5073540 Merge pull request #2905 from Nicofuma/ticket/13008
[ticket/13008] Use an absolute path with the FileLocator for the routing files

* Nicofuma/ticket/13008:
  [ticket/13008] Add functionnal test
  [ticket/13008] Use an absolute path with the FileLocator for the routing files
2014-08-24 22:32:54 +02:00
Tristan Darricau
0386b1788a [ticket/13008] Add functionnal test
PHPBB3-13008
2014-08-24 15:17:50 +02:00
Pico88
273fc5b5b6 [ticket/12661] Add template test
PHPBB3-12661
2014-08-24 10:16:39 +02:00
Pico88
ae3b015f65 [ticket/12661] Load extensions templates from "all" folder by render()
PHPBB3-12661
2014-08-24 08:10:37 +02:00
Tristan Darricau
154710aa50 Merge pull request #2907 from marc1706/ticket/13010
[ticket/13010] Specifiy correct clean_row() call in phpbb_get_avatar docblock

* marc1706/ticket/13010:
  [ticket/13010] Specifiy correct clean_row() call in phpbb_get_avatar docblock
2014-08-24 00:26:27 +02:00
Marc Alexander
e2c56609ab Merge pull request #2904 from Nicofuma/ticket/12990
[ticket/12990] Disable all the notifications types which are not in the core
2014-08-24 00:20:24 +02:00
Marc Alexander
6e274740df [ticket/13010] Specifiy correct clean_row() call in phpbb_get_avatar docblock
PHPBB3-13010
2014-08-24 00:11:43 +02:00
Tristan Darricau
1a41632af8 [ticket/12990] Disable all the notifications types which are not in the core
PHPBB3-12990
2014-08-23 23:39:46 +02:00
Marc Alexander
e5e45f860b [ticket/12966] Sort by post_time and post_id where applicable
This change was not applied to the search as this would require a larger
rewrite of the search methods.

PHPBB3-12966
2014-08-23 16:36:39 +02:00
Andreas Fischer
1e09fd0cee Merge pull request #2551 from ptitlazy/ticket/12658
[ticket/12658] Add test for base case of commands config:

* ptitlazy/ticket/12658:
  [ticket/12658] Rebased and fixed unit tests
  [ticket/12658] Fix wrong eol character
  [ticket/12658] Refactoring code
  [ticket/12658] Fix typo and coding style mistakes
  [ticket/12658] Add test for command config:delete
  [ticket/12658] Add test for command config:increment
  [ticket/12658] Add test for command config:get
  [ticket/12658] Add test for command config:set-atomic
  [ticket/12658] Add test for base case of command config:set
2014-08-23 13:21:50 +02:00
Tristan Darricau
91804b53fb [ticket/12658] Rebased and fixed unit tests
PHPBB3-12658
2014-08-23 12:45:25 +02:00
LEZY Thomas
5a4de4aa1f [ticket/12658] Fix wrong eol character
PHPBB3-12658
2014-08-23 12:41:44 +02:00
LEZY Thomas
059f21a3ac [ticket/12658] Refactoring code
PHPBB3-12658
2014-08-23 12:41:42 +02:00
LEZY Thomas
ab6c9775d3 [ticket/12658] Fix typo and coding style mistakes
PHPBB3-12658
2014-08-23 12:41:41 +02:00
LEZY Thomas
f9803b7360 [ticket/12658] Add test for command config:delete
PHPBB3-12658
2014-08-23 12:41:39 +02:00
LEZY Thomas
3fbab9504b [ticket/12658] Add test for command config:increment
PHPBB3-12658
2014-08-23 12:41:37 +02:00
LEZY Thomas
9affb8c171 [ticket/12658] Add test for command config:get
PHPBB3-12658
2014-08-23 12:41:36 +02:00
LEZY Thomas
ede73b207b [ticket/12658] Add test for command config:set-atomic
PHPBB3-12658
2014-08-23 12:41:35 +02:00
LEZY Thomas
1662ee64e0 [ticket/12658] Add test for base case of command config:set
PHPBB3-12658
2014-08-23 12:41:32 +02:00
Tristan Darricau
03b9eb5dcb [ticket/13008] Use an absolute path with the FileLocator for the routing files
PHPBB3-13008
2014-08-23 12:34:23 +02:00
PayBas
5eea1ca44e [ticket/12961] Fix missing phpBB.com
Don't know how that happened. Weird

PHPBB3-12961
2014-08-23 12:32:43 +02:00
Andreas Fischer
a79da361ee Merge pull request #2783 from hanakin/ticket/12862
[ticket/12862] Fix pop-up box wraps

* hanakin/ticket/12862:
  [ticket/12862] Remove remaining simple-wrap id
  [ticket/12862] Resize popups consistently
  [ticket/12862] Add Border
2014-08-23 11:40:37 +02:00
rxu
30b6080529 [ticket/13006] Add variables to the 'core.modify_quickmod_actions' event
Add $quickmod and $action variables
for the 'core.modify_quickmod_actions' event trigerring
to avoid of using global operator in corresponding extensions.

PHPBB3-13006
2014-08-22 21:55:26 +08:00
PayBas
f22ee4f73a [ticket/12961] Remove target="_blank" and switch to <strong>
PHPBB3-12961
2014-08-22 15:23:35 +02:00
rxu
0aa7d3ef75 [ticket/13005] Add event to display_forums() to modify category template data
While there're events to modify/add FORUM_POST/FORUM_LINK template data,
such an event is missing for FORUM_CAT forum type.

PHPBB3-13005
2014-08-22 18:53:20 +08:00
Andreas Fischer
d2ed2c4e1e Merge pull request #2899 from Skouat/ticket/13003
[ticket/13003] Add missing language keys

* Skouat/ticket/13003:
  [ticket/13003] Add missing language keys
2014-08-22 11:59:26 +02:00
Andreas Fischer
39bfbc3a26 Merge pull request #2900 from prototech/ticket/13004
[ticket/13004] Remove obsolete S_HAS_ATTACHMENTS check from topic tools.

* prototech/ticket/13004:
  [ticket/13004] Remove obsolete S_HAS_ATTACHMENTS check from topic tools.
2014-08-21 22:48:15 +02:00
Marc Alexander
7483d01942 Merge pull request #2898 from Nicofuma/ticket/12990
[ticket/12990] Use {$var} instead of ${var}
2014-08-21 20:49:41 +02:00
PayBas
ca55f22c73 [ticket/12961] Add additional link to the KB
PHPBB3-12961
2014-08-21 20:05:55 +02:00
Cesar G
be0ebbe644 [ticket/13004] Remove obsolete S_HAS_ATTACHMENTS check from topic tools.
PHPBB3-13004
2014-08-21 10:47:40 -07:00
Mario Skouat
923a818e37 [ticket/13003] Add missing language keys
PHPBB3-13003
2014-08-21 19:37:03 +02:00
Tristan Darricau
afb9d0a3d7 [ticket/12990] Use {$var} instead of ${var}
PHPBB3-12990
2014-08-21 16:04:46 +02:00
Andreas Fischer
a7a05ca75c Merge pull request #2894 from Nicofuma/ticket/12999
[ticket/12999] Remove @author tags

* Nicofuma/ticket/12999:
  [ticket/12999] Remove @author tags
2014-08-21 13:44:10 +02:00
Marc Alexander
31aac66f5a Merge pull request #2885 from Nicofuma/ticket/12990
[ticket/12990] Use the full services name for the notification's types
2014-08-21 00:44:05 +02:00
Marc Alexander
421005b282 Merge pull request #2889 from rxu/ticket/12994
[ticket/12994] Add core event to viewtopic.php before sending vars to template
2014-08-21 00:22:18 +02:00
rxu
60b38847d2 [ticket/12994] Add core event to viewtopic.php before sending vars to template
Add core event to viewtopic.php before sending vars to template
to allow extensions performing additional actions/modifying data first.

PHPBB3-12994
2014-08-21 04:54:26 +08:00
Marc Alexander
43d7d47e9b Merge pull request #2895 from Nicofuma/ticket/12998
[ticket/12998] Fix use of $lang in mcp_warn.php
2014-08-20 22:03:50 +02:00
Tristan Darricau
9486c693b6 [ticket/12998] Fix use of $lang in mcp_warn.php
PHPBB3-12998
2014-08-19 23:02:54 +02:00
Tristan Darricau
c013e727d4 [ticket/12999] Remove @author tags
PHPBB3-12999
2014-08-19 22:54:45 +02:00
Tristan Darricau
fe1ab6d2ef [ticket/12993] Return an array instead of reference passing
PHPBB3-12993
2014-08-19 22:25:01 +02:00
Andreas Fischer
0f3defbb26 Merge pull request #2893 from bantu/ticket/12989
[ticket/12989] Remove unused "created_by.jpg"

* bantu/ticket/12989:
  [ticket/12989] Remove unused "created_by.jpg"
2014-08-19 21:29:17 +02:00
Louis7777
8a5dd101a3 [ticket/12989] Remove unused "created_by.jpg"
This image is not used anywhere in prosilver.

PHPBB3-12989
2014-08-19 20:58:47 +02:00
Tristan Darricau
5e7d9d2fcf [ticket/12993] Fix includes of functions_display
PHPBB3-12993
2014-08-19 13:51:21 +02:00
Andreas Fischer
da3ddaf676 Merge pull request #2892 from bantu/ticket/12996
[ticket/12996] Fix reliability issue in flock test.

* bantu/ticket/12996:
  [ticket/12996] Fix reliability issue in flock test.
2014-08-19 12:20:06 +02:00
Fred Emmott
0ef7a9d455 [ticket/12996] Fix reliability issue in flock test.
$delta was always an int - so, this test would sometimes fail if you
happened to call time() /very/ close to a 1s boundary.

Found by HHVM's continuous testing.

PHPBB3-12996
2014-08-19 11:53:34 +02:00
Tristan Darricau
496cc64bc6 [ticket/12993] Rename to phpbb_get_user_rank
PHPBB3-12993
2014-08-18 16:32:05 +02:00
Tristan Darricau
685bdc87e6 [ticket/12993] Fix user_loader and memberlist
PHPBB3-12993
2014-08-18 14:07:47 +02:00
Forumhulp.com
8671e40217 [ticket/12993] Improve get_user_ranks
Explanation in http://area51.phpbb.com/phpBB/viewtopic.php?f=108&t=46051

PHPBB3-12993
2014-08-18 13:59:33 +02:00
Tristan Darricau
71f78fb8c6 [ticket/12990] Use protected instead of private
PHPBB3-12990
2014-08-17 23:03:44 +02:00
Andreas Fischer
a82a88b555 Merge pull request #2886 from Oyabun1/ticket/12984
[ticket/12984] Remove blank line when no forum description shown

* Oyabun1/ticket/12984:
  [ticket/12984] Remove blank line when no forum description shown
2014-08-17 22:31:46 +02:00
Pico88
9d7deba67a [ticket/12991] Have events after/before "add warning" field - user and post
PHPBB3-12991
2014-08-17 19:04:35 +02:00
Tristan Darricau
b18fe1203a [ticket/12990] Fix unit tests
PHPBB3-12990
2014-08-17 16:19:23 +02:00
Oyabun1
621f8c922f [ticket/12984] Remove blank line when no forum description shown
Add a conditional for forum description and move the <br /> within it.
Currently if there is no forum description but there is
1. a displayed forum moderator and/or
2. a displayed sub-forum
a blank line is added in place of the description

PHPBB3-12984
2014-08-17 20:39:22 +10:00
Andreas Fischer
4ff5aa18ae Merge pull request #2881 from rxu/ticket/12986
[ticket/12986] Fix detection of common words in search

* rxu/ticket/12986:
  [ticket/12986] Fix detection of common words in search
2014-08-17 01:14:46 +02:00
Tristan Darricau
fe80967535 [ticket/12990] Use the full services name for the notification's types
PHPBB3-12990
2014-08-16 21:46:03 +02:00
rxu
354d08dfff [ticket/12986] Fix detection of common words in search
$search->get_common_words() call goes before the split_keywords() call,
but $search->common_words array is being generated
within the function $search->split_keywords(). Thus, get_common_words()
returned an empty array instead of common words array.

PHPBB3-12986
2014-08-17 00:35:12 +08:00
Andreas Fischer
e9f5b9d657 Merge pull request #2872 from Nicofuma/ticket/12975
[ticket/12975] Fix the construction of phpbb\auth\provider\db for Oauth

* Nicofuma/ticket/12975:
  [ticket/12975] Fix the construction of phpbb\auth\provider\db for Oauth
2014-08-16 09:50:51 +02:00
PayBas
45405a48a8 [ticket/12961] Move link to language file
PHPBB3-12961
2014-08-15 22:53:05 +02:00
PayBas
73426d2d30 [ticket/12961] Refactor lang entry
PHPBB3-12961
2014-08-14 22:22:20 +02:00
Marc Alexander
ad625c1e6d Merge pull request #2876 from PayBas/ticket/12900
[ticket/12900] Fix potential avatar size box overflow
2014-08-14 14:47:20 +02:00
PayBas
27bb2b7289 [ticket/12961] Change url to anti-spam-ext
As per IRC suggestion

PHPBB3-12961
2014-08-14 10:03:41 +02:00
PayBas
d08a7f70e6 [ticket/12961] Change url to https://www.phpbb.com/go/anti-spam/
PHPBB3-12961
2014-08-14 10:03:35 +02:00
Callum Macrae
9c87972385 [ticket/12982] Refactoring: Cleaned up crazy insert users stuff
PHPBB3-12982
2014-08-14 00:19:34 +01:00
Callum Macrae
9e3db526d5 [ticket/12982] Refactoring: Cleaned up forum_fn.js
PHPBB3-12982
2014-08-14 00:04:16 +01:00
Callum Macrae
9578fdf7d7 [ticket/12982] Refactoring: Cleaned up phpbb.search
PHPBB3-12982
2014-08-13 23:18:50 +01:00
Cesar G
26b8c6cc13 Merge remote-tracking branch 'PayBas/ticket/12856' into develop-ascraeus
* PayBas/ticket/12856:
  [ticket/12856] Remove images from assets/plupload/img/
  [ticket/12856] Copy plupload images to prosilver dir
2014-08-13 15:00:48 -07:00
Callum Macrae
d79fec1c3f [ticket/12982] Refactoring: made JS in adm nice
PHPBB3-12982
2014-08-13 22:53:28 +01:00
Callum Macrae
340f48fdeb [ticket/12982] Refactoring: made most JS nice.
PHPBB3-12982
2014-08-13 22:44:21 +01:00
PayBas
5cf9ab8a97 [ticket/12856] Remove images from assets/plupload/img/
PHPBB3-12856
2014-08-13 23:20:43 +02:00
PayBas
9db2ff7186 [ticket/12856] Copy plupload images to prosilver dir
PHPBB3-12856
2014-08-13 16:37:44 +02:00
PayBas
030d1a683b [ticket/12900] Fix potential avatar size box overflow
PHPBB3-12900
2014-08-13 16:23:20 +02:00
PayBas
55260127bd [ticket/12961] Add link in anti-spam ACP page to titania
PHPBB3-12961
2014-08-13 15:39:03 +02:00
Tristan Darricau
e31aafb393 [ticket/12975] Fix the construction of phpbb\auth\provider\db for Oauth
PHPBB3-12975
2014-08-12 23:12:57 +02:00
Dhruv Goel
1dc2d0e759 Merge pull request #2853 from callumacrae/ticket/12951
[ticket/12951] Added editorconfig
2014-08-12 16:15:47 +02:00
Joas Schilling
e47b7540c3 Merge branch 'prep-release-3.1.0-RC3' into develop-ascraeus
* prep-release-3.1.0-RC3:
  [prep-release-3.1.0-RC3] Update phpBB Version for RC4 development
  [prep-release-3.1.0-RC3] Add changelog for 3.1.0-RC3
  [prep-release-3.1.0-RC3] Prepare Changelog
  [prep-release-3.1.0-RC3] Add migration for 3.1.0-RC3
  [prep-release-3.1.0-RC3] Update version to 3.1.0-RC3
2014-08-12 10:16:38 +02:00
Joas Schilling
3be239b864 [prep-release-3.1.0-RC3] Update phpBB Version for RC4 development 2014-08-12 10:15:42 +02:00
Joas Schilling
de819bea74 [prep-release-3.1.0-RC3] Add changelog for 3.1.0-RC3 2014-08-11 19:34:31 +02:00
Joas Schilling
29886e703a [prep-release-3.1.0-RC3] Prepare Changelog 2014-08-11 19:33:18 +02:00
Joas Schilling
7367ab6e15 [prep-release-3.1.0-RC3] Add migration for 3.1.0-RC3 2014-08-11 19:32:54 +02:00
Joas Schilling
b40225c142 [prep-release-3.1.0-RC3] Update version to 3.1.0-RC3 2014-08-11 19:30:55 +02:00
Tristan Darricau
f76d671dc7 Merge pull request #2870 from nickvergessen/ticket/12970
[ticket/12970] Regenerate schema.json with new dependencies

* nickvergessen/ticket/12970:
  [ticket/12970] Regenerate schema.json with new dependencies
2014-08-11 19:24:56 +02:00
Joas Schilling
edbae9ceaa [ticket/12970] Regenerate schema.json with new dependencies
PHPBB3-12970
2014-08-11 19:09:59 +02:00
Nils Adermann
96005ceb9e Merge remote-tracking branch 'github-marc1706/ticket/12822' into develop-ascraeus
* github-marc1706/ticket/12822:
  [ticket/12822] Correctly call \phpbb\user in avatar manager test
2014-08-11 18:13:51 +02:00
Marc Alexander
07576dc169 [ticket/12822] Correctly call \phpbb\user in avatar manager test
PHPBB3-12822
2014-08-11 18:04:20 +02:00
Nils Adermann
bad90dafbf Merge remote-tracking branch 'github-marc1706/ticket/12822' into develop-ascraeus
* github-marc1706/ticket/12822:
  [ticket/12822] Fix test runs of avatar manager_test
  [ticket/12822] Add method for deleting avatars and use confirm_box
  [ticket/12822] Remove "None" option from avatar select boxes
2014-08-11 17:37:56 +02:00
Marc Alexander
91df95a90d Merge pull request #2842 from Nicofuma/ticket/11854
[ticket/11854] Move captchas to phpbb/ and use DI for plugins
2014-08-11 12:20:35 +02:00
Tristan Darricau
756aa68b34 [ticket/11854] Don't override get service name in nogd
PHPBB3-11854
2014-08-11 08:04:14 +02:00
Marc Alexander
c10c6bd342 Merge pull request #2845 from rxu/ticket/12942
[ticket/12942] Add core.add_form_key core event
2014-08-11 07:37:57 +02:00
Marc Alexander
48ce9f5e9d Merge pull request #2867 from prototech/ticket/12967
[ticket/12967] Fix undefined variable phpbb_dispatcher error.
2014-08-11 07:31:59 +02:00
Marc Alexander
71c9e6c67c Merge pull request #2863 from rxu/ticket/12944
[ticket/12944] Add core.login_forum_box core event
2014-08-11 07:27:42 +02:00
Tristan Darricau
4683864b4b [ticket/11854] Update tests
PHPBB3-11854
2014-08-11 01:17:01 +02:00
Tristan Darricau
fa2ac1f271 [ticket/11854] Use a set_name method instead of overriding get_service_name
PHPBB3-11854
2014-08-11 01:16:58 +02:00
Tristan Darricau
76633544ee [ticket/11854] Change the error message in reCaptcha
PHPBB3-11854
2014-08-11 01:16:55 +02:00
Tristan Darricau
fc4b1090cc [ticket/11854] Fix comments
PHPBB3-11854
2014-08-11 01:16:50 +02:00
Tristan Darricau
351a6dcad2 [ticket/11854] Base the migration on rc2
PHPBB3-11854
2014-08-11 01:16:46 +02:00
Tristan Darricau
2cbcf4bcbf [ticket/11854] Fix the factory in \phpbb\auth\provider\db
PHPBB3-11854
2014-08-11 01:16:42 +02:00
Tristan Darricau
036a61a904 [ticket/11854] Remove unused globals
PHPBB3-11854
2014-08-11 01:16:38 +02:00
Tristan Darricau
e889b8f931 [ticket/11854] Remove constants and use DI for QA tables
PHPBB3-11854
2014-08-11 01:16:35 +02:00
Tristan Darricau
02f3b74e8a [ticket/11854] Fix coding style
PHPBB3-11854
2014-08-11 01:16:30 +02:00
Tristan Darricau
850b7dbf07 [ticket/11854] Update the default captcha choosen during the installation
PHPBB3-11854
2014-08-11 01:16:28 +02:00
Tristan Darricau
bd09356c30 [ticket/11854] Rename captchas.plugins.service_collection service
PHPBB3-11854
2014-08-11 01:16:25 +02:00
Tristan Darricau
b91abf1a0b [ticket/11854] Rename captchas.factory service to captcha.factory
PHPBB3-11854
2014-08-11 01:16:22 +02:00
Tristan Darricau
d73d606f11 [ticket/11854] Fix various comments
PHPBB3-11854
2014-08-11 01:16:18 +02:00
Tristan Darricau
577f9ac7e4 [ticket/11854] Split phpbb\captcha\gd.php
PHPBB3-11854
2014-08-11 01:16:15 +02:00
Tristan Darricau
99b7d18ab2 [ticket/11854] Migrate all old php4 constructor
PHPBB3-11854
2014-08-11 01:16:10 +02:00
Tristan Darricau
28cf0ef832 [ticket/11854] Update unit tests
PHPBB3-11854
2014-08-11 01:16:07 +02:00
Tristan Darricau
6e4991093a [ticket/11854] Fix migration
PHPBB3-11854
2014-08-11 01:16:02 +02:00
Tristan Darricau
a1d5ad8a37 [ticket/11854] Add missing dot in the migration file
PHPBB3-11854
2014-08-11 01:15:58 +02:00
Tristan Darricau
dd88022a70 [ticket/11854] Add a migration to update the captcha_plugin setting
PHPBB3-11854
2014-08-11 01:15:54 +02:00
Tristan Darricau
160ff7b912 [ticket/11854] Move captcha stuff to phpbb/ and use DI for plugins
PHPBB3-11854
2014-08-11 01:15:49 +02:00
Michael Miday
ada35dca00 [ticket/12862] Remove remaining simple-wrap id
PHPBB3-12862
2014-08-11 00:55:26 +02:00
rxu
96e8b67a4e [ticket/12944] Add core.login_forum_box core event
Add core.login_forum_box core event to allow extensions
performing additional actions on forum login.

PHPBB3-12944
2014-08-11 06:35:36 +08:00
Cesar G
43a309ce2b [ticket/12967] Fix undefined variable phpbb_dispatcher error.
PHPBB3-12967
2014-08-11 00:34:12 +02:00
rxu
b20af9a6d2 [ticket/12942] Add core.add_form_key core event
Add core.add_form_key core event to allow extensions modifying
form key.

PHPBB3-12942
2014-08-11 02:15:05 +08:00
brunoais
67de119566 [ticket/12930] Adding more variables to the event
More variables, according to comments, were added to the event.

PHPBB3-12930
2014-08-10 18:59:57 +01:00
brunoais
1e1efa294e [ticket/12929] Adding more variables to event.
More variables added that may be useful to events at this stage.

PHPBB3-12929
2014-08-10 18:51:35 +01:00
Dhruv Goel
e0d377bca7 Merge pull request #2866 from bantu/ticket/12964
[ticket/12964] Correct use of undefined $row variable.
2014-08-10 18:36:25 +02:00
Marc Alexander
bc9b813ce7 Merge pull request #2864 from rxu/ticket/12931
[ticket/12931] Fix general error on user registration
2014-08-10 18:06:55 +02:00
Marc Alexander
2a5eca0391 Merge pull request #2714 from prototech/ticket/12809
[ticket/12809] Fix select button and dropdown list items in RTL.
2014-08-10 17:00:19 +02:00
Marc Alexander
752c73193e [ticket/12966] Sort posts by post_id in addition to sorting by post_time
This should make sure that posts with the same post time are properly sorted
on database backends like postgres.

PHPBB3-12966
2014-08-10 16:49:01 +02:00
Callum Macrae
7df97601a3 [ticket/12951] Made editorconfig file comments better
PHPBB3-12951
2014-08-10 15:55:02 +02:00
Andreas Fischer
f471eeda33 [ticket/12964] Correct use of undefined $row variable.
PHPBB3-12964
2014-08-10 15:54:56 +02:00
rxu
838d4dc2c6 [ticket/12931] Fix general error on user registration
Fix "Illegal use of $_SERVER" general error on user registration
when $config['server_name'] is not set.

PHPBB3-12931
2014-08-10 21:31:08 +08:00
Joas Schilling
54b0ebc410 Merge pull request #2862 from marc1706/ticket/12932
[ticket/12932] Add method for allowing override of \phpbb\datetime class

* marc1706/ticket/12932:
  [ticket/12932] Remove set_datetime_class method from user class
  [ticket/12932] Fix tests and calls to create_datetime
  [ticket/12932] Add method for getting the datetime class and allow overriding
2014-08-10 15:23:15 +02:00
Dhruv Goel
472fe9fe60 Merge pull request #2730 from omniError/ticket/12831
[ticket/12831] Allow events in page_header functions to prevent the setting of HTTP headers
2014-08-10 15:05:28 +02:00
Carlo
51f534c82e [ticket/12765] Execute query directly from db tools
PHPBB3-12765
2014-08-10 14:26:12 +02:00
Carlo
03040de75a [ticket/12765] Use db_tools instead of generating queries at moment
PHPBB3-12765
2014-08-10 14:26:10 +02:00
Andreas Fischer
547c8a6d8b Merge pull request #2858 from nickvergessen/ticket/12956
[ticket/12956] Ensure the contact columns have been added before using t...

* nickvergessen/ticket/12956:
  [ticket/12956] Ensure the contact columns have been added before using them
2014-08-10 14:16:01 +02:00
Marc Alexander
f0852dcf1a [ticket/12932] Remove set_datetime_class method from user class
PHPBB3-12932
2014-08-10 14:06:19 +02:00
Nils Adermann
252ddd71d0 Merge remote-tracking branch 'github-dhruvgoel92/ticket/12950' into develop-ascraeus
* github-dhruvgoel92/ticket/12950:
  [ticket/12950] Force the installer to use language=en
2014-08-10 13:59:59 +02:00
Dhruv
0244a9b6a4 [ticket/12950] Force the installer to use language=en
PHPBB3-12950
2014-08-10 13:49:42 +02:00
Marc Alexander
8d99b4afe1 [ticket/12932] Fix tests and calls to create_datetime
PHPBB3-12932
2014-08-10 13:43:04 +02:00
Marc Alexander
a57a96cbdd [ticket/12932] Add method for getting the datetime class and allow overriding
An extension can now override the datetime class by overwriting the
datetime.class parameter in their own yml file.

PHPBB3-12932
2014-08-10 13:41:08 +02:00
Joas Schilling
7cc9f216e7 Merge pull request #2836 from marc1706/ticket/12794
[ticket/12794] Properly validate google+ field against valid character set

* marc1706/ticket/12794:
  [ticket/12794] Properly validate google+ field against valid character set
2014-08-10 13:38:48 +02:00
Joas Schilling
b3ca955fb5 Merge pull request #2837 from Geolim4/ticket/12671
Ticket/12671 Possibility to use NOT LIKE expression

* Geolim4/ticket/12671:
  [ticket/12671] Possibility to use NOT LIKE expression
  [ticket/12671] Possibility to use NOT LIKE expression
  [ticket/12671] Possibility to use NOT LIKE expression
  [ticket/12671] Possibility to use NOT LIKE expression
  [ticket/12671] Possibility to use NOT LIKE expression
2014-08-10 13:35:27 +02:00
Joas Schilling
707568c496 Merge pull request #2846 from rxu/ticket/12943
[ticket/12943] Add core.phpbb_generate_debug_output core event

* rxu/ticket/12943:
  [ticket/12943] Add core.phpbb_generate_debug_output core event
2014-08-10 13:19:56 +02:00
Joas Schilling
7ae2ceb5cf Merge pull request #2855 from Geolim4/ticket/12953
[ticket/12953] Page title not updated when notifications are marked as read

* Geolim4/ticket/12953:
  [ticket/12953] Page title not updated when notifications are marked as read
2014-08-10 13:13:55 +02:00
Joas Schilling
1f6b9628e7 Merge pull request #2852 from bantu/ticket/12938
[ticket/12938] Remove the 'Download all attachments' feature.

* bantu/ticket/12938:
  [ticket/12938] Remove functional tests for 'Download all attachments'.
  [ticket/12938] Remove the 'Download all attachments' feature.
2014-08-10 12:22:22 +02:00
Nils Adermann
df9f35cce6 Merge remote-tracking branch 'github-nicofuma/ticket/8064' into develop-ascraeus
* github-nicofuma/ticket/8064:
  [ticket/8064] Change the collation of topic_first_poster_name
2014-08-10 11:54:52 +02:00
omniError
71d39ab7d5 [ticket/12831] fix CS
https://tracker.phpbb.com/browse/PHPBB3-12831

PHPBB3-12831
2014-08-09 20:24:03 -05:00
Joas Schilling
2c7e81bd33 [ticket/12956] Ensure the contact columns have been added before using them
PHPBB3-12956
2014-08-10 02:23:28 +02:00
omniError
7e4c3fde01 [ticket/12831] simplified code, upd event block
https://tracker.phpbb.com/browse/PHPBB3-12831

PHPBB3-12831
2014-08-09 18:48:26 -05:00
Dhruv Goel
5c93735557 Merge pull request #2851 from marc1706/ticket/12949
[ticket/12949] Check if mime_content_type is actually callable
2014-08-10 01:29:59 +02:00
Andreas Fischer
74c3579693 [ticket/12938] Remove functional tests for 'Download all attachments'.
PHPBB3-12938
2014-08-10 01:27:28 +02:00
Tristan Darricau
b000d10ef8 Merge pull request #2849 from bantu/ticket/12941
[ticket/12941] Check for Sami parse errors on Travis CI.

* bantu/ticket/12941:
  [ticket/12941] Fix remaining Sami complaints.
  [ticket/12941] Check for Sami parse errors on Travis CI.
  [ticket/12941] Add sami.conf.php for Travis CI.
2014-08-10 01:02:27 +02:00
Tristan Darricau
990e64105f [ticket/8064] Change the collation of topic_first_poster_name
PHPBB3-8064
2014-08-10 00:58:22 +02:00
Tristan Darricau
6a8413f064 Merge pull request #2691 from dhruvgoel92/ticket/11528
[ticket/11528] Revert all mink changes in functional tests

* dhruvgoel92/ticket/11528:
  [ticket/11528] Revert Mink changes
2014-08-10 00:28:01 +02:00
Tristan Darricau
469790146c Merge pull request #2854 from bantu/ticket/12954
[ticket/12954] Correctly setup PATH_INFO on Travis CI.

* bantu/ticket/12954:
  [ticket/12954] Correctly setup PATH_INFO on Travis CI.
2014-08-10 00:12:58 +02:00
omniError
8989f6f878 [ticket/12831] reimplemented headers as array
https://tracker.phpbb.com/browse/PHPBB3-12831

PHPBB3-12831
2014-08-09 14:40:18 -05:00
Dhruv Goel
d066240e27 Merge pull request #2840 from marc1706/ticket/12742
[ticket/12742] Put duplicated code into one method in notifications base
2014-08-09 20:01:59 +02:00
brunoais
602b932a23 [ticket/12928] Update to RC4
PHPBB3-12928
2014-08-09 18:18:19 +01:00
brunoais
9f5d383d50 [ticket/12930] Update to RC4
PHPBB3-12930
2014-08-09 18:14:11 +01:00
brunoais
8880871951 [ticket/12929] Update to RC4
PHPBB3-12929
2014-08-09 18:13:10 +01:00
Geolim4
db0815f680 [ticket/12671] Possibility to use NOT LIKE expression
PHPBB3-12671
2014-08-09 19:11:21 +02:00
Geolim4
39defd0b6b [ticket/12953] Page title not updated when notifications are marked as read
PHPBB3-12953
2014-08-09 18:56:36 +02:00
Marc Alexander
59398020b6 Merge pull request #2848 from bantu/ticket/12948
[ticket/12948] Remove no longer needed opcache workaround. Travis has 5.5.15
2014-08-09 18:47:41 +02:00
Andreas Fischer
23ca9cd81d [ticket/12954] Correctly setup PATH_INFO on Travis CI.
PHPBB3-12954
2014-08-09 18:33:48 +02:00
Andreas Fischer
076d4ddd7f [ticket/12941] Fix remaining Sami complaints.
PHPBB3-12941
2014-08-09 18:08:49 +02:00
Marc Alexander
496b804a0f [ticket/12742] Add sorting back to bookmark notification list of users
PHPBB3-12742
2014-08-09 17:48:59 +02:00
Marc Alexander
57d94b7bb4 [ticket/12742] Add sort options for notification types requiring sorting
PHPBB3-12742
2014-08-09 17:43:28 +02:00
Tristan Darricau
86f94f922c Merge pull request #2624 from dhruvgoel92/ticket/12718
[ticket/12718] Use remove_topic_from_statistic() for delete_topic

* dhruvgoel92/ticket/12718:
  [ticket/12718] Use a separate variable for sql query
  [ticket/12718] Fix spacing and type casting
  [ticket/12718] Fix docblocks
  [ticket/12718] Add tests to check user_posts on post deletion
  [ticket/12718] Update docblock
  [ticket/12718] Use remove_topic_from_statistic() for delete_topic
2014-08-09 17:33:44 +02:00
Callum Macrae
07f8edcc26 [ticket/12951] Added editorconfig
PHPBB3-12951
2014-08-09 17:33:23 +02:00
Marc Alexander
9f87341046 [ticket/12949] Check if mime_content_type is actually callable
PHPBB3-12949
2014-08-09 17:21:19 +02:00
Dhruv
dd8adb5d6e [ticket/11528] Revert Mink changes
PHPBB3-11528
2014-08-09 17:18:33 +02:00
rxu
917cd4dec7 [ticket/12943] Add core.phpbb_generate_debug_output core event
Add core.phpbb_generate_debug_output core event to allow extensions
outputting additional debug info.

PHPBB3-12943
2014-08-09 23:02:36 +08:00
Andreas Fischer
12caf2f03d [ticket/12938] Remove the 'Download all attachments' feature.
PHPBB3-12938
2014-08-09 16:33:59 +02:00
Nils Adermann
02801dee7c Merge remote-tracking branch 'github-nicofuma/ticket/12693' into develop-ascraeus
* github-nicofuma/ticket/12693:
  [ticket/12693] Don't try to check the composer.phar file
2014-08-09 16:11:34 +02:00
Tristan Darricau
3f73d32c30 [ticket/12693] Don't try to check the composer.phar file
PHPBB3-12693
2014-08-09 16:08:04 +02:00
Andreas Fischer
873d1c6d57 [ticket/12941] Check for Sami parse errors on Travis CI.
PHPBB3-12941
2014-08-09 15:58:04 +02:00
Andreas Fischer
4f131c2248 [ticket/12941] Add sami.conf.php for Travis CI.
PHPBB3-12941
2014-08-09 15:58:04 +02:00
Nils Adermann
56ca276dcf Merge remote-tracking branch 'github-nickvergessen/ticket/12710' into develop-ascraeus
* github-nickvergessen/ticket/12710:
  [ticket/12710] Fix missing closing bracket
  [ticket/12710] Prefix column so it does not start with a number
  [ticket/12710] Pass the original column data to the create function
  [ticket/12710] Fix foreach generation
  [ticket/12710] Compare to uppercase version
  [ticket/12710] Do not try to match the uniqueness in the query
  [ticket/12710] Remove table_name from index_name before deleting and recreating them
  [ticket/12710] Can not use upper in oracles where claus
  [ticket/12710] Correctly select index name and compare to column name
  [ticket/12710] Fix "ORA-00972: identifier is too long [972]" on oracle
  [ticket/12710] Fix problems with creating unique indexes on oracle
  [ticket/12710] Correctly fetch unique and normal indexes only in MSSQL
  [ticket/12710] Fix changing the column type on oracle
  [ticket/12710] Prepare get_existing_indexes() for other DBMS
2014-08-09 15:40:46 +02:00
Andreas Fischer
0a6fdbe636 [ticket/12948] Remove no longer needed opcache workaround. Travis has 5.5.15.
PHPBB3-12948
2014-08-09 15:24:21 +02:00
Nils Adermann
051466106a Merge remote-tracking branch 'github-nicofuma/ticket/12693' into develop-ascraeus
* github-nicofuma/ticket/12693:
  [ticket/12693] Fix composer.phar path
  [ticket/12693] The files skipped list can not be empty
  [ticket/12693] Force the composer.phar to be executable
  [ticket/12693] All the files in bin/ must be executable
  [ticket/12693] Expand manually the wildcard
  [ticket/12693] Fix the query for bin/*
  [ticket/12693] Extract exceptions, bin/* must be executable
  [ticket/12693] Remove the executable bit on icon_print.gif
  [ticket/12693] Check the persmissions of the owner
  [ticket/12693] Check if the are executable and not if they are 644
  [ticket/12693] Fix the permissions
  [ticket/12693] Check if the files have the right 644
  [ticket/12693] Fix indentation
  [ticket/12693] Add a travis test that checks file permissions
2014-08-09 15:19:27 +02:00
Joas Schilling
f87831aee5 [ticket/12710] Fix missing closing bracket
PHPBB3-12710
2014-08-09 15:04:49 +02:00
Geolim4
635cde218c [ticket/12671] Possibility to use NOT LIKE expression
PHPBB3-12671
2014-08-09 15:04:39 +02:00
Joas Schilling
0806c74084 [ticket/12710] Prefix column so it does not start with a number
PHPBB3-12710
2014-08-09 14:42:31 +02:00
Joas Schilling
ef9360d285 [ticket/12710] Pass the original column data to the create function
PHPBB3-12710
2014-08-09 14:42:28 +02:00
Joas Schilling
37a1874782 [ticket/12710] Fix foreach generation
PHPBB3-12710
2014-08-09 14:41:25 +02:00
Joas Schilling
c8e7db60ba [ticket/12710] Compare to uppercase version
PHPBB3-12710
2014-08-09 13:34:22 +02:00
Geolim4
4c06467777 [ticket/12671] Possibility to use NOT LIKE expression
PHPBB3-12671
2014-08-09 13:19:03 +02:00
Joas Schilling
f03a003bea [ticket/12710] Do not try to match the uniqueness in the query
PHPBB3-12710
2014-08-09 13:14:08 +02:00
Marc Alexander
20b8ea947c Merge pull request #2833 from Geolim4/ticket/11520
[ticket/11520] Re-adjust userpost count on topic fork
2014-08-09 13:00:34 +02:00
Joas Schilling
7d44995f16 [ticket/12710] Remove table_name from index_name before deleting and recreating them
PHPBB3-12710
2014-08-09 12:53:15 +02:00
Marc Alexander
0de1d65804 [ticket/12742] Remove unneeded sort of users
It doesn't matter which user will get the notification first so we shouldn't
sort the users array.

PHPBB3-12742
2014-08-09 12:49:32 +02:00
Joas Schilling
078c68da63 [ticket/12710] Can not use upper in oracles where claus
PHPBB3-12710
2014-08-09 12:46:59 +02:00
Marc Alexander
6a13f983a4 [ticket/12742] Replace authenticated with authorised
PHPBB3-12742
2014-08-09 12:42:14 +02:00
brunoais
468f92261a [ticket/12929] core.ucp_pm_compose_compose_pm_basic_info_query_before
Adding the core.ucp_pm_compose_compose_pm_basic_info_query_before
event to mcp backend.

PHPBB3-12929
2014-08-09 11:18:45 +01:00
Dhruv Goel
1351a1fe80 Merge pull request #2843 from bantu/ticket/12940
[ticket/12940] Remove unused use statements.
2014-08-09 12:14:57 +02:00
Andreas Fischer
336d7cd41a [ticket/12940] Remove unused use statements.
PHPBB3-12940
2014-08-09 12:04:30 +02:00
Joas Schilling
7a016572bd Merge pull request #2724 from VSEphpbb/ticket/12841
[ticket/12841] Allow extensions to position new config vars

* VSEphpbb/ticket/12841:
  [ticket/12841] Make config position default to after
  [ticket/12841] Update comments in tests making after default
  [ticket/12841] prefix function name with phpbb_
  [ticket/12841] Add a tests for the new function
  [ticket/12841] Fix white space issues reported by sniffer
  [ticket/12841] Allow extensions to position new config vars
2014-08-09 11:43:56 +02:00
Joas Schilling
12eb993d23 [ticket/12710] Correctly select index name and compare to column name
PHPBB3-12710
2014-08-09 08:54:40 +02:00
Joas Schilling
4e4ea681be [ticket/12710] Fix "ORA-00972: identifier is too long [972]" on oracle
PHPBB3-12710
2014-08-09 08:33:15 +02:00
Joas Schilling
cdcfd1fe1e [ticket/12710] Fix problems with creating unique indexes on oracle
PHPBB3-12710
2014-08-09 08:28:44 +02:00
Joas Schilling
96fc29eecc [ticket/12710] Correctly fetch unique and normal indexes only in MSSQL
PHPBB3-12710
2014-08-09 08:27:10 +02:00
Marc Alexander
deaa0a8c75 Merge pull request #2841 from nickvergessen/ticket/security-155
[ticket/security-155] Cast the types of string values in the controller routes
2014-08-09 01:46:39 +02:00
Joas Schilling
e6f43f5974 [ticket/security-155] Fix spelling error in comment
SECURITY-155
2014-08-09 01:45:26 +02:00
Geolim4
01943adbf7 [ticket/12671] Possibility to use NOT LIKE expression
PHPBB3-12671
2014-08-08 18:32:17 +02:00
Nils Adermann
13ccb352ce Merge remote-tracking branch 'github-bantu/ticket/12937' into develop-ascraeus
* github-bantu/ticket/12937:
  [ticket/12937] Do not return false. Return null for get and array() for all.
2014-08-08 17:23:07 +02:00
brunoais
6fafa40d93 [ticket/12930] core.ucp_pm_compose_compose_pm_quotepost_query_after
Adding the core.ucp_pm_compose_compose_pm_quotepost_query_after
event to ucp backend.

PHPBB3-12930
2014-08-08 16:20:51 +01:00
Joas Schilling
558aff46cd [ticket/security-155] Cast the types of string values in the controller routes
SECURITY-155
2014-08-08 17:15:01 +02:00
Geolim4
3825aee130 [ticket/11520] Re-adjust userpost count on topic fork
PHPBB3-11520
2014-08-08 17:07:29 +02:00
Geolim4
af67bd3ea5 [ticket/11520] Coding guideline compliance
PHPBB3-11520
2014-08-08 17:07:16 +02:00
Marc Alexander
a6b275de5c [ticket/12794] Properly validate google+ field against valid character set
PHPBB3-12794
2014-08-08 17:06:01 +02:00
Geolim4
fc1e420a7c [ticket/11520] Re-adjust userpost count on topic fork
PHPBB3-11520
2014-08-08 17:05:40 +02:00
Marc Alexander
cccd54dde8 [ticket/12742] Add check for empty $users and add method to fitting methods
The method might now return an empty array in case of an empty users array,
too. The notification types then check if the returned array is empty and
return this if it is empty and if the notification types would otherwise
carry out other operations afterwards.

PHPBB3-12742
2014-08-08 16:54:23 +02:00
Marc Alexander
80788980aa [ticket/12742] Add method for getting authenticated recipients
PHPBB3-12742
2014-08-08 16:43:31 +02:00
Geolim4
6b60153ab4 [ticket/12671] Possibility to use NOT LIKE expression
PHPBB3-12671
2014-08-08 16:40:33 +02:00
Andreas Fischer
f6da266109 Merge pull request #2822 from marc1706/ticket/12886
[ticket/12886] Remove obsolete check for f_user_lock

* marc1706/ticket/12886:
  [ticket/12886] Remove obsolete check for f_user_lock
2014-08-08 16:11:47 +02:00
Joas Schilling
0465e9d1b9 Merge pull request #2838 from dhruvgoel92/ticket/12738
[ticket/12738] Pass $this->config in content_visibility constructor

* dhruvgoel92/ticket/12738:
  [ticket/12738] Pass $this->config in content_visibility constructor
2014-08-08 16:05:55 +02:00
Andreas Fischer
42c26cd781 Merge pull request #2832 from marc1706/ticket/10404
[ticket/10404] Use anonymous function instead of create_function in acp/auth

* marc1706/ticket/10404:
  [ticket/10404] Fix codesniffer complaint about anonymous function
  [ticket/10404] Use anonymous function instead of create_function in acp/auth
2014-08-08 16:03:24 +02:00
Andreas Fischer
50fcd70428 Merge pull request #2815 from dhruvgoel92/ticket/12778
[ticket/12778] Automatically delete files on update

* dhruvgoel92/ticket/12778:
  [ticket/12778] Rename the file to *.bak instead of deleting
  [ticket/12778] Automatically delete files on update
2014-08-08 16:01:42 +02:00
Dhruv
fcb57edd06 [ticket/12738] Pass $this->config in content_visibility constructor
PHPBB3-12738
2014-08-08 15:54:42 +02:00
Andreas Fischer
c5f0c1aa8e [ticket/12937] Do not return false. Return null for get and array() for all.
PHPBB3-12937
2014-08-08 15:29:34 +02:00
Nils Adermann
44a0f43062 Merge remote-tracking branch 'github-nicofuma/ticket/12789' into develop-ascraeus
* github-nicofuma/ticket/12789:
  [ticket/12789] Move duplicated functions to the base class
  [ticket/12789] Remove the directories in \phpbb\cache\driver\memory::purge()
2014-08-08 15:04:01 +02:00
Joas Schilling
96e9d728b9 Merge pull request #2824 from brunoais/ticket/12927
[ticket/12927] core.mcp_queue_get_posts2_query_before

* brunoais/ticket/12927:
  [ticket/12927] core.mcp_queue_get_posts2_query_before
2014-08-08 14:52:35 +02:00
Tristan Darricau
e07e9f6cee [ticket/12789] Move duplicated functions to the base class
PHPBB3-12789
2014-08-08 14:49:12 +02:00
Tristan Darricau
e7251252ce [ticket/12789] Remove the directories in \phpbb\cache\driver\memory::purge()
PHPBB3-12789
2014-08-08 14:37:18 +02:00
Joas Schilling
53247573c2 Merge pull request #2764 from brunoais/ticket/12880
[ticket/12880] core.mcp_queue_!is_topics_query_before

* brunoais/ticket/12880:
  [ticket/12880] core.mcp_queue_!is_topics_query_before
2014-08-08 14:35:53 +02:00
Joas Schilling
bef9d64179 Merge pull request #2762 from brunoais/ticket/12876
[ticket/12876] core.mcp_mcp_front.mcp_front_view_queue_postid_list_after

* brunoais/ticket/12876:
  [ticket/12876] core.mcp_mcp_front.mcp_front_view_queue_postid_list_after
2014-08-08 14:32:55 +02:00
brunoais
621f940805 [ticket/12928] core.mcp_reports_gather_query_before
Adding the core.mcp_reports_gather_query_before
event to mcp backend.

PHPBB3-12928
2014-08-08 13:10:59 +01:00
Marc Alexander
27f769e461 [ticket/10404] Fix codesniffer complaint about anonymous function
PHPBB3-10404
2014-08-08 14:01:04 +02:00
Cesar G
ad97ad07f8 Merge remote-tracking branch 'PayBas/ticket/12535' into develop-ascraeus
* PayBas/ticket/12535:
  [ticket/12535] Combine inner clearing CSS rules
  [ticket/12535] Update events.md to RC3
  [ticket/12535] Add events to subsilver2
  [ticket/12535] Make <a> adjust to the image width
2014-08-08 13:46:58 +02:00
Cesar G
f1b1bd0de9 Merge remote-tracking branch 'marc1706/ticket/12744' into develop-ascraeus
* marc1706/ticket/12744:
  [ticket/12744] Fix additional height of one line in header in rtl languages
2014-08-08 13:41:37 +02:00
Marc Alexander
20f8fd4af2 [ticket/12744] Fix additional height of one line in header in rtl languages
PHPBB3-12744
2014-08-08 13:26:11 +02:00
Marc Alexander
c5d72c94f1 [ticket/10404] Use anonymous function instead of create_function in acp/auth
PHPBB3-10404
2014-08-08 12:19:36 +02:00
Marc Alexander
70978e96d3 [ticket/12822] Fix test runs of avatar manager_test
PHPBB3-12822
2014-08-08 12:01:29 +02:00
brunoais
0679f76287 [ticket/12927] core.mcp_queue_get_posts2_query_before
Adding the core.mcp_queue_get_posts2_query_before
event to mcp backend.

PHPBB3-12927
2014-08-08 10:52:08 +01:00
Dhruv
15afaafcb6 [ticket/12718] Use a separate variable for sql query
PHPBB3-12718
2014-08-08 00:18:50 +02:00
Dhruv
6d399c7d6a [ticket/12718] Fix spacing and type casting
PHPBB3-12718
2014-08-07 23:47:32 +02:00
Dhruv
833ba11113 [ticket/12718] Fix docblocks
PHPBB3-12718
2014-08-07 23:46:12 +02:00
Marc Alexander
e4e7a8f849 Merge pull request #2829 from nickvergessen/ticket/12853
[ticket/12853] Hide moderator link if it is really necessary
2014-08-07 23:37:35 +02:00
Joas Schilling
9ed71d523a [ticket/12853] Hide moderator link if it is really necessary
PHPBB3-12853
2014-08-07 23:27:56 +02:00
Marc Alexander
98c98e52eb [ticket/12886] Remove obsolete check for f_user_lock
The user shouldn't be able to unlock his own topic if he doesn't have m_lock
permissions. Also, the check for f_user_lock was never going to evaluate to
true due to the topic not being unlocked making it obsolete anyway.

PHPBB3-12886
2014-08-07 23:10:14 +02:00
Joas Schilling
b39305b9f6 [ticket/12710] Fix changing the column type on oracle
PHPBB3-12710
2014-08-07 19:45:34 +02:00
brunoais
1f5f2327e8 [ticket/12876] core.mcp_mcp_front.mcp_front_view_queue_postid_list_after
Adding the core.mcp_mcp_front.mcp_front_view_queue_topicid_list_after
event to mcp backend.

PHPBB3-12876
2014-08-07 18:37:07 +01:00
brunoais
50cc81afa3 [ticket/12880] core.mcp_queue_!is_topics_query_before
Adding core.mcp_queue_is_topics_query_before

PHPBB3-12880
2014-08-07 18:33:37 +01:00
Joas Schilling
339bf90ec2 [ticket/12710] Prepare get_existing_indexes() for other DBMS
PHPBB3-12710
2014-08-07 18:43:48 +02:00
Dhruv
4c2b4b4145 [ticket/12718] Add tests to check user_posts on post deletion
PHPBB3-12718
2014-08-07 18:36:50 +02:00
Andreas Fischer
8d8d54aac7 Merge pull request #2816 from n-aleha/ticket/12922
[ticket/12922] Posts per page in MCP should have a min value of zero

* n-aleha/ticket/12922:
  [ticket/12922] Subsilver2 fix
  [ticket/12922] Posts per page in MCP should have a min value of zero
2014-08-07 18:23:46 +02:00
PayBas
e6dec0348a [ticket/12535] Combine inner clearing CSS rules
PHPBB3-12535
2014-08-07 18:23:01 +02:00
PayBas
dda853b896 [ticket/12535] Update events.md to RC3
PHPBB3-12535
2014-08-07 18:08:50 +02:00
PayBas
e28abe0db2 [ticket/12535] Add events to subsilver2
Forgot subsilver... yet again

PHPBB3-12535
2014-08-07 18:08:48 +02:00
PayBas
5fedcf0fa8 [ticket/12535] Make <a> adjust to the image width
PHPBB3-12535
2014-08-07 18:08:46 +02:00
Dhruv Goel
ba2c40cde9 Merge pull request #2821 from bantu/ticket/12903
[ticket/12903] Remove dead phpbb\extension\metadata_manager::_validate_version
2014-08-07 18:01:11 +02:00
jeroendedauw
f6f6657842 [ticket/12903] Remove dead phpbb\extension\metadata_manager::_validate_version
PHPBB3-12903
2014-08-07 17:52:59 +02:00
Marc Alexander
a8dee3fb65 Merge pull request #2810 from nickvergessen/ticket/12919
[ticket/12919] Use the modules basename as identifier for extension modules
2014-08-07 17:36:19 +02:00
Marc Alexander
e0c2013bb9 [ticket/12822] Add method for deleting avatars and use confirm_box
The method will take care of the actual deletion process in the avatar manager.
Additionally, we'll be using a confirm box while deleting the avatar to prevent
users from accidentally deleting their avatars.

PHPBB3-12822
2014-08-07 17:29:33 +02:00
Marc Alexander
4f23bb711c [ticket/12822] Remove "None" option from avatar select boxes
This option is just used for deleting avatars for which we already have
a checkbox.

PHPBB3-12822
2014-08-07 17:28:21 +02:00
Dhruv
340bea63b6 [ticket/12718] Update docblock
PHPBB3-12718
2014-08-07 17:19:28 +02:00
Dhruv
17e360225d [ticket/12718] Use remove_topic_from_statistic() for delete_topic
PHPBB3-12718
2014-08-07 17:19:14 +02:00
PayBas
802232c907 [ticket/12506] Fix search result h3 margin
There are no buttons present, so don't need to do all this stuff.

PHPBB3-12506
2014-08-07 17:13:22 +02:00
PayBas
3522808528 [ticket/12506] Fix responsive profile min-height (no avatar)
PHPBB3-12506
2014-08-07 17:13:20 +02:00
PayBas
09e45fee89 [ticket/12506] Reposition buttons to make room for "online" banner
PHPBB3-12506
2014-08-07 17:13:18 +02:00
PayBas
64dfb3fba9 [ticket/12506] Reposition post-buttons for compact layout
PHPBB3-12506
2014-08-07 17:13:17 +02:00
Dhruv
5488541640 [ticket/12778] Rename the file to *.bak instead of deleting
PHPBB3-12778
2014-08-07 16:52:49 +02:00
Joas Schilling
9b36b5283c Merge pull request #2761 from Nicofuma/ticket/12873
[ticket/12873] Test the correct identifier in \phpbb\db\tools

* Nicofuma/ticket/12873:
  [ticket/12873] Add migration to rename the index
  [ticket/12873] Don not touch the existing migrations
  [ticket/12873] Test the good identifier in \phpbb\db\tools
2014-08-07 16:49:37 +02:00
Tristan Darricau
ab8a197e92 Merge pull request #2623 from dhruvgoel92/ticket/12738
[ticket/12738] Move related code from functions_posting to function

* dhruvgoel92/ticket/12738:
  [ticket/12738] Update constructor docblock
  [ticket/12738] Add $config to constructor in notification test
  [ticket/12738] Fix tests with new config object injection
  [ticket/12738] Inject config object into content_visibility class
  [ticket/11528] Move related code from functions_posting to function
2014-08-07 16:44:49 +02:00
Cesar G
742133f6dc [ticket/12809] Restore text-align for the pagination.
PHPBB3-12809
2014-08-07 16:40:09 +02:00
Cesar G
cf4fb73440 [ticket/12809] Remove obsolete rules and selector.
PHPBB3-12809
2014-08-07 16:40:09 +02:00
Cesar G
42afa369a0 [ticket/12809] Fix select button and dropdown list items in RTL.
PHPBB3-12809
2014-08-07 16:40:09 +02:00
Nils Adermann
778483d070 Merge remote-tracking branch 'github-nickvergessen/ticket/12776' into develop-ascraeus
* github-nickvergessen/ticket/12776:
  [ticket/12776] Add section about 3.0.x to 3.1.x update to INSTALL.html
2014-08-07 16:25:53 +02:00
Joas Schilling
a2b6f4e166 Merge pull request #2812 from bantu/ticket/12826
[ticket/12826] Add root namespace indicator to exception catching.

* bantu/ticket/12826:
  [ticket/12826] Add optional root namespace indicator for consistency.
  [ticket/12826] Add mandatory root namespace indicator to exception catching.
2014-08-07 16:24:41 +02:00
Cesar G
3b7ab23e29 Merge remote-tracking branch 'PayBas/ticket/12832' into develop-ascraeus
* PayBas/ticket/12832:
  [ticket/12832] Remove old .quick-links icon reference
  [ticket/12832] Remove unnecessary attr and classes
  [ticket/12832] Add footer links to quick-links
  [ticket/12832] Make .small-icon styling uniform
2014-08-07 16:20:37 +02:00
Joas Schilling
0194c261c3 Merge pull request #2720 from PayBas/ticket/12838
[ticket/12838] Add ACP events to acp_ranks

* PayBas/ticket/12838:
  [ticket/12838] Simplify normal special rank array creation
  [ticket/12838] Update RC2 to RC3
  [ticket/12838] Update events.md to RC3
  [ticket/12838] Allow for extra columns in cache obtain_ranks()
  [ticket/12838] Add raw row-data to acp_ranks core event
  [ticket/12838] Simplify special rank template conditional
  [ticket/12838] Add core events to acp_ranks.php
  [ticket/12838] Update events.md
  [ticket/12838] Add _before versions
  [ticket/12838] Add template events to acp_ranks.html
2014-08-07 16:13:35 +02:00
n-aleha
035f84d2da [ticket/12922] Subsilver2 fix
PHPBB3-12922
2014-08-07 17:10:32 +03:00
Joas Schilling
6bb71e2ca9 Merge pull request #2813 from naderman/ticket/12920
[ticket/12920] Add composer.json to phpBB/phpbb and fix the one in phpBB/

* naderman/ticket/12920:
  [ticket/12920] Add missing comma
  [ticket/12920] Update composer.lock file after update nothing
  [ticket/12920] Fix sh syntax error in post-update-cmd script
  [ticket/12920] Remove incorrect @ from self.version reference in composer.json
  [ticket/12920] Output warning message about vendor cleaning target
  [ticket/12920] Turn phpBB composer.json into publishable full version
  [ticket/12920] Add require for minimum php version
  [ticket/12920] Add composer.json for phpbb/phpbb-core library
2014-08-07 16:09:51 +02:00
n-aleha
98155a945f [ticket/12922] Posts per page in MCP should have a min value of zero
In order to allow displaying the whole topic in MCP=>Main=>View topic,
the min value in the html input field must be 0.

PHPBB3-12922
2014-08-07 17:08:33 +03:00
Joas Schilling
f1d3d87d47 [ticket/12776] Add section about 3.0.x to 3.1.x update to INSTALL.html
PHPBB3-12776
2014-08-07 16:06:44 +02:00
Dhruv
07a92d29df [ticket/12778] Automatically delete files on update
PHPBB3-12778
2014-08-07 15:49:41 +02:00
Nils Adermann
be04b6c136 [ticket/12920] Add missing comma
PHPBB3-12920
2014-08-07 15:44:36 +02:00
Nils Adermann
b9fb4e3050 [ticket/12920] Update composer.lock file after update nothing
PHPBB3-12920
2014-08-07 15:43:44 +02:00
Nils Adermann
9f3e678117 [ticket/12920] Fix sh syntax error in post-update-cmd script
PHPBB3-12920
2014-08-07 15:40:57 +02:00
Nils Adermann
9e282b8d4d [ticket/12920] Remove incorrect @ from self.version reference in composer.json
PHPBB3-12920
2014-08-07 15:38:04 +02:00
Nils Adermann
e0b7a3e9ff [ticket/12920] Output warning message about vendor cleaning target
PHPBB3-12920
2014-08-07 15:37:13 +02:00
Joas Schilling
ef26a6fd64 Merge pull request #2811 from bantu/ticket/12918
[ticket/12918] Load class fileupload in fileupload_remote_test.php.

* bantu/ticket/12918:
  [ticket/12918] Load class fileupload in fileupload_remote_test.php.
2014-08-07 15:29:40 +02:00
Nils Adermann
c863136a69 [ticket/12920] Turn phpBB composer.json into publishable full version
PHPBB3-12920
2014-08-07 15:26:02 +02:00
Nils Adermann
200c6f2d32 [ticket/12920] Add require for minimum php version
PHPBB3-12920
2014-08-07 15:25:47 +02:00
Nils Adermann
3b3da3938d [ticket/12920] Add composer.json for phpbb/phpbb-core library
PHPBB3-12920
2014-08-07 15:16:58 +02:00
Marc Alexander
1304ccc02b Merge pull request #2763 from brunoais/ticket/12877
[ticket/12877] core.mcp_mcp_front_reports_listing_query_before
2014-08-07 15:09:18 +02:00
Andreas Fischer
aa88d48b37 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
2014-08-07 14:30:53 +02:00
Andreas Fischer
f8d2dd720f Merge pull request #2809 from nickvergessen/ticket/12917-asc
Ticket/12917 asc

* nickvergessen/ticket/12917-asc:
  [ticket/12917] Check commit message and image ICC profile on 5.3.3
2014-08-07 14:30:48 +02:00
Andreas Fischer
f01b602e9f Merge pull request #2808 from nickvergessen/ticket/12917
[ticket/12917] Check commit message and image ICC profile on 5.3.3

* nickvergessen/ticket/12917:
  [ticket/12917] Check commit message and image ICC profile on 5.3.3
2014-08-07 14:30:41 +02:00
Tristan Darricau
2b3e15cf64 [ticket/12873] Add migration to rename the index
PHPBB3-12873
2014-08-07 14:27:12 +02:00
Andreas Fischer
e523711ec2 [ticket/12826] Add optional root namespace indicator for consistency.
PHPBB3-12826
2014-08-07 14:25:53 +02:00
Andreas Fischer
cc1a713fd8 [ticket/12826] Add mandatory root namespace indicator to exception catching.
PHPBB3-12826
2014-08-07 14:24:38 +02:00
PayBas
d8d09e0df2 [ticket/12838] Simplify normal special rank array creation
PHPBB3-12838
2014-08-07 14:24:21 +02:00
Tristan Darricau
27b4ab9241 [ticket/12873] Don not touch the existing migrations
PHPBB3-12873
2014-08-07 14:16:57 +02:00
Andreas Fischer
714ac0b039 [ticket/12918] Load class fileupload in fileupload_remote_test.php.
PHPBB3-12918
2014-08-07 14:11:22 +02:00
Joas Schilling
f1419ab27e [ticket/12919] Use the modules basename as identifier for extension modules
PHPBB3-12919
2014-08-07 14:06:45 +02:00
Tristan Darricau
079f1e2f41 [ticket/12693] Fix composer.phar path
PHPBB3-12693
2014-08-07 14:00:43 +02:00
Joas Schilling
7cde9a8ec0 Merge branch 'ticket/12917' into ticket/12917-asc
* ticket/12917:
  [ticket/12917] Check commit message and image ICC profile on 5.3.3

Conflicts:
	.travis.yml
2014-08-07 13:43:13 +02:00
Joas Schilling
b700e871cf [ticket/12917] Check commit message and image ICC profile on 5.3.3
PHPBB3-12917
2014-08-07 13:40:31 +02:00
Joas Schilling
f474e33a43 Merge pull request #2729 from Nicofuma/ticket/12847
[ticket/12847] Allow the extensions to say if they can be enabled

* Nicofuma/ticket/12847:
  [ticket/12847] Allow the extensions to say if they can be enabled
2014-08-07 13:00:08 +02:00
Joas Schilling
2f44a865a0 Merge pull request #2477 from n-aleha/ticket/12557ascraeus
[ticket/12557] Fix doc block errors found by Sami for ascraeus

* n-aleha/ticket/12557ascraeus:
  [ticket/12557] Fix load active module description
  [ticket/12557] Fix php file description
  [ticket/12557] Fix post data description for notifications
  [ticket/12557] Fix pass by reference doc blocks
  [ticket/12557] Fix doc block in extension base class
  [ticket/12557] Fix doc block in mimetype guesser
  [ticket/12557] Fix var $preserve_cr description
  [ticket/12557] Fix doc block errors found by Sami
  [ticket/12557] Fix doc block errors found by Sami
  [ticket/12557] Fix doc block errors found by Sami
  [ticket/12557] Template fixes
  [ticket/12557] Search, cron and profilefields fixes
  [ticket/12557] Notification fixes
  [ticket/12557] Fix doc block errors found by Sami pt1
  [ticket/12557] Fix doc block errors found by Sami
  [ticket/12557] Fix doc block errors found by Sami
2014-08-07 12:43:45 +02:00
Joas Schilling
83544992ec Merge pull request #2644 from Nicofuma/ticket/12051
[ticket/12051] Optimise Composer Autoloader on Build

* Nicofuma/ticket/12051:
  [ticket/12051] Optimise Composer Autoloader on Build
2014-08-07 12:30:46 +02:00
n-aleha
cea0cfa6f8 [ticket/12557] Fix load active module description
PHPBB3-12557
2014-08-07 13:22:07 +03:00
n-aleha
8006746780 [ticket/12557] Fix php file description
PHPBB3-12557
2014-08-07 13:19:49 +03:00
Nils Adermann
b203b4afa1 Merge remote-tracking branch 'github-marc1706/ticket/11148' into develop-ascraeus
* github-marc1706/ticket/11148:
  [ticket/11148] Remove unneeded variable mimetype and use type octet-stream
  [ticket/11148] Change expected output with disallowed content in test
  [ticket/11148] Always use the output of the mimetype guesser in get_mimetype
  [ticket/11148] Get rid of extra line in mimetype guesser setter doc block
  [ticket/11148] Add missing parts to docblock of get_mimetype() method
  [ticket/11148] Default to application/octet-stream if no mimetype given
  [ticket/11148] Use mimetype guesser for uploaded avatars
  [ticket/11148] Pass mimetype guesser to upload_attachment() function
  [ticket/11148] Add mimetype guesser to filespec and fileupload class
2014-08-07 12:06:33 +02:00
n-aleha
9133b913ec [ticket/12557] Fix post data description for notifications
PHPBB3-12557
2014-08-07 13:03:11 +03:00
Joas Schilling
a8cb525f77 Merge pull request #2717 from Nicofuma/ticket/12836
[ticket/12836] Add event core.functions.redirect

* Nicofuma/ticket/12836:
  [ticket/12836] Add event core.functions.redirect
2014-08-07 11:47:37 +02:00
n-aleha
9d285bdcf5 [ticket/12557] Fix pass by reference doc blocks
PHPBB3-12557
2014-08-07 11:39:04 +03:00
Marc Alexander
decc896bf5 Merge pull request #2799 from nickvergessen/ticket/12901
Ticket/12901 Wrong type hint in show_available_child_styles() doc block
2014-08-06 23:42:04 +02:00
Marc Alexander
964bf0b9f5 Merge pull request #2807 from nickvergessen/ticket/12875
[ticket/12875] Find language files in the default and english language
2014-08-06 23:37:55 +02:00
Joas Schilling
ca11018760 Merge pull request #2798 from tmbackoff/ticket/12912
[ticket/12912] Undefined index when adding logs from extensions

* tmbackoff/ticket/12912:
  [ticket/12912] Undefined index when adding logs from extensions
2014-08-06 23:35:59 +02:00
Joas Schilling
0328bc38a4 Merge pull request #2795 from Dragooon/ticket/12910
[ticket/12910] Set get_name for Google+ fields

* Dragooon/ticket/12910:
  [ticket/12910] Set get_name for Google+ fields
2014-08-06 23:27:44 +02:00
Joas Schilling
243ca3ae82 Merge pull request #2806 from rxu/ticket/12913
[ticket/12913] Add more parameters to core.submit_post_end event

* rxu/ticket/12913:
  [ticket/12913] Add more parameters to core.submit_post_end event
2014-08-06 23:14:06 +02:00
Joas Schilling
591d04157e [ticket/12875] Find language files in the default and english language ...
... when looking for info_xcp_ files.

PHPBB3-12875
2014-08-06 23:04:33 +02:00
n-aleha
e6d6977750 [ticket/12557] Fix doc block in extension base class
PHPBB3-12557
2014-08-06 15:34:42 +03:00
rxu
a9c3c4056c [ticket/12913] Add more parameters to core.submit_post_end event
As @event core.modify_submit_post_data can modify any of the
function submit_post parameters, they may be needed to perform
actions directly after a post or topic has been submitted in
@event core.submit_post_end (includes/functions_posting.php).

PHPBB3-12913
2014-08-06 15:48:26 +08:00
Tristan Darricau
f3f54922be [ticket/12836] Add event core.functions.redirect
PHPBB3-12836
2014-08-04 10:19:32 +02:00
Joas Schilling
7755f5354f [ticket/12901] Fix another wrong type hint for $level
PHPBB3-12901
2014-08-03 22:42:17 +02:00
jeroendedauw
1d923260a6 [ticket/12901] Fix type hinting of style $level
PHPBB3-12901
2014-08-03 22:42:16 +02:00
Andreas Fischer
eb872c36d8 Merge pull request #2796 from bantu/ticket/12906
[ticket/12906] Add rel="help" to FAQ link

* bantu/ticket/12906:
  [ticket/12906] Add rel="help" to FAQ link
2014-08-03 19:51:23 +02:00
Shitiz Garg
79cccebc6e [ticket/12910] Set get_name for Google+ fields
PHPBB3-12910
2014-08-03 23:20:53 +05:30
Tabitha Backoff
d5db09e888 [ticket/12912] Undefined index when adding logs from extensions
Add isset() to forum_id and topic_id.

PHPBB3-12912
2014-08-03 13:28:14 -04:00
Louis7777
89fc664227 [ticket/12906] Add rel="help" to FAQ link
PHPBB3-12906
2014-08-03 18:00:25 +02:00
Andreas Fischer
7beef6e142 Merge pull request #2793 from n-aleha/ticket/12909
[ticket/12909] Use correct lang vars in cli extension enable

* n-aleha/ticket/12909:
  [ticket/12909] Use correct lang vars in cli extension enable
2014-08-03 17:52:24 +02:00
Andreas Fischer
b20c6936bc Merge pull request #2792 from n-aleha/ticket/12908
[ticket/12908] Fix operator typo in increment.php

* n-aleha/ticket/12908:
  [ticket/12908] Fix operator typo in increment.php
2014-08-03 17:52:00 +02:00
n-aleha
752363b435 [ticket/12909] Use correct lang vars in cli extension enable
PHPBB3-12909
2014-08-03 09:53:18 +03:00
n-aleha
cf93b7e367 [ticket/12908] Fix operator typo in increment.php
PHPBB3-12908
2014-08-03 08:34:25 +03:00
n-aleha
2cc20fb977 [ticket/12557] Fix doc block in mimetype guesser
PHPBB3-12557
2014-08-03 07:13:21 +03:00
n-aleha
6d7689f581 [ticket/12557] Fix var $preserve_cr description
PHPBB3-12557
2014-08-03 07:13:21 +03:00
n-aleha
95ec9590df [ticket/12557] Fix doc block errors found by Sami
PHPBB3-12557
2014-08-03 07:13:20 +03:00
n-aleha
6ac8d17af6 [ticket/12557] Fix doc block errors found by Sami
More corrections.

PHPBB3-12557
2014-08-03 07:13:20 +03:00
n-aleha
c355b60c62 [ticket/12557] Fix doc block errors found by Sami
More corrections.

PHPBB3-12557
2014-08-03 07:13:20 +03:00
n-aleha
dfcbace621 [ticket/12557] Template fixes
PHPBB3-12557
2014-08-03 07:12:34 +03:00
n-aleha
8f2395857e [ticket/12557] Search, cron and profilefields fixes
PHPBB3-12557
2014-08-03 07:06:29 +03:00
n-aleha
f34bc924a6 [ticket/12557] Notification fixes
PHPBB3-12557
2014-08-03 07:03:08 +03:00
n-aleha
ffcf45abf3 [ticket/12557] Fix doc block errors found by Sami pt1
PHPBB3-12557
2014-08-03 07:03:08 +03:00
n-aleha
8ac8c9ec61 [ticket/12557] Fix doc block errors found by Sami
More corrections.

PHPBB3-12557
2014-08-03 06:57:05 +03:00
n-aleha
19b9df7e63 [ticket/12557] Fix doc block errors found by Sami
PHPBB3-12557
2014-08-03 06:57:05 +03:00
Joas Schilling
c991b1d587 Merge pull request #2782 from marc1706/ticket/12895
[ticket/12895] Rename user style setting to resolve conflict with style param

* marc1706/ticket/12895:
  [ticket/12895] Rename user style setting to resolve conflict with style param
2014-08-02 13:56:16 +02:00
Joas Schilling
66f859d109 Merge branch 'ticket/JeroenDeDauw/12902' into develop-ascraeus
* ticket/JeroenDeDauw/12902:
  [ticket/12902] Remove duplicate entry in switch statement
2014-08-02 13:46:13 +02:00
jeroendedauw
626234aece [ticket/12902] Remove duplicate entry in switch statement
PHPBB3-12902
2014-08-02 13:44:51 +02:00
Marc Alexander
ce2c31d18a Merge remote-tracking branch 'brunoais/ticket/12801' into develop-ascraeus 2014-08-01 23:31:31 +02:00
Marc Alexander
5b2e962934 Merge remote-tracking branch 'brunoais/ticket/12800' into develop-ascraeus 2014-08-01 23:27:55 +02:00
omniError
a7794b765c [ticket/12831] Optn to prevent setting HTTP headers
https://tracker.phpbb.com/browse/PHPBB3-12831

PHPBB3-12831
2014-08-01 15:27:17 -05:00
Joas Schilling
50d10c4efd Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
2014-08-01 22:23:53 +02:00
Joas Schilling
6ced579ab3 Merge pull request #2784 from Nicofuma/ticket/11480-ascraeus
[ticket/11480-ascraeus] PM : "Unknown folder" returned when inbox folder is full

* Nicofuma/ticket/11480-ascraeus:
  [ticket/11480] Header file
  [ticket/11480] Fix unit tests
  [ticket/11480] Move the test into get_folder()
  [ticket/11480] Fix the double spaces in phpbb_functional_test_case
  [ticket/11480] Fix typos
  [ticket/11480] Add functionnal test
  [ticket/11480] PM : "Unknown folder" returned when inbox folder is full
2014-08-01 22:23:36 +02:00
Joas Schilling
122898d221 Merge pull request #2350 from Nicofuma/ticket/11480
[ticket/11480] PM : "Unknown folder" returned when inbox folder is full

* Nicofuma/ticket/11480:
  [ticket/11480] Move the test into get_folder()
  [ticket/11480] Fix the double spaces in phpbb_functional_test_case
  [ticket/11480] Fix typos
  [ticket/11480] Add functionnal test
  [ticket/11480] PM : "Unknown folder" returned when inbox folder is full
2014-08-01 22:17:17 +02:00
brunoais
47bfe2999d [ticket/12801] Changed name change @since as requested
Changed name to core.load_drafts_draft_list_result as requested

Changed @since to 3.1.0-RC3 because RC2 is already out.

PHPBB3-12801
2014-08-01 11:12:29 +01:00
brunoais
25826fa587 [ticket/12880] Changed name change @since as requested
Changed name to core.display_user_activity_modify_actives as requested

Changed @since to 3.1.0-RC3 because RC2 is already out.

PHPBB3-12880
2014-08-01 11:09:26 +01:00
Marc Alexander
89557f5cac Merge remote-tracking branch 'VSE/ticket/12864' into develop-ascraeus 2014-07-31 21:39:48 +02:00
Tristan Darricau
cd0dad8951 [ticket/11480] Header file
PHPBB3-11480
2014-07-31 15:36:58 +02:00
Tristan Darricau
67d19920c4 [ticket/11480] Fix unit tests
PHPBB3-11480
2014-07-31 15:36:42 +02:00
Tristan Darricau
4328141fd2 [ticket/12693] The files skipped list can not be empty
PHPBB3-12693
2014-07-31 14:20:48 +02:00
Tristan Darricau
92106d52d0 [ticket/12693] Force the composer.phar to be executable
PHPBB3-12693
2014-07-31 14:20:46 +02:00
Tristan Darricau
5739a3da8f [ticket/12693] All the files in bin/ must be executable
PHPBB3-12693
2014-07-31 14:20:45 +02:00
Tristan Darricau
d284675241 [ticket/12693] Expand manually the wildcard
PHPBB3-12693
2014-07-31 14:20:44 +02:00
Tristan Darricau
6081175857 [ticket/12693] Fix the query for bin/*
PHPBB3-12693
2014-07-31 14:20:42 +02:00
Tristan Darricau
ffcc1e9d94 [ticket/12693] Extract exceptions, bin/* must be executable
PHPBB3-12693
2014-07-31 14:20:41 +02:00
Tristan Darricau
ae9c1cddc8 [ticket/12693] Remove the executable bit on icon_print.gif
PHPBB3-12693
2014-07-31 14:20:40 +02:00
Tristan Darricau
949264507d [ticket/12693] Check the persmissions of the owner
PHPBB3-12693
2014-07-31 14:20:38 +02:00
Tristan Darricau
30e13a429c [ticket/12693] Check if the are executable and not if they are 644
PHPBB3-12693
2014-07-31 14:20:37 +02:00
Tristan Darricau
f394f55fe2 [ticket/12693] Fix the permissions
PHPBB3-12693
2014-07-31 14:20:36 +02:00
Tristan Darricau
636eac2cd2 [ticket/12693] Check if the files have the right 644
And not only if they are executable.

PHPBB3-12693
2014-07-31 14:20:34 +02:00
Tristan Darricau
18207ae1ec [ticket/12693] Fix indentation
PHPBB3-12693
2014-07-31 14:20:33 +02:00
Tristan Darricau
a6f43d09d7 [ticket/12693] Add a travis test that checks file permissions
PHPBB3-12693
2014-07-31 14:20:32 +02:00
Joas Schilling
f4fc1bde03 Merge pull request #2767 from Nicofuma/ticket/12882
[ticket/12882] Update search_type when it's not prefixed by phpbb_search

* Nicofuma/ticket/12882:
  [ticket/12882] Use a new migration
  [ticket/12882] Update search_type when it's not prefixed by phpbb_search
2014-07-31 14:03:23 +02:00
Tristan Darricau
702d567c69 Merge branch 'ticket/11480' into ticket/11480-ascraeus
* ticket/11480:
  [ticket/11480] Move the test into get_folder()
  [ticket/11480] Fix the double spaces in phpbb_functional_test_case
  [ticket/11480] Fix typos
  [ticket/11480] Add functionnal test
  [ticket/11480] PM : "Unknown folder" returned when inbox folder is full

Conflicts:
	tests/test_framework/phpbb_functional_test_case.php
2014-07-30 21:01:05 +02:00
hanakin
913b363126 [ticket/12862] Resize popups consistently
PHPBB3-12862
2014-07-30 17:48:23 +02:00
Tristan Darricau
8bdfda723c [ticket/11480] Move the test into get_folder()
PHPBB3-11480
2014-07-30 15:28:02 +02:00
Joas Schilling
6d39a5b015 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12492] Add support of special chars
2014-07-30 15:01:16 +02:00
Joas Schilling
9a3af2a052 Merge pull request #2425 from Zoddo/ticket/12492
[ticket/12492] Add support of special chars

* Zoddo/ticket/12492:
  [ticket/12492] Add support of special chars
2014-07-30 15:00:32 +02:00
hanakin
d6c772f15c [ticket/12862] Add Border
PHPBB3-12862
2014-07-29 18:40:30 +02:00
Marc Alexander
98eeaacc36 [ticket/12895] Rename user style setting to resolve conflict with style param
The style URL parameter, i.e. style=1, will conflict with the user's style
setting due to it also being named style. This patch with solve this conflict.

PHPBB3-12895
2014-07-29 13:24:44 +02:00
Matt Friedman
ced76b5f4d [ticket/12841] Make config position default to after
PHPBB3-12841
2014-07-28 22:27:01 -05:00
Andreas Fischer
e992eab4c3 Merge pull request #2780 from Nicofuma/ticket/12870
[ticket/12870] phpbbcli.php db:migrate can not update from 3.0.12 to 3.1

* Nicofuma/ticket/12870:
  [ticket/12870] Add doc block
  [ticket/12870] Create the migrations table with a method in the migrator
  [ticket/12870] Add $config['version'] in phpbb_extension_manager_test
  [ticket/12870] Create the migrations table in db:migrate
2014-07-28 18:13:44 +02:00
Marc Alexander
d8867bb40d Merge remote-tracking branch 'nickvergessen/ticket/12891' into develop-ascraeus 2014-07-28 16:44:37 +02:00
Marc Alexander
63c938c703 Merge remote-tracking branch 'Nicofuma/ticket/12898' into develop-ascraeus 2014-07-28 16:32:27 +02:00
Tristan Darricau
ae350bda42 [ticket/12870] Add doc block
PHPBB3-12870
2014-07-28 15:17:19 +02:00
Tristan Darricau
f86bfeb3a1 [ticket/12898] Call garbage_collection() at the end of cron.php
PHPBB3-12898
2014-07-28 14:45:39 +02:00
Andreas Fischer
52e8a7231e Merge pull request #2772 from dhruvgoel92/ticket/12656
[ticket/12656] Translate existing CLI commands

* dhruvgoel92/ticket/12656:
  [ticket/12656] Fix typo for "purged extension"
  [ticket/12656] Fix syntax in language file
  [ticket/12656] Fix typo
  [ticket/12656] Use utf8 ’ instead of escaping '
  [ticket/12656] Use lang keys for all CLI strings
  [ticket/12656] Use lang keys for CLI command descriptions
2014-07-28 14:45:33 +02:00
Matt Friedman
6576e0eb88 [ticket/12841] Update comments in tests making after default
PHPBB3-12841
2014-07-27 23:03:43 -05:00
Matt Friedman
4ce6811d2b [ticket/12864] Update event docs
PHPBB3-12864
2014-07-27 22:55:36 -05:00
Joas Schilling
3df41920f7 Merge pull request #2718 from lucifer4o/ticket/12793
[ticket/12793] String '0' does not display for string profile fields

* lucifer4o/ticket/12793:
  [ticket/12793] Tests (added and changed)
  [ticket/12793] Changing get_profile_contact_value to get_profile_value_raw
  [ticket/12793] String '0' does not display for string profile fields
2014-07-27 20:11:44 +02:00
Joas Schilling
8a6d3f2b1d Merge pull request #2719 from lucifer4o/ticket/12791
[ticket/12791] String profile fields do not use links ...

* lucifer4o/ticket/12791:
  [ticket/12791] Changed the if check
  [ticket/12791] String profile fields do not use links ...
2014-07-27 20:06:53 +02:00
Joas Schilling
e94f24c821 Merge branch 'ticket/sumanai/12843' into develop-ascraeus
* ticket/sumanai/12843:
  [ticket/12843] Fix Mark forums read browser console error
2014-07-27 19:51:38 +02:00
Sumanai
ab8400a616 [ticket/12843] Fix Mark forums read browser console error
When you click on "Mark forums read" in the browser console error occurs
ReferenceError: assignment to undeclared variable phpbbAlertTimer
ajax.js (line13)

PHPBB3-12843
2014-07-27 19:50:48 +02:00
Joas Schilling
e226c99474 Merge pull request #2769 from rxu/ticket/12884
[ticket/12884] Add core event to the function upload_attachment()

* rxu/ticket/12884:
  [ticket/12884] Add core event to the function upload_attachment()
2014-07-27 19:45:07 +02:00
Joas Schilling
64f2d778cd Merge branch 'ticket/forumhulp/12896' into develop-ascraeus
* ticket/forumhulp/12896:
  [ticket/12896] Add php event for admin notices
2014-07-27 19:41:56 +02:00
Forumhulp.com
5dcf56c98d [ticket/12896] Add php event for admin notices
PHPBB3-12896
2014-07-27 19:35:07 +02:00
Dhruv
8a046743bc [ticket/12656] Fix typo for "purged extension"
PHPBB3-12656
2014-07-27 14:56:12 +05:30
Tristan Darricau
a8e81b6e9f [ticket/12870] Create the migrations table with a method in the migrator
PHPBB3-12870
2014-07-27 11:08:13 +02:00
Andreas Fischer
a775bb082c Merge pull request #2768 from Nicofuma/ticket/12883
[ticket/12883] Do not use basename() to get the search class in tidy_search

* Nicofuma/ticket/12883:
  [ticket/12883] Remove pointless comments
  [ticket/12883] Do not use basename() to get the search class in tidy_search
2014-07-26 22:52:08 +02:00
Andreas Fischer
155f709e36 Merge pull request #2777 from Nicofuma/ticket/12881
[ticket/12881] Debug error - Undefined index: mark_time

* Nicofuma/ticket/12881:
  [ticket/12881] Checks earlier if server-side topic marking is enabled
2014-07-26 22:50:06 +02:00
Tristan Darricau
e4a829071e [ticket/12870] Add $config['version'] in phpbb_extension_manager_test
PHPBB3-12870
2014-07-26 12:08:35 +02:00
Tristan Darricau
8b8e09f4d5 [ticket/12870] Create the migrations table in db:migrate
PHPBB3-12870
2014-07-26 11:50:28 +02:00
Tristan Darricau
9d6ff36c6c Merge pull request #2779 from nickvergessen/ticket/12892
[ticket/12892] Do not set S_NUM_ROWS when adding a row to a template loop

* nickvergessen/ticket/12892:
  [ticket/12892] Do not set S_NUM_ROWS when adding a row to a template loop
2014-07-25 18:34:21 +02:00
Joas Schilling
831e9116ab [ticket/12892] Do not set S_NUM_ROWS when adding a row to a template loop
We do not set S_NUM_ROWS while adding a row, to reduce the complexity
If we would set it on adding, each subsequent adding would cause
n modifications, resulting in a O(n!) complexity, rather then O(n)

PHPBB3-12892
2014-07-25 17:48:53 +02:00
Joas Schilling
75aef80104 [ticket/12891] Replace template loops with 1 loop to reduce generation time
PHPBB3-12891
2014-07-25 13:27:49 +02:00
Tristan Darricau
d9a62a7333 [ticket/12881] Checks earlier if server-side topic marking is enabled
PHPBB3-12881
2014-07-25 00:22:46 +02:00
Matt Friedman
056584680b [ticket/12841] prefix function name with phpbb_
PHPBB3-12841
2014-07-24 07:44:35 -07:00
Dhruv Goel
8064d2931f Merge pull request #2773 from bantu/ticket/12887
[ticket/12887] Fix Typo: offest -> offset
2014-07-24 19:02:07 +05:30
Dhruv
ed9fb450de [ticket/12656] Fix syntax in language file
PHPBB3-12656
2014-07-24 18:56:52 +05:30
Marc Alexander
3cd7078900 Merge remote-tracking branch 'paybas/ticket/12857' into develop-ascraeus 2014-07-24 11:00:43 +02:00
Dhruv
6531856108 [ticket/12656] Fix typo
PHPBB3-12656
2014-07-24 01:12:40 +05:30
Dhruv
91b0e75cc7 [ticket/12656] Use utf8 ’ instead of escaping '
PHPBB3-12656
2014-07-24 01:08:31 +05:30
PayBas
1bd5edacb6 [ticket/12857] Add header/footer distinction for subsilver2 events
PHPBB3-12857
2014-07-23 16:09:12 +02:00
PayBas
5507c503b4 [ticket/12857] Clarify events.md on difference between PS and SS2 breadcrumbs
PHPBB3-12857
2014-07-23 10:37:44 +02:00
brunoais
a0feced63e [ticket/12877] core.mcp_mcp_front_reports_listing_query_before
Adding core.mcp_mcp_front_reports_listing_query_before

PHPBB3-12877
2014-07-23 07:20:20 +01:00
Andreas Fischer
b5c847c2ef [ticket/12887] Fix Typo: offest -> offset
PHPBB3-12887
2014-07-23 01:27:42 +02:00
Andreas Fischer
9e1802396f Merge pull request #2733 from n-aleha/ticket/12851
[ticket/12851] Fix the Font colour button title

* n-aleha/ticket/12851:
  [ticket/12851] Fix the Font colour button title
2014-07-23 01:12:18 +02:00
Tristan Darricau
3bf04d7152 [ticket/12883] Remove pointless comments
PHPBB3-12883
2014-07-23 00:30:55 +02:00
Dhruv
c81438e1f8 [ticket/12656] Use lang keys for all CLI strings
PHPBB3-12656
2014-07-23 01:23:44 +05:30
Dhruv
4092b63be3 [ticket/12656] Use lang keys for CLI command descriptions
PHPBB3-12656
2014-07-23 00:35:09 +05:30
Dhruv Goel
4a6a54472c Merge pull request #2766 from marc1706/ticket/12560
[ticket/12560] Add methods to set upload and temp paths in plupload
2014-07-22 22:42:05 +05:30
rxu
9485f59c61 [ticket/12884] Add core event to the function upload_attachment()
Add core event to the function upload_attachment()
in functions_posting.php to provide ability for extensions
to perform additional actions on uploaded files, like resizing etc.

PHPBB3-12884
2014-07-23 00:31:15 +08:00
Joas Schilling
58d91d1d54 Merge pull request #2757 from rxu/ticket/12871
[ticket/12871] Add PHPBB_DISPLAY_LOAD_TIME const to config.php on installation

* rxu/ticket/12871:
  [ticket/12871] Add PHPBB_DISPLAY_LOAD_TIME const to config.php on installation
2014-07-21 22:40:02 +02:00
n-aleha
d16ce21926 [ticket/12851] Fix the Font colour button title
PHPBB3-12851
2014-07-21 23:36:58 +03:00
Tristan Darricau
38100cc7c0 Merge pull request #2745 from nickvergessen/ticket/12861
[ticket/12861] Add event to modify the post, poster and attachment data

* nickvergessen/ticket/12861:
  [ticket/12861] Add event to modify the post, poster and attachment data
2014-07-21 20:48:30 +02:00
Dhruv Goel
e11875527d Merge pull request #2752 from bantu/ticket/12656
[ticket/12656] Pass user object into all console commands for translation
2014-07-22 00:14:01 +05:30
Dhruv Goel
1c8357a1cb Merge pull request #2651 from nickvergessen/ticket/12448
[ticket/12448] Allow null as default value for columns
2014-07-22 00:08:07 +05:30
Dhruv
83e5a25c0a [ticket/12738] Update constructor docblock
PHPBB3-12738
2014-07-21 22:08:05 +05:30
Tristan Darricau
2fbf12456d [ticket/12882] Use a new migration
PHPBB3-12882
2014-07-21 17:53:01 +02:00
Tristan Darricau
7d7bf86728 [ticket/12883] Do not use basename() to get the search class in tidy_search
PHPBB3-12883
2014-07-21 17:42:37 +02:00
Tristan Darricau
db3bddf15c [ticket/12882] Update search_type when it's not prefixed by phpbb_search
PHPBB3-12882
2014-07-21 11:29:37 +02:00
Tristan Darricau
919aeb3879 [ticket/12873] Test the good identifier in \phpbb\db\tools
We need to rename the index key because with the default prefix (phpbb_)
this key has a length of 31. And because we don't accept the keys longer
than 30 characters we should ensure that by default no key is longer than
30 characters.

PHPBB3-12873
2014-07-20 23:15:34 +02:00
Marc Alexander
b94ce7b932 [ticket/12560] Add methods to set upload and temp paths in plupload
The paths will be reset to the default paths after an upload is complete.

PHPBB3-12560
2014-07-20 21:37:34 +02:00
Marc Alexander
449ffbe799 Merge remote-tracking branch 'tmbackoff/ticket/12872' into develop-ascraeus 2014-07-20 18:44:38 +02:00
brunoais
51feab9ed6 [ticket/12800] removed superfulous tab character
PHPBB3-12800
2014-07-20 10:05:50 +01:00
brunoais
49a1d845fe [ticket/12800] Missing $phpbb_dispatcher as a global
PHPBB3-12800
2014-07-20 09:24:26 +01:00
brunoais
acaa1fe59c [ticket/12801] missing $phpbb_dispatcher as a global
PHPBB3-12801
2014-07-20 09:19:23 +01:00
Tabitha Backoff
247c5a1808 [ticket/12872] Add poster_id to viewtopic_modify_post_row
Change "rc3" to "RC3".

PHPBB3-12872
2014-07-19 05:33:42 -04:00
Tabitha Backoff
f6ad9d5fd2 [ticket/12872] Add poster_id to viewtopic_modify_post_row
To allow extension authors to use the poster_id var.

PHPBB3-12872
2014-07-19 03:26:33 -04:00
rxu
7b91b66b87 [ticket/12871] Add PHPBB_DISPLAY_LOAD_TIME const to config.php on installation
To make it consistent with another config.php constants,
PHPBB_DISPLAY_LOAD_TIME is to be put in config.php during installation as well.

PHPBB3-12871
2014-07-19 14:09:22 +08:00
Andreas Fischer
d5f87e6053 Merge pull request #2755 from Elsensee/ticket/12748
[ticket/12748] Fix typo in terms of use

* Elsensee/ticket/12748:
  [ticket/12748] Fix typo in terms of use
2014-07-18 22:58:01 +02:00
Matt Friedman
20c50e55b1 [ticket/12864] Add template event to header after stylesheets
https://tracker.phpbb.com/browse/PHPBB3-12864

PHPBB3-12864
2014-07-18 10:13:19 -07:00
Andreas Fischer
65544066c2 Merge pull request #2751 from bantu/ticket/12663
[ticket/12663] Extract CLI language string into their own file

* bantu/ticket/12663:
  [ticket/12663] Have cli.php language file at top level; unrelated to ACP.
  [ticket/12663] Extract CLI language string into their own file
2014-07-18 00:57:53 +02:00
Andreas Fischer
1a66ad8483 Merge pull request #2735 from carlo94it/ticket/12814
[ticket/12814] Fix field type for LDAP email attribute

* carlo94it/ticket/12814:
  [ticket/12814] Replace email type with text type
2014-07-18 00:54:21 +02:00
Oliver Schramm
8a5ec8d9d1 [ticket/12748] Fix typo in terms of use
PHPBB3-12748
2014-07-18 00:28:24 +02:00
Oliver Schramm
bef207e9b7 [ticket/10729] Update *_delete_user when user being deleted
PHPBB3-10729
2014-07-18 00:19:21 +02:00
Oliver Schramm
1e0775a3da Merge branch 'ticket/10729' into ticket/10729-2
Conflicts:
	phpBB/includes/functions_user.php
2014-07-18 00:17:20 +02:00
Oliver Schramm
da6b378e64 [ticket/10729] Update message_edit_user when user being deleted
PHPBB3-10729
2014-07-18 00:11:51 +02:00
Andreas Fischer
07ce29c081 [ticket/12656] Pass user object into all console commands.
PHPBB3-12656
2014-07-17 20:37:24 +02:00
Andreas Fischer
e78a6046ca [ticket/12663] Have cli.php language file at top level; unrelated to ACP.
PHPBB3-12663
2014-07-17 16:54:42 +02:00
Carlo
f784510494 [ticket/12663] Extract CLI language string into their own file
PHPBB3-12663
2014-07-17 16:53:33 +02:00
Oliver Schramm
53f597b6d0 [ticket/10729] Update post_edit_user when user being deleted
PHPBB3-10729
2014-07-17 16:28:32 +02:00
Tristan Darricau
42477861a4 Merge pull request #2576 from carlo94it/ticket/12685
[ticket/12685] New CLI container for load extensions

* carlo94it/ticket/12685:
  [ticket/12685] Setup class loader for extensions only if not in safe mode
  [ticket/12685] Replace getParameterOption with hasParameterOption
  [ticket/12685] Do not dump container
  [ticket/12685] Override getDefaultInputDefinition()
  [ticket/12685] Removed unused USE statement
  [ticket/12685] Inject console.command_collection instead of the container
  [ticket/12685] Add a new line
  [ticket/12685] Container is dumped by default
  [ticket/12685] Removed spaces
  [ticket/12685] Add --safe-mode
  [ticket/12685] We need extensions enabled
  [ticket/12685] Add space after foreach
  [ticket/12685] Add console collection and fixing CLI
2014-07-17 16:03:55 +02:00
Joas Schilling
0d2a478076 Merge pull request #2747 from Elsensee/ticket/12860
[ticket/12860] Add template events to mcp_ban.html

* Elsensee/ticket/12860:
  [ticket/12860] Fix typo
  [ticket/12860] Add template events mcp_ban_unban
  [ticket/12860] Add template events mcp_ban_fields
2014-07-17 15:31:20 +02:00
Carlo
7f4d425006 [ticket/12685] Setup class loader for extensions only if not in safe mode
PHPBB3-12685
2014-07-17 00:05:33 +02:00
Oliver Schramm
b1df0cffb1 [ticket/12860] Fix typo
PHPBB3-12860
2014-07-17 00:00:02 +02:00
PayBas
2913b44080 [ticket/12857] Add missing template events breadcrumb_prepend
To insert links after site-home

PHPBB3-12857
2014-07-16 22:15:31 +02:00
PayBas
c7be452861 [ticket/12857] Add template events breadcrumbs_before/after
PHPBB3-12857
2014-07-16 22:15:30 +02:00
Joas Schilling
0332b68dbb Merge pull request #2739 from PayBas/ticket/12853
[WIP][ticket/12853] Change navbar ACP from skip- to last-responsive

* PayBas/ticket/12853:
  [ticket/12853] Change navbar ACP from skip- to last-responsive
2014-07-16 22:08:00 +02:00
PayBas
8d8e0aae68 [ticket/12838] Update RC2 to RC3
PHPBB3-12838
2014-07-16 22:05:28 +02:00
Joas Schilling
9fede3baf4 Merge pull request #2740 from PayBas/ticket/12845
[ticket/12845] Fix invalid ARIA role for breadcrumbs

* PayBas/ticket/12845:
  [ticket/12845] Remove invalid ARIA role for breadcrumbs
2014-07-16 21:57:15 +02:00
Joas Schilling
99b60a2f5e Merge pull request #2741 from PayBas/ticket/12837
[ticket/12837] Detect "viewing contact admin page" on viewonline

* PayBas/ticket/12837:
  [ticket/12837] Use else if instead of elseif
  [ticket/12837] Detect "viewing contact admin page" on viewonline
2014-07-16 21:54:14 +02:00
Joas Schilling
9a369a9e14 Merge pull request #2743 from PayBas/ticket/12859
[ticket/12859] Add template events ucp_pm_viewmessage_post_buttons

* PayBas/ticket/12859:
  [ticket/12859] Add template events ucp_pm_viewmessage_post_buttons
2014-07-16 21:51:28 +02:00
Oliver Schramm
42308091ef [ticket/12860] Add template events mcp_ban_unban
PHPBB3-12860
2014-07-16 20:00:05 +02:00
Oliver Schramm
876c1f4f00 [ticket/12860] Add template events mcp_ban_fields
PHPBB3-12860
2014-07-16 19:59:06 +02:00
Joas Schilling
ab4a77aa0f [ticket/12861] Add event to modify the post, poster and attachment data
PHPBB3-12861
2014-07-16 19:26:05 +02:00
PayBas
0ed971d129 [ticket/12859] Add template events ucp_pm_viewmessage_post_buttons
PHPBB3-12859
2014-07-16 18:04:54 +02:00
Joas Schilling
cd5fbd52c2 Merge pull request #2709 from rxu/ticket/12828
[ticket/12828] Add ucp_prefs.php common core event

* rxu/ticket/12828:
  [ticket/12828] Add ucp_prefs.php common core event
2014-07-16 16:15:30 +02:00
PayBas
a22549f247 [ticket/12837] Use else if instead of elseif
PHPBB3-12837
2014-07-16 11:19:28 +02:00
PayBas
09e5896cae [ticket/12837] Detect "viewing contact admin page" on viewonline
PHPBB3-12837
2014-07-16 10:39:40 +02:00
PayBas
1548b81cac [ticket/12845] Remove invalid ARIA role for breadcrumbs
PHPBB3-12845
2014-07-16 10:16:16 +02:00
PayBas
78315d824a [ticket/12853] Change navbar ACP from skip- to last-responsive
PHPBB3-12853
2014-07-16 09:49:06 +02:00
Andreas Fischer
496b34cd96 Merge pull request #2736 from Elsensee/ticket/12854
[ticket/12854] Don't show contact page link if board emails are disabled

* Elsensee/ticket/12854:
  [ticket/12854] Don't show contact page link if board emails are disabled
2014-07-15 23:19:52 +02:00
Andreas Fischer
389d8e844e Merge pull request #2737 from Elsensee/ticket/12855
[ticket/12855] Dump the container based on DEBUG_CONTAINER instead of DEBUG

* Elsensee/ticket/12855:
  [ticket/12855] Dump the container based on DEBUG_CONTAINER instead of DEBUG
2014-07-15 23:10:53 +02:00
Oliver Schramm
1ee7df57ae [ticket/12855] Dump the container based on DEBUG_CONTAINER instead of DEBUG
PHPBB3-12855
2014-07-15 22:58:28 +02:00
Oliver Schramm
021adcc14f [ticket/12854] Don't show contact page link if board emails are disabled
PHPBB3-12854
2014-07-15 22:19:56 +02:00
Carlo
81905158a1 [ticket/12814] Replace email type with text type
PHPBB3-12814
2014-07-15 19:36:35 +02:00
Carlo
a4972bb338 [ticket/12685] Replace getParameterOption with hasParameterOption
PHPBB3-12685
2014-07-15 19:21:41 +02:00
Carlo
d95d6720bc [ticket/12685] Do not dump container
PHPBB3-12685
2014-07-15 17:51:23 +02:00
Carlo
7cffedf5e3 [ticket/12685] Override getDefaultInputDefinition()
PHPBB3-12685
2014-07-15 16:07:52 +02:00
Carlo
3eafeeb88d [ticket/12685] Removed unused USE statement
PHPBB3-12685
2014-07-15 13:31:34 +02:00
Carlo
15136e4f8e [ticket/12685] Inject console.command_collection instead of the container
PHPBB3-12685
2014-07-15 11:36:51 +02:00
Carlo
a54f1275d0 [ticket/12685] Add a new line
PHPBB3-12685
2014-07-15 11:27:58 +02:00
Carlo
7e6215fb7f [ticket/12685] Container is dumped by default
PHPBB3-12685
2014-07-15 10:22:39 +02:00
Carlo
0f41a8fc31 [ticket/12685] Removed spaces
PHPBB3-12685
2014-07-15 10:21:23 +02:00
Carlo
2ec50c0ff1 [ticket/12685] Add --safe-mode
PHPBB3-12685
2014-07-15 00:38:07 +02:00
Andreas Fischer
fcf426ad5c Merge pull request #2728 from lucifer4o/ticket/12846
[ticket/12846] SQLite3 bug in profilefield_base_migration.php

* lucifer4o/ticket/12846:
  [ticket/12846] SQLite3 bug in profilefield_base_migration.php
2014-07-14 19:45:43 +02:00
Andreas Fischer
f6039562ea Merge pull request #2731 from callumacrae/ticket/12849-2
[ticket/12849] Fixed possible ReferenceError in core.js.

* callumacrae/ticket/12849-2:
  [ticket/12849] Fixed possible ReferenceError in core.js.
2014-07-14 19:27:27 +02:00
Callum Macrae
581391c21e [ticket/12849] Fixed possible ReferenceError in core.js.
PHPBB3-12849
2014-07-13 23:18:21 +01:00
Tristan Darricau
519e64205a [ticket/12847] Allow the extensions to say if they can be enabled
PHPBB3-12847
2014-07-13 18:09:34 +02:00
rxu
fe02caa8e0 [ticket/12828] Add ucp_prefs.php common core event
Add common core event at the bottom of the includes/ucp/ucp_prefs.php
to allow additional actions (like template variable assignments etc.)
before the page load.

PHPBB3-12828
2014-07-13 21:34:24 +08:00
Andreas Fischer
aadcbb765a Merge pull request #2727 from Nicofuma/ticket/12844
[ticket/12844] Don't clear $dbpasswd early in connection manager

* Nicofuma/ticket/12844:
  [ticket/12844] Don't clear $dbpasswd early in connection manager
2014-07-13 01:17:55 +02:00
Stanislav Atanasov
1043d1a27c [ticket/12846] SQLite3 bug in profilefield_base_migration.php
Using profilefield_base_migration.php to create a custom profile
field with SQlite3 DBMS returns warning:

[phpBB Debug] PHP Warning: in file [ROOT]/phpbb/db/driver/sqlite3.php
on line 218: SQLite3Result::fetchArray(): Unable to execute statement:
constraint failed

This is due passing filed_id and lang_id to the DB driver in
unspecified format. As they are always int we should cast them
in int to prevent the error message appearance.

PHPBB3-12846
2014-07-13 01:45:20 +03:00
Tristan Darricau
c4cd1c58c1 [ticket/12844] Don't clear $dbpasswd early in connection manager
PHPBB3-12844
2014-07-13 00:25:25 +02:00
Carlo
6082b5e3d3 [ticket/12685] We need extensions enabled
PHPBB3-12685
2014-07-12 17:48:53 +02:00
Joas Schilling
3e004d22cb Merge pull request #2725 from Nicofuma/ticket/12842
[ticket/12842] Out of memory issue in code sniffer call for extensions

* Nicofuma/ticket/12842:
  [ticket/12842] Skip parameters without exlicit type
2014-07-12 17:30:25 +02:00
Carlo
1125fb3cab [ticket/12685] Add space after foreach
PHPBB3-12685
2014-07-12 17:20:33 +02:00
Carlo
b95ab44028 [ticket/12685] Add console collection and fixing CLI
Added a commands service collection and removed CLI container

PHPBB3-12685
2014-07-12 17:19:43 +02:00
Tristan Darricau
57f7fdf989 [ticket/12842] Skip parameters without exlicit type
PHPBB3-12842
2014-07-12 16:55:14 +02:00
Matt Friedman
0d320186cf [ticket/12841] Add a tests for the new function
PHPBB3-12841
2014-07-11 14:33:45 -07:00
Matt Friedman
14979e6399 [ticket/12841] Fix white space issues reported by sniffer
PHPBB3-12841
2014-07-11 13:40:45 -07:00
PayBas
20a55bc8dd [ticket/12838] Update events.md to RC3
PHPBB3-12838
2014-07-11 20:07:32 +02:00
Matt Friedman
95032c31af [ticket/12841] Allow extensions to position new config vars
PHPBB3-12841
2014-07-11 10:18:46 -07:00
Joas Schilling
0d6fe20372 Merge branch 'prep-release-3.1.0-RC2' into develop-ascraeus
* prep-release-3.1.0-RC2:
  [prep-release-3.1.0-RC2] Update phpBB Version for RC3 development
  [prep-release-3.1.0-RC2] Add changelog for 3.1.0-RC2
  [prep-release-3.1.0-RC2] Prepare Changelog
  [prep-release-3.1.0-RC2] Add migration for 3.1.0-RC2
  [prep-release-3.1.0-RC2] Update version to 3.1.0-RC2
2014-07-11 17:23:53 +02:00
Joas Schilling
b5492a07da [prep-release-3.1.0-RC2] Update phpBB Version for RC3 development 2014-07-11 17:22:16 +02:00
Joas Schilling
4dc26274bf [prep-release-3.1.0-RC2] Add changelog for 3.1.0-RC2 2014-07-11 16:07:09 +02:00
Joas Schilling
166c3988ff [prep-release-3.1.0-RC2] Prepare Changelog 2014-07-11 16:05:38 +02:00
Joas Schilling
4449793b07 [prep-release-3.1.0-RC2] Add migration for 3.1.0-RC2 2014-07-11 16:04:27 +02:00
Joas Schilling
c0e0011b10 [prep-release-3.1.0-RC2] Update version to 3.1.0-RC2 2014-07-11 16:03:44 +02:00
Tristan Darricau
dd78b564e5 Merge pull request #2723 from nickvergessen/ticket/12839
[ticket/12839] Include update related templates and assets in the package

* nickvergessen/ticket/12839:
  [ticket/12839] Include update related templates and assets in the package
2014-07-11 15:53:37 +02:00
Andreas Fischer
35588c20bd Merge pull request #2713 from n-aleha/ticket/12768
[ticket/12768] 'NOTIFICATION_REPORT_CLOSED' entry has wrong indentation

* n-aleha/ticket/12768:
  [ticket/12768] More fixes in language files
  [ticket/12768] 'NOTIFICATION_REPORT_CLOSED' entry has wrong indentation
2014-07-11 12:11:14 +02:00
Andreas Fischer
1a1fb4a915 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12120] Remove imkingdavid from active authors

Conflicts:
	phpBB/docs/AUTHORS
2014-07-11 12:03:02 +02:00
Andreas Fischer
a58cc394bc Merge pull request #2716 from marc1706/ticket/12120
[ticket/12120] Remove imkingdavid from active authors

* marc1706/ticket/12120:
  [ticket/12120] Remove imkingdavid from active authors
2014-07-11 12:00:02 +02:00
Andreas Fischer
248b11c4db Merge pull request #2701 from Nicofuma/ticket/12818
[ticket/12818] Deleting a log entry in MCP produces a General error

* Nicofuma/ticket/12818:
  [ticket/12818] Use assertGreaterThanOrEqual in the tests
  [ticket/12818] Don't use the id for i=
  [ticket/12818] Add tests
  [ticket/12818] Fix the conditions in the call to $log->delete() in mcp_logs
2014-07-11 11:53:38 +02:00
Andreas Fischer
b2a883d504 Merge pull request #2671 from Nicofuma/ticket/12775
[ticket/12775] Replace functions_container with a container_builder class.

* Nicofuma/ticket/12775: (34 commits)
  [ticket/12775] Set dbal.conn.driver as synthetic during installation
  [ticket/12775] Add the definition of dbal.conn in fixtures/config/services.yml
  [ticket/12775] Inject the connection when created in the container
  [ticket/12775] Extract the vars later in install/install_update.php
  [ticket/12775] Rename config_php_handler to config_php_file container_builder
  [ticket/12775] Set defined_vars as a property of config_php_file
  [ticket/12775] Fix doc blocks in the container builder
  [ticket/12775] Remove useless includes of config.php
  [ticket/12775] Move phpbb_convert_30_dbms_to_31 into the config file class
  [ticket/12775] Fix comments
  [ticket/12775] Update doc blocks
  [ticket/12775] Fix container_builder
  [ticket/12775] Rename config_php to config_php_file
  [ticket/12775] Renamed to \phpbb\di\container_builder
  [ticket/12775] Remove the last include of functions_container
  [ticket/12775] Fix unit tests
  [ticket/12775] Add tests for \phpbb\config_php
  [ticket/12775] Add tests for the container factory
  [ticket/12775] Use a field instead of a local var in load_config_var()
  [ticket/12775] Update container and config in install/
  ...
2014-07-11 11:49:51 +02:00
Andreas Fischer
147b942e5c Merge pull request #2711 from n-aleha/ticket/12829
[ticket/12829] Remove check for pgsql 8.3/8.2

* n-aleha/ticket/12829:
  [ticket/12829] Remove check for pgsql 8.3/8.2
2014-07-11 10:17:03 +02:00
Joas Schilling
9f76b3414c [ticket/12839] Include update related templates and assets in the package
PHPBB3-12839
2014-07-11 09:48:49 +02:00
PayBas
08264ec3af [ticket/12838] Allow for extra columns in cache obtain_ranks()
PHPBB3-12838
2014-07-10 17:54:08 +02:00
PayBas
c9803b7ba3 [ticket/12838] Add raw row-data to acp_ranks core event
PHPBB3-12838
2014-07-10 16:24:49 +02:00
PayBas
0bece6dada [ticket/12838] Simplify special rank template conditional
PHPBB3-12838
2014-07-10 16:24:17 +02:00
Tristan Darricau
cc0f931473 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12695] Add viewtopic language file for parse_attachments in mcp_post
2014-07-10 15:26:27 +02:00
Tristan Darricau
3a11fec5de Merge pull request #2722 from marc1706/ticket/12695
[ticket/12695] Add viewtopic language file for parse_attachments in mcp_...

* marc1706/ticket/12695:
  [ticket/12695] Add viewtopic language file for parse_attachments in mcp_post
2014-07-10 15:25:00 +02:00
Marc Alexander
83f4bd9ee7 [ticket/12695] Add viewtopic language file for parse_attachments in mcp_post
PHPBB3-12695
2014-07-10 14:39:53 +02:00
PayBas
9468d173bc [ticket/12838] Add core events to acp_ranks.php
PHPBB3-12838
2014-07-10 13:29:07 +02:00
PayBas
bfdaefa7f6 [ticket/12838] Update events.md
PHPBB3-12838
2014-07-10 12:16:50 +02:00
PayBas
1f61f3a416 [ticket/12838] Add _before versions
PHPBB3-12838
2014-07-10 12:10:06 +02:00
PayBas
dbb331284e [ticket/12838] Add template events to acp_ranks.html
PHPBB3-12838
2014-07-10 12:07:51 +02:00
Stanislav Atanasov
902937ce70 [ticket/12793] Tests (added and changed)
changed behavieur of 0 as in and added 0 as string test

PHPBB3-12793
2014-07-10 11:53:10 +03:00
Stanislav Atanasov
223c634bee [ticket/12793] Changing get_profile_contact_value to get_profile_value_raw
Changing the return to get_profile_value_raw

PHPBB3-12793
2014-07-10 11:46:11 +03:00
Stanislav Atanasov
57bbb4548b [ticket/12793] String '0' does not display for string profile fields
See https://github.com/phpbb/phpbb/pull/2647#discussion_r14503051

PHPBB3-12793
2014-07-10 11:46:00 +03:00
Stanislav Atanasov
27f15c0d5b [ticket/12791] Changed the if check
Removed unneeded variable

PHPBB3-12791
2014-07-10 11:43:52 +03:00
Stanislav Atanasov
690de21134 [ticket/12791] String profile fields do not use links ...
smilies and line breaks in memberlist

The value is overwritten with the contact value
Added aditional check if the field is a contact so we don't overwrite it.

PHPBB3-12791
2014-07-10 11:42:31 +03:00
Joas Schilling
d5fd1ecfc8 Merge pull request #2675 from lucifer4o/ticket/12786
[ticket/12786] Extend profilefield_base_migration.php class

* lucifer4o/ticket/12786:
  [ticket/12786] Correcting some tabs
  [ticket/12786] Array_merge instead copy array parts
  [ticket/12786] Some changes of the comments.
  [ticket/12786] Dixing a typo
  [ticket/12786] Some minor fixes of comments and function naming
  [ticket/12786] Add clean_cpf_db_entries
  [ticket/12786] White spaces found
  [ticket/12786] Add create_language_entries
  [ticket/12786] Add get_custom_field_id
  [ticket/12786] Extend profilefield_base_migration.php class
2014-07-09 17:00:43 +02:00
Tristan Darricau
8de8cbab5e [ticket/12818] Use assertGreaterThanOrEqual in the tests
PHPBB3-12818
2014-07-09 00:12:57 +02:00
Marc Alexander
e68094679e [ticket/12120] Remove imkingdavid from active authors
PHPBB3-12120
2014-07-08 21:20:51 +02:00
Stanislav Atanasov
c468a5d8d4 [ticket/12786] Correcting some tabs
Some tabs needed corection

PHPBB3-12786
2014-07-08 22:01:49 +03:00
PayBas
16a13fed1a [ticket/12832] Remove old .quick-links icon reference
PHPBB3-12832
2014-07-08 19:05:06 +02:00
Marc Alexander
b132939471 Merge remote-tracking branch 'nickvergessen/ticket/12834' into develop-ascraeus 2014-07-08 18:48:32 +02:00
Joas Schilling
91f5d59f69 Merge pull request #2676 from Nicofuma/ticket/12787
[ticket/12787] Allow the route to say that the referer has to be used.

* Nicofuma/ticket/12787:
  [ticket/12787] Updates phpbb_mock_controller_helper
  [ticket/12787] Add controller_helper::get_current_url()
  [ticket/12787] Remove one app.php when it's both in $path and $web_root_path
  [ticket/12787] Fix the absolute board url
  [ticket/12787] Use a parameter (_referer) instead of the Referer header
  [ticket/12099] Add unit tests for get_web_root_path_from_ajax_referer()
  [ticket/12099] Remove config again
  [ticket/12099] Correctly fix the path when performing AJAX requests
  [ticket/12099] Add request argument to path_helper service
2014-07-08 18:09:41 +02:00
Joas Schilling
e3e236da72 [ticket/12834] Correctly match directories in session page
Also clean path before working with it

PHPBB3-12834
2014-07-08 17:53:32 +02:00
Joas Schilling
633a517791 [ticket/12834] Fix tests to match what we want to have
PHPBB3-12834
2014-07-08 17:53:06 +02:00
Marc Alexander
dca8afcd6f Merge remote-tracking branch 'paybas/ticket/12804' into develop-ascraeus 2014-07-08 15:59:23 +02:00
PayBas
44e76495a9 [ticket/12832] Remove unnecessary attr and classes
PHPBB3-12832
2014-07-08 15:53:03 +02:00
n-aleha
f2745d1e57 [ticket/12768] More fixes in language files
More spaces converted to tabs for identation in language files.

PHPBB3-12768
2014-07-08 02:09:10 +03:00
Tristan Darricau
b170c6a8db Merge pull request #2695 from VSEphpbb/ticket/12812
[ticket/12812] Add a migrator tool for config_text database changes

* VSEphpbb/ticket/12812:
  [ticket/12812] Remove unused global $db from tests
  [ticket/12812] Improve migrator config_text tool tests
  [ticket/12812] Improve migrator config_text tool tests
  [ticket/12812] Add a migrator tool for config_text database changes
2014-07-08 00:52:51 +02:00
PayBas
bdfca39e07 [ticket/12804] Disable jabber from memberlist sort options
PHPBB3-12804
2014-07-08 00:42:01 +02:00
Tristan Darricau
b4d7192b62 [ticket/12787] Updates phpbb_mock_controller_helper
PHPBB3-12787
2014-07-08 00:20:33 +02:00
n-aleha
4679fa543b [ticket/12768] 'NOTIFICATION_REPORT_CLOSED' entry has wrong indentation
'NOTIFICATION_REPORT_CLOSED' has 3 spaces before the first tab indentation
in language/en/common.php.

PHPBB3-12768
2014-07-08 01:13:59 +03:00
Tristan Darricau
9374d14e27 [ticket/12787] Add controller_helper::get_current_url()
PHPBB3-12787
2014-07-08 00:04:11 +02:00
PayBas
3f290bad82 [ticket/12832] Add footer links to quick-links
PHPBB3-12832
2014-07-07 23:27:58 +02:00
PayBas
e4941ee875 [ticket/12832] Make .small-icon styling uniform
PHPBB3-12832
2014-07-07 23:23:15 +02:00
Tristan Darricau
de1da3170c [ticket/12818] Don't use the id for i=
PHPBB3-12818
2014-07-07 22:13:42 +02:00
n-aleha
b08497f66c [ticket/12829] Remove check for pgsql 8.3/8.2
Remove check for pgsql 8.3/8.2 and set multi_insert to true.

PHPBB3-12829
2014-07-07 23:10:18 +03:00
Tristan Darricau
42fde81b21 Merge pull request #2690 from Noxwizard/ticket/12802
[ticket/12802] Properly handle connection failures in SQLite3

* Noxwizard/ticket/12802:
  [ticket/12802] Properly handle connection failures in SQLite3
2014-07-07 21:56:35 +02:00
Matt Friedman
5ef7510fb3 [ticket/12812] Remove unused global $db from tests
PHPBB3-12812
2014-07-07 12:50:18 -07:00
Tristan Darricau
14e9c7695d [ticket/12818] Add tests
PHPBB3-12818
2014-07-07 21:49:48 +02:00
Joas Schilling
80f8c550f9 Merge pull request #2706 from Nicofuma/ticket/12825
[ticket/12825] Better sniff for the extensions and skip the vendor/ directory

* Nicofuma/ticket/12825:
  [ticket/12825] Better sniff for the extensions and skip the vendor/ directory
2014-07-07 21:05:23 +02:00
Joas Schilling
4c1a9d1e5d Merge pull request #2705 from PayBas/ticket/12824
[ticket/12824] Move MCP/ACP links after navigation_append event

* PayBas/ticket/12824:
  [ticket/12824] Move MCP/ACP links after navigation_append event
2014-07-07 20:46:35 +02:00
Joas Schilling
e8e9ad1bdf Merge pull request #2708 from PayBas/ticket/12827
[ticket/12827] Reorder quick-links

* PayBas/ticket/12827:
  [ticket/12827] Reorder quick-links
2014-07-07 20:38:54 +02:00
Joas Schilling
f340e54e0c Merge pull request #2710 from Crizz0/ticket/12830
[ticket/12830] Removes double .postlink in colours.css

* Crizz0/ticket/12830:
  [ticket/12830] Remove double .postlink in colours.css
2014-07-07 20:33:35 +02:00
Joas Schilling
29a07404d3 Merge pull request #2672 from Nicofuma/ticket/12782
[ticket/12782] Use an interface for the phpbb event_dispatcher

* Nicofuma/ticket/12782:
  [ticket/12782] Add doc block
  [ticket/12782] Use an interface for the phpbb event_dispatcher
2014-07-07 20:23:10 +02:00
Tristan Darricau
b9750bb590 Merge pull request #2656 from nickvergessen/ticket/12197
[ticket/12197] Fix several misleading FAQ entries

* nickvergessen/ticket/12197:
  [ticket/12197] Fix several misleading FAQ entries
2014-07-07 19:00:33 +02:00
Crizzo
22448a9c6d [ticket/12830] Remove double .postlink in colours.css
PHPBB3-12830
2014-07-07 18:25:04 +02:00
PayBas
6759004642 [ticket/12827] Reorder quick-links
PHPBB3-12827
2014-07-07 12:05:46 +02:00
PayBas
0a286e044b [ticket/12804] Dont use ternary form
PHPBB3-12804
2014-07-07 11:28:06 +02:00
PayBas
fbc07d3b14 [ticket/12804] Hide jabber for subSilver2 as well
PHPBB3-12804
2014-07-07 11:21:48 +02:00
Cesar G
3a317edc92 Merge remote-tracking branch 'VSEphpbb/ticket/12811' into develop-ascraeus
* VSEphpbb/ticket/12811:
  [ticket/12811] Responsive adjustments to margin changes
  [ticket/12811] Fix padding/margin bug affecting bottom layout
2014-07-07 01:33:34 -07:00
Cesar G
0b91c5488a Merge remote-tracking branch 'PayBas/ticket/12813' into develop-ascraeus
* PayBas/ticket/12813:
  [ticket/12813] Move inline-CSS to css file
  [ticket/12813] Use -moz-only fix instead of generic padding
  [ticket/12813] Reorder .row pagination so it aligns better
  [ticket/12813] Fix page-jump title lang and use input type=number
2014-07-07 01:32:18 -07:00
PayBas
c5b4d0afb7 [ticket/12804] Hide Jabber from UCP & member search when disabled
PHPBB3-12804
2014-07-07 09:05:57 +02:00
Tristan Darricau
58a52fe5b9 [ticket/12775] Set dbal.conn.driver as synthetic during installation
PHPBB3-12775
2014-07-07 01:10:24 +02:00
Tristan Darricau
e2cbaf4f1a [ticket/12775] Add the definition of dbal.conn in fixtures/config/services.yml
PHPBB3-12775
2014-07-07 01:02:50 +02:00
Tristan Darricau
5b11ee8c97 [ticket/12775] Inject the connection when created in the container
PHPBB3-12775
2014-07-07 01:02:49 +02:00
Tristan Darricau
285656a6d4 [ticket/12775] Extract the vars later in install/install_update.php
PHPBB3-12775
2014-07-07 01:02:47 +02:00
Tristan Darricau
6c57fbecac [ticket/12775] Rename config_php_handler to config_php_file container_builder
PHPBB3-12775
2014-07-07 01:02:46 +02:00
Tristan Darricau
8c0d179e3e [ticket/12775] Set defined_vars as a property of config_php_file
PHPBB3-12775
2014-07-07 01:02:44 +02:00
Tristan Darricau
35c0b6d77a [ticket/12775] Fix doc blocks in the container builder
PHPBB3-12775
2014-07-07 01:02:43 +02:00
Tristan Darricau
d226a73111 [ticket/12775] Remove useless includes of config.php
PHPBB3-12775
2014-07-07 01:02:42 +02:00
Tristan Darricau
ed812a9dfb [ticket/12775] Move phpbb_convert_30_dbms_to_31 into the config file class
PHPBB3-12775
2014-07-07 01:02:40 +02:00
Tristan Darricau
98e8be966b [ticket/12775] Fix comments
PHPBB3-12775
2014-07-07 01:02:39 +02:00
Tristan Darricau
15c23e60b8 [ticket/12775] Update doc blocks
PHPBB3-12775
2014-07-07 01:02:37 +02:00
Tristan Darricau
f2e8e928c0 [ticket/12775] Fix container_builder
PHPBB3-12775
2014-07-07 01:02:36 +02:00
Tristan Darricau
2db160ff87 [ticket/12775] Rename config_php to config_php_file
PHPBB3-12775
2014-07-07 01:02:34 +02:00
Tristan Darricau
40937e21c5 [ticket/12775] Renamed to \phpbb\di\container_builder
PHPBB3-12775
2014-07-07 01:02:33 +02:00
Tristan Darricau
11ff91c87d [ticket/12775] Remove the last include of functions_container
PHPBB3-12775
2014-07-07 01:02:31 +02:00
Tristan Darricau
926e47e5a1 [ticket/12775] Fix unit tests
PHPBB3-12775
2014-07-07 01:02:30 +02:00
Tristan Darricau
afffec8184 [ticket/12775] Add tests for \phpbb\config_php
PHPBB3-12775
2014-07-07 01:02:29 +02:00
Tristan Darricau
1d966fbc86 [ticket/12775] Add tests for the container factory
PHPBB3-12775
2014-07-07 01:02:27 +02:00
Tristan Darricau
c87f44c669 [ticket/12775] Use a field instead of a local var in load_config_var()
PHPBB3-12775
2014-07-07 01:02:26 +02:00
Tristan Darricau
91ca12f20e [ticket/12775] Update container and config in install/
PHPBB3-12775
2014-07-07 01:02:24 +02:00
Tristan Darricau
cefffe0777 [ticket/12775] Load the config file before constants.php
PHPBB3-12775
2014-07-07 01:02:23 +02:00
Tristan Darricau
20912d7af2 [ticket/12775] Skip the tests related to the container
PHPBB3-12775
2014-07-07 01:02:21 +02:00
Tristan Darricau
ef1346c931 [ticket/12775] Update phpBB/install/index.php
PHPBB3-12775
2014-07-07 01:02:20 +02:00
Tristan Darricau
e7804ecce4 [ticket/12775] Update phpBB/install/database_update.php
PHPBB3-12775
2014-07-07 01:02:19 +02:00
Tristan Darricau
f87e76b910 [ticket/12775] Update phpBB/download/file.php
PHPBB3-12775
2014-07-07 01:02:17 +02:00
Tristan Darricau
78648514fa [ticket/12775] Update phpBB/bin/phpbbcli.php
PHPBB3-12775
2014-07-07 01:02:16 +02:00
Tristan Darricau
98890fe1a3 [ticket/12775] Fix config_php::load_config_file()
PHPBB3-12775
2014-07-07 01:02:14 +02:00
Tristan Darricau
4f56f9b904 [ticket/12775] Rename the variables into common.php
PHPBB3-12775
2014-07-07 01:02:13 +02:00
Tristan Darricau
01c25d3d6b [ticket/12775] Use the config.php handler in \phpbb\config_php
PHPBB3-12775
2014-07-07 01:02:12 +02:00
Tristan Darricau
b9995405cf [ticket/12775] Add get() and get_all() into config_php
PHPBB3-12775
2014-07-07 01:02:10 +02:00
Tristan Darricau
301d9ce990 [ticket/12775] Add a config.php class (and service)
PHPBB3-12775
2014-07-07 01:02:09 +02:00
Tristan Darricau
cbe846a64e [ticket/12775] Don't assign $container to null
PHPBB3-12775
2014-07-07 01:02:07 +02:00
Tristan Darricau
86205454af [ticket/12775] Add customs parameters
PHPBB3-12775
2014-07-07 01:02:06 +02:00
Tristan Darricau
cdf87e0078 [ticket/12775] Add a conter_factory class and remove functions_container
PHPBB3-12775
2014-07-07 01:02:04 +02:00
Andreas Fischer
0bec9897d7 Merge pull request #2697 from n-aleha/ticket/12816
[ticket/12816] Fix comment about logs in user_ban function

* n-aleha/ticket/12816:
  [ticket/12816] Fix comment about logs in user_ban function
2014-07-07 00:20:27 +02:00
Andreas Fischer
bd0f692bf3 Merge pull request #2679 from dhruvgoel92/ticket/12788
[ticket/12788] Update symfony components

* dhruvgoel92/ticket/12788:
  [ticket/12788] Force 2.3.* on symfony dependencies
  [ticket/12788] Update symfony components
2014-07-07 00:02:11 +02:00
Andreas Fischer
730991e785 Merge pull request #2704 from hanakin/ticket/12823
[ticket/12823] Remove all trailing whitespace

* hanakin/ticket/12823:
  [ticket/12823] Remove all trailing whitespace
2014-07-06 23:46:24 +02:00
Tristan Darricau
a2af95cb37 [ticket/12825] Better sniff for the extensions and skip the vendor/ directory
PHPBB3-12825
2014-07-06 23:34:17 +02:00
brunoais
4629ebfc4f [ticket/12801] Add core.functions_posting.load_drafts_draft_list_results
Adding event core.functions_posting.load_drafts_draft_list_results

PHPBB3-12801
2014-07-06 20:10:44 +01:00
Tristan Darricau
f8eca98b3f Merge pull request #2654 from nickvergessen/ticket/12515
[ticket/12515] Remove check for PostgreSQL 8.3+ in search

* nickvergessen/ticket/12515:
  [ticket/12515] Remove check for PostgreSQL 8.3+
2014-07-06 20:05:38 +02:00
Joas Schilling
e3e0c79b7a [ticket/12515] Remove check for PostgreSQL 8.3+
PHPBB3-12515
2014-07-06 19:31:46 +02:00
PayBas
39261907da [ticket/12824] Move MCP/ACP links after navigation_append event
PHPBB3-12824
2014-07-06 18:55:01 +02:00
Tristan Darricau
5dd19c726e Merge pull request #2699 from marc1706/ticket/12810
[ticket/12810] Use correct template vars for shadow pruning settings

* marc1706/ticket/12810:
  [ticket/12810] Use correct template vars for shadow pruning settings
2014-07-06 18:16:42 +02:00
Marc Alexander
18054332e4 [ticket/12810] Use correct template vars for shadow pruning settings
PHPBB3-12810
2014-07-06 18:03:09 +02:00
Marc Alexander
57567d5611 Merge remote-tracking branch 'Crizzo/ticket/12807' into develop-ascraeus 2014-07-06 17:59:05 +02:00
Matt Friedman
5527044a00 [ticket/12812] Improve migrator config_text tool tests
PHPBB3-12812
2014-07-06 08:13:20 -07:00
hanakin
5136be4225 [ticket/12823] Remove all trailing whitespace
PHPBB3-12823
2014-07-06 17:09:21 +02:00
Cesar G
b412339cad Merge remote-tracking branch 'PayBas/ticket/12808' into develop-ascraeus
* PayBas/ticket/12808:
  [ticket/12808] Fix small gap between username and drop-down arrow
2014-07-06 06:14:56 -07:00
Cesar G
1504ec4ba3 Merge remote-tracking branch 'PayBas/ticket/12815' into develop-ascraeus
* PayBas/ticket/12815:
  [ticket/12815] Remove S_REGISTERED_USER for team link
  [ticket/12815] Show memberlist link for guests (if permitted)
2014-07-06 06:04:08 -07:00
PayBas
21320820ce [ticket/12815] Remove S_REGISTERED_USER for team link
PHPBB3-12815
2014-07-06 14:53:23 +02:00
PayBas
c190ee315e [ticket/12815] Show memberlist link for guests (if permitted)
PHPBB3-12815
2014-07-06 13:40:36 +02:00
PayBas
b323a01fd3 [ticket/12813] Move inline-CSS to css file
PHPBB3-12813
2014-07-06 13:02:26 +02:00
PayBas
8d6d21c7de [ticket/12813] Use -moz-only fix instead of generic padding
PHPBB3-12813
2014-07-06 13:01:57 +02:00
Crizzo
addcbb1585 [ticket/12807] New variables for _EXPLAIN
PHPBB3-12807
2014-07-06 00:28:25 +02:00
Tristan Darricau
b7fb2e557e [ticket/12818] Fix the conditions in the call to $log->delete() in mcp_logs
PHPBB3-12818
2014-07-06 00:00:58 +02:00
Crizzo
dbefb74abe [ticket/12807] Adds missing language variables language/en/acp/forums.php
PHPBB3-12807
2014-07-05 23:57:57 +02:00
Crizzo
b6816c4237 [ticket/12807] Changes PRUNE_FREQ to PRUNE_SHADOW_FREQ/_DAYS
PHPBB3-12807
2014-07-05 22:18:01 +02:00
n-aleha
182d22567d [ticket/12816] Fix comment about logs in user_ban function
PHPBB3-12816
2014-07-05 23:00:13 +03:00
Matt Friedman
9dfce860e7 [ticket/12812] Improve migrator config_text tool tests
PHPBB3-12812
2014-07-05 08:26:01 -07:00
Tristan Darricau
7399f29df8 [ticket/12787] Remove one app.php when it's both in $path and $web_root_path
PHPBB3-12787
2014-07-05 14:01:14 +02:00
PayBas
ba207cd3b5 [ticket/12813] Reorder .row pagination so it aligns better
PHPBB3-12813
2014-07-05 12:40:20 +02:00
PayBas
2d2525f382 [ticket/12813] Fix page-jump title lang and use input type=number
PHPBB3-12813
2014-07-05 11:08:15 +02:00
Matt Friedman
606d82f7dd [ticket/12812] Add a migrator tool for config_text database changes
PHPBB3-12812
2014-07-05 00:57:34 -07:00
Nils Adermann
53ff23671c Merge remote-tracking branch 'github-nicofuma/ticket/12446' into develop-ascraeus
* github-nicofuma/ticket/12446:
  [ticket/12446] Unnecessary db connect inphpbb_bootstrap_enabled_exts
2014-07-04 21:08:20 +02:00
Matt Friedman
3c223c2978 [ticket/12811] Responsive adjustments to margin changes
PHPBB3-12811
2014-07-04 10:36:33 -07:00
Matt Friedman
8643ca6303 [ticket/12811] Fix padding/margin bug affecting bottom layout
PHPBB3-12811
2014-07-04 10:26:17 -07:00
PayBas
e01e7b1529 [ticket/12808] Fix small gap between username and drop-down arrow
PHPBB3-12808
2014-07-04 15:45:11 +02:00
Stanislav Atanasov
4cec5bcd55 [ticket/12786] Array_merge instead copy array parts
nickvergessen proposed this

PHPBB3-12786
2014-07-04 14:49:23 +03:00
Joas Schilling
86e21a9b26 Merge pull request #1864 from prototech/ticket/12013
[ticket/12013] Use new dropdown for quickmod tools and jumpbox.

* prototech/ticket/12013:
  [ticket/12013] Fix functional tests and sniffer issue.
  [ticket/12013] Clear the jumpbox.
  [ticket/12013] Add moderator tools icon.
  [ticket/12013] Remove obsolete jumpbox and quickmod CSS.
  [ticket/12013] Prevent the dropdown scrollbar from overlapping the content.
  [ticket/12013] Update to use the new .button class.
  [ticket/12013] Add missing class to place the buttons on the rightside.
  [ticket/12013] Use the correct variable for the forum id.
  [ticket/12013] Use DEFINE instead of Twig's set.
  [ticket/12013] Use path helper.
  [ticket/12013] Use new dropdown for quickmod tools and jumpbox.
2014-07-04 13:32:03 +02:00
Cesar G
d95c97c3b4 [ticket/12013] Fix functional tests and sniffer issue.
PHPBB3-12013
2014-07-04 01:22:32 -07:00
Cesar G
ddf3ab323b [ticket/12013] Clear the jumpbox.
PHPBB3-12013
2014-07-04 00:56:28 -07:00
Cesar G
e7b9013dba [ticket/12013] Add moderator tools icon.
PHPBB3-12013
2014-07-04 00:56:28 -07:00
Cesar G
76cd9ec953 [ticket/12013] Remove obsolete jumpbox and quickmod CSS.
PHPBB3-12013
2014-07-04 00:56:27 -07:00
Cesar G
45458b240b [ticket/12013] Prevent the dropdown scrollbar from overlapping the content.
PHPBB3-12013
2014-07-04 00:56:27 -07:00
Cesar G
3bfc9ccbc7 [ticket/12013] Update to use the new .button class.
PHPBB3-12013
2014-07-04 00:56:04 -07:00
Cesar G
bf5d3030b4 [ticket/12013] Add missing class to place the buttons on the rightside.
PHPBB3-12013
2014-07-04 00:56:04 -07:00
Cesar G
e1513a985b [ticket/12013] Use the correct variable for the forum id.
PHPBB3-12013
2014-07-04 00:56:04 -07:00
Cesar G
35fab0fc72 [ticket/12013] Use DEFINE instead of Twig's set.
PHPBB3-12013
2014-07-04 00:56:03 -07:00
Cesar G
2ff8302c51 [ticket/12013] Use path helper.
PHPBB3-12013
2014-07-04 00:56:03 -07:00
Cesar G
90a8c7e29a [ticket/12013] Use new dropdown for quickmod tools and jumpbox.
PHPBB3-12013
2014-07-04 00:56:03 -07:00
Cesar G
c1627ef52e Merge remote-tracking branch 'hanakin/ticket/12735' into develop-ascraeus
* hanakin/ticket/12735:
  [ticket/12735] Remove unnecessary span
  [ticket/12735] Fix line breaks
  [ticket/12732] Undo search-box change
  [ticket/12735] Fix some color incosistencies
  [ticket/12735] Remove underlines by default
  [ticket/12735] Undo selector rename
  [ticket/12735] Remove all :link, :visited, :active states
2014-07-03 23:03:39 -07:00
Cesar G
5878314671 Merge remote-tracking branch 'PayBas/ticket/12662' into develop-ascraeus
* PayBas/ticket/12662: (29 commits)
  [ticket/12662] Hide quick-links when empty
  [ticket/12662] Fix white-space issue to make dropdowns uniform
  [ticket/12662] Remove last remaining linklist outside navbars
  [ticket/12662] Use data-last-responsive attr instead of hardcoded list
  [ticket/12662] Remove <li> container from logged_out_content event
  [ticket/12662] Username <span> fix for list columns
  [ticket/12662] Fix notifications dropdown positioning for RTL
  [ticket/12662] Update tests that utilize get_username_string
  [ticket/12662] Update subsilver2 index template event names
  [ticket/12662] Update events docs from b5 to rc1/rc2
  [ticket/12662] Move dropdown container from <li> to new inner div
  [ticket/12662] Remove linklist container and update template events
  [ticket/12662] Add span containers to all usernames for consistency
  [ticket/12662] IE8 fixes
  [ticket/12662] Fix responsive positioning of notifications dropdown
  [ticket/12662] Remove inherited props from ddown-extendended
  [ticket/12662] Change CSS selectors to direct descendants for linklist
  [ticket/12662] Reorder icon CSS rules alphabetically
  [ticket/12662] Use slack variable to determine line-break sensitivity
  [ticket/12662] Change new event names and fix events.md
  ...
2014-07-03 23:02:11 -07:00
Patrick Webster
3ca708edad [ticket/12802] Properly handle connection failures in SQLite3
PHPBB3-12802
2014-07-03 13:05:54 -05:00
Stanislav Atanasov
c9da9ec858 [ticket/12786] Some changes of the comments.
Comments and quotes

PHPBB3-12786

[ticket/12786]

PHPBB3-12786

Revert "[ticket/12786]"

This reverts commit 61a6647101731110f67689b109de953f7449b03e.
2014-07-03 20:18:51 +03:00
Dhruv
b4e8e9e29f [ticket/12788] Force 2.3.* on symfony dependencies
PHPBB3-12788
2014-07-03 20:50:06 +05:30
brunoais
4127acb19b [ticket/12800] core.functions_display.display_user_activity.actives_after
Adding core.functions_display.display_user_activity.actives_after

PHPBB3-12800
2014-07-03 15:35:52 +01:00
brunoais
e7f124b8ce [ticket/12801] Add topic_poster to load_drafts' topics query
PHPBB3-12801
2014-07-03 15:11:19 +01:00
Nils Adermann
0deacb8438 Merge branch 'ticket/12562' of https://github.com/PayBas/phpbb into develop-ascraeus
* 'ticket/12562' of https://github.com/PayBas/phpbb:
  [ticket/12562] Use border for all sizes except responsive
  [ticket/12562] Use Hanakin's version
  [ticket/12562] Increase mq trigger screen size to hide border
  [ticket/12562] Add max-width to proSilver
2014-07-03 15:58:15 +02:00
PayBas
d8d6e3e943 [ticket/12662] Hide quick-links when empty
Also some noJS fixes

PHPBB3-12662
2014-07-03 15:53:39 +02:00
PayBas
8222eeaaff [ticket/12562] Use border for all sizes except responsive
PHPBB3-12562
2014-07-03 15:35:30 +02:00
Tristan Darricau
0232fcc22a Merge pull request #2673 from nickvergessen/ticket/12783
Ticket/12783 Move require:phpbb/phpbb to extra:phpbb/phpbb in Extensions composer.json files

* nickvergessen/ticket/12783:
  [ticket/12783] Move phpbb requirement to extra->soft-require
  [ticket/12783] Correctly use dataProviders and mark tests as incomplete
  [ticket/12783] Move phpbb/phpbb require version to extra
2014-07-03 14:23:49 +02:00
PayBas
c23c56f31c [ticket/12562] Use Hanakin's version
PHPBB3-12562
2014-07-03 13:42:12 +02:00
Joas Schilling
a0e00889d1 Merge pull request #2670 from Nicofuma/ticket/12781
[ticket/12781] Template regex for IF catch too many things

* Nicofuma/ticket/12781:
  [ticket/12781] Add tests
  [ticket/12781] Template regex for IF catch too many things
2014-07-03 12:44:33 +02:00
Joas Schilling
b0a3f2dc8f Merge pull request #2578 from marc1706/ticket/9801
[ticket/9801] Allow display of page outside board directory on viewonline

* marc1706/ticket/9801:
  [ticket/9801] Use empty instead of sizeof
  [ticket/9801] Remove spaces before * in docblock
  [ticket/9801] Add viewonline_helper service to allow proper testing
  [ticket/9801] Allow display of page outside board directory on viewonline
2014-07-03 12:02:48 +02:00
Joas Schilling
380e9c2ef4 Merge pull request #2674 from Nicofuma/ticket/12784
[ticket/12784] Allow the extensions to add a custom auto loader

* Nicofuma/ticket/12784:
  [ticket/12784] Shearch the "vendor" folders and then the autoload.php files
  [ticket/12784] Allow the extensions to add a custom auto loader
2014-07-03 11:58:04 +02:00
Tristan Darricau
520f3b3bd6 [ticket/12784] Shearch the "vendor" folders and then the autoload.php files
PHPBB3-12784
2014-07-03 11:26:07 +02:00
Joas Schilling
107693ff58 Merge pull request #2647 from Dragooon/ticket/12334
[ticket/12334] Add PROFILE_FIELD_VALUE_RAW template var

* Dragooon/ticket/12334:
  [ticket/12334] Remove profile fields test group
  [ticket/12334] Add additional test for type_string
  [ticket/12334] Add string test for type_int
  [ticket/12334] Improve type_dropdown's test description
  [ticket/12334] Group profile fields test
  [ticket/12334] Change get_profile_value_raw_data to profile_value_raw_data
  [ticket/12334] Add get_profile_value_raw unit test for type_bool
  [ticket/12334] Add get_profile_value_raw unit test for type_date
  [ticket/12334] Add get_profile_value_raw unit tests for type_dropdown
  [ticket/12334] Add get_profile_value_raw unit test for type_string
  [ticket/12334] Add get_profile_value_raw unit test for type_url
  [ticket/12334] Add get_profile_value_raw unit tests for type_int
  [ticket/12334] Removed tests
  [ticket/12334] Dropdowns cannot be tested this way
  [ticket/12334] Added test get_profile_value_raw
  [ticket/12334] Changed from valueid to value_raw
  [ticket/12334] Implemented get_profile_valueid method
  [ticket/12334] Added field_novalue fall-back as requested
  [ticket/12334] Add PROFILE_FIELD_VALUEID template var
2014-07-03 11:21:16 +02:00
Cesar G
ad967b1122 Merge remote-tracking branch 'nickvergessen/ticket/12645' into develop-ascraeus
* nickvergessen/ticket/12645:
  [ticket/12645] Replace support links in SUPPORT_BODY with 3.1 links
2014-07-02 16:46:36 -07:00
Tristan Darricau
868179c295 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12120] Add nicofuma to the developers

Conflicts:
	phpBB/docs/AUTHORS
2014-07-02 22:55:00 +02:00
Tristan Darricau
a6d66b2ab0 Merge pull request #2685 from nickvergessen/ticket/12120
[ticket/12120] Add nicofuma to the developers

* nickvergessen/ticket/12120:
  [ticket/12120] Add nicofuma to the developers
2014-07-02 22:43:12 +02:00
Joas Schilling
eff07032c0 [ticket/12120] Add nicofuma to the developers
PHPBB3-12120
2014-07-02 22:26:32 +02:00
PayBas
e99b25e273 [ticket/12562] Increase mq trigger screen size to hide border
PHPBB3-12562
2014-07-02 17:47:16 +02:00
Joas Schilling
3f0dec4ce6 [ticket/12783] Move phpbb requirement to extra->soft-require
PHPBB3-12783
2014-07-02 16:23:20 +02:00
Tristan Darricau
fbc15407a2 [ticket/12784] Allow the extensions to add a custom auto loader
PHPBB3-12784
2014-07-01 22:55:06 +02:00
Joas Schilling
b83c623480 Merge pull request #2681 from Nicofuma/ticket/12790
[ticket/12790] Use \phpbb\db\driver\driver_interface in prune_shadow_topics

* Nicofuma/ticket/12790:
  [ticket/12790] Use \phpbb\db\driver\driver_interface in prune_shadow_topics
2014-07-01 20:47:57 +02:00
Tristan Darricau
2b729c67bd [ticket/12790] Use \phpbb\db\driver\driver_interface in prune_shadow_topics
PHPBB3-12790
2014-07-01 19:46:19 +02:00
PayBas
3568eec4df [ticket/12562] Add max-width to proSilver
PHPBB3-12562
2014-07-01 18:41:56 +02:00
PayBas
04550fcd8c [ticket/12662] Fix white-space issue to make dropdowns uniform
PHPBB3-12662
2014-07-01 12:09:42 +02:00
Marc Alexander
330f21ab76 [ticket/9801] Use empty instead of sizeof
PHPBB3-9801
2014-06-30 21:36:11 +02:00
Dhruv
54a143c968 Merge remote-tracking branch 'Elsensee/ticket/12674' into develop-ascraeus
# By Oliver Schramm
# Via Oliver Schramm
* Elsensee/ticket/12674:
  [ticket/12674] Use user's colour in 'Last edited' line in sent PMs
2014-07-01 00:35:45 +05:30
Dhruv Goel
f870bc0f18 Merge pull request #2677 from nickvergessen/ticket/12779
[ticket/12779] Change order of file lists on automatic update
2014-07-01 00:27:55 +05:30
Dhruv
0190d1b207 [ticket/12788] Update symfony components
PHPBB3-12788
2014-06-30 22:04:29 +05:30
hanakin
5783b00fb6 [ticket/12735] Remove unnecessary span
PHPBB3-12735
2014-06-30 17:14:29 +02:00
hanakin
20e9480ba5 [ticket/12735] Fix line breaks
PHPBB3-12735
2014-06-30 17:08:08 +02:00
hanakin
710e0e7aa6 [ticket/12732] Undo search-box change
PHPBB3-12735
2014-06-30 17:08:08 +02:00
hanakin
bf3ac9b1dc [ticket/12735] Fix some color incosistencies
PHPBB3-12735
2014-06-30 17:08:08 +02:00
hanakin
8ef8056fd4 [ticket/12735] Remove underlines by default
PHPBB3-12735
2014-06-30 17:08:08 +02:00
hanakin
194224b550 [ticket/12735] Undo selector rename
PHPBB3-12735
2014-06-30 17:08:08 +02:00
hanakin
7d04d953c7 [ticket/12735] Remove all :link, :visited, :active states
PHPBB3-12735
2014-06-30 17:08:08 +02:00
Tristan Darricau
0ce27eacb1 [ticket/11480] Fix the double spaces in phpbb_functional_test_case
PHPBB3-11480
2014-06-30 00:33:33 +02:00
Oliver Schramm
6d1403cb13 [ticket/12674] Use user's colour in 'Last edited' line in sent PMs
PHPBB3-12674
2014-06-30 00:01:14 +02:00
Joas Schilling
5652f33ccc Merge pull request #2669 from Nicofuma/ticket/12777
[ticket/12777] Rename extension status functions and add is_configured()

* Nicofuma/ticket/12777:
  [ticket/12777] Add tests for unavailable extension
  [ticket/12777] Add tests
  [ticket/12777] Add is_purged()
  [ticket/12777] Update doc block of is_configured()
  [ticket/12777] Rename extension status functions and add is_configured()
2014-06-29 23:33:47 +02:00
Tristan Darricau
bc47e719b1 [ticket/12787] Fix the absolute board url
PHPBB3-12787
2014-06-29 22:23:32 +02:00
Joas Schilling
97725db3f4 [ticket/12779] Change order of file lists on automatic update
Also allow collapsing all the groups and collapse categories without user
interaction per default

PHPBB3-12779
2014-06-29 22:13:33 +02:00
Stanislav Atanasov
41047bc369 [ticket/12786] Dixing a typo
Typos fixed

PHPBB3-12786
2014-06-29 22:46:45 +03:00
Stanislav Atanasov
ffbd7cf1a7 [ticket/12786] Some minor fixes of comments and function naming
PHPBB3-12786
2014-06-29 22:38:05 +03:00
Tristan Darricau
31099a8efd [ticket/12787] Use a parameter (_referer) instead of the Referer header
PHPBB3-12787
2014-06-29 21:02:03 +02:00
Joas Schilling
8feb383468 [ticket/12099] Add unit tests for get_web_root_path_from_ajax_referer()
PHPBB3-12099
2014-06-29 20:54:43 +02:00
Joas Schilling
b7e1959d56 [ticket/12099] Remove config again
PHPBB3-12099
2014-06-29 20:54:41 +02:00
Joas Schilling
779d8a68ff [ticket/12099] Correctly fix the path when performing AJAX requests
If the current request is a AJAX we need to fix the paths.
We need to get the root path based on the Referer, so we can use
the generated URLs in the template of the Referer. If we do not
generate the relative path based on the Referer, but based on the
currently requested URL, the generated URLs will not point to the
intended locations:
	Referer				desired URL			desired relative root path
	memberlist.php		faq.php				./
	memberlist.php		app.php/foo/bar		./
	app.php/foo			memberlist.php		../
	app.php/foo			app.php/fox			../
	app.php/foo/bar		memberlist.php		../../
	../page.php			memberlist.php		./phpBB/
	../sub/page.php		memberlist.php		./../phpBB/

PHPBB3-12099
2014-06-29 20:54:40 +02:00
Pico88
f383d4221c [ticket/12099] Add request argument to path_helper service
PHPBB3-12099
2014-06-29 20:54:38 +02:00
Stanislav Atanasov
18631801d5 [ticket/12786] Add clean_cpf_db_entries
Add function to clean the cpf fields entries

PHPBB3-12786
2014-06-29 16:29:09 +03:00
Stanislav Atanasov
52204e0e6d [ticket/12786] White spaces found
Removed some white spaces

PHPBB3-12786
2014-06-29 12:21:40 +03:00
Stanislav Atanasov
e3b07274ef [ticket/12786] Add create_language_entries
Add function to create entries in PROFILE_FIELDS_LANG_TABLE

PHPBB3-12786
2014-06-29 11:51:47 +03:00
Stanislav Atanasov
b70a1cc4af [ticket/12786] Add get_custom_field_id
Adding function to get CPFs ID

PHPBB3-12786
2014-06-29 11:50:40 +03:00
Stanislav Atanasov
564924e876 [ticket/12786] Extend profilefield_base_migration.php class
If extensions authors will use profilefield_base_migration.php
class as base class for creation of CPFs, the class need to be
extended a bit.

At the moment there are two issues with it:

It does not create entries for PROFILE_FIELDS_LANG_TABLE
(as it can't know what fields to create).

The migration is not "cleaning" the DBMS after purging
the extension and leaves everything except the CPF column.

Adding profilefield_language_data

PHPBB3-12786
2014-06-29 11:48:06 +03:00
Tristan Darricau
539eadc450 [ticket/12782] Add doc block
PHPBB3-12782
2014-06-28 14:35:40 +02:00
PayBas
ce74a4f263 [ticket/12662] Remove last remaining linklist outside navbars
PHPBB3-12662
2014-06-28 13:53:14 +02:00
PayBas
abc0147daa [ticket/12662] Use data-last-responsive attr instead of hardcoded list
PHPBB3-12662
2014-06-28 13:47:41 +02:00
Joas Schilling
07cb08fd18 [ticket/12783] Correctly use dataProviders and mark tests as incomplete
PHPBB3-12783
2014-06-28 13:36:17 +02:00
PayBas
ca770e476c [ticket/12662] Remove <li> container from logged_out_content event
PHPBB3-12662
2014-06-28 13:25:26 +02:00
Tristan Darricau
eb13b4ae28 [ticket/12782] Use an interface for the phpbb event_dispatcher
PHPBB3-12782
2014-06-28 13:19:55 +02:00
Joas Schilling
2d116ffede [ticket/12783] Move phpbb/phpbb require version to extra
PHPBB3-12783
2014-06-28 13:06:46 +02:00
Tristan Darricau
daeb635d6c [ticket/12777] Add tests for unavailable extension
PHPBB3-12777
2014-06-27 18:35:35 +02:00
Tristan Darricau
e6b8ae6bd5 [ticket/12777] Add tests
PHPBB3-12777
2014-06-27 16:53:14 +02:00
Tristan Darricau
7ef983b426 [ticket/12781] Add tests
PHPBB3-12781
2014-06-27 16:41:21 +02:00
Shitiz Garg
b484439691 [ticket/12334] Remove profile fields test group
PHPBB3-12334
2014-06-27 20:01:25 +05:30
Tristan Darricau
6d40b87661 [ticket/12781] Template regex for IF catch too many things
PHPBB3-12781
2014-06-27 16:04:56 +02:00
Joas Schilling
404c2f1144 Merge pull request #2598 from Nicofuma/ticket/12716
[ticket/12716] Add the missing parameters in the call of clearToken

* Nicofuma/ticket/12716:
  [ticket/12716] Use a string as session_id
  [ticket/12716] Add regression test
  [ticket/12716] Add the missing parameters in the call of clearToken
2014-06-27 16:00:29 +02:00
Shitiz Garg
e6f9b060dc [ticket/12334] Add additional test for type_string
PHPBB3-12334
2014-06-27 19:19:18 +05:30
Shitiz Garg
8cb7afa503 [ticket/12334] Add string test for type_int
PHPBB3-12334
2014-06-27 19:14:36 +05:30
Shitiz Garg
482a22351d [ticket/12334] Improve type_dropdown's test description
PHPBB3-12334
2014-06-27 19:10:23 +05:30
Joas Schilling
919e1a6bc8 Merge pull request #2660 from marc1706/ticket/12764
[ticket/12764] Properly handle errors upon connecting to MySQLi database

* marc1706/ticket/12764:
  [ticket/12764] Properly handle errors upon connecting to MySQLi database
2014-06-27 15:39:07 +02:00
Shitiz Garg
9051248e12 [ticket/12334] Group profile fields test
PHPBB3-12334
2014-06-27 19:03:33 +05:30
Shitiz Garg
dbc223b4c3 [ticket/12334] Change get_profile_value_raw_data to profile_value_raw_data
PHPBB3-12334
2014-06-27 19:03:19 +05:30
Joas Schilling
8fa4ca49e0 Merge pull request #2658 from lucifer4o/ticket/12771
[ticket/12771] Bug in profilefield_base_migration when used in ext

* lucifer4o/ticket/12771:
  [ticket/12771] Shanging substr to strpos
  [ticket/12771] Change var name
  [ticket/12771] Bug in profilefield_base_migration when used in ext
2014-06-27 15:30:49 +02:00
Joas Schilling
b0286bf854 Merge pull request #2636 from Dragooon/ticket/12759
[ticket/12759] Resolve query flooding while displaying large number of custom profile fields

* Dragooon/ticket/12759:
  [ticket/12759] Fix type_bool and type_dropdown's UCP fields
  [ticket/12759] Remove lang_helper from profilefields_manager
  [ticket/12759] Cache all lang_options in lang_helper instead
  [ticket/12759] Extra line in profilefields_manager
  [ticket/12759] Cache lang_options for pm_viewmessage
  [ticket/12759] Cache lang_options on memberlist
  [ticket/12759] Add phpDoc comments to explain get_option_lang
  [ticket/12759] Little code cleanup
  [ticket/12759] Make sure $field_id has unique elements
  [ticket/12759] Cache the lang options earlier
  [ticket/12759] Cache lang options for all fields while displaying
  [ticket/12759] Allow multiple fields to be loaded via get_option_lang
2014-06-27 15:20:21 +02:00
Marc Alexander
aadc6de9c4 Merge remote-tracking branch 'dragoon/ticket/12772' into develop-ascraeus 2014-06-27 15:17:51 +02:00
Shitiz Garg
6d464e0bc4 [ticket/12759] Fix type_bool and type_dropdown's UCP fields
PHPBB3-12759
2014-06-27 17:58:28 +05:30
Shitiz Garg
98262a5a17 [ticket/12759] Remove lang_helper from profilefields_manager
No longer required

PHPBB3-12759
2014-06-27 17:48:37 +05:30
Shitiz Garg
2cf4a4f6fe [ticket/12759] Cache all lang_options in lang_helper instead
PHPBB3-12759
2014-06-27 17:48:37 +05:30
Shitiz Garg
c1df2ce62a [ticket/12759] Extra line in profilefields_manager
PHPBB3-12759
2014-06-27 17:48:37 +05:30
Shitiz Garg
f776ac7d58 [ticket/12759] Cache lang_options for pm_viewmessage
PHPBB3-12759
2014-06-27 17:48:36 +05:30
Shitiz Garg
7484859c71 [ticket/12759] Cache lang_options on memberlist
PHPBB3-12759
2014-06-27 17:48:36 +05:30
Shitiz Garg
c82a0b74cf [ticket/12759] Add phpDoc comments to explain get_option_lang
PHPBB3-12759
2014-06-27 17:48:36 +05:30
Shitiz Garg
51bc31da20 [ticket/12759] Little code cleanup
PHPBB3-12759
2014-06-27 17:48:36 +05:30
Shitiz Garg
6251d68be4 [ticket/12759] Make sure $field_id has unique elements
Otherwise it would cause a bunch of repetitive IDs passed to the IN clause

PHPBB3-12759
2014-06-27 17:48:36 +05:30
Shitiz Garg
aebe03f88c [ticket/12759] Cache the lang options earlier
Previously it would re-run on every post

PHPBB3-12759
2014-06-27 17:48:36 +05:30
Shitiz Garg
6cf6ec3354 [ticket/12759] Cache lang options for all fields while displaying
Previously these would be fetched one field at one time, causing a large
number of queries in case there were large number of custom profile fields
and/or unique number of users in areas such as viewing topics. Resolve this
by caching them at once when generating data for displaying them in templates.

PHPBB3-12759
2014-06-27 17:48:36 +05:30
Shitiz Garg
6d23cc3a0e [ticket/12759] Allow multiple fields to be loaded via get_option_lang
PHPBB3-12759
2014-06-27 17:48:36 +05:30
Joas Schilling
18763d7286 Merge pull request #2493 from Nicofuma/ticket/12325
[ticket/12325] Automatic update should notify about outdated files

* Nicofuma/ticket/12325:
  [ticket/12325] Fix the language var name
  [ticket/12325] Update coding style in template
  [ticket/12325] Fix: add a missing colon
  [ticket/12325] Don't use L_COLON
  [ticket/12325] Fix: it's not stuck in an inifinite loop anymore
  [ticket/12325] Automatic update should notify about outdated files
2014-06-27 14:01:31 +02:00
Tristan Darricau
8e8b493fae [ticket/12777] Add is_purged()
PHPBB3-12777
2014-06-27 11:28:13 +02:00
Tristan Darricau
4d9e451f60 [ticket/12777] Update doc block of is_configured()
PHPBB3-12777
2014-06-27 11:23:11 +02:00
Tristan Darricau
d13e02c7b1 [ticket/12777] Rename extension status functions and add is_configured()
PHPBB3-12777
2014-06-27 10:49:13 +02:00
Joas Schilling
59c0a31fc4 [ticket/12645] Replace support links in SUPPORT_BODY with 3.1 links
PHPBB3-12645
2014-06-27 10:18:36 +02:00
Andreas Fischer
cc4f1e401e Merge pull request #2665 from nickvergessen/ticket/12196-ascraeus
[ticket/12196] Fix typo in "referrer"

* nickvergessen/ticket/12196-ascraeus:
  [ticket/12196] Fix typo in "referrer"
2014-06-26 23:46:40 +02:00
Andreas Fischer
e8d7204580 Merge pull request #2661 from n-aleha/ticket/12773
[ticket/12773] Fix language variable name in cli extension enable command

* n-aleha/ticket/12773:
  [ticket/12773] Fix language variable name in cli extension enable command
2014-06-26 23:44:41 +02:00
Joas Schilling
7e769083bf [ticket/12196] Fix typo in "referrer"
Referer is a typo in the HTTP RFC and should not be used in the UI

PHPBB3-12196
2014-06-26 23:44:21 +02:00
Andreas Fischer
ffa1f9baf5 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12196] Revert Fix typo "referer" in acp/attachments
2014-06-26 23:33:47 +02:00
Andreas Fischer
66efb1889d Merge pull request #2662 from dhruvgoel92/ticket/12196
[ticket/12196] Revert Fix typo "referer" in acp/attachments

* dhruvgoel92/ticket/12196:
  [ticket/12196] Revert Fix typo "referer" in acp/attachments
2014-06-26 23:33:46 +02:00
Tristan Darricau
ff6e026a40 [ticket/12446] Unnecessary db connect inphpbb_bootstrap_enabled_exts
PHPBB3-12446
2014-06-26 21:09:19 +02:00
Dhruv
a730c0291f [ticket/12196] Revert Fix typo "referer" in acp/attachments
This reverts commit 9bc1f7924d.
https://tracker.phpbb.com/browse/PHPBB3-12196

PHPBB3-12196
2014-06-27 00:07:15 +05:30
n-aleha
a54d74bf09 [ticket/12773] Fix language variable name in cli extension enable command
PHPBB3-12773
2014-06-26 21:05:32 +03:00
Dhruv
eb3e1b35d6 Merge branch 'develop-olympus' into develop-ascraeus
# By Joas Schilling
# Via Dhruv (1) and Joas Schilling (1)
* develop-olympus:
  [ticket/12196] Fix typo "referer" in acp/attachments
2014-06-26 23:30:06 +05:30
Stanislav Atanasov
deb393bff3 [ticket/12771] Shanging substr to strpos
Logical change ...

PHPBB3-12771
2014-06-26 20:56:00 +03:00
Dhruv
fbbf210747 Merge remote-tracking branch 'nickvergessen/ticket/12196' into develop-olympus
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/ticket/12196:
  [ticket/12196] Fix typo "referer" in acp/attachments
2014-06-26 23:23:33 +05:30
Marc Alexander
9b27d00d5f Merge remote-tracking branch 'nickvergessen/ticket/12099' into develop-ascraeus
* nickvergessen/ticket/12099:
  [ticket/12099] Fix correction in path_helper test
  [ticket/12099] Prepend ./ to path to fix assets
  [ticket/12099] Deduplicate path generation
  [ticket/12099] Fix clean_path() ".." stripping when previous directory was "."
  [ticket/12099] Break clean_path tests with a simple test
  [ticket/12099] Clean paths in tests
  [ticket/12099] Correctly fix go back to root before prepending the root path
  [ticket/12099] Clean some paths before using them
  [ticket/12099] Fix several issues in path_helper test
2014-06-26 15:07:05 +02:00
Marc Alexander
eb9321c3a1 [ticket/9801] Remove spaces before * in docblock
PHPBB3-9801
2014-06-26 14:37:38 +02:00
Marc Alexander
40a65abc3a [ticket/12764] Properly handle errors upon connecting to MySQLi database
As the db_connect_id gets set up by mysql_init(), the db_connect_id will be an
object with empty settings instead of just empty. Even if mysql_real_connect()
encounters an error upon connecting, the db_connect_id is still set. This
will result in trying to just access the database which obviously does
nothing.
By setting db_connect_id to an empty string, the script will not try to query
th database and properly handle any errors that occur upon connecting.

PHPBB3-12764
2014-06-26 14:33:08 +02:00
Stanislav Atanasov
c14db9ccd0 [ticket/12771] Change var name
Change var name

PHPBB3-12771
2014-06-26 14:19:49 +03:00
Shitiz Garg
570acb7ccc [ticket/12772] Remove config_text parameter from message.form.topic
Broke Email topic since the topic_form class doesn't require this to be passed

PHPBB3-12772
2014-06-26 16:44:40 +05:30
Stanislav Atanasov
5a76b36dfb [ticket/12771] Bug in profilefield_base_migration when used in ext
The base migration class should create lang entry for the new CPF
but it is supposed to strip it of phpbb_ prefix. As extensions
CPFs do not use phpbb_ prefix it will not create a lang entry.
This is as simple solution as it can be done.

PHPBB3-12771
2014-06-26 13:18:27 +03:00
PayBas
de250273db [ticket/12662] Username <span> fix for list columns
PHPBB3-12662
2014-06-26 11:23:37 +02:00
Marc Alexander
69b9aa2859 Merge remote-tracking branch 'nickvergessen/ticket/12462' into develop-ascraeus 2014-06-25 23:23:18 +02:00
Joas Schilling
9bc1f7924d [ticket/12196] Fix typo "referer" in acp/attachments
PHPBB3-12196
2014-06-25 23:17:02 +02:00
Joas Schilling
993afd9140 [ticket/12197] Fix several misleading FAQ entries
PHPBB3-12197
2014-06-25 22:26:15 +02:00
Joas Schilling
29ec455a45 [ticket/12462] Do not use string "None" for different options
... it limits translations.

PHPBB3-12462
2014-06-25 22:14:33 +02:00
Joas Schilling
8b00be6fce Merge pull request #2567 from Crizz0/ticket/12680
[Ticket/12680] - Adds alternative text to contact icon in viewtopic.php

* Crizz0/ticket/12680:
  [ticket/12680] Adds variable for guest user
  [ticket/12680] Brings back get_username_string()
  [ticket/12680] Solves last bugs. viewprofile: contact --> contact nickname
  [ticket/12680] Still some problems with displaying the nickname in ucp
  [ticket/12680] Little changes, but some issues are still there
  [ticket/12680] Removes unnessesary $user->lang from CONTACT_USER
  [ticket/12680] Adds alternativ text with new variable to contact:
  [ticket/12680] Adds second alternativ text and font-size: 0 to remove text
  [ticket/12680] Adds alternative text to contact icon in viewtopic.php
2014-06-25 19:36:18 +02:00
Joas Schilling
4917ebe93a [ticket/12448] Fix null columns for MS SQL
PHPBB3-12448
2014-06-25 18:39:10 +02:00
Joas Schilling
b2044884ff [ticket/12448] Fix null columns for postgres
PHPBB3-12448
2014-06-25 18:37:46 +02:00
PayBas
367c6aafca [ticket/12662] Fix notifications dropdown positioning for RTL
PHPBB3-12662
2014-06-25 14:19:09 +02:00
PayBas
665742945f [ticket/12662] Update tests that utilize get_username_string
PHPBB3-12662
2014-06-25 14:19:09 +02:00
PayBas
419de00a9c [ticket/12662] Update subsilver2 index template event names
PHPBB3-12662
2014-06-25 14:19:08 +02:00
PayBas
6d641ad590 [ticket/12662] Update events docs from b5 to rc1/rc2
PHPBB3-12662
2014-06-25 14:19:07 +02:00
PayBas
9c2ef168c1 [ticket/12662] Move dropdown container from <li> to new inner div
PHPBB3-12662
2014-06-25 14:19:07 +02:00
PayBas
020218fcea [ticket/12662] Remove linklist container and update template events
PHPBB3-12662
2014-06-25 14:19:06 +02:00
PayBas
23caeb7712 [ticket/12662] Add span containers to all usernames for consistency
PHPBB3-12662
2014-06-25 14:19:06 +02:00
PayBas
775dc316b0 [ticket/12662] IE8 fixes
PHPBB3-12662
2014-06-25 14:19:05 +02:00
PayBas
dd18085ba6 [ticket/12662] Fix responsive positioning of notifications dropdown
PHPBB3-12662
2014-06-25 14:19:05 +02:00
PayBas
faa47cd176 [ticket/12662] Remove inherited props from ddown-extendended
PHPBB3-12662
2014-06-25 14:19:04 +02:00
PayBas
8c7127f573 [ticket/12662] Change CSS selectors to direct descendants for linklist
PHPBB3-12662
2014-06-25 14:19:03 +02:00
PayBas
e528a57c2f [ticket/12662] Reorder icon CSS rules alphabetically
Was getting a bit disorganized

PHPBB3-12662
2014-06-25 14:19:03 +02:00
PayBas
99065e18ca [ticket/12662] Use slack variable to determine line-break sensitivity
PHPBB3-12662
2014-06-25 14:19:02 +02:00
PayBas
5c90b82fde [ticket/12662] Change new event names and fix events.md
Previously merged PR said b4 instead of b5, also not alphabetical.

PHPBB3-12662
2014-06-25 14:19:01 +02:00
PayBas
bd0110ae79 [ticket/12662] Fix recently merged PR changes lost in rebase
PHPBB3-12662
2014-06-25 14:19:01 +02:00
PayBas
b8f8b884e7 [ticket/12662] Update PR after ticket/12553 merge
Rebasing was a nightmare with all the code moving around between
commits. Hopefully this will merge without a rebase.

PHPBB3-12662
2014-06-25 14:19:00 +02:00
PayBas
5a00054f52 [ticket/12662] Improve template checks
And changed _CLEAN to _SIMPLE, and move teamlink events

PHPBB3-12662
2014-06-25 14:19:00 +02:00
PayBas
ac89c84808 [ticket/12662] Added ARIA functionality
PHPBB3-12662
2014-06-25 14:18:59 +02:00
PayBas
329b1826af [ticket/12662] Improve icons and footer links
PHPBB3-12662
2014-06-25 14:18:59 +02:00
PayBas
f41947f726 [ticket/12662] Fix rounding problems when detecting relative height
Firefox and IE round subpixels up, while webkit rounds down. So we have
to account for that.

PHPBB3-12662
2014-06-25 14:18:58 +02:00
PayBas
4a98d7e46d [ticket/12662] RTL (bidi.css) fixes
PHPBB3-12662
2014-06-25 14:18:57 +02:00
PayBas
cf1b56af8d [ticket/12662] Enable responsive linkslist for IE8
Also fixed arrow color

PHPBB3-12662
2014-06-25 14:18:57 +02:00
PayBas
a540cdc3b2 [ticket/12662] Initial setup
PHPBB3-12662
2014-06-25 14:18:56 +02:00
Joas Schilling
5265091c83 Merge pull request #2649 from VSEphpbb/ticket/12760
[ticket/12760] Fix wording for unapproved posts icon...

* VSEphpbb/ticket/12760:
  [ticket/12760] Fix wording for unapproved posts icon...
2014-06-25 14:16:53 +02:00
Joas Schilling
d083f29244 Merge pull request #2650 from PayBas/ticket/12766
[ticket/12766] Event exporter does not like RCx as version

* PayBas/ticket/12766:
  [ticket/12766] Event exporter does not like RCx as version
2014-06-25 14:06:39 +02:00
Joas Schilling
95ab4b3e93 [ticket/12448] Allow null as default value for columns
PHPBB3-12448
2014-06-25 13:40:32 +02:00
PayBas
1b0b4cd5e2 [ticket/12766] Event exporter does not like RCx as version
PHPBB3-12766
2014-06-25 13:35:57 +02:00
Matt Friedman
e42b316d87 [ticket/12760] Fix wording for unapproved posts icon...
in last post column of forum lists.
https://tracker.phpbb.com/browse/PHPBB3-12760

PHPBB3-12760
2014-06-24 20:47:51 -07:00
Joas Schilling
3e9d62b9b0 Merge branch 'prep-release-3.1.0-RC1' into develop-ascraeus
* prep-release-3.1.0-RC1:
  [prep-release-3.1.0-RC1] Update phpBB Version for RC2 development
  [prep-release-3.1.0-RC1] Add changelog for 3.1.0-RC1
  [prep-release-3.1.0-RC1] Prepare Changelog
  [prep-release-3.1.0-RC1] Add migration for 3.1.0-RC1
  [prep-release-3.1.0-RC1] Update version to 3.1.0-RC1
2014-06-25 00:07:18 +02:00
Joas Schilling
19b4391eef [prep-release-3.1.0-RC1] Update phpBB Version for RC2 development 2014-06-25 00:06:08 +02:00
Joas Schilling
60cb10e62b [prep-release-3.1.0-RC1] Add changelog for 3.1.0-RC1 2014-06-24 23:21:58 +02:00
Joas Schilling
cf92032ebb [prep-release-3.1.0-RC1] Prepare Changelog 2014-06-24 23:21:54 +02:00
Joas Schilling
6a9baaab0b [prep-release-3.1.0-RC1] Add migration for 3.1.0-RC1 2014-06-24 23:21:48 +02:00
Joas Schilling
894dcaaaad [prep-release-3.1.0-RC1] Update version to 3.1.0-RC1 2014-06-24 23:21:43 +02:00
Andreas Fischer
70a98e6f63 Merge pull request #2648 from dhruvgoel92/ticket/12562
Revert "[ticket/12562] Add max-width to proSilver"

* dhruvgoel92/ticket/12562:
  [ticket/12562] Revert "Add max-width to proSilver"
2014-06-24 21:10:44 +02:00
Andreas Fischer
b5b0175d59 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12755] Apply de morgan to conditional
  [ticket/12755] Terminate upload loop if upload reaches filesize
  [ticket/12755] Change upload in remote_upload() method to fit get_remote_file
  [ticket/12755] Add language string for timed out remote upload
  [ticket/12755] Add timeout to remote upload to prevent infinite loop
2014-06-24 20:59:11 +02:00
Andreas Fischer
2596dbc850 Merge pull request #2633 from marc1706/ticket/12755
[ticket/12755] Add timeout to remote upload to prevent infinite loop

* marc1706/ticket/12755:
  [ticket/12755] Apply de morgan to conditional
  [ticket/12755] Terminate upload loop if upload reaches filesize
  [ticket/12755] Change upload in remote_upload() method to fit get_remote_file
  [ticket/12755] Add language string for timed out remote upload
  [ticket/12755] Add timeout to remote upload to prevent infinite loop
2014-06-24 20:59:10 +02:00
Dhruv
c563d96633 [ticket/12562] Revert "Add max-width to proSilver"
https://tracker.phpbb.com/browse/PHPBB3-12562

PHPBB3-12562
2014-06-25 00:28:50 +05:30
Marc Alexander
8b3cc9a6c4 [ticket/12755] Apply de morgan to conditional
PHPBB3-12755
2014-06-24 19:53:52 +02:00
Shitiz Garg
24eeab4883 [ticket/12334] Add get_profile_value_raw unit test for type_bool
PHPBB3-12334
2014-06-24 22:46:43 +05:30
Shitiz Garg
e406cc6fad [ticket/12334] Add get_profile_value_raw unit test for type_date
PHPBB3-12334
2014-06-24 22:46:43 +05:30
Shitiz Garg
15929201b8 [ticket/12334] Add get_profile_value_raw unit tests for type_dropdown
PHPBB3-12334
2014-06-24 22:46:43 +05:30
Shitiz Garg
ab6d36dd57 [ticket/12334] Add get_profile_value_raw unit test for type_string
PHPBB3-12334
2014-06-24 22:46:33 +05:30
Marc Alexander
309dbb4ef9 [ticket/12755] Terminate upload loop if upload reaches filesize
Terminate the upload loop if the expected filesize has been reached instead
of trying to read more bytes until the timeout has been reached.

PHPBB3-12755
2014-06-24 19:07:49 +02:00
Marc Alexander
277e9a7a85 [ticket/9801] Add viewonline_helper service to allow proper testing
The viewonline_helper service can and will be extended in the future which
will allow us to also test the viewonline page better.

PHPBB3-9801
2014-06-24 18:49:31 +02:00
Shitiz Garg
e9fbaac212 [ticket/12334] Add get_profile_value_raw unit test for type_url
PHPBB3-12334
2014-06-24 22:15:20 +05:30
Shitiz Garg
7a5afdeb4c [ticket/12334] Add get_profile_value_raw unit tests for type_int
PHPBB3-12334
2014-06-24 22:12:00 +05:30
PayBas
8cef0b6971 [ticket/12334] Removed tests
Will be implemented in #2459

PHPBB3-12334
2014-06-24 21:47:29 +05:30
PayBas
349fbabd2e [ticket/12334] Dropdowns cannot be tested this way
PHPBB3-12334
2014-06-24 21:47:29 +05:30
PayBas
ac97497d95 [ticket/12334] Added test get_profile_value_raw
PHPBB3-12334
2014-06-24 21:47:29 +05:30
PayBas
2b451a174b [ticket/12334] Changed from valueid to value_raw
PHPBB3-12334
2014-06-24 21:47:29 +05:30
PayBas
507eca319d [ticket/12334] Implemented get_profile_valueid method
PHPBB3-12334
2014-06-24 21:47:29 +05:30
PayBas
4169fd65f0 [ticket/12334] Added field_novalue fall-back as requested
PHPBB3-12334
2014-06-24 21:47:29 +05:30
PayBas
08e2c07f0b [ticket/12334] Add PROFILE_FIELD_VALUEID template var
PHPBB3-12334
2014-06-24 21:47:29 +05:30
Andreas Fischer
1edcfcb502 Merge pull request #2646 from prototech/ticket/12750
[ticket/12750] Center installation page copyright text.

* prototech/ticket/12750:
  [ticket/12750] Center installation page copyright text.
2014-06-24 13:01:02 +02:00
Marc Alexander
5ee1e07e17 [ticket/12755] Change upload in remote_upload() method to fit get_remote_file
PHPBB3-12755
2014-06-24 11:53:32 +02:00
Cesar G
e427d203b6 [ticket/12750] Center installation page copyright text.
PHPBB3-12750
2014-06-24 01:48:31 -07:00
Nils Adermann
41becd9c92 Merge remote-tracking branch 'github-nickvergessen/ticket/12612' into develop-ascraeus
* github-nickvergessen/ticket/12612:
  [ticket/12612] Prefix check_ids() with phpbb_
  [ticket/12612] Prefix mcp_sorting() with phpbb_
  [ticket/12612] Prefix get_*_data() with phpbb_ and delete unused global
  [ticket/12612] Prefix module url functions with phpbb_
  [ticket/12612] Prefix upload_popup() with phpbb_
  [ticket/12612] Prefix handle_post_delete() with phpbb and remove unused global
  [ticket/12612] Prefix custom UCP module function with phpbb_
  [ticket/12612] Prefix _sort_last_active() with phpbb_
  [ticket/12612] Prefix show_profile() with phpbb and delete unused global
2014-06-24 01:24:01 -04:00
Cesar G
0b4abd01c8 Merge remote-tracking branch 'PayBas/ticket/12562' into develop-ascraeus
* PayBas/ticket/12562:
  [ticket/12562] Add max-width to proSilver
2014-06-23 20:57:31 -07:00
Cesar G
8c44b2721c Merge remote-tracking branch 'PayBas/ticket/12648' into develop-ascraeus
* PayBas/ticket/12648:
  [ticket/12648] RTL fix & ACP border fix
  [ticket/12648] Slightly clear ACP active tab border
  [ticket/12648] Fix poll tab and revert unrelated color change
  [ticket/12648] Fix poll tab display error
  [ticket/12648] Added ARIA functionality
  [ticket/12648] Fix and modernize ACP header tabs
  [ticket/12648] More style fixes and also cleaned up CP left navigation
  [ticket/12648] IE8 & IE9 color fix
  [ticket/12648] Improve UCP/MCP/Posting tabs
2014-06-23 20:45:20 -07:00
Andreas Fischer
05bcce3169 Merge pull request #2642 from Nicofuma/ticket/12762
[ticket/12762] Make ext.php optional for extensions

* Nicofuma/ticket/12762:
  [ticket/12762] Make ext.php optional for extensions
2014-06-24 00:39:40 +02:00
Andreas Fischer
ba456bb00e Merge pull request #2643 from nickvergessen/ticket/12763
Ticket/12763 Do not regenerate the *_schema.sql files

* nickvergessen/ticket/12763:
  [ticket/12763] Remove invalid comment from oracle and postgres *_schema.sql
  [ticket/12763] Remove empty schema files
  [ticket/12763] Do not regenerate the *_schema.sql files
2014-06-24 00:19:30 +02:00
PayBas
7517cc0e05 [ticket/12648] RTL fix & ACP border fix
PHPBB3-12648
2014-06-24 00:02:26 +02:00
PayBas
919fee6b1b [ticket/12648] Slightly clear ACP active tab border
PHPBB3-12648
2014-06-24 00:02:26 +02:00
PayBas
8547fd4c2e [ticket/12648] Fix poll tab and revert unrelated color change
PHPBB3-12648
2014-06-24 00:02:25 +02:00
PayBas
1189fc9e51 [ticket/12648] Fix poll tab display error
PHPBB3-12648
2014-06-24 00:02:25 +02:00
PayBas
1cf6a0e124 [ticket/12648] Added ARIA functionality
PHPBB3-12648
2014-06-24 00:02:24 +02:00
PayBas
b83b72b271 [ticket/12648] Fix and modernize ACP header tabs
PHPBB3-12648
2014-06-24 00:02:24 +02:00
PayBas
6f9674228c [ticket/12648] More style fixes and also cleaned up CP left navigation
PHPBB3-12648
2014-06-24 00:02:23 +02:00
PayBas
f888b31645 [ticket/12648] IE8 & IE9 color fix
PHPBB3-12648
2014-06-24 00:02:23 +02:00
PayBas
eda3c36b1c [ticket/12648] Improve UCP/MCP/Posting tabs
PHPBB3-12648
2014-06-24 00:02:22 +02:00
Tristan Darricau
2ebd86611a [ticket/12716] Use a string as session_id
PHPBB3-12716
2014-06-23 23:59:45 +02:00
Joas Schilling
952b4de231 [ticket/12612] Prefix check_ids() with phpbb_
PHPBB3-12612
2014-06-23 23:01:52 +02:00
Joas Schilling
4ac43856f7 [ticket/12612] Prefix mcp_sorting() with phpbb_
PHPBB3-12612
2014-06-23 23:00:13 +02:00
Joas Schilling
c315fc6c89 [ticket/12612] Prefix get_*_data() with phpbb_ and delete unused global
PHPBB3-12612
2014-06-23 22:58:41 +02:00
Joas Schilling
bba23f61b3 [ticket/12612] Prefix module url functions with phpbb_
PHPBB3-12612
2014-06-23 22:54:15 +02:00
Joas Schilling
e4437e19e8 [ticket/12612] Prefix upload_popup() with phpbb_
PHPBB3-12612
2014-06-23 22:49:00 +02:00
Joas Schilling
5403b48788 [ticket/12612] Prefix handle_post_delete() with phpbb and remove unused global
PHPBB3-12612
2014-06-23 22:48:08 +02:00
Joas Schilling
0abc1f0f97 [ticket/12612] Prefix custom UCP module function with phpbb_
PHPBB3-12612
2014-06-23 22:46:20 +02:00
Joas Schilling
b72fdd9acf [ticket/12612] Prefix _sort_last_active() with phpbb_
PHPBB3-12612
2014-06-23 22:38:58 +02:00
Joas Schilling
7575c478c7 [ticket/12612] Prefix show_profile() with phpbb and delete unused global
PHPBB3-12612
2014-06-23 22:34:17 +02:00
Tristan Darricau
ffb992f9a9 [ticket/12051] Optimise Composer Autoloader on Build
PHPBB3-12051
2014-06-23 22:26:25 +02:00
Joas Schilling
307c9bc15f [ticket/12763] Remove invalid comment from oracle and postgres *_schema.sql
PHPBB3-12763
2014-06-23 21:41:59 +02:00
Joas Schilling
3fd7fd435d [ticket/12763] Remove empty schema files
PHPBB3-12763
2014-06-23 21:41:04 +02:00
Joas Schilling
e45cd32de7 [ticket/12763] Do not regenerate the *_schema.sql files
PHPBB3-12763
2014-06-23 21:39:34 +02:00
Marc Alexander
ff56f0dcfe [ticket/11148] Remove unneeded variable mimetype and use type octet-stream
The variable $mimetype is not used in the method local_upload() afterwards
so it shouldn't be assigned. The correct default mimetype should be
application/octet-stream and not application/octetstream according to RFC 2046.

PHPBB3-11148
2014-06-23 21:39:24 +02:00
Marc Alexander
3823fe355f [ticket/11148] Change expected output with disallowed content in test
PHPBB3-11148
2014-06-23 21:39:24 +02:00
Marc Alexander
4eb7485b39 [ticket/11148] Always use the output of the mimetype guesser in get_mimetype
PHPBB3-11148
2014-06-23 21:39:24 +02:00
Marc Alexander
a402d619b4 [ticket/11148] Get rid of extra line in mimetype guesser setter doc block
PHPBB3-11148
2014-06-23 21:39:24 +02:00
Marc Alexander
ea5bc9c833 [ticket/11148] Add missing parts to docblock of get_mimetype() method
PHPBB3-11148
2014-06-23 21:39:24 +02:00
Marc Alexander
de404002c7 [ticket/11148] Default to application/octet-stream if no mimetype given
This should prevent us from having an empty mimetype while uploading a file
using local_upload().

PHPBB3-11148
2014-06-23 21:39:24 +02:00
Marc Alexander
c22983cbdb [ticket/11148] Use mimetype guesser for uploaded avatars
PHPBB3-11148
2014-06-23 21:39:24 +02:00
Marc Alexander
94a81fa01d [ticket/11148] Pass mimetype guesser to upload_attachment() function
PHPBB3-11148
2014-06-23 21:37:47 +02:00
Marc Alexander
9bc6e641bf [ticket/11148] Add mimetype guesser to filespec and fileupload class
The mimetype guesser will be used to get the mimetype of uploaded files.
Until now, this was only used for files uploaded with plupload. If a file
doesn't have a mimetype supplied, we will now try to get the correct mimetype.

PHPBB3-11148
2014-06-23 21:37:47 +02:00
Crizzo
aff67b99b5 [ticket/12680] Adds variable for guest user
PHPBB3-12680
2014-06-23 20:49:25 +02:00
Andreas Fischer
8332671813 Merge pull request #2587 from dhruvgoel92/ticket/11528
[ticket/11528] Refactor install_board( ) into a new mink class

* dhruvgoel92/ticket/11528:
  [ticket/11528] Change click_submit() to accept id as param
  [ticket/11528] Handle case when config file cant be written by installer
  [ticket/11528] Change NULL to null
  [ticket/11528] Fix spaces and slashes as per guidelines
  [ticket/11528] Add asserts in installation steps
  [ticket/11528] Use 'use' keyword to import classes to current scope
  [ticket/11528] Move parent::tearDown() to end of tearDown()
  [ticket/11528] Call parent::tearDown in overrided tearDown method
  [ticket/11528] Instantiate $client, $driver from functional test case
  [ticket/11528] Refactor install_board() code into a new class
  [ticket/11528] Add behat/mink and mink-goutte-driver as dependency
2014-06-23 20:38:11 +02:00
Marc Alexander
8817b59377 [ticket/12755] Add language string for timed out remote upload
PHPBB3-12755
2014-06-23 20:35:36 +02:00
Crizzo
8984dc6103 [ticket/12680] Brings back get_username_string()
PHPBB3-12680
2014-06-23 20:12:12 +02:00
Joas Schilling
052a4e6f58 Merge pull request #2640 from dhruvgoel92/ticket/12532
[ticket/12532] Add navbar_header_username_append/prepend

* dhruvgoel92/ticket/12532:
  [ticket/12532] Move logged_out event into its own <li>
  [ticket/12532] Fix tab -> space indentation in events.md
  [ticket/12532] Add navbar_header_logged_out_content event
  [ticket/12532] Add navbar_header_username_append/prepend
2014-06-23 20:05:01 +02:00
Joas Schilling
ec4924cf14 Merge pull request #2581 from lucifer4o/ticket/12696
[Ticket/12696] Add events to ucp_register.html

* lucifer4o/ticket/12696:
  [ticket/12696] Typo
  [ticket/12696] Change some parts
  [ticket/12696] Naming convention changes
  [ticket/12696] A small error with events.md perms
  [ticket/12696] Add events to evets.md
  [ticket/12696] Add prosilver ucp_register
  [ticket/12696] Add events to ucp_register.html
2014-06-23 19:49:21 +02:00
Joas Schilling
c740772d93 Merge pull request #2574 from lucifer4o/ticket/12690
[ticket/12690] Add core.submit_pm_after event

* lucifer4o/ticket/12690:
  [ticket/12690] Find a space
  [ticket/12690] Remove $msg_id and chmod
  [ticket/12690] Add other info to core.submit_pm_after
  [ticket/12690] Add core.submit_pm_after event
2014-06-23 19:46:50 +02:00
Joas Schilling
08f244229c Merge pull request #2609 from VSEphpbb/ticket/12728
[ticket/12728] Enforce box model sizing on image attachment thumbnails

* VSEphpbb/ticket/12728:
  [ticket/12728] Adjust .postimage sizing to 100%
  [ticket/12728] Enforce box model sizing on image attachment thumbnails
2014-06-23 19:42:19 +02:00
Tristan Darricau
26eb15ffab [ticket/12762] Make ext.php optional for extensions
PHPBB3-12762
2014-06-23 19:39:19 +02:00
Crizzo
453f2904c2 [ticket/12680] Solves last bugs. viewprofile: contact --> contact nickname
PHPBB3-12680
2014-06-23 19:38:44 +02:00
Dhruv Goel
dfbe072d51 Merge pull request #2571 from Crizz0/ticket/12563
[ticket/12563] Changes 2 style specific language variables for better understanding
2014-06-23 22:04:20 +05:30
Dhruv
61fa0908bc [ticket/11528] Change click_submit() to accept id as param
PHPBB3-11528
2014-06-23 21:24:29 +05:30
Dhruv
2147a5eba5 [ticket/11528] Handle case when config file cant be written by installer
PHPBB3-11528
2014-06-23 21:23:47 +05:30
Nils Adermann
1f9e1fd177 Merge remote-tracking branch 'github-nickvergessen/ticket/12612-ascraeus' into develop-ascraeus
* github-nickvergessen/ticket/12612-ascraeus:
  [ticket/12612] Move functions from mcp.php to functions_mcp.php
  [ticket/12612] Move function from ucp.php to functions_user.php
  [ticket/12612] Move functions from memberlist.php to functions_display.php
  [ticket/12612] Move functions from posting.php to functions_posting.php
2014-06-23 11:19:15 -04:00
Dhruv
12590af750 [ticket/12532] Move logged_out event into its own <li>
PHPBB3-12532
2014-06-23 19:59:59 +05:30
imkingdavid
5b02613a83 [ticket/12532] Fix tab -> space indentation in events.md
PHPBB3-12532
2014-06-23 19:56:36 +05:30
imkingdavid
99e9f198b0 [ticket/12532] Add navbar_header_logged_out_content event
PHPBB3-12532
2014-06-23 19:56:34 +05:30
David King
3113963cb6 [ticket/12532] Add navbar_header_username_append/prepend
PHPBB3-12532
2014-06-23 19:56:33 +05:30
Andreas Fischer
4cb7cbd093 Merge pull request #2639 from n-aleha/ticket/12761
[ticket/12761] Remove the execute bit from functions_user.php

* n-aleha/ticket/12761:
  [ticket/12761] Remove the execute bit from functions_user.php
2014-06-23 16:17:14 +02:00
n-aleha
ec69a22899 [ticket/12761] Remove the execute bit from functions_user.php
PHPBB3-12761
2014-06-23 17:13:03 +03:00
Andreas Fischer
647869721d Merge pull request #2625 from Nicofuma/ticket/12726
[ticket/12726] Add Code Sniffer sniff ensuring PHP files do not contain any unused use statements

* Nicofuma/ticket/12726:
  [ticket/12726] Fix coding style
  [ticket/12726] Update error message
  [ticket/12726] Fix coding style
  [ticket/12726] Ensure PHP files do not contain any unused use statements
  [ticket/12726] PSR2.Namespaces.NamespaceDeclaration
2014-06-23 00:53:55 +02:00
Cesar G
74a37259f7 Merge remote-tracking branch 'PayBas/ticket/12608' into develop-ascraeus
* PayBas/ticket/12608:
  [ticket/12608] Change CSS classes to prevent styling conflicts
  [ticket/12608] Add subSilver
  [ticket/12608] Changed get_styling() to get_style_class()
  [ticket/12608] Remove somewhat redundant reported color style
  [ticket/12608] Improved LTR and various bugfixes
  [ticket/12608] Clean up whitespace
  [ticket/12608] Add styling (CSS class) options to notifications
  [ticket/12608] Updated tests
  [ticket/12608] Improve notifications drop-down menu styling in header
2014-06-22 15:44:06 -07:00
Stanislav Atanasov
1d5e94ba36 [ticket/12696] Typo
Fixing typo

PHPBB3-12696
2014-06-23 01:02:06 +03:00
Tristan Darricau
7958a97fdd [ticket/12726] Fix coding style
PHPBB3-12726
2014-06-22 23:57:39 +02:00
Tristan Darricau
147ae8374c [ticket/12726] Update error message
PHPBB3-12726
2014-06-22 23:52:19 +02:00
Tristan Darricau
2ff9064ffb [ticket/12726] Fix coding style
PHPBB3-12726
2014-06-22 23:52:17 +02:00
Tristan Darricau
fa5afb60aa [ticket/12726] Ensure PHP files do not contain any unused use statements
PHPBB3-12726
2014-06-22 23:52:16 +02:00
Tristan Darricau
e46ef86104 [ticket/12726] PSR2.Namespaces.NamespaceDeclaration
PHPBB3-12726
2014-06-22 23:52:14 +02:00
Andreas Fischer
4f2acbaed2 Merge pull request #2629 from nickvergessen/ticket/12747
[ticket/12747] Drop support for Firebird

* nickvergessen/ticket/12747:
  [ticket/12747] Remove some methods which are not used anymore
  [ticket/12747] Drop support for Firebird

Conflicts:
	phpBB/phpbb/db/driver/firebird.php
2014-06-22 23:41:14 +02:00
Joas Schilling
de04304e94 Merge pull request #2591 from rxu/ticket/12704
[ticket/12704] Improve the load time information in the footer when enabled

* rxu/ticket/12704:
  [ticket/12704] Improve the load time information in the footer when enabled
2014-06-22 23:09:21 +02:00
Joas Schilling
d3b3e9265c Merge pull request #2597 from Skouat/ticket/12714
[ticket/12714] Switching the description of radio buttons to align the correct description above the listbox

* Skouat/ticket/12714:
  [ticket/12714] Move "allow all forums" in its own dd-element
2014-06-22 23:01:32 +02:00
Joas Schilling
bb8be29fd5 Merge pull request #2575 from lucifer4o/ticket/12691
[ticket/12691] Add core.delete_pm to funtion delete_pm

* lucifer4o/ticket/12691:
  [ticket/12691] Comment change
  [ticket/12691] Change event to core.delete_pm_before
  [ticket/12691] Add core.delete_pm to funtion delete_pm
2014-06-22 22:59:37 +02:00
Joas Schilling
1e97502d90 Merge pull request #2586 from lucifer4o/ticket/12701
[Ticket/12701] Add events to user_add function

* lucifer4o/ticket/12701:
  [ticket/12701] Add change
  [ticket/12701] Rmove before event and expand modify_data
  [ticket/12701] Add events to user_add function
2014-06-22 22:57:40 +02:00
PayBas
1a3c1d5b9a [ticket/12608] Change CSS classes to prevent styling conflicts
PHPBB3-12608
2014-06-22 22:41:56 +02:00
Stanislav Atanasov
334c77cd0d [ticket/12696] Change some parts
Change placment of ucp_register_profile_fields_before

PHPBB3-12696
2014-06-22 23:24:49 +03:00
Stanislav Atanasov
2ee8b738e5 [ticket/12690] Find a space
Lost a spce there ... found it ...

PHPBB3-12690
2014-06-22 23:22:15 +03:00
PayBas
5bbcc39b66 [ticket/12562] Add max-width to proSilver
PHPBB3-12562
2014-06-22 22:11:39 +02:00
Crizzo
c4e48ed0b9 [ticket/12563] Adds &laquo; and &raquo; to the links in acp_styles.php
PHPBB3-12563
2014-06-22 22:02:46 +02:00
Dhruv
f0e115fdcc [ticket/11528] Change NULL to null
PHPBB3-11528
2014-06-23 01:26:22 +05:30
Dhruv
a92c1d1ec0 [ticket/11528] Fix spaces and slashes as per guidelines
PHPBB3-11528
2014-06-23 01:26:21 +05:30
Dhruv
f5aa9732d1 [ticket/11528] Add asserts in installation steps
PHPBB3-11528
2014-06-23 01:26:19 +05:30
Dhruv
2d1a998003 [ticket/11528] Use 'use' keyword to import classes to current scope
PHPBB3-11528
2014-06-23 01:26:18 +05:30
Dhruv
c26fa6a15b [ticket/11528] Move parent::tearDown() to end of tearDown()
PHPBB3-11528
2014-06-23 01:26:17 +05:30
Dhruv
019b345171 [ticket/11528] Call parent::tearDown in overrided tearDown method
PHPBB3-11528
2014-06-23 01:26:16 +05:30
Dhruv
648cbbd9a0 [ticket/11528] Instantiate $client, $driver from functional test case
Make mink test case an abstract class, instantiate $driver, $client
from its child class i.e. functional test case.

PHPBB3-11528
2014-06-23 01:26:14 +05:30
Dhruv
01f350a614 [ticket/11528] Refactor install_board() code into a new class
PHPBB3-11528
2014-06-23 01:26:13 +05:30
Dhruv
0ebf6011b7 [ticket/11528] Add behat/mink and mink-goutte-driver as dependency
PHPBB3-11528
2014-06-23 01:26:02 +05:30
Stanislav Atanasov
dc5e2f5d9a [ticket/12696] Naming convention changes
Some changes propsed by nickvergessen

PHPBB3-12696
2014-06-22 22:21:52 +03:00
Stanislav Atanasov
d387d08db3 [ticket/12696] A small error with events.md perms
docs/events.md was in 755 changed to 644

PHPBB3-12696
2014-06-22 22:21:52 +03:00
Stanislav Atanasov
641f8f6121 [ticket/12696] Add events to evets.md
Add events in documentation

PHPBB3-12696
2014-06-22 22:21:52 +03:00
Stanislav Atanasov
cfae4ed0eb [ticket/12696] Add prosilver ucp_register
Add events to prosilver ucp_register

PHPBB3-12696
2014-06-22 22:21:52 +03:00
Stanislav Atanasov
6afd09fcb0 [ticket/12696] Add events to ucp_register.html
Add events to UCP Register template:
ucp_register_before - add before start of registration form fields
ucp_register_after - add after end of registration form fileds
ucp_register_passowrd_after - add event after passowrd field
ucp_register_language_before - add event before language selector
ucp_register_profiles_before - add event just before begining of
registration profile informatiom

All events are inside the registration form fieldset.
All events are inside the registration form

Justification:

Add abbility of extension author to include custom
checks or fields inside the registration form.
Like age check field/verification.

PHPBB3-12696
2014-06-22 22:21:52 +03:00
Mario Skouat
a487fab0ea [ticket/12714] Move "allow all forums" in its own dd-element
PHPBB3-12714
2014-06-22 21:13:42 +02:00
Stanislav Atanasov
152d5fc263 [ticket/12701] Add change
Change back to since
Add change

PHPBB3-12701
2014-06-22 22:07:04 +03:00
Stanislav Atanasov
165c5f8f15 [ticket/12701] Rmove before event and expand modify_data
Removing core.user_add_before
Adding $user_row and $cp_data to core.user_add_modify_data

PHPBB3-12701
2014-06-22 22:07:04 +03:00
Stanislav Atanasov
dd075e4bbc [ticket/12701] Add events to user_add function
Add two new events to user_add function
in ./includes/functions_user.php.

core.user_add_before - allow modification of
submitted to function data.
Returns:
@var array $user_row - user_row array - User array
@var array $cp_data - cp_data array - CPF array

core.user_add_after - return user_id, user_row and
cp_data after user registration
Returns:
@var int $user_id - user_id of the new user
@var array $user_row - user_row array - User array
@var array $cp_data - cp_data array - CPF array

Justification:
Allow extensions to parse data before and after
creation of the user.

PHPBB3-12701
2014-06-22 22:07:04 +03:00
Stanislav Atanasov
992fb8e452 [ticket/12691] Comment change
Change a bit the core event comment

PHPBB3-12691
2014-06-22 22:03:01 +03:00
Stanislav Atanasov
e8dd7904e9 [ticket/12691] Change event to core.delete_pm_before
Just a requested change by nickvergessen

PHPBB3-12691
2014-06-22 22:03:00 +03:00
Stanislav Atanasov
cd31aea4be [ticket/12691] Add core.delete_pm to funtion delete_pm
Add core.delete_pm to funtion delete_pm.
Event will return:
int $user_id - ID of the user requested the message delete
array $msg_ids - array of all messages to be deleted
int $folder_id - ID of the user folder where the messages are stored
Justification:
Allow extensions to capture this event
and act as intended by ext author

PHPBB3-12691
2014-06-22 22:03:00 +03:00
Stanislav Atanasov
85b37a5f4d [ticket/12690] Remove $msg_id and chmod
Remove inneded $msg_id
Chmod file to 644

PHPBB3-12690
2014-06-22 21:54:51 +03:00
Stanislav Atanasov
9c6f74daff [ticket/12690] Add other info to core.submit_pm_after
Added $mode
Added $subject
Added $data
Added $pm_data

PHPBB3-12690
2014-06-22 21:54:51 +03:00
Stanislav Atanasov
e05df3bf3d [ticket/12690] Add core.submit_pm_after event
Add core.submit_pm_after to funtion submit_pm.
Event will return just submited msg_id. It should be plased
just before return $data['msg_id'];

Justification:
Using only core.submit_pm_before does not allow to
follow up after message submission.
The message ID is recieved at DB submission.
Some times we need the MSG_ID as identifier

PHPBB3-12690
2014-06-22 21:54:51 +03:00
Joas Schilling
80ac276971 Merge pull request #2530 from PayBas/ticket/12646
[ticket/12646] Add data-# attribute to breadcrumb links

* PayBas/ticket/12646:
  [ticket/12646] Changed to navlinks.MICRODATA
  [ticket/12646] Add check for navlinks.FORUM_ID
  [ticket/12646] Changed index/home data attr & updated subsilver
  [ticket/12646] Add data-f attribute to breadcrumb links
2014-06-22 20:50:23 +02:00
Joas Schilling
b41a730471 Merge pull request #2635 from PayBas/ticket/12758
[ticket/12758] Add show_results var to core.search_modify_rowset

* PayBas/ticket/12758:
  [ticket/12758] Add @changed to doc block
  [ticket/12758] Add show_results var to core.search_modify_rowset
2014-06-22 20:42:14 +02:00
Joas Schilling
d421187cb6 Merge pull request #2638 from VSEphpbb/ticket/12332
[ticket/12332] Fix plupload attachments with long names

* VSEphpbb/ticket/12332:
  [ticket/12332] Fix plupload attachments with long names overflow
2014-06-22 20:38:22 +02:00
Joas Schilling
92a385dea6 Merge pull request #2617 from hanakin/ticket/12740
[ticket/12740] Use .logo instead of #logo in css

* hanakin/ticket/12740:
  [ticket/12740] Use class for logo in css
2014-06-22 20:10:13 +02:00
Joas Schilling
eddf77d2c2 Merge pull request #2632 from Dragooon/ticket/12753
[ticket/12753] Add invalid chars string for ALPHA_DOTS and ALPHA_PUNCTUAION

* Dragooon/ticket/12753:
  [ticket/12753] Add invalid chars string for ALPHA_DOTS and ALPHA_PUNCTUATION
2014-06-22 20:00:19 +02:00
Matt Friedman
bd7fdb32cf [ticket/12332] Fix plupload attachments with long names overflow
PHPBB3-12332
2014-06-22 10:58:00 -07:00
Joas Schilling
7afc13b4db Merge pull request #2615 from Dragooon/ticket/12730
[ticket/12730] Add Google+ profile field

* Dragooon/ticket/12730:
  [ticket/12730] Update Google+ button class to use proper identification
  [ticket/12730] Update maxlen for type_googleplus to 255
  [ticket/12730] Fix type_googleplus_test to use same validation rule as the field
  [ticket/12730] Update field_length to be 20 by default for Google+
  [ticket/12730] Google+ field_order should be 13
  [ticket/12730] Switch service name to googleplus for type_googleplus
  [ticket/12730] Restore field_length to 10 for type_googleplus
  [ticket/12730] Add functional test for Google+ field
  [ticket/12730] Value shouldn't be escaped for schema_data.sql
  [ticket/12730] Missing newline at type_googleplus_test.php
  [ticket/12730] Set field_active to 1 for Google+ field
  [ticket/12730] Add unit test for type_googleplus
  [ticket/12730] Add missing brackets to type_googleplus.php
  [ticket/12730] Update field_order for Google+ CPF
  [ticket/12730] Use string template for Google+ CPF instead of a new one
  [ticket/12730] Minor formatting fixes
  [ticket/12730] Incorrect indentation for type_googleplus
  [ticket/12730] Spaces in block header
  [ticket/12730] Add a Google+ field by default
  [ticket/12730] Add Google+ profile field type
2014-06-22 19:40:56 +02:00
Matt Friedman
d3db8b6565 [ticket/12728] Adjust .postimage sizing to 100%
PHPBB3-12728
2014-06-22 10:36:12 -07:00
Joas Schilling
dc7ed58bf5 [ticket/12747] Remove some methods which are not used anymore
PHPBB3-12747
2014-06-22 19:31:40 +02:00
Andreas Fischer
afe9d3c3f3 Merge pull request #2630 from Nicofuma/ticket/12723
[ticket/12723] Add Sniff ensuring PHP files use the correct file header

* Nicofuma/ticket/12723:
  [ticket/12723] Do not mention too many details on documentation.
  [ticket/12723] Do not reference the coding guidelines section.
  [ticket/12757] Add a Code Sniffer ruleset for PHP files of phpBB extensions
  [ticket/12723] Properly describe new Code Sniffer rulsets.
  [ticket/12723] Use core suffix in filename instead of phpbb in the middle.
  [ticket/12723] Add Sniff ensuring PHP files use the correct file header
2014-06-22 11:35:13 +02:00
PayBas
e5b7414589 [ticket/12758] Add @changed to doc block
PHPBB3-12758
2014-06-22 10:23:41 +02:00
PayBas
22966927ea [ticket/12758] Add show_results var to core.search_modify_rowset
PHPBB3-12758
2014-06-22 02:43:24 +02:00
Tristan Darricau
fdcc544ae6 Merge pull request #1 from bantu/ticket/12723
Ticket/12723
2014-06-22 02:09:32 +02:00
Andreas Fischer
ddb35531ac [ticket/12723] Do not mention too many details on documentation.
PHPBB3-12723
2014-06-22 01:49:59 +02:00
Andreas Fischer
e10bf39d08 [ticket/12723] Do not reference the coding guidelines section.
PHPBB3-12723
2014-06-22 01:42:43 +02:00
Andreas Fischer
900a5b07c4 [ticket/12757] Add a Code Sniffer ruleset for PHP files of phpBB extensions
PHPBB3-12757
2014-06-22 01:33:13 +02:00
Andreas Fischer
82c43e258b [ticket/12723] Properly describe new Code Sniffer rulsets.
PHPBB3-12723
2014-06-22 01:20:49 +02:00
Andreas Fischer
e7c6da2c54 [ticket/12723] Use core suffix in filename instead of phpbb in the middle.
PHPBB3-12723
2014-06-22 01:19:02 +02:00
Tristan Darricau
32a2c95f90 [ticket/12723] Add Sniff ensuring PHP files use the correct file header
PHPBB3-12723
2014-06-22 00:45:34 +02:00
Andreas Fischer
566615fa31 Merge pull request #2634 from Nicofuma/ticket/12756
[ticket/12756] Fix mysqli_fetch_assoc on hhvm

* Nicofuma/ticket/12756:
  [ticket/12756] Fix mysqli_fetch_assoc on hhvm
2014-06-22 00:38:36 +02:00
Tristan Darricau
89a7a55190 [ticket/12756] Fix mysqli_fetch_assoc on hhvm
PHPBB3-12756
2014-06-21 16:50:17 +02:00
Marc Alexander
0499655ba4 [ticket/12755] Add timeout to remote upload to prevent infinite loop
PHPBB3-12755
2014-06-21 11:55:54 +02:00
Joas Schilling
40d264654c Merge pull request #2631 from Nicofuma/ticket/12752
[ticket/12752] Cron list tests fail on windows with ansi support

* Nicofuma/ticket/12752:
  [ticket/12752] Cron list tests fail on windows with ansi support
2014-06-21 00:40:55 +02:00
Shitiz Garg
6b90a0d095 [ticket/12753] Add invalid chars string for ALPHA_DOTS and ALPHA_PUNCTUATION
PHPBB3-12753
2014-06-21 04:03:43 +05:30
Shitiz Garg
d4679e6a95 [ticket/12730] Update Google+ button class to use proper identification
PHPBB3-12730
2014-06-21 03:55:09 +05:30
Shitiz Garg
e51a5791dd [ticket/12730] Update maxlen for type_googleplus to 255
PHPBB3-12730
2014-06-21 03:51:08 +05:30
Shitiz Garg
ff057dfc8e [ticket/12730] Fix type_googleplus_test to use same validation rule as the field
PHPBB3-12730
2014-06-21 03:49:59 +05:30
Shitiz Garg
72f3ff2dcc [ticket/12730] Update field_length to be 20 by default for Google+
PHPBB3-12730
2014-06-21 03:48:23 +05:30
Shitiz Garg
4b49d451aa [ticket/12730] Google+ field_order should be 13
PHPBB3-12730
2014-06-21 03:42:38 +05:30
Shitiz Garg
985dbd4482 [ticket/12730] Switch service name to googleplus for type_googleplus
PHPBB3-12730
2014-06-21 03:35:19 +05:30
Shitiz Garg
83966a575b [ticket/12730] Restore field_length to 10 for type_googleplus
PHPBB3-12730
2014-06-21 03:35:19 +05:30
Shitiz Garg
ea0e073c12 [ticket/12730] Add functional test for Google+ field
PHPBB3-12730
2014-06-21 03:35:19 +05:30
Shitiz Garg
4690709212 [ticket/12730] Value shouldn't be escaped for schema_data.sql
PHPBB3-12730
2014-06-21 03:33:02 +05:30
Shitiz Garg
b50744ae09 [ticket/12730] Missing newline at type_googleplus_test.php
PHPBB3-12730
2014-06-21 03:32:34 +05:30
Shitiz Garg
9c18df8690 [ticket/12730] Set field_active to 1 for Google+ field
PHPBB3-12730
2014-06-21 03:32:34 +05:30
Shitiz Garg
30cce1ed49 [ticket/12730] Add unit test for type_googleplus
PHPBB3-12730
2014-06-21 03:31:45 +05:30
Shitiz Garg
474dc57782 [ticket/12730] Add missing brackets to type_googleplus.php
PHPBB3-12730
2014-06-21 03:31:45 +05:30
Shitiz Garg
b516da649f [ticket/12730] Update field_order for Google+ CPF
PHPBB3-12730
2014-06-21 03:31:45 +05:30
Shitiz Garg
1363dccf12 [ticket/12730] Use string template for Google+ CPF instead of a new one
PHPBB3-12730
2014-06-21 03:31:23 +05:30
Shitiz Garg
e1454ec487 [ticket/12730] Minor formatting fixes
PHPBB3-12730
2014-06-21 03:31:23 +05:30
Shitiz Garg
d15706bff5 [ticket/12730] Incorrect indentation for type_googleplus
PHPBB3-12730
2014-06-21 03:31:23 +05:30
Shitiz Garg
0e04748d7f [ticket/12730] Spaces in block header
PHPBB3-12730
2014-06-21 03:31:23 +05:30
Shitiz Garg
ab83995f44 [ticket/12730] Add a Google+ field by default
PHPBB3-12730
2014-06-21 03:31:23 +05:30
Shitiz Garg
3cebb18ce8 [ticket/12730] Add Google+ profile field type
Google+ has a "+" before a custom URL but doesn't for those which are using
their integer ID. To cover that we need to have an extra profile field

PHPBB3-12730
2014-06-21 03:29:31 +05:30
Joas Schilling
18bf45ab1b Merge pull request #2628 from Dragooon/ticket/12731
[ticket/12731] Add YouTube custom profile field

* Dragooon/ticket/12731:
  [ticket/12731] Add functional test for youtube field
  [ticket/12731] Set field_active to 1 for YouTube field
  [ticket/12731] Add YouTube custom profile field

Conflicts:
	phpBB/install/schemas/schema.json
	phpBB/install/schemas/schema_data.sql
	phpBB/language/en/memberlist.php
	tests/functional/ucp_profile_test.php
2014-06-20 23:42:54 +02:00
Joas Schilling
3c38fcce40 Merge pull request #2621 from Dragooon/ticket/12732
[ticket/12732] Add Skype custom profile field

* Dragooon/ticket/12732:
  [ticket/12732] Update schema.json for Skype
  [ticket/12732] Add functional test for Skype profile field
  [ticket/12732] Values shouldn't be escaped for schema_data.sql
  [ticket/12732] Set field_active to 1 for Skype's field
  [ticket/12732] Add unit tests for ALPHA_PUNCTUATION
  [ticket/12732] Missing comma after validation definition
  [ticket/12732] Improve ALPHA_PUNCTUATION description
  [ticket/12732] Use user info instead of chat as default Skype action
  [ticket/12732] Add Skype custom profile field

Conflicts:
	phpBB/install/schemas/schema.json
	phpBB/install/schemas/schema_data.sql
	phpBB/language/en/memberlist.php
	tests/functional/ucp_profile_test.php
	tests/profilefields/type_string_test.php
2014-06-20 23:39:54 +02:00
Joas Schilling
b9890c6a4c Merge pull request #2612 from Dragooon/ticket/12733
[ticket/12733] Add Twitter custom profile field

* Dragooon/ticket/12733:
  [ticket/12733] Add functional test for twitter profile field
  [ticket/12733] Values needn't be escaped for schema_data.sql
  [ticket/12733] Set field_active to 1 for Twitter
  [ticket/12733] Convert spaces to tabs
  [ticket/12733] Fix spacing for block header in profilefield_twitter.php
  [ticket/12733] Update schema.json
  [ticket/12733] Add Twitter custom profile field

Conflicts:
	phpBB/install/schemas/schema.json
	phpBB/install/schemas/schema_data.sql
	phpBB/language/en/memberlist.php
	tests/functional/ucp_profile_test.php
2014-06-20 23:37:51 +02:00
Joas Schilling
8595fee040 Merge pull request #2611 from Dragooon/ticket/12729
[ticket/12729] Add Facebook custom profile field

* Dragooon/ticket/12729:
  [ticket/12729] Add functional test for Facebook field
  [ticket/12730] Values needn't be escaped for schema_data.sql
  [ticket/12729] Set field_active as 1 for Facebook profile field
  [ticket/12729] Add unit test for ALPHA_DOTS validation
  [ticket/12729] Move ALPHA_DOTS to above ALPHA_SPACERS
  [ticket/12729] Convert spaces to tabs
  [ticket/12729] Fix block header spacing for profilefield_facebook.php
  [ticket/12729] Update schema.json
  [ticket/12729] Unnecessary whitespace in profilefield_facebook.php
  [ticket/12729] Cleanup schema_data.sql for Facebook field
  [ticket/12729] Add Facebook custom profile field
2014-06-20 23:36:26 +02:00
Shitiz Garg
6b58f40663 [ticket/12732] Update schema.json for Skype
PHPBB3-12732
2014-06-21 01:16:37 +05:30
Tristan Darricau
0404d3b910 [ticket/12752] Cron list tests fail on windows with ansi support
PHPBB3-12752
2014-06-20 19:12:58 +02:00
Shitiz Garg
aeeaf2f6ef [ticket/12729] Add functional test for Facebook field
PHPBB3-12729
2014-06-20 21:20:04 +05:30
Shitiz Garg
51b4dc7077 [ticket/12731] Add functional test for youtube field
PHPBB3-12731
2014-06-20 21:17:23 +05:30
Shitiz Garg
10b466848a [ticket/12732] Add functional test for Skype profile field
PHPBB3-12732
2014-06-20 21:13:29 +05:30
Shitiz Garg
cdfcbfc6d0 [ticket/12733] Add functional test for twitter profile field
PHPBB3-12733
2014-06-20 21:12:02 +05:30
Shitiz Garg
27d761d08e [ticket/12730] Values needn't be escaped for schema_data.sql
PHPBB3-12730
2014-06-20 21:04:07 +05:30
Shitiz Garg
abc55dcb40 [ticket/12733] Values needn't be escaped for schema_data.sql
PHPBB3-12733
2014-06-20 21:03:04 +05:30
Shitiz Garg
01e05ccc6b [ticket/12732] Values shouldn't be escaped for schema_data.sql
PHPBB3-12732
2014-06-20 21:02:11 +05:30
hanakin
cc67f49fce [ticket/12740] Use class for logo in css
PHPBB3-12740
2014-06-20 17:25:06 +02:00
Joas Schilling
a5ca7479b2 Merge pull request #2626 from dhruvgoel92/ticket/12746
[ticket/12746] Init phpbb_dispatcher being used by delete_post()

* dhruvgoel92/ticket/12746:
  [ticket/12746] Init phpbb_dispatcher being used by delete_post()
2014-06-20 16:02:18 +02:00
Shitiz Garg
acbc0ea1f7 [ticket/12731] Set field_active to 1 for YouTube field
PHPBB3-12731
2014-06-20 19:21:57 +05:30
Shitiz Garg
03c5de594e [ticket/12731] Add YouTube custom profile field
PHPBB3-12731
2014-06-20 19:21:57 +05:30
Shitiz Garg
a4db81b379 [ticket/12733] Set field_active to 1 for Twitter
PHPBB3-12733
2014-06-20 19:21:35 +05:30
Shitiz Garg
deae22b85f [ticket/12733] Convert spaces to tabs
PHPBB3-12733
2014-06-20 19:21:35 +05:30
Shitiz Garg
04e43e2087 [ticket/12733] Fix spacing for block header in profilefield_twitter.php
PHPBB3-12733
2014-06-20 19:21:35 +05:30
Shitiz Garg
d7edf31b95 [ticket/12733] Update schema.json
PHPBB3-12733
2014-06-20 19:21:35 +05:30
Shitiz Garg
fac6ab1fd4 [ticket/12733] Add Twitter custom profile field
PHPBB3-12733
2014-06-20 19:21:35 +05:30
Shitiz Garg
c61a67503e [ticket/12732] Set field_active to 1 for Skype's field
PHPBB3-12732
2014-06-20 19:15:46 +05:30
Shitiz Garg
c23532e052 [ticket/12729] Set field_active as 1 for Facebook profile field
PHPBB3-12729
2014-06-20 19:09:17 +05:30
rxu
f850d5fa90 [ticket/12704] Improve the load time information in the footer when enabled
PR #2570 has added new constant to display load time information without
debug mode is being on (https://tracker.phpbb.com/browse/PHPBB3-12687).
This patch expands the total load time info with SQL/PHP load times,
while hiding the additional info with <abbr> element.

PHPBB3-12704
2014-06-20 20:57:32 +08:00
Shitiz Garg
fc6cb02e1f [ticket/12729] Add unit test for ALPHA_DOTS validation
PHPBB3-12729
2014-06-20 18:12:26 +05:30
Shitiz Garg
5701a4658c [ticket/12729] Move ALPHA_DOTS to above ALPHA_SPACERS
Have easier matches first for better performance

PHPBB3-12729
2014-06-20 18:10:08 +05:30
Shitiz Garg
2ba12a17b2 [ticket/12729] Convert spaces to tabs
PHPBB3-12729
2014-06-20 18:10:08 +05:30
Shitiz Garg
e127a4fcce [ticket/12729] Fix block header spacing for profilefield_facebook.php
PHPBB3-12729
2014-06-20 18:10:08 +05:30
Shitiz Garg
f310bc00a7 [ticket/12729] Update schema.json
PHPBB3-12729
2014-06-20 18:10:08 +05:30
Shitiz Garg
ab47798a3e [ticket/12729] Unnecessary whitespace in profilefield_facebook.php
PHPBB3-12729
2014-06-20 18:10:08 +05:30
Shitiz Garg
c408ac52c3 [ticket/12729] Cleanup schema_data.sql for Facebook field
PHPBB3-12729
2014-06-20 18:10:08 +05:30
Shitiz Garg
310b8af148 [ticket/12729] Add Facebook custom profile field
PHPBB3-12729
2014-06-20 18:10:08 +05:30
Shitiz Garg
9b85e4b141 [ticket/12732] Add unit tests for ALPHA_PUNCTUATION
PHPBB3-12732
2014-06-20 16:43:15 +05:30
Shitiz Garg
352f3b7e78 [ticket/12732] Missing comma after validation definition
PHPBB3-12732
2014-06-20 16:37:43 +05:30
Shitiz Garg
9d3f437149 [ticket/12732] Improve ALPHA_PUNCTUATION description
PHPBB3-12732
2014-06-20 16:37:42 +05:30
Shitiz Garg
da4b1d25a1 [ticket/12732] Use user info instead of chat as default Skype action
PHPBB3-12732
2014-06-20 16:37:42 +05:30
Shitiz Garg
28012dc9e1 [ticket/12732] Add Skype custom profile field
PHPBB3-12732
2014-06-20 16:37:42 +05:30
Joas Schilling
04164affe6 [ticket/12747] Drop support for Firebird
PHPBB3-12747
2014-06-20 12:35:42 +02:00
Dhruv
37fd00b298 [ticket/12738] Add $config to constructor in notification test
PHPBB3-12738
2014-06-20 16:01:11 +05:30
Joas Schilling
70d4ede9b2 Merge pull request #2459 from Dragooon/ticket/12514
[ticket/12514] Add tests for profile fields

* Dragooon/ticket/12514: (28 commits)
  [ticket/12514] Fix array formatting for tests
  [ticket/12514] Fix indention for type_url_test.php
  [ticket/12514] Missed a few spaces in comments
  [ticket/12514] Convert spaces to tabs
  [ticket/12514] Add a few additional tests for type_dropdown
  [ticket/12514] Add a few additional tests for type_int
  [ticket/12514] Fix some formatting for tests
  [ticket/12514] Add a few more tests for type_date
  [ticket/12514] Remove spaces in header blocks
  [ticket/12514] Use generic domain name for URL test
  [ticket/12514] Update file headers to represent the current format
  [ticket/12514] Remove get_ prefix from data providers
  [ticket/12514] Add a few more validation cases for type_string_test
  [ticket/12514] Minor fault in type_bool_test.php
  [ticket/12514] Remove tests/profiles as they're no longer required
  [ticket/12514] Fix type_int_test to correctly respect boundaries
  [ticket/12514] Multi value GET parameters are invalid for phpBB
  [ticket/12514] Add unit test for type_url custom profile field
  [ticket/12514] Add unit test for type_date custom profile field
  [ticket/12514] Add unit test for type_bool custom profile field
  ...
2014-06-20 12:14:23 +02:00
Dhruv
eeb2c128f5 [ticket/12738] Fix tests with new config object injection
PHPBB3-12738
2014-06-20 15:40:23 +05:30
Dhruv
752b5b6628 [ticket/12746] Init phpbb_dispatcher being used by delete_post()
PHPBB3-12746
2014-06-20 15:30:04 +05:30
Shitiz Garg
4472a492da [ticket/12514] Fix array formatting for tests
PHPBB3-12514
2014-06-20 14:47:20 +05:30
Shitiz Garg
3ac73a831a [ticket/12514] Fix indention for type_url_test.php
PHPBB3-12514
2014-06-20 14:41:59 +05:30
Joas Schilling
b855f5fc6a Merge pull request #2566 from marc1706/ticket/11711
[ticket/11711] Inform user of unsupported characters while posting

* marc1706/ticket/11711:
  [ticket/11711] Improve coding and comments of character check
  [ticket/11711] Reduce size of tests and also test topic titles
  [ticket/11711] Improve checks for unsupported characters and check subject
  [ticket/11711] Inform user of unsupported characters while posting
2014-06-20 10:51:58 +02:00
Joas Schilling
ccb8fd18e2 Merge pull request #2514 from prototech/ticket/12553
[ticket/12553] Right-to-left fixes.

* prototech/ticket/12553:
  [ticket/12553] Fix responsive user profile.
  [ticket/12553] Fix responsive post profile.
  [ticket/12553] Remove dropdown-trigger class from member search input.
  [ticket/12553] Fix the merge topic list.
  [ticket/12553] Fix dropdown position of live search
  [ticket/12553] Fix the responsive topic/forum lists.
  [ticket/12553] Align the text in responsive tables to the right.
  [ticket/12553] Center the responsive CP menus instead of floating right.
  [ticket/12553] Open the notification dropdown to the left.
  [ticket/12553] Fix alignment of contact icon.
  [ticket/12553] Fix incorrect alignment in ACP responsive tables.
  [ticket/12553] Align alert text to the right.
  [ticket/12553] Remove incorrect size for site logo.
  [ticket/12553] Fix links in the last post column that are not clickable.
  [ticket/12553] Align contact icons to the right.
  [ticket/12553] Move Place inline and Delete buttons left of the file name.
2014-06-20 10:37:30 +02:00
Dhruv
1a79de4214 [ticket/12738] Inject config object into content_visibility class
PHPBB3-12738
2014-06-20 13:25:45 +05:30
Tristan Darricau
8595b2ae86 [ticket/12716] Add regression test
PHPBB3-12716
2014-06-19 21:04:43 +02:00
Dhruv
517273fa0b [ticket/11528] Move related code from functions_posting to function
Move related code from functions_posting to
remove_post_from_statistic() in content_visibility.php

PHPBB3-11528
2014-06-19 23:04:03 +05:30
Andreas Fischer
99e08bffd8 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12741] Change the mode of the socket file
2014-06-19 19:32:22 +02:00
Andreas Fischer
51b2cc14f8 Merge pull request #2622 from Nicofuma/ticket/12741
[ticket/12741] Functional tests on Travis fail since php update last night

* Nicofuma/ticket/12741:
  [ticket/12741] Change the mode of the socket file
2014-06-19 19:32:21 +02:00
Tristan Darricau
f62ec14926 [ticket/12741] Change the mode of the socket file
Since php 5.4.29, by default, php-fpm creates the socket with the 0600 mode
instead of 0666.

PHPBB3-12741
2014-06-19 18:44:44 +02:00
Joas Schilling
729c353f27 [ticket/12612] Move functions from mcp.php to functions_mcp.php
PHPBB3-12612
2014-06-18 16:57:32 +02:00
Joas Schilling
de103f60e3 [ticket/12612] Move function from ucp.php to functions_user.php
PHPBB3-12612
2014-06-18 16:57:13 +02:00
Joas Schilling
7e66fa0f8d [ticket/12612] Move functions from memberlist.php to functions_display.php
PHPBB3-12612
2014-06-18 16:56:44 +02:00
Joas Schilling
73c69cc653 [ticket/12612] Move functions from posting.php to functions_posting.php
PHPBB3-12612
2014-06-18 16:56:29 +02:00
Shitiz Garg
f076b43915 [ticket/12514] Missed a few spaces in comments
PHPBB3-12514
2014-06-18 18:18:15 +05:30
Shitiz Garg
d1f517ad65 [ticket/12514] Convert spaces to tabs
PHPBB3-12514
2014-06-18 17:54:15 +05:30
Shitiz Garg
9f478de2ca [ticket/12514] Add a few additional tests for type_dropdown
PHPBB3-12514
2014-06-18 17:48:56 +05:30
Shitiz Garg
566f76a6b0 [ticket/12514] Add a few additional tests for type_int
PHPBB3-12514
2014-06-18 17:48:47 +05:30
Shitiz Garg
e820143e87 [ticket/12514] Fix some formatting for tests
PHPBB3-12514
2014-06-18 01:48:34 +05:30
Shitiz Garg
f549a6ce9f [ticket/12514] Add a few more tests for type_date
PHPBB3-12514
2014-06-18 01:40:40 +05:30
Shitiz Garg
aee20bcf0c [ticket/12514] Remove spaces in header blocks
PHPBB3-12514
2014-06-18 01:25:04 +05:30
Shitiz Garg
934db6ded1 [ticket/12514] Use generic domain name for URL test
PHPBB3-12514
2014-06-18 01:17:10 +05:30
Shitiz Garg
5fc51fd7b7 [ticket/12514] Update file headers to represent the current format
PHPBB3-12514
2014-06-18 01:13:28 +05:30
Shitiz Garg
c15ab1e87e [ticket/12514] Remove get_ prefix from data providers
PHPBB3-12514
2014-06-18 01:11:21 +05:30
Shitiz Garg
80d9e4b2e3 [ticket/12514] Add a few more validation cases for type_string_test
PHPBB3-12514
2014-06-18 01:05:57 +05:30
Andreas Fischer
5964ca21c2 Merge pull request #2525 from Nicofuma/ticket/12638
[ticket/12638] v30x\local_url_bbcode break the migrations if we don't use the auto updater

* Nicofuma/ticket/12638:
  [ticket/12638] Use require if phpbb_require_updated isn't available
2014-06-17 21:04:47 +02:00
Andreas Fischer
82cf239294 Merge pull request #2610 from brunoais/ticket/12699
[Ticket/12699] Remove magic numbers in the message textarea keydown callback

* brunoais/ticket/12699:
  [ticket/12699] Replace magic numbers for the TAB and for ENTER keydown
  [ticket/12699] Add tab key to keymap
2014-06-17 18:13:12 +02:00
brunoais
e1b72c0b86 [ticket/12699] Replace magic numbers for the TAB and for ENTER keydown
Replaced the magic numbers 9 and 13 in the keydown for the text editor
with constants in the existing keymap for phpBB.

PHPBB3-12699
2014-06-17 17:07:32 +01:00
Shitiz Garg
d38816fc14 [ticket/12514] Minor fault in type_bool_test.php
Had a double new line before get_profile_value_data

PHPBB3-12514
2014-06-17 15:09:13 +05:30
Shitiz Garg
70db69cb8c [ticket/12514] Remove tests/profiles as they're no longer required
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
2fc5c51d9a [ticket/12514] Fix type_int_test to correctly respect boundaries
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
995690e192 [ticket/12514] Multi value GET parameters are invalid for phpBB
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
165d7c4b98 [ticket/12514] Add unit test for type_url custom profile field
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
8be079bd66 [ticket/12514] Add unit test for type_date custom profile field
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
6534e13c33 [ticket/12514] Add unit test for type_bool custom profile field
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
e08a4eaf9a [ticket/12514] Cleanup for type_dropdown_test.php
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
87729c81fc [ticket/12514] Add newline at the end of file for type_dropdown_test.php
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
e8a6fee743 [ticket/12514] Move requires to the top of the files
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
86754cf572 [ticket/12514] Use @return null instead of @return void
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
cee46f2405 [ticket/12514] Add unit test for drop down type custom profile field
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
3cb04756bf [ticket/12514] custom_string_test is no longer required
PHPBB3-12514
2014-06-17 14:59:25 +05:30
Shitiz Garg
16f6edc02a [ticket/12514] Add unit test for type_string and type_string_common field types
PHPBB3-12514
2014-06-17 14:59:25 +05:30
Shitiz Garg
b1da3e9c7e [ticket/12514] Add test for "int" type custom profile field
PHPBB3-12514
2014-06-17 14:59:25 +05:30
Dhruv Goel
7ee3e3f73f Merge pull request #2588 from nickvergessen/ticket/12705
Ticket/12705 Fix make_clickable when called with different server_urls
2014-06-17 14:56:55 +05:30
Matt Friedman
09de0c3df9 [ticket/12728] Enforce box model sizing on image attachment thumbnails
PHPBB3-12728
2014-06-16 17:53:09 -07:00
Andreas Fischer
89af115071 Merge pull request #2603 from Nicofuma/ticket/12721
[ticket/12721] Improve the code sniffer: simple rules

* Nicofuma/ticket/12721:
  [ticket/12721] Update rules descriptions
  [ticket/12721] Add Generic.NamingConventions.ConstructorName in strict
  [ticket/12721] Add Squiz.Functions.LowercaseFunctionKeywords in legacy
  [ticket/12721] Add Squiz.ControlStructures.ForLoopDeclaration in legacy
  [ticket/12721] Add Squiz.ControlStructures.ForEachLoopDeclaration
  [ticket/12721] Add Squiz.ControlStructures.ElseIfDeclaration in legacy
  [ticket/12721] Add Generic.Functions.OpeningFunctionBraceBsdAllman
  [ticket/12721] Add Squiz.Arrays.ArrayBracketSpacing in the legacy ruleset
  [ticket/12721] Add Generic.Files.LowercasedFilename in the legacy ruleset
2014-06-17 00:42:39 +02:00
Tristan Darricau
afcca62784 [ticket/12721] Update rules descriptions
PHPBB3-12721
2014-06-16 23:07:28 +02:00
Tristan Darricau
6b52155a2a [ticket/12721] Add Generic.NamingConventions.ConstructorName in strict
PHPBB3-12721
2014-06-16 22:35:46 +02:00
Tristan Darricau
13c03b6fcf [ticket/12721] Add Squiz.Functions.LowercaseFunctionKeywords in legacy
PHPBB3-12721
2014-06-16 22:35:45 +02:00
Tristan Darricau
a94581e7ca [ticket/12721] Add Squiz.ControlStructures.ForLoopDeclaration in legacy
PHPBB3-12721
2014-06-16 22:35:44 +02:00
Tristan Darricau
99a2f2fdb4 [ticket/12721] Add Squiz.ControlStructures.ForEachLoopDeclaration
PHPBB3-12721
2014-06-16 22:35:42 +02:00
Tristan Darricau
09fc008e62 [ticket/12721] Add Squiz.ControlStructures.ElseIfDeclaration in legacy
PHPBB3-12721
2014-06-16 22:35:41 +02:00
Tristan Darricau
06bf864c41 [ticket/12721] Add Generic.Functions.OpeningFunctionBraceBsdAllman
PHPBB3-12721
2014-06-16 22:35:39 +02:00
Tristan Darricau
34a4ba36cd [ticket/12721] Add Squiz.Arrays.ArrayBracketSpacing in the legacy ruleset
PHPBB3-12721
2014-06-16 22:35:12 +02:00
Tristan Darricau
1aec0d29fd [ticket/12721] Add Generic.Files.LowercasedFilename in the legacy ruleset
PHPBB3-12721
2014-06-16 22:35:11 +02:00
Andreas Fischer
4d6afb2638 Merge pull request #2604 from Nicofuma/ticket/12722
[ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset

* Nicofuma/ticket/12722:
  [ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset
2014-06-16 22:24:59 +02:00
Tristan Darricau
ca3cdadd08 [ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset
PHPBB3-12722
2014-06-16 19:05:09 +02:00
Andreas Fischer
0b106ab0e3 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12720] Allow commit heading to begin with lowercase letters
2014-06-16 15:28:26 +02:00
Andreas Fischer
d2aee6d2ea Merge pull request #2608 from dhruvgoel92/ticket/12720
[ticket/12720] Allow commit heading to begin with lowercase letters

* dhruvgoel92/ticket/12720:
  [ticket/12720] Allow commit heading to begin with lowercase letters
2014-06-16 15:28:25 +02:00
Dhruv
6db849cba5 [ticket/12720] Allow commit heading to begin with lowercase letters
PHPBB3-12720
2014-06-16 18:55:19 +05:30
Andreas Fischer
9531691537 Merge pull request #2607 from Noxwizard/ticket/12643
Ticket/12643 Fixes deletion of columns that have the target column as a prefix

* Noxwizard/ticket/12643:
  [ticket/12643] Properly handle changing columns on tables with constraints
  [ticket/12643] Tests dropping similarly named columns
  [ticket/12643] Ensure that similarly named columns are not removed
2014-06-16 15:14:10 +02:00
Patrick Webster
754e36e378 [ticket/12643] Properly handle changing columns on tables with constraints
PHPBB3-12643
2014-06-15 19:07:32 -05:00
Andreas Fischer
663c375f5c Merge pull request #2605 from Nicofuma/ticket/12724
[ticket/12724] Add Squiz.PHP.Eval in the legacy ruleset

* Nicofuma/ticket/12724:
  [ticket/12724] Add Squiz.PHP.Eval in the legacy ruleset
2014-06-16 01:37:21 +02:00
Tristan Darricau
5a320adc75 [ticket/12724] Add Squiz.PHP.Eval in the legacy ruleset
PHPBB3-12724
2014-06-16 01:26:59 +02:00
Andreas Fischer
f27be59cf1 Merge pull request #2600 from Nicofuma/ticket/12715
[ticket/12715] Fix mistakes in the doc blocks

* Nicofuma/ticket/12715: (30 commits)
  [ticket/12715] Add missing new line in the notification manager
  [ticket/12715] Cleanup comments in \phpbb\symfony_request
  [ticket/12715] Cleanup comments in \phpbb\permissions
  [ticket/12715] Cleanup comments in \phpbb\path_helper
  [ticket/12715] Cleanup comments in \phpbb\pagination
  [ticket/12715] Cleanup comments in \phpbb\datetime
  [ticket/12715] Cleanup comments in \phpbb\content_visibility
  [ticket/12715] Cleanup comments in \phpbb\tree\*
  [ticket/12715] Cleanup comments in \phpbb\template\*
  [ticket/12715] Cleanup comments in \phpbb\plupload\*
  [ticket/12715] Cleanup comments in \phpbb\profilefields\*
  [ticket/12715] Cleanup comments in \phpbb\passwords\*
  [ticket/12715] Cleanup comments in \phpbb\notification\*
  [ticket/12715] Cleanup comments in \phpbb\mimetype\*
  [ticket/12715] Cleanup comments in \phpbb\message\*
  [ticket/12715] Cleanup comments in \phpbb\log\*
  [ticket/12715] Cleanup comments in \phpbb\lock\*
  [ticket/12715] Cleanup comments in \phpbb\groupposition\*
  [ticket/12715] Cleanup comments in \phpbb\feed\*
  [ticket/12715] Cleanup comments in \phpbb\extension\*
  ...
2014-06-16 01:12:03 +02:00
Tristan Darricau
f4ef1ab6bd [ticket/12715] Add missing new line in the notification manager
PHPBB3-12715
2014-06-16 01:01:10 +02:00
Patrick Webster
e6a8df7f7e [ticket/12643] Tests dropping similarly named columns
PHPBB3-12643
2014-06-15 14:18:39 -05:00
BorisBerdichevski
2dc389c936 [ticket/12643] Ensure that similarly named columns are not removed
PHPBB3-12643
2014-06-15 14:15:42 -05:00
Tristan Darricau
bae1724476 [ticket/12715] Cleanup comments in \phpbb\symfony_request
PHPBB3-12715
2014-06-15 19:15:23 +02:00
Tristan Darricau
1eb50c67df [ticket/12715] Cleanup comments in \phpbb\permissions
PHPBB3-12715
2014-06-15 19:15:21 +02:00
Tristan Darricau
cfa399110d [ticket/12715] Cleanup comments in \phpbb\path_helper
PHPBB3-12715
2014-06-15 19:15:18 +02:00
Tristan Darricau
9bd23917dc [ticket/12715] Cleanup comments in \phpbb\pagination
PHPBB3-12715
2014-06-15 19:15:16 +02:00
Tristan Darricau
7f3e0e5e42 [ticket/12715] Cleanup comments in \phpbb\datetime
PHPBB3-12715
2014-06-15 19:15:13 +02:00
Tristan Darricau
706484c80d [ticket/12715] Cleanup comments in \phpbb\content_visibility
PHPBB3-12715
2014-06-15 19:15:11 +02:00
Tristan Darricau
dba01c5690 [ticket/12715] Cleanup comments in \phpbb\tree\*
PHPBB3-12715
2014-06-15 19:15:09 +02:00
Tristan Darricau
0d0113e6da [ticket/12715] Cleanup comments in \phpbb\template\*
PHPBB3-12715
2014-06-15 19:15:06 +02:00
Tristan Darricau
e6b422517b [ticket/12715] Cleanup comments in \phpbb\plupload\*
PHPBB3-12715
2014-06-15 19:15:04 +02:00
Tristan Darricau
5ab6998e0e [ticket/12715] Cleanup comments in \phpbb\profilefields\*
PHPBB3-12715
2014-06-15 19:15:01 +02:00
Tristan Darricau
5dfb1cc66a [ticket/12715] Cleanup comments in \phpbb\passwords\*
PHPBB3-12715
2014-06-15 19:14:59 +02:00
Tristan Darricau
52e8359497 [ticket/12715] Cleanup comments in \phpbb\notification\*
PHPBB3-12715
2014-06-15 19:14:56 +02:00
Tristan Darricau
03ad0b3e08 [ticket/12715] Cleanup comments in \phpbb\mimetype\*
PHPBB3-12715
2014-06-15 19:14:54 +02:00
Tristan Darricau
0d0465bc08 [ticket/12715] Cleanup comments in \phpbb\message\*
PHPBB3-12715
2014-06-15 19:14:52 +02:00
Tristan Darricau
d357dd9e47 [ticket/12715] Cleanup comments in \phpbb\log\*
PHPBB3-12715
2014-06-15 19:14:49 +02:00
Tristan Darricau
d3e35149a5 [ticket/12715] Cleanup comments in \phpbb\lock\*
PHPBB3-12715
2014-06-15 19:14:47 +02:00
Tristan Darricau
51ade62400 [ticket/12715] Cleanup comments in \phpbb\groupposition\*
PHPBB3-12715
2014-06-15 19:14:44 +02:00
Tristan Darricau
df041c1086 [ticket/12715] Cleanup comments in \phpbb\feed\*
PHPBB3-12715
2014-06-15 19:14:42 +02:00
Tristan Darricau
047b709c47 [ticket/12715] Cleanup comments in \phpbb\extension\*
PHPBB3-12715
2014-06-15 19:14:40 +02:00
Tristan Darricau
1033da36a3 [ticket/12715] Cleanup comments in \phpbb\di\*
PHPBB3-12715
2014-06-15 19:14:37 +02:00
Tristan Darricau
3039d000c6 [ticket/12715] Cleanup comments in \phpbb\db\*
PHPBB3-12715
2014-06-15 19:14:35 +02:00
Tristan Darricau
4ac9315728 [ticket/12715] Cleanup comments in \phpbb\cron\*
PHPBB3-12715
2014-06-15 19:14:32 +02:00
Tristan Darricau
358a10d8a9 [ticket/12715] Cleanup comments in \phpbb\controller\*
PHPBB3-12715
2014-06-15 19:14:10 +02:00
Andreas Fischer
ad11925c77 Merge pull request #2599 from marc1706/ticket/12712
[ticket/12712] Add user_password to GROUP BY clause to fix query for mssql

* marc1706/ticket/12712:
  [ticket/12712] Remove unneeded GROUP BY clause to fix query for mssql
2014-06-15 17:44:19 +02:00
Marc Alexander
2ca9e25bf2 [ticket/12712] Remove unneeded GROUP BY clause to fix query for mssql
PHPBB3-12712
2014-06-15 17:09:07 +02:00
Tristan Darricau
8966e4a269 [ticket/12715] Update console command cron:* comments
PHPBB3-12715
2014-06-15 16:39:36 +02:00
Tristan Darricau
413754af1f [ticket/12715] Update console command config:* comments
PHPBB3-12715
2014-06-15 16:39:34 +02:00
Tristan Darricau
48b19ac37c [ticket/12715] Update console command cache:purge comments
PHPBB3-12715
2014-06-15 16:39:33 +02:00
Tristan Darricau
b6f3bf9b0c [ticket/12715] Cleanup comments in \phpbb\cache\driver\*
PHPBB3-12715
2014-06-15 16:39:31 +02:00
Tristan Darricau
569ebd1592 [ticket/12715] Cleanup comments in \phpbb\avatar\driver\*
PHPBB3-12715
2014-06-15 16:39:30 +02:00
Tristan Darricau
d7b9e33b94 [ticket/12715] Cleanup comments in \phpbb\auth\provider\*
PHPBB3-12715
2014-06-15 16:39:28 +02:00
Crizzo
05ae46acdc [ticket/12680] Still some problems with displaying the nickname in ucp
PHPBB3-12680
2014-06-15 16:13:29 +02:00
Tristan Darricau
7c51418420 [ticket/12716] Add the missing parameters in the call of clearToken
PHPBB3-12716
2014-06-15 16:10:55 +02:00
PayBas
c805e53da3 [ticket/12608] Add subSilver
PHPBB3-12608
2014-06-15 10:02:12 +02:00
PayBas
8e06d76aaa [ticket/12608] Changed get_styling() to get_style_class()
PHPBB3-12608
2014-06-15 10:02:11 +02:00
PayBas
a9e6caa775 [ticket/12608] Remove somewhat redundant reported color style
PHPBB3-12608
2014-06-15 10:02:11 +02:00
PayBas
976bda83db [ticket/12608] Improved LTR and various bugfixes
PHPBB3-12608
2014-06-15 10:02:10 +02:00
PayBas
49a1896a76 [ticket/12608] Clean up whitespace
PHPBB3-12608
2014-06-15 10:02:10 +02:00
PayBas
693cbd247c [ticket/12608] Add styling (CSS class) options to notifications
This will allow different notifications to have different styles

PHPBB3-12608
2014-06-15 10:02:09 +02:00
PayBas
72d29e76ce [ticket/12608] Updated tests
PHPBB3-12608
2014-06-15 10:02:09 +02:00
PayBas
d5f4d288e9 [ticket/12608] Improve notifications drop-down menu styling in header
PHPBB3-12608
2014-06-15 10:02:08 +02:00
Dhruv Goel
3a96c5b753 Merge pull request #2593 from bantu/ticket/12575
[ticket/12575] Cleanup service_collection_iterator
2014-06-15 13:12:42 +05:30
Dhruv Goel
587759bd6a Merge pull request #2431 from Nicofuma/ticket/12109
[ticket/12109] Bug when setting permissions with "Select all users"
2014-06-15 13:04:35 +05:30
Cesar G
44269b3660 Merge remote-tracking branch 'bantu/ticket/12711' into develop-ascraeus
* bantu/ticket/12711:
  [ticket/12711] Cast values to string such that they are quoted in SQL queries.
2014-06-14 17:41:38 -07:00
Cesar G
24bbd06d49 Merge remote-tracking branch 'PayBas/ticket/12613' into develop-ascraeus
* PayBas/ticket/12613: (25 commits)
  [ticket/12613] Add distinction between top/bottom action-bar
  [ticket/12613] Replaced topic-actions with action-bar
  [ticket/12613] Remove responsive linklist from memberlist
  [ticket/12613] Remove unnecessary checks and clean up CSS
  [ticket/12613] role="navigation" not allowed on <ul>
  [ticket/12613] Improved screen reader functionality
  [ticket/12613] Removed unnecessary checks
  [ticket/12613] Set fixed font-size
  [ticket/12613] Slightly better icons
  [ticket/12613] Typo and L_COLON
  [ticket/12613] Small inconsistency fixes
  [ticket/12613] Don't display page-jump if all pages are visible (6)
  [ticket/12613] Fixes from comments (single quotes and typos)
  [ticket/12613] Minor $bull; and <hr> fix
  [ticket/12613] Pagination should never be in responsive linklist
  [ticket/12613] Minor CSS fixes
  [ticket/12613] Dropdown-visible page-jump icon, fix focus() timing
  [ticket/12613] Renamed jump-to to page-jump to prevent confusion
  [ticket/12613] Removed form in order to prevent nested forms
  [ticket/12613] Fix functional test and post sorting bug
  ...
2014-06-14 16:30:41 -07:00
Andreas Fischer
c7ae61f2f3 [ticket/12711] Cast values to string such that they are quoted in SQL queries.
The value is stored in a text column and the key is stored in a varchar. Some
DBMSes do not like it when we insert integers into text columns. Cast both to
string to be on the safe side.

PHPBB3-12711
2014-06-15 00:21:11 +02:00
Cesar G
d310ffc26c Merge remote-tracking branch 'dhruvgoel92/ticket/12709' into develop-ascraeus
* dhruvgoel92/ticket/12709:
  [ticket/12709] Update plupload.full.min.js
2014-06-14 11:42:13 -07:00
Dhruv
34848afeb0 [ticket/12709] Update plupload.full.min.js
The earlier js file was not returning the correct list of filesAdded

PHPBB3-12709
2014-06-14 23:06:51 +05:30
Cesar G
0f034ca717 [ticket/12553] Fix responsive user profile.
PHPBB3-12553
2014-06-14 10:03:09 -07:00
Andreas Fischer
04e2fcd4d8 [ticket/12575] Just forward service_collection::offsetGet() to container.
PHPBB3-12575
2014-06-14 19:01:53 +02:00
Cesar G
c11ad7bc9d [ticket/12553] Fix responsive post profile.
PHPBB3-12553
2014-06-14 09:54:17 -07:00
Cesar G
25e58669d2 [ticket/12553] Remove dropdown-trigger class from member search input.
PHPBB3-12553
2014-06-14 09:54:17 -07:00
Cesar G
661c9f1f73 [ticket/12553] Fix the merge topic list.
PHPBB3-12553
2014-06-14 09:54:17 -07:00
Joas Schilling
925c4dc739 [ticket/12553] Fix dropdown position of live search
PHPBB3-12553
2014-06-14 09:54:17 -07:00
Cesar G
dd141d55f9 [ticket/12553] Fix the responsive topic/forum lists.
PHPBB3-12553
2014-06-14 09:54:17 -07:00
Cesar G
e17b5796bf [ticket/12553] Align the text in responsive tables to the right.
PHPBB3-12553
2014-06-14 09:54:16 -07:00
Cesar G
0f4c947a03 [ticket/12553] Center the responsive CP menus instead of floating right.
PHPBB3-12553
2014-06-14 09:54:16 -07:00
Cesar G
edd9c0e064 [ticket/12553] Open the notification dropdown to the left.
PHPBB3-12553
2014-06-14 09:54:16 -07:00
Cesar G
def39a670b [ticket/12553] Fix alignment of contact icon.
PHPBB3-12553
2014-06-14 09:54:16 -07:00
Cesar G
c0063a9e2e [ticket/12553] Fix incorrect alignment in ACP responsive tables.
PHPBB3-12553
2014-06-14 09:54:16 -07:00
Cesar G
73c2a3f177 [ticket/12553] Align alert text to the right.
PHPBB3-12553
2014-06-14 09:54:16 -07:00
Cesar G
e539fd53db [ticket/12553] Remove incorrect size for site logo.
The logo is displayed standalone, so there is no need to change the padding
from the left side to right.

PHPBB3-12553
2014-06-14 09:54:16 -07:00
Cesar G
ee9fceedff [ticket/12553] Fix links in the last post column that are not clickable.
The relative position of the <dt> is causing it to sit atop of the <dd> thus
preventing the user from clicking the links. The <dl> has a relative position
in LTR, which takes care of containing the read/unread icon link that has an
absolute position. We no longer support IE6, so removing the tweak that sets
the <dl> position to static will make everything behave the same way in RTL as
in LTR.

PHPBB3-12553
2014-06-14 09:54:16 -07:00
Cesar G
3ed767351c [ticket/12553] Align contact icons to the right.
PHPBB3-12553
2014-06-14 09:54:16 -07:00
Cesar G
55ffcca591 [ticket/12553] Move Place inline and Delete buttons left of the file name.
PHPBB3-12553
2014-06-14 09:54:16 -07:00
Dhruv Goel
b242a15af6 Merge pull request #2594 from bantu/ticket/12708
[ticket/12708] Fix install_main still linking to docs/COPYING
2014-06-14 22:06:24 +05:30
Andreas Fischer
2149bd4e8f [ticket/12575] Do not duplicate logic in service_collection_iterator.
PHPBB3-12575
2014-06-14 18:33:23 +02:00
Andreas Fischer
5f4a058655 [ticket/12708] Make the path absolute by using __DIR__.
PHPBB3-12708
2014-06-14 18:16:57 +02:00
Huynh Buu Tam
a120e4bdf6 [ticket/12708] Correct the path to the LICENSE file in install_main.
PHPBB3-12708
2014-06-14 18:16:08 +02:00
Andreas Fischer
f460287856 [ticket/12575] Workaround for offsetExists seems not required for the Iterator.
PHPBB3-12575
2014-06-14 18:06:43 +02:00
Dhruv Goel
a6e9da5a7c Merge pull request #2583 from nickvergessen/ticket/12209
[ticket/12209] Notify the admin that OAuth still allows DB authentification
2014-06-14 21:10:37 +05:30
Crizzo
8a5cb4a026 [ticket/12680] Little changes, but some issues are still there
PHPBB3-12680
2014-06-14 15:57:20 +02:00
Andreas Fischer
87a13a8c77 [ticket/12575] Pass service_collection instead of ContainerInterface.
PHPBB3-12575
2014-06-14 15:00:35 +02:00
Crizzo
ff808b341c [ticket/12563] Removes ending . from <a>
PHPBB3-12563
2014-06-14 14:31:12 +02:00
Joas Schilling
88987306de Merge pull request #2590 from bantu/ticket/12707
[ticket/12707] Do not try to load 3.1 DBMS driver name as 3.0 driver.

* bantu/ticket/12707:
  [ticket/12707] Do not try to load 3.1 DBMS driver name as 3.0 driver.
2014-06-14 13:32:51 +02:00
Andreas Fischer
21b5a52381 Merge pull request #2483 from Nicofuma/ticket/12575
[ticket/12575] Use a proxy pattern in \phpbb\di\service_collection

* Nicofuma/ticket/12575:
  [ticket/12575] Use strict comparison
  [ticket/12575] Add missing property
  [ticket/12575] Usethe new header
  [ticket/12575] Fix 2 typos in comments
  [ticket/12575] Fix typos in comments
  [ticket/12575] Skip sniffer issue triggered by the solution of a php bug
  [ticket/12575] Remove  inline assignments
  [ticket/12575] Fix the tests
  [ticket/12575] Move service_collection_iterator to its own file
  [ticket/12575] Speed up load_class()
2014-06-14 12:45:27 +02:00
Andreas Fischer
a4c75d8970 Merge pull request #2589 from nickvergessen/ticket/12706
Ticket/12706 Add languages styles and rank images to git ignore

* nickvergessen/ticket/12706:
  [ticket/12706] Ignore additional rank images
  [ticket/12706] Ignore additional languages
  [ticket/12706] Ignore additional styles
2014-06-14 12:44:31 +02:00
Andreas Fischer
0260c0ccaf [ticket/12707] Do not try to load 3.1 DBMS driver name as 3.0 driver.
PHPBB3-12707
2014-06-14 12:28:47 +02:00
Joas Schilling
102faf4d1f [ticket/12706] Ignore additional rank images
PHPBB3-12706
2014-06-14 12:08:39 +02:00
Joas Schilling
08ce6b96a4 [ticket/12706] Ignore additional languages
PHPBB3-12706
2014-06-14 12:08:15 +02:00
Joas Schilling
a620a6c5fe [ticket/12706] Ignore additional styles
PHPBB3-12706
2014-06-14 12:07:48 +02:00
Tristan Darricau
482f60f1bd [ticket/12575] Use strict comparison
PHPBB3-12575
2014-06-14 12:04:25 +02:00
Joas Schilling
f1adf82aea [ticket/12705] Store the regular expression matches based on server_url
PHPBB3-12705
2014-06-14 11:35:27 +02:00
Joas Schilling
828e995f03 [ticket/12705] Break calling make_clickable with a different server_url
PHPBB3-12705
2014-06-14 11:34:32 +02:00
Tristan Darricau
d33ed1edf6 [ticket/12575] Add missing property
PHPBB3-12575
2014-06-14 09:42:32 +02:00
Tristan Darricau
232a1c4fcb [ticket/12575] Usethe new header
PHPBB3-12575
2014-06-14 01:52:12 +02:00
Tristan Darricau
30a62d2e11 [ticket/12575] Fix 2 typos in comments
PHPBB3-12575
2014-06-14 01:45:29 +02:00
Tristan Darricau
0e4c7dbda5 [ticket/12575] Fix typos in comments
PHPBB3-12575
2014-06-14 01:45:27 +02:00
Tristan Darricau
d4cc6990e4 [ticket/12575] Skip sniffer issue triggered by the solution of a php bug
https://bugs.php.net/bug.php?id=66834
https://bugs.php.net/bug.php?id=67067

PHPBB3-12575
2014-06-14 01:45:25 +02:00
Tristan Darricau
6e47886227 [ticket/12575] Remove inline assignments
PHPBB3-12575
2014-06-14 01:45:23 +02:00
Tristan Darricau
bea9372efa [ticket/12575] Fix the tests
PHPBB3-12575
2014-06-14 01:45:21 +02:00
Tristan Darricau
a0985c7a22 [ticket/12575] Move service_collection_iterator to its own file
PHPBB3-12575
2014-06-14 01:45:19 +02:00
Tristan Darricau
a4c15bbf4f [ticket/12575] Speed up load_class()
Load the services referenced in a service_collection only when
they are used to avoid to load some unsuded services.

PHPBB3-12575
2014-06-14 01:45:17 +02:00
Andreas Fischer
7642fbbd63 Merge pull request #2527 from dhruvgoel92/ticket/11445
[ticket/11445] optimize no of queries in get_global_subscriptions( )

* dhruvgoel92/ticket/11445:
  [ticket/11445] Move get user's notification code into its own method
  [ticket/11445] Remove unused foreach key $group_name
  [ticket/11445] Improve unit tests for get_global_subscriptions
  [ticket/11445] Optimize no of queries in get_global_subscriptions
2014-06-14 00:16:52 +02:00
Joas Schilling
99c3ca18be Merge pull request #2582 from bantu/ticket/12682
[ticket/12682] Make Code Sniffer run properly on Travis CI again.

* bantu/ticket/12682:
  [ticket/12682] Make Code Sniffer run properly on Travis CI again.
2014-06-13 22:30:48 +02:00
Andreas Fischer
a262bfc78f Merge pull request #2570 from Nicofuma/ticket/12687
[ticket/12687] Add a constant to display the load time without DEBUG

* Nicofuma/ticket/12687:
  [ticket/12687] Remove french spaces
  [ticket/12687] Display the number of cached queries
  [ticket/12687] Don't check if memory_get_peak_usage() exists
  [ticket/12687] Wrap $GLOBALS['starttime'] in a if
  [ticket/12687] Fix the namespace of $request
  [ticket/12687] Update doc block
  [ticket/12687] Use microtime(true)
  [ticket/12687] Remove globals
  [ticket/12687] Return a string and move the displaying of the sql report
  [ticket/12687] Rename DISPLAY_LOAD_TIME to PHPBB_DISPLAY_LOAD_TIME
  [ticket/12687] Display the explain link only when DEBUG is set
  [ticket/12687] Add a constant to display the load time without DEBUG
2014-06-13 16:28:19 +02:00
Tristan Darricau
8e9b27314b [ticket/12687] Remove french spaces
PHPBB3-12687
2014-06-13 14:56:55 +02:00
Tristan Darricau
bbc63456f9 [ticket/12687] Display the number of cached queries
PHPBB3-12687
2014-06-13 14:55:29 +02:00
Tristan Darricau
c605e8f423 [ticket/12687] Don't check if memory_get_peak_usage() exists
PHPBB3-12687
2014-06-13 14:54:13 +02:00
PayBas
f6ee0152ed [ticket/12613] Add distinction between top/bottom action-bar
PHPBB3-12613
2014-06-13 14:53:45 +02:00
Tristan Darricau
dc4132a494 [ticket/12687] Wrap $GLOBALS['starttime'] in a if
PHPBB3-12687
2014-06-13 14:53:30 +02:00
PayBas
93c39477e0 [ticket/12613] Replaced topic-actions with action-bar
PHPBB3-12613
2014-06-13 14:38:41 +02:00
Joas Schilling
e18365dc63 [ticket/12209] Notify the admin that OAuth still allows DB authentification
PHPBB3-12209
2014-06-13 14:00:34 +02:00
Andreas Fischer
f2e57d339e [ticket/12682] Make Code Sniffer run properly on Travis CI again.
The --ignore parameter takes a case-insensitive pattern and as such
'phpBB/phpbb/*' matches any '/home/travis/build/phpbb/phpbb/...' file name.
This results in nothing being checked against ruleset-php-legacy.xml.

Using absolute paths in the --ignore pattern fixes this issues.

PHPBB3-12682
2014-06-13 13:32:19 +02:00
PayBas
f17eee19de [ticket/12613] Remove responsive linklist from memberlist
PHPBB3-12613
2014-06-13 13:29:50 +02:00
brunoais
2c70cec4fb [ticket/12699] Add tab key to keymap
PHPBB3-12699
2014-06-13 12:08:03 +01:00
Joas Schilling
309aa1d8bf Merge pull request #2580 from VSEphpbb/ticket/12697
[ticket/12697] Delete cached extension schema.json files after testing

* VSEphpbb/ticket/12697:
  [ticket/12697] Delete cached extension schema.json files after testing
2014-06-13 12:49:04 +02:00
PayBas
7c527adee8 [ticket/12613] Remove unnecessary checks and clean up CSS
PHPBB3-12613
2014-06-13 12:25:02 +02:00
Tristan Darricau
f7f65fe6c2 [ticket/12687] Fix the namespace of $request
PHPBB3-12687
2014-06-13 00:03:27 +02:00
Matt Friedman
be54b64893 [ticket/12697] Delete cached extension schema.json files after testing
PHPBB3-12697
2014-06-12 14:57:32 -07:00
Tristan Darricau
d70554760f [ticket/12687] Update doc block
PHPBB3-12687
2014-06-12 23:43:01 +02:00
Tristan Darricau
b93269f7bb [ticket/12687] Use microtime(true)
PHPBB3-12687
2014-06-12 23:35:55 +02:00
Tristan Darricau
6c0fd61b1d [ticket/12687] Remove globals
PHPBB3-12687
2014-06-12 23:27:19 +02:00
Crizzo
453cb70963 [ticket/12563] Removes strintf in acp_styles.php and shorts up <a>
PHPBB3-12563
2014-06-12 19:19:46 +02:00
Tristan Darricau
ceef85ee0e [ticket/12687] Return a string and move the displaying of the sql report
PHPBB3-12687
2014-06-12 14:33:00 +02:00
Marc Alexander
204904441a [ticket/9801] Allow display of page outside board directory on viewonline
Until now, the preg_match didn't take into account that a page might be
outside the board directory. After this change, the regular expression will
allow preceding dots and slashes. Paths like ../../test.php will be allowed.
The page will be unknown in viewonline.php and it will revert to index.php as
current page. However, the core.viewonline_overwrite_location event will
receive proper info of the page the user is on right now allowing a listener
to change the info that is being displayed.

PHPBB3-9801
2014-06-11 23:34:51 +02:00
Dhruv Goel
1fdb47bb20 Merge pull request #2577 from marc1706/ticket/12694
[ticket/12694] Remove whitespace at end of line from acp_groups
2014-06-11 22:43:06 +05:30
Marc Alexander
afbf4ba296 [ticket/12694] Remove whitespace at end of line from acp_groups
PHPBB3-12694
2014-06-11 19:03:36 +02:00
Nils Adermann
694f8391c9 Merge remote-tracking branch 'github-marc1706/ticket/12352' into develop-ascraeus
* github-marc1706/ticket/12352: (33 commits)
  [ticket/12352] Do not check hashes that don't have the necessary length
  [ticket/12352] Update file headers to fit new format
  [ticket/12352] Use custom provider collection for auth providers
  [ticket/12352] Add checks for existing user_pass_convert to migrations
  [ticket/12352] Remove usages of user_pass_convert column
  [ticket/12352] Update schema json file
  [ticket/12352] Remove user_pass_convert column from database
  [ticket/12352] Check each newly added passwords driver in manager_test
  [ticket/12352] Add get_settings_only method to passwords driver base
  [ticket/12352] Add passwords driver for xenforo 1.0, 1.1 passwords
  [ticket/12352] Add tests for wcf1 and wcf2 drivers
  [ticket/12352] Add driver for woltlab community framework 1 passwords
  [ticket/12352] Add driver for woltlab community framework 2 passwords
  [ticket/12352] Add missing $ to md5_mybb and md5_vb driver
  [ticket/12352] Fix spacing in passwords tests
  [ticket/12352] Add passwords driver for vB passwords
  [ticket/12352] Use correct hashing method in md5_mybb driver
  [ticket/12352] Add driver for myBB md5 passwords
  [ticket/12352] Rename phpbb2_md5 driver to fit filenames of other drivers
  [ticket/12352] Add passwords driver for sha1 password hashes
  ...
2014-06-11 14:27:57 +02:00
Tristan Darricau
06e6c91513 [ticket/12687] Rename DISPLAY_LOAD_TIME to PHPBB_DISPLAY_LOAD_TIME
PHPBB3-12687
2014-06-11 14:27:11 +02:00
Marc Alexander
e1f371d14a Merge remote-tracking branch 'nickvergessen/ticket/12483' into develop-ascraeus
* nickvergessen/ticket/12483:
  [ticket/12483] Fix selectors for installing extensions in functional tests
  [ticket/12483] Remove unused globals
  [ticket/12483] Fix finder usage when generating the schema.json file
  [ticket/12483] Fix copyright in prepare_extension.sh
  [ticket/12483] Use file_put_contents()
  [ticket/12483] Close database connection when tearDown() is called
  [ticket/12483] Require the extension manager class
  [ticket/12483] Move schema files into tmp/ and only copy them when needed
  [ticket/12483] Add a .sh that moves an extension in place
  [ticket/12483] Allow to setup extensions before database and functional tests
2014-06-11 09:27:12 +02:00
Marc Alexander
cab1f2cf16 Merge remote-tracking branch 'nickvergessen/ticket/12688' into develop-ascraeus
* nickvergessen/ticket/12688:
  [ticket/12688] Correctly use web root path instead of phpbb root path
2014-06-10 22:12:01 +02:00
Joas Schilling
d7ebc2c1fc [ticket/12688] Correctly use web root path instead of phpbb root path
PHPBB3-12688
2014-06-10 21:24:24 +02:00
Joas Schilling
e71f65c2bb [ticket/12099] Fix correction in path_helper test
PHPBB3-12099
2014-06-10 21:06:36 +02:00
Joas Schilling
916db1a0b1 [ticket/12483] Fix selectors for installing extensions in functional tests
PHPBB3-12483
2014-06-10 20:30:07 +02:00
Crizzo
3a48f76558 [ticket/12563] Changes 2 language variables to better understandable names
PHPBB3-12563
2014-06-10 20:29:30 +02:00
Joas Schilling
38c2d42304 [ticket/12483] Remove unused globals
PHPBB3-12483
2014-06-10 19:44:06 +02:00
Joas Schilling
d0766a2321 [ticket/12483] Fix finder usage when generating the schema.json file
PHPBB3-12483
2014-06-10 19:43:13 +02:00
Joas Schilling
3d347d47f2 [ticket/12483] Fix copyright in prepare_extension.sh
PHPBB3-12483
2014-06-10 19:41:38 +02:00
Joas Schilling
18d145f38f [ticket/12483] Use file_put_contents()
PHPBB3-12483
2014-06-10 19:41:37 +02:00
Joas Schilling
7b0b6a99c0 [ticket/12483] Close database connection when tearDown() is called
Similar to phpbb_database_test_case::tearDown()

PHPBB3-12483
2014-06-10 19:41:36 +02:00
Joas Schilling
13217fe3ff [ticket/12483] Require the extension manager class
PHPBB3-12483
2014-06-10 19:41:36 +02:00
Joas Schilling
5bae2911a2 [ticket/12483] Move schema files into tmp/ and only copy them when needed
PHPBB3-12483
2014-06-10 19:41:35 +02:00
Joas Schilling
709296e54a [ticket/12483] Add a .sh that moves an extension in place
PHPBB3-12483
2014-06-10 19:41:34 +02:00
Joas Schilling
997028a0ec [ticket/12483] Allow to setup extensions before database and functional tests
PHPBB3-12483
2014-06-10 19:41:34 +02:00
Crizzo
af60861cfd [ticket/12680] Removes unnessesary $user->lang from CONTACT_USER
PHPBB3-12680
2014-06-10 19:34:32 +02:00
Crizzo
02c53595b5 [ticket/12680] Adds alternativ text with new variable to contact:
PHPBB3-12680
2014-06-10 19:32:27 +02:00
Nils Adermann
9842137028 Merge remote-tracking branch 'github-nickvergessen/ticket/12508' into develop-ascraeus
* github-nickvergessen/ticket/12508:
  [ticket/12508] Ignore extensions in migration_tips dev tool
  [ticket/12508] Fix doc block
  [ticket/12508] Add new line to separate the if and foreach better
  [ticket/12508] Add a unit test for set_extensions()
  [ticket/12508] Only take a list of names for set_extensions()
  [ticket/12508] Fix class doc block
  [ticket/12508] Move \phpbb\extension\finder to \phpbb\finder
  [ticket/12508] Fix usages of the finder
  [ticket/12508] Remove extension manager from finder
2014-06-10 18:40:07 +02:00
Tristan Darricau
1e769ba87f [ticket/12687] Display the explain link only when DEBUG is set
PHPBB3-12687
2014-06-10 17:52:41 +02:00
Tristan Darricau
39b76a628b [ticket/12687] Add a constant to display the load time without DEBUG
PHPBB3-12687
2014-06-10 16:13:09 +02:00
Marc Alexander
5ee7f20f4e [ticket/11711] Improve coding and comments of character check
PHPBB3-11711
2014-06-10 15:51:25 +02:00
PayBas
ad59f371bf [ticket/12646] Changed to navlinks.MICRODATA
PHPBB3-12646
2014-06-10 12:47:31 +02:00
PayBas
a77a19af93 [ticket/12646] Add check for navlinks.FORUM_ID
PHPBB3-12646
2014-06-10 12:08:19 +02:00
Joas Schilling
0134acd53f [ticket/12508] Ignore extensions in migration_tips dev tool
PHPBB3-12508
2014-06-10 11:50:11 +02:00
Joas Schilling
c82ae94f8a [ticket/12508] Fix doc block
PHPBB3-12508
2014-06-10 11:47:43 +02:00
Joas Schilling
1e9492bcaa [ticket/12508] Add new line to separate the if and foreach better
PHPBB3-12508
2014-06-10 11:47:42 +02:00
Joas Schilling
fb3c6b94ae [ticket/12508] Add a unit test for set_extensions()
PHPBB3-12508
2014-06-10 11:47:42 +02:00
Joas Schilling
6980fbd27b [ticket/12508] Only take a list of names for set_extensions()
PHPBB3-12508
2014-06-10 11:47:41 +02:00
Joas Schilling
e1707b27ca [ticket/12508] Fix class doc block
PHPBB3-12508
2014-06-10 11:47:41 +02:00
Joas Schilling
183492b019 [ticket/12508] Move \phpbb\extension\finder to \phpbb\finder
PHPBB3-12508
2014-06-10 11:47:40 +02:00
Joas Schilling
d45c681b40 [ticket/12508] Fix usages of the finder
PHPBB3-12508
2014-06-10 11:47:39 +02:00
Joas Schilling
c20653dfbe [ticket/12508] Remove extension manager from finder
PHPBB3-12508
2014-06-10 11:47:36 +02:00
Joas Schilling
0aa6381834 Merge pull request #2569 from bantu/ticket/12664
[ticket/12664] Refactor develop/migration_tips.php into a console command.

* bantu/ticket/12664:
  [ticket/12664] Refactor develop/migration_tips.php into a console command.
2014-06-10 11:40:55 +02:00
Andreas Fischer
2964fb37e8 [ticket/12664] Refactor develop/migration_tips.php into a console command.
PHPBB3-12664
2014-06-10 01:57:59 +02:00
Joas Schilling
456ff2559a Merge pull request #2518 from Pico88/ticket/12606
[ticket/12606] Add ACP group core events

* Pico88/ticket/12606:
  [ticket/12606] Add ACP group core events
2014-06-10 00:13:11 +02:00
Joas Schilling
3a167ee801 Merge pull request #2568 from prototech/ticket/12667
[ticket/12667] Do not point viewtopic URL to unread post outside of view=unread.

* prototech/ticket/12667:
  [ticket/12667] Do not point viewtopic URL to unread post outside of view=unread
2014-06-10 00:01:30 +02:00
Crizzo
2d90c754fe [ticket/12680] Adds second alternativ text and font-size: 0 to remove text
PHPBB3-12680
2014-06-09 23:27:46 +02:00
Crizzo
f7f80a424f [ticket/12680] Adds alternative text to contact icon in viewtopic.php
PHPBB3-12680
2014-06-09 23:08:21 +02:00
Joas Schilling
771cbb2b3a Merge pull request #2434 from Nicofuma/ticket/8610
[ticket/8610] Merging topics does not handle bookmarks correctly

* Nicofuma/ticket/8610:
  [ticket/8610] Use css selector instead of xPath
  [ticket/8610] Add functional test when two topics are merged
  [ticket/8610] Throw an error when the dest topic isn't set
  [ticket/8610] Fix bookmarks when merging all the posts of a topic
  [ticket/8610] Merging topics does not handle bookmarks correctly
2014-06-09 22:57:27 +02:00
Cesar G
169a9a560d [ticket/12667] Do not point viewtopic URL to unread post outside of view=unread
PHPBB3-12667
2014-06-09 13:54:43 -07:00
Marc Alexander
65884bf2bd [ticket/11711] Reduce size of tests and also test topic titles
PHPBB3-11711
2014-06-09 18:57:05 +02:00
Marc Alexander
b8151b1299 [ticket/11711] Improve checks for unsupported characters and check subject
PHPBB3-11711
2014-06-09 18:56:13 +02:00
Pico88
74842b2354 [ticket/12606] Add ACP group core events
PHPBB3-12606
2014-06-09 18:56:04 +02:00
PayBas
86a320ff5c [ticket/12613] role="navigation" not allowed on <ul>
PHPBB3-12613
2014-06-09 18:05:53 +02:00
Nils Adermann
b6232aa9b2 Merge remote-tracking branch 'github-nickvergessen/ticket/10073' into develop-ascraeus
* github-nickvergessen/ticket/10073: (36 commits)
  [ticket/10073] Fix button descriptions
  [ticket/10073] Do not check disable boxes by default
  [ticket/10073] Store values with config_text in the ACP
  [ticket/10073] Move config values to config_text
  [ticket/10073] Fix request usage
  [ticket/10073] Deduplicate template variable names
  [ticket/10073] Get service from container
  [ticket/10073] Fix more "Contact Us" strings
  [ticket/10073] Move template code into the template
  [ticket/10073] Make contact page available when board is disabled
  [ticket/10073] Change name of the ACP module
  [ticket/10073] Deduplicate posting buttons code in ACP
  [ticket/10073] Use phpbb_validate_email to verify email address
  [ticket/10073] Add tests for new validate_email()
  [ticket/10073] Split email validation from email ban and taken checks
  [ticket/10073] Deduplicate the if statement
  [ticket/10073] Fallback to board_contact when contact page is disabled
  [ticket/10073] Remove language string from rebase conflict
  [ticket/10073] Add ACP module to add bbcode text for contact admin info
  [ticket/10073] Add new configs to the schema
  ...
2014-06-09 17:55:25 +02:00
Marc Alexander
89f7067377 [ticket/11711] Inform user of unsupported characters while posting
PHPBB3-11711
2014-06-09 17:48:06 +02:00
Joas Schilling
0c5af536f1 Merge pull request #2553 from rxu/ticket/12668
[ticket/12668] Add subforums_row to core.display_forums_modify_template_vars event

* rxu/ticket/12668:
  [ticket/12668] Add subforums_row to core.display_forums_modify_template_vars
2014-06-09 17:20:29 +02:00
rxu
1ee39d8c93 [ticket/12668] Add subforums_row to core.display_forums_modify_template_vars
Add subforums template data array to
'core.display_forums_modify_template_vars' event
to allow extensions to modify it if needed.

PHPBB3-12668
2014-06-09 22:22:54 +08:00
Joas Schilling
41a5c3bf2b Merge pull request #2554 from rxu/ticket/12669
[ticket/12669] Add core event to the function display_forums()

* rxu/ticket/12669:
  [ticket/12669] Add core event to the function display_forums()
2014-06-09 16:09:23 +02:00
Joas Schilling
223c8c4784 Merge branch 'k0nsl-ticket/12677' into develop-ascraeus
* k0nsl-ticket/12677:
  [ticket/12677] Replace ‘thread’ with ‘topic’ in functions_display comment
2014-06-09 15:43:58 +02:00
Knecht Ruprecht
4d3fcd19ac [ticket/12677] Replace ‘thread’ with ‘topic’ in functions_display comment
PHPBB3-12677
2014-06-09 15:42:14 +02:00
Dhruv
5e9cb35457 Merge branch 'develop-olympus' into develop-ascraeus
# By Andreas Fischer
# Via Andreas Fischer (1) and Dhruv Goel (1)
* develop-olympus:
  [ticket/12660] Improve check for when phpinfo() is disabled.
2014-06-09 13:23:49 +05:30
Dhruv Goel
233cdbfd66 Merge pull request #2548 from bantu/ticket/12660
[ticket/12660] Improve check for when phpinfo() is disabled.
2014-06-09 13:22:15 +05:30
Andreas Fischer
a0c442d16e [ticket/12660] Improve check for when phpinfo() is disabled.
PHPBB3-12660
2014-06-09 03:28:57 +02:00
Andreas Fischer
14d0a5f66b Merge pull request #2556 from brunoais/ticket/12672
[ticket/12672] Make tab intercept; CB for keypress only react without key mods

* brunoais/ticket/12672:
  [ticket/12672] Make tab intercept; CB for keypress only react without key mods
2014-06-09 03:04:45 +02:00
Andreas Fischer
373918583d Merge pull request #2561 from marc1706/ticket/12675
[ticket/12675] Fix code sniffer complaints introduced by recent commits

* marc1706/ticket/12675:
  [ticket/12675] Fix code sniffer complaints introduced by recent commits
2014-06-09 02:38:34 +02:00
Joas Schilling
92f43c5371 [ticket/10073] Fix button descriptions
PHPBB3-10073
2014-06-09 01:40:17 +02:00
Joas Schilling
e3c3a5d2a7 [ticket/10073] Do not check disable boxes by default
PHPBB3-10073
2014-06-09 01:36:19 +02:00
Joas Schilling
1a6d8dd94d [ticket/12099] Prepend ./ to path to fix assets
PHPBB3-12099
2014-06-09 01:10:18 +02:00
Dhruv Goel
6c1ff04ca0 Merge pull request #2555 from marc1706/ticket/11331
[ticket/11331] Inform user that double dots will be stripped from avatar paths
2014-06-09 04:38:01 +05:30
Marc Alexander
e8174f3d66 [ticket/12675] Fix code sniffer complaints introduced by recent commits
PHPBB3-12675
2014-06-09 00:51:01 +02:00
Joas Schilling
edc5908e48 [ticket/12099] Deduplicate path generation
PHPBB3-12099
2014-06-09 00:48:02 +02:00
Marc Alexander
b667923bcc Merge remote-tracking branch 'bantu/ticket/12673' into develop-ascraeus
* bantu/ticket/12673:
  [ticket/12673] IMAGETYPE_SWC might be missing when SWC is not supported.
2014-06-08 22:17:56 +02:00
Andreas Fischer
ae35c4b05c [ticket/12673] IMAGETYPE_SWC might be missing when SWC is not supported.
PHPBB3-12673
2014-06-08 16:46:55 +02:00
PayBas
8841f7f960 [ticket/12613] Improved screen reader functionality
PHPBB3-12613
2014-06-08 12:31:44 +02:00
rxu
d5865e316c [ticket/12669] Add core event to the function display_forums()
Add core event to the function display_forums()
in includes/functions_display.php to allow assigning additional template data
for every forum, f.e. additional forumrow subloops.

PHPBB3-12669
2014-06-08 16:32:28 +08:00
brunoais
f8a9eccb2a [ticket/12672] Make tab intercept; CB for keypress only react without key mods
Changed the callback of keypress inside the <textarea> for the posting
such that, if key 9 is pressed (tab character) and ctrl, shift, alt and meta
are not pressed the tab is placed. Otherwise, nothing is made and default is
not prevented.

PHPBB3-12672
2014-06-07 17:08:05 +01:00
Marc Alexander
9a02dc3e27 [ticket/11331] Inform user that double dots will be stripped from avatar paths
PHPBB3-11331
2014-06-07 16:28:03 +02:00
Dhruv
f5415619eb [ticket/11445] Move get user's notification code into its own method
PHPBB3-11445
2014-06-07 01:34:20 +05:30
Dhruv
ac74dc876c [ticket/11445] Remove unused foreach key $group_name
PHPBB3-11445
2014-06-07 01:00:09 +05:30
Andreas Fischer
fc4275ab2b Merge pull request #2543 from Nicofuma/ticket/12655
[ticket/12655] Run phpbbcli as a shell when --shell or -s is used

* Nicofuma/ticket/12655:
  [ticket/12655] Set register_container_commands as public
  [ticket/12655] Don't try to restore the definition in the help
  [ticket/12655] Fix coding style
  [ticket/12655] Make the --shell option available only for phpbbcli.php
  [ticket/12655] Fix coding style in \phpbb\console\application
  [ticket/12655] Set the arguments of \phpbb\console\application as required
  [ticket/12655] Don't require acp/common again in the commands
  [ticket/12655] Run the shell when --shell is used
2014-06-06 19:49:29 +02:00
Andreas Fischer
69e50dffae Merge pull request #2509 from Stephannos/ticket/12602
[ticket/12602] Add command to print the cron list

* Stephannos/ticket/12602:
  [ticket/12602] Fix language key removal.
  [ticket/12602] Rectify language keys.
  [ticket/12602] Fix test mistake.
  [ticket/12602] Fix language var mistakes.
  [ticket/12602] Add types, change description of cron:list.
  [ticket/12602] Fix internationalisation of cron_list.php
  [ticket/12602] Fix spaces issues.
  [ticket/12602] Coding style correction.
  [ticket/12602] Fix coding style mistakes.
  [ticket/12602] Headers updated.
  [ticket/12602] Changes to respect coding style and to factorize code.
  [ticket/12602] Cleanup tests
  [ticket/12602] Add function get_tasks.
  [ticket/12602] Correction of the output message for the cron list
  [ticket/12602] Add files to print the cron list and test files.
2014-06-06 19:43:09 +02:00
Etienne Baroux
088ce641be [ticket/12602] Fix language key removal.
PHPBB3-12602
2014-06-06 17:49:18 +02:00
Andreas Fischer
1f78ab536b Merge pull request #2552 from marc1706/ticket/12666
[ticket/12666] Use "None" for images in root of gallery avatar path

* marc1706/ticket/12666:
  [ticket/12666] Use "None" for images in root of gallery avatar path
2014-06-06 16:03:08 +02:00
Etienne Baroux
347de7f060 [ticket/12602] Rectify language keys.
PHPBB3-12602
2014-06-06 14:55:37 +02:00
PayBas
371e363c30 [ticket/12613] Removed unnecessary checks
PHPBB3-12613
2014-06-06 14:37:58 +02:00
Etienne Baroux
49beb2075b [ticket/12602] Fix test mistake.
PHPBB3-12602
2014-06-06 10:29:58 +02:00
Etienne Baroux
8f0a04f318 [ticket/12602] Fix language var mistakes.
PHPBB3-12602
2014-06-06 10:21:00 +02:00
PayBas
36b42d376e [ticket/12613] Set fixed font-size
and clean up spaces > tabs

PHPBB3-12613
2014-06-06 00:40:03 +02:00
Marc Alexander
4d24681259 [ticket/12666] Use "None" for images in root of gallery avatar path
"None" serves no real purpose right now. After this it will be used instead
of "Main" for images in the root of the gallery avatar path.

PHPBB3-12666
2014-06-05 23:28:00 +02:00
Etienne Baroux
c6999481e7 [ticket/12602] Add types, change description of cron:list.
PHPBB3-12602
2014-06-05 15:11:15 +02:00
PayBas
2d8ca3ea90 [ticket/12613] Slightly better icons
PHPBB3-12613
2014-06-05 11:01:44 +02:00
PayBas
5bd46c467b [ticket/12613] Typo and L_COLON
PHPBB3-12613
2014-06-05 10:02:16 +02:00
PayBas
087a91f628 [ticket/12613] Small inconsistency fixes
PHPBB3-12613
2014-06-05 10:02:16 +02:00
PayBas
cd326ae093 [ticket/12613] Don't display page-jump if all pages are visible (6)
PHPBB3-12613
2014-06-05 10:02:15 +02:00
PayBas
d218f707b1 [ticket/12613] Fixes from comments (single quotes and typos)
PHPBB3-12613
2014-06-05 10:02:14 +02:00
PayBas
ef435cb89d [ticket/12613] Minor $bull; and <hr> fix
PHPBB3-12613
2014-06-05 10:02:14 +02:00
PayBas
09a433be61 [ticket/12613] Pagination should never be in responsive linklist
PHPBB3-12613
2014-06-05 10:02:13 +02:00
PayBas
57a051c023 [ticket/12613] Minor CSS fixes
PHPBB3-12613
2014-06-05 09:59:37 +02:00
PayBas
27c678125a [ticket/12613] Dropdown-visible page-jump icon, fix focus() timing
Also removed outdated CSS

PHPBB3-12613
2014-06-05 09:59:36 +02:00
PayBas
c47b546bf0 [ticket/12613] Renamed jump-to to page-jump to prevent confusion
Jump-to can easily be confused with forum-jump.
Also switched the lang vars to reflect changes better

PHPBB3-12613
2014-06-05 09:59:35 +02:00
PayBas
9808b55258 [ticket/12613] Removed form in order to prevent nested forms
PHPBB3-12613
2014-06-05 09:59:35 +02:00
PayBas
f2c7890c64 [ticket/12613] Fix functional test and post sorting bug
PHPBB3-12613
2014-06-05 09:59:34 +02:00
PayBas
cd90b39a83 [ticket/12613] Removed jump-to placeholder and added .focus() check
PHPBB3-12613
2014-06-05 09:59:34 +02:00
PayBas
140ecf1c98 [ticket/12613] Removed all previous_page / next_page text links
PHPBB3-12613
2014-06-05 09:59:33 +02:00
PayBas
da1d24a1f0 [ticket/12613] Fix tests
PHPBB3-12613
2014-06-05 09:59:32 +02:00
PayBas
015ddc8fa8 [ticket/12613] Fix dropdown-up positioning
PHPBB3-12613
2014-06-05 09:59:32 +02:00
PayBas
c3b24e2005 [ticket/12613] Improved pagination
PHPBB3-12613
2014-06-05 09:59:31 +02:00
Etienne Baroux
f119e060b7 [ticket/12602] Fix internationalisation of cron_list.php
PHPBB3-12602
2014-06-05 09:12:44 +02:00
Cesar G
49c875413c Merge remote-tracking branch 'PayBas/ticket/12541' into develop-ascraeus
* PayBas/ticket/12541:
  [ticket/12541] Activate attachments tab when files are dropped into textarea

Conflicts:
	phpBB/styles/prosilver/template/forum_fn.js
2014-06-04 23:07:02 -07:00
Cesar G
e67a19a940 Merge remote-tracking branch 'PayBas/ticket/12615' into develop-ascraeus
* PayBas/ticket/12615:
  [ticket/12615] Fixed inproper clearing of .topic-actions
2014-06-04 22:59:37 -07:00
Cesar G
3c3a182f07 Merge remote-tracking branch 'PayBas/ticket/12565' into develop-ascraeus
* PayBas/ticket/12565:
  [ticket/12565] Empty anchors introduce white-space in IE11
2014-06-04 22:58:19 -07:00
Cesar G
5ae331a27a Merge pull request #2536 from PayBas/ticket/12521
[ticket/12521] Fix MCP merge topics row overflow
2014-06-04 21:54:41 -07:00
Andreas Fischer
d79ad22a21 Merge pull request #2539 from marc1706/ticket/12457
[ticket/12457] Default to first category if none is selected in gallery avatar

* marc1706/ticket/12457:
  [ticket/12457] Default to first category if none is selected in gallery avatar
2014-06-05 02:26:48 +02:00
Tristan Darricau
5b51acf245 [ticket/12655] Set register_container_commands as public
PHPBB3-12655
2014-06-05 01:03:16 +02:00
Tristan Darricau
5e9c8a0cea [ticket/12655] Don't try to restore the definition in the help
PHPBB3-12655
2014-06-05 01:00:33 +02:00
Tristan Darricau
012702307b [ticket/12655] Fix coding style
PHPBB3-12655
2014-06-05 00:21:53 +02:00
Andreas Fischer
f9c0a6b96e Merge pull request #2526 from Nicofuma/ticket/12639
[ticket/12639] Delete entry in admin-log leads to mysql-error

* Nicofuma/ticket/12639:
  [ticket/12639] Add a space in the code generated by generate_sql_keyword()
  [ticket/12639] Handle $conditions['keywords'] outside of the loop
  [ticket/12639] Don't make a copy of $marked when deleting logs in acp_logs
  [ticket/12639] Send a correct IN entry when deleting marked logs
  [ticket/12639] Use assertSame
  [ticket/12639] Remove old commented tests
  [ticket/12639] Order the results correctly in the test
  [ticket/12639] Fix tests on postgres
  [ticket/12639] Update tests to use a dataProvider
  [ticket/12639] Add a test case with an empty keywords list
  [ticket/12639] Delete entry in admin-log leads to mysql-error
2014-06-04 23:59:20 +02:00
Marc Alexander
1e7a782fb3 Merge remote-tracking branch 'prototech/ticket/12640' into develop-ascraeus
* prototech/ticket/12640:
  [ticket/12640] Preserve the active tab when previewing in posting page.
2014-06-04 23:25:48 +02:00
Tristan Darricau
ce104e2c72 [ticket/12655] Make the --shell option available only for phpbbcli.php
PHPBB3-12655
2014-06-04 22:33:05 +02:00
Etienne Baroux
442e12828b [ticket/12602] Fix spaces issues.
PHPBB3-12602
2014-06-04 21:56:55 +02:00
Tristan Darricau
99ebf4b8dd [ticket/12655] Fix coding style in \phpbb\console\application
PHPBB3-12655
2014-06-04 21:08:11 +02:00
Tristan Darricau
fb46e42ab3 [ticket/12639] Add a space in the code generated by generate_sql_keyword()
PHPBB3-12639
2014-06-04 20:22:22 +02:00
Etienne Baroux
7c22d653e9 [ticket/12602] Coding style correction.
PHPBB3-12602
2014-06-04 15:50:09 +02:00
Tristan Darricau
a14d16172c [ticket/12655] Set the arguments of \phpbb\console\application as required
PHPBB3-12655
2014-06-04 15:34:11 +02:00
Tristan Darricau
6c9518ea32 [ticket/12655] Don't require acp/common again in the commands
PHPBB3-12655
2014-06-04 14:47:00 +02:00
Tristan Darricau
5efd55a348 [ticket/12655] Run the shell when --shell is used
PHPBB3-12655
2014-06-04 14:46:40 +02:00
Etienne Baroux
5aca27e8cf [ticket/12602] Fix coding style mistakes.
PHPBB3-12602
2014-06-03 10:54:28 +02:00
Etienne Baroux
721a1d0bc4 [ticket/12602] Headers updated.
PHPBB3-12602
2014-06-03 10:50:00 +02:00
Etienne Baroux
760aa9d402 [ticket/12602] Changes to respect coding style and to factorize code.
PHPBB3-12602
2014-06-03 10:42:50 +02:00
Marc Alexander
2d47f85801 [ticket/12457] Default to first category if none is selected in gallery avatar
If any category exists, the key() function should always return the first
key of the $avatar_list array.

PHPBB3-12457
2014-06-03 00:31:17 +02:00
Tristan Darricau
f980fed5d2 [ticket/12639] Handle $conditions['keywords'] outside of the loop
PHPBB3-12639
2014-06-02 23:35:35 +02:00
Tristan Darricau
3e31764007 [ticket/12639] Don't make a copy of $marked when deleting logs in acp_logs
PHPBB3-12639
2014-06-02 23:22:36 +02:00
Tristan Darricau
5b5f3a5d0c [ticket/12639] Send a correct IN entry when deleting marked logs
PHPBB3-12639
2014-06-02 23:15:25 +02:00
Cesar G
8ba083f886 Merge remote-tracking branch 'PayBas/ticket/12566' into develop-ascraeus
* PayBas/ticket/12566:
  [ticket/12566] Also changed for ucp_pm_viewmessage.php
  [ticket/12566] "Private messages" should be "Send pivate message"
2014-06-02 13:47:37 -07:00
PayBas
0baf501569 [ticket/12566] Also changed for ucp_pm_viewmessage.php
PHPBB3-12566
2014-06-02 22:12:58 +02:00
Stephannos
71fb956498 Merge pull request #3 from Nicofuma/Stephannos-ticket/12602
[ticket/12602] Cleanup tests
2014-06-02 16:25:19 +02:00
Tristan Darricau
c3ccef10d1 [ticket/12602] Cleanup tests
PHPBB3-12602
2014-06-02 16:21:25 +02:00
Etienne Baroux
85e8d1c2ef [ticket/12602] Add function get_tasks.
PHPBB3-12602
2014-06-02 16:12:47 +02:00
Etienne Baroux
dc7be4f273 [ticket/12602] Correction of the output message for the cron list
PHPBB3-12602
2014-06-02 15:58:02 +02:00
PayBas
dc43073450 [ticket/12521] Fix MCP merge topics row overflow
PHPBB3-12521
2014-06-02 14:22:31 +02:00
PayBas
560e0f97be [ticket/12565] Empty anchors introduce white-space in IE11
PHPBB3-12565
2014-06-02 14:05:46 +02:00
PayBas
8ecb6b2aa2 [ticket/12566] "Private messages" should be "Send pivate message"
PHPBB3-12566
2014-06-02 13:36:49 +02:00
PayBas
082a6b29a9 [ticket/12541] Activate attachments tab when files are dropped into textarea
PHPBB3-12541
2014-06-02 12:42:45 +02:00
Etienne Baroux
58d7302b49 [ticket/12602] Add files to print the cron list and test files.
PHPBB3-12602
2014-06-02 12:17:37 +02:00
Marc Alexander
ac311e1b39 [ticket/12352] Do not check hashes that don't have the necessary length
This should significantly reduce the time spent on checking hashes of
passwords that should be converted.

PHPBB3-12352
2014-06-02 10:14:26 +02:00
Marc Alexander
94b2b64ca1 [ticket/12352] Update file headers to fit new format
PHPBB3-12352
2014-06-01 21:36:53 +02:00
Marc Alexander
6f5f0d6d8d [ticket/12352] Use custom provider collection for auth providers
Using this custom provider collection, we can properly check whether the
configured auth provider does exist. The method get_provider() has been added
for returning the default auth provider or the standard db auth provider if
the specified one does not exist.
Additionally, the method get_provider() will throw an RuntimeException if
none of the above exist.

PHPBB3-12352
2014-06-01 21:31:06 +02:00
Marc Alexander
306beab4cb [ticket/12352] Add checks for existing user_pass_convert to migrations
PHPBB3-12352
2014-06-01 21:31:05 +02:00
Marc Alexander
4698f6928e [ticket/12352] Remove usages of user_pass_convert column
PHPBB3-12352
2014-06-01 21:31:05 +02:00
Marc Alexander
0a1e21c17f [ticket/12352] Update schema json file
PHPBB3-12352
2014-06-01 21:31:05 +02:00
Marc Alexander
dde9201975 [ticket/12352] Remove user_pass_convert column from database
PHPBB3-12352
2014-06-01 21:31:05 +02:00
Marc Alexander
fcaae9b047 [ticket/12352] Check each newly added passwords driver in manager_test
PHPBB3-12352
2014-06-01 21:31:05 +02:00
Marc Alexander
4b3aacfd18 [ticket/12352] Add get_settings_only method to passwords driver base
PHPBB3-12352
2014-06-01 21:31:05 +02:00
Marc Alexander
f3eba6275a [ticket/12352] Add passwords driver for xenforo 1.0, 1.1 passwords
PHPBB3-12352
2014-06-01 21:31:05 +02:00
Marc Alexander
97c36b00b3 [ticket/12352] Add tests for wcf1 and wcf2 drivers
PHPBB3-12352
2014-06-01 21:31:05 +02:00
Marc Alexander
cf61d35d75 [ticket/12352] Add driver for woltlab community framework 1 passwords
PHPBB3-12352
2014-06-01 21:31:05 +02:00
Marc Alexander
2d7593995e [ticket/12352] Add driver for woltlab community framework 2 passwords
PHPBB3-12352
2014-06-01 21:31:05 +02:00
Marc Alexander
61a5fd59cf [ticket/12352] Add missing $ to md5_mybb and md5_vb driver
PHPBB3-12352
2014-06-01 21:31:05 +02:00
Marc Alexander
146d3cfe75 [ticket/12352] Fix spacing in passwords tests
PHPBB3-12352
2014-06-01 21:31:05 +02:00
Marc Alexander
c6e1b51d78 [ticket/12352] Add passwords driver for vB passwords
PHPBB3-12352
2014-06-01 21:31:05 +02:00
Marc Alexander
252a061864 [ticket/12352] Use correct hashing method in md5_mybb driver
PHPBB3-12352
2014-06-01 21:31:05 +02:00
Marc Alexander
af25aef04c [ticket/12352] Add driver for myBB md5 passwords
PHPBB3-12352
2014-06-01 21:31:05 +02:00
Marc Alexander
dc5a5a7cdf [ticket/12352] Rename phpbb2_md5 driver to fit filenames of other drivers
PHPBB3-12352
2014-06-01 21:31:05 +02:00
Marc Alexander
033272f968 [ticket/12352] Add passwords driver for sha1 password hashes
PHPBB3-12352
2014-06-01 21:31:04 +02:00
Marc Alexander
d9e49fae23 [ticket/12352] Check phpBB2 passwords that have been encrypted with phpass
PHPBB3-12352
2014-06-01 21:31:04 +02:00
Marc Alexander
b35ed3bc69 [ticket/12352] Add tests for functions in convert password driver
PHPBB3-12352
2014-06-01 21:31:04 +02:00
Marc Alexander
3508409c89 [ticket/12352] Add tests for phpBB2 md5 passwords driver
PHPBB3-12352
2014-06-01 21:31:04 +02:00
Marc Alexander
5a243af879 [ticket/12352] Add driver for phpBB2 hashes with md5 length of 32
PHPBB3-12352
2014-06-01 21:31:04 +02:00
Marc Alexander
60cb648ab0 [ticket/12352] Remove code for converting passwords in db auth provider
PHPBB3-12352
2014-06-01 21:31:04 +02:00
Marc Alexander
f78b99dce4 [ticket/12352] Add $CP$ prefix to passwords that need to be converted
Also set user_pass_convert to 0 in the process of doing so.

PHPBB3-12352
2014-06-01 21:31:04 +02:00
Marc Alexander
2a96b9e285 [ticket/12352] Use $CP$ prefix for converting passwords in manager
PHPBB3-12352
2014-06-01 21:31:04 +02:00
Marc Alexander
1e758ba7f0 [ticket/12352] Add passwords driver for passwords that should be converted
This driver will only be used for getting the new $CP$ prefix that will signal
that the hash is a legacy hash that needs to be converted.

PHPBB3-12352
2014-06-01 21:31:04 +02:00
Marc Alexander
57e4fb3810 [ticket/12352] Add tests for checking smf passwords
PHPBB3-12352
2014-06-01 21:31:04 +02:00
Marc Alexander
ed1d4fe4a0 [ticket/12352] Revert to db auth provider if default does not exist
This will make sure that we will not encounter a non-existing auth provider.
We will revert to the default db auth provider if the one set in the config
does not exist in our auth provider collection.

PHPBB3-12352
2014-06-01 21:31:04 +02:00
Marc Alexander
68f59defb0 [ticket/12352] Mark salted md5 and phpass passwords driver as legacy
PHPBB3-12352
2014-06-01 21:31:04 +02:00
Marc Alexander
ee72e7b3ad [ticket/12352] Introduce user row to passwords check methods
This will ensure that legacy hash types that might need the user row can
properly check if the supplied password is correct.

PHPBB3-12352
2014-06-01 21:31:04 +02:00
Marc Alexander
2ea45a06e7 [ticket/12352] Add legacy passwords driver for sha1 smf type passwords
PHPBB3-12352
2014-06-01 21:31:04 +02:00
PayBas
eeb077c336 [ticket/12646] Changed index/home data attr & updated subsilver
PHPBB3-12646
2014-06-01 20:59:19 +02:00
PayBas
92c7d07c65 [ticket/12646] Add data-f attribute to breadcrumb links
PHPBB3-12646
2014-06-01 20:24:01 +02:00
Dhruv
c7687ba5aa [ticket/11445] Improve unit tests for get_global_subscriptions
PHPBB3-11445
2014-06-01 13:44:09 +05:30
Dhruv
572debd0e8 [ticket/11445] Optimize no of queries in get_global_subscriptions
PHPBB3-11445
2014-06-01 13:38:37 +05:30
Tristan Darricau
8e2a0caf54 [ticket/12639] Use assertSame
PHPBB3-12639
2014-06-01 02:57:16 +02:00
Tristan Darricau
6794c6b79b [ticket/12639] Remove old commented tests
PHPBB3-12639
2014-06-01 01:59:29 +02:00
Andreas Fischer
48679eeff8 Merge pull request #2529 from prototech/ticket/12641
[ticket/12641] Use jQuery's trim() method. IE8 does not support the native one.

* prototech/ticket/12641:
  [ticket/12641] Use jQuery's trim() method. IE8 does not support the native one
2014-05-31 23:00:07 +02:00
Cesar G
6a00ff3fa6 [ticket/12641] Use jQuery's trim() method. IE8 does not support the native one
PHPBB3-12641
2014-05-31 10:56:08 -07:00
Cesar G
95b9c93892 [ticket/12640] Preserve the active tab when previewing in posting page.
PHPBB3-12640
2014-05-31 10:12:24 -07:00
Tristan Darricau
6d3bc7a60b [ticket/12639] Order the results correctly in the test
PHPBB3-12639
2014-05-31 19:00:15 +02:00
Tristan Darricau
dce7c7e0e0 [ticket/12639] Fix tests on postgres
PHPBB3-12639
2014-05-31 18:10:12 +02:00
Tristan Darricau
fd9c17ca04 [ticket/12639] Update tests to use a dataProvider
PHPBB3-12639
2014-05-31 17:42:40 +02:00
Tristan Darricau
9c497a7b46 [ticket/12639] Add a test case with an empty keywords list
PHPBB3-12639
2014-05-31 13:34:04 +02:00
Tristan Darricau
36071ded9d [ticket/12639] Delete entry in admin-log leads to mysql-error
PHPBB3-12639
2014-05-31 12:56:44 +02:00
Tristan Darricau
f7b8043b43 [ticket/12638] Use require if phpbb_require_updated isn't available
PHPBB3-12638
2014-05-31 01:54:38 +02:00
Joas Schilling
9c2687ddc9 Merge pull request #2494 from Nicofuma/ticket/12589
[ticket/12589] Search directly in $directory if it's an absolute sub-path

* Nicofuma/ticket/12589:
  [ticket/12589] Add test searching in a non absolute directory
  [ticket/12589] Fix tests
  [ticket/12589] Search directly in $directory if it's an absolute sub-path
2014-05-31 01:35:10 +02:00
Tristan Darricau
7c4bd8cc76 [ticket/8610] Use css selector instead of xPath
PHPBB3-8610
2014-05-31 00:29:42 +02:00
Andreas Fischer
f4dcb69dae [develop-ascraeus] Correct capitalisation of NeoThermic. 2014-05-31 00:25:28 +02:00
Tristan Darricau
7c16d1c2ab [ticket/12325] Fix the language var name
PHPBB3-12325
2014-05-30 23:23:01 +02:00
Joas Schilling
b92787a132 Merge pull request #2524 from bantu/ticket/12637
[ticket/12637] Correct file header in coding-guidelines

* bantu/ticket/12637:
  [ticket/12637] Fixup all incorrect uses of file header.
  [ticket/12637] Correctly escape the file header in coding-guidelines.html.
2014-05-30 23:22:49 +02:00
Joas Schilling
40218ba5e6 Merge pull request #2433 from Nicofuma/ticket/10899
[ticket/10899] Using Delete All in log viewer with keyword search

* Nicofuma/ticket/10899:
  [ticket/10899] Update doc block
  [ticket/10899] Use isset($field_value['IN'])
  [ticket/10899] Add event core.delete_log
  [ticket/10899] Remove trailing ;
  [ticket/10899] Fix typo in the class name
  [ticket/10899] Add unit tests
  [ticket/10899] Get $phpbb_log from the container
  [ticket/10899] Remove extra ';'
  [ticket/10899] Typo
  [ticket/10899] Refactoring in \phpbb\log\log_interface
  [ticket/10899] Using Delete All in log viewer with keyword search
2014-05-30 23:13:00 +02:00
Joas Schilling
be52ea882a Merge pull request #2357 from Nicofuma/ticket/11942
[ticket/11942] Delete post/topic reason should be added to logs

* Nicofuma/ticket/11942:
  [ticket/11942] Don't change the reason to '' when hard deleting
  [ticket/11942] Don't show the checkbox if the post is already soft-deleted
  [ticket/11942] Remove useless IF in templates
  [ticket/11942] Apply the modifications to subsilver
  [ticket/11942] Always display delete reason
  [ticket/11942] Edits messages
  [ticket/11942] Change the formulation
  [ticket/11942] Adding the reason to hard deleted topic/post
  [ticket/11942] Delete post/topic reason should be added to logs
2014-05-30 23:04:02 +02:00
Joas Schilling
9f87c497fe Merge pull request #2447 from n-aleha/ticket/11467
[ticket/11467] Add language variables for extension exception messages

* n-aleha/ticket/11467:
  [ticket/11467] Add user object to extension manager for tests
  [ticket/11467] Add language variables to tests
  [ticket/11467] Add language variables for extension exception messages
2014-05-30 23:01:19 +02:00
Joas Schilling
669a6c3e3d Merge pull request #2512 from bantu/ticket/11266
[ticket/11266] Better message for when composer dependencies are missing...

* bantu/ticket/11266:
  [ticket/11266] Better message for when composer dependencies are missing.
2014-05-30 22:57:43 +02:00
Joas Schilling
a6a2d1bc2d Merge pull request #2523 from bantu/ticket/12597
[ticket/12597] Command for executing all available cron tasks

* bantu/ticket/12597:
  [ticket/12597] Update USE_SYSTEM_CRON_EXPLAIN to be a bit more verbose.
  [ticket/12597] Improve language for cron:run command.
  [ticket/12597] Do not output anything besides the gif image.
2014-05-30 22:52:01 +02:00
Andreas Fischer
21c6102d55 [ticket/12637] Fixup all incorrect uses of file header.
PHPBB3-12637
2014-05-30 22:34:26 +02:00
Andreas Fischer
b372d515ff [ticket/12637] Correctly escape the file header in coding-guidelines.html.
PHPBB3-12637
2014-05-30 22:30:43 +02:00
Andreas Fischer
cc41e2eef7 [ticket/12597] Update USE_SYSTEM_CRON_EXPLAIN to be a bit more verbose.
PHPBB3-12597
2014-05-30 20:39:06 +02:00
Andreas Fischer
bbb83c09c0 Merge pull request #2508 from ptitlazy/ticket/12597
[ticket/12597] Command for executing all available cron tasks

* ptitlazy/ticket/12597: (27 commits)
  [ticket/12597] Reformating an acp message
  [ticket/12597] Modifiying acp message
  [ticket/12597] Fix wrong global variable name
  [ticket/12597] Typo correction
  [ticket/12597] Typo corrections
  [ticket/12597] Changing place of lock release in execute() method
  [ticket/12597] Fix test file
  [ticket/12597] Typing corrections and improvement of code consistency
  [ticket/12597] Fix various mistakes
  [ticket/12597] Fix various mistakes
  [ticket/12597] Fix visibilty of two functions in run.php
  [ticket/12597] Refactoring and test improving
  [ticket/12597] Fix language key name
  [ticket/12597] Fix coding style and typing mistakes
  [ticket/12597] Changes name of command  cron:run-all to cron:run.
  [ticket/12597] Fix various problems
  [ticket/12597] Fix constructor bug and servral doc blocs
  [ticket/12597] Modification of return statuses and of test files
  [ticket/12597] Fix misplaced release of db lock
  [ticket/12597] Change EXECUTE to RUN in language
  ...
2014-05-30 20:12:15 +02:00
Andreas Fischer
4d80d90f73 [ticket/12597] Improve language for cron:run command.
PHPBB3-12597
2014-05-30 19:51:11 +02:00
Andreas Fischer
a8e412e2b7 [ticket/12597] Do not output anything besides the gif image.
PHPBB3-12597
2014-05-30 19:41:49 +02:00
Joas Schilling
807e000b91 Merge branch 'prep-release-3.1.0-b4' into develop-ascraeus
* prep-release-3.1.0-b4:
  [prep-release-3.1.0-b4] Update phpBB Version for b5 development
  [prep-release-3.1.0-b4] Add changelog for 3.1.0-b4
  [prep-release-3.1.0-b4] Prepare Changelog
  [prep-release-3.1.0-b4] Add migration for 3.1.0-b4
  [prep-release-3.1.0-b4] Update version to 3.1.0-b4
2014-05-30 17:53:03 +02:00
Joas Schilling
da48b7df22 [prep-release-3.1.0-b4] Update phpBB Version for b5 development 2014-05-30 17:52:38 +02:00
Joas Schilling
f9c6297a09 [prep-release-3.1.0-b4] Add changelog for 3.1.0-b4 2014-05-30 16:33:19 +02:00
Joas Schilling
814b077864 [prep-release-3.1.0-b4] Prepare Changelog 2014-05-30 16:32:30 +02:00
Joas Schilling
0cfc0413ca [prep-release-3.1.0-b4] Add migration for 3.1.0-b4 2014-05-30 16:27:42 +02:00
Joas Schilling
b6135d3d02 [prep-release-3.1.0-b4] Update version to 3.1.0-b4 2014-05-30 16:23:44 +02:00
Joas Schilling
fda2a774b7 Merge pull request #2522 from PayBas/ticket/12621
[ticket/12621] schema.json is not up to date with migration files

* PayBas/ticket/12621:
  [ticket/12621] schema.json is not up to date with migration files
2014-05-30 16:11:18 +02:00
PayBas
5c37d28096 [ticket/12621] schema.json is not up to date with migration files
PHPBB3-12621
2014-05-30 16:07:23 +02:00
Andreas Fischer
89d296a1db Merge pull request #2520 from nickvergessen/ticket/12594
[ticket/12594] Fix file headers of new files

* nickvergessen/ticket/12594:
  [ticket/12594] Update file header in non-php files
  [ticket/12594] Fix file headers of new files
2014-05-30 15:40:37 +02:00
Joas Schilling
9f568959a9 [ticket/12594] Update file header in non-php files
PHPBB3-12594
2014-05-30 15:31:15 +02:00
Joas Schilling
634824e888 [ticket/12594] Fix file headers of new files
PHPBB3-12594
2014-05-30 15:29:10 +02:00
LEZY Thomas
fa3a634ae1 [ticket/12597] Reformating an acp message
PHPBB3-12597
2014-05-30 10:55:03 +02:00
PayBas
376d6a2d91 [ticket/12615] Fixed inproper clearing of .topic-actions
PHPBB3-12615
2014-05-30 00:11:01 +02:00
Joas Schilling
638d43d6fe [ticket/12099] Fix clean_path() ".." stripping when previous directory was "."
PHPBB3-12099
2014-05-29 23:44:10 +02:00
Joas Schilling
41e52d9c9d [ticket/12099] Break clean_path tests with a simple test
PHPBB3-12099
2014-05-29 23:44:10 +02:00
Joas Schilling
b8f3972afa [ticket/12099] Clean paths in tests
PHPBB3-12099
2014-05-29 23:44:09 +02:00
Joas Schilling
58cfdfe143 [ticket/12099] Correctly fix go back to root before prepending the root path
This allows moving app.php outside of phpBB and still work as expected

PHPBB3-12099
2014-05-29 23:44:08 +02:00
Joas Schilling
64f51bd3dd [ticket/12099] Clean some paths before using them
PHPBB3-12099
2014-05-29 23:44:08 +02:00
Joas Schilling
b378bd7a2e [ticket/12099] Fix several issues in path_helper test
PHPBB3-12099
2014-05-29 23:44:07 +02:00
Andreas Fischer
59e968cd7d Merge pull request #2513 from prototech/ticket/12614
[ticket/12614] Make the post buttons always visible.

* prototech/ticket/12614:
  [ticket/12614] Make the post buttons always visible.
2014-05-29 23:21:19 +02:00
Tristan Darricau
5762af6180 [ticket/11480] Fix typos
PHPBB3-11480
2014-05-29 22:45:34 +02:00
LEZY Thomas
9cda850b3a [ticket/12597] Modifiying acp message
Modifying an acp message in order to include the use of the command

PHPBB3-12597
2014-05-29 20:46:23 +02:00
LEZY Thomas
01dba249d7 [ticket/12597] Fix wrong global variable name
$pathEx changed to $phpEx

PHPBB3-12597
2014-05-29 18:27:00 +02:00
LEZY Thomas
43fbb84cc3 [ticket/12597] Typo correction
PHPBB3-12597
2014-05-29 18:09:42 +02:00
LEZY Thomas
3b845b1893 [ticket/12597] Typo corrections
PHPBB3-12597
2014-05-29 18:08:02 +02:00
LEZY Thomas
fda2cc636c [ticket/12597] Changing place of lock release in execute() method
PHPBB3-12597
2014-05-29 18:03:23 +02:00
Cesar G
5310838163 [ticket/12614] Make the post buttons always visible.
PHPBB3-12614
2014-05-29 08:45:22 -07:00
LEZY Thomas
2f2e404639 [ticket/12597] Fix test file
Fix bug of test_no_task that expected a message where none was supposed
to exist.

PHPBB3-12597
2014-05-29 17:40:57 +02:00
LEZY Thomas
335faafae8 Merge branch 'ticket/12597' of github.com:ptitlazy/phpbb into ticket/12597 2014-05-29 17:31:50 +02:00
LEZY Thomas
03e0e736ab [ticket/12597] Typing corrections and improvement of code consistency
PHPBB3-12597
2014-05-29 17:29:22 +02:00
LEZY Thomas
7508d2b546 [ticket/12597] Fix various mistakes
Typing mistakes
Coding style issue
Verbose mode messag

PHPBB3-12597
2014-05-29 17:26:31 +02:00
LEZY Thomas
79bdcdf988 [ticket/12597] Fix various mistakes
Typing mistakes
Coding style issue
Verbose mode messag

PHPBB3-12597
2014-05-29 17:03:34 +02:00
LEZY Thomas
c17a1e92c5 [ticket/12597] Fix visibilty of two functions in run.php
PHPBB3-12597
2014-05-29 16:59:41 +02:00
LEZY Thomas
e7fd259766 [ticket/12597] Refactoring and test improving
Adding tests of return status
Refactoring code
Adding consistency in verbose mode

PHPBB3-12597
2014-05-29 16:37:45 +02:00
Andreas Fischer
505b26ed86 [ticket/11266] Better message for when composer dependencies are missing.
PHPBB3-11266
2014-05-29 16:13:29 +02:00
Andreas Fischer
f0dcc271ac Merge pull request #2506 from brunoais/ticket/12604
[ticket/12604] Fix wrong padding when no notifications

* brunoais/ticket/12604:
  [ticket/12604] Fix wrong padding when no notifications
2014-05-29 15:42:30 +02:00
Tristan Darricau
9c8e843def [ticket/11480] Add functionnal test
PHPBB3-11480
2014-05-29 14:56:45 +02:00
Tristan Darricau
63c62f86ee [ticket/8610] Add functional test when two topics are merged
PHPBB3-8610
2014-05-29 11:48:48 +02:00
Tristan Darricau
4b3bba6693 [ticket/10899] Update doc block
PHPBB3-10899
2014-05-29 02:30:15 +02:00
Joas Schilling
6a9fd06b73 [ticket/10073] Store values with config_text in the ACP
PHPBB3-10073
2014-05-29 02:14:48 +02:00
Joas Schilling
e2e7e2a55b [ticket/10073] Move config values to config_text
PHPBB3-10073
2014-05-29 02:14:48 +02:00
Joas Schilling
1c0036f118 [ticket/10073] Fix request usage
PHPBB3-10073
2014-05-29 02:14:47 +02:00
Joas Schilling
975afa9048 [ticket/10073] Deduplicate template variable names
PHPBB3-10073
2014-05-29 02:14:46 +02:00
Joas Schilling
81f22a1c8e [ticket/10073] Get service from container
PHPBB3-10073
2014-05-29 02:14:46 +02:00
Joas Schilling
8e48840034 [ticket/10073] Fix more "Contact Us" strings
PHPBB3-10073
2014-05-29 02:14:45 +02:00
Joas Schilling
3e0f8d7f1e [ticket/10073] Move template code into the template
PHPBB3-10073
2014-05-29 02:14:45 +02:00
Joas Schilling
67281199be [ticket/10073] Make contact page available when board is disabled
PHPBB3-10073
2014-05-29 02:14:44 +02:00
Joas Schilling
c5a51efd20 [ticket/10073] Change name of the ACP module
PHPBB3-10073
2014-05-29 02:14:43 +02:00
Joas Schilling
a2ca0bc611 [ticket/10073] Deduplicate posting buttons code in ACP
PHPBB3-10073
2014-05-29 02:14:43 +02:00
Joas Schilling
427d70d138 [ticket/10073] Use phpbb_validate_email to verify email address
PHPBB3-10073
2014-05-29 02:14:42 +02:00
Joas Schilling
0108e19d21 [ticket/10073] Add tests for new validate_email()
PHPBB3-10073
2014-05-29 02:14:41 +02:00
Joas Schilling
911725a581 [ticket/10073] Split email validation from email ban and taken checks
PHPBB3-10073
2014-05-29 02:14:41 +02:00
Joas Schilling
f01e0a2eef [ticket/10073] Deduplicate the if statement
PHPBB3-10073
2014-05-29 02:14:40 +02:00
Joas Schilling
ed8c16bf0d [ticket/10073] Fallback to board_contact when contact page is disabled
PHPBB3-10073
2014-05-29 02:14:39 +02:00
Joas Schilling
d1fb8d3c9e [ticket/10073] Remove language string from rebase conflict
PHPBB3-10073
2014-05-29 02:14:38 +02:00
Joas Schilling
d3f65cd66e [ticket/10073] Add ACP module to add bbcode text for contact admin info
PHPBB3-10073
2014-05-29 02:14:38 +02:00
Joas Schilling
deee3be9ef [ticket/10073] Add new configs to the schema
PHPBB3-10073
2014-05-29 02:14:37 +02:00
Joas Schilling
4f2f3d9757 [ticket/10073] Display contact info
PHPBB3-10073
2014-05-29 02:14:36 +02:00
Joas Schilling
971b3f59bf [ticket/10073] Add configs for contact info text
PHPBB3-10073
2014-05-29 02:14:36 +02:00
Joas Schilling
1ffcbdd3c5 [ticket/10073] Fix invalid type hint
PHPBB3-10073
2014-05-29 02:14:35 +02:00
Joas Schilling
d6484a8177 [ticket/10073] Fix missing language string
PHPBB3-10073
2014-05-29 02:14:35 +02:00
Joas Schilling
299fe086b4 [ticket/10073] Fix title for "Email topic"
PHPBB3-10073
2014-05-29 02:14:34 +02:00
Joas Schilling
84a02f5cef [ticket/10073] Use get_username_string and correctly sprintf for languages
PHPBB3-10073
2014-05-29 02:14:33 +02:00
Joas Schilling
ef8d7b995e [ticket/10073] Add @config_text to admin_form
PHPBB3-10073
2014-05-29 02:14:33 +02:00
Joas Schilling
35b88624f5 [ticket/10073] Remove unneccessary todos he config switch is enough
PHPBB3-10073
2014-05-29 02:14:32 +02:00
Joas Schilling
67cf0a912c [ticket/10073] Add doc blocks to new classes
PHPBB3-10073
2014-05-29 02:14:32 +02:00
Joas Schilling
5c13829111 [ticket/10073] Fix grammar in comment
PHPBB3-10073
2014-05-29 02:14:31 +02:00
Joas Schilling
af024ea3e5 [ticket/10073] Global announcements have a forum_id now
PHPBB3-10073
2014-05-29 02:14:30 +02:00
Joas Schilling
ea9756917e [ticket/10073] Fix code sniffer complain
PHPBB3-10073
2014-05-29 02:14:30 +02:00
Joas Schilling
fffb07fd91 [ticket/10073] Use namespaces and fix all class names
PHPBB3-10073
2014-05-29 02:14:29 +02:00
Nils Adermann
6c287e57fc [ticket/10073] Add Admin contact email template
PHPBB3-10073
2014-05-29 02:14:29 +02:00
Nils Adermann
389bc0b8dd [ticket/10073] Replace board_contact mail with links to contact page
Error pages still contain the email address.

PHPBB3-10073
2014-05-29 02:14:28 +02:00
Nils Adermann
d52f34f5ec [ticket/10073] Add a contact administrators page and refactor email forms.
The message to be displayed on top of the email form cannot be configured yet.

PHPBB3-10073
2014-05-29 02:14:27 +02:00
Tristan Darricau
70f313eb4f [ticket/11942] Don't change the reason to '' when hard deleting
PHPBB3-11942
2014-05-29 00:49:12 +02:00
Andreas Fischer
624c0e4ef6 Merge pull request #2511 from Marshalrusty/ticket/12611
[ticket/12611] Remove phpBB Group copyright notice from .gifs

* Marshalrusty/ticket/12611:
  [ticket/12611] Remove phpBB Group copyright notice from .gifs
2014-05-29 00:29:44 +02:00
Joas Schilling
cae8448fe4 Merge pull request #2432 from Nicofuma/ticket/11226
[ticket/11226] filespec::move_file() should error correctly

* Nicofuma/ticket/11226:
  [ticket/11226] Explicity set file_moved to false
  [ticket/11226] Add tests
  [ticket/11226] Use $user->lang()
  [ticket/11226] filespec::move_file() should error correctly
2014-05-29 00:15:10 +02:00
n-aleha
7f00c38c50 [ticket/11467] Add user object to extension manager for tests
PHPBB3-11467
2014-05-29 01:07:44 +03:00
n-aleha
56959a2f83 [ticket/11467] Add language variables to tests
Convert the hardcoded strings to language variables.

PHPBB3-11467
2014-05-29 01:07:44 +03:00
n-aleha
031273de72 [ticket/11467] Add language variables for extension exception messages
Remove hard-coded messages and add language variables for extension
exception messages.

PHPBB3-11467
2014-05-29 01:07:44 +03:00
Joas Schilling
305be2ae64 Merge pull request #2309 from Nicofuma/ticket/11366
[ticket/11366] Extension's version's check

* Nicofuma/ticket/11366: (29 commits)
  [ticket/11366] Fix headings css in list page
  [ticket/11366] Add config value in schema_data.sql
  [ticket/11366] Fix HTML
  [ticket/11366] Exchange links and settings' form
  [ticket/11366] Remove the extra {S_FORM_TOKEN}
  [ticket/11366] Move the links to the top of the page
  [ticket/11366] Hide the version check settings by default
  [ticket/11366] Versions, options and actions heading should be centered
  [ticket/11366] Better language string for "recheck all"
  [ticket/11366] Move "recheck all" link
  [ticket/11366] Add $config['extension_force_unstable']
  [ticket/11366] Use force_cache on the list page
  [ticket/11366] Add recheck-all link
  [ticket/11366] Force the use of the cache on the list page
  [ticket/11366] Update FILE_NOT_FOUND language string
  [ticket/11366] Fix whitespaces
  [ticket/11366] Update FILE_NOT_FOUND language string
  [ticket/11366] Update var names
  [ticket/11366] Align language strings
  [ticket/11366] Fix detailed view
  ...
2014-05-28 23:46:03 +02:00
Joas Schilling
033df350d9 Merge pull request #2474 from PayBas/ticket/12561
[ticket/12561] Add "after" check to schema_generator for columns_add

* PayBas/ticket/12561:
  [ticket/12561] Reworked tests by nickvergessen
  [ticket/12561] Added tests for "after last", "after missing" and "empty"
  [ticket/12561] Add check to see if "after" column actually exists
  [ticket/12561] Added test for "after"
  [ticket/12561] Add "after" check to schema_generator for columns_add
2014-05-28 23:33:25 +02:00
Joas Schilling
1b2238a6b1 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
2014-05-28 23:31:13 +02:00
Joas Schilling
1024f3d44e Merge pull request #2292 from bantu/ticket/12384-ascraeus
[ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.

* bantu/ticket/12384-ascraeus:
  [ticket/12384] Use mysqli on hhvm in ascraeus. Keep explicit matrix though.
  [ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.
2014-05-28 23:31:05 +02:00
Tristan Darricau
ff5fd3442d [ticket/10899] Use isset($field_value['IN'])
PHPBB3-10899
2014-05-28 23:30:47 +02:00
Joas Schilling
a396b647f3 Merge pull request #2282 from bantu/ticket/12384
[ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.

* bantu/ticket/12384:
  [ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.
2014-05-28 23:30:03 +02:00
Tristan Darricau
59f39273d4 [ticket/10899] Add event core.delete_log
PHPBB3-10899
2014-05-28 23:20:50 +02:00
Yuriy Rusko
b934904fbd [ticket/12611] Remove phpBB Group copyright notice from .gifs
PHPBB3-12611
2014-05-28 23:05:32 +02:00
Tristan Darricau
b75fb96bab [ticket/11226] Explicity set file_moved to false
PHPBB3-11226
2014-05-28 22:34:10 +02:00
Tristan Darricau
fde5a9d472 [ticket/11366] Fix headings css in list page
PHPBB3-11366
2014-05-28 22:19:21 +02:00
Tristan Darricau
629c47acfe [ticket/11366] Add config value in schema_data.sql
PHPBB3-11366
2014-05-28 22:19:19 +02:00
Tristan Darricau
73cdfae42b [ticket/11366] Fix HTML
PHPBB3-11366
2014-05-28 22:19:17 +02:00
Tristan Darricau
f3aaab93d6 [ticket/11366] Exchange links and settings' form
PHPBB3-11366
2014-05-28 22:19:16 +02:00
Tristan Darricau
ccddd44105 [ticket/11366] Remove the extra {S_FORM_TOKEN}
PHPBB3-11366
2014-05-28 22:19:14 +02:00
Tristan Darricau
9cbec4deb2 [ticket/11366] Move the links to the top of the page
PHPBB3-11366
2014-05-28 22:19:12 +02:00
Tristan Darricau
edc3b3fb75 [ticket/11366] Hide the version check settings by default
PHPBB3-11366
2014-05-28 22:19:11 +02:00
Tristan Darricau
9b756b9b98 [ticket/11366] Versions, options and actions heading should be centered
PHPBB3-11366
2014-05-28 22:19:09 +02:00
Tristan Darricau
82c97b0a3f [ticket/11366] Better language string for "recheck all"
PHPBB3-11366
2014-05-28 22:19:07 +02:00
Tristan Darricau
b4dec33581 [ticket/11366] Move "recheck all" link
PHPBB3-11366
2014-05-28 22:19:05 +02:00
Tristan Darricau
8dc10d6971 [ticket/11366] Add $config['extension_force_unstable']
PHPBB3-11366
2014-05-28 22:19:03 +02:00
Tristan Darricau
f4d598559f [ticket/11366] Use force_cache on the list page
PHPBB3-11366
2014-05-28 22:19:02 +02:00
Tristan Darricau
13ecddf85b [ticket/11366] Add recheck-all link
PHPBB3-11366
2014-05-28 22:19:00 +02:00
Tristan Darricau
521fe2b8e2 [ticket/11366] Force the use of the cache on the list page
PHPBB3-11366
2014-05-28 22:18:54 +02:00
Tristan Darricau
64467f50db [ticket/11366] Update FILE_NOT_FOUND language string
PHPBB3-11366
2014-05-28 22:17:00 +02:00
Tristan Darricau
537d8b3c16 [ticket/11366] Fix whitespaces
PHPBB3-11366
2014-05-28 22:16:59 +02:00
Tristan Darricau
08ddd1c628 [ticket/11366] Update FILE_NOT_FOUND language string
This var is always used with a colon.

PHPBB3-11366
2014-05-28 22:16:57 +02:00
Tristan Darricau
492c1952c1 [ticket/11366] Update var names
PHPBB3-11366
2014-05-28 22:16:55 +02:00
Tristan Darricau
9173e7d7fd [ticket/11366] Align language strings
PHPBB3-11366
2014-05-28 22:16:53 +02:00
Tristan Darricau
bee6c6baea [ticket/11366] Fix detailed view
PHPBB3-11366
2014-05-28 22:16:51 +02:00
Tristan Darricau
29244c29d1 [ticket/11366] Remove the double spaces
PHPBB3-11366
2014-05-28 22:16:50 +02:00
Tristan Darricau
5e29ea77d8 [ticket/11366] Coding style
PHPBB3-11366
2014-05-28 22:16:48 +02:00
Tristan Darricau
a80a9efa8d [ticket/11366] Correct a sentence
PHPBB3-11366
2014-05-28 22:16:46 +02:00
Tristan Darricau
e4aff6669c [ticket/11366] Remove unused langage entry
PHPBB3-11366
2014-05-28 22:16:44 +02:00
Nicofuma
9cd25cc828 [ticket/11366] Set the size of the 'current version' column to 20%
PHPBB3-11366
2014-05-28 22:16:42 +02:00
Nicofuma
f5da195a03 [ticket/11366] Adding a missing commit
PHPBB3-11366
2014-05-28 22:16:41 +02:00
Nicofuma
2552a0fef2 [ticket/11366] Bug Fix: Extensions removed but still registred in DB
Fix the bug with the Extensions removed but still registred in DB

PHPBB3-11366
2014-05-28 22:16:39 +02:00
Nicofuma
44752c0dbf [ticket/11366] Moving to \phpbb\version_helper
+ bug fix (missing exception)
+ Using \phpbb\version_helper
So, now, the version file have a new format :

	{
		"stable": {
			"<branch>": {
				"current": "<version>",
				[ "announcement": "<announcement link>", ]
				[ "download": "<download link>", ]
			},
			"<branch>": {
				...
			}
		},
		"unstable": {
		}
	}

PHPBB3-11366
2014-05-28 22:16:37 +02:00
Nicofuma
e0b2ceef83 [ticket/11366] Extension's version's check
Add a feature to check automatically the version of the installed
extensions. The informations are cached for 24 hours (like for the
global update check on the main page of the acp).

The informations about the versions are display both on the global list
and on the detailled page.

To do this the developper has to to let the composer.json of the latest
version available and add some informations into it :

    "extra": {
		"version-check": {
			"host": "<the host>",
			"directory": "<the directory containing the file>",
			"filename": "<the composer.json of the latest version>"
		}
    }

He can also add two extra informations which will be displayed if a new
version is available :

	"extra": {
		"download": "<download link>",
		"annoucement": "<announcement link>",
    }

Currently a notice is displayed when the "extra.version-check"
informations are
missing.

Ticket: https://tracker.phpbb.com/browse/PHPBB3-11366

Signed-off-by: Nicofuma <github@nicofuma.fr>

PHPBB3-11366
2014-05-28 22:15:47 +02:00
LEZY Thomas
532e4470ea [ticket/12597] Fix language key name
PHPBB3-12597
2014-05-28 22:09:38 +02:00
Joas Schilling
47b240660b Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
2014-05-28 21:50:25 +02:00
Joas Schilling
3021a6e12a Merge pull request #2505 from bantu/ticket/12582-ascraeus
[ticket/12582] Strip away copyrighted ICC profile from images

* bantu/ticket/12582-ascraeus:
  [ticket/12582] Use the correct script name.
  [ticket/12582] Fix coding style.
  [ticket/12582] Remove set -e due to exiftool not liking 0 byte files.
  [ticket/12582] Strip away copyrighted ICC profile
  [ticket/12582] Change strip_icc_profiles.sh to only take a single file.
  [ticket/12582] Run strip_icc_profiles.sh on Travis CI.
  [ticket/12582] Overwrite inplace instead of creating _original files.
  [ticket/12582] Add script for strippping ICC profiles from images.
2014-05-28 21:50:19 +02:00
Joas Schilling
f09799322e Merge pull request #2498 from bantu/ticket/12582
[ticket/12582] Strip away copyrighted ICC profile from images

* bantu/ticket/12582:
  [ticket/12582] Fix coding style.
  [ticket/12582] Remove set -e due to exiftool not liking 0 byte files.
  [ticket/12582] Strip away copyrighted ICC profile
  [ticket/12582] Change strip_icc_profiles.sh to only take a single file.
  [ticket/12582] Run strip_icc_profiles.sh on Travis CI.
  [ticket/12582] Overwrite inplace instead of creating _original files.
  [ticket/12582] Add script for strippping ICC profiles from images.
2014-05-28 21:49:54 +02:00
Joas Schilling
e2308df14d Merge pull request #2426 from Nicofuma/ticket/12174
[ticket/12174] Update topic_attachment flag when a post is soft-deleted

* Nicofuma/ticket/12174:
  [ticket/12174] Add tests
  [ticket/12174] Coding style
  [ticket/12174] Remove $update_topic_attachments_flag
  [ticket/12174] Don't update the flag for a post without attachment
  [ticket/12174] Update the conditions
  [ticket/12174] Remove inline assignment
  [ticket/12174] Update sql query
  [ticket/12174] Revert the changes on $topic_update_array
  [ticket/12174] Corrections
  [ticket/12174] Update topic_attachment flag when a post is soft-deleted
2014-05-28 21:45:39 +02:00
LEZY Thomas
54d60e3f78 [ticket/12597] Fix coding style and typing mistakes
PHPBB3-12597
2014-05-28 21:26:33 +02:00
LEZY Thomas
9f942776ad [ticket/12597] Changes name of command cron:run-all to cron:run.
Also adds an optional argument to specify one precise cron task to
lauch, and modifies test file accordingly.

PHPBB3-12597
2014-05-28 20:03:28 +02:00
LEZY Thomas
61ad42790f [ticket/12597] Fix various problems
Actually fix the return status of command cron:run-all
Fix some doc block coding style issue
Fix missing and obsolete file headers
Delete a useless constructor method

PHPBB3-12597
2014-05-28 19:22:25 +02:00
LEZY Thomas
18875894ec [ticket/12597] Fix constructor bug and servral doc blocs
PHPBB3-12597
2014-05-28 18:19:46 +02:00
Andreas Fischer
c8e7b2c5d4 Merge pull request #2507 from Marshalrusty/ticket/12594
File headers, credit lines, etc. should reflect updated legal info

* Marshalrusty/ticket/12594:
  [ticket/12594] Replace phpBB Group with phpBB Limited
  [ticket/12594] Update footer credit lines
  [ticket/12594] Remove @package tags and update file headers
2014-05-28 18:19:20 +02:00
LEZY Thomas
0d839cbefc [ticket/12597] Modification of return statuses and of test files
PHPBB3-12597
2014-05-28 18:02:30 +02:00
LEZY Thomas
5fca308138 [ticket/12597] Fix misplaced release of db lock
PHPBB3-12597
2014-05-28 16:47:57 +02:00
LEZY Thomas
9a78772745 [ticket/12597] Change EXECUTE to RUN in language
Fix previous commit : change execute to run in language keys

PHPBB3-12597
2014-05-28 14:57:16 +02:00
Tristan Darricau
ad4a373557 [ticket/12174] Add tests
PHPBB3-12174
2014-05-28 14:55:55 +02:00
LEZY Thomas
6f279c1bf4 [ticket/12597] Update pull-request
Removes a useless comment.
Switchs command name from cron:execute-all to cron:run-all.
Replaces assertEquals by assertSame

PHPBB3-12597
2014-05-28 14:49:55 +02:00
brunoais
8173f96d60 [ticket/12604] Fix wrong padding when no notifications
Added a class to the <li> when the <li> represents that there's no
notifications (no_notifications) and
Added a CSS rule that matches the change to the HTML source for when
there's no notifications.

PHPBB3-12604
2014-05-28 11:59:44 +01:00
LEZY Thomas
9761c1bf61 [ticket/12597] Fix various refactoring mistakes
PHPBB3-12597
2014-05-28 12:57:49 +02:00
LEZY Thomas
6f0121e2a4 [ticket/12597] Correcting bug in cron.php
PHPBB3-12597
2014-05-28 12:36:55 +02:00
LEZY Thomas
8a1e189970 [ticket/12597] Add doc blocs in execute_all.php
PHPBB3-12597
2014-05-28 12:20:02 +02:00
LEZY Thomas
50cb9d5838 [ticket/12597] Correcing coding style mistakes
PHPBB3-12597
2014-05-28 11:57:20 +02:00
Tristan Darricau
d3f4dbedde [ticket/10899] Remove trailing ;
PHPBB3-10899
2014-05-28 11:50:13 +02:00
LEZY Thomas
6f3276653f [ticket/12597] Improvement of test files
PHPBB3-12597
2014-05-28 11:12:50 +02:00
Tristan Darricau
6a3b343dfc [ticket/11226] Add tests
PHPBB3-11226
2014-05-28 10:53:19 +02:00
Tristan Darricau
dfec62c68d [ticket/10899] Fix typo in the class name
PHPBB3-10899
2014-05-28 01:14:36 +02:00
Yuriy Rusko
55e1f02151 [ticket/12594] Replace phpBB Group with phpBB Limited
PHPBB3-12594
2014-05-28 01:07:56 +02:00
Yuriy Rusko
2a42aee8ac Merge remote-tracking branch 'upstream/develop-ascraeus' into ticket/12594 2014-05-28 01:02:39 +02:00
Tristan Darricau
05e76e55e1 [ticket/10899] Add unit tests
PHPBB3-10899
2014-05-28 00:54:22 +02:00
Joas Schilling
08c01b7cee Merge pull request #2455 from Nicofuma/ticket/12509
[ticket/12509] Add an option to set the path of custom style directory (ie: email templates) for extensions

* Nicofuma/ticket/12509:
  [ticket/12509] Add example in doc block
  [ticket/12509] Add missing ',' in arrays
  [ticket/12509] Update calls to set_custom_style in forgotten places
  [ticket/12509] Fix path in adm/index.php
  [ticket/12509] Fix typo in adm/index.php
  [ticket/12509] Fix doc block
  [ticket/12509] Fix the call to set_custom_file in adm/index and messenger
  [ticket/12509] Update acp custom_style setter
  [ticket/12509] Add an option to set the path of custom file for extensions
2014-05-28 00:23:37 +02:00
Joas Schilling
83fc8725da Merge pull request #2453 from Nicofuma/ticket/12536
[ticket/12536] Get Versions Should Not Require Both Stable and Unstable

* Nicofuma/ticket/12536:
  [ticket/12536] Restore missing @throws
  [ticket/12536] Add test cases with empty versions list
  [ticket/12536] Use stable values when unstable are unavailable
  [ticket/12536] Update doc block
  [ticket/12536] Return empty array if stability unavailable
  [ticket/12536] Get Versions Should Not Require Both Stable and Unstable
2014-05-28 00:07:33 +02:00
Andreas Fischer
97dc817158 [ticket/12582] Use the correct script name.
PHPBB3-12582
2014-05-27 23:50:52 +02:00
Dhruv Goel
e9f28c7be0 Merge pull request #2502 from tmbackoff/ticket/12596
[ticket/12596] Add template event acp_group_options_before/after
2014-05-28 01:29:27 +05:30
Yuriy Rusko
1d61bcedfd Merge remote-tracking branch 'upstream/develop-ascraeus' into ticket/12594
Conflicts:
	phpBB/docs/hook_system.html
2014-05-27 21:55:40 +02:00
Yuriy Rusko
27f787e5e4 [ticket/12594] Update footer credit lines
PHPBB3-12594
2014-05-27 21:39:30 +02:00
Andreas Fischer
f4d37749b6 Merge branch 'ticket/12582' into ticket/12582-ascraeus
* ticket/12582:
  [ticket/12582] Fix coding style.
2014-05-27 20:56:47 +02:00
Andreas Fischer
de71837b71 [ticket/12582] Fix coding style.
PHPBB3-12582
2014-05-27 20:56:29 +02:00
Andreas Fischer
709e363349 Merge branch 'ticket/12582' into ticket/12582-ascraeus
* ticket/12582:
  [ticket/12582] Remove set -e due to exiftool not liking 0 byte files.
2014-05-27 20:53:22 +02:00
Andreas Fischer
d7c143da24 [ticket/12582] Remove set -e due to exiftool not liking 0 byte files.
PHPBB3-12582
2014-05-27 20:51:48 +02:00
Yuriy Rusko
a759704b39 [ticket/12594] Remove @package tags and update file headers
PHPBB3-12594
2014-05-27 20:51:13 +02:00
Andreas Fischer
a1e31f4389 Merge branch 'ticket/12582' into ticket/12582-ascraeus
* ticket/12582:
  [ticket/12582] Strip away copyrighted ICC profile
  [ticket/12582] Change strip_icc_profiles.sh to only take a single file.
  [ticket/12582] Run strip_icc_profiles.sh on Travis CI.
  [ticket/12582] Overwrite inplace instead of creating _original files.
  [ticket/12582] Add script for strippping ICC profiles from images.

Conflicts:
	.travis.yml
2014-05-27 20:38:20 +02:00
Tristan Darricau
ac1eb2d789 [ticket/10899] Get $phpbb_log from the container
PHPBB3-10899
2014-05-27 19:57:25 +02:00
Andreas Fischer
0acaa77229 Merge pull request #2469 from prototech/ticket/12155
[ticket/12155] Construct post buttons using CSS.

* prototech/ticket/12155: (21 commits)
  [ticket/12155] Remove use of !important and move reddish color back to .button
  [ticket/12155] Reposition the button icons to the left side while we're at it.
  [ticket/12155] Get rid of line-height value causing alignment issues in FF.
  [ticket/12155] Get rid of the <span> where possible and fix buttons in Safari.
  [ticket/12155] Fix misplaced semicolon and ensure that value comparison works.
  [ticket/12155] Combine the post and topic/PM button icons into a single sprite
  [ticket/12155] Move icon class directly to <a> and use <span> consistently.
  [ticket/12155] Remove star hack from padding-right property of .button.
  [ticket/12155] Fix tabbing and put one selector per line if string is too long
  [ticket/12155] Make opacity transition faster and fix background image paths.
  [ticket/12155] Keep the selection method consistent with the one below it.
  [ticket/12155] Fade out the buttons when leaving the post.
  [ticket/12155] Display the buttons only when hovering the post.
  [ticket/12155] Make the buttons bigger on touch devices.
  [ticket/12155] Clean up icons.
  [ticket/12155] Remove unused font.
  [ticket/12155] Remove obsolete images.
  [ticket/12155] Use the new .button class as the basis for the post buttons.
  [ticket/12155] Move existing button style to a more generic class.
  [ticket/12155] Remove obsolete language images.
  ...
2014-05-27 18:41:31 +02:00
LEZY Thomas
abb8a2892d [ticket/12597] Command for executing all available cron tasks
Command cron:execute-all executes all available cron tasks.
Test files in tests/console/cron folder

PHPBB3-12597
2014-05-27 18:37:37 +02:00
David Prévot
b485318ba9 [ticket/12582] Strip away copyrighted ICC profile
This images embed a non free ICC profile that doesn’t allow
modification:

http://web.archive.org/web/20020603153925/srgb.com/usingsrgb.html

Please use the proposed version stripping away this copyrighted binary
profile, probably embedded by an image software at one time:

	exiftool -icc_profile"-<=" phpBB/adm/images/phpbb_logo.png

I’ve checked the resulting image and trust it is identical to the
original.

Some more background on the issue:
https://lists.debian.org/debian-devel/2014/05/msg00339.html

PHPBB3-12582
2014-05-27 18:35:44 +02:00
Andreas Fischer
2a1925a783 Merge pull request #2503 from prototech/ticket/12603
[ticket/12603] Remove hook system documentation.

* prototech/ticket/12603:
  [ticket/12603] Remove hook system documentation.
2014-05-27 18:33:56 +02:00
Cesar G
4c4227589f [ticket/12603] Remove hook system documentation.
The code for hooks still exists in Ascraeus for compatibility reasons, however,
it is no longer recommended that they be used. The events system should be
used instead.

PHPBB3-12603
2014-05-27 09:28:23 -07:00
Andreas Fischer
7392c75562 [ticket/12384] Use mysqli on hhvm in ascraeus. Keep explicit matrix though.
PHPBB3-12384
2014-05-27 18:13:01 +02:00
Andreas Fischer
9eb89fa5fd Merge branch 'ticket/12384' into ticket/12384-ascraeus
* ticket/12384:
  [ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.
2014-05-27 18:11:30 +02:00
Andreas Fischer
edf81cd534 Merge pull request #2440 from nickvergessen/ticket/12527
[ticket/12527] Remove translation editor from ACP

* nickvergessen/ticket/12527:
  [ticket/12527] Fix "board’s language" vs "boards language"
  [ticket/12527] Use a proper language string on confirm screen
  [ticket/12527] Remove unnecessary language strings
  [ticket/12527] Check whether the language exists
  [ticket/12527] Restore missing files and variables check
  [ticket/12527] Remove editor from template
  [ticket/12527] Remove language file editor form ACP
2014-05-27 17:34:50 +02:00
Andreas Fischer
c02fba3f1c [ticket/12582] Change strip_icc_profiles.sh to only take a single file.
PHPBB3-12582
2014-05-27 17:23:54 +02:00
Andreas Fischer
4f9aa5e384 [ticket/12582] Run strip_icc_profiles.sh on Travis CI.
PHPBB3-12582
2014-05-27 17:23:54 +02:00
Andreas Fischer
ac3bc45874 [ticket/12582] Overwrite inplace instead of creating _original files.
PHPBB3-12582
2014-05-27 17:23:54 +02:00
Andreas Fischer
31b5e749c1 Merge pull request #2500 from Nicofuma/ticket/12600
[ticket/12600] Add @log to the dependencies of extension:show

* Nicofuma/ticket/12600:
  [ticket/12600] Add @log to the dependencies of extension:show
2014-05-27 16:59:09 +02:00
Cesar G
7518648c21 [ticket/12155] Remove use of !important and move reddish color back to .button
PHPBB3-12155
2014-05-27 07:35:49 -07:00
Tabitha Backoff
6230ae66a3 [ticket/12596] Add template event acp_group_options_before/after
Add template events to the group settings page to allow extensions to
add
additional options for groups.

PHPBB3-12596
2014-05-27 10:31:03 -04:00
Cesar G
ee9b99cc31 [ticket/12155] Reposition the button icons to the left side while we're at it.
PHPBB3-12155
2014-05-27 07:17:48 -07:00
Cesar G
aad195aaa8 [ticket/12155] Get rid of line-height value causing alignment issues in FF.
PHPBB3-12155
2014-05-27 07:17:48 -07:00
Cesar G
4d60583412 [ticket/12155] Get rid of the <span> where possible and fix buttons in Safari.
PHPBB3-12155
2014-05-27 07:17:47 -07:00
Cesar G
dff6741c7b [ticket/12155] Fix misplaced semicolon and ensure that value comparison works.
PHPBB3-12155
2014-05-27 07:17:47 -07:00
Cesar G
7c3af55918 [ticket/12155] Combine the post and topic/PM button icons into a single sprite
PHPBB3-12155
2014-05-27 07:17:47 -07:00
Cesar G
70f9d4a54a [ticket/12155] Move icon class directly to <a> and use <span> consistently.
PHPBB3-12155
2014-05-27 07:17:47 -07:00
Cesar G
523c374e16 [ticket/12155] Remove star hack from padding-right property of .button.
This was in place for IE7 due to the use of :after for inserting the button
icon. IE7 does not support :after, so the hack removed the extra padding that
made room for the icon. We no longer use :after for the icon, so this is no
longer an issue... not to mention that IE7 is no longer supported.

PHPBB3-12155
2014-05-27 07:17:47 -07:00
Cesar G
7f2c3866ed [ticket/12155] Fix tabbing and put one selector per line if string is too long
PHPBB3-12155
2014-05-27 07:17:47 -07:00
Cesar G
74afe4acea [ticket/12155] Make opacity transition faster and fix background image paths.
PHPBB3-12155
2014-05-27 07:17:47 -07:00
Cesar G
c0c42dec24 [ticket/12155] Keep the selection method consistent with the one below it.
PHPBB3-12155
2014-05-27 07:17:47 -07:00
Cesar G
c521fc2a4e [ticket/12155] Fade out the buttons when leaving the post.
PHPBB3-12155
2014-05-27 07:17:47 -07:00
Cesar G
cba58fe4e9 [ticket/12155] Display the buttons only when hovering the post.
PHPBB3-12155
2014-05-27 07:17:47 -07:00
Cesar G
3106306a4d [ticket/12155] Make the buttons bigger on touch devices.
PHPBB3-12155
2014-05-27 07:17:47 -07:00
Cesar G
84fd965272 [ticket/12155] Clean up icons.
PHPBB3-12155
2014-05-27 07:17:46 -07:00
Cesar G
f31f1dca4b [ticket/12155] Remove unused font.
PHPBB3-12155
2014-05-27 07:17:46 -07:00
Cesar G
673087d5f0 [ticket/12155] Remove obsolete images.
PHPBB3-12155
2014-05-27 07:17:46 -07:00
Cesar G
d3b9c87b42 [ticket/12155] Use the new .button class as the basis for the post buttons.
PHPBB3-12155
2014-05-27 07:17:46 -07:00
Cesar G
00ff33c9b4 [ticket/12155] Move existing button style to a more generic class.
PHPBB3-12155
2014-05-27 07:17:46 -07:00
Cesar G
03d3762d52 [ticket/12155] Remove obsolete language images.
PHPBB3-12155
2014-05-27 07:17:46 -07:00
neufke
aeb7803017 [ticket/12155] CSS-ing of the mini post buttons
Created a css version of the mini post buttons with the use of language vars
and no fixed width of height.

PHPBB3-12155
2014-05-27 07:17:46 -07:00
Cesar G
bca34bd3bb Merge remote-tracking branch 'hanakin/ticket/12580' into develop-ascraeus
* hanakin/ticket/12580:
  [ticket/12580] Remove :link pseudo from a tag
2014-05-27 07:13:46 -07:00
Tristan Darricau
0a2e0ee964 [ticket/12600] Add @log to the dependencies of extension:show
PHPBB3-12600
2014-05-27 15:35:10 +02:00
Andreas Fischer
b3ba11024b Merge pull request #2497 from bantu/ticket/12592
[ticket/12592] Make hhvm run MySQL again.

* bantu/ticket/12592:
  [ticket/12592] Make hhvm run MySQL again.
2014-05-27 13:43:41 +02:00
Andreas Fischer
af05015a69 [ticket/12582] Add script for strippping ICC profiles from images.
PHPBB3-12582
2014-05-27 13:13:29 +02:00
Tristan Darricau
c517cd6778 [ticket/8610] Throw an error when the dest topic isn't set
PHPBB3-8610
2014-05-27 01:38:43 +02:00
Tristan Darricau
d20d86bf10 [ticket/8610] Fix bookmarks when merging all the posts of a topic
PHPBB3-8610
2014-05-27 01:35:52 +02:00
PayBas
9f37d414be [ticket/12561] Reworked tests by nickvergessen
PHPBB3-12561
2014-05-27 00:41:11 +02:00
Tristan Darricau
05cd25a88b [ticket/12509] Add example in doc block
PHPBB3-12509
2014-05-27 00:05:12 +02:00
Tristan Darricau
1ba516a052 [ticket/11942] Don't show the checkbox if the post is already soft-deleted
PHPBB3-11942
2014-05-26 23:59:27 +02:00
Tristan Darricau
8a227b981a [ticket/12536] Restore missing @throws
PHPBB3-12536
2014-05-26 23:52:09 +02:00
Tristan Darricau
9a846e447b [ticket/12509] Add missing ',' in arrays
PHPBB3-12509
2014-05-26 23:44:30 +02:00
Tristan Darricau
2ff3efc4a1 [ticket/12325] Update coding style in template
PHPBB3-12325
2014-05-26 23:38:30 +02:00
Tristan Darricau
814d10fe5e [ticket/11942] Remove useless IF in templates
PHPBB3-11942
2014-05-26 23:35:47 +02:00
Andreas Fischer
d646354b0e Merge pull request #2492 from nickvergessen/ticket/12570
[ticket/12570] Fix updating a config with the same value

* nickvergessen/ticket/12570:
  [ticket/12570] Keep MySQLi procedural
  [ticket/12570] Remove test for affected rows after SELECT
  [ticket/12570] Add a test for set_array() and updating with the same value
  [ticket/12570] Fix MySQL affectedrows
  [ticket/12570] Fix MySQLi affectedrows by specifying MYSQLI_CLIENT_FOUND_ROWS
  [ticket/12570] Add a unit test to show broken sql_affectedrows()
  [ticket/12570] Add test for updating a config with the same value
2014-05-26 23:09:51 +02:00
Andreas Fischer
ea17a7cc5b [ticket/12592] Make hhvm run MySQL again.
PHPBB3-12592
2014-05-26 21:55:44 +02:00
Joas Schilling
fcdf1101cb [ticket/12570] Keep MySQLi procedural
PHPBB3-12570
2014-05-26 21:43:40 +02:00
Joas Schilling
275e56ce70 [ticket/12570] Remove test for affected rows after SELECT
It's not supposed to work

PHPBB3-12570
2014-05-26 21:43:40 +02:00
Joas Schilling
adc62684f0 [ticket/12570] Add a test for set_array() and updating with the same value
PHPBB3-12570
2014-05-26 21:43:39 +02:00
Joas Schilling
d87dba3b05 [ticket/12570] Fix MySQL affectedrows
We always want the number of matched rows instead of changed rows,
when running an update. So when mysql_info() returns the number of
matched rows we return that one instead of mysql_affected_rows()

PHPBB3-12570
2014-05-26 21:43:38 +02:00
Joas Schilling
b92eac71e4 [ticket/12570] Fix MySQLi affectedrows by specifying MYSQLI_CLIENT_FOUND_ROWS
PHPBB3-12570
2014-05-26 21:43:38 +02:00
Joas Schilling
15516bd078 [ticket/12570] Add a unit test to show broken sql_affectedrows()
PHPBB3-12570
2014-05-26 21:43:37 +02:00
Joas Schilling
ce5258d801 [ticket/12570] Add test for updating a config with the same value
PHPBB3-12570
2014-05-26 21:43:36 +02:00
Joas Schilling
502cbad5a7 Merge pull request #2496 from bantu/ticket/12592
[ticket/12592] Run mysql driver on Travis CI.

* bantu/ticket/12592:
  [ticket/12592] Add PHP 5.4 environment using mysql driver.
  [ticket/12592] Rename mysql environment to mysqli.
2014-05-26 21:36:17 +02:00
PayBas
3cabe5fd79 [ticket/12561] Added tests for "after last", "after missing" and "empty"
Also removed tabs

PHPBB3-12561
2014-05-26 20:47:19 +02:00
PayBas
c51b926631 [ticket/12561] Add check to see if "after" column actually exists
If not, just append to the end

PHPBB3-12561
2014-05-26 19:28:37 +02:00
Andreas Fischer
d90da12afc [ticket/12592] Add PHP 5.4 environment using mysql driver.
PHPBB3-12592
2014-05-26 19:07:40 +02:00
Joas Schilling
a6782801e7 Merge pull request #2429 from Nicofuma/ticket/12074
[ticket/12074] Managing extensions doesn't produce any log entry

* Nicofuma/ticket/12074:
  [ticket/12074] Update the visibility of the constructor
  [ticket/12074] Don't log errors
  [ticket/12074] Managing extensions doesn't produce any log entry
2014-05-26 18:55:19 +02:00
Andreas Fischer
c0dc0fc09b [ticket/12592] Rename mysql environment to mysqli.
PHPBB3-12592
2014-05-26 18:49:29 +02:00
Joas Schilling
26674bff39 Merge pull request #2487 from n-aleha/ticket/12583
[ticket/12583] Add event core.mcp_warn_post_before/after

* n-aleha/ticket/12583:
  [ticket/12583] Redirect only on non-empty $message
  [ticket/12583] Add event core.mcp_warn_post_before/after
2014-05-26 18:39:44 +02:00
Joas Schilling
85fb2bf203 Merge pull request #2488 from n-aleha/ticket/12584
[ticket/12584] Add event core.mcp_warn_user_before/after

* n-aleha/ticket/12584:
  [ticket/12584] Redirect only on non-empty $message
  [ticket/12584] Add event core.mcp_warn_user_before/after
2014-05-26 18:36:53 +02:00
Tristan Darricau
91305a43af [ticket/12589] Add test searching in a non absolute directory
PHPBB3-12589
2014-05-26 18:30:04 +02:00
Joas Schilling
172b7cfe35 Merge pull request #2134 from marcosbc/ticket/12270
[ticket/12270] Current post and topic approval notification message

* marcosbc/ticket/12270:
  [ticket/12270] Fixed topic counting bug and tests
  [ticket/12270] Fixed tests not working
  [ticket/12270] No quote notif and double poster notification fix
  [ticket/12270] Fixed tests
  [ticket/12270] Fixed rebase conflicts
  [ticket/12270] Correct confirm approval message for topics
  [ticket/12270] Correcting to follow phpBB coding standards
  [ticket/12270] Better structured code and no debug error message
  [ticket/12270] Correct notifications for posts/topics now working
  [ticket/12270] Reverted templates
  [ticket/12270] Correct post&topic approval msg, no template changes
  [ticket/12270] Corrent post and topic approval notification message
2014-05-26 18:09:54 +02:00
n-aleha
62cb7e0c10 [ticket/12584] Redirect only on non-empty $message
PHPBB3-12584
2014-05-25 22:40:20 +03:00
n-aleha
fdb53b23fb [ticket/12584] Add event core.mcp_warn_user_before/after
Event for when warning a user from MCP.

PHPBB3-12584
2014-05-25 22:40:15 +03:00
n-aleha
589ad564cc [ticket/12583] Redirect only on non-empty $message
PHPBB3-12583
2014-05-25 22:00:37 +03:00
Tristan Darricau
930c5d85ed [ticket/12589] Fix tests
PHPBB3-12589
2014-05-24 18:58:52 +02:00
Tristan Darricau
f7896f46a5 [ticket/12589] Search directly in $directory if it's an absolute sub-path
PHPBB3-12589
2014-05-24 17:57:01 +02:00
PayBas
05839f8599 [ticket/12561] Added test for "after"
PHPBB3-12561
2014-05-24 14:37:08 +02:00
Skouat
a0a5c852d5 [ticket/12492] Add support of special chars
Add support of special chars during db test in the installation

PHPBB3-12492
2014-05-24 14:33:02 +02:00
Joas Schilling
1b73c217f0 Merge pull request #2458 from prototech/ticket/12543
[ticket/12543] Only take over ENTER and ESC keys when alert box is active.

* prototech/ticket/12543:
  [ticket/12543] Only take over ENTER and ESC keys when alert box is active.
2014-05-24 14:28:38 +02:00
Tristan Darricau
672ffbe8f6 [ticket/12325] Fix: add a missing colon
PHPBB3-12325
2014-05-24 14:25:04 +02:00
Joas Schilling
c7f51ca1a7 Merge pull request #2199 from Zoddo/ticket/12275
[ticket/12275] Fix a bug on the event "core.modify_username_string"

* Zoddo/ticket/12275:
  [ticket/12275] Change if (empty) to if (!isset)
  [ticket/12275] Fix a bug on the event "core.modify_username_string"
2014-05-24 14:18:43 +02:00
Tristan Darricau
2f52934fad [ticket/12325] Don't use L_COLON
PHPBB3-12325
2014-05-24 14:12:11 +02:00
marcosbc
36dfb95816 [ticket/12270] Fixed topic counting bug and tests
Topics was not correctly counted (the counter didn't count topics
that were re-approved, for example, but only the ones that were
unapproved.
This should also fix the test that wasn't working correctly.

PHPBB3-12270
2014-05-24 14:06:23 +02:00
Tristan Darricau
088f5b47c3 [ticket/12325] Fix: it's not stuck in an inifinite loop anymore
PHPBB3-12325
2014-05-24 14:06:14 +02:00
Joas Schilling
2aeb795494 Merge pull request #2444 from VSEphpbb/ticket/12531
[ticket/12531] Restore default topic link behavior to subsilver2

* VSEphpbb/ticket/12531:
  [ticket/12531] Add some line breaks to really long lines
  [ticket/12531] Restore default topic link functionality in subsilver2
2014-05-24 14:03:16 +02:00
Andreas Fischer
42bc2612c4 Merge pull request #2490 from Nicofuma/ticket/12585
[ticket/12585] Don't check the cron on each page load

* Nicofuma/ticket/12585:
  [ticket/12585] Use a 5 minutes interval instead of 10 minutes
  [ticket/12585] Don't check the cron on each page load
2014-05-24 11:55:32 +02:00
Tristan Darricau
0ae4b82c30 [ticket/12585] Use a 5 minutes interval instead of 10 minutes
PHPBB3-12585
2014-05-23 23:02:31 +02:00
Tristan Darricau
6e6891f841 [ticket/12325] Automatic update should notify about outdated files
PHPBB3-12325
2014-05-23 22:59:46 +02:00
Matt Friedman
3913ee9607 [ticket/12531] Add some line breaks to really long lines
PHPBB3-12531
2014-05-23 10:47:25 -07:00
hanakin
9a130e31a2 [ticket/12580] Remove :link pseudo from a tag
removed the :link pseudo from a tag as due to specificity it prevents
classes from altering any properties set to it.

PHPBB3-12580
2014-05-23 15:46:39 +02:00
n-aleha
7a6867d54e [ticket/12583] Add event core.mcp_warn_post_before/after
Event for when warning a user for a post.

PHPBB3-12583
2014-05-23 16:30:41 +03:00
Andreas Fischer
3d19776037 Merge pull request #2468 from nickvergessen/ticket/12555
[Ticket/12555] Make use of canonical urls to avoid duplicate content

* nickvergessen/ticket/12555:
  [ticket/12555] Add canonical URL for viewtopic
  [ticket/12555] Add canonical URL for viewforum
  [ticket/12555] Add canonical URl for memberlist mode=viewprofile
  [ticket/12555] Allow to set canonical URLs to avoid duplicate content
2014-05-23 03:06:42 +02:00
Andreas Fischer
7a464a83b5 Merge pull request #2480 from rxu/ticket/12572
[ticket/12572] Fix JS error when alert message title is undefined

* rxu/ticket/12572:
  [ticket/12572] Fix JS error when alert message title is undefined
2014-05-23 00:58:12 +02:00
Joas Schilling
adf5daa1c7 Merge pull request #2467 from prototech/ticket/12551
[ticket/12551] Float breadcrumbs to the right in RTL languages.

* prototech/ticket/12551:
  [ticket/12551] Float breadcrumbs to the right in RTL languages.
2014-05-23 00:45:35 +02:00
Joas Schilling
7223339f1e Merge pull request #2466 from prototech/ticket/12550
[ticket/12550] Prevent last post column from jumping to second line in RTL.

* prototech/ticket/12550:
  [ticket/12550] Prevent last post column from jumping to second line in RTL.
2014-05-23 00:45:06 +02:00
Joas Schilling
a9cce2e857 Merge pull request #2465 from prototech/ticket/12549
[ticket/12549] Hide topic/forum list <dfn> tags in RTL languages.

* prototech/ticket/12549:
  [ticket/12549] Hide topic/forum list <dfn> tags in RTL languages.
2014-05-23 00:44:20 +02:00
Andreas Fischer
1eef2f2782 Merge pull request #2484 from Nicofuma/ticket/12576
[ticket/12576] Remove cron from common.php

* Nicofuma/ticket/12576:
  [ticket/12576] Retrieve the cron_manager in cron.php if needed
  [ticket/12576] Remove cron from common.php
2014-05-23 00:34:28 +02:00
Andreas Fischer
b0dd144fe3 Merge pull request #2491 from nickvergessen/ticket/12586
Ticket/12586 Filter files and depth when looking for extensions

* nickvergessen/ticket/12586:
  [ticket/12586] Limit depth to 2, we require vendor/extension/ext.php
  [ticket/12586] Use dot filter when trying to find available extensions
2014-05-23 00:19:32 +02:00
Joas Schilling
1572aca7b0 [ticket/12586] Limit depth to 2, we require vendor/extension/ext.php
PHPBB3-12586
2014-05-22 23:43:35 +02:00
Joas Schilling
488904d0bf [ticket/12586] Use dot filter when trying to find available extensions
PHPBB3-12586
2014-05-22 23:42:49 +02:00
Tristan Darricau
c83b568848 [ticket/12585] Don't check the cron on each page load
PHPBB3-12585
2014-05-22 22:34:03 +02:00
rxu
6466002052 [ticket/12572] Fix JS error when alert message title is undefined
JS console reports error in core.js:
TypeError: alert is undefined
alert.hide()
when res.MESSAGE_TITLE is undefined.

PHPBB3-12572
2014-05-22 19:59:33 +08:00
Tristan Darricau
004b317876 [ticket/12576] Retrieve the cron_manager in cron.php if needed
PHPBB3-12576
2014-05-22 13:47:37 +02:00
Tristan Darricau
ff280d3f46 [ticket/12576] Remove cron from common.php
PHPBB3-12576
2014-05-22 12:45:03 +02:00
marcosbc
c47c50a29e [ticket/12270] Fixed tests not working
The success message wasn't output correctly if we were approving
topics.

PHPBB3-12270
2014-05-21 00:52:42 +02:00
PayBas
9ddf02243e [ticket/12561] Add "after" check to schema_generator for columns_add
PHPBB3-12561
2014-05-19 12:04:47 +02:00
Joas Schilling
a2cd9c2464 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
2014-05-18 18:58:30 +02:00
Joas Schilling
785c56ab56 Merge pull request #2471 from bantu/task/sami-ascraeus
[task/sami-ascraeus] Add Sami to composer dependencies and build script

* bantu/task/sami-ascraeus:
  [task/sami] Establish alphabetical order.
  [task/sami] Also ignore ext/ directory.
  [task/sami] Replace phpdoctor with sami.
  [task/sami] Add sami/sami as a composer development dependency.
2014-05-18 18:58:27 +02:00
Joas Schilling
ac3e0e53b2 Merge pull request #2470 from bantu/task/sami
[task/sami] Add Sami to composer dependencies and build script

* bantu/task/sami:
  [task/sami] Establish alphabetical order.
  [task/sami] Also ignore ext/ directory.
  [task/sami] Replace phpdoctor with sami.
  [task/sami] Add sami/sami as a composer development dependency.
2014-05-18 18:56:52 +02:00
Joas Schilling
b040c3f7c1 [ticket/12527] Fix "board’s language" vs "boards language"
PHPBB3-12527
2014-05-18 12:28:28 +02:00
Andreas Fischer
e44acf4084 Merge branch 'task/sami' into task/sami-ascraeus
* task/sami:
  [task/sami] Establish alphabetical order.
  [task/sami] Also ignore ext/ directory.
2014-05-17 13:07:00 +02:00
Andreas Fischer
223058c8c6 [task/sami] Establish alphabetical order.
PHPBB3-12495
2014-05-17 13:05:52 +02:00
Andreas Fischer
6a97d9f855 [task/sami] Also ignore ext/ directory.
PHPBB3-12495
2014-05-17 13:04:25 +02:00
Cesar G
8b5b318f0a Merge remote-tracking branch 'n-aleha/ticket/12547' into develop-ascraeus
* n-aleha/ticket/12547:
  [ticket/12547] Rename jquery.js to jquery.min.js in assets directory
2014-05-16 22:04:52 -07:00
Cesar G
747eb198ef Merge remote-tracking branch 'n-aleha/ticket/12525' into develop-ascraeus
* n-aleha/ticket/12525:
  [ticket/12525] Add string argument to contact and email user language variables
2014-05-16 20:04:34 -07:00
n-aleha
a114333209 [ticket/12525] Add string argument to contact and email user language variables
In language/en/common.php:
* Introduce a new language variable 'CONTACT' => 'Contact'
* Add a string argument to lang var 'CONTACT_USER' to avoid an appended
 '{USERNAME}' in template.
* Add a string argument to lang var 'SEND_EMAIL_USER' to avoid an appended
 '{USERNAME}' in template.

Also fix typos.

PHPBB3-12525
2014-05-17 04:50:57 +03:00
Cesar G
5dc0605b6b Merge remote-tracking branch 'brunoais/ticket/PHPBB3-12533' into develop-ascraeus
* brunoais/ticket/PHPBB3-12533:
  [ticket/12533] Make <a> use all the "see all" "button"
  [ticket/12533] Make <a> use all the notification item size
2014-05-16 17:00:40 -07:00
Andreas Fischer
9cea96ad4e Merge branch 'task/sami' into task/sami-ascraeus
* task/sami:
  [task/sami] Replace phpdoctor with sami.
  [task/sami] Add sami/sami as a composer development dependency.

Conflicts:
	phpBB/composer.json
	phpBB/composer.lock
2014-05-16 18:13:45 +02:00
Andreas Fischer
f08f283143 [task/sami] Replace phpdoctor with sami.
PHPBB3-12495
2014-05-16 17:56:03 +02:00
Andreas Fischer
b32f91b9c6 [task/sami] Add sami/sami as a composer development dependency.
PHPBB3-12495
2014-05-16 17:55:41 +02:00
Joas Schilling
0ad2e22ec0 [ticket/12555] Add canonical URL for viewtopic
Avoids duplicate content of:
* viewtopic.php?t=topic_id
* viewtopic.php?f=forum_id&t=topic_id
* viewtopic.php?f=forum_id&t=topic_id&hilit=highlight_string
* viewtopic.php?f=forum_id&t=topic_id&view=unread
* viewtopic.php?f=forum_id&p=post_id
* viewtopic.php?f=forum_id&t=topic_id&start=0

PHPBB3-12555
2014-05-16 11:38:37 +02:00
Joas Schilling
08b5d052c6 [ticket/12555] Add canonical URL for viewforum
Avoids duplicate content of:
* viewforum.php?f=forum_id
* viewforum.php?f=forum_id&start=0

PHPBB3-12555
2014-05-16 11:34:04 +02:00
Joas Schilling
199854af1b [ticket/12555] Add canonical URl for memberlist mode=viewprofile
Avoids duplicate content of:
* memberlist.php?mode=viewprofile&u=user_id
* memberlist.php?mode=viewprofile&un=username

PHPBB3-12555
2014-05-16 11:32:33 +02:00
Joas Schilling
613f4f7525 [ticket/12555] Allow to set canonical URLs to avoid duplicate content
PHPBB3-12555
2014-05-16 11:32:01 +02:00
Cesar G
9860780ccf [ticket/12550] Prevent last post column from jumping to second line in RTL.
PHPBB3-12550
2014-05-15 11:38:04 -07:00
Cesar G
e2f2cc8902 [ticket/12549] Hide topic/forum list <dfn> tags in RTL languages.
PHPBB3-12549
2014-05-15 11:36:48 -07:00
Cesar G
4eb1294a27 [ticket/12551] Float breadcrumbs to the right in RTL languages.
PHPBB3-12551
2014-05-15 11:30:01 -07:00
Andreas Fischer
a496015b98 Merge pull request #2463 from nickvergessen/ticket/12433
[ticket/12433] Use a different message when nesting of quotes is not allowed

* nickvergessen/ticket/12433:
  [ticket/12433] Use a different message when nesting of quotes is not allowed
2014-05-15 16:48:18 +02:00
Andreas Fischer
46ca856bda Merge pull request #2464 from nickvergessen/ticket/11163
[ticket/11163] Add ext/index.htm

* nickvergessen/ticket/11163:
  [ticket/11163] Add ext/index.htm
2014-05-15 16:33:55 +02:00
Joas Schilling
0f30613a7e [ticket/11163] Add ext/index.htm
PHPBB3-11163
2014-05-15 14:11:11 +02:00
Joas Schilling
34c1691d7e [ticket/12433] Use a different message when nesting of quotes is not allowed
PHPBB3-12433
2014-05-15 14:03:27 +02:00
Andreas Fischer
8b8c25194a Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12540] Fix broken placeholders in language files

Conflicts:
	phpBB/language/en/common.php
	phpBB/language/en/posting.php
	phpBB/language/en/ucp.php
2014-05-15 13:41:54 +02:00
Andreas Fischer
f2500da8ec Merge pull request #2454 from nickvergessen/ticket/12540
[ticket/12540] Fix broken placeholders in language files

* nickvergessen/ticket/12540:
  [ticket/12540] Fix broken placeholders in language files
2014-05-15 13:36:06 +02:00
Tristan Darricau
d53336af06 [ticket/11224] Remove new line in acm_memory.php
PHPBB3-11224
2014-05-15 12:36:22 +02:00
Tristan Darricau
a1e21f0a5c [ticket/12536] Add test cases with empty versions list
PHPBB3-12536
2014-05-15 02:10:51 +02:00
Tristan Darricau
292908ca4a [ticket/11224] Use assertNotEquals(false) instead of assertNotFalse()
assertNotFalse() is unavailable with the version of phpunit used with php
5.2

PHPBB3-11224
2014-05-15 01:50:44 +02:00
Tristan Darricau
7c99e30920 [ticket/11224] Fix coding style
PHPBB3-11224
2014-05-15 01:17:02 +02:00
Tristan Darricau
e1d9f1c67c [ticket/12536] Use stable values when unstable are unavailable
PHPBB3-12536
2014-05-15 01:14:44 +02:00
Tristan Darricau
b7f54e42b2 [ticket/11224] Add unit test
PHPBB3-11224
2014-05-15 00:22:27 +02:00
n-aleha
cc99a6b6ab [ticket/12547] Rename jquery.js to jquery.min.js in assets directory
phpBB uses the minified version of jQuery hence the rename.

PHPBB3-12547
2014-05-15 01:18:26 +03:00
Andreas Fischer
dacece711b Merge pull request #2456 from Nicofuma/ticket/12435
[ticket/12435] purge_notifications() fails for unused notifications

* Nicofuma/ticket/12435:
  [ticket/12435] Update the comment
  [ticket/12435] purge_notifications() fails for unused notifications
2014-05-14 23:12:11 +02:00
Andreas Fischer
1b8bcef2d1 Merge pull request #2457 from prototech/ticket/12544
[ticket/12544] Update Plupload to 2.1.2.

* prototech/ticket/12544:
  [ticket/12544] Update Plupload to 2.1.2.
2014-05-14 23:04:25 +02:00
Tristan Darricau
9dd71fa32e [ticket/11224] Fix the blank line after ?>
PHPBB3-11224
2014-05-14 20:23:27 +02:00
Tristan Darricau
0c4b53e2f1 [ticket/11224] Fix returned data
PHPBB3-11224
2014-05-14 20:22:36 +02:00
Tristan Darricau
0c109c9d37 [ticket/11224] SQL cache destroy does not destroy queries to tables joined
https://tracker.phpbb.com/browse/PHPBB3-11224

PHPBB3-11224
2014-05-14 20:00:04 +02:00
brunoais
d27ece1994 [ticket/12533] Make <a> use all the "see all" "button"
Changed the CSS so that the `<a>` of the notifications
list for the "see all" uses all the container.

PHPBB3-12533
2014-05-14 09:51:51 +01:00
brunoais
86d19b6062 [ticket/12533] Make <a> use all the notification item size
Changed padding CSS to the notifications' `<li>` and it's
`<a>` (immediate child) so that the `<a>` block uses all
 it's container width and height.

To compensate that, I added the padding that was in the
`<li>` to the `<a>`

PHPBB3-12533
2014-05-14 09:51:39 +01:00
Cesar G
bc31a0d252 [ticket/12543] Only take over ENTER and ESC keys when alert box is active.
PHPBB3-12543
2014-05-13 17:49:54 -07:00
Tristan Darricau
7af785f903 [ticket/12435] Update the comment
PHPBB3-12435
2014-05-14 02:32:12 +02:00
Cesar G
c1b817466c [ticket/12544] Update Plupload to 2.1.2.
PHPBB3-12544
2014-05-13 17:23:48 -07:00
Tristan Darricau
9d7c36041e [ticket/12509] Update calls to set_custom_style in forgotten places
PHPBB3-12509
2014-05-14 02:16:32 +02:00
Tristan Darricau
cb97c26e88 [ticket/12435] purge_notifications() fails for unused notifications
https://tracker.phpbb.com/browse/PHPBB3-12435

PHPBB3-12435
2014-05-14 02:09:41 +02:00
Tristan Darricau
c8080d6464 [ticket/12509] Fix path in adm/index.php
PHPBB3-12509
2014-05-14 01:11:43 +02:00
Tristan Darricau
57d08dc77b [ticket/12509] Fix typo in adm/index.php
PHPBB3-12509
2014-05-14 00:27:04 +02:00
Tristan Darricau
9fc2063d86 [ticket/12509] Fix doc block
PHPBB3-12509
2014-05-13 23:49:21 +02:00
Tristan Darricau
1e427fa031 [ticket/12509] Fix the call to set_custom_file in adm/index and messenger
PHPBB3-12509
2014-05-13 23:39:42 +02:00
Tristan Darricau
910b9b59b3 [ticket/12509] Update acp custom_style setter
PHPBB3-12509
2014-05-13 23:25:44 +02:00
Tristan Darricau
300d5c32db [ticket/12509] Add an option to set the path of custom file for extensions
https://tracker.phpbb.com/browse/PHPBB3-12509

PHPBB3-12509
2014-05-13 23:22:54 +02:00
Joas Schilling
dceea23b1f [ticket/12540] Fix broken placeholders in language files
PHPBB3-12540
2014-05-13 21:41:11 +02:00
Tristan Darricau
8b6df0e2f8 [ticket/12536] Update doc block
PHPBB3-12536
2014-05-13 12:59:10 +02:00
Tristan Darricau
3dddf1f4bf [ticket/12536] Return empty array if stability unavailable
PHPBB3-12536
2014-05-13 12:48:08 +02:00
Joas Schilling
bec9b7c34e Merge pull request #2452 from n-aleha/ticket/12519
[ticket/12519] Restore m_approve language description

* n-aleha/ticket/12519:
  [ticket/12519] Restore m_approve language description
2014-05-13 12:21:28 +02:00
Tristan Darricau
36d5fff1c6 [ticket/12536] Get Versions Should Not Require Both Stable and Unstable
https://tracker.phpbb.com/browse/PHPBB3-12536

PHPBB3-12536
2014-05-12 23:57:08 +02:00
n-aleha
9c8e228236 [ticket/12519] Restore m_approve language description
Restore acl_m_approve language description to:
"Can approve and restore posts"

PHPBB3-12519
2014-05-12 22:15:39 +03:00
Marc Alexander
b62c39c36e Merge remote-tracking branch 'nickvergessen/ticket/12534' into develop-ascraeus
* nickvergessen/ticket/12534:
  [ticket/12534] Fix filter for functional tests
  [ticket/12534] Do not use errorbox for multi steps
  [ticket/12534] Do not abuse errorbox for en/disable confirmation of extensions
2014-05-12 13:09:44 +02:00
Joas Schilling
b3eb38ecaf [ticket/12534] Fix filter for functional tests
PHPBB3-12534
2014-05-12 11:38:14 +02:00
Joas Schilling
0c6ef9aabf [ticket/12534] Do not use errorbox for multi steps
PHPBB3-12534
2014-05-12 11:35:59 +02:00
Joas Schilling
1d4c20b3d2 [ticket/12534] Do not abuse errorbox for en/disable confirmation of extensions
PHPBB3-12534
2014-05-12 10:49:52 +02:00
Andreas Fischer
bfacf2d6eb Merge pull request #2446 from nickvergessen/ticket/12518
[ticket/12518] Apply De Morgan to make the conditions easier reasable

* nickvergessen/ticket/12518:
  [ticket/12518] Apply De Morgan to make the conditions easier to read
2014-05-12 01:10:30 +02:00
Joas Schilling
8d20f095aa [ticket/12518] Apply De Morgan to make the conditions easier to read
PHPBB3-12518
2014-05-11 22:52:09 +02:00
Marc Alexander
92e25398c7 Merge remote-tracking branch 'nickvergessen/ticket/12518' into develop-ascraeus
* nickvergessen/ticket/12518:
  [ticket/12518] Add event to overwrite the cannot edit condition in posting.php
  [ticket/12518] Add event to overwrite the allow edit and delete conditions
2014-05-11 22:36:45 +02:00
Joas Schilling
b430979f60 [ticket/12518] Add event to overwrite the cannot edit condition in posting.php
PHPBB3-12518
2014-05-11 21:27:21 +02:00
Joas Schilling
aeb5189be0 [ticket/12518] Add event to overwrite the allow edit and delete conditions
PHPBB3-12518
2014-05-11 21:27:21 +02:00
Tristan Darricau
12e0e358d1 [ticket/11942] Apply the modifications to subsilver
PHPBB3-11942
2014-05-11 19:35:42 +02:00
Tristan Darricau
237619792d [ticket/11942] Always display delete reason
PHPBB3-11942
2014-05-11 19:28:26 +02:00
Matt Friedman
beab2c9252 [ticket/12531] Restore default topic link functionality in subsilver2
PHPBB3-12531
2014-05-11 10:27:47 -07:00
Joas Schilling
34e93b0e15 Merge pull request #2442 from Elsensee/ticket/12451-2
[ticket/12451] Fix whitespace in posting.php lang file

* Elsensee/ticket/12451-2:
  [ticket/12451] Fix whitespace in posting.php lang file
2014-05-11 18:57:34 +02:00
Oliver Schramm
cce6f7d4a6 [ticket/12451] Fix whitespace in posting.php lang file
PHPBB3-12451
2014-05-11 18:20:56 +02:00
Joas Schilling
8cdc6632ee Merge pull request #2438 from marc1706/ticket/12517
[ticket/12517] Correctly call $log->add in prune shadow topics

* marc1706/ticket/12517:
  [ticket/12517] Correctly call $log->add in prune shadow topics
2014-05-11 18:11:44 +02:00
Joas Schilling
e28b1a8389 Merge pull request #2439 from prototech/ticket/12526
[ticket/12526] Fix undefined index: filesize when editing PM with attachments.

* prototech/ticket/12526:
  [ticket/12526] Fix undefined index: filesize when editing PM with attachments.
2014-05-11 18:09:12 +02:00
Joas Schilling
f37ff48e2c Merge pull request #2441 from Nicofuma/ticket/12529
[ticket/12529] Use root_path in controller\resolver to check the template dir

* Nicofuma/ticket/12529:
  [ticket/12529] Move $phpbb_root_path to the end of the constructor
  [ticket/12529] Use root_path in controller\resolver to check the template dir
2014-05-11 15:47:13 +02:00
Tristan Darricau
16cd1db59a [ticket/12529] Move $phpbb_root_path to the end of the constructor
PHPBB3-12529
2014-05-11 15:10:14 +02:00
Tristan Darricau
197c801746 [ticket/12529] Use root_path in controller\resolver to check the template dir
PHPBB3-12529
2014-05-11 14:10:19 +02:00
Joas Schilling
192bb74e3c [ticket/12527] Use a proper language string on confirm screen
PHPBB3-12527
2014-05-11 13:30:13 +02:00
Joas Schilling
eaa4552412 [ticket/12527] Remove unnecessary language strings
PHPBB3-12527
2014-05-11 13:30:07 +02:00
Joas Schilling
ada9fc81a3 [ticket/12527] Check whether the language exists
PHPBB3-12527
2014-05-11 13:29:56 +02:00
Joas Schilling
63e195d7f0 [ticket/12527] Restore missing files and variables check
PHPBB3-12527
2014-05-11 13:29:49 +02:00
Joas Schilling
c334d8431d [ticket/12527] Remove editor from template
PHPBB3-12527
2014-05-11 13:29:44 +02:00
Joas Schilling
61bca8ed8a [ticket/12527] Remove language file editor form ACP
PHPBB3-12527
2014-05-11 13:29:17 +02:00
Cesar G
a7d1fd44ee [ticket/12526] Fix undefined index: filesize when editing PM with attachments.
PHPBB3-12526
2014-05-11 02:36:48 -07:00
Joas Schilling
f2fc18b4b7 Merge pull request #2412 from prototech/ticket/12501
[ticket/12501] Fix improper display of inline attachments in post report page

* prototech/ticket/12501:
  [ticket/12501] Only select attachments uploaded before the post was reported.
  [ticket/12501] Parse the reported post message before its attachments.
2014-05-11 11:00:27 +02:00
Joas Schilling
6cd7abe255 Merge pull request #2420 from prototech/ticket/9388
[ticket/9388] Only display the settings for the selected method in the auth and search ACP pages.

* prototech/ticket/9388:
  [ticket/9388] Use "togglable" instead of "toggable"
  [ticket/9388] Do not nest the <fieldset> tags in the OAuth settings.
  [ticket/9388] Reopen <fieldset> after auth templates.
  [ticket/9388] Fix unit tests.
  [ticket/9388] Use the new toggle function for the avatar type <select>.
  [ticket/9388] Display only the settings for the selected search backend.
  [ticket/9388] Display only the settings for the auth method that's selected.
  [ticket/9388] Add support for making <select> options able to toggle settings.
2014-05-11 10:48:10 +02:00
Joas Schilling
9aee2ed039 Merge pull request #2437 from rxu/ticket/12524
[ticket/12524] Add search.php core event to modify search results rowset

* rxu/ticket/12524:
  [ticket/12524] Add search.php core event to modify search results rowset
2014-05-11 10:42:46 +02:00
Marc Alexander
9a295e4845 [ticket/12517] Correctly call $log->add in prune shadow topics
PHPBB3-12517
2014-05-11 10:31:28 +02:00
Joas Schilling
135b76b643 Merge pull request #2340 from PayBas/ticket/12431
[ticket/12431] Add has_poll icon to topiclists

* PayBas/ticket/12431:
  [ticket/12431] Lang full sentence
  [ticket/12431] Add topic poll icon.
  [ticket/12431] Add has_poll icon to topiclists
2014-05-11 10:24:03 +02:00
Joas Schilling
61c92c07ee Merge pull request #2436 from rxu/ticket/12523
[ticket/12523] Add template events search_results_topic_(before/after)

* rxu/ticket/12523:
  [ticket/12523] Add template events search_results_topic_(before/after)
2014-05-11 10:19:49 +02:00
Joas Schilling
491d50a994 Merge pull request #2306 from marc1706/ticket/12407
[ticket/12407] Allow changing of post_data, etc. at end of posting.php

* marc1706/ticket/12407:
  [ticket/12407] Remove merge marker from posting.php
  [ticket/12407] Fix incorrect @since line in event
  [ticket/12407] Merge @change in doc block of event
  [ticket/12407] Assign template variables again after merging develop-ascraeus
  [ticket/12407] Add message_parser as passed variable to event
  [ticket/12407] Allow changing of post_data, etc. at end of posting.php
2014-05-11 10:16:44 +02:00
rxu
1b24d68971 [ticket/12524] Add search.php core event to modify search results rowset
Currently it is possible to change search results within the search row scope,
but it should be possible to modify/unset every individual row
within the rowset.

PHPBB3-12524
2014-05-11 16:10:54 +08:00
Joas Schilling
4147681640 Merge pull request #2435 from n-aleha/ticket/12522
[ticket/12522] Add function parameter description in guesser interface

* n-aleha/ticket/12522:
  [ticket/12522] Add function parameter description in guesser interface
2014-05-11 10:10:31 +02:00
Marc Alexander
e7923336fb [ticket/12407] Remove merge marker from posting.php
PHPBB3-12407
2014-05-11 10:10:26 +02:00
Joas Schilling
0871e649f6 Merge pull request #2428 from n-aleha/ticket/12476
[ticket/12476] Increase assets version on cache purge

* n-aleha/ticket/12476:
  [ticket/12476] Label the constructor as public
  [ticket/12476] Increase assets also from acp_styles and phpbbcli
  [ticket/12476] Increase asset version on cache purge
2014-05-11 10:03:30 +02:00
rxu
2d989acd0c [ticket/12523] Add template events search_results_topic_(before/after)
Add template events search_results_topic_(before/after)
to search_results.html.

PHPBB3-12523
2014-05-11 15:57:21 +08:00
Marc Alexander
0bc5e95198 [ticket/12407] Fix incorrect @since line in event
PHPBB3-12407
2014-05-11 09:40:26 +02:00
n-aleha
ca1ed19e45 [ticket/12522] Add function parameter description in guesser interface
Add parameter description for $file_name of the function guess in
guesser_interface

PHPBB3-12522
2014-05-11 02:27:14 +03:00
Tristan Darricau
ca5987ceb8 [ticket/12174] Coding style
PHPBB3-12174
2014-05-10 23:50:42 +02:00
Tristan Darricau
49bc10de4d [ticket/8610] Merging topics does not handle bookmarks correctly
https://tracker.phpbb.com/browse/PHPBB3-8610

PHPBB3-8610
2014-05-10 22:17:01 +02:00
Tristan Darricau
cee9b1d856 [ticket/11226] Use $user->lang()
PHPBB3-11226
2014-05-10 19:47:32 +02:00
Tristan Darricau
164f52c3f3 [ticket/10899] Remove extra ';'
PHPBB3-10899
2014-05-10 19:04:37 +02:00
Tristan Darricau
56aaba696f [ticket/10899] Typo
PHPBB3-10899
2014-05-10 18:25:24 +02:00
Tristan Darricau
c6d7875b9b [ticket/10899] Refactoring in \phpbb\log\log_interface
PHPBB3-10899
2014-05-10 18:24:07 +02:00
Andreas Fischer
d340d2fe25 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
2014-05-10 17:14:21 +02:00
Andreas Fischer
007f041a4a Merge pull request #2415 from nickvergessen/ticket/10839
Ticket/10839 Remove phpunit configuration files

* nickvergessen/ticket/10839:
  [ticket/10839] Remove version compare as the php minimum requirement is 5.3.3
  [ticket/10839] Fix note about running slow tests and build task
  [ticket/10839] Removing phpunit.xml.all
  [ticket/10839] Always run functional tests by default
2014-05-10 17:14:14 +02:00
Andreas Fischer
cc0446dc17 Merge pull request #2430 from nickvergessen/ticket/10839-olympus
[Ticket/10839] olympus - Remove phpunit configuration files

* nickvergessen/ticket/10839-olympus:
  [ticket/10839] Fix note about running slow tests and build task
  [ticket/10839] Removing phpunit.xml.all
  [ticket/10839] Always run functional tests by default
2014-05-10 17:14:00 +02:00
Tristan Darricau
c5a4ad3d31 [ticket/10899] Using Delete All in log viewer with keyword search
https://tracker.phpbb.com/browse/PHPBB3-10899

PHPBB3-10899
2014-05-10 17:03:09 +02:00
marcosbc
984ae598be [ticket/12270] No quote notif and double poster notification fix
Since a call was added to self::approve_topic(), the poster would
get double-notified about it (even if it was later marked as read).
Also, when creating a new topic with a quote, it would not be
notified, this has also been fixed.

PHPBB3-12270
2014-05-10 16:36:11 +02:00
Tristan Darricau
eee2091201 [ticket/11226] filespec::move_file() should error correctly
PHPBB3-11226
2014-05-10 15:09:25 +02:00
Tristan Darricau
9519c4e8c4 [ticket/12109] Fix coding style
PHPBB3-12109
2014-05-10 02:35:51 +02:00
Tristan Darricau
9b9c048702 [ticket/12109] Bug when setting permissions with "Select all users"
https://tracker.phpbb.com/browse/PHPBB3-12109

PHPBB3-12109
2014-05-10 01:53:51 +02:00
Cesar G
e233f0af36 [ticket/9388] Use "togglable" instead of "toggable"
PHPBB3-9388
2014-05-09 13:49:41 -07:00
Joas Schilling
f8fb65db63 [ticket/10839] Remove version compare as the php minimum requirement is 5.3.3
PHPBB3-10839
2014-05-09 11:22:58 +02:00
Joas Schilling
3b3f941f5f Merge branch 'ticket/10839-olympus' into ticket/10839
* ticket/10839-olympus:
  [ticket/10839] Fix note about running slow tests and build task
  [ticket/10839] Removing phpunit.xml.all
  [ticket/10839] Always run functional tests by default

Conflicts:
	phpunit.xml.dist
2014-05-09 11:22:30 +02:00
Joas Schilling
333120a992 [ticket/10839] Fix note about running slow tests and build task
PHPBB3-10839
2014-05-09 11:19:49 +02:00
Joas Schilling
8a9b1a8fed [ticket/10839] Removing phpunit.xml.all
To run all tests, just append
    --group slow
to your call

PHPBB3-10839
2014-05-09 11:19:48 +02:00
Joas Schilling
d6ac4a1130 [ticket/10839] Always run functional tests by default
They are skipped anyway, if $phpbb_functional_url is not configured.
If you want to run tests without functional tests, just append
    --exclude-group functional
to your call

PHPBB3-10839
2014-05-09 11:19:48 +02:00
Tristan Darricau
27cb84d3d4 [ticket/12174] Remove $update_topic_attachments_flag
PHPBB3-12174
2014-05-09 09:48:09 +02:00
marcosbc
867dc84c33 [ticket/12270] Fixed tests
PHPBB3-12270
2014-05-09 01:22:20 +02:00
n-aleha
5dacd7ff5b [ticket/12476] Label the constructor as public
Label the the constructor as public.

PHPBB3-12476
2014-05-09 01:50:52 +03:00
n-aleha
f2471878a6 [ticket/12476] Increase assets also from acp_styles and phpbbcli
Increase assets also from "ACP > Styles > Purge Cache" and phpbbcli

PHPBB3-12476
2014-05-09 01:50:51 +03:00
Tristan Darricau
93f901d078 [ticket/12174] Don't update the flag for a post without attachment
PHPBB3-12174
2014-05-09 00:50:34 +02:00
n-aleha
cfc0c9bcf9 [ticket/12476] Increase asset version on cache purge
Increace the asset version when purging the cache from "ACP > General"

PHPBB3-12476
2014-05-09 01:49:41 +03:00
Tristan Darricau
93d3c517e3 [ticket/12074] Update the visibility of the constructor
PHPBB3-12074
2014-05-09 00:48:34 +02:00
Tristan Darricau
712491697e [ticket/12174] Update the conditions
PHPBB3-12174
2014-05-09 00:46:56 +02:00
Tristan Darricau
a80ad5d00f [ticket/12174] Remove inline assignment
PHPBB3-12174
2014-05-09 00:31:53 +02:00
Tristan Darricau
3029f93000 [ticket/12074] Don't log errors
PHPBB3-12074
2014-05-09 00:26:07 +02:00
Tristan Darricau
f755f69606 [ticket/12174] Update sql query
PHPBB3-12174
2014-05-09 00:18:38 +02:00
Tristan Darricau
a640a455f3 [ticket/12074] Managing extensions doesn't produce any log entry
PHPBB3-12074
2014-05-09 00:07:56 +02:00
Cesar G
2ca01bdcbe [ticket/9388] Do not nest the <fieldset> tags in the OAuth settings.
PHPBB3-9388
2014-05-08 13:39:31 -07:00
Tristan Darricau
51c93aeb02 [ticket/12174] Revert the changes on $topic_update_array
PHPBB3-12174
2014-05-08 19:48:00 +02:00
Tristan Darricau
112e55e8ab [ticket/12174] Corrections
PHPBB3-12174
2014-05-08 19:07:18 +02:00
Marc Alexander
8121f87f08 Merge branch 'develop-ascraeus' of github.com:phpbb/phpbb into ticket/12407
* 'develop-ascraeus' of github.com:phpbb/phpbb: (424 commits)
  [ticket/12428] Use the database to store the original version number
  [ticket/12493] Add functional test
  [ticket/12493] Fix sql query for selection of users that have disabled PM
  [ticket/12513] Add asset include support to simple header/footer in ACP
  [ticket/12513] Add simple_header head event with support for CSS assets calls
  [ticket/12511] Add missing titles for profile fields in members group view
  [ticket/12428] Incorrect from version in database update log entry
  [ticket/12510] Convert & to &amp; in build_url() when no params are stripped.
  [ticket/12402] CAPTCHA plugin migration fails to detect missing plugins
  [ticket/12440] Use a more generic approach for replacing the URL.
  [ticket/12507] Move the 'require' statement
  [ticket/12507] Add console command to purge the cache
  [ticket/12421] Rebase and enable tests
  [ticket/12421] Don't parse [attachment] tags if user can't view them
  [ticket/12325] Use \RecursiveDirectoryIterator
  [ticket/12325] Doc blocks
  [ticket/12440] Set browser URL to point to specific post when using view=unread
  [ticket/12357] Support routes in generate_smilies() function.
  [ticket/12459] Change language strings
  [ticket/12504] Use local variables where possible
  ...

Conflicts:
	phpBB/posting.php
2014-05-08 18:43:46 +02:00
Cesar G
f95a7b0222 [ticket/9388] Reopen <fieldset> after auth templates.
PHPBB3-9388
2014-05-08 08:35:38 -07:00
Cesar G
0832d34192 [ticket/9388] Fix unit tests.
PHPBB3-9388
2014-05-08 08:35:38 -07:00
Cesar G
1836b01303 [ticket/9388] Use the new toggle function for the avatar type <select>.
PHPBB3-9388
2014-05-08 08:35:38 -07:00
Cesar G
e378037516 [ticket/9388] Display only the settings for the selected search backend.
PHPBB3-9388
2014-05-08 08:35:38 -07:00
Cesar G
d95164e641 [ticket/9388] Display only the settings for the auth method that's selected.
PHPBB3-9388
2014-05-08 08:35:38 -07:00
Cesar G
2e025f1655 [ticket/9388] Add support for making <select> options able to toggle settings.
PHPBB3-9388
2014-05-08 08:35:38 -07:00
PayBas
1cdff60676 [ticket/12431] Lang full sentence
PHPBB3-12431
2014-05-08 15:27:27 +02:00
Joas Schilling
d4fc060bcd Merge pull request #2363 from Elsensee/ticket/12451
[ticket/12451] Split lang vars in posting.php for plurals

* Elsensee/ticket/12451:
  [ticket/12451] Remove duplicated lang var
  [ticket/12451] Use new line to concatenate strings
  [ticket/12451] Split TOO_MANY_CHARS vars for plurals
  [ticket/12451] Split TOO_FEW_CHARS_LIMIT for plurals
2014-05-08 15:10:34 +02:00
Joas Schilling
44d593ad85 Merge pull request #2360 from Nicofuma/ticket/12025
[ticket/12025] Post Preview no longer shows warnings

* Nicofuma/ticket/12025:
  [ticket/12025] Apply DeMorgan
  [ticket/12025] Fixing the condition....
  [ticket/12025] Don't show any error on preview if the message is empty
  [ticket/12025] Post Preview no longer shows warnings
2014-05-08 14:41:49 +02:00
Joas Schilling
5f2b0fba1e Merge pull request #2410 from Nicofuma/ticket/12325
[ticket/12325] Generate the list of the deleted files and folders

* Nicofuma/ticket/12325:
  [ticket/12325] Use \RecursiveDirectoryIterator
  [ticket/12325] Doc blocks
  [ticket/12325] Change private function to protected
  [ticket/12325] Add visibilities
  [ticket/12325] Add files located in deleted dirs
  [ticket/12325] Generate the list of the deleted files and folders
2014-05-08 14:22:01 +02:00
Joas Schilling
dcfb4cacd8 Merge pull request #2408 from prototech/ticket/12500
[ticket/12500] Set a title attribute in user.img()

* prototech/ticket/12500:
  [ticket/12500] Set a title attribute in user.img()
2014-05-08 13:27:33 +02:00
Joas Schilling
e976f7908a Merge pull request #2414 from prototech/ticket/12440
[ticket/12440] Set browser URL to point to specific post when using view=unread

* prototech/ticket/12440:
  [ticket/12440] Use a more generic approach for replacing the URL.
  [ticket/12440] Set browser URL to point to specific post when using view=unread

Conflicts:
	phpBB/styles/prosilver/template/viewtopic_body.html
2014-05-08 13:23:12 +02:00
Joas Schilling
416c58a418 Merge pull request #2418 from Nicofuma/ticket/12402
[ticket/12402] CAPTCHA plugin migration fails to detect missing plugins

* Nicofuma/ticket/12402:
  [ticket/12402] CAPTCHA plugin migration fails to detect missing plugins
2014-05-08 13:13:15 +02:00
Joas Schilling
aade62b0a3 Merge pull request #2419 from prototech/ticket/12510
[ticket/12510] Convert & to &amp; in build_url() when no params are stripped.

* prototech/ticket/12510:
  [ticket/12510] Convert & to &amp; in build_url() when no params are stripped.
2014-05-08 13:02:01 +02:00
Joas Schilling
0c3c77c6bf Merge pull request #2422 from Nicofuma/ticket/12428
[ticket/12428] Incorrect from version in database update log entry

* Nicofuma/ticket/12428:
  [ticket/12428] Use the database to store the original version number
  [ticket/12428] Incorrect from version in database update log entry
2014-05-08 12:56:59 +02:00
Joas Schilling
ef99d6fcc5 Merge pull request #2423 from rxu/ticket/12511
[ticket/12511] Add missing titles for profile fields in members group view

* rxu/ticket/12511:
  [ticket/12511] Add missing titles for profile fields in members group view
2014-05-08 12:32:04 +02:00
Joas Schilling
03f3f1141f Merge pull request #2424 from VSEphpbb/ticket/12513
[ticket/12513] Add simple_header head event with support for asset calls

* VSEphpbb/ticket/12513:
  [ticket/12513] Add asset include support to simple header/footer in ACP
  [ticket/12513] Add simple_header head event with support for CSS assets calls
2014-05-08 12:28:53 +02:00
Joas Schilling
48a170549c Merge pull request #2421 from n-aleha/ticket/12493
[ticket/12493] Fix sql query for selection of users that have disabled PM

* n-aleha/ticket/12493:
  [ticket/12493] Add functional test
  [ticket/12493] Fix sql query for selection of users that have disabled PM
2014-05-08 12:22:49 +02:00
Tristan Darricau
7935388306 [ticket/12174] Update topic_attachment flag when a post is soft-deleted
https://tracker.phpbb.com/browse/PHPBB3-12174

PHPBB3-12174
2014-05-08 01:43:56 +02:00
Tristan Darricau
32efd5de73 [ticket/12428] Use the database to store the original version number
PHPBB3-12428
2014-05-07 23:04:41 +02:00
n-aleha
83a905de4b [ticket/12493] Add functional test
Added a functional test.

PHPBB3-12493
2014-05-07 23:00:50 +03:00
n-aleha
0166493a89 [ticket/12493] Fix sql query for selection of users that have disabled PM
This fixes a bug where a user A could not send a PM to user B when both users
allowed other users to send them a PM. More precisely, it fixes the selection
of users that either are inactive or have disabled private messages.

PHPBB3-12493
2014-05-07 23:00:42 +03:00
Joas Schilling
077c7cf7aa Merge pull request #2400 from PayBas/ticket/12488
[ticket/12488] Add user warning indication to viewtopic posts

* PayBas/ticket/12488:
  [ticket/12488] subSilver2 fix (no longer displays if warnings = 0)
  [ticket/12488] Typo fix
  [ticket/12488] Removed <em> and removed anonymous check
  [ticket/12488] Add user warning indication to viewtopic posts
2014-05-07 21:17:04 +02:00
Joas Schilling
7294bc9402 Merge pull request #2413 from prototech/ticket/12357
[ticket/12357] Support routes in generate_smilies() function.

* prototech/ticket/12357:
  [ticket/12357] Support routes in generate_smilies() function.
2014-05-07 21:08:10 +02:00
Matt Friedman
d2c5386394 [ticket/12513] Add asset include support to simple header/footer in ACP
PHPBB3-12513
2014-05-07 11:59:49 -07:00
Matt Friedman
8fda490050 [ticket/12513] Add simple_header head event with support for CSS assets calls
PHPBB3-12513
2014-05-07 11:53:25 -07:00
rxu
4b54d0b4af [ticket/12511] Add missing titles for profile fields in members group view
For memberlist group view in cases the group is presented with the group leader
and group members, for members profile fields titles are missing: Posts,
Joined, Last active and custom profile fields titles.

PHPBB3-12511
2014-05-07 23:31:09 +08:00
Tristan Darricau
e0dbbfb4af [ticket/12428] Incorrect from version in database update log entry
https://tracker.phpbb.com/browse/PHPBB3-12428

PHPBB3-12428
2014-05-07 02:07:30 +02:00
Cesar G
eddb420375 [ticket/12510] Convert & to &amp; in build_url() when no params are stripped.
PHPBB3-12510
2014-05-06 15:58:10 -07:00
Tristan Darricau
290a1b04c4 [ticket/12402] CAPTCHA plugin migration fails to detect missing plugins
PHPBB3-12402
2014-05-06 23:36:37 +02:00
Cesar G
3c86a9bcca Merge remote-tracking branch 'Elsensee/ticket/suheb/12185' into develop-ascraeus
* Elsensee/ticket/suheb/12185:
  [ticket/12185] Fix and increase width
  [ticket/12185] Fixing the width of topic header for translation.
2014-05-06 13:56:09 -07:00
Cesar G
ed14d12d14 [ticket/12440] Use a more generic approach for replacing the URL.
PHPBB3-12440
2014-05-06 13:34:12 -07:00
Joas Schilling
6d40d437eb Merge pull request #2330 from Nicofuma/ticket/12421
[ticket/12421] Don't parse [attachment] tags if user can't view them

* Nicofuma/ticket/12421:
  [ticket/12421] Rebase and enable tests
  [ticket/12421] Don't parse [attachment] tags if user can't view them
2014-05-06 21:50:42 +02:00
Andreas Fischer
0d4a7d76f4 Merge pull request #2416 from Nicofuma/ticket/12507
[ticket/12507] Add console command to purge the cache

* Nicofuma/ticket/12507:
  [ticket/12507] Move the 'require' statement
  [ticket/12507] Add console command to purge the cache
2014-05-06 18:33:40 +02:00
Tristan Darricau
09011288b6 [ticket/12507] Move the 'require' statement
PHPBB3-12507
2014-05-06 17:58:31 +02:00
Tristan Darricau
06ecb62abd [ticket/12507] Add console command to purge the cache
PHPBB3-12507
2014-05-06 16:50:18 +02:00
Tristan Darricau
62b4e7b9d2 [ticket/12421] Rebase and enable tests
PHPBB3-12421
2014-05-06 14:54:22 +02:00
Tristan Darricau
f4df3f0aaf [ticket/12421] Don't parse [attachment] tags if user can't view them
https://tracker.phpbb.com/browse/PHPBB3-12421

PHPBB3-12421
2014-05-06 14:19:55 +02:00
Dhruv Goel
571d6ae852 Merge pull request #2411 from nickvergessen/ticket/12503
[ticket/12503] Fix several errors in test suite
2014-05-06 17:49:23 +05:30
Tristan Darricau
e4beea0c1e [ticket/12325] Use \RecursiveDirectoryIterator
PHPBB3-12325
2014-05-06 14:04:06 +02:00
Joas Schilling
c7d29fbdb1 Merge pull request #2373 from Nicofuma/ticket/12459
[ticket/12459] Unapproved posts/topics are not correctly handled in feeds

* Nicofuma/ticket/12459:
  [ticket/12459] Change language strings
  [ticket/12459] Enable related tests
  [ticket/12459] Fix: Differentiating unapproved and deleted posts
  [ticket/12459] Fix: Soft deleted topics should appear in feeds
  [ticket/12459] Fix: the posts were always marked as unapproved
2014-05-06 13:59:09 +02:00
Joas Schilling
1b3d54f5dd Merge pull request #2397 from Nicofuma/ticket/11497
[ticket/11497] Remove 'ext.finder' from services' list

* Nicofuma/ticket/11497:
  [ticket/11497] Rename set_ext_finder in find_routing_files
  [ticket/11497] Change the date in the package declaration
  [ticket/11497] Fix pagination tests
  [ticket/11497] Use a mock object to define the root folder for the finder
  [ticket/11497] Generate the list of the routes in controller_helper
  [ticket/11497] Fix the path for the finder in controller_provider
  [ticket/11497] Fix tests
  [ticket/11497] Update pagination test
  [ticket/11497] Remove 'ext.finder' from services' list
2014-05-06 13:51:29 +02:00
Tristan Darricau
cd5129f261 [ticket/12325] Doc blocks
PHPBB3-12325
2014-05-06 10:53:54 +02:00
Cesar G
71379c3a0f Merge remote-tracking branch 'VSEphpbb/ticket/12332' into develop-ascraeus
* VSEphpbb/ticket/12332:
  [ticket/12332] Add missing semicolon to inline styling
  [ticket/12332] Adjust size of mark column where too wide
  [ticket/12332] Adjust column widths for responsive changes
  [ticket/12332] Restore some changes back to original state
  [ticket/12332] Add break-word to fixed width table CSS
  [ticket/12332] Accomplish all word creaking in template and CSS
  [ticket/12332] Remove width sizing, as it is already set
  [ticket/12332] Fix displaying attachments with long file names
2014-05-05 16:51:29 -07:00
Cesar G
698d8551cf Merge remote-tracking branch 'Crizz0/ticket/12498' into develop-ascraeus
* Crizz0/ticket/12498:
  [ticket/12498] Adds height-property for IE8 in tweaks.css
2014-05-05 16:45:44 -07:00
Cesar G
7475e05f99 [ticket/12440] Set browser URL to point to specific post when using view=unread
PHPBB3-12440
2014-05-05 16:33:27 -07:00
Cesar G
74cb99f067 [ticket/12357] Support routes in generate_smilies() function.
PHPBB3-12357
2014-05-05 13:13:48 -07:00
Cesar G
7b0e535f03 [ticket/12501] Only select attachments uploaded before the post was reported.
The post text displayed to the user is the same as when it was reported, even if
the post was edited afterwards, thus it follows that the attachments would be
the same. This also addresses an issue where the index in the attachment bbcode
no longer matches that of its corresponding attachment when new attachments
are uploaded after the post is reported.

PHPBB3-12501
2014-05-05 11:05:15 -07:00
Cesar G
9705e1883d [ticket/12501] Parse the reported post message before its attachments.
This ensures that the empty lines from attachment.html aren't converted into
<br />.

PHPBB3-12501
2014-05-05 11:05:15 -07:00
Tristan Darricau
717f8a6671 [ticket/12459] Change language strings
PHPBB3-12459
2014-05-05 18:58:15 +02:00
Joas Schilling
d9de4fc72c [ticket/12504] Use local variables where possible
PHPBB3-12504
2014-05-05 18:31:01 +02:00
Joas Schilling
f27e4a44b8 [ticket/12504] Use defined variables
PHPBB3-12504
2014-05-05 18:27:00 +02:00
Joas Schilling
5d8d42d88a [ticket/12504] Remove unused request object from avatar manager test
PHPBB3-12504
2014-05-05 18:25:44 +02:00
Tristan Darricau
0061067715 [ticket/12025] Apply DeMorgan
PHPBB3-12025
2014-05-05 18:23:55 +02:00
Joas Schilling
fe99e60d82 [ticket/12486] Make assertion on the return to remove "Risky" from phpunit
PHPBB3-12486
2014-05-05 18:21:28 +02:00
Tristan Darricau
346c6f3998 [ticket/11497] Rename set_ext_finder in find_routing_files
PHPBB3-11497
2014-05-05 18:20:14 +02:00
Joas Schilling
e9dabb0903 [ticket/12486] Rename data provider to fix "Risky" from phpunit
PHPBB3-12486
2014-05-05 18:19:12 +02:00
Joas Schilling
baef26f7ed [ticket/12503] All tests should extend \phpbb_test_case
PHPBB3-12503
2014-05-05 18:16:50 +02:00
Tristan Darricau
21f06ac9e6 [ticket/12325] Change private function to protected
PHPBB3-12325
2014-05-05 18:16:42 +02:00
Tristan Darricau
f6a8485dae [ticket/12325] Add visibilities
PHPBB3-12325
2014-05-05 16:38:21 +02:00
Tristan Darricau
81ac5e7a00 [ticket/12325] Add files located in deleted dirs
PHPBB3-12325
2014-05-05 16:38:21 +02:00
Tristan Darricau
c5f5520013 [ticket/12325] Generate the list of the deleted files and folders
https://tracker.phpbb.com/browse/PHPBB3-12325

PHPBB3-12325
2014-05-05 16:38:21 +02:00
Joas Schilling
324daf72fe Merge pull request #2409 from prototech/ticket/12491
[ticket/12491] Fix clashing USERNAME_FULL template variable.

* prototech/ticket/12491:
  [ticket/12491] Fix clashing USERNAME_FULL template variable.
2014-05-05 12:36:50 +02:00
PayBas
4d64e09e7a [ticket/12488] subSilver2 fix (no longer displays if warnings = 0)
Don't know what I was thinking with this

PHPBB3-12488
2014-05-05 09:38:00 +02:00
Cesar G
a4aeb91ec0 [ticket/12491] Fix clashing USERNAME_FULL template variable.
The user notes and user warn pages have a variable with the same name.

PHPBB3-12491
2014-05-04 15:31:19 -07:00
Cesar G
fad41a6874 [ticket/12500] Set a title attribute in user.img()
PHPBB3-12500
2014-05-04 14:30:51 -07:00
Cesar G
0cc5cf57b2 Merge remote-tracking branch 'MGaetan89/ticket/12415' into develop-ascraeus
* MGaetan89/ticket/12415:
  [ticket/12415] Use private message instead of "pm" accronym
2014-05-04 13:55:14 -07:00
Andreas Fischer
0f4bff6101 Merge pull request #2407 from Nicofuma/ticket/12499
[ticket/12499] Incorrect call to phpbb\log\log::add() in db:migrate

* Nicofuma/ticket/12499:
  [ticket/12499] Incorrect call to phpbb\log\log::add() in db:migrate
2014-05-04 22:38:46 +02:00
Tristan Darricau
66b7eaa1ca [ticket/12499] Incorrect call to phpbb\log\log::add() in db:migrate
https://tracker.phpbb.com/browse/PHPBB3-12499

PHPBB3-12499
2014-05-04 22:20:22 +02:00
PayBas
172fa9e7aa [ticket/12488] Typo fix
PHPBB3-12488
2014-05-04 22:19:55 +02:00
PayBas
cefeb7f752 [ticket/12488] Removed <em> and removed anonymous check
PHPBB3-12488
2014-05-04 22:07:03 +02:00
PayBas
d6c1ca7d94 Merge pull request #4 from prototech/ticket/12431
[ticket/12431] Add topic poll icon.
2014-05-04 21:42:15 +02:00
Cesar G
2e6413a522 [ticket/12431] Add topic poll icon.
PHPBB3-12431
2014-05-04 12:34:51 -07:00
Joas Schilling
6cca7d0443 Merge branch 'prep-release-3.1.0-b3' into develop-ascraeus
* prep-release-3.1.0-b3:
  [prep-release-3.1.0-b3] Update phpBB Version for b4 development
  [prep-release-3.1.0-b3] Add changelog for 3.1.0-b3
  [prep-release-3.1.0-b3] Prepare Changelog
  [prep-release-3.1.0-b3] Add migration for 3.1.0-b3
  [prep-release-3.1.0-b3] Update version to 3.1.0-b3
2014-05-04 20:25:11 +02:00
Joas Schilling
a469974c85 [prep-release-3.1.0-b3] Update phpBB Version for b4 development 2014-05-04 20:23:33 +02:00
Crizzo
2c8cb4dd60 [ticket/12498] Adds height-property for IE8 in tweaks.css
PHPBB3-12498
2014-05-04 18:58:27 +02:00
Joas Schilling
4f5ab1e5e7 [prep-release-3.1.0-b3] Add changelog for 3.1.0-b3 2014-05-04 17:47:19 +02:00
Joas Schilling
324a30315c [prep-release-3.1.0-b3] Prepare Changelog 2014-05-04 17:36:59 +02:00
Gaëtan Muller
eccdc74478 [ticket/12415] Use private message instead of "pm" accronym
https://tracker.phpbb.com/browse/PHPBB3-12415

PHPBB3-12415
2014-05-04 17:35:06 +02:00
Joas Schilling
eca1e582d0 [prep-release-3.1.0-b3] Add migration for 3.1.0-b3 2014-05-04 17:34:02 +02:00
Joas Schilling
80d113f688 [prep-release-3.1.0-b3] Update version to 3.1.0-b3 2014-05-04 17:27:20 +02:00
Joas Schilling
5b6bce89c9 Merge pull request #2405 from Nicofuma/ticket/12494
[ticket/12494] Undefined index: user_type on viewtopic.php

* Nicofuma/ticket/12494:
  [ticket/12494] Undefined index: user_type on viewtopic.php
2014-05-04 16:43:47 +02:00
Joas Schilling
541de3281a Merge pull request #2394 from VSEphpbb/ticket/12484
[ticket/12484] Add template event ucp_agreement_terms_before/after

* VSEphpbb/ticket/12484:
  [ticket/12484] Add template event ucp_agreement_terms_before/after
2014-05-04 16:41:19 +02:00
Joas Schilling
40e28ac56b Merge pull request #2315 from PayBas/ticket/12411
[ticket/12411] Expand vars of event: core.search_modify_tpl_ary

* PayBas/ticket/12411:
  [ticket/12411] Improved change documentation
  [ticket/12411] Missed on bool var
  [ticket/12411] Corrected event vars description
  [ticket/12411] Expand vars of event: core.search_modify_tpl_ary
2014-05-04 16:35:03 +02:00
Joas Schilling
1e66500d2c Merge pull request #2294 from PayBas/ticket/12392
[ticket/12392] Include $profile_fields in core.memberlist_view_profile

* PayBas/ticket/12392:
  [ticket/12392] Fix avatar double assignment bug
  [ticket/12392] Include $profile_fields in core.memberlist_view_profile
2014-05-04 16:31:46 +02:00
Joas Schilling
b5ce72d8d9 Merge pull request #2257 from PayBas/ticket/12366
[ticket/12366] Add Event core.search_get_posts_data

* PayBas/ticket/12366:
  [ticket/12366] Fixed missing comma
  [ticket/12366] Conform to new event coding guidelines
  [ticket/12366] Expanded event vars
  [ticket/12366] Include ORDER BY into the query builder
  [ticket/12366] Changed to sql_build_query
  [ticket/12366] Add Event core.search_get_posts_data
2014-05-04 16:28:43 +02:00
Joas Schilling
b1d30dad5c Merge pull request #2203 from PayBas/ticket/12323
[ticket/12323] Template Event search_results_postprofile_before/after

* PayBas/ticket/12323:
  [ticket/12323] Template Event search_results_postprofile_before

Conflicts:
	phpBB/docs/events.md
2014-05-04 16:23:14 +02:00
Tristan Darricau
20022f0dc8 [ticket/12494] Undefined index: user_type on viewtopic.php
PHPBB3-12494
2014-05-04 16:15:50 +02:00
Joas Schilling
3674f95e52 Merge pull request #2346 from PayBas/ticket/12438
[ticket/12438] Add Template event memberlist_view_content_prepend

* PayBas/ticket/12438:
  [ticket/12438] Add Template event memberlist_view_content_prepend
2014-05-04 16:14:20 +02:00
Joas Schilling
eb52028334 Merge pull request #2314 from PayBas/ticket/12410
[ticket/12410] Add Template events search_results_post_ b/a

* PayBas/ticket/12410:
  [ticket/12410] Add Template events search_results_post_ b/a
2014-05-04 16:11:56 +02:00
Joas Schilling
f615d46261 Merge pull request #2297 from PayBas/ticket/12396
[ticket/12396] Add Template events viewforum_forum_name_append/prepend

* PayBas/ticket/12396:
  [ticket/12396] Added missing viewtopic_topic_title_append
  [ticket/12396] Add Template events viewforum_forum_name
2014-05-04 16:09:18 +02:00
Joas Schilling
28f2c1eb08 Merge pull request #2273 from PayBas/ticket/12376
[ticket/12376] Add template events viewtopic_body_polls

* PayBas/ticket/12376:
  [ticket/12376] Changed to viewtopic_body_poll_option_before and after
  [ticket/12376] Added viewtopic_body_poll_question_append
  [ticket/12376] Add template events viewtopic_body_polls
2014-05-04 15:58:33 +02:00
Joas Schilling
587a9445cd Merge pull request #2270 from PayBas/ticket/12374
[ticket/12374] Add Template events index_body_block_(name)_append

* PayBas/ticket/12374:
  [ticket/12374] Fixed alphabetical sorting
  [ticket/12374] Added prepend-versions of events
  [ticket/12374] Updated code layout
  [ticket/12374] Add Template events index_body_block_(name)_append
2014-05-04 15:55:44 +02:00
Joas Schilling
96394bb044 Merge pull request #2233 from PayBas/ticket/12346
[ticket/12346] Add Template Event overall_header_navlink_append/prepend

* PayBas/ticket/12346:
  [ticket/12346] Change tabs to spaces
  [ticket/12346] Add Template Event overall_header_navlink_app/pre
2014-05-04 15:52:26 +02:00
Joas Schilling
329c2d9292 Merge pull request #2219 from PayBas/ticket/12335
[ticket/12335] Add Events to phpbb\profilefields\manager

* PayBas/ticket/12335:
  [ticket/12335] Remove $ from desc
  [ticket/12335] Added generate_profile_fields _ before
  [ticket/12335] Documentation fix and added use_contact_fields
  [ticket/12335] Fix phpBB version number
  [ticket/12335] Add Events to phpbb\profilefields\manager
2014-05-04 15:48:05 +02:00
Nicofuma
f90e6649f7 [ticket/12459] Enable related tests
PHPBB3-12459
2014-05-04 15:44:15 +02:00
Tristan Darricau
3bf61d4df0 [ticket/12459] Fix: Differentiating unapproved and deleted posts
Unapproved and deleted posts should not be displayed with the same message
(POST_UNAPPROVED)

PHPBB3-12459
2014-05-04 15:44:13 +02:00
Tristan Darricau
9dc4e5a61f [ticket/12459] Fix: Soft deleted topics should appear in feeds
As for the posts, a soft deleted topic should appear (with a corresponding
message) in topic's based feeds.

PHPBB3-12459
2014-05-04 15:44:12 +02:00
Tristan Darricau
68293450f9 [ticket/12459] Fix: the posts were always marked as unapproved
the database return a string, so the strict comparison always returned false

PHPBB3-12459
2014-05-04 15:44:10 +02:00
Joas Schilling
a1561fffba Merge pull request #2402 from MGaetan89/ticket/12378
[ticket/12378] Prosilver common.css duplicate entry

* MGaetan89/ticket/12378:
  [ticket/12378] Prosilver common.css duplicate entry
2014-05-04 15:44:00 +02:00
Nicofuma
cc1a304da6 [ticket/11942] Edits messages
PHPBB3-11942
2014-05-04 15:43:13 +02:00
Nicofuma
fee4e61933 [ticket/11942] Change the formulation
PHPBB3-11942
2014-05-04 15:43:11 +02:00
Nicofuma
1c336c3559 [ticket/11942] Adding the reason to hard deleted topic/post
PHPBB3-11942
2014-05-04 15:43:08 +02:00
Nicofuma
dccc9ceeb5 [ticket/11942] Delete post/topic reason should be added to logs
https://tracker.phpbb.com/browse/PHPBB3-11942

PHPBB3-11942
2014-05-04 15:43:06 +02:00
Gaëtan Muller
05491b0050 [ticket/12378] Prosilver common.css duplicate entry
https://tracker.phpbb.com/browse/PHPBB3-12378

PHPBB3-12378
2014-05-04 15:40:35 +02:00
Joas Schilling
59da8eb46a Merge pull request #2401 from n-aleha/ticket/12455
[ticket/12455] Remove unused language strings from common.php and app.php

* n-aleha/ticket/12455:
  [ticket/12455] Remove unused language strings from common.php and app.php
2014-05-04 15:38:02 +02:00
n-aleha
e6b312221c [ticket/12455] Remove unused language strings from common.php and app.php
Removed the following unused language strings from common.php:
EXTENSION_CONTROLLER_MISSING
EXTENSION_CLASS_WRONG_TYPE

Removed the following unused language strings from app.php:
CONTROLLER_NOT_FOUND
CONTROLLER_SERVICE_NOT_GIVEN
CONTROLLER_RETURN_TYPE_INVALID

PHPBB3-12455
2014-05-04 13:38:06 +03:00
PayBas
2c5a2a1390 [ticket/12488] Add user warning indication to viewtopic posts
PHPBB3-12488
2014-05-03 23:07:30 +02:00
PayBas
78834e49e4 [ticket/12346] Change tabs to spaces
PHPBB3-12346
2014-05-03 21:45:48 +02:00
marcosbc
deba1329c8 [ticket/12270] Fixed rebase conflicts
PHPBB3-12270
2014-05-03 21:05:29 +02:00
marcosbc
46c658bdbf [ticket/12270] Correct confirm approval message for topics
When clicking on approving a topic's first post in the MCP to
approve the topic itself, the confirm box dialog asks whether
to approve the post or not, instead of asking to approve the
topic.
To achieve this fix, we just need to count the topics to be
approved and check if it's greater than zero.

PHPBB3-12270
2014-05-03 20:31:32 +02:00
marcosbc
1fec5e6967 [ticket/12270] Correcting to follow phpBB coding standards
I forgot to put the brackets (so it follows the phpBB coding
standards) and changed "count($topic_id_list) > 0"
to "!empty($topic_id_list)", making the syntax more
comprehensible.

PHPBB3-12270
2014-05-03 20:31:32 +02:00
marcosbc
f9edc85f82 [ticket/12270] Better structured code and no debug error message
A variable (that's not essential) has been removed, two if's
has been merged to an if-else control structure. A variable
named topic_ids_list has been renamed to topic_id_list to follow
the naming standard in that file's code.
Also, the debug error has been fixed by changing the topic data
key 'username' to 'post_username' in the array_merge function
in approve_topics().

PHPBB3-12270
2014-05-03 20:31:22 +02:00
marcosbc
158705cf41 [ticket/12270] Correct notifications for posts/topics now working
This patch should finally work correctly: Add the correct
notification for post/topic approval without touching templates.

This has been done by calling the function approve_topics()
inside the approve_posts() function. It's the simplest way for
this to work correctly. There may be a call to the DB but other
ways (if any), without touching templates,  would have been too
messy for a function like this.

PHPBB3-12270
2014-05-03 20:30:51 +02:00
marcosbc
b8477ad3a2 [ticket/12270] Reverted templates
Some lines in the templates  were not reverted correctly,
so it's done now.

PHPBB3-12270
2014-05-03 20:29:28 +02:00
marcosbc
55757ddc65 [ticket/12270] Correct post&topic approval msg, no template changes
Following the previous commits, this patch removes the changes
done to templates to depend only on code, as suggested by
@nickvergessen.
All previous modifications have been removed, with another one
which checks, in the approve_posts() function, if it is sending a
notification for post approval and it is the first one in the
topic, send notification indicating that the topic has been
approved (and not the post). If not the first post in the topic,
do just as before (send a notification about a newly approved
post).

PHPBB3-12270
2014-05-03 20:29:28 +02:00
marcosbc
7446361ad4 [ticket/12270] Corrent post and topic approval notification message
When you submit a post with needed approval (say user A), and then
it gets approved by another user (user B), a subscribed user (user C)
to that forum would receive a notification indicating:
-A has replied to topic 'New Topic' in the forum 'xyz'.
The expected result would be:
-A has posted a new topic 'New topic' in the forum 'xyz'.
This has fixed by adding a TOPIC_ID template variable to
mcp_post.html and, in there, depending if the first post is the topic's
first post or not, add a input's with name topic_id_list[] or
post_id_list[] and then the respective value (TOPIC_ID or POST_ID).

PHPBB3-12270
2014-05-03 20:29:28 +02:00
Tristan Darricau
78e1d119f5 [ticket/11497] Change the date in the package declaration
PHPBB3-11497
2014-05-03 19:16:40 +02:00
PayBas
1a39f5f6b9 [ticket/12346] Add Template Event overall_header_navlink_app/pre
Rebased

PHPBB3-12346
2014-05-03 18:21:15 +02:00
PayBas
1c84cea394 [ticket/12323] Template Event search_results_postprofile_before
PHPBB3-12323
2014-05-03 17:56:13 +02:00
PayBas
5b5b61c6c9 [ticket/12335] Remove $ from desc
Come on travis, play nice this time

PHPBB3-12335
2014-05-03 17:54:38 +02:00
PayBas
42dfd1aa3c [ticket/12335] Added generate_profile_fields _ before
PHPBB3-12335
2014-05-03 17:54:38 +02:00
PayBas
2343d9f8d4 [ticket/12335] Documentation fix and added use_contact_fields
PHPBB3-12335
2014-05-03 17:54:37 +02:00
PayBas
1fd1803a3b [ticket/12335] Fix phpBB version number
PHPBB3-12335
2014-05-03 17:54:37 +02:00
PayBas
b3b0e5ccf2 [ticket/12335] Add Events to phpbb\profilefields\manager
PHPBB3-12335
2014-05-03 17:54:36 +02:00
PayBas
aa5adbf1f7 [ticket/12374] Fixed alphabetical sorting
PHPBB3-12374
2014-05-03 17:50:31 +02:00
PayBas
8186e282f1 [ticket/12374] Added prepend-versions of events
PHPBB3-12374
2014-05-03 17:50:31 +02:00
PayBas
bb7941a52b [ticket/12374] Updated code layout
PHPBB3-12374
2014-05-03 17:50:30 +02:00
PayBas
a14930466b [ticket/12374] Add Template events index_body_block_(name)_append
Hopefully to the correct branch this time

PHPBB3-12374
2014-05-03 17:50:30 +02:00
PayBas
36aa8ecad8 [ticket/12376] Changed to viewtopic_body_poll_option_before and after
PHPBB3-12376
2014-05-03 17:48:31 +02:00
PayBas
21c11c7b24 [ticket/12376] Added viewtopic_body_poll_question_append
PHPBB3-12376
2014-05-03 17:43:06 +02:00
PayBas
4e79764aca [ticket/12376] Add template events viewtopic_body_polls
PHPBB3-12376
2014-05-03 17:42:13 +02:00
PayBas
59ba62f5d9 [ticket/12396] Added missing viewtopic_topic_title_append
rebased for travis... again

PHPBB3-12396
2014-05-03 17:37:49 +02:00
PayBas
a1b159aa82 [ticket/12396] Add Template events viewforum_forum_name
PHPBB3-12396
2014-05-03 17:29:54 +02:00
PayBas
530d09204c [ticket/12410] Add Template events search_results_post_ b/a
PHPBB3-12410
2014-05-03 17:25:36 +02:00
Joas Schilling
b60108dc78 Merge pull request #2267 from prototech/ticket/10737
[ticket/10737] Add  live member search.

* prototech/ticket/10737:
  [ticket/10737] Remove loading indicator.
  [ticket/10737] Enforce allow_live_searches setting in memberlist.php.
  [ticket/10737] Add config setting to disable live searches.
  [ticket/10737] Add loading indicator and alert box code to simple_footer.html.
  [ticket/10737] Load core.js and ajax.js in simple_footer.html.
  [ticket/10737] Set the username as the input value instead of redirecting.
  [ticket/10737] Drop subsilver2 changes.
  [ticket/10737] Add a more generic live search implementation.
  [ticket/10737] Clean up memberlist.php.
  [ticket/10737] Use dropdown for search results container.
  [ticket/10737] Adding delayed keyup and removing target_blank.
  [ticket/10737] Using UTF-8 aware alternatives in PHP code.
  [ticket/10737] Removing obsolete code.
  [ticket/10737] Avoid hard-coding table row and use case-insensitive search.
  [ticket/10737] Removing unnecessary/obsolete code.
  [ticket/10737] Using JQuery events and JSON response.
  [ticket/10737] Code fixes in AJAX search feature
  [ticket/10737] Improvements over last commit
  [ticket/10737] Adding username suggestions in "Find a member" using AJAX
2014-05-03 16:39:31 +02:00
Oliver Schramm
b7fde76852 [ticket/12451] Remove duplicated lang var
PHPBB3-12451
2014-05-03 16:16:17 +02:00
Oliver Schramm
1f76a95bf6 [ticket/12451] Use new line to concatenate strings
PHPBB3-12451
2014-05-03 16:16:16 +02:00
Oliver Schramm
d7c0d604b5 [ticket/12451] Split TOO_MANY_CHARS vars for plurals
PHPBB3-12451
2014-05-03 16:16:15 +02:00
Oliver Schramm
daa69ecfa9 [ticket/12451] Split TOO_FEW_CHARS_LIMIT for plurals
PHPBB3-12451
2014-05-03 16:16:14 +02:00
Oliver Schramm
3f0334c107 [ticket/12185] Fix and increase width
PHPBB3-12185
2014-05-03 16:07:07 +02:00
Andreas Fischer
4e529fda03 Merge pull request #2375 from nickvergessen/ticket/12470
Ticket/12470 Move commands from .travis.yml to separate files to allow reusing

* nickvergessen/ticket/12470:
  [ticket/12470] Correctly set up the php extensions
  [ticket/12470] Fix setup of phpbb
  [ticket/12470] Move setup of phpBB to new .sh
  [ticket/12470] Move setup of database to new .sh
  [ticket/12470] Move phing sniff into new .sh
2014-05-03 15:53:57 +02:00
Tristan Darricau
5cb68b6be9 [ticket/11497] Fix pagination tests
PHPBB3-11497
2014-05-03 14:07:49 +02:00
Tristan Darricau
8d9133a30e [ticket/11497] Use a mock object to define the root folder for the finder
PHPBB3-11497
2014-05-03 14:00:47 +02:00
Tristan Darricau
0d893d65eb [ticket/11497] Generate the list of the routes in controller_helper
PHPBB3-11497
2014-05-03 13:41:32 +02:00
Nicofuma
e920f146ca [ticket/11497] Fix the path for the finder in controller_provider
PHPBB3-11497
2014-05-03 12:24:07 +02:00
Nicofuma
01e19a00f8 [ticket/11497] Fix tests
PHPBB3-11497
2014-05-03 11:44:58 +02:00
Nicofuma
2463466826 [ticket/11497] Update pagination test
PHPBB3-11497
2014-05-03 11:36:05 +02:00
Nicofuma
dc6e2be884 [ticket/11497] Remove 'ext.finder' from services' list
PHPBB3-11497
2014-05-03 11:29:14 +02:00
Joas Schilling
d2b783338f [ticket/12470] Correctly set up the php extensions
PHPBB3-12470
2014-05-03 10:43:40 +02:00
Joas Schilling
994ab684bc [ticket/12470] Fix setup of phpbb
PHPBB3-12470
2014-05-03 10:43:40 +02:00
Joas Schilling
a2ac425688 [ticket/12470] Move setup of phpBB to new .sh
PHPBB3-12470
2014-05-03 10:43:39 +02:00
Joas Schilling
5cef3254f7 [ticket/12470] Move setup of database to new .sh
PHPBB3-12470
2014-05-03 10:43:39 +02:00
Joas Schilling
acf9524710 [ticket/12470] Move phing sniff into new .sh
PHPBB3-12470
2014-05-03 10:43:38 +02:00
Joas Schilling
3b823465db Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12485] Broken tests due to absolute exclude

Conflicts:
	.travis.yml
	phpunit.xml.all
	phpunit.xml.dist
	phpunit.xml.functional
2014-05-03 10:28:15 +02:00
Joas Schilling
436e388b87 Merge pull request #2396 from Nicofuma/ticket/12485
[ticket/12485] Broken tests due to absolute 'exclude'

* Nicofuma/ticket/12485:
  [ticket/12485] Broken tests due to absolute exclude
2014-05-03 10:19:52 +02:00
Nicofuma
3dee1db260 [ticket/12485] Broken tests due to absolute exclude
PHPBB3-12485
2014-05-03 04:05:25 +02:00
Cesar G
386aac3a85 Merge remote-tracking branch 'VSEphpbb/ticket/10521' into develop-ascraeus
* VSEphpbb/ticket/10521:
  [ticket/10521] Fix broken tests using set_cookie
2014-05-02 17:55:57 -07:00
Matt Friedman
b07ea805d4 [ticket/10521] Fix broken tests using set_cookie
PHPBB3-10521
2014-05-02 17:33:40 -07:00
Matt Friedman
47ff63f823 [ticket/12484] Add template event ucp_agreement_terms_before/after
PHPBB3-12484
2014-05-02 16:41:40 -07:00
Nils Adermann
57927ef8ea Merge remote-tracking branch 'github-vse/ticket/10521' into develop-ascraeus
* github-vse/ticket/10521:
  [ticket/10521] Update docblock of set_cookie for new HttpOnly param
2014-05-03 00:59:55 +02:00
Matt Friedman
6d71f7d7ba [ticket/10521] Update docblock of set_cookie for new HttpOnly param
PHPBB3-10521
2014-05-02 15:57:39 -07:00
Nils Adermann
5800532264 Merge remote-tracking branch 'github-bantu/ticket/12429-ascraeus' into develop-ascraeus
* github-bantu/ticket/12429-ascraeus:
  [ticket/12429] Can not insert into more columns than exist.
2014-05-03 00:51:31 +02:00
Andreas Fischer
6cfee5f2c2 [ticket/12429] Can not insert into more columns than exist.
PHPBB3-12429
2014-05-03 00:37:31 +02:00
Nils Adermann
c7baeaa912 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/11860] htaccess: Support for Apache 2.4's "Require" syntax.
2014-05-03 00:37:28 +02:00
Nils Adermann
af7ec71967 Merge remote-tracking branch 'github-bantu/ticket/11860' into develop-olympus
* github-bantu/ticket/11860:
  [ticket/11860] htaccess: Support for Apache 2.4's "Require" syntax.
2014-05-03 00:37:11 +02:00
Joas Schilling
a995f1166c Merge pull request #2391 from naderman/ticket/12382
[ticket/12382] Allow nested loops in included files.
2014-05-03 00:21:50 +02:00
Nils Adermann
c5660ed177 [ticket/12382] Event loop nesting inclusion applies to regular includes too
PHPBB3-12382
2014-05-03 00:20:37 +02:00
Nils Adermann
1399d60954 Merge remote-tracking branch 'github-vse/ticket/10521' into develop-ascraeus
* github-vse/ticket/10521:
  [ticket/10521] Allow language switching by URL parameter
2014-05-03 00:15:28 +02:00
Nils Adermann
d18f19a3bb [ticket/12382] Allow nested loops in included files.
They have to reference the fully qualified loop name in BEGIN and END.

PHPBB3-12382
2014-05-03 00:13:06 +02:00
Andreas Fischer
936518d201 Merge pull request #2389 from prototech/ticket/12482
[ticket/12482] Fixed undefined variable: data.

* prototech/ticket/12482:
  [ticket/12482] Fixed undefined variable: data.
2014-05-02 23:32:14 +02:00
Matt Friedman
257ff46659 [ticket/10521] Allow language switching by URL parameter
PHPBB3-10521
2014-05-02 14:22:59 -07:00
Cesar G
68f4e84e62 [ticket/12482] Fixed undefined variable: data.
PHPBB3-12482
2014-05-02 14:22:16 -07:00
Joas Schilling
0d133e483b Merge pull request #2385 from prototech/ticket/12478
Add contact field before/after events.
2014-05-02 23:12:10 +02:00
Andreas Fischer
56f881953d Merge pull request #2388 from nickvergessen/ticket/12480
[ticket/12480] Only load config/routing.yml from extensions route

* nickvergessen/ticket/12480:
  [ticket/12480] Remove unused use statements
  [ticket/12480] Add subfolder/config/routing.yml which should not be found
  [ticket/12480] Only load config/routing.yml from extensions route
2014-05-02 23:04:33 +02:00
Joas Schilling
ed089f4b5f [ticket/12480] Remove unused use statements
PHPBB3-12480
2014-05-02 22:52:20 +02:00
Joas Schilling
a470b6c519 [ticket/12480] Add subfolder/config/routing.yml which should not be found
PHPBB3-12480
2014-05-02 22:48:28 +02:00
Joas Schilling
10b23612e3 [ticket/12480] Only load config/routing.yml from extensions route
PHPBB3-12480
2014-05-02 22:35:36 +02:00
Andreas Fischer
dbb7552614 Merge pull request #2384 from prototech/ticket/12477
[ticket/12477] Fix logic to prevent admin-deactivated users from getting PM's.

* prototech/ticket/12477:
  [ticket/12477] Tab instead of spaces.
  [ticket/12477] Fix logic to prevent admin-deactivated users from getting PM's.
2014-05-02 22:16:06 +02:00
Cesar G
0684d9c689 [ticket/12477] Tab instead of spaces.
PHPBB3-12477
2014-05-02 13:05:31 -07:00
Cesar G
a4a7fcb93d [ticket/12477] Fix logic to prevent admin-deactivated users from getting PM's.
PHPBB3-12477
2014-05-02 13:05:25 -07:00
Cesar G
9431a018cb [ticket/12478] Add contact field events to viewtopic_body.html.
PHPBB3-12478
2014-05-02 12:50:59 -07:00
Cesar G
f34af2669d [ticket/12478] Re-add contact field events in ucp_pm_viewmessage.html.
PHPBB3-12478
2014-05-02 12:50:16 -07:00
Nils Adermann
603c3b4629 Merge remote-tracking branch 'github-bantu/ticket/12429-ascraeus' into develop-ascraeus
* github-bantu/ticket/12429-ascraeus:
  [ticket/12429] Update PHPUnit to 4.1, update DBUnit to 1.3.
2014-05-02 21:43:33 +02:00
Nils Adermann
7b94368d52 Merge remote-tracking branch 'github-bantu/ticket/12429' into develop-olympus
* github-bantu/ticket/12429:
  [ticket/12429] Update PHPUnit to 4.1, update DBUnit to 1.3.
2014-05-02 21:42:54 +02:00
Nils Adermann
0fc6b6ac36 Merge remote-tracking branch 'github-vse/ticket/12254' into develop-ascraeus
* github-vse/ticket/12254:
  [ticket/12254] Add subsilver2 support for cookie storage instead of SID
  [ticket/12254] Use a cookie instead of SID to store language selection
  [ticket/12254] No longer need to add change_lang to the URL params
  [ticket/12254] Use 'language' instead of 'set_lang' as the variable name
  [ticket/12254] Persist set_lang after reg only if changed from default
  [ticket/12254] Add set_lang var changes to subsilver2 files
  [ticket/12254] Use new set_lang var to avoid conflict with change_lang
  [ticket/12254] Stop using deprecated request_var in user class
  [ticket/12254] Better language switching on registration page
2014-05-02 21:23:58 +02:00
Matt Friedman
5b0b0d7c66 [ticket/12254] Add subsilver2 support for cookie storage instead of SID
PHPBB3-12254
2014-05-02 12:10:59 -07:00
Matt Friedman
78325736b1 [ticket/12254] Use a cookie instead of SID to store language selection
PHPBB3-12254
2014-05-02 12:08:35 -07:00
Andreas Fischer
0cee35aeef Merge branch 'ticket/12429' into ticket/12429-develop
* ticket/12429:
  [ticket/12429] Update PHPUnit to 4.1, update DBUnit to 1.3.

Conflicts:
	phpBB/composer.json
	phpBB/composer.lock
2014-05-02 20:28:58 +02:00
Andreas Fischer
30dc3afb69 [ticket/12429] Update PHPUnit to 4.1, update DBUnit to 1.3.
PHPBB3-12429
2014-05-02 20:19:10 +02:00
Nils Adermann
03594b6443 [ticket/12475] Tabs, spaces, ...
PHPBB3-12475
2014-05-02 20:03:40 +02:00
Nils Adermann
3420f8f320 [ticket/12475] Load extension migrations on cli updater too
PHPBB3-12475
2014-05-02 19:55:19 +02:00
Andreas Fischer
ab1c181620 Merge pull request #2381 from Nicofuma/ticket/12475
[ticket/12475] Undefined variable $log in db:migrate console command

* Nicofuma/ticket/12475:
  [ticket/12475] Error in db:update console command
2014-05-02 19:50:05 +02:00
Andreas Fischer
e2e6404a3b Merge pull request #2380 from Nicofuma/ticket/12474
[ticket/12474] The console command for updating/migrating the db should display the error with the <error> tag

* Nicofuma/ticket/12474:
  [ticket/12474] Error messages should be displayed with <error> tag
2014-05-02 19:50:01 +02:00
Nicofuma
4bbace8c0d [ticket/12475] Error in db:update console command
PHPBB3-12475
2014-05-02 19:40:18 +02:00
Nicofuma
b302c6c145 [ticket/12474] Error messages should be displayed with <error> tag
PHPBB3-12474
2014-05-02 19:39:15 +02:00
Nils Adermann
b73d0bdbd6 Merge remote-tracking branch 'github-bantu/ticket/12473' into develop-ascraeus
* github-bantu/ticket/12473:
  [ticket/12473] Add console command for database migration.
  [ticket/12473] Add more compatibility to phpBB Console Application.
  [ticket/12473] Move compatibility globals out into its own file.
2014-05-02 19:16:52 +02:00
Andreas Fischer
99a932e0f9 [ticket/12473] Add console command for database migration.
PHPBB3-12473
2014-05-02 19:07:46 +02:00
Andreas Fischer
c193bfc496 [ticket/12473] Add more compatibility to phpBB Console Application.
PHPBB3-12473
2014-05-02 19:01:56 +02:00
Andreas Fischer
d798184d08 [ticket/12473] Move compatibility globals out into its own file.
PHPBB3-12473
2014-05-02 19:01:26 +02:00
Nils Adermann
c609c57035 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12472] Set fast_finish for travis
2014-05-02 18:58:28 +02:00
Nils Adermann
1cd2aaf92f Merge remote-tracking branch 'github-nickvergessen/ticket/12472' into develop-olympus
* github-nickvergessen/ticket/12472:
  [ticket/12472] Set fast_finish for travis
2014-05-02 18:58:15 +02:00
Marc Alexander
9401edecca Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12120] Add Marc Alexander to AUTHORS
2014-05-02 18:51:59 +02:00
Marc Alexander
cb2538dc84 Merge remote-tracking branch 'nickvergessen/ticket/12120' into develop-olympus
* nickvergessen/ticket/12120:
  [ticket/12120] Add Marc Alexander to AUTHORS
2014-05-02 18:36:08 +02:00
Nils Adermann
b187031082 Merge remote-tracking branch 'github-prototech/ticket/12265' into develop-ascraeus
* github-prototech/ticket/12265:
  [ticket/12265] Actually use $u_pm.
  [ticket/12265] Ensure that dropdown is always at the very left of the container
  [ticket/12265] Define a loop for contact icons.
  [ticket/12265] Break the icons that aren't in loop in case extensions add more
  [ticket/12265] Fix modulo logic.
  [ticket/12265] Adjust alignment of AIM and Jabber icons.
  [ticket/12265] Ensure that there's only 4 icons per row in IE & Opera.
  [ticket/12265] Add contact icon and remove border from last row & cells.
  [ticket/12265] Fix issue with dropdown being restricted by the width of parent
  [ticket/12265] Remove ugly logic.
  [ticket/12265] Simplify contact icon design and move to dropdown.

Conflicts:
	phpBB/viewtopic.php
2014-05-02 18:29:50 +02:00
PayBas
042ccce086 [ticket/12392] Fix avatar double assignment bug
PHPBB3-12392
2014-05-02 17:59:43 +02:00
PayBas
48cc7961d4 [ticket/12392] Include $profile_fields in core.memberlist_view_profile
PHPBB3-12392
2014-05-02 17:59:43 +02:00
Joas Schilling
acdaad2625 [ticket/12472] Set fast_finish for travis
Now, a build will finish as soon as a job has failed,
or when the only jobs left allow failures.
http://docs.travis-ci.com/user/build-configuration/#Fast-finishing

PHPBB3-12472
2014-05-02 17:59:22 +02:00
PayBas
d486ff6209 [ticket/12431] Add has_poll icon to topiclists
PHPBB3-12431
2014-05-02 17:58:54 +02:00
PayBas
173bffb61a [ticket/12438] Add Template event memberlist_view_content_prepend
PHPBB3-12438
2014-05-02 17:58:02 +02:00
Nils Adermann
f0be9549ac Merge remote-tracking branch 'github-nickvergessen/feature/sqlite3' into develop-ascraeus
* github-nickvergessen/feature/sqlite3:
  [feature/sqlite3] Add sqlite3 database to .gitignore
  [feature/sqlite3] Use SQLite3 by default
  [feature/sqlite3] Remove invalid comment
  [feature/sqlite3] Remove unneeded ORDER BY type from sqlite_master queries
  [feature/sqlite3] Correctly recreate indexes when recreating a table
  [feature/sqlite3] Fix sql_index_drop() for sqlite3
  [feature/sqlite3] Remove trailing comma from column list
  [feature/sqlite3] Update docblocks and function visibility
  [feature/sqlite3] Add support for SQLite 3
2014-05-02 17:57:22 +02:00
Joas Schilling
797cb02f06 [ticket/12120] Add Marc Alexander to AUTHORS
PHPBB3-12120
2014-05-02 17:12:44 +02:00
PayBas
3c936b055d [ticket/12366] Fixed missing comma
PHPBB3-12366
2014-05-02 17:02:33 +02:00
Nils Adermann
1dd02b0a91 Merge remote-tracking branch 'github-marc1706/ticket/12071' into develop-ascraeus
* github-marc1706/ticket/12071:
  [ticket/12071] Add test that covers not available fileinfo
  [ticket/12071] Get rid of unneeded cast to boolean in tests
  [ticket/12071] Skip tests that depend on fileinfo and fix expected results
2014-05-02 16:54:24 +02:00
Nils Adermann
e65c51e3cd Merge remote-tracking branch 'github-prototech/ticket/11508' into develop-ascraeus
* github-prototech/ticket/11508:
  [ticket/11508] Fix build_url test.
  [ticket/11508] Add functional test for jumpbox.
  [ticket/11508] Use $phpbb_path_helper.
  [ticket/11508] Allow equal sign in parameter value.
  [ticket/11508] Remove unnecessary implode.
  [ticket/11508] Remove unnecessary isset check.
  [ticket/11508] Fix build_url test.
  [ticket/11508] Curly brace should be on its own line...
  [ticket/11508] The question mark is expected even if there are no parameters.
  [ticket/11508] Add tests.
  [ticket/11508] Do not add the '?' unless there are parameters.
  [ticket/11508] Change separator parameter to a simple true|false $is_amp.
  [ticket/11508] Move helper functions to path_helper class.
  [ticket/11508] Move the stripping param code to separate function as well.
  [ticket/11508] Build the jumpbox hidden fields using the _form action_
  [ticket/11508] Split parts of build_url() into reusable functions.
2014-05-02 16:40:01 +02:00
Andreas Fischer
a9ae1f83c7 Merge remote-tracking branch 'naderman/ticket/12469' into develop-ascraeus
* naderman/ticket/12469:
  [ticket/12469] Remove user table columns from fixtures that were deleted
2014-05-02 16:33:27 +02:00
Nils Adermann
ebd56b6955 [ticket/12469] Remove user table columns from fixtures that were deleted
PHPBB3-12469
2014-05-02 16:22:52 +02:00
PayBas
67c26623ed [ticket/12411] Improved change documentation
PHPBB3-12411
2014-05-02 16:05:52 +02:00
Nils Adermann
97e651a491 Merge remote-tracking branch 'github-exreaction/ticket/8323' into develop-ascraeus
* github-exreaction/ticket/8323:
  [ticket/8323] Cache auth request
  [ticket/8323] Combine into a single query
  [ticket/8323] Comments on phpbb_get_banned_user_ids input for test
  [ticket/8323] More readability in test case
  [ticket/8323] Comments
  [ticket/8323] dataProvider for the test; better test data
  [ticket/8323] Comments
  [ticket/8323] Unit test for phpbb_get_banned_user_ids
  [ticket/8323] Comments for inactive reasons in constants.php
  [ticket/8323] Only disable administrative deactivated accounts from receiving PMs
  [ticket/8323] Allow temporarily banned users to receive PMs, but not a notification
  [ticket/8323] Correct PM notification settings (only notify those who can receive them)
  [ticket/8323] Cleanup viewtopic code (not sure how this mess happened)
  [ticket/8323] Allow sending PMs to temporarily banned users
  [ticket/8323] Do not allow sending PMs to Inactive users
  [ticket/8323] Hide the Send PM link if users cannot receive the PM
  [ticket/8323] Correcting the comment
  [ticket/8323] Do not allow sending of Private Messages to users who are banned
  [ticket/8323] Remove code used for testing
  [ticket/8323] Do not allow sending of Private Messages to users who do not have permission to read private messages

Conflicts:
	phpBB/language/en/ucp.php
2014-05-02 15:54:10 +02:00
Joas Schilling
5496dd41ed [feature/sqlite3] Add sqlite3 database to .gitignore
PHPBB3-9728
2014-05-02 15:45:25 +02:00
Joas Schilling
d419bd1899 [feature/sqlite3] Use SQLite3 by default
PHPBB3-9728
2014-05-02 15:45:24 +02:00
Joas Schilling
86c073ec3e [feature/sqlite3] Remove invalid comment
PHPBB3-9728
2014-05-02 15:45:24 +02:00
Joas Schilling
ae3586869a [feature/sqlite3] Remove unneeded ORDER BY type from sqlite_master queries
PHPBB3-9728
2014-05-02 15:45:23 +02:00
Joas Schilling
fd37f63614 [feature/sqlite3] Correctly recreate indexes when recreating a table
PHPBB3-9728
2014-05-02 15:45:22 +02:00
Joas Schilling
b5267d97f4 [feature/sqlite3] Fix sql_index_drop() for sqlite3
PHPBB3-9728
2014-05-02 15:45:22 +02:00
Joas Schilling
07042e484e [feature/sqlite3] Remove trailing comma from column list
PHPBB3-9728
2014-05-02 15:45:21 +02:00
Patrick Webster
8c2b80e3d2 [feature/sqlite3] Update docblocks and function visibility
Added missing docblock annotations and added visibility identifiers.

PHPBB3-9728
2014-05-02 15:45:21 +02:00
Patrick Webster
b39b0369aa [feature/sqlite3] Add support for SQLite 3
Minimum version requirement is 3.6.15 as that's what ships with PHP 5.3.0
when support for SQLite 3 was added.

PHPBB3-9728
2014-05-02 15:45:20 +02:00
Nils Adermann
d52c2d1b5c Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12468] Having mbstring.http_input set to '' is as good as 'pass'.
2014-05-02 15:39:52 +02:00
Nils Adermann
c7450592d8 Merge remote-tracking branch 'github-bantu/ticket/12468' into develop-olympus
* github-bantu/ticket/12468:
  [ticket/12468] Having mbstring.http_input set to '' is as good as 'pass'.
  [ticket/12467] Add config*.php and tests_config*.php to .gitignore
2014-05-02 15:36:59 +02:00
Joas Schilling
fa1ac3c54d Merge pull request #2336 from Nicofuma/ticket/12413
[ticket/12413] Fatal Error log created for feed.php file
2014-05-02 15:08:15 +02:00
Nils Adermann
4f17d0653a Merge branch 'exreaction/ticket/11881' into develop-ascraeus
* exreaction/ticket/11881:
  [ticket/11881] Move convert_timezones_test to migrator
  [ticket/11881] Fix test filename
  [ticket/11881] Limit to 500
  [ticket/11881] Make sure user_timezone isn't converted twice
  [ticket/11881] Better split the timezone conversion into chunks; add test
  [ticket/11881] Timezone migration can take a long time
2014-05-02 14:46:25 +02:00
Nils Adermann
46c5ab64d4 [ticket/11881] Move convert_timezones_test to migrator
PHPBB3-11881
2014-05-02 14:45:53 +02:00
Andreas Fischer
370015c1a5 [ticket/12468] Having mbstring.http_input set to '' is as good as 'pass'.
PHPBB3-12468
2014-05-02 14:41:08 +02:00
Andreas Fischer
5e95815503 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12467] Add config*.php and tests_config*.php to .gitignore
2014-05-02 14:22:02 +02:00
Andreas Fischer
43c6fd768f Merge pull request #2371 from nickvergessen/ticket/12467
[ticket/12467] Add config*.php and tests_config*.php to .gitignore

* nickvergessen/ticket/12467:
  [ticket/12467] Add config*.php and tests_config*.php to .gitignore
2014-05-02 14:21:54 +02:00
PayBas
c63f2656a8 [ticket/12366] Conform to new event coding guidelines
PHPBB3-12366
2014-05-02 14:12:01 +02:00
PayBas
573ec0dbe9 [ticket/12366] Expanded event vars
PHPBB3-12366
2014-05-02 14:10:04 +02:00
PayBas
fadbd23456 [ticket/12366] Include ORDER BY into the query builder
PHPBB3-12366
2014-05-02 14:10:03 +02:00
PayBas
03e081df26 [ticket/12366] Changed to sql_build_query
PHPBB3-12366
2014-05-02 14:10:03 +02:00
PayBas
baf51dd5fd [ticket/12366] Add Event core.search_get_posts_data
PHPBB3-12366
2014-05-02 14:10:02 +02:00
PayBas
91ab67d1d9 [ticket/12411] Missed on bool var
sloppy

PHPBB3-12411
2014-05-02 13:54:06 +02:00
PayBas
598d1ecda8 [ticket/12411] Corrected event vars description
PHPBB3-12411
2014-05-02 13:54:05 +02:00
PayBas
ceca2e9ba1 [ticket/12411] Expand vars of event: core.search_modify_tpl_ary
PHPBB3-12411
2014-05-02 13:54:05 +02:00
Joas Schilling
535cd5670f [ticket/12467] Add config*.php and tests_config*.php to .gitignore
PHPBB3-12467
2014-05-02 13:47:30 +02:00
Nils Adermann
2a280513ca Merge remote-tracking branch 'github-rxu/ticket/12403' into develop-ascraeus
* github-rxu/ticket/12403:
  [ticket/12403] Add template events to acp_users_prefs.html
2014-05-02 13:35:01 +02:00
Nils Adermann
ef0600bfa2 Merge remote-tracking branch 'github-marc1706/ticket/8960' into develop-ascraeus
* github-marc1706/ticket/8960:
  [ticket/8960] Allow changing avatar path if it's not writable
2014-05-02 13:26:03 +02:00
Nicofuma
8812cfcfbf [ticket/12413] Update configuration's asserts
PHPBB3-12413
2014-05-02 13:25:55 +02:00
Nicofuma
2bc4c0e39f [ticket/12413] Update init
PHPBB3-12413
2014-05-02 13:25:54 +02:00
Nicofuma
87fe1e6136 [ticket/12413] Remove unnecessary casts
PHPBB3-12413
2014-05-02 13:25:52 +02:00
Nicofuma
dcadc04b18 [ticket/12413] Disabled unapproved and solftdeleted tests
PHPBB3-12413
2014-05-02 13:25:51 +02:00
Nicofuma
21e2f5c517 [ticket/12413] Move parent:open() call to the end of the function
PHPBB3-12413
2014-05-02 13:25:49 +02:00
Nicofuma
ff2d26e7e8 [ticket/12413] Coding style again
PHPBB3-12413
2014-05-02 13:25:47 +02:00
Nicofuma
80b4a7f337 [ticket/12413] Fix coding style
PHPBB3-12413
2014-05-02 13:25:46 +02:00
Nicofuma
7d8d8394fc [ticket/12413] Fix: coding style
PHPBB3-12413
2014-05-02 13:25:44 +02:00
Nicofuma
ac59b6a199 [ticket/12413] Fixing the failed test
The test was failing because travis is too fast: 2 posts had the same
timestamp.

PHPBB3-12413
2014-05-02 13:25:42 +02:00
Nicofuma
edf0fd0fbd [ticket/12413] Adding the missing visibilities
PHPBB3-12413
2014-05-02 13:25:40 +02:00
Tristan Darricau
6c58f8cdee [ticket/12413] Using static attribute instead of @depends
Using a static attribute to store the initial state of the feeds instead
of transmit it with the @depends annotation.

This attribute is also added to backupStaticAttributesBlackList

PHPBB3-12413
2014-05-02 13:25:38 +02:00
Tristan Darricau
13d939b7e1 [ticket/12413] Useing @depends to transmit the state of the board
the state of the board is calculate in the first test and transmit to the
others thanks to the @depends annotation.

PHPBB3-12413
2014-05-02 13:25:36 +02:00
Tristan Darricau
103befc3d6 [ticket/12413] Tests: Adding functional tests for the feeds
Some tests are disabled until PHPBB3-12418 (#2331) and PHPBB3-12421 (#2330) are
fixed and merged

PHPBB3-12413
2014-05-02 13:25:35 +02:00
Tristan Darricau
e7f970e26d [ticket/12413] Fatal Error for feed.php?mode=forums
https://tracker.phpbb.com/browse/PHPBB3-12413
http://area51.phpbb.com/phpBB/viewtopic.php?f=81&t=45475

PHPBB3-12413
2014-05-02 13:25:33 +02:00
Nils Adermann
fa230b48ec Merge remote-tracking branch 'github-marc1706/ticket/8960-olympus' into develop-olympus
* github-marc1706/ticket/8960-olympus:
  [ticket/8960] Allow changing avatar path if it's not writable
2014-05-02 13:25:29 +02:00
Nils Adermann
76574d4b5e [ticket/8558] htmlspecialchars_decode the contact name for emails
PHPBB3-8558
2014-05-02 13:03:14 +02:00
Nils Adermann
854854b60f Merge remote-tracking branch 'github-elsensee/ticket/stenudd/8558-2' into develop-ascraeus
* github-elsensee/ticket/stenudd/8558-2:
  [ticket/8558] Fix operator
  [ticket/8558] Fix field length in ACP
  [ticket/8558] Use only one variable and improve explain string
  [ticket/8558] Add config in migrations and schema_data
  [ticket/8558] Add display name in emails from board

Conflicts:
	phpBB/includes/functions_messenger.php
2014-05-02 12:49:07 +02:00
Nils Adermann
e511ea71c1 Merge remote-tracking branch 'github-elsensee/ticket/stenudd/8558' into develop-ascraeus
* github-elsensee/ticket/stenudd/8558:
  [ticket/8558] Do string concatenation only once and do htmlspecialchars
  [ticket/8558] Add display name in emails from board
2014-05-02 12:42:32 +02:00
Nils Adermann
0c02607aa8 Merge remote-tracking branch 'github-rxu/ticket/12409' into develop-ascraeus
* github-rxu/ticket/12409:
  [ticket/12409] Add acp_users.php core events to modify users preferences data
2014-05-02 12:29:18 +02:00
Nils Adermann
7c2239e75c Merge remote-tracking branch 'github-nickvergessen/ticket/12273' into develop-ascraeus
* github-nickvergessen/ticket/12273: (55 commits)
  [ticket/12273] Move $extension to constructor so the path is always set
  [ticket/12273] Find events.md relative from the path not the phpbb root
  [ticket/12273] Do not look in extensions docs/ and tests/ directory
  [ticket/12273] Also check file for adm "Location:" events
  [ticket/12273] Do not allow template events in non-html files
  [ticket/12273] Fix return description
  [ticket/12273] Update exporter to allow specifying an extension
  [ticket/12273] Allow to filter events for extensions
  [ticket/12273] Remove old parameter from function call
  [ticket/12273] Fix table header for adm events
  [ticket/12273] Add root path to recursive_event_filter_iterator
  [ticket/12273] Fix missing classes in export_events_for_wiki.php
  [ticket/12273] Use RecursiveDirectoryIterator with filter in php_exporter
  [ticket/12273] Use RecursiveDirectoryIterator in md_exporter
  [ticket/12273] Fix doc blocks
  [ticket/12273] Do not allow 3.1-A1 for template events
  [ticket/12273] Sort arguments alphabetically before exporting
  [ticket/12273] Do not allow 3.1-A1 version
  [ticket/12273] Update since version to 3.1.0-a* style
  [ticket/12273] Update existing events
  ...
2014-05-02 12:22:05 +02:00
Nils Adermann
d36795b844 Merge remote-tracking branch 'github-nickvergessen/ticket/12371' into develop-ascraeus
* github-nickvergessen/ticket/12371:
  [ticket/12371] Fix language string
  [ticket/12371] Fix typos in comment
  [ticket/12371] Fix redirect link for approve_post and post_in_queue
  [ticket/12371] Delete the approve_post notification when editing a post
  [ticket/12371] Fix language in comment
  [ticket/12371] Reapprove the post and topic again in tests
  [ticket/12371] Correctly set is_starter when editing first post of the topic
  [ticket/12371] Add functional tests for reapproving
  [ticket/12371] Fix query in mcp_sorting()
  [ticket/12371] Rename disapprove and softdelete tests
  [ticket/12371] We do not group quote notifications anymore
  [ticket/12371] Fix SQL query
  [ticket/11772] Do not send out new topic/post notifications when reapproving
  [ticket/12052] Use different visibility when post was edited
  [ticket/12052] Add support for ITEM_UNAPPROVED to set_post_visibility method
  [ticket/12371] Do not add unlimited users as responders
  [ticket/12371] Do not update the notification entry unneccessarily
  [ticket/12371] Do not delete post related notifications when a post is deleted
  [ticket/12371] Allow notification types to redirect to a different url
  [ticket/12371] Do not group "quote" notifications
2014-05-02 12:11:09 +02:00
Joas Schilling
5c7199f3dd [ticket/12371] Fix language string
PHPBB3-12371
2014-05-02 11:51:40 +02:00
Joas Schilling
2bb12d0d6f [ticket/12371] Fix typos in comment
PHPBB3-12371
2014-05-02 11:51:20 +02:00
Nathaniel Guse
73b950d2f1 Merge remote-tracking branch 'remotes/Crizz0/ticket/12404' into develop-ascraeus
# By Crizzo
# Via Crizzo
* remotes/Crizz0/ticket/12404:
  [ticket/12404] Splits up the line 18 in subsilver2 into more lines
  [ticket/12404] Changes append/prepend to after/before
  [ticket/12404] Adds two new events and changes some places
  [ticket/12404] Adds a new event before and after the Timezone display
2014-05-01 22:24:31 -05:00
Nathaniel Guse
4f393ad096 Merge remote-tracking branch 'remotes/Nicofuma/ticket/12432' into develop-ascraeus
# By Nicofuma
# Via Nicofuma
* remotes/Nicofuma/ticket/12432:
  [ticket/12432] Correcting the assertion
  [ticket/12432] Adding unit test
  [ticket/12432] Migrator should not revert custom functions
2014-05-01 22:16:02 -05:00
Matt Friedman
0e0eca2d2e [ticket/12332] Add missing semicolon to inline styling
PHPBB3-12332
2014-05-01 20:04:27 -07:00
Nathaniel Guse
f0036d2ac6 Merge remote-tracking branch 'remotes/PayBas/ticket/12442' into develop-ascraeus
# By PayBas
# Via PayBas
* remotes/PayBas/ticket/12442:
  [ticket/12442] More heading classes
  [ticket/12442] Add CSS classes to important headings
2014-05-01 21:55:45 -05:00
Nathaniel Guse
4f236729e4 Merge remote-tracking branch 'remotes/Nicofuma/ticket/12444' into develop-ascraeus
# By Nicofuma
# Via Nicofuma
* remotes/Nicofuma/ticket/12444:
  [ticket/12444] Replacing spaces with tabs
  [ticket/12444] Replace spaces with tabs
  [ticket/12444] Adding regression test
  [ticket/12444] The logs message aren't filled correctly
2014-05-01 21:49:18 -05:00
Nathaniel Guse
5c54cd6a45 Merge remote-tracking branch 'remotes/Nicofuma/ticket/12445' into develop-ascraeus
# By Nicofuma
# Via Nicofuma
* remotes/Nicofuma/ticket/12445:
  [ticket/12445] Change the formulation
  [ticket/12445] Disapproved post: the name of the poster should be in logs
2014-05-01 21:46:34 -05:00
Nathaniel Guse
621023e4ae Merge remote-tracking branch 'remotes/prototech/ticket/11339' into develop-ascraeus
# By Cesar G
# Via Cesar G
* remotes/prototech/ticket/11339:
  [ticket/11339] Always clear timeout functions on subsequent AJAX calls
2014-05-01 21:35:40 -05:00
PayBas
5ec67ed248 [ticket/12442] More heading classes
I think that about finishes the most important one

PHPBB3-12442
2014-04-30 09:44:28 +02:00
Joas Schilling
83cdad77ec Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
2014-04-29 21:29:29 +02:00
Joas Schilling
1ba6a45a78 Merge pull request #2362 from n-aleha/ticket/12186a
[ticket/12186] Move PM reports below post reports while installing for ascraeus

* n-aleha/ticket/12186a:
  [ticket/12186] Move PM reports below post reports while installing for ascraeus
  [ticket/12186] Move PM reports below post reports while installing
2014-04-29 21:29:18 +02:00
Joas Schilling
06e9d8871c Merge pull request #2319 from n-aleha/ticket/12186
[ticket/12186] Move PM reports below post reports while installing

* n-aleha/ticket/12186:
  [ticket/12186] Move PM reports below post reports while installing
2014-04-29 21:28:54 +02:00
Joas Schilling
417a0d0ea6 Merge pull request #2366 from bantu/ticket/12458
[ticket/12458] Apply Squiz.WhiteSpace.SuperfluousWhitespace.* to legacy code

* bantu/ticket/12458:
  [ticket/12458] Apply Squiz.WhiteSpace.SuperfluousWhitespace.* to legacy code.
2014-04-29 20:40:06 +02:00
Andreas Fischer
89391dec08 [ticket/12458] Apply Squiz.WhiteSpace.SuperfluousWhitespace.* to legacy code.
* There MUST NOT be trailing whitespace at the end of lines.
* There MUST NOT be whitespace before the first content of a file.
* There MUST NOT be whitespace after the last content of a file.
* Functions MUST NOT contain multiple empty lines in a row.

PHPBB3-12458
2014-04-29 17:51:21 +02:00
Andreas Fischer
40351fae96 Merge pull request #2364 from nickvergessen/ticket/12456
[ticket/12456] Missing new lines at the end of file in language files

* nickvergessen/ticket/12456:
  [ticket/12456] Add , after the last array element
  [ticket/12456] Fix duplicated empty lines in language files
  [ticket/12456] Fix missing new lines at the end of email templates
2014-04-29 17:08:49 +02:00
Joas Schilling
23b3667978 [ticket/12456] Add , after the last array element
PHPBB3-12456
2014-04-29 16:24:51 +02:00
Joas Schilling
38f05750b7 [ticket/12456] Fix duplicated empty lines in language files
PHPBB3-12456
2014-04-29 15:44:17 +02:00
Joas Schilling
cec060bb9b [ticket/12456] Fix missing new lines at the end of email templates
PHPBB3-12456
2014-04-29 15:43:55 +02:00
Joas Schilling
7f90ff70ac [ticket/12273] Move $extension to constructor so the path is always set
PHPBB3-12273
2014-04-28 23:52:48 +02:00
Joas Schilling
2d5bae555d [ticket/12273] Find events.md relative from the path not the phpbb root
PHPBB3-12273
2014-04-28 23:15:38 +02:00
Joas Schilling
8d9fb27edc [ticket/12273] Do not look in extensions docs/ and tests/ directory
PHPBB3-12273
2014-04-28 23:11:40 +02:00
Nicofuma
7af9f41e4f [ticket/12025] Fixing the condition....
PHPBB3-12025
2014-04-28 21:18:01 +02:00
Joas Schilling
f57df8e12e [ticket/12273] Also check file for adm "Location:" events
PHPBB3-12273
2014-04-28 21:14:29 +02:00
Joas Schilling
b28c8aebaa [ticket/12273] Do not allow template events in non-html files
PHPBB3-12273
2014-04-28 21:10:08 +02:00
Joas Schilling
da6eb0282d [ticket/12273] Fix return description
PHPBB3-12273
2014-04-28 21:08:48 +02:00
Joas Schilling
2928effb3c [ticket/12273] Update exporter to allow specifying an extension
PHPBB3-12273
2014-04-28 21:04:36 +02:00
Joas Schilling
ed669982c2 [ticket/12273] Allow to filter events for extensions
PHPBB3-12273
2014-04-28 21:03:59 +02:00
Nicofuma
5c33c20186 [ticket/12445] Change the formulation
PHPBB3-12445
2014-04-28 18:44:56 +02:00
Joas Schilling
bf8b9f0143 [ticket/12273] Remove old parameter from function call
PHPBB3-12273
2014-04-28 00:06:14 +02:00
Joas Schilling
35f8b7f5ea [ticket/12273] Fix table header for adm events
PHPBB3-12273
2014-04-27 23:54:12 +02:00
Joas Schilling
dbac4bb5c0 [ticket/12273] Add root path to recursive_event_filter_iterator
PHPBB3-12273
2014-04-27 23:51:06 +02:00
Joas Schilling
e934cefe80 [ticket/12273] Fix missing classes in export_events_for_wiki.php
PHPBB3-12273
2014-04-27 23:50:02 +02:00
Nicofuma
8facf2b8d9 [ticket/12025] Don't show any error on preview if the message is empty
PHPBB3-12025
2014-04-27 23:11:10 +02:00
n-aleha
ac8ce42a12 [ticket/12186] Move PM reports below post reports while installing for ascraeus
In mcp, move PM reports below post reports while installing.

PHPBB3-12186
2014-04-27 22:44:41 +03:00
n-aleha
edeeaa03c1 Merge branch 'ticket/12186' into ticket/12186a 2014-04-27 22:29:37 +03:00
Joas Schilling
0b6accf1ac Merge pull request #2359 from Nicofuma/ticket/12097
[ticket/12097] Validate_data() should work with class method

* Nicofuma/ticket/12097:
  [ticket/12097] Bug fix and adding unit test
  [ticket/12097] Validate_data() should work with class method
2014-04-27 20:43:03 +02:00
Nicofuma
ea15b879f1 [ticket/12432] Correcting the assertion
PHPBB3-12432
2014-04-26 18:54:47 +02:00
Nicofuma
7b8a8a2a5d [ticket/12444] Replacing spaces with tabs
PHPBB3-12444
2014-04-26 18:52:26 +02:00
Matt Friedman
7d5672f6c5 [ticket/12332] Adjust size of mark column where too wide
PHPBB3-12332
2014-04-26 09:50:45 -07:00
Matt Friedman
76843f4a3a [ticket/12332] Adjust column widths for responsive changes
PHPBB3-12332
2014-04-26 09:25:59 -07:00
Joas Schilling
42e29daa1f Merge pull request #2325 from n-aleha/ticket/12406
[ticket/12406] Fix variable description of core.viewtopic_modify_page_ti...

* n-aleha/ticket/12406:
  [ticket/12406] Fix variable description of core.viewtopic_modify_page_title
2014-04-26 18:18:18 +02:00
Matt Friedman
92fa39b79d [ticket/12332] Restore some changes back to original state
PHPBB3-12332
2014-04-26 09:18:14 -07:00
Matt Friedman
2b9b6412b8 [ticket/12332] Add break-word to fixed width table CSS
This ensures long words break and remain within the table cell

PHPBB3-12332
2014-04-26 09:16:03 -07:00
Matt Friedman
f5262eb928 [ticket/12332] Accomplish all word creaking in template and CSS
PHPBB3-12332
2014-04-26 09:15:22 -07:00
Matt Friedman
3bebbc05ee [ticket/12332] Remove width sizing, as it is already set
PHPBB3-12332
2014-04-26 09:14:15 -07:00
Joas Schilling
927c219b1f [ticket/12273] Use RecursiveDirectoryIterator with filter in php_exporter
PHPBB3-12273
2014-04-26 18:04:47 +02:00
Suhaib Khan
590e1cacbd [ticket/12185] Fixing the width of topic header for translation.
PHPBB3-12185
2014-04-26 17:20:25 +02:00
Joas Schilling
7a44f66448 [ticket/12273] Use RecursiveDirectoryIterator in md_exporter
PHPBB3-12273
2014-04-26 16:59:18 +02:00
Joas Schilling
6aa8596d4d [ticket/12273] Fix doc blocks
PHPBB3-12273
2014-04-26 16:39:53 +02:00
Nicofuma
6ba61785f8 [ticket/12097] Bug fix and adding unit test
PHPBB3-12097
2014-04-26 15:46:50 +02:00
Nicofuma
0ef920eb42 [ticket/12025] Post Preview no longer shows warnings
https://tracker.phpbb.com/browse/PHPBB3-12025

PHPBB3-12025
2014-04-26 15:01:30 +02:00
Nicofuma
a29f3c878a [ticket/12097] Validate_data() should work with class method
https://tracker.phpbb.com/browse/PHPBB3-12097

PHPBB3-12097
2014-04-26 14:10:10 +02:00
Nicofuma
28176b0746 [ticket/12432] Adding unit test
PHPBB3-12432
2014-04-26 12:15:21 +02:00
Nicofuma
595f831589 [ticket/12432] Migrator should not revert custom functions
https://tracker.phpbb.com/browse/PHPBB3-12432

PHPBB3-12432
2014-04-26 12:15:19 +02:00
Andreas Fischer
9eedd45aac Merge pull request #2345 from Nicofuma/ticket/12199
[ticket/12199] Move deprecated functions to functions_compatibility.php

* Nicofuma/ticket/12199:
  [ticket/12199] Move deprecated functions to functions_compatibility.php
2014-04-26 01:41:50 +02:00
Nicofuma
af827bf2b4 [ticket/12199] Move deprecated functions to functions_compatibility.php
Currently 13 functions are marked as deprecated:
functions.php:
function set_var()
function request_var()
function set_config()
function set_config_count()
function tz_select()
function add_log()

functions_admin:
function cache_moderators()
function update_foes()

functions_compatibility:
function get_user_avatar()
function phpbb_hash()
function phpbb_check_hash()
function phpbb_clean_path()

functions_install:
function get_tables()

8 of them are still used in the core:
add_log              Used in many places (~198 calls)
get_tables           Used in install\install_convert::get_convert_settings
			and functions_install.php\connect_check_db
get_user_avatar      Used in phpbb\user_loader:get_avatar
phpbb_hash           Used in phpbb\db\migration\data\v30x\release_3_0_5_rc1
request_var          Used quite everywhere (~997 calls)
set_config           Used in many places (~129 calls)
set_config_count     Used in a few places (~37 calls)
set_var              Used by phpbb_http_login
			and phpbb\auth\provider\apache::autologin

PHPBB3-12199
2014-04-26 01:25:51 +02:00
Nicofuma
5ec9f40b78 [ticket/12445] Disapproved post: the name of the poster should be in logs
https://tracker.phpbb.com/browse/PHPBB3-12445

PHPBB3-12445
2014-04-26 01:18:34 +02:00
Nicofuma
41b004ae50 [ticket/12444] Replace spaces with tabs
PHPBB3-12444
2014-04-26 00:52:56 +02:00
Nicofuma
3d1569d385 [ticket/12444] Adding regression test
PHPBB3-12444
2014-04-26 00:42:24 +02:00
Nicofuma
2991918bac [ticket/12444] The logs message aren't filled correctly
https://tracker.phpbb.com/browse/PHPBB3-12444

PHPBB3-12444
2014-04-25 23:31:31 +02:00
Crizzo
df47cbb254 [ticket/12404] Splits up the line 18 in subsilver2 into more lines
PHPBB3-12404
2014-04-25 22:15:13 +02:00
Cesar G
0553d79808 Merge remote-tracking branch 'Nicofuma/ticket/12418' into develop-ascraeus
* Nicofuma/ticket/12418:
  [ticket/12418] Notice displayed for feed.php
2014-04-25 13:03:23 -07:00
Cesar G
5cc0f50d28 [ticket/11339] Always clear timeout functions on subsequent AJAX calls
PHPBB3-11339
2014-04-25 12:10:46 -07:00
Matt Friedman
770ab13cb0 [ticket/12332] Fix displaying attachments with long file names
PHPBB3-12332
2014-04-25 11:26:49 -07:00
Joas Schilling
18be18e998 [ticket/12273] Do not allow 3.1-A1 for template events
PHPBB3-12273
2014-04-25 20:26:47 +02:00
Cesar G
fe768d460d Merge remote-tracking branch 'PayBas/ticket/12437' into develop-ascraeus
* PayBas/ticket/12437:
  [ticket/12437] Clean up redundant "clear" elements & "corners"
2014-04-25 10:10:32 -07:00
Andreas Fischer
d7c3cf4700 Merge pull request #2288 from nickvergessen/ticket/12012
[ticket/12012] Correctly drop default value constraints

* nickvergessen/ticket/12012:
  [ticket/12012] Move property to the top
  [ticket/12012] Move MS SQL server comparison into a method
  [ticket/12012] Fix docs in connection manager
  [ticket/12012] Remove duplicated code (only the $sql are different)
  [ticket/12012] Handle begin and commit transactions in tests
  [ticket/12012] Drop and recreate indexes when removing columns
  [ticket/12012] Add a unit test for removing a column with indexes
  [ticket/12012] Add a unit test for changing the column type
  [ticket/12012] Return SQL statements for index drop/create
  [ticket/12012] Fix tools::mssql_get_existing_indexes() for SQL Server 2000
  [ticket/12012] Drop and recreate indexes when changing a column on MSSQL
  [ticket/12012] Fix query layout
  [ticket/12012] Correctly drop default value constraints on MSSQL
2014-04-25 18:54:40 +02:00
Cesar G
b305ec5611 Merge remote-tracking branch 'PayBas/ticket/12389' into develop-ascraeus
* PayBas/ticket/12389:
  [ticket/12389] Change "PM" to "Message"
  [ticket/12389] Moved PM tools to UCP template
  [ticket/12389] Replace email and print icons.
  [ticket/12389] Change language of email friend
  [ticket/12389] Move print topic & email topic icons to topic tools
2014-04-25 07:33:22 -07:00
Cesar G
fefd6b7423 Merge remote-tracking branch 'nickvergessen/ticket/12382' into develop-ascraeus
* nickvergessen/ticket/12382:
  [ticket/12382] Mark broken nested loop with include as incomplete
  [ticket/12382] Add template test for subloops inside includes
  [ticket/12382] Add template test for subloops inside events
2014-04-25 07:24:50 -07:00
Andreas Fischer
c61f92eb46 Merge pull request #2352 from nickvergessen/ticket/11917
[ticket/11917] Replace space with tabs

* nickvergessen/ticket/11917:
  [ticket/11917] Replace space with tabs
2014-04-25 16:01:26 +02:00
rxu
60d2a3389a [ticket/12403] Add template events to acp_users_prefs.html
Since it is possible for extensions to add new user preferences to UCP,
it should be also possible to control it via ACP too
just like for build-in user preferences.
Thus, some prepend/append template events are added.

PHPBB3-12403
2014-04-25 21:46:38 +08:00
PayBas
5109d3a12f [ticket/12442] Add CSS classes to important headings
PHPBB3-12442
2014-04-25 12:56:58 +02:00
Joas Schilling
9c689ef8dd [ticket/11917] Replace space with tabs
PHPBB3-11917
2014-04-25 12:45:48 +02:00
Joas Schilling
3bcda97e28 [ticket/12273] Sort arguments alphabetically before exporting
PHPBB3-12273
2014-04-25 12:37:39 +02:00
Joas Schilling
48278f122c [ticket/12273] Do not allow 3.1-A1 version
PHPBB3-12273
2014-04-25 12:31:57 +02:00
Joas Schilling
b32895308d [ticket/12273] Update since version to 3.1.0-a* style
PHPBB3-12273
2014-04-25 12:15:44 +02:00
Joas Schilling
7324cb051f [ticket/12371] Fix redirect link for approve_post and post_in_queue
PHPBB3-12371
2014-04-25 11:52:29 +02:00
Joas Schilling
40d91a5d6e [ticket/12371] Delete the approve_post notification when editing a post
We need to delete the initial approve notification,
so we can notify the user again, when his post got reapproved.

PHPBB3-12371
2014-04-25 11:52:28 +02:00
Joas Schilling
465aa9c346 [ticket/12371] Fix language in comment
PHPBB3-12371
2014-04-25 11:52:28 +02:00
Joas Schilling
16329c7ad9 [ticket/12371] Reapprove the post and topic again in tests
PHPBB3-12371
2014-04-25 11:52:27 +02:00
Joas Schilling
ddbb521e57 [ticket/12371] Correctly set is_starter when editing first post of the topic
PHPBB3-12371
2014-04-25 11:52:26 +02:00
Joas Schilling
793680478b [ticket/12371] Add functional tests for reapproving
PHPBB3-12371
2014-04-25 11:52:26 +02:00
Joas Schilling
70f5686efb [ticket/12371] Fix query in mcp_sorting()
PHPBB3-12371
2014-04-25 11:52:25 +02:00
Joas Schilling
1d61fcf3c9 [ticket/12371] Rename disapprove and softdelete tests
PHPBB3-12371
2014-04-25 11:52:25 +02:00
Joas Schilling
84a77d07be [ticket/12371] We do not group quote notifications anymore
PHPBB3-12371
2014-04-25 11:52:23 +02:00
Joas Schilling
8375c3f789 [ticket/12371] Fix SQL query
PHPBB3-12371
2014-04-25 11:52:23 +02:00
Joas Schilling
5512e62c3c [ticket/11772] Do not send out new topic/post notifications when reapproving
Only add notifications, if we are not reapproving post
When the topic was already approved, but was edited and
now needs re-approval, we don't want to notify the users again.

PHPBB3-11772
2014-04-25 11:52:22 +02:00
Joas Schilling
2ec9c08a2b [ticket/12052] Use different visibility when post was edited
... and needs to be reapproved.

PHPBB3-12052
2014-04-25 11:52:22 +02:00
Cesar G
dac01e8ca5 [ticket/12052] Add support for ITEM_UNAPPROVED to set_post_visibility method
PHPBB3-12052
2014-04-25 11:52:21 +02:00
Joas Schilling
37751b51f9 [ticket/12371] Do not add unlimited users as responders
We run into the risc that the data is longer then the character limit
of the table column. However as we trim the users list anyway, we can
also just stop adding them and display "many others" instead of "x others"

PHPBB3-12371
2014-04-25 11:52:20 +02:00
Joas Schilling
418747ed34 [ticket/12371] Do not update the notification entry unneccessarily
When the data did not change, we also don't have to run the query at all.

PHPBB3-12371
2014-04-25 11:52:20 +02:00
Joas Schilling
92db22c882 [ticket/12371] Do not delete post related notifications when a post is deleted
When a post is marked edited and therefor marked as softdeleted/unapproved,
we should not delete the notifications, just like we can't delete the emails.
Links are out there anyway and just keeping the notification is fail save.

If we keep the notification we can just continue to update it when more posts
are added. Also when we delete a post, we don't have to go though the table
and find all related notifications to be able to delete them or even update
them, when they have responders set.

PHPBB3-12371
2014-04-25 11:52:19 +02:00
Joas Schilling
e0fadfb4d6 [ticket/12371] Allow notification types to redirect to a different url
This way we can redirect the post and bookmark notification to the first
unread post in the topic

PHPBB3-12371
2014-04-25 11:52:19 +02:00
Joas Schilling
ed40846590 [ticket/12371] Do not group "quote" notifications
Grouping these notification makes no sense, as the user will not find the
posts he is quoted in, when they are spread over multiple pages

PHPBB3-12371
2014-04-25 11:52:18 +02:00
Joas Schilling
87899b0e14 [ticket/12273] Update existing events
PHPBB3-12273
2014-04-25 11:46:44 +02:00
Joas Schilling
01e2d7c26c [ticket/12273] Fix unit tests for multi line arrays
PHPBB3-12273
2014-04-25 11:46:24 +02:00
Joas Schilling
142fe1a0e5 [ticket/12273] Use multiline arrays instead of array_merge()
PHPBB3-12273
2014-04-25 11:45:54 +02:00
Nicofuma
4f6441b411 [ticket/11480] PM : "Unknown folder" returned when inbox folder is full
https://tracker.phpbb.com/browse/PHPBB3-11480

PHPBB3-11480
2014-04-25 01:04:00 +02:00
Joas Schilling
d5ea4906ca [ticket/12012] Move property to the top
PHPBB3-12012
2014-04-24 22:57:35 +02:00
PayBas
65c8280fb6 [ticket/12389] Change "PM" to "Message"
PHPBB3-12389
2014-04-24 22:09:15 +02:00
Joas Schilling
c2dace762e [ticket/12273] Fix long $vars lines for existing events
PHPBB3-12273
2014-04-24 17:26:27 +02:00
Joas Schilling
8599554443 [ticket/12273] Fix unit test for multi line $vars
PHPBB3-12273
2014-04-24 17:14:45 +02:00
Joas Schilling
b0a9acd8ff [ticket/12273] Use array_merge instead of +=
PHPBB3-12273
2014-04-24 17:14:12 +02:00
Joas Schilling
d2ab305909 [ticket/12273] Add missing event documentation
PHPBB3-12273
2014-04-24 16:51:43 +02:00
Joas Schilling
320a2f7578 [ticket/12273] Fix number of = in events.md
PHPBB3-12273
2014-04-24 16:51:42 +02:00
Joas Schilling
8e4b4bc72e [ticket/12273] Fix subsilver2 missing from simple_footer_after docs
PHPBB3-12273
2014-04-24 16:51:42 +02:00
Joas Schilling
a2c3b2534a [ticket/12273] Fix method name of test and fix undefined index
PHPBB3-12273
2014-04-24 16:51:41 +02:00
Joas Schilling
5889255529 [ticket/12273] Test source files and compare with events.md
PHPBB3-12273
2014-04-24 16:51:40 +02:00
Joas Schilling
7dc32a45e5 [ticket/12273] Verify the result of the .md file to the source
PHPBB3-12273
2014-04-24 16:51:40 +02:00
Joas Schilling
f676f50c22 [ticket/12273] Only check selected files
PHPBB3-12273
2014-04-24 16:51:39 +02:00
Joas Schilling
23dbddc59d [ticket/12273] Fix some locations of existing events
PHPBB3-12273
2014-04-24 16:51:38 +02:00
Joas Schilling
c7dcc6d700 [ticket/12273] Verify that the events are still in the named files
PHPBB3-12273
2014-04-24 16:51:37 +02:00
Joas Schilling
bbc2e6c7b2 [ticket/12012] Move MS SQL server comparison into a method
PHPBB3-12012
2014-04-24 14:53:33 +02:00
Joas Schilling
f86bf3c4d3 Merge pull request #2348 from bantu/ticket/12436
[ticket/12436] Data passed to sql_multi_insert is expected to be multi-d...

* bantu/ticket/12436:
  [ticket/12436] Data passed to sql_multi_insert is expected to be multi-dim.
2014-04-24 14:31:07 +02:00
Andreas Fischer
69865852a0 [ticket/12436] Data passed to sql_multi_insert is expected to be multi-dim.
PHPBB3-12436
2014-04-24 13:16:50 +02:00
PayBas
d76d061cfa [ticket/12437] Clean up redundant "clear" elements & "corners"
PHPBB3-12437
2014-04-24 12:20:23 +02:00
Nils Adermann
6e85b2acc7 Merge remote-tracking branch 'github-nickvergessen/ticket/11917' into develop-ascraeus
* github-nickvergessen/ticket/11917:
  [ticket/11917] Move OAuth Module to the bottom while installing
  [ticket/11917] Hide OAuth UCP Module when OAuth is not the selected backend

Conflicts:
	phpBB/install/install_install.php
2014-04-24 11:33:00 +02:00
n-aleha
5a91399dac [ticket/12186] Move PM reports below post reports while installing
In mcp, move PM reports below post reports while installing.

PHPBB3-12186
2014-04-23 22:43:20 +03:00
Cesar G
a62b672530 [ticket/10737] Remove loading indicator.
PHPBB3-10737
2014-04-23 09:14:42 -07:00
Cesar G
f2e74354a3 [ticket/10737] Enforce allow_live_searches setting in memberlist.php.
PHPBB3-10737
2014-04-23 09:11:41 -07:00
Cesar G
607698c884 [ticket/10737] Add config setting to disable live searches.
PHPBB3-10737
2014-04-23 09:11:40 -07:00
Cesar G
683e8c0c17 [ticket/10737] Add loading indicator and alert box code to simple_footer.html.
PHPBB3-10737
2014-04-23 09:11:40 -07:00
Cesar G
6cb84402fd [ticket/10737] Load core.js and ajax.js in simple_footer.html.
PHPBB3-10737
2014-04-23 09:11:40 -07:00
Cesar G
3fec8dff2c [ticket/10737] Set the username as the input value instead of redirecting.
PHPBB3-10737
2014-04-23 09:11:40 -07:00
Cesar G
333a18d846 [ticket/10737] Drop subsilver2 changes.
PHPBB3-10737
2014-04-23 09:11:40 -07:00
Cesar G
2fbae2bb41 [ticket/10737] Add a more generic live search implementation.
PHPBB3-10737
2014-04-23 09:11:40 -07:00
Cesar G
1a51ceeabe [ticket/10737] Clean up memberlist.php.
PHPBB3-10737
2014-04-23 09:11:40 -07:00
Cesar G
652f787abd [ticket/10737] Use dropdown for search results container.
PHPBB3-10737
2014-04-23 09:11:40 -07:00
Suhaib Khan
a60d9a7f86 [ticket/10737] Adding delayed keyup and removing target_blank.
PHPBB3-10737
2014-04-23 09:11:40 -07:00
Suhaib Khan
6ef4e4e790 [ticket/10737] Using UTF-8 aware alternatives in PHP code.
PHPBB3-10737
2014-04-23 09:11:40 -07:00
Suhaib Khan
a74216527c [ticket/10737] Removing obsolete code.
PHPBB3-10737
2014-04-23 09:11:40 -07:00
Suhaib Khan
aa23cf64ca [ticket/10737] Avoid hard-coding table row and use case-insensitive search.
PHPBB3-10737
2014-04-23 09:11:39 -07:00
Suhaib Khan
e644c67dcf [ticket/10737] Removing unnecessary/obsolete code.
PHPBB3-10737
2014-04-23 09:11:39 -07:00
Suhaib Khan
dd07efcac7 [ticket/10737] Using JQuery events and JSON response.
PHPBB3-10737
2014-04-23 09:11:39 -07:00
Suhaib Khan
b5ee81dae6 [ticket/10737] Code fixes in AJAX search feature
PHPBB3-10737
2014-04-23 09:11:39 -07:00
Suhaib Khan
bc67377400 [ticket/10737] Improvements over last commit
PHPBB3-10737
2014-04-23 09:11:39 -07:00
Suhaib Khan
dad60045b6 [ticket/10737] Adding username suggestions in "Find a member" using AJAX
PHPBB3-10737
2014-04-23 09:11:39 -07:00
Oliver Schramm
45e39d0990 [ticket/8558] Fix operator
PHPBB3-8558
2014-04-23 17:45:09 +02:00
Cesar G
e9b00071dd [ticket/11508] Fix build_url test.
PHPBB3-11508
2014-04-22 16:03:13 -07:00
Cesar G
e104c364f4 [ticket/11508] Add functional test for jumpbox.
PHPBB3-11508
2014-04-22 16:02:35 -07:00
Cesar G
c2ac76e8b1 [ticket/11508] Use $phpbb_path_helper.
PHPBB3-11508
2014-04-22 15:21:03 -07:00
Cesar G
e287eea2c6 [ticket/11508] Allow equal sign in parameter value.
PHPBB3-11508
2014-04-22 15:21:02 -07:00
Cesar G
9e605b1338 [ticket/11508] Remove unnecessary implode.
PHPBB3-11508
2014-04-22 15:21:02 -07:00
Cesar G
b0dd532c14 [ticket/11508] Remove unnecessary isset check.
PHPBB3-11508
2014-04-22 15:21:02 -07:00
Cesar G
141d386025 [ticket/11508] Fix build_url test.
PHPBB3-11508
2014-04-22 15:21:02 -07:00
Cesar G
5e7bcd2fa6 [ticket/11508] Curly brace should be on its own line...
PHPBB3-11508
2014-04-22 15:21:02 -07:00
Cesar G
5e0ab146d9 [ticket/11508] The question mark is expected even if there are no parameters.
PHPBB3-11508
2014-04-22 15:21:02 -07:00
Cesar G
47f8a6375f [ticket/11508] Add tests.
PHPBB3-11508
2014-04-22 15:21:02 -07:00
Cesar G
f05e0ec9eb [ticket/11508] Do not add the '?' unless there are parameters.
PHPBB3-11508
2014-04-22 15:21:02 -07:00
Cesar G
8987fc95f9 [ticket/11508] Change separator parameter to a simple true|false $is_amp.
PHPBB3-11508
2014-04-22 15:21:02 -07:00
Cesar G
3163388f63 [ticket/11508] Move helper functions to path_helper class.
PHPBB3-11508
2014-04-22 15:21:02 -07:00
Cesar G
e1c6b40ee8 [ticket/11508] Move the stripping param code to separate function as well.
PHPBB3-11508
2014-04-22 15:21:02 -07:00
Cesar G
ef4202d859 [ticket/11508] Build the jumpbox hidden fields using the _form action_
PHPBB3-11508
2014-04-22 15:21:01 -07:00
Cesar G
c96ade8463 [ticket/11508] Split parts of build_url() into reusable functions.
PHPBB3-11508
2014-04-22 15:21:01 -07:00
Crizzo
600ab46a93 [ticket/12404] Changes append/prepend to after/before
PHPBB3-12404
2014-04-22 22:06:31 +02:00
Crizzo
94c21684ff [ticket/12404] Adds two new events and changes some places
PHPBB3-12404
2014-04-22 21:28:10 +02:00
Joas Schilling
5b6a675399 Merge pull request #2036 from prototech/ticket/12201
[ticket/12201] Clean up ACP attachment management page

* prototech/ticket/12201:
  [ticket/12201] Decreased pagination font size.
  [ticket/12201] Update select element to follow same design as prosilver.
  [ticket/12201] Increase sort font size just slightly.
  [ticket/12201] Add link to resync file stats after error.
  [ticket/12201] Fix typos in language pack.
  [ticket/12201] Display error and sorting options when there are no attachments
  [ticket/12201] Only the top pagination should be floated to the right.
  [ticket/12201] Rearrange pagination, sorting, and submit elements.
  [ticket/12201] Center the file size and mark columns.
  [ticket/12201] Separate pagination from table.
2014-04-22 19:58:15 +02:00
Joas Schilling
121bd90873 Merge pull request #2337 from prototech/ticket/12130
[ticket/12130] Fix issue with li:first-child in <ul> having a bullet in IE8.

* prototech/ticket/12130:
  [ticket/12130] Fix issue with li:first-child in <ul> having a bullet in IE8.
2014-04-22 19:51:16 +02:00
Joas Schilling
36ef90528b Merge pull request #2335 from Elsensee/ticket/12422
[ticket/12422] Fix debug warning in log search

* Elsensee/ticket/12422:
  [ticket/12422] Add tests
  [ticket/12422] Fix debug warning in log search
2014-04-22 19:42:20 +02:00
Andreas Fischer
631182524a Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
2014-04-22 19:25:14 +02:00
Andreas Fischer
d50d8a1512 Merge pull request #2342 from nickvergessen/ticket/12413-ascraeus
[ticket/12413-ascraeus] Revert e65a6dd8f4 in olympus

* nickvergessen/ticket/12413-ascraeus:
  [ticket/12413] Revert e65a6dd8f4
2014-04-22 19:25:10 +02:00
Andreas Fischer
c0f3011b53 Merge pull request #2341 from nickvergessen/ticket/12413
[ticket/12413] Revert e65a6dd8f4 in olympus

* nickvergessen/ticket/12413:
  [ticket/12413] Revert e65a6dd8f4
2014-04-22 19:24:43 +02:00
Joas Schilling
3425eeaf7d [ticket/12413] Revert e65a6dd8f4 in olympus
Merge branch 'ticket/12413' into ticket/12413-ascraeus

* ticket/12413:
  [ticket/12413] Revert e65a6dd8f4

Conflicts:
	phpBB/feed.php

The reverting is not done for develop-ascraeus and above.
We want to fix it properly there instead.

PHPBB3-12413
2014-04-22 19:04:32 +02:00
Joas Schilling
f9cdec90fc [ticket/12413] Revert e65a6dd8f4
"Merge remote-tracking branch 'dhruvgoel92/ticket/11271' into develop-olympus"

This reverts commit e65a6dd8f4, reversing
changes made to 214f515e9c.

PHPBB3-12413
2014-04-22 18:55:17 +02:00
Joas Schilling
ed07f1b85e Merge pull request #2248 from Elsensee/ticket/12193
[ticket/12193] Fix broken HTML if SQL error occurs during migration

* Elsensee/ticket/12193:
  [ticket/12193] Fix broken HTML if SQL error occurs during migration
2014-04-22 18:25:33 +02:00
Joas Schilling
e360f911f8 Merge pull request #2334 from bantu/ticket/12423
Stable Composer Minimum Stability + Some Composer Dependency Updates

* bantu/ticket/12423:
  [ticket/12424] Update Symfony component from v2.3.4 to v2.3.12.
  [ticket/12423] Move PHP CodeSniffer from non-stable 1.5.0RC4 to latest 1.5.2.
  [ticket/12423] Increase Composer minimum-stability to stable.
2014-04-22 13:42:04 +02:00
Oliver Schramm
bf3425b0f8 [ticket/12422] Add tests
PHPBB3-12422
2014-04-22 03:20:41 +02:00
Cesar G
227949d10b [ticket/12130] Fix issue with li:first-child in <ul> having a bullet in IE8.
PHPBB3-12130
2014-04-20 19:32:35 -07:00
Cesar G
52ebeb5f82 Merge remote-tracking branch 'PayBas/ticket/12347' into develop-ascraeus
* PayBas/ticket/12347:
  [ticket/12347] Remove unknown/unnecessary hack
  [ticket/12347] IE8 compatible CSS selector
  [ticket/12347] Changed from :after to :before
  [ticket/12347] Changed to the new navbar templates
2014-04-20 19:26:08 -07:00
Joas Schilling
c4bd2d682f Merge pull request #2332 from VSEphpbb/ticket/12405
[ticket/12405] Valid timezone and dateformat for create_user() in tests

* VSEphpbb/ticket/12405:
  [ticket/12405] Valid timezone and dateformat for create_user() in tests
2014-04-20 22:10:21 +02:00
PayBas
1abd031ad6 [ticket/12347] Remove unknown/unnecessary hack
PHPBB3-12347
2014-04-20 20:53:29 +02:00
PayBas
4e1a86d848 [ticket/12389] Moved PM tools to UCP template
PHPBB3-12389
2014-04-20 20:33:34 +02:00
Cesar G
889f6673b2 Merge remote-tracking branch 'PayBas/ticket/12363' into develop-ascraeus
* PayBas/ticket/12363:
  [ticket/12363] Fix typo
  [ticket/12363] changed _winner_ to _most-votes_
  [ticket/12363] Mark winning (most votes) results bar
2014-04-20 10:17:08 -07:00
Oliver Schramm
1905a2a7b2 [ticket/12422] Fix debug warning in log search
PHPBB3-12422
2014-04-20 18:36:39 +02:00
PayBas
f13689887e Merge pull request #3 from prototech/ticket/12389
[ticket/12389] Replace email and print icons.
2014-04-20 18:15:50 +02:00
Cesar G
f890b7098f [ticket/12389] Replace email and print icons.
PHPBB3-12389
2014-04-20 08:57:35 -07:00
Andreas Fischer
92d82e80cb [ticket/12424] Update Symfony component from v2.3.4 to v2.3.12.
PHPBB3-12424
2014-04-20 16:48:26 +02:00
Andreas Fischer
22210d3dc4 [ticket/12423] Move PHP CodeSniffer from non-stable 1.5.0RC4 to latest 1.5.2.
PHPBB3-12423
2014-04-20 16:46:37 +02:00
Andreas Fischer
ca5438d8fe [ticket/12423] Increase Composer minimum-stability to stable.
PHPBB3-12423
2014-04-20 16:45:34 +02:00
Andreas Fischer
c31ea7af66 Merge pull request #2299 from nickvergessen/ticket/12390
[ticket/12390] Remove documentation, tests and other files from vendor/

* nickvergessen/ticket/12390:
  [ticket/12390] Add comment to composer.json to update the build target
  [ticket/12390] Move cleaning of vendor into it's own target
  [ticket/12390] Remove documentation, tests and other files from vendor/
2014-04-20 16:16:42 +02:00
Joas Schilling
bc1ab3dc79 [ticket/12273] Fix missing space in some Exceptions
PHPBB3-12273
2014-04-20 15:11:23 +02:00
Joas Schilling
08cce5fba5 [ticket/12273] Remove duplicated code
PHPBB3-12273
2014-04-20 14:58:24 +02:00
Joas Schilling
6849e8b36f [ticket/12273] Add file line to exception message
PHPBB3-12273
2014-04-20 14:57:18 +02:00
PayBas
f251a8b50d [ticket/12347] IE8 compatible CSS selector
PHPBB3-12347
2014-04-20 14:32:19 +02:00
Joas Schilling
b83a555da5 [ticket/12273] Move phpBB test to new file and use a data provider
PHPBB3-12273
2014-04-20 14:28:09 +02:00
Joas Schilling
8ddc9ff185 [ticket/12273] Allow multiple $vars lines
PHPBB3-12273
2014-04-20 14:15:54 +02:00
Joas Schilling
4775ad59b0 [ticket/12012] Fix docs in connection manager
PHPBB3-12012
2014-04-20 12:58:46 +02:00
Joas Schilling
0a953ddb15 [ticket/12012] Remove duplicated code (only the $sql are different)
PHPBB3-12012
2014-04-20 12:54:19 +02:00
Joas Schilling
1757fdd4b7 [ticket/12390] Add comment to composer.json to update the build target
PHPBB3-12390
2014-04-20 12:41:19 +02:00
Marc Alexander
bfd66ef2fd [ticket/12407] Merge @change in doc block of event
PHPBB3-12407
2014-04-20 12:38:55 +02:00
Matt Friedman
067ab9e800 [ticket/12405] Valid timezone and dateformat for create_user() in tests
PHPBB3-12405
2014-04-19 09:42:45 -07:00
Oliver Schramm
7cccd59cdc [ticket/12193] Fix broken HTML if SQL error occurs during migration
PHPBB3-12193
2014-04-19 16:58:38 +02:00
Cesar G
6f41e7a98b Merge remote-tracking branch 'VSEphpbb/ticket/12419' into develop-ascraeus
* VSEphpbb/ticket/12419:
  [ticket/12419] Also shrink the size of "See All" in footer a little bit
  [ticket/12419] Improve font size in notifications drop-down
2014-04-18 09:23:02 -07:00
Matt Friedman
34533a86da [ticket/12419] Also shrink the size of "See All" in footer a little bit
PHPBB3-12419
2014-04-18 09:17:36 -07:00
Matt Friedman
8b61ba238f [ticket/12419] Improve font size in notifications drop-down
PHPBB3-12419
2014-04-18 08:48:40 -07:00
Joas Schilling
1a913d6e0f [ticket/12273] Do not use Inline control structures
PHPBB3-12273
2014-04-18 14:05:38 +02:00
Joas Schilling
be48d12583 [ticket/12273] Fix Markdown layout
PHPBB3-12273
2014-04-18 13:07:41 +02:00
Joas Schilling
8f57880edb [ticket/12273] Fix missing $vars line
PHPBB3-12273
2014-04-18 13:07:41 +02:00
Joas Schilling
7b53210926 [ticket/12273] Fix invalid @event and @since tags
PHPBB3-12273
2014-04-18 13:07:40 +02:00
Joas Schilling
9ba9a024d6 [ticket/12273] Make event exporter compatible with php 5.3.3
PHPBB3-12273
2014-04-18 13:07:39 +02:00
Joas Schilling
3566325874 [ticket/12273] Fix export script
PHPBB3-12273
2014-04-18 12:57:39 +02:00
Joas Schilling
17a1ed6fb5 [ticket/12273] Move MD Exporter to separate file
PHPBB3-12273
2014-04-18 12:57:30 +02:00
Joas Schilling
6da52acb3c [ticket/12273] Rename exporter to php_exporter
PHPBB3-12273
2014-04-18 12:57:23 +02:00
Joas Schilling
3352d9fd34 [ticket/12273] Move event exporter to namespace
PHPBB3-12273
2014-04-18 12:57:13 +02:00
Joas Schilling
d213e09a40 [ticket/12273] Crawl the phpBB directory for events
PHPBB3-12273
2014-04-18 12:57:06 +02:00
Joas Schilling
b831e96aaf [ticket/12273] Use class properties instead of parameters
PHPBB3-12273
2014-04-18 12:56:59 +02:00
Joas Schilling
91deb4419b [ticket/12273] Add more tests for the event exporter
PHPBB3-12273
2014-04-18 12:56:51 +02:00
Joas Schilling
4a3756741c [ticket/12273] Move grabbing the $vars array line to a method
PHPBB3-12273
2014-04-18 12:56:43 +02:00
Joas Schilling
5387511f89 [ticket/12273] Grab name of events with a function
PHPBB3-12273
2014-04-18 12:56:34 +02:00
Joas Schilling
6c57edf3a3 [ticket/12273] Use the new class
PHPBB3-12273
2014-04-18 12:56:24 +02:00
Joas Schilling
22de4a5927 [ticket/12273] Add a basic set of tests for the exporter
PHPBB3-12273
2014-04-18 12:55:12 +02:00
Tristan Darricau
5008cbf903 [ticket/12418] Notice displayed for feed.php
https://tracker.phpbb.com/browse/PHPBB3-12418

language/viewtopic.php isn't loaded, so MISSING_INLINE_ATTACHMENT isn't
available.

PHPBB3-12418
2014-04-18 00:33:02 +02:00
Joas Schilling
3608abdf8c Merge pull request #2317 from Elsensee/ticket/11978
[ticket/11978] Fix width of topic search text field

* Elsensee/ticket/11978:
  [ticket/11978] Fix width of topic search text field
2014-04-17 23:31:45 +02:00
Oliver Schramm
933dcde805 [ticket/8558] Fix field length in ACP
PHPBB3-8558
2014-04-17 23:13:39 +02:00
Oliver Schramm
59cdc26fb4 [ticket/8558] Use only one variable and improve explain string
PHPBB3-8558
2014-04-17 23:12:32 +02:00
Oliver Schramm
809054abfd [ticket/8558] Add config in migrations and schema_data
PHPBB3-8558
2014-04-17 15:17:54 +02:00
rxu
71422e5180 [ticket/12409] Add acp_users.php core events to modify users preferences data
There're events to modify UCP user preferences in ucp_prefs.php,
so it makes sense to add related events to acp_users.php to control
new user's prefs via ACP.

PHPBB3-12409
2014-04-17 20:40:20 +08:00
Markus Stenudd
40c685e6fc [ticket/8558] Add display name in emails from board
PHPBB3-8558
2014-04-17 13:30:48 +02:00
Joas Schilling
a75ac5efd2 [ticket/12012] Handle begin and commit transactions in tests
PHPBB3-12012
2014-04-17 11:35:10 +02:00
Joas Schilling
7dc163f2b7 [ticket/12012] Drop and recreate indexes when removing columns
PHPBB3-12012
2014-04-17 11:35:09 +02:00
Joas Schilling
5403848902 [ticket/12012] Add a unit test for removing a column with indexes
PHPBB3-12012
2014-04-17 11:35:03 +02:00
Joas Schilling
a48f1abf66 [ticket/12012] Add a unit test for changing the column type
PHPBB3-12012
2014-04-17 11:29:45 +02:00
Joas Schilling
190b4282df [ticket/12012] Return SQL statements for index drop/create
Otherwise we recreate the index before changing the column

PHPBB3-12012
2014-04-17 11:29:44 +02:00
Joas Schilling
e2784d01ce [ticket/12012] Fix tools::mssql_get_existing_indexes() for SQL Server 2000
PHPBB3-12012
2014-04-17 11:29:44 +02:00
Joas Schilling
9036cdaaa2 [ticket/12012] Drop and recreate indexes when changing a column on MSSQL
PHPBB3-12012
2014-04-17 11:29:43 +02:00
Joas Schilling
29ba06968d [ticket/12012] Fix query layout
PHPBB3-12012
2014-04-17 11:29:42 +02:00
Joas Schilling
743d816631 [ticket/12012] Correctly drop default value constraints on MSSQL
We need to drop the default constraints of a column,
before being able to change their type or deleting them.

PHPBB3-12012
2014-04-17 11:29:42 +02:00
n-aleha
31e11d81e8 [ticket/12406] Fix variable description of core.viewtopic_modify_page_title
Variable page_title should be described as "Title of the viewtopic page".

PHPBB3-12406
2014-04-17 01:47:18 +03:00
Joas Schilling
0da5e3bee9 Merge pull request #2318 from prototech/ticket/12121
[ticket/12121] Preserve link redirect counts when updating from 3.0.x.

* prototech/ticket/12121:
  [ticket/12121] Preserve link redirect counts when updating from 3.0.x.
2014-04-16 23:33:03 +02:00
Joas Schilling
659c2e14b8 Merge pull request #2243 from n-aleha/ticket/12345
[ticket/12345] Improve search flood interval message for ascraeus

* n-aleha/ticket/12345:
  [ticket/12345] Improve search flood interval message for ascraeus
2014-04-16 23:26:09 +02:00
Joas Schilling
7f3aebd495 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12417] Revert "No longer allow Travis CI HHVM environment to fail."
2014-04-16 22:47:27 +02:00
Joas Schilling
d735129d6e Merge pull request #2324 from bantu/ticket/12417
[ticket/12417] Revert "No longer allow Travis CI HHVM environment to fai...

* bantu/ticket/12417:
  [ticket/12417] Revert "No longer allow Travis CI HHVM environment to fail."
2014-04-16 22:46:41 +02:00
Andreas Fischer
04893e3f98 [ticket/12417] Revert "No longer allow Travis CI HHVM environment to fail."
hhvm-nightly 2014.04.16~precise introduced "Attempted to serialize
unserializable builtin class DOMElement" errors when running functional tests.

This reverts commit ff7cc77f9d.

PHPBB3-12417
2014-04-16 22:16:52 +02:00
Crizzo
23bf9d0c42 [ticket/12404] Adds a new event before and after the Timezone display
PHPBB3-12404
2014-04-16 21:03:03 +02:00
Joas Schilling
013cc2c66f [ticket/12390] Move cleaning of vendor into it's own target
PHPBB3-12390
2014-04-16 20:16:03 +02:00
Oliver Schramm
e0151abdb5 [ticket/8558] Do string concatenation only once and do htmlspecialchars
PHPBB3-8558
2014-04-16 17:48:09 +02:00
Markus Stenudd
7e7647c159 [ticket/8558] Add display name in emails from board
PHPBB3-8558
2014-04-16 16:07:55 +02:00
Marc Alexander
a3dbfb749e [ticket/12407] Assign template variables again after merging develop-ascraeus
PHPBB3-12407
2014-04-16 11:10:29 +02:00
Marc Alexander
01030bb3a9 Merge branch 'develop-ascraeus' of https://github.com/phpbb/phpbb into ticket/12407
Conflicts:
	phpBB/posting.php
2014-04-16 11:08:31 +02:00
Marc Alexander
0679a403d5 Merge branch 'ticket/8960-olympus' into ticket/8960
Conflicts:
	phpBB/includes/acp/acp_board.php
2014-04-16 10:11:09 +02:00
Cesar G
3d1a07f8f0 [ticket/12121] Preserve link redirect counts when updating from 3.0.x.
PHPBB3-12121
2014-04-15 21:15:54 -07:00
n-aleha
1f44b4da18 [ticket/12345] Improve search flood interval message for ascraeus
Show to guests and users the remaining seconds until their next allowed
search, if a search flood limit is enabled for them.

PHPBB3-12345
2014-04-16 02:14:36 +03:00
Joas Schilling
b305364b27 Merge pull request #2305 from n-aleha/ticket/12391
[ticket/12391] Assign variables to core.posting_modify_template_vars

* n-aleha/ticket/12391:
  [ticket/12391] Assign variables to core.posting_modify_template_vars
2014-04-16 00:57:07 +02:00
Joas Schilling
e50b6b5889 Merge pull request #2304 from n-aleha/ticket/12191
[ticket/12191] Move notification options to bottom while installing

* n-aleha/ticket/12191:
  [ticket/12191] Move notification options to bottom while installing
2014-04-16 00:49:59 +02:00
Joas Schilling
c4e3cc0850 Merge pull request #2301 from rxu/ticket/12401
[ticket/12401] Add $topic_data array to core.viewtopic_modify_post_row event

* rxu/ticket/12401:
  [ticket/12401] Pass more data to core.viewtopic_modify_post_row event
2014-04-16 00:17:31 +02:00
Cesar G
a9fbc34cf4 [ticket/12201] Decreased pagination font size.
PHPBB3-12201
2014-04-15 15:14:47 -07:00
Cesar G
e174e29b41 [ticket/12201] Update select element to follow same design as prosilver.
PHPBB3-12201
2014-04-15 15:10:15 -07:00
Joas Schilling
07442211b9 Merge pull request #2300 from rxu/ticket/12400
[ticket/12400] Add viewforum event to modify topics data

* rxu/ticket/12400:
  [ticket/12400] Add viewforum event to modify topics data
2014-04-16 00:03:20 +02:00
Cesar G
ccadda530d [ticket/12201] Increase sort font size just slightly.
PHPBB3-12201
2014-04-15 15:00:34 -07:00
Andreas Fischer
41db97ad3a Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12397] Fix sql_unique_index_exists doc block
2014-04-15 23:59:56 +02:00
Andreas Fischer
e9807e1741 Merge pull request #2310 from n-aleha/ticket/12397
[ticket/12397] Fix sql_unique_index_exists doc block

* n-aleha/ticket/12397:
  [ticket/12397] Fix sql_unique_index_exists doc block
2014-04-15 23:59:39 +02:00
n-aleha
bff63be512 [ticket/12397] Fix sql_unique_index_exists doc block
db_tools::sql_unique_index_exists() searches for unique indexes but not
primary key indexes.

PHPBB3-12397
2014-04-16 00:55:05 +03:00
Joas Schilling
d1f96aa036 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/10423] Replace foreach with function in viewtopic.php
  [ticket/10423] Remove unnecessary include in test
  [ticket/10423] Match multiple wildcards
  [ticket/10423] Move code into a function and add tests for it
  [ticket/10423] Remove * from search or highlight string
2014-04-15 23:23:44 +02:00
Joas Schilling
675cef9c2e Merge pull request #2195 from Elsensee/ticket/10423
[ticket/10423] Remove * from search or highlight string

* Elsensee/ticket/10423:
  [ticket/10423] Replace foreach with function in viewtopic.php
  [ticket/10423] Remove unnecessary include in test
  [ticket/10423] Match multiple wildcards
  [ticket/10423] Move code into a function and add tests for it
  [ticket/10423] Remove * from search or highlight string
2014-04-15 23:23:26 +02:00
Cesar G
b73e22ae71 [ticket/12201] Add link to resync file stats after error.
PHPBB3-12201
2014-04-15 14:19:47 -07:00
Oliver Schramm
7824535839 [ticket/11978] Fix width of topic search text field
PHPBB3-11978
2014-04-15 23:18:41 +02:00
Cesar G
52251acefa [ticket/12201] Fix typos in language pack.
PHPBB3-12201
2014-04-15 13:57:45 -07:00
Cesar G
38775fc063 [ticket/12201] Display error and sorting options when there are no attachments
PHPBB3-12201
2014-04-15 13:57:45 -07:00
Cesar G
01464e2451 [ticket/12201] Only the top pagination should be floated to the right.
PHPBB3-12201
2014-04-15 13:57:45 -07:00
Cesar G
f78d4196ea [ticket/12201] Rearrange pagination, sorting, and submit elements.
PHPBB3-12201
2014-04-15 13:57:45 -07:00
Cesar G
609c4efff6 [ticket/12201] Center the file size and mark columns.
PHPBB3-12201
2014-04-15 13:57:45 -07:00
Cesar G
efe667130d [ticket/12201] Separate pagination from table.
PHPBB3-12201
2014-04-15 13:57:45 -07:00
Joas Schilling
c63b5275d8 Merge branch 'ticket/lucifer4o/12344' into develop-ascraeus
* ticket/lucifer4o/12344:
  [ticket/12344] Add core.pm_submit_before to function submit_pm
2014-04-15 22:25:43 +02:00
lucifer4o
84c8c61eb2 [ticket/12344] Add core.pm_submit_before to function submit_pm
PHPBB3-12344
2014-04-15 22:19:47 +02:00
Oliver Schramm
f3cd7f73e1 [ticket/10423] Replace foreach with function in viewtopic.php
PHPBB3-10423
2014-04-15 20:43:16 +02:00
Oliver Schramm
601ecd3da1 [ticket/10423] Remove unnecessary include in test
PHPBB3-10423
2014-04-15 20:43:01 +02:00
Cesar G
ed4b72d1f2 [ticket/12265] Actually use $u_pm.
PHPBB3-12265
2014-04-15 09:15:52 -07:00
Cesar G
05dec34917 [ticket/12265] Ensure that dropdown is always at the very left of the container
PHPBB3-12265
2014-04-15 09:00:14 -07:00
Cesar G
975c5655f0 [ticket/12265] Define a loop for contact icons.
PHPBB3-12265
2014-04-15 08:56:34 -07:00
Cesar G
161b610a94 [ticket/12265] Break the icons that aren't in loop in case extensions add more
PHPBB3-12265
2014-04-15 08:56:34 -07:00
Cesar G
ed45981a50 [ticket/12265] Fix modulo logic.
PHPBB3-12265
2014-04-15 08:56:34 -07:00
Cesar G
89532ebbbe [ticket/12265] Adjust alignment of AIM and Jabber icons.
PHPBB3-12265
2014-04-15 08:56:34 -07:00
Cesar G
b9f9c33199 [ticket/12265] Ensure that there's only 4 icons per row in IE & Opera.
PHPBB3-12265
2014-04-15 08:56:34 -07:00
Cesar G
11dd010f84 [ticket/12265] Add contact icon and remove border from last row & cells.
PHPBB3-12265
2014-04-15 08:56:34 -07:00
Cesar G
ec145419ed [ticket/12265] Fix issue with dropdown being restricted by the width of parent
PHPBB3-12265
2014-04-15 08:56:34 -07:00
Cesar G
df8832455d [ticket/12265] Remove ugly logic.
PHPBB3-12265
2014-04-15 08:56:34 -07:00
Cesar G
eae37267a5 [ticket/12265] Simplify contact icon design and move to dropdown.
PHPBB3-12265
2014-04-15 08:56:34 -07:00
Andreas Fischer
7d4be1fe19 Merge pull request #2286 from nickvergessen/ticket/12388
[ticket/12388] Fix translation of log entries without additional log data

* nickvergessen/ticket/12388:
  [ticket/12388] Add tests for lang() use on log actions without data
  [ticket/12388] Fix translation of log entries without additional log data
2014-04-15 11:38:21 +02:00
Marc Alexander
c6fd2f01eb [ticket/8960] Allow changing avatar path if it's not writable
This change will allow users to change the avatar path even if it's not
writable. However, this will get rid of the error message that the path is
not writable. Due to this, a minor addition to the explain message in the ACP
settings has been made.

PHPBB3-8960
2014-04-14 22:44:37 +02:00
Zoddo
aa5f268ea5 [ticket/12275] Change if (empty) to if (!isset)
PHPBB3-12275
2014-04-14 22:02:48 +02:00
PayBas
1c72e97bc8 [ticket/12347] Changed from :after to :before
PHPBB3-12347
2014-04-14 20:57:22 +02:00
Joas Schilling
91eaae122f [ticket/12382] Mark broken nested loop with include as incomplete
PHPBB3-12382
2014-04-14 18:56:34 +02:00
Marc Alexander
61f4802b5a [ticket/12407] Add message_parser as passed variable to event
PHPBB3-12407
2014-04-14 16:00:12 +02:00
Marc Alexander
b2bfcda19c [ticket/12407] Allow changing of post_data, etc. at end of posting.php
The current event core.posting_modify_template_vars is just ran using dispatch
but it doesn't pass any data from posting.php to the listener. Because of that,
it's not possible to know anything from posting.php and therefore limits the
use cases of this event. This will change it to allow similar actions as with
the event core.modify_posting_parameters.

PHPBB3-12407
2014-04-14 14:40:50 +02:00
n-aleha
11c4d14a9b [ticket/12391] Assign variables to core.posting_modify_template_vars
Assign variables to event "core.posting_modify_template_vars".
Also, fix a couple of typos.

PHPBB3-12391
2014-04-14 14:37:21 +03:00
Joas Schilling
b487da7c05 Merge remote-tracking branch 'marc/ticket/12004' into develop-ascraeus
* marc/ticket/12004:
  [ticket/12004] Support empty routes to app.php/ in path_helper
2014-04-14 12:40:47 +02:00
Joas Schilling
aebf2cc5cd Merge remote-tracking branch 'marc/ticket/12372' into develop-ascraeus
* marc/ticket/12372:
  [ticket/12372] Use $() instead of jQuery() in core.js for toggleDisplay
  [ticket/12372] Use admin.js $(document).ready for hiding questionnaire details
  [ticket/12372] Rename JS function dE() to phpbb.toggleDisplay()
  [ticket/12372] Move dE() function core.js
  [ticket/12372] Unify definition of function dE() across all files
  [ticket/12372] Use jQuery in javascript dE() function
2014-04-14 12:33:33 +02:00
n-aleha
6584f5eba6 [ticket/12191] Move notification options to bottom while installing
Move "ucp>board preferences>edit notification options" to bottom while
installing.

PHPBB3-12191
2014-04-14 00:02:28 +03:00
Joas Schilling
3ce479f061 Merge remote-tracking branch 'marc/ticket/12398' into develop-ascraeus
* marc/ticket/12398:
  [ticket/12398] Select correct post to restore during softdelete tests
2014-04-13 22:42:45 +02:00
Marc Alexander
ad1513cde9 [ticket/12398] Select correct post to restore during softdelete tests
PHPBB3-12398
2014-04-13 22:22:55 +02:00
Oliver Schramm
dde7ac3b2b [ticket/10423] Match multiple wildcards
Multiple wildcards are removed from the string if there is
no word before or after them. If there is a word before or
after them, they are just replaced with a single one.

PHPBB3-10423
2014-04-13 21:36:09 +02:00
Oliver Schramm
face175471 [ticket/10423] Move code into a function and add tests for it
PHPBB3-10423
2014-04-13 21:15:14 +02:00
rxu
62a729e85e [ticket/12401] Pass more data to core.viewtopic_modify_post_row event
$topic_data array is used in viewtopic.php to populate $post_row template
block array data. Although $topic_data is not being passed
to core.viewtopic_modify_post_row event for modifying/adding
$post_row data in it. So, pass this array to the event.
Also, total_posts is added.

PHPBB3-12401
2014-04-13 23:13:55 +08:00
rxu
e6a4633b51 [ticket/12400] Add viewforum event to modify topics data
The event allows extensions to use and/or modify topics list and/or
topics data before dumping out the viewforum page.
For extensions which operate with viewforum page, f.e. if the topics list
and data is needed to retrieve, add, modify additional topics info
before the output loop.

PHPBB3-12400
2014-04-13 22:51:24 +08:00
Joas Schilling
cbc1c4bf31 Merge remote-tracking branch 'marc/ticket/12398' into develop-ascraeus
* marc/ticket/12398:
  [ticket/12398] Use return of submit_post in softdelete and download tests
  [ticket/12398] Use submit_post return in prune_shadow_topic_test
2014-04-12 16:45:30 +02:00
Joas Schilling
8d012197f4 [ticket/12390] Remove documentation, tests and other files from vendor/
PHPBB3-12390
2014-04-12 16:35:20 +02:00
Marc Alexander
5124920d22 [ticket/12398] Use return of submit_post in softdelete and download tests
PHPBB3-12398
2014-04-12 14:36:05 +02:00
Marc Alexander
bd31ebd287 [ticket/12398] Use submit_post return in prune_shadow_topic_test
This should get rid of possible failures during functional tests.

PHPBB3-12398
2014-04-12 14:34:16 +02:00
Cesar G
1efb0a8488 Merge remote-tracking branch 'nickvergessen/ticket/12395' into develop-ascraeus
* nickvergessen/ticket/12395:
  [ticket/12395] Check for posts in the middle of the page
2014-04-12 03:34:51 -07:00
Joas Schilling
3d9b5aed46 [ticket/11917] Move OAuth Module to the bottom while installing
PHPBB3-11917
2014-04-12 11:50:55 +02:00
Joas Schilling
57146ccdd1 [ticket/11917] Hide OAuth UCP Module when OAuth is not the selected backend
PHPBB3-11917
2014-04-12 11:50:54 +02:00
Joas Schilling
b3a758a43b [ticket/12382] Add template test for subloops inside includes
PHPBB3-12382
2014-04-12 11:13:06 +02:00
Joas Schilling
beeca90861 [ticket/12395] Check for posts in the middle of the page
PHPBB3-12395
2014-04-12 10:46:06 +02:00
Joas Schilling
da834a96f9 Merge remote-tracking branch 'marc/ticket/12211' into develop-ascraeus
* marc/ticket/12211:
  [ticket/12211] Do not run attachment file names twice through htmlspecialchars
2014-04-12 10:16:41 +02:00
Matt Friedman
42c60c6a9f [ticket/12254] No longer need to add change_lang to the URL params
PHPBB3-12254
2014-04-11 21:11:32 -07:00
Andreas Fischer
b19ee00b9c [ticket/12384] Run Travis CI HHVM tests against MySQLi instead of MySQL.
HHVM MySQLi has been fixed and works for us now.

PHPBB3-12384
2014-04-12 01:58:54 +02:00
Cesar G
c1bcc1e7b3 Merge remote-tracking branch 'VarunAgw/ticket/12351' into develop-ascraeus
* VarunAgw/ticket/12351:
  [ticket/12351] Add loading indicator to links that are missing it.
2014-04-11 15:40:01 -07:00
Marc Alexander
106be54de3 [ticket/12211] Do not run attachment file names twice through htmlspecialchars
Upload filenames are already processed via htmlspecialchars in the
type_cast_helper of the new request class. There is no need to run it through
htmlspecialchars() again in the filespec class.

PHPBB3-12211
2014-04-11 21:10:28 +02:00
Varun Agrawal
bf79367a65 [ticket/12351] Add loading indicator to links that are missing it.
When you click on the link, the turning circle is missing, so you don't
know whether it is actually doing something or not, until the response is
served.

PHPBB3-12351
2014-04-12 00:28:59 +05:30
PayBas
9c8ea7bdba [ticket/12389] Change language of email friend
PHPBB3-12389
2014-04-11 19:48:18 +02:00
PayBas
0e842d9958 [ticket/12389] Move print topic & email topic icons to topic tools
PHPBB3-12389
2014-04-11 19:41:40 +02:00
Matt Friedman
60be502190 [ticket/12254] Use 'language' instead of 'set_lang' as the variable name
PHPBB3-12254
2014-04-11 08:50:15 -07:00
Marc Alexander
5dc3651290 [ticket/12004] Support empty routes to app.php/ in path_helper
The symfony routing component allows us to use the path "/" for routes.
Therefore, we should be able to use example.com/app.php/ for controllers.
However, this currently does not properly work. The method get_web_root_path
incorrectly returns phpbb_root_path. Therefore, paths to images or files are
broken.

PHPBB3-12004
2014-04-11 17:21:30 +02:00
Joas Schilling
13a34ce59f Merge remote-tracking branch 'rxu/ticket/12336' into develop-ascraeus
* rxu/ticket/12336:
  [ticket/12336] Add functions_module.php core event
2014-04-11 16:31:26 +02:00
Joas Schilling
a6183c6484 Merge remote-tracking branch 'marc/ticket/12386' into develop-ascraeus
* marc/ticket/12386:
  [ticket/12386] Rename DEBUG_EXTRA to DEBUG_CONTAINER for more descriptive name
  [ticket/12386] Add DEBUG_EXTRA again and use it for container creation
2014-04-11 16:23:07 +02:00
Joas Schilling
68bd70ef37 [ticket/12388] Add tests for lang() use on log actions without data
PHPBB3-12388
2014-04-11 13:09:16 +02:00
PayBas
4abcdd9a18 [ticket/12347] Changed to the new navbar templates
PHPBB3-12347
2014-04-11 11:43:52 +02:00
Marc Alexander
fbeed2d975 [ticket/12372] Use $() instead of jQuery() in core.js for toggleDisplay
PHPBB3-12372
2014-04-11 11:31:22 +02:00
Marc Alexander
b2eef2f5f9 [ticket/12372] Use admin.js $(document).ready for hiding questionnaire details
PHPBB3-12372
2014-04-11 11:27:13 +02:00
Marc Alexander
03667081e1 [ticket/12386] Rename DEBUG_EXTRA to DEBUG_CONTAINER for more descriptive name
PHPBB3-12386
2014-04-11 11:11:31 +02:00
Marc Alexander
22090dc3a3 [ticket/12386] Add DEBUG_EXTRA again and use it for container creation
We are currently creating a new compiled container on every page load when
having DEBUG enabled. However, one might only have that enabled to be
presented with errors or for getting the page load stats.
This change will add the DEBUG_EXTRA constant again. It will be used for
choosing whether the compiled container should be created on every page load -
when defined as true - or just once after the cache is cleared.

PHPBB3-12386
2014-04-11 11:11:31 +02:00
Joas Schilling
d5363bd095 Merge remote-tracking branch 'vsephpbb/ticket/12283' into develop-ascraeus
* vsephpbb/ticket/12283:
  [ticket/12283] Remove obsolete online class from posting review page
2014-04-11 10:39:40 +02:00
Joas Schilling
59015cfaff Merge remote-tracking branch 'paybas/ticket/12377' into develop-ascraeus
* paybas/ticket/12377:
  [ticket/12377] Forgot to change the INCLUDEs
  [ticket/12377] Renamed template files to navbar_xxx
  [ticket/12377] Moved notifications to new template
  [ticket/12377] Forgot empty line at the end
  [ticket/12377] Move navbar(s) to new template file
2014-04-11 10:35:35 +02:00
Joas Schilling
b832ebe718 Merge remote-tracking branch 'vsephpbb/ticket/12380' into develop-ascraeus
* vsephpbb/ticket/12380:
  [ticket/12380] Explicity state the order of sorting for login keys
  [ticket/12380] Sort Remember Me keys by last login time in UCP
2014-04-11 10:32:53 +02:00
Joas Schilling
6664dbb586 Merge remote-tracking branch 'varunagw/ticket/12355' into develop-ascraeus
* varunagw/ticket/12355:
  [ticket/12355] Topic Tools not fully updated when subscribing/bookmarking
2014-04-11 09:13:45 +02:00
Joas Schilling
d3f378d1d6 [ticket/12388] Fix translation of log entries without additional log data
PHPBB3-12388
2014-04-11 09:08:46 +02:00
Varun Agrawal
285b7a1f4c [ticket/12355] Topic Tools not fully updated when subscribing/bookmarking
The Topic Tools menu appears at the top of a topic page and again at the
bottom of a topic page.
When you use the Topic Tools menu to Bookmark or Subscribe to a Topic, the
menu item you chose is updated to reflect that, by switching to say
Unsubscribe topic or Remove from Bookmarks.
However, this change is not mirrored in the other Topic Tools menu at the
other location on the page.
Both Topic Tools menus should be updated during the AJAX event, so that
they always show the same options to the user.
It is solved by creating a data-update-all attribute which contains all
the class/ID that will update when topic tool is clicked

PHPBB3-12355
2014-04-11 10:12:35 +05:30
Cesar G
251b2ba28f Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/10687] Improve error message if unable to get image dimensions
2014-04-10 17:42:59 -07:00
Cesar G
e64c2326bd Merge remote-tracking branch 'marc1706/ticket/10687' into develop-olympus
* marc1706/ticket/10687:
  [ticket/10687] Improve error message if unable to get image dimensions
2014-04-10 17:42:14 -07:00
Nils Adermann
3f74e5b88b Merge remote-tracking branch 'github-nickvergessen/ticket/12370' into develop-ascraeus
* github-nickvergessen/ticket/12370:
  [ticket/12370] Add unit tests for topic notifications
  [ticket/12370] Fix functional notification test and remove unneeded requests
  [ticket/12370] Do not delete topic notifications when the topic is visible
2014-04-10 14:26:41 -07:00
Nils Adermann
62fad6ae9b Merge remote-tracking branch 'github-nickvergessen/ticket/12367' into develop-ascraeus
* github-nickvergessen/ticket/12367:
  [ticket/12367] Change phpbb_wrapper_gmgetdate_test to use data providers
2014-04-10 14:25:01 -07:00
Nils Adermann
497d81af68 Merge remote-tracking branch 'github-nickvergessen/ticket/12113' into develop-ascraeus
* github-nickvergessen/ticket/12113:
  [ticket/12113] Fix view_log() tests
  [ticket/12113] Correctly use plurals when deleting user warnings
  [ticket/12113] Allow log entries to use plurals
2014-04-10 14:22:36 -07:00
Nils Adermann
90ebd49a2b Merge remote-tracking branch 'github-nickvergessen/ticket/12373' into develop-ascraeus
* github-nickvergessen/ticket/12373:
  [ticket/12373] Add to and from forum_id to LOG_MOVE log entries
2014-04-10 14:19:13 -07:00
Nils Adermann
5de4d181ee Merge remote-tracking branch 'github-nickvergessen/ticket/12348' into develop-ascraeus
* github-nickvergessen/ticket/12348:
  [ticket/12348] Allow to run create_schema_files when phpBB is not installed
2014-04-10 14:16:38 -07:00
Nils Adermann
0ad9833668 Merge remote-tracking branch 'github-nickvergessen/ticket/12331' into develop-ascraeus
* github-nickvergessen/ticket/12331:
  [ticket/12331] Add functional test for saving custom profile fields
  [ticket/12331] Fix SQL error when inserting a new entry to profile field data
2014-04-10 14:14:30 -07:00
Nils Adermann
e2654b34c8 Merge remote-tracking branch 'github-nickvergessen/ticket/12286' into develop-ascraeus
* github-nickvergessen/ticket/12286:
  [ticket/12286] Reword section about plurals
  [ticket/12286] Fix spelling of elephant(s) in the sample
  [ticket/12286] Correctly capitalize PHP
  [ticket/12286] Fix nesting of ul inside li element
  [ticket/12286] Add note that goto should not be used
  [ticket/12286] Add section about plurals to the coding guidelines
  [ticket/12286] Classes must use the name space
  [ticket/12286] Remove section about utf8_normalize_nfc()
  [ticket/12286] Use $request->variable() instead of request_var()
  [ticket/12286] Function names should be prefixed with phpbb_
  [ticket/12286] Add "Since" to template event docs
  [ticket/12286] style.php and imagesets dont exist anymore
  [ticket/12286] Styles have a phpbb_version and a style_version in 3.1
  [ticket/12286] Use UTF8 (c) in style.cfg samples
2014-04-10 14:05:56 -07:00
Nils Adermann
7a947b247d Merge remote-tracking branch 'github-nickvergessen/ticket/12282' into develop-ascraeus
* github-nickvergessen/ticket/12282:
  [ticket/12282] Update new references
  [ticket/12282] Update container db mock
  [ticket/12282] Add new line at EOF of the interface
  [ticket/12282] Use interface for type hinting
  [ticket/12282] Use {@inheritDoc} for inherited methods
  [ticket/12282] Add Interface for DBAL drivers
2014-04-10 14:04:43 -07:00
Nils Adermann
79fe781629 Merge remote-tracking branch 'github-nickvergessen/ticket/11352' into develop-ascraeus
* github-nickvergessen/ticket/11352:
  [ticket/11352] Add functional tests for disapproving a post/topic
  [ticket/11352] Redirect the user back to view*.php after disapproving
2014-04-10 13:56:30 -07:00
Matt Friedman
eb6b877330 [ticket/12380] Explicity state the order of sorting for login keys
PHPBB3-12380
2014-04-10 09:10:01 -07:00
Matt Friedman
49885e55e7 [ticket/12380] Sort Remember Me keys by last login time in UCP
PHPBB3-12380
2014-04-10 09:04:35 -07:00
Joas Schilling
09804bbae8 [ticket/12382] Add template test for subloops inside events
PHPBB3-12382
2014-04-10 16:06:00 +02:00
Andreas Fischer
2284e2897f Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12381] Fix broken error message when selecting invalid DB driver
2014-04-10 15:44:47 +02:00
Andreas Fischer
7d54fbd31a Merge pull request #2279 from Elsensee/ticket/12381
[ticket/12381] Fix broken error message when selecting invalid DB driver

* Elsensee/ticket/12381:
  [ticket/12381] Fix broken error message when selecting invalid DB driver
2014-04-10 15:44:35 +02:00
Oliver Schramm
87cfcda638 [ticket/12381] Fix broken error message when selecting invalid DB driver
PHPBB3-12381
2014-04-10 15:05:16 +02:00
Joas Schilling
0e2079da85 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12320] Install a nightly build of HHVM.
  [ticket/12320] No longer allow Travis CI HHVM environment to fail.
2014-04-10 13:38:17 +02:00
Joas Schilling
f0f479c517 Merge remote-tracking branch 'bantu/ticket/12320' into develop-olympus
* bantu/ticket/12320:
  [ticket/12320] Install a nightly build of HHVM.
  [ticket/12320] No longer allow Travis CI HHVM environment to fail.
2014-04-10 13:38:01 +02:00
PayBas
c8429b8e6a [ticket/12377] Forgot to change the INCLUDEs
PHPBB3-12377
2014-04-10 12:52:18 +02:00
PayBas
9dbc9b0cc2 [ticket/12377] Renamed template files to navbar_xxx
PHPBB3-12377
2014-04-10 12:52:18 +02:00
PayBas
95212746c7 [ticket/12377] Moved notifications to new template
And also reset all starting indentation to 0

PHPBB3-12377
2014-04-10 12:52:17 +02:00
PayBas
16b06c980d [ticket/12377] Forgot empty line at the end
PHPBB3-12377
2014-04-10 12:52:17 +02:00
PayBas
00d87e86ec [ticket/12377] Move navbar(s) to new template file
PHPBB3-12377
2014-04-10 12:52:16 +02:00
Joas Schilling
377fb770fb Merge remote-tracking branch 'vsephpbb/ticket/11098' into develop-ascraeus
* vsephpbb/ticket/11098:
  [ticket/11098] Fix error reporting on the autologin key pages
  [ticket/11098] Update subsilver2 to also include mark/unmark all buttons
  [ticket/11098] HTML Validity fix to Notifications in UCP
  [ticket/11098] Add mark/unmark all options to remember me keys
2014-04-10 12:08:01 +02:00
Joas Schilling
15dfa9bba2 Merge remote-tracking branch 'prototech/ticket/12375' into develop-ascraeus
* prototech/ticket/12375:
  [ticket/12375] Fix broken attachment deletion.
2014-04-10 12:03:41 +02:00
Joas Schilling
20c6139ad1 Merge remote-tracking branch 'prototech/ticket/12356' into develop-ascraeus
* prototech/ticket/12356:
  [ticket/12356] Assign vars preventing Plupload from loading in PM editor.
2014-04-10 11:59:32 +02:00
Joas Schilling
b785fff3ed Merge remote-tracking branch 'prototech/ticket/12379' into develop-ascraeus
* prototech/ticket/12379:
  [ticket/12379] Remove duplicate labels in attachment uploader when responsive.
2014-04-10 11:56:15 +02:00
Andreas Fischer
4d206e2ced [ticket/12320] Install a nightly build of HHVM.
PHPBB3-12320
2014-04-10 11:37:25 +02:00
Andreas Fischer
ff7cc77f9d [ticket/12320] No longer allow Travis CI HHVM environment to fail.
PHPBB3-12320
2014-04-10 11:36:48 +02:00
Matt Friedman
80bc30214f [ticket/11098] Fix error reporting on the autologin key pages
PHPBB3-11098
2014-04-09 23:17:30 -07:00
Matt Friedman
150a45b943 [ticket/11098] Update subsilver2 to also include mark/unmark all buttons
PHPBB3-11098
2014-04-09 19:16:45 -07:00
Cesar G
072094cb8d [ticket/12379] Remove duplicate labels in attachment uploader when responsive.
PHPBB3-12379
2014-04-09 18:10:38 -07:00
Matt Friedman
9eeb9ed259 [ticket/11098] HTML Validity fix to Notifications in UCP
PHPBB3-11098
2014-04-09 17:36:46 -07:00
Matt Friedman
51b152c8ab [ticket/11098] Add mark/unmark all options to remember me keys
PHPBB3-11098
2014-04-09 17:35:55 -07:00
Cesar G
55a674adcf Merge remote-tracking branch 'nickvergessen/ticket/8700' into develop-ascraeus
* nickvergessen/ticket/8700:
  [ticket/8700] Use L_COLON instead of adding ":" manually
  [ticket/8700] Remove unused language strings
2014-04-09 17:22:00 -07:00
Cesar G
b7d7f73693 Merge remote-tracking branch 'VSEphpbb/ticket/12365' into develop-ascraeus
* VSEphpbb/ticket/12365:
  [ticket/12365] Do not crop image attachments at 350px
2014-04-09 12:02:54 -07:00
Cesar G
a8ec1905e1 [ticket/12356] Assign vars preventing Plupload from loading in PM editor.
PHPBB3-12356
2014-04-09 11:38:14 -07:00
Marc Alexander
5c34b9c371 [ticket/10687] Improve error message if unable to get image dimensions
The error message that is presented if getimagesize() was unable to determine
an image's dimensions now additionally states that this might be caused by an
incorrect URL.

PHPBB3-10687
2014-04-09 14:55:49 +02:00
Cesar G
934696766a [ticket/12375] Fix broken attachment deletion.
The response is already parsed and when running it through parseJSON returned
null prior to 1.9. Now there's an actual error thrown, so the function is
returning and thus leaving the attachment row intact.

PHPBB3-12375
2014-04-08 21:51:56 -07:00
Matt Friedman
401a13b1a8 [ticket/12283] Remove obsolete online class from posting review page
PHPBB3-12283
2014-04-08 20:53:48 -07:00
Joas Schilling
88c47c251d [ticket/12373] Add to and from forum_id to LOG_MOVE log entries
PHPBB3-12373
2014-04-08 22:29:05 +02:00
Joas Schilling
0e3e715a48 Merge remote-tracking branch 'paybas/ticket/12369' into develop-ascraeus
* paybas/ticket/12369:
  [ticket/12369] White-space cleanup
  [ticket/12369] Removed template vars initial state
  [ticket/12369] Added ACP vars
  [ticket/12369] Add template var {BODY_CLASS} to HTML body
2014-04-08 20:57:06 +02:00
Joas Schilling
e11d833dcd Merge remote-tracking branch 'vsephpbb/ticket/12083' into develop-ascraeus
* vsephpbb/ticket/12083:
  [ticket/12083] Fix Select All in CODE bbcode with only one char
2014-04-08 07:47:27 +02:00
PayBas
f1201a8ec5 [ticket/12363] Fix typo
PHPBB3-12363
2014-04-07 23:39:49 +02:00
Matt Friedman
af6cabc106 [ticket/12254] Persist set_lang after reg only if changed from default
PHPBB3-12254
2014-04-07 13:58:47 -07:00
Dhruv
634e5cae0f Merge remote-tracking branch 'nickvergessen/ticket/12349' into develop-ascraeus
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/ticket/12349:
  [ticket/12349] Fix Sniffer for @license tag
  [ticket/12349] Update license header in several new files
2014-04-08 02:27:32 +05:30
PayBas
4cd6317d41 [ticket/12369] White-space cleanup
PHPBB3-12369
2014-04-07 22:46:22 +02:00
Joas Schilling
6c6916dc7d Merge remote-tracking branch 'Marc/ticket/12362' into develop-ascraeus
* Marc/ticket/12362:
  [ticket/12362] Do not use database test case as it's not needed
  [ticket/12362] Add tests for schema generator
  [ticket/12362] Throw exception in schema generator on unresolvable dependency
2014-04-07 22:42:42 +02:00
Joas Schilling
6593e028be [ticket/11352] Add functional tests for disapproving a post/topic
PHPBB3-11352
2014-04-07 22:37:20 +02:00
Joas Schilling
b2d73922c6 Merge remote-tracking branch 'paybas/ticket/12364' into develop-ascraeus
* paybas/ticket/12364:
  [ticket/12364] Add template identifier var to all missing pages
2014-04-07 22:24:18 +02:00
Joas Schilling
094a746715 Merge remote-tracking branch 'Elsensee/ticket/12360' into develop-ascraeus
* Elsensee/ticket/12360:
  [ticket/12360] Fix duplicated creation of session when logging out the user
2014-04-07 22:17:29 +02:00
Joas Schilling
be68ce657e Merge branch 'ticket/mael/12361' into develop-ascraeus
* ticket/mael/12361:
  [ticket/12361] Replace the Google logo.
2014-04-07 22:10:03 +02:00
Maël Soucaze
02f739e0e7 [ticket/12361] Replace the Google logo.
Currently, a link to Google and its logo are displayed in the
language/en/help_bbcode.php file to explain how to correctly format tags
and to add an image to a post. However, the Google logo is outdated and
Google does not allow the use of its logo on third-party websites. Plus,
that overload their servers. I used the blue phpBB logo to replace it
because the grey one with transparent background is hardly visible.

Originally, I just refreshed the old Google logo with the new one
(https://www.google.com/images/srpr/logo5w.png) but Joas proposed to use
the phpBB logo, and I agree with him.

PHPBB3-12361
2014-04-07 22:09:33 +02:00
Marc Alexander
91a1c3af90 [ticket/12372] Rename JS function dE() to phpbb.toggleDisplay()
PHPBB3-12372
2014-04-07 21:42:30 +02:00
Joas Schilling
c99584ec7b [ticket/12370] Add unit tests for topic notifications
PHPBB3-12370
2014-04-07 21:32:31 +02:00
Marc Alexander
966a2b4892 [ticket/12372] Move dE() function core.js
PHPBB3-12372
2014-04-07 21:27:48 +02:00
Marc Alexander
ad98a070c3 [ticket/12372] Unify definition of function dE() across all files
PHPBB3-12372
2014-04-07 20:43:32 +02:00
Marc Alexander
385420c8f5 [ticket/12372] Use jQuery in javascript dE() function
PHPBB3-12372
2014-04-07 20:40:21 +02:00
Nils Adermann
2efa0c2f8e Merge remote-tracking branch 'github-nickvergessen/ticket/12358' into develop-ascraeus
* github-nickvergessen/ticket/12358:
  [ticket/12358] Correctly check and change the redirect url for ajax requests
2014-04-07 14:20:39 -04:00
Joas Schilling
708db0f05c [ticket/12370] Fix functional notification test and remove unneeded requests
PHPBB3-12370
2014-04-07 19:42:18 +02:00
Joas Schilling
3315702b5f [ticket/12370] Do not delete topic notifications when the topic is visible
We should only delete the topic notifications, when the topic is not approved
anymore. This happens, when the post was the last approved but is now
unapproved because the user is on queue, or when it has been softdeleted while
editing.

PHPBB3-12370
2014-04-07 19:13:32 +02:00
Matt Friedman
8af9092cf6 [ticket/12254] Add set_lang var changes to subsilver2 files
PHPBB3-12254
2014-04-07 09:21:28 -07:00
Matt Friedman
daae87d65a [ticket/12254] Use new set_lang var to avoid conflict with change_lang
PHPBB3-12254
2014-04-07 09:14:58 -07:00
rxu
4b26292df2 [ticket/12336] Add functions_module.php core event
Add functions_module.php core event to allow adjusting parameters
for custom ACP, MCP, UCP modules (location: function list_modules()).

PHPBB3-12336
2014-04-07 23:59:38 +08:00
PayBas
964a75ba7c [ticket/12369] Removed template vars initial state
PHPBB3-12369
2014-04-07 17:56:27 +02:00
Joas Schilling
bcdd3d5bec [ticket/11352] Redirect the user back to view*.php after disapproving
The user should be redirected back to:
- the topic, if he came from viewtopic and the topic still exists
- the forum, if he came from viewtopic, but the topic does not exist anymore

PHPBB3-11352
2014-04-07 14:43:51 +02:00
Matt Friedman
a5940ede5b [ticket/12254] Stop using deprecated request_var in user class
PHPBB3-12254
2014-04-07 01:38:24 -07:00
Matt Friedman
41b0b8c5f9 [ticket/12254] Better language switching on registration page
PHPBB3-12254
2014-04-06 23:55:46 -07:00
PayBas
4e2e8f8621 [ticket/12369] Added ACP vars
PHPBB3-12369
2014-04-07 08:39:03 +02:00
PayBas
5bb0c65c24 [ticket/12369] Add template var {BODY_CLASS} to HTML body
http://tracker.phpbb.com/browse/PHPBB3-12369

PHPBB3-12369
2014-04-07 08:16:39 +02:00
Joas Schilling
60be4c70a7 [ticket/12358] Correctly check and change the redirect url for ajax requests
PHPBB3-12358
2014-04-07 00:06:55 +02:00
Oliver Schramm
1a56400a45 [ticket/12360] Fix duplicated creation of session when logging out the user
In 7d8b578 this line was introduced to fix a bug with style.php.

Later since 1d42d1b a new session is always created after
killing the old one.

This causes a duplicated creation of the session everytime
the user logs itself out.

PHPBB3-12360
2014-04-06 23:49:20 +02:00
Joas Schilling
2721b16cc3 [ticket/12367] Change phpbb_wrapper_gmgetdate_test to use data providers
PHPBB3-12367
2014-04-06 23:36:04 +02:00
Joas Schilling
f0176b5393 Merge remote-tracking branch 'Marc/ticket/12150' into develop-ascraeus
* Marc/ticket/12150:
  [ticket/12150] Use correct license URL in prune shadow migrations file
  [ticket/12150] Remove 'after' for columns from migrations file
  [ticket/12150] Update schema files for prune shadow topics
  [ticket/12150] Use log service instead of add_log() function
  [ticket/12150] Use shorter column names for prune settings
  [ticket/12150] Add functional tests for pruning shadow topics
  [ticket/12150] Add missing space to query for shadow topics
  [ticket/12150] Add missing prune settings variables in acp_forums
  [ticket/12150] Add file and caller for pruning shadow topics
  [ticket/12150] Add prune columns to schema files and migration file
  [ticket/12150] Add options to acp
2014-04-06 22:26:27 +02:00
PayBas
b64c5f84ab [ticket/12363] changed _winner_ to _most-votes_
PHPBB3-12363
2014-04-06 22:18:52 +02:00
Joas Schilling
6f122d6886 Merge remote-tracking branch 'Marc/ticket/12354' into develop-ascraeus
* Marc/ticket/12354:
  [ticket/12354] Assert same instead of equal where necessary in passwords tests
2014-04-06 22:18:34 +02:00
Marc Alexander
44a9bfc071 [ticket/12362] Do not use database test case as it's not needed
PHPBB3-12362
2014-04-06 22:04:00 +02:00
Marc Alexander
f123512280 [ticket/12362] Add tests for schema generator
PHPBB3-12362
2014-04-06 20:33:12 +02:00
Matt Friedman
7aa044a845 [ticket/12365] Do not crop image attachments at 350px
PHPBB3-12365
2014-04-06 09:35:26 -07:00
PayBas
66dad8d2fb [ticket/12364] Add template identifier var to all missing pages
PHPBB3-12364
2014-04-06 17:41:09 +02:00
PayBas
3384e87b6f [ticket/12363] Mark winning (most votes) results bar
PHPBB3-12363
2014-04-06 16:43:25 +02:00
Marc Alexander
904de5b39a [ticket/12362] Throw exception in schema generator on unresolvable dependency
Make sure we throw an exception in the schema generator if we come across an
unresolvable dependency. Otherwise we'll get stuck in a infinite loop that
needs to be cancelled by the user or the maximum execution time.

PHPBB3-12362
2014-04-06 14:50:22 +02:00
Andreas Fischer
0e88f0db4a Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12359] Remove inline width styling on UCP birthday fields

Conflicts:
	phpBB/styles/prosilver/template/ucp_profile_profile_info.html
2014-04-06 11:08:18 +02:00
Andreas Fischer
8920ca5d43 Merge remote-tracking branch 'VSEphpbb/ticket/12359' into develop-olympus
* VSEphpbb/ticket/12359:
  [ticket/12359] Remove inline width styling on UCP birthday fields
2014-04-06 11:04:38 +02:00
Matt Friedman
399f2f5a1f [ticket/12359] Remove inline width styling on UCP birthday fields
PHPBB3-12359
2014-04-05 21:13:38 -07:00
Matt Friedman
7e6d6a6be6 [ticket/12083] Fix Select All in CODE bbcode with only one char
PHPBB3-12083
2014-04-05 15:05:02 -07:00
Marc Alexander
06aa3d948a [ticket/12354] Assert same instead of equal where necessary in passwords tests
In some tests we try to make sure that we do not get the same output in a
limited timeframe. These tests should use assertSame/NotSame instead of
assertEqual/NotEqual.

PHPBB3-12354
2014-04-05 11:51:38 +02:00
Marc Alexander
e83c6cb61d [ticket/12150] Use correct license URL in prune shadow migrations file
PHPBB3-12150
2014-04-05 11:14:41 +02:00
Joas Schilling
d0aa7c6455 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
2014-04-05 10:06:19 +02:00
Joas Schilling
1b16b8cd42 Merge remote-tracking branch 'Marc/ticket/10851-ascraeus' into develop-ascraeus
* Marc/ticket/10851-ascraeus:
  [ticket/10851] Request index instead of logging in and out in tests
  [ticket/10851] Add unit and functional tests for checking attachments
  [ticket/10851] Set disallowed content to empty array if checking is disabled
2014-04-05 10:00:40 +02:00
Joas Schilling
352b523889 Merge remote-tracking branch 'Marc/ticket/10851' into develop-olympus
* Marc/ticket/10851:
  [ticket/10851] Set disallowed content to empty array if checking is disabled
2014-04-05 10:00:17 +02:00
Joas Schilling
ced48a51a4 Merge remote-tracking branch 'Elsensee/ticket/7707' into develop-ascraeus
* Elsensee/ticket/7707:
  [ticket/7707] Fix undefined variable: perm_from
  [ticket/7707] Add comma to last entry of arrays
  [ticket/7707] Remove unnecessary variables
  [ticket/7707] Add get_username_string() once more
  [ticket/7707] Remove unnecessary variables
  [ticket/7707] Add get_username_string() where possible
2014-04-05 09:54:14 +02:00
Joas Schilling
bd36ca1016 Merge remote-tracking branch 'paybas/ticket/12338' into develop-ascraeus
* paybas/ticket/12338:
  [ticket/12338] Add Template Event overall_footer_page_body_after

Conflicts:
	phpBB/docs/events.md
2014-04-04 23:57:06 +02:00
Joas Schilling
b5db7d49a8 Merge remote-tracking branch 'paybas/ticket/12333' into develop-ascraeus
* paybas/ticket/12333:
  [ticket/12333] Change event name
  [ticket/12333] Add Template Event overall_header_body_after
2014-04-04 23:55:36 +02:00
Joas Schilling
1a82ce9f48 Merge remote-tracking branch 'paybas/ticket/12327' into develop-ascraeus
* paybas/ticket/12327:
  [ticket/12327] Ajax fix
  [ticket/12327] Coding style fixes
  [ticket/12327] Changing poll result-bars width from absolute to relative
2014-04-04 23:52:04 +02:00
Oliver Schramm
8f525e1ef5 [ticket/7707] Fix undefined variable: perm_from
PHPBB3-7707
2014-04-04 23:48:14 +02:00
Joas Schilling
1a3a296558 Merge remote-tracking branch 'paybas/ticket/12339' into develop-ascraeus
* paybas/ticket/12339:
  [ticket/12339] removed return var
  [ticket/12339] more complete params and updated _since version
  [ticket/12339] Add Event core.page_header_after
2014-04-04 23:21:18 +02:00
Marc Alexander
fdfaba4607 [ticket/10851] Request index instead of logging in and out in tests
PHPBB3-10851
2014-04-04 20:56:39 +02:00
PayBas
20c18d08e9 [ticket/12327] Ajax fix
PHPBB3-12327
2014-04-04 18:53:00 +02:00
PayBas
e850e49a1b [ticket/12327] Coding style fixes
PHPBB3-12327
2014-04-04 18:53:00 +02:00
PayBas
bf37342c86 [ticket/12327] Changing poll result-bars width from absolute to relative
PHPBB3-12327
2014-04-04 18:52:59 +02:00
PayBas
084e6725f7 [ticket/12339] removed return var
need to learn more about events... evidently

PHPBB3-12339
2014-04-04 18:26:20 +02:00
Joas Schilling
82fa935d5d Merge remote-tracking branch 'vsephpbb/ticket/11962' into develop-ascraeus
* vsephpbb/ticket/11962:
  [ticket/11962] Resize posted images to fit and give them a class
2014-04-04 18:25:01 +02:00
Joas Schilling
e00a4b411d Merge remote-tracking branch 'vsephpbb/ticket/12342' into develop-ascraeus
* vsephpbb/ticket/12342:
  [ticket/12342] Remove spinner and fix useage of ajax on memberlist
  [ticket/12342] Fix the Custom Dates function in UCP Prefs Global
  [ticket/12342] Fix Find a member show / hide script
  [ticket/12342] Use prop() instead of attr() for boolean properties
2014-04-04 18:00:44 +02:00
Joas Schilling
9bfada03f3 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12353] Fix displayed attachments in ACP
2014-04-04 17:40:18 +02:00
Joas Schilling
67e049b7ff Merge remote-tracking branch 'Elsensee/ticket/12353' into develop-olympus
* Elsensee/ticket/12353:
  [ticket/12353] Fix displayed attachments in ACP
2014-04-04 17:39:51 +02:00
Oliver Schramm
744b39e6c4 [ticket/12353] Fix displayed attachments in ACP
PHPBB3-12353
2014-04-04 17:07:54 +02:00
PayBas
c6c5f7c874 [ticket/12339] more complete params and updated _since version
PHPBB3-12339
2014-04-04 13:45:57 +02:00
PayBas
069e515747 [ticket/12338] Add Template Event overall_footer_page_body_after
implement

PHPBB3-12338
2014-04-04 13:12:33 +02:00
Marc Alexander
91c3ad07ec [ticket/10851] Add unit and functional tests for checking attachments
These tests will make sure that fileuploads now work as expected regarding
the check for disallowed content.

PHPBB3-10851
2014-04-04 11:48:41 +02:00
Marc Alexander
e4e3df0b37 Merge branch 'ticket/10851' into ticket/10851-ascraeus 2014-04-04 11:48:17 +02:00
Joas Schilling
23455e92d0 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12318] Revert "Pin HHVM version to 3.0.0~precise."
2014-04-03 23:07:58 +02:00
Joas Schilling
296e573b6b Merge remote-tracking branch 'bantu/ticket/12318' into develop-olympus
* bantu/ticket/12318:
  [ticket/12318] Revert "Pin HHVM version to 3.0.0~precise."
2014-04-03 23:07:35 +02:00
Andreas Fischer
1a044711fb [ticket/12318] Revert "Pin HHVM version to 3.0.0~precise."
This reverts commit f6614f2078 as the install
command started failing with "Version '3.0.0~precise' for 'hhvm' was not found"
in the meantime.

PHPBB3-12318
2014-04-03 22:33:46 +02:00
Andreas Fischer
4e3117a27f Merge pull request #2239 from k-fish/ticket/12350
[ticket/12350] Instantiate Mock Dispatcher for modules_test

* k-fish/ticket/12350:
  [ticket/12350] Instantiate Mock Dispatcher for modules_test
2014-04-03 22:20:37 +02:00
K Fisher
a5216e1b04 [ticket/12350] Instantiate Mock Dispatcher for modules_test
PHPBB3-12350
2014-04-03 16:17:10 -04:00
Matt Friedman
0c25c60381 [ticket/12342] Remove spinner and fix useage of ajax on memberlist
PHPBB3-12342
2014-04-03 08:32:46 -07:00
Marc Alexander
519adb5060 [ticket/10851] Set disallowed content to empty array if checking is disabled
The disallowed content defaults to a standard set of mimetype triggers by
default. If one doesn't want to check the attachments mimetype triggers then
we need to set the disallowed content to an empty array.

PHPBB3-10851
2014-04-03 16:06:46 +02:00
Joas Schilling
d88929210a Merge remote-tracking branch 'vsephpbb/ticket/12337' into develop-ascraeus
* vsephpbb/ticket/12337:
  [ticket/12337] Fix jQuery update migration file
  [ticket/12337] Update jQuery to version 1.11.0
2014-04-03 16:02:57 +02:00
Joas Schilling
e39c4f0d20 [ticket/12349] Fix Sniffer for @license tag
PHPBB3-12349
2014-04-03 15:45:59 +02:00
Joas Schilling
0a586258a2 [ticket/12349] Update license header in several new files
PHPBB3-12349
2014-04-03 15:42:36 +02:00
Joas Schilling
0dbbf7fbbe Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
2014-04-03 15:21:11 +02:00
Joas Schilling
8a277e6e59 Merge remote-tracking branch 'Elsensee/ticket/12341-ascraeus' into develop-ascraeus
* Elsensee/ticket/12341-ascraeus:
  [ticket/12341] Update test with new class name and dependencies
  [ticket/12341] Add tests for get_username_string()
2014-04-03 15:21:02 +02:00
Joas Schilling
801a1f9ab9 Merge remote-tracking branch 'Elsensee/ticket/12341' into develop-olympus
* Elsensee/ticket/12341:
  [ticket/12341] Add tests for get_username_string()
2014-04-03 15:20:30 +02:00
Joas Schilling
b567c0a9e2 Merge remote-tracking branch 'vsephpbb/ticket/12043' into develop-ascraeus
* vsephpbb/ticket/12043:
  [ticket/12043] Fix order of disabled extensions in unit tests
  [ticket/12043] Correct try/catch exceptions for invalid extensions
  [ticket/12043] Sort Extensions by Display Name in ACP Extension mananger
2014-04-03 15:06:28 +02:00
Joas Schilling
049872644a [ticket/12348] Allow to run create_schema_files when phpBB is not installed
PHPBB3-12348
2014-04-03 14:44:07 +02:00
Marc Alexander
808c5277a9 [ticket/12150] Remove 'after' for columns from migrations file
PHPBB3-12150
2014-04-03 11:07:58 +02:00
Oliver Schramm
2b6145da0a [ticket/12341] Update test with new class name and dependencies
PHPBB3-12341
2014-04-02 21:01:09 +02:00
Oliver Schramm
b64fcf4e53 Merge branch 'ticket/12341' into ticket/12341-ascraeus 2014-04-02 20:15:17 +02:00
Matt Friedman
6de0350836 [ticket/12342] Fix the Custom Dates function in UCP Prefs Global
Function was being called before dE() function exists,
causing it to fail. Should be called when the page/window
is ready.

PHPBB3-12342
2014-04-01 18:02:27 -07:00
Matt Friedman
18645aa069 [ticket/12342] Fix Find a member show / hide script
PHPBB3-12342
2014-04-01 18:00:17 -07:00
Matt Friedman
0f3e6ca676 [ticket/12342] Use prop() instead of attr() for boolean properties
PHPBB3-12342
2014-04-01 17:58:56 -07:00
Joas Schilling
b6128dee3f [ticket/8700] Use L_COLON instead of adding ":" manually
PHPBB3-8700
2014-04-02 00:23:26 +02:00
Joas Schilling
bdc08a3fcd [ticket/8700] Remove unused language strings
Most of the strings were obsoleted by the removal of:
* Imagesets
* Themes
* Templates
* Editor
* Exporter

PHPBB3-8700
2014-04-02 00:17:39 +02:00
Oliver Schramm
31e1d7be8d [ticket/12341] Add tests for get_username_string()
PHPBB3-12341
2014-04-01 23:53:04 +02:00
Zoddo
c82c6f8d8c [ticket/12275] Fix a bug on the event "core.modify_username_string"
Call the event "core.modify_username_string"
also if $mode is "colour", "username" or "profile".

PHPBB3-12275
2014-04-01 23:19:04 +02:00
Joas Schilling
2fcfca7369 [ticket/12113] Fix view_log() tests
PHPBB3-12113
2014-04-01 23:10:29 +02:00
Joas Schilling
f471831916 [ticket/12113] Correctly use plurals when deleting user warnings
PHPBB3-12113
2014-04-01 22:43:30 +02:00
Joas Schilling
668f248c4d [ticket/12113] Allow log entries to use plurals
PHPBB3-12113
2014-04-01 22:43:07 +02:00
Oliver Schramm
908057301c [ticket/7707] Add comma to last entry of arrays
PHPBB3-7707
2014-04-01 22:03:59 +02:00
Joas Schilling
45e6dd23e9 [ticket/12331] Add functional test for saving custom profile fields
PHPBB3-12331
2014-04-01 21:36:11 +02:00
Joas Schilling
3656fa3026 [ticket/12282] Update new references
PHPBB3-12282
2014-04-01 19:19:52 +02:00
Joas Schilling
fd462bfd15 [ticket/12282] Update container db mock
PHPBB3-12282
2014-04-01 19:17:42 +02:00
Joas Schilling
94a0331603 [ticket/12282] Add new line at EOF of the interface
PHPBB3-12282
2014-04-01 19:17:41 +02:00
Joas Schilling
11a9104b8a [ticket/12282] Use interface for type hinting
PHPBB3-12282
2014-04-01 19:17:41 +02:00
Joas Schilling
1f28451d58 [ticket/12282] Use {@inheritDoc} for inherited methods
PHPBB3-12282
2014-04-01 19:17:40 +02:00
Joas Schilling
7b131119e6 [ticket/12282] Add Interface for DBAL drivers
PHPBB3-12282
2014-04-01 19:17:39 +02:00
Matt Friedman
025779ac62 [ticket/12337] Fix jQuery update migration file
PHPBB3-12337
2014-04-01 06:50:00 -07:00
Joas Schilling
5a3d4109bb Merge remote-tracking branch 'paybas/ticket/12329' into develop-ascraeus
* paybas/ticket/12329:
  [ticket/12329] changed all CSS classes to ".stat-block"
  [ticket/12329] Add <div> container to index blocks (stats, etc.)
2014-04-01 15:07:19 +02:00
Joas Schilling
00a3eabc59 Merge remote-tracking branch 'paybas/ticket/12328' into develop-ascraeus
* paybas/ticket/12328:
  [ticket/12328] Change "since" to B3
  [ticket/12328] Add Template Event index_body_stat_blocks_after
2014-04-01 14:45:36 +02:00
Joas Schilling
e9eb456f1a Merge remote-tracking branch 'paybas/ticket/12322' into develop-ascraeus
* paybas/ticket/12322:
  [ticket/12322] Added profile-custom-field class
  [ticket/12322] CSS classes for postprofile-profile <dd> items
2014-04-01 14:37:13 +02:00
PayBas
205e098b38 [ticket/12339] Add Event core.page_header_after
PHPBB3-12339
2014-04-01 14:25:40 +02:00
PayBas
e0f64b7058 [ticket/12329] changed all CSS classes to ".stat-block"
PHPBB3-12329
2014-04-01 12:53:13 +02:00
PayBas
6dac8813d0 [ticket/12322] Added profile-custom-field class
PHPBB3-12322
2014-04-01 10:58:44 +02:00
PayBas
d561e6ddaa [ticket/12333] Change event name
PHPBB3-12333
2014-04-01 10:55:13 +02:00
PayBas
a87e576d1e [ticket/12328] Change "since" to B3
PHPBB3-12328
2014-04-01 10:32:01 +02:00
Matt Friedman
2b77dcfca6 [ticket/12337] Update jQuery to version 1.11.0
PHPBB3-12337
2014-03-31 21:09:47 -07:00
Joas Schilling
7fb65f20da Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12318] Use MySQL instead of MySQLi for now on HHVM.
  [ticket/12318] Pin HHVM version to 3.0.0~precise.
  [ticket/12318] Always install new config file on HHVM upgrade conflict.
  [ticket/12318] Add PPA providing dependencies for recent HHVM on Ubuntu 12.04.
  [ticket/12318] Upgrade to a recent stable version of HHVM.
  [ticket/12318] Correctly setup HHVM for functional tests.
2014-03-31 20:58:03 +02:00
Joas Schilling
c2fbaf3af2 Merge remote-tracking branch 'bantu/ticket/12318-olympus' into develop-olympus
* bantu/ticket/12318-olympus:
  [ticket/12318] Use MySQL instead of MySQLi for now on HHVM.
  [ticket/12318] Pin HHVM version to 3.0.0~precise.
  [ticket/12318] Always install new config file on HHVM upgrade conflict.
  [ticket/12318] Add PPA providing dependencies for recent HHVM on Ubuntu 12.04.
  [ticket/12318] Upgrade to a recent stable version of HHVM.
  [ticket/12318] Correctly setup HHVM for functional tests.
2014-03-31 20:53:55 +02:00
Joas Schilling
ba84268d4e Merge remote-tracking branch 'crizz0/ticket/9758' into develop-ascraeus
* crizz0/ticket/9758:
  [ticket/9758] Clickable avatar in header and renamed class for avatar-img
  [ticket/9758] Remove unnessary if-question for include functions_display
  [ticket/9758] Slims the line 4775 in includes/functions.php
  [ticket/9758] Adds id and changes filter to fix travis CI test
  [ticket/9758] Removed the needless space after first ENDIF
  [ticket/9758] Adding impr. for overall_header display of avatar and username
  [ticket/9758] Fixed bug in mcp_warn.php
  [ticket/9758] Optimises the html code of avatar image in header
  [ticket/9758] Error because of missing functions_display.php fixed
  [ticket/9758] Removed useless if-conditions to include functions.php
  [ticket/9758] Changes class name of new "span" in overall_header.html
  [ticket/9758] Adds global template variable CURRENT_USER_AVATAR
2014-03-31 20:29:45 +02:00
PayBas
f8b5b71890 [ticket/12333] Add Template Event overall_header_body_after
PHPBB3-12333
2014-03-31 12:27:19 +02:00
Matt Friedman
8ee37def81 [ticket/11962] Resize posted images to fit and give them a class
PHPBB3-11962
2014-03-30 14:19:16 -07:00
Joas Schilling
a618710a69 Merge branch 'prep-release-3.1.0-b2' into develop-ascraeus
* prep-release-3.1.0-b2:
  [prep-release-3.1.0-b2] Prepare development of 3.1.0-b3
  [prep-release-3.1.0-b2] Add changelog for 3.1.0-b2
  [prep-release-3.1.0-b2] Prepare Changelog
  [prep-release-3.1.0-b2] Add migration for 3.1.0-b2
  [prep-release-3.1.0-b2] Update version to 3.1.0-b2
2014-03-30 23:01:27 +02:00
Joas Schilling
45f2efea19 [prep-release-3.1.0-b2] Prepare development of 3.1.0-b3 2014-03-30 22:53:09 +02:00
Joas Schilling
120aa3685f [prep-release-3.1.0-b2] Add changelog for 3.1.0-b2 2014-03-30 22:14:54 +02:00
Joas Schilling
d81c5437d1 [prep-release-3.1.0-b2] Prepare Changelog 2014-03-30 22:08:12 +02:00
Joas Schilling
fdbe5e2f42 [prep-release-3.1.0-b2] Add migration for 3.1.0-b2 2014-03-30 22:08:11 +02:00
Joas Schilling
254b7739a8 [prep-release-3.1.0-b2] Update version to 3.1.0-b2 2014-03-30 22:08:10 +02:00
David King
acb4d90371 Merge remote-tracking branch 'nickvergessen/ticket/12326' into develop-ascraeus
* nickvergessen/ticket/12326:
  [ticket/12326] Correctly format update/index.php and remove php closing tag
  [ticket/12326] Do not add deleted files to the list of changed files
2014-03-30 16:03:11 -04:00
Joas Schilling
1a6dc6e767 Merge remote-tracking branch 'Elsensee/ticket/12330' into develop-ascraeus
* Elsensee/ticket/12330:
  [ticket/12330] Fix create index in db tools on mssql
2014-03-30 19:24:11 +02:00
Crizzo
fa6c1044b8 [ticket/9758] Clickable avatar in header and renamed class for avatar-img
PHPBB3-9758
2014-03-30 19:13:14 +02:00
Joas Schilling
86c4d24a8a [ticket/12331] Fix SQL error when inserting a new entry to profile field data
There was a "Field 'pf_phpbb_interests' doesn't have a default value" error,
because we didn't specify values for the disabled fields.
We can not disable the sql_return_on_error() thou, because it otherwise we run
into "Duplicate entry '2' for key 'PRIMARY'" errors when the user submits the
form again but didn't change any values.

PHPBB3-12331
2014-03-30 15:59:51 +02:00
Andreas Fischer
297729aa32 [ticket/12318] Use MySQL instead of MySQLi for now on HHVM.
PHPBB3-12318
2014-03-30 15:43:55 +02:00
Andreas Fischer
e1be4943d8 [ticket/12318] Pin HHVM version to 3.0.0~precise.
PHPBB3-12318
2014-03-30 15:43:55 +02:00
Andreas Fischer
d53c411d90 [ticket/12318] Always install new config file on HHVM upgrade conflict.
PHPBB3-12318
2014-03-30 15:43:54 +02:00
Andreas Fischer
a53312636a [ticket/12318] Add PPA providing dependencies for recent HHVM on Ubuntu 12.04.
PHPBB3-12318
2014-03-30 15:43:54 +02:00
Andreas Fischer
672eab3a9c [ticket/12318] Upgrade to a recent stable version of HHVM.
PHPBB3-12318
2014-03-30 15:43:54 +02:00
Andreas Fischer
04707cbf8d [ticket/12318] Correctly setup HHVM for functional tests.
PHPBB3-12318
2014-03-30 15:43:54 +02:00
Oliver Schramm
55c1b49bed [ticket/12330] Fix create index in db tools on mssql
PHPBB3-12330
2014-03-30 15:42:04 +02:00
Andreas Fischer
570aab34f5 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12316] Add Build Status Icon for develop-ascraeus to README.md
2014-03-30 15:40:42 +02:00
Andreas Fischer
dc3cb2205b Merge remote-tracking branch 'VSEphpbb/ticket/12316' into develop-olympus
* VSEphpbb/ticket/12316:
  [ticket/12316] Add Build Status Icon for develop-ascraeus to README.md
2014-03-30 15:40:30 +02:00
Andreas Fischer
4346fbee4d Merge pull request #2198 from n-aleha/ticket/12321
[ticket/12321] Remove execute bit from ucp_main_subscribed.html and buttons.png

* n-aleha/ticket/12321:
  [ticket/12321] Remove execute bit from ucp_main_subscribed.html and buttons.png
2014-03-30 15:37:16 +02:00
Joas Schilling
badb16e68e [ticket/12326] Correctly format update/index.php and remove php closing tag
PHPBB3-12326
2014-03-30 15:09:35 +02:00
Joas Schilling
b8cb407da9 [ticket/12326] Do not add deleted files to the list of changed files
PHPBB3-12326
2014-03-30 14:57:12 +02:00
n-aleha
eefc652220 [ticket/12321] Remove execute bit from ucp_main_subscribed.html and buttons.png
PHPBB3-12321
2014-03-30 14:29:56 +03:00
Joas Schilling
3e909711d2 Merge remote-tracking branch 'Elsensee/ticket/12324' into develop-ascraeus
* Elsensee/ticket/12324:
  [ticket/12324] Correctly create di container if config/ is missing from update/
2014-03-30 13:22:44 +02:00
Marc Alexander
1812d3ce99 [ticket/12150] Update schema files for prune shadow topics
PHPBB3-12150
2014-03-30 13:06:18 +02:00
PayBas
39398dec1b [ticket/12329] Add <div> container to index blocks (stats, etc.)
PHPBB3-12329
2014-03-30 12:58:30 +02:00
Marc Alexander
a7c037520b Merge branch 'develop-ascraeus' of https://github.com/phpbb/phpbb into ticket/12150 2014-03-30 12:35:40 +02:00
PayBas
b7c77952a4 [ticket/12328] Add Template Event index_body_stat_blocks_after
PHPBB3-12328
2014-03-30 12:07:44 +02:00
Matt Friedman
a6b988c844 [ticket/12316] Add Build Status Icon for develop-ascraeus to README.md
PHPBB3-12316
2014-03-30 00:07:08 -07:00
Oliver Schramm
df5761b370 [ticket/12324] Correctly create di container if config/ is missing from update/
PHPBB3-12324
2014-03-29 23:02:37 +01:00
Marc Alexander
494dd4110b [ticket/12150] Use log service instead of add_log() function
PHPBB3-12150
2014-03-29 22:16:25 +01:00
Marc Alexander
d83d819827 [ticket/12150] Use shorter column names for prune settings
All columns were renamed from having prune_shadow_topics as namebase to just
prune_shadow.
A missing column was also added to the migration file's remove_schema() method.

PHPBB3-12150
2014-03-29 22:14:58 +01:00
Marc Alexander
5866f08919 [ticket/12150] Add functional tests for pruning shadow topics
PHPBB3-12150
2014-03-29 21:57:19 +01:00
Marc Alexander
76b7355b87 [ticket/12150] Add missing space to query for shadow topics
PHPBB3-12150
2014-03-29 21:57:09 +01:00
Marc Alexander
d97c58aeea [ticket/12150] Add missing prune settings variables in acp_forums
PHPBB3-12150
2014-03-29 21:57:00 +01:00
Marc Alexander
02fdae4e88 [ticket/12150] Add file and caller for pruning shadow topics
PHPBB3-12150
2014-03-29 21:56:53 +01:00
Marc Alexander
a7abf8218d [ticket/12150] Add prune columns to schema files and migration file
PHPBB3-12150
2014-03-29 21:56:14 +01:00
Nils Adermann
8442f2239d Merge remote-tracking branch 'github-nickvergessen/ticket/11459' into develop-ascraeus
* github-nickvergessen/ticket/11459:
  [ticket/11459] 3.0.1-RC1 should depend on 3.0.0 migration
2014-03-29 16:53:09 -04:00
Marc Alexander
3c7ff1c417 [ticket/12150] Add options to acp
PHPBB3-12150
2014-03-29 21:49:31 +01:00
Joas Schilling
1497cb0b3c [ticket/11459] 3.0.1-RC1 should depend on 3.0.0 migration
PHPBB3-11459
2014-03-29 21:48:23 +01:00
Matt Friedman
c674de6a32 [ticket/12043] Fix order of disabled extensions in unit tests
PHPBB3-12043
2014-03-29 13:35:08 -07:00
Nils Adermann
308e8b0c96 Merge remote-tracking branch 'github-nickvergessen/ticket/11459' into develop-ascraeus
* github-nickvergessen/ticket/11459: (21 commits)
  [ticket/11459] Make 3.1.0-dev migration depend on migrations_table
  [ticket/11459] Move $supported_dbms to beginning of create schema file
  [ticket/11459] Fix missing constant CONFIG_TABLE for sql_create_index()
  [ticket/11459] Fix auth provider test
  [ticket/11459] Correctly set up the database from schema in unit tests
  [ticket/11459] Install DB schema from json file
  [ticket/11459] Clean up a little more
  [ticket/11459] Do not add table schema to database schema files
  [ticket/11459] Create schema.json from migration files
  [ticket/11459] Do not take files of extensions into account
  [ticket/11459] Pass array with migration class names to schema generator
  [ticket/11459] Refresh schema files
  [ticket/11459] Remove spaces from the end of lines in MSSQL
  [ticket/11459] Correctly handle index column length
  [ticket/11459] Add migration for migrations table
  [ticket/11459] Update doc blocks
  [ticket/11459] Remove old schema file
  [ticket/11459] Update schema files with new script
  [ticket/11459] Use new migration/schema_generator to create schema files
  [ticket/11459] Add Schema from 3.0.0
  ...
2014-03-29 16:29:33 -04:00
Joas Schilling
8824a53b0a [ticket/11459] Make 3.1.0-dev migration depend on migrations_table
PHPBB3-11459
2014-03-29 21:16:23 +01:00
Joas Schilling
f426fa0295 Merge remote-tracking branch 'prototech/ticket/11959' into develop-ascraeus
* prototech/ticket/11959:
  [ticket/11959] Move phpbb_generate_string_list() to functions_content.php.
  [ticket/11959] Add unit tests.
  [ticket/11959] Remove use of plurals and make it possible to use Oxford comma.
  [ticket/11959] Rename phpbb_gen_string_list() & fix incorrect var name.
  [ticket/11959] Simplify how the users are trimmed.
  [ticket/11959] Add function to create a string list.
  [ticket/11959] Add samples for the untrimmed strings.
  [ticket/11959] List the last user with "and" instead of a comma.
  [ticket/11959] Use the plurals system for the untrimmed language strings.
  [ticket/11959] Fix the NOTIFICATION_QUOTE_TRIMMED text.
  [ticket/11959] Use plurals for the language strings.
2014-03-29 20:39:22 +01:00
PayBas
1b922f2c64 [ticket/12322] CSS classes for postprofile-profile <dd> items
There is no subsilver2 equivalent for this commit

PHPBB3-12322
2014-03-29 19:15:17 +01:00
Matt Friedman
2024c5adc2 [ticket/12043] Correct try/catch exceptions for invalid extensions
PHPBB3-12043
2014-03-29 11:09:27 -07:00
Matt Friedman
bf2aca6f8b [ticket/12043] Sort Extensions by Display Name in ACP Extension mananger
PHPBB3-12043
2014-03-29 10:47:09 -07:00
Joas Schilling
3e281790e3 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12319] Backport Travis CI HHVM environment to develop-olympus.
2014-03-29 17:50:07 +01:00
Joas Schilling
1663a0a5fe Merge remote-tracking branch 'bantu/ticket/12319' into develop-olympus
* bantu/ticket/12319:
  [ticket/12319] Backport Travis CI HHVM environment to develop-olympus.
2014-03-29 17:49:51 +01:00
Joas Schilling
01697ab2f5 Merge remote-tracking branch 'prosk8er/ticket/12298' into develop-ascraeus
* prosk8er/ticket/12298:
  [ticket/12298] Template Event memberlist_view_contact_before/after
2014-03-29 17:43:03 +01:00
Cesar G
b893dae105 [ticket/11959] Move phpbb_generate_string_list() to functions_content.php.
PHPBB3-11959
2014-03-29 09:32:04 -07:00
Prosk8er
255fab038d [ticket/12298] Template Event memberlist_view_contact_before/after
add template event memberlist_view_contact_before
and memberlist_view_contact_after

PHPBB3-12298
2014-03-29 12:13:17 -04:00
Joas Schilling
f879714d35 Merge remote-tracking branch 'prosk8er/ticket/12301' into develop-ascraeus
* prosk8er/ticket/12301:
  [ticket/12301] Template Event overall_header_body_before
2014-03-29 16:42:10 +01:00
Oliver Schramm
825077073b [ticket/7707] Remove unnecessary variables
PHPBB3-7707
2014-03-29 16:38:24 +01:00
Oliver Schramm
0edfcc5a28 [ticket/7707] Add get_username_string() once more
PHPBB3-7707
2014-03-29 15:43:49 +01:00
Prosk8er
fb25917fa9 [ticket/12301] Template Event overall_header_body_before
add template event overall_header_body_before

PHPBB3-12301
2014-03-29 09:57:11 -04:00
Joas Schilling
3ac8b8b40d Merge branch 'ticket/paybas/12308' into develop-ascraeus
* ticket/paybas/12308:
  [ticket/12308] Template Event forumlist_body_last_row_after
2014-03-29 12:50:40 +01:00
PayBas
e8b43a1bb8 [ticket/12308] Template Event forumlist_body_last_row_after
PHPBB3-12308
2014-03-29 12:50:23 +01:00
Joas Schilling
1e0af0d252 Merge remote-tracking branch 'paybas/ticket/12304' into develop-ascraeus
* paybas/ticket/12304:
  [ticket/12304] Add CSS class to rules-link container
2014-03-29 12:36:05 +01:00
Joas Schilling
f3e9fe6de8 Merge branch 'ticket/paybas/12309' into develop-ascraeus
* ticket/paybas/12309:
  [ticket/12309] Template Event quickreply_editor_panel_before/after
2014-03-29 12:17:37 +01:00
PayBas
0d84a42cd4 [ticket/12309] Template Event quickreply_editor_panel_before/after
PHPBB3-12309
2014-03-29 12:17:11 +01:00
Joas Schilling
7f6aff1d09 Merge branch 'ticket/lucifer4o/12276' into develop-ascraeus
* ticket/lucifer4o/12276:
  [ticket/12276] Expand core.memberlist_view_profile
  [ticket/12276] Expand core.memberlist_view_profile
2014-03-29 12:10:02 +01:00
lucifer4o
2e7f66b16c [ticket/12276] Expand core.memberlist_view_profile
Expand core.memberlist_view_profile to include zebra states

PHPBB3-12276
2014-03-29 12:09:42 +01:00
Andreas Fischer
f7f18a3c66 [ticket/12319] Backport Travis CI HHVM environment to develop-olympus.
PHPBB3-12319
2014-03-29 12:08:52 +01:00
PayBas
7a5639816a [ticket/12304] Add CSS class to rules-link container
When a forum has a forum-rules link instead of forum-rules text, there
is no way to distinguish in the styling of the container (or the button)
it will have.

It should be possible to style the <div class="rules"> container
differently if there is only a link (no text).

PHPBB3-12304
2014-03-29 11:20:03 +01:00
Joas Schilling
fd16a50baf Merge remote-tracking branch 'vsephpbb/ticket/12300' into develop-ascraeus
* vsephpbb/ticket/12300:
  [ticket/12300] Make only red topic/forum row icons clickable to unread posts
  [ticket/12300] Fix broken link to last post in topic subscriptions list
  [ticket/12300] Fix alignment of clickable icons
  [ticket/12300] Make all topic row icons clickable
  [ticket/12300] Rename new class for row icon links
  [ticket/12300] Make topic icon links clickable to newest unread posts
  [ticket/12300] Revert topic title links back to default behavior
2014-03-29 11:09:33 +01:00
Joas Schilling
47825a78ef [ticket/11459] Move $supported_dbms to beginning of create schema file
PHPBB3-11459
2014-03-29 11:03:45 +01:00
Joas Schilling
f30b9dbfba [ticket/11459] Fix missing constant CONFIG_TABLE for sql_create_index()
PHPBB3-11459
2014-03-29 11:03:44 +01:00
Joas Schilling
959e9beedc [ticket/11459] Fix auth provider test
user_timezone has no default value anymore

PHPBB3-11459
2014-03-29 11:03:44 +01:00
Joas Schilling
ba139297b5 [ticket/11459] Correctly set up the database from schema in unit tests
PHPBB3-11459
2014-03-29 11:03:43 +01:00
Joas Schilling
67737345f6 [ticket/11459] Install DB schema from json file
PHPBB3-11459
2014-03-29 11:03:42 +01:00
Joas Schilling
fd434a2f78 [ticket/11459] Clean up a little more
PHPBB3-11459
2014-03-29 11:03:42 +01:00
Joas Schilling
a63b229bec [ticket/11459] Do not add table schema to database schema files
PHPBB3-11459
2014-03-29 11:03:40 +01:00
Joas Schilling
b87f18bbc0 [ticket/11459] Create schema.json from migration files
PHPBB3-11459
2014-03-29 11:01:06 +01:00
Joas Schilling
81f7240583 [ticket/11459] Do not take files of extensions into account
PHPBB3-11459
2014-03-29 11:01:05 +01:00
Joas Schilling
b0aa366b12 [ticket/11459] Pass array with migration class names to schema generator
PHPBB3-11459
2014-03-29 11:01:04 +01:00
Joas Schilling
ac6f0c94bf [ticket/11459] Refresh schema files
PHPBB3-11459
2014-03-29 11:00:19 +01:00
Joas Schilling
0fd0be8e85 [ticket/11459] Remove spaces from the end of lines in MSSQL
PHPBB3-11459
2014-03-29 10:59:29 +01:00
Joas Schilling
b3560264e8 [ticket/11459] Correctly handle index column length
Code is copied from db\tools::sql_create_index()

PHPBB3-11459
2014-03-29 10:58:17 +01:00
Joas Schilling
18e70d4380 [ticket/11459] Add migration for migrations table
This migration will always be skipped on updates, because database_update.php
creates the table. But the create schema script requires the migration,
so the table is created for new installs.

PHPBB3-11459
2014-03-29 10:58:16 +01:00
Joas Schilling
3153ec20d8 [ticket/11459] Update doc blocks
PHPBB3-11459
2014-03-29 10:58:16 +01:00
Joas Schilling
5e8341c395 [ticket/11459] Remove old schema file
PHPBB3-11459
2014-03-29 10:58:15 +01:00
Joas Schilling
a20d2faa56 [ticket/11459] Update schema files with new script
The order of some tables and columns was changed

PHPBB3-11459
2014-03-29 10:58:14 +01:00
Joas Schilling
9d56e60c66 [ticket/11459] Use new migration/schema_generator to create schema files
PHPBB3-11459
2014-03-29 10:54:06 +01:00
Joas Schilling
3467700670 [ticket/11459] Add Schema from 3.0.0
PHPBB3-11459
2014-03-29 10:52:57 +01:00
Joas Schilling
3898caca7d [ticket/11459] Add a migration/schema_generator
It loops over the migrations and creates the schema from it.

PHPBB3-11459
2014-03-29 10:52:57 +01:00
Joas Schilling
70a2110223 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/9725] Code sniffer fixes
  [ticket/9725] Do not use deprecated views to remove default constraints
  [ticket/9725] Move primary key creation to the correct location
  [ticket/9725] Remove trailing spaces from MSSQL schema
  [ticket/9725] Create MSSQL primary keys if none exist
  [ticket/9725] Remove explicit filegroup designations
  [ticket/9725] Fetch Azure db stats from proper table
  [ticket/9725] Add dummy indexes for Azure
  [ticket/9725] Create an Azure SQL compatible Schema

Conflicts:
	phpBB/install/schemas/mssql_schema.sql
2014-03-29 10:50:18 +01:00
Joas Schilling
4e8aef7cd6 Merge remote-tracking branch 'noxwizard/ticket/naderman/9725' into develop-olympus
* noxwizard/ticket/naderman/9725:
  [ticket/9725] Code sniffer fixes
  [ticket/9725] Do not use deprecated views to remove default constraints
  [ticket/9725] Move primary key creation to the correct location
  [ticket/9725] Remove trailing spaces from MSSQL schema
  [ticket/9725] Create MSSQL primary keys if none exist
  [ticket/9725] Remove explicit filegroup designations
  [ticket/9725] Fetch Azure db stats from proper table
  [ticket/9725] Add dummy indexes for Azure
  [ticket/9725] Create an Azure SQL compatible Schema
2014-03-29 10:43:09 +01:00
Matt Friedman
96ac2790fc [ticket/12300] Make only red topic/forum row icons clickable to unread posts
PHPBB3-12300
2014-03-28 20:54:49 -07:00
Nils Adermann
b7909ba71b Merge pull request #2192 from bantu/ticket/12314
[ticket/12314] Workaround HHVM SPL autoloader sometimes using leading ba...
2014-03-28 22:25:48 -04:00
Nils Adermann
6d0b7bba3f Merge pull request #2194 from bantu/ticket/12317
[ticket/12317] Fix notification tests for DBMS drivers using int for integers ;-)
2014-03-28 22:24:57 -04:00
Joas Schilling
c7d18eaadd Merge remote-tracking branch 'crizz0/ticket/11336' into develop-ascraeus
* crizz0/ticket/11336:
  [ticket/11336] Adds 301 info to redirect
  [ticket/11336] Adds redirect for old "leaders" mode
  [ticket/11336] Changes language variabel LOGIN_EXPLAIN_LEADERS to _TEAM
  [ticket/11336] Changes "leaders"-mode to "team"-mode and so in test-file
2014-03-28 23:32:05 +01:00
Patrick Webster
79492d4110 [ticket/9725] Code sniffer fixes
PHPBB3-9725
2014-03-28 17:07:50 -05:00
Patrick Webster
aaa846cb3a [ticket/9725] Do not use deprecated views to remove default constraints
PHPBB3-9725
2014-03-28 17:05:37 -05:00
Patrick Webster
31e610f0b1 [ticket/9725] Move primary key creation to the correct location
PHPBB3-9725
2014-03-28 17:05:25 -05:00
Patrick Webster
a2580687ee [ticket/9725] Remove trailing spaces from MSSQL schema
PHPBB3-9725
2014-03-28 17:05:13 -05:00
Patrick Webster
83be990701 [ticket/9725] Create MSSQL primary keys if none exist
PHPBB3-9725
2014-03-28 17:04:56 -05:00
Patrick Webster
68ae8dfa97 [ticket/9725] Remove explicit filegroup designations
PHPBB3-9725
2014-03-28 17:04:41 -05:00
Patrick Webster
80a844d38c [ticket/9725] Fetch Azure db stats from proper table
PHPBB3-9725
2014-03-28 17:04:29 -05:00
Oliver Schramm
02378e94e7 [ticket/10423] Remove * from search or highlight string
PHPBB3-10423
2014-03-28 22:28:14 +01:00
Andreas Fischer
ad2ed01623 [ticket/12317] Cast string to int to refix DBMSes not using int for integers.
PHPBB3-12317
2014-03-28 22:14:53 +01:00
Andreas Fischer
c489244895 [ticket/12317] Fix notification tests for DBMSes returning integers as int.
PHPBB3-12317
2014-03-28 22:14:53 +01:00
Andreas Fischer
043b6a207a [ticket/12317] Do not repeat SQL query in notification_submit_post_base.
PHPBB3-12317
2014-03-28 22:14:53 +01:00
Andreas Fischer
bd0ba37207 [ticket/12314] Workaround HHVM SPL autoloader sometimes using leading backslash
PHPBB3-12314
2014-03-28 21:47:23 +01:00
Crizzo
28f17897b4 [ticket/11336] Adds 301 info to redirect
PHPBB3-11336
2014-03-28 19:36:12 +01:00
Crizzo
38d2efe829 [ticket/11336] Adds redirect for old "leaders" mode
PHPBB3-11336
2014-03-28 19:36:10 +01:00
Crizzo
c5eccedfb6 [ticket/11336] Changes language variabel LOGIN_EXPLAIN_LEADERS to _TEAM
PHPBB3-11336
2014-03-28 19:36:09 +01:00
Crizzo
76558fbce5 [ticket/11336] Changes "leaders"-mode to "team"-mode and so in test-file
PHPBB3-11336
2014-03-28 19:36:08 +01:00
Joas Schilling
e742d1ec26 Merge remote-tracking branch 'vsephpbb/ticket/12315' into develop-ascraeus
* vsephpbb/ticket/12315:
  [ticket/12315] Fix invalid HTML in NO_SEARCH_INDEX in language/en/acp/common.php
2014-03-28 19:31:36 +01:00
Matt Friedman
e2c2692e9c [ticket/12315] Fix invalid HTML in NO_SEARCH_INDEX in language/en/acp/common.php
PHPBB3-12315
2014-03-28 11:27:25 -07:00
Crizzo
cde4070b19 [ticket/9758] Remove unnessary if-question for include functions_display
PHPBB3-9758
2014-03-28 19:26:56 +01:00
Crizzo
4f2a512052 [ticket/9758] Slims the line 4775 in includes/functions.php
PHPBB3-9758
2014-03-28 19:26:53 +01:00
Crizzo
9568181b98 [ticket/9758] Adds id and changes filter to fix travis CI test
PHPBB3-9758
2014-03-28 19:26:28 +01:00
Crizzo
d48d47c916 [ticket/9758] Removed the needless space after first ENDIF
PHPBB3-9758
2014-03-28 19:12:37 +01:00
Crizzo
175d83146e [ticket/9758] Adding impr. for overall_header display of avatar and username
PHPBB3-9758
2014-03-28 19:12:36 +01:00
Crizzo
aa6077c150 [ticket/9758] Fixed bug in mcp_warn.php
PHPBB3-9758
2014-03-28 19:12:35 +01:00
Crizzo
ce1b4da59e [ticket/9758] Optimises the html code of avatar image in header
PHPBB3-9758
2014-03-28 19:12:34 +01:00
Crizzo
9d568986ad [ticket/9758] Error because of missing functions_display.php fixed
PHPBB3-9758
2014-03-28 19:12:32 +01:00
Crizzo
0d4968f735 [ticket/9758] Removed useless if-conditions to include functions.php
PHPBB3-9758
2014-03-28 19:12:31 +01:00
Crizzo
e149c266ce [ticket/9758] Changes class name of new "span" in overall_header.html
PHPBB3-9758
2014-03-28 19:12:29 +01:00
Crizzo
ddbdde53ab [ticket/9758] Adds global template variable CURRENT_USER_AVATAR
PHPBB3-9758
2014-03-28 19:12:28 +01:00
Joas Schilling
0be6582d7f Merge branch 'ticket/suheb/11666' into develop-ascraeus
* ticket/suheb/11666:
  [ticket/11666] Rewording POST_DELETED and
  [ticket/11666] Removing MESSAGE_DELETED..
2014-03-28 17:42:34 +01:00
Suhaib Khan
96291d9e6e [ticket/11666] Rewording POST_DELETED and
reverting removal of MESSAGE_DELETED.

PHPBB3-11666
2014-03-28 17:41:42 +01:00
Joas Schilling
ce6e3966cf Merge remote-tracking branch 'vsephpbb/ticket/12311' into develop-ascraeus
* vsephpbb/ticket/12311:
  [ticket/12311] Use British-English spelling of licence in lang file
  [ticket/12311] Use valid composer schema - license - for extensions
2014-03-28 17:29:56 +01:00
Joas Schilling
968da05e51 Merge remote-tracking branch 'vsephpbb/ticket/11230' into develop-ascraeus
* vsephpbb/ticket/11230:
  [ticket/11230] Add missing last returns to dock block
  [ticket/11230] Update cache driver dock blocks
  [ticket/11230] Use inheritdoc in docblocks in cache drivers
2014-03-28 17:27:14 +01:00
Joas Schilling
d2572888f9 [ticket/12286] Reword section about plurals
PHPBB3-12286
2014-03-28 17:24:59 +01:00
Joas Schilling
c985b018a7 [ticket/12286] Fix spelling of elephant(s) in the sample
PHPBB3-12286
2014-03-28 17:19:03 +01:00
Joas Schilling
99dccc2df8 [ticket/12286] Correctly capitalize PHP
PHPBB3-12286
2014-03-28 17:16:56 +01:00
Joas Schilling
f88e9d1c04 [ticket/12286] Fix nesting of ul inside li element
PHPBB3-12286
2014-03-28 17:14:09 +01:00
Matt Friedman
dab35589fe [ticket/11230] Add missing last returns to dock block
PHPBB3-11230
2014-03-28 09:12:42 -07:00
Matt Friedman
368dd23d4b [ticket/12311] Use British-English spelling of licence in lang file
PHPBB3-12311
2014-03-28 09:08:11 -07:00
Joas Schilling
6af942740c Merge remote-tracking branch 'geetakshi/ticket/11360' into develop-ascraeus
* geetakshi/ticket/11360:
  [ticket/11360] Updating default value of $display_online_list
  [ticket/11360] Avoiding online list where not required
  [ticket/11360] Change second parameter in page_header function
2014-03-28 17:07:16 +01:00
Matt Friedman
ba9bc9c7dc [ticket/12311] Use valid composer schema - license - for extensions
http://tracker.phpbb.com/browse/PHPBB3-12311

PHPBB3-12311
2014-03-27 23:27:30 -07:00
Matt Friedman
619e844c1b [ticket/12300] Fix broken link to last post in topic subscriptions list
PHPBB3-12300
2014-03-27 17:32:15 -07:00
Matt Friedman
e1c962894b [ticket/12300] Fix alignment of clickable icons
PHPBB3-12300
2014-03-27 17:31:31 -07:00
Matt Friedman
2bc5fcc7de [ticket/12300] Make all topic row icons clickable
Forum list icons link to first page of forum
UCP subscribed forums icons link to first page of forum
MCP Forum page topic icons link to first (or first unread) post
PM Icons link to the message

PHPBB3-12300
2014-03-27 17:29:50 -07:00
Matt Friedman
c897ac5d70 [ticket/12300] Rename new class for row icon links
PHPBB3-12300
2014-03-27 17:25:37 -07:00
Joas Schilling
c256d7a88d Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
2014-03-27 14:32:43 +01:00
Joas Schilling
252a8d4e9e Merge remote-tracking branch 'bantu/ticket/12257-ascraeus' into develop-ascraeus
* bantu/ticket/12257-ascraeus:
  [ticket/12257] Use MyISAM in PHP 5.3 environment such that FULLTEXT tests run.
2014-03-27 14:32:36 +01:00
Joas Schilling
40ed3f6776 Merge remote-tracking branch 'bantu/ticket/12257' into develop-olympus
* bantu/ticket/12257:
  [ticket/12257] Use MyISAM in PHP 5.3 environment such that FULLTEXT tests run.
2014-03-27 14:31:23 +01:00
Nils Adermann
02c4d4ee7e Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12310] Don't autocomplete SMTP user/pass on install
2014-03-26 23:35:57 -04:00
Nils Adermann
47ab801440 Merge remote-tracking branch 'marshalrusty/ticket/12310' into develop-olympus
* marshalrusty/ticket/12310:
  [ticket/12310] Don't autocomplete SMTP user/pass on install
2014-03-26 23:35:48 -04:00
Yuriy Rusko
dc9ae231e5 [ticket/12310] Don't autocomplete SMTP user/pass on install
PHPBB3-12310
2014-03-26 23:16:39 -04:00
Oliver Schramm
db6e5a19f2 [ticket/7707] Remove unnecessary variables
PHPBB3-7707
2014-03-26 17:13:46 +01:00
Andreas Fischer
5e688f9540 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12302] Added `--no-dev` to composer call in build.xml
  [ticket/12302] Updated composer.phar to 1.0.0-alpha8
2014-03-25 17:32:03 +01:00
Andreas Fischer
0b9752a594 Merge pull request #2183 from s9e/ticket/12302
Upgrade all composer.phar to 1.0.0-alpha8

* s9e/ticket/12302:
  [ticket/12302] Added `--no-dev` to composer call in build.xml
  [ticket/12302] Updated composer.phar to 1.0.0-alpha8
2014-03-25 17:27:15 +01:00
s9e
55e7459922 [ticket/12302] Added --no-dev to composer call in build.xml
PHPBB3-12302
2014-03-25 17:20:59 +01:00
s9e
53740111f6 [ticket/12302] Updated composer.phar to 1.0.0-alpha8
wget -N https://getcomposer.org/download/1.0.0-alpha8/composer.phar

PHPBB3-12302
2014-03-25 17:09:00 +01:00
Andreas Fischer
389bbe32d1 Merge pull request #2179 from bantu/ticket/12257
[ticket/12257] Use MyISAM in PHP 5.3 environment such that FULLTEXT test...

* bantu/ticket/12257:
  [ticket/12257] Use MyISAM in PHP 5.3 environment such that FULLTEXT tests run.

Conflicts:
	.travis.yml
2014-03-25 00:15:09 +01:00
Andreas Fischer
ca8fa03659 [ticket/12257] Use MyISAM in PHP 5.3 environment such that FULLTEXT tests run.
PHPBB3-12257
2014-03-24 21:42:06 +01:00
Joas Schilling
800c779403 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/10174] Rename "Ban usernames" to "Ban users" in ACP
2014-03-24 20:58:43 +01:00
Joas Schilling
574a9f4f2a Merge remote-tracking branch 'schosser/ticket/10174' into develop-olympus
* schosser/ticket/10174:
  [ticket/10174] Rename "Ban usernames" to "Ban users" in ACP
2014-03-24 20:58:11 +01:00
Joas Schilling
ce76a028c8 Merge remote-tracking branch 'Elsensee/ticket/12297' into develop-ascraeus
* Elsensee/ticket/12297:
  [ticket/12297] Delete user_from column on update
2014-03-24 20:46:02 +01:00
Matt Friedman
f6519414b7 [ticket/12300] Make topic icon links clickable to newest unread posts
PHPBB3-12300
2014-03-24 10:42:32 -07:00
Matt Friedman
449e583fc4 [ticket/12300] Revert topic title links back to default behavior
PHPBB3-12300
2014-03-24 09:43:25 -07:00
geetakshi
76f7ef5c83 [ticket/11360] Updating default value of $display_online_list
PHPBB3-11360
2014-03-24 00:12:40 +05:30
Oliver Schramm
ccf400ef0f [ticket/12297] Delete user_from column on update
PHPBB3-12297
2014-03-23 15:53:24 +01:00
Daniel Schosser
a46ad06c19 [ticket/10174] Rename "Ban usernames" to "Ban users" in ACP
Changing the language string from "Ban usernames" to "Ban users"
to clarify its use. It bans users by their name and not the username itself

PHPBB3-10174
2014-03-23 14:06:32 +01:00
Cesar G
2e6911b7e7 Merge remote-tracking branch 'VSEphpbb/ticket/12292' into develop-ascraeus
* VSEphpbb/ticket/12292:
  [ticket/12292] Fix syntax error in admin.css
2014-03-22 20:50:21 -07:00
Matt Friedman
b6b32c2340 [ticket/12292] Fix syntax error in admin.css
PHPBB3-12292
2014-03-22 19:49:03 -07:00
Dhruv
dfa1377f1b Merge remote-tracking branch 'nickvergessen/ticket/12268' into develop-ascraeus
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/ticket/12268:
  [ticket/12268] Do not use substr but just compare the character
  [ticket/12268] Rename class file to recursive_dot_prefix_filter_iterator.php
  [ticket/12268] Move class out of extension namespace and rename it
  [ticket/12268] Do not search in folders starting with a dot
  [ticket/12268] Use FilesystemIterator::SKIP_DOTS
  [ticket/12268] Extension finder should not crawl through .git/ of extensions
2014-03-23 02:39:00 +05:30
Joas Schilling
84b91beed1 Merge remote-tracking branch 'rxu/ticket/12289' into develop-ascraeus
* rxu/ticket/12289:
  [ticket/12289] Add viewtopic template events for posts specific custom notices
2014-03-22 21:35:38 +01:00
Matt Friedman
b87fc1e56c [ticket/11230] Update cache driver dock blocks
PHPBB3-12230
2014-03-22 08:23:18 -07:00
rxu
4bb898a061 [ticket/12289] Add viewtopic template events for posts specific custom notices
These events allow extensions to add own posts specific notices-alike info.

PHPBB3-12289
2014-03-22 22:45:05 +08:00
Joas Schilling
13eb0ec5b9 Merge branch 'develop-olympus' into develop-ascraeus
* develop-olympus:
  [ticket/12035] Correcting the condition
  [ticket/12035] Adding necessary conditions
  [ticket/12035] Adding link to user posts to ACP page

Conflicts:
	phpBB/adm/style/acp_users_overview.html
2014-03-22 15:13:41 +01:00
Joas Schilling
5197e5afe3 Merge remote-tracking branch 'geetakshi/ticket/12035' into develop-olympus
* geetakshi/ticket/12035:
  [ticket/12035] Correcting the condition
  [ticket/12035] Adding necessary conditions
  [ticket/12035] Adding link to user posts to ACP page
2014-03-22 15:07:01 +01:00
Joas Schilling
4de099d969 Merge remote-tracking branch 'vsephpbb/ticket/11904' into develop-ascraeus
* vsephpbb/ticket/11904:
  [ticket/11904] Update explanation for what Allow CDN does
2014-03-22 15:01:11 +01:00
Joas Schilling
b191c1c5a6 Merge remote-tracking branch 'geetakshi/ticket/11357' into develop-ascraeus
* geetakshi/ticket/11357:
  [ticket/11357] Correcting invalid markup
2014-03-22 14:15:09 +01:00
Joas Schilling
4e58a03c20 Merge remote-tracking branch 'vsephpbb/ticket/12292' into develop-ascraeus
* vsephpbb/ticket/12292:
  [ticket/12292] Improve style details page
2014-03-22 13:22:13 +01:00
Andreas Fischer
3654ba4a35 Merge pull request #2169 from bantu/ticket/12293
[ticket/12293] Add missing compact() call to phpBB/phpbb/log/log.php eve...

* bantu/ticket/12293:
  [ticket/12293] Add missing compact() call to phpBB/phpbb/log/log.php events.
2014-03-22 02:38:42 +01:00
Forumhulp.com
4051ab689f [ticket/12293] Add missing compact() call to phpBB/phpbb/log/log.php events.
PHPBB3-12293
2014-03-22 02:07:39 +01:00
Joas Schilling
d7c2c9d472 [ticket/12286] Add note that goto should not be used
PHPBB3-12286
2014-03-21 17:04:58 +01:00
Matt Friedman
e4f6d9bc90 [ticket/12292] Improve style details page
http://tracker.phpbb.com/browse/PHPBB3-12292
Gave style details page a proper heading and back button.
Also removed a few obsolete code leftovers in the style
and CSS.

PHPBB3-12292
2014-03-20 18:11:45 -07:00
geetakshi
5afb06102b [ticket/11360] Avoiding online list where not required
PHPBB3-11360
2014-03-20 17:15:43 +05:30
geetakshi
663eb74cf3 [ticket/12035] Correcting the condition
PHPBB3-12035
2014-03-20 14:17:03 +05:30
Matt Friedman
60e5757fa1 [ticket/11230] Use inheritdoc in docblocks in cache drivers
http://tracker.phpbb.com/browse/PHPBB3-11230

PHPBB3-11230
2014-03-19 20:31:55 -07:00
Dhruv Goel
7f5d8becad Merge pull request #2137 from geetakshi/ticket/8309
[ticket/8309] Rename "Last visited" to "Last activity" on memberlist/viewprofile
2014-03-20 03:44:39 +05:30
geetakshi
5316c32b10 [ticket/12035] Adding necessary conditions
PHPBB3-12035
2014-03-20 03:36:53 +05:30
Joas Schilling
82c8986aed Merge remote-tracking branch 'vsephpbb/ticket/12285' into develop
* vsephpbb/ticket/12285:
  [ticket/12285] Fix mult-lingual issues between extensions
2014-03-19 21:48:29 +01:00
Joas Schilling
997ad65062 Merge remote-tracking branch 'Elsensee/ticket/11169' into develop
* Elsensee/ticket/11169:
  [ticket/11169] Skip migration if "Users" category has been deleted
  [ticket/11169] Move module 'prune users' to users category
2014-03-19 21:35:08 +01:00
Dhruv Goel
03f6ad544f Merge pull request #2145 from Elsensee/ticket/10590
[ticket/10590] Remove confirmation page after posting
2014-03-20 01:50:17 +05:30
geetakshi
9a3011c2dd [ticket/8309] Changing $last_activity to $last_active
PHPBB3-8309
2014-03-20 01:48:52 +05:30
Oliver Schramm
dd7e8c8d1d [ticket/11169] Skip migration if "Users" category has been deleted
or the module has already been moved to that category

PHPBB3-11169
2014-03-19 21:16:25 +01:00
Joas Schilling
2d1e6975b4 Merge remote-tracking branch 'netdeamon/ticket/12198-Language-issue' into develop
* netdeamon/ticket/12198-Language-issue:
  [ticket/12198] Language issue in en/common.php
2014-03-19 21:07:15 +01:00
Joas Schilling
76d7d38dea Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11766] Hide edit, quote and delete buttons if topic is locked

Conflicts:
	phpBB/viewtopic.php
2014-03-19 20:37:52 +01:00
Joas Schilling
bdab6dede0 Merge remote-tracking branch 'Elsensee/ticket/11766' into develop-olympus
* Elsensee/ticket/11766:
  [ticket/11766] Hide edit, quote and delete buttons if topic is locked
2014-03-19 20:34:22 +01:00
Oliver Schramm
d71fd5d660 [ticket/11766] Hide edit, quote and delete buttons if topic is locked
But show quote button to guests if topic isn't locked

PHPBB3-11766
2014-03-19 20:23:56 +01:00
Matt Friedman
b0f34afb8b [ticket/12285] Fix mult-lingual issues between extensions
PHPBB3-12285
2014-03-19 09:10:17 -07:00
geetakshi
51ff202820 [ticket/11357] Correcting invalid markup
PHPBB3-11357
2014-03-19 19:59:19 +05:30
geetakshi
18bed2ea47 [ticket/11360] Change second parameter in page_header function
PHPBB3-11360
2014-03-19 19:55:55 +05:30
Cesar G
2a822931c6 [ticket/11959] Add unit tests.
PHPBB3-11959
2014-03-19 03:08:34 -07:00
Cesar G
7c1ab5f79d [ticket/11959] Remove use of plurals and make it possible to use Oxford comma.
PHPBB3-11959
2014-03-19 03:08:34 -07:00
Cesar G
3da1f6d989 [ticket/11959] Rename phpbb_gen_string_list() & fix incorrect var name.
PHPBB3-11959
2014-03-19 03:08:33 -07:00
Cesar G
285ad0f6fa [ticket/11959] Simplify how the users are trimmed.
PHPBB3-11959
2014-03-19 03:08:33 -07:00
Cesar G
f0a85a90cc [ticket/11959] Add function to create a string list.
PHPBB3-11959
2014-03-19 03:08:33 -07:00
Cesar G
7cc1a8d224 [ticket/11959] Add samples for the untrimmed strings.
PHPBB3-11959
2014-03-19 03:08:33 -07:00
Cesar G
b32a66ca78 [ticket/11959] List the last user with "and" instead of a comma.
PHPBB3-11959
2014-03-19 03:08:33 -07:00
Cesar G
126ee37f66 [ticket/11959] Use the plurals system for the untrimmed language strings.
PHPBB3-11959
2014-03-19 03:08:33 -07:00
Cesar G
7e4b7a1542 [ticket/11959] Fix the NOTIFICATION_QUOTE_TRIMMED text.
PHPBB3-11959
2014-03-19 03:08:33 -07:00
Cesar G
6a278248e5 [ticket/11959] Use plurals for the language strings.
PHPBB3-11959
2014-03-19 03:08:33 -07:00
Oliver Schramm
3ea1ee651c Merge branch 'nickvergessen/ticket/elsensee/10590' into ticket/10590 2014-03-18 19:22:37 +01:00
netdeamon
a8274ae137 [ticket/12198] Language issue in en/common.php
Deleted lines as they are not needed anymore.

PHPBB3-12198
2014-03-18 22:13:10 +05:30
Joas Schilling
1af7697143 Merge remote-tracking branch 'prototech/ticket/12160' into develop
* prototech/ticket/12160:
  [ticket/12160] Use phpbb_check_installation_exists() in the other modules.
  [ticket/12160] Move phpbb_check_installation_exists() to functions_install.php
  [ticket/12160] Check if phpBB is installed before creating phpBB container.
  [ticket/12160] Add function to check if phpBB is installed.
2014-03-18 11:00:43 +01:00
Joas Schilling
f0d9a008d3 [ticket/10590] Fix functional tests are post confirm message removal
PHPBB3-10590
2014-03-18 10:58:26 +01:00
Joas Schilling
6750e19214 [ticket/12286] Add section about plurals to the coding guidelines
PHPBB3-12286
2014-03-18 10:14:11 +01:00
Joas Schilling
244d783865 [ticket/12286] Classes must use the name space
PHPBB3-12286
2014-03-18 09:54:14 +01:00
Joas Schilling
218e04a1e4 [ticket/12286] Remove section about utf8_normalize_nfc()
The request class takes care of this

PHPBB3-12286
2014-03-18 09:36:40 +01:00
Joas Schilling
c68f7671d2 [ticket/12286] Use $request->variable() instead of request_var()
PHPBB3-12286
2014-03-18 09:36:02 +01:00
Joas Schilling
d275a7cf63 [ticket/12286] Function names should be prefixed with phpbb_
PHPBB3-12286
2014-03-18 09:26:59 +01:00
Joas Schilling
30eccacb1d [ticket/12286] Add "Since" to template event docs
PHPBB3-12286
2014-03-18 09:21:30 +01:00
Joas Schilling
45857fe5c9 [ticket/12286] style.php and imagesets dont exist anymore
PHPBB3-12286
2014-03-18 09:18:41 +01:00
Joas Schilling
ac5a808ff3 [ticket/12286] Styles have a phpbb_version and a style_version in 3.1
PHPBB3-12286
2014-03-18 09:17:45 +01:00
Joas Schilling
37eea9fa41 [ticket/12286] Use UTF8 (c) in style.cfg samples
PHPBB3-12286
2014-03-18 09:10:01 +01:00
Joas Schilling
96e5a04001 Merge remote-tracking branch 'rxu3/ticket/12278' into develop
* rxu3/ticket/12278:
  [ticket/12278] Add mcp.php core event to allow to modify modules display option
2014-03-18 00:25:57 +01:00
Andreas Fischer
c09d3f924b Merge remote-tracking branch 'VSEphpbb/ticket/12284' into develop
* VSEphpbb/ticket/12284:
  [ticket/12284] Fix functional test for extension manager changes
2014-03-17 23:10:35 +01:00
Matt Friedman
9d2381cf3d [ticket/12284] Fix functional test for extension manager changes
PHPBB3-12284
2014-03-17 13:23:42 -07:00
Andreas Fischer
4635c5917c Merge remote-tracking branch 'VSEphpbb/ticket/12284' into develop
* VSEphpbb/ticket/12284:
  [ticket/12284] Improve readability of extension manager details
2014-03-17 20:30:57 +01:00
Matt Friedman
e46e3111e2 [ticket/12284] Improve readability of extension manager details
Use span tags like the rest of the ACP does, instead of P tags.
There is no semantic need to use P tags here. These are not
paragraphs.

PHPBB3-12284
2014-03-17 12:10:18 -07:00
geetakshi
66ed9881df [ticket/8309] Removing key with similar function to avoid redundancy
PHPBB3-8309
2014-03-17 21:08:03 +05:30
rxu
378cfd6e16 [ticket/12278] Add mcp.php core event to allow to modify modules display option
This event allows extensions to set display option for custom MCP modules
for extensions which add custom MCP modules
and some of them should be displayed conditionally.

PHPBB3-12278
2014-03-17 23:28:51 +08:00
Joas Schilling
772dd0def6 Merge remote-tracking branch 'rxu3/ticket/12279' into develop
* rxu3/ticket/12279:
  [ticket/12279] Add memberlist_view.html template event to add custom info
2014-03-17 15:58:33 +01:00
Joas Schilling
6fba2c6778 Merge remote-tracking branch 'vsephpbb/ticket/7580' into develop
* vsephpbb/ticket/7580:
  [ticket/7580] Add test for IF {VAR} is defined in templates
2014-03-17 15:55:51 +01:00
rxu
1e1a54882c [ticket/12279] Add memberlist_view.html template event to add custom info
Template event to ddd custom content
to the user profile view after the main content.

PHPBB3-12279
2014-03-17 21:01:16 +08:00
Joas Schilling
ee754dfab1 Merge remote-tracking branch 'dragooon/ticket/9040' into develop
* dragooon/ticket/9040:
  [ticket/9040] Minor cleanup in the unit test file
  [ticket/9040] Count HTML entities as single in custom profile fields
2014-03-17 13:33:23 +01:00
Shitiz Garg
8a48f6e267 [ticket/9040] Minor cleanup in the unit test file
PHPBB3-9040
2014-03-17 17:35:37 +05:30
Shitiz Garg
403ab49716 [ticket/9040] Count HTML entities as single in custom profile fields
Currently when an user adds a HTML entity to a custom profile field, the length
gets incremented by 4 since the code reads &gt; instead of <. However, the
length is presentational and not DB storage so it should be treated as a
single character even if it takes four lengths in the DB by being stored as
a HTML entity.

Work around this by decoding html entities before counting. Also, added unit
tests for string field type

PHPBB3-9040
2014-03-17 17:35:30 +05:30
Joas Schilling
ec25eba444 Merge branch 'ticket/12269' of github.com:netdeamon/phpbb into develop
# By netdeamon
# Via netdeamon
* 'ticket/12269' of github.com:netdeamon/phpbb:
  [ticket/12269] Delete folder mods in language
2014-03-17 10:18:37 +01:00
netdeamon
85147eb987 [ticket/12269] Delete folder mods in language
Deleted mods folder in phpbb/language/en/.

PHPBB3-12269
2014-03-17 14:26:08 +05:30
lucifer4o
c4034ac79a [ticket/12276] Expand core.memberlist_view_profile
Expand core.memberlist_view_profile to include zebra states

PHPBB3-12276
2014-03-17 10:40:56 +02:00
Matt Friedman
d8c1c7fb9a [ticket/7580] Add test for IF {VAR} is defined in templates
http://tracker.phpbb.com/browse/PHPBB3-7580
This test demonstrates that is possible to test if a
variable exists and then use it if it does, similar to
using isset(), but in template/twig syntax.
<!— IF {VAR} is defined —>{VAR}<!— ENDIF —>

PHPBB3-7580
2014-03-16 20:38:50 -07:00
Matt Friedman
3845a560b6 [ticket/11904] Update explanation for what Allow CDN does
PHPBB3-11904
2014-03-16 15:55:58 -07:00
Joas Schilling
f9438bcbf7 Merge branch 'ticket/11239' of github.com:geetakshi/phpbb into develop
# By geetakshi
# Via geetakshi
* 'ticket/11239' of github.com:geetakshi/phpbb:
  [ticket/11239] Removing hard-coded, language specific possessive
  [ticket/11239] Including username before Overview title
2014-03-16 23:30:54 +01:00
Joas Schilling
cdbc1e8a5c Merge remote-tracking branch 'vsephpbb/ticket/12274' into develop
* vsephpbb/ticket/12274:
  [ticket/12274] Add core.js to the install footer
  [ticket/12274] Fix broke/missing jQuery asset paths in update script
  [ticket/12274] Load correct T_TEMPLATE_PATH during update
2014-03-16 23:05:24 +01:00
geetakshi
418034af0e [ticket/12035] Adding link to user posts to ACP page
Adding link of posts behind displayed number of posts of the user

PHPBB3-12035
2014-03-17 00:52:11 +05:30
Nathan Guse
5f70518987 Merge pull request #2136 from Elsensee/ticket/11071
[ticket/11071] Add fallback if requested style don't exist
2014-03-16 14:09:46 -05:00
Oliver Schramm
e2835d66cd [ticket/10590] Remove confirmation page after posting
PHPBB3-10590
2014-03-16 17:54:58 +01:00
Nathan Guse
69c195687f Merge pull request #2144 from nickvergessen/travis/disable-redis
[travis/disable-redis] Disable redis on travis until its fixed again
2014-03-16 11:06:26 -05:00
Joas Schilling
ada37226bf [ticket/12281] Disable redis on travis until its fixed again
/home/travis/build/phpbb/phpbb/redis/redis.c:6141:34:
error: unknown type name ‘tsrm_ls’
make: *** [redis.lo] Error 1

The command "sh -c "if [ '$TRAVIS_PHP_VERSION' != 'hhvm' ];
then travis/setup-php-extensions.sh; fi"" failed
and exited with 2 during install.

PHPBB3-12281
2014-03-16 16:36:58 +01:00
Matt Friedman
a29ad78da6 [ticket/12274] Add core.js to the install footer
Required so phpbb var is defined, as it is used in admin.js.

PHPBB3-12274
2014-03-16 07:56:26 -07:00
Matt Friedman
81ceefd889 [ticket/12274] Fix broke/missing jQuery asset paths in update script
PHPBB3-12274
2014-03-16 07:22:24 -07:00
geetakshi
4d191f254d [ticket/11239] Removing hard-coded, language specific possessive
PHPBB3-11239
2014-03-16 15:36:47 +05:30
geetakshi
6a1967514d [ticket/8309] Moving key to get keys in alphabetical order
PHPBB3-8309
2014-03-16 14:27:34 +05:30
Matt Friedman
fd6836ca8a [ticket/12274] Load correct T_TEMPLATE_PATH during update
PHPBB3-12274
2014-03-15 20:44:56 -07:00
Oliver Schramm
fac814f8e7 [ticket/11169] Move module 'prune users' to users category
PHPBB3-11169
2014-03-16 02:53:01 +01:00
Oliver Schramm
4b2d7735b3 [ticket/7707] Add get_username_string() where possible
PHPBB3-7707
2014-03-16 00:11:12 +01:00
geetakshi
0bf758f00f [ticket/8309] Rename $last_visit to $last_activity
PHPBB3-8309
2014-03-16 03:37:21 +05:30
geetakshi
8c4604a78e [ticket/8309] Renaming "Last visit" to "Last activity"
PHPBB3-8309
2014-03-16 03:32:08 +05:30
Oliver Schramm
df0ac9876c [ticket/11071] Add fallback if requested style don't exist
PHPBB3-11071
2014-03-15 22:00:48 +01:00
geetakshi
7647b51d5d [ticket/11239] Including username before Overview title
Adding username to the page title to avoid confusion while managing
multiple users in ACP

PHPBB3-11239
2014-03-16 02:12:50 +05:30
Joas Schilling
584d7b5823 [ticket/12268] Do not use substr but just compare the character
PHPBB3-12268
2014-03-15 21:00:16 +01:00
Joas Schilling
325931a56b Merge branch 'prep-release-3.1.0-b1' into develop
* prep-release-3.1.0-b1:
  [prep-release-3.1.0-b1] Update build version to 3.1.0-b2-dev
  [prep-release-3.1.0-b1] Add changelog for 3.1.0-b1
  [prep-release-3.1.0-b1] Prepare Changelog
  [prep-release-3.1.0-b1] Add migration for 3.1.0-b1
  [prep-release-3.1.0-b1] Update version to 3.1.0-b1
2014-03-15 17:32:48 +01:00
Joas Schilling
9be5405e5b [prep-release-3.1.0-b1] Update build version to 3.1.0-b2-dev 2014-03-15 17:32:07 +01:00
Joas Schilling
873b5686a1 [prep-release-3.1.0-b1] Add changelog for 3.1.0-b1 2014-03-15 16:05:12 +01:00
Joas Schilling
f9c27ccd52 [prep-release-3.1.0-b1] Prepare Changelog 2014-03-15 15:37:22 +01:00
Joas Schilling
6159c3c738 [prep-release-3.1.0-b1] Add migration for 3.1.0-b1 2014-03-15 15:37:22 +01:00
Joas Schilling
407e0dbd8b [prep-release-3.1.0-b1] Update version to 3.1.0-b1 2014-03-15 15:37:21 +01:00
Andreas Fischer
aee4534d71 Merge pull request #2111 from nickvergessen/ticket/12262
[ticket/12262] Fix event exporter

* nickvergessen/ticket/12262:
  [ticket/12262] Do not use inline assignments
  [ticket/12262] Do not use getExtension()
  [ticket/12262] Fix location list for acp events with "Locations:"
  [ticket/12262] Also find vars array when it's defined in the trigger_event()
2014-03-15 15:34:55 +01:00
Joas Schilling
2d987d36c1 Merge remote-tracking branch 'maelsoucaze/develop' into develop
* maelsoucaze/develop:
  [ticket/12272] Fix hardcoded colons in subforums.
  [ticket/12272] Fix hardcoded colons in subforums.
2014-03-15 15:17:55 +01:00
Joas Schilling
87292f534e [ticket/12262] Do not use inline assignments
PHPBB3-12262
2014-03-15 15:14:00 +01:00
Joas Schilling
2071abda1f [ticket/12262] Do not use getExtension()
The method is php 5.3.6+ only.

PHPBB3-12262
2014-03-15 15:13:59 +01:00
Maël Soucaze
23b7671617 [ticket/12272] Fix hardcoded colons in subforums.
In subforums list, under the parent forum description, there are two
harcoded colons instead of {L_COLON}.

PHPBB3-12272
2014-03-15 14:32:26 +01:00
Maël Soucaze
e1278320a2 [ticket/12272] Fix hardcoded colons in subforums.
In subforums list, under the parent forum description, there are two
harcoded colons instead of {L_COLON}.

PHPBB3-12272
2014-03-15 14:25:11 +01:00
Dhruv Goel
eafba554fd Merge pull request #2128 from nickvergessen/ticket/12271
[ticket/12271] Decouple dropdown header and footer from #notifications_list
2014-03-14 22:24:42 +05:30
Joas Schilling
d9037965c8 [ticket/12271] Decouple dropdown header and footer from #notifications_list
PHPBB3-12271
2014-03-14 17:10:20 +01:00
Joas Schilling
f852630ef3 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12072] Fix comment about NEW MEMBERS permission
2014-03-14 14:36:29 +01:00
Joas Schilling
c1b48bdd01 Merge remote-tracking branch 'Elsensee/ticket/12072' into develop-olympus
* Elsensee/ticket/12072:
  [ticket/12072] Fix comment about NEW MEMBERS permission
2014-03-14 14:35:56 +01:00
Oliver Schramm
647f976c30 [ticket/12072] Fix comment about NEW MEMBERS permission
PHPBB3-12072
2014-03-14 14:33:56 +01:00
Joas Schilling
bfe872d1b7 Merge remote-tracking branch 'vsephpbb/ticket/11429' into develop
* vsephpbb/ticket/11429:
  [ticket/11429] Increment asset version on Ext enable
2014-03-14 14:25:50 +01:00
Joas Schilling
0aa23d203e Merge remote-tracking branch 'EXreaction/ticket/9871-2' into develop
* EXreaction/ticket/9871-2:
  [ticket/9871] Can set current version to use instead of the phpBB version
  [ticket/9871] Fix indentation on comment
  [ticket/9871] Fix test name
  [ticket/9871] Split fast and slow version tests
  [ticket/9871] Option to force the stability when checking for updates
  [ticket/9871] Allow setting the host/file to load for the version class
  [ticket/9871] Restore get_remote_file_test
  [ticket/9871] Fix tests
  [ticket/9871] Typehint and comment on var types
  [ticket/9871] Mark test as slow
  [ticket/9871] Restore phpbb_version_compare
  [ticket/9871] Restore get_remote_file
  [ticket/9871] Use $request->variable instead of request_var
  [ticket/9871] Update version check file to use json format
2014-03-14 14:04:30 +01:00
Joas Schilling
c743e28b94 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12247] Makes static usernames work
  [ticket/12247] Add ['username'] to mcp_queue.php's user_notification()

Conflicts:
	phpBB/includes/mcp/mcp_queue.php
2014-03-14 13:59:46 +01:00
Joas Schilling
bdce7abc84 Merge remote-tracking branch 'marcosbc/ticket/12247' into develop-olympus
* marcosbc/ticket/12247:
  [ticket/12247] Makes static usernames work
  [ticket/12247] Add ['username'] to mcp_queue.php's user_notification()
2014-03-14 13:58:17 +01:00
Joas Schilling
7b08a483fd Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12202] Use an array in the data provider instead of exploding manually
  [ticket/12202] Can't call htmlspecialchars before checking for quotes
  [ticket/12202] Fix tests
  [ticket/12202] Test for parse_cfg_file
  [ticket/12202] Use copyright symbol in style.cfg files
  [ticket/12202] Apply htmlspecialchars to style.cfg data

Conflicts:
	phpBB/styles/prosilver/style.cfg
	phpBB/styles/subsilver2/style.cfg
2014-03-14 13:55:53 +01:00
Joas Schilling
943e4e35ee Merge remote-tracking branch 'exreaction/ticket/12202' into develop-olympus
* exreaction/ticket/12202:
  [ticket/12202] Use an array in the data provider instead of exploding manually
  [ticket/12202] Can't call htmlspecialchars before checking for quotes
  [ticket/12202] Fix tests
  [ticket/12202] Test for parse_cfg_file
  [ticket/12202] Use copyright symbol in style.cfg files
  [ticket/12202] Apply htmlspecialchars to style.cfg data
2014-03-14 13:53:55 +01:00
Dhruv Goel
287c2b95ee Merge pull request #2126 from nickvergessen/ticket/forumhulp/12241
[ticket/12241] Event to add and/or modify acp_board configurations
2014-03-14 18:00:14 +05:30
Nathan Guse
a6b274e8ab Merge pull request #11 from nickvergessen/ticket/exreaction/12202
[ticket/12202] Use an array in the data provider instead of exploding manually
2014-03-14 07:29:22 -05:00
Joas Schilling
1f8ab1c196 [ticket/12202] Use an array in the data provider instead of exploding manually
PHPBB3-12202
2014-03-14 13:18:30 +01:00
Nathan Guse
60d2c1f400 [ticket/9871] Can set current version to use instead of the phpBB version
PHPBB3-9871
2014-03-14 07:07:26 -05:00
Nathan Guse
0c40cd5f13 [ticket/9871] Fix indentation on comment
PHPBB3-9871
2014-03-14 07:03:37 -05:00
Nathan Guse
23289c89a1 [ticket/9871] Fix test name
PHPBB3-9871
2014-03-14 07:02:25 -05:00
Joas Schilling
dc0bcdf8a0 [ticket/12268] Rename class file to recursive_dot_prefix_filter_iterator.php
PHPBB3-12268
2014-03-14 12:54:28 +01:00
Joas Schilling
56318fb5c4 [ticket/12241] Add @var for the arguments
PHPBB3-12241
2014-03-14 12:49:04 +01:00
Joas Schilling
7821cf0257 [ticket/12241] Update event name and version match our guidelines
PHPBB3-12241
2014-03-14 12:43:15 +01:00
Joas Schilling
973f5aa8c5 [ticket/12268] Move class out of extension namespace and rename it
PHPBB3-12268
2014-03-14 11:08:25 +01:00
Joas Schilling
5f8f1f04fd Merge remote-tracking branch 'dhruv/ticket/11040' into develop
* dhruv/ticket/11040:
  [ticket/11040] Topic is deleted if test is skipped
  [ticket/11040] Use unique text for the test post added
  [ticket/11040] Use hard delete in delete_topic
  [ticket/11040] Add migration to drop postgres search indexes
  [ticket/11040] Delete the functional test topic to avoid conflicts
  [ticket/11040] Add methods to delete post and topic in functional tests
  [ticket/11040] Swap post_text and post_subject for post_content index
  [ticket/11040] Add test cases for searching subject and post content together
  [ticket/11040] Remove postgres extra indexes
  [ticket/11040] Add post_content index
  [ticket/11040] Search subject and text together
2014-03-14 10:13:42 +01:00
Forumhulp.com
4b7a718f85 [ticket/12241] Add submit to event variables
PHPBB3-12241
2014-03-14 09:38:57 +01:00
Forumhulp.com
9d87b1a3c7 [ticket/12241] Move $phpbb_dispatcher to the top
PHPBB3-12241
2014-03-14 09:38:31 +01:00
Forumhulp.com
6db1a2bfad [ticket/12241] Event to add and/or modify acp_board configurations
PHPBB3-12241
2014-03-14 09:38:11 +01:00
Joas Schilling
3c6a17ae6b Merge remote-tracking branch 'vsephpbb/ticket/12263' into develop
* vsephpbb/ticket/12263:
  [ticket/12263] Add missing variable names to docblock fixes
  [ticket/12263] Remove invalid SQL query and unused variables
  [ticket/12263] Remove unused argument in module add/remove
  [ticket/12263] Fix incorrect docblock commets
2014-03-14 09:25:32 +01:00
Joas Schilling
954f0697ce Merge remote-tracking branch 'EXreaction/ticket/10288' into develop
* EXreaction/ticket/10288:
  [ticket/10288] Test to make sure included templates have proper variable scope
2014-03-14 08:56:06 +01:00
Matt Friedman
71246a5472 [ticket/11429] Increment asset version on Ext enable
PHPBB3-11429
2014-03-13 19:09:41 -07:00
Nathan Guse
a45aa2e5a0 [ticket/10288] Test to make sure included templates have proper variable scope
PHPBB3-10288
2014-03-13 19:48:07 -05:00
Nathan Guse
fb6b350c21 [ticket/9871] Split fast and slow version tests
PHPBB3-9871
2014-03-13 19:38:20 -05:00
Nathan Guse
36837e1975 Merge pull request #2109 from nickvergessen/ticket/11581
[ticket/11581] Hide categories on level 0 when they have no visible children
2014-03-13 19:31:22 -05:00
Marcos Bjorkelund
4333401a27 [ticket/12247] Makes static usernames work
Relative to the last ticket, this allows static usernames to
work correctly (those inserted in the post-column post_username)
when sending the e-mail, instead of showing just "Anonymous".

PHPBB3-12247
2014-03-14 00:49:20 +01:00
Matt Friedman
08165881f2 [ticket/12263] Add missing variable names to docblock fixes
PHPBB3-12263
2014-03-13 16:38:10 -07:00
Joas Schilling
59af5f4cbf [ticket/12268] Do not search in folders starting with a dot
PHPBB3-12268
2014-03-14 00:33:00 +01:00
Joas Schilling
329eb7c2b1 [ticket/12268] Use FilesystemIterator::SKIP_DOTS
PHPBB3-12268
2014-03-14 00:32:35 +01:00
Joas Schilling
12b8460089 Merge remote-tracking branch 'crizz0/ticket/11787' into develop
* crizz0/ticket/11787:
  [ticket/11787] Changes <samp> to <strong> in en/acp/permissions.php
2014-03-14 00:22:01 +01:00
Matt Friedman
c48fe65dfd [ticket/12263] Remove invalid SQL query and unused variables
PHPBB3-12263
2014-03-13 16:20:38 -07:00
Matt Friedman
5df3e0a4ec [ticket/12263] Remove unused argument in module add/remove
PHPBB3-12263
2014-03-13 16:10:08 -07:00
Matt Friedman
89b0ff1da8 [ticket/12263] Fix incorrect docblock commets
PHPBB3-12263
2014-03-13 16:09:32 -07:00
Joas Schilling
c695aa3903 Merge remote-tracking branch 'vsephpbb/ticket/12029' into develop
* vsephpbb/ticket/12029:
  [ticket/12029] Remove ellipsis and wrap long sidebar items in ACP
2014-03-13 23:55:19 +01:00
Marcos Bjorkelund
b322cb4c11 [ticket/12247] Add ['username'] to mcp_queue.php's user_notification()
It includes the poster's username in the email notifications of
posts that get approved by moderators.

This is done by adding the username to every user_notification()
function located in /phpBB/includes/mcp/mcp_queue.php.

PHPBB3-12247
2014-03-13 23:54:06 +01:00
Joas Schilling
92b15fbdf8 Merge remote-tracking branch 'vsephpbb/ticket/11111' into develop
* vsephpbb/ticket/11111:
  [ticket/11111] Prosilver posting textarea may only be resized vertically
2014-03-13 23:49:29 +01:00
Joas Schilling
4f8cba3c82 Merge remote-tracking branch 'vsephpbb/ticket/12073' into develop
* vsephpbb/ticket/12073:
  [ticket/12073] Increase size of samp and code tags in ACP
2014-03-13 23:40:51 +01:00
Matt Friedman
2c0efd5d1b [ticket/12029] Remove ellipsis and wrap long sidebar items in ACP
PHPBB3-12029
2014-03-13 15:24:27 -07:00
Matt Friedman
2de3943cec [ticket/12073] Increase size of samp and code tags in ACP
PHPBB3-12073
2014-03-13 15:08:21 -07:00
Crizzo
0c02eae1ad [ticket/11787] Changes <samp> to <strong> in en/acp/permissions.php
PHPBB3-11787
2014-03-13 20:58:05 +01:00
Matt Friedman
21bec33e0b [ticket/11111] Prosilver posting textarea may only be resized vertically
The resize element displays a mechanism for allowing the
user to resize the element. Setting this to vertical means it
may only be resized vertically.

PHPBB3-11111
2014-03-13 12:47:28 -07:00
Joas Schilling
a3b95839f5 [ticket/12268] Extension finder should not crawl through .git/ of extensions
This new filter ignores .svn and .git directories.
When searching for php classes and template files of extensions
we don't need to look inside these directories.

PHPBB3-12268
2014-03-13 17:12:03 +01:00
Joas Schilling
8a61e4b4c0 Merge remote-tracking branch 'crizz0/ticket/8785' into develop
* crizz0/ticket/8785:
  [ticket/8785] Deletes additional add and add_bcc buttons
  [ticket/8785] Fixed problem with add empty.png and travis will now pass
  [ticket/8785] and again a fresh line
  [ticket/8785] Just one blank line
  [ticket/8785] pm_layout.html back to more standard code
  [ticket/8785] <hr /> will only displayed when needed
  [ticket/8785] Adds blank lines at file end
  [ticket/8785] Adds a new optical improvement, new file and fixes html bugs
  [ticket/8785] Adds two <hr /> to seperate recipients and BCC
  [ticket/8785] Scrollbar to Reciepients and BCC with max-height: 200px
  [ticket/8785] Little spaces mistake
  [ticket/8785] Rebuilding posting_editor pm head + new language vars
2014-03-13 11:28:21 +01:00
Joas Schilling
6361d382b3 [ticket/11581] Add assertNotContainsLang() for functional test cases
PHPBB3-11581
2014-03-13 11:25:58 +01:00
Joas Schilling
eb1dd47e39 [ticket/11581] Hide categories when they have no visible children
PHPBB3-11581
2014-03-13 11:25:45 +01:00
Andreas Fischer
bd33855e7b Merge pull request #2110 from nickvergessen/ticket/12168
[ticket/12168] Move padding-top to ul.linklist li

* nickvergessen/ticket/12168:
  [ticket/12168] Move padding-top to ul.linklist li
2014-03-13 11:10:08 +01:00
Andreas Fischer
4ecfc07e03 Merge pull request #2113 from nickvergessen/ticket/8041
[ticket/8041] Merge item name into "Return to" string for better translations

* nickvergessen/ticket/8041:
  [ticket/8041] Add space/tabs after => in array list
  [ticket/8041] Wrap forum name, topic title and pm folder name with quotes
  [ticket/8041] Merge item name into "Return to" string for better translations
2014-03-13 11:02:29 +01:00
Andreas Fischer
16e7a1d931 Merge pull request #2115 from Elsensee/ticket/12267
[ticket/12267] Replace $php_ext with $phpEx

* Elsensee/ticket/12267:
  [ticket/12267] Replace $php_ext with $phpEx
2014-03-13 11:00:31 +01:00
Oliver Schramm
86a88751a8 [ticket/12267] Replace $php_ext with $phpEx
PHPBB3-12267
2014-03-13 10:52:10 +01:00
Joas Schilling
db63d0fbf9 [ticket/8041] Add space/tabs after => in array list
PHPBB3-8041
2014-03-13 10:41:41 +01:00
Joas Schilling
dbebe30c9a Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12176] Reword comment about config entries.
  [ticket/12176] Add newest_user_colour to config array to ensure it exists
  [ticket/12176] Display correct message when trying to delete founder.
  [ticket/12176] Add functional test for founder deletion message.

Conflicts:
	tests/test_framework/phpbb_functional_test_case.php
2014-03-13 10:27:19 +01:00
Joas Schilling
03eb23cbae Merge remote-tracking branch 'bantu/ticket/12176' into develop-olympus
* bantu/ticket/12176:
  [ticket/12176] Reword comment about config entries.
  [ticket/12176] Add newest_user_colour to config array to ensure it exists
  [ticket/12176] Display correct message when trying to delete founder.
  [ticket/12176] Add functional test for founder deletion message.
2014-03-13 10:16:41 +01:00
Andreas Fischer
e123b0c0a0 [ticket/12176] Reword comment about config entries.
PHPBB3-12176
2014-03-13 00:53:07 +01:00
Nathan Guse
d69012ea6d Merge pull request #2104 from nickvergessen/ticket/12261
[ticket/12261] Remove web root path from login redirect url
2014-03-12 18:48:41 -05:00
Andreas Fischer
d3ddf29e59 Merge pull request #6 from nickvergessen/ticket/bantu/12176
[ticket/12176] Add newest_user_colour to config array to ensure it exists

* nickvergessen/ticket/bantu/12176:
  [ticket/12176] Add newest_user_colour to config array to ensure it exists
2014-03-13 00:17:59 +01:00
Joas Schilling
c6a87e77d4 Merge remote-tracking branch 'vsephpbb/ticket/12244' into develop
* vsephpbb/ticket/12244:
  [ticket/12244] Rename extensions manager tab
  [ticket/12244] Rename link to Extensions Manager in the ACP
2014-03-12 20:18:29 +01:00
Joas Schilling
ca92ed918a [ticket/12176] Add newest_user_colour to config array to ensure it exists
PHPBB3-12176
2014-03-12 20:08:55 +01:00
Joas Schilling
871a89af07 Merge remote-tracking branch 'EXreaction/ticket/11716' into develop
* EXreaction/ticket/11716:
  [ticket/11716] Correct license URL
  [ticket/11716] Fix dependencies in migration files
  [ticket/11716] Rename migration files and add note that it's converting a MOD
  [ticket/11716] Convert Soft Delete Mod to post/topic visibility
2014-03-12 18:51:14 +01:00
Joas Schilling
dfa077710f [ticket/8041] Wrap forum name, topic title and pm folder name with quotes
PHPBB3-8041
2014-03-12 18:47:02 +01:00
Andreas Fischer
b809bea3d4 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/10549] using correct variable in includes/functions_module.php too
  [ticket/10549] changed "right" to "incorrect"

Conflicts:
	phpBB/includes/functions_module.php
2014-03-12 16:28:47 +01:00
Andreas Fischer
d81a604ef8 Merge remote-tracking branch 'Crizz0/ticket/10549' into develop-olympus
* Crizz0/ticket/10549:
  [ticket/10549] using correct variable in includes/functions_module.php too
  [ticket/10549] changed "right" to "incorrect"
2014-03-12 16:25:01 +01:00
Dhruv
6918921d53 [ticket/11040] Topic is deleted if test is skipped
PHPBB3-11040
2014-03-12 11:03:33 +05:30
Dhruv
3d1d25a122 [ticket/11040] Use unique text for the test post added
PHPBB3-11040
2014-03-12 11:03:30 +05:30
Dhruv
799c575990 [ticket/11040] Use hard delete in delete_topic
PHPBB3-11040
2014-03-12 11:03:29 +05:30
Dhruv
556c7d9218 [ticket/11040] Add migration to drop postgres search indexes
PHPBB3-11040
2014-03-12 11:03:27 +05:30
Dhruv
6524513f9d [ticket/11040] Delete the functional test topic to avoid conflicts
PHPBB3-11040
2014-03-12 11:02:08 +05:30
Dhruv
b5310e9565 [ticket/11040] Add methods to delete post and topic in functional tests
PHPBB3-11040
2014-03-12 11:02:06 +05:30
Dhruv
932e0eb17e [ticket/11040] Swap post_text and post_subject for post_content index
Provides better performance as per PostgreSQL Docs.

PHPBB3-11040
2014-03-12 11:02:04 +05:30
Dhruv
1094a2b577 [ticket/11040] Add test cases for searching subject and post content together
PHPBB3-11040
2014-03-12 11:02:01 +05:30
Dhruv
101ceed80c [ticket/11040] Remove postgres extra indexes
Remove post_text index as post_content index is sufficient to search post
text.

PHPBB3-11040
2014-03-12 11:02:00 +05:30
Dhruv
87688687e4 [ticket/11040] Add post_content index
In addition to post_subject and post_title indexes add a post_content
which is concatenation of both the columns.

PHPBB3-11040
2014-03-12 11:01:42 +05:30
Dhruv
274c83c74d [ticket/11040] Search subject and text together
Instead of searching for post_subject and post_text seperately and then
OR them in where clause we use concatenation of the two columns and search

PHPBB3-11040
2014-03-12 11:01:21 +05:30
Nathan Guse
feed1441ad [ticket/9871] Option to force the stability when checking for updates
PHPBB3-9871
2014-03-11 19:15:50 -05:00
Joas Schilling
9419edd686 [ticket/8041] Merge item name into "Return to" string for better translations
PHPBB3-8041
2014-03-12 01:05:05 +01:00
Nathan Guse
c14d2fb60f [ticket/11716] Correct license URL
PHPBB3-11716
2014-03-11 18:43:03 -05:00
Nathan Guse
f75b98aa8b [ticket/11716] Fix dependencies in migration files
PHPBB3-11716
2014-03-11 18:34:35 -05:00
Crizzo
21961a25ba [ticket/8785] Deletes additional add and add_bcc buttons
PHPBB3-8785
2014-03-11 22:02:43 +01:00
Crizzo
d95d062a42 [ticket/10549] using correct variable in includes/functions_module.php too
PHPBB3-10549
2014-03-11 18:45:46 +01:00
Crizzo
239f72ddda [ticket/10549] changed "right" to "incorrect"
PHPBB3-10549
2014-03-11 18:24:35 +01:00
Joas Schilling
ad6fda5776 Merge remote-tracking branch 'rxu3/ticket/12260' into develop
* rxu3/ticket/12260:
  [ticket/12260] Add core events to delete_posts() function.
2014-03-11 17:55:38 +01:00
Joas Schilling
8aa22550b9 [ticket/12262] Fix location list for acp events with "Locations:"
PHPBB3-12262
2014-03-11 17:44:25 +01:00
Joas Schilling
e1d5702853 [ticket/12262] Also find vars array when it's defined in the trigger_event()
PHPBB3-12262
2014-03-11 17:44:25 +01:00
Matt Friedman
9b1620911d [ticket/12244] Rename extensions manager tab
PHPBB3-12244
2014-03-11 08:36:51 -07:00
rxu
e8b7f68406 [ticket/12260] Add core events to delete_posts() function.
Events for extensions to perform additional actions on posts deletion.

PHPBB3-12260
2014-03-11 23:31:11 +08:00
Joas Schilling
8eb15de406 [ticket/12168] Move padding-top to ul.linklist li
PHPBB3-12168
2014-03-11 11:26:13 +01:00
Joas Schilling
e07f314117 [ticket/12261] Mark test as incomplete, something is wrong with sessions
PHPBB3-12261
2014-03-11 11:05:27 +01:00
Dhruv
cf468bcc09 [ticket/11581] Fix year in copyright header
PHPBB3-11581
2014-03-11 10:38:20 +01:00
Dhruv
8b936fc8eb [ticket/11581] Enabled private messages after tests
PHPBB3-11581
2014-03-11 10:38:04 +01:00
Dhruv
ce4926d000 [ticket/11581] Add test to check UCP_PM is enabled/disabled correctly
PHPBB3-11581
2014-03-11 10:37:52 +01:00
Joas Schilling
5a43ea2067 Merge branch 'develop-olympus' into develop
* develop-olympus:
2014-03-11 09:54:01 +01:00
Joas Schilling
296af6c679 Merge remote-tracking branch 'dhruvgoel92/ticket/11271-develop' into develop
* dhruvgoel92/ticket/11271-develop: (25 commits)
  [ticket/11271] Make path conversion more precise
  [ticket/11271] limit absolute path conversion to attachment links only
  [ticket/11271] Add docblock of feed_generate_content( )
  [ticket/11271] Fix tabs and use !empty( ) instead of count( )
  [ticket/11271] Remove unnecessary inclusion of functions_display
  [ticket/11271] Typecast forum and topic id to integer
  [ticket/11271] Use absolute path for displaying inline attachments in feeds
  [ticket/11271] Changed executable bit.
  [ticket/11271] Formatting code and removing null assignment.
  [ticket/11271] Removing unnecessary database object
  [ticket/11271] Separated attachment fetching query
  [ticket/11271] Fetched feed attachments before loop.
  [ticket/11271] Removed in-line attachment comments properly.
  [ticket/11271] Displaying in-line attached images in ATOM feed.
  [ticket/11271] Add the inline images html to content
  [ticket/11271] Use class variable $db instead of global
  [ticket/11271] Typecast forum and topic id to integer
  [ticket/11271] Use absolute path for displaying inline attachments in feeds
  [ticket/11271] Changed executable bit.
  [ticket/11271] Formatting code and removing null assignment.
  ...
2014-03-11 09:53:52 +01:00
Joas Schilling
e65a6dd8f4 Merge remote-tracking branch 'dhruvgoel92/ticket/11271' into develop-olympus
* dhruvgoel92/ticket/11271:
  [ticket/11271] Make path conversion more precise
  [ticket/11271] Add docblock of feed_generate_content( )
  [ticket/11271] Fix tabs and use !empty( ) instead of count( )
  [ticket/11271] Remove unnecessary inclusion of functions_display
  [ticket/11271] Typecast forum and topic id to integer
  [ticket/11271] Use absolute path for displaying inline attachments in feeds
  [ticket/11271] Changed executable bit.
  [ticket/11271] Formatting code and removing null assignment.
  [ticket/11271] Removing unnecessary database object
  [ticket/11271] Separated attachment fetching query
  [ticket/11271] Fetched feed attachments before loop.
  [ticket/11271] Removed in-line attachment comments properly.
  [ticket/11271] Displaying in-line attached images in ATOM feed.
2014-03-11 09:53:18 +01:00
Joas Schilling
65626d602e Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11288] Handle +,- without preceeding whitespace characters
2014-03-11 09:48:32 +01:00
Joas Schilling
4b259e3c82 Merge remote-tracking branch 'dhruvgoel92/ticket/11288-develop' into develop
* dhruvgoel92/ticket/11288-develop:
  [ticket/11288] Add unit test cases for foo-bar like queries
  [ticket/11288] Handle +,- without preceeding whitespace characters
2014-03-11 09:48:24 +01:00
Joas Schilling
214f515e9c Merge remote-tracking branch 'dhruvgoel92/ticket/11288' into develop-olympus
* dhruvgoel92/ticket/11288:
  [ticket/11288] Handle +,- without preceeding whitespace characters
2014-03-11 09:46:31 +01:00
Joas Schilling
37b19bc533 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12259] Reduce the size of our test matrix

Conflicts:
	.travis.yml
2014-03-11 09:15:33 +01:00
Joas Schilling
a35901c29b Merge remote-tracking branch 'EXreaction/ticket/12259-olympus' into develop-olympus
* EXreaction/ticket/12259-olympus:
  [ticket/12259] Reduce the size of our test matrix
2014-03-11 09:13:37 +01:00
Nathan Guse
052bbf654f Merge remote-tracking branch 'remotes/upstream/develop-olympus' into develop
* remotes/upstream/develop-olympus:
  [ticket/12106] Combined first and second sentence
  [ticket/12106] Adds a explaination that admin/mods still able to use the board

Conflicts:
	phpBB/language/en/acp/board.php
2014-03-10 21:51:07 -05:00
Nathan Guse
9aa947f7fb Merge pull request #2105 from Crizz0/ticket/12106
[ticket/12106] Adds a explaination that admin/mods still able to use the...
2014-03-10 21:49:29 -05:00
Nathan Guse
3181c44fc9 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/10549] Adds language variables

Conflicts:
	phpBB/includes/functions_module.php
2014-03-10 21:44:04 -05:00
Nathan Guse
ea63e1412b Merge pull request #2100 from Crizz0/ticket/10549
[ticket/10549] Adds language variables to Error messages MODULE...
2014-03-10 21:40:44 -05:00
Nathan Guse
a4810405d2 [ticket/12259] Reduce the size of our test matrix
Only test MariaDB or PostgreSQL once on PHP 5.4. This reduces our build matrix
by 10 builds (over half).

PHPBB3-12259
2014-03-10 21:34:55 -05:00
Nathan Guse
92b638ed83 Merge pull request #2107 from VSEphpbb/ticket/12117
[ticket/12117] Add get_all_tree_data method to tree class
2014-03-10 21:30:39 -05:00
Nathan Guse
00d86a4af1 [ticket/9871] Allow setting the host/file to load for the version class
PHPBB3-9871
2014-03-10 21:26:46 -05:00
Nathan Guse
1f7c891da2 [ticket/9871] Restore get_remote_file_test
PHPBB3-9871
2014-03-10 20:57:20 -05:00
Nathan Guse
23ea833425 Merge pull request #2101 from nickvergessen/ticket/10763
[ticket/10763] Do not call non-static functions statically
2014-03-10 20:51:20 -05:00
Nathan Guse
f7020fb5d1 Merge pull request #2092 from nickvergessen/ticket/12090
[ticket/12090] Pass route name to url() instead of the url itself
2014-03-10 20:50:08 -05:00
Matt Friedman
4127f92496 [ticket/12117] Select all fields instead of item_basic_data
PHPBB3-12117
2014-03-10 16:06:53 -07:00
Matt Friedman
c1115d9451 [ticket/12117] Add get_all_tree_data method to tree class
PHPBB3-12117
2014-03-10 15:59:45 -07:00
Joas Schilling
235f7c3721 Merge remote-tracking branch 'rxu3/ticket/12224' into develop
* rxu3/ticket/12224:
  [ticket/12224] Add assign_block_vars_array() test.
  [ticket/12224] Add template wrapper method to assign block arrays
2014-03-10 23:49:37 +01:00
Crizzo
957e9aabc3 [ticket/12106] Combined first and second sentence
PHPBB3-12106
2014-03-10 21:19:25 +01:00
Suhaib Khan
92fe7e61c2 [ticket/11666] Removing MESSAGE_DELETED..
..in /en/posting.php as it is not used.

PHPBB3-11666
2014-03-10 23:42:56 +05:30
Crizzo
13327a13a0 [ticket/12106] Adds a explaination that admin/mods still able to use the board
PHPBB3-12106
2014-03-10 18:50:39 +01:00
Crizzo
ec4c9833ca [ticket/10549] Adds language variables
PHPBB3-10549
2014-03-10 18:35:23 +01:00
Joas Schilling
fe63ac888f [ticket/12261] Fix doc block
PHPBB3-12261
2014-03-10 17:09:28 +01:00
Joas Schilling
f43da31bba [ticket/12261] Validate the redirect hidden field before submitting the form
PHPBB3-12261
2014-03-10 15:27:48 +01:00
rxu
d29514f3e7 [ticket/12224] Add assign_block_vars_array() test.
Add tests, also change return value to null.

PHPBB3-12224
2014-03-10 20:59:45 +08:00
Joas Schilling
e8fdc1545a [ticket/12261] Add a functional test for redirect after using login_box()
PHPBB3-12261
2014-03-10 12:35:30 +01:00
Joas Schilling
b876c07377 [ticket/12261] Remove web root path from login redirect url
The redirect url must be relative to the ucp.php and not relative to the
current page.

PHPBB3-12261
2014-03-10 10:15:38 +01:00
Nathan Guse
c169583dc3 Merge pull request #2089 from nickvergessen/ticket/12251
[ticket/12251] Clean up and Enhancement of Custom Profile Fields
2014-03-09 17:26:22 -05:00
Nathaniel Guse
f3d8dfd1e3 [ticket/12202] Can't call htmlspecialchars before checking for quotes
PHPBB3-12202
2014-03-09 17:17:33 -05:00
Nathaniel Guse
50dd76aef3 [ticket/12202] Fix tests
PHPBB3-12202
2014-03-09 17:16:45 -05:00
Nathan Guse
20723a9315 Merge pull request #2099 from bantu/ticket/12256
[ticket/12256] Selecting founders is fetching $sql instead of $result
2014-03-09 16:55:28 -05:00
Crizzo
47ad92ae31 [ticket/8785] Fixed problem with add empty.png and travis will now pass
PHPBB3-8785
2014-03-09 22:14:40 +01:00
Joas Schilling
521c6c7d75 [ticket/10763] Do not call messenger::error() statically
PHPBB3-10763
2014-03-09 22:03:38 +01:00
Joas Schilling
37dace4967 [ticket/10763] Do not call non-static transfer() statically
PHPBB3-10763
2014-03-09 21:53:21 +01:00
Crizzo
0fd172aaa4 [ticket/8785] and again a fresh line
PHPBB3-8785
2014-03-09 21:50:44 +01:00
Joas Schilling
38aef98a69 [ticket/10763] Fix static calls to non static methods in colour_manager
PHPBB3-10763
2014-03-09 21:42:59 +01:00
Joas Schilling
12dc36903e [ticket/10763] Do not call set_post_visibility() statically
PHPBB3-10763
2014-03-09 21:38:32 +01:00
Forumhulp.com
86845e48a2 [ticket/12256] Selecting founders is fetching $sql instead of $result
PHPBB3-12256
2014-03-09 21:37:44 +01:00
Nathan Guse
49734db9cd [ticket/12202] Test for parse_cfg_file
PHPBB3-12202
2014-03-09 15:20:42 -05:00
Nathan Guse
224e3f139f [ticket/12202] Use copyright symbol in style.cfg files
PHPBB3-12202
2014-03-09 15:20:18 -05:00
Nathan Guse
f2d3879da4 [ticket/12202] Apply htmlspecialchars to style.cfg data
PHPBB3-12202
2014-03-09 15:19:52 -05:00
Crizzo
cc59b5e44b [ticket/8785] Just one blank line
PHPBB3-8785
2014-03-09 21:16:40 +01:00
Joas Schilling
bc74819cc9 [ticket/12251] Remove leading whitespace on doc blocks
PHPBB3-12251
2014-03-09 21:13:04 +01:00
Crizzo
b4a65da2ed [ticket/8785] pm_layout.html back to more standard code
PHPBB3-8785
2014-03-09 19:37:45 +01:00
Joas Schilling
0119a21862 [ticket/12090] Comment out broken test
PHPBB3-12090
2014-03-09 19:17:12 +01:00
Joas Schilling
b29c4c6358 [ticket/12090] Move find() call to container and fix tests
PHPBB3-12090
2014-03-09 19:03:15 +01:00
Joas Schilling
2eb24d0ace [ticket/12090] Split finding routes and returning routes into 2 methods
PHPBB3-12090
2014-03-09 18:38:21 +01:00
Joas Schilling
436b1d3577 [ticket/12090] Fix parameter list of controller helper constructor
PHPBB3-12090
2014-03-09 18:22:32 +01:00
Dhruv
baed78bde7 [ticket/11288] Add unit test cases for foo-bar like queries
foo-bar and foo -bar are interpreted differently by
native search backend now.

PHPBB3-11288
2014-03-09 22:30:22 +05:30
Crizzo
cace4a50d0 [ticket/8785] <hr /> will only displayed when needed
PHPBB3-8785
2014-03-09 17:59:49 +01:00
Dhruv
1688d88059 Merge branch 'ticket/11288' into ticket/11288-develop
* ticket/11288:
  [ticket/11288] Handle +,- without preceeding whitespace characters
2014-03-09 22:00:06 +05:30
Dhruv
a3033a4a86 [ticket/11288] Handle +,- without preceeding whitespace characters
PHPBB3-11288
2014-03-09 21:51:34 +05:30
Nathan Guse
7ca762c524 Merge branch 'develop-olympus' into develop
* develop-olympus:
2014-03-09 11:15:58 -05:00
Nathan Guse
72e0fe0b22 Merge remote-tracking branch 'remotes/dhruvgoel92/ticket/10945-develop' into develop
* remotes/dhruvgoel92/ticket/10945-develop:
  [ticket/10945] Remove mark test incomplete for native search backend
  [ticket/10945] Fix Unit Tests as per new changes to split_keywords
  [ticket/10945] Remove mark test incomplete for mysql and postgres
  [ticket/10945] Fix return values for split_keywords function
  [ticket/10945] Display search query when search fails in native search
  [ticket/10945] remove trigger_error call
2014-03-09 11:15:48 -05:00
Nathan Guse
00f8fe24d2 Merge remote-tracking branch 'remotes/dhruvgoel92/ticket/10945' into develop-olympus
* remotes/dhruvgoel92/ticket/10945:
  [ticket/10945] Fix return values for split_keywords function
  [ticket/10945] Display search query when search fails in native search
  [ticket/10945] remove trigger_error call
2014-03-09 11:15:10 -05:00
Crizzo
f2321af9ed [ticket/8785] Adds blank lines at file end
PHPBB3-8785
2014-03-09 14:21:17 +01:00
Crizzo
9ef79776a9 [ticket/8785] Adds a new optical improvement, new file and fixes html bugs
PHPBB3-8785
2014-03-09 13:20:49 +01:00
Nathan Guse
c305bd25e4 Merge pull request #2074 from Crizz0/ticket/12240
Ticket/12240 - Adds specific class to BBCode-Buttons in Template incl. Custom-BBCode support
2014-03-08 19:20:22 -06:00
Nathan Guse
7880a87c5e Merge pull request #2094 from dhruvgoel92/ticket/11938
[ticket/11938] remove deprecated sql_attr_str2ordinal and use sql_attr_string
2014-03-08 19:17:46 -06:00
Nathan Guse
c655757aa6 [ticket/9871] Fix tests
PHPBB3-9871
2014-03-08 17:43:58 -06:00
Dhruv
8290dd6b1c [ticket/11938] Fix whitespace characters
PHPBB3-11938
2014-03-09 01:17:36 +05:30
Dhruv
1207767bb3 [ticket/11938] use sql_attr_string instead of sql_attr_str2ordinal
PHPBB3-11938
2014-03-09 01:16:13 +05:30
Andreas Fischer
4fb19c8541 Merge pull request #2093 from nickvergessen/ticket/11764
[ticket/11764] Create separate packages for subsilver2 on releases.

* nickvergessen/ticket/11764:
  [ticket/11764] Create separate packages for subsilver2 on releases.
2014-03-08 18:48:40 +01:00
Joas Schilling
40e76c090e [ticket/11764] Create separate packages for subsilver2 on releases.
PHPBB3-11764
2014-03-08 17:37:29 +01:00
Dhruv
0036b00fc4 [ticket/10945] Remove mark test incomplete for native search backend
PHPBB3-10945
2014-03-08 21:46:14 +05:30
Dhruv
304c0799ba [ticket/10945] Fix Unit Tests as per new changes to split_keywords
PHPBB3-10945
2014-03-08 21:45:23 +05:30
Dhruv
41fa32bae4 [ticket/10945] Remove mark test incomplete for mysql and postgres
PHPBB3-10945
2014-03-08 21:45:07 +05:30
Dhruv
3b6d371310 Merge branch 'ticket/10945' into ticket/10945-develop
* ticket/10945:
  [ticket/10945] Fix return values for split_keywords function
  [ticket/10945] Display search query when search fails in native search
  [ticket/10945] remove trigger_error call

Conflicts:
	phpBB/phpbb/search/fulltext_native.php
2014-03-08 21:44:30 +05:30
Dhruv
c51dcbe6a0 [ticket/10945] Fix return values for split_keywords function
The function now returns false if all the words are common words and true
otherwise.

PHPBB3-10945
2014-03-08 21:23:08 +05:30
Dhruv
b6eec5c142 [ticket/10945] Display search query when search fails in native search
If search fails and common words are present, split_keywords returns false
and search.php file prints appropriate message of common words.
If search fails and there are no common words, split_keywords returns true
and keyword_search returns false so that the search query is displayed in
search box.

PHPBB3-10945
2014-03-08 21:20:37 +05:30
Dhruv Goel
f4645a6376 [ticket/10945] remove trigger_error call
removes trigger_error call incase no search results are found or start
variable exceeds the amount. So that search query is displayed in the
search box even if no results are returned.

PHPBB3-10945
2014-03-08 21:15:51 +05:30
Joas Schilling
07c07171f9 [ticket/12090] Make provider a service and inject it into the helper
PHPBB3-12090
2014-03-08 16:37:22 +01:00
Joas Schilling
275910d8b0 [ticket/12090] Fix pagination for routes
No clickable "jump to" at the moment, as we can not get the route url
by the route name in js yet. Need to find another solution later.

PHPBB3-12090
2014-03-08 16:02:44 +01:00
Dhruv
9100f4ebbf Merge remote-tracking branch 'VarunAgw/ticket/12250' into develop
# By Varun Agrawal
# Via Varun Agrawal
* VarunAgw/ticket/12250:
  [ticket/12250] Remove deprecated phpbb_clean_path function
  [ticket/12250] Remove deprecated phpbb_clean_path function
2014-03-08 18:14:05 +05:30
Joas Schilling
6491477809 [ticket/12090] Fix helper usage in functional controller tests
PHPBB3-12090
2014-03-07 15:14:35 +01:00
Joas Schilling
ecf1e94726 [ticket/12090] Change redirect tests to use route()
PHPBB3-12090
2014-03-07 14:07:45 +01:00
Joas Schilling
51273f6fb1 [ticket/12090] Pass route name to url() to allow admins to change the routes
PHPBB3-12090
2014-03-07 12:32:38 +01:00
Andreas Fischer
19d0c2abd5 Merge remote-tracking branch 'VSEphpbb/ticket/12248' into develop
* VSEphpbb/ticket/12248:
  [ticket/12248] Restore id attributes to extension details (used by tests)
2014-03-06 23:50:07 +01:00
Varun Agrawal
429c006440 [ticket/12250] Remove deprecated phpbb_clean_path function
The function phpbb_clean_path() in functions.php is deprecated and is
replaced by filesystem class. Therefore, this function is moved to the
functions_compatibility file.

PHPBB3-12250
2014-03-07 03:44:28 +05:30
Matt Friedman
aae22d699e [ticket/12248] Restore id attributes to extension details (used by tests)
PHPBB3-12248
2014-03-06 12:02:27 -08:00
Varun Agrawal
1cf8554d0e [ticket/12250] Remove deprecated phpbb_clean_path function
The function phpbb_clean_path() in functions.php is deprecated as is not
used used 3.0/3.1 core

PHPBB3-12250
2014-03-06 23:51:49 +05:30
Nathan Guse
c40b15ae19 Merge pull request #2087 from marc1706/ticket/12239
[ticket/12239] Move deprecated passwords functions to compatibility file
2014-03-06 07:00:30 -06:00
Joas Schilling
600e5f6c11 [ticket/12251] Add string validation for a-zA-Z0-9 and underscore
PHPBB3-12251
2014-03-06 12:28:36 +01:00
Joas Schilling
50165fe920 [ticket/12251] Load profile fields by default on posts, pms and memberlist
PHPBB3-12251
2014-03-06 12:08:46 +01:00
Joas Schilling
e6f492c7ac [ticket/12251] Enable displaying profile fields on memberlist, posts and pms
PHPBB3-12251
2014-03-06 12:02:11 +01:00
Joas Schilling
f0ac25f3c5 [ticket/12251] Deactivate outdated profile fields by default
PHPBB3-12251
2014-03-06 12:00:40 +01:00
Joas Schilling
d9c93337cc [ticket/12251] Sort IM profile fields alphabetically
PHPBB3-12251
2014-03-06 12:00:01 +01:00
Marc Alexander
6251ca1459 [ticket/12239] Move deprecated passwords functions to compatibility file
The deprecated passwords functions are no longer used in the core and have
been replaced with the passwords manager. Therefore, the functions are
moved to the functions_compatibility file.

PHPBB3-12239
2014-03-06 09:43:52 +01:00
Nathan Guse
98542547e2 [ticket/9871] Typehint and comment on var types
PHPBB3-9871
2014-03-05 19:18:54 -06:00
Nathan Guse
dc5a34eb88 [ticket/9871] Mark test as slow
PHPBB3-9871
2014-03-05 19:18:23 -06:00
Nathan Guse
43074a1b69 [ticket/9871] Restore phpbb_version_compare
PHPBB3-9871
2014-03-05 19:09:47 -06:00
Nathan Guse
8748032866 [ticket/9871] Restore get_remote_file
PHPBB3-9871
2014-03-05 19:07:39 -06:00
Nathan Guse
6a8f110b5a [ticket/9871] Use $request->variable instead of request_var
PHPBB3-9871
2014-03-05 19:00:52 -06:00
Nathan Guse
4b6f3f8b0f Merge pull request #2088 from nickvergessen/ticket/12236
Ticket/12236 Convert AOL and Yahoo to custom profile fields
2014-03-05 18:44:39 -06:00
Joas Schilling
d380cdec02 [ticket/12236] Fix language key name for Yahoo Messanger
PHPBB3-12236
2014-03-06 01:41:38 +01:00
Nathan Guse
40c582688b Merge pull request #2054 from rxu/ticket/12213-1
[ticket/12213] Add MCP events for custom quick moderation options
2014-03-05 18:37:26 -06:00
Nathan Guse
c1ca74ee6d Merge pull request #2058 from nickvergessen/ticket/12216
[ticket/12216] Undefined index: lang_options when creating date profile field
2014-03-05 18:36:15 -06:00
Nathan Guse
9d25485b32 Merge pull request #2061 from rxu/ticket/12231
[ticket/12231] Add template events to forumlist_body.html
2014-03-05 18:33:27 -06:00
Nathan Guse
ad46fe62d8 Merge pull request #2075 from Elsensee/ticket/11693
[ticket/11693] Change sql_build_array to support DELETE
2014-03-05 18:31:36 -06:00
Nathan Guse
9b1b57c649 Merge pull request #2080 from nickvergessen/ticket/12243
[Ticket/12243] subsilver2 is missing profile field files
2014-03-05 18:29:07 -06:00
Nathan Guse
3ece3223e4 Merge pull request #2086 from VSEphpbb/ticket/12248
[ticket/12248] Make extension details homepage a clickable link
2014-03-05 18:27:29 -06:00
Matt Friedman
898976f8a1 [ticket/12248] Remove unused label for attributes and related id tags
PHPBB3-12248
2014-03-05 15:05:40 -08:00
Matt Friedman
2e49efc12d [ticket/12248] Use id instead of name attribute in a tags
PHPBB3-12248
2014-03-05 14:54:04 -08:00
Matt Friedman
4e770c2b42 [ticket/12248] Fix meta_author tags (IDs must be unique)
PHPBB3-12248
2014-03-05 14:53:31 -08:00
Matt Friedman
d0b07503ad [ticket/12248] Remove p tag in favor of strong tag
PHPBB3-12248
2014-03-05 14:45:45 -08:00
Joas Schilling
240eeec71d [ticket/12236] Change order of profile fields for new installs
PHPBB3-12236
2014-03-05 22:40:54 +01:00
Joas Schilling
e88c61f85e [ticket/12249] Fix "Undefined variable: row" when editing profile
PHPBB3-12249
2014-03-05 22:32:03 +01:00
Joas Schilling
fed3e7c2de [ticket/12236] Fix layout of memberlist search
PHPBB3-12236
2014-03-05 22:28:22 +01:00
Joas Schilling
f2059f52f3 [ticket/12236] Move AOL Instant Messanger field to custom profile field
PHPBB3-12236
2014-03-05 22:13:22 +01:00
Joas Schilling
a1dab58f6d [ticket/12237] Regenerate db schema files
PHPBB3-12237
2014-03-05 21:47:11 +01:00
Joas Schilling
2e5106aae1 [ticket/12237] Convert yahoo messanger to custom profile field
PHPBB3-12237
2014-03-05 21:38:57 +01:00
Nils Adermann
71354ef185 [develop] Fix incorrect merge conflict resolution from PR #2085
PHPBB3-12235
2014-03-05 11:51:38 +01:00
Nils Adermann
0e35a85155 Merge remote-tracking branch 'github-nickvergessen/ticket/12235' into develop
* github-nickvergessen/ticket/12235:
  [ticket/12235] Convert WLM to custom profile field
  [ticket/12187] Do not make clickable when using as contact field
  [ticket/12187] Split generate_profile_fields_template() into 2 methods
  [ticket/12187] Remove user_website field
  [ticket/12187] Remove user_website functionality
  [ticket/12187] Convert website field data to custom profile field
  [ticket/12187] Add URL type for profile fields
  [ticket/12234] Replace ICQ with custom profile field
  [ticket/12233] Update schema file
  [ticket/12233] Add images back to subsilver2
  [ticket/12233] Allow profile fields to be contact fields

Conflicts:
	phpBB/adm/style/acp_prune_users.html
2014-03-05 11:49:11 +01:00
Nils Adermann
4e144005f0 Merge pull request #2057 from nickvergessen/ticket/12226
Ticket/12226 Split language strings to correctly allow multiple plural rules
2014-03-05 11:31:38 +01:00
Matt Friedman
03492e6211 [ticket/12248] Make extension details homepage a clickable link
http://tracker.phpbb.com/browse/PHPBB3-12248

PHPBB3-12248
2014-03-04 15:49:33 -08:00
Crizzo
60ca7f91e2 [ticket/8785] Adds two <hr /> to seperate recipients and BCC
PHPBB3-8785
2014-03-04 10:26:22 +01:00
Joas Schilling
83a7e632b9 [ticket/12235] Convert WLM to custom profile field
PHPBB3-12235
2014-03-04 10:19:08 +01:00
Joas Schilling
03ef39c1f1 [ticket/12187] Do not make clickable when using as contact field
PHPBB3-12187
2014-03-04 09:10:57 +01:00
Joas Schilling
c650078904 [ticket/12187] Split generate_profile_fields_template() into 2 methods
Removing the mode switch that wraps the content of the method

PHPBB3-12187
2014-03-04 08:47:47 +01:00
Joas Schilling
a3627a9ff7 [ticket/12187] Remove user_website field
PHPBB3-12187
2014-03-04 08:25:36 +01:00
Andreas Fischer
9c11f4a3cf Merge pull request #2083 from hjpotter92/ticket/12245
[ticket/12245] Fix id attributes in acp_prune_users.html

* hjpotter92/ticket/12245:
  [ticket/12245] Fix id attributes in acp_prune_users.html
2014-03-03 23:43:06 +01:00
hjpotter92
c82f59b5ab [ticket/12245] Fix id attributes in acp_prune_users.html
The following labels had invalid id references:
1. joined (renamed to link to joined_after)
2. group_id (create teh id attribute on select box)

PHPBB3-12245
2014-03-04 03:41:45 +05:30
Crizzo
837a909f8c [ticket/8785] Scrollbar to Reciepients and BCC with max-height: 200px
PHPBB3-8785
2014-03-03 21:23:58 +01:00
Crizzo
2d7e76013f [ticket/8785] Little spaces mistake
PHPBB3-8785
2014-03-03 21:15:56 +01:00
Crizzo
d40fb32dcd [ticket/8785] Rebuilding posting_editor pm head + new language vars
PHPBB3-8785
2014-03-03 21:11:06 +01:00
Joas Schilling
5b1fbfb2f2 [ticket/12187] Remove user_website functionality
PHPBB3-12187
2014-03-03 20:01:19 +01:00
Crizzo
19fbd1699a [ticket/12240] fontsize => size; fontcolor => color and added bbcode- in96
PHPBB3-12240
2014-03-03 18:34:53 +01:00
Matt Friedman
321d430dba [ticket/12244] Rename link to Extensions Manager in the ACP
PHPBB3-12244
2014-03-03 08:21:01 -08:00
rxu
efe4393c91 [ticket/12231] Add template events to forumlist_body.html
Add events before/after category header, before/after subforums list
to allow add/modify content in respective places.

PHPBB3-12231
2014-03-03 20:51:06 +08:00
Joas Schilling
e750d71f84 [ticket/12187] Convert website field data to custom profile field
PHPBB3-12187
2014-03-03 12:38:55 +01:00
Joas Schilling
a2f2629e2a [ticket/12187] Add URL type for profile fields
PHPBB3-12187
2014-03-03 12:30:07 +01:00
Joas Schilling
3e52d780ba [ticket/12243] Remove outdated adm/style/custom_profile_fields.html
PHPBB3-12243
2014-03-03 12:16:22 +01:00
Joas Schilling
a506e21fa7 [ticket/12243] Split custom_profile_fields.html into 1 file for each type
PHPBB3-12243
2014-03-03 12:15:09 +01:00
Joas Schilling
b01a0fe7c5 Merge remote-tracking branch 'vsephpbb/ticket/11645' into develop
* vsephpbb/ticket/11645:
  [ticket/11645] Rename .MODs tab in ACP to Extensions
2014-03-02 23:56:29 +01:00
Cesar G
9dee0647bf Merge remote-tracking branch 'Crizz0/ticket/9255' into develop
* Crizz0/ticket/9255:
  [ticket/9255] Changed overflow-x to overflow-y
  [ticket/9255] Added max-height and overflow-x to cp-mini in cp.css
2014-03-02 14:24:07 -08:00
Cesar G
bb09cebb88 Merge remote-tracking branch 'Crizz0/ticket/12126' into develop
* Crizz0/ticket/12126:
  [ticket/12126] deleted left:0 and right:0 in responsive.css .phpbb_alert
  [ticket/12126] left:0 and right: 0; admin.css --> width: auto
  [ticket/12126] Changed .phpbb_alert "max-width: 640px" to "width: 620px"
  [ticket/12126] Fixed position of alert box in IE
2014-03-02 14:23:25 -08:00
Crizzo
8db5db64c9 [ticket/12126] deleted left:0 and right:0 in responsive.css .phpbb_alert
PHPBB3-12126
2014-03-02 23:13:45 +01:00
Crizzo
50e4cac5de [ticket/12126] left:0 and right: 0; admin.css --> width: auto
PHPBB3-12126
2014-03-02 22:41:38 +01:00
Crizzo
2f31e79445 [ticket/9255] Changed overflow-x to overflow-y
PHPBB3-9255
2014-03-02 21:31:08 +01:00
Crizzo
8e3b13d5c5 [ticket/9255] Added max-height and overflow-x to cp-mini in cp.css
PHPBB3-9255
2014-03-02 20:59:59 +01:00
Matt Friedman
87fa7b98cc [ticket/11645] Rename .MODs tab in ACP to Extensions
http://tracker.phpbb.com/browse/PHPBB3-11645

PHPBB3-11645
2014-03-02 11:58:26 -08:00
Oliver Schramm
a88366f4b6 [ticket/11693] Change sql_build_array to support DELETE
PHPBB3-11693
2014-03-02 20:51:00 +01:00
Crizzo
4970934475 [ticket/12240] Added template changes for subsilver2, too
PHPBB3-12240
2014-03-02 20:45:05 +01:00
Crizzo
281df15a53 [ticket/12240] Added class code for custom bbcodes based on bbcode_tag
PHPBB3-12240
2014-03-02 20:30:09 +01:00
Crizzo
046b1b9d98 [ticket/12240] Added specific class name to posting buttons
PHPBB3-12240
2014-03-02 19:52:44 +01:00
Crizzo
f997d98a2a [ticket/12126] Changed .phpbb_alert "max-width: 640px" to "width: 620px"
PHPBB3-12126
2014-03-02 18:43:31 +01:00
Crizz0
e97b0e16e0 [ticket/12126] Fixed position of alert box in IE
PHPBB3-12126
2014-03-02 18:10:48 +01:00
Henry Sudhof
b993fa54a5 [ticket/9725] Add dummy indexes for Azure
SQL Azure requires a primary AKA clustered key on every table.
This adds a dummy INT column to act as key,
avoiding possible duplicate entries.
so that these columns can support bigger (speak: huge) tables

PHPBB3-9725
2014-03-01 21:03:25 -06:00
Henry Sudhof
fd4f973440 [ticket/9725] Create an Azure SQL compatible Schema
Two problems were encountered when installing on AzureSQL:
-Azure SQL does not support the ON clause of T-SQL
-Azure SQL requries a clustered index AKA primary key on all tables

The fix is makeshift; it introduces questionable primary indices, which should be replaced with auto--increment columns.

PHPBB3-9725
2014-03-01 20:59:11 -06:00
Nathan Guse
6152d6c41e Merge pull request #2065 from prototech/ticket/12232
[ticket/12232] Remove excessive calls to sizeof() in assign_block_vars() method.
2014-03-01 15:20:21 -06:00
Joas Schilling
08ed4d2c67 Merge remote-tracking branch 'rxu3/ticket/12222' into develop
* rxu3/ticket/12222:
  [ticket/12222] Replace hardoded comma with translatable separator
2014-03-01 21:42:23 +01:00
Joas Schilling
79c36c885a Merge remote-tracking branch 'prototech/ticket/12238' into develop
* prototech/ticket/12238:
  [ticket/12238] Remove defunct confirmation box template code.
2014-03-01 19:27:58 +01:00
Joas Schilling
d636cb0fc9 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11509] Exit with the expected (non-zero) exit status on failure.
  [ticket/11509] Output which commit is being inspected.
  [ticket/11509] Three dots means sym. difference, but we only want new commits.

Conflicts:
	.travis.yml
2014-03-01 19:16:58 +01:00
Cesar G
6d1b0d41f1 [ticket/12238] Remove defunct confirmation box template code.
Confirmation boxes are handled by confirm_body.html.

PHPBB3-12238
2014-03-01 10:15:26 -08:00
Joas Schilling
9f4908f0f2 Merge remote-tracking branch 'bantu/ticket/11509' into develop-olympus
* bantu/ticket/11509:
  [ticket/11509] Exit with the expected (non-zero) exit status on failure.
  [ticket/11509] Output which commit is being inspected.
  [ticket/11509] Three dots means sym. difference, but we only want new commits.
2014-03-01 19:13:58 +01:00
Joas Schilling
e9ed9cd942 Merge branch 'develop-olympus' into develop
* develop-olympus:
2014-03-01 19:13:07 +01:00
Joas Schilling
76409388af [ticket/12234] Replace ICQ with custom profile field
PHPBB3-12234
2014-02-28 15:24:35 +01:00
Joas Schilling
f2c208fa7f [ticket/12233] Update schema file
PHPBB3-12233
2014-02-28 15:13:46 +01:00
Joas Schilling
43040dd6a4 [ticket/12233] Add images back to subsilver2
PHPBB3-12233
2014-02-28 15:08:15 +01:00
Joas Schilling
a823205403 [ticket/12233] Allow profile fields to be contact fields
Contact fields are displayed with in the contact section of the user profile
and are displayed differently in the mini profile next to posts and private
messages

PHPBB3-12233
2014-02-28 14:38:03 +01:00
Cesar G
99db2d9199 [ticket/12232] Fix a similar excessive pattern in the method.
PHPBB3-12232
2014-02-27 22:28:43 -08:00
Cesar G
5c3fc4840c [ticket/12232] Remove excessive calls to sizeof() in assign_block_vars() method
The size of the template block array is calculated within a foreach loop
iterating through the array, which is unnecessary. It only needs to be done
once. In a block of 1000 rows, this results in
500,500 calls to sizeof() in this location. With this change, that's reduced to
1000.

PHPBB3-12232
2014-02-27 19:29:02 -08:00
Nils Adermann
620f2840d7 Merge pull request #2062 from nickvergessen/ticket/12194
[ticket/12194] Ensure that field_show_novalue is present
2014-02-27 15:07:51 +01:00
Joas Schilling
de0b7ddce9 [ticket/12194] Ensure that field_show_novalue is present
The field was not created on boards that were 3.1-dev before 3.0.11 was relesed

PHPBB3-12194
2014-02-27 10:00:36 +01:00
Nils Adermann
f99cce0f44 Merge pull request #2060 from nickvergessen/ticket/12205-develop
[ticket/12205-Develop] Do not display 0 for empty integers when show_novalue is off
2014-02-26 11:49:32 +01:00
Nils Adermann
05d921fbbc Merge pull request #2059 from nickvergessen/ticket/12205
[ticket/12205] Do not display 0 for empty integers when show_novalue is off
2014-02-25 19:48:54 +01:00
Joas Schilling
ae98810ddc Merge remote-tracking branch 'nickvergessen/ticket/12205' into ticket/12205-develop
* nickvergessen/ticket/12205:
  [ticket/12205] Do not display 0 for empty integers when show_novalue is off

Conflicts:
	phpBB/includes/functions_profile_fields.php
2014-02-25 18:35:03 +01:00
Joas Schilling
ffbc7ccb64 [ticket/12205] Do not display 0 for empty integers when show_novalue is off
PHPBB3-12205
2014-02-25 18:24:45 +01:00
Joas Schilling
3930978e64 [ticket/12216] Undefined index: lang_options when creating date profile field
PHPBB3-12216
2014-02-24 10:00:45 +01:00
Joas Schilling
bd00b8e9bf [ticket/12227] "X from Y messages" should be "X out of Y messages"
PHPBB3-12227
2014-02-24 09:48:36 +01:00
Joas Schilling
87dfd76100 [ticket/12226] Split language strings to correctly allow multiple plural rules
PHPBB3-12226
2014-02-24 09:46:31 +01:00
rxu
dda775c418 [ticket/12224] Add template wrapper method to assign block arrays
Add one more wrapper template method for the function assign_block_vars() which
takes a 2-dimensional array as a parameter
and calls assign_block_vars() in a loop to assign the whole block loop at once.
This can make the core a little bit more expendable from the point of
developing extensions as it allows to pass the data to events before
it's being assigned to template.

PHPBB3-12224
2014-02-23 22:04:35 +08:00
rxu
aa8f43b356 [ticket/12222] Replace hardoded comma with translatable separator
Replace hardoded comma with translatable separator
in forumlist_body.html.

PHPBB3-12222
2014-02-23 21:04:35 +08:00
Cesar G
249b9dcdb5 [ticket/12160] Use phpbb_check_installation_exists() in the other modules.
PHPBB3-12160
2014-02-22 20:23:30 -08:00
Cesar G
fc33a0c176 [ticket/12160] Move phpbb_check_installation_exists() to functions_install.php
PHPBB3-12160
2014-02-22 20:22:36 -08:00
rxu
82e3f5a768 [ticket/12213] Add MCP events for custom quick moderation options
Addition to PR #2045 - rename the flag variable to more sensible one.

PHPBB3-12213
2014-02-23 01:33:34 +08:00
Andreas Fischer
4b7932e8b3 Merge pull request #2053 from prototech/ticket/12220
[ticket/12220] Fix division by zero in search page with no results.

* prototech/ticket/12220:
  [ticket/12220] Fix division by zero in search page with no results.
2014-02-21 22:12:51 +01:00
Cesar G
888a059994 [ticket/12220] Fix division by zero in search page with no results.
The page url parameter no longer exists in the pagination.on_page() method,
therefore the page url passed is being divided by 0 - the total number of
items. Since PAGE_NUMBER is assigned in generate_template_pagination(), this
separate assignment is no longer needed.

PHPBB3-12220
2014-02-21 12:36:26 -08:00
Nathan Guse
c0c19fbb29 Merge pull request #2035 from prototech/ticket/12138
[ticket/12138] Include file time limit when generating attachment management pagination and stats.
2014-02-20 21:13:06 -06:00
Nathan Guse
736d11225c Merge pull request #1939 from prototech/ticket/12078
[ticket/12078] Check for f_delete when a user attempts to permanently delete a post.
2014-02-20 21:04:52 -06:00
Nathan Guse
4f6b9080e8 Merge pull request #2037 from prototech/ticket/12080
[ticket/12080] Fix color palettes when responsive.
2014-02-20 20:59:14 -06:00
Nathan Guse
2df2032b48 Merge pull request #2025 from marc1706/ticket/12183
[ticket/12183] Update user_newpasswd column in users table for passwords manager
2014-02-20 20:54:30 -06:00
Nathan Guse
b8d30bfc80 Merge pull request #2021 from nickvergessen/ticket/12171
Ticket/12171 Attachments from soft-deleted posts are still downloadable
2014-02-20 20:51:58 -06:00
Andreas Fischer
42e8c2e8cf [ticket/11509] Exit with the expected (non-zero) exit status on failure.
PHPBB3-11509
2014-02-21 01:48:55 +01:00
Andreas Fischer
fe5858902e [ticket/11509] Output which commit is being inspected.
PHPBB3-11509
2014-02-21 01:47:45 +01:00
Andreas Fischer
ccd30912d9 [ticket/11509] Three dots means sym. difference, but we only want new commits.
PHPBB3-11509
2014-02-21 01:47:37 +01:00
Nathan Guse
92cf69abec Merge branch 'ticket/12139' into develop
* ticket/12139:
  [ticket/12139] Spaces $ show_guests viewonline.php
2014-02-20 17:03:42 -06:00
karan
20625e896b [ticket/12139] Spaces $ show_guests viewonline.php
PHPBB3-12139
2014-02-20 17:02:50 -06:00
Nathan Guse
cadf0dd3fd Merge pull request #2050 from rxu/ticket/12217
[ticket/12217] Add more template events to viewtopic_body.html
2014-02-20 10:32:45 -06:00
rxu
6d9afcd077 [ticket/12217] Add more template events to viewtopic_body.html
Add viewtopic template events before/after the posts,
after the sorting options to allow adding contents to
respective places (like advertisement and so on).

PHPBB3-12217
2014-02-21 00:27:47 +08:00
Nathan Guse
2ffca79c0e Merge pull request #2044 from prototech/ticket/12212
[ticket/12212] Encode the attachment file name before presenting to user.
2014-02-20 10:18:22 -06:00
Nathan Guse
169b1cf6cb Merge pull request #2049 from prototech/ticket/12200
[ticket/12200] Add missing profile field template files to adm/style/ directory.
2014-02-20 10:15:15 -06:00
Cesar G
55b38e8003 [ticket/12200] Add missing profile field template files to adm/style/ directory
PHPBB3-12200
2014-02-19 22:08:36 -08:00
Nathan Guse
6c8589775b [ticket/9871] Update version check file to use json format
PHPBB3-9871
2014-02-19 16:13:23 -06:00
Nathan Guse
e56f562d47 Merge pull request #2047 from prototech/ticket/12153
[ticket/12153] Replace old template variables with {PAGE_NUMBER}.
2014-02-19 15:27:00 -06:00
Cesar G
f43dedb3fd [ticket/12153] Replace old template variables with {PAGE_NUMBER}.
PHPBB3-12153
2014-02-19 13:16:58 -08:00
Marc Alexander
92f1980377 [ticket/12183] Check if database columns were updated before changing them
PHPBB3-12183
2014-02-19 18:59:45 +01:00
Nathan Guse
60de5e66de Merge pull request #2030 from rxu/ticket/12190
Add core event "core.modify_submit_post_data"
2014-02-19 10:50:21 -06:00
rxu
01bf27f789 [ticket/12190] Add core event "core.modify_submit_post_data"
Add core event - core.modify_submit_post_data
to submit_post() function. This allows extensions to modify the
whole post data before the post submitting, or even provide
its own post submit procedure.

PHPBB3-12190
2014-02-20 00:47:26 +08:00
Nathan Guse
c30668b010 Merge pull request #2045 from rxu/ticket/12213
[ticket/12213] Add MCP events for custom quick moderation options
2014-02-19 10:42:17 -06:00
rxu
b7dea19bf3 [ticket/12213] Add MCP events for custom quick moderation options
Add core events to mcp.php and mcp_main.php. This allows
extensions to add and to handle custom quick moderation options.

PHPBB3-12213
2014-02-20 00:38:28 +08:00
Nathan Guse
bd8951cfbe Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12093] Check that document.selection is supported.

Conflicts:
	phpBB/adm/style/editor.js
	phpBB/assets/javascript/editor.js
	phpBB/styles/prosilver/template/editor.js
2014-02-19 09:23:02 -06:00
Nathan Guse
823dca737f Merge remote-tracking branch 'remotes/prototech/ticket/12093' into develop-olympus
* remotes/prototech/ticket/12093:
  [ticket/12093] Check that document.selection is supported.
2014-02-19 09:06:57 -06:00
Nathan Guse
eaf9a41ed8 Merge pull request #1994 from prototech/ticket/12158
[ticket/12158] The pagination start value should be 0 when there are no items.
2014-02-18 14:25:46 -06:00
Nathan Guse
7015fc8a00 Merge pull request #2002 from prototech/ticket/12153
[ticket/12153] Assign PAGE_NUMBER in pagination.generate_template_pagination()
2014-02-18 14:11:48 -06:00
Cesar G
c7efadc26d [ticket/12153] Remove duplicate assignment of $u_previous_page & $u_next_page.
PHPBB3-12153
2014-02-18 12:04:31 -08:00
Nathan Guse
74d2d6c66a Merge pull request #2027 from lucifer4o/ticket/12177
[ticket/12177] Add ucp_friend_list_before/after
2014-02-18 12:36:55 -06:00
Nils Adermann
7a21d99b9b Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12210] dbtools::sql_create_table incorrectly throws error related to auto-increment length on non auto-increment fields
2014-02-18 19:34:08 +01:00
Nils Adermann
14017b7032 Merge remote-tracking branch 'github-exreaction/ticket/12210' into develop-olympus
* github-exreaction/ticket/12210:
  [ticket/12210] dbtools::sql_create_table incorrectly throws error related to auto-increment length on non auto-increment fields
2014-02-18 19:33:36 +01:00
Nathan Guse
061d9fba5a Merge pull request #2038 from prototech/ticket/12206
[ticket/12206] Fix mismatched Plupload language vars preventing localization.
2014-02-18 12:29:17 -06:00
Nathan Guse
74836f8c64 Merge pull request #2040 from prototech/ticket/12208
[ticket/12208] Remove file from upload queue if deleted before being uploaded.
2014-02-18 12:28:20 -06:00
Nathan Guse
69c119485a Merge pull request #2007 from rxu/ticket/12166
Add template events before/after the textbox in quickreply_editor.html.
2014-02-18 12:27:43 -06:00
Nathan Guse
5fc29e0d2b Merge pull request #2008 from marc1706/ticket/12167
[ticket/12167] Allow users to change style via style parameter by default
2014-02-18 12:26:49 -06:00
Cesar G
627dc886b3 [ticket/12212] Encode the attachment file name before presenting to user.
The uploader inserts the file name directly into the page at the moment without
handling any HTML special chars that may be in the name. This results in HTML
that may be present getting rendered in error messages and the attachments
list. This simply causes layout breakage for the user, since the backend takes
care of sanitizing the name. Once phpBB returns the file data for the uploaded
file, the name in the attachment list gets replaced by the one that phpBB
provides.

PHPBB3-12212
2014-02-18 00:01:05 -08:00
Nathaniel Guse
602f4a2b54 [ticket/12210] dbtools::sql_create_table incorrectly throws error
related to auto-increment length on non auto-increment fields

PHPBB3-12210
2014-02-17 23:46:39 -06:00
rxu
cab8181af1 [ticket/12166] Add template events to quickreply_editor.html.
Add template event pair - quickreply_editor_message_before
and quickreply_editor_message_before to
quickreply_editor.html for both of prosilver and subsilver2 styles.
This allows extensions to modify quick reply
postform. For example, to add BBCode buttons and/or smilies
and so on.

PHPBB3-12166
2014-02-18 10:51:34 +08:00
Cesar G
233bdfa5f6 Merge remote-tracking branch 'Zoddo/ticket/12207' into develop
* Zoddo/ticket/12207:
  [ticket/12207] Forum broken when error thrown
2014-02-17 17:30:44 -08:00
Cesar G
1c56d28d9b [ticket/12208] Remove file from upload queue if deleted before being uploaded.
The table row is removed, but the files aren't actually removed from the
upload queue, so they get uploaded either way.

PHPBB3-12208
2014-02-17 15:11:24 -08:00
Marc Alexander
c82967d92b [ticket/12183] Test that login with old password doesn't work after reset
PHPBB3-12183
2014-02-17 23:43:53 +01:00
Zoddo
fb662ebf50 [ticket/12207] Forum broken when error thrown
Fix display of forum when error is outputted before <html> tag.

PHPBB3-12207
2014-02-17 21:58:39 +01:00
Cesar G
a589c88d25 [ticket/12206] Fix mismatched Plupload language vars preventing localization.
PHPBB3-12206
2014-02-17 12:33:19 -08:00
Cesar G
b3ecb9e1e4 Merge remote-tracking branch 'Zoddo/ticket/12003' into develop
* Zoddo/ticket/12003:
  [ticket/12003] ACP broken when error thrown
2014-02-17 10:27:23 -08:00
Zoddo
b942615c3b [ticket/12003] ACP broken when error thrown
Fix display of ACP when error is outputted before <html> tag.

PHPBB3-12003
2014-02-17 19:21:20 +01:00
Marc Alexander
f1c913f176 [ticket/12183] Move user_newpasswd, user_actkey below user_pass_convert
PHPBB3-12183
2014-02-17 16:28:36 +01:00
Marc Alexander
3cb702f4ab [ticket/12183] Test activating new password after reset
PHPBB3-12183
2014-02-17 16:18:56 +01:00
Cesar G
b8c836836b [ticket/12080] Stop responsive ACP sig textarea from dropping to second line.
PHPBB3-12080
2014-02-16 13:27:48 -08:00
Cesar G
bfbf0fefbf [ticket/12080] Reduce the palette options in all locations when responsive.
PHPBB3-12080
2014-02-16 13:27:01 -08:00
Cesar G
5ef55d9e45 [ticket/12080] Add classes to color palette table to identify it more easily.
PHPBB3-12080
2014-02-16 13:25:43 -08:00
Cesar G
3bdc1e9e1c [ticket/12138] Replace old code and generate pagination using filetime limit.
PHPBB3-12138
2014-02-16 10:21:10 -08:00
Cesar G
e4685ac80d [ticket/12138] Add methods for attachment manage functionality.
PHPBB3-12138
2014-02-16 10:21:02 -08:00
Cesar G
d6ec463977 [ticket/12160] Check if phpBB is installed before creating phpBB container.
PHPBB3-12160
2014-02-15 17:14:16 -08:00
Cesar G
d002d31b86 [ticket/12160] Add function to check if phpBB is installed.
PHPBB3-12160
2014-02-15 17:09:13 -08:00
Andreas Fischer
9f923f2359 Merge pull request #2032 from prototech/ticket/12192
[ticket/12192] Fix call to undefined method get_user_avatar().

* prototech/ticket/12192:
  [ticket/12192] Fix call to undefined method get_user_avatar().
2014-02-15 12:30:03 +01:00
Cesar G
d4affedaab [ticket/12192] Fix call to undefined method get_user_avatar().
PHPBB3-12192
2014-02-14 19:19:53 -08:00
Andreas Fischer
ccf12ba166 Merge pull request #1964 from prototech/ticket/12136
[ticket/12136] Use new pagination class in generate_smilies().

* prototech/ticket/12136:
  [ticket/12136] Use new pagination class in generate_smilies().
2014-02-15 02:35:19 +01:00
Andreas Fischer
8960e6d777 [ticket/12176] Display correct message when trying to delete founder.
PHPBB3-12176
2014-02-15 02:27:54 +01:00
Andreas Fischer
587241f3a9 [ticket/12176] Add functional test for founder deletion message.
PHPBB3-12176
2014-02-15 02:27:54 +01:00
Nils Adermann
06581ba927 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12188] Add php 5.6 to travis enviroments

Conflicts:
	.travis.yml
2014-02-13 15:43:31 +01:00
Nils Adermann
f245198652 Merge remote-tracking branch 'github-nickvergessen/ticket/12188' into develop-olympus
* github-nickvergessen/ticket/12188:
  [ticket/12188] Add php 5.6 to travis enviroments
2014-02-13 15:42:50 +01:00
lucifer4o
c20a313ab0 [ticket/12177] Add ucp_friend_list_before/after
Add events before and after list of friends in UCP template
Change Since part from a3 to a4

PHPBB3-12177
2014-02-13 16:23:42 +02:00
Joas Schilling
9d1d90e336 [ticket/12188] Add php 5.6 to travis enviroments
PHPBB3-12188
2014-02-13 14:47:51 +01:00
lucifer4o
89007db505 [ticket/12177] Add ucp_friend_list_before/after
Add events before and after list of friends in UCP template

PHPBB3-12177
2014-02-13 14:51:53 +02:00
Cesar G
13e7bd76a5 Merge remote-tracking branch 'vinny/ticket/12134' into develop
* vinny/ticket/12134:
  [ticket/12134] Add ucp_pm_viewmessage_print_head_append event to subsilver2
2014-02-12 18:39:39 -08:00
Cesar G
965b3365fe Merge remote-tracking branch 'vinny/ticket/12132' into develop
* vinny/ticket/12132:
  [ticket/12132] Add the event to events.md doc
  [ticket/12132] Add viewtopic_print_head_append event to subsilver2
2014-02-12 18:38:40 -08:00
Joas Schilling
75fa467b7b Merge remote-tracking branch 'bantu/ticket/12180' into develop
* bantu/ticket/12180:
  [ticket/12180] Add "Each file MUST end with exactly one newline character" rule
2014-02-12 22:12:30 +01:00
Andreas Fischer
0888df9520 Merge pull request #2026 from nickvergessen/ticket/12184
[ticket/12184] Fix undefined variable tpl_fields in profile field manager

* nickvergessen/ticket/12184:
  [ticket/12184] Fix undefined variable tpl_fields in profile field manager
2014-02-11 20:04:22 +01:00
Joas Schilling
30fbaab8de [ticket/12184] Fix undefined variable tpl_fields in profile field manager
PHPBB3-12184
2014-02-11 19:17:24 +01:00
Marc Alexander
4c62cb4989 [ticket/12183] Make sure to undo changes to config in forgot_password_test
The forgot_password_test disables the password reset functionalty but doesn't
enable it again afterwards.

PHPBB3-12183
2014-02-11 08:24:49 +01:00
Nils Adermann
0b2b76f951 Merge pull request #2010 from nickvergessen/ticket/12169
Ticket/12169  Convert location user field to profile field
2014-02-11 02:18:16 +01:00
Marc Alexander
488bd1a1b1 [ticket/12183] Add functional test for user password reset
PHPBB3-12183
2014-02-10 22:37:28 +01:00
Marc Alexander
c864d06ac6 [ticket/12183] Add migration file for updating user_newpasswd column
PHPBB3-12183
2014-02-10 22:10:31 +01:00
Marc Alexander
5ce0bb7630 [ticket/12183] Update user_newpasswd column to length of 255 in schema files
PHPBB3-12183
2014-02-10 22:06:42 +01:00
Joas Schilling
5550f0fa87 [ticket/12169] Split mode==headline into it's own function
PHPBB3-12169
2014-02-10 19:04:10 +01:00
Joas Schilling
995019a992 [ticket/12169] Add new option to display profile fields on memberlist
PHPBB3-12169
2014-02-10 16:28:21 +01:00
Joas Schilling
3c46aeb005 [ticket/12169] Allow displaying profile fields on memberlist
We can not sort by profile field values atm. And also I'm not sure
whether this is possible at all.

PHPBB3-12169
2014-02-10 15:58:55 +01:00
Andreas Fischer
1e86f71133 [ticket/12180] Add "Each file MUST end with exactly one newline character" rule
PHPBB3-12180
2014-02-10 15:01:50 +01:00
Joas Schilling
6bee91c429 [ticket/12169] Convert user_from to profile field location
Missing changes on memberlist view due to missing functionality

PHPBB3-12169
2014-02-10 14:38:43 +01:00
Joas Schilling
b088bf864b Merge remote-tracking branch 'Marc/ticket/12170' into develop
* Marc/ticket/12170:
  [ticket/12170] Test for 12170
  [ticket/12170] Assign schema keys in migration helper with data_depth 1
2014-02-10 14:23:09 +01:00
Nils Adermann
840ab75520 Merge pull request #1988 from nickvergessen/ticket/12115
[ticket/12115] Convert occupation profile field to custom field
2014-02-10 13:52:12 +01:00
Joas Schilling
09a17b4944 [ticket/12171] Add functional tests for downloading attachments
PHPBB3-12171
2014-02-10 12:56:46 +01:00
Joas Schilling
b5105363db [ticket/12171] Add functionality to upload attachments to submit_post() method
PHPBB3-12171
2014-02-10 12:56:46 +01:00
Joas Schilling
ee1c055b70 [ticket/12171] Send correct status 403 when forbidden and 404 when not found
PHPBB3-12171
2014-02-10 12:56:45 +01:00
Joas Schilling
c36b1c16f9 [ticket/12171] Check post visibility before being able to download attachments
PHPBB3-12171
2014-02-10 12:56:41 +01:00
Joas Schilling
e4129687cb [ticket/12171] Split post and pm download links
PHPBB3-12171
PHPBB3-12172
2014-02-10 12:37:10 +01:00
Joas Schilling
8744b0da6d [ticket/12171] Check topic visibility before allowing to download attachments
PHPBB3-12171
2014-02-10 12:36:01 +01:00
Andreas Fischer
02674de893 Merge pull request #2022 from nickvergessen/ticket/12175
Ticket/12175 Fix and run functional upload tests

* nickvergessen/ticket/12175:
  [ticket/12175] Do not use admin account for file size limit test
  [ticket/12175] Fix test for uploading a valid file
  [ticket/12175] Fix upload test for empty file
2014-02-10 02:16:27 +01:00
Joas Schilling
1fdd01275e [ticket/12175] Do not use admin account for file size limit test
PHPBB3-12175
2014-02-09 23:48:34 +01:00
Joas Schilling
07f19647f4 [ticket/12175] Fix test for uploading a valid file
PHPBB3-12175
2014-02-09 23:47:20 +01:00
Joas Schilling
ff57ecf0bc [ticket/12175] Fix upload test for empty file
PHPBB3-12175
2014-02-09 23:45:41 +01:00
Andreas Fischer
eb2d8fe6d8 Merge pull request #2017 from nickvergessen/ticket/12141
[ticket/12141] Disable opcache on travis for php 5.5.8 aswell

* nickvergessen/ticket/12141:
  [ticket/12141] Disable opcache on travis for php 5.5.8 aswell
2014-02-08 14:00:30 +01:00
Joas Schilling
81c6ca7e4c [ticket/12141] Disable opcache on travis for php 5.5.8 aswell
PHPBB3-12141
2014-02-08 12:52:22 +01:00
Marc Alexander
9b1b6bd477 Merge remote-tracking branch 'exreaction/ticket/12170' into ticket/12170 2014-02-07 22:35:04 +01:00
Nathan Guse
344fde7f06 [ticket/12170] Test for 12170
PHPBB3-12170
2014-02-07 14:37:45 -06:00
Marc Alexander
e8f8dcf0ea [ticket/12170] Assign schema keys in migration helper with data_depth 1
The migration helper currently drops any keys with schema changes that have
the data_depth 1. This change will correctly assign the keys to the steps
array without dropping the keys that might contain important info like the
actual table that should be created.

PHPBB3-12170
2014-02-07 21:13:50 +01:00
Joas Schilling
4663ea7c82 [ticket/12115] Remove space from line ending
PHPBB3-12115
2014-02-06 14:18:30 +01:00
Joas Schilling
26640bad3d [ticket/12115] Add migration file to remove old user columns
PHPBB3-12115
2014-02-06 11:32:13 +01:00
Joas Schilling
190301021b [ticket/12115] Use base class to reduce duplicate code
PHPBB3-12115
2014-02-06 11:32:12 +01:00
Joas Schilling
c2cf294be5 [ticket/12115] Add a new migration for profilefield_interests
With this we avoid missing to copy one, when the admin already created
a phpbb_* profile field.

PHPBB3-12115
2014-02-06 11:32:12 +01:00
Joas Schilling
bbada27ee9 [ticket/12115] Also port user interests to profile fields
PHPBB3-12115
2014-02-06 11:32:11 +01:00
Joas Schilling
0ad726768c [ticket/12115] Remove old language strings
PHPBB3-12115
2014-02-06 11:32:09 +01:00
Joas Schilling
8dab016a7b [ticket/12115] Add methods to interface
PHPBB3-12115
2014-02-06 11:32:09 +01:00
Joas Schilling
f97d268a79 [ticket/12115] Translate profile field name before displaying it in errors
PHPBB3-12115
2014-02-06 11:32:08 +01:00
Joas Schilling
38608bfa62 [ticket/12115] Remove occupation field from html files
PHPBB3-12115
2014-02-06 11:32:07 +01:00
Joas Schilling
7d04961919 [ticket/12115] Add language entries for the profile fields
PHPBB3-12115
2014-02-06 11:32:06 +01:00
Joas Schilling
3c640e57c5 [ticket/12115] Convert user occupation to a profile field
PHPBB3-12115
2014-02-06 11:32:06 +01:00
Marc Alexander
8a96e0bc52 [ticket/12167] Allow users to change style via style parameter by default
This change will enable users that don't have the a_styles permission to
preview styles using the style parameter. Using this, they will be able to
use extensions that are or incorporate stylechangers.

PHPBB3-12167
2014-02-06 00:25:48 +01:00
Joas Schilling
344baf9180 Merge branch 'prep-release-3.1.0-a3' into develop 2014-02-05 22:25:45 +01:00
Joas Schilling
bf93e20afb [prep-release-3.1.0-a3] Update version to 3.1.0-a4-dev for future development 2014-02-05 22:23:33 +01:00
Nils Adermann
32bc5d72e4 Merge pull request #1995 from EXreaction/ticket/11880
Schema changes can take too long and cause a timeout
2014-02-05 17:52:17 +01:00
Nathan Guse
be28445b66 [ticket/11880] migration helper file
PHPBB3-11880
2014-02-05 10:00:01 -06:00
Joas Schilling
11d5f49adb [prep-release-3.1.0-a3] Commit changelog for 3.1.0-a3 2014-02-05 16:58:05 +01:00
Nathan Guse
38eb6b0e13 [ticket/11880] Move get_schema_steps function to a migrator helper class
PHPBB3-11880
2014-02-05 09:57:36 -06:00
Joas Schilling
36c41d8848 [prep-release-3.1.0-a3] Prepare Changelog 2014-02-05 16:55:21 +01:00
Joas Schilling
7f70a73634 [prep-release-3.1.0-a3] Add migration for 3.1.0-a3 2014-02-05 16:55:21 +01:00
Joas Schilling
127c0c4493 [prep-release-3.1.0-a3] Update version to 3.1.0-a3 2014-02-05 16:55:21 +01:00
Andreas Fischer
0b6b7fc486 Merge pull request #2004 from prototech/ticket/12163
[ticket/12163] Use posts_per_page to calculate current page in viewtopic.php

* prototech/ticket/12163:
  [ticket/12163] Use posts_per_page to calculate current page in viewtopic.php
2014-02-04 17:40:57 +01:00
Cesar G
32ddbf374f [ticket/12163] Use posts_per_page to calculate current page in viewtopic.php
PHPBB3-12163
2014-02-04 07:15:15 -08:00
Nils Adermann
f5f6b834f8 [develop] Remove left over conflict marker from merge 1a31f03 2014-02-04 16:01:49 +01:00
Cesar G
5e1db72532 [ticket/12158] Add test data for 0 items to validate_start() test.
PHPBB3-12158
2014-02-04 05:55:47 -08:00
Nils Adermann
1a31f03a7b Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12162] Set language to C before running diff to ensure its english
  [ticket/11509] Be exact when referencing the branch name.
  [ticket/12161] Do not use subdirectories in build/save directory.
  [ticket/11509] Run commit message checker only in one environment.
  [ticket/11509] Contrary to docs, COMMIT_RANGE is not available in PR mode.

Conflicts:
	.travis.yml
2014-02-04 13:05:20 +01:00
Nils Adermann
c955d01456 Merge remote-tracking branch 'github-nickvergessen/ticket/12162' into develop-olympus
* github-nickvergessen/ticket/12162:
  [ticket/12162] Set language to C before running diff to ensure its english
2014-02-04 13:03:02 +01:00
Joas Schilling
aae4d4c90d [ticket/12162] Set language to C before running diff to ensure its english
PHPBB3-12162
2014-02-04 12:32:25 +01:00
Nils Adermann
39b9274a94 Merge pull request #2001 from bantu/ticket/12161
[ticket/12161] Do not use subdirectories in build/save directory.
2014-02-04 02:59:52 -08:00
Nils Adermann
2dc2476070 Merge pull request #1999 from bantu/ticket/11509
[ticket/11509] Further improvements/fixes for the Travis CI commit message checker
2014-02-04 02:59:11 -08:00
Nils Adermann
db9fd30e7c Merge pull request #1998 from bantu/ticket/12141
[ticket/12141] Disable opcache extension on PHP 5.5.7
2014-02-04 02:57:35 -08:00
Cesar G
151c05e92e [ticket/12158] The pagination start value should be 0 when there are no items.
PHPBB3-12158
2014-02-03 23:34:22 -08:00
Cesar G
5f9d54646f [ticket/12153] Adjust pagination tests.
PHPBB3-12153
2014-02-03 23:00:39 -08:00
Cesar G
1251b68668 [ticket/12153] Remove redundant calls to pagination.on_page().
PHPBB3-12153
2014-02-03 23:00:39 -08:00
Cesar G
f22e51c8a1 [ticket/12153] Remove vars already assigned in generate_template_pagination().
PHPBB3-12153
2014-02-03 23:00:34 -08:00
Cesar G
06e9959648 [ticket/12153] Assign PAGE_NUMBER in pagination.generate_template_pagination()
PHPBB3-12153
2014-02-03 22:52:38 -08:00
Andreas Fischer
33593a508c [ticket/11509] Be exact when referencing the branch name.
PHPBB3-11509
2014-02-04 02:18:46 +01:00
Andreas Fischer
cb544ed7ae [ticket/12141] Disable broken opcache extension on PHP 5.5.7.
PHPBB3-12141
2014-02-04 02:16:36 +01:00
Andreas Fischer
ac954a7c4b [ticket/12141] PHP extension setup must happen before webserver + PHP-FPM.
PHPBB3-12141
2014-02-04 02:16:00 +01:00
Andreas Fischer
78116a5298 [ticket/12161] Do not use subdirectories in build/save directory.
This is pretty much pointless because a new build will wipe the save directory
and there are only a few files in there anyway.

PHPBB3-12161
2014-02-04 02:07:45 +01:00
Nathan Guse
68b5a2b6b2 [ticket/11716] Rename migration files and add note that it's converting a MOD
PHPBB3-11716
2014-02-03 18:09:34 -06:00
Andreas Fischer
b6d45c5d71 [ticket/11985] Do not try to setup PHP extensions on HHVM.
PHPBB3-11985
2014-02-04 00:13:36 +01:00
Andreas Fischer
116ff19185 [ticket/11985] Rename install -> setup. This is more generic and consistent.
PHPBB3-11985
2014-02-04 00:12:28 +01:00
Andreas Fischer
5069922e24 [ticket/11509] Run commit message checker only in one environment.
PHPBB3-11509
2014-02-03 23:50:48 +01:00
Andreas Fischer
6f727bc0f9 [ticket/11509] Contrary to docs, COMMIT_RANGE is not available in PR mode.
PHPBB3-11509
2014-02-03 23:44:15 +01:00
Andreas Fischer
d50b8df364 Merge pull request #1997 from marc1706/ticket/12159
[ticket/12159] Fix codesniffer complaints due to profilefields and passwords

* marc1706/ticket/12159:
  [ticket/12159] Fix codesniffer complaints due to profilefields and passwords
2014-02-03 22:33:51 +01:00
Marc Alexander
6f92996d98 [ticket/12159] Fix codesniffer complaints due to profilefields and passwords
The two PRs regarding profilefields and passwords manager that were recently
merged caused a few codesniffer complaints that are fixed by these changes.

PHPBB3-12159
2014-02-03 22:25:43 +01:00
Nathan Guse
2c878ead31 [ticket/11880] Break up schema changes in the migrator
PHPBB3-11880
2014-02-03 15:07:57 -06:00
Nathan Guse
ad2d1fcbcb Merge pull request #1942 from nickvergessen/ticket/11996
[ticket/11996] Add explanation how to correctly remove and update an extension
2014-02-03 11:49:24 -08:00
Joas Schilling
c7f6cccdf1 [ticket/11996] Remove note until we really do disable the board
PHPBB3-11996
2014-02-03 20:48:01 +01:00
Nathan Guse
2cc6d03cca Merge pull request #1991 from marc1706/ticket/12156
[ticket/12156] Add missing passwords manager to oauth
2014-02-03 09:57:59 -08:00
Marc Alexander
2c9e6f196b [ticket/12156] Add missing passwords manager to oauth
PHPBB3-12156
2014-02-03 18:08:13 +01:00
Nathan Guse
2fa491f965 Merge pull request #1993 from bantu/ticket/11509-develop
[ticket/11509] Perform commit message checking after PHPUnit (fixes path...
2014-02-03 08:31:41 -08:00
Andreas Fischer
1594c09971 [ticket/11509] Perform commit message checking after PHPUnit (fixes path).
PHPBB3-11509
2014-02-03 17:19:35 +01:00
Andreas Fischer
b16448b3f8 [ticket/11985] Don't try to install APC on PHP 5.5 or higher.
PHPBB3-11985
2014-02-03 16:53:15 +01:00
Nathan Guse
b5c1a52368 Merge pull request #1990 from nickvergessen/ticket/12154
[ticket/12154] Update schema files with lastest database schema
2014-02-03 07:51:02 -08:00
Nathan Guse
455d55d497 [ticket/11716] Convert Soft Delete Mod to post/topic visibility
PHPBB3-11716
2014-02-03 09:45:33 -06:00
Andreas Fischer
3b6542adf8 [ticket/11985] Enable APC on command line so it can be used by PHPUnit.
PHPBB3-11985
2014-02-03 15:33:46 +01:00
Andreas Fischer
a012293462 [ticket/11985] Reorganise travis/install-php-extensions.sh
PHPBB3-11985
2014-02-03 15:33:46 +01:00
Nils Adermann
1f93d940fd Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11509] Fail on Travis CI if commit messages are improperly formatted.

Conflicts:
	.travis.yml
2014-02-03 01:08:25 +01:00
Nils Adermann
32536880f4 Merge remote-tracking branch 'github-bantu/ticket/11509' into develop-olympus
* github-bantu/ticket/11509:
  [ticket/11509] Fail on Travis CI if commit messages are improperly formatted.
2014-02-03 01:07:19 +01:00
Joas Schilling
76708be47e [ticket/12154] Update schema files with lastest database schema
PHPBB3-12154
2014-02-02 22:05:58 +01:00
Nathan Guse
b88e070116 Merge pull request #1989 from nickvergessen/ticket/12151
[ticket/12151] Remove old dependency from profile type in tests
2014-02-02 11:15:47 -08:00
Joas Schilling
360862fad0 [ticket/12151] Remove old dependency from profile type in tests
PHPBB3-12151
2014-02-02 19:52:23 +01:00
Andreas Fischer
bc98118f92 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12146] Added a missing # to inline css-style of <span>

Conflicts:
	phpBB/styles/prosilver/template/ucp_groups_manage.html
2014-02-02 17:20:07 +01:00
Andreas Fischer
34c6677d14 Merge remote-tracking branch 'Crizz0/ticket/12146' into develop-olympus
* Crizz0/ticket/12146:
  [ticket/12146] Added a missing # to inline css-style of <span>
2014-02-02 17:15:46 +01:00
Andreas Fischer
16e81d4d18 [ticket/11509] Fail on Travis CI if commit messages are improperly formatted.
PHPBB3-11509
2014-02-02 17:11:30 +01:00
Crizz0
88fad5856a [ticket/12146] Added a missing # to inline css-style of <span>
PHPBB3-12146
2014-02-02 16:44:52 +01:00
Nils Adermann
38af79dd30 Merge remote-tracking branch 'github-nickvergessen/ticket/11201' into develop
* github-nickvergessen/ticket/11201: (50 commits)
  [ticket/11201] Remove empty calls section from .yml
  [ticket/11201] Split template file into multiple files
  [ticket/11201] Remove dependency from types on the manager
  [ticket/11201] Rename profilefields class to manager
  [ticket/11201] Fix parameter description
  [ticket/11201] Use !== null, its faster
  [ticket/11201] Also translate profile fields in UCP and ACP
  [ticket/11201] Add parameters and variables to profile field class
  [ticket/11201] Add commas on last array entry
  [ticket/11201] Allow translation of profile field name and explanation
  [ticket/11201] Fix some variable names
  [ticket/11201] Add tables to constructor in tests
  [ticket/11201] Add a method to return the translated full name of the type
  [ticket/11201] Remove db depending code from field class
  [ticket/11201] Add variables to classes and add constructor doc blocks
  [ticket/11201] Update copyright in class file
  [ticket/11201] Add visibility and remove unused variable
  [ticket/11201] Add some commas at the last array entry
  [ticket/11201] Cast some variables to integer
  [ticket/11201] Inject table names rather then using constants
  ...

Conflicts:
	phpBB/config/services.yml
2014-02-02 16:34:55 +01:00
Joas Schilling
a59d6e94a5 [ticket/11201] Remove empty calls section from .yml
PHPBB3-11201
2014-02-02 16:32:20 +01:00
Nils Adermann
8a6b961c54 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12147] Remove Travis CI notifications.

Conflicts:
	.travis.yml
2014-02-02 16:27:28 +01:00
Nils Adermann
ed43436c18 Merge remote-tracking branch 'github-bantu/ticket/12147' into develop-olympus
* github-bantu/ticket/12147:
  [ticket/12147] Remove Travis CI notifications.
2014-02-02 16:26:33 +01:00
Joas Schilling
cbad102f88 [ticket/11201] Split template file into multiple files
PHPBB3-11201
2014-02-02 16:20:02 +01:00
Joas Schilling
cacd43bfbd [ticket/11201] Remove dependency from types on the manager
PHPBB3-11201
2014-02-02 16:13:04 +01:00
Nils Adermann
f8d6a07392 Merge pull request #1716 from marc1706/feature/passwords
[feature/passwords] Add password hashing manager with support for newer hashing algorithms
2014-02-02 06:26:35 -08:00
Andreas Fischer
9cc8768fa0 [ticket/12147] Remove Travis CI notifications.
We don't want to get notifications for branches other people are working on.

PHPBB3-12147
2014-02-02 15:12:30 +01:00
Marc Alexander
b094c79996 [feature/passwords] Move combined hashing methods to manager
This will get rid of the circular dependency between the passwords manager
and the passwords helper. The combined_hash_password() method was also
slightly changed to allow both the definitions of service names or prefixes
for the hash types.

PHPBB3-11610
2014-02-02 14:57:43 +01:00
Joas Schilling
cb04252fbd Merge remote-tracking branch 'vsephpbb/ticket/12100' into develop 2014-02-02 14:48:14 +01:00
Marc Alexander
08a8bd8e6f [feature/passwords] Add support for passwords driver service name in hash()
This will allow users to specify both the hash type by prefix and by its
service name.

PHPBB3-11610
2014-02-02 14:13:21 +01:00
Marc Alexander
292961a277 [feature/passwords] Get rid of set_name/get_name methods for passwords drivers
PHPBB3-11610
2014-02-02 14:09:09 +01:00
Andreas Fischer
dfe1761c95 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12140] Remove the diff class / MOD text build script

Conflicts:
	build/build_diff.php
2014-02-02 14:01:39 +01:00
Andreas Fischer
1666476b42 Merge remote-tracking branch 'naderman/ticket/12140' into develop-olympus
* naderman/ticket/12140:
  [ticket/12140] Remove the diff class / MOD text build script
2014-02-02 13:51:56 +01:00
Joas Schilling
5fff6fc169 Merge remote-tracking branch 'prototech/ticket/12135' into develop 2014-02-02 13:39:44 +01:00
Nils Adermann
9047c0c061 [ticket/12140] Remove the diff class / MOD text build script
PHPBB3-12140
2014-02-02 13:36:12 +01:00
Joas Schilling
fecca29328 Merge remote-tracking branch 'prototech/ticket/12124' into develop 2014-02-02 13:15:29 +01:00
Andreas Fischer
c25d4e8e43 Merge pull request #1959 from prototech/ticket/12131
[ticket/12131] Remove invalid imageset var in viewtopic print view.

* prototech/ticket/12131:
  [ticket/12131] Remove invalid imageset var in viewtopic print view.
2014-02-02 12:58:11 +01:00
Joas Schilling
7bcbdfc1b1 [ticket/11201] Rename profilefields class to manager
PHPBB3-11201
2014-02-02 12:53:29 +01:00
Joas Schilling
514a59ffa7 [ticket/11201] Fix parameter description
PHPBB3-11201
2014-02-02 12:39:21 +01:00
Joas Schilling
85dfe868af Merge remote-tracking branch 'prototech/ticket/12123' into develop 2014-02-02 12:20:40 +01:00
Cesar G
d32b758428 [ticket/12124] IE8 does not support indexOf() for arrays.
PHPBB3-12124
2014-01-28 15:47:43 -08:00
Cesar G
53ef25e837 [ticket/12124] The textarea selector is failing in IE8 & 9.
PHPBB3-12124
2014-01-28 15:44:34 -08:00
Cesar G
a18dc8d1d6 [ticket/12124] Set attachment data to preserve AJAX delete functionality.
PHPBB3-12124
2014-01-28 15:42:53 -08:00
Matt Friedman
d3ce584dc7 [ticket/12100] Re-order arguments in template environment constructor
PHPBB3-12100
2014-01-27 20:38:15 -08:00
Matt Friedman
75c54f7f5e [ticket/12100] Ensure enabled extensions are fresh in Twig environment
PHPBB3-12100
2014-01-27 18:51:39 -08:00
Andreas Fischer
5553f33f3d Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12119] Remove meta tags from view-print templates

Conflicts:
	phpBB/styles/prosilver/template/ucp_pm_viewmessage_print.html
	phpBB/styles/prosilver/template/viewtopic_print.html
2014-01-27 20:48:28 +01:00
Andreas Fischer
917a61832e Merge remote-tracking branch 'vinny/ticket/12119' into develop-olympus
* vinny/ticket/12119:
  [ticket/12119] Remove meta tags from view-print templates
2014-01-27 20:47:19 +01:00
Marcus Vinicius
a32db45166 [ticket/12119] Remove meta tags from view-print templates
PHPBB3-12119
2014-01-27 16:42:39 -03:00
Cesar G
cd14eec8e5 [ticket/12135] Reduce verbosity in bbfontstyle() by using textarea var.
PHPBB3-12135
2014-01-26 18:25:48 -08:00
Andreas Fischer
578d5abbf3 Merge pull request #1965 from prototech/ticket/12137
[ticket/12137] Fix spacing in smiley block.

* prototech/ticket/12137:
  [ticket/12137] Fix spacing in smiley block.
2014-01-27 03:16:52 +01:00
Cesar G
f6d338fd8b [ticket/12137] Fix spacing in smiley block.
PHPBB3-12137
2014-01-26 18:11:16 -08:00
Cesar G
779868e4f4 [ticket/12136] Use new pagination class in generate_smilies().
PHPBB3-12136
2014-01-26 17:57:16 -08:00
Andreas Fischer
9b500538e3 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12118] Add noindex meta tag to subsilver2 view-print templates

Conflicts:
	phpBB/styles/subsilver2/template/ucp_pm_viewmessage_print.html
	phpBB/styles/subsilver2/template/viewtopic_print.html
2014-01-26 20:51:55 +01:00
Andreas Fischer
0d6e587fda Merge remote-tracking branch 'vinny/ticket/12118' into develop-olympus
* vinny/ticket/12118:
  [ticket/12118] Add noindex meta tag to subsilver2 view-print templates
2014-01-26 20:50:40 +01:00
Cesar G
525f1be319 [ticket/12131] Remove invalid imageset var in viewtopic print view.
PHPBB3-12131
2014-01-26 01:03:49 -08:00
Marcus Vinicius
19e2449525 [ticket/12134] Add ucp_pm_viewmessage_print_head_append event to subsilver2
PHPBB3-12134
2014-01-26 03:44:52 -03:00
Marcus Vinicius
525576eaed [ticket/12132] Add the event to events.md doc
PHPBB3-12132
2014-01-26 03:36:24 -03:00
Marcus Vinicius
98191894dd [ticket/12132] Add viewtopic_print_head_append event to subsilver2
PHPBB3-12132
2014-01-26 03:33:36 -03:00
Marcus Vinicius
cb7a0d6f2a [ticket/12118] Add noindex meta tag to subsilver2 view-print templates
PHPBB3-12118
2014-01-26 03:19:43 -03:00
Cesar G
ff9e16950b [ticket/12123] Add soft delete to phpbb/permissions.php.
PHPBB3-12123
2014-01-25 16:22:01 -08:00
Cesar G
43ccfbc6f4 [ticket/12093] Check that document.selection is supported.
PHPBB3-12093
2014-01-25 15:37:33 -08:00
Cesar G
10149933bd [ticket/12124] Remove double bang.
PHPBB3-12124
2014-01-25 15:26:37 -08:00
Cesar G
a8a349670a [ticket/12124] Revert to basic uploader if the html5 runtime is not supported.
PHPBB3-12124
2014-01-24 04:37:29 -08:00
Joas Schilling
e91a45df33 Merge remote-tracking branch 'prototech/ticket/12125' into develop
* prototech/ticket/12125:
  [ticket/12125] Specify nth-child selectors separately - IE8 does not like them
2014-01-24 13:35:34 +01:00
Cesar G
8620f1e619 [ticket/12125] Specify nth-child selectors separately - IE8 does not like them
PHPBB3-12125
2014-01-24 04:30:14 -08:00
Cesar G
4c102322c1 Merge branch 'develop-olympus' into develop 2014-01-23 14:13:34 -08:00
Cesar G
ed409d3d5b Merge remote-tracking branch 'nickvergessen/ticket/12120' into develop-olympus 2014-01-23 14:10:46 -08:00
Joas Schilling
42e4566fe4 [ticket/12120] Restore alphabetic order
PHPBB3-12120
2014-01-23 22:59:42 +01:00
Joas Schilling
a672d983c9 [ticket/12120] Add prototech to authors
PHPBB3-12120
2014-01-23 22:59:33 +01:00
Joas Schilling
79089ad7fe Merge remote-tracking branch 'EXreaction/ticket/11950' into develop
* EXreaction/ticket/11950:
  [ticket/11950] Fix prior commit
2014-01-22 18:29:29 +01:00
Nathan Guse
5b452ffe27 [ticket/11950] Fix prior commit
PHPBB3-11950
2014-01-22 10:43:29 -06:00
Nathan Guse
026272967a Merge pull request #1952 from suheb/ticket/11950
Ticket/11950 - Added 'forgot password' link to index page.
2014-01-22 07:34:57 -08:00
Suhaib Khan
88bd88b612 Adding 'forgot password' link to index page
PHPBB3-11950

Signed-off-by: Suhaib Khan <suhebjerk@gmail.com>
2014-01-22 12:42:33 +05:30
Joas Schilling
12932e8113 [ticket/11201] Use !== null, its faster
PHPBB3-11201
2014-01-20 00:15:06 +01:00
Joas Schilling
430a0c1c21 [ticket/11201] Also translate profile fields in UCP and ACP
PHPBB3-11201
2014-01-19 17:58:12 +01:00
Joas Schilling
4213b93cde [ticket/11201] Add parameters and variables to profile field class
PHPBB3-11201
2014-01-19 15:00:26 +01:00
Joas Schilling
ec8fd57f28 [ticket/11201] Add commas on last array entry
PHPBB3-11201
2014-01-19 14:55:47 +01:00
Joas Schilling
0ce98d7eac [ticket/11201] Allow translation of profile field name and explanation
PHPBB3-11201
2014-01-19 14:52:51 +01:00
Joas Schilling
45ab32bf61 Merge remote-tracking branch 'EXreaction/ticket/11902' into develop
* EXreaction/ticket/11902:
  [ticket/11902] Use phpbb\php\ini class
  [ticket/11902] Prevent errors if set_time_limit disabled
  [ticket/11902] Set max execution time to 0 in db update
2014-01-18 21:42:30 +01:00
Joas Schilling
dea91108fe Merge remote-tracking branch 'EXreaction/ticket/12006' into develop
* EXreaction/ticket/12006:
  [ticket/12006] global $phpbb_dispatcher;
  [ticket/12006] Missing a space
  [ticket/12006] Add module_auth event
  [ticket/12006] Test for ext module auth
  [ticket/12006] Add extension enabled check token to module auth
  [ticket/12006] Cleanup the module auth function token replacement code
2014-01-18 21:20:01 +01:00
Joas Schilling
f40f774b2e [ticket/11201] Fix some variable names
PHPBB3-11201
2014-01-18 13:28:17 +01:00
Joas Schilling
ad8d4492a7 [ticket/11201] Add tables to constructor in tests
PHPBB3-11201
2014-01-18 13:16:28 +01:00
Joas Schilling
197e026699 [ticket/11201] Add a method to return the translated full name of the type
PHPBB3-11201
2014-01-18 13:16:18 +01:00
Joas Schilling
df85364baa [ticket/11201] Remove db depending code from field class
sql_build_array() should already take care of that

PHPBB3-11201
2014-01-18 13:01:29 +01:00
Joas Schilling
b1bed49eae [ticket/11201] Add variables to classes and add constructor doc blocks
PHPBB3-11201
2014-01-18 12:53:41 +01:00
Joas Schilling
7fac238398 [ticket/11201] Update copyright in class file
PHPBB3-11201
2014-01-18 12:47:19 +01:00
Joas Schilling
7a8818fbc6 [ticket/11201] Add visibility and remove unused variable
PHPBB3-11201
2014-01-18 12:46:48 +01:00
Joas Schilling
1c884d07eb [ticket/11201] Add some commas at the last array entry
PHPBB3-11201
2014-01-18 12:44:24 +01:00
Joas Schilling
876e5e5fbb [ticket/11201] Cast some variables to integer
PHPBB3-11201
2014-01-18 12:40:12 +01:00
Joas Schilling
431fa7b593 [ticket/11201] Inject table names rather then using constants
PHPBB3-11201
2014-01-18 12:36:18 +01:00
Nathan Guse
ab41396707 Merge pull request #1866 from prototech/ticket/11915
[ticket/11915] Improve Plupload integration
2014-01-17 19:28:31 -08:00
Nathan Guse
efd56bc981 Merge pull request #1861 from prototech/ticket/12011
[ticket/12011] RTL fixes.
2014-01-17 19:27:50 -08:00
Cesar G
ebc2d1dd1b [ticket/11915] Pass the data to the template instead of scraping HTML for it.
PHPBB3-11915
2014-01-17 19:25:12 -08:00
Cesar G
9a21dec1b6 [ticket/11915] Replace inline onclick event for inserting attachment bbcodes.
PHPBB3-11915
2014-01-17 19:25:11 -08:00
Cesar G
702efc8496 [ticket/11915] Remove files that are no longer used.
PHPBB3-11915
2014-01-17 19:25:11 -08:00
Cesar G
c1cca8aff4 [ticket/11915] Hide attachments table when removing last failed file.
PHPBB3-11915
2014-01-17 19:20:37 -08:00
Cesar G
628323a80a [ticket/11915] Remove unused language string.
PHPBB3-11915
2014-01-17 19:20:37 -08:00
Cesar G
020b7a31bf [ticket/11915] Make the user aware of the drag-and-drop zone.
PHPBB3-11915
2014-01-17 19:20:37 -08:00
Cesar G
1fedad5e07 [ticket/11915] Fix the Plupload test.
PHPBB3-11915
2014-01-17 19:20:36 -08:00
Cesar G
8b351104ed [ticket/11915] Check if trigger_error() was called after sending chunk.
PHPBB3-11915
2014-01-17 19:20:36 -08:00
Cesar G
a70f08513d [ticket/11915] Fix spacing and ensure that strings are translated.
PHPBB3-11915
2014-01-17 19:20:36 -08:00
Cesar G
f858ec1f56 [ticket/11915] Fix various problems with responsive design.
PHPBB3-11915
2014-01-17 19:20:36 -08:00
Cesar G
9c1cacae42 [ticket/11915] Provide the URL to the attachment when it's uploaded.
PHPBB3-11915
2014-01-17 19:20:36 -08:00
Cesar G
708622a0bb [ticket/11915] Do not display the "Place inline" button when JS is disabled.
PHPBB3-11915
2014-01-17 19:20:36 -08:00
Cesar G
6837b724a3 [ticket/11915] Do not allow more files to be added if queue is already running
PHPBB3-11915
2014-01-17 19:20:36 -08:00
Cesar G
1272c9272e [ticket/11915] Remove unnecessary JS file and include others using INCLUDEJS.
PHPBB3-11915
2014-01-17 19:20:36 -08:00
Cesar G
508b43c197 [ticket/11915] Update the inline attachment bbcode indices on every upload.
PHPBB3-11915
2014-01-17 19:20:36 -08:00
Cesar G
688ca7fade [ticket/11915] Add the new uploader.
PHPBB3-11915
2014-01-17 19:20:36 -08:00
Cesar G
2719a18f7f [ticket/11915] Make it possible to display trigger_error() messages to user.
PHPBB3-11915
2014-01-17 19:20:36 -08:00
Cesar G
0ea110292b [ticket/11915] Provide some additional info about limits to the uploader.
PHPBB3-11915
2014-01-17 19:20:36 -08:00
Cesar G
be52a823f8 [ticket/11915] Provide the attachment file size to the template.
PHPBB3-11915
2014-01-17 19:20:36 -08:00
Cesar G
691dfd8453 [ticket/11915] Add row template for new attachments.
PHPBB3-11915
2014-01-17 19:20:36 -08:00
Cesar G
4361c1c9ac [ticket/11915] Move the uploaded attachment list under the attachments tab.
PHPBB3-11915
2014-01-17 19:20:35 -08:00
Cesar G
aeb215a5c2 [ticket/11915] Move some of the #cp-main table rules to separate class.
PHPBB3-11915
2014-01-17 19:20:35 -08:00
Cesar G
0ca1d14316 [ticket/12011] Correctly position the MCP minitabs.
PHPBB3-12011
2014-01-17 19:19:22 -08:00
Cesar G
68eef83a8e [ticket/12011] Prevent the <dfn> from bumping the unapproved icon to second line
A RTL rule is not needed for this since the content is just moved out of
view.

PHPBB3-12011
2014-01-17 19:19:22 -08:00
Cesar G
6b746ef029 [ticket/12011] Separate the navbar bullet points from the text.
PHPBB3-12011
2014-01-17 19:19:22 -08:00
Cesar G
be38a67768 [ticket/12011] Correctly align the posting options.
PHPBB3-12011
2014-01-17 19:15:38 -08:00
Cesar G
954cf7e064 [ticket/12011] Fix the overlapping unapproved post icon.
PHPBB3-12011
2014-01-17 19:15:38 -08:00
Cesar G
00356f7844 [ticket/12011] Align PM/post titles to the right.
PHPBB3-12011
2014-01-17 19:15:38 -08:00
Cesar G
567106988e [ticket/12011] Correctly align the pagination icon in topic rows.
PHPBB3-12011
2014-01-17 19:15:38 -08:00
Cesar G
d1edd04742 [ticket/12011] Stop the last post column from dropping to a second line.
PHPBB3-12011
2014-01-17 19:15:38 -08:00
Cesar G
57088e3b26 [ticket/12011] Align ACP tabs to the right and separate ACP content from menu.
PHPBB3-12011
2014-01-17 19:15:38 -08:00
Nathan Guse
059880debf Merge pull request #1809 from VSEphpbb/ticket/11966
[ticket/11966] Add header navigation template events to Subsilver2
2014-01-17 19:07:56 -08:00
Nathan Guse
ce8b8593e0 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12046] Use PHP_BINARY environment variable in PHP lint test.
2014-01-17 20:50:25 -06:00
Nathan Guse
90f3cc48e5 Merge remote-tracking branch 'remotes/bantu/ticket/12046' into develop-olympus
* remotes/bantu/ticket/12046:
  [ticket/12046] Use PHP_BINARY environment variable in PHP lint test.
2014-01-17 20:50:04 -06:00
Nathan Guse
8486d6a9d1 Merge pull request #1938 from prototech/ticket/12077
[ticket/12077] Ensure that valid upload methods are presented to user in language packs page.
2014-01-17 18:28:19 -08:00
Nathan Guse
2cf4b68351 [ticket/12006] global $phpbb_dispatcher;
PHPBB3-12006
2014-01-17 20:26:59 -06:00
Nathan Guse
54afdeb7ee Merge pull request #1945 from VSEphpbb/ticket/12104
[ticket/12104] Replace shadow topics $sql with $sql_array for better Eve...
2014-01-17 18:08:19 -08:00
Nathan Guse
574eb2c199 Merge pull request #1947 from bantu/ticket/12107
[ticket/12107] Use log table property instead of log table constant.
2014-01-17 17:57:06 -08:00
Nathan Guse
6c8f217832 Merge pull request #1949 from prototech/ticket/12110
[ticket/12110] Update Plupload to 2.1.1.
2014-01-17 17:56:19 -08:00
Nathan Guse
6ae6dceb47 Merge pull request #1950 from prototech/ticket/12096
[ticket/12096] Use plurals for MAX_NUM_SEARCH_KEYWORDS_REFINE.
2014-01-17 17:55:00 -08:00
Nathan Guse
8eb9f1542c Merge pull request #1951 from prototech/ticket/12032
[ticket/12032] Do not inherit read status in certain notifications.
2014-01-17 17:52:49 -08:00
Joas Schilling
39ff387d36 [ticket/11201] Update schema files and unit test
PHPBB3-11201
2014-01-17 21:53:08 +01:00
Joas Schilling
aa2f0a652f [ticket/11201] Change type from integer to service name
PHPBB3-11201
2014-01-17 21:13:59 +01:00
Joas Schilling
0ec6af38a9 [ticket/11201] Fix construction of dropdown type once again
PHPBB3-11201
2014-01-17 21:13:58 +01:00
Joas Schilling
74d36591e1 [ticket/11201] Move custom template variable assignment to type class
PHPBB3-11201
2014-01-17 21:13:56 +01:00
Joas Schilling
af5c747f6f [ticket/11201] Move preparation of hidden fields to type class
PHPBB3-11201
2014-01-17 21:13:46 +01:00
Joas Schilling
67f477fc8f [ticket/11201] Allow manipulating the intended variables with the type class
PHPBB3-11201
2014-01-17 13:59:07 +01:00
Joas Schilling
ae38cfaa70 [ticket/11201] Move type specific error messages to type class
PHPBB3-11201
2014-01-17 10:20:00 +01:00
Joas Schilling
5e2ffe0d5c [ticket/11201] Add abstract base class with shared methods
PHPBB3-11201
2014-01-17 10:12:30 +01:00
Joas Schilling
9653764fb1 [ticket/11201] Move field type depending preparation of the options to class
PHPBB3-11201
2014-01-17 09:55:52 +01:00
Cesar G
4bb05c74e5 [ticket/12032] Do not inherit read status in certain notifications.
PHPBB3-12032
2014-01-16 17:27:30 -08:00
Cesar G
b3a25c52e5 [ticket/12096] Use plurals for MAX_NUM_SEARCH_KEYWORDS_REFINE.
PHPBB3-12096
2014-01-16 11:48:40 -08:00
Cesar G
86ee2a470d [ticket/12110] Update Plupload to 2.1.1.
PHPBB3-12110
2014-01-16 11:05:43 -08:00
Joas Schilling
0bdec35cd4 [ticket/11201] Move grabbing the input of the language options to type class
PHPBB3-11201
2014-01-16 16:00:52 +01:00
Joas Schilling
78603bb96d [ticket/11201] Move language option determination into type class
PHPBB3-11201
2014-01-15 18:25:28 +01:00
Joas Schilling
bd1425d075 [ticket/11201] Use database type from the type class
PHPBB3-11201
2014-01-15 16:39:06 +01:00
Joas Schilling
7d2d18fb50 [ticket/11201] Move "get type" code into a new function
PHPBB3-11201
2014-01-15 16:37:21 +01:00
Joas Schilling
8e86e56120 [ticket/11201] Add database column type to type class
PHPBB3-11201
2014-01-15 16:36:50 +01:00
Joas Schilling
1dbc2d6218 [ticket/11201] Fix dropdown tests
The error message is now already the language string including the fieldname
and not the language key anymore.

PHPBB3-11201
2014-01-15 12:36:54 +01:00
Joas Schilling
7fd5f16fa2 [ticket/11201] Use a service collection for the types instead of the container
PHPBB3-11201
2014-01-15 12:16:04 +01:00
Joas Schilling
5df7f76e6b [ticket/11201] Split language options into a new class
Otherwise we run into a circular dependency

PHPBB3-11201
2014-01-15 12:15:41 +01:00
Joas Schilling
cd6bdc7b27 [ticket/11201] Remove remaining type depending code to type class
PHPBB3-11201
2014-01-14 15:08:33 +01:00
Joas Schilling
9dec023632 [ticket/11201] Add visibility to methods
PHPBB3-11201
2014-01-14 13:42:18 +01:00
Joas Schilling
d601aaad26 [ticket/11201] Remove type related code from build_insert_sql_array()
PHPBB3-11201
2014-01-14 13:38:24 +01:00
Joas Schilling
daf21fcb30 [ticket/11201] Move generate_field() method to type class
PHPBB3-11201
2014-01-14 12:51:32 +01:00
Joas Schilling
d57c43d397 [ticket/11201] Move error message generation to type class
PHPBB3-11201
2014-01-14 12:04:02 +01:00
Joas Schilling
190c2e989a [ticket/11201] Remove call by refernce
PHPBB3-11201
2014-01-14 10:50:12 +01:00
Joas Schilling
0d79ccaadd [ticket/11201] Move get_profile_value() to type class
PHPBB3-11201
2014-01-14 10:36:44 +01:00
Joas Schilling
dda5992a79 [ticket/11201] Rename test file for now, so the other tests run
PHPBB3-11201
2014-01-14 10:20:33 +01:00
Joas Schilling
ee78aed2f1 [ticket/11201] Move validate_profile_field() to type class
PHPBB3-11201
2014-01-14 10:13:47 +01:00
Joas Schilling
b3803d563a [ticket/11201] Move get_profile_field() to type classes
PHPBB3-11201
2014-01-13 21:09:17 +01:00
Joas Schilling
a7e3538e5b [ticket/11201] Move get_options to type classes
PHPBB3-11201
2014-01-13 21:09:07 +01:00
Joas Schilling
b155056cb9 [ticket/11996] Use a table for better styling
PHPBB3-11996
2014-01-13 10:31:54 +01:00
Andreas Fischer
83ec308eff [ticket/12107] Use log table property instead of log table constant.
PHPBB3-12107
2014-01-12 21:36:50 +01:00
Andreas Fischer
670a9a1aea Merge pull request #1893 from nickvergessen/ticket/12039
[ticket/12039] Add config:* to the command line interface tool

* nickvergessen/ticket/12039:
  [ticket/12039] Allow getting the value without a new line at the end
  [ticket/12039] Do not print success message when config did not exist
  [ticket/12039] Do not colour returned value in get command
  [ticket/12039] Update command descriptions
  [ticket/12039] Remove debug code
  [ticket/12039] Fix option descriptions
  [ticket/12039] Use an abstract class and some more minor adjustments
  [ticket/12039] Add config:* to the command line interface tool
2014-01-12 21:23:21 +01:00
Nils Adermann
46fec7ee90 Merge pull request #1936 from nickvergessen/ticket/12030
[Ticket/12030] Include some directories completly in update packages
2014-01-12 02:31:40 -08:00
Joas Schilling
c665839636 [ticket/11201] Remove global use from admin class
PHPBB3-11201
2014-01-10 23:00:37 +01:00
Nathan Guse
7bac4bf9bd [ticket/12006] Missing a space
PHPBB3-12006
2014-01-10 13:15:37 -06:00
Nathan Guse
e3cba9ceba [ticket/12006] Add module_auth event
PHPBB3-12006
2014-01-10 13:14:50 -06:00
Joas Schilling
2471b19d73 [ticket/11201] Make profile field classes autoloadable
PHPBB3-11201
2014-01-10 16:11:11 +01:00
Joas Schilling
a70973ea42 [ticket/12039] Allow getting the value without a new line at the end
PHPBB3-12039
2014-01-10 11:36:11 +01:00
Matt Friedman
f14ca6df6f [ticket/12104] Update the event's doc block to reflect new variable
PHPBB3-12104
2014-01-09 15:48:32 -08:00
Matt Friedman
c2c677d4f2 [ticket/12104] Remove newline before WHERE parameter
PHPBB3-12104
2014-01-09 15:45:24 -08:00
Matt Friedman
b95631b163 [ticket/12104] Remove empty LEFT_JOIN array
PHPBB3-12104
2014-01-09 15:42:25 -08:00
Matt Friedman
f9cef15989 [ticket/12104] Replace shadow topics $sql with $sql_array for better Event handling
PHPBB3-12104
2014-01-09 12:43:33 -08:00
Joas Schilling
5d89c283f0 [ticket/12039] Do not print success message when config did not exist
PHPBB3-12039
2014-01-08 23:59:46 +01:00
Joas Schilling
52c452c768 [ticket/12039] Do not colour returned value in get command
PHPBB3-12039
2014-01-08 23:56:50 +01:00
Joas Schilling
2081d973b0 [ticket/12030] Fix some spelling issues
PHPBB3-12030
2014-01-08 23:53:45 +01:00
Joas Schilling
3e84fb76a3 Merge remote-tracking branch 'Marc/ticket/11997' into develop
* Marc/ticket/11997: (23 commits)
  [ticket/11997] Use functional test cases that should always work
  [ticket/11997] Fix redirect tests for mod rewrite
  [ticket/11997] Add user's page dir to redirect path and fix unit tests for it
  [ticket/11997] Remove obsolete function get_controller_redirect_url()
  [ticket/11997] Use path_helper in in foo/bar extension for redirect URLs
  [ticket/11997] Add remove_web_root_path() in order to prevent incorrect URLs
  [ticket/11997] Do not check if file or dir we redirect to exist
  [ticket/11997] Modifiy tests after adding path_helper clean_url method
  [ticket/11997] Add clean_url() method to path_helper
  [ticket/11997] Allow redirects to parent folders like previously
  [ticket/11997] Move expected redirect returns to controller and output to HTML
  [ticket/11997] Fix tests for path_helper's get_controller_redirect_url()
  [ticket/11997] Use get_controller_redirect_url() in redirect() function
  [ticket/11997] Add method for controller redirect URLs to path helper
  [ticket/11997] Undo changes to phpbb_own_realpath()
  [ticket/11997] Remove obsolete failover_flag in function redirect()
  [ticket/11997] Add functional test for redirects in controller
  [ticket/11997] Fix missing global
  [ticket/11997] Fix redirects from inside controllers
  [ticket/11997] Use $phpbb_filesystem->clean_path() for proper redirect paths
  ...
2014-01-08 16:17:48 +01:00
marc1706
98aebabd73 [ticket/12071] Add test that covers not available fileinfo
The newly added test case will also emulate a non-existing fileinfo
in order to check if the mimetype guesser is properly working when
fileinfo is not available.

PHPBB3-12071
2014-01-03 16:40:12 +01:00
marc1706
f111a9262f [ticket/12071] Get rid of unneeded cast to boolean in tests
PHPBB3-12071
2014-01-03 13:45:38 +01:00
marc1706
8ebf5bb8d1 [ticket/12071] Skip tests that depend on fileinfo and fix expected results
Tests that depend on fileinfo being enabled will now be skipped to prevent
fatal errors while running the test suite. The expected results will be
modified to "application/octet-stream" in test_guess_files() if only the
extension_guesser is available due to the non-existing extension of those
files.

PHPBB3-12071
2014-01-03 13:30:52 +01:00
Nathan Guse
c6491c9078 [ticket/11881] Fix test filename
PHPBB3-11881
2013-12-30 14:27:13 -06:00
Nathan Guse
405f883437 [ticket/11902] Use phpbb\php\ini class
PHPBB3-11902
2013-12-30 14:24:58 -06:00
Nathan Guse
821f737560 Merge pull request #1890 from prototech/ticket/12034
[ticket/12034] AJAXify notifications popup.
2013-12-30 12:20:22 -08:00
Nathan Guse
b186d31ce6 Merge pull request #1920 from prototech/ticket/12038
[ticket/12038] AJAXify move up/down buttons for various ACP pages.
2013-12-30 11:23:22 -08:00
Cesar G
d76ec60ee1 [ticket/12034] Move similar code in the two callbacks to separate function.
PHPBB3-12034
2013-12-30 11:12:15 -08:00
Cesar G
0c0375df65 [ticket/12034] Add comma to end of array.
PHPBB3-12034
2013-12-30 11:12:15 -08:00
Cesar G
f4b832a27d [ticket/12034] AJAXify notifications popup.
PHPBB3-12034
2013-12-30 11:12:15 -08:00
Cesar G
06262aca54 [ticket/12038] Free query results.
PHPBB3-12038
2013-12-30 11:09:08 -08:00
Nathan Guse
be67124dc7 Merge pull request #1889 from prototech/ticket/11963
[ticket/11963] Remove stale MCP notifications.
2013-12-30 11:04:43 -08:00
Nathan Guse
34c3e74c16 Merge pull request #1913 from prototech/ticket/12055
[ticket/12055] Alternate table row background colors using nth-child rule.
2013-12-30 10:44:30 -08:00
Nathan Guse
6ab12c1779 [ticket/12006] Test for ext module auth
PHPBB3-12006
2013-12-30 12:32:48 -06:00
Nathan Guse
05cf83aca7 [ticket/12006] Add extension enabled check token to module auth
PHPBB3-12006
2013-12-30 11:50:37 -06:00
Nathan Guse
7740ab5dc3 [ticket/12006] Cleanup the module auth function token replacement code
PHPBB3-12006
2013-12-30 11:46:02 -06:00
Marc Alexander
85f1e8afa5 [feature/passwords] Correct docblock of phpbb_hash() function
PHPBB3-11610
2013-12-29 20:52:25 +01:00
Marc Alexander
4b832cf2bd [feature/passwords] Intialize output array before usage in passwords helper
PHPBB3-11610
2013-12-29 17:57:17 +01:00
Marc Alexander
1465915830 [feature/passwords] Remove unneeded definitions of full namespace
PHPBB3-11610
2013-12-29 17:56:41 +01:00
Marc Alexander
8383d1f1d3 [feature/passwords] Add missing documentation to docblocks
Also contains some minor spacing changes.

PHPBB3-11610
2013-12-29 17:55:00 +01:00
Marc Alexander
141bef75cb [feature/passwords] Undo simplification to bcrypt driver
By simplifying, a needed part was removed that is actually required.

PHPBB3-11610
2013-12-29 17:04:38 +01:00
Marc Alexander
808c54fa89 [feature/passwords] Get rid of unneeded code complexity
Simplified a little bit of code as pointed out by imkingdavid on github.

PHPBB3-11610
2013-12-29 16:33:09 +01:00
Marc Alexander
555cd025b2 [feature/passwords] Remove unnecessary specification of namespace in drivers
PHPBB3-11610
2013-12-29 16:17:37 +01:00
Marc Alexander
b37549ce63 [feature/passwords] Remove IN_PHPBB check from passwords files
PHPBB3-11610
2013-12-29 14:07:27 +01:00
Marc Alexander
382317b135 Merge branch 'develop' of https://github.com/phpbb/phpbb into feature/passwords
Conflicts:
	phpBB/config/services.yml
2013-12-29 13:46:42 +01:00
Marc Alexander
f906fb41e9 [ticket/11997] Use functional test cases that should always work
The previous test cases that tried to redirect to ../index.php and similar
might cause us to try to go to http://localhost/../index.php, which will
result in http://index.php. As this obviously will trigger an error as
intended, we should not put this inside our test cases for the redirect
function.

PHPBB3-11997
2013-12-28 20:40:18 +01:00
Marc Alexander
ac131a5159 [feature/passwords] Fix indentation in auth providers
PHPBB3-11610
2013-12-28 16:56:20 +01:00
Marc Alexander
3e815616c5 [ticket/11997] Fix redirect tests for mod rewrite
Controller routes that are supposed to link to parent directories can't be
tested as the links are incorrectly created depending on enabled mod rewrite
or not.

PHPBB3-11997
2013-12-28 16:50:15 +01:00
Marc Alexander
4c1569dd8a [ticket/11997] Add user's page dir to redirect path and fix unit tests for it
The user's page directory needs to be added to the redirect URL for proper
redirects outside of the forum root. Fix the unit tests accordingly.

PHPBB3-11997
2013-12-28 00:14:12 +01:00
Marc Alexander
ce2c5213d7 [ticket/11997] Remove obsolete function get_controller_redirect_url()
PHPBB3-11997
2013-12-27 18:41:44 +01:00
Marc Alexander
68ce16f9b3 [ticket/11997] Use path_helper in in foo/bar extension for redirect URLs
By using path_helper's clean_url() method, we'll be able to properly check
the full URL instead of just parts of the expected URL.

PHPBB3-11997
2013-12-27 17:55:14 +01:00
Marc Alexander
a304d99b2b [ticket/11997] Add remove_web_root_path() in order to prevent incorrect URLs
Adding a call to this method to the redirect function will make sure that we
do not end up with incorrect URLs after using append_sid().

PHPBB3-11997
2013-12-27 17:50:17 +01:00
Joas Schilling
95d4e6aa97 [ticket/11996] Add explanation how to correctly remove and update an extension
See http://area51.phpbb.com/phpBB/viewtopic.php?f=81&t=44001 for more
information about the decision.

PHPBB3-11996
2013-12-27 15:25:03 +01:00
Dhruv
db94f80c5b Merge remote-tracking branch 'nickvergessen/ticket/11911' into develop
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/ticket/11911:
  [ticket/11911] Warn admins when there is no search index for the selected engine
2013-12-27 18:01:48 +05:30
Joas Schilling
bef7bc7900 [ticket/11911] Warn admins when there is no search index for the selected engine
PHPBB3-11911
2013-12-27 13:16:38 +01:00
Marc Alexander
9161816267 [ticket/11997] Do not check if file or dir we redirect to exist
The redirect function will now properly redirect to where we want it to.
It will no longer try to check if the file or directory we redirect to exist.
This will ensure compatibility with the new routes.

PHPBB3-11997
2013-12-27 13:00:22 +01:00
Dhruv
99d312da2a Merge branch 'ticket/11271' into ticket/11271-develop
* ticket/11271:
  [ticket/11271] Make path conversion more precise

Conflicts:
	phpBB/feed.php
2013-12-27 03:43:22 +05:30
Dhruv
1aa27f400c [ticket/11271] Make path conversion more precise
PHPBB3-11271
2013-12-27 03:31:28 +05:30
Dhruv
657ddf8309 [ticket/11271] limit absolute path conversion to attachment links only
PHPBB3-11271
2013-12-27 01:33:54 +05:30
Dhruv
fd9366daf5 Merge branch 'ticket/11271' into ticket/11271-develop
* ticket/11271:
  [ticket/11271] Add docblock of feed_generate_content( )
  [ticket/11271] Fix tabs and use !empty( ) instead of count( )
  [ticket/11271] Remove unnecessary inclusion of functions_display
  [ticket/11271] Typecast forum and topic id to integer
  [ticket/11271] Use absolute path for displaying inline attachments in feeds
  [ticket/11271] Changed executable bit.
  [ticket/11271] Formatting code and removing null assignment.
  [ticket/11271] Removing unnecessary database object
  [ticket/11271] Separated attachment fetching query
  [ticket/11271] Fetched feed attachments before loop.
  [ticket/11271] Removed in-line attachment comments properly.
  [ticket/11271] Displaying in-line attached images in ATOM feed.

Conflicts:
	phpBB/feed.php
2013-12-27 01:33:32 +05:30
Dhruv
a71625ca76 [ticket/11271] Add docblock of feed_generate_content( )
PHPBB3-11271
2013-12-27 00:38:42 +05:30
Dhruv
80c05e861b Merge branch 'develop' into ticket/11271-develop
# By Vjacheslav Trushkin (148) and others
# Via Joas Schilling (50) and others
* develop: (635 commits)
  [ticket/12079] Add default value to $multibyte in request.untrimmed_variable().
  [ticket/11849] Fix more function calls
  [ticket/11849] Update more MCP calls to pagination class
  [ticket/11849] Update some ACP modules with new pagination
  [ticket/11849] Update rest of the UCP modules
  [ticket/11849] Update UCP notifications and pm folder
  [ticket/11849] Update search and memberlist
  [ticket/11849] Update pagination in viewonline.php
  [ticket/11849] Remove old pagination test
  [ticket/11849] Update pagination code in viewtopic.php
  [ticket/11849] Replace pagination in viewforum.php with class
  [ticket/11849] Add service definition
  [ticket/11849] Remove pagination functions
  [ticket/11849] Test validate_start and on_page
  [ticket/11849] Move pagination code to class
  [ticket/12060] A little less verbose cleanup of event docblocks
  [ticket/12060] Further clarifying new event docblocks as much as possible
  [ticket/12060] More fixes to dockblock for acp_bbcodes_modify_create event
  [ticket/12060] Remove whitespaces
  [ticket/12060] Fix docblock for acp_bbcodes_modify_create event
  ...
2013-12-27 00:28:38 +05:30
Dhruv
f7c764986f [ticket/11271] Fix tabs and use !empty( ) instead of count( )
PHPBB3-11271
2013-12-27 00:22:29 +05:30
Dhruv
6611329d83 [ticket/11271] Remove unnecessary inclusion of functions_display
PHPBB3-11271
2013-12-27 00:22:28 +05:30
Dhruv
3bae72d164 [ticket/11271] Typecast forum and topic id to integer
PHPBB3-11271
2013-12-27 00:22:27 +05:30
Dhruv
dc37f3a0e3 [ticket/11271] Use absolute path for displaying inline attachments in feeds
PHPBB3-11271
2013-12-27 00:22:26 +05:30
erangamapa
62263c13d4 [ticket/11271] Changed executable bit.
Changed executable bit value from 755 to 644.

PHPBB3-11271
2013-12-27 00:22:25 +05:30
erangamapa
08d69de933 [ticket/11271] Formatting code and removing null assignment.
Formatted code and replaced null assignment with empty array
assignment to attachments parameter in method 'feed_generate_content'.

PHPBB3-11271
2013-12-27 00:22:24 +05:30
erangamapa
cca4067694 [ticket/11271] Removing unnecessary database object
Removed unnecessary global database object from 'feed_generate_content'
Method.

PHPBB3-11271
2013-12-27 00:22:22 +05:30
erangamapa
8586171187 [ticket/11271] Separated attachment fetching query
Removed external query used to fetch related attachments.
Added attachments fetching method with database query to
post based feed.

PHPBB3-11271
2013-12-27 00:22:21 +05:30
erangamapa
91a14a9e63 [ticket/11271] Fetched feed attachments before loop.
Fetched feed attachments before looping through feed items and
send them to method 'feed_generate_content' for each feed item.

PHPBB3-11271
2013-12-27 00:22:20 +05:30
erangamapa
a41e2ca380 [ticket/11271] Removed in-line attachment comments properly.
Added a new regex to remove in-line attachment comments.

PHPBB3-11271
2013-12-27 00:22:19 +05:30
erangamapa
5bf4726195 [ticket/11271] Displaying in-line attached images in ATOM feed.
In-line attached images are not displaying as they are not parsing.
Included 'parse_attachments' column name for data fetching queries
in feed.php. Checked weather feeds have in-line attachments and
parsed them by using parse_attachments() method.

PHPBB3-11271
2013-12-27 00:22:18 +05:30
Joas Schilling
98200161fc [ticket/12039] Update command descriptions
PHPBB3-12039
2013-12-26 19:03:43 +01:00
Dhruv
1bb175ce77 [ticket/11271] Add the inline images html to content
PHPBB3-11271
2013-12-25 04:58:41 +05:30
Dhruv
e2f72539e1 [ticket/11271] Use class variable $db instead of global
PHPBB3-11271
2013-12-25 04:58:28 +05:30
Dhruv
f9c7f0fc19 Merge remote-tracking branch 'nickvergessen/feature/pagination-class' into develop
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/feature/pagination-class:
  [ticket/11849] Fix more function calls
  [ticket/11849] Update more MCP calls to pagination class
  [ticket/11849] Update some ACP modules with new pagination
  [ticket/11849] Update rest of the UCP modules
  [ticket/11849] Update UCP notifications and pm folder
  [ticket/11849] Update search and memberlist
  [ticket/11849] Update pagination in viewonline.php
  [ticket/11849] Remove old pagination test
  [ticket/11849] Update pagination code in viewtopic.php
  [ticket/11849] Replace pagination in viewforum.php with class
  [ticket/11849] Add service definition
  [ticket/11849] Remove pagination functions
  [ticket/11849] Test validate_start and on_page
  [ticket/11849] Move pagination code to class
2013-12-25 00:54:07 +05:30
Marc Alexander
4ced162646 [ticket/11997] Modifiy tests after adding path_helper clean_url method
PHPBB3-11997
2013-12-21 20:08:33 +01:00
Marc Alexander
d9358c26da [ticket/11997] Add clean_url() method to path_helper
This method will get rid of unnecessary . and .. in URLs.

PHPBB3-11997
2013-12-21 20:08:00 +01:00
Andreas Fischer
02336d9a69 Merge pull request #1940 from prototech/ticket/12079
[ticket/12079] Add default value to $multibyte in request.untrimmed_varible().

* prototech/ticket/12079:
  [ticket/12079] Add default value to $multibyte in request.untrimmed_variable().
2013-12-21 19:24:21 +01:00
Marc Alexander
235d2069e0 [ticket/11997] Allow redirects to parent folders like previously
Redirects to parent folders were possible with the previous redirect function.
This change will allow these redirects again.

PHPBB3-11997
2013-12-21 16:31:20 +01:00
Marc Alexander
15913fdf79 [ticket/11997] Move expected redirect returns to controller and output to HTML
The controller will now output the expected redirect returns the same way the
redirect returns are output. The extension controller test will compare those
2 outputs.

PHPBB3-11997
2013-12-20 18:13:53 +01:00
Nils Adermann
9f7985d725 Merge pull request #1932 from ptarjan/patch-1
Try running unit tests on HHVM
2013-12-20 07:15:32 -08:00
Joas Schilling
558f3cd21c Merge remote-tracking branch 'vsephpbb/ticket/12060' into develop
* vsephpbb/ticket/12060: (37 commits)
  [ticket/12060] A little less verbose cleanup of event docblocks
  [ticket/12060] Further clarifying new event docblocks as much as possible
  [ticket/12060] More fixes to dockblock for acp_bbcodes_modify_create event
  [ticket/12060] Remove whitespaces
  [ticket/12060] Fix docblock for acp_bbcodes_modify_create event
  [ticket/12060] Rename event in message parser to modify_format_display_text_after
  [ticket/12060] Add num_predefined_bbcodes to display_custom_bbcodes_modify_sql
  [ticket/12060] Further clarify/fix a var in acp_bbcodes_modify_create event doc block
  [ticket/12060] Use separate template event for acp user signature posting buttons
  [ticket/12060] Rename event from append to after in acp_bbcodes.html
  [ticket/12060] Correctly label alpha versions in event docblocks
  [ticket/12060] Fix u_action comments in docblocks
  [ticket/12060] Change @since in event docblocks
  [ticket/12060] Update the docblock comments in acp core events
  [ticket/12060] Refactor u_action in the events that use it
  [ticket/12060] Use $sql_ary instead of $sql
  [ticket/12060] Update docblock for core event due to addition of another var
  [ticket/12060] Remove re-tabbing of html from subsilver2 files
  [ticket/12060] Add $update_this_message var to the core event
  [ticket/12060] Adjust last item in array to use a comma instead of closing parenthesis
  ...
2013-12-20 16:11:02 +01:00
Cesar G
d512197bb9 [ticket/12077] Fix another strict standards error.
PHPBB3-12077
2013-12-19 19:36:49 -08:00
Cesar G
cd98dba0b9 [ticket/12079] Add default value to $multibyte in request.untrimmed_variable().
PHPBB3-12079
2013-12-19 19:09:40 -08:00
Cesar G
0a418739a3 [ticket/12078] Check for f_delete when a user attempts to permanently delete
PHPBB3-12078
2013-12-19 17:28:16 -08:00
Cesar G
9db8665a54 [ticket/12077] Add missing space after template block name.
PHPBB3-12077
2013-12-19 17:15:15 -08:00
Cesar G
9d34170b32 [ticket/12077] Fix strict standards error.
PHPBB3-12077
2013-12-19 17:14:24 -08:00
Joas Schilling
df61389238 [ticket/12030] Fix wrong file and directory names
PHPBB3-12030
2013-12-19 16:40:30 +01:00
Joas Schilling
4429022b98 [ticket/12030] Include adm/images/ when the css file was updated
The images are referenced relative from the admin.css file.
So when it was updated and the images where not, the updater will be without
images, unless we ensure that they are included in the update-package.

PHPBB3-12021
PHPBB3-12030
2013-12-19 15:25:38 +01:00
Joas Schilling
eac19fb5f6 [ticket/12030] Include config directory completly in update packages
When one of the config files was updated, we need to include all config files
because they are referenced relative from the files themselves.

PHPBB3-12030
2013-12-19 15:23:09 +01:00
Joas Schilling
cb8b2bab5f [ticket/11849] Fix more function calls
PHPBB3-11849
2013-12-18 18:39:11 +01:00
Joas Schilling
edd183b53a [ticket/11849] Update more MCP calls to pagination class
PHPBB3-11849
2013-12-18 18:39:01 +01:00
Joas Schilling
8652589469 [ticket/11849] Update some ACP modules with new pagination
PHPBB3-11849
2013-12-18 18:36:47 +01:00
Joas Schilling
e4950ced92 [ticket/11849] Update rest of the UCP modules
PHPBB3-11849
2013-12-18 18:36:08 +01:00
Joas Schilling
a5b55e5ab4 [ticket/11849] Update UCP notifications and pm folder
PHPBB3-11849
2013-12-18 18:35:59 +01:00
Joas Schilling
dfe0526979 [ticket/11849] Update search and memberlist
PHPBB3-11849
2013-12-18 18:35:47 +01:00
Joas Schilling
59a24f6423 [ticket/11849] Update pagination in viewonline.php
PHPBB3-11849
2013-12-18 18:35:40 +01:00
Joas Schilling
a836a107ca [ticket/11849] Remove old pagination test
PHPBB3-11849
2013-12-18 18:35:32 +01:00
Joas Schilling
4f4512cbac [ticket/11849] Update pagination code in viewtopic.php
PHPBB3-11849
2013-12-18 18:35:25 +01:00
Joas Schilling
725c512468 [ticket/11849] Replace pagination in viewforum.php with class
PHPBB3-11849
2013-12-18 18:35:16 +01:00
Joas Schilling
fcfa1a35cc [ticket/11849] Add service definition
PHPBB3-11849
2013-12-18 18:35:07 +01:00
Joas Schilling
a485184434 [ticket/11849] Remove pagination functions
The functions where changed in 3.1 anyway, so we can just delete them

PHPBB3-11849
2013-12-18 18:34:58 +01:00
Joas Schilling
ed16fbd5b7 [ticket/11849] Test validate_start and on_page
PHPBB3-11849
2013-12-18 18:34:49 +01:00
Joas Schilling
268afe20f4 [ticket/11849] Move pagination code to class
PHPBB3-11849
2013-12-18 18:34:13 +01:00
Matt Friedman
121f2394ff [ticket/12060] A little less verbose cleanup of event docblocks
PHPBB3-12060
2013-12-17 18:55:59 -08:00
Matt Friedman
4665e3df21 [ticket/12060] Further clarifying new event docblocks as much as possible
PHPBB3-12060
2013-12-16 23:54:55 -08:00
Matt Friedman
01c4235f00 [ticket/12060] More fixes to dockblock for acp_bbcodes_modify_create event
PHPBB3-12060
2013-12-16 15:33:44 -08:00
Matt Friedman
df9e782fa4 [ticket/12060] Remove whitespaces
PHPBB3-12060
2013-12-16 15:31:44 -08:00
Matt Friedman
6b178c758e [ticket/12060] Fix docblock for acp_bbcodes_modify_create event
PHPBB3-12060
2013-12-16 15:31:25 -08:00
Joas Schilling
e3e34add7f Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/10023] Make password change notification more noticeable
2013-12-16 10:25:45 +01:00
Joas Schilling
89fd73c18d Merge remote-tracking branch 'Elsensee/ticket/10023' into develop-olympus
* Elsensee/ticket/10023:
  [ticket/10023] Make password change notification more noticeable
2013-12-16 10:25:21 +01:00
Joas Schilling
4a73ce0933 Merge remote-tracking branch 'prototech/ticket/12009' into develop
* prototech/ticket/12009:
  [ticket/12009] Prevent user from enabling invalid extension through direct URL
  [ticket/12009] Update functional test to check for invalid extensions.
  [ticket/12009] Fix functional tests.
  [ticket/12009] Move valid extensions in tests to correct dir structure.
  [ticket/12009] Do not allow incorrectly structured extensions to be installed.
2013-12-16 10:18:56 +01:00
Joas Schilling
8da2f349fe Merge remote-tracking branch 'vsephpbb/ticket/12054' into develop
* vsephpbb/ticket/12054:
  [ticket/12054] Re-word event documentation
  [ticket/12054] Reword descriptions and resort events alphabetically
  [ticket/12054] Update index_body_linklist_before/after template events
2013-12-16 10:08:19 +01:00
Matt Friedman
b13f64b5a9 [ticket/12054] Re-word event documentation
PHPBB3-12054
2013-12-14 12:59:52 -08:00
Paul Tarjan
f495f937e9 HHVM is failing for now
Lets at least keep running it so we remember to fix it
2013-12-13 18:11:49 -08:00
Matt Friedman
f045458679 [ticket/12060] Rename event in message parser to modify_format_display_text_after
PHPBB3-12060
2013-12-13 17:00:06 -08:00
Matt Friedman
a24d2058cd [ticket/12060] Add num_predefined_bbcodes to display_custom_bbcodes_modify_sql
event

PHPBB3-12060
2013-12-13 16:47:38 -08:00
Matt Friedman
aa0c463d0f [ticket/12060] Further clarify/fix a var in acp_bbcodes_modify_create event doc block
PHPBB3-12060
2013-12-13 16:46:12 -08:00
Matt Friedman
31eb759aa4 [ticket/12060] Use separate template event for acp user signature posting buttons
PHPBB3-12060
2013-12-13 13:36:59 -08:00
Matt Friedman
8864c601a2 [ticket/12060] Rename event from append to after in acp_bbcodes.html
PHPBB3-12060
2013-12-13 13:34:58 -08:00
Paul Tarjan
66c9ca4400 Try running unit tests on HHVM 2013-12-13 11:49:12 -08:00
Joas Schilling
a999dbad74 Merge remote-tracking branch 'vsephpbb/ticket/12063' into develop
* vsephpbb/ticket/12063:
  [ticket/12063] Use CSS to replace valign=top
  [ticket/12063] Remove obsolete valign attributes from tr tags
2013-12-13 20:28:22 +01:00
Matt Friedman
7bc4571753 [ticket/12063] Use CSS to replace valign=top
PHPBB3-12063
2013-12-13 10:33:38 -08:00
Matt Friedman
b26e4dd42c [ticket/12060] Correctly label alpha versions in event docblocks
PHPBB3-12060
2013-12-13 10:31:04 -08:00
Cesar G
c42bd28d17 [ticket/12009] Prevent user from enabling invalid extension through direct URL
PHPBB3-12009
2013-12-12 14:40:03 -08:00
Matt Friedman
21e269b9ca [ticket/12060] Fix u_action comments in docblocks
PHPBB3-12060
2013-12-12 14:09:58 -08:00
Matt Friedman
75831dc2d0 [ticket/12060] Change @since in event docblocks
PHPBB3-12060
2013-12-12 14:09:30 -08:00
Matt Friedman
730a05bd30 [ticket/12060] Update the docblock comments in acp core events
PHPBB3-12060
2013-12-12 13:59:30 -08:00
Matt Friedman
caca36bc50 [ticket/12060] Refactor u_action in the events that use it
PHPBB3-12060
2013-12-12 13:58:59 -08:00
Matt Friedman
6ccec39e43 [ticket/12060] Use $sql_ary instead of $sql
PHPBB3-12060
2013-12-12 13:50:13 -08:00
Cesar G
2735982c55 [ticket/12009] Update functional test to check for invalid extensions.
PHPBB3-12009
2013-12-12 13:03:04 -08:00
Cesar G
495ded59f3 [ticket/12009] Fix functional tests.
PHPBB3-12009
2013-12-12 12:24:16 -08:00
Cesar G
31234b26d8 [ticket/12009] Move valid extensions in tests to correct dir structure.
PHPBB3-12009
2013-12-12 10:52:51 -08:00
Matt Friedman
b6eb1f66e1 [ticket/12060] Update docblock for core event due to addition of another var
PHPBB3-12060
2013-12-12 10:37:11 -08:00
Matt Friedman
a59bbeed2d [ticket/11966] Merge branch 'develop' into ticket/11966
PHPBB3-11966
2013-12-12 10:28:10 -08:00
Matt Friedman
1be42e7ab2 [ticket/12054] Reword descriptions and resort events alphabetically
PHPBB3-12054
2013-12-12 10:11:53 -08:00
Matt Friedman
9e0dd14e19 [ticket/12060] Remove re-tabbing of html from subsilver2 files
PHPBB3-12060
2013-12-12 09:56:51 -08:00
Matt Friedman
0156136c85 [ticket/12060] Add $update_this_message var to the core event
PHPBB3-12060
2013-12-12 09:56:00 -08:00
Matt Friedman
b1e05be6ea [ticket/12060] Adjust last item in array to use a comma instead of closing parenthesis
PHPBB3-12060
2013-12-12 09:55:21 -08:00
Matt Friedman
3659ba884e [ticket/12060] Copy this_u_action back to original this->u_action var
PHPBB3-12060
2013-12-12 09:54:46 -08:00
Oliver Schramm
e6b91de17b [ticket/10023] Make password change notification more noticeable
PHPBB3-10023
2013-12-12 16:57:06 +01:00
Joas Schilling
da6ced59d9 Merge remote-tracking branch 'vsephpbb/ticket/12064' into develop
* vsephpbb/ticket/12064:
  [ticket/12064] Delete obsolete viewsource.html file from adm/style/
2013-12-12 10:29:31 +01:00
Joas Schilling
4816446c4a Merge remote-tracking branch 'Marc/ticket/11859' into develop
* Marc/ticket/11859:
  [ticket/11859] Add missing get_template_name method to test drivers
  [ticket/11859] Make avatar drivers return template filename
2013-12-12 10:21:36 +01:00
Cesar G
4d65727acc [ticket/12009] Do not allow incorrectly structured extensions to be installed.
PHPBB3-12009
2013-12-11 23:11:52 -08:00
Joas Schilling
d252ef3f60 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12061] Fix keyboard shortcut in firefox

Conflicts:
	phpBB/styles/prosilver/template/overall_footer.html
2013-12-09 01:23:29 +01:00
Joas Schilling
6658cd279c Merge remote-tracking branch 'Elsensee/ticket/12061' into develop-olympus
* Elsensee/ticket/12061:
  [ticket/12061] Fix keyboard shortcut in firefox
2013-12-09 01:21:24 +01:00
Andreas Fischer
d5742d7ec1 Merge remote-tracking branch 'imkingdavid/ticket/12069' into develop
* imkingdavid/ticket/12069:
  [ticket/12069] Globalize  in submit_post()
2013-12-08 21:43:06 +01:00
David King
6b081433c5 [ticket/12069] Globalize in submit_post()
PHPBB3-12069
2013-12-08 15:08:30 -05:00
Nathan Guse
b5bfe7b3ca Merge pull request #1923 from prototech/ticket/12067
[ticket/12067] Remove double scrollbar from notifications dropdown.
2013-12-08 12:04:14 -08:00
Nathan Guse
e379b84c7b Merge pull request #1926 from imkingdavid/ticket/12069
[ticket/12069] Fix event documentation
2013-12-08 12:03:33 -08:00
David King
0b76880816 [ticket/12069] Fix event documentation
PHPBB3-12069
2013-12-08 15:01:53 -05:00
Nathan Guse
44a0e91ab9 Merge pull request #1925 from imkingdavid/ticket/12069
[ticket/12069] Add core.submit_post_end event
2013-12-08 11:47:07 -08:00
David King
fdac051956 [ticket/12069] Add core.submit_post_end event
PHPBB3-12069
2013-12-08 14:42:46 -05:00
Marc Alexander
47ea6bc9e6 Merge branch 'develop' of https://github.com/phpbb/phpbb into ticket/11997
Conflicts:
	tests/functional/fixtures/ext/foo/bar/config/services.yml
2013-12-07 13:32:19 +01:00
Marc Alexander
f32a30eeca [ticket/11997] Fix tests for path_helper's get_controller_redirect_url()
PHPBB3-11997
2013-12-07 13:28:44 +01:00
Marc Alexander
a7f2788c72 [ticket/11997] Use get_controller_redirect_url() in redirect() function
This method of path_helper will now be used instead of the previous hack
of the phpbb_own_realpath() function.

PHPBB3-11997
2013-12-07 13:25:04 +01:00
Marc Alexander
8bbede4251 [ticket/11997] Add method for controller redirect URLs to path helper
This method will allow us to get proper redirect URLs for controllers.

PHPBB3-11997
2013-12-07 13:23:57 +01:00
Marc Alexander
8370857f04 [ticket/11997] Undo changes to phpbb_own_realpath()
PHPBB3-11997
2013-12-07 13:20:40 +01:00
Cesar G
6098134cc6 [ticket/12067] Remove double scrollbar from notifications dropdown.
PHPBB3-12067
2013-12-07 00:43:55 -08:00
Cesar G
3ccc8add10 [ticket/12038] Do not rely on stale order value to move items.
This makes it possible to move the items more than once with AJAX.

PHPBB3-12038
2013-12-06 13:02:11 -08:00
Oliver Schramm
204d6781d8 [ticket/12061] Fix keyboard shortcut in firefox
PHPBB3-12061
2013-12-06 19:59:33 +01:00
Joas Schilling
71169de823 Merge remote-tracking branch 'prototech/ticket/11241' into develop
* prototech/ticket/11241:
  [ticket/11241] Retain button gradient when menu is active.
  [ticket/11241] Fix the disappearing dropdown when responsive changes take effect
  [ticket/11241] Add border to dropdown menu options.
  [ticket/11241] Add events & var for extensions to dropdown.
  [ticket/11241] Fix the dropdown in RTL languages.
  [ticket/11241] Use DEFINE for the block.
  [ticket/11241] Consolidate topic actions into "Topic tools" dropdown.
  [ticket/11241] Add dropdown control button.
2013-12-06 12:54:32 +01:00
Cesar G
dbe7154065 [ticket/11241] Retain button gradient when menu is active.
PHPBB3-11241
2013-12-06 03:32:49 -08:00
Cesar G
664e7862d0 [ticket/11241] Fix the disappearing dropdown when responsive changes take effect
PHPBB3-11241
2013-12-06 00:56:31 -08:00
Cesar G
42a70154fa [ticket/11241] Add border to dropdown menu options.
PHPBB3-11241
2013-12-06 00:56:31 -08:00
Cesar G
5579dc2412 [ticket/11241] Add events & var for extensions to dropdown.
PHPBB3-11241
2013-12-06 00:56:31 -08:00
Cesar G
a25b1e6a40 [ticket/11241] Fix the dropdown in RTL languages.
PHPBB3-11241
2013-12-06 00:56:31 -08:00
Cesar G
9c9c20ad55 [ticket/11241] Use DEFINE for the block.
PHPBB3-11241
2013-12-06 00:56:31 -08:00
Cesar G
e110d591a9 [ticket/11241] Consolidate topic actions into "Topic tools" dropdown.
PHPBB3-11241
2013-12-06 00:56:24 -08:00
Cesar G
4b0410a9d9 [ticket/11241] Add dropdown control button.
PHPBB3-11241
2013-12-06 00:44:48 -08:00
Joas Schilling
4684ba0869 Merge remote-tracking branch 'cyberalien/ticket/11979' into develop
* cyberalien/ticket/11979:
  [ticket/11979] Fix errors in dropdown
  [ticket/11979] Add ability to create dropdown menu to prosilver
2013-12-06 09:31:30 +01:00
Cesar G
823d2b697a [ticket/12038] Use $move_executed in place of $db->sql_affectedrows().
PHPBB3-12038
2013-12-06 00:09:36 -08:00
Cesar G
9e8ee56404 [ticket/12038] AJAXify move up/down buttons in report/denial reasons page.
PHPBB3-12038
2013-12-05 23:45:01 -08:00
Cesar G
58a0764759 [ticket/12038] AJAXify move up/down buttons in custom profile fields page.
PHPBB3-12038
2013-12-05 23:44:07 -08:00
Cesar G
97558e5fd4 [ticket/12038] AJAXify move up/down buttons in the permission roles page.
PHPBB3-12038
2013-12-05 23:43:16 -08:00
Cesar G
d399d255b6 [ticket/12038] AJAXify move up/down buttons in the module management pages.
PHPBB3-12038
2013-12-05 23:41:26 -08:00
Cesar G
8d9cc63c19 [ticket/12038] AJAXify move up/down buttons in the smilies/topic icons page.
PHPBB3-12038
2013-12-05 23:41:21 -08:00
Cesar G
7b86a5bc60 [ticket/12038] Check that the move action succeeded before moving the rows.
PHPBB3-12038
2013-12-05 22:31:27 -08:00
Matt Friedman
63276dacda [ticket/12064] Delete obsolete viewsource.html file from adm/style/
PHPBB3-12064
2013-12-05 16:29:49 -08:00
Matt Friedman
88aa7b88a4 [ticket/12063] Remove obsolete valign attributes from tr tags
PHPBB3-12063
2013-12-05 16:25:51 -08:00
Matt Friedman
f41638ebbf [ticket/12060] Fix typo in core.acp_bbcodes_edit_add doc block
PHPBB3-12060
2013-12-05 13:52:20 -08:00
Matt Friedman
d93200c973 [ticket/12060] Add bbcode tokens array to core.acp_bbcodes_edit_add
PHPBB3-12060
2013-12-05 13:49:47 -08:00
Nathan Guse
7f08a33b9f Merge pull request #1917 from VSEphpbb/ticket/12062
[ticket/12062] Fix to allow extensions to use INCLUDEJS in the ACP
2013-12-05 10:08:00 -08:00
Matt Friedman
5530942468 [ticket/12062] Fix to allow extensions to use INCLUDEJS in the ACP
PHPBB3-12062
2013-12-05 09:55:52 -08:00
Matt Friedman
fba2c2c680 [ticket/12060] Use actions class for BBCodes list in ACP
PHPBB3-12060
2013-12-04 19:36:52 -08:00
Matt Friedman
02ddc181d6 [ticket/12060] Fix a core typo in display_custom_bbcodes doc block
PHPBB3-12060
2013-12-04 16:46:28 -08:00
Matt Friedman
feb4ae13f4 [ticket/12060] Add event core.modify_text_for_format_display_after
Use this event to modify the text after it is parsed

PHPBB3-12060
2013-12-04 16:45:30 -08:00
Matt Friedman
e179f25154 [ticket/12060] Add event core.modify_bbcode_init
Use this event to modify the bbcode data for later parsing

PHPBB3-12060
2013-12-04 16:45:02 -08:00
Matt Friedman
5195f9c299 [ticket/12060] Add event core.display_custom_bbcodes_modify_sql
Modify the SQL statement retrieving the custom bbcodes

PHPBB3-12060
2013-12-04 16:44:21 -08:00
Matt Friedman
8f309a70db [ticket/12060] Add $phpbb_dispatcher to acp_bbcodes.php for events
PHPBB3-12060
2013-12-04 16:43:26 -08:00
Matt Friedman
2e33095177 [ticket/12060] Add acp event core.acp_bbcodes_display_bbcodes
Modify display of bbcodes in the form

PHPBB3-12060
2013-12-04 16:42:55 -08:00
Matt Friedman
79b8ecad4d [ticket/12060] Add acp event core.acp_bbcodes_display_form
Modify bbcode template data before we display the form

PHPBB3-12060
2013-12-04 16:42:07 -08:00
Matt Friedman
226376c573 [ticket/12060] Add acp event core.acp_bbcodes_modify_create
Modify bbcode data before modify/create

PHPBB3-12060
2013-12-04 16:40:41 -08:00
Matt Friedman
a4d20d988b [ticket/12060] Add acp event core.acp_bbcodes_edit_add
Modify bbcode template before we display the add/edit form

PHPBB3-12060
2013-12-04 16:39:10 -08:00
Matt Friedman
bd8c444c12 [ticket/12060] Wrap subsilver2 posting buttons in div with id tags
Wrap the posting buttons in div tags with id attributes to allow needed
ability to process them with CSS, for example, to hide them.

PHPBB3-12060
2013-12-04 16:37:16 -08:00
Matt Friedman
35da9ab9cf [ticket/12060] Add template events posting_editor_buttons_before/after
PHPBB3-12060
2013-12-04 16:35:11 -08:00
Matt Friedman
60a51eddd4 [ticket/12060] Add template event acp_bbcodes_actions_prepend/append
PHPBB3-12060
2013-12-04 16:32:47 -08:00
Matt Friedman
b3a96f0a70 [ticket/12060] Add template event acp_bbcodes_edit_form_append
PHPBB3-12060
2013-12-04 16:32:27 -08:00
Nathan Guse
b878763ba5 Merge pull request #1914 from VSEphpbb/ticket/12059
[ticket/12059] Allow INCLUDECSS to work with ACP templates
2013-12-04 15:54:09 -08:00
Matt Friedman
097fba9fdf [ticket/12059] Allow INCLUDECSS to work with ACP templates
PHPBB3-12059
2013-12-04 15:51:14 -08:00
Cesar G
03509f2f97 [ticket/12055] Alternate table row background colors using nth-child rule.
PHPBB3-12055
2013-12-04 14:53:07 -08:00
Nathan Guse
e3a0540fa6 Merge pull request #1912 from marc1706/ticket/12058
[ticket/12058] Add missing apostrophe to avatar_types migration queries
2013-12-04 14:43:30 -08:00
Marc Alexander
53be0a4432 [ticket/12058] Add missing apostrophe to avatar_types migration queries
PHPBB3-12058
2013-12-04 23:40:38 +01:00
Nathan Guse
1d243b78bb Merge pull request #1813 from marc1706/ticket/11912
[ticket/11912] Add mimetype guesser for proper mimetype guessing
2013-12-04 14:12:25 -08:00
Nathan Guse
97bf88dd32 Merge pull request #1879 from Pico88/ticket/12026
[ticket/12026] Correct path for template files
2013-12-04 13:59:59 -08:00
Nathan Guse
e399a52816 Merge pull request #1887 from nickvergessen/ticket/skouat/10910
[ticket/10910] Function build_cfg_template() allow $size for $tpl_type = select
2013-12-04 09:48:10 -08:00
Joas Schilling
b474917ba3 Merge remote-tracking branch 'Marc/ticket/11842' into develop
* Marc/ticket/11842:
  [ticket/11842] Add functional test for creating group
  [ticket/11842] Use avatar_data for obtaining driver that should be deleted
  [ticket/11842] Use type map for updating avatar types in database
  [ticket/11842] Add missing prefix for group id in avatar data
  [ticket/11842] Use only new avatar type in user_delete function
  [ticket/11842] Add migration file for updating avatar type in database
  [ticket/11842] Replace outdated occurences of user and group avatar_type
  [ticket/11842] Use group_id 0 and correct avatar name after creating group
2013-12-04 17:20:20 +01:00
Joas Schilling
fa33abaf0d Merge remote-tracking branch 'bantu/ticket/12056-develop' into develop
* bantu/ticket/12056-develop:
  [ticket/12056] group_user_attributes: Fix "Creating ... from empty value".
  [ticket/12056] Fix "Call to undefined function ...\utf8_normalize_nfc()"
  [ticket/12056] Fix "Call to undefined function ...\utf8_clean_string()"
  [ticket/12056] Fix "Call to a member function trigger_event() on a non-object".
  [ticket/12056] Fix "Call to undefined function phpbb\phpbb_get_plural_form()".
  [ticket/12056] Fix "undefined function phpbb_pcre_utf8_support()".
  [ticket/12056] validate_config_vars: Fix ".. undefined function utf8_strlen()"
  [ticket/12056] validate_config_vars: Fix "Creating ... from empty value".
  [ticket/12056] validate_range: Fix "Creating default object from empty value"
  [ticket/12056] build_select: Fix "Creating default object from empty value"
  [ticket/12056] h_radio test: Fix "Creating default object from empty value"
2013-12-04 16:01:32 +01:00
Marc Alexander
80fa658e8f [ticket/11842] Add functional test for creating group
PHPBB3-11842
2013-12-04 15:58:07 +01:00
Joas Schilling
8087a76c36 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12056] Fix failure due to "Creating default object from empty value".
2013-12-04 15:57:25 +01:00
Joas Schilling
0e93c2516c Merge remote-tracking branch 'bantu/ticket/12056' into develop-olympus
* bantu/ticket/12056:
  [ticket/12056] Fix failure due to "Creating default object from empty value".
2013-12-04 15:56:03 +01:00
Marc Alexander
abb2def48d [ticket/11842] Use avatar_data for obtaining driver that should be deleted
PHPBB3-11842
2013-12-04 15:42:17 +01:00
Andreas Fischer
3a03b01ce0 [ticket/12056] group_user_attributes: Fix "Creating ... from empty value".
PHPBB3-12056
2013-12-04 14:22:33 +01:00
Andreas Fischer
ffc24a507d [ticket/12056] Fix "Call to undefined function ...\utf8_normalize_nfc()"
PHPBB3-12056
2013-12-04 14:16:10 +01:00
Andreas Fischer
d589696827 [ticket/12056] Fix "Call to undefined function ...\utf8_clean_string()"
PHPBB3-12056
2013-12-04 14:13:59 +01:00
Andreas Fischer
b41781ed64 [ticket/12056] Fix "Call to a member function trigger_event() on a non-object".
PHPBB3-12056
2013-12-04 13:51:42 +01:00
Andreas Fischer
d63ac61b19 [ticket/12056] Fix "Call to undefined function phpbb\phpbb_get_plural_form()".
PHPBB3-12056
2013-12-04 13:46:51 +01:00
Andreas Fischer
417fddf710 [ticket/12056] Fix "undefined function phpbb_pcre_utf8_support()".
PHPBB3-12056
2013-12-04 13:44:33 +01:00
Andreas Fischer
7e160e4fc0 [ticket/12056] validate_config_vars: Fix ".. undefined function utf8_strlen()"
PHPBB3-12056
2013-12-04 13:37:56 +01:00
Andreas Fischer
0f41241273 [ticket/12056] validate_config_vars: Fix "Creating ... from empty value".
PHPBB3-12056
2013-12-04 13:36:23 +01:00
Andreas Fischer
70e47bc929 [ticket/12056] validate_range: Fix "Creating default object from empty value"
PHPBB3-12056
2013-12-04 13:33:19 +01:00
Andreas Fischer
c07b44716c [ticket/12056] build_select: Fix "Creating default object from empty value"
PHPBB3-12056
2013-12-04 13:31:12 +01:00
Andreas Fischer
c659fe4cbe [ticket/12056] h_radio test: Fix "Creating default object from empty value"
PHPBB3-12056
2013-12-04 13:29:40 +01:00
Andreas Fischer
e41cd384f5 [ticket/12056] Fix failure due to "Creating default object from empty value".
PHPBB3-12056
2013-12-04 13:22:47 +01:00
Matt Friedman
186f3ecb7e [ticket/12054] Update index_body_linklist_before/after template events
PHPBB3-12054
2013-12-03 17:20:32 -08:00
Joas Schilling
8b2d515736 Merge remote-tracking branch 'prototech/ticket/11672' into develop
* prototech/ticket/11672:
  [ticket/11672] Move the reapply_sid() call before meta_refresh() is called.
  [ticket/11672] Remove duplicate $request global.
  [ticket/11672] The json response call exits so the else is not necessary.
  [ticket/11672] Remove the messages for lock/unlock/change topic type.
  [ticket/11672] Clean up the logic in mcp_queue.php.
  [ticket/11672] Remove some messages that were missed in mcp_queue.php.
  [ticket/11672] Replace sprintf() usage with $user->lang().
  [ticket/11672] Removed unnecessary text from alerts.
2013-12-03 21:10:25 +01:00
Pico88
9e18867cc5 Merge pull request #1 from nickvergessen/ticket/pico88/12026-2
Ticket/pico88/12026
2013-12-03 10:53:50 -08:00
Joas Schilling
8f504b1ca5 Merge remote-tracking branch 'cyberalien/ticket/11969' into develop
* cyberalien/ticket/11969:
  [ticket/11969] Change topic link to unread post in subsilver2
  [ticket/11969] Change topic link to unread post in prosilver
  [ticket/11969] New language strings for first and last post links
2013-12-03 18:29:10 +01:00
Joas Schilling
8a6d01591b Merge remote-tracking branch 'vsephpbb/ticket/12014' into develop
* vsephpbb/ticket/12014:
  [ticket/12014] Change event date in docs
  [ticket/12014] Fix version number in event docs
  [ticket/12014] Template Event index_body.html before forumlist
2013-12-03 18:18:09 +01:00
Joas Schilling
9fbeae3e0c [ticket/12026] Add functional test for ucp extension module
PHPBB3-12026
2013-12-03 18:10:33 +01:00
Joas Schilling
a5f1dc67b9 [ticket/12026] Remove root path, its prepended later
PHPBB3-12026
2013-12-03 18:10:20 +01:00
Joas Schilling
a8e29f0804 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11699] Also exclude the phpBB/cache directory.
  [ticket/11699] Properly exclude the .git directory. Namely missing dot prefix.
  [ticket/11699] Exclude build/new_version and build/old_versions from lint.
2013-12-02 23:33:24 +01:00
Joas Schilling
1977a10efb Merge remote-tracking branch 'bantu/ticket/11699' into develop-olympus
* bantu/ticket/11699:
  [ticket/11699] Also exclude the phpBB/cache directory.
  [ticket/11699] Properly exclude the .git directory. Namely missing dot prefix.
  [ticket/11699] Exclude build/new_version and build/old_versions from lint.
2013-12-02 23:32:39 +01:00
Joas Schilling
dfe7896a4d Merge remote-tracking branch 'bantu/ticket/12050' into develop
* bantu/ticket/12050:
  [ticket/12050] Make phpbb_notification_submit_post_base abstract.
2013-12-02 22:21:50 +01:00
Joas Schilling
9be443769a Merge remote-tracking branch 'prototech/ticket/11346' into develop
* prototech/ticket/11346:
  [ticket/11346] Hide "Mark topics read" link when forum is empty.
2013-12-02 21:30:07 +01:00
Joas Schilling
86e629e533 [ticket/12039] Remove debug code
PHPBB3-12039
2013-12-02 13:26:49 +01:00
Joas Schilling
d4da154cda Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12048] Fix the regexp for language keys in custom bbcodes.
2013-12-02 10:07:49 +01:00
Joas Schilling
be338864ef Merge remote-tracking branch 'prototech/ticket/12048' into develop-olympus
* prototech/ticket/12048:
  [ticket/12048] Fix the regexp for language keys in custom bbcodes.
2013-12-02 10:07:06 +01:00
Cesar G
eef1b586d5 [ticket/12048] Fix the regexp for language keys in custom bbcodes.
PHPBB3-12048
2013-12-02 00:53:42 -08:00
Cesar G
5ab5bd6bda [ticket/11346] Hide "Mark topics read" link when forum is empty.
TOTAL_POSTS and TOTAL_USERS are not defined for viewforum.php.

PHPBB3-11346
2013-12-01 17:16:31 -08:00
Andreas Fischer
0b55ab720c [ticket/12050] Make phpbb_notification_submit_post_base abstract.
PHPBB3-12050
2013-12-01 13:03:03 +01:00
Dhruv
d867bda6af Merge remote-tracking branch 'nickvergessen/ticket/12045' into develop
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/ticket/12045:
  [ticket/12045] Only display group selection if there are groups
  [ticket/12045] Correctly close <span> before closing parent tag
  [ticket/12045] Correctly close <dd> with </dd>
2013-11-30 17:21:40 +05:30
Dhruv
09b5499d87 Merge remote-tracking branch 'nickvergessen/ticket/12042' into develop
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/ticket/12042:
  [ticket/12042] Replace B with a more meaningful key name
  [ticket/12042] Add all language strings from PLUpload 2.0 to the language file
2013-11-30 14:14:17 +05:30
Andreas Fischer
981df153d2 [ticket/11699] Also exclude the phpBB/cache directory.
PHPBB3-11699
2013-11-29 14:02:50 +01:00
Andreas Fischer
0834a749e7 [ticket/11699] Properly exclude the .git directory. Namely missing dot prefix.
PHPBB3-11699
2013-11-29 14:00:55 +01:00
Andreas Fischer
4171ef9ed7 [ticket/12046] Use PHP_BINARY environment variable in PHP lint test.
PHPBB3-12046
2013-11-29 13:53:11 +01:00
Andreas Fischer
97b1d70a37 [ticket/11699] Exclude build/new_version and build/old_versions from lint.
PHPBB3-11699
2013-11-29 10:50:38 +01:00
Joas Schilling
5d69eddcf5 [ticket/12045] Only display group selection if there are groups
Also fixed the empty option which is not allowed.

PHPBB3-12045
2013-11-28 13:22:25 +01:00
Joas Schilling
d9c754a650 [ticket/12045] Correctly close <span> before closing parent tag
PHPBB3-12045
2013-11-28 13:17:38 +01:00
Joas Schilling
371cfa4bfc [ticket/12045] Correctly close <dd> with </dd>
PHPBB3-12045
2013-11-28 13:17:07 +01:00
Joas Schilling
f58add8d79 Merge remote-tracking branch 'prototech/ticket/11507' into develop
* prototech/ticket/11507:
  [ticket/11507] Handle empty sets correctly.
  [ticket/11507] Allow group & unapproved post count options to be used alone.
  [ticket/11507] Fix the unapproved posts count query.
  [ticket/11507] Allow the posts awaiting approval value to be 0.
2013-11-28 13:12:12 +01:00
Joas Schilling
13bed15363 Merge remote-tracking branch 'prototech/ticket/12040' into develop
* prototech/ticket/12040:
  [ticket/12040] Prevent AJAX background animation flicker in ACP
2013-11-28 12:20:56 +01:00
Joas Schilling
3585d167ad Merge remote-tracking branch 'prototech/ticket/11869' into develop
* prototech/ticket/11869:
  [ticket/11869] Fix strict standards error when registering.
2013-11-28 12:10:41 +01:00
Cesar G
7da4490402 [ticket/11507] Handle empty sets correctly.
Using the last parameter in $db->sql_in_set() does not give the correct
behaviour expected here. The query should not be negated if the set is empty.

PHPBB3-11507
2013-11-27 21:26:23 -08:00
Cesar G
ef2e5ca966 [ticket/11507] Allow group & unapproved post count options to be used alone.
PHPBB3-11507
2013-11-27 21:26:22 -08:00
Cesar G
c5656747d8 [ticket/11507] Fix the unapproved posts count query.
Only unapproved posts should be counted.

PHPBB3-11507
2013-11-27 21:26:22 -08:00
Cesar G
b41e2d335a [ticket/11507] Allow the posts awaiting approval value to be 0.
PHPBB3-11507
2013-11-27 21:26:18 -08:00
Cesar G
83b1278273 [ticket/11869] Fix strict standards error when registering.
PHPBB3-11869
2013-11-27 20:05:00 -08:00
Joas Schilling
f3d7823050 [ticket/12042] Replace B with a more meaningful key name
PHPBB3-12042
2013-11-27 18:54:51 +01:00
Joas Schilling
6a2d0c345c [ticket/12042] Add all language strings from PLUpload 2.0 to the language file
PHPBB3-12042
2013-11-27 18:09:38 +01:00
Marc Alexander
b0a561117c [ticket/11859] Add missing get_template_name method to test drivers
PHPBB3-11859
2013-11-27 15:28:14 +01:00
Marc Alexander
6618f0ea24 [ticket/11859] Make avatar drivers return template filename
The service name might not follow the expected naming scheme which would
cause abnormally long filenames and confusion for authors that might add
more avatar drivers.

PHPBB3-11859
2013-11-27 15:18:42 +01:00
Joas Schilling
e3eb82cf7d Merge remote-tracking branch 'Marc/ticket/11914' into develop
* Marc/ticket/11914:
  [ticket/11914] Add assets version to included plupload scripts
  [ticket/11914] Update plupload to 2.0.0
  [ticket/11914] Use unix line endings in plupload queue css file
2013-11-27 15:18:39 +01:00
Joas Schilling
de727b80e2 [ticket/12039] Fix option descriptions
PHPBB3-12039
2013-11-27 15:16:40 +01:00
Marc Alexander
33f4d267ef Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/11842
Conflicts:
	phpBB/includes/acp/acp_groups.php
2013-11-27 14:55:24 +01:00
Joas Schilling
e6749261f1 [ticket/12039] Use an abstract class and some more minor adjustments
PHPBB3-12039
2013-11-27 14:16:34 +01:00
Cesar G
680f8eae50 [ticket/12040] Prevent AJAX background animation flicker in ACP
PHPBB3-12040
2013-11-26 10:18:53 -08:00
Joas Schilling
d5743f008d [ticket/12039] Add config:* to the command line interface tool
PHPBB3-12039
2013-11-26 18:11:54 +01:00
Joas Schilling
125e76f9aa Merge remote-tracking branch 'prototech/ticket/12036' into develop
* prototech/ticket/12036:
  [ticket/12036] Re-add missing move up button to module management page.
2013-11-26 14:52:32 +01:00
Joas Schilling
c49e7387d6 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/12037] Fix hard-coded text in acp_inactive.html.

Conflicts:
	phpBB/adm/style/acp_inactive.html
2013-11-26 11:33:17 +01:00
Joas Schilling
afb4585dd9 Merge remote-tracking branch 'prototech/ticket/12037' into develop-olympus
* prototech/ticket/12037:
  [ticket/12037] Fix hard-coded text in acp_inactive.html.
2013-11-26 11:31:43 +01:00
Cesar G
e111d7bd13 [ticket/12037] Fix hard-coded text in acp_inactive.html.
PHPBB3-12037
2013-11-25 12:38:53 -08:00
Cesar G
95e380ec18 [ticket/12036] Re-add missing move up button to module management page.
PHPBB3-12036
2013-11-25 11:56:09 -08:00
Marc Alexander
0d4bf3ff45 [ticket/11842] Use type map for updating avatar types in database
PHPBB3-11842
2013-11-25 13:12:08 +01:00
Cesar G
3da445ada4 [ticket/11963] Fix undefined variable: post_data when mass-approving topics.
PHPBB3-11963
2013-11-23 11:56:56 -08:00
Cesar G
8fa8037b4e [ticket/11963] Delete topic_in_queue notifications in MCP approve_details mode
PHPBB3-11963
2013-11-23 11:03:37 -08:00
Cesar G
a6a23784c3 [ticket/11963] Don't depend on user_notify flag to delete report notifications.
PHPBB3-11963
2013-11-23 10:19:49 -08:00
Marc Alexander
c9c419c431 [ticket/11912] Expect logic exceptions in test if no guesser available
PHPBB3-11912
2013-11-23 01:19:43 +01:00
Marc Alexander
b5e6d107ae [ticket/11842] Add missing prefix for group id in avatar data
PHPBB3-11842
2013-11-23 01:05:39 +01:00
Marc Alexander
943ab555da Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/11912
Conflicts:
	phpBB/config/services.yml
2013-11-23 00:54:56 +01:00
Marc Alexander
e108418824 [ticket/11912] Check if content_guesser is supported with function_exists
PHPBB3-11912
2013-11-23 00:51:29 +01:00
Joas Schilling
2f4d15015e [ticket/10910] Do not add size when its 1 (default)
PHPBB3-10910
2013-11-22 15:52:59 +01:00
Joas Schilling
8c73c9658e [ticket/10910] Fix unit tests
PHPBB3-10910
2013-11-22 15:51:22 +01:00
Mario Skouat
9861cd21dd [ticket/10910] Add unit tests for select
PHPBB3-10910
2013-11-22 15:04:39 +01:00
Mario Skouat
3a00cb0c08 [ticket/10910] Allow setting size selects in build_cfg_template()
PHPBB3-10910
2013-11-22 15:02:44 +01:00
Nils Adermann
0d0b2627f7 Merge pull request #1886 from nickvergessen/ticket/12027
[Ticket/12027] List redis as service in .travis.yml
2013-11-22 03:24:49 -08:00
Joas Schilling
a3df2cb454 [ticket/12027] List redis as service in .travis.yml
PHPBB3-12027
2013-11-22 10:26:05 +01:00
Nathan Guse
6e842f11fc Merge pull request #1884 from nickvergessen/ticket/12015-2
[ticket/12015] Fix variable name and event version
2013-11-21 14:56:05 -08:00
Joas Schilling
2a154d0a10 [ticket/12015] Fix variable name and event version
PHPBB3-12015
2013-11-21 23:42:40 +01:00
Matt Friedman
7f890ebed7 [ticket/12014] Change event date in docs
PHPBB3-12014
2013-11-21 14:31:43 -08:00
Nathan Guse
5220013f9d Merge pull request #1883 from s9e/ticket/12028
[ticket/12028] Replace L_COLON with literal colon
2013-11-21 14:24:56 -08:00
Nathan Guse
b64d94b6bc Merge pull request #1870 from nickvergessen/ticket/12015
Ticket/12015 Enhance events in viewtopic to increase their usability
2013-11-21 14:21:31 -08:00
s9e
263f213ffe [ticket/12028] Replace L_COLON with literal colon
Replace L_COLON with literal colon in JavaScript context.

[ci skip]

PHPBB3-12028
2013-11-21 23:20:16 +01:00
Joas Schilling
e9e667762b [ticket/12015] Fix english grammar
PHPBB3-12015
2013-11-21 23:18:29 +01:00
Nathan Guse
df7fa8e499 Merge pull request #1854 from Pico88/ticket/12005
[ticket/12005] Remove code responsible for PM popup completely
2013-11-21 14:01:23 -08:00
Nathan Guse
be33d37c89 Merge pull request #1856 from prototech/ticket/12001
[ticket/12001] Ensure that form data is sent to server in AJAX requests.
2013-11-21 13:56:03 -08:00
Nathan Guse
38994965f2 Merge pull request #1860 from prototech/ticket/12010
[ticket/12010] Make the navbar icons clickable.
2013-11-21 13:53:02 -08:00
Nathan Guse
355ceac4a0 Merge pull request #1834 from cyberalien/ticket/11984
Move responsive design adjustments
2013-11-21 13:42:48 -08:00
Nathan Guse
6f419b0049 Merge pull request #1869 from prototech/ticket/10810
[ticket/10810] Move color swatches from popup windows to inline blocks.
2013-11-21 13:41:03 -08:00
Nathan Guse
20885ccb8c Merge pull request #1882 from prototech/ticket/11959
[ticket/11959] Trim the list of users from post notifications.
2013-11-21 13:27:52 -08:00
Nathan Guse
6403d6848e Merge pull request #1878 from blitze/ticket/12024
[ticket/12024] Template event overall_header_content_before
2013-11-21 13:26:24 -08:00
Cesar G
e3a28e5e2a [ticket/11959] Rename $extra_cnt to something more descriptive.
PHPBB3-11959
2013-11-21 13:18:28 -08:00
Cesar G
43f454a6c6 [ticket/11959] Use COMMA_SEPARATOR to join the user list.
PHPBB3-11959
2013-11-21 13:15:08 -08:00
Nathan Guse
7c1c870852 Merge pull request #1881 from prototech/ticket/11484
[ticket/11484] Display login box for users following email notification link.
2013-11-21 13:04:46 -08:00
Cesar G
bcf347420e [ticket/11959] Trim the list of users from post notifications.
PHPBB3-11959
2013-11-21 13:02:26 -08:00
Cesar G
44b6f45759 [ticket/11484] Display login box for users following email notification link.
The link used for the latest post now uses view=unread so redirecting the user
using the value for the e parameter is no longer necessary.

PHPBB3-11484
2013-11-21 08:11:17 -08:00
Cesar G
6d45146df7 [ticket/11672] Move the reapply_sid() call before meta_refresh() is called.
The $redirect assignment is not necessary because the variable  has already been
set near the start of the functions. The redirect value will also never default
to index.php because a default value has already been provided when $redirect
is initially assigned and passed to the template as a hidden field.

PHPBB3-11672
2013-11-21 04:45:16 -08:00
Lukasz
fc778fe637 [ticket/12026] Remove phpbb root path
PHPBB3-12026
2013-11-20 23:12:35 +01:00
Lukasz
fa31096cb9 [ticket/12026] Correct path for template files
Correct path for template files in MCP and UCP modules, which are added
via extenstions

PHPBB3-12026
2013-11-20 22:57:41 +01:00
Marc Alexander
3caeb09b18 [ticket/11842] Use only new avatar type in user_delete function
PHPBB3-11842
2013-11-20 17:15:32 +01:00
Marc Alexander
6db967bdd5 [ticket/11842] Add migration file for updating avatar type in database
PHPBB3-11842
2013-11-20 17:12:00 +01:00
Vjacheslav Trushkin
be3bab4946 [ticket/11979] Fix errors in dropdown
PHPBB3-11979
2013-11-20 00:17:28 +02:00
Vjacheslav Trushkin
739f1a3bdd [ticket/11984] Do not resize textarea on touch devices
PHPBB3-11984
2013-11-19 23:58:05 +02:00
Vjacheslav Trushkin
796e22d675 [ticket/11984] Hide <dfn> for invalid extensions
PHPBB3-11984
2013-11-19 23:58:04 +02:00
Vjacheslav Trushkin
366a224a24 [ticket/11984] Fix stray </ul> and active tab hover in ACP
PHPBB3-11984
2013-11-19 23:58:04 +02:00
Vjacheslav Trushkin
094da3ba16 [ticket/11984] Prevent AJAX background animation flicker in prosilver
PHPBB3-11984
2013-11-19 23:58:04 +02:00
Vjacheslav Trushkin
a5c4e4f3ce [ticket/11984] Prevent AJAX background animation flicker in ACP
PHPBB3-11984
2013-11-19 23:58:04 +02:00
Cesar G
bc33fd9950 [ticket/11672] Remove duplicate $request global.
PHPBB3-11672
2013-11-19 07:34:37 -08:00
Cesar G
03e78c33fa [ticket/11672] The json response call exits so the else is not necessary.
PHPBB3-11672
2013-11-19 07:32:49 -08:00
Cesar G
cccb4fb83d [ticket/11672] Remove the messages for lock/unlock/change topic type.
PHPBB3-11672
2013-11-19 07:32:49 -08:00
Cesar G
10bfb212c4 [ticket/11672] Clean up the logic in mcp_queue.php.
PHPBB3-11672
2013-11-19 07:32:49 -08:00
Cesar G
3eda261b8d [ticket/11672] Remove some messages that were missed in mcp_queue.php.
PHPBB3-11672
2013-11-19 07:32:49 -08:00
Cesar G
c6473da412 [ticket/11672] Replace sprintf() usage with $user->lang().
PHPBB3-11672
2013-11-19 07:32:49 -08:00
callumacrae
0faafce4ce [ticket/11672] Removed unnecessary text from alerts.
Messages like "Return to forum last visited" are entirely unnecessary
when using AJAX to delete a post, so this commit removes them.

PHPBB3-11672
2013-11-19 07:32:49 -08:00
OpenShift guest
55670d75b0 [ticket/12024] Add new line
PHPBB3-12024
2013-11-19 09:55:58 -05:00
OpenShift guest
77dc1ac09a [ticket/12024] Correct the 'since' information in event list
PHPBB3-12024
2013-11-19 09:51:47 -05:00
Joas Schilling
46994e8dfb Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11814] Remove redundant text from the topic reply email notification.
2013-11-19 15:28:37 +01:00
Joas Schilling
af3417ce86 Merge remote-tracking branch 'prototech/ticket/11814' into develop-olympus
* prototech/ticket/11814:
  [ticket/11814] Remove redundant text from the topic reply email notification.
2013-11-19 15:28:06 +01:00
Cesar G
f833a42e7e [ticket/11814] Remove redundant text from the topic reply email notification.
PHPBB3-11814
2013-11-19 06:20:37 -08:00
OpenShift guest
122e95486c [ticket/12024] Update events list
PHPBB3-12024
2013-11-18 23:44:59 -05:00
OpenShift guest
bc47455dfb [ticket/12024] Replace newline
PHPBB3-12024
2013-11-18 23:43:39 -05:00
OpenShift guest
9d39457e35 [ticket/12024] Template event overall_header_content_before
http://area51.phpbb.com/phpBB/viewtopic.php?f=111&t=44959
http://tracker.phpbb.com/browse/PHPBB3-12024

PHPBB3-12024
2013-11-18 23:17:03 -05:00
Joas Schilling
8ae315a796 Merge branch 'prep-release-3.1.0-a2' into develop
* prep-release-3.1.0-a2:
  [prep-release-3.1.0-a2] Update version to 3.1.0-a3-dev in install and constant
  [prep-release-3.1.0-a2] Add changelog for alpha2
  [prep-release-3.1.0-a2] Prepare Changelog
  [prep-release-3.1.0-a2] Add migration for 3.1.0-a2
  [prep-release-3.1.0-a2] Update version to 3.1.0-a2
2013-11-19 01:39:25 +01:00
Joas Schilling
d67341ea00 [prep-release-3.1.0-a2] Update version to 3.1.0-a3-dev in install and constant 2013-11-19 01:37:31 +01:00
Joas Schilling
e74b5ac9e3 [prep-release-3.1.0-a2] Add changelog for alpha2 2013-11-19 01:19:20 +01:00
Joas Schilling
212e367bfe [prep-release-3.1.0-a2] Prepare Changelog 2013-11-19 01:18:22 +01:00
Joas Schilling
7678186b09 [prep-release-3.1.0-a2] Add migration for 3.1.0-a2 2013-11-19 01:18:21 +01:00
Joas Schilling
6ee05d369e [prep-release-3.1.0-a2] Update version to 3.1.0-a2 2013-11-19 01:18:21 +01:00
Joas Schilling
d213e23ab6 Merge remote-tracking branch 'Marc/ticket/11896' into develop
* Marc/ticket/11896:
  [ticket/11896] Use $form_time and fix out of bounds $form_time
  [ticket/11896] Correctly document return of null in docblocks
  [ticket/11896] Minor code improvements in phpbb_functional_test_case
  [ticket/11896] Add functional tests for marking all notifications read
  [ticket/11896] Add ability to define expected message after posting
  [ŧicket/11896] Set form_time with time() when marking all notifications read
2013-11-19 01:03:12 +01:00
Nils Adermann
c31787436e Merge pull request #1877 from nickvergessen/ticket/12023
Ticket/12023 New css files missing after update
2013-11-18 15:28:57 -08:00
Joas Schilling
5fe822021b [ticket/12023] Correctly compare the size of the array in ignore_new_files
PHPBB3-12023
2013-11-19 00:23:49 +01:00
Joas Schilling
632d6e9621 [ticket/12023] Add test for failing .css copy
PHPBB3-12023
2013-11-19 00:23:23 +01:00
Marc Alexander
68db335468 [ticket/11997] Remove obsolete failover_flag in function redirect()
This flag is no longer needed as the failover is no longer needed.

PHPBB3-11997
2013-11-17 20:16:02 +01:00
Marc Alexander
0d3396487e [ticket/11896] Use $form_time and fix out of bounds $form_time
PHPBB3-11896
2013-11-14 18:16:29 +01:00
Joas Schilling
ace66f861a Merge remote-tracking branch 'Marc/ticket/12018' into develop
* Marc/ticket/12018:
  [ticket/12018] Use path_helper for admin style CSS in sql report
2013-11-14 17:36:12 +01:00
Marc Alexander
23e2f920f5 [ticket/12018] Use path_helper for admin style CSS in sql report
The path to the admin style CSS is currently created with $phpbb_admin_path.
We should however use the path_helper to correctly link to this file in order
to have a correct link on pages like extensions

PHPBB3-12018
2013-11-14 15:55:04 +01:00
Marc Alexander
7f10312bf2 [ticket/11896] Correctly document return of null in docblocks
Also got rid of previous incorrect comment in docblocks.

PHPBB3-11896
2013-11-14 15:17:25 +01:00
Marc Alexander
df6e03266f [ticket/11912] Remove obsolete "return null" in content_guesser
PHPBB3-11912
2013-11-14 15:12:42 +01:00
Marc Alexander
308329b547 [ticket/11896] Minor code improvements in phpbb_functional_test_case
Use assertContainsLang() and get rid of unnecessary logic in create_post()
and create_topic(). The docblocks were also slightly improved.

PHPBB3-11896
2013-11-14 15:09:49 +01:00
Joas Schilling
692fbf732f Merge remote-tracking branch 'prototech/ticket/12008' into develop
* prototech/ticket/12008:
  [ticket/12008] Update the run time value for the prune notifications cron task
  [ticket/12008] The read_notification_last_gc config setting should be dynamic.
2013-11-14 12:38:06 +01:00
Cesar G
287c2550b8 [ticket/12008] Update the run time value for the prune notifications cron task
PHPBB3-12008
2013-11-14 01:05:58 -08:00
Cesar G
50896305fa [ticket/12008] The read_notification_last_gc config setting should be dynamic.
PHPBB3-12008
2013-11-14 01:05:53 -08:00
David King
8fd1f90e5f Merge pull request #1872 from nickvergessen/ticket/12017
Ticket/12017 Extension tests are broken on current develop
2013-11-13 16:34:32 -08:00
Joas Schilling
1e73e0c954 [ticket/12017] Fix phpbb requirement in composer.json
PHPBB3-12017
2013-11-14 00:15:23 +01:00
Joas Schilling
4e2bb6ef53 [ticket/12017] Copy config/ dir so events work
PHPBB3-12017
2013-11-14 00:14:53 +01:00
Joas Schilling
009a1303f5 [ticket/12017] Remove IN_PHPBB defined check
PHPBB3-12017
2013-11-14 00:14:04 +01:00
Vjacheslav Trushkin
6b39f3b6a7 [ticket/11979] Add ability to create dropdown menu to prosilver
PHPBB3-11979
2013-11-14 00:45:22 +02:00
Joas Schilling
39be6ab521 [ticket/12015] Add some parameters to viewonline events
PHPBB3-12015
2013-11-13 23:44:57 +01:00
Nils Adermann
52845b22f2 Merge pull request #1815 from marc1706/ticket/11525
[ticket/11525] Only remove group or user prefix from given avatar data
2013-11-13 09:52:21 -08:00
Marc Alexander
13a4ceedb1 [ticket/11525] Use foreach instead of array_walk in method clean_row()
This approach is cleaner and probably even faster the previous ways that
included using array_walk() or array_map() and other helper functions
and methods.

PHPBB3-11525
2013-11-13 18:27:40 +01:00
Nils Adermann
e48b2c07eb Merge pull request #1871 from nickvergessen/ticket/12016
Ticket/12016 Event listeners should be services
2013-11-13 08:45:48 -08:00
Joas Schilling
fbf5911ac5 [ticket/12016] Update functional tests to use service for event listeners
PHPBB3-12016
2013-11-13 17:38:58 +01:00
Joas Schilling
d3f9a51709 [ticket/12016] Use a service provider for event listeners
This allows them to use dependency injection

PHPBB3-12016
2013-11-13 17:34:06 +01:00
Joas Schilling
ecda590b86 [ticket/12015] Add @change to events that got changed
PHPBB3-12015
2013-11-13 17:13:18 +01:00
Marc Alexander
27ae58713b Merge pull request #4 from nickvergessen/ticket/marc/11997
Ticket/marc/11997
2013-11-13 07:34:40 -08:00
Joas Schilling
a0fca0acc2 [ticket/11997] Add functional test for redirects in controller
PHPBB3-11997
2013-11-13 16:30:20 +01:00
Joas Schilling
c2c976fe03 [ticket/12015] Add post counting information to event
PHPBB3-12015
2013-11-13 16:24:25 +01:00
Joas Schilling
1efab9ec77 [ticket/12015] Add an event after the post has been assigned to the template
PHPBB3-12015
2013-11-13 14:31:51 +01:00
Joas Schilling
e3b70c4c08 [ticket/12015] Add attachments to core.viewtopic_modify_post_row
PHPBB3-12015
2013-11-13 14:30:20 +01:00
Joas Schilling
f4cff08a19 [ticket/12015] Add more parameters to core.viewtopic_get_post_data
PHPBB3-12015
2013-11-13 14:29:24 +01:00
Joas Schilling
0aed281676 [ticket/11997] Fix missing global
PHPBB3-11997
2013-11-13 11:30:41 +01:00
Joas Schilling
0a7db81426 [ticket/11997] Fix redirects from inside controllers
The redirect url currently uses the web root path. However as we prepend the
full board url later, we need to remove the relative web root path and prepend
the normal root path again. Otherwise redirects from inside routes will not
work as intended.

PHPBB3-11997
2013-11-13 11:30:13 +01:00
Cesar G
97915b467e [ticket/10810] Remove obsolete swatch code.
PHPBB3-10810
2013-11-13 01:27:24 -08:00
Cesar G
c5680ca822 [ticket/10810] Update all palettes.
PHPBB3-10810
2013-11-13 01:24:37 -08:00
Cesar G
9a9669bebd [ticket/10810] Make the color palette usable outside of the editor context.
PHPBB3-10810
2013-11-13 01:01:15 -08:00
Cesar G
0385d16364 [ticket/10810] Move the color palette code to core.js.
PHPBB3-10810
2013-11-12 23:57:27 -08:00
David King
37f73f86e2 Merge pull request #1800 from prototech/ticket/11472
[ticket/11472] Make prosilver's editor.js an asset used by all styles.
2013-11-12 18:16:41 -08:00
Cesar G
13d2d7d036 [ticket/11472] Expand palette cell links to the full block size.
PHPBB3-11472
2013-11-12 18:15:16 -08:00
Cesar G
1ea07e2270 [ticket/11472] Use {T_ASSETS_PATH}.
PHPBB3-11472
2013-11-12 18:15:16 -08:00
Cesar G
b99e87664d [ticket/11472] Update the ACP user signature page.
PHPBB3-11472
2013-11-12 18:15:16 -08:00
Cesar G
79b5e96896 [ticket/11472] Make the color swatch configurable and fix it in subsilver2
PHPBB3-11472
2013-11-12 18:11:56 -08:00
Cesar G
c386bf7911 [ticket/11472] Make prosilver's editor.js an asset used by all styles.
PHPBB3-11472
2013-11-12 18:11:56 -08:00
Matt Friedman
a7ba8d8993 [ticket/12014] Fix version number in event docs
PHPBB3-12014
2013-11-12 10:19:19 -08:00
Andreas Fischer
c19bf3d0d3 Merge remote-tracking branch 'naderman/ticket/11998' into develop
* naderman/ticket/11998:
  [ticket/11998] Make phpbbcli executable and add shebang
2013-11-12 00:56:54 +01:00
Marc Alexander
d43542a434 [ticket/11997] Use $phpbb_filesystem->clean_path() for proper redirect paths
PHPBB3-11997
2013-11-12 00:46:43 +01:00
Marc Alexander
e380eed78e [ticket/11912] Remove obsolete variable $mimetype from content_guesser
PHPBB3-11912
2013-11-12 00:35:52 +01:00
Matt Friedman
e74f1c1790 [ticket/12014] Template Event index_body.html before forumlist
Add content above the forums list (on forum index only)

PHPBB3-12014
2013-11-11 15:28:18 -08:00
Nils Adermann
e567f82d72 [ticket/11998] Make phpbbcli executable and add shebang
PHPBB3-11998
2013-11-12 00:12:34 +01:00
Nils Adermann
592c8b7566 Merge pull request #1849 from bantu/ticket/11998
[ticket/11998] Introduction of the phpBB Console
2013-11-11 15:02:03 -08:00
Marc Alexander
95b22819a7 [ticket/11912] Use inverted $overload for setting function_exists in tests
PHPBB3-11912
2013-11-11 21:59:47 +01:00
Marc Alexander
2d0fb4d166 [ticket/11997] Rename root_dirs_size to superordinate_dirs_count
This variable name better fits what is done with it. A comment explaining
why 2 has to be subtracted from the size of root_dirs has also been added

PHPBB3-11997
2013-11-11 21:55:21 +01:00
Marc Alexander
9d4893b047 [ticket/11912] Remove IN_PHPBB checks from mimetype guesser files
PHPBB3-11912
2013-11-11 21:29:11 +01:00
Marc Alexander
81caa35955 [ticket/11912] Remove obsolete $file_info from plupload
PHPBB3-11912
2013-11-11 21:24:44 +01:00
Marc Alexander
bef6a5a640 [ticket/11912] Introduce guesser priority to mimetype guessers
The mimetype guesser priority can now be set through the service definition.
Mimetypes will be guessed from the guesser with the highest priority to
the one with the lowest priority. Standard priority types have been added
to the service definition file. Any integer value can be used though.
Standard mimetype guessers that do not have the methods get_priority
and set_priority implemented, like the standard MimeTypeGuessers of symfony,
will have the default priority with the value of 0. Lower priority guessers
have values lower than 0 while high priority ones can be added with values
higher than 0.

PHPBB3-11912
2013-11-11 21:18:23 +01:00
Marc Alexander
b1719db47d [ticket/11912] Add extension_guesser for guessing mimetype by extension
The content_guesser now only guesses the mimetype with the function
mime_content_type() while the guessing by extension is done using the
extension_guesser.

PHPBB3-11912
2013-11-11 20:15:28 +01:00
Nathan Guse
d69f35d450 Merge pull request #1853 from nickvergessen/ticket/11927
[ticket/11927] Correctly add new files on update
2013-11-11 09:40:50 -08:00
Joas Schilling
cfb0a41030 Merge remote-tracking branch 'EXreaction/ticket/11943' into develop
* EXreaction/ticket/11943:
  [ticket/11943] New line at EOF for define_error.html
  [ticket/11943] Forgot template file for test
  [ticket/11943] Throw an exception if DEFINE is setup improperly
  [ticket/11943] Split fix_inline_variable_tokens into 3 steps
  [ticket/11943] Require stricter DEFINE statements for templates
  [ticket/11943] Do not quote the value when it is exactly true, false, or null
  [ticket/11943] Add test for DEFINE $VAR = false
2013-11-11 18:23:37 +01:00
Nathan Guse
4bd078e00f Merge pull request #1862 from nickvergessen/ticket/11949
[ticket/11949] Do not prepend leading backslash to cache class name
2013-11-11 09:14:48 -08:00
Nathan Guse
fea933e2e9 Merge pull request #1855 from nickvergessen/ticket/12002
Ticket/12002 Add link hash to extension manager links
2013-11-11 09:08:32 -08:00
Nathan Guse
47e364ae68 [ticket/11943] New line at EOF for define_error.html
PHPBB3-11943
2013-11-11 10:59:17 -06:00
Marc Alexander
0ec644532d Merge pull request #3 from nickvergessen/marc/ticket/11525
Marc/ticket/11525 Part 2
2013-11-10 15:05:59 -08:00
Joas Schilling
a74c560eca [ticket/11525] Fix expected value of group avatar test
PHPBB3-11525
2013-11-11 00:02:12 +01:00
Joas Schilling
32ba402c34 [ticket/11525] Compare correct array to expected value
PHPBB3-11525
2013-11-11 00:01:31 +01:00
Marc Alexander
4468525ee3 Merge pull request #2 from nickvergessen/marc/ticket/11525
Marc/ticket/11525
2013-11-10 14:25:58 -08:00
Joas Schilling
aa84f7de04 [ticket/11525] Prefix id parameter with 'g' again when its a group avatar
PHPBB3-11525
2013-11-10 23:20:48 +01:00
Joas Schilling
47f2caff6b [ticket/11525] Fix doc blocks
PHPBB3-11525
2013-11-10 22:20:15 +01:00
Marc Alexander
6bb9bce40e [ticket/11997] Remove obsolete if statement in phpbb_own_realpath()
PHPBB3-11997
2013-11-10 12:56:09 +01:00
Marc Alexander
95c2b12bf7 [ticket/11896] Add functional tests for marking all notifications read
PHPBB3-11896
2013-11-09 20:35:37 +01:00
Marc Alexander
29d3b08d50 [ticket/11896] Add ability to define expected message after posting
This change will add the ability to define the expected message after a
topic or post has been submitted with the methods create_post() and
create_topic(). If the expected message is not 'POST_STORED', we will not
try to get the topic and post id.

PHPBB3-11896
2013-11-09 20:33:01 +01:00
Marc Alexander
252b5fe4f7 [ŧicket/11896] Set form_time with time() when marking all notifications read
form_time is only set if is passed via the form. Since the mark notifications
read link does not use the form, it will default to 0 causing the mark
notifications logic to only mark notifications read if their time is smaller
or equal to 0. This patch will change ucp_notifications to correctly set
form_time for the confirm_box.

PHPBB3-11896
2013-11-09 20:28:24 +01:00
Nathan Guse
64ed46e682 [ticket/11943] Forgot template file for test
PHPBB3-11943
2013-11-09 11:39:35 -06:00
Nathan Guse
2e5117a71e [ticket/11943] Throw an exception if DEFINE is setup improperly
PHPBB3-11943
2013-11-09 11:14:55 -06:00
Joas Schilling
31e60f0c8d [ticket/11949] Do not prepend leading backslash to cache class name
The container seems to prepend the leading \ itself, so we get an
InvalidArgumentException with message '"'\\phpbb\\cache\\driver\\file'" is
not a valid class name for the "cache.driver" service.'

PHPBB3-11949
2013-11-09 17:06:38 +01:00
Joas Schilling
7344024b10 Merge remote-tracking branch 'dhruv/ticket/12007' into develop
* dhruv/ticket/12007:
  [ticket/12007] Default last_result to 0 instead of false
2013-11-09 15:53:29 +01:00
Nathan Guse
3b68540cee Merge pull request #1857 from nickvergessen/ticket/11922
[ticket/11922] Drop all keys before trying to delete columns to avoid issues
2013-11-08 20:33:18 -08:00
Nathan Guse
6370970f13 [ticket/11943] Split fix_inline_variable_tokens into 3 steps
DEFINE shouldn't add/remove surrounding quotes, but must have the inline
variable tokens fixed

PHPBB3-11943
2013-11-08 22:30:58 -06:00
Cesar G
069cd4a195 [ticket/12010] Make the navbar icons clickable.
PHPBB3-12010
2013-11-08 18:41:59 -08:00
Nathan Guse
da332aa0a5 [ticket/11943] Require stricter DEFINE statements for templates
PHPBB3-11943
2013-11-08 19:55:16 -06:00
Marc Alexander
60dda5577d [ticket/11997] Correctly redirect to front controllers
We currently do a lot of checks in order to prevent users from getting to
a 404 page. However, this logic relies on checking if a file or folder exists.
Due to the front controllers and the URL rewriting in 3.1, it is no longer
possible to rely on existing files for redirecting. This patch will take
care of properly redirecting users to front controller files. An incorrect
link will cause users to get a 404 error though.

PHPBB3-11997
2013-11-08 23:12:42 +01:00
Lukasz
a353673e7c [ticket/12005] Remove PM popup module from DB
PHPBB3-12005
2013-11-08 21:57:12 +01:00
Lukasz
9328d42809 [ticket/12005] Delete templates files
PHPBB3-12005
2013-11-08 21:57:11 +01:00
Lukasz
d5ffb30025 [ticket/12005] Remove language vars used by PM popup
PHPBB3-12005
2013-11-08 21:57:09 +01:00
Lukasz
65fbf87ce7 [ticket/12005] Remove PM popup
PHPBB3-12005
2013-11-08 21:57:08 +01:00
Lukasz
0499c30b2b [ticket/12005] Remove PM popup UCP module
PHPBB3-12005
2013-11-08 21:57:06 +01:00
Lukasz
166e27566a [ticket/12005] Remove PM popup from converter
PHPBB3-12005
2013-11-08 21:57:05 +01:00
Lukasz
57ec9ee49e [ticket/12005] Remove PM popup setting from user preferences
PHPBB3-12005
2013-11-08 21:57:03 +01:00
Dhruv
1173adfe87 [ticket/12007] Default last_result to 0 instead of false
PostgreSQL does not map null/false to 0 and thus this variable causes
an error.

PHPBB3-12007
2013-11-08 23:34:49 +05:30
Joas Schilling
6f33954757 [ticket/11922] Drop all keys before trying to delete columns to avoid issues
On MSSQL columns that have an index can not be dropped.

PHPBB3-11922
2013-11-08 17:45:48 +01:00
Cesar G
253f8d7593 [ticket/12001] Ensure that form data is sent to server in AJAX requests.
PHPBB3-12001
2013-11-08 06:13:55 -08:00
Joas Schilling
7a8a440895 [ticket/12002] Change functional test to use link hash
PHPBB3-12002
2013-11-08 14:08:55 +01:00
Joas Schilling
a6c73ea0c8 [ticket/12002] Add link hash to extension manager links
PHPBB3-12002
2013-11-08 14:08:02 +01:00
David King
082a467cc8 Merge pull request #1845 from nickvergessen/ticket/11994
[ticket/11994] Make extension manager UI less misleading
2013-11-07 17:46:58 -08:00
Joas Schilling
bf7eab423e [ticket/11994] Fix functional tests
PHPBB3-11994
2013-11-08 01:20:04 +01:00
Joas Schilling
d17bf9aa27 [ticket/11994] "Delete data" is only available for disabled extensions
PHPBB3-11994
2013-11-08 01:20:03 +01:00
Joas Schilling
12a6e2c603 [ticket/11994] Filter crawler for better search comparisons
PHPBB3-11994
2013-11-08 01:20:02 +01:00
Joas Schilling
bb0ff715f8 [ticket/11994] Change error level for missing .json file
PHPBB3-11994
2013-11-08 01:20:02 +01:00
Joas Schilling
05c97fd03c [ticket/11994] Fix more language
PHPBB3-11994
2013-11-08 01:20:01 +01:00
Joas Schilling
40fcc906a2 [ticket/11994] Fix tests after uninstall rename
PHPBB3-11994
2013-11-08 01:20:00 +01:00
Joas Schilling
f8e92efc3f [ticket/11994] Rename "uninstall" to "delete data"
PHPBB3-11994
2013-11-08 01:20:00 +01:00
Joas Schilling
7e1a02b3a1 [ticket/11994] Make install/enable just one UI thing
PHPBB3-11994
2013-11-08 01:19:59 +01:00
Joas Schilling
476464374a [ticket/11994] Update functional tests with display name
PHPBB3-11994
2013-11-08 01:19:58 +01:00
Joas Schilling
473402c77b [ticket/11994] Use display name on confirmation screen
PHPBB3-11994
2013-11-08 01:19:58 +01:00
Joas Schilling
3ac3688a7f [ticket/11994] Fix some language
PHPBB3-11994
2013-11-08 01:19:57 +01:00
Joas Schilling
e60588a259 [ticket/11994] Replace spaces with tabs
PHPBB3-11994
2013-11-08 01:19:56 +01:00
Joas Schilling
f98ddb23e8 [ticket/11994] Fix functional extension tests
PHPBB3-11994
2013-11-08 01:19:55 +01:00
Joas Schilling
7bc6f32100 [ticket/11994] More language fixes
PHPBB3-11994
2013-11-08 01:19:55 +01:00
Joas Schilling
8d5fcc8d4c [ticket/11994] Make extension manager UI less misleading
Enable and Install were split into two different expressions.
Purge was renamed to uninstall to make clearer what is going to happen.

PHPBB3-11994
2013-11-08 01:19:54 +01:00
Joas Schilling
95348c8f6d [ticket/11927] Prefix function with phpbb_
PHPBB3-11927
2013-11-07 13:49:55 +01:00
Joas Schilling
0e33c8d3d2 [ticket/11927] Add doc block to new function
PHPBB3-11927
2013-11-07 13:26:43 +01:00
Joas Schilling
7aa4d8fce2 [ticket/11927] Correctly add new files on update
Currently we ignore language and style files when the directory where they
go to do not exist. However in 3.1 we introduce some new sub directories:
* language/en/email/short/
* styles/prosilver/theme/en/
So we need to change our check to look whether the language or style exist,
rather then the parent directory.

PHPBB3-11927
2013-11-07 13:12:58 +01:00
Andreas Fischer
00294e3dae [ticket/11998] Turn develop/extensions.php into console commands.
PHPBB3-11998
2013-11-05 21:40:42 +01:00
Andreas Fischer
73ea5daf97 [ticket/11998] Add phpBB abstraction for application and command.
PHPBB3-11998
2013-11-05 19:42:34 +01:00
Andreas Fischer
6bd2a89efc [ticket/11998] Move application file to bin/phpbbcli.php
PHPBB3-11998
2013-11-05 19:10:33 +01:00
Marc Alexander
fbedce8d4a [ticket/11914] Add assets version to included plupload scripts
PHPBB3-11914
2013-11-05 17:01:59 +01:00
Nathan Guse
cc54e6a9e5 Merge pull request #1819 from marc1706/ticket/11534
[ticket/11534] Check remote avatar content type if possible
2013-11-04 10:22:28 -08:00
Nathan Guse
b49d3a1851 [ticket/11943] Do not quote the value when it is exactly true, false, or null
Quoting these can change the meaning of the value (e.g. 'false' == true)

PHPBB3-11943
2013-11-04 12:21:12 -06:00
Nathan Guse
c609f25bae [ticket/11943] Add test for DEFINE $VAR = false
PHPBB3-11943
2013-11-04 12:15:02 -06:00
Nathan Guse
ad69d5af8a Merge pull request #1788 from VSEphpbb/ticket/11935
[ticket/11935] Fix invalid HTML and Errors
2013-11-04 09:43:34 -08:00
Nathan Guse
817a21dcfc Merge pull request #1826 from imkingdavid/ticket/11975
[ticket/11975] Add ACP link next to MCP link in header
2013-11-04 09:38:32 -08:00
Dhruv
27e54f9473 Merge remote-tracking branch 'prototech/ticket/11899' into develop
# By Cesar G
# Via Cesar G
* prototech/ticket/11899:
  [ticket/11899] Give indication of activity after voting in poll.
2013-11-04 00:42:59 +05:30
Dhruv
0e0e12963a Merge remote-tracking branch 'prototech/ticket/11928' into develop
# By Cesar G
# Via Cesar G
* prototech/ticket/11928:
  [ticket/11928] Javascript requires camel case.
  [ticket/11928] Rename loadingAlert to loading_indicator.
  [ticket/11928] Make sure the indicator is on top of other elements.
  [ticket/11928] Replace AJAX loading popup with animation.
2013-11-04 00:28:02 +05:30
Cesar G
478c3ea3a0 [ticket/11928] Javascript requires camel case.
PHPBB3-11928
2013-11-03 10:49:28 -08:00
Dhruv
efe94e9c73 Merge remote-tracking branch 'nickvergessen/ticket/11973' into develop
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/ticket/11973:
  [ticket/11973] Remove logic from tokens language array
2013-11-04 00:11:23 +05:30
Andreas Fischer
e02836b19c Merge remote-tracking branch 'Noxwizard/ticket/11990' into develop
* Noxwizard/ticket/11990:
  [ticket/11990] Remove result_mssqlnative usage in acp_database.php
2013-11-03 18:09:44 +01:00
Joas Schilling
478d4971a6 Merge remote-tracking branch 'cyberalien/ticket/11977' into develop
* cyberalien/ticket/11977:
  [ticket/11977] Remove data and change code in acp_modules
  [ticket/11977] Use CSS instead of JS to disable up/down icons
2013-11-03 15:08:05 +01:00
Vjacheslav Trushkin
a6117c51b9 [ticket/11977] Remove data and change code in acp_modules
PHPBB3-11977
2013-11-03 15:36:20 +02:00
Andreas Fischer
743a0560c3 [ticket/11998] Add console command for recalculating email hash.
PHPBB3-11998
2013-11-03 13:02:48 +01:00
Patrick Webster
ad44407b19 [ticket/11990] Remove result_mssqlnative usage in acp_database.php
The class result_mssqlnative was removed in ticket 11980. This removes
the dependency on that class from the database backup utility. It is
possible to use the sqlsrv functions to retrieve the field information,
but they must be then mapped back to type names. That mapping was removed
in 11980 and it is easier to just look it up in the information schema
table.

PHPBB3-11990
2013-11-03 00:37:18 -05:00
Andreas Fischer
a1af10848d [ticket/11998] Also setup extension class loader.
PHPBB3-11998
2013-11-03 03:28:04 +01:00
Andreas Fischer
5db1ec163d [ticket/11998] Use container to get all commands using 'console.command' tag.
PHPBB3-11998
2013-11-03 03:24:06 +01:00
Andreas Fischer
aec5b9d156 [ticket/11998] Basic console application script.
PHPBB3-11998
2013-11-03 02:49:50 +01:00
Andreas Fischer
edfc48a71c [ticket/11998] Add symfony/console as dependency.
PHPBB3-11998
2013-11-03 01:52:40 +01:00
David King
6ee8f19fea [ticket/11975] Remove copy/paste fail, fix tests
PHPBB3-11975
2013-11-02 15:53:40 -07:00
David King
47f7992bf1 [ticket/11975] Change shortened ACP/MCP label to Administer/Moderate
Also utilizing the new data-responsive-text attribute

PHPBB3-11975
2013-11-02 15:34:19 -07:00
David King
54e82392f0 [ticket/11975] Make link text shorter on smaller resolutions
PHPBB3-11975
2013-11-02 15:34:18 -07:00
David King
abd035fcc9 [ticket/11975] Add ACP link next to MCP link in header
PHPBB3-11975
2013-11-02 15:34:18 -07:00
Nils Adermann
8f88ff093e Merge pull request #1821 from imkingdavid/ticket/11972
[ticket/11972] Add template events to posting page
2013-11-02 15:31:01 -07:00
David King
37aff2077a [ticket/11972] Fix the sinces
PHPBB3-11972
2013-11-02 15:27:53 -07:00
David King
567d4dab99 [ticket/11972] Add the sinces
PHPBB3-11972
2013-11-02 15:27:53 -07:00
David King
835900123e [ticket/11972] Add posting_editor_message_after template event
PHPBB3-11972
2013-11-02 15:27:53 -07:00
David King
b8eeca7048 [ticket/11972] Add posting_editor_message_before template event
PHPBB3-11972
2013-11-02 15:27:53 -07:00
David King
3be5fe5354 [ticket/11972] Add posting_editor_subject_before template event
PHPBB3-11972
2013-11-02 15:27:53 -07:00
David King
069f806169 [ticket/11972] Add posting_editor_subject_after template event
PHPBB3-11972
2013-11-02 15:27:52 -07:00
Nathan Guse
63a82f26dd Merge pull request #1848 from prototech/ticket/11746
[ticket/11746] Add "admin activation required" notification
2013-11-02 13:55:09 -07:00
Cesar G
66c08de4cb [ticket/11746] The IN_PHPBB check is not necessary.
PHPBB3-11746
2013-11-02 13:50:09 -07:00
Nathan Guse
2e9b39285d Merge pull request #1840 from cyberalien/ticket/11030
Fix cursor in prosilver and ACP
2013-11-02 13:36:18 -07:00
Vjacheslav Trushkin
b225dd37d7 [ticket/11977] Use CSS instead of JS to disable up/down icons
PHPBB3-11977
2013-11-02 22:31:39 +02:00
Nathan Guse
25995e311c Merge pull request #1790 from prototech/ticket/11280
[ticket/11280] Prevent duplicate entry in forums_track table.
2013-11-02 12:10:19 -07:00
Nathan Guse
0a3bb18e93 Merge pull request #1812 from prototech/ticket/11746
[ticket/11746] Add "admin activation required" notification.
2013-11-02 11:55:16 -07:00
Nathan Guse
4d6c7223b4 Merge pull request #1847 from nickvergessen/ticket/11995
Ticket/11995 Fix Revert of config.remove migration
2013-11-02 11:38:22 -07:00
Joas Schilling
e8a3028ea6 [ticket/11995] Remove exceptions and split reverse into different tests
PHPBB3-11995
2013-11-02 19:26:45 +01:00
Joas Schilling
414a4d587e [ticket/11995] Fix Revert of config.remove
PHPBB3-11995
2013-11-02 18:13:11 +01:00
Joas Schilling
a175b091b9 [ticket/11995] Add unit test for reverting config.remove
PHPBB3-11995
2013-11-02 18:12:50 +01:00
Joas Schilling
8a78699f6c Merge remote-tracking branch 'brunoais/ticket/11663' into develop
* brunoais/ticket/11663:
  [ticket/11663] Add the doc block about the parameters.
  [ticket/11663] Add the doc block about the return value.
  [ticket/11663] Make generate_text_for_storage return the errors.
2013-11-02 16:26:29 +01:00
Nils Adermann
158c998216 Merge pull request #1810 from nickvergessen/ticket/11031
Ticket/11031 Bring phpBB2 converter up to speed with 3.1 changes
2013-11-02 07:20:15 -07:00
Joas Schilling
481d25d885 [ticket/11031] Convert user notification options with default settings
PHPBB3-11031
2013-11-02 13:30:29 +01:00
Joas Schilling
cb8cd50495 [ticket/11031] Correctly add groups to teampage
PHPBB3-11031
2013-11-02 13:25:46 +01:00
Joas Schilling
252a2d7991 Merge remote-tracking branch 'Marc/ticket/11983' into develop
* Marc/ticket/11983:
  [ticket/11983] Add missing argument to docblock in ucp_notifications
2013-11-02 11:00:42 +01:00
Marc Alexander
54b7b2320c [ticket/11983] Add missing argument to docblock in ucp_notifications
The argument $subscriptions was not documented in the docblock of the method
output_notification_types() until now.

PHPBB3-11983
2013-11-02 10:42:16 +01:00
Nils Adermann
e118b4f4c0 Merge pull request #1839 from bantu/task/code-sniffer
More PHP Code Sniffer rules
2013-11-01 07:58:18 -07:00
Nathan Guse
652365158a Merge pull request #1844 from mvinny/ticket/11992
ticket/11992
2013-10-31 11:39:26 -07:00
Marcus Vinny
e4008308fc [ticket/11992] Fix Users with most Warnings block
PHPBB3-11992
2013-10-31 15:30:02 -03:00
Andreas Fischer
ae7ef3e09d [task/code-sniffer] Remove class result_mssqlnative.
PHPBB3-11980
2013-10-31 00:48:03 +01:00
Andreas Fischer
d499db36a0 Merge remote-tracking branch 'prototech/ticket/11987' into develop
* prototech/ticket/11987:
  [ticket/11987] Add {ADMIN_ROOT_PATH}.
  [ticket/11987] Replace {PHPBB_ROOT_PATH} with {ROOT_PATH}.
  [ticket/11987] Change {ROOT_PATH} to point to board root.
2013-10-31 00:44:58 +01:00
Andreas Fischer
f11b7a7828 Merge remote-tracking branch 'prototech/ticket/11991' into develop
* prototech/ticket/11991:
  [ticket/11991] Fix incorrect class name for report_post_closed notification.
2013-10-31 00:44:48 +01:00
Cesar G
831075e5fe [ticket/11987] Add {ADMIN_ROOT_PATH}.
PHPBB3-11987
2013-10-30 16:13:20 -07:00
Cesar G
05dd4d55d2 [ticket/11987] Replace {PHPBB_ROOT_PATH} with {ROOT_PATH}.
PHPBB3-11987
2013-10-30 15:43:07 -07:00
Cesar G
7251feab67 [ticket/11987] Change {ROOT_PATH} to point to board root.
PHPBB3-11987
2013-10-30 15:42:35 -07:00
Cesar G
4b024f035e [ticket/11928] Rename loadingAlert to loading_indicator.
PHPBB3-11928
2013-10-30 15:28:11 -07:00
Cesar G
a95306643e [ticket/11991] Fix incorrect class name for report_post_closed notification.
PHPBB3-11991
2013-10-30 15:17:08 -07:00
Dhruv
a9524d6e08 Merge remote-tracking branch 'nickvergessen/ticket/11974' into develop
# By Joas Schilling
# Via Joas Schilling
* nickvergessen/ticket/11974:
  [ticket/11974] Fix timezone names with underscores
  [ticket/11974] Translate all timezones
2013-10-30 22:43:25 +05:30
Andreas Fischer
10bfb2fe05 [task/code-sniffer] Completely ignore database_update.php.
PHPBB3-11980
2013-10-30 13:56:11 +01:00
Andreas Fischer
ef1f991837 [task/code-sniffer] Replace spaces with tabs.
PHPBB3-11980
2013-10-30 13:37:29 +01:00
Andreas Fischer
7aa8f6461f [task/code-sniffer] Remove the IN_PHPBB check side-effect from class files.
PHPBB3-11980
2013-10-30 13:05:28 +01:00
Andreas Fischer
6ac46ad469 [task/code-sniffer] Add PSR1.Files.SideEffects.FoundWithSymbols
PHPBB3-11980
2013-10-30 11:40:34 +01:00
Vjacheslav Trushkin
7ce34f3f90 [ticket/11030] Fix cursor for checkboxes
PHPBB3-11030
2013-10-30 11:51:16 +02:00
Matt Friedman
16213c92fe [ticket/11935] Merge remote-tracking branch 'upstream/develop'
PHPBB3-11935
2013-10-29 19:12:32 -07:00
Andreas Fischer
49269fbdf4 [task/code-sniffer] Add PSR1.Classes.ClassDeclaration.MissingNamespace
PHPBB3-11980
2013-10-30 01:33:00 +01:00
Andreas Fischer
3944efe528 [task/code-sniffer] Add Generic.WhiteSpace.DisallowSpaceIndent
PHPBB3-11980
2013-10-30 01:15:57 +01:00
erangamapa
dffe790f19 [ticket/11030] Fixing cursor appearing in file upload browse button.
Removed unnecessary cursor CSS properties added for form inputs in both acp
and prosilver styles. Added cursor:pointer property only for buttons.

PHPBB3-11030
2013-10-30 02:10:47 +02:00
Andreas Fischer
63ce04d565 [task/code-sniffer] Add Generic.Functions.CallTimePassByReference
PHPBB3-11980
2013-10-30 00:49:01 +01:00
Andreas Fischer
94334992ec [task/code-sniffer] Add Generic.Formatting.DisallowMultipleStatements
PHPBB3-11980
2013-10-30 00:44:24 +01:00
Andreas Fischer
69a766fe79 [task/code-sniffer] Add OneClassPerFile and OneInterfacePerFile.
PHPBB3-11980
2013-10-30 00:31:39 +01:00
Andreas Fischer
27a180f5d2 [task/code-sniffer] Add Generic.CodeAnalysis.UselessOverridingMethod
PHPBB3-11980
2013-10-30 00:12:47 +01:00
Andreas Fischer
721e652425 [task/code-sniffer] Add Generic.CodeAnalysis.ForLoopShouldBeWhileLoop
PHPBB3-11980
2013-10-29 23:56:11 +01:00
Andreas Fischer
387ed37b31 [task/code-sniffer] Do not abort immediately on PHP Code Sniffer failure.
PHPBB3-11980
2013-10-29 23:53:07 +01:00
Andreas Fischer
02e9f6e284 [task/code-sniffer] Fix argument list spacing.
PHPBB3-11980
2013-10-29 23:38:05 +01:00
Andreas Fischer
d326a49fd0 [task/code-sniffer] Check function/method argument list spacing.
PHPBB3-11980
2013-10-29 21:27:07 +01:00
Cesar G
57fc62b000 [ticket/11928] Make sure the indicator is on top of other elements.
PHPBB3-11928
2013-10-29 10:11:29 -07:00
Cesar G
da4e0c4219 [ticket/11928] Replace AJAX loading popup with animation.
PHPBB3-11928
2013-10-29 07:27:08 -07:00
Andreas Fischer
2f1cf0d287 Merge remote-tracking branch 'prototech/ticket/11986' into develop
* prototech/ticket/11986:
  [ticket/11986] Fix undefined index: poster_id in file.php.
2013-10-29 14:09:43 +01:00
Cesar G
68d80f9952 [ticket/11986] Fix undefined index: poster_id in file.php.
PHPBB3-11986
2013-10-29 06:02:04 -07:00
Nils Adermann
d437f1f133 Merge pull request #1835 from bantu/task/code-sniffer
[task/code-sniffer] Require PHP Code Sniffer to pass
2013-10-28 22:59:33 -07:00
Andreas Fischer
99fccb6f19 [task/code-sniffer] Cleanup code sniffer ruleset files.
PHPBB3-11980
2013-10-29 01:36:37 +01:00
Andreas Fischer
5b66083120 [task/code-sniffer] Reorganise .travis.yml
PHPBB3-11980
2013-10-29 01:03:53 +01:00
Andreas Fischer
92144b370c [task/code-sniffer] Check phpBB/phpbb first. This is where new files go.
PHPBB3-11980
2013-10-29 01:00:24 +01:00
Andreas Fischer
6a7db8d51a [task/code-sniffer] Require code sniffer to pass on Travis CI.
PHPBB3-11980
2013-10-29 00:59:51 +01:00
Andreas Fischer
59e3c2d16e Merge remote-tracking branch 'marc1706/ticket/11981' into develop
* marc1706/ticket/11981:
  [ticket/11981] Fix code sniffer complaints
2013-10-29 00:00:00 +01:00
Joas Schilling
85a12ce4f4 [ticket/11031] Fix group legend position
PHPBB3-11031
2013-10-28 23:28:24 +01:00
Marc Alexander
7f58a4572e [ticket/11981] Fix code sniffer complaints
PHPBB3-11981
2013-10-28 23:05:46 +01:00
Nils Adermann
ed94e3c576 Merge pull request #1784 from nickvergessen/ticket/11924
[Ticket/11924] Add a script to export the events in wiki format
2013-10-28 14:53:59 -07:00
Joas Schilling
88f72bd411 [ticket/11031] Convert timezones to new 3.1 timezone
PHPBB3-11031
2013-10-28 21:54:43 +01:00
Nils Adermann
0ffc3395c5 Merge pull request #1832 from cyberalien/ticket/11982
Fix z-index for AJAX popup background
2013-10-28 11:51:28 -07:00
Vjacheslav Trushkin
5dd199dd60 [ticket/11982] Fix z-index for AJAX popup background
PHPBB3-11982
2013-10-28 20:18:56 +02:00
Nils Adermann
bf08b9ad34 Merge pull request #1818 from cyberalien/ticket/11957
Responsive design for ACP
2013-10-28 10:14:06 -07:00
Nils Adermann
2afd47b938 Merge pull request #1831 from bantu/task/code-sniffer
[task/code-sniffer] Setup PHP Code Sniffer
2013-10-28 09:19:51 -07:00
Vjacheslav Trushkin
2f19b549d8 [ticket/11957] Append new line to install_header
PHPBB3-11957
2013-10-28 13:42:00 +02:00
Andreas Fischer
77ee81c2f6 Merge remote-tracking branch 'marc1706/ticket/11857' into develop
* marc1706/ticket/11857:
  [ticket/11857] Use passed service collection instead of container in manager
2013-10-27 17:56:25 +01:00
Andreas Fischer
8c83acb28b [task/code-sniffer] Add code sniffer rulesets.
PHPBB3-11980
2013-10-27 17:50:58 +01:00
Andreas Fischer
c230701e48 [task/code-sniffer] Run code sniffer in PHP 5.5 / MySQL Travis CI environment.
PHPBB3-11980
2013-10-27 17:43:08 +01:00
Andreas Fischer
e660d1bac1 [task/code-sniffer] Phing target for sniffing.
PHPBB3-11980
2013-10-27 17:43:03 +01:00
Andreas Fischer
c82979a472 [task/code-sniffer] Add PHP CodeSniffer dependency to composer.
PHPBB3-11980
2013-10-27 17:42:58 +01:00
Andreas Fischer
7fb3676957 [task/code-sniffer] Move code sniffer below build folder.
PHPBB3-11980
2013-10-27 17:42:49 +01:00
Marc Alexander
b2f638b793 [ticket/11857] Use passed service collection instead of container in manager
The service collection that was already passed to the avatar manager should
be used in the avatar manager method get_driver() instead of the container
itself.

PHPBB3-11857
2013-10-27 15:08:58 +01:00
Marc Alexander
a4d50d52b6 [feature/passwords] Use correct default type in manager_test
PHPBB3-11610
2013-10-27 14:29:36 +01:00
Marc Alexander
5193b3279c [feature/passwords] Pass list of default types to passwords manager
This list is in the order of how the driver types would be used. If a driver
is not supported we will try the subsequent one.

PHPBB3-11610
2013-10-27 14:18:02 +01:00
Marc Alexander
760f148a2b [feature/passwords] Fix tests on PHP < 5.3.3 again
PHPBB3-11610
2013-10-27 13:22:53 +01:00
Joas Schilling
ce487aad09 [ticket/11974] Fix timezone names with underscores
PHPBB3-11974
2013-10-27 00:48:23 +02:00
Vjacheslav Trushkin
65ab004f96 [ticket/11957] Responsive ACP groups table
PHPBB3-11957
2013-10-27 01:27:31 +03:00
Joas Schilling
2086db0d7a [ticket/11974] Translate all timezones
PHPBB3-11974
2013-10-27 00:21:17 +02:00
Joas Schilling
6a87388e69 [ticket/11973] Remove logic from tokens language array
Previously if a translator did no translate a token, it would not be
displayed. On the other hand, the translator could add additional tokens
which have no functionality.  Functionality is already hardcoded into
bbcode.php so we can that in the ACP aswell, in order to prevent namend
issues.

PHPBB3-11973
2013-10-26 23:55:19 +02:00
Joas Schilling
616574d7ab [ticket/11924] Verify that the script is only run from command line
PHPBB3-11924
2013-10-26 22:53:40 +02:00
Vjacheslav Trushkin
522d5cc3f4 [ticket/11957] Responsive ACP permissions
PHPBB3-11957
2013-10-26 22:45:55 +03:00
Vjacheslav Trushkin
bea94b1f5b [ticket/11957] Fix position of main block for tab-less pages
PHPBB3-11957
2013-10-26 22:16:54 +03:00
Vjacheslav Trushkin
1cdb9a8057 [ticket/11957] Hide other navigation items when one is activated
PHPBB3-11957
2013-10-26 22:11:55 +03:00
Vjacheslav Trushkin
00734741af [ticket/11957] Do not add empty headers to responsive tables
PHPBB3-11957
2013-10-26 22:00:25 +03:00
Vjacheslav Trushkin
e9c0c9d5d2 [ticket/11957] Responsive ACP tabs
PHPBB3-11957
2013-10-26 22:00:25 +03:00
Vjacheslav Trushkin
b79cfa9f4a [ticket/11957] Add z-index to menu
Add z-index to menu to prevent content block from overlapping menu

PHPBB3-11957
2013-10-26 22:00:24 +03:00
Vjacheslav Trushkin
2a1db92955 [ticket/11957] Wrap content in double div
PHPBB3-11957
2013-10-26 22:00:24 +03:00
Vjacheslav Trushkin
c1ca57fcdb [ticket/11957] Misc responsive changes
PHPBB3-11957
2013-10-26 22:00:24 +03:00
Vjacheslav Trushkin
49e30b1243 [ticket/11957] Responsive styles list
PHPBB3-11957
2013-10-26 22:00:24 +03:00
Vjacheslav Trushkin
7b3f63e8a3 [ticket/11957] More responsive forms adjustments
PHPBB3-11957
2013-10-26 22:00:24 +03:00
Vjacheslav Trushkin
b107b4c0e2 [ticket/11957] Responsive forums list
PHPBB3-11957
2013-10-26 22:00:24 +03:00
Vjacheslav Trushkin
10f0c8b333 [ticket/11957] Change avatars gallery from table to list
PHPBB3-11957
2013-10-26 22:00:24 +03:00
Vjacheslav Trushkin
365d07ff6c [ticket/11957] Responsive forms
PHPBB3-11957
2013-10-26 22:00:24 +03:00
Vjacheslav Trushkin
c23c64cb6d [ticket/11957] Responsive jQuery popups
PHPBB3-11957
2013-10-26 22:00:24 +03:00
Vjacheslav Trushkin
9a8b463c33 [ticket/11957] Remove IE6 hacks
PHPBB3-11957
2013-10-26 22:00:23 +03:00
Vjacheslav Trushkin
b80f213995 [ticket/11957] Responsive ACP tables
PHPBB3-11957
2013-10-26 22:00:23 +03:00
Vjacheslav Trushkin
5f39fd470c [ticket/11957] Use fixed width for sidebar
Use fixed width for sidebar and few minor fixes for other items

PHPBB3-11957
2013-10-26 22:00:23 +03:00
Vjacheslav Trushkin
1b3daa1ad8 [ticket/11957] Adjustments to ACP layout, menu and some elements
PHPBB3-11957
2013-10-26 22:00:23 +03:00
Vjacheslav Trushkin
43b9314390 [ticket/11957] Enhance responsive nav with JS
PHPBB3-11957
2013-10-26 22:00:23 +03:00
Vjacheslav Trushkin
8567adf5db [ticket/11957] Include admin.js in footer
Include admin.js in footer, swap .hasjs and .nojs

PHPBB3-11957
2013-10-26 22:00:23 +03:00
Vjacheslav Trushkin
5779c300e4 [ticket/11957] Responsive layout and menu
PHPBB3-11957
2013-10-26 22:00:23 +03:00
Vjacheslav Trushkin
64e26e8c71 [ticket/11957] Remove menu toggle
PHPBB3-11957
2013-10-26 22:00:23 +03:00
Vjacheslav Trushkin
12c5997471 [ticket/11957] Replace corner images with CSS3 corners
PHPBB3-11957
2013-10-26 22:00:22 +03:00
Vjacheslav Trushkin
b3140f58a0 [ticket/11957] Viewport meta for install_update_diff
PHPBB3-11957
2013-10-26 22:00:22 +03:00
Vjacheslav Trushkin
afa71cc15b [ticket/11957] Viewport meta
PHPBB3-11957
2013-10-26 22:00:21 +03:00
David King
b0e0834637 Merge pull request #1817 from cyberalien/ticket/11956
More responsive design adjustments
2013-10-26 11:37:51 -07:00
Vjacheslav Trushkin
e8b4a50a3d [ticket/11956] Ability to swap full and responsive text
PHPBB3-11956
2013-10-26 20:28:36 +03:00
Joas Schilling
35dff79cd8 [ticket/11924] Do not use globals :(
PHPBB3-11924
2013-10-26 18:03:46 +02:00
Nils Adermann
5c5ff6cb7c Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11970] Make apt-get less quiet.
  [ticket/11970] Add set -x to Travis setup scripts.
2013-10-26 10:53:49 -05:00
Nils Adermann
3eb4575f61 Merge remote-tracking branch 'github-bantu/ticket/11970' into develop-olympus
* github-bantu/ticket/11970:
  [ticket/11970] Make apt-get less quiet.
  [ticket/11970] Add set -x to Travis setup scripts.
2013-10-26 10:53:35 -05:00
Vjacheslav Trushkin
c521380273 [ticket/11956] Move code that hides dropdowns to assets
PHPBB3-11956
2013-10-26 16:35:59 +03:00
Vjacheslav Trushkin
368b3f0d9e [ticket/11956] Move dropdown handler to assets
PHPBB3-11956
2013-10-26 16:29:37 +03:00
Vjacheslav Trushkin
ee4c1ba5a8 [ticket/11956] Check for children elements in tables
PHPBB3-11956
2013-10-26 12:22:33 +03:00
Cesar G
c5fc8c43cb [ticket/11746] Delete the notification after user is approved & fix language.
PHPBB3-11746
2013-10-26 01:01:08 -07:00
Andreas Fischer
e65483ac32 [ticket/11970] Make apt-get less quiet.
PHPBB3-11970
2013-10-26 01:39:04 +02:00
Andreas Fischer
3c135ccab2 [ticket/11970] Add set -x to Travis setup scripts.
Output is hidden by Travis by default and this will allow easier debugging.

PHPBB3-11970
2013-10-26 01:37:03 +02:00
Marc Alexander
bb836b65e3 [feature/passwords] Integrate convert_flag with db auth provider
PHPBB3-11610
2013-10-25 15:21:09 +02:00
Andreas Fischer
f40f378483 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11920] Pin MariaDB repository to avoid conflicts with Ubuntu MySQL.
2013-10-25 14:01:41 +02:00
Andreas Fischer
66841a55d0 Merge remote-tracking branch 'bantu/ticket/11920' into develop-olympus
* bantu/ticket/11920:
  [ticket/11920] Pin MariaDB repository to avoid conflicts with Ubuntu MySQL.
2013-10-25 14:01:33 +02:00
Andreas Fischer
acc6e440d0 [ticket/11920] Pin MariaDB repository to avoid conflicts with Ubuntu MySQL.
PHPBB3-11920
2013-10-25 13:21:10 +02:00
Vjacheslav Trushkin
dbd4b5bdbc [ticket/11969] Change topic link to unread post in subsilver2
PHPBB3-11969
2013-10-25 14:18:53 +03:00
Vjacheslav Trushkin
7cb9493489 [ticket/11969] Change topic link to unread post in prosilver
PHPBB3-11969
2013-10-25 14:18:24 +03:00
Vjacheslav Trushkin
23954ac1b8 [ticket/11969] New language strings for first and last post links
PHPBB3-11969
2013-10-25 14:17:51 +03:00
Joas Schilling
157de2d80d [ticket/11031] Fix missing variable lang_file from code conversion
PHPBB3-11031
2013-10-25 13:10:33 +02:00
Joas Schilling
19380a9b08 [ticket/11031] Correctly set topic and post visibility
PHPBB3-11031
2013-10-25 12:36:06 +02:00
Joas Schilling
e9f4be9052 [ticket/11031] Update extension group names after converting them
PHPBB3-11031
2013-10-25 12:09:09 +02:00
Vjacheslav Trushkin
6dedac1929 [ticket/11956] Adjust few elements for tiny devices
Change min-width for tiny phones
Adjust form elements max-width for tiny phones

PHPBB3-11956
2013-10-25 12:50:36 +03:00
Nils Adermann
fe7745a1e8 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [task/github-readme/travis] Fix Travis-Badge and link
2013-10-24 21:54:46 -05:00
Nils Adermann
5e01ea61f9 Merge branch 'task/github-readme/travis' into develop-olympus
* task/github-readme/travis:
  [task/github-readme/travis] Fix Travis-Badge and link
2013-10-24 21:53:47 -05:00
Falk Seidel
98a6f10ce7 [task/github-readme/travis] Fix Travis-Badge and link
PHPBB3-11968
2013-10-24 21:51:49 -05:00
Vjacheslav Trushkin
db9ca2fc63 [ticket/11956] Fix IE responsive breadcrumbs and navigation icon
PHPBB3-11956
2013-10-25 02:20:49 +03:00
Vjacheslav Trushkin
fa8d1eb2dc [ticket/11956] Swap navigation events in header
PHPBB3-11956
2013-10-25 02:20:13 +03:00
Marc Alexander
9b0b5481fe [ticket/11534] Check remote avatar content type if possible
This should make sure that error pages like 404 or 503 pages are not treated
as remote avatar images.

PHPBB3-11534
2013-10-24 23:43:40 +02:00
Marc Alexander
1f624e1367 [ticket/11842] Replace outdated occurences of user and group avatar_type
user_avatar_type und group_avatar_type are now a string and should therefore
be treated accordingly.

PHPBB3-11842
2013-10-24 21:41:41 +02:00
Vjacheslav Trushkin
c879e8c0dd [ticket/11956] Fix asterix position in post menu icon
PHPBB3-11956
2013-10-24 21:28:49 +03:00
Vjacheslav Trushkin
4639d4fc86 [ticket/11956] Reverse order of .rightside items in dropdown
PHPBB3-11956
2013-10-24 20:51:58 +03:00
Nils Adermann
f67ebc2cdb Merge pull request #1816 from cyberalien/ticket/11956
[ticket/11956] More resposive dropdown fixes
2013-10-24 10:00:23 -07:00
Vjacheslav Trushkin
3b1260fd28 [ticket/11956] One more dropdown fix
PHPBB3-11956
2013-10-24 19:59:31 +03:00
Vjacheslav Trushkin
1795f1d54b [ticket/11956] More resposive dropdown fixes
PHPBB3-11956
2013-10-24 19:57:19 +03:00
Nils Adermann
9185fce9d4 Merge pull request #1803 from cyberalien/ticket/11956
Fixes for responsive design
2013-10-24 09:45:16 -07:00
Vjacheslav Trushkin
bbb73d6e5c [ticket/11956] Move dropdown menu from edges of screen
Also add -webkit prefix to box-sizing

PHPBB3-11956
2013-10-24 18:36:18 +03:00
Vjacheslav Trushkin
3134580007 [ticket/11956] More fixes for responsive minitabs
PHPBB3-11956
2013-10-24 18:36:18 +03:00
Vjacheslav Trushkin
fb3a466805 [ticket/11956] Adjustments for responsive minitabs
PHPBB3-11956
2013-10-24 18:36:18 +03:00
Vjacheslav Trushkin
bf964d9570 [ticket/11956] Make notification, pm and forum index icons clickable
PHPBB3-11956
2013-10-24 18:36:18 +03:00
Vjacheslav Trushkin
17a954f454 [ticket/11956] Responsive subforums list
PHPBB3-11956
2013-10-24 18:36:18 +03:00
Vjacheslav Trushkin
a8f14b9ce3 [ticket/11956] Fix docblock for dropdown handler
PHPBB3-11956
2013-10-24 18:36:17 +03:00
Vjacheslav Trushkin
016958ea5e [ticket/11956] Reusable dropdown handler
Replace dropdown menu code with reusable handler that
is shared between all types of dropdown menus and can
be used by custom menus by extensions.

PHPBB3-11956
2013-10-24 18:36:17 +03:00
Vjacheslav Trushkin
6f97367ef0 [ticket/11956] Remove background image from *CP navigation
PHPBB3-11956
2013-10-24 18:36:17 +03:00
Vjacheslav Trushkin
c2f5ab3c6b [ticket/11956] Change .skip-responsive to data attribute
PHPBB3-11956
2013-10-24 18:36:17 +03:00
Vjacheslav Trushkin
11157e4f03 [ticket/11956] Fix responsive linkslist bug
PHPBB3-11956
2013-10-24 18:36:17 +03:00
Vjacheslav Trushkin
02cf80da9d [ticket/11956] Wider pagination links on mobile devices
Wider pagination links on mobile devices. Also fixes
typo in pagination selector.

PHPBB3-11956
2013-10-24 18:36:17 +03:00
Vjacheslav Trushkin
76bfd138c9 [ticket/11956] Fix postprofile popup
PHPBB3-11956
2013-10-24 18:36:17 +03:00
Vjacheslav Trushkin
5eeaab562c [ticket/11956] Responsive quick login form
PHPBB3-11956
2013-10-24 18:36:17 +03:00
Vjacheslav Trushkin
1638ff3cba [ticket/11956] Arrow for responsive popup
PHPBB3-11956
2013-10-24 18:36:16 +03:00
Vjacheslav Trushkin
d11e62930a [ticket/11956] Fix missing class name in index_body.html
PHPBB3-11956
2013-10-24 18:36:16 +03:00
Vjacheslav Trushkin
5e67c41629 [ticket/11956] Better responsive breadcrumbs
PHPBB3-11956
2013-10-24 18:36:16 +03:00
Vjacheslav Trushkin
85b9867edb [ticket/11956] Put bottom nav in one block
PHPBB3-11956
2013-10-24 18:36:16 +03:00
Vjacheslav Trushkin
e6dd672e49 [ticket/11956] Put top navigation in one block
PHPBB3-11956
2013-10-24 18:36:16 +03:00
Vjacheslav Trushkin
431b4acb36 [ticket/11956] Move JS to reusable function
Move JS to reusable function that can be ran
for all content added with JavaScript such as
results of AJAX forms

PHPBB3-11956
2013-10-24 18:36:16 +03:00
Vjacheslav Trushkin
d2d4438db5 [ticket/11956] Adjustments to responsive topiclist lists
Changes behavior of topiclist lists on mobile devices.
Shows/hides certain elements in each row to present all
important information to visitor on mobile devices, such
as last post when viewing forum instead of first post.

Also fixes topiclist layout bug in drafts.html

PHPBB3-11956
2013-10-24 18:36:16 +03:00
Vjacheslav Trushkin
5c51378186 [ticket/11956] Move responsive *CP navigation
Move responsive *CP navigation to cp.css because
layout has to change at width higher than 700px

PHPBB3-11956
2013-10-24 18:36:16 +03:00
Vjacheslav Trushkin
9b78966211 [ticket/11956] Fix errors in drafts.html
PHPBB3-11956
2013-10-24 18:36:15 +03:00
Vjacheslav Trushkin
9833354578 [ticket/11956] Fix topic actions layout
Fix topic actions layout on mobile devices

PHPBB3-11956
2013-10-24 18:36:15 +03:00
Vjacheslav Trushkin
3016e5227b [ticket/11956] Fix responsive jumpbox
PHPBB3-11956
2013-10-24 18:36:15 +03:00
Vjacheslav Trushkin
08811daa74 [ticket/11956] Hide author on mobile devices
Hide duplicate author name in posts on mobile devices

PHPBB3-11956
2013-10-24 18:36:15 +03:00
Vjacheslav Trushkin
4188d178f3 [ticket/11956] Scale down online image for HD display
Scale down online image for HD displays

PHPBB3-11956
2013-10-24 18:36:15 +03:00
Vjacheslav Trushkin
af5e25cdf5 [ticket/11956] Scale down large avatars
Prevent large avatars from breaking layout on any resolution.

PHPBB3-11956
2013-10-24 18:36:14 +03:00
Vjacheslav Trushkin
e660c1a554 [ticket/11956] Fix member list page
PHPBB3-11956
2013-10-24 18:36:14 +03:00
Vjacheslav Trushkin
b196c9e8ff [ticket/11956] Add assets_version to responsive.css link
PHPBB3-11556
2013-10-24 18:36:14 +03:00
Vjacheslav Trushkin
8c5101a729 [ticket/11956] Responsive AJAX alerts
PHPBB3-11956
2013-10-24 18:36:14 +03:00
Joas Schilling
6a2fef97d5 Merge remote-tracking branch 'prototech/ticket/11138' into develop
* prototech/ticket/11138:
  [ticket/11138] Do not use AJAX for ACP resync features.
  [ticket/11138] Increase AJAX timeout period to 15 seconds.
  [ticket/11872] Template syntax typos in oauth templates
2013-10-24 14:08:27 +02:00
Marc Alexander
9d4d212e0f [ticket/11525] Only remove group or user prefix from given avatar data
Until now, the user data had both user_id and group_id keys in the avatar
data. As both group_ and user_ prefixes were removed the group_id was
collapsed onto the user_id and therefore all users in the same group had
the same prefix for their uploaded avatars. This patch will make sure
that the correct id is used depending on whether it's a group's or user's
avatar data.

PHPBB3-11525
2013-10-24 13:55:23 +02:00
Marc Alexander
3c632fa8e4 [ticket/11842] Use group_id 0 and correct avatar name after creating group
It seems like the function group_correct_avatar() was forgotten while adding
the new avatar system. We now pass the group_id 0 to the upload avatar and
let the function group_correct_avatar() fix the avatar filename after creating
the group like it was done previously.

PHPBB3-11842
2013-10-24 13:14:51 +02:00
Marc Alexander
3bd4289562 [ticket/11912] Use lowercase names for guesser services
PHPBB3-11912
2013-10-24 12:10:17 +02:00
Marc Alexander
d25ab02ef3 [ticket/11912] Introduce guesser_interface
This will contain proper documentation of the required methods if anyone
would implement a newer guesser.

PHPBB3-11912
2013-10-24 12:07:26 +02:00
Marc Alexander
bc7ff47537 [ticket/11912] Supply filename to content_guesser for guessing on windows
The filename of the files sent to the guesser by plupload do not contain
the file extension. Therefore, it's impossible to guess the mimetype if
only the content_guesser is available and the function mime_content_type()
doesn't exist. By supplying the filename we can circumvent this issue.

PHPBB3-11912
2013-10-24 12:05:00 +02:00
Marc Alexander
24099583a3 [ticket/11912] Remove typo in content_guesser
PHPBB3-11912
2013-10-24 12:03:46 +02:00
Marc Alexander
973682cb2d [ŧicket/11912] Get rid of obsolete variables in content_guesser
PHPBB3-11912
2013-10-24 12:03:28 +02:00
Cesar G
d607f1c927 [ticket/11746] Add "admin activation required" notification.
PHPBB3-11746
2013-10-24 02:37:20 -07:00
Marc Alexander
4af6270d0f [ticket/11912] Improve extension map in content_guesser
PHPBB3-11912
2013-10-24 11:28:49 +02:00
Cesar G
963dbed106 [ticket/11138] Do not use AJAX for ACP resync features.
PHPBB3-11138
2013-10-23 22:47:44 -07:00
Cesar G
7ab90c6c82 [ticket/11138] Increase AJAX timeout period to 15 seconds.
PHPBB3-11138
2013-10-23 22:33:02 -07:00
Andreas Fischer
2adf3d7a34 Merge remote-tracking branch 'cyberalien/ticket/fixes-only/11872' into develop
* cyberalien/ticket/fixes-only/11872:
  [ticket/11872] Template syntax typos in oauth templates
2013-10-24 00:05:00 +02:00
Marc Alexander
f617aff182 [ticket/11912] Add tests for content_guesser
PHPBB3-11912
2013-10-23 23:18:40 +02:00
Marc Alexander
63945f3687 [ticket/11912] Add content_guesser
The content_guesser will try to use the function mime_content_type()
if it's available. If that is not the case, the content_guesser will try to
guess the mimetype using the file extension of the supplied file.
Since this guesser will be registered after the other guessers, it will
be only used if the other guessers are not available.

PHPBB3-11912
2013-10-23 23:18:22 +02:00
Joas Schilling
881ad935d5 [ticket/11031] Fix conversion of topic_replies to topic_posts
PHPBB3-11031
2013-10-23 21:13:45 +02:00
Joas Schilling
6dd4620609 [ticket/11031] Fix container construction and missing objects
PHPBB3-11031
2013-10-23 21:13:25 +02:00
Matt Friedman
2ae6f216f6 [ticket/11966] Add header navigation template events to Subsilver2
Add the overall_header_navigation_append / prepend template events
used in Prosilver to subsilver2 as well. This will allow extensions to
add Nav Links to Subsilver2.
http://tracker.phpbb.com/browse/PHPBB3-11966

PHPBB3-11966
2013-10-23 11:52:32 -07:00
Marc Alexander
c8040024cb [ticket/11912] Add tests for phpbb mimetype guesser
PHPBB3-11912
2013-10-23 18:36:11 +02:00
Marc Alexander
36d314e032 [ticket/11912] Add phpbb mimetype guesser
Mimetype guesser will be used as front-end file for mimetype guessing.

PHPBB3-11912
2013-10-23 18:34:35 +02:00
Marc Alexander
789d493595 [ticket/11912] Integrate mimetype guesser with plupload
PHPBB3-11912
2013-10-23 18:34:06 +02:00
Vjacheslav Trushkin
cb21c33a14 [ticket/11872] Template syntax typos in oauth templates
PHPBB3-11872
2013-10-23 19:12:37 +03:00
Marc Alexander
b9f950054a [ticket/11914] Update plupload to 2.0.0
There are no longer seperate javascript files for each type of uploader.
New filenames have been kept as used inside the plupload package.

PHPBB3-11914
2013-10-23 14:44:55 +02:00
Marc Alexander
38eb86fe6d [ticket/11914] Use unix line endings in plupload queue css file
PHPBB3-11914
2013-10-23 14:43:02 +02:00
Joas Schilling
d612041cd1 Merge remote-tracking branch 'Marc/ticket/11916' into develop
* Marc/ticket/11916:
  [ticket/11916] Remove files from hidden attach list after deletion
2013-10-23 12:08:20 +02:00
Marc Alexander
c810f1934e [ticket/11916] Remove files from hidden attach list after deletion
The hidden attachment_data list needs to be updated if a file got removed.
This was not done until now and caused a general error after submitting a
post if a file was removed after uploading it.

PHPBB3-11916
2013-10-23 11:50:41 +02:00
Nils Adermann
a7e41b23fd Merge pull request #1801 from nickvergessen/ticket/11948
Ticket/11948 Extensions should be allowed to have more then 1 routing file
2013-10-22 00:29:20 -07:00
Joas Schilling
96317b2c45 [ticket/11948] Check actual result of routes
PHPBB3-11948
2013-10-21 22:18:03 +02:00
Joas Schilling
51561ed538 [ticket/11948] Allow resource importing for routing
PHPBB3-11948
2013-10-21 21:52:48 +02:00
Andreas Fischer
ba5b53521a Merge remote-tracking branch 'marc1706/ticket/11930' into develop
* marc1706/ticket/11930:
  [ticket/11930] Update docblock of avatar driver constructor
  [ticket/11930] Modify order of properties to fit constructor method
  [ticket/11930] Move path_helper in front of optional cache argument
  [ticket/11930] Fix tests after adding phpbb\path_helper to avatar drivers
  [ticket/11930] Use \phpbb\path_helper for avatar URLs
2013-10-21 11:04:23 +02:00
Marc Alexander
a80d5c93e3 [ticket/11930] Update docblock of avatar driver constructor
PHPBB3-11930
2013-10-21 11:02:59 +02:00
Marc Alexander
acbb1ed3ee [ticket/11930] Modify order of properties to fit constructor method
PHPBB3-11930
2013-10-21 10:47:40 +02:00
Marc Alexander
d7bf50bc80 [ticket/11930] Move path_helper in front of optional cache argument
Optional method arguments should be after any mandatory ones.

PHPBB3-11930
2013-10-21 10:20:12 +02:00
Nils Adermann
4649155f41 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11951] Add MariaDB to platforms we test on.
  [ticket/11951] Add MariaDB to supported DBMSes in requirement section.

Conflicts:
	phpBB/docs/INSTALL.html
	phpBB/docs/README.html
2013-10-20 16:05:46 -07:00
Nils Adermann
a5eaaa10dc Merge remote-tracking branch 'github-bantu/ticket/11951' into develop-olympus
* github-bantu/ticket/11951:
  [ticket/11951] Add MariaDB to platforms we test on.
  [ticket/11951] Add MariaDB to supported DBMSes in requirement section.
2013-10-20 16:03:23 -07:00
Matt Friedman
67beb97efe Merge branch 'develop' into ticket/11935 2013-10-20 15:57:57 -07:00
Nils Adermann
1aa80b47b1 Merge pull request #1789 from VSEphpbb/ticket/11936
[Ticket/11936] Notification Avatars - Fixes and Restyling
2013-10-20 15:42:49 -07:00
Matt Friedman
b9358e75bf [ticket/11936] Update color scheme of new no_avatar.gif
PHPBB3-11936
2013-10-20 14:53:44 -07:00
Matt Friedman
3c38f4e20a [ticket/11936] Merge branch 'develop' into ticket/11936
PHPBB3-11936
2013-10-20 14:30:29 -07:00
Andreas Fischer
eda35d15f8 Merge remote-tracking branch 'prototech/ticket/11939' into develop
* prototech/ticket/11939:
  [ticket/11939] Removed unneeded data attribute.
2013-10-20 23:15:25 +02:00
Andreas Fischer
953d31dc75 Merge remote-tracking branch 'prototech/ticket/11923' into develop
* prototech/ticket/11923:
  [ticket/11923] Attempt to translate errors only if user can change avatar.
2013-10-20 22:14:58 +02:00
Andreas Fischer
9c299ad759 Merge remote-tracking branch 'cyberalien/ticket/11945' into develop
* cyberalien/ticket/11945:
  [ticket/11945] Change color for focused button
2013-10-20 22:05:26 +02:00
Nils Adermann
e08db41d0d Merge pull request #1719 from cyberalien/ticket/11552
Responsive design for prosilver
2013-10-20 11:12:55 -07:00
Nils Adermann
3b39a44b00 Merge pull request #1799 from cyberalien/ticket/11947
[ticket/11947] Notification link fixes
2013-10-20 11:07:51 -07:00
Vjacheslav Trushkin
ff10f1ab6a [ticket/11552] Fix non-square avatars in notifications
Old code was changing all avatars to square. This code
will keep 50px height limit without changing aspect ratio.

PHPBB3-11552
2013-10-20 20:48:57 +03:00
Vjacheslav Trushkin
61b5ebfdd3 [ticket/11552] Padding for lists with checkbox
PHPBB3-11552
2013-10-20 20:45:59 +03:00
Vjacheslav Trushkin
2bb094cc19 [ticket/11552] More responsive design adjustments
PHPBB3-11552
2013-10-20 13:12:03 +03:00
Vjacheslav Trushkin
076198da7b [ticket/11552] Adjustments for responsive post buttons
PHPBB3-11552
2013-10-20 11:54:51 +03:00
Vjacheslav Trushkin
87194d6000 [ticket/11552] Better responsive post buttons
PHPBB3-11552
2013-10-20 11:50:47 +03:00
Vjacheslav Trushkin
fef51d199b [ticket/11552] Fixing incorrect min-height
PHPBB3-11552
2013-10-20 11:49:54 +03:00
Vjacheslav Trushkin
87134080b3 [ticket/11552] Responsive design fixes
PHPBB3-11552
2013-10-20 10:35:41 +03:00
Vjacheslav Trushkin
806a9d37f3 [ticket/11552] Adjustments for table headers
PHPBB3-11552
2013-10-20 10:16:27 +03:00
Vjacheslav Trushkin
ff7b140c75 [ticket/11552] Responsive polls
PHPBB3-11552
2013-10-20 09:57:55 +03:00
Joas Schilling
bd86dea16c [ticket/11948] Use basename and dirname
PHPBB3-11948
2013-10-20 00:02:15 +02:00
Andreas Fischer
7df35a288a [ticket/11951] Add MariaDB to platforms we test on.
PHPBB3-11951
2013-10-19 23:08:04 +02:00
Andreas Fischer
6de519431d [ticket/11951] Add MariaDB to supported DBMSes in requirement section.
PHPBB3-11951
2013-10-19 23:05:27 +02:00
Vjacheslav Trushkin
2c15b653cc [ticket/11552] Tweaks to responsive navigation
PHPBB3-11552
2013-10-19 22:30:03 +03:00
Vjacheslav Trushkin
7b972204ae [ticket/11552] Do not hide all links at once
Do not hide some links as long as their is enough space
to keep them out of dropdown menu

PHPBB3-11552
2013-10-19 22:19:32 +03:00
Vjacheslav Trushkin
e9481c41f8 [ticket/11552] Fix online users list and popups
PHPBB3-11552
2013-10-19 21:10:33 +03:00
Vjacheslav Trushkin
734131d750 [ticket/11552] Responsive member list
Responsive member list and better responsive tables

PHPBB3-11552
2013-10-19 21:01:25 +03:00
Matt Friedman
dd25b83ee4 [ticket/11935] Tweak colour swatch table
PHPBB3-11935
2013-10-19 10:14:46 -07:00
Matt Friedman
f003c35fdc [ticket/11935] Replace obsolete table attributes in Admin with CSS
PHPBB3-11935
2013-10-19 08:59:08 -07:00
Matt Friedman
546332b141 [ticket/11935] Remove obsolete table attributes from Prosilver
cellpadding, cellspacing, border are obsolete table attributes.
They are handled by CSS already using table and .table1

PHPBB3-11935
2013-10-19 08:55:13 -07:00
Matt Friedman
5d49a8f06e [ticket/11935] Fix invalid HTML usage of <label> tag in prosilver
PHPBB3-11935
2013-10-19 08:51:08 -07:00
Matt Friedman
8816664d8a [ticket/11935] Fix stray </a> tags
PHPBB3-11935
2013-10-19 08:49:18 -07:00
Matt Friedman
2b7120508b [ticket/11935] Fix incorrect alt tags that should be title tags
PHPBB3-11935
2013-10-19 08:48:41 -07:00
Matt Friedman
6fce4b44a8 [ticket/11935] Fix <p> tags not allowed inside <strong> tags
PHPBB3-11935
2013-10-19 08:47:12 -07:00
Vjacheslav Trushkin
fbd57b9369 [ticket/11552] Responsive PM editor
Responsive PM editor, fix quickmod tools

PHPBB3-11552
2013-10-19 16:20:34 +03:00
Vjacheslav Trushkin
ee8d7b536c [ticket/11552] Responsive post
PHPBB3-11552
2013-10-19 15:40:20 +03:00
Vjacheslav Trushkin
2e5f9ede41 [ticket/11552] Do not collapse empty link lists
PHPBB3-11552
2013-10-19 15:31:09 +03:00
Vjacheslav Trushkin
71723f6484 [ticket/11552] Remove inline css for signature
PHPBB3-11552
2013-10-19 13:24:40 +03:00
Vjacheslav Trushkin
68a4c6acbf [ticket/11552] Move post subject before buttons
PHPBB3-11552
2013-10-19 13:22:47 +03:00
Joas Schilling
d45582d32a [ticket/11948] Allow multiple routing files for extensions
PHPBB3-11948
2013-10-19 12:12:14 +02:00
Joas Schilling
3cc2e619d2 [ticket/11948] Add second routing file to tests
PHPBB3-11948
2013-10-19 12:11:09 +02:00
Vjacheslav Trushkin
1a1d5f7307 [ticket/11552] Change order of postbody and postprofile
PHPBB3-11552
2013-10-19 13:10:11 +03:00
Vjacheslav Trushkin
5f96769b93 [ticket/11552] Scrollbars for iOS devices
Show scroll bars for items with overflow on iOS
devices with touch screen that do not show scroll
bars by default

PHPBB3-11552
2013-10-19 12:47:19 +03:00
Vjacheslav Trushkin
74eb7012a3 [ticket/11552] Responsive user profile
PHPBB3-11552
2013-10-19 12:39:13 +03:00
Vjacheslav Trushkin
9f0b0d9017 [ticket/11552] Fixes for notifications list
PHPBB3-11552
2013-10-19 12:17:38 +03:00
Matt Friedman
cc42191598 [ticket/11936] Additional Notification Bell Icon improvement
PHPBB3-11936
2013-10-18 23:31:18 -07:00
Matt Friedman
802d2add97 [ticket/11936] Replace Notifications icon with a custom bell design
PHPBB3-11936
2013-10-18 23:15:18 -07:00
Matt Friedman
67c4dbf682 [ticket/11936] Update the PM Notification Icon 2013-10-18 20:19:39 -07:00
Matt Friedman
613fa70948 [ticket/11936] Make UCP Notifications page look even better
Make only the Notification Title/Text the href link. Use a font family
and size consistent with rest of phpBB. Make Notification date
smaller too.

PHPBB3-11936
2013-10-18 20:04:01 -07:00
Vjacheslav Trushkin
18d505c171 [ticket/11947] Notification link fixes
Allow clicking child elements of link that toggles notification popup

PHPBB3-11947
2013-10-19 02:18:22 +03:00
Vjacheslav Trushkin
bb0baa4522 [ticket/11552] Fix overflow for large images
PHPBB3-11552
2013-10-19 02:16:59 +03:00
Vjacheslav Trushkin
7464252f60 [ticket/11945] Change color for focused button
PHPBB3-11945
2013-10-19 01:40:55 +03:00
Vjacheslav Trushkin
ea874c2ffb [ticket/11552] Responsive forms
PHPBB3-11552
2013-10-18 23:47:03 +03:00
Vjacheslav Trushkin
12c34e4176 [ticket/11552] Fixes for auto-resize textarea
Changing auto-resize code to work with all possible
box-sizing and checking for negative height.

PHPBB3-11552
2013-10-18 23:43:32 +03:00
Vjacheslav Trushkin
f93d2cbdc1 [ticket/11552] Break long words
Something that should have been added long time
ago, but was not an issue until responsive design

PHPBB3-11552
2013-10-18 22:44:39 +03:00
Vjacheslav Trushkin
a23d4526fd [ticket/11552] Compact mode for notifications and pm links
This will hide part of buttons for notifications and pm links
in header before switching to responsive mode

PHPBB3-11552
2013-10-18 22:32:46 +03:00
Matt Friedman
59e175906e [ticket/11936] Update no avatar image in Prosilver/Subsilver2
PHPBB3-11936
2013-10-18 10:28:41 -07:00
Joas Schilling
667ccbcffb Merge remote-tracking branch 'prototech/ticket/10948' into develop
* prototech/ticket/10948:
  [ticket/10948] Separate color swatch cells.
2013-10-18 10:32:19 +02:00
Cesar G
d9a9083d90 [ticket/10948] Separate color swatch cells.
PHPBB3-10948
2013-10-17 23:43:47 -07:00
Cesar G
c7b88ee1d1 [ticket/11923] Attempt to translate errors only if user can change avatar.
PHPBB3-11923
2013-10-17 21:29:02 -07:00
callumacrae
98c8a29698 [ticket/11939] Removed unneeded data attribute.
PHPBB3-11939
2013-10-17 20:39:54 -07:00
Cesar G
42a4305f19 [ticket/11899] Give indication of activity after voting in poll.
PHPBB3-11899
2013-10-17 19:23:21 -07:00
Marc Alexander
3f0ce78a25 [ticket/11930] Fix tests after adding phpbb\path_helper to avatar drivers
PHPBB3-11930
2013-10-17 20:49:10 +02:00
Vjacheslav Trushkin
bd4dab8026 [ticket/11552] Fix rebase conflicts
PHPBB3-11552
2013-10-17 21:22:17 +03:00
Vjacheslav Trushkin
bc01da9dba [ticket/11552] Fix topiclist selectors
PHPBB3-11552
2013-10-17 21:13:06 +03:00
Vjacheslav Trushkin
cab21f3a1e [ticket/11552] Responsive tables in MCP
PHPBB3-11552
2013-10-17 21:13:06 +03:00
Vjacheslav Trushkin
961a27091e [ticket/11552] MCP fixes, responsive logs
PHPBB3-11552
2013-10-17 21:13:06 +03:00
Vjacheslav Trushkin
8093e4e053 [ticket/11552] Do not wrap site name
PHPBB3-11552
2013-10-17 21:13:05 +03:00
Vjacheslav Trushkin
fd932820df [ticket/11552] Responsive paragraphs
Responsive blocks below topics list and misc items

PHPBB3-11552
2013-10-17 21:13:05 +03:00
Vjacheslav Trushkin
9ccccb8baa [ticket/11552] Fixes for tabs and breadcrumbs
PHPBB3-11552
2013-10-17 21:13:05 +03:00
Vjacheslav Trushkin
378b2dfa96 [ticket/11552] Responsive minitabs
PHPBB3-11552
2013-10-17 21:13:05 +03:00
Vjacheslav Trushkin
34fa93a153 [ticket/11552] Adjustments for CP navigation
PHPBB3-11552
2013-10-17 21:13:05 +03:00
Vjacheslav Trushkin
f655ca3e54 [ticket/11552] Responsive CP navigation
PHPBB3-11552
2013-10-17 21:13:04 +03:00
Vjacheslav Trushkin
118b66534e [ticket/11552] Add search link to responsive header
PHPBB3-11552
2013-10-17 21:12:45 +03:00
Vjacheslav Trushkin
5d999e008c [ticket/11552] Breadcrumbs in footer, tabs bg color
Change breadcrumbs layout in footer to match breadcrumbs
in header. Change background color for tabs dropdown menu

PHPBB3-11552
2013-10-17 21:11:39 +03:00
Vjacheslav Trushkin
e5788cbda8 [ticket/11552] Disable responsive JS for IE8-
PHPBB3-11552
2013-10-17 21:11:38 +03:00
Vjacheslav Trushkin
8ea5a77aa2 [ticket/11552] Join functions for hiding tabs and menu
PHPBB3-11552
2013-10-17 21:11:38 +03:00
Vjacheslav Trushkin
a1f118872b [ticket/11552] Responsive CP tabs
PHPBB3-11552
2013-10-17 21:11:38 +03:00
Vjacheslav Trushkin
88cbd68d00 [ticket/11552] Responsive notifications list, pagination
PHPBB3-11552
2013-10-17 21:11:38 +03:00
Vjacheslav Trushkin
7e683cb14d [ticket/11552] Insert responsive menu toggle before li.rightside
Insert responsive menu toggle before li.rightside to prevent
li.rightside:last-child css rule from not working

PHPBB3-11552
2013-10-17 21:11:38 +03:00
Vjacheslav Trushkin
9b4001a786 [ticket/11552] Align text to left in right side popups
PHPBB3-11552
2013-10-17 21:11:37 +03:00
Vjacheslav Trushkin
28fbbcbbc1 [ticket/11552] Hide other popups when menu is toggled
PHPBB3-11552
2013-10-17 21:11:37 +03:00
Vjacheslav Trushkin
70a4bab9ed [ticket/11552] Limit width of linklists
Limit width of left/right aligned link lists

PHPBB3-11552
2013-10-17 21:11:37 +03:00
Vjacheslav Trushkin
dbb6fc2ebe [ticket/11552] Responsive menu
PHPBB3-11552
2013-10-17 21:11:03 +03:00
Vjacheslav Trushkin
c15ab90c38 [ticket/11552] More breadcrumbs adjustments
PHPBB3-11552
2013-10-17 21:08:32 +03:00
Vjacheslav Trushkin
464248d341 [ticket/11552] Tooltips for breadcrumbs
PHPBB3-11552
2013-10-17 21:08:31 +03:00
Vjacheslav Trushkin
77a9635495 [ticket/11552] Keep first nav row on same line
PHPBB3-11552
2013-10-17 21:08:31 +03:00
Vjacheslav Trushkin
b84f0791b2 [ticket/11552] Change breadcrumbs structure
PHPBB3-11552
2013-10-17 21:08:31 +03:00
Vjacheslav Trushkin
284fb30958 [ticket/11552] Display checkbox in forums list
PHPBB3-11552
2013-10-17 21:08:31 +03:00
Vjacheslav Trushkin
5e8eec6330 [ticket/11552] Move breadcrumbs up
Remove spacing between navigation and breadcrumbs
Fix comments format in responsive.css

PHPBB3-11552
2013-10-17 21:08:31 +03:00
Vjacheslav Trushkin
f3d83def0a [ticket/11552] Responsive forums list
PHPBB3-11552
2013-10-17 21:08:31 +03:00
Vjacheslav Trushkin
744a91dc7b [ticket/11552] Responsive breadcrumbs
PHPBB3-11552
2013-10-17 21:07:41 +03:00
Vjacheslav Trushkin
a189c38853 [ticket/11552] Add .nojs or .hasjs to body
Add .nojs to body element, swap it to .hasjs when
JavaScript is enabled

PHPBB3-11552
2013-10-17 21:03:53 +03:00
Vjacheslav Trushkin
befffe7472 [ticket/11552] Basic rules for wrappers and header
Basic rules for content wrapper, common block wrappers and header

PHPBB3-11552
2013-10-17 21:03:53 +03:00
Vjacheslav Trushkin
5c3669eccb [ticket/11552] Add link to responsive.css
Add link to responsive.css and blank responsive.css

PHPBB3-11552
2013-10-17 21:03:53 +03:00
Vjacheslav Trushkin
7cf0cdb67e [ticket/11552] Viewport meta for mobile devices
PHPBB3-11552
2013-10-17 21:03:52 +03:00
Marc Alexander
e1fc008d15 [ticket/11930] Use \phpbb\path_helper for avatar URLs
This will ensure that avatars still properly display on extension pages
supplied via app.php.

PHPBB3-11930
2013-10-17 14:20:59 +02:00
Cesar G
403da5d38d [ticket/11280] Prevent duplicate entry in forums_track table.
Enforcing a time limit prevents all rows from being selected, thus a new row
is inserted resulting in a duplicate entry.

PHPBB3-11280
2013-10-16 23:56:45 -07:00
Matt Friedman
1f2714e695 [ticket/11936] Remove "px" from html syntax
PHPBB3-11936
2013-10-16 18:02:18 -07:00
Matt Friedman
7c0e839fe3 [ticket/11936] Add no_avatars to UCP list Notifications too
PHPBB3-11936
2013-10-16 17:33:01 -07:00
Matt Friedman
25f287a991 [ticket/11936] Use "no_avatar.gif" if needed in Notification window 2013-10-16 17:23:25 -07:00
Matt Friedman
b7f1f3d38f [ticket/11936] Restyle the notification text (no underline/decoration)
PHPBB3-11936
2013-10-16 17:22:02 -07:00
Matt Friedman
cc884be593 [ticket/11936] Fix Avatar overflow issue in Notification window
PHPBB3-11936
2013-10-16 17:21:22 -07:00
Nathan Guse
852b707b48 Merge pull request #1781 from VSEphpbb/ticket/11921
Ticket/11921 - Streamline PMs and Notifications in Header Link List
2013-10-16 10:50:17 -07:00
Matt Friedman
ab8ac5e284 [ticket/11921] Directly inject unread messages count into the template
PHPBB3-11921
2013-10-16 10:26:33 -07:00
Matt Friedman
bd58c31ee0 [ticket/11921] Only get the count of unread PMs
PHPBB3-11921
2013-10-16 10:08:29 -07:00
Matt Friedman
2867831232 [ticket/11921] Move any HTML for Notifications to the templates
PHPBB3-11921
2013-10-16 10:07:54 -07:00
Nathan Guse
d062402c4b [ticket/11902] Prevent errors if set_time_limit disabled
PHPBB3-11902
2013-10-16 11:08:33 -05:00
Joas Schilling
91eeebfb07 [ticket/11924] Remove duplicated code
PHPBB3-11924
2013-10-16 16:38:22 +02:00
Joas Schilling
3c9a8a3788 [ticket/11924] Fix some minor issues with the php event docs
PHPBB3-11924
2013-10-16 16:32:40 +02:00
Joas Schilling
e04a06ab94 [ticket/11924] Add option to export php event list
PHPBB3-11924
2013-10-16 16:32:00 +02:00
Andreas Fischer
ecc756e12e Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11920] Print MariaDB version after successful setup.
  [ticket/11920] Manually purge mysql-common.
  [ticket/11920] Actually call travis/setup-mariadb.sh.
2013-10-16 02:17:11 +02:00
Nils Adermann
16ab35c1b5 Merge pull request #1782 from bantu/ticket/11920
[ticket/11920] Actually call travis/setup-mariadb.sh.
2013-10-15 16:34:32 -07:00
Joas Schilling
a03965554e [ticket/11924] Reduce unneccessary load
PHPBB3-11924
2013-10-16 00:48:51 +02:00
Joas Schilling
fa5fdc53b6 [ticket/11924] Add version info of template events to events.md
PHPBB3-11924
2013-10-16 00:45:28 +02:00
Joas Schilling
9cf634e517 [ticket/11924] Add script to export events.md with wiki markup
PHPBB3-11924
2013-10-16 00:39:52 +02:00
Joas Schilling
5f788e40d8 [ticket/11924] Bring layout of events.md to one style
PHPBB3-11924
2013-10-16 00:37:54 +02:00
Andreas Fischer
5a481bb176 [ticket/11920] Print MariaDB version after successful setup.
PHPBB3-11920
2013-10-16 00:25:07 +02:00
Andreas Fischer
0f64f0edc4 [ticket/11920] Manually purge mysql-common.
PHPBB3-11920
2013-10-16 00:24:44 +02:00
Joas Schilling
7afff1e5bd Merge pull request #1783 from bantu/ticket/11926
[ticket/11926] Fix plupload migration dependency.
2013-10-15 15:04:38 -07:00
Andreas Fischer
2adbd08714 [ticket/11926] Fix plupload migration dependency.
PHPBB3-11926
2013-10-16 00:02:51 +02:00
Matt Friedman
457ca9c763 [ticket/11921] Remove "l_" from non-lang variables
PHPBB3-11921
2013-10-15 14:09:47 -07:00
Joas Schilling
3bb93ab2d3 [develop] Update version to 3.1.0-a2-dev 2013-10-15 22:46:02 +02:00
Andreas Fischer
878cb836f5 [ticket/11920] Actually call travis/setup-mariadb.sh.
PHPBB3-11920
2013-10-15 22:44:49 +02:00
Nils Adermann
437d38bc05 Merge remote-tracking branch 'github-phpbb/develop-olympus' into develop
* github-phpbb/develop-olympus:
  [ticket/11920] Have to use empty root password otherwise db creation fails.
  [ticket/11920] Add MariaDB environment to Travis-CI.

Conflicts:
	.travis.yml
2013-10-15 13:36:42 -07:00
Nils Adermann
8131700330 Merge pull request #1780 from bantu/ticket/11920
[ticket/11920] Add MariaDB environment to Travis-CI.
2013-10-15 13:34:51 -07:00
Matt Friedman
8608204097 [ticket/11921] Improve appearance of PM notifications in linklist
PHPBB3-11921
2013-10-15 10:29:15 -07:00
Matt Friedman
9363986f43 [ticket/11921] Improve appearance of Notifications in linklist
PHPBB3-11921
2013-10-15 10:27:00 -07:00
Joas Schilling
3521dfc278 Merge remote-tracking branch 'p/prep-release-3.1.0-a1' into develop
* p/prep-release-3.1.0-a1:
  [prep-release-3.1.0-a1] Update changelog with the latest changes
  [ticket/11919] Remove extra argument to notification manager's sql_fetchfield()
  [ticket/11918] Make sql_freeresult() consistent across all DB drivers
  [prep-release-3.1.0-a1] Only build packages for the latest olympus versions
  [prep-release-3.1.0-a1] Update changelog with 3.1.0-a1 changes
  [prep-release-3.1.0-a1] Update version to 3.1.0-a1
2013-10-15 18:40:43 +02:00
Andreas Fischer
55e24eb4f8 [ticket/11920] Have to use empty root password otherwise db creation fails.
PHPBB3-11920
2013-10-15 16:57:16 +02:00
Andreas Fischer
cdaea7a406 [ticket/11920] Add MariaDB environment to Travis-CI.
PHPBB3-11920
2013-10-15 16:28:59 +02:00
Marc Alexander
87bd628241 [feature/passwords] Minor cleanup in passwords files
PHPBB3-11610
2013-10-14 14:31:00 +02:00
Marc Alexander
61f60d395a [feature/passwords] Use passwords manager service instead of functions
The old functions phpbb_hash() and phpbb_check_hash() have been replaced with
the passwords manager service in all front-end related files. The phpBB2
converter and the release_3_0_5_rc1 migration file have not been changed.
The same applies to the security/hash_test that still tests the function
phpbb_check_hash(). This will however make sure that the old function
still works.

PHPBB3-11610
2013-10-13 16:32:37 +02:00
Marc Alexander
e674313559 [feature/passwords] Use passwords.manager service in login_forum_box()
Additionally, unused variables have been removed from the globals and
the request class is now used instead of the request_var() function.

PHPBB3-11610
2013-10-13 16:09:55 +02:00
Marc Alexander
0f64843ac8 [feature/passwords] Use VCHAR_UNI instead of VCHAR_CI for user_passwords
PHPBB3-11610
2013-10-13 12:06:02 +02:00
Marc Alexander
1d57ec1f65 [feature/passwords] Add functional tests for forum passwords
PHPBB3-11610
2013-10-13 12:06:02 +02:00
Marc Alexander
841dd6b19f [feature/passwords] Modify forum_password column type for new hash types
PHPBB3-11610
2013-10-13 12:05:55 +02:00
Marc Alexander
b795ce8b7d [feature/passwords] Remove obsolete hashing functions from functions.php
These hashing functions have been worked into the salted md5 driver.

PHPBB3-11610
2013-10-11 13:34:40 +02:00
Marc Alexander
da39707d16 [feature/passwords] Mark old hashing functions as deprecated
PHPBB3-11610
2013-10-11 13:34:15 +02:00
Marc Alexander
ce51f878eb [feature/passwords] Add phpass copyright notice to salted md5 driver
PHPBB3-11610
2013-10-11 09:43:30 +02:00
Nathaniel Guse
3e694f784d [ticket/11902] Set max execution time to 0 in db update
PHPBB3-11902
2013-10-10 10:05:20 -05:00
Marc Alexander
7c347864a4 [feature/passwords] Fix tests for 8th bit characters in bcrypt on PHP < 5.3.7
PHPBB3-11610
2013-10-10 12:09:50 +02:00
Marc Alexander
fdf9ae7c18 [feature/passwords] Increase test coverage to 100% of methods
Obsolete code that is impossible to hit has been removed and the logic
of the salted md5 driver has been changed to correctly implement the
phpBB 3.0 phpbb_hash() function.

PHPBB3-11610
2013-10-10 12:01:10 +02:00
Marc Alexander
cd74fb0946 [feature/passwords] Increase test coverage to 35 out ouf 36 methods
Only one small code part in the salted md5 driver can't be tested right now.
Passwords helper and passwords driver helper are now fully covered by tests.

PHPBB3-11610
2013-10-09 22:53:13 +02:00
Marc Alexander
3b6038cfcd [feature/passwords] Add tests for unique_id() method in helper
PHPBB3-11610
2013-10-09 14:28:57 +02:00
Marc Alexander
f1d2949985 [feature/passwords] Move check for 8-bit characters to bcrypt driver
PHPBB3-11610
2013-10-07 16:00:52 +02:00
Dhruv
2b959e3331 [ticket/11288] Handle +,- without preceeding whitespace characters
PHPBB3-11288
2013-10-05 21:09:52 +05:30
Dhruv
7a971f896d Merge branch 'ticket/11271' into ticket/11271-develop
# By erangamapa (7) and Dhruv (2)
* ticket/11271:
  [ticket/11271] Typecast forum and topic id to integer
  [ticket/11271] Use absolute path for displaying inline attachments in feeds
  [ticket/11271] Changed executable bit.
  [ticket/11271] Formatting code and removing null assignment.
  [ticket/11271] Removing unnecessary database object
  [ticket/11271] Separated attachment fetching query
  [ticket/11271] Fetched feed attachments before loop.
  [ticket/11271] Removed in-line attachment comments properly.
  [ticket/11271] Displaying in-line attached images in ATOM feed.

Conflicts:
	phpBB/feed.php
2013-10-05 16:54:09 +05:30
Nathan Guse
efe130bcfc [ticket/11881] Limit to 500
PHPBB3-11881
2013-10-04 15:04:30 -05:00
Nathan Guse
cd7d29b90e [ticket/11881] Make sure user_timezone isn't converted twice
PHPBB3-11881
2013-10-04 15:04:08 -05:00
Nathan Guse
9653276ebc [ticket/11881] Better split the timezone conversion into chunks; add test
PHPBB3-11881
2013-10-04 12:10:27 -05:00
Dhruv
c73801242d [ticket/11271] Typecast forum and topic id to integer
PHPBB3-11271
2013-10-04 20:51:17 +05:30
Marc Alexander
035db5e08b [feature/passwords] Fix hash_test for use of passwords manager
PHPBB3-11610
2013-10-03 10:23:17 +02:00
Marc Alexander
7006db7a2d Merge branch 'develop' of https://github.com/phpbb/phpbb3 into feature/passwords
Conflicts:
	phpBB/includes/functions.php
2013-10-03 10:04:59 +02:00
Marc Alexander
93531e7fb0 [feature/passwords] Add prepending backslash to class namespaces
PHPBB3-11610
2013-10-02 23:45:32 +02:00
Nathan
ee89ede59f [ticket/11881] Timezone migration can take a long time
PHPBB3-11881
2013-10-02 14:23:01 -05:00
Marc Alexander
e7e11112b1 [feature/passwords] Fix tests after changes to phpBB hashing functions
PHPBB3-11610
2013-10-02 17:24:11 +02:00
Marc Alexander
3aba3235d5 [feature/passwords] Use passwords manager in phpBB hash functions
PHPBB3-11610
2013-10-02 15:43:10 +02:00
Marc Alexander
afb7d2e616 [feature/passwords] Rename manager methods to check() and hash()
These method names are more straightforward than the previous ones.

PHPBB3-11610
2013-10-02 13:30:36 +02:00
Marc Alexander
356f3eef07 [feature/passwords] Inject passwords manager into auth providers
The passwords manager will replace the old method of using the functions
phpbb_hash() and phpbb_check_hash().

PHPBB3-11610
2013-10-02 13:28:38 +02:00
Marc Alexander
61e4c0f251 [feature/passwords] Do not hash passwords longer than 4096 bytes
PHPBB3-11610
2013-10-01 17:38:52 +02:00
Marc Alexander
3ebff0a960 [feature/passwords] Pass config via service container to driver helper
This will get rid of the global $config in the driver helper

PHPBB3-11610
2013-09-28 12:42:11 +02:00
Marc Alexander
de087d537e [feature/passwords] A few more corrections in methods due to namespacing
PHPBB3-11610
2013-09-28 12:41:02 +02:00
Marc Alexander
5bc5e4716c [feature/passwords] More changes due to namespacing
PHPBB3-11610
2013-09-27 16:58:06 +02:00
Marc Alexander
3f63b9b470 [feature/passwords] Modify passwords files for namespacing changes
PHPBB3-11610
2013-09-27 11:16:47 +02:00
Marc Alexander
e41c9ef6cd [feature/passwords] Add schema changes to schema_data for new hash types
PHPBB3-11610
2013-09-27 10:48:00 +02:00
Marc Alexander
663b4b2eb7 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into feature/passwords
Conflicts:
	phpBB/develop/create_schema_files.php
2013-09-27 10:47:10 +02:00
Andreas Fischer
6c3f3ec893 [ticket/11860] htaccess: Support for Apache 2.4's "Require" syntax.
PHPBB3-11860
2013-09-23 14:10:21 +02:00
Marc Alexander
01512104b5 [feature/passwords] Use dependency injection for passwords driver helper
The passwords driver helper is now injected into the driver base instead
of being manually loaded.

PHPBB3-11610
2013-09-22 22:53:10 +02:00
Marc Alexander
f5eb0d744e [feature/passwords] Use dependency injection for helper
This will now be used instead of manually loading the passwords helper
instance in the passwords manager.

PHPBB3-11610
2013-09-22 21:17:30 +02:00
Marc Alexander
1970c69c8c [feature/passwords] Rename migrations file to passwords
Also removed the effectively_installed() check that is not needed according
to EXreaction.

PHPBB3-11610
2013-09-20 19:37:05 +02:00
Marc Alexander
211f99d881 [feature/passwords] Do not manually include passwords drivers in tests
PHPBB3-11610
2013-09-20 17:53:33 +02:00
Marc Alexander
a00854c406 [feature/passwords] Do not pass phpbb_container to passwords manager
PHPBB3-11610
2013-09-20 17:31:32 +02:00
Dhruv
e4977b714e [ticket/11271] Use absolute path for displaying inline attachments in feeds
PHPBB3-11271
2013-09-15 20:40:32 +05:30
erangamapa
1450d29aba [ticket/11271] Changed executable bit.
Changed executable bit value from 755 to 644.

PHPBB3-11271
2013-09-15 15:42:55 +05:30
erangamapa
08fdd30917 [ticket/11271] Formatting code and removing null assignment.
Formatted code and replaced null assignment with empty array
assignment to attachments parameter in method 'feed_generate_content'.

PHPBB3-11271
2013-09-15 15:42:51 +05:30
erangamapa
31957abeb1 [ticket/11271] Removing unnecessary database object
Removed unnecessary global database object from 'feed_generate_content'
Method.

PHPBB3-11271
2013-09-15 15:42:37 +05:30
erangamapa
86d83f2bb2 [ticket/11271] Separated attachment fetching query
Removed external query used to fetch related attachments.
Added attachments fetching method with database query to
post based feed.

PHPBB3-11271
2013-09-15 15:42:24 +05:30
erangamapa
098fdf95ae [ticket/11271] Fetched feed attachments before loop.
Fetched feed attachments before looping through feed items and
send them to method 'feed_generate_content' for each feed item.

PHPBB3-11271
2013-09-15 15:42:09 +05:30
erangamapa
224c863377 [ticket/11271] Removed in-line attachment comments properly.
Added a new regex to remove in-line attachment comments.

PHPBB3-11271
2013-09-15 15:41:52 +05:30
erangamapa
72b92f70f1 [ticket/11271] Displaying in-line attached images in ATOM feed.
In-line attached images are not displaying as they are not parsing.
Included 'parse_attachments' column name for data fetching queries
in feed.php. Checked weather feeds have in-line attachments and
parsed them by using parse_attachments() method.

PHPBB3-11271
2013-09-15 15:41:36 +05:30
Marc Alexander
beafef0000 [feature/passwords] Add missing function documentation
Additionally, a new line has been added to make the code look nicer.

PHPBB3-11610
2013-09-14 14:17:14 +02:00
Marc Alexander
19512b2595 [feature/passwords] Rename "crypto" files to "passwords" files
PHPBB3-11610
2013-09-14 14:04:48 +02:00
Marc Alexander
b810957c4b [feature/passwords] Properly set convert_flag and add test for it
PHPBB3-11610
2013-09-14 13:55:53 +02:00
Marc Alexander
8b9370c6a9 [feature/passwords] Define default hashing algorithm in container file
The default hashing algorithm type is defined as a parameter in the service
definition file for the password hashing system. This will allow us to change
this in the future but it will also prevent unexperienced admins from changing
the hashing algorithm.

PHPBB3-11610
2013-09-14 13:55:45 +02:00
Marc Alexander
58755c4972 [feature/passwords] Add get_name() method to drivers
This will allow us to actually properly differentiate between the available
drivers.

PHPBB3-11610
2013-09-14 13:55:39 +02:00
Marc Alexander
df8e5f4c3c [feature/passwords] Move migrations file to phpbb folder
PHPBB3-11610
2013-09-14 13:55:34 +02:00
Marc Alexander
9b24fda5cd [feature/passwords] Move files after namespacing changes
PHPBB3-11610
2013-09-14 13:55:28 +02:00
Marc Alexander
2e453eb2cb [feature/passwords] Add legacy support for md5 passwords
PHPBB3-11610
2013-09-14 13:55:23 +02:00
Marc Alexander
bd4664807f [feature/passwords] Increase code coverage in bcrypt driver
PHPBB3-11610
2013-09-14 13:55:18 +02:00
Marc Alexander
3a776ed0af [feature/passwords] Increase test coverage of salted_md5 driver
PHPBB3-11610
2013-09-14 13:55:13 +02:00
Marc Alexander
05a5ac282d [feature/passwords] Fix incorrect call to helper instead of $this
The driver helper method unique_id is called inside the helper. Therefore,
it shouldn't be called via $this->helper but rather via $this.

PHPBB3-11610
2013-09-14 13:55:06 +02:00
Marc Alexander
b6473a515b [feature/passwords] Increase manager test coverage to cover all methods
All methods in the manager are now fully covered.

PHPBB3-11610
2013-09-14 13:55:00 +02:00
Marc Alexander
a4b0a8ceb9 [feature/passwords] Do not use specific errors but just return false
The authentication system should handle the possible errors for now.
Additional error returns can be added later on if they are needed.

PHPBB3-11610
2013-09-14 13:54:53 +02:00
Marc Alexander
dbd6d33e9f [feature/passwords] NULL should be null according to coding guidelines
PHPBB3-11610
2013-09-14 13:54:48 +02:00
Marc Alexander
8f863d1d49 [feature/passwords] Do not check if type_map is empty
If the type map is empty the service container is incomplete or broken.
There is no need to check this as other components would probably be broken
at the same time.

PHPBB3-11610
2013-09-14 13:54:39 +02:00
Marc Alexander
fcb7130823 [feature/passwords] Use randomly generated password for tests
The password will start with 'foobar' and then continue with random
characters that will be appended every iteration.

PHPBB3-11610
2013-09-14 13:54:33 +02:00
Marc Alexander
ddc207fae8 [feature/passwords] Fix tests on PHP versions < 5.3.7
PHPBB3-11610
2013-09-14 13:54:27 +02:00
Marc Alexander
cfbd858bd7 [feature/passwords] Properly treat duplicates in combined hashes
PHPBB3-11610
2013-09-14 13:54:21 +02:00
Marc Alexander
556048177f [feature/passwords] Make method get_hashing_public_algorithm public
Combined hashing requires it for checking the supplied password hash for
its hashing algorithm.

PHPBB3-11610
2013-09-14 13:54:13 +02:00
Marc Alexander
6f33ca85a2 [feature/passwords] Add tests for combined hashing of passwords
PHPBB3-11610
2013-09-14 13:54:06 +02:00
Marc Alexander
dc76146cef [feature/passwords] Add combined hashing method to helper
This will allow to hash a previously hashed password with another hashing
method, i.e. as upgrade path from phpBB 3.0 to 3.1.

PHPBB3-11610
2013-09-14 13:53:58 +02:00
Marc Alexander
c67f7dba60 [feature/passwords] Add function for obtaining only the hash to helper
This is also needed for combined hashing of passwords.

PHPBB3-11610
2013-09-14 13:53:52 +02:00
Marc Alexander
16e5d0dc35 [feature/passwords] Fix minor code limitations in helper
These limitations caused it to only allow a specific input to combined
hashes.

PHPBB3-11610
2013-09-14 13:53:44 +02:00
Marc Alexander
ab068799b1 [feature/passwords] Pass phpbb_container to passwords helper
PHPBB3-11610
2013-09-14 13:53:31 +02:00
Marc Alexander
e4a5aacf2a [feature/passwords] Use correct prefix for salt in salted_md5
PHPBB3-11610
2013-09-14 13:53:26 +02:00
Marc Alexander
857b90057b [feature/passwords] Add method for obtaining the hash settings only
This is needed for combined hashing of passwords.

PHPBB3-11610
2013-09-14 13:53:19 +02:00
Marc Alexander
dae4327cfc [feature/passwords] Add schema changes for new hash types
PHPBB3-11610
2013-09-14 13:53:14 +02:00
Marc Alexander
4b81b93d10 [feature/passwords] Make sure hash has the required length
Also added tests to make sure that crypto drivers are enforcing the hash
length.

PHPBB3-11610
2013-09-14 13:53:08 +02:00
Marc Alexander
7ddf004489 [feature/passwords] Make method get_hashing_algorithm() protected
There is currently no use for it being public.

PHPBB3-11610
2013-09-14 13:53:03 +02:00
Marc Alexander
e7b3daeb29 [feature/passwords] Add tests for manager check_hash() method
Tests cover all supported hashing algorithms.

PHPBB3-11610
2013-09-14 13:52:57 +02:00
Marc Alexander
13d25e6a32 [feature/passwords] Fix tests for PHP version < 5.3.7
PHPBB3-11610
2013-09-14 13:52:52 +02:00
Marc Alexander
3f70699aa3 [feature/passwords] Use common salt generation function for all types
We will be using the same method inside the driver helper class for all hash
types. This is the same function that has been used for the salted md5 hash
of phpBB 3.0.

PHPBB3-11610
2013-09-14 13:52:43 +02:00
Marc Alexander
5574b2a8e9 [feature/passwords] Add driver helper class file
PHPBB3-11610
2013-09-14 13:52:38 +02:00
Marc Alexander
33725f6e2f [feature/passwords] Include driver helper in manager_test
PHPBB3-11610
2013-09-14 13:52:33 +02:00
Marc Alexander
61e98fbd63 [feature/passwords] Add driver helper class for additional functions
Functions for the helper class might be used in other drivers as well and
therefore shouldn't be limited to just one driver.

PHPBB3-11610
2013-09-14 13:52:25 +02:00
Marc Alexander
c9fafcefd3 [feature/passwords] Add basic passwords manager test file
PHPBB3-11610
2013-09-14 13:52:15 +02:00
Marc Alexander
f8bcf99c7f [feature/passwords] Do not support 8-bit characters with $2a$ bcrypt
8-bit unicode characters might reduce the security of the password hash
when using the $2a$ bcrypt prefix. Those types of characters are usually
not used in passwords but we should prevent this possible issue anyway.

PHPBB3-11610
2013-09-14 13:52:09 +02:00
Marc Alexander
8795fe9c77 [feature/passwords] Add convert flag for converting to default
PHPBB3-11610
2013-09-14 13:52:04 +02:00
Marc Alexander
d3d317a2de [feature/passwords] Correctly supply hash salt and settings to bcrypt
PHPBB3-11610
2013-09-14 13:51:44 +02:00
Marc Alexander
c9afda5a65 [feature/passwords] Use correct prefix for bcrypt type
PHPBB3-11610
2013-09-14 13:51:39 +02:00
Marc Alexander
7a526284d3 [feature/passwords] Default to bcrypt with $2y$ prefix if possible
PHPBB3-11610
2013-09-14 13:51:31 +02:00
Marc Alexander
78a8369173 [feature/passwords] Add basic bcrypt drivers for $2a$ & $2y$ prefix
The $2a$ prefix is the basic implementation with the $2y$ prefix extending
that class. However, the default hashes for phpBB should be generated with
$2y$ unless the PHP version is older than 5.3.7.

PHPBB3-11610
2013-09-14 13:51:24 +02:00
Marc Alexander
31d2a8ef05 [feature/passwords] Add salted md5 (phpBB3 default) and phpass drivers
The phpass driver extends the standard salted md5 driver of phpBB3. It will
only support the $P$ prefix that phpass uses.

PHPBB3-11610
2013-09-14 13:51:16 +02:00
Marc Alexander
4b6646d1be [feature/passwords] Add crypto driver base class and interface
PHPBB3-11610
2013-09-14 13:51:10 +02:00
Marc Alexander
fbdbf41dc8 [feature/passwords] Add helper functions, i.e. for combined hashes
Combined hashes can be used for i.e. converting already existing
password hashes to bcrypt. While this will not provide the same security
a pure bcrypt hash provides, it will still be significantly more secure
than a standard salted md5.
A combined hash will look as follows:
$H\2y${salted_for_H_prefix}${salt_+_settings_for_2y_prefix}${hash}
The prefixes are seperated by a backslash. Individual settings (which
can include either just the salt or a salt and possible additional settings)
are seperated by dollar signs. As backslashes and dollar signs are not
allowed in hashes or salts, they will be used for seperating the settings
from the salt.

Here is an example of a password hash:
$H\2a$9zv1uIaq1$10\1ff4640409fb96a449c1fO$/oN1O0cdUmFSMZT3UZKrgAyalhnt1LC

The 'H' prefix stands for the salted md5 implementation of phpBB 3.0.
Its settings will be parsed as 9zv1uIaq1 resulting in a hash for the check
as follows:
$H$9zv1uIaq1{hash}
Since the password is used for hashing, the {hash} can be left blank and
will basically be filled by the hashing algorithm. The {hash} will then be
used as password for the next hashing algorithm. In this case that would be
the bcrypt algorithm. The settings are set to 10\1ff4640409fb96a449c1fO which
will be transformed to 10$1ff4640409fb96a449c1fO resulting in a hash like
this for the bcrypt hashing function:
$2a$10$1ff4640409fb96a449c1fO{hash}
The {hash} will again be basically filled by the hashing algorithm.
Afterwards, the {hash} will be extracted from the returned hash and put at
the end of the already known hash settings:
$H\2a$9zv1uIaq1$10\1ff4640409fb96a449c1fO$

If the password is correct, the combined hash will of course be the same
as the stored one.

PHPBB3-11610
2013-09-14 13:50:56 +02:00
Marc Alexander
d66cae7cbc [feature/passwords] Add service collection file crypto.yml
This will contain definitions of the services and the service collection
that will be passed to the passwords manager.

PHPBB3-11610
2013-09-14 13:50:42 +02:00
Marc Alexander
3a0dd248d0 [feature/passwords] Add basic implementation of passwords manager
The passwords manager is capable of checking and hashing passwords.
It will support different hashing algorithms.

PHPBB3-11610
2013-09-14 13:50:07 +02:00
Nathan Guse
d14aed0819 [ticket/8323] Cache auth request
PHPBB3-8323
2013-09-05 13:59:24 -05:00
Nathan Guse
e8ab8fe0bc Merge branch 'develop' of github.com:phpbb/phpbb3 into ticket/8323
# By Joas Schilling (613) and others
# Via Andreas Fischer (214) and others
* 'develop' of github.com:phpbb/phpbb3: (2494 commits)
  [ticket/11825] Move schema_data.php into includes/ instead of phpbb/
  [ticket/11215] Remove unnecessary comment
  [ticket/11755] MySQL upgrader out of date
  [prep-release-3.0.12] Update Changelog for 3.0.12-RC3 release.
  [prep-release-3.0.12] Bumping version number for 3.0.12-RC3.
  [ticket/11823] Set up nginx server to match PHP files with characters after .php
  [ticket/11812] Fix empty define
  [ticket/11818] Update Symfony dependencies to 2.3.*
  [ticket/11791] Load adm/ events from styles/adm/event/
  [ticket/11215] Fix helper_url_test.php tests
  [ticket/11215] Add newline back to .htaccess, fix wording
  [ticket/11215] Update comment in .htaccess
  [ticket/11215] Uncomment rewrite rules in .htaccess
  [ticket/11215] Make controller helper url() method use correct format
  [ticket/11215] Add commented-out URL rewrite capability to .htaccess
  [ticket/11821] Fix comma usage next to "You are receiving this notification".
  [ticket/11769] Allow using 0 as poster name
  [ticket/11769] Allow '0' as username
  [ticket/11215] Use new URL structure for controllers
  [ticket/11215] Everything appears to be working...
  ...

Conflicts:
	phpBB/includes/functions_privmsgs.php
2013-09-05 13:56:57 -05:00
brunoais
7a02a8bcf2 [ticket/11663] Add the doc block about the parameters.
PHPBB3-11663
2013-08-17 20:11:26 +01:00
brunoais
53888ec540 [ticket/11663] Add the doc block about the return value.
generate_text_for_storage does not return anything, all returned values are outputted using the parameters so this uses the returned value with the same idea as many C language functions where the returned value is if all went well or not and if it didn't what went wrong.

PHPBB3-11663
2013-08-14 10:44:45 +01:00
brunoais
b6d6938b9f [ticket/11663] Make generate_text_for_storage return the errors.
generate_text_for_storage does not return anything, all returned values are outputted using the parameters so this uses the returned value with the same idea as many C language functions where the returned value is if all went well or not and if it didn't what went wrong.

PHPBB3-11663
2013-08-09 17:01:09 +01:00
Nathaniel Guse
abaa53b0b2 [ticket/8323] Combine into a single query
PHPBB3-8323
2013-05-01 12:28:31 -05:00
Nathan Guse
d68778e7eb [ticket/8323] Comments on phpbb_get_banned_user_ids input for test
PHPBB3-8323
2012-12-13 20:05:00 -06:00
Nathan Guse
12aa6b4b2c [ticket/8323] More readability in test case
PHPBB3-8323
2012-12-11 11:24:18 -06:00
Nathan Guse
e74f4ab6e4 [ticket/8323] Comments
PHPBB3-8323
2012-12-07 21:01:45 -06:00
Nathan Guse
b3dae8fd61 [ticket/8323] dataProvider for the test; better test data
PHPBB3-8323
2012-12-07 20:26:35 -06:00
Nathan Guse
4ab07aa45e [ticket/8323] Comments
PHPBB3-8323
2012-12-07 18:51:06 -06:00
Nathan Guse
8e6a69bf0c [ticket/8323] Unit test for phpbb_get_banned_user_ids
PHPBB3-8323
2012-12-07 18:50:22 -06:00
Nathan Guse
473a26a553 [ticket/8323] Comments for inactive reasons in constants.php
Copied from language output

PHPBB3-8323
2012-12-07 18:17:53 -06:00
Nathan Guse
92ec214537 Merge branch 'develop' of git://github.com/phpbb/phpbb3 into ticket/8323
Conflicts:
	phpBB/viewtopic.php
2012-12-07 18:11:38 -06:00
Nathan
b25efd744d [ticket/8323] Only disable administrative deactivated accounts from receiving PMs
Allow other types of inactive accounts to receive PMs. Remove the banned PM error message and use the string saying they do not have permission (less translation)

PHPBB3-8323
2012-07-10 17:41:27 -05:00
Nathan
08bdebb0b5 [ticket/8323] Allow temporarily banned users to receive PMs, but not a notification
PHPBB3-8323
2012-07-10 16:38:07 -05:00
Nathan
33852e6251 [ticket/8323] Correct PM notification settings (only notify those who can receive them)
Also correcting the way it was setup for users to be able to receive PMs (do not allow administrators/moderators to send to banned, inactive, or non-standard users, that just doesn't make sense)

PHPBB3-8323
2012-07-10 16:07:12 -05:00
Nathan
07b9c1e2fd [ticket/8323] Cleanup viewtopic code (not sure how this mess happened)
PHPBB3-8323
2012-07-10 12:34:40 -05:00
Nathan
362ba43f18 [ticket/8323] Allow sending PMs to temporarily banned users
Added an argument to the phpbb_get_banned_user_ids() function to allow specifying a banned end time (default true for current functionality, false for only permanent bans, timestamp to find banned until a specified time)

PHPBB3-8323
2012-07-10 12:34:40 -05:00
Nathan
0f4956b280 [ticket/8323] Do not allow sending PMs to Inactive users
PHPBB3-8323
2012-07-10 12:34:39 -05:00
Nathan
6f4538c676 [ticket/8323] Hide the Send PM link if users cannot receive the PM
Updated memberlist/viewtopic to the new rules

PHPBB3-8323
2012-07-10 12:34:39 -05:00
Nathan
e6d4e9bbb9 [ticket/8323] Correcting the comment
PHPBB3-8323
2012-07-10 12:34:38 -05:00
Nathan
c38bb4254a [ticket/8323] Do not allow sending of Private Messages to users who are banned
PHPBB3-8323
2012-07-10 12:34:38 -05:00
Nathan
c53d7f0b62 [ticket/8323] Remove code used for testing
PHPBB3-8323
2012-07-10 12:34:38 -05:00
Nathan
05452b9ec0 [ticket/8323] Do not allow sending of Private Messages to users who do not have permission to read private messages
PHPBB3-8323
2012-07-10 12:34:37 -05:00
1678 changed files with 76990 additions and 43929 deletions

18
.editorconfig Normal file
View File

@@ -0,0 +1,18 @@
# This file is for standardising the coding style between different editors
# http://editorconfig.org/
root = true
[*]
end_of_line = lf
indent_size = 4
indent_style = tab
insert_final_newline = true
trim_trailing_whitespace = true
[*.md]
trim_trailing_whitespace = false
[*.yml]
indent_size = 4
indent_style = space

23
.gitignore vendored
View File

@@ -1,19 +1,24 @@
*~
/phpunit.xml
/phpBB/cache/twig/*
/phpBB/cache/*.html
/phpBB/cache/*.php
/phpBB/cache/*.lock
/phpBB/cache/*
!/phpBB/cache/.htaccess
!/phpBB/cache/index.html
/phpBB/composer.phar
/phpBB/config.php
/phpBB/config_dev.php
/phpBB/config_test.php
/phpBB/config*.php
/phpBB/ext/*
/phpBB/files/*
/phpBB/images/avatars/gallery/*
/phpBB/images/avatars/upload/*
/phpBB/images/ranks/*
/phpBB/install/schemas/schema.json
/phpBB/language/*
!/phpBB/language/en
/phpBB/store/*
/phpBB/styles/*
!/phpBB/styles/prosilver
!/phpBB/styles/subsilver2
/phpBB/vendor
/tests/phpbb_unit_tests.sqlite2
/tests/test_config.php
/tests/phpbb_unit_tests.sqlite*
/tests/test_config*.php
/tests/tmp/*
/tests/vendor

View File

@@ -1,30 +1,49 @@
language: php
php:
- 5.3.3
- 5.3
- 5.4
- 5.5
env:
- DB=mysql
- DB=postgres
matrix:
include:
- php: 5.3.3
env: DB=mysqli
- php: 5.3
env: DB=mysqli # MyISAM
- php: 5.4
env: DB=mysqli
- php: 5.4
env: DB=mysql
- php: 5.4
env: DB=mariadb
- php: 5.4
env: DB=postgres
- php: 5.4
env: DB=sqlite3
- php: 5.4
env: DB=mysqli;SLOWTESTS=1
- php: 5.5
env: DB=mysqli
- php: 5.6
env: DB=mysqli
- php: hhvm
env: DB=mysqli
allow_failures:
- php: hhvm
fast_finish: true
services:
- redis-server
install:
- travis/setup-phpbb.sh $DB $TRAVIS_PHP_VERSION
before_script:
- sh -c "if [ '$DB' = 'postgres' ]; then psql -c 'DROP DATABASE IF EXISTS phpbb_tests;' -U postgres; fi"
- sh -c "if [ '$DB' = 'postgres' ]; then psql -c 'create database phpbb_tests;' -U postgres; fi"
- sh -c "if [ '$DB' = 'mysql' ]; then mysql -e 'create database IF NOT EXISTS phpbb_tests;'; fi"
- travis/install-php-extensions.sh
- cd phpBB
- php ../composer.phar install --dev --no-interaction --prefer-source
- cd ..
- sh -c "if [ `php -r "echo (int) version_compare(PHP_VERSION, '5.3.19', '>=');"` = "1" ]; then travis/setup-webserver.sh; fi"
- travis/setup-database.sh $DB $TRAVIS_PHP_VERSION
- phantomjs --webdriver=8910 > /dev/null &
script:
- phpBB/vendor/bin/phpunit --configuration travis/phpunit-$DB-travis.xml
notifications:
email:
recipients:
- dev-team@phpbb.com
on_success: change
on_failure: change
- travis/phing-sniff.sh $DB $TRAVIS_PHP_VERSION
- travis/check-sami-parse-errors.sh $DB $TRAVIS_PHP_VERSION
- travis/check-image-icc-profiles.sh $DB $TRAVIS_PHP_VERSION
- travis/check-executable-files.sh $DB $TRAVIS_PHP_VERSION ./
- sh -c "if [ '$SLOWTESTS' != '1' ]; then phpBB/vendor/bin/phpunit --configuration travis/phpunit-$DB-travis.xml; fi"
- sh -c "if [ '$SLOWTESTS' = '1' ]; then phpBB/vendor/bin/phpunit --configuration travis/phpunit-$DB-travis.xml --group slow; fi"
- sh -c "if [ '$TRAVIS_PHP_VERSION' = '5.3.3' -a '$DB' = 'mysqli' -a '$TRAVIS_PULL_REQUEST' != 'false' ]; then git-tools/commit-msg-hook-range.sh origin/$TRAVIS_BRANCH..FETCH_HEAD; fi"

View File

@@ -25,9 +25,11 @@ To be able to run an installation from the repo (and not from a pre-built packag
## AUTOMATED TESTING
We have unit and functional tests in order to prevent regressions. You can view the bamboo continuous integration [here](http://bamboo.phpbb.com) or check our travis build below.
develop - [![Build Status](https://secure.travis-ci.org/phpbb/phpbb3.png?branch=develop)](http://travis-ci.org/phpbb/phpbb3)
develop-olympus - [![Build Status](https://secure.travis-ci.org/phpbb/phpbb3.png?branch=develop-olympus)](http://travis-ci.org/phpbb/phpbb3)
We have unit and functional tests in order to prevent regressions. You can view the bamboo continuous integration [here](http://bamboo.phpbb.com) or check our travis build below:
* develop [![Build Status](https://secure.travis-ci.org/phpbb/phpbb.png?branch=develop)](http://travis-ci.org/phpbb/phpbb)
* develop-ascraeus [![Build Status](https://secure.travis-ci.org/phpbb/phpbb.png?branch=develop-ascraeus)](http://travis-ci.org/phpbb/phpbb)
* develop-olympus [![Build Status](https://secure.travis-ci.org/phpbb/phpbb.png?branch=develop-olympus)](http://travis-ci.org/phpbb/phpbb)
## LICENSE

View File

@@ -2,9 +2,9 @@
<project name="phpBB" description="The phpBB forum software" default="all" basedir="../">
<!-- a few settings for the build -->
<property name="newversion" value="3.1.0-a1" />
<property name="prevversion" value="3.0.12" />
<property name="olderversions" value="3.0.11" />
<property name="newversion" value="3.1.3-RC1" />
<property name="prevversion" value="3.1.2" />
<property name="olderversions" value="3.0.12, 3.0.13, 3.1.0-a1, 3.1.0-a2, 3.1.0-a3, 3.1.0-b1, 3.1.0-b2, 3.1.0-b3, 3.1.0-b4, 3.1.0-RC1, 3.1.0-RC2, 3.1.0-RC3, 3.1.0-RC4, 3.1.0-RC5, 3.1.0-RC6, 3.1.0, 3.1.1, 3.1.2-RC1" />
<!-- no configuration should be needed beyond this point -->
<property name="oldversions" value="${olderversions}, ${prevversion}" />
@@ -67,22 +67,66 @@
<exec dir="."
command="phpBB/vendor/bin/phpunit
--log-junit build/logs/phpunit.xml
--configuration phpunit.xml.all
--group slow
--coverage-clover build/logs/clover-slow.xml
--coverage-html build/coverage-slow"
passthru="true" />
</target>
<target name="sniff">
<exec command="phpBB/vendor/bin/phpcs
-s
--extensions=php
--standard=build/code_sniffer/ruleset-php-strict-core.xml
--ignore=${project.basedir}/phpBB/phpbb/db/migration/data/v30x/*
phpBB/phpbb"
dir="." returnProperty="retval-php-strict" passthru="true" />
<exec command="phpBB/vendor/bin/phpcs
-s
--extensions=php
--standard=build/code_sniffer/ruleset-php-legacy-core.xml
--ignore=${project.basedir}/phpBB/cache/*
--ignore=${project.basedir}/phpBB/develop/*
--ignore=${project.basedir}/phpBB/ext/*
--ignore=${project.basedir}/phpBB/includes/diff/*.php
--ignore=${project.basedir}/phpBB/includes/sphinxapi.php
--ignore=${project.basedir}/phpBB/includes/utf/data/*
--ignore=${project.basedir}/phpBB/install/data/*
--ignore=${project.basedir}/phpBB/install/database_update.php
--ignore=${project.basedir}/phpBB/phpbb/*
--ignore=${project.basedir}/phpBB/vendor/*
phpBB"
dir="." returnProperty="retval-php-legacy" passthru="true" />
<exec command="phpBB/vendor/bin/phpcs
-s
--extensions=php
--standard=build/code_sniffer/ruleset-php-extensions.xml
--ignore=${project.basedir}/phpBB/ext/*/tests/*
--ignore=${project.basedir}/phpBB/ext/*/vendor/*
phpBB/ext"
dir="." returnProperty="retval-php-ext" passthru="true" />
<if>
<or>
<not><equals arg1="${retval-php-strict}" arg2="0" /></not>
<not><equals arg1="${retval-php-legacy}" arg2="0" /></not>
<not><equals arg1="${retval-php-ext}" arg2="0" /></not>
</or>
<then>
<fail message="PHP Code Sniffer failed." />
</then>
</if>
</target>
<!-- Builds docs for current branch into build/api/output/master -->
<target name="docs">
<!-- only works if you setup phpdoctor:
git clone https://github.com/peej/phpdoctor.git
and then create an executable phpdoctor in your path containing
#!/bin/sh
php -f /path/to/phpdoctor/phpdoc.php $@
-->
<exec dir="build"
command="phpdoctor phpdoc-phpbb.ini"
<exec dir="."
command="phpBB/vendor/bin/sami.php update build/sami-checkout.conf.php"
passthru="true" />
</target>
<!-- Builds docs for multiple branches/tags into build/api/output/$branch -->
<target name="docs-all">
<exec dir="."
command="phpBB/vendor/bin/sami.php update build/sami-all.conf.php"
passthru="true" />
</target>
@@ -105,8 +149,9 @@
<property name="dir" value="build/old_versions/release-${version}" />
</phingcall>
<exec dir="build/old_versions" command="diff -crNEBwd release-${version} release-${newversion} >
<exec dir="build/old_versions" command="LC_ALL=C diff -crNEBwd release-${version} release-${newversion} >
../new_version/patches/phpBB-${version}_to_${newversion}.patch" escape="false" />
<exec dir="build/old_versions" command="LC_ALL=C diff -qr release-${version} release-${newversion} | grep 'Only in release-${version}' > ../new_version/patches/phpBB-${version}_to_${newversion}.deleted" escape="false" />
</target>
<target name="prepare-new-version">
@@ -131,24 +176,22 @@
<target name="package" depends="clean,prepare,prepare-new-version,old-version-diffs">
<exec dir="build" command="php -f package.php '${versions}' > logs/package.log" escape="false" />
<exec dir="build" command="php -f build_diff.php '${prevversion}' '${newversion}' > logs/build_diff.log" escape="false" />
<exec dir="build" escape="false"
command="diff -crNEBwd old_versions/release-${prevversion}/language new_version/phpBB3/language >
save/save_${prevversion}_to_${newversion}/language/phpbb-${prevversion}_to_${newversion}_language.patch" />
save/phpbb-${prevversion}_to_${newversion}_language.patch" />
<exec dir="build" escape="false"
command="diff -crNEBwd old_versions/release-${prevversion}/styles/prosilver new_version/phpBB3/styles/prosilver >
save/save_${prevversion}_to_${newversion}/prosilver/phpbb-${prevversion}_to_${newversion}_prosilver.patch" />
save/phpbb-${prevversion}_to_${newversion}_prosilver.patch" />
<exec dir="build" escape="false"
command="diff -crNEBwd old_versions/release-${prevversion}/styles/subsilver2 new_version/phpBB3/styles/subsilver2 >
save/save_${prevversion}_to_${newversion}/subsilver2/phpbb-${prevversion}_to_${newversion}_subsilver2.patch" />
save/phpbb-${prevversion}_to_${newversion}_subsilver2.patch" />
<exec dir="build" escape="false"
command="git shortlog --summary --numbered release-${prevversion}...HEAD >
save/save_${prevversion}_to_${newversion}/phpbb-${prevversion}_to_${newversion}_git_shortlog.txt" />
save/phpbb-${prevversion}_to_${newversion}_git_shortlog.txt" />
<exec dir="build" escape="false"
command="git diff --stat release-${prevversion}...HEAD >
save/save_${prevversion}_to_${newversion}/phpbb-${prevversion}_to_${newversion}_git_diffstat.txt" />
save/phpbb-${prevversion}_to_${newversion}_git_diffstat.txt" />
<phingcall target="checksum-dir">
<property name="dir" value="build/new_version/release_files" />
@@ -223,7 +266,7 @@
command="git archive ${revision} composer.phar | tar -xf - -C ${dir}"
checkreturn="true" />
<exec dir="${dir}"
command="php composer.phar install"
command="php composer.phar install --no-dev --optimize-autoloader"
checkreturn="true"
passthru="true" />
<delete file="${dir}/composer.phar" />
@@ -237,10 +280,17 @@
</else>
</if>
<!-- Create schema.json -->
<exec dir="${dir}" command="php develop/create_schema_files.php" />
<delete file="${dir}/config.php" />
<delete dir="${dir}/develop" />
<delete dir="${dir}/install/data" />
<phingcall target="clean-vendor-dir">
<property name="dir" value="${dir}" />
</phingcall>
<echo msg="Setting permissions for checkout of ${revision} in ${dir}" />
<!-- set permissions of all files to 644, directories to 755 -->
<exec dir="${dir}" command="find . -type f|xargs chmod 644" escape="false" />
@@ -252,6 +302,91 @@
<chmod mode="0777" file="${dir}/images/avatars/upload" />
</target>
<target name="clean-vendor-dir">
<!-- Delete unrelated files from vendor/, see PHPBB3-12390 -->
<delete dir="${dir}/vendor/lusitanian/oauth/examples" />
<delete dir="${dir}/vendor/lusitanian/oauth/tests" />
<delete file="${dir}/vendor/lusitanian/oauth/.gitignore" />
<delete file="${dir}/vendor/lusitanian/oauth/.travis.yml" />
<delete file="${dir}/vendor/lusitanian/oauth/phpunit.xml.dist" />
<delete file="${dir}/vendor/lusitanian/oauth/README.md" />
<delete dir="${dir}/vendor/psr/log/Psr/Log/Test" />
<delete file="${dir}/vendor/psr/log/.gitignore" />
<delete file="${dir}/vendor/psr/log/README.md" />
<delete dir="${dir}/vendor/symfony/config/Symfony/Component/Config/Tests" />
<delete file="${dir}/vendor/symfony/config/Symfony/Component/Config/.gitignore" />
<delete file="${dir}/vendor/symfony/config/Symfony/Component/Config/CHANGELOG.md" />
<delete file="${dir}/vendor/symfony/config/Symfony/Component/Config/README.md" />
<delete file="${dir}/vendor/symfony/config/Symfony/Component/Config/phpunit.xml.dist" />
<delete dir="${dir}/vendor/symfony/console/Symfony/Component/Console/Tests" />
<delete file="${dir}/vendor/symfony/console/Symfony/Component/Console/.gitignore" />
<delete file="${dir}/vendor/symfony/console/Symfony/Component/Console/CHANGELOG.md" />
<delete file="${dir}/vendor/symfony/console/Symfony/Component/Console/README.md" />
<delete file="${dir}/vendor/symfony/console/Symfony/Component/Console/phpunit.xml.dist" />
<delete dir="${dir}/vendor/symfony/debug/Symfony/Component/Debug/Tests" />
<delete file="${dir}/vendor/symfony/debug/Symfony/Component/Debug/.gitignore" />
<delete file="${dir}/vendor/symfony/debug/Symfony/Component/Debug/CHANGELOG.md" />
<delete file="${dir}/vendor/symfony/debug/Symfony/Component/Debug/README.md" />
<delete file="${dir}/vendor/symfony/debug/Symfony/Component/Debug/phpunit.xml.dist" />
<delete dir="${dir}/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/Tests" />
<delete file="${dir}/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/.gitignore" />
<delete file="${dir}/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/CHANGELOG.md" />
<delete file="${dir}/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/README.md" />
<delete file="${dir}/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/phpunit.xml.dist" />
<delete dir="${dir}/vendor/symfony/event-dispatcher/Symfony/Component/EventDispatcher/Tests" />
<delete file="${dir}/vendor/symfony/event-dispatcher/Symfony/Component/EventDispatcher/.gitignore" />
<delete file="${dir}/vendor/symfony/event-dispatcher/Symfony/Component/EventDispatcher/CHANGELOG.md" />
<delete file="${dir}/vendor/symfony/event-dispatcher/Symfony/Component/EventDispatcher/README.md" />
<delete file="${dir}/vendor/symfony/event-dispatcher/Symfony/Component/EventDispatcher/phpunit.xml.dist" />
<delete dir="${dir}/vendor/symfony/filesystem/Symfony/Component/Filesystem/Tests" />
<delete file="${dir}/vendor/symfony/filesystem/Symfony/Component/Filesystem/.gitignore" />
<delete file="${dir}/vendor/symfony/filesystem/Symfony/Component/Filesystem/CHANGELOG.md" />
<delete file="${dir}/vendor/symfony/filesystem/Symfony/Component/Filesystem/README.md" />
<delete file="${dir}/vendor/symfony/filesystem/Symfony/Component/Filesystem/phpunit.xml.dist" />
<delete dir="${dir}/vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/Tests" />
<delete file="${dir}/vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/.gitignore" />
<delete file="${dir}/vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/CHANGELOG.md" />
<delete file="${dir}/vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/README.md" />
<delete file="${dir}/vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/phpunit.xml.dist" />
<delete dir="${dir}/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/Tests" />
<delete file="${dir}/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/.gitignore" />
<delete file="${dir}/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/CHANGELOG.md" />
<delete file="${dir}/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/README.md" />
<delete file="${dir}/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/phpunit.xml.dist" />
<delete dir="${dir}/vendor/symfony/routing/Symfony/Component/Routing/Tests" />
<delete file="${dir}/vendor/symfony/routing/Symfony/Component/Routing/.gitignore" />
<delete file="${dir}/vendor/symfony/routing/Symfony/Component/Routing/CHANGELOG.md" />
<delete file="${dir}/vendor/symfony/routing/Symfony/Component/Routing/README.md" />
<delete file="${dir}/vendor/symfony/routing/Symfony/Component/Routing/phpunit.xml.dist" />
<delete dir="${dir}/vendor/symfony/yaml/Symfony/Component/Yaml/Tests" />
<delete file="${dir}/vendor/symfony/yaml/Symfony/Component/Yaml/.gitignore" />
<delete file="${dir}/vendor/symfony/yaml/Symfony/Component/Yaml/CHANGELOG.md" />
<delete file="${dir}/vendor/symfony/yaml/Symfony/Component/Yaml/README.md" />
<delete file="${dir}/vendor/symfony/yaml/Symfony/Component/Yaml/phpunit.xml.dist" />
<delete dir="${dir}/vendor/twig/twig/doc" />
<delete dir="${dir}/vendor/twig/twig/ext" />
<delete dir="${dir}/vendor/twig/twig/test" />
<delete file="${dir}/vendor/twig/twig/.editorconfig" />
<delete file="${dir}/vendor/twig/twig/.gitignore" />
<delete file="${dir}/vendor/twig/twig/.travis.yml" />
<delete file="${dir}/vendor/twig/twig/AUTHORS" />
<delete file="${dir}/vendor/twig/twig/CHANGELOG" />
<delete file="${dir}/vendor/twig/twig/phpunit.xml.dist" />
<delete file="${dir}/vendor/twig/twig/README.markdown" />
</target>
<target name="clean-diff-dir">
<delete dir="${dir}/cache" />
<delete dir="${dir}/docs" />

View File

@@ -2,9 +2,13 @@
<?php
/**
*
* @package build
* @copyright (c) 2013 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
* This file is part of the phpBB Forum Software package.
*
* @copyright (c) phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
* For full copyright and license information, please see
* the docs/CREDITS.txt file.
*
*/

View File

@@ -2,9 +2,13 @@
<?php
/**
*
* @package build
* @copyright (c) 2011 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
* This file is part of the phpBB Forum Software package.
*
* @copyright (c) phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
* For full copyright and license information, please see
* the docs/CREDITS.txt file.
*
*/
@@ -16,7 +20,7 @@ if ($_SERVER['argc'] != 2)
$fixVersion = $_SERVER['argv'][1];
$query = 'project = PHPBB3
$query = 'project IN (PHPBB3, SECURITY)
AND resolution = Fixed
AND fixVersion = "' . $fixVersion . '"
AND status IN ("Unverified Fix", Closed)';

View File

@@ -1,409 +0,0 @@
#!/usr/bin/env php
<?php
/**
*
* @package build
* @copyright (c) 2010 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
*
*/
if ($_SERVER['argc'] != 3)
{
die("Please specify the previous and current version as arguments (e.g. build_diff.php '1.0.2' '1.0.3').");
}
$old_version = trim($_SERVER['argv'][1]);
$new_version = trim($_SERVER['argv'][2]);
$substitute_old = $old_version;
$substitute_new = $new_version;
$simple_name_old = 'release-' . $old_version;
$simple_name_new = 'release-' . $new_version;
$echo_changes = false;
// DO NOT EVER USE THE FOLLOWING! Fix the script to generate proper changes,
// do NOT manually create them.
// Set this to true to just compress the changes and do not build them again
// This should be used for building custom modified txt file. ;)
$package_changed_files = false;
//$debug_file = 'includes/functions_user.php'; //'styles/prosilver/style.cfg';
$debug_file = false;
if ($debug_file !== false)
{
$echo_changes = false;
}
$s_name = 'save_' . $substitute_old . '_to_' . $substitute_new;
$location = dirname(__FILE__);
if (!$package_changed_files)
{
if (!$echo_changes)
{
// Create directory...
run_command("mkdir $location/save/{$s_name}");
run_command("mkdir $location/save/{$s_name}/language");
run_command("mkdir $location/save/{$s_name}/prosilver");
run_command("mkdir $location/save/{$s_name}/subsilver2");
}
}
// Build code changes and place them into 'save'
if (!$package_changed_files)
{
build_code_changes('language');
build_code_changes('prosilver');
build_code_changes('subsilver2');
}
// Package code changes
$code_changes_filename = 'phpBB-' . $substitute_old . '_to_' . $substitute_new . '-codechanges';
if (!$echo_changes)
{
// Now compress the files...
// Build Main phpBB Release
$compress_programs = array(
// 'tar.gz' => 'tar -czf',
'tar.bz2' => 'tar -cjf',
'zip' => 'zip -r'
);
chdir($location . '/save/' . $s_name);
foreach ($compress_programs as $extension => $compress_command)
{
echo "Packaging code changes for $extension\n";
run_command("rm ./../../new_version/release_files/{$code_changes_filename}.{$extension}");
flush();
// Build Package
run_command("$compress_command ./../../new_version/release_files/{$code_changes_filename}.{$extension} *");
flush();
}
}
/**
* $output_format can be: language, prosilver and subsilver2
*/
function build_code_changes($output_format)
{
global $substitute_new, $substitute_old, $simple_name_old, $simple_name_new, $echo_changes, $package_changed_files, $location, $debug_file, $s_name;
// Global array holding the data entries
$data = array(
'header' => array(),
'diff' => array(),
);
// Read diff file and prepare the output filedata...
//$patch_filename = '../new_version/patches/phpBB-' . $substitute_old . '_to_' . $substitute_new . '.patch';
$release_filename = 'phpbb-' . $substitute_old . '_to_' . $substitute_new . '_' . $output_format . '.txt';
if (!$package_changed_files)
{
if (!$echo_changes)
{
$fp = fopen('save/' . $s_name . '/' . $output_format . '/' . $release_filename, 'wb');
if (!$fp)
{
die('Unable to create ' . $release_filename);
}
}
}
include_once($location . '/build_helper.php');
$package = new build_package(array($substitute_old, $substitute_new), false);
$titles = array(
'language' => 'phpBB ' . $substitute_old . ' to phpBB ' . $substitute_new . ' Language Pack Changes',
'prosilver' => 'phpBB ' . $substitute_old . ' to phpBB ' . $substitute_new . ' prosilver Changes',
'subsilver2' => 'phpBB ' . $substitute_old . ' to phpBB ' . $substitute_new . ' subsilver2 Changes',
);
$data['header'] = array(
'title' => $titles[$output_format],
'intro' => '
These are the ' . $titles[$output_format] . ' summed up into a little Mod. These changes are only partial and do not include any code changes, therefore not meant for updating phpBB.
',
'included_files' => array(),
);
// We collect the files we want to diff first (ironically we grab this from a diff file)
if (!$echo_changes)
{
echo "\n\nCollecting Filenames:";
}
// We re-create the patch file
foreach ($package->old_packages as $_package_name => $dest_package_filename)
{
chdir($package->locations['old_versions']);
if (!$echo_changes)
{
echo "\n\n" . 'Creating patch/diff files for phpBB-' . $dest_package_filename . $package->get('new_version_number');
}
$dest_package_filename = $location . '/save/' . $s_name . '/phpBB-' . $dest_package_filename . $package->get('new_version_number') . '.patch';
$package->run_command('diff ' . $package->diff_options . ' ' . $_package_name . ' ' . $package->get('simple_name') . ' > ' . $dest_package_filename);
// Parse this diff to determine file changes from the checked versions and save them
$result = $package->collect_diff_files($dest_package_filename, $_package_name);
$package->run_command('rm ' . $dest_package_filename);
}
chdir($location);
$filenames = array();
foreach ($result['files'] as $filename)
{
if ($debug_file !== false && $filename != $debug_file)
{
continue;
}
// Decide which files to compare...
switch ($output_format)
{
case 'language':
if (strpos($filename, 'language/en/') !== 0)
{
continue 2;
}
break;
case 'prosilver':
if (strpos($filename, 'styles/prosilver/') !== 0)
{
continue 2;
}
break;
case 'subsilver2':
if (strpos($filename, 'styles/subsilver2/') !== 0)
{
continue 2;
}
break;
}
if (!file_exists($location . '/old_versions/' . $simple_name_old . '/' . $filename))
{
// New file... include it
$data['header']['included_files'][] = array(
'old' => $location . '/old_versions/' . $simple_name_old . '/' . $filename,
'new' => $location . '/old_versions/' . $simple_name_new . '/' . $filename,
'phpbb_filename' => $filename,
);
continue;
}
$filenames[] = array(
'old' => $location . '/old_versions/' . $simple_name_old . '/' . $filename,
'new' => $location . '/old_versions/' . $simple_name_new . '/' . $filename,
'phpbb_filename' => $filename,
);
}
// Now let us go through the filenames list and create a more comprehensive diff
if (!$echo_changes)
{
fwrite($fp, build_header($output_format, $filenames, $data['header']));
}
else
{
//echo build_header('text', $filenames, $data['header']);
}
// Copy files...
$files_to_copy = array();
foreach ($data['header']['included_files'] as $filename)
{
$files_to_copy[] = $filename['phpbb_filename'];
}
// First step is to copy the new version over (clean structure)
if (!$echo_changes && sizeof($files_to_copy))
{
foreach ($files_to_copy as $file)
{
// Create directory?
$dirname = dirname($file);
if ($dirname)
{
$dirname = explode('/', $dirname);
$__dir = array();
foreach ($dirname as $i => $dir)
{
$__dir[] = $dir;
run_command("mkdir -p $location/save/" . $s_name . '/' . $output_format . '/' . implode('/', $__dir));
}
}
$source_file = $location . '/new_version/phpBB3/' . $file;
$dest_file = $location . '/save/' . $s_name . '/' . $output_format . '/';
$dest_file .= $file;
$command = "cp -p $source_file $dest_file";
$result = trim(`$command`);
echo "- Copied File: " . $source_file . " -> " . $dest_file . "\n";
}
}
include_once('diff_class.php');
if (!$echo_changes)
{
echo "\n\nDiffing Codebases:";
}
foreach ($filenames as $file_ary)
{
if (!file_exists($file_ary['old']))
{
$lines1 = array();
}
else
{
$lines1 = file($file_ary['old']);
}
$lines2 = file($file_ary['new']);
if (!sizeof($lines1))
{
// New File
}
else
{
$diff = new Diff($lines1, $lines2);
$fmt = new BBCodeDiffFormatter(false, 5, $debug_file);
if (!$echo_changes)
{
fwrite($fp, $fmt->format_open($file_ary['phpbb_filename']));
fwrite($fp, $fmt->format($diff, $lines1));
fwrite($fp, $fmt->format_close($file_ary['phpbb_filename']));
}
else
{
echo $fmt->format_open($file_ary['phpbb_filename']);
echo $fmt->format($diff, $lines1);
echo $fmt->format_close($file_ary['phpbb_filename']);
}
if ($debug_file !== false)
{
echo $fmt->format_open($file_ary['phpbb_filename']);
echo $fmt->format($diff, $lines1);
echo $fmt->format_close($file_ary['phpbb_filename']);
exit;
}
}
}
if (!$echo_changes)
{
fwrite($fp, build_footer($output_format));
// Close file
fclose($fp);
chmod('save/' . $s_name . '/' . $output_format . '/' . $release_filename, 0666);
}
else
{
echo build_footer($output_format);
}
}
/**
* Build Footer
*/
function build_footer($mode)
{
$html = '';
$html .= "# \n";
$html .= "#-----[ SAVE/CLOSE ALL FILES ]------------------------------------------ \n";
$html .= "# \n";
$html .= "# EoM";
return $html;
}
/**
* Build Header
*/
function build_header($mode, $filenames, $header)
{
global $substitute_old;
$html = '';
$html .= "############################################################## \n";
$html .= "## Title: " . $header['title'] . "\n";
$html .= "## Author: naderman < naderman@phpbb.com > (Nils Adermann) http://www.phpbb.com \n";
$html .= "## Description: \n";
$intr = explode("\n", $header['intro']);
$introduction = '';
foreach ($intr as $_line)
{
$introduction .= wordwrap($_line, 80) . "\n";
}
$intr = explode("\n", $introduction);
foreach ($intr as $_line)
{
$html .= "## " . $_line . "\n";
}
$html .= "## \n";
$html .= "## Files To Edit: \n";
foreach ($filenames as $file_ary)
{
$html .= "## " . $file_ary['phpbb_filename'] . "\n";
}
$html .= "##\n";
if (sizeof($header['included_files']))
{
$html .= "## Included Files: \n";
foreach ($header['included_files'] as $filename)
{
$html .= "## {$filename['phpbb_filename']}\n";
}
}
$html .= "## License: http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2 \n";
$html .= "############################################################## \n";
$html .= "\n";
// COPY Statement?
if (sizeof($header['included_files']))
{
$html .= "#\n#-----[ COPY ]------------------------------------------\n#\n";
foreach ($header['included_files'] as $filename)
{
$html .= "copy {$filename['phpbb_filename']} to {$filename['phpbb_filename']}\n";
}
$html .= "\n";
}
return $html;
}
function run_command($command)
{
$result = trim(`$command`);
echo "\n- Command Run: " . $command . "\n";
}

View File

@@ -1,9 +1,13 @@
<?php
/**
*
* @package build
* @copyright (c) 2010 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
* This file is part of the phpBB Forum Software package.
*
* @copyright (c) phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
* For full copyright and license information, please see
* the docs/CREDITS.txt file.
*
*/
@@ -312,4 +316,63 @@ class build_package
return $result;
}
/**
* Collect the list of the deleted files from a list of deleted files and folders.
*
* @param string $deleted_filename The full path to a file containing the list of deleted files and directories
* @param string $package_name The name of the package
* @return array
*/
public function collect_deleted_files($deleted_filename, $package_name)
{
$result = array();
$file_contents = file($deleted_filename);
foreach ($file_contents as $filename)
{
$filename = trim($filename);
if (!$filename)
{
continue;
}
$filename = str_replace('Only in ' . $package_name, '', $filename);
$filename = ltrim($filename, '/');
if (substr($filename, 0, 1) == ':')
{
$replace = '';
}
else
{
$replace = '/';
}
$filename = str_replace(': ', $replace, $filename);
if (is_dir("{$this->locations['old_versions']}{$package_name}/{$filename}"))
{
$iterator = new \RecursiveIteratorIterator(
new \RecursiveDirectoryIterator(
"{$this->locations['old_versions']}{$package_name}/{$filename}",
\FilesystemIterator::UNIX_PATHS | \FilesystemIterator::SKIP_DOTS
),
\RecursiveIteratorIterator::LEAVES_ONLY
);
foreach ($iterator as $file_info)
{
$result[] = "{$filename}/{$iterator->getSubPathname()}";
}
}
else
{
$result[] = $filename;
}
}
return $result;
}
}

View File

@@ -0,0 +1,222 @@
<?php
/**
*
* This file is part of the phpBB Forum Software package.
*
* @copyright (c) phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
* For full copyright and license information, please see
* the docs/CREDITS.txt file.
*
*/
/**
* Checks that each PHP source file contains a valid header as defined by the
* phpBB Coding Guidelines.
*
* @package code_sniffer
* @author Manuel Pichler <mapi@phpundercontrol.org>
*/
class phpbb_Sniffs_Commenting_FileCommentSniff implements PHP_CodeSniffer_Sniff
{
/**
* Returns an array of tokens this test wants to listen for.
*
* @return array
*/
public function register()
{
return array(T_OPEN_TAG);
}
/**
* Processes this test, when one of its tokens is encountered.
*
* @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
* @param int $stackPtr The position of the current token
* in the stack passed in $tokens.
*
* @return null
*/
public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
{
// We are only interested in the first file comment.
if ($stackPtr !== 0)
{
if ($phpcsFile->findPrevious(T_OPEN_TAG, $stackPtr - 1) !== false)
{
return;
}
}
// Fetch next non whitespace token
$tokens = $phpcsFile->getTokens();
$start = $phpcsFile->findNext(T_WHITESPACE, $stackPtr + 1, null, true);
// Skip empty files
if ($tokens[$start]['code'] === T_CLOSE_TAG)
{
return;
}
// Mark as error if this is not a doc comment
else if ($start === false || $tokens[$start]['code'] !== T_DOC_COMMENT)
{
$phpcsFile->addError('Missing required file doc comment.', $stackPtr);
return;
}
// Find comment end token
$end = $phpcsFile->findNext(T_DOC_COMMENT, $start + 1, null, true) - 1;
// If there is no end, skip processing here
if ($end === false)
{
return;
}
// List of found comment tags
$tags = array();
// check comment lines without the first(/**) an last(*/) line
for ($i = $start + 1, $c = $end - 1; $i <= $c; ++$i)
{
$line = $tokens[$i]['content'];
// Check that each line starts with a '*'
if (substr($line, 0, 1) !== '*' && substr($line, 0, 2) !== ' *')
{
$message = 'The file doc comment should not be indented.';
$phpcsFile->addWarning($message, $i);
}
else if (preg_match('/^[ ]?\*\s+@([\w]+)\s+(.*)$/', $line, $match) !== 0)
{
if (!isset($tags[$match[1]]))
{
$tags[$match[1]] = array();
}
$tags[$match[1]][] = array($match[2], $i);
}
}
// Check that the first and last line is empty
if (trim($tokens[$start + 1]['content']) !== '*')
{
$message = 'The first file comment line should be empty.';
$phpcsFile->addWarning($message, ($start + 1));
}
if (trim($tokens[$end - 1]['content']) !== '*')
{
$message = 'The last file comment line should be empty.';
$phpcsFile->addWarning($message, $end - 1);
}
//$this->processPackage($phpcsFile, $start, $tags);
//$this->processVersion($phpcsFile, $start, $tags);
$this->processCopyright($phpcsFile, $start, $tags);
$this->processLicense($phpcsFile, $start, $tags);
}
/**
* Checks that the tags array contains a valid package tag
*
* @param PHP_CodeSniffer_File $phpcsFile The context source file instance.
* @param integer The stack pointer for the first comment token.
* @param array(string=>array) $tags The found file doc comment tags.
*
* @return null
*/
protected function processPackage(PHP_CodeSniffer_File $phpcsFile, $ptr, $tags)
{
if (!isset($tags['package']))
{
$message = 'Missing require @package tag in file doc comment.';
$phpcsFile->addError($message, $ptr);
}
else if (preg_match('/^([\w]+)$/', $tags['package'][0]) === 0)
{
$message = 'Invalid content found for @package tag.';
$phpcsFile->addWarning($message, $tags['package'][1]);
}
}
/**
* Checks that the tags array contains a valid version tag
*
* @param PHP_CodeSniffer_File $phpcsFile The context source file instance.
* @param integer The stack pointer for the first comment token.
* @param array(string=>array) $tags The found file doc comment tags.
*
* @return null
*/
protected function processVersion(PHP_CodeSniffer_File $phpcsFile, $ptr, $tags)
{
if (!isset($tags['version']))
{
$message = 'Missing require @version tag in file doc comment.';
$phpcsFile->addError($message, $ptr);
}
else if (preg_match('/^\$Id:[^\$]+\$$/', $tags['version'][0]) === 0)
{
$message = 'Invalid content found for @version tag, use "$Id: $".';
$phpcsFile->addError($message, $tags['version'][1]);
}
}
/**
* Checks that the tags array contains a valid copyright tag
*
* @param PHP_CodeSniffer_File $phpcsFile The context source file instance.
* @param integer The stack pointer for the first comment token.
* @param array(string=>array) $tags The found file doc comment tags.
*
* @return null
*/
protected function processCopyright(PHP_CodeSniffer_File $phpcsFile, $ptr, $tags)
{
$copyright = '(c) phpBB Limited <https://www.phpbb.com>';
if (!isset($tags['copyright']))
{
$message = 'Missing require @copyright tag in file doc comment.';
$phpcsFile->addError($message, $ptr);
}
else if ($tags['copyright'][0][0] !== $copyright)
{
$message = 'Invalid content found for the first @copyright tag, use "' . $copyright . '".';
$phpcsFile->addError($message, $tags['copyright'][0][1]);
}
}
/**
* Checks that the tags array contains a valid license tag
*
* @param PHP_CodeSniffer_File $phpcsFile The context source file instance.
* @param integer The stack pointer for the first comment token.
* @param array(string=>array) $tags The found file doc comment tags.
*
* @return null
*/
protected function processLicense(PHP_CodeSniffer_File $phpcsFile, $ptr, $tags)
{
$license = 'GNU General Public License, version 2 (GPL-2.0)';
if (!isset($tags['license']))
{
$message = 'Missing require @license tag in file doc comment.';
$phpcsFile->addError($message, $ptr);
}
else if (sizeof($tags['license']) !== 1)
{
$message = 'It must be only one @license tag in file doc comment.';
$phpcsFile->addError($message, $ptr);
}
else if (trim($tags['license'][0][0]) !== $license)
{
$message = 'Invalid content found for @license tag, use '
. '"' . $license . '".';
$phpcsFile->addError($message, $tags['license'][0][1]);
}
}
}

View File

@@ -0,0 +1,234 @@
<?php
/**
*
* This file is part of the phpBB Forum Software package.
*
* @copyright (c) phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
* For full copyright and license information, please see
* the docs/CREDITS.txt file.
*
*/
/**
* Checks that each use statement is used.
*/
class phpbb_Sniffs_Namespaces_UnusedUseSniff implements PHP_CodeSniffer_Sniff
{
/**
* {@inheritdoc}
*/
public function register()
{
return array(T_USE);
}
protected function check($phpcsFile, $found_name, $full_name, $short_name, $line)
{
if ($found_name === $full_name)
{
$error = 'Either use statement or full name must be used.';
$phpcsFile->addError($error, $line, 'FullName');
}
if ($found_name === $short_name)
{
return true;
}
return false;
}
/**
* {@inheritdoc}
*/
public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
{
if ($this->should_ignore_use($phpcsFile, $stackPtr) === true)
{
return;
}
$tokens = $phpcsFile->getTokens();
$class_name_start = $phpcsFile->findNext(array(T_NS_SEPARATOR, T_STRING), ($stackPtr + 1));
$find = array(
T_NS_SEPARATOR,
T_STRING,
T_WHITESPACE,
);
$class_name_end = $phpcsFile->findNext($find, ($stackPtr + 1), null, true);
$aliasing_as_position = $phpcsFile->findNext(T_AS, $class_name_end, null, false, null, true);
if ($aliasing_as_position !== false)
{
$alias_position = $phpcsFile->findNext(T_STRING, $aliasing_as_position, null, false, null, true);
$class_name_short = $tokens[$alias_position]['content'];
$class_name_full = $phpcsFile->getTokensAsString($class_name_start, ($class_name_end - $class_name_start - 1));
}
else
{
$class_name_full = $phpcsFile->getTokensAsString($class_name_start, ($class_name_end - $class_name_start));
$class_name_short = $tokens[$class_name_end - 1]['content'];
}
$ok = false;
// Checks in simple statements (new, instanceof and extends)
foreach (array(T_INSTANCEOF, T_NEW, T_EXTENDS) as $keyword)
{
$old_simple_statement = $stackPtr;
while (($simple_statement = $phpcsFile->findNext($keyword, ($old_simple_statement + 1))) !== false)
{
$old_simple_statement = $simple_statement;
$simple_class_name_start = $phpcsFile->findNext(array(T_NS_SEPARATOR, T_STRING), ($simple_statement + 1));
$simple_class_name_end = $phpcsFile->findNext($find, ($simple_statement + 1), null, true);
$simple_class_name = trim($phpcsFile->getTokensAsString($simple_class_name_start, ($simple_class_name_end - $simple_class_name_start)));
$ok = $this->check($phpcsFile, $simple_class_name, $class_name_full, $class_name_short, $simple_statement) ? true : $ok;
}
}
// Checks paamayim nekudotayim
$old_paamayim_nekudotayim = $stackPtr;
while (($paamayim_nekudotayim = $phpcsFile->findNext(T_PAAMAYIM_NEKUDOTAYIM, ($old_paamayim_nekudotayim + 1))) !== false)
{
$old_paamayim_nekudotayim = $paamayim_nekudotayim;
$paamayim_nekudotayim_class_name_start = $phpcsFile->findPrevious($find, $paamayim_nekudotayim - 1, null, true);
$paamayim_nekudotayim_class_name_end = $paamayim_nekudotayim - 1;
$paamayim_nekudotayim_class_name = trim($phpcsFile->getTokensAsString($paamayim_nekudotayim_class_name_start + 1, ($paamayim_nekudotayim_class_name_end - $paamayim_nekudotayim_class_name_start)));
$ok = $this->check($phpcsFile, $paamayim_nekudotayim_class_name, $class_name_full, $class_name_short, $paamayim_nekudotayim) ? true : $ok;
}
// Checks in implements
$old_implements = $stackPtr;
while (($implements = $phpcsFile->findNext(T_IMPLEMENTS, ($old_implements + 1))) !== false)
{
$old_implements = $implements;
$old_implemented_class = $implements;
while (($implemented_class = $phpcsFile->findNext(T_STRING, ($old_implemented_class + 1), null, false, null, true)) !== false)
{
$old_implemented_class = $implemented_class;
$implements_class_name_start = $phpcsFile->findNext(array(T_NS_SEPARATOR, T_STRING), ($implemented_class - 1));
$implements_class_name_end = $phpcsFile->findNext($find, ($implemented_class - 1), null, true);
$implements_class_name = trim($phpcsFile->getTokensAsString($implements_class_name_start, ($implements_class_name_end - $implements_class_name_start)));
$ok = $this->check($phpcsFile, $implements_class_name, $class_name_full, $class_name_short, $implements) ? true : $ok;
}
}
// Checks in type hinting
$old_function_declaration = $stackPtr;
while (($function_declaration = $phpcsFile->findNext(T_FUNCTION, ($old_function_declaration + 1))) !== false)
{
$old_function_declaration = $function_declaration;
// Check docblocks
$find = array(
T_COMMENT,
T_DOC_COMMENT,
T_CLASS,
T_FUNCTION,
T_OPEN_TAG,
);
$comment_end = $phpcsFile->findPrevious($find, ($function_declaration - 1));
if ($comment_end !== false)
{
if (!$tokens[$comment_end]['code'] !== T_DOC_COMMENT)
{
$comment_start = ($phpcsFile->findPrevious(T_DOC_COMMENT, ($comment_end - 1), null, true) + 1);
$comment = $phpcsFile->getTokensAsString($comment_start, ($comment_end - $comment_start + 1));
try
{
$comment_parser = new PHP_CodeSniffer_CommentParser_FunctionCommentParser($comment, $phpcsFile);
$comment_parser->parse();
// Check @param
foreach ($comment_parser->getParams() as $param) {
$type = $param->getType();
$types = explode('|', str_replace('[]', '', $type));
foreach ($types as $type)
{
$ok = $this->check($phpcsFile, $type, $class_name_full, $class_name_short, $param->getLine() + $comment_start) ? true : $ok;
}
}
// Check @return
$return = $comment_parser->getReturn();
if ($return !== null)
{
$type = $return->getValue();
$types = explode('|', str_replace('[]', '', $type));
foreach ($types as $type)
{
$ok = $this->check($phpcsFile, $type, $class_name_full, $class_name_short, $return->getLine() + $comment_start) ? true : $ok;
}
}
}
catch (PHP_CodeSniffer_CommentParser_ParserException $e)
{
$line = ($e->getLineWithinComment() + $comment_start);
$phpcsFile->addError($e->getMessage(), $line, 'FailedParse');
}
}
}
// Check type hint
$params = $phpcsFile->getMethodParameters($function_declaration);
foreach ($params as $param)
{
$ok = $this->check($phpcsFile, $param['type_hint'], $class_name_full, $class_name_short, $function_declaration) ? true : $ok;
}
}
if (!$ok)
{
$error = 'There must not be unused USE statements.';
$phpcsFile->addError($error, $stackPtr, 'Unused');
}
}
/**
* Check if this use statement is part of the namespace block.
*
* @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
* @param int $stackPtr The position of the current token in
* the stack passed in $tokens.
*
* @return bool
*/
private function should_ignore_use(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
{
$tokens = $phpcsFile->getTokens();
// Ignore USE keywords inside closures.
$next = $phpcsFile->findNext(T_WHITESPACE, ($stackPtr + 1), null, true);
if ($tokens[$next]['code'] === T_OPEN_PARENTHESIS)
{
return true;
}
// Ignore USE keywords for traits.
if ($phpcsFile->hasCondition($stackPtr, array(T_CLASS, T_TRAIT)) === true)
{
return true;
}
return false;
}
}

View File

@@ -0,0 +1,15 @@
<?xml version="1.0"?>
<ruleset name="phpBB Minimum Standard">
<description>phpBB minimum coding standard</description>
<!-- All code files MUST use only UTF-8 without BOM. -->
<rule ref="Generic.Files.ByteOrderMark" />
<!-- All code files MUST use the Unix LF (linefeed) line ending. -->
<rule ref="Generic.Files.LineEndings" />
<!-- Tabs MUST be used for indentation -->
<rule ref="Generic.WhiteSpace.DisallowSpaceIndent" />
</ruleset>

View File

@@ -0,0 +1,8 @@
<?xml version="1.0"?>
<ruleset name="phpBB PHP Strict Standard Extensions">
<description>phpBB coding standard for PHP files of phpBB extensions</description>
<rule ref="./ruleset-php-strict.xml" />
</ruleset>

View File

@@ -0,0 +1,11 @@
<?xml version="1.0"?>
<ruleset name="phpBB PHP Legacy Standard Core">
<description>phpBB legacy coding standard for PHP files of phpBB core</description>
<rule ref="./ruleset-php-legacy.xml" />
<!-- Each file MUST start with a valid header as defined by the Coding Guidelines -->
<rule ref="./phpbb/Sniffs/Commenting/FileCommentSniff.php" />
</ruleset>

View File

@@ -0,0 +1,89 @@
<?xml version="1.0"?>
<ruleset name="phpBB PHP Legacy Standard">
<description>phpBB legacy coding standard for PHP files</description>
<rule ref="./ruleset-minimum.xml" />
<!-- "for (; bar; )" should be "while (bar)" instead -->
<rule ref="Generic.CodeAnalysis.ForLoopShouldBeWhileLoop" />
<!-- A method MUST not only call its parent -->
<rule ref="Generic.CodeAnalysis.UselessOverridingMethod" />
<!-- The body of each structure MUST be enclosed by braces. -->
<rule ref="Generic.ControlStructures.InlineControlStructure" />
<!-- There MUST not be more than one statement per line. -->
<rule ref="Generic.Formatting.DisallowMultipleStatements" />
<!-- Call-time pass-by-reference MUST not be used. -->
<rule ref="Generic.Functions.CallTimePassByReference.NotAllowed" />
<!-- Filenames MUST be lowercase. -->
<rule ref="Generic.Files.LowercasedFilename" />
<!-- The function brace MUST be on the line following the function declaration
and MUST be indented to the same column as the start of the function declaration. -->
<rule ref="Generic.Functions.OpeningFunctionBraceBsdAllman" />
<!-- There MUST be exactly one space after a cast. -->
<rule ref="Generic.Formatting.SpaceAfterCast" />
<!-- Class constants MUST be declared in all upper case with underscore separators. -->
<rule ref="Generic.NamingConventions.UpperCaseConstantName" />
<!-- Only <?php, no short tags. -->
<rule ref="Generic.PHP.DisallowShortOpenTag.EchoFound" />
<!-- Method arguments with default values MUST go at the end of the argument list. -->
<rule ref="PEAR.Functions.ValidDefaultValue" />
<!-- Each file MUST end with exactly one newline character -->
<rule ref="PSR2.Files.EndFileNewline" />
<!-- When referencing arrays there MUST NOT be any whitespace around the opening bracket
or before the closing bracket. -->
<rule ref="Squiz.Arrays.ArrayBracketSpacing" />
<!-- The "else if" statement MUST be written with a space between the words else and if. -->
<rule ref="Squiz.ControlStructures.ElseIfDeclaration" />
<!-- There MUST be a space between each element of a foreach loop. -->
<rule ref="Squiz.ControlStructures.ForEachLoopDeclaration" />
<!-- In a for loop declaration, there MUST be no space inside the brackets
and there MUST be 0 spaces before and 1 space after semicolons. -->
<rule ref="Squiz.ControlStructures.ForLoopDeclaration" />
<!-- In the argument list, there MUST NOT be a space before each comma,
and there MUST be one space after each comma. -->
<rule ref="Squiz.Functions.FunctionDeclarationArgumentSpacing">
<properties>
<property name="equalsSpacing" value="1"/>
</properties>
</rule>
<rule ref="Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint" />
<!-- All built-in PHP functions MUST be called lowercased. -->
<rule ref="Squiz.Functions.LowercaseFunctionKeywords" />
<!-- The eval() function MUST NOT be used. -->
<rule ref="Squiz.PHP.Eval" />
<!-- There MUST NOT be trailing whitespace at the end of lines. -->
<rule ref="Squiz.WhiteSpace.SuperfluousWhitespace" />
<!-- There MUST NOT be whitespace before the first content of a file -->
<rule ref="Squiz.WhiteSpace.SuperfluousWhitespace.StartFile" />
<!-- There MUST NOT be whitespace after the last content of a file -->
<rule ref="Squiz.WhiteSpace.SuperfluousWhitespace.EndFile" />
<!-- Functions MUST NOT contain multiple empty lines in a row -->
<rule ref="Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines" />
<!-- The ?> closing tag MUST be omitted from files containing only PHP. -->
<rule ref="Zend.Files.ClosingTag" />
</ruleset>

View File

@@ -0,0 +1,9 @@
<?xml version="1.0"?>
<ruleset name="phpBB PHP Strict Standard Core">
<description>phpBB coding standard for PHP files of phpBB core</description>
<rule ref="./ruleset-php-legacy-core.xml" />
<rule ref="./ruleset-php-strict.xml" />
</ruleset>

View File

@@ -0,0 +1,48 @@
<?xml version="1.0"?>
<ruleset name="phpBB PHP Strict Standard">
<description>phpBB coding standard for PHP files</description>
<rule ref="./ruleset-php-legacy.xml" />
<!-- There SHOULD NOT be more than 80 characters per line
There MUST NOT be more than 120 characters per line -->
<!--
<rule ref="Generic.Files.LineLength">
<properties>
<property name="lineLimit" value="80"/>
<property name="absoluteLineLimit" value="120"/>
</properties>
</rule>
-->
<!-- The PHP constants true, false, and null MUST be in lower case. -->
<rule ref="Generic.PHP.LowerCaseConstant" />
<!-- PHP keywords MUST be in lower case. -->
<rule ref="Generic.PHP.LowerCaseKeyword" />
<!-- Constructors MUST be called __construct() instead of after the class. -->
<rule ref="Generic.NamingConventions.ConstructorName" />
<!-- Classes etc. MUST be namespaced -->
<rule ref="PSR1.Classes.ClassDeclaration.MissingNamespace" />
<!-- A file MUST not contain more than one class/interface -->
<rule ref="PSR1.Classes.ClassDeclaration.MultipleClasses" />
<!-- Files containing classes MUST not have any side-effects -->
<rule ref="PSR1.Files.SideEffects.FoundWithSymbols" />
<!-- When present, all use declarations MUST go after the namespace declaration.
There MUST be one use keyword per declaration.
There MUST be one blank line after the use block. -->
<rule ref="PSR2.Namespaces.UseDeclaration" />
<!-- There MUST be one blank line after the namespace declaration -->
<rule ref="PSR2.Namespaces.NamespaceDeclaration" />
<!-- There MUST NOT be unused use statements. -->
<rule ref="./phpbb/Sniffs/Namespaces/UnusedUseSniff.php" />
</ruleset>

File diff suppressed because it is too large Load Diff

View File

@@ -2,9 +2,13 @@
<?php
/**
*
* @package build
* @copyright (c) 2010 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
* This file is part of the phpBB Forum Software package.
*
* @copyright (c) phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
* For full copyright and license information, please see
* the docs/CREDITS.txt file.
*
*/
@@ -45,6 +49,10 @@ if (sizeof($package->old_packages))
$package->get('patch_directory') . '/phpBB-' . $dest_package_filename . $package->get('new_version_number') . '.patch',
$_package_name
);
$diff_file_changes[$_package_name]['deleted'] = $package->collect_deleted_files(
$package->get('patch_directory') . '/phpBB-' . $dest_package_filename . $package->get('new_version_number') . '.deleted',
$_package_name
);
}
// Now put those files determined within the correct directories
@@ -139,6 +147,12 @@ if (sizeof($package->old_packages))
{
unset($file_contents['all'][$index]);
}
$source_filename = $package->locations['old_versions'] . $package->get('simple_name') . '/' . $file;
if (!file_exists($source_filename))
{
unset($file_contents['all'][$index]);
}
}
// First of all, fill the 'old' directory
@@ -174,16 +188,27 @@ if (sizeof($package->old_packages))
$package->run_command('cp ' . $source_filename . ' ' . $dest_filename);
}
/**
* We try to keep the update packages as small as possible while creating them.
* However, we sometimes need to include additional files that are not included
* in the diff in order to be able to correctly include the relatively
* referenced files from the same or subsequent directories.
*/
$copy_relative_directories = array(
'config/' => array(
'copied' => false,
'copy' => array(
'config/*.yml' => 'config',
),
),
);
// Then fill the 'new' directory
foreach ($file_contents['all'] as $file)
{
$source_filename = $package->locations['old_versions'] . $package->get('simple_name') . '/' . $file;
$dest_filename = $dest_filename_dir . '/install/update/new/' . $file;
if (!file_exists($source_filename))
{
continue;
}
$filename = $file;
// Create Directories along the way?
$file = explode('/', $file);
@@ -205,6 +230,73 @@ if (sizeof($package->old_packages))
}
$package->run_command('cp ' . $source_filename . ' ' . $dest_filename);
foreach ($copy_relative_directories as $reference => $data)
{
// Copy all relative referenced files if needed
if (strpos($filename, $reference) === 0 && !$data['copied'])
{
foreach ($data['copy'] as $source_dir_files => $destination_dir)
{
// Create directories along the way?
$directories = explode('/', $destination_dir);
chdir($dest_filename_dir . '/install/update/new');
foreach ($directories as $dir)
{
$dir = trim($dir);
if ($dir)
{
if (!file_exists('./' . $dir))
{
$package->run_command('mkdir ' . $dir);
}
chdir('./' . $dir);
}
}
$source_dir_files = $package->locations['old_versions'] . $package->get('simple_name') . '/' . $source_dir_files;
$destination_dir = $dest_filename_dir . '/install/update/new/' . $destination_dir;
$package->run_command('cp ' . $source_dir_files . ' ' . $destination_dir);
}
$copy_relative_directories[$reference]['copied'] = true;
}
}
}
/**
* We need to always copy the template and asset files that we need in
* the update, to ensure that the page is displayed correctly.
*/
$copy_update_files = array(
'adm/images/*' => 'adm/images',
'adm/style/admin.css' => 'adm/style',
'adm/style/admin.js' => 'adm/style',
'adm/style/ajax.js' => 'adm/style',
'adm/style/install_*' => 'adm/style',
'assets/javascript/*' => 'assets/javascript',
);
foreach ($copy_update_files as $source_files => $destination_dir)
{
// Create directories along the way?
$directories = explode('/', $destination_dir);
chdir($dest_filename_dir . '/install/update/new');
foreach ($directories as $dir)
{
$dir = trim($dir);
if ($dir)
{
if (!file_exists('./' . $dir))
{
$package->run_command('mkdir ' . $dir);
}
chdir('./' . $dir);
}
}
$source_dir_files = $package->locations['old_versions'] . $package->get('simple_name') . '/' . $source_files;
$destination_dir = $dest_filename_dir . '/install/update/new/' . $destination_dir;
$package->run_command('cp ' . $source_dir_files . ' ' . $destination_dir);
}
// Build index.php file for holding the file structure
@@ -222,29 +314,32 @@ $update_info = array(
if (sizeof($file_contents['all']))
{
$index_contents .= '\'files\' => array(\'' . implode("',\n\t'", $file_contents['all']) . '\'),
';
$index_contents .= "\t'files' => array(\n\t\t'" . implode("',\n\t\t'", $file_contents['all']) . "',\n\t),\n";
}
else
{
$index_contents .= '\'files\' => array(),
';
$index_contents .= "\t'files' => array(),\n";
}
if (sizeof($file_contents['binary']))
{
$index_contents .= '\'binary\' => array(\'' . implode("',\n\t'", $file_contents['binary']) . '\'),
';
$index_contents .= "\t'binary' => array(\n\t\t'" . implode("',\n\t\t'", $file_contents['binary']) . "',\n\t),\n";
}
else
{
$index_contents .= '\'binary\' => array(),
';
$index_contents .= "\t'binary' => array(),\n";
}
$index_contents .= ');
if (sizeof($file_contents['deleted']))
{
$index_contents .= "\t'deleted' => array(\n\t\t'" . implode("',\n\t\t'", $file_contents['deleted']) . "',\n\t),\n";
}
else
{
$index_contents .= "\t'deleted' => array(),\n";
}
?' . '>';
$index_contents .= ");\n";
$fp = fopen($dest_filename_dir . '/install/update/index.php', 'wt');
fwrite($fp, $index_contents);
@@ -299,6 +394,7 @@ if (sizeof($package->old_packages))
$package->run_command('mkdir ' . $package->get('files_directory') . '/release');
$package->run_command('cp -Rp ' . $package->get('dest_dir') . '/docs ' . $package->get('files_directory') . '/release');
$package->run_command('cp -Rp ' . $package->get('dest_dir') . '/install ' . $package->get('files_directory') . '/release');
$package->run_command('cp -Rp ' . $package->get('dest_dir') . '/vendor ' . $package->get('files_directory') . '/release');
$package->run_command('rm -v ' . $package->get('files_directory') . '/release/install/install_install.php');
$package->run_command('rm -v ' . $package->get('files_directory') . '/release/install/install_update.php');
@@ -374,14 +470,22 @@ chdir($package->get('dest_dir') . '/install');
// $package->run_command('rm -v database_update.php');
$package->run_command('rm -v install_update.php');
chdir($package->get('dest_dir'));
$package->run_command('mv -v styles/subsilver2 ../subsilver2');
$package->run_command('cp -p docs/COPYING ../subsilver2/license.txt');
chdir($package->locations['package_dir']);
foreach ($compress_programs as $extension => $compress_command)
{
$package->begin_status('Packaging phpBB for ' . $extension);
$package->run_command('rm -v ./release_files/' . $package->get('release_filename') . ".{$extension}");
$package->run_command('rm -v ./release_files/subsilver2_' . $package->get('new_version_number') . ".{$extension}");
// Build Package
$package->run_command("$compress_command ./release_files/" . $package->get('release_filename') . '.' . $extension . ' ' . $package->get('package_name'));
// Build subSilver2 Package
$package->run_command("$compress_command ./release_files/subsilver2_" . $package->get('new_version_number') . '.' . $extension . ' subsilver2');
}
// Microsoft Web PI packaging

View File

@@ -1,145 +0,0 @@
; Default configuration file for PHPDoctor
; This config file will cause PHPDoctor to generate API documentation of
; itself.
; PHPDoctor settings
; -----------------------------------------------------------------------------
; Names of files to parse. This can be a single filename, or a comma separated
; list of filenames. Wildcards are allowed.
files = "*.php"
; Names of files or directories to ignore. This can be a single filename, or a
; comma separated list of filenames. Wildcards are NOT allowed.
;ignore = "CVS, .svn, .git, _compiled"
ignore = templates_c/,*HTML/default/*,spec/,*config.php*,*CVS/,test_chora.php,testupdate/,cache/,store/,*proSilver/,develop/,includes/utf/data/,includes/captcha/fonts/,install/update/,install/update.new/,files/,*phpinfo.php*,*update_script.php*,*upgrade.php*,*convert.php*,install/converter/,language/de/,script/,*swatch.php*,*test.php*,*test2.php*,*install.php*,*functions_diff.php*,*acp_update.php*,acm_xcache.php
; The directory to look for files in, if not used the PHPDoctor will look in
; the current directory (the directory it is run from).
source_path = "../phpBB/"
; If you do not want PHPDoctor to look in each sub directory for files
; uncomment this line.
;subdirs = off
; Set how loud PHPDoctor is as it runs. Quiet mode suppresses all output other
; than warnings and errors. Verbose mode outputs additional messages during
; execution.
quiet = on
;verbose = on
; Select the doclet to use for generating output.
doclet = standard
;doclet = debug
; The directory to find the doclet in. Doclets control the HTML output of
; phpDoctor and can be modified to suit your needs. They are expected to be
; in a directory named after themselves at the location given.
;doclet_path = ./doclets
; Select the formatter to use for generating output.
;formatter = htmlStandardFormatter
; The directory to find the formatter in. Formatters convert textual markup
; for use by the doclet.
;formatter_path = ./formatters
; The directory to find taglets in. Taglets allow you to make PHPDoctor handle
; new tags and to alter the behavour of existing tags and their output.
;taglet_path = ./taglets
; If the code you are parsing does not use package tags or not all elements
; have package tags, use this setting to place unbound elements into a
; particular package.
default_package = "phpBB"
use_class_path_as_package = off
ignore_package_tags = off
; Specifies the name of a HTML file containing text for the overview
; documentation to be placed on the overview page. The path is relative to
; "source_path" unless an absolute path is given.
overview = ../README.md
; Package comments will be looked for in a file named package.html in the same
; directory as the first source file parsed in that package or in the directory
; given below. If package comments are placed in the directory given below then
; they should be named "<packageName>.html".
package_comment_dir = ./
; Parse out global variables and/or global constants?
;globals = off
;constants = off
; Generate documentation for all class members
;private = on
; Generate documentation for public and protected class members
;protected = on
; Generate documentation for only public class members
;public = on
; Use the PEAR compatible handling of the docblock first sentence
;pear_compat = on
; Standard doclet settings
; -----------------------------------------------------------------------------
; The directory to place generated documentation in. If the given path is
; relative to it will be relative to "source_path".
d = "../build/api/"
; Specifies the title to be placed in the HTML <title> tag.
windowtitle = "phpBB3"
; Specifies the title to be placed near the top of the overview summary file.
doctitle = "phpBB3 Sourcecode Documentation"
; Specifies the header text to be placed at the top of each output file. The
; header will be placed to the right of the upper navigation bar.
header = "phpBB3"
; Specifies the footer text to be placed at the bottom of each output file. The
; footer will be placed to the right of the lower navigation bar.
footer = "phpBB3"
; Specifies the text to be placed at the bottom of each output file. The text
; will be placed at the bottom of the page, below the lower navigation bar.
;bottom = "This document was generated by <a href="http://peej.github.com/phpdoctor/">PHPDoctor: The PHP Documentation Creator</a>"
; Create a class tree?
;tree = off
; Use GeSHi to include formatted source files in the documentation. PHPDoctor will look in the current doclet directory for a /geshi subdirectory. Unpack the GeSHi archive from http://qbnz.com/highlighter to get this directory - it will contain a php script and a subdirectory with formatting files.
include_source = off

30
build/sami-all.conf.php Normal file
View File

@@ -0,0 +1,30 @@
<?php
/**
*
* This file is part of the phpBB Forum Software package.
*
* @copyright (c) phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
* For full copyright and license information, please see
* the docs/CREDITS.txt file.
*
*/
require __DIR__ . '/sami-checkout.conf.php';
$config['versions'] = Sami\Version\GitVersionCollection::create(__DIR__ . '/../')
/*
This would be nice, but currently causes various problems that need
debugging.
->addFromTags('release-3.0.*')
->add('develop-olympus', '3.0-next (olympus)')
->addFromTags('release-3.1.*')
->add('develop-ascraeus', '3.1-next (ascraeus)')
->add('develop')
*/
->add('develop-olympus')
->add('develop-ascraeus')
;
return new Sami\Sami($iterator, $config);

View File

@@ -0,0 +1,44 @@
<?php
/**
*
* This file is part of the phpBB Forum Software package.
*
* @copyright (c) phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
* For full copyright and license information, please see
* the docs/CREDITS.txt file.
*
*/
// Prevent 'Class "acm" does not exist.' exception on removeClass().
class PhpbbArrayStore extends Sami\Store\ArrayStore
{
public function removeClass(Sami\Project $project, $name)
{
unset($this->classes[$name]);
}
}
$iterator = Symfony\Component\Finder\Finder::create()
->files()
->name('*.php')
->in(__DIR__ . '/../phpBB/')
->notPath('#^cache/#')
->notPath('#^develop/#')
->notPath('#^ext/#')
->notPath('#^vendor/#')
->notPath('data')
;
$config = array(
'theme' => 'enhanced',
'title' => 'phpBB API Documentation',
'build_dir' => __DIR__.'/api/output/%version%',
'cache_dir' => __DIR__.'/api/cache/%version%',
'default_opened_level' => 2,
// Do not use JsonStore. See https://github.com/fabpot/Sami/issues/79
'store' => new PhpbbArrayStore,
);
return new Sami\Sami($iterator, $config);

View File

@@ -1,210 +0,0 @@
<?php
/**
*
* @package code_sniffer
* @version $Id: $
* @copyright (c) 2007 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
*
*/
/**
* Checks that each source file contains the standard header.
*
* Based on Coding Guidelines 1.ii File Header.
*
* @package code_sniffer
* @author Manuel Pichler <mapi@phpundercontrol.org>
*/
class phpbb_Sniffs_Commenting_FileCommentSniff implements PHP_CodeSniffer_Sniff
{
/**
* Returns an array of tokens this test wants to listen for.
*
* @return array
*/
public function register()
{
return array(T_OPEN_TAG);
}
/**
* Processes this test, when one of its tokens is encountered.
*
* @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
* @param int $stackPtr The position of the current token
* in the stack passed in $tokens.
*
* @return null
*/
public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
{
// We are only interested in the first file comment.
if ($stackPtr !== 0)
{
if ($phpcsFile->findPrevious(T_OPEN_TAG, $stackPtr - 1) !== false)
{
return;
}
}
// Fetch next non whitespace token
$tokens = $phpcsFile->getTokens();
$start = $phpcsFile->findNext(T_WHITESPACE, $stackPtr + 1, null, true);
// Skip empty files
if ($tokens[$start]['code'] === T_CLOSE_TAG)
{
return;
}
// Mark as error if this is not a doc comment
else if ($start === false || $tokens[$start]['code'] !== T_DOC_COMMENT)
{
$phpcsFile->addError('Missing required file doc comment.', $stackPtr);
return;
}
// Find comment end token
$end = $phpcsFile->findNext(T_DOC_COMMENT, $start + 1, null, true) - 1;
// If there is no end, skip processing here
if ($end === false)
{
return;
}
// List of found comment tags
$tags = array();
// check comment lines without the first(/**) an last(*/) line
for ($i = $start + 1, $c = ($end - $start); $i <= $c; ++$i)
{
$line = $tokens[$i]['content'];
// Check that each line starts with a '*'
if (substr($line, 0, 1) !== '*')
{
$message = 'The file doc comment should not be idented.';
$phpcsFile->addWarning($message, $i);
}
else if (preg_match('/^\*\s+@([\w]+)\s+(.*)$/', $line, $match) !== 0)
{
$tags[$match[1]] = array($match[2], $i);
}
}
// Check that the first and last line is empty
if (trim($tokens[$start + 1]['content']) !== '*')
{
$message = 'The first file comment line should be empty.';
$phpcsFile->addWarning($message, ($start + 1));
}
if (trim($tokens[$end - $start]['content']) !== '*')
{
$message = 'The last file comment line should be empty.';
$phpcsFile->addWarning($message, ($end - $start));
}
$this->processPackage($phpcsFile, $start, $tags);
$this->processVersion($phpcsFile, $start, $tags);
$this->processCopyright($phpcsFile, $start, $tags);
$this->processLicense($phpcsFile, $start, $tags);
//print_r($tags);
}
/**
* Checks that the tags array contains a valid package tag
*
* @param PHP_CodeSniffer_File $phpcsFile The context source file instance.
* @param integer The stack pointer for the first comment token.
* @param array(string=>array) $tags The found file doc comment tags.
*
* @return null
*/
protected function processPackage(PHP_CodeSniffer_File $phpcsFile, $ptr, $tags)
{
if (!isset($tags['package']))
{
$message = 'Missing require @package tag in file doc comment.';
$phpcsFile->addError($message, $ptr);
}
else if (preg_match('/^([\w]+)$/', $tags['package'][0]) === 0)
{
$message = 'Invalid content found for @package tag.';
$phpcsFile->addWarning($message, $tags['package'][1]);
}
}
/**
* Checks that the tags array contains a valid version tag
*
* @param PHP_CodeSniffer_File $phpcsFile The context source file instance.
* @param integer The stack pointer for the first comment token.
* @param array(string=>array) $tags The found file doc comment tags.
*
* @return null
*/
protected function processVersion(PHP_CodeSniffer_File $phpcsFile, $ptr, $tags)
{
if (!isset($tags['version']))
{
$message = 'Missing require @version tag in file doc comment.';
$phpcsFile->addError($message, $ptr);
}
else if (preg_match('/^\$Id:[^\$]+\$$/', $tags['version'][0]) === 0)
{
$message = 'Invalid content found for @version tag, use "$Id: $".';
$phpcsFile->addError($message, $tags['version'][1]);
}
}
/**
* Checks that the tags array contains a valid copyright tag
*
* @param PHP_CodeSniffer_File $phpcsFile The context source file instance.
* @param integer The stack pointer for the first comment token.
* @param array(string=>array) $tags The found file doc comment tags.
*
* @return null
*/
protected function processCopyright(PHP_CodeSniffer_File $phpcsFile, $ptr, $tags)
{
if (!isset($tags['copyright']))
{
$message = 'Missing require @copyright tag in file doc comment.';
$phpcsFile->addError($message, $ptr);
}
else if (preg_match('/^\(c\) 2[0-9]{3} phpBB Group\s*$/', $tags['copyright'][0]) === 0)
{
$message = 'Invalid content found for @copyright tag, use "(c) <year> phpBB Group".';
$phpcsFile->addError($message, $tags['copyright'][1]);
}
}
/**
* Checks that the tags array contains a valid license tag
*
* @param PHP_CodeSniffer_File $phpcsFile The context source file instance.
* @param integer The stack pointer for the first comment token.
* @param array(string=>array) $tags The found file doc comment tags.
*
* @return null
*/
protected function processLicense(PHP_CodeSniffer_File $phpcsFile, $ptr, $tags)
{
$license = 'http://opensource.org/licenses/gpl-license.php GNU Public License';
if (!isset($tags['license']))
{
$message = 'Missing require @license tag in file doc comment.';
$phpcsFile->addError($message, $ptr);
}
else if (trim($tags['license'][0]) !== $license)
{
$message = 'Invalid content found for @license tag, use '
. '"' . $license . '".';
$phpcsFile->addError($message, $tags['license'][1]);
}
}
}

View File

@@ -1,19 +0,0 @@
<?php
/**
*
* @package code_sniffer³
* @version $Id: $
* @copyright (c) 2008 phpBB Group
* @license http://opensource.org/licenses/gpl-license.php BSD License
*
*/
?>
<?php
/**
* Broken but not first file doc comment.
*
* @version @package_version@
* @license http://www.opensource.org/licenses/bsd-license.php BSD License
* @copyright (c) 2007 phpBB Group
*
*/

View File

@@ -1,51 +0,0 @@
<?php
/**
*
* @package code_sniffer
* @version $Id: $
* @copyright (c) 2007 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
*
*/
/**
* Unit test class for the EmptyStatement sniff.
*
* @package code_sniffer
* @author Manuel Pichler <mapi@phpundercontrol.org>
*/
class phpbb_Tests_Commenting_FileCommentUnitTest extends AbstractSniffUnitTest
{
/**
* Returns the lines where errors should occur.
*
* The key of the array should represent the line number and the value
* should represent the number of errors that should occur on that line.
*
* @return array(int => int)
*/
public function getErrorList()
{
return array(
7 => 1 // BSD License error :)
);
}//end getErrorList()
/**
* Returns the lines where warnings should occur.
*
* The key of the array should represent the line number and the value
* should represent the number of warnings that should occur on that line.
*
* @return array(int => int)
*/
public function getWarningList()
{
return array(
4 => 1,
8 => 1
);
}//end getWarningList()
}

View File

@@ -1,23 +0,0 @@
<?xml version="1.0" encoding="UTF-8"?>
<project name="code_sniffer" basedir="." default="install">
<property name="working.dir" value="${basedir}" />
<property name="target.dir" value="/usr/share/php/PHP/CodeSniffer/Standards" />
<!--
Install phpbb sniff
-->
<target name="install">
<delete dir="${target.dir}/phpbb" />
<mkdir dir="${target.dir}/phpbb"/>
<copy todir="${target.dir}/phpbb">
<fileset file="${working.dir}/phpbbCodingStandard.php" />
</copy>
<copy todir="${target.dir}/phpbb/Sniffs">
<fileset dir="${working.dir}/Sniffs" />
</copy>
</target>
</project>

View File

@@ -1,43 +0,0 @@
<?php
/**
*
* @package code_sniffer
* @version $Id: $
* @copyright (c) 2007 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
*
*/
/**
* @ignore
*/
if (class_exists('PHP_CodeSniffer_Standards_CodingStandard', true) === false) {
throw new PHP_CodeSniffer_Exception(
'Class PHP_CodeSniffer_Standards_CodingStandard not found'
);
}
/**
* Primary class for the phpbb coding standard.
*
* @package code_sniffer
*/
class PHP_CodeSniffer_Standards_phpbb_phpbbCodingStandard extends PHP_CodeSniffer_Standards_CodingStandard
{
/**
* Return a list of external sniffs to include with this standard.
*
* External locations can be single sniffs, a whole directory of sniffs, or
* an entire coding standard. Locations start with the standard name. For
* example:
* PEAR => include all sniffs in this standard
* PEAR/Sniffs/Files => include all sniffs in this dir
* PEAR/Sniffs/Files/LineLengthSniff => include this single sniff
*
* @return array
*/
public function getIncludedSniffs()
{
return array();
}
}

Binary file not shown.

View File

@@ -0,0 +1,56 @@
#!/bin/bash
#
# This file is part of the phpBB Forum Software package.
#
# @copyright (c) phpBB Limited <https://www.phpbb.com>
# @license GNU General Public License, version 2 (GPL-2.0)
#
# For full copyright and license information, please see
# the docs/CREDITS.txt file.
#
# Calls the git commit-msg hook on all non-merge commits in a given commit range.
#
if [ "$#" -ne 1 ];
then
echo "Expected one argument (commit range, e.g. phpbb/develop..ticket/12345)."
exit
fi
DIR=$(dirname "$0")
COMMIT_RANGE="$1"
COMMIT_MSG_HOOK_PATH="$DIR/hooks/commit-msg"
COMMIT_MSG_HOOK_FATAL=$(git config --bool phpbb.hooks.commit-msg.fatal 2> /dev/null)
git config phpbb.hooks.commit-msg.fatal true
EXIT_STATUS=0
for COMMIT_HASH in $(git rev-list --no-merges "$COMMIT_RANGE")
do
echo "Inspecting commit message of commit $COMMIT_HASH"
# The git commit-msg hook takes a path to a file containing a commit
# message. So we have to extract the commit message into a file first,
# which then also needs to be deleted after our work is done.
COMMIT_MESSAGE_PATH="$DIR/commit_msg.$COMMIT_HASH"
git log -n 1 --pretty=format:%B "$COMMIT_HASH" > "$COMMIT_MESSAGE_PATH"
# Invoke hook on commit message file.
"$COMMIT_MSG_HOOK_PATH" "$COMMIT_MESSAGE_PATH"
# If any commit message hook complains with a non-zero exit status, we
# will send a non-zero exit status upstream.
if [ $? -ne 0 ]
then
EXIT_STATUS=1
fi
rm "$COMMIT_MESSAGE_PATH"
done
# Restore phpbb.hooks.commit-msg.fatal config
if [ -n "$COMMIT_MSG_HOOK_FATAL" ]
then
git config phpbb.hooks.commit-msg.fatal "$COMMIT_MSG_HOOK_FATAL"
fi
exit $EXIT_STATUS

View File

@@ -191,12 +191,12 @@ do
err=$ERR_HEADER;
echo "$line" | grep -Eq "^\[(ticket/[0-9]+|feature/$branch_regex|task/$branch_regex)\] .+$"
result=$?
if ! echo "$line" | grep -Eq "^\[(ticket/[0-9]+|feature/$branch_regex|task/$branch_regex)\] [A-Z].+$"
if ! echo "$line" | grep -Eq "^\[(ticket/[0-9]+|feature/$branch_regex|task/$branch_regex)\] [a-zA-Z].+$"
then
# Don't be too strict.
# Commits may be temporary, intended to be squashed later.
# Just issue a warning here.
complain "$severity: heading should be a sentence beginning with a capital letter." 1>&2
complain "$severity: heading should be a sentence beginning with a letter." 1>&2
complain "You entered:" 1>&2
complain "$line" 1>&2
fi

View File

@@ -2,9 +2,13 @@
<?php
/**
*
* @package phpBB3
* @copyright (c) 2011 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
* This file is part of the phpBB Forum Software package.
*
* @copyright (c) phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
* For full copyright and license information, please see
* the docs/CREDITS.txt file.
*
*/

View File

@@ -2,9 +2,13 @@
<?php
/**
*
* @package phpBB3
* @copyright (c) 2011 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
* This file is part of the phpBB Forum Software package.
*
* @copyright (c) phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
* For full copyright and license information, please see
* the docs/CREDITS.txt file.
*
*/

View File

@@ -26,12 +26,50 @@ RewriteRule ^(.*)$ app.php [QSA,L]
#Options +FollowSymLinks
</IfModule>
<Files "config.php">
Order Allow,Deny
Deny from All
</Files>
<Files "common.php">
Order Allow,Deny
Deny from All
</Files>
# With Apache 2.4 the "Order, Deny" syntax has been deprecated and moved from
# module mod_authz_host to a new module called mod_access_compat (which may be
# disabled) and a new "Require" syntax has been introduced to mod_authz_host.
# We could just conditionally provide both versions, but unfortunately Apache
# does not explicitly tell us its version if the module mod_version is not
# available. In this case, we check for the availability of module
# mod_authz_core (which should be on 2.4 or higher only) as a best guess.
<IfModule mod_version.c>
<IfVersion < 2.4>
<Files "config.php">
Order Allow,Deny
Deny from All
</Files>
<Files "common.php">
Order Allow,Deny
Deny from All
</Files>
</IfVersion>
<IfVersion >= 2.4>
<Files "config.php">
Require all denied
</Files>
<Files "common.php">
Require all denied
</Files>
</IfVersion>
</IfModule>
<IfModule !mod_version.c>
<IfModule !mod_authz_core.c>
<Files "config.php">
Order Allow,Deny
Deny from All
</Files>
<Files "common.php">
Order Allow,Deny
Deny from All
</Files>
</IfModule>
<IfModule mod_authz_core.c>
<Files "config.php">
Require all denied
</Files>
<Files "common.php">
Require all denied
</Files>
</IfModule>
</IfModule>

Binary file not shown.

Before

Width:  |  Height:  |  Size: 113 B

After

Width:  |  Height:  |  Size: 51 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 111 B

After

Width:  |  Height:  |  Size: 49 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 111 B

After

Width:  |  Height:  |  Size: 49 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 113 B

After

Width:  |  Height:  |  Size: 51 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 2.3 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 541 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 796 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 55 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 175 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 56 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 688 B

After

Width:  |  Height:  |  Size: 662 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 734 B

After

Width:  |  Height:  |  Size: 708 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 707 B

After

Width:  |  Height:  |  Size: 681 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 751 B

After

Width:  |  Height:  |  Size: 725 B

Binary file not shown.

After

Width:  |  Height:  |  Size: 1.3 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 474 B

After

Width:  |  Height:  |  Size: 930 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 9.1 KiB

After

Width:  |  Height:  |  Size: 6.5 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 788 B

View File

@@ -1,9 +1,13 @@
<?php
/**
*
* @package acp
* @copyright (c) 2005 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
* This file is part of the phpBB Forum Software package.
*
* @copyright (c) phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
* For full copyright and license information, please see
* the docs/CREDITS.txt file.
*
*/
@@ -50,7 +54,13 @@ $module_id = request_var('i', '');
$mode = request_var('mode', '');
// Set custom style for admin area
$template->set_custom_style('adm', $phpbb_admin_path . 'style');
$template->set_custom_style(array(
array(
'name' => 'adm',
'ext_path' => 'adm/style/',
),
), $phpbb_admin_path . 'style');
$template->assign_var('T_ASSETS_PATH', $phpbb_root_path . 'assets');
$template->assign_var('T_TEMPLATE_PATH', $phpbb_admin_path . 'style');

View File

@@ -122,11 +122,11 @@
{
if (newimage == 'no_image')
{
document.getElementById('image_upload_icon').src = "{PHPBB_ROOT_PATH}images/spacer.gif";
document.getElementById('image_upload_icon').src = "{ROOT_PATH}images/spacer.gif";
}
else
{
document.getElementById('image_upload_icon').src = "{PHPBB_ROOT_PATH}{IMG_PATH}/" + newimage;
document.getElementById('image_upload_icon').src = "{ROOT_PATH}{IMG_PATH}/" + newimage;
}
}
@@ -192,7 +192,7 @@
<dd><select name="upload_icon" id="upload_icon" onchange="update_image(this.options[selectedIndex].value);">
<option value="no_image"<!-- IF S_NO_IMAGE --> selected="selected"<!-- ENDIF -->>{L_NO_IMAGE}</option>{S_FILENAME_LIST}
</select></dd>
<dd>&nbsp;<img <!-- IF S_NO_IMAGE -->src="{PHPBB_ROOT_PATH}images/spacer.gif"<!-- ELSE -->src="{UPLOAD_ICON_SRC}"<!-- ENDIF --> id="image_upload_icon" alt="" title="" />&nbsp;</dd>
<dd>&nbsp;<img <!-- IF S_NO_IMAGE -->src="{ROOT_PATH}images/spacer.gif"<!-- ELSE -->src="{UPLOAD_ICON_SRC}"<!-- ENDIF --> id="image_upload_icon" alt="" title="" />&nbsp;</dd>
</dl>
<dl>
<dt><label for="extgroup_filesize">{L_MAX_EXTGROUP_FILESIZE}{L_COLON}</label></dt>
@@ -205,8 +205,8 @@
</dl>
<dl>
<dt><label for="allowed_forums">{L_ALLOWED_FORUMS}{L_COLON}</label><br /><span>{L_ALLOWED_FORUMS_EXPLAIN}</span></dt>
<dd><label><input type="radio" id="allowed_forums" class="radio" name="forum_select" value="0"<!-- IF not S_FORUM_IDS --> checked="checked"<!-- ENDIF --> /> {L_ALLOW_ALL_FORUMS}</label>
<label><input type="radio" class="radio" name="forum_select" value="1"<!-- IF S_FORUM_IDS --> checked="checked"<!-- ENDIF --> /> {L_ALLOW_SELECTED_FORUMS}</label></dd>
<dd><label><input type="radio" id="allowed_forums" class="radio" name="forum_select" value="0"<!-- IF not S_FORUM_IDS --> checked="checked"<!-- ENDIF --> /> {L_ALLOW_ALL_FORUMS}</label></dd>
<dd><label><input type="radio" class="radio" name="forum_select" value="1"<!-- IF S_FORUM_IDS --> checked="checked"<!-- ENDIF --> /> {L_ALLOW_SELECTED_FORUMS}</label></dd>
<dd><select name="allowed_forums[]" multiple="multiple" size="8">{S_FORUM_ID_OPTIONS}</select></dd>
</dl>
@@ -224,7 +224,7 @@
<fieldset class="tabulated">
<legend>{L_TITLE}</legend>
<table cellspacing="1">
<table class="table1">
<col class="row1" /><col class="row1" /><col class="row2" />
<thead>
<tr>
@@ -284,14 +284,12 @@
</fieldset>
</form>
<br />
<form id="change_ext" method="post" action="{U_ACTION}">
<fieldset class="tabulated">
<legend>{L_TITLE}</legend>
<table cellspacing="1">
<table class="table1">
<col class="row1" /><col class="row1" /><col class="row2" />
<thead>
<tr>
@@ -331,24 +329,24 @@
<fieldset class="tabulated">
<legend>{L_TITLE}</legend>
<table cellspacing="1">
<table class="table1 zebra-table fixed-width-table">
<thead>
<tr>
<th>{L_FILENAME}</th>
<th>{L_FILEDATE}</th>
<th>{L_FILESIZE}</th>
<th>{L_ATTACH_POST_ID}</th>
<th>{L_ATTACH_TO_POST}</th>
<th>{L_DELETE}</th>
<th style="width: 15%;">{L_FILEDATE}</th>
<th style="width: 15%;">{L_FILESIZE}</th>
<th style="width: 15%;">{L_ATTACH_POST_ID}</th>
<th style="width: 15%;">{L_ATTACH_TO_POST}</th>
<th style="width: 15%;">{L_DELETE}</th>
</tr>
</thead>
<tbody>
<!-- BEGIN orphan -->
<!-- IF orphan.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td><a href="{orphan.U_FILE}">{orphan.REAL_FILENAME}</a></td>
<td>{orphan.FILETIME}</td>
<td>{orphan.FILESIZE}</td>
<td><strong>{L_ATTACH_ID}{L_COLON} </strong><input type="number" name="post_id[{orphan.ATTACH_ID}]" size="7" maxlength="10" value="{orphan.POST_ID}" /></td>
<td><strong>{L_ATTACH_ID}{L_COLON} </strong><input type="number" name="post_id[{orphan.ATTACH_ID}]" maxlength="10" value="{orphan.POST_ID}" style="width: 75%;" /></td>
<td><input type="checkbox" class="radio" name="add[{orphan.ATTACH_ID}]" /></td>
<td><input type="checkbox" class="radio" name="delete[{orphan.ATTACH_ID}]" /></td>
</tr>
@@ -378,46 +376,58 @@
<fieldset class="tabulated">
<legend>{L_TITLE}</legend>
<div class="pagination">
<div class="pagination top-pagination">
<!-- IF .pagination or TOTAL_FILES -->
{L_NUMBER_FILES}{L_COLON} {TOTAL_FILES} &bull; {L_TOTAL_SIZE}{L_COLON} {TOTAL_SIZE}
<!-- IF .pagination -->
&bull; <!-- INCLUDE pagination.html -->
<!-- ELSE -->
&bull; {S_ON_PAGE}
&bull; {PAGE_NUMBER}
<!-- ENDIF -->
<!-- ENDIF -->
</div>
<table cellspacing="1">
<!-- IF .attachments -->
<table class="table1 zebra-table fixed-width-table">
<thead>
<tr>
<th>{L_FILENAME}</th>
<th>{L_POSTED}</th>
<th>{L_FILESIZE}</th>
<th>{L_DELETE}</th>
<th style="width: 15%;">{L_POSTED}</th>
<th style="width: 15%;" class="centered-text">{L_FILESIZE}</th>
<th style="width: 10%;" class="centered-text">{L_MARK}</th>
</tr>
</thead>
<tbody>
<!-- BEGIN attachments -->
<!-- IF attachments.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td>
<!-- IF attachments.S_IN_MESSAGE -->{L_EXTENSION_GROUP}{L_COLON} <strong><!-- IF attachments.EXT_GROUP_NAME -->{attachments.EXT_GROUP_NAME}<!-- ELSE -->{L_NO_EXT_GROUP}<!-- ENDIF --></strong><br />{attachments.L_DOWNLOAD_COUNT}<br />{L_IN} {L_PRIVATE_MESSAGE}
<!-- ELSE --><a href="{attachments.U_FILE}" style="font-weight: bold;">{attachments.REAL_FILENAME}</a><br /><!-- IF attachments.COMMENT -->{attachments.COMMENT}<br /><!-- ENDIF -->{attachments.L_DOWNLOAD_COUNT}<br />{L_TOPIC}{L_COLON} <a href="{attachments.U_VIEW_TOPIC}">{attachments.TOPIC_TITLE}</a><!-- ENDIF -->
</td>
<td>{attachments.FILETIME}<br />{L_POST_BY_AUTHOR} {attachments.ATTACHMENT_POSTER}</td>
<td>{attachments.FILESIZE}</td>
<td><input type="checkbox" class="radio" name="delete[{attachments.ATTACH_ID}]" /></td>
<td class="centered-text">{attachments.FILESIZE}</td>
<td class="centered-text"><input type="checkbox" class="radio" name="delete[{attachments.ATTACH_ID}]" /></td>
</tr>
<!-- END attachments -->
<tr class="row4">
<td colspan="3">&nbsp;</td>
<td class="small"><a href="#" onclick="marklist('attachments', 'delete', true); return false;">{L_MARK_ALL}</a> :: <a href="#" onclick="marklist('attachments', 'delete', false); return false;">{L_UNMARK_ALL}</a></td>
</tr>
</tbody>
</table>
<!-- ELSE -->
<div class="errorbox">
<p>{L_NO_ATTACHMENTS}</p>
</div>
<!-- ENDIF -->
<!-- IF TOTAL_FILES -->
<div class="pagination">
{L_NUMBER_FILES}{L_COLON} {TOTAL_FILES} &bull; {L_TOTAL_SIZE}{L_COLON} {TOTAL_SIZE}
<!-- IF .pagination -->
&bull; <!-- INCLUDE pagination.html -->
<!-- ELSE -->
&bull; {PAGE_NUMBER}
<!-- ENDIF -->
</div>
<!-- ENDIF -->
<fieldset class="display-options">
{L_DISPLAY_LOG}{L_COLON} &nbsp;{S_LIMIT_DAYS}&nbsp;{L_SORT_BY}{L_COLON} {S_SORT_KEY} {S_SORT_DIR}
<input class="button2" type="submit" value="{L_GO}" name="sort" />
@@ -425,20 +435,15 @@
<hr />
<div class="pagination">
{L_NUMBER_FILES}{L_COLON} {TOTAL_FILES} &bull; {L_TOTAL_SIZE}{L_COLON} {TOTAL_SIZE}
<!-- IF .pagination -->
&bull; <!-- INCLUDE pagination.html -->
<!-- ELSE -->
&bull; {S_ON_PAGE}
<!-- ENDIF -->
</div>
<!-- ENDIF -->
<p class="submit-buttons">
<input class="button1" type="submit" id="submit" name="submit" value="{L_SUBMIT}" />&nbsp;
<input class="button2" type="reset" id="reset" name="reset" value="{L_RESET}" />
</p>
<!-- IF .attachments -->
<fieldset class="quick">
<input class="button2" type="submit" name="submit" value="{L_DELETE_MARKED}" /><br />
<p class="small">
<a href="#" onclick="marklist('attachments', 'delete', true); return false;">{L_MARK_ALL}</a> &bull;
<a href="#" onclick="marklist('attachments', 'delete', false); return false;">{L_UNMARK_ALL}</a>
</p>
</fieldset>
<!-- ENDIF -->
{S_FORM_TOKEN}
</fieldset>
</form>

View File

@@ -1,25 +1,20 @@
<dl>
<dt><label for="category">{L_AVATAR_CATEGORY}{L_COLON}</label></dt>
<dd><select name="avatar_local_cat" id="category">
<option value="">{L_NO_AVATAR_CATEGORY}</option>
<!-- BEGIN avatar_local_cats -->
<option value="{avatar_local_cats.NAME}"<!-- IF avatar_local_cats.SELECTED --> selected="selected"<!-- ENDIF -->>{avatar_local_cats.NAME}</option>
<!-- END avatar_local_cats -->
</select>&nbsp;<input type="submit" value="{L_GO}" name="avatar_local_go" class="button2" /></dd>
</dl>
<!-- IF AVATAR_LOCAL_SHOW -->
<table>
<ul id="gallery">
<!-- BEGIN avatar_local_row -->
<tr>
<!-- BEGIN avatar_local_col -->
<td class="row1" style="text-align: center;"><img src="{avatar_local_row.avatar_local_col.AVATAR_IMAGE}" alt="{avatar_local_row.avatar_local_col.AVATAR_NAME}" title="{avatar_local_row.avatar_local_col.AVATAR_NAME}"/></td>
<!-- END avatar_local_col -->
</tr>
<tr>
<!-- BEGIN avatar_local_option -->
<td class="row2" style="text-align: center;"><input type="radio" name="avatar_local_file" id="av-{avatar_local_row.S_ROW_COUNT}-{avatar_local_row.avatar_local_option.S_ROW_COUNT}" value="{avatar_local_row.avatar_local_option.AVATAR_FILE}" /></td>
<!-- END avatar_local_option -->
</tr>
<!-- BEGIN avatar_local_col -->
<li>
<label for="av-{avatar_local_row.S_ROW_COUNT}-{avatar_local_row.avatar_local_col.S_ROW_COUNT}"><img src="{avatar_local_row.avatar_local_col.AVATAR_IMAGE}" alt="" /><br />
<input type="radio" name="avatar_local_file" id="av-{avatar_local_row.S_ROW_COUNT}-{avatar_local_row.avatar_local_col.S_ROW_COUNT}" value="{avatar_local_row.avatar_local_col.AVATAR_FILE}" /></label>
</li>
<!-- END avatar_local_col -->
<!-- END avatar_local_row -->
</table>
</ul>
<!-- ENDIF -->

View File

@@ -13,27 +13,34 @@
var ban_length = new Array();
ban_length[-1] = '';
<!-- BEGIN ban_length -->
ban_length['{ban_length.BAN_ID}'] = '{ban_length.A_LENGTH}';
<!-- END ban_length -->
var ban_reason = new Array();
ban_reason[-1] = '';
<!-- BEGIN ban_reason -->
ban_reason['{ban_reason.BAN_ID}'] = '{ban_reason.A_REASON}';
<!-- END ban_reason -->
var ban_give_reason = new Array();
ban_give_reason[-1] = '';
<!-- BEGIN ban_give_reason -->
ban_give_reason['{ban_give_reason.BAN_ID}'] = '{ban_give_reason.A_REASON}';
<!-- END ban_give_reason -->
<!-- BEGIN bans -->
ban_length['{bans.BAN_ID}'] = '{bans.A_LENGTH}';
<!-- IF bans.A_REASON -->
ban_reason['{bans.BAN_ID}'] = '{bans.A_REASON}';
<!-- ENDIF -->
<!-- IF bans.A_GIVE_REASON -->
ban_give_reason['{bans.BAN_ID}'] = '{bans.A_GIVE_REASON}';
<!-- ENDIF -->
<!-- END bans -->
function display_details(option)
{
document.getElementById('acp_unban').unbangivereason.innerHTML = ban_give_reason[option];
document.getElementById('acp_unban').unbanreason.innerHTML = ban_reason[option];
document.getElementById('acp_unban').unbanlength.value = ban_length[option];
document.getElementById('unbanlength').value = ban_length[option];
if (option in ban_reason) {
document.getElementById('unbanreason').innerHTML = ban_reason[option];
} else {
document.getElementById('unbanreason').innerHTML = '';
}
if (option in ban_give_reason) {
document.getElementById('unbangivereason').innerHTML = ban_give_reason[option];
} else {
document.getElementById('unbangivereason').innerHTML = '';
}
}
// ]]>

View File

@@ -47,6 +47,8 @@
</dl>
</fieldset>
<!-- EVENT acp_bbcodes_edit_fieldsets_after -->
<fieldset class="submit-buttons">
<legend>{L_SUBMIT}</legend>
<input class="button1" type="submit" id="submit" name="submit" value="{L_SUBMIT}" />&nbsp;
@@ -56,7 +58,7 @@
<br />
<table cellspacing="1" id="down">
<table class="table1" id="down">
<thead>
<tr>
<th colspan="2">{L_TOKENS}</th>
@@ -71,7 +73,7 @@
</thead>
<tbody>
<!-- BEGIN token -->
<tr valign="top">
<tr style="vertical-align: top;">
<td class="row1">{token.TOKEN}</td>
<td class="row2">{token.EXPLAIN}</td>
</tr>
@@ -90,7 +92,7 @@
<fieldset class="tabulated">
<legend>{L_ACP_BBCODES}</legend>
<table cellspacing="1" id="down">
<table class="table1 zebra-table" id="down">
<thead>
<tr>
<th>{L_BBCODE_TAG}</th>
@@ -99,9 +101,9 @@
</thead>
<tbody>
<!-- BEGIN bbcodes -->
<!-- IF bbcodes.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td style="text-align: center;">{bbcodes.BBCODE_TAG}</td>
<td style="text-align: right; width: 40px;"><a href="{bbcodes.U_EDIT}">{ICON_EDIT}</a> <a href="{bbcodes.U_DELETE}" data-ajax="row_delete">{ICON_DELETE}</a></td>
<td class="actions"><!-- EVENT acp_bbcodes_actions_prepend --> <a href="{bbcodes.U_EDIT}">{ICON_EDIT}</a> <a href="{bbcodes.U_DELETE}" data-ajax="row_delete">{ICON_DELETE}</a> <!-- EVENT acp_bbcodes_actions_append --></td>
</tr>
<!-- BEGINELSE -->
<tr class="row3">

View File

@@ -33,9 +33,12 @@
<!-- END options -->
<!-- IF S_AUTH -->
</fieldset>
<!-- BEGIN auth_tpl -->
<!-- INCLUDE {auth_tpl.TEMPLATE_FILE} -->
<!-- END auth_tpl -->
<fieldset>
<legend>{L_ACP_SUBMIT_CHANGES}</legend>
<!-- ENDIF -->
<p class="submit-buttons">

View File

@@ -62,7 +62,7 @@
<form id="acp_bots" method="post" action="{U_ACTION}">
<table cellspacing="1">
<table class="table1 zebra-table">
<thead>
<tr>
<th>{L_BOT_NAME}</th>
@@ -73,7 +73,7 @@
</thead>
<tbody>
<!-- BEGIN bots -->
<!-- IF bots.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td style="width: 50%;">{bots.BOT_NAME}</td>
<td style="width: 15%; white-space: nowrap;" align="center">&nbsp;{bots.LAST_VISIT}&nbsp;</td>
<td style="text-align: center;">&nbsp;<a href="{bots.U_ACTIVATE_DEACTIVATE}" data-ajax="activate_deactivate">{bots.L_ACTIVATE_DEACTIVATE}</a>&nbsp;</td>

View File

@@ -6,6 +6,7 @@
<p>{L_ACP_VC_SETTINGS_EXPLAIN}</p>
<p>{L_ACP_VC_EXT_GET_MORE}</p>
<form id="acp_captcha" method="post" action="{U_ACTION}">

View File

@@ -0,0 +1,76 @@
<!-- INCLUDE overall_header.html -->
<script type="text/javascript">
// <![CDATA[
var form_name = 'acp_contact';
var text_name = 'contact_admin_info';
var load_draft = false;
var upload = false;
var imageTag = false;
// ]]>
</script>
<a id="maincontent"></a>
<h1>{L_ACP_CONTACT_SETTINGS}</h1>
<p>{L_ACP_CONTACT_SETTINGS_EXPLAIN}</p>
<form id="acp_contact" method="post" action="{U_ACTION}">
<fieldset>
<legend>{L_GENERAL_OPTIONS}</legend>
<dl>
<dt><label for="contact_admin_form_enable">{L_CONTACT_US_ENABLE}{L_COLON}</label><br /><span>{L_CONTACT_US_ENABLE_EXPLAIN}</span></dt>
<dd>
<label><input type="radio" class="radio" id="contact_admin_form_enable" name="contact_admin_form_enable" value="1"<!-- IF CONTACT_ENABLED --> checked="checked"<!-- ENDIF --> /> {L_ENABLED}</label>
<label><input type="radio" class="radio" name="contact_admin_form_enable" value="0"<!-- IF not CONTACT_ENABLED --> checked="checked"<!-- ENDIF --> /> {L_DISABLED}</label>
</dd>
</dl>
</fieldset>
<!-- IF CONTACT_US_INFO_PREVIEW -->
<fieldset>
<legend>{L_CONTACT_US_INFO_PREVIEW}</legend>
<p>{CONTACT_US_INFO_PREVIEW}</p>
</fieldset>
<!-- ENDIF -->
<fieldset>
<legend>{L_CONTACT_US_INFO}</legend>
<p>{L_CONTACT_US_INFO_EXPLAIN}</p>
<!-- INCLUDE acp_posting_buttons.html -->
<dl class="responsive-columns">
<dt style="width: 90px;" id="color_palette_placeholder" data-orientation="v" data-height="12" data-width="15" data-bbcode="true">
</dt>
<dd style="margin-{S_CONTENT_FLOW_BEGIN}: 90px;">
<textarea name="contact_admin_info" rows="10" cols="60" style="width: 95%;" onselect="storeCaret(this);" onclick="storeCaret(this);" onkeyup="storeCaret(this);" onfocus="initInsertions();" data-bbcode="true">{CONTACT_US_INFO}</textarea>
</dd>
<dd style="margin-{S_CONTENT_FLOW_BEGIN}: 90px; margin-top: 5px;">
<!-- IF S_BBCODE_ALLOWED -->
<label><input type="checkbox" class="radio" name="disable_bbcode"<!-- IF S_BBCODE_DISABLE_CHECKED --> checked="checked"<!-- ENDIF --> /> {L_DISABLE_BBCODE}</label>
<!-- ENDIF -->
<!-- IF S_SMILIES_ALLOWED -->
<label><input type="checkbox" class="radio" name="disable_smilies"<!-- IF S_SMILIES_DISABLE_CHECKED --> checked="checked"<!-- ENDIF --> /> {L_DISABLE_SMILIES}</label>
<!-- ENDIF -->
<!-- IF S_LINKS_ALLOWED -->
<label><input type="checkbox" class="radio" name="disable_magic_url"<!-- IF S_MAGIC_URL_DISABLE_CHECKED --> checked="checked"<!-- ENDIF --> /> {L_DISABLE_MAGIC_URL}</label>
<!-- ENDIF -->
</dd>
<dd style="margin-{S_CONTENT_FLOW_BEGIN}: 90px; margin-top: 10px;"><strong>{L_OPTIONS}{L_COLON} </strong>{BBCODE_STATUS} :: {IMG_STATUS} :: {FLASH_STATUS} :: {URL_STATUS} :: {SMILIES_STATUS}</dd>
</dl>
</fieldset>
<fieldset class="submit-buttons">
<input class="button1" type="submit" id="submit" name="submit" value="{L_SUBMIT}" />&nbsp;
<input class="button2" type="submit" name="preview" value="{L_PREVIEW}" />
{S_FORM_TOKEN}
</fieldset>
</form>
<!-- INCLUDE overall_footer.html -->

View File

@@ -47,6 +47,8 @@
<dd><input id="send" type="checkbox" class="radio" name="send_immediately" checked="checked" /></dd>
</dl>
<!-- EVENT acp_email_options_after -->
<p class="submit-buttons">
<input class="button1" type="submit" id="submit" name="submit" value="{L_SEND_EMAIL}" />&nbsp;
<input class="button2" type="reset" id="reset" name="reset" value="{L_RESET}" />

View File

@@ -1,39 +1,39 @@
<!-- INCLUDE overall_header.html -->
<a name="maincontent"></a>
<a id="maincontent"></a>
<h1>{L_EXTENSIONS_ADMIN}</h1>
<p>{L_EXTENSIONS_EXPLAIN}</p>
<p>{L_PURGE_EXPLAIN}</p>
<p>{L_EXTENSION_DELETE_DATA_EXPLAIN}</p>
<!-- IF MIGRATOR_ERROR -->
<div class="errorbox">
<p><strong>{L_MIGRATION_EXCEPTION_ERROR}</strong></p>
<p>{MIGRATOR_ERROR}</p>
<p><a href="{U_RETURN}">{L_RETURN}</a></p>
<p><a href="{U_RETURN}">{L_RETURN_TO_EXTENSION_LIST}</a></p>
</div>
<!-- ELSEIF PRE -->
<div class="errorbox">
<p>{L_PURGE_CONFIRM}</p>
<p>{L_CONFIRM_MESSAGE}</p>
</div>
<form id="acp_extensions" method="post" action="{U_PURGE}">
<fieldset class="submit-buttons">
<legend>{L_PURGE}</legend>
<input class="button1" type="submit" name="purge" value="{L_PURGE}" />
<legend>{L_EXTENSION_DELETE_DATA}</legend>
<input class="button1" type="submit" name="delete_data" value="{L_EXTENSION_DELETE_DATA}" />
<input class="button2" type="submit" name="cancel" value="{L_CANCEL}" />
</fieldset>
</form>
<!-- ELSEIF S_NEXT_STEP -->
<div class="errorbox">
<p>{L_PURGE_IN_PROGRESS}</p>
<p>{L_EXTENSION_DELETE_DATA_IN_PROGRESS}</p>
</div>
<!-- ELSE -->
<div class="successbox">
<p>{L_PURGE_SUCCESS}</p>
<p>{L_EXTENSION_DELETE_DATA_SUCCESS}</p>
<br />
<p><a href="{U_RETURN}">{L_RETURN}</a></p>
<p><a href="{U_RETURN}">{L_RETURN_TO_EXTENSION_LIST}</a></p>
</div>
<!-- ENDIF -->

View File

@@ -1,64 +1,106 @@
<!-- INCLUDE overall_header.html -->
<a name="maincontent"></a>
<a id="maincontent"></a>
<a href="{U_BACK}" style="float: {S_CONTENT_FLOW_END};">&laquo; {L_BACK}</a>
<h1>{L_EXTENSIONS_ADMIN}</h1>
<!-- IF S_VERSIONCHECK -->
<div class="<!-- IF S_UP_TO_DATE -->successbox<!-- ELSE -->errorbox<!-- ENDIF -->">
<p>{UP_TO_DATE_MSG} - <a href="{U_VERSIONCHECK_FORCE}">{L_VERSIONCHECK_FORCE_UPDATE}</a></p>
</div>
<!-- ELSE IF S_VERSIONCHECK_STATUS == 0 -->
<div class="errorbox notice">
<p>{L_VERSIONCHECK_FAIL}</p>
<p>{VERSIONCHECK_FAIL_REASON}</p>
<p><a href="{U_VERSIONCHECK_FORCE}">{L_VERSIONCHECK_FORCE_UPDATE}</a></p>
</div>
<!-- ELSE IF S_VERSIONCHECK_STATUS == 1 -->
<div class="errorbox notice">
<p>{VERSIONCHECK_FAIL_REASON}</p>
</div>
<!-- ENDIF -->
<fieldset>
<legend>{L_EXT_DETAILS}</legend>
<!-- IF META_DISPLAY_NAME -->
<dl>
<dt><label for="meta_display_name">{L_DISPLAY_NAME}{L_COLON}</label></dt>
<dt><label>{L_DISPLAY_NAME}{L_COLON}</label></dt>
<dd><strong id="meta_display_name">{META_DISPLAY_NAME}</strong></dd>
</dl>
<!-- ENDIF -->
<dl>
<dt><label for="meta_name">{L_CLEAN_NAME}{L_COLON}</label></dt>
<dt><label>{L_CLEAN_NAME}{L_COLON}</label></dt>
<dd><strong id="meta_name">{META_NAME}</strong></dd>
</dl>
<!-- IF META_DESCRIPTION -->
<dl>
<dt><label for="meta_description">{L_DESCRIPTION}{L_COLON}</label></dt>
<dd><p id="meta_description">{META_DESCRIPTION}</p></dd>
<dt><label>{L_DESCRIPTION}{L_COLON}</label></dt>
<dd><span id="meta_description">{META_DESCRIPTION}</span></dd>
</dl>
<!-- ENDIF -->
<dl>
<dt><label for="meta_version">{L_VERSION}{L_COLON}</label></dt>
<dd><p id="meta_version">{META_VERSION}</p></dd>
<dt><label>{L_VERSION}{L_COLON}</label></dt>
<dd><span id="meta_version">{META_VERSION}</span></dd>
</dl>
<!-- IF META_HOMEPAGE -->
<dl>
<dt><label for="meta_homepage">{L_HOMEPAGE}{L_COLON}</label></dt>
<dd><p id="meta_homepage">{META_HOMEPAGE}</p></dd>
<dt><label>{L_HOMEPAGE}{L_COLON}</label></dt>
<dd><strong id="meta_homepage"><a href="{META_HOMEPAGE}">{META_HOMEPAGE}</a></strong></dd>
</dl>
<!-- ENDIF -->
<!-- IF META_TIME -->
<dl>
<dt><label for="meta_time">{L_TIME}{L_COLON}</label></dt>
<dd><p id="meta_time">{META_TIME}</p></dd>
<dt><label>{L_TIME}{L_COLON}</label></dt>
<dd><span id="meta_time">{META_TIME}</span></dd>
</dl>
<!-- ENDIF -->
<dl>
<dt><label for="meta_license">{L_LICENCE}{L_COLON}</label></dt>
<dd><p id="meta_license">{META_LICENCE}</p></dd>
<dt><label>{L_LICENSE}{L_COLON}</label></dt>
<dd><span id="meta_license">{META_LICENSE}</span></dd>
</dl>
</fieldset>
<!-- IF S_VERSIONCHECK && not S_UP_TO_DATE -->
<fieldset>
<legend>{L_LATEST_VERSION}</legend>
<!-- BEGIN updates_available -->
<fieldset>
<dl>
<dt><label>{L_VERSION}{L_COLON}</label></dt>
<dd><strong>{updates_available.current}</strong></dd>
</dl>
<!-- IF updates_available.download-->
<dl>
<dt><label>{L_DOWNLOAD_LATEST}</label></dt>
<dd><strong><a href="{updates_available.download}">{L_DOWNLOAD} {META_NAME} {LATEST_VERSION}</a></strong></dd>
</dl>
<!-- ENDIF -->
<!-- IF updates_available.announcement -->
<dl>
<dt><label>{L_ANNOUNCEMENT_TOPIC}</label></dt>
<dd><strong><a href="{updates_available.announcement}">{L_RELEASE_ANNOUNCEMENT}</a></strong></dd>
</dl>
<!-- ENDIF -->
</fieldset>
<!-- END updates_available -->
</fieldset>
<!-- ENDIF -->
<!-- IF META_REQUIRE_PHPBB || META_REQUIRE_PHP -->
<fieldset>
<legend>{L_REQUIREMENTS}</legend>
<!-- IF META_REQUIRE_PHPBB -->
<dl<!-- IF META_REQUIRE_PHPBB_FAIL --> class="requirements_not_met"<!-- ENDIF -->>
<dt><label for="require_phpbb">{L_PHPBB_VERSION}{L_COLON}</label></dt>
<dd><p id="require_phpbb">{META_REQUIRE_PHPBB}</p></dd>
<dt><label>{L_PHPBB_VERSION}{L_COLON}</label></dt>
<dd><span id="require_phpbb">{META_REQUIRE_PHPBB}</span></dd>
</dl>
<!-- ENDIF -->
<!-- IF META_REQUIRE_PHP -->
<dl<!-- IF META_REQUIRE_PHP_FAIL --> class="requirements_not_met"<!-- ENDIF -->>
<dt><label for="require_php">{L_PHP_VERSION}{L_COLON}</label></dt>
<dd><p id="require_php">{META_REQUIRE_PHP}</p></dd>
<dt><label>{L_PHP_VERSION}{L_COLON}</label></dt>
<dd><span id="require_php">{META_REQUIRE_PHP}</span></dd>
</dl>
<!-- ENDIF -->
</fieldset>
@@ -69,25 +111,25 @@
<!-- BEGIN meta_authors -->
<fieldset>
<dl>
<dt><label for="meta_author_name">{L_AUTHOR_NAME}{L_COLON}</label></dt>
<dd><strong id="meta_author_name">{meta_authors.AUTHOR_NAME}</strong></dd>
<dt><label>{L_AUTHOR_NAME}{L_COLON}</label></dt>
<dd><strong>{meta_authors.AUTHOR_NAME}</strong></dd>
</dl>
<!-- IF meta_authors.AUTHOR_EMAIL -->
<dl>
<dt><label for="meta_author_email">{L_AUTHOR_EMAIL}{L_COLON}</label></dt>
<dd><strong id="meta_author_email"><a href="mailto:{meta_authors.AUTHOR_EMAIL}">{meta_authors.AUTHOR_EMAIL}</a></strong></dd>
<dt><label>{L_AUTHOR_EMAIL}{L_COLON}</label></dt>
<dd><strong><a href="mailto:{meta_authors.AUTHOR_EMAIL}">{meta_authors.AUTHOR_EMAIL}</a></strong></dd>
</dl>
<!-- ENDIF -->
<!-- IF meta_authors.AUTHOR_HOMEPAGE -->
<dl>
<dt><label for="meta_author_url">{L_AUTHOR_HOMEPAGE}{L_COLON}</label></dt>
<dd><strong id="meta_author_url"><a href="{meta_authors.AUTHOR_HOMEPAGE}">{meta_authors.AUTHOR_HOMEPAGE}</a></strong></dd>
<dt><label>{L_AUTHOR_HOMEPAGE}{L_COLON}</label></dt>
<dd><strong><a href="{meta_authors.AUTHOR_HOMEPAGE}">{meta_authors.AUTHOR_HOMEPAGE}</a></strong></dd>
</dl>
<!-- ENDIF -->
<!-- IF meta_authors.AUTHOR_ROLE -->
<dl>
<dt><label for="author_role">{L_AUTHOR_ROLE}{L_COLON}</label></dt>
<dd><strong id="meta_author_role">{meta_authors.AUTHOR_ROLE}</strong></dd>
<dt><label>{L_AUTHOR_ROLE}{L_COLON}</label></dt>
<dd><strong>{meta_authors.AUTHOR_ROLE}</strong></dd>
</dl>
<!-- ENDIF -->
</fieldset>

View File

@@ -1,33 +1,33 @@
<!-- INCLUDE overall_header.html -->
<a name="maincontent"></a>
<a id="maincontent"></a>
<h1>{L_EXTENSIONS_ADMIN}</h1>
<p>{L_EXTENSIONS_EXPLAIN}</p>
<p>{L_DISABLE_EXPLAIN}</p>
<p>{L_EXTENSION_DISABLE_EXPLAIN}</p>
<!-- IF PRE -->
<div class="errorbox">
<p>{L_DISABLE_CONFIRM}</p>
</div>
<fieldset>
<h2>{L_CONFIRM}</h2>
<p>{L_CONFIRM_MESSAGE}</p>
</fieldset>
<form id="acp_extensions" method="post" action="{U_DISABLE}">
<fieldset class="submit-buttons">
<legend>{L_DISABLE}</legend>
<input class="button1" type="submit" name="disable" value="{L_DISABLE}" />
<input class="button1" type="submit" name="disable" value="{L_EXTENSION_DISABLE}" />
<input class="button2" type="submit" name="cancel" value="{L_CANCEL}" />
</fieldset>
</form>
<!-- ELSEIF S_NEXT_STEP -->
<div class="errorbox">
<p>{L_DISABLE_IN_PROGRESS}</p>
<div class="successbox notice">
<p>{L_EXTENSION_DISABLE_IN_PROGRESS}</p>
</div>
<!-- ELSE -->
<div class="successbox">
<p>{L_DISABLE_SUCCESS}</p>
<p>{L_EXTENSION_DISABLE_SUCCESS}</p>
<br />
<p><a href="{U_RETURN}">{L_RETURN}</a></p>
<p><a href="{U_RETURN}">{L_RETURN_TO_EXTENSION_LIST}</a></p>
</div>
<!-- ENDIF -->

View File

@@ -1,39 +1,39 @@
<!-- INCLUDE overall_header.html -->
<a name="maincontent"></a>
<a id="maincontent"></a>
<h1>{L_EXTENSIONS_ADMIN}</h1>
<p>{L_EXTENSIONS_EXPLAIN}</p>
<p>{L_ENABLE_EXPLAIN}</p>
<p>{L_EXTENSION_ENABLE_EXPLAIN}</p>
<!-- IF MIGRATOR_ERROR -->
<div class="errorbox">
<p><strong>{L_MIGRATION_EXCEPTION_ERROR}</strong></p>
<p>{MIGRATOR_ERROR}</p>
<p><a href="{U_RETURN}">{L_RETURN}</a></p>
<p><a href="{U_RETURN}">{L_RETURN_TO_EXTENSION_LIST}</a></p>
</div>
<!-- ELSEIF PRE -->
<div class="errorbox">
<p>{L_ENABLE_CONFIRM}</p>
</div>
<fieldset>
<h2>{L_CONFIRM}</h2>
<p>{L_CONFIRM_MESSAGE}</p>
</fieldset>
<form id="acp_extensions" method="post" action="{U_ENABLE}">
<fieldset class="submit-buttons">
<legend>{L_ENABLE}</legend>
<input class="button1" type="submit" name="enable" value="{L_ENABLE}" />
<input class="button1" type="submit" name="enable" value="{L_EXTENSION_ENABLE}" />
<input class="button2" type="submit" name="cancel" value="{L_CANCEL}" />
</fieldset>
</form>
<!-- ELSEIF S_NEXT_STEP -->
<div class="errorbox">
<p>{L_ENABLE_IN_PROGRESS}</p>
<div class="successbox notice">
<p>{L_EXTENSION_ENABLE_IN_PROGRESS}</p>
</div>
<!-- ELSE -->
<div class="successbox">
<p>{L_ENABLE_SUCCESS}</p>
<p>{L_EXTENSION_ENABLE_SUCCESS}</p>
<br />
<p><a href="{U_RETURN}">{L_RETURN}</a></p>
<p><a href="{U_RETURN}">{L_RETURN_TO_EXTENSION_LIST}</a></p>
</div>
<!-- ENDIF -->

View File

@@ -1,34 +1,65 @@
<!-- INCLUDE overall_header.html -->
<a name="maincontent"></a>
<a id="maincontent"></a>
<h1>{L_EXTENSIONS_ADMIN}</h1>
<p>{L_EXTENSIONS_EXPLAIN}</p>
<table cellspacing="1">
<col class="row1" ><col class="row2" ><col class="row2" >
<fieldset class="quick">
<span class="small"><a href="{U_VERSIONCHECK_FORCE}">{L_VERSIONCHECK_FORCE_UPDATE_ALL}</a> &bull; <a href="javascript:phpbb.toggleDisplay('version_check_settings');">{L_SETTINGS}</a></span>
</fieldset>
<form id="version_check_settings" method="post" action="{U_ACTION}" style="display:none">
<fieldset>
<legend>{L_EXTENSIONS_VERSION_CHECK_SETTINGS}</legend>
<dl>
<dt><label for="force_unstable">{L_FORCE_UNSTABLE}{L_COLON}</label></dt>
<dd>
<label><input type="radio" id="force_unstable" name="force_unstable" class="radio" value="1"<!-- IF FORCE_UNSTABLE --> checked="checked"<!-- ENDIF --> /> {L_YES}</label>
<label><input type="radio" name="force_unstable" class="radio" value="0"<!-- IF not FORCE_UNSTABLE --> checked="checked"<!-- ENDIF --> /> {L_NO}</label>
</dd>
</dl>
<p class="submit-buttons">
<input class="button1" type="submit" name="update" value="{L_SUBMIT}" />&nbsp;
<input class="button2" type="reset" name="reset" value="{L_RESET}" />
<input type="hidden" name="action" value="set_config_version_check_force_unstable" />
{S_FORM_TOKEN}
</p>
</fieldset>
</form>
<table class="table1">
<col class="row1" ><col class="row1" ><col class="row2" ><col class="row2" >
<thead>
<tr>
<th>{L_EXTENSION_NAME}</th>
<th>{L_EXTENSION_OPTIONS}</th>
<th>{L_EXTENSION_ACTIONS}</th>
<th style="text-align: center; width: 20%;">{L_CURRENT_VERSION}</th>
<th style="text-align: center; width: 10%;">{L_EXTENSION_OPTIONS}</th>
<th style="text-align: center; width: 25%;">{L_EXTENSION_ACTIONS}</th>
</tr>
</thead>
<tbody>
<!-- IF .enabled -->
<tr>
<td class="row3" colspan="3">
<strong>{L_ENABLED} {L_EXTENSIONS}</strong>
</td>
<td class="row3" colspan="4"><strong>{L_EXTENSIONS_ENABLED}</strong></td>
</tr>
<!-- BEGIN enabled -->
<tr class="ext_enabled">
<td><strong>{enabled.META_DISPLAY_NAME}</strong></a></td>
<td><strong>{enabled.META_DISPLAY_NAME}</strong></td>
<td style="text-align: center;">
<!-- IF enabled.S_VERSIONCHECK -->
<strong <!-- IF enabled.S_UP_TO_DATE -->style="color: #228822;"<!-- ELSE -->style="color: #BC2A4D;"<!-- ENDIF -->>{enabled.META_VERSION}</strong>
<!-- ELSE -->
{enabled.META_VERSION}
<!-- ENDIF -->
</td>
<td style="text-align: center;"><a href="{enabled.U_DETAILS}">{L_DETAILS}</a></td>
<td style="text-align: center;">
<!-- BEGIN actions -->
<a href="{enabled.actions.U_ACTION}" alt="{enabled.actions.L_ACTION}">{enabled.actions.L_ACTION}</a>
<a href="{enabled.actions.U_ACTION}"<!-- IF enabled.actions.L_ACTION_EXPLAIN --> title="{enabled.actions.L_ACTION_EXPLAIN}"<!-- ENDIF -->>{enabled.actions.L_ACTION}</a>
<!-- IF not enabled.actions.S_LAST_ROW -->&nbsp;|&nbsp;<!-- ENDIF -->
<!-- END actions -->
</td>
@@ -38,17 +69,24 @@
<!-- IF .disabled -->
<tr>
<td class="row3" colspan="3"><strong>{L_DISABLED} {L_EXTENSIONS}</strong></td>
<td class="row3" colspan="4"><strong>{L_EXTENSIONS_DISABLED}</strong></td>
</tr>
<!-- BEGIN disabled -->
<tr class="ext_disabled">
<td><strong>{disabled.META_DISPLAY_NAME}</strong></a></td>
<td><strong>{disabled.META_DISPLAY_NAME}</strong></td>
<td style="text-align: center;">
<!-- IF disabled.S_VERSIONCHECK -->
<strong <!-- IF disabled.S_UP_TO_DATE -->style="color: #228822;"<!-- ELSE -->style="color: #BC2A4D;"<!-- ENDIF -->>{disabled.META_VERSION}</strong>
<!-- ELSE -->
{disabled.META_VERSION}
<!-- ENDIF -->
</td>
<td style="text-align: center;">
<!-- IF disabled.U_DETAILS --><a href="{disabled.U_DETAILS}">{L_DETAILS}</a><!-- ENDIF -->
</td>
<td style="text-align: center;">
<!-- BEGIN actions -->
<a href="{disabled.actions.U_ACTION}" alt="{disabled.actions.L_ACTION}">{disabled.actions.L_ACTION}</a>
<a href="{disabled.actions.U_ACTION}"<!-- IF disabled.actions.L_ACTION_EXPLAIN --> title="{disabled.actions.L_ACTION_EXPLAIN}"<!-- ENDIF -->>{disabled.actions.L_ACTION}</a>
<!-- IF not disabled.actions.S_LAST_ROW -->&nbsp;|&nbsp;<!-- ENDIF -->
<!-- END actions -->
</td>
@@ -58,4 +96,20 @@
</tbody>
</table>
<table class="table1">
<tr>
<th>{L_EXTENSION_UPDATE_HEADLINE}</th>
</tr>
<tr>
<td class="row3">{L_EXTENSION_UPDATE_EXPLAIN}</td>
</tr>
<tr>
<th>{L_EXTENSION_REMOVE_HEADLINE}</th>
</tr>
<tr>
<td class="row3">{L_EXTENSION_REMOVE_EXPLAIN}</td>
</tr>
</tbody>
</table>
<!-- INCLUDE overall_footer.html -->

View File

@@ -14,45 +14,45 @@
<!-- IF not S_ADD_ACTION and S_FORUM_ORIG_POST -->
if (value == {FORUM_POST})
{
dE('type_actions', -1);
phpbb.toggleDisplay('type_actions', -1);
}
else
{
dE('type_actions', 1);
phpbb.toggleDisplay('type_actions', 1);
}
<!-- ENDIF -->
<!-- IF not S_ADD_ACTION and S_FORUM_ORIG_CAT and S_HAS_SUBFORUMS -->
if (value == {FORUM_LINK})
{
dE('cat_to_link_actions', 1);
phpbb.toggleDisplay('cat_to_link_actions', 1);
}
else
{
dE('cat_to_link_actions', -1);
phpbb.toggleDisplay('cat_to_link_actions', -1);
}
<!-- ENDIF -->
if (value == {FORUM_POST})
{
dE('forum_post_options', 1);
dE('forum_link_options', -1);
dE('forum_rules_options', 1);
dE('forum_cat_options', -1);
phpbb.toggleDisplay('forum_post_options', 1);
phpbb.toggleDisplay('forum_link_options', -1);
phpbb.toggleDisplay('forum_rules_options', 1);
phpbb.toggleDisplay('forum_cat_options', -1);
}
else if (value == {FORUM_LINK})
{
dE('forum_post_options', -1);
dE('forum_link_options', 1);
dE('forum_rules_options', -1);
dE('forum_cat_options', -1);
phpbb.toggleDisplay('forum_post_options', -1);
phpbb.toggleDisplay('forum_link_options', 1);
phpbb.toggleDisplay('forum_rules_options', -1);
phpbb.toggleDisplay('forum_cat_options', -1);
}
else if (value == {FORUM_CAT})
{
dE('forum_post_options', -1);
dE('forum_link_options', -1);
dE('forum_rules_options', 1);
dE('forum_cat_options', 1);
phpbb.toggleDisplay('forum_post_options', -1);
phpbb.toggleDisplay('forum_link_options', -1);
phpbb.toggleDisplay('forum_rules_options', 1);
phpbb.toggleDisplay('forum_cat_options', 1);
}
}
@@ -64,30 +64,30 @@
{
<!-- IF not S_ADD_ACTION and S_FORUM_ORIG_POST -->
<!-- IF S_FORUM_POST -->
dE('type_actions', -1);
phpbb.toggleDisplay('type_actions', -1);
<!-- ENDIF -->
<!-- ENDIF -->
<!-- IF not S_ADD_ACTION and S_FORUM_ORIG_CAT and S_HAS_SUBFORUMS -->
<!-- IF S_FORUM_CAT -->
dE('cat_to_link_actions', -1);
phpbb.toggleDisplay('cat_to_link_actions', -1);
<!-- ENDIF -->
<!-- ENDIF -->
<!-- IF not S_FORUM_POST -->
dE('forum_post_options', -1);
phpbb.toggleDisplay('forum_post_options', -1);
<!-- ENDIF -->
<!-- IF not S_FORUM_CAT -->
dE('forum_cat_options', -1);
phpbb.toggleDisplay('forum_cat_options', -1);
<!-- ENDIF -->
<!-- IF not S_FORUM_LINK -->
dE('forum_link_options', -1);
phpbb.toggleDisplay('forum_link_options', -1);
<!-- ENDIF -->
<!-- IF S_FORUM_LINK -->
dE('forum_rules_options', -1);
phpbb.toggleDisplay('forum_rules_options', -1);
<!-- ENDIF -->
}
@@ -111,6 +111,7 @@
<fieldset>
<legend>{L_FORUM_SETTINGS}</legend>
<!-- EVENT acp_forums_main_settings_prepend -->
<dl>
<dt><label for="forum_type">{L_FORUM_TYPE}{L_COLON}</label></dt>
<dd><select id="forum_type" name="forum_type" onchange="display_options(this.options[this.selectedIndex].value);">{S_FORUM_TYPE_OPTIONS}</select></dd>
@@ -182,6 +183,7 @@
<dt><label for="forum_style">{L_FORUM_STYLE}{L_COLON}</label></dt>
<dd><select id="forum_style" name="forum_style"><option value="0">{L_DEFAULT_STYLE}</option>{S_STYLES_OPTIONS}</select></dd>
</dl>
<!-- EVENT acp_forums_main_settings_append -->
</fieldset>
<div id="forum_cat_options">
@@ -198,6 +200,7 @@
<div id="forum_post_options">
<fieldset>
<legend>{L_GENERAL_FORUM_SETTINGS}</legend>
<!-- EVENT acp_forums_normal_settings_prepend -->
<dl>
<dt><label for="forum_status">{L_FORUM_STATUS}{L_COLON}</label></dt>
<dd><select id="forum_status" name="forum_status">{S_STATUS_OPTIONS}</select></dd>
@@ -246,6 +249,7 @@
<fieldset>
<legend>{L_FORUM_PRUNE_SETTINGS}</legend>
<!-- EVENT acp_forums_prune_settings_prepend -->
<dl>
<dt><label for="enable_prune">{L_FORUM_AUTO_PRUNE}{L_COLON}</label><br /><span>{L_FORUM_AUTO_PRUNE_EXPLAIN}</span></dt>
<dd><label><input type="radio" class="radio" name="enable_prune" value="1"<!-- IF S_PRUNE_ENABLE --> id="enable_prune" checked="checked"<!-- ENDIF --> /> {L_YES}</label>
@@ -278,6 +282,20 @@
<dd><label><input type="radio" class="radio" name="prune_sticky" value="1"<!-- IF S_PRUNE_STICKY --> id="prune_sticky" checked="checked"<!-- ENDIF --> /> {L_YES}</label>
<label><input type="radio" class="radio" name="prune_sticky" value="0"<!-- IF not S_PRUNE_STICKY --> id="prune_sticky" checked="checked"<!-- ENDIF --> /> {L_NO}</label></dd>
</dl>
<dl>
<dt><label for="enable_shadow_prune">{L_FORUM_PRUNE_SHADOW}{L_COLON}</label><br /><span>{L_FORUM_PRUNE_SHADOW_EXPLAIN}</span></dt>
<dd><label><input type="radio" class="radio" name="enable_shadow_prune" value="1"<!-- IF S_PRUNE_SHADOW_ENABLE --> id="enable_shadow_prune" checked="checked"<!-- ENDIF --> /> {L_YES}</label>
<label><input type="radio" class="radio" name="enable_shadow_prune" value="0"<!-- IF not S_PRUNE_SHADOW_ENABLE --> id="enable_shadow_prune" checked="checked"<!-- ENDIF --> /> {L_NO}</label></dd>
</dl>
<dl>
<dt><label for="prune_shadow_freq">{L_AUTO_PRUNE_SHADOW_FREQ}{L_COLON}</label><br /><span>{L_AUTO_PRUNE_SHADOW_FREQ_EXPLAIN}</span></dt>
<dd><input type="number" id="prune_shadow_freq" name="prune_shadow_freq" value="{PRUNE_SHADOW_FREQ}" maxlength="4" size="4" min="0" max="9999" /> {L_DAYS}</dd>
</dl>
<dl>
<dt><label for="prune_shadow_days">{L_AUTO_PRUNE_SHADOW_DAYS}{L_COLON}</label><br /><span>{L_AUTO_PRUNE_SHADOW_DAYS_EXPLAIN}</span></dt>
<dd><input type="number" id="prune_shadow_days" name="prune_shadow_days" value="{PRUNE_SHADOW_DAYS}" maxlength="4" size="4" min="0" max="9999" /> {L_DAYS}</dd>
</dl>
<!-- EVENT acp_forums_prune_settings_append -->
</fieldset>
</div>
@@ -304,6 +322,7 @@
<div id="forum_rules_options">
<fieldset>
<legend>{L_FORUM_RULES}</legend>
<!-- EVENT acp_forums_rules_settings_prepend -->
<dl>
<dt><label for="forum_rules_link">{L_FORUM_RULES_LINK}{L_COLON}</label><br /><span>{L_FORUM_RULES_LINK_EXPLAIN}</span></dt>
<dd><input class="text medium" type="text" id="forum_rules_link" name="forum_rules_link" value="{FORUM_RULES_LINK}" maxlength="255" /></dd>
@@ -321,6 +340,7 @@
<label><input type="checkbox" class="radio" name="rules_parse_smilies"<!-- IF S_SMILIES_CHECKED --> checked="checked"<!-- ENDIF --> /> {L_PARSE_SMILIES}</label>
<label><input type="checkbox" class="radio" name="rules_parse_urls"<!-- IF S_URLS_CHECKED --> checked="checked"<!-- ENDIF --> /> {L_PARSE_URLS}</label></dd>
</dl>
<!-- EVENT acp_forums_rules_settings_append -->
</fieldset>
</div>
@@ -440,32 +460,23 @@
<p><strong>{NAVIGATION}<!-- IF S_NO_FORUMS --> [<a href="{U_EDIT}">{L_EDIT}</a> | <a href="{U_DELETE}">{L_DELETE}</a><!-- IF not S_LINK --> | <a href="{U_SYNC}">{L_RESYNC}</a><!-- ENDIF -->]<!-- ENDIF --></strong></p>
<!-- IF .forums -->
<table cellspacing="1">
<table class="table1 forums">
<col class="row1" /><col class="row1" /><col class="row2" />
<tbody>
<!-- BEGIN forums -->
<tr data-down="{forums.U_MOVE_DOWN}" data-up="{forums.U_MOVE_UP}">
<td style="width: 5%; text-align: center;">{forums.FOLDER_IMAGE}</td>
<td>
<tr>
<td class="folder">{forums.FOLDER_IMAGE}</td>
<td class="forum-desc">
<!-- IF forums.FORUM_IMAGE --><div style="float: {S_CONTENT_FLOW_BEGIN}; margin-right: 5px;">{forums.FORUM_IMAGE}</div><!-- ENDIF -->
<strong><!-- IF forums.S_FORUM_LINK -->{forums.FORUM_NAME}<!-- ELSE --><a href="{forums.U_FORUM}">{forums.FORUM_NAME}</a><!-- ENDIF --></strong>
<!-- IF forums.FORUM_DESCRIPTION --><br /><span>{forums.FORUM_DESCRIPTION}</span><!-- ENDIF -->
<!-- IF forums.S_FORUM_POST --><br /><br /><span>{L_TOPICS}{L_COLON} <strong>{forums.FORUM_TOPICS}</strong> / {L_POSTS}{L_COLON} <strong>{forums.FORUM_POSTS}</strong></span><!-- ENDIF -->
</td>
<td style="vertical-align: top; width: 100px; text-align: right; white-space: nowrap;">
<!-- IF forums.S_FIRST_ROW && not forums.S_LAST_ROW -->
<span class="up">{ICON_MOVE_UP_DISABLED}</span>
<span class="down"><a href="{forums.U_MOVE_DOWN}" data-ajax="row_down" data-overlay="false">{ICON_MOVE_DOWN}</a></span>
<!-- ELSEIF not forums.S_FIRST_ROW && not forums.S_LAST_ROW -->
<span class="up"><a href="{forums.U_MOVE_UP}" data-ajax="row_up" data-overlay="false">{ICON_MOVE_UP}</a></span>
<span class="down"><a href="{forums.U_MOVE_DOWN}" data-ajax="row_down" data-overlay="false">{ICON_MOVE_DOWN}</a></span>
<!-- ELSEIF forums.S_LAST_ROW && not forums.S_FIRST_ROW -->
<span class="up"><a href="{forums.U_MOVE_UP}" data-ajax="row_up" data-overlay="false">{ICON_MOVE_UP}</a></span>
<span class="down">{ICON_MOVE_DOWN_DISABLED}</span>
<!-- ELSE -->
<span class="up">{ICON_MOVE_UP_DISABLED}</span>
<span class="down">{ICON_MOVE_DOWN_DISABLED}</span>
<!-- ENDIF -->
<td class="actions">
<span class="up-disabled" style="display:none;">{ICON_MOVE_UP_DISABLED}</span>
<span class="up"><a href="{forums.U_MOVE_UP}" data-ajax="row_up">{ICON_MOVE_UP}</a></span>
<span class="down-disabled" style="display:none;">{ICON_MOVE_DOWN_DISABLED}</span>
<span class="down"><a href="{forums.U_MOVE_DOWN}" data-ajax="row_down">{ICON_MOVE_DOWN}</a></span>
<a href="{forums.U_EDIT}">{ICON_EDIT}</a>
<!-- IF not forums.S_FORUM_LINK -->
<a href="{forums.U_SYNC}" onclick="popup_progress_bar();">{ICON_SYNC}</a>
@@ -501,14 +512,6 @@
</fieldset>
</form>
<div class="hidden">
<a class="template-up-img" href="#">{ICON_MOVE_UP}</a>
<span class="template-up-img-disabled">{ICON_MOVE_UP_DISABLED}</span>
<a class="template-down-img" href="#">{ICON_MOVE_DOWN}</a>
<span class="template-down-img-disabled">{ICON_MOVE_DOWN_DISABLED}</span>
</div>
<!-- ENDIF -->
<!-- INCLUDE overall_footer.html -->

View File

@@ -56,6 +56,7 @@
<fieldset>
<legend>{L_GROUP_OPTIONS_SAVE}</legend>
<!-- EVENT acp_group_options_before -->
<!-- IF S_USER_FOUNDER -->
<dl>
<dt><label for="group_founder_manage">{L_GROUP_FOUNDER_MANAGE}{L_COLON}</label><br /><span>{L_GROUP_FOUNDER_MANAGE_EXPLAIN}</span></dt>
@@ -78,6 +79,7 @@
<dt><label for="group_receive_pm">{L_GROUP_RECEIVE_PM}{L_COLON}</label><br /><span>{L_GROUP_RECEIVE_PM_EXPLAIN}</span></dt>
<dd><input name="group_receive_pm" type="checkbox" value="1" class="radio" id="group_receive_pm"{GROUP_RECEIVE_PM} /></dd>
</dl>
<!-- EVENT acp_group_options_after -->
</fieldset>
<fieldset>
@@ -92,7 +94,12 @@
</dl>
<dl>
<dt><label for="group_colour">{L_GROUP_COLOR}{L_COLON}</label><br /><span>{L_GROUP_COLOR_EXPLAIN}</span></dt>
<dd><input name="group_colour" type="text" id="group_colour" value="{GROUP_COLOUR}" size="6" maxlength="6" /><!-- IF GROUP_COLOUR -->&nbsp;<span style="background-color: #{GROUP_COLOUR}">&nbsp; &nbsp;</span><!-- ENDIF -->&nbsp;&nbsp;<span>[ <a href="{U_SWATCH}" onclick="popup(this.href, 636, 150, '_swatch'); return false">{L_COLOUR_SWATCH}</a> ]</span></dd>
<dd>
<input name="group_colour" type="text" id="group_colour" value="{GROUP_COLOUR}" size="6" maxlength="6" />
<!-- IF GROUP_COLOUR -->&nbsp;<span style="background-color: #{GROUP_COLOUR}">&nbsp; &nbsp;</span><!-- ENDIF -->&nbsp;&nbsp;<span>
[ <a href="#" id="color_palette_toggle">{L_COLOUR_SWATCH}</a> ]</span>
<div id="color_palette_placeholder" style="display: none;" data-orientation="h" data-height="12" data-width="15" data-target="#group_colour"></div>
</dd>
</dl>
<dl>
<dt><label for="group_rank">{L_GROUP_RANK}{L_COLON}</label></dt>
@@ -109,10 +116,9 @@
</dl>
<dl>
<dt><label>{L_AVATAR_TYPE}{L_COLON}</label></dt>
<dd><select name="avatar_driver" id="avatar_driver">
<option value="">{L_NO_AVATAR_CATEGORY}</option>
<dd><select name="avatar_driver" id="avatar_driver" data-togglable-settings="true">
<!-- BEGIN avatar_drivers -->
<option value="{avatar_drivers.DRIVER}"<!-- IF avatar_drivers.SELECTED --> selected="selected"<!-- ENDIF -->>{avatar_drivers.L_TITLE}</option>
<option value="{avatar_drivers.DRIVER}"<!-- IF avatar_drivers.SELECTED --> selected="selected"<!-- ENDIF --> data-toggle-setting="#avatar_option_{avatar_drivers.DRIVER}">{avatar_drivers.L_TITLE}</option>
<!-- END avatar_drivers -->
</select></dd>
</dl>
@@ -134,8 +140,6 @@
</fieldset>
</form>
<!-- INCLUDEJS avatars.js -->
<!-- ELSEIF S_LIST -->
<a href="{U_BACK}" style="float: {S_CONTENT_FLOW_END};">&laquo; {L_BACK}</a>
@@ -150,7 +154,7 @@
<a href="{U_DEFAULT_ALL}">&raquo; {L_MAKE_DEFAULT_FOR_ALL}</a>
</fieldset>
<table cellspacing="1">
<table class="table1 zebra-table">
<thead>
<tr>
<th>{L_USERNAME}</th>
@@ -165,7 +169,7 @@
<td class="row3" colspan="5"><strong>{L_GROUP_LEAD}</strong></td>
</tr>
<!-- BEGIN leader -->
<!-- IF leader.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td><!-- IF leader.USERNAME_COLOUR --><a href="{leader.U_USER_EDIT}" style="color: #{leader.USERNAME_COLOUR};" class="username-coloured">{leader.USERNAME}</a><!-- ELSE --><a href="{leader.U_USER_EDIT}">{leader.USERNAME}</a><!-- ENDIF --></td>
<td style="text-align: center;"><!-- IF leader.S_GROUP_DEFAULT -->{L_YES}<!-- ELSE -->{L_NO}<!-- ENDIF --></td>
<td style="text-align: center;">{leader.JOINED}</td>
@@ -174,7 +178,7 @@
</tr>
<!-- BEGINELSE -->
<tr>
<td class="row1" colspan="5" style="text-align: center;">{L_GROUPS_NO_MODS}</td>
<td colspan="5" style="text-align: center;">{L_GROUPS_NO_MODS}</td>
</tr>
<!-- END leader -->
<tr>
@@ -186,7 +190,7 @@
<td class="row3" colspan="5"><strong>{L_GROUP_PENDING}</strong></td>
</tr>
<!-- ELSE -->
<!-- IF member.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td><!-- IF member.USERNAME_COLOUR --><a href="{member.U_USER_EDIT}" style="color: #{member.USERNAME_COLOUR};" class="username-coloured">{member.USERNAME}</a><!-- ELSE --><a href="{member.U_USER_EDIT}">{member.USERNAME}</a><!-- ENDIF --></td>
<td style="text-align: center;"><!-- IF member.S_GROUP_DEFAULT -->{L_YES}<!-- ELSE -->{L_NO}<!-- ENDIF --></td>
<td style="text-align: center;">{member.JOINED}</td>
@@ -196,7 +200,7 @@
<!-- ENDIF -->
<!-- BEGINELSE -->
<tr>
<td class="row1" colspan="5" style="text-align: center;">{L_GROUPS_NO_MEMBERS}</td>
<td colspan="5" style="text-align: center;">{L_GROUPS_NO_MEMBERS}</td>
</tr>
<!-- END member -->
</tbody>
@@ -261,7 +265,7 @@
<form id="acp_groups" method="post" action="{U_ACTION}">
<table cellspacing="1">
<table class="table1">
<col class="col1" /><col class="col1" /><col class="col2" /><col class="col2" /><col class="col2" />
<thead>
<tr>
@@ -295,7 +299,7 @@
<p>{L_SPECIAL_GROUPS_EXPLAIN}</p>
<table cellspacing="1">
<table class="table1">
<col class="col1" /><col class="col1" /><col class="col2" /><col class="col2" /><col class="col2" />
<thead>
<tr>

View File

@@ -27,7 +27,7 @@
<p>{L_LEGEND_EXPLAIN}</p>
<table cellspacing="1">
<table class="table1">
<col class="col1" /><col class="col2" /><col class="col2" />
<thead>
<tr>
@@ -38,23 +38,14 @@
</thead>
<tbody>
<!-- BEGIN legend -->
<tr data-down="{legend.U_MOVE_DOWN}" data-up="{legend.U_MOVE_UP}">
<tr>
<td><strong<!-- IF legend.GROUP_COLOUR --> style="color: {legend.GROUP_COLOUR}"<!-- ENDIF -->>{legend.GROUP_NAME}</strong></td>
<td style="text-align: center;">{legend.GROUP_TYPE}</td>
<td style="vertical-align: top; width: 100px; text-align: right; white-space: nowrap;">
<!-- IF legend.S_FIRST_ROW && not legend.S_LAST_ROW -->
<span class="up">{ICON_MOVE_UP_DISABLED}</span>
<span class="down"><a href="{legend.U_MOVE_DOWN}" data-ajax="row_down" data-overlay="false">{ICON_MOVE_DOWN}</a></span>
<!-- ELSEIF not legend.S_FIRST_ROW && not legend.S_LAST_ROW -->
<span class="up"><a href="{legend.U_MOVE_UP}" data-ajax="row_up" data-overlay="false">{ICON_MOVE_UP}</a></span>
<span class="down"><a href="{legend.U_MOVE_DOWN}" data-ajax="row_down" data-overlay="false">{ICON_MOVE_DOWN}</a></span>
<!-- ELSEIF legend.S_LAST_ROW && not legend.S_FIRST_ROW -->
<span class="up"><a href="{legend.U_MOVE_UP}" data-ajax="row_up" data-overlay="false">{ICON_MOVE_UP}</a></span>
<span class="down">{ICON_MOVE_DOWN_DISABLED}</span>
<!-- ELSE -->
<span class="up">{ICON_MOVE_UP_DISABLED}</span>
<span class="down">{ICON_MOVE_DOWN_DISABLED}</span>
<!-- ENDIF -->
<td class="actions">
<span class="up-disabled" style="display: none;">{ICON_MOVE_UP_DISABLED}</span>
<span class="up"><a href="{legend.U_MOVE_UP}" data-ajax="row_up">{ICON_MOVE_UP}</a></span>
<span class="down-disabled" style="display:none;">{ICON_MOVE_DOWN_DISABLED}</span>
<span class="down"><a href="{legend.U_MOVE_DOWN}" data-ajax="row_down">{ICON_MOVE_DOWN}</a></span>
<a href="{legend.U_DELETE}">{ICON_DELETE}</a>
</td>
</tr>
@@ -115,7 +106,7 @@
<!-- IF S_TEAMPAGE_CATEGORY and CURRENT_CATEGORY_NAME --><p><strong><a href="{U_ACTION}">{L_TEAMPAGE}</a> &raquo; {CURRENT_CATEGORY_NAME}</strong></p><!-- ENDIF -->
<table cellspacing="1">
<table class="table1">
<col class="col1" /><col class="col2" /><col class="col2" />
<thead>
<tr>
@@ -126,7 +117,7 @@
</thead>
<tbody>
<!-- BEGIN teampage -->
<tr data-down="{teampage.U_MOVE_DOWN}" data-up="{teampage.U_MOVE_UP}">
<tr>
<td>
<!-- IF teampage.U_CATEGORY -->
<a href="{teampage.U_CATEGORY}">{teampage.GROUP_NAME}</a>
@@ -136,20 +127,11 @@
</td>
<td style="text-align: center;"><!-- IF teampage.GROUP_TYPE -->{teampage.GROUP_TYPE}<!-- ELSE -->-<!-- ENDIF -->
</td></td>
<td style="vertical-align: top; width: 100px; text-align: right; white-space: nowrap;">
<!-- IF teampage.S_FIRST_ROW && not teampage.S_LAST_ROW -->
<span class="up">{ICON_MOVE_UP_DISABLED}</span>
<span class="down"><a href="{teampage.U_MOVE_DOWN}" data-ajax="row_down" data-overlay="false">{ICON_MOVE_DOWN}</a></span>
<!-- ELSEIF not teampage.S_FIRST_ROW && not teampage.S_LAST_ROW -->
<span class="up"><a href="{teampage.U_MOVE_UP}" data-ajax="row_up" data-overlay="false">{ICON_MOVE_UP}</a></span>
<span class="down"><a href="{teampage.U_MOVE_DOWN}" data-ajax="row_down" data-overlay="false">{ICON_MOVE_DOWN}</a></span>
<!-- ELSEIF teampage.S_LAST_ROW && not teampage.S_FIRST_ROW -->
<span class="up"><a href="{teampage.U_MOVE_UP}" data-ajax="row_up" data-overlay="false">{ICON_MOVE_UP}</a></span>
<span class="down">{ICON_MOVE_DOWN_DISABLED}</span>
<!-- ELSE -->
<span class="up">{ICON_MOVE_UP_DISABLED}</span>
<span class="down">{ICON_MOVE_DOWN_DISABLED}</span>
<!-- ENDIF -->
<td class="actions">
<span class="up-disabled" style="display: none;">{ICON_MOVE_UP_DISABLED}</span>
<span class="up"><a href="{teampage.U_MOVE_UP}" data-ajax="row_up">{ICON_MOVE_UP}</a></span>
<span class="down-disabled" style="display:none;">{ICON_MOVE_DOWN_DISABLED}</span>
<span class="down"><a href="{teampage.U_MOVE_DOWN}" data-ajax="row_down">{ICON_MOVE_DOWN}</a></span>
<a href="{teampage.U_DELETE}">{ICON_DELETE}</a>
</td>
</tr>
@@ -186,12 +168,4 @@
</fieldset>
</form>
<div class="hidden">
<a class="template-up-img" href="#">{ICON_MOVE_UP}</a>
<span class="template-up-img-disabled">{ICON_MOVE_UP_DISABLED}</span>
<a class="template-down-img" href="#">{ICON_MOVE_DOWN}</a>
<span class="template-down-img-disabled">{ICON_MOVE_DOWN_DISABLED}</span>
</div>
<!-- INCLUDE overall_footer.html -->

View File

@@ -7,7 +7,7 @@
<script type="text/javascript" defer="defer">
// <![CDATA[
<!-- IF S_ADD_CODE -->
var smiley = Array();
<!-- BEGIN smile -->
smiley['{smile.SMILEY_URL}'] = Array();
@@ -22,7 +22,7 @@
{
var use_element = smiley[newimage];
document.getElementById('add_image_src').src = '{PHPBB_ROOT_PATH}{IMG_PATH}/' + encodeURI(newimage);
document.getElementById('add_image_src').src = '{ROOT_PATH}{IMG_PATH}/' + encodeURI(newimage);
document.getElementById('add_code').value = use_element['code'];
document.getElementById('add_emotion').value = use_element['emotion'];
document.getElementById('add_width').value = use_element['width'];
@@ -37,10 +37,10 @@
}
}
}
<!-- ENDIF -->
function toggle_select(icon, display, select)
{
var disp = document.getElementById('order_disp_' + select);
@@ -74,7 +74,7 @@
<fieldset class="tabulated">
<legend>{L_TITLE}</legend>
<table cellspacing="1" id="smilies">
<table class="table1 zebra-table" id="smilies">
<thead>
<tr>
<th colspan="{COLSPAN}">{L_CONFIG}</th>
@@ -100,8 +100,8 @@
</thead>
<tbody>
<!-- BEGIN items -->
<!-- IF items.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td style="text-align: center;"><img src="{items.IMG_SRC}" alt="" title="" /><input type="hidden" name="image[{items.IMG}]" value="1" /></td>
<td style="vertical-align: top;">[{items.IMG}]</td>
<!-- IF S_SMILIES -->
@@ -121,7 +121,7 @@
<optgroup id="order_disp_{items.S_ROW_COUNT}" label="{L_DISPLAY_POSTING}" <!-- IF not items.POSTING_CHECKED -->disabled="disabled" class="disabled-options" <!-- ENDIF -->>{S_ORDER_LIST_DISPLAY}</optgroup>
<optgroup id="order_no_disp_{items.S_ROW_COUNT}" label="{L_DISPLAY_POSTING_NO}" <!-- IF items.POSTING_CHECKED -->disabled="disabled" class="disabled-options" <!-- ENDIF -->>{S_ORDER_LIST_UNDISPLAY}</optgroup>
</select></td>
<!-- ENDIF -->
<!-- ENDIF -->
<!-- IF S_ADD -->
<td><input type="checkbox" class="radio" name="add_img[{items.IMG}]" value="1" /></td>
<!-- ENDIF -->
@@ -147,6 +147,8 @@
</tr>
<!-- ENDIF -->
<!-- ELSE -->
</thead>
<tbody>
<tr class="row3">
<td colspan="{COLSPAN}">{L_NO_ICONS}</td>
</tr>
@@ -174,7 +176,7 @@
<fieldset>
<legend>{L_IMPORT}</legend>
<!-- IF not S_PAK_OPTIONS -->
<p>{L_NO_PAK_OPTIONS}</p>
@@ -218,7 +220,7 @@
<legend>{L_TITLE}</legend>
<table cellspacing="1">
<table class="table1 zebra-table">
<thead>
<tr>
<th>{L_TITLE}</th>
@@ -236,16 +238,18 @@
<td class="row3" colspan="{COLSPAN}" style="text-align: center;">{L_NOT_DISPLAYED}</td>
</tr>
<!-- ENDIF -->
<!-- IF items.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td style="width: 85%; text-align: center;"><img src="{items.IMG_SRC}" width="{items.WIDTH}" height="{items.HEIGHT}" alt="{items.ALT_TEXT}" title="{items.ALT_TEXT}" /></td>
<!-- IF S_SMILIES -->
<td style="text-align: center;">{items.CODE}</td>
<td style="text-align: center;">{items.EMOTION}</td>
<!-- ENDIF -->
<td style="text-align: right; white-space: nowrap;">
<!-- IF items.S_FIRST_ROW and not U_PREVIOUS_PAGE -->{ICON_MOVE_UP_DISABLED}<!-- ELSE --><a href="{items.U_MOVE_UP}">{ICON_MOVE_UP}</a><!-- ENDIF -->&nbsp;
<!-- IF items.S_LAST_ROW and not U_NEXT_PAGE -->{ICON_MOVE_DOWN_DISABLED}<!-- ELSE --><a href="{items.U_MOVE_DOWN}">{ICON_MOVE_DOWN}</a><!-- ENDIF -->
&nbsp;<a href="{items.U_EDIT}">{ICON_EDIT}</a> <a href="{items.U_DELETE}" data-ajax="row_delete">{ICON_DELETE}</a>
<td class="actions" style="text-align: right;">
<span class="up-disabled" style="display:none;">{ICON_MOVE_UP_DISABLED}</span>
<span class="up"><a href="{items.U_MOVE_UP}" data-ajax="row_up">{ICON_MOVE_UP}</a></span>
<span class="down-disabled" style="display:none;">{ICON_MOVE_DOWN_DISABLED}</span>
<span class="down"><a href="{items.U_MOVE_DOWN}" data-ajax="row_down">{ICON_MOVE_DOWN}</a></span>
<a href="{items.U_EDIT}">{ICON_EDIT}</a> <a href="{items.U_DELETE}" data-ajax="row_delete">{ICON_DELETE}</a>
</td>
</tr>
<!-- BEGINELSE -->
@@ -257,7 +261,7 @@
</table>
<div class="pagination">
<!-- IF .pagination -->
<!-- INCLUDE pagination.html -->
<!-- INCLUDE pagination.html -->
<!-- ENDIF -->
</div>
<p class="quick">

View File

@@ -2,21 +2,19 @@
<a id="maincontent"></a>
<h2>{L_INACTIVE_USERS}</h2>
<h1>{L_INACTIVE_USERS}</h1>
<p>{L_INACTIVE_USERS_EXPLAIN}</p>
<form id="inactive" method="post" action="{U_ACTION}">
<div class="clearfix"></div>
<!-- IF .pagination -->
<div class="pagination">
<!-- INCLUDE pagination.html -->
</div>
<!-- ENDIF -->
<table cellspacing="1">
<table class="table1 zebra-table">
<thead>
<tr>
<th>{L_USERNAME}</th>
@@ -29,8 +27,7 @@
</thead>
<tbody>
<!-- BEGIN inactive -->
<!-- IF inactive.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td style="vertical-align: top;">
{inactive.USERNAME_FULL}
<!-- IF inactive.POSTS --><br />{L_POSTS}{L_COLON} <strong>{inactive.POSTS}</strong> [<a href="{inactive.U_SEARCH_USER}">{L_SEARCH_USER_POSTS}</a>]<!-- ENDIF -->
@@ -53,7 +50,7 @@
</table>
<fieldset class="display-options">
{L_DISPLAY_LOG}{L_COLON} &nbsp;{S_LIMIT_DAYS}&nbsp;{L_SORT_BY}{L_COLON} {S_SORT_KEY} {S_SORT_DIR}<!-- IF .pagination -->&nbsp;Users per page{L_COLON} <input class="inputbox autowidth" type="number" name="users_per_page" id="users_per_page" size="3" value="{USERS_PER_PAGE}" /><!-- ENDIF -->
{L_DISPLAY_LOG}{L_COLON} &nbsp;{S_LIMIT_DAYS}&nbsp;{L_SORT_BY}{L_COLON} {S_SORT_KEY} {S_SORT_DIR}<!-- IF .pagination -->&nbsp;{L_USERS_PER_PAGE}{L_COLON} <input class="inputbox autowidth" type="number" name="users_per_page" id="users_per_page" size="3" value="{USERS_PER_PAGE}" /><!-- ENDIF -->
<input class="button2" type="submit" value="{L_GO}" name="sort" />
</fieldset>

View File

@@ -2,29 +2,7 @@
<a id="maincontent"></a>
<!-- IF S_SELECT_METHOD -->
<a href="{U_BACK}" style="float: {S_CONTENT_FLOW_END};">&laquo; {L_BACK}</a>
<h1>{L_SELECT_DOWNLOAD_FORMAT}</h1>
<form id="selectmethod" method="post" action="{U_ACTION}">
<fieldset>
<legend>{L_DOWNLOAD_AS}</legend>
<dl>
<dt><label for="use_method">{L_DOWNLOAD_AS}{L_COLON}</label></dt>
<dd>{RADIO_BUTTONS}</dd>
</dl>
<p class="quick">
<input type="submit" class="button2" value="{L_DOWNLOAD}" name="download" />
</p>
</fieldset>
</form>
<!-- ELSEIF S_DETAILS -->
<!-- IF S_DETAILS -->
<a href="{U_BACK}" style="float: {S_CONTENT_FLOW_END};">&laquo; {L_BACK}</a>
@@ -58,160 +36,39 @@
</fieldset>
</form>
<br /><br />
<!-- IF .missing_files -->
<h3 class="error">{L_MISSING_FILES}</h3>
<!-- IF S_MISSING_FILES -->
<div class="errorbox">
<h3>{L_MISSING_FILES}</h3>
<p>{MISSING_FILES}</p>
</div>
<br /><br />
<!-- ENDIF -->
<!-- IF S_MISSING_VARS -->
<h1>{L_MISSING_LANG_VARIABLES}</h1>
<p>{L_MISSING_VARS_EXPLAIN}</p>
<form id="missing" method="post" action="{U_MISSING_ACTION}">
<table cellspacing="1">
<thead>
<tr>
<th>{L_LANGUAGE_KEY}</th>
<th>{L_LANGUAGE_VARIABLE}</th>
</tr>
</thead>
<tbody>
<!-- BEGIN missing -->
<tr class="row4">
<td><strong>{missing.FILE}</strong></td>
<td style="text-align: right;"><input type="submit" name="missing_file[{missing.KEY}]" value="{L_SELECT}" class="button2" /></td>
</tr>
{missing.TPL}
<!-- END missing -->
</tbody>
</table>
<div>{S_FORM_TOKEN}</div>
</form>
<br /><br />
<!-- ENDIF -->
<a id="entries"></a>
<h1>{L_LANGUAGE_ENTRIES}</h1>
<p>{L_LANGUAGE_ENTRIES_EXPLAIN}</p>
<form id="lang_entries" method="post" action="{U_ENTRY_ACTION}">
<!-- IF S_FROM_STORE -->
<fieldset class="quick" style="float: {S_CONTENT_FLOW_BEGIN};">
<input type="submit" name="remove_store" value="{L_REMOVE_FROM_STORAGE_FOLDER}" class="button2" />
<fieldset>
<legend>{L_MISSING_LANG_FILES}</legend>
<!-- BEGIN missing_files -->
&raquo; {missing_files.FILE_NAME}<br />
<!-- END missing_files -->
</fieldset>
<!-- ENDIF -->
<fieldset class="quick" style="float: {S_CONTENT_FLOW_END};">
<select name="language_file">{S_LANG_OPTIONS}</select>&nbsp;<input type="submit" class="button2" name="change" value="{L_SELECT}" />
</fieldset>
<!-- IF .missing_varfile -->
<h3 class="error">{L_MISSING_VARS_EXPLAIN}</h3>
<p>&nbsp;<br />&nbsp;</p>
<!--[if lt IE 8]>
<style type="text/css">
/* <![CDATA[ */
input.langvalue, textarea.langvalue {
width: 450px;
}
/* ]]> */
</style>
<![endif]-->
<table cellspacing="1">
<thead>
<!-- IF S_EMAIL_FILE -->
<tr>
<th colspan="2">{L_FILE_CONTENTS}</th>
</tr>
<!-- ELSE -->
<tr>
<th>{L_LANGUAGE_KEY}</th>
<th>{L_LANGUAGE_VARIABLE}</th>
</tr>
<fieldset>
<legend>{L_MISSING_LANG_VARIABLES}</legend>
<!-- BEGIN missing_varfile -->
<dl>
<dt><label>{missing_varfile.FILE_NAME}</label></dt>
<!-- BEGIN variable -->
<dd>{missing_varfile.variable.VAR_NAME}</dd>
<!-- END variable -->
</dl>
<!-- END missing_varfile -->
</fieldset>
<!-- ENDIF -->
<tr>
<td rowspan="2" class="row3"><strong>{PRINT_MESSAGE}<!-- IF S_FROM_STORE --><br /><span style="color: red;">{L_FILE_FROM_STORAGE}</span><!-- ENDIF --></strong></td>
<td class="row3" style="text-align: right;"><input type="submit" name="download_file" class="button2" value="{L_SUBMIT_AND_DOWNLOAD}" />&nbsp;&nbsp;<input type="submit" name="submit_file" class="button2" value="{L_SUBMIT}" /></td>
</tr>
<tr>
<td class="row3" style="text-align: right;">
<!-- IF ALLOW_UPLOAD -->&nbsp;&nbsp;{L_UPLOAD_METHOD}{L_COLON}&nbsp;<!-- BEGIN buttons--><input type="radio" class="radio"<!-- IF buttons.S_FIRST_ROW --> id="method" checked="checked"<!-- ENDIF --> value="{buttons.VALUE}" name="method" />&nbsp;{buttons.VALUE}&nbsp;<!-- END buttons --><input type="submit" name="upload_file" class="button2" value="{L_SUBMIT_AND_UPLOAD}" /><!-- ENDIF --></td>
</tr>
</thead>
<tbody>
<!-- IF S_EMAIL_FILE -->
<tr>
<td class="row2" colspan="2" style="text-align: center;"><textarea name="entry" id="entry" cols="80" rows="20">{LANG}</textarea></td>
</tr>
<!-- ELSE -->
{TPL}
<!-- ENDIF -->
<tr>
<td class="row3" colspan="3" style="text-align: right;">{S_FORM_TOKEN}<input type="submit" name="download_file" class="button2" value="{L_SUBMIT_AND_DOWNLOAD}" />&nbsp;&nbsp;<input type="submit" name="submit_file" class="button2" value="{L_SUBMIT}" /></td>
</tr>
</tbody>
</table>
</form>
<!-- ELSEIF S_UPLOAD -->
<a href="{U_BACK}" style="float: {S_CONTENT_FLOW_END};">&laquo; {L_BACK}</a>
<h1>{L_UPLOAD_SETTINGS}</h1>
<form id="upload" method="post" action="{U_ACTION}">
<!-- IF S_CONNECTION_SUCCESS -->
<div class="successbox">
<p>{L_CONNECTION_SUCCESS}</p>
</div>
<!-- ELSEIF S_CONNECTION_FAILED -->
<div class="errorbox">
<p>{L_CONNECTION_FAILED}</p>
</div>
<!-- ENDIF -->
<fieldset>
<legend>{L_UPLOAD_SETTINGS}</legend>
<dl>
<dt><label>{L_UPLOAD_METHOD}{L_COLON}</label></dt>
<dd><strong>{NAME}</strong></dd>
</dl>
<!-- BEGIN data -->
<dl>
<dt><label for="{data.DATA}">{data.NAME}{L_COLON}</label><br /><span>{data.EXPLAIN}</span></dt>
<dd><input type="<!-- IF data.DATA == 'password' -->password<!-- ELSE -->text<!-- ENDIF -->" id="{data.DATA}" name="{data.DATA}" value="{data.DEFAULT}" /></dd>
</dl>
<!-- END data -->
</fieldset>
<fieldset class="quick">
{HIDDEN}
{S_FORM_TOKEN}
<input class="button1" type="submit" name="update" value="{L_SUBMIT}" />
<input class="button1" type="submit" name="test_connection" value="{L_TEST_CONNECTION}" />
</fieldset>
</form>
<!-- ELSE -->
<h1>{L_ACP_LANGUAGE_PACKS}</h1>
<p>{L_ACP_LANGUAGE_PACKS_EXPLAIN}</p>
<table cellspacing="1">
<table class="table1 zebra-table">
<thead>
<tr>
<th>{L_LANGUAGE_PACK_NAME}</th>
@@ -226,12 +83,12 @@
<td class="row3" colspan="5"><strong>{L_INSTALLED_LANGUAGE_PACKS}</strong></td>
</tr>
<!-- BEGIN lang -->
<!-- IF lang.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td><a href="{lang.U_DETAILS}">{lang.ENGLISH_NAME}</a> {lang.TAG}</td>
<td>{lang.LOCAL_NAME}</td>
<td style="text-align: center;"><strong>{lang.ISO}</strong></td>
<td style="text-align: center;">{lang.USED_BY}</td>
<td style="text-align: center;">&nbsp;<a href="{lang.U_DOWNLOAD}">{L_DOWNLOAD}</a>&nbsp;|&nbsp;<a href="{lang.U_DELETE}">{L_DELETE}</a></td>
<td style="text-align: center;"><a href="{lang.U_DELETE}">{L_DELETE}</a></td>
</tr>
<!-- END lang -->
<!-- IF .notinst -->
@@ -240,7 +97,7 @@
</tr>
<!-- ENDIF -->
<!-- BEGIN notinst -->
<!-- IF notinst.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td>{notinst.NAME}</td>
<td>{notinst.LOCAL_NAME}</td>
<td style="text-align: center;"><strong>{notinst.ISO}</strong></td>

View File

@@ -8,35 +8,32 @@
<form id="list" method="post" action="{U_ACTION}">
<fieldset class="display-options" style="float: left">
<fieldset class="display-options search-box">
{L_SEARCH_KEYWORDS}{L_COLON} <input type="text" name="keywords" value="{S_KEYWORDS}" />&nbsp;<input type="submit" class="button2" name="filter" value="{L_SEARCH}" />
</fieldset>
<!-- IF .pagination -->
<div class="pagination" style="float: right; margin: 15px 0 2px 0">
<div class="pagination top-pagination">
<!-- INCLUDE pagination.html -->
</div>
<!-- ENDIF -->
<div class="clearfix">&nbsp;</div>
<div><br style="clear: both;" /></div>
<!-- IF .log -->
<table cellspacing="1">
<table class="table1 zebra-table fixed-width-table">
<thead>
<tr>
<th>{L_USERNAME}</th>
<th>{L_IP}</th>
<th>{L_TIME}</th>
<th style="width: 15%;">{L_USERNAME}</th>
<th style="width: 15%;">{L_IP}</th>
<th style="width: 20%;">{L_TIME}</th>
<th>{L_ACTION}</th>
<!-- IF S_CLEARLOGS -->
<th>{L_MARK}</th>
<th style="width: 50px;">{L_MARK}</th>
<!-- ENDIF -->
</tr>
</thead>
<tbody>
<!-- BEGIN log -->
<!-- IF log.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td>
{log.USERNAME}
<!-- IF log.REPORTEE_USERNAME -->

View File

@@ -17,6 +17,7 @@
<!-- IF S_VERSIONCHECK_FAIL -->
<div class="errorbox notice">
<p>{L_VERSIONCHECK_FAIL}</p>
<p>{VERSIONCHECK_FAIL_REASON}</p>
<p><a href="{U_VERSIONCHECK_FORCE}">{L_VERSIONCHECK_FORCE_UPDATE}</a> &middot; <a href="{U_VERSIONCHECK}">{L_MORE_INFORMATION}</a></p>
</div>
<!-- ELSEIF not S_VERSION_UP_TO_DATE -->
@@ -26,6 +27,12 @@
</div>
<!-- ENDIF -->
<!-- IF S_SEARCH_INDEX_MISSING -->
<div class="errorbox">
<h3>{L_WARNING}</h3>
<p>{L_NO_SEARCH_INDEX}</p>
</div>
<!-- ENDIF -->
<!-- IF S_REMOVE_INSTALL -->
<div class="errorbox">
@@ -78,7 +85,7 @@
<!-- EVENT acp_main_notice_after -->
<table cellspacing="1">
<table class="table1 two-columns no-header" data-no-responsive-header="true">
<caption>{L_FORUM_STATS}</caption>
<col class="col1" /><col class="col2" /><col class="col1" /><col class="col2" />
<thead>
@@ -168,21 +175,21 @@
</dl>
</form>
<form id="action_stats_form" method="post" action="{U_ACTION}" data-ajax="true">
<form id="action_stats_form" method="post" action="{U_ACTION}">
<dl>
<dt><label for="action_stats">{L_RESYNC_STATS}</label><br /><span>{L_RESYNC_STATS_EXPLAIN}</span></dt>
<dd><input type="hidden" name="action" value="stats" /><input class="button2" type="submit" id="action_stats" name="action_stats" value="{L_RUN}" /></dd>
</dl>
</form>
<form id="action_user_form" method="post" action="{U_ACTION}" data-ajax="true">
<form id="action_user_form" method="post" action="{U_ACTION}">
<dl>
<dt><label for="action_user">{L_RESYNC_POSTCOUNTS}</label><br /><span>{L_RESYNC_POSTCOUNTS_EXPLAIN}</span></dt>
<dd><input type="hidden" name="action" value="user" /><input class="button2" type="submit" id="action_user" name="action_user" value="{L_RUN}" /></dd>
</dl>
</form>
<form id="action_db_track_form" method="post" action="{U_ACTION}" data-ajax="true">
<form id="action_db_track_form" method="post" action="{U_ACTION}">
<dl>
<dt><label for="action_db_track">{L_RESYNC_POST_MARKING}</label><br /><span>{L_RESYNC_POST_MARKING_EXPLAIN}</span></dt>
<dd><input type="hidden" name="action" value="db_track" /><input class="button2" type="submit" id="action_db_track" name="action_db_track" value="{L_RUN}" /></dd>
@@ -216,7 +223,7 @@
<div style="text-align: right;"><a href="{U_ADMIN_LOG}">&raquo; {L_VIEW_ADMIN_LOG}</a></div>
<table cellspacing="1">
<table class="table1 zebra-table">
<thead>
<tr>
<th>{L_USERNAME}</th>
@@ -227,8 +234,7 @@
</thead>
<tbody>
<!-- BEGIN log -->
<!-- IF log.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td>{log.USERNAME}</td>
<td style="text-align: center;">{log.IP}</td>
<td style="text-align: center;">{log.DATE}</td>
@@ -237,9 +243,6 @@
<!-- END log -->
</tbody>
</table>
<br />
<!-- ENDIF -->
<!-- IF S_INACTIVE_USERS -->
@@ -249,7 +252,7 @@
<div style="text-align: right;"><a href="{U_INACTIVE_USERS}">&raquo; {L_VIEW_INACTIVE_USERS}</a></div>
<table cellspacing="1">
<table class="table1 zebra-table">
<thead>
<tr>
<th>{L_USERNAME}</th>
@@ -261,8 +264,7 @@
</thead>
<tbody>
<!-- BEGIN inactive -->
<!-- IF inactive.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td style="vertical-align: top;">
{inactive.USERNAME_FULL}
<!-- IF inactive.POSTS --><br />{L_POSTS}{L_COLON} <strong>{inactive.POSTS}</strong> [<a href="{inactive.U_SEARCH_USER}">{L_SEARCH_USER_POSTS}</a>]<!-- ENDIF -->
@@ -282,7 +284,6 @@
<!-- END inactive -->
</tbody>
</table>
<!-- ENDIF -->
<!-- ENDIF -->

View File

@@ -10,11 +10,11 @@
{
if (value == 'category')
{
dE('modoptions', -1);
phpbb.toggleDisplay('modoptions', -1);
}
else
{
dE('modoptions', 1);
phpbb.toggleDisplay('modoptions', 1);
}
}
@@ -132,7 +132,7 @@
</div>
<!-- ENDIF -->
<table cellspacing="1">
<table class="table1">
<tbody>
<tr>
<td class="row3">{NAVIGATION}<!-- IF S_NO_MODULES --> [<a href="{U_EDIT}">{L_EDIT}</a> | <a href="{U_DELETE}">{L_DELETE}</a> | <!-- IF MODULE_ENABLED --><a href="{U_DISABLE}">{L_DISABLE}</a><!-- ELSE --><a href="{U_ENABLE}">{L_ENABLE}</a><!-- ENDIF -->]<!-- ENDIF --></td>
@@ -141,7 +141,7 @@
</table>
<!-- IF .modules -->
<table cellspacing="1">
<table class="table1">
<col class="row1" /><col class="row1" /><col class="row2" /><col class="row2" />
<tbody>
<!-- BEGIN modules -->
@@ -149,20 +149,11 @@
<td style="width: 5%; text-align: center;">{modules.MODULE_IMAGE}</td>
<td><a href="{modules.U_MODULE}">{modules.MODULE_TITLE}</a><!-- IF not modules.MODULE_DISPLAYED --> <span class="small">[{L_HIDDEN_MODULE}]</span><!-- ENDIF --></td>
<td style="width: 15%; white-space: nowrap; text-align: center; vertical-align: middle;">&nbsp;<!-- IF modules.MODULE_ENABLED --><a href="{modules.U_DISABLE}">{L_DISABLE}</a><!-- ELSE --><a href="{modules.U_ENABLE}">{L_ENABLE}</a><!-- ENDIF -->&nbsp;</td>
<td style="width:90px; white-space: nowrap; text-align: right; vertical-align: middle;">
<!-- IF modules.S_FIRST_ROW && not modules.S_LAST_ROW -->
{ICON_MOVE_UP_DISABLED}
<a href="{modules.U_MOVE_DOWN}">{ICON_MOVE_DOWN}</a>
<!-- ELSEIF not modules.S_FIRST_ROW && not modules.S_LAST_ROW-->
<a href="{modules.U_MOVE_UP}">{ICON_MOVE_UP}</a>
<a href="{modules.U_MOVE_DOWN}">{ICON_MOVE_DOWN}</a>
<!-- ELSEIF modules.S_LAST_ROW && not modules.S_FIRST_ROW -->
<a href="{modules.U_MOVE_UP}">{ICON_MOVE_UP}</a>
{ICON_MOVE_DOWN_DISABLED}
<!-- ELSE -->
{ICON_MOVE_UP_DISABLED}
{ICON_MOVE_DOWN_DISABLED}
<!-- ENDIF -->
<td class="actions">
<span class="up-disabled" style="display:none;">{ICON_MOVE_UP_DISABLED}</span>
<span class="up"><a href="{modules.U_MOVE_UP}" data-ajax="row_up">{ICON_MOVE_UP}</a></span>
<span class="down-disabled" style="display:none;">{ICON_MOVE_DOWN_DISABLED}</span>
<span class="down"><a href="{modules.U_MOVE_DOWN}" data-ajax="row_down">{ICON_MOVE_DOWN}</a></span>
<a href="{modules.U_EDIT}">{ICON_EDIT}</a>
<a href="{modules.U_DELETE}" data-ajax="row_delete">{ICON_DELETE}</a>
</td>

View File

@@ -90,9 +90,8 @@
</div>
<!-- BEGIN auth -->
<div class="permissions-panel" id="options00{auth.S_ROW_COUNT}"<!-- IF auth.S_FIRST_ROW --><!-- ELSE --> style="display: none;"<!-- ENDIF -->>
<span class="corners-top"><span></span></span>
<div class="tablewrap">
<table id="table00{auth.S_ROW_COUNT}" cellspacing="1">
<table id="table00{auth.S_ROW_COUNT}" class="table1 not-responsive">
<colgroup>
<col class="permissions-name" />
<col class="permissions-yes" />
@@ -120,7 +119,6 @@
</tbody>
</table>
</div>
<span class="corners-bottom"><span></span></span>
</div>
<!-- END auth -->
</div>
@@ -144,7 +142,7 @@
<form id="acp_roles" method="post" action="{U_ACTION}">
<table cellspacing="1">
<table class="table1">
<col class="col2" /><col class="col2" /><col class="col1" /><col class="col2" /><col class="col2" />
<thead>
<tr>
@@ -159,20 +157,11 @@
<!-- IF roles.ROLE_DESCRIPTION --><br /><span>{roles.ROLE_DESCRIPTION}</span><!-- ENDIF -->
</td>
<td style="width: 30%; text-align: center; vertical-align: top; white-space: nowrap;"><!-- IF roles.U_DISPLAY_ITEMS --><a href="{roles.U_DISPLAY_ITEMS}">{L_VIEW_ASSIGNED_ITEMS}</a><!-- ELSE -->{L_VIEW_ASSIGNED_ITEMS}<!-- ENDIF --></td>
<td style="width: 80px; text-align: right; vertical-align: top; white-space: nowrap;">
<!-- IF roles.S_FIRST_ROW && not roles.S_LAST_ROW -->
{ICON_MOVE_UP_DISABLED}
<a href="{roles.U_MOVE_DOWN}">{ICON_MOVE_DOWN}</a>
<!-- ELSEIF not roles.S_FIRST_ROW && not roles.S_LAST_ROW-->
<a href="{roles.U_MOVE_UP}">{ICON_MOVE_UP}</a>
<a href="{roles.U_MOVE_DOWN}">{ICON_MOVE_DOWN}</a>
<!-- ELSEIF roles.S_LAST_ROW && not roles.S_FIRST_ROW -->
<a href="{roles.U_MOVE_UP}">{ICON_MOVE_UP}</a>
{ICON_MOVE_DOWN_DISABLED}
<!-- ELSE -->
{ICON_MOVE_UP_DISABLED}
{ICON_MOVE_DOWN_DISABLED}
<!-- ENDIF -->
<td class="actions">
<span class="up-disabled" style="display:none;">{ICON_MOVE_UP_DISABLED}</span>
<span class="up"><a href="{roles.U_MOVE_UP}" data-ajax="row_up">{ICON_MOVE_UP}</a></span>
<span class="down-disabled" style="display:none;">{ICON_MOVE_DOWN_DISABLED}</span>
<span class="down"><a href="{roles.U_MOVE_DOWN}" data-ajax="row_down">{ICON_MOVE_DOWN}</a></span>
<a href="{roles.U_EDIT}" title="{L_EDIT_ROLE}">{ICON_EDIT}</a>
<a href="{roles.U_REMOVE}" title="{L_REMOVE_ROLE}" data-ajax="row_delete">{ICON_DELETE}</a>
</td>

View File

@@ -110,7 +110,7 @@
<!-- ELSEIF S_SELECT_USERGROUP -->
<div style="float: {S_CONTENT_FLOW_BEGIN}; width: 48%;">
<div class="column1">
<!-- IF S_CAN_SELECT_USER -->
@@ -155,7 +155,7 @@
</div>
<div style="float: {S_CONTENT_FLOW_END}; width: 48%">
<div class="column2">
<!-- IF S_CAN_SELECT_GROUP -->
@@ -200,7 +200,7 @@
<!-- ELSEIF S_SELECT_USERGROUP_VIEW -->
<div style="float: {S_CONTENT_FLOW_BEGIN}; width: 48%;">
<div class="column1">
<h1>{L_USERS}</h1>
@@ -241,7 +241,7 @@
</div>
<div style="float: {S_CONTENT_FLOW_END}; width: 48%">
<div class="column2">
<h1>{L_USERGROUPS}</h1>
@@ -324,7 +324,7 @@
</form>
<!-- ENDIF -->
<br /><br />
<br class="responsive-hide" /><br class="responsive-hide" />
<!-- include tooltip file -->
<script type="text/javascript" src="style/tooltip.js"></script>
@@ -340,7 +340,7 @@
<!-- INCLUDE permission_mask.html -->
<br /><br />
<br class="responsive-hide" /><br class="responsive-hide" />
<fieldset class="quick" style="float: {S_CONTENT_FLOW_END};">
<input class="button1" type="submit" name="action[apply_all_permissions]" value="{L_APPLY_ALL_PERMISSIONS}" />
@@ -348,7 +348,7 @@
{S_FORM_TOKEN}
</fieldset>
<br /><br />
<br class="responsive-hide" /><br class="responsive-hide" />
</form>

View File

@@ -0,0 +1,70 @@
<script type="text/javascript">
// <![CDATA[
// Define the bbCode tags
var bbcode = new Array();
var bbtags = new Array('[b]','[/b]','[i]','[/i]','[u]','[/u]','[quote]','[/quote]','[code]','[/code]','[list]','[/list]','[list=]','[/list]','[img]','[/img]','[url]','[/url]','[flash=]', '[/flash]','[size=]','[/size]'<!-- BEGIN custom_tags -->, {custom_tags.BBCODE_NAME}<!-- END custom_tags -->);
// Helpline messages
var help_line = {
b: '{LA_BBCODE_B_HELP}',
i: '{LA_BBCODE_I_HELP}',
u: '{LA_BBCODE_U_HELP}',
q: '{LA_BBCODE_Q_HELP}',
c: '{LA_BBCODE_C_HELP}',
l: '{LA_BBCODE_L_HELP}',
o: '{LA_BBCODE_O_HELP}',
p: '{LA_BBCODE_P_HELP}',
w: '{LA_BBCODE_W_HELP}',
a: '{LA_BBCODE_A_HELP}',
s: '{LA_BBCODE_S_HELP}',
f: '{LA_BBCODE_F_HELP}',
y: '{LA_BBCODE_Y_HELP}',
d: '{LA_BBCODE_D_HELP}'
<!-- BEGIN custom_tags -->
,cb_{custom_tags.BBCODE_ID}{L_COLON} '{custom_tags.A_BBCODE_HELPLINE}'
<!-- END custom_tags -->
}
// ]]>
</script>
<!-- INCLUDEJS {T_ASSETS_PATH}/javascript/editor.js -->
<!-- EVENT acp_posting_buttons_before -->
<div id="format-buttons">
<input type="button" class="button2" accesskey="b" name="addbbcode0" value=" B " style="font-weight:bold; width: 30px" onclick="bbstyle(0)" title="{L_BBCODE_B_HELP}" />
<input type="button" class="button2" accesskey="i" name="addbbcode2" value=" i " style="font-style:italic; width: 30px" onclick="bbstyle(2)" title="{L_BBCODE_I_HELP}" />
<input type="button" class="button2" accesskey="u" name="addbbcode4" value=" u " style="text-decoration: underline; width: 30px" onclick="bbstyle(4)" title="{L_BBCODE_U_HELP}" />
<!-- IF S_BBCODE_QUOTE -->
<input type="button" class="button2" accesskey="q" name="addbbcode6" value="Quote" style="width: 50px" onclick="bbstyle(6)" title="{L_BBCODE_Q_HELP}" />
<!-- ENDIF -->
<input type="button" class="button2" accesskey="c" name="addbbcode8" value="Code" style="width: 40px" onclick="bbstyle(8)" title="{L_BBCODE_C_HELP}" />
<input type="button" class="button2" accesskey="l" name="addbbcode10" value="List" style="width: 40px" onclick="bbstyle(10)" title="{L_BBCODE_L_HELP}" />
<input type="button" class="button2" accesskey="o" name="addbbcode12" value="List=" style="width: 40px" onclick="bbstyle(12)" title="{L_BBCODE_O_HELP}" />
<input type="button" class="button2" accesskey="y" name="addlistitem" value="[*]" style="width: 40px" onclick="bbstyle(-1)" title="{L_BBCODE_LISTITEM_HELP}" />
<!-- IF S_BBCODE_IMG -->
<input type="button" class="button2" accesskey="p" name="addbbcode14" value="Img" style="width: 40px" onclick="bbstyle(14)" title="{L_BBCODE_P_HELP}" />
<!-- ENDIF -->
<!-- IF S_LINKS_ALLOWED -->
<input type="button" class="button2" accesskey="w" name="addbbcode16" value="URL" style="text-decoration: underline; width: 40px" onclick="bbstyle(16)" title="{L_BBCODE_W_HELP}" />
<!-- ENDIF -->
<!-- IF S_BBCODE_FLASH -->
<input type="button" class="button2" accesskey="d" name="addbbcode18" value="Flash" onclick="bbstyle(18)" title="{L_BBCODE_D_HELP}" />
<!-- ENDIF -->
<select name="addbbcode20" onchange="bbfontstyle('[size=' + this.form.addbbcode20.options[this.form.addbbcode20.selectedIndex].value + ']', '[/size]');this.form.addbbcode20.selectedIndex = 2;" title="{L_BBCODE_F_HELP}">
<option value="50">{L_FONT_TINY}</option>
<option value="85">{L_FONT_SMALL}</option>
<option value="100" selected="selected">{L_FONT_NORMAL}</option>
<!-- IF not MAX_FONT_SIZE or MAX_FONT_SIZE >= 150 -->
<option value="150">{L_FONT_LARGE}</option>
<!-- IF not MAX_FONT_SIZE or MAX_FONT_SIZE >= 200 -->
<option value="200">{L_FONT_HUGE}</option>
<!-- ENDIF -->
<!-- ENDIF -->
</select>
<!-- BEGIN custom_tags -->
<input type="button" class="button2" name="addbbcode{custom_tags.BBCODE_ID}" value="{custom_tags.BBCODE_TAG}" onclick="bbstyle({custom_tags.BBCODE_ID})" title="{custom_tags.BBCODE_HELPLINE}" />
<!-- END custom_tags -->
</div>
<!-- EVENT acp_posting_buttons_after -->

View File

@@ -63,6 +63,10 @@
<dt><label for="field_show_on_vt">{L_DISPLAY_ON_VT}{L_COLON}</label><br /><span>{L_DISPLAY_ON_VT_EXPLAIN}</span></dt>
<dd><input type="checkbox" class="radio" id="field_show_on_vt" name="field_show_on_vt" value="1"<!-- IF S_SHOW_ON_VT --> checked="checked"<!-- ENDIF --> /></dd>
</dl>
<dl>
<dt><label for="field_show_on_ml">{L_DISPLAY_ON_MEMBERLIST}{L_COLON}</label><br /><span>{L_DISPLAY_ON_MEMBERLIST_EXPLAIN}</span></dt>
<dd><input type="checkbox" class="radio" id="field_show_on_ml" name="field_show_on_ml" value="1"<!-- IF S_SHOW_ON_MEMBERLIST --> checked="checked"<!-- ENDIF --> /></dd>
</dl>
<dl>
<dt><label for="field_required">{L_REQUIRED_FIELD}{L_COLON}</label><br /><span>{L_REQUIRED_FIELD_EXPLAIN}</span></dt>
<dd><input type="checkbox" class="radio" id="field_required" name="field_required" value="1"<!-- IF S_FIELD_REQUIRED --> checked="checked"<!-- ENDIF --> /></dd>
@@ -75,6 +79,12 @@
<dt><label for="field_hide">{L_HIDE_PROFILE_FIELD}{L_COLON}</label><br /><span>{L_HIDE_PROFILE_FIELD_EXPLAIN}</span></dt>
<dd><input type="checkbox" class="radio" id="field_hide" name="field_hide" value="1"<!-- IF S_FIELD_HIDE --> checked="checked"<!-- ENDIF --> /></dd>
</dl>
<dl>
<dt><label for="field_is_contact">{L_FIELD_IS_CONTACT}{L_COLON}</label><br /><span>{L_FIELD_IS_CONTACT_EXPLAIN}</span></dt>
<dd><input type="checkbox" class="radio" id="field_is_contact" name="field_is_contact" value="1"<!-- IF S_FIELD_CONTACT --> checked="checked"<!-- ENDIF --> /></dd>
<dd><input class="text medium" type="text" name="field_contact_desc" id="field_contact_desc" value="{FIELD_CONTACT_DESC}" /> <label for="field_contact_desc">{L_FIELD_CONTACT_DESC}</label></dd>
<dd><input class="text medium" type="text" name="field_contact_url" id="field_contact_url" value="{FIELD_CONTACT_URL}" /> <label for="field_contact_url">{L_FIELD_CONTACT_URL}</label></dd>
</dl>
</fieldset>
<!-- IF S_EDIT_MODE -->
@@ -185,7 +195,7 @@
</div>
<!-- ENDIF -->
<table cellspacing="1">
<table class="table1 zebra-table">
<thead>
<tr>
<th>{L_FIELD_IDENT}</th>
@@ -195,23 +205,16 @@
</thead>
<tbody>
<!-- BEGIN fields -->
<!-- IF fields.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td>{fields.FIELD_IDENT}</td>
<td>{fields.FIELD_TYPE}</td>
<td style="text-align: center;"><a href="{fields.U_ACTIVATE_DEACTIVATE}" data-ajax="activate_deactivate">{fields.L_ACTIVATE_DEACTIVATE}</a><!-- IF fields.S_NEED_EDIT --> | <a href="{fields.U_TRANSLATE}" style="color: red;">{L_TRANSLATE}</a><!-- ENDIF --></td>
<td style="width: 80px; text-align: right; white-space: nowrap;">
<!-- IF fields.S_FIRST_ROW && not fields.S_LAST_ROW -->
{ICON_MOVE_UP_DISABLED}
<a href="{fields.U_MOVE_DOWN}">{ICON_MOVE_DOWN}</a>
<!-- ELSEIF not fields.S_FIRST_ROW && not fields.S_LAST_ROW-->
<a href="{fields.U_MOVE_UP}">{ICON_MOVE_UP}</a>
<a href="{fields.U_MOVE_DOWN}">{ICON_MOVE_DOWN}</a>
<!-- ELSEIF fields.S_LAST_ROW && not fields.S_FIRST_ROW -->
<a href="{fields.U_MOVE_UP}">{ICON_MOVE_UP}</a>
{ICON_MOVE_DOWN_DISABLED}
<!-- ENDIF -->
<td class="actions" style="width: 80px;">
<span class="up-disabled" style="display:none;">{ICON_MOVE_UP_DISABLED}</span>
<span class="up"><a href="{fields.U_MOVE_UP}" data-ajax="row_up">{ICON_MOVE_UP}</a></span>
<span class="down-disabled" style="display:none;">{ICON_MOVE_DOWN_DISABLED}</span>
<span class="down"><a href="{fields.U_MOVE_DOWN}" data-ajax="row_down">{ICON_MOVE_DOWN}</a></span>
<!-- IF not fields.S_NEED_EDIT -->
<a href="{fields.U_EDIT}">{ICON_EDIT}</a>
<!-- ELSE -->

View File

@@ -8,7 +8,7 @@
<p>{L_PRUNE_SUCCESS}</p>
<table cellspacing="1">
<table class="table1 zebra-table">
<thead>
<tr>
<th>{L_FORUM}</th>
@@ -18,7 +18,7 @@
</thead>
<tbody>
<!-- BEGIN pruned -->
<!-- IF pruned.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td style="text-align: center;">{pruned.FORUM_NAME}</td>
<td style="text-align: center;">{pruned.NUM_TOPICS}</td>
<td style="text-align: center;">{pruned.NUM_POSTS}</td>

View File

@@ -19,11 +19,7 @@
<dd><input type="text" id="email" name="email" /></dd>
</dl>
<dl>
<dt><label for="email">{L_WEBSITE}{L_COLON}</label></dt>
<dd><input type="text" id="website" name="website" /></dd>
</dl>
<dl>
<dt><label for="joined">{L_JOINED}{L_COLON}</label><br /><span>{L_JOINED_EXPLAIN}</span></dt>
<dt><label for="joined_after">{L_JOINED}{L_COLON}</label><br /><span>{L_JOINED_EXPLAIN}</span></dt>
<dd>
<strong>{L_AFTER}</strong> <input type="text" id="joined_after" name="joined_after" />
<br /> <br /> <strong>{L_BEFORE}</strong> <input type="text" id="joined_before" name="joined_before" />
@@ -39,12 +35,12 @@
</dl>
<dl>
<dt><label for="posts_on_queue">{L_POSTS_ON_QUEUE}{L_COLON}</label></dt>
<dd><select name="queue_select">{S_COUNT_OPTIONS}</select> <input type="number" id="posts_on_queue" name="posts_on_queue" /></select>
<dd><select name="queue_select">{S_COUNT_OPTIONS}</select> <input type="number" id="posts_on_queue" name="posts_on_queue" /></dd>
</dl>
<!-- IF S_GROUP_LIST -->
<dl>
<dt><label for="group_id">{L_GROUP}{L_COLON}</label><br /><span>{L_PRUNE_USERS_GROUP_EXPLAIN}</dt>
<dd><select name="group_id">{S_GROUP_LIST}</select></dd>
<dt><label for="group_id">{L_GROUP}{L_COLON}</label><br /><span>{L_PRUNE_USERS_GROUP_EXPLAIN}</span></dt>
<dd><select id="group_id" name="group_id">{S_GROUP_LIST}</select></dd>
</dl>
<!-- ENDIF -->
</fieldset>

View File

@@ -24,6 +24,9 @@
<fieldset>
<legend>{L_ACP_RANKS}</legend>
<!-- EVENT acp_ranks_edit_before -->
<dl>
<dt><label for="title">{L_RANK_TITLE}{L_COLON}</label></dt>
<dd><input name="title" type="text" id="title" value="{RANK_TITLE}" maxlength="255" /></dd>
@@ -35,16 +38,18 @@
</dl>
<dl>
<dt><label for="special_rank">{L_RANK_SPECIAL}{L_COLON}</label></dt>
<dd><label><input onclick="dE('posts', -1)" type="radio" class="radio" name="special_rank" value="1" id="special_rank"<!-- IF S_SPECIAL_RANK --> checked="checked"<!-- ENDIF --> /> {L_YES}</label>
<label><input onclick="dE('posts', 1)" type="radio" class="radio" name="special_rank" value="0"<!-- IF not S_SPECIAL_RANK --> checked="checked"<!-- ENDIF --> /> {L_NO}</label></dd>
<dd><label><input onclick="phpbb.toggleDisplay('posts', -1)" type="radio" class="radio" name="special_rank" value="1" id="special_rank"<!-- IF S_SPECIAL_RANK --> checked="checked"<!-- ENDIF --> /> {L_YES}</label>
<label><input onclick="phpbb.toggleDisplay('posts', 1)" type="radio" class="radio" name="special_rank" value="0"<!-- IF not S_SPECIAL_RANK --> checked="checked"<!-- ENDIF --> /> {L_NO}</label></dd>
</dl>
<!-- IF S_SPECIAL_RANK --><div id="posts" style="display: none;"><!-- ELSE --><div id="posts"><!-- ENDIF -->
<div id="posts"<!-- IF S_SPECIAL_RANK --> style="display: none;"<!-- ENDIF -->>
<dl>
<dt><label for="min_posts">{L_RANK_MINIMUM}{L_COLON}</label></dt>
<dd><input name="min_posts" type="number" id="min_posts" maxlength="10" value="{MIN_POSTS}" /></dd>
</dl>
</div>
<!-- EVENT acp_ranks_edit_after -->
<p class="submit-buttons">
<input type="hidden" name="action" value="save" />
@@ -65,21 +70,25 @@
<fieldset class="tabulated">
<legend>{L_ACP_MANAGE_RANKS}</legend>
<table cellspacing="1">
<table class="table1 zebra-table">
<thead>
<tr>
<!-- EVENT acp_ranks_list_header_before -->
<th>{L_RANK_IMAGE}</th>
<th>{L_RANK_TITLE}</th>
<th>{L_RANK_MINIMUM}</th>
<!-- EVENT acp_ranks_list_header_after -->
<th>{L_ACTION}</th>
</tr>
</thead>
<tbody>
<!-- BEGIN ranks -->
<!-- IF ranks.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<!-- EVENT acp_ranks_list_column_before -->
<td style="text-align: center;"><!-- IF ranks.S_RANK_IMAGE --><img src="{ranks.RANK_IMAGE}" alt="{ranks.RANK_TITLE}" title="{ranks.RANK_TITLE}" /><!-- ELSE -->&nbsp; - &nbsp;<!-- ENDIF --></td>
<td style="text-align: center;">{ranks.RANK_TITLE}</td>
<td style="text-align: center;"><!-- IF ranks.S_SPECIAL_RANK -->&nbsp; - &nbsp;<!-- ELSE -->{ranks.MIN_POSTS}<!-- ENDIF --></td>
<!-- EVENT acp_ranks_list_column_after -->
<td style="text-align: center;"><a href="{ranks.U_EDIT}">{ICON_EDIT}</a> <a href="{ranks.U_DELETE}" data-ajax="row_delete">{ICON_DELETE}</a></td>
</tr>
<!-- END ranks -->

View File

@@ -68,7 +68,7 @@
<legend>{L_ACP_REASONS}</legend>
<!-- IF .reasons -->
<table cellspacing="1">
<table class="table1">
<col class="row1" /><col class="row1" /><col class="row2" />
<thead>
<tr>
@@ -86,17 +86,11 @@
<br /><span>{reasons.REASON_DESCRIPTION}</span>
</td>
<td style="width: 100px;">{reasons.REASON_COUNT}</td>
<td style="width: 80px; text-align: right; white-space: nowrap;">
<!-- IF reasons.S_FIRST_ROW && not reasons.S_LAST_ROW -->
{ICON_MOVE_UP_DISABLED}
<a href="{reasons.U_MOVE_DOWN}">{ICON_MOVE_DOWN}</a>
<!-- ELSEIF not reasons.S_FIRST_ROW && not reasons.S_LAST_ROW-->
<a href="{reasons.U_MOVE_UP}">{ICON_MOVE_UP}</a>
<a href="{reasons.U_MOVE_DOWN}">{ICON_MOVE_DOWN}</a>
<!-- ELSEIF reasons.S_LAST_ROW && not reasons.S_FIRST_ROW -->
<a href="{reasons.U_MOVE_UP}">{ICON_MOVE_UP}</a>
{ICON_MOVE_DOWN_DISABLED}
<!-- ENDIF -->
<td class="actions" style="width: 80px;">
<span class="up-disabled" style="display:none;">{ICON_MOVE_UP_DISABLED}</span>
<span class="up"><a href="{reasons.U_MOVE_UP}" data-ajax="row_up">{ICON_MOVE_UP}</a></span>
<span class="down-disabled" style="display:none;">{ICON_MOVE_DOWN_DISABLED}</span>
<span class="down"><a href="{reasons.U_MOVE_DOWN}" data-ajax="row_down">{ICON_MOVE_DOWN}</a></span>
<a href="{reasons.U_EDIT}">{ICON_EDIT}</a>
<!-- IF reasons.U_DELETE -->
<a href="{reasons.U_DELETE}" data-ajax="row_delete">{ICON_DELETE}</a>

View File

@@ -46,13 +46,13 @@
<legend>{L_SEARCH_TYPE}</legend>
<dl>
<dt><label for="search_type">{L_SEARCH_TYPE}{L_COLON}</label><br /><span>{L_SEARCH_TYPE_EXPLAIN}</span></dt>
<dd><select id="search_type" name="config[search_type]">{S_SEARCH_TYPES}</select></dd>
<dd><select id="search_type" name="config[search_type]" data-togglable-settings="true">{S_SEARCH_TYPES}</select></dd>
</dl>
</fieldset>
<!-- BEGIN backend -->
<fieldset>
<fieldset id="search_{backend.IDENTIFIER}_settings">
<legend>{backend.NAME}</legend>
{backend.SETTINGS}
</fieldset>
@@ -112,7 +112,7 @@
<legend>{L_INDEX_STATS}{L_COLON} {backend.L_NAME} <!-- IF backend.S_ACTIVE -->({L_ACTIVE}) <!-- ENDIF --></legend>
<table cellspacing="1">
<table class="table1">
<caption>{backend.L_NAME} <!-- IF backend.S_ACTIVE -->({L_ACTIVE}) <!-- ENDIF --></caption>
<col class="col1" /><col class="col2" /><col class="col1" /><col class="col2" />
<thead>

View File

@@ -17,8 +17,8 @@ function iframe_updated()
return;
}
dE('questionnaire-form', -1);
dE('questionnaire-thanks', 1);
phpbb.toggleDisplay('questionnaire-form', -1);
phpbb.toggleDisplay('questionnaire-thanks', 1);
}
//]]>
</script>
@@ -31,10 +31,10 @@ function iframe_updated()
<p>{L_EXPLAIN_SHOW_STATISTICS}</p>
<p id="show-button"><input type="button" class="button2" onclick="dE('configlist', 1); dE('show-button', -1);" value="{L_SHOW_STATISTICS}" /></p>
<p id="show-button"><input type="button" class="button2" onclick="phpbb.toggleDisplay('configlist', 1); phpbb.toggleDisplay('show-button', -1);" value="{L_SHOW_STATISTICS}" /></p>
<div id="configlist">
<input type="button" class="button2" onclick="dE('show-button', 1); dE('configlist', -1);" value="{L_HIDE_STATISTICS}" />
<input type="button" class="button2" onclick="phpbb.toggleDisplay('show-button', 1); phpbb.toggleDisplay('configlist', -1);" value="{L_HIDE_STATISTICS}" />
<p class="submit-buttons">
<input class="button1" type="submit" id="submit" name="submit" value="{L_SEND_STATISTICS}" />
</p>
@@ -61,11 +61,4 @@ function iframe_updated()
<p><strong>{L_THANKS_SEND_STATISTICS}</strong><br /><br /><a href="{U_ACP_MAIN}">&laquo; {L_GO_ACP_MAIN}</a></p>
</div>
<script type="text/javascript">
//<![CDATA[
dE('configlist', -1);
dE('questionnaire-thanks', -1);
//]]>
</script>
<!-- INCLUDE overall_footer.html -->

View File

@@ -2,6 +2,10 @@
<a id="maincontent"></a>
<!-- IF S_STYLE_DETAILS -->
<a href="{U_ACTION}" style="float: {S_CONTENT_FLOW_END};">&laquo; {L_BACK}</a>
<!-- ENDIF -->
<!-- IF S_CONFIRM_ACTION -->
<form id="confirm" method="post" action="{S_CONFIRM_ACTION}">
@@ -20,7 +24,7 @@
</div>
</fieldset>
</form>
<!-- ELSE -->
@@ -40,7 +44,7 @@
<dd><input type="text" id="name" name="style_name" value="{STYLE_NAME}" /></dd>
</dl>
<dl>
<dt><label>{L_STYLE_PATH}</label></dt>
<dt><label>{L_STYLE_PATH}{L_COLON}</label></dt>
<dd><strong>{STYLE_PATH}</strong></dd>
</dl>
<dl>
@@ -72,14 +76,14 @@
<fieldset class="submit-buttons">
<legend>{L_SUBMIT}</legend>
<input class="button1" type="submit" name="update" value="{L_SUBMIT}" />
<a href="{U_ACTION}" class="button2">{L_BACK}</a>
<input class="button1" type="submit" name="update" value="{L_SUBMIT}" />&nbsp;
<input class="button2" type="reset" id="reset" name="reset" value="{L_RESET}" />
{S_FORM_TOKEN}
</fieldset>
<!-- ENDIF -->
<!-- IF .styles_list -->
<table cellspacing="1">
<table class="table1 styles">
<thead>
<tr>
<th>{L_STYLE_NAME}</th>
@@ -97,9 +101,9 @@
<!-- ELSE -->
<!-- IF $ROW_CLASS == 'row2a' --><!-- DEFINE $ROW_CLASS = 'row2b' --><!-- ELSE --><!-- DEFINE $ROW_CLASS = 'row2a' --><!-- ENDIF -->
<!-- ENDIF -->
<td class="{$ROW_CLASS}" style="padding-left: {styles_list.PADDING}px;">
<td class="{$ROW_CLASS}" style="padding-{S_CONTENT_FLOW_BEGIN}: {styles_list.PADDING}px;">
<!-- IF styles_list.STYLE_ID and styles_list.COMMENT == '' and styles_list.STYLE_ACTIVE -->
<div class="default-style" style="display: none; float: right;">
<div class="default-style" style="display: none; float: {S_CONTENT_FLOW_END};">
<input class="radio" type="radio" name="default" value="{styles_list.STYLE_ID}"<!-- IF styles_list.DEFAULT --> checked="checked"<!-- ELSE --><!-- DEFINE $S_DEFAULT = 1 --><!-- ENDIF --> title="{L_STYLE_DEFAULT}" />
</div>
<!-- ENDIF -->
@@ -113,13 +117,13 @@
<span class="error"><br />{styles_list.COMMENT}</span>
<!-- ENDIF -->
<!-- IF not styles_list.STYLE_ID and styles_list.COMMENT == '' -->
<span class="style-path"><br />{L_STYLE_PATH} {styles_list.STYLE_PATH_FULL}</span>
<span class="style-path"><br />{L_STYLE_PATH}{L_COLON} {styles_list.STYLE_PATH_FULL}</span>
<!-- ENDIF -->
</td>
<!-- IF not STYLES_LIST_HIDE_COUNT -->
<td class="{$ROW_CLASS}" style="text-align: center;">{styles_list.USERS}</td>
<td class="{$ROW_CLASS} users">{styles_list.USERS}</td>
<!-- ENDIF -->
<td class="{$ROW_CLASS}" style="text-align: center;">
<td class="{$ROW_CLASS} actions">
<!-- BEGIN actions -->
<!-- IF styles_list.actions.S_ROW_COUNT > 0 --> | <!-- ENDIF -->
<!-- IF styles_list.actions.U_ACTION -->
@@ -129,7 +133,7 @@
<!-- END actions -->
</td>
{styles_list.EXTRA}
<td class="{$ROW_CLASS}" width="20" style="text-align: center;">
<td class="{$ROW_CLASS} mark" width="20">
<!-- IF styles_list.STYLE_ID -->
<input class="checkbox" type="checkbox" name="ids[]" value="{styles_list.STYLE_ID}" />
<!-- ELSE -->
@@ -154,14 +158,6 @@
</fieldset>
<!-- ENDIF -->
<!-- IF .extra_links -->
<fieldset class="quick">
<!-- BEGIN extra_links -->
<a class="button2" href="{extra_links.U_ACTION}">{extra_links.L_ACTION}</a>
<!-- END extra_links -->
</fieldset>
<!-- ENDIF -->
</form>
<!-- ENDIF -->

View File

@@ -1,52 +1,46 @@
<!-- INCLUDE overall_header.html -->
<a id="maincontent"></a>
<!-- IF S_VERSION_CHECK -->
<h1>{L_VERSION_CHECK}</h1>
<h1>{L_VERSION_CHECK}</h1>
<p>{L_VERSION_CHECK_EXPLAIN}</p>
<p>{L_VERSION_CHECK_EXPLAIN}</p>
<!-- IF S_UP_TO_DATE and S_UP_TO_DATE_AUTO -->
<div class="successbox">
<p>{L_VERSION_UP_TO_DATE_ACP} - <a href="{U_VERSIONCHECK_FORCE}">{L_VERSIONCHECK_FORCE_UPDATE}</a></p>
</div>
<!-- ELSE -->
<div class="errorbox">
<p>{L_VERSION_NOT_UP_TO_DATE_ACP} - <a href="{U_VERSIONCHECK_FORCE}">{L_VERSIONCHECK_FORCE_UPDATE}</a></p>
</div>
<!-- ENDIF -->
<!-- IF S_UP_TO_DATE -->
<div class="successbox">
<p>{L_VERSION_UP_TO_DATE_ACP} - <a href="{U_VERSIONCHECK_FORCE}">{L_VERSIONCHECK_FORCE_UPDATE}</a></p>
</div>
<!-- ELSE -->
<div class="errorbox">
<p>{L_VERSION_NOT_UP_TO_DATE_ACP} - <a href="{U_VERSIONCHECK_FORCE}">{L_VERSIONCHECK_FORCE_UPDATE}</a></p>
</div>
<!-- ENDIF -->
<!-- IF NEXT_FEATURE_VERSION -->
<div class="errorbox">
<p>{UPGRADE_INSTRUCTIONS}</p>
</div>
<!-- ENDIF -->
<fieldset>
<legend></legend>
<fieldset>
<legend></legend>
<dl>
<dt><label>{L_CURRENT_VERSION}</label></dt>
<dd><strong><!-- IF S_UP_TO_DATE and not S_UP_TO_DATE_AUTO -->{AUTO_VERSION}<!-- ELSE -->{CURRENT_VERSION}<!-- ENDIF --></strong></dd>
</dl>
<dl>
<dt><label>{L_LATEST_VERSION}</label></dt>
<dd><strong>{LATEST_VERSION}</strong></dd>
<dd><strong>{CURRENT_VERSION}</strong></dd>
</dl>
</fieldset>
<!-- BEGIN updates_available -->
<fieldset>
<legend></legend>
<dl>
<dt><label>{L_LATEST_VERSION}</label></dt>
<dd><strong>{updates_available.current}</strong></dd>
</dl>
<dl>
<dt><label>{L_RELEASE_ANNOUNCEMENT}</label></dt>
<dd><strong><a href="{updates_available.announcement}">{updates_available.announcement}</a></strong></dd>
</dl>
</fieldset>
<!-- END updates_available -->
<!-- IF S_UP_TO_DATE and not S_UP_TO_DATE_AUTO -->
{L_UPDATE_INSTRUCTIONS_INCOMPLETE}
<br /><br />
{UPDATE_INSTRUCTIONS}
<br /><br />
<!-- ENDIF -->
<!-- IF not S_UP_TO_DATE -->
{UPDATE_INSTRUCTIONS}
<br /><br />
<!-- ENDIF -->
<!-- IF not S_UP_TO_DATE -->
{UPDATE_INSTRUCTIONS}
<br /><br />
<!-- ENDIF -->
<!-- INCLUDE overall_footer.html -->

View File

@@ -125,7 +125,7 @@
<form id="user_groups" method="post" action="{U_ACTION}">
<table cellspacing="1">
<table class="table1 zebra-table">
<tbody>
<!-- BEGIN group -->
<!-- IF group.S_NEW_GROUP_TYPE -->
@@ -133,7 +133,7 @@
<td class="row3" colspan="4"><strong>{group.GROUP_TYPE}</strong></td>
</tr>
<!-- ELSE -->
<!-- IF group.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td><a href="{group.U_EDIT_GROUP}">{group.GROUP_NAME}</a></td>
<td><!-- IF group.S_IS_MEMBER --><!-- IF group.S_NO_DEFAULT --><a href="{group.U_DEFAULT}">{L_GROUP_DEFAULT}</a><!-- ELSE --><strong>{L_GROUP_DEFAULT}</strong><!-- ENDIF --><!-- ELSEIF not group.S_IS_MEMBER and group.U_APPROVE --><a href="{group.U_APPROVE}">{L_GROUP_APPROVE}</a><!-- ELSE -->&nbsp;<!-- ENDIF --></td>
<td><!-- IF group.S_IS_MEMBER and not group.S_SPECIAL_GROUP --><a href="{group.U_DEMOTE_PROMOTE}">{group.L_DEMOTE_PROMOTE}</a><!-- ELSE -->&nbsp;<!-- ENDIF --></td>
@@ -164,19 +164,19 @@
</div>
<!-- IF .attach -->
<table cellspacing="1">
<table class="table1 zebra-table fixed-width-table">
<thead>
<tr>
<th>{L_FILENAME}</th>
<th>{L_POST_TIME}</th>
<th>{L_FILESIZE}</th>
<th>{L_DOWNLOADS}</th>
<th>{L_MARK}</th>
<th style="width: 20%;">{L_POST_TIME}</th>
<th style="width: 20%;">{L_FILESIZE}</th>
<th style="width: 20%;">{L_DOWNLOADS}</th>
<th style="width: 50px;">{L_MARK}</th>
</tr>
</thead>
<tbody>
<!-- BEGIN attach -->
<!-- IF attach.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td><a href="{attach.U_DOWNLOAD}">{attach.REAL_FILENAME}</a><br /><span class="small"><!-- IF attach.S_IN_MESSAGE --><strong>{L_PM}{L_COLON} </strong><!-- ELSE --><strong>{L_POST}{L_COLON} </strong><!-- ENDIF --><a href="{attach.U_VIEW_TOPIC}">{attach.TOPIC_TITLE}</a></span></td>
<td style="text-align: center">{attach.POST_TIME}</td>
<td style="text-align: center">{attach.SIZE}</td>

View File

@@ -13,10 +13,9 @@
<legend>{L_AVATAR_SELECT}</legend>
<dl>
<dt><label>{L_AVATAR_TYPE}</label></dt>
<dd><select name="avatar_driver" id="avatar_driver">
<option value="">{L_NO_AVATAR_CATEGORY}</option>
<dd><select name="avatar_driver" id="avatar_driver" data-togglable-settings="true">
<!-- BEGIN avatar_drivers -->
<option value="{avatar_drivers.DRIVER}"<!-- IF avatar_drivers.SELECTED --> selected="selected"<!-- ENDIF -->>{avatar_drivers.L_TITLE}</option>
<option value="{avatar_drivers.DRIVER}"<!-- IF avatar_drivers.SELECTED --> selected="selected"<!-- ENDIF --> data-toggle-setting="#avatar_option_{avatar_drivers.DRIVER}">{avatar_drivers.L_TITLE}</option>
<!-- END avatar_drivers -->
</select></dd>
</dl>
@@ -35,5 +34,3 @@
{S_FORM_TOKEN}
</fieldset>
</form>
<!-- INCLUDEJS avatars.js -->

View File

@@ -7,7 +7,7 @@
</div>
<!-- IF .log -->
<table cellspacing="1">
<table class="table1 zebra-table">
<thead>
<tr>
<th>{L_REPORT_BY}</th>
@@ -19,8 +19,7 @@
</thead>
<tbody>
<!-- BEGIN log -->
<!-- IF log.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td>{log.USERNAME}</td>
<td style="text-align: center;">{log.IP}</td>
<td style="text-align: center;">{log.DATE}</td>

View File

@@ -30,7 +30,20 @@
</dl>
<dl>
<dt><label>{L_POSTS}{L_COLON}</label></dt>
<dd><strong>{USER_POSTS}</strong><!-- IF POSTS_IN_QUEUE and U_MCP_QUEUE --> (<a href="{U_MCP_QUEUE}">{L_POSTS_IN_QUEUE}</a>)<!-- ELSEIF POSTS_IN_QUEUE --> ({L_POSTS_IN_QUEUE})<!-- ENDIF --></dd>
<dd>
<strong>
<!-- IF USER_HAS_POSTS and U_SEARCH_USER -->
<a href="{U_SEARCH_USER}">{USER_POSTS}</a>
<!-- ELSE -->
{USER_POSTS}
<!-- ENDIF -->
</strong>
<!-- IF POSTS_IN_QUEUE and U_MCP_QUEUE -->
(<a href="{U_MCP_QUEUE}">{L_POSTS_IN_QUEUE}</a>)
<!-- ELSEIF POSTS_IN_QUEUE -->
({L_POSTS_IN_QUEUE})
<!-- ENDIF -->
</dd>
</dl>
<dl>
<dt><label>{L_WARNINGS}{L_COLON}</label></dt>
@@ -73,11 +86,11 @@
{
if (option != 'banuser' && option != 'banemail' && option != 'banip')
{
dE('reasons', -1);
phpbb.toggleDisplay('reasons', -1);
return;
}
dE('reasons', 1);
phpbb.toggleDisplay('reasons', 1);
element = document.getElementById('user_quick_tools').ban_reason;

View File

@@ -5,9 +5,10 @@
</script>
<form id="user_prefs" method="post" action="{U_ACTION}">
<!-- EVENT acp_users_prefs_prepend -->
<fieldset>
<legend>{L_UCP_PREFS_PERSONAL}</legend>
<!-- EVENT acp_users_prefs_personal_prepend -->
<dl>
<dt><label for="viewemail">{L_SHOW_EMAIL}{L_COLON}</label></dt>
<dd><label><input type="radio" class="radio" name="viewemail" value="1"<!-- IF VIEW_EMAIL --> id="viewemail" checked="checked"<!-- ENDIF --> /> {L_YES}</label>
@@ -39,11 +40,6 @@
<dd><label><input type="radio" class="radio" name="notifypm" value="1"<!-- IF NOTIFY_PM --> id="notifypm" checked="checked"<!-- ENDIF --> /> {L_YES}</label>
<label><input type="radio" class="radio" name="notifypm" value="0"<!-- IF not NOTIFY_PM --> id="notifypm" checked="checked"<!-- ENDIF --> /> {L_NO}</label></dd>
</dl>
<dl>
<dt><label for="popuppm">{L_POPUP_ON_PM}{L_COLON}</label></dt>
<dd><label><input type="radio" class="radio" name="popuppm" value="1"<!-- IF POPUP_PM --> id="popuppm" checked="checked"<!-- ENDIF --> /> {L_YES}</label>
<label><input type="radio" class="radio" name="popuppm" value="0"<!-- IF not POPUP_PM --> id="popuppm" checked="checked"<!-- ENDIF --> /> {L_NO}</label></dd>
</dl>
<dl>
<dt><label for="lang">{L_BOARD_LANGUAGE}{L_COLON}</label></dt>
<dd><select id="lang" name="lang">{S_LANG_OPTIONS}</select></dd>
@@ -55,13 +51,15 @@
<!-- INCLUDE timezone_option.html -->
<dl>
<dt><label for="dateoptions">{L_BOARD_DATE_FORMAT}{L_COLON}</label><br /><span>{L_BOARD_DATE_FORMAT_EXPLAIN}</span></dt>
<dd><select name="dateoptions" id="dateoptions" onchange="if(this.value=='custom'){dE('custom_date',1);}else{dE('custom_date',-1);} if (this.value == 'custom') { document.getElementById('dateformat').value = default_dateformat; } else { document.getElementById('dateformat').value = this.value; }">{S_DATEFORMAT_OPTIONS}</select></dd>
<dd><select name="dateoptions" id="dateoptions" onchange="if(this.value=='custom'){phpbb.toggleDisplay('custom_date',1);}else{phpbb.toggleDisplay('custom_date',-1);} if (this.value == 'custom') { document.getElementById('dateformat').value = default_dateformat; } else { document.getElementById('dateformat').value = this.value; }">{S_DATEFORMAT_OPTIONS}</select></dd>
<dd><div id="custom_date"<!-- IF not S_CUSTOM_DATEFORMAT --> style="display:none;"<!-- ENDIF -->><input type="text" name="dateformat" id="dateformat" value="{DATE_FORMAT}" maxlength="30" /></div></dd>
</dl>
<!-- EVENT acp_users_prefs_personal_append -->
</fieldset>
<fieldset>
<legend>{L_UCP_PREFS_POST}</legend>
<!-- EVENT acp_users_prefs_post_prepend -->
<dl>
<dt><label for="bbcode">{L_DEFAULT_BBCODE}{L_COLON}</label></dt>
<dd><label><input type="radio" class="radio" name="bbcode" value="1"<!-- IF BBCODE --> id="bbcode" checked="checked"<!-- ENDIF --> /> {L_YES}</label>
@@ -82,10 +80,12 @@
<dd><label><input type="radio" class="radio" name="notify" value="1"<!-- IF NOTIFY --> id="notify" checked="checked"<!-- ENDIF --> /> {L_YES}</label>
<label><input type="radio" class="radio" name="notify" value="0"<!-- IF not NOTIFY --> id="notify" checked="checked"<!-- ENDIF --> /> {L_NO}</label></dd>
</dl>
<!-- EVENT acp_users_prefs_post_append -->
</fieldset>
<fieldset>
<legend>{L_UCP_PREFS_VIEW}</legend>
<!-- EVENT acp_users_prefs_view_prepend -->
<dl>
<dt><label for="view_images">{L_VIEW_IMAGES}{L_COLON}</label></dt>
<dd><label><input type="radio" class="radio" name="view_images" value="1"<!-- IF VIEW_IMAGES --> id="view_images" checked="checked"<!-- ENDIF --> /> {L_YES}</label>
@@ -140,8 +140,9 @@
<dt><label>{L_VIEW_POSTS_DIR}{L_COLON}</label></dt>
<dd>{S_POST_SORT_DIR}</dd>
</dl>
<!-- EVENT acp_users_prefs_view_append -->
</fieldset>
<!-- EVENT acp_users_prefs_append -->
<fieldset class="quick">
<input class="button1" type="submit" name="update" value="{L_SUBMIT}" />
{S_FORM_TOKEN}

View File

@@ -2,42 +2,10 @@
<fieldset>
<legend>{L_USER_PROFILE}</legend>
<dl>
<dt><label for="icq">{L_UCP_ICQ}{L_COLON}</label></dt>
<dd><input type="text" id="icq" name="icq" value="{ICQ}" /></dd>
</dl>
<dl>
<dt><label for="aim">{L_UCP_AIM}{L_COLON}</label></dt>
<dd><input type="text" id="aim" name="aim" value="{AIM}" /></dd>
</dl>
<dl>
<dt><label for="msn">{L_UCP_MSNM}{L_COLON}</label></dt>
<dd><input type="email" id="msn" name="msn" value="{MSN}" /></dd>
</dl>
<dl>
<dt><label for="yim">{L_UCP_YIM}{L_COLON}</label></dt>
<dd><input type="text" id="yim" name="yim" value="{YIM}" /></dd>
</dl>
<dl>
<dt><label for="jabber">{L_UCP_JABBER}{L_COLON}</label></dt>
<dd><input type="email" id="jabber" name="jabber" value="{JABBER}" /></dd>
</dl>
<dl>
<dt><label for="website">{L_WEBSITE}{L_COLON}</label></dt>
<dd><input type="url" id="website" name="website" value="{WEBSITE}" /></dd>
</dl>
<dl>
<dt><label for="location">{L_LOCATION}{L_COLON}</label></dt>
<dd><input type="text" id="location" name="location" value="{LOCATION}" /></dd>
</dl>
<dl>
<dt><label for="occupation">{L_OCCUPATION}{L_COLON}</label></dt>
<dd><textarea id="occupation" name="occupation" rows="3" cols="30">{OCCUPATION}</textarea></dd>
</dl>
<dl>
<dt><label for="interests">{L_INTERESTS}{L_COLON}</label></dt>
<dd><textarea id="interests" name="interests" rows="3" cols="30">{INTERESTS}</textarea></dd>
</dl>
<dl>
<dt><label for="birthday">{L_BIRTHDAY}{L_COLON}</label><br /><span>{L_BIRTHDAY_EXPLAIN}</span></dt>
<dd>{L_DAY}{L_COLON} <select id="birthday" name="bday_day">{S_BIRTHDAY_DAY_OPTIONS}</select> {L_MONTH}{L_COLON} <select name="bday_month">{S_BIRTHDAY_MONTH_OPTIONS}</select> {L_YEAR}{L_COLON} <select name="bday_year">{S_BIRTHDAY_YEAR_OPTIONS}</select></dd>

View File

@@ -3,36 +3,12 @@
var form_name = 'user_signature';
var text_name = 'signature';
// Define the bbCode tags
var bbcode = new Array();
var bbtags = new Array('[b]','[/b]','[i]','[/i]','[u]','[/u]','[quote]','[/quote]','[code]','[/code]','[list]','[/list]','[list=]','[/list]','[img]','[/img]','[url]','[/url]','[flash=]', '[/flash]','[size=]','[/size]'<!-- BEGIN custom_tags -->, {custom_tags.BBCODE_NAME}<!-- END custom_tags -->);
var load_draft = false;
var upload = false;
var imageTag = false;
// Helpline messages
var help_line = {
b: '{LA_BBCODE_B_HELP}',
i: '{LA_BBCODE_I_HELP}',
u: '{LA_BBCODE_U_HELP}',
q: '{LA_BBCODE_Q_HELP}',
c: '{LA_BBCODE_C_HELP}',
l: '{LA_BBCODE_L_HELP}',
o: '{LA_BBCODE_O_HELP}',
p: '{LA_BBCODE_P_HELP}',
w: '{LA_BBCODE_W_HELP}',
s: '{LA_BBCODE_S_HELP}',
f: '{LA_BBCODE_F_HELP}',
y: '{LA_BBCODE_Y_HELP}',
d: '{LA_BBCODE_D_HELP}',
tip: '{L_STYLES_TIP}'
<!-- BEGIN custom_tags -->
,cb_{custom_tags.BBCODE_ID}{L_COLON} '{custom_tags.A_BBCODE_HELPLINE}'
<!-- END custom_tags -->
}
// ]]>
</script>
<script type="text/javascript" src="{T_TEMPLATE_PATH}/editor.js"></script>
<form id="user_signature" method="post" action="{U_ACTION}">
@@ -47,53 +23,13 @@
<legend>{L_SIGNATURE}</legend>
<p>{L_SIGNATURE_EXPLAIN}</p>
<div id="format-buttons">
<input type="button" class="button2" accesskey="b" name="addbbcode0" value=" B " style="font-weight:bold; width: 30px;" onclick="bbstyle(0)" onmouseover="helpline('b')" onmouseout="helpline('tip')" />
<input type="button" class="button2" accesskey="i" name="addbbcode2" value=" i " style="font-style:italic; width: 30px;" onclick="bbstyle(2)" onmouseover="helpline('i')" onmouseout="helpline('tip')" />
<input type="button" class="button2" accesskey="u" name="addbbcode4" value=" u " style="text-decoration: underline; width: 30px;" onclick="bbstyle(4)" onmouseover="helpline('u')" onmouseout="helpline('tip')" />
<input type="button" class="button2" accesskey="q" name="addbbcode6" value="Quote" style="width: 50px" onclick="bbstyle(6)" onmouseover="helpline('q')" onmouseout="helpline('tip')" />
<input type="button" class="button2" accesskey="c" name="addbbcode8" value="Code" style="width: 40px" onclick="bbstyle(8)" onmouseover="helpline('c')" onmouseout="helpline('tip')" />
<input type="button" class="button2" accesskey="l" name="addbbcode10" value="List" style="width: 40px" onclick="bbstyle(10)" onmouseover="helpline('l')" onmouseout="helpline('tip')" />
<input type="button" class="button2" accesskey="o" name="addbbcode12" value="List=" style="width: 40px" onclick="bbstyle(12)" onmouseover="helpline('o')" onmouseout="helpline('tip')" />
<input type="button" class="button2" accesskey="y" name="addlistitem" value="[*]" style="width: 40px" onclick="bbstyle(-1)" onmouseover="helpline('y')" onmouseout="helpline('tip')" />
<!-- IF S_BBCODE_IMG -->
<input type="button" class="button2" accesskey="p" name="addbbcode14" value="Img" style="width: 40px" onclick="bbstyle(14)" onmouseover="helpline('p')" onmouseout="helpline('tip')" />
<!-- ENDIF -->
<!-- IF S_LINKS_ALLOWED -->
<input type="button" class="button2" accesskey="w" name="addbbcode16" value="URL" style="text-decoration: underline; width: 40px" onclick="bbstyle(16)" onmouseover="helpline('w')" onmouseout="helpline('tip')" />
<!-- ENDIF -->
<!-- IF S_BBCODE_FLASH -->
<input type="button" class="button2" accesskey="d" name="addbbcode18" value="Flash" onclick="bbstyle(18)" onmouseover="helpline('d')" onmouseout="helpline('tip')" />
<!-- ENDIF -->
<!-- INCLUDE acp_posting_buttons.html -->
{L_FONT_SIZE}{L_COLON} <select name="addbbcode20" onchange="bbfontstyle('[size=' + this.form.addbbcode20.options[this.form.addbbcode20.selectedIndex].value + ']', '[/size]');this.form.addbbcode20.selectedIndex = 2;" title="{L_FONT_SIZE}" onmouseover="helpline('f')" onmouseout="helpline('tip')">
<option value="50">{L_FONT_TINY}</option>
<option value="85">{L_FONT_SMALL}</option>
<option value="100" selected="selected">{L_FONT_NORMAL}</option>
<option value="150">{L_FONT_LARGE}</option>
<option value="200">{L_FONT_HUGE}</option>
</select>
<!-- IF .custom_tags -->
<br /><br />
<!-- BEGIN custom_tags -->
<input type="button" class="button2" name="addbbcode{custom_tags.BBCODE_ID}" value="{custom_tags.BBCODE_TAG}" onclick="bbstyle({custom_tags.BBCODE_ID})"<!-- IF custom_tags.BBCODE_HELPLINE !== '' --> onmouseover="helpline('cb_{custom_tags.BBCODE_ID}')" onmouseout="helpline('tip')"<!-- ENDIF --> />
<!-- END custom_tags -->
<!-- ENDIF -->
</div>
<p><input type="text" class="text full" style="border: 0; background: none;" name="helpbox" value="{L_STYLES_TIP}" /></p>
<dl>
<dt style="width: 90px;">
<script type="text/javascript">
// <![CDATA[
colorPalette('v', 12, 10);
// ]]>
</script>
<dl class="responsive-columns">
<dt style="width: 90px;" id="color_palette_placeholder" data-orientation="v" data-height="12" data-width="15" data-bbcode="true">
</dt>
<dd style="margin-{S_CONTENT_FLOW_BEGIN}{L_COLON} 90px;"><textarea name="signature" rows="10" cols="60" style="width: 95%;" onselect="storeCaret(this);" onclick="storeCaret(this);" onkeyup="storeCaret(this);" onfocus="initInsertions();" data-bbcode="true">{SIGNATURE}</textarea></dd>
<dd style="margin-{S_CONTENT_FLOW_BEGIN}{L_COLON} 90px; margin-top: 5px;">
<dd style="margin-{S_CONTENT_FLOW_BEGIN}: 90px;"><textarea name="signature" rows="10" cols="60" style="width: 95%;" onselect="storeCaret(this);" onclick="storeCaret(this);" onkeyup="storeCaret(this);" onfocus="initInsertions();" data-bbcode="true">{SIGNATURE}</textarea></dd>
<dd style="margin-{S_CONTENT_FLOW_BEGIN}: 90px; margin-top: 5px;">
<!-- IF S_BBCODE_ALLOWED -->
<label><input type="checkbox" class="radio" name="disable_bbcode"{S_BBCODE_CHECKED} /> {L_DISABLE_BBCODE}</label>
<!-- ENDIF -->
@@ -104,7 +40,7 @@
<label><input type="checkbox" class="radio" name="disable_magic_url"{S_MAGIC_URL_CHECKED} /> {L_DISABLE_MAGIC_URL}</label>
<!-- ENDIF -->
</dd>
<dd style="margin-{S_CONTENT_FLOW_BEGIN}{L_COLON} 90px; margin-top: 10px;"><strong>{L_OPTIONS}{L_COLON} </strong>{BBCODE_STATUS} :: {IMG_STATUS} :: {FLASH_STATUS} :: {URL_STATUS} :: {SMILIES_STATUS}</dd>
<dd style="margin-{S_CONTENT_FLOW_BEGIN}: 90px; margin-top: 10px;"><strong>{L_OPTIONS}{L_COLON} </strong>{BBCODE_STATUS} :: {IMG_STATUS} :: {FLASH_STATUS} :: {URL_STATUS} :: {SMILIES_STATUS}</dd>
</dl>
</fieldset>

View File

@@ -1,7 +1,7 @@
<form id="list" method="post" action="{U_ACTION}">
<!-- IF .warn -->
<table cellspacing="1">
<table class="table1 zebra-table">
<thead>
<tr>
<th>{L_REPORT_BY}</th>
@@ -12,7 +12,7 @@
</thead>
<tbody>
<!-- BEGIN warn -->
<!-- IF warn.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td>{warn.USERNAME}</td>
<td style="text-align: center; nowrap: nowrap;">{warn.DATE}</td>
<td>{warn.ACTION}</td>

View File

@@ -47,7 +47,7 @@
<input class="button2" name="add" type="submit" value="{L_ADD_WORD}" />
</p>
<table cellspacing="1">
<table class="table1 zebra-table">
<thead>
<tr>
<th>{L_WORD}</th>
@@ -57,7 +57,7 @@
</thead>
<tbody>
<!-- BEGIN words -->
<!-- IF words.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
<tr>
<td style="text-align: center;">{words.WORD}</td>
<td style="text-align: center;">{words.REPLACEMENT}</td>
<td>&nbsp;<a href="{words.U_EDIT}">{ICON_EDIT}</a>&nbsp;&nbsp;<a href="{words.U_DELETE}" data-ajax="row_delete">{ICON_DELETE}</a>&nbsp;</td>

File diff suppressed because it is too large Load Diff

250
phpBB/adm/style/admin.js Normal file
View File

@@ -0,0 +1,250 @@
/**
* phpBB3 ACP functions
*/
/**
* Parse document block
*/
function parse_document(container)
{
var test = document.createElement('div'),
oldBrowser = (typeof test.style.borderRadius == 'undefined');
delete test;
/**
* Navigation
*/
container.find('#menu').each(function() {
var menu = $(this),
blocks = menu.children('.menu-block');
if (!blocks.length) {
return;
}
// Set onclick event
blocks.children('a.header').click(function() {
var parent = $(this).parent();
if (!parent.hasClass('active')) {
parent.siblings().removeClass('active');
}
parent.toggleClass('active');
});
// Set active menu
menu.find('#activemenu').parents('.menu-block').addClass('active');
// Check if there is active menu
if (!blocks.filter('.active').length) {
blocks.filter(':first').addClass('active');
}
});
/**
* Responsive tables
*/
container.find('table').not('.not-responsive').each(function() {
var $this = $(this),
th = $this.find('thead > tr > th'),
columns = th.length,
headers = [],
totalHeaders = 0,
i, headersLength;
// Find columns
$this.find('colgroup:first').children().each(function(i) {
var column = $(this);
$this.find('td:nth-child(' + (i + 1) + ')').addClass(column.prop('className'));
});
// Styles table
if ($this.hasClass('styles')) {
$this.find('td:first-child[style]').each(function() {
var style = $(this).attr('style');
if (style.length) {
$(this).parent('tr').attr('style', style.toLowerCase().replace('padding', 'margin')).addClass('responsive-style-row');
}
});
}
// Find each header
if (!$this.data('no-responsive-header'))
{
th.each(function(column) {
var cell = $(this),
colspan = parseInt(cell.attr('colspan')),
dfn = cell.attr('data-dfn'),
text = dfn ? dfn : $.trim(cell.text());
if (text == '&nbsp;') text = '';
colspan = isNaN(colspan) || colspan < 1 ? 1 : colspan;
for (i=0; i<colspan; i++) {
headers.push(text);
}
totalHeaders ++;
if (dfn && !column) {
$this.addClass('show-header');
}
});
}
headersLength = headers.length;
// Add header text to each cell as <dfn>
$this.addClass('responsive');
if (totalHeaders < 2) {
$this.addClass('show-header');
return;
}
$this.find('tbody > tr').each(function() {
var row = $(this),
cells = row.children('td'),
column = 0;
if (cells.length == 1) {
row.addClass('big-column');
return;
}
cells.each(function() {
var cell = $(this),
colspan = parseInt(cell.attr('colspan')),
text = $.trim(cell.text());
if (headersLength <= column) {
return;
}
if ((text.length && text !== '-') || cell.children().length) {
if (headers[column] != '') {
cell.prepend('<dfn style="display: none;">' + headers[column] + '</dfn>');
}
}
else {
cell.addClass('empty');
}
colspan = isNaN(colspan) || colspan < 1 ? 1 : colspan;
column += colspan;
});
});
// Remove <dfn> in disabled extensions list
$this.find('tr.ext_disabled > .empty:nth-child(2) + .empty').siblings(':first-child').children('dfn').remove();
});
/**
* Hide empty responsive tables
*/
container.find('table.responsive > tbody').each(function() {
var items = $(this).children('tr');
if (items.length == 0)
{
$(this).parent('table:first').addClass('responsive-hide');
}
});
/**
* Fieldsets with empty <span>
*/
container.find('fieldset dt > span:last-child').each(function() {
var $this = $(this);
if ($this.html() == '&nbsp;') {
$this.addClass('responsive-hide');
}
});
/**
* Responsive tabs
*/
container.find('#tabs').not('[data-skip-responsive]').each(function() {
var $this = $(this),
$body = $('body'),
ul = $this.children(),
tabs = ul.children().not('[data-skip-responsive]'),
links = tabs.children('a'),
item = ul.append('<li class="tab responsive-tab" style="display:none;"><a href="javascript:void(0);" class="responsive-tab-link">&nbsp;</a><div class="dropdown tab-dropdown" style="display: none;"><div class="pointer"><div class="pointer-inner" /></div><ul class="dropdown-contents" /></div></li>').find('li.responsive-tab'),
menu = item.find('.dropdown-contents'),
maxHeight = 0,
lastWidth = false,
responsive = false;
links.each(function() {
var link = $(this);
maxHeight = Math.max(maxHeight, Math.max(link.outerHeight(true), link.parent().outerHeight(true)));
})
function check() {
var width = $body.width(),
height = $this.height();
if (arguments.length == 0 && (!responsive || width <= lastWidth) && height <= maxHeight) {
return;
}
tabs.show();
item.hide();
lastWidth = width;
height = $this.height();
if (height <= maxHeight) {
responsive = false;
if (item.hasClass('dropdown-visible')) {
phpbb.toggleDropdown.call(item.find('a.responsive-tab-link').get(0));
}
return;
}
responsive = true;
item.show();
menu.html('');
var availableTabs = tabs.filter(':not(.activetab, .responsive-tab)'),
total = availableTabs.length,
i, tab;
for (i = total - 1; i >= 0; i --) {
tab = availableTabs.eq(i);
menu.prepend(tab.clone(true).removeClass('tab'));
tab.hide();
if ($this.height() <= maxHeight) {
menu.find('a').click(function() { check(true); });
return;
}
}
menu.find('a').click(function() { check(true); });
}
phpbb.registerDropdown(item.find('a.responsive-tab-link'), item.find('.dropdown'), {visibleClass: 'activetab', verticalDirection: 'down'});
check(true);
$(window).resize(check);
});
}
/**
* Run onload functions
*/
(function($) {
$(document).ready(function() {
// Swap .nojs and .hasjs
$('body.nojs').toggleClass('nojs hasjs');
// Focus forms
$('form[data-focus]:first').each(function() {
$('#' + this.getAttribute('data-focus')).focus();
});
parse_document($('body'));
// Hide configlist and success message in send statistics page
phpbb.toggleDisplay('configlist', -1);
phpbb.toggleDisplay('questionnaire-thanks', -1);
});
})(jQuery);

View File

@@ -1,13 +1,8 @@
/* global phpbb */
(function($) { // Avoid conflicts with other libraries
"use strict";
var imgTemplates = {
up: $('.template-up-img'),
upDisabled: $('.template-up-img-disabled'),
down: $('.template-down-img'),
downDisabled: $('.template-down-img-disabled')
};
'use strict';
/**
* The following callbacks are for reording items. row_down
@@ -15,92 +10,26 @@ var imgTemplates = {
* an item is moved up. It moves the row up or down, and deactivates /
* activates any up / down icons that require it (the ones at the top or bottom).
*/
phpbb.addAjaxCallback('row_down', function() {
var el = $(this),
tr = el.parents('tr'),
trSwap = tr.next();
/*
* If the element was the first one, we have to:
* - Add the up-link to the row we moved
* - Remove the up-link on the next row
*/
if (tr.is(':first-child')) {
var upImg = imgTemplates.up.clone().attr('href', tr.attr('data-up'));
tr.find('.up').html(upImg);
phpbb.ajaxify({
selector: tr.find('.up').children('a'),
callback: 'row_up',
overlay: false
});
trSwap.find('.up').html(imgTemplates.upDisabled.clone());
phpbb.addAjaxCallback('row_down', function(res) {
if (typeof res.success === 'undefined' || !res.success) {
return;
}
tr.insertAfter(trSwap);
var $firstTr = $(this).parents('tr'),
$secondTr = $firstTr.next();
/*
* As well as:
* - Remove the down-link on the moved row, if it is now the last row
* - Add the down-link to the next row, if it was the last row
*/
if (tr.is(':last-child')) {
tr.find('.down').html(imgTemplates.downDisabled.clone());
var downImg = imgTemplates.down.clone().attr('href', trSwap.attr('data-down'));
trSwap.find('.down').html(downImg);
phpbb.ajaxify({
selector: trSwap.find('.down').children('a'),
callback: 'row_down',
overlay: false
});
}
$firstTr.insertAfter($secondTr);
});
phpbb.addAjaxCallback('row_up', function() {
var el = $(this),
tr = el.parents('tr'),
trSwap = tr.prev();
/*
* If the element was the last one, we have to:
* - Add the down-link to the row we moved
* - Remove the down-link on the next row
*/
if (tr.is(':last-child')) {
var downImg = imgTemplates.down.clone().attr('href', tr.attr('data-down'));
tr.find('.down').html(downImg);
phpbb.ajaxify({
selector: tr.find('.down').children('a'),
callback: 'row_down',
overlay: false
});
trSwap.find('.down').html(imgTemplates.downDisabled.clone());
phpbb.addAjaxCallback('row_up', function(res) {
if (typeof res.success === 'undefined' || !res.success) {
return;
}
tr.insertBefore(trSwap);
var $secondTr = $(this).parents('tr'),
$firstTr = $secondTr.prev();
/*
* As well as:
* - Remove the up-link on the moved row, if it is now the first row
* - Add the up-link to the previous row, if it was the first row
*/
if (tr.is(':first-child')) {
tr.find('.up').html(imgTemplates.upDisabled.clone());
var upImg = imgTemplates.up.clone().attr('href', trSwap.attr('data-up'));
trSwap.find('.up').html(upImg);
phpbb.ajaxify({
selector: trSwap.find('.up').children('a'),
callback: 'row_up',
overlay: false
});
}
$secondTr.insertBefore($firstTr);
});
/**
@@ -109,10 +38,10 @@ phpbb.addAjaxCallback('row_up', function() {
* in the href with "deactivate", and vice versa.
*/
phpbb.addAjaxCallback('activate_deactivate', function(res) {
var el = $(this),
newHref = el.attr('href');
var $this = $(this),
newHref = $this.attr('href');
el.text(res.text);
$this.text(res.text);
if (newHref.indexOf('deactivate') !== -1) {
newHref = newHref.replace('deactivate', 'activate');
@@ -120,7 +49,7 @@ phpbb.addAjaxCallback('activate_deactivate', function(res) {
newHref = newHref.replace('activate', 'deactivate');
}
el.attr('href', newHref);
$this.attr('href', newHref);
});
/**
@@ -137,11 +66,10 @@ phpbb.addAjaxCallback('row_delete', function(res) {
$('[data-ajax]').each(function() {
var $this = $(this),
ajax = $this.attr('data-ajax'),
fn;
ajax = $this.attr('data-ajax');
if (ajax !== 'false') {
fn = (ajax !== 'true') ? ajax : null;
var fn = (ajax !== 'true') ? ajax : null;
phpbb.ajaxify({
selector: this,
refresh: $this.attr('data-refresh') !== undefined,
@@ -153,7 +81,7 @@ $('[data-ajax]').each(function() {
/**
* Automatically resize textarea
*/
$(document).ready(function() {
$(function() {
phpbb.resizeTextArea($('textarea:not(.no-auto-resize)'), {minHeight: 75});
});

View File

@@ -1,32 +1,35 @@
<dl>
<dt><label for="ldap_server">{L_LDAP_SERVER}{L_COLON}</label><br /><span>{L_LDAP_SERVER_EXPLAIN}</span></dt>
<dd><input type="text" id="ldap_server" size="40" name="config[ldap_server]" value="{AUTH_LDAP_SERVER}" /></dd>
</dl>
<dl>
<dt><label for="ldap_port">{L_LDAP_PORT}{L_COLON}</label><br /><span>{L_LDAP_PORT_EXPLAIN}</span></dt>
<dd><input type="text" id="ldap_port" size="40" name="config[ldap_port]" value="{AUTH_LDAP_PORT}" /></dd>
</dl>
<dl>
<dt><label for="ldap_dn">{L_LDAP_DN}{L_COLON}</label><br /><span>{L_LDAP_DN_EXPLAIN}</span></dt>
<dd><input type="text" id="ldap_dn" size="40" name="config[ldap_base_dn]" value="{AUTH_LDAP_BASE_DN}" /></dd>
</dl>
<dl>
<dt><label for="ldap_uid">{L_LDAP_UID}{L_COLON}</label><br /><span>{L_LDAP_UID_EXPLAIN}</span></dt>
<dd><input type="text" id="ldap_uid" size="40" name="config[ldap_uid]" value="{AUTH_LDAP_UID}" /></dd>
</dl>
<dl>
<dt><label for="ldap_user_filter">{L_LDAP_USER_FILTER}{L_COLON}</label><br /><span>{L_LDAP_USER_FILTER_EXPLAIN}</span></dt>
<dd><input type="text" id="ldap_user_filter" size="40" name="config[ldap_user_filter]" value="{AUTH_LDAP_USER_FILTER}" /></dd>
</dl>
<dl>
<dt><label for="ldap_email">{L_LDAP_EMAIL}{L_COLON}</label><br /><span>{L_LDAP_EMAIL_EXPLAIN}</span></dt>
<dd><input type="email" id="ldap_email" size="40" name="config[ldap_email]" value="{AUTH_LDAP_EMAIL}" /></dd>
</dl>
<dl>
<dt><label for="ldap_user">{L_LDAP_USER}{L_COLON}</label><br /><span>{L_LDAP_USER_EXPLAIN}</span></dt>
<dd><input type="text" id="ldap_user" size="40" name="config[ldap_user]" value="{AUTH_LDAP_USER}" /></dd>
</dl>
<dl>
<dt><label for="ldap_password">{L_LDAP_PASSWORD}{L_COLON}</label><br /><span>{L_LDAP_PASSWORD_EXPLAIN}</span></dt>
<dd><input type="password" id="ldap_password" size="40" name="config[ldap_password]" value="{AUTH_LDAP_PASSWORD}" autocomplete="off" /></dd>
</dl>
<fieldset id="auth_ldap_settings">
<legend>{L_LDAP}</legend>
<dl>
<dt><label for="ldap_server">{L_LDAP_SERVER}{L_COLON}</label><br /><span>{L_LDAP_SERVER_EXPLAIN}</span></dt>
<dd><input type="text" id="ldap_server" size="40" name="config[ldap_server]" value="{AUTH_LDAP_SERVER}" /></dd>
</dl>
<dl>
<dt><label for="ldap_port">{L_LDAP_PORT}{L_COLON}</label><br /><span>{L_LDAP_PORT_EXPLAIN}</span></dt>
<dd><input type="text" id="ldap_port" size="40" name="config[ldap_port]" value="{AUTH_LDAP_PORT}" /></dd>
</dl>
<dl>
<dt><label for="ldap_dn">{L_LDAP_DN}{L_COLON}</label><br /><span>{L_LDAP_DN_EXPLAIN}</span></dt>
<dd><input type="text" id="ldap_dn" size="40" name="config[ldap_base_dn]" value="{AUTH_LDAP_BASE_DN}" /></dd>
</dl>
<dl>
<dt><label for="ldap_uid">{L_LDAP_UID}{L_COLON}</label><br /><span>{L_LDAP_UID_EXPLAIN}</span></dt>
<dd><input type="text" id="ldap_uid" size="40" name="config[ldap_uid]" value="{AUTH_LDAP_UID}" /></dd>
</dl>
<dl>
<dt><label for="ldap_user_filter">{L_LDAP_USER_FILTER}{L_COLON}</label><br /><span>{L_LDAP_USER_FILTER_EXPLAIN}</span></dt>
<dd><input type="text" id="ldap_user_filter" size="40" name="config[ldap_user_filter]" value="{AUTH_LDAP_USER_FILTER}" /></dd>
</dl>
<dl>
<dt><label for="ldap_email">{L_LDAP_EMAIL}{L_COLON}</label><br /><span>{L_LDAP_EMAIL_EXPLAIN}</span></dt>
<dd><input type="text" id="ldap_email" size="40" name="config[ldap_email]" value="{AUTH_LDAP_EMAIL}" /></dd>
</dl>
<dl>
<dt><label for="ldap_user">{L_LDAP_USER}{L_COLON}</label><br /><span>{L_LDAP_USER_EXPLAIN}</span></dt>
<dd><input type="text" id="ldap_user" size="40" name="config[ldap_user]" value="{AUTH_LDAP_USER}" /></dd>
</dl>
<dl>
<dt><label for="ldap_password">{L_LDAP_PASSWORD}{L_COLON}</label><br /><span>{L_LDAP_PASSWORD_EXPLAIN}</span></dt>
<dd><input type="password" id="ldap_password" size="40" name="config[ldap_password]" value="{AUTH_LDAP_PASSWORD}" autocomplete="off" /></dd>
</dl>
</fieldset>

Some files were not shown because too many files have changed in this diff Show More